1. 11 Sep, 2012 40 commits
    • fpizlo@apple.com's avatar
      LLInt should optimize and profile array length accesses · 4cafdbd1
      fpizlo@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=96417
      
      Reviewed by Oliver Hunt.
      
      This fixes the following hole in our array profiling strategy, where the array
      is large (more than 1000 elements):
              
      for (var i = 0; i < array.length; ++i) ...
              
      The peeled use of array.length (in the array prologue) will execute only once
      before DFG optimization kicks in from the loop's OSR point. Since it executed
      only once, it executed in the LLInt. And prior to this patch, the LLInt did
      not profile array.length accesses - so the DFG will assume, based on the lack
      of profiling, that the access is in fact not an access to the JSArray length
      property. That could then impede our ability to hoist the array structure
      check, and may make us pessimistic in other ways as well, since the generic
      GetById used for the array length access will be viewed as a side-effecting
      operation.
      
      * bytecode/CodeBlock.cpp:
      (JSC::CodeBlock::printGetByIdCacheStatus):
      (JSC::CodeBlock::finalizeUnconditionally):
      * bytecode/GetByIdStatus.cpp:
      (JSC::GetByIdStatus::computeFromLLInt):
      * dfg/DFGByteCodeParser.cpp:
      (JSC::DFG::ByteCodeParser::parseBlock):
      * dfg/DFGCapabilities.h:
      (JSC::DFG::canCompileOpcode):
      * dfg/DFGFixupPhase.cpp:
      (JSC::DFG::FixupPhase::fixupNode):
      * jit/JIT.cpp:
      (JSC::JIT::privateCompileMainPass):
      (JSC::JIT::privateCompileSlowCases):
      * llint/LLIntSlowPaths.cpp:
      (JSC::LLInt::LLINT_SLOW_PATH_DECL):
      * llint/LowLevelInterpreter.asm:
      * llint/LowLevelInterpreter32_64.asm:
      * llint/LowLevelInterpreter64.asm:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@128219 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      4cafdbd1
    • commit-queue@webkit.org's avatar
      Unreviewed. Rolled DEPS. · 72f7f916
      commit-queue@webkit.org authored
      Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-09-11
      
      * DEPS:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@128218 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      72f7f916
    • jsbell@chromium.org's avatar
      IndexedDB: IDBObjectStore.count() is slow · b24a9aec
      jsbell@chromium.org authored
      https://bugs.webkit.org/show_bug.cgi?id=96033
      
      Reviewed by Tony Chang.
      
      Avoid decoding record values when performing count() iteration, and factor out common code
      used for initializing object store and index cursors. Also, remove unused indexDataId()
      methods (which date back to the SQLite backing store), and rename some p's and q's.
      
      No new tests - no functional changes. Covered by existing test:
          LayoutTests/storage/indexeddb/objectstore-count.html
      
      * Modules/indexeddb/IDBBackingStore.h: Expose new (internal) ObjectStoreKeyCursor
      (IDBBackingStore):
      * Modules/indexeddb/IDBLevelDBBackingStore.cpp:
      (WebCore): Factor out common CursorOptions initialization code. The objectStoreCursorOptions()
      function is needed for this patch. The indexCursorOptions() function is not, but eliminates
      duplicated code and is a nearly identical refactor.
      (WebCore::IDBLevelDBBackingStore::openObjectStoreCursor): Refactor.
      (WebCore::IDBLevelDBBackingStore::openObjectStoreKeyCursor): Implement.
      (WebCore::IDBLevelDBBackingStore::openIndexKeyCursor): Refactor.
      (WebCore::IDBLevelDBBackingStore::openIndexCursor): Ditto.
      * Modules/indexeddb/IDBLevelDBBackingStore.h:
      (IDBLevelDBBackingStore):
      * Modules/indexeddb/IDBObjectStoreBackendImpl.cpp:
      (WebCore::IDBObjectStoreBackendImpl::countInternal): Use ObjectStoreKeyCursor for iteration.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@128217 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      b24a9aec
    • adamk@chromium.org's avatar
      Unreviewed chromium gardening. · 5c330e05
      adamk@chromium.org authored
      Remove bogus rebaseline added in r128105, and remove "flaky"
      expectation (since tests seems non-flaky).
      
      * platform/chromium-win-xp/fast/hidpi/gradient-with-scaled-ancestor-expected.png: Removed.
      * platform/chromium/TestExpectations:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@128216 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      5c330e05
    • ojan@chromium.org's avatar
      Refactor computePercentageLogicalHeight to simplify the logic a bit · 2b040697
      ojan@chromium.org authored
      https://bugs.webkit.org/show_bug.cgi?id=96329
      
      Reviewed by Tony Chang.
      
      This makes it clear that the value we're computing as we go is the availableHeight.
      
      * rendering/RenderBox.cpp:
      (WebCore::RenderBox::computePercentageLogicalHeight):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@128215 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      2b040697
    • adamk@chromium.org's avatar
      Unreviewed chromium gardening. · 48aa4c06
      adamk@chromium.org authored
      Mark compositing/overflow/overflow-scaled-descendant-overflapping as
      failing on cr-mac after r127789 and remove bad rebaselines.
      
      * platform/chromium-mac-snowleopard/compositing/overflow/overflow-scaled-descendant-overlapping-expected.png: Removed.
      * platform/chromium-mac/compositing/overflow/overflow-scaled-descendant-overlapping-expected.png: Removed.
      * platform/chromium/TestExpectations:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@128214 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      48aa4c06
    • adamk@chromium.org's avatar
      Garden-o-matic should ignore a wider variety of warnings in buildbot json · 4aef4dbe
      adamk@chromium.org authored
      https://bugs.webkit.org/show_bug.cgi?id=96411
      
      Reviewed by Adam Barth.
      
      Previously only the exact string "warning" was treated as a warning
      result. This patch treats any string with "warning" as a substring
      as a warning (e.g., "warnings", as seen on the cr-win buildbots).
      
      * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/builders.js:
      (.):
      * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/builders_unittests.js:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@128213 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      4aef4dbe
    • jsbell@chromium.org's avatar
      IndexedDB: Optimize key decode and comparison operations · 1c250a36
      jsbell@chromium.org authored
      https://bugs.webkit.org/show_bug.cgi?id=96037
      
      Reviewed by Tony Chang.
      
      Eliminate memory allocations in code identified as CPU bottlenecks in IDB profiling.
      
      No new tests - just performance work.
      
      * Modules/indexeddb/IDBLevelDBCoding.cpp:
      (WebCore::IDBLevelDBCoding::extractEncodedIDBKey): Avoid incremental allocations.
      (WebCore::IDBLevelDBCoding::compareEncodedIDBKeys): Rename confusing variables p and q.
      (IDBLevelDBCoding):
      (WebCore::IDBLevelDBCoding::compare): Rename from decodeAndCompare, and add specializations
      for frequently encountered types (e.g. object/index data) that can be compared without a
      full decode.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@128212 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      1c250a36
    • kpiascik@rim.com's avatar
      [BlackBerry] Fix history navigation for error pages. · da9dfd52
      kpiascik@rim.com authored
      https://bugs.webkit.org/show_bug.cgi?id=96410
      
      Reviewed by Rob Buis.
      
      Fix how history navigation handles restoring view state when navigating between error pages.
      
      * WebCoreSupport/FrameLoaderClientBlackBerry.cpp:
      (WebCore::FrameLoaderClientBlackBerry::FrameLoaderClientBlackBerry):
      (WebCore::FrameLoaderClientBlackBerry::saveViewStateToItem):
      (WebCore::FrameLoaderClientBlackBerry::restoreViewState):
      * WebCoreSupport/FrameLoaderClientBlackBerry.h:
      (FrameLoaderClientBlackBerry):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@128211 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      da9dfd52
    • commit-queue@webkit.org's avatar
      Restore original value of mock scrollbars enabled in InternalSettings · 2f7ffcec
      commit-queue@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=87680
      
      Patch by Marcelo Lira <marcelo.lira@openbossa.org> on 2012-09-11
      Reviewed by Adam Barth.
      
      Added backup support for mock scrollbars state in
      InternalSettings::Backup, and removed support for these
      from Qt's DumpRenderTree.
      
      .:
      
      * Source/autotools/symbols.filter:
      
      Source/WebCore:
      
      * testing/InternalSettings.cpp:
      (WebCore::InternalSettings::Backup::Backup):
      (WebCore::InternalSettings::Backup::restoreTo):
      * testing/InternalSettings.h:
      (Backup):
      
      Source/WebKit/qt:
      
      * WebCoreSupport/DumpRenderTreeSupportQt.cpp:
      * WebCoreSupport/DumpRenderTreeSupportQt.h:
      
      Source/WebKit2:
      
      * win/WebKit2.def:
      
      Tools:
      
      * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
      (WebCore::WebPage::resetSettings):
      * DumpRenderTree/qt/TestRunnerQt.cpp:
      (TestRunner::setFrameFlatteningEnabled):
      * DumpRenderTree/qt/TestRunnerQt.h:
      (TestRunner):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@128210 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      2f7ffcec
    • dino@apple.com's avatar
      [Apple] Install plist for Apple Open Source build system · a6d60ebd
      dino@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=96345
      
      Reviewed by Mark Rowe.
      
      Apple's build system requires a couple of files that describe where
      the 3rd party Open Source library came from, and what license it
      uses. These files are copied into /usr/local when the project is
      being installed.
      
      * ANGLE.plist: Added.
      * ANGLE.txt: Added.
      * ANGLE.xcodeproj/project.pbxproj:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@128209 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      a6d60ebd
    • commit-queue@webkit.org's avatar
      Improve console error messages when 'document.domain' blocks cross-origin script access. · 64e672d3
      commit-queue@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=96247
      
      Patch by Mike West <mkwst@chromium.org> on 2012-09-11
      Reviewed by Adam Barth.
      
      Source/WebCore:
      
      Setting 'document.domain' can produce counterintuitive "cross-origin"
      error messages for script access in cases where the property isn't set
      to the same value in both the accessor and accessee. This patch adds a
      bit more context to the error message to make it clear that both sides
      must set the property, and that the values must match.
      
      This shouldn't change any externally visible behavior other than the
      error warnings. It's covered by changes to existing tests.
      
      * page/DOMWindow.cpp:
      (WebCore::DOMWindow::crossDomainAccessErrorMessage):
          Adding checks for 'document.domain'-related errors, and adding an
          ASSERT that crossDomainAccessErrorMessage is called in cases where
          the accessing frame is actually denied access to the frame being
          accessed.
      
      LayoutTests:
      
      * http/tests/security/cross-frame-access-callback-explicit-domain-DENY-expected.txt:
      * http/tests/security/cross-frame-access-child-explicit-domain-expected.txt:
      * http/tests/security/cross-frame-access-parent-explicit-domain-expected.txt:
      * http/tests/security/cross-frame-access-protocol-expected.txt:
      * http/tests/security/cross-frame-access-protocol-explicit-domain-expected.txt:
      * http/tests/security/dataURL/xss-DENIED-from-data-url-in-foreign-domain-subframe-expected.txt:
      * http/tests/security/dataURL/xss-DENIED-from-data-url-in-foreign-domain-window-open-expected.txt:
      * http/tests/security/dataURL/xss-DENIED-from-data-url-sub-frame-2-level-expected.txt:
      * http/tests/security/dataURL/xss-DENIED-from-data-url-sub-frame-expected.txt:
      * http/tests/security/dataURL/xss-DENIED-from-javascript-url-window-open-expected.txt:
      * http/tests/security/dataURL/xss-DENIED-to-data-url-in-foreign-domain-subframe-expected.txt:
      * http/tests/security/dataURL/xss-DENIED-to-data-url-in-foreign-domain-subframe-location-change-expected.txt:
      * http/tests/security/dataURL/xss-DENIED-to-data-url-in-foreign-domain-window-open-expected.txt:
      * http/tests/security/dataURL/xss-DENIED-to-data-url-sub-frame-2-level-expected.txt:
      * http/tests/security/dataURL/xss-DENIED-to-data-url-sub-frame-expected.txt:
      * http/tests/security/dataURL/xss-DENIED-to-data-url-sub-frame-uppercase-expected.txt:
      * http/tests/security/dataURL/xss-DENIED-to-data-url-window-open-expected.txt:
      * http/tests/security/view-source-no-javascript-url-expected.txt:
      * platform/chromium/http/tests/security/dataURL/xss-DENIED-from-data-url-in-foreign-domain-subframe-expected.txt:
      * platform/chromium/http/tests/security/dataURL/xss-DENIED-from-data-url-in-foreign-domain-window-open-expected.txt:
      * platform/chromium/http/tests/security/dataURL/xss-DENIED-from-data-url-sub-frame-2-level-expected.txt:
      * platform/chromium/http/tests/security/dataURL/xss-DENIED-from-data-url-sub-frame-expected.txt:
      * platform/chromium/http/tests/security/dataURL/xss-DENIED-from-javascript-url-window-open-expected.txt:
      * platform/chromium/http/tests/security/dataURL/xss-DENIED-to-data-url-in-foreign-domain-subframe-expected.txt:
      * platform/chromium/http/tests/security/dataURL/xss-DENIED-to-data-url-in-foreign-domain-subframe-location-change-expected.txt:
      * platform/chromium/http/tests/security/dataURL/xss-DENIED-to-data-url-in-foreign-domain-window-open-expected.txt:
      * platform/chromium/http/tests/security/dataURL/xss-DENIED-to-data-url-sub-frame-2-level-expected.txt:
      * platform/chromium/http/tests/security/dataURL/xss-DENIED-to-data-url-sub-frame-expected.txt:
      * platform/chromium/http/tests/security/dataURL/xss-DENIED-to-data-url-sub-frame-uppercase-expected.txt:
      * platform/chromium/http/tests/security/dataURL/xss-DENIED-to-data-url-window-open-expected.txt:
      * platform/chromium/http/tests/security/inactive-document-with-empty-security-origin-expected.txt:
      * platform/chromium/http/tests/security/window-named-proto-expected.txt:
          Updating error message.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@128208 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      64e672d3
    • mitz@apple.com's avatar
      Fixed a bug where kill-old-processes failed to kill clang++. · 6b45433a
      mitz@apple.com authored
      Rubber-stamped by Alexey Proskuryakov.
      
      * BuildSlaveSupport/kill-old-processes: Escape the + signs in "clang++"
      where it is passed as a regular expression to killall.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@128206 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      6b45433a
    • beidson@apple.com's avatar
      We should wait longer before killing the PluginProcess. · 86cb94fc
      beidson@apple.com authored
      <rdar://problem/12067728> and https://bugs.webkit.org/show_bug.cgi?id=96407
      
      Reviewed by Anders Carlsson.
      
      Currently we kill the PluginProcess 15 seconds after the last plug-in is destroyed.
      This is short enough that most users will have the process killed many times during browsing sessions,
      which is painful because relaunching the process is I/O and kernel intensive.
      
      In an ideal world we could keep it around forever until the system tells us resources are running low.
      
      In reality we do want to kill it occasionally to get a clean slate from any plug-in leaks.
      
      A reasonable balance for now is to set a minimum lifetime of 30 minutes on the plug-in process and to
      extend the termination timer from 15 seconds to 10 minutes.
      
      * PluginProcess/PluginProcess.cpp:
      (WebKit::PluginProcess::PluginProcess):
      (WebKit::PluginProcess::initializePluginProcess):
      (WebKit::PluginProcess::setMinimumLifetime):
      (WebKit):
      (WebKit::PluginProcess::minimumLifetimeTimerFired):
      * PluginProcess/PluginProcess.h:
      (PluginProcess):
      
      * Shared/Plugins/PluginProcessCreationParameters.cpp:
      (WebKit::PluginProcessCreationParameters::encode):
      (WebKit::PluginProcessCreationParameters::decode):
      * Shared/Plugins/PluginProcessCreationParameters.h:
      (PluginProcessCreationParameters):
      
      * UIProcess/Plugins/PluginProcessProxy.cpp:
      (WebKit):
      (WebKit::PluginProcessProxy::didFinishLaunching):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@128205 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      86cb94fc
    • commit-queue@webkit.org's avatar
      Deploy StringBuilder::appendNumber() and StringBuilder::appendLiteral() in more places · 2e53009b
      commit-queue@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=96344
      
      Patch by Jinwoo Song <jinwoo7.song@samsung.com> on 2012-09-11
      Reviewed by Benjamin Poulain.
      
      Use StringBuilder::appendNumber() instead of String::number(). Also deploy
      StringBuilder::appendLiteral() instead of String::append() in the surrounding code.
      
      Source/WebCore:
      
      * css/CSSAspectRatioValue.cpp:
      (WebCore::CSSAspectRatioValue::customCssText):
      * platform/graphics/gpu/LoopBlinnPathProcessor.cpp:
      (WebCore):
      * svg/SVGPointList.cpp:
      (WebCore::SVGPointList::valueAsString):
      
      Source/WebKit/blackberry:
      
      * WebCoreSupport/DatePickerClient.cpp:
      (WebCore::DatePickerClient::generateHTML):
      * WebCoreSupport/SelectPopupClient.cpp:
      (WebCore::SelectPopupClient::generateHTML):
      
      Source/WebKit2:
      
      * Shared/WebMemorySampler.cpp:
      (WebKit::WebMemorySampler::appendCurrentMemoryUsageToFile):
      * UIProcess/InspectorServer/WebSocketServerConnection.cpp:
      (WebKit::WebSocketServerConnection::sendHTTPResponseHeader):
      * UIProcess/InspectorServer/qt/WebInspectorServerQt.cpp:
      (WebKit::WebInspectorServer::inspectorUrlForPageID):
      (WebKit::WebInspectorServer::buildPageList):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@128204 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      2e53009b
    • enne@google.com's avatar
      Clang doesn't optimize away undefined OwnPtr copy constructor · 65ce68c7
      enne@google.com authored
      https://bugs.webkit.org/show_bug.cgi?id=74625
      
      Reviewed by Anders Carlsson.
      
      Original patch by Anders Carlsson, with a minor edit.
      
      The publicly declared-but-not-defined copy constructor is a compiler
      optimization-dependent landmine. Clang often fails to optimize the use
      of this function out, leading to internal linkage errors for the missing
      definition. gcc doesn't have this problem and optimizes that function
      out, leading to code that inconsistently fails to link across platforms.
      
      As a partial fix for this problem, on any compiler that supports C++11
      move semantics, replace the bogus copy constructor with the move
      constructors.  In the future, if all compilers support this, then the
      copy constructor can be removed.
      
      This still leaves other compilers that don't support move semantics
      like Visual Studio vulnerable to linking inconsistencies.
      
      * wtf/OwnPtr.h:
      (OwnPtr):
      (WTF):
      (WTF::::OwnPtr):
      (WTF::=):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@128203 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      65ce68c7
    • andersca@apple.com's avatar
      Fix speling error in comment. · cd0fbcbd
      andersca@apple.com authored
      * WebProcess/Plugins/Netscape/NetscapePlugin.cpp:
      (WebKit::isTransparentSilverlightBackgroundValue):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@128202 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      cd0fbcbd
    • tony@chromium.org's avatar
      Rename computeLogicalHeight to updateLogicalHeight · b7ebe386
      tony@chromium.org authored
      https://bugs.webkit.org/show_bug.cgi?id=96305
      
      Reviewed by Ojan Vafai.
      
      computeLogicalHeight changes the value of 4 member variables of the
      render box, so give it a name that makes it more clear that it is
      updating member variables.
      
      No new tests, this is just a refactor.
      
      * rendering/RenderBlock.cpp:
      (WebCore::RenderBlock::computeInitialRegionRangeForBlock):
      (WebCore::RenderBlock::checkForPaginationLogicalHeightChange):
      (WebCore::RenderBlock::layoutBlock):
      (WebCore::RenderBlock::layoutPositionedObjects):
      (WebCore::RenderBlock::computeBlockPreferredLogicalWidths):
      * rendering/RenderBox.cpp:
      (WebCore::RenderBox::updateLogicalHeight):
      (WebCore::RenderBox::computePercentageLogicalHeight):
      (WebCore::RenderBox::computeReplacedLogicalHeightUsing):
      (WebCore::RenderBox::availableLogicalHeightUsing):
      * rendering/RenderBox.h:
      (RenderBox):
      (WebCore::RenderBox::tryLayoutDoingPositionedMovementOnly):
      * rendering/RenderDeprecatedFlexibleBox.cpp:
      (WebCore::RenderDeprecatedFlexibleBox::layoutBlock):
      (WebCore::RenderDeprecatedFlexibleBox::layoutHorizontalBox):
      (WebCore::RenderDeprecatedFlexibleBox::layoutVerticalBox):
      * rendering/RenderEmbeddedObject.cpp:
      (WebCore::RenderEmbeddedObject::layout):
      * rendering/RenderFlexibleBox.cpp:
      (WebCore::RenderFlexibleBox::layoutBlock):
      (WebCore::RenderFlexibleBox::layoutAndPlaceChildren):
      * rendering/RenderFlowThread.cpp:
      (WebCore::RenderFlowThread::updateLogicalHeight):
      * rendering/RenderFlowThread.h:
      * rendering/RenderGrid.cpp:
      (WebCore::RenderGrid::layoutBlock):
      * rendering/RenderHTMLCanvas.cpp:
      (WebCore::RenderHTMLCanvas::canvasSizeChanged):
      * rendering/RenderIFrame.cpp:
      (WebCore::RenderIFrame::updateLogicalHeight):
      (WebCore::RenderIFrame::layoutSeamlessly):
      (WebCore::RenderIFrame::layout):
      * rendering/RenderIFrame.h:
      (RenderIFrame):
      * rendering/RenderImage.cpp:
      (WebCore::RenderImage::imageDimensionsChanged):
      * rendering/RenderListBox.cpp:
      (WebCore::RenderListBox::updateLogicalHeight):
      * rendering/RenderListBox.h:
      (RenderListBox):
      * rendering/RenderMeter.cpp:
      (WebCore::RenderMeter::updateLogicalHeight):
      * rendering/RenderMeter.h:
      (RenderMeter):
      * rendering/RenderMultiColumnBlock.cpp:
      (WebCore::RenderMultiColumnBlock::checkForPaginationLogicalHeightChange):
      * rendering/RenderMultiColumnFlowThread.h:
      * rendering/RenderMultiColumnSet.cpp:
      (WebCore::RenderMultiColumnSet::updateLogicalHeight):
      * rendering/RenderMultiColumnSet.h:
      (RenderMultiColumnSet):
      * rendering/RenderReplaced.cpp:
      (WebCore::RenderReplaced::layout):
      * rendering/RenderSearchField.cpp:
      (WebCore::RenderSearchField::computeControlHeight):
      * rendering/RenderTable.cpp:
      (WebCore::RenderTable::layout):
      * rendering/RenderTextControl.cpp:
      (WebCore::RenderTextControl::updateLogicalHeight):
      * rendering/RenderTextControl.h:
      (RenderTextControl):
      * rendering/RenderView.cpp:
      (WebCore::RenderView::updateLogicalHeight):
      * rendering/RenderView.h:
      * rendering/svg/RenderSVGForeignObject.cpp:
      (WebCore::RenderSVGForeignObject::updateLogicalHeight):
      * rendering/svg/RenderSVGForeignObject.h:
      (RenderSVGForeignObject):
      * rendering/svg/RenderSVGRoot.cpp:
      (WebCore::RenderSVGRoot::layout):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@128201 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      b7ebe386
    • zhajiang@rim.com's avatar
      [BlackBerry] InRegion scrollable area dangling pointers were accessed in UI thread · 94b13f5b
      zhajiang@rim.com authored
      https://bugs.webkit.org/show_bug.cgi?id=96318
      
      Reviewed by Antonio Gomes.
      Patch by Jacky Jiang <zhajiang@rim.com>
      
      PR: 204066
      Dangling pointers were accessed in UI thread, as the actual InRegion
      scrollable areas of WebKit side had been destroyed before that in
      WebKit thread after UI thread set scrolling to false.
      Notify the client side to clear InRegion scrollable areas before we
      destroy them in WebKit side.
      
      Internally reviewed by Gen Mak and George Staikos.
      
      * Api/WebPage.cpp:
      (BlackBerry::WebKit::WebPagePrivate::notifyInRegionScrollStopped):
      (BlackBerry::WebKit::WebPagePrivate::setScrollOriginPoint):
      * Api/WebPageClient.h:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@128200 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      94b13f5b
    • commit-queue@webkit.org's avatar
      [chromium] Fix double call to scrollBegin() when handling scroll gesture · 95a529ba
      commit-queue@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=95322
      
      Patch by Iain Merrick <husky@chromium.org> on 2012-09-11
      Reviewed by James Robinson.
      
      WebCompositorInputHandlerImpl::handleGestureFling() calls scrollBegin() on its
      client, then if the result is ScrollStarted, it creates a PlatformGestureCurve
      object to handle the fling animation. This patch adds a matching scrollEnd()
      before the animation starts.
      
      Now using strict mocks in WebCompositorInputHandlerImplTest, which turns all
      unexpected calls into test failures. This ensures that scrollBegin / scrollEnd
      happen exactly when we want and at no other times.
      
      * src/WebCompositorInputHandlerImpl.cpp:
      (WebKit::WebCompositorInputHandlerImpl::handleGestureFling):
      * tests/WebCompositorInputHandlerImplTest.cpp:
      (WebCompositorInputHandlerImplTest):
      (WebKit::TEST_F):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@128199 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      95a529ba
    • mifenton@rim.com's avatar
      [BlackBerry] Suppress keyboard requests while processing spell checking suggestions. · e4ecccb2
      mifenton@rim.com authored
      https://bugs.webkit.org/show_bug.cgi?id=96394
      
      Reviewed by Rob Buis.
      
      Suppress the VKB notification when the touch event
      is a spell checking request.
      
      PR 192925.
      
      Reviewed Internally by Gen Mak.
      
      * WebKitSupport/TouchEventHandler.cpp:
      (BlackBerry::WebKit::TouchEventHandler::handleTouchPoint):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@128198 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      e4ecccb2
    • mifenton@rim.com's avatar
      [BlackBerry] Colour Dialog popup request should return proper state. · 4f4aabfb
      mifenton@rim.com authored
      https://bugs.webkit.org/show_bug.cgi?id=96392
      
      Reviewed by Rob Buis.
      
      Return proper state from openColorPopup dependent on
      whether the popup actually opened.
      
      Reviewed Internally by Chris Hutten-Czapski
      
      * WebKitSupport/InputHandler.cpp:
      (BlackBerry::WebKit::InputHandler::openColorPopup):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@128197 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      4f4aabfb
    • commit-queue@webkit.org's avatar
      Fix FilterTypeZoom to properly call canvas->restore() · 13e24b33
      commit-queue@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=96082
      
      Patch by Zach Kuznia <zork@chromium.org> on 2012-09-11
      Reviewed by Adrienne Walker.
      
      Source/Platform:
      
      Fix zoom filter to properly indicate that it affects pixels.
      
      * chromium/src/WebFilterOperations.cpp:
      (WebKit::WebFilterOperations::hasFilterThatMovesPixels):
      (WebKit::WebFilterOperations::hasFilterThatAffectsOpacity):
      
      Source/WebCore:
      
      Fix zoom filter to properly call canvas->restore()
      
      * platform/graphics/chromium/cc/CCRenderSurfaceFilters.cpp:
      (WebCore::CCRenderSurfaceFilters::apply):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@128196 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      13e24b33
    • sergio@webkit.org's avatar
      [GTK] WebKitGtk+ crashes with non-UTF8 HTTP header names · c85d02f6
      sergio@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=96284
      
      Reviewed by Gustavo Noronha Silva.
      
      Source/WebCore:
      
      Non UTF-8 characters sent as part of a HTTP header name were
      causing crashes as String::fromUTF8() was returning NULL for
      them. Use String::fromUTF8WithLatin1Fallback() instead.
      
      Test: http/tests/misc/non-utf8-header-name.php
      
      * platform/network/soup/ResourceResponseSoup.cpp:
      (WebCore::ResourceResponse::updateFromSoupMessage):
      
      LayoutTests:
      
      Added a new test to make sure that WebKitGtk+ does not crash when
      a non-UTF8 character is sent as part of a HTTP header name.
      
      * http/tests/misc/non-utf8-header-name-expected.txt: Added.
      * http/tests/misc/non-utf8-header-name.php: Added.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@128195 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      c85d02f6
    • peter@chromium.org's avatar
      Make sure that md5sum is not setup on non-Chromium Android platforms. · 5cc8deb9
      peter@chromium.org authored
      https://bugs.webkit.org/show_bug.cgi?id=96393
      
      Patch by Philippe Liard <pliard@google.com> on 2012-09-11
      Reviewed by Adam Barth.
      
      Previously md5sum was setup in ChromiumAndroidDriver's constructor
      which is also invoked on non-Chromium Android platforms. The following patch
      moves this logic to _startup_test() which is guaranteed to be invoked
      only on Android.
      
      This also updates the prompt unit test in chromium_android_unittest.py.
      
      * Scripts/webkitpy/layout_tests/port/chromium_android.py:
      (ChromiumAndroidDriver.__init__):
      (ChromiumAndroidDriver._setup_md5sum_and_push_data_if_needed):
      (ChromiumAndroidDriver._setup_test):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@128194 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      5cc8deb9
    • ossy@webkit.org's avatar
      [Qt][WK2] Unreviewed gardening, skip new failing tests to paint the bot green. · e9b1fee0
      ossy@webkit.org authored
      * platform/qt-5.0-wk2/Skipped:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@128193 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      e9b1fee0
    • commit-queue@webkit.org's avatar
      Unreviewed, rolling out r128175. · 14d20b21
      commit-queue@webkit.org authored
      http://trac.webkit.org/changeset/128175
      https://bugs.webkit.org/show_bug.cgi?id=96395
      
      broke hunders of tests for EFL and GTK (Requested by rakuco on
      #webkit).
      
      Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-09-11
      
      Source/WebCore:
      
      * platform/network/soup/ResourceResponseSoup.cpp:
      (WebCore::ResourceResponse::updateFromSoupMessage):
      
      LayoutTests:
      
      * http/tests/misc/non-utf8-header-name-expected.txt: Removed.
      * http/tests/misc/non-utf8-header-name.php: Removed.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@128192 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      14d20b21
    • rakuco@webkit.org's avatar
      [EFL] Rewrite the EFL-related Find modules · 72080605
      rakuco@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=95237
      
      Reviewed by Kenneth Rohde Christiansen.
      
      .:
      
      FindEFL.cmake had several problems which caused unnecessary trouble
      when building the EFL port under some setups:
      
      o It looked for some modules (such as ecore) more than once for no
      reason, which led to people adding libraries and include paths in
      different ways across the build system.
      
      o It depended on pkg-config being present for the searches to
      succeed.
      
      o It obtained the library definitions from pkg-config, so
      ${FOO_LIBRARIES} would be set to something like "foo;bar" which
      expanded to "-lfoo -lbar" to the linker. If a wrong -L<path> was
      passed before that, the wrong library installation would end up
      being picked up.
      
      o Due to the problem above, we also needed to set the LINK_FLAGS
      property for each target with the value of ${FOO_LDFLAGS}, which was
      also obtained from pkg-config and sort of compensated the fact that
      the libraries did not use absolute paths and added the required -L
      paths. This also included dependencies for these libraries, so we
      ended up including libraries indirectly, which is bad.
      
      We have now replaced that file with a set of Find-modules which are
      much more granular, each of them responsible for looking for a
      single library and its components and setting library and include
      locations the right way (with FIND_PATH() and FIND_LIBRARY()), so
      that all the problems above are fixed.
      
      * Source/cmake/EFLHelpers.cmake: Added.
      * Source/cmake/FindEDBus.cmake: Added.
      * Source/cmake/FindEFL.cmake: Removed.
      * Source/cmake/FindEcore.cmake: Added.
      * Source/cmake/FindEdje.cmake: Added.
      * Source/cmake/FindEeze.cmake: Added.
      * Source/cmake/FindEfreet.cmake: Added.
      * Source/cmake/FindEina.cmake: Added.
      * Source/cmake/FindEvas.cmake: Added.
      * Source/cmake/OptionsEfl.cmake:
      
      Source/JavaScriptCore:
      
      * CMakeLists.txt: Stop setting the LINK_FLAGS property.
      * PlatformEfl.cmake: Ditto.
      * shell/PlatformEfl.cmake: Ditto.
      
      Source/WebCore:
      
      * CMakeLists.txt: Stop setting the LINK_FLAGS property now that no
      port sets WebCore_LINK_FLAGS.
      * PlatformEfl.cmake: Add libraries and include directories for
      each Enlightenment Foundation Library used by the port.
      
      Source/WebKit:
      
      * PlatformEfl.cmake: Stop setting the LINK_FLAGS property and add
      libraries and include directories for each Enlightenment
      Foundation Library used by the port.
      
      Source/WebKit2:
      
      * CMakeLists.txt: Stop setting the LINK_FLAGS property.
      * PlatformEfl.cmake: Add libraries and include directories for
      each Enlightenment Foundation Library used by the port.
      
      Source/WTF:
      
      * CMakeLists.txt: Stop setting the LINK_FLAGS property.
      * PlatformEfl.cmake: Add libraries and include directories for
      each Enlightenment Foundation Library used by the port.
      
      Tools:
      
      * DumpRenderTree/efl/CMakeLists.txt: Stop setting the LINK_FLAGS
      property and include all the Enlightenment Foundation Libraries
      required by the target.
      * EWebLauncher/CMakeLists.txt: Ditto.
      * MiniBrowser/efl/CMakeLists.txt: Ditto.
      * TestWebKitAPI/PlatformEfl.cmake: Add missing include directories
      now that they are not added implicitly.
      * WebKitTestRunner/CMakeLists.txt: Stop setting the LINK_FLAGS
      property.
      * WebKitTestRunner/PlatformEfl.cmake: Stop setting the LINK_FLAGS
      property and include all the Enlightenment Foundation Libraries
      required by the target.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@128191 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      72080605
    • commit-queue@webkit.org's avatar
      [WK2][WKTR] TestRunner needs to implement setApplicationCacheOriginQuota · d66427ec
      commit-queue@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=96379
      
      Patch by Christophe Dumez <christophe.dumez@intel.com> on 2012-09-11
      Reviewed by Kenneth Rohde Christiansen.
      
      Source/WebKit2:
      
      Add Bundle C API to set the application cache quota for a
      given security origin. This is needed by WebKitTestRunner
      to implement setApplicationCacheOriginQuota().
      
      * WebProcess/InjectedBundle/API/c/WKBundle.cpp:
      (WKBundleSetApplicationCacheOriginQuota):
      * WebProcess/InjectedBundle/API/c/WKBundlePrivate.h:
      * WebProcess/InjectedBundle/InjectedBundle.cpp:
      (WebKit::InjectedBundle::setApplicationCacheOriginQuota):
      (WebKit):
      * WebProcess/InjectedBundle/InjectedBundle.h:
      (InjectedBundle):
      
      Tools:
      
      Add implementation for setApplicationCacheOriginQuota
      to WebKitTestRunner.
      
      * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
      * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
      (WTR::TestRunner::setApplicationCacheOriginQuota):
      (WTR):
      * WebKitTestRunner/InjectedBundle/TestRunner.h:
      (TestRunner):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@128190 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      d66427ec
    • commit-queue@webkit.org's avatar
      [Qt] [WK2] editing/inserting/typing-tab-designmode tests are failing · 4f100cfc
      commit-queue@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=91988
      
      Patch by Luciano Wolf <luciano.wolf@openbossa.org> on 2012-09-11
      Reviewed by Kenneth Rohde Christiansen.
      
      Tools:
      
      Regular key events generated by Qt for the tab key fill both
      keyCode and keyText, so we should do the same for our fake events.
      
      * WebKitTestRunner/qt/EventSenderProxyQt.cpp:
      (WTR::EventSenderProxy::keyDown):
      
      LayoutTests:
      
      Unskip related tests.
      
      * platform/qt-5.0-wk2/Skipped:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@128189 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      4f100cfc
    • commit-queue@webkit.org's avatar
      [BlackBerry] Take account for single words that exceed our client character limit · be4cf7b4
      commit-queue@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=96389
      
      Fix to the processing of long single-line text using getRangeForSpellCheckWithFineGranularity.
      This was failing if a single word was longer than our maximum allowed limit.
      
      Internally reviewed by Mike Fenton.
      
      Patch by Nima Ghanavatian <nghanavatian@rim.com> on 2012-09-11
      Reviewed by Rob Buis.
      
      * WebKitSupport/InputHandler.cpp:
      (WebKit):
      (BlackBerry::WebKit::InputHandler::getRangeForSpellCheckWithFineGranularity):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@128188 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      be4cf7b4
    • ossy@webkit.org's avatar
      [Qt] Unreviewed, rolling out 128054, because it broke the Windows build. · 352cef70
      ossy@webkit.org authored
      * DerivedSources.pri:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@128187 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      352cef70
    • commit-queue@webkit.org's avatar
      [WK2][WTR] WebKitTestRunner needs testRunner.setSpatialNavigationEnabled · d1b0200d
      commit-queue@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=96269
      
      Patch by Mikhail Pozdnyakov <mikhail.pozdnyakov@intel.com> on 2012-09-11
      Reviewed by Kenneth Rohde Christiansen.
      
      Source/WebKit2:
      
      Added a new setter for spacial navigation enabling to Injected Bundle private API.
      
      * WebProcess/InjectedBundle/API/c/WKBundle.cpp:
      (WKBundleSetSpatialNavigationEnabled):
      * WebProcess/InjectedBundle/API/c/WKBundlePrivate.h:
      * WebProcess/InjectedBundle/InjectedBundle.cpp:
      (WebKit::InjectedBundle::setSpatialNavigationEnabled):
      (WebKit):
      * WebProcess/InjectedBundle/InjectedBundle.h:
      (InjectedBundle):
      
      Tools:
      
      Exported missing testRunner.setSpatialNavigationEnabled() method.
      
      * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
      * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
      (WTR::InjectedBundle::beginTesting):
      * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
      (WTR::TestRunner::setSpatialNavigationEnabled):
      (WTR):
      * WebKitTestRunner/InjectedBundle/TestRunner.h:
      (TestRunner):
      
      LayoutTests:
      
      Unskipped fast/spatial-navigation tests. Put those which still fail to an appropriate group.
      
      * platform/wk2/Skipped:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@128186 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      d1b0200d
    • abecsi@webkit.org's avatar
      [Qt] Fix the build with libwebp · 58b3da94
      abecsi@webkit.org authored
      Rubber-stamped by Tor Arne Vestbø
      
      The use-flag is called WEBP not LIBWEBP, so use that when appending -lwebp.
      
      * WebCore.pri:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@128185 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      58b3da94
    • caseq@chromium.org's avatar
      Web Inspector: visualize layout root in Timeline · 0fb6ee27
      caseq@chromium.org authored
      https://bugs.webkit.org/show_bug.cgi?id=96279
      
      Reviewed by Pavel Feldman.
      
      - pass layout root to InspectorTimelineAgent::didLayout
      - show rectangles of the layout root upon hover over the Layout record;
      
      * inspector/InspectorInstrumentation.cpp:
      (WebCore):
      (WebCore::InspectorInstrumentation::didLayoutImpl):
      * inspector/InspectorInstrumentation.h:
      (WebCore):
      (InspectorInstrumentation):
      (WebCore::InspectorInstrumentation::didLayout):
      * inspector/InspectorTimelineAgent.cpp:
      (WebCore::InspectorTimelineAgent::didLayout):
      * inspector/InspectorTimelineAgent.h:
      (WebCore):
      (InspectorTimelineAgent):
      * inspector/TimelineRecordFactory.cpp:
      (WebCore::TimelineRecordFactory::createPaintData):
      (WebCore::TimelineRecordFactory::addRectData):
      (WebCore):
      * inspector/TimelineRecordFactory.h:
      (TimelineRecordFactory):
      * inspector/front-end/TimelinePanel.js:
      (WebInspector.TimelinePanel.prototype._mouseMove):
      * page/FrameView.cpp:
      (WebCore::FrameView::layout):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@128184 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      0fb6ee27
    • anilsson@rim.com's avatar
      [BlackBerry] SelectionHandler drops caret change notifications · eaf279e8
      anilsson@rim.com authored
      https://bugs.webkit.org/show_bug.cgi?id=96378
      
      Reviewed by Antonio Gomes.
      
      The selection handler deliberately drops caret change notifications
      while the input handler is processing changes, to avoid displaying
      intermediate state during a complex change.
      
      However, this meant that the client was never informed of the final
      caret position.
      
      Fixed by notifying client about caret change after processing ends, if
      one or more caret change notifications were dropped during processing.
      
      PR #205073
      
      Reviewed internally by Mike Fenton.
      
      * WebKitSupport/InputHandler.cpp:
      (BlackBerry::WebKit::InputHandler::setProcessingChange):
      (WebKit):
      * WebKitSupport/InputHandler.h:
      (InputHandler):
      * WebKitSupport/SelectionHandler.cpp:
      (BlackBerry::WebKit::SelectionHandler::SelectionHandler):
      (BlackBerry::WebKit::SelectionHandler::inputHandlerDidFinishProcessingChange):
      (WebKit):
      (BlackBerry::WebKit::SelectionHandler::selectionPositionChanged):
      (BlackBerry::WebKit::SelectionHandler::notifyCaretPositionChangedIfNeeded):
      * WebKitSupport/SelectionHandler.h:
      (SelectionHandler):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@128183 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      eaf279e8
    • commit-queue@webkit.org's avatar
      [Blackberry] use ReadOnlyLatin1String to save a deep copy · 81c5882c
      commit-queue@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=96364
      
      Patch by Chris Guan <chris.guan@torchmobile.com.cn> on 2012-09-11
      Reviewed by Yong Li.
      Internally reviewed by Yong li.
      
      * platform/network/blackberry/NetworkManager.cpp:
      (WebCore::NetworkManager::startJob):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@128182 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      81c5882c
    • commit-queue@webkit.org's avatar
      Tools: Support LayoutTests on non-rooted devices for Chromium Android. · dc19e85c
      commit-queue@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=95346
      
      Patch by Philippe Liard <pliard@chromium.org> on 2012-09-11
      Reviewed by Dirk Pranke.
      
      We were requiring root permissions to sync resource files with the
      device by comparing host and device files' timestamp after we
      synchronized the device and host clocks.
      We now rely on md5sum provided by Chromium to handle data files
      synchronization.
      
      * Scripts/webkitpy/layout_tests/port/chromium.py:
      (ChromiumPort._check_driver_build_up_to_date):
      * Scripts/webkitpy/layout_tests/port/chromium_android.py:
      (ChromiumAndroidDriver.__init__):
      (ChromiumAndroidDriver._setup_test):
      (ChromiumAndroidDriver._push_executable):
      (ChromiumAndroidDriver._push_test_resources):
      (ChromiumAndroidDriver._read_prompt):
      
      LayoutTests: Support LayoutTests on non-rooted Android devices.
      https://bugs.webkit.org/show_bug.cgi?id=95346
      
      Patch by Philippe Liard <pliard@chromium.org> on 2012-09-11
      Reviewed by Dirk Pranke.
      
      http/tests/cache/resources/subresource-test.js was assuming that the
      client and server clocks are the same which is no longer true since we
      are getting rid of host/device clock synchronization.
      
      * http/tests/cache/resources/cache-simulator.cgi:
      * http/tests/cache/resources/current-time.cgi: Added.
      * http/tests/cache/resources/subresource-test.js:
      (getServerDate):
      (nextTest):
      (testComplete):
      (runTests):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@128181 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      dc19e85c
    • hausmann@webkit.org's avatar
      [Qt] Fix output paths on Windows · b252b778
      hausmann@webkit.org authored
      Reviewed by Tor Arne Vestbø.
      
      BUILD_ROOT_RELATIVE_TO_OUT_PWD was calculated incorrectly Windows, resulting in an incorrect
      DESTDIR transformation at the end of default_post.prf. The calculation should be baased no qmake
      paths, which can use drive letters but always use forward slashes. So the use of QMAKE_DIR_SEP is
      incorrect here and instead for the calculation we should use forward slashes.
      
      * qmake/mkspecs/features/default_pre.prf:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@128180 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      b252b778
    • vestbo@webkit.org's avatar
      [Qt] Fix passing of defines from the build system · fd6e0d52
      vestbo@webkit.org authored
      We explicitly have to pass -DENABLE_FOO=0 for every single feature
      that's not explicitly enabled in WEBKIT_CONFIG, since Platform.h
      will add it's own defaults if the features are not defined.
      
      At some point we might want to run a configure-test to inspect what
      Platform.h will do, so we can sync up the build system's view of
      the feature-defines with the compile-time situation.
      
      Reviewed by Simon Hausmann.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@128179 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      fd6e0d52