1. 03 Feb, 2012 1 commit
  2. 19 Jan, 2012 1 commit
    • alexis.menard@openbossa.org's avatar
      Strange Result for getComputedStyle on borderWidth set in em · 31e4cf3b
      alexis.menard@openbossa.org authored
      https://bugs.webkit.org/show_bug.cgi?id=18294
      
      Reviewed by Tony Chang.
      
      Source/WebCore:
      
      BorderValue stores its width on a 12 bits unsigned. This patch
      increase it to 27. The patch also modify the way to set the
      width or to get it, we now use a unsigned rather than a short.
      
      Test: fast/css/border-width-large.html
      
      * css/CSSPrimitiveValue.cpp:
      (WebCore::CSSPrimitiveValue::computeLength):
      * css/CSSStyleApplyProperty.cpp:
      (WebCore::CSSStyleApplyProperty::CSSStyleApplyProperty):
      * page/animation/AnimationBase.cpp:
      (WebCore::blendFunc):
      (WebCore::AnimationBase::ensurePropertyMap):
      * platform/animation/AnimationUtilities.h:
      (WebCore::blend):
      * rendering/RenderTheme.cpp:
      (WebCore::RenderTheme::adjustStyle):
      * rendering/style/BorderData.h:
      (WebCore::BorderData::borderLeftWidth):
      (WebCore::BorderData::borderRightWidth):
      (WebCore::BorderData::borderTopWidth):
      (WebCore::BorderData::borderBottomWidth):
      * rendering/style/BorderValue.h:
      (WebCore::BorderValue::width):
      * rendering/style/RenderStyle.cpp:
      * rendering/style/RenderStyle.h:
      (WebCore::RenderStyleBitfields::borderLeftWidth):
      (WebCore::RenderStyleBitfields::borderRightWidth):
      (WebCore::RenderStyleBitfields::borderTopWidth):
      (WebCore::RenderStyleBitfields::borderBottomWidth):
      (WebCore::RenderStyleBitfields::setBorderLeftWidth):
      (WebCore::RenderStyleBitfields::setBorderRightWidth):
      (WebCore::RenderStyleBitfields::setBorderTopWidth):
      (WebCore::RenderStyleBitfields::setBorderBottomWidth):
      (WebCore::RenderStyleBitfields::initialBorderWidth):
      (WebCore::RenderStyleBitfields::initialColumnRuleWidth):
      (WebCore::RenderStyleBitfields::initialOutlineWidth):
      
      LayoutTests:
      
      This test covers that setting big values to border-width will
      return correct values.
      
      * fast/css/border-width-large-expected.txt: Added.
      * fast/css/border-width-large.html: Added.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@105403 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      31e4cf3b
  3. 14 Dec, 2011 1 commit
  4. 13 Dec, 2011 1 commit
    • simon.fraser@apple.com's avatar
      Share blend progress code · 8b3b768c
      simon.fraser@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=74464
      
      Reviewed by Dean Jackson.
      
      Lots of places in the code had copies of the animation interpolation
      logic "from + (to - from) * progress", in various forms.
      
      Coalesce all these into calls to a few new inline functions in a new
      AnimationUtilities.h header. Color and Length get their own blend fuctions
      in their respective headers.
      
      Covered by existing tests.
      
      * GNUmakefile.list.am:
      * Target.pri:
      * WebCore.gypi:
      * WebCore.vcproj/WebCore.vcproj:
      * WebCore.xcodeproj/project.pbxproj:
      * css/CSSGradientValue.cpp:
      * page/animation/AnimationBase.cpp:
      (WebCore::blendFunc):
      * platform/Length.h:
      (WebCore::Length::blend):
      * platform/animation/AnimationUtilities.h: Added.
      (WebCore::blend):
      * platform/graphics/Color.h:
      (WebCore::blend):
      * platform/graphics/transforms/PerspectiveTransformOperation.cpp:
      (WebCore::PerspectiveTransformOperation::blend):
      * platform/graphics/transforms/RotateTransformOperation.cpp:
      (WebCore::RotateTransformOperation::blend):
      * platform/graphics/transforms/ScaleTransformOperation.cpp:
      (WebCore::ScaleTransformOperation::blend):
      * platform/graphics/transforms/SkewTransformOperation.cpp:
      (WebCore::SkewTransformOperation::blend):
      * platform/graphics/transforms/TranslateTransformOperation.cpp:
      (WebCore::TranslateTransformOperation::blend):
      * svg/SVGLength.h:
      (WebCore::SVGLength::blend):
      * svg/SVGPathBlender.cpp:
      (WebCore::blendFloatPoint):
      (WebCore::SVGPathBlender::blendAnimatedDimensonalFloat):
      (WebCore::SVGPathBlender::blendArcToSegment):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@102740 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      8b3b768c
  5. 25 Aug, 2011 1 commit
    • macpherson@chromium.org's avatar
      Implement animation and transition properties in CSSStyleApplyProperty. · cf898fa0
      macpherson@chromium.org authored
      https://bugs.webkit.org/show_bug.cgi?id=66126
      
      Reviewed by Dean Jackson.
      
      No new tests. This is essentially a refactoring of the HANDLE_ANIMATION* and HANDLE_TRANSITION* macros in CSSStyleSelector.cpp.
      The only functional change is to iterate correctly over the lists instead of setting only the first element. See bug 66118 for details on that.
      
      * css/CSSStyleApplyProperty.cpp:
      Added new class ApplyPropertyAnimation to handle animation and transition properties.
      (WebCore::ApplyPropertyAnimation::ApplyPropertyAnimation):
      (WebCore::ApplyPropertyAnimation::applyInheritValue):
      (WebCore::ApplyPropertyAnimation::applyInitialValue):
      (WebCore::ApplyPropertyAnimation::applyValue):
      (WebCore::ApplyPropertyAnimation::setValue):
      (WebCore::ApplyPropertyAnimation::value):
      (WebCore::ApplyPropertyAnimation::test):
      (WebCore::ApplyPropertyAnimation::clear):
      (WebCore::ApplyPropertyAnimation::initial):
      (WebCore::ApplyPropertyAnimation::map):
      (WebCore::ApplyPropertyAnimation::accessAnimations):
      (WebCore::ApplyPropertyAnimation::animations):
      (WebCore::CSSStyleApplyProperty::CSSStyleApplyProperty):
      * css/CSSStyleSelector.cpp:
      Removed animation and transition macros (celebrate!)
      (WebCore::CSSStyleSelector::applyProperty):
      Removed old implementations of animation and transition properties.
      * platform/animation/Animation.h:
      Changed return types of initial values to match the setters and getters.
      (WebCore::Animation::initialAnimationDelay):
      (WebCore::Animation::initialAnimationName):
      (WebCore::Animation::initialAnimationTimingFunction):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@93848 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      cf898fa0
  6. 30 May, 2011 2 commits
  7. 03 Mar, 2011 2 commits
    • cmarrin@apple.com's avatar
      2011-03-03 Chris Marrin <cmarrin@apple.com> · 5eb611d0
      cmarrin@apple.com authored
              Reviewed by Simon Fraser.
      
              REGRESSION: Accelerated transitions are jumpy
              https://bugs.webkit.org/show_bug.cgi?id=55022
      
              Changed the way default TimingFunction is stored according to Adam Roben's
              suggestion.
      
              * platform/animation/TimingFunction.h:
              (WebCore::CubicBezierTimingFunction::defaultTimingFunction):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@80289 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      5eb611d0
    • cmarrin@apple.com's avatar
      2011-03-02 Chris Marrin <cmarrin@apple.com> · 4b511939
      cmarrin@apple.com authored
              Reviewed by Simon Fraser.
      
              REGRESSION: Accelerated transitions are jumpy
              https://bugs.webkit.org/show_bug.cgi?id=55022
      
              Got rid of default TimingFunction values from PlatformCAAnimation*. A TimingFunction
              is now always passed in. The TimingFunction class now has a static method to get
              a default object which has the 'ease' values in it. I now assert in both Mac and
              Win implementations if a null TimingFunction pointer is seen.
      
              * platform/animation/TimingFunction.h:
              (WebCore::CubicBezierTimingFunction::create):
              (WebCore::CubicBezierTimingFunction::defaultTimingFunction):
              (WebCore::CubicBezierTimingFunction::CubicBezierTimingFunction):
              * platform/graphics/ca/GraphicsLayerCA.cpp:
              (WebCore::GraphicsLayerCA::timingFunctionForAnimationValue):
              * platform/graphics/ca/mac/PlatformCAAnimationMac.mm:
              (toCAMediaTimingFunction):
              * platform/graphics/ca/win/PlatformCAAnimationWin.cpp:
              (toCACFTimingFunction):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@80266 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      4b511939
  8. 20 Jan, 2011 1 commit
    • ossy@webkit.org's avatar
      Refactoring of the custom allocation framework · 95c1bc42
      ossy@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=49897
      
      Patch by Zoltan Horvath <zoltan@webkit.org> on 2011-01-20
      Reviewed by Csaba Osztrogonác.
      
      Source/JavaScriptCore:
      
      Inheriting from FastAllocBase can result in objects getting larger (bug #33896, #46589).
      The modification replaces Noncopyable and FastAllocBase classes and these inherits with their
      equivalent macro implementation at the necessary places.
      
      * wtf/FastAllocBase.h: Turn FastAllocBase's implementation into a macro.
      
      Source/WebCore:
      
      Inheriting from FastAllocBase can result in objects getting larger (bug #33896, #46589).
      The modification replaces Noncopyable and FastAllocBase classes and these inherits with their
      equivalent macro implementation at the necessary places.
      
      Source/WebKit:
      
      Inheriting from FastAllocBase can result in objects getting larger (bug #33896, #46589).
      The modification replaces Noncopyable and FastAllocBase classes and these inherits with their
      equivalent macro implementation at the necessary places.
      
      Source/WebKit2:
      
      Inheriting from FastAllocBase can result in objects getting larger (bug #33896, #46589).
      The modification replaces Noncopyable and FastAllocBase classes and these inherits with their
      equivalent macro implementation at the necessary places.
      
      Tools:
      
      Inheriting from FastAllocBase can result in objects getting larger (bug #33896, #46589).
      The modification replaces Noncopyable and FastAllocBase classes and these inherits with their
      equivalent macro implementation at the necessary places.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@76248 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      95c1bc42
  9. 08 Jan, 2011 1 commit