1. 23 Jul, 2009 40 commits
    • cfleizach@apple.com's avatar
    • darin@apple.com's avatar
      2009-07-23 Darin Adler <darin@apple.com> · 0395090d
      darin@apple.com authored
              * WebView/WebDataSource.mm:
              (-[WebDataSource _makeRepresentation]): Landed a comment I forgot last time.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@46300 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      0395090d
    • mrowe@apple.com's avatar
      Update layout test results for three tests related to text fields as their metrics · b43babdd
      mrowe@apple.com authored
      have changed slightly since the results were last updated.
      
      Rubber-stamped by Dan Bernstein.
      
      * platform/mac-leopard/fast/forms/text-control-intrinsic-widths-expected.txt: Copied from LayoutTests/fast/forms/text-control-intrinsic-widths-expected.txt.
      * platform/mac/fast/forms/input-text-maxlength-expected.txt:
      * platform/mac/fast/forms/input-text-paste-maxlength-expected.txt:
      * platform/mac/fast/forms/text-control-intrinsic-widths-expected.txt: Renamed from LayoutTests/fast/forms/text-control-intrinsic-widths-expected.txt.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@46299 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      b43babdd
    • darin@apple.com's avatar
      WebCore: · 719d29cb
      darin@apple.com authored
      2009-07-23  Darin Adler  <darin@apple.com>
      
              Reviewed by Brady Eidson.
      
              URL appears in back/forward button menu instead of title for items with custom representation
              https://bugs.webkit.org/show_bug.cgi?id=27586
              rdar://problem/5060337
      
              * WebCore.base.exp: Exported DocumentLoader::setTitle for use by Mac WebKit.
              * loader/FrameLoader.cpp:
              (WebCore::FrameLoader::didChangeTitle): Tightened code to check if the document
              loader is the correct one; previously this would never happen because we'd
              commit the load before any title changes could be registered, but now we can
              encounter a case where we get a title during a provisional load.
      
      WebKit/mac:
      
      2009-07-23  Darin Adler  <darin@apple.com>
      
              Reviewed by Brady Eidson.
      
              URL appears in back/forward button menu instead of title for items with custom representation
              https://bugs.webkit.org/show_bug.cgi?id=27586
              rdar://problem/5060337
      
              The problem is that DocumentLoader expects to store a title, but for custom representations
              it is never passed to the document loader.
      
              * WebView/WebDataSource.mm:
              (-[WebDataSource _makeRepresentation]): Added a call to DocumentLoader::setTitle.
              Works as long as the title does not change during the document's lifetime, which
              is good enough for the simple cases in Safari.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@46298 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      719d29cb
    • mrowe@apple.com's avatar
      Update default state of the XSS auditor in GTK DumpRenderTree to match Mac and Windows · 062ce4a1
      mrowe@apple.com authored
      in hopes of fixing some layout test failures seen on the build bot.
      
      Reviewed by Oliver Hunt.
      
      * DumpRenderTree/gtk/DumpRenderTree.cpp:
      (resetWebViewToConsistentStateBeforeTesting):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@46297 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      062ce4a1
    • mrowe@apple.com's avatar
      Windows appears to match the Leopard results for the CSS 2.1 counter tests that were failing. · 23c2cc53
      mrowe@apple.com authored
      * platform/win/css2.1/t1202-counter-04-b-expected.txt: Copied from LayoutTests/platform/mac-leopard/css2.1/t1202-counter-04-b-expected.txt.
      * platform/win/css2.1/t1202-counters-04-b-expected.txt: Copied from LayoutTests/platform/mac-leopard/css2.1/t1202-counters-04-b-expected.txt.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@46296 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      23c2cc53
    • mitz@apple.com's avatar
      WebCore: · fde1b4b0
      mitz@apple.com authored
              Reviewed by Dave Hyatt.
      
              [CSS3 Backgrounds and Borders] Add support for inset box shadows
              https://bugs.webkit.org/show_bug.cgi?id=27582
      
              Test: fast/box-shadow/inset.html
      
              * css/CSSComputedStyleDeclaration.cpp:
              (WebCore::valueForShadow): Set the ShadowValue’s shadow style to 'inset'
                  as needed.
      
              * css/CSSParser.cpp:
              (WebCore::ShadowParseContext::ShadowParseContext): Added style and allowStyle
                  members. Initialize the allowStyle member.
              (WebCore::ShadowParseContext::commitValue): Pass the style value to the
                  ShadowValue constructor. Reset allowStyle.
              (WebCore::ShadowParseContext::commitLength): Update allowStyle.
              (WebCore::ShadowParseContext::commitColor): Ditto.
              (WebCore::ShadowParseContext::commitStyle): Added. Sets the style member and
                  updates the state.
              (WebCore::CSSParser::parseShadow): Parse the 'inset' keyword.
      
              * css/CSSStyleSelector.cpp:
              (WebCore::CSSStyleSelector::applyProperty): Get the style value from the
                  shadow value and pass it to the ShadowData constructor.
      
              * css/ShadowValue.cpp:
              (WebCore::ShadowValue::ShadowValue): Added style.
              (WebCore::ShadowValue::cssText): Added style.
      
              * css/ShadowValue.h:
              (WebCore::ShadowValue::create): Added style.
      
              * page/animation/AnimationBase.cpp:
              (WebCore::blendFunc): Added a blend function for shadow styles. When blending
                  between normal and inset shadows, all intermediate values map to normal.
              (WebCore::PropertyWrapperShadow::blend): Added normal style to the default
                  shadow.
                  
              * rendering/InlineFlowBox.cpp:
              (WebCore::InlineFlowBox::paintBoxShadow): Added a shadow style parameter,
                  which is passed through to RenderBoxModelObject::paintBoxShadow().
      
              (WebCore::InlineFlowBox::paintBoxDecorations): Paint inset shadows on top of
                  the background.
      
              * rendering/InlineFlowBox.h:
      
              * rendering/RenderBox.cpp:
              (WebCore::RenderBox::paintBoxDecorations): Paint inset shadows on top of the
                  background.
      
              * rendering/RenderBoxModelObject.cpp:
              (WebCore::RenderBoxModelObject::paintBoxShadow): Added a shadow style
                  parameter, and code to paint inset shadows.
      
              * rendering/RenderBoxModelObject.h:
      
              * rendering/RenderFieldset.cpp:
              (WebCore::RenderFieldset::paintBoxDecorations): Paint inset shadows on top of
                  the background.
      
              * rendering/RenderTable.cpp:
              (WebCore::RenderTable::paintBoxDecorations): Ditto.
      
              * rendering/RenderTableCell.cpp:
              (WebCore::RenderTableCell::paintBoxDecorations): Ditto.
      
              * rendering/style/ShadowData.h:
              Added a ShadowStyle enum.
              (WebCore::ShadowData::ShadowData): Add and initialize a style member.
      
      LayoutTests:
      
              Reviewed by Dave Hyatt.
      
              [CSS3 Backgrounds and Borders] Add support for inset box shadows
              https://bugs.webkit.org/show_bug.cgi?id=27582
      
              * fast/box-shadow/inset.html: Added.
              * platform/mac/fast/box-shadow/inset-expected.checksum: Added.
              * platform/mac/fast/box-shadow/inset-expected.png: Added.
              * platform/mac/fast/box-shadow/inset-expected.txt: Added.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@46295 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      fde1b4b0
    • treat@webkit.org's avatar
      2009-07-23 Jakob Petsovits <jakob.petsovits@torchmobile.com> · 4629ee3a
      treat@webkit.org authored
               Reviewed by Adam Treat.
      
               Fix false positives for switch statement indentation check in cpplint.
               https://bugs.webkit.org/show_bug.cgi?id=27615
      
               Makes one-line case statements (e.g. "case foo: bar();") work.
               Also a few general improvements to the robustness and readability of
               the check, and more test cases.
      
               * Scripts/modules/cpplint.py:
               * Scripts/modules/cpplint_unittest.py:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@46294 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      4629ee3a
    • simon.fraser@apple.com's avatar
      2009-07-23 Simon Fraser <simon.fraser@apple.com> · 69070f36
      simon.fraser@apple.com authored
              Fix the build with UNUSED_PARAM(frame) for when ENABLE(3D_RENDERING) is not defined.
      
              * css/MediaQueryEvaluator.cpp:
              (WebCore::transform_3dMediaFeatureEval):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@46293 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      69070f36
    • treat@webkit.org's avatar
      2009-07-23 Jakob Petsovits <jakob.petsovits@torchmobile.com> · 2fe25536
      treat@webkit.org authored
               Reviewed by Adam Treat.
      
               Add check for line-breaking rule #3 to cpplint.
               https://bugs.webkit.org/show_bug.cgi?id=27610
      
               "An else if statement should be written as an if statement when
               the prior if concludes with a return statement."
      
               Implemented by a multi-line (kind of back-tracking) algorithm.
               Comes with loads of unit tests. Fixes the check for label indentation
               to be not so overzealous, as it didn't allow for completely unindented
               goto labels (at the very start of a line).
      
               * Scripts/modules/cpplint.py:
               * Scripts/modules/cpplint_unittest.py:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@46292 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      2fe25536
    • simon.fraser@apple.com's avatar
      2009-07-23 Simon Fraser <simon.fraser@apple.com> · ec4b4f9e
      simon.fraser@apple.com authored
              Reviewed by Adele Peterson.
      
              3d-transforms media query needs to look check that accelerated compositing is enabled
              https://bugs.webkit.org/show_bug.cgi?id=27621
      
              When evaluating a media query with '-webkit-transform-3d', we need to check the
              runtime switch that toggles accererated compositing, and therefore 3D.
      
              No test because we can't disable the pref dynamically in DRT.
      
              * css/MediaQueryEvaluator.cpp:
              (WebCore::transform_3dMediaFeatureEval):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@46291 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      ec4b4f9e
    • mrowe@apple.com's avatar
      Update layout test results for two international text tests that are failing... · 5752f6e1
      mrowe@apple.com authored
      Update layout test results for two international text tests that are failing due to font differences.
      
      Rubber-stamped by Dan Bernstein.
      
      * platform/mac-leopard/fast/text/international/thai-baht-space-expected.checksum: Renamed from LayoutTests/platform/mac/fast/text/international/thai-baht-space-expected.checksum.
      * platform/mac-leopard/fast/text/international/thai-baht-space-expected.png: Renamed from LayoutTests/platform/mac/fast/text/international/thai-baht-space-expected.png.
      * platform/mac-leopard/fast/text/international/thai-baht-space-expected.txt: Copied from LayoutTests/platform/mac/fast/text/international/thai-baht-space-expected.txt.
      * platform/mac/fast/text/international/bidi-neutral-directionality-paragraph-start-expected.txt:
      * platform/mac/fast/text/international/thai-baht-space-expected.txt:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@46290 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      5752f6e1
    • mrowe@apple.com's avatar
      Update layout test results for two CSS 2.1 counter tests that are failing due to font differences. · 9e962c0b
      mrowe@apple.com authored
      Rubber-stamped by Dan Bernstein.
      
      * platform/mac-leopard/css2.1/t1202-counter-04-b-expected.txt: Copied from LayoutTests/platform/mac/css2.1/t1202-counter-04-b-expected.txt.
      * platform/mac-leopard/css2.1/t1202-counters-04-b-expected.txt: Copied from LayoutTests/platform/mac/css2.1/t1202-counters-04-b-expected.txt.
      * platform/mac/css2.1/t1202-counter-04-b-expected.txt:
      * platform/mac/css2.1/t1202-counters-04-b-expected.txt:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@46289 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      9e962c0b
    • pdherbemont@apple.com's avatar
      2009-07-23 Pierre d'Herbemont <pdherbemont@apple.com> · b1a382bb
      pdherbemont@apple.com authored
              Layout test fix so no review.
      
              Add audio-controls-rendering layout test results for windows and leopard.
      
              * platform/mac-leopard/media/audio-controls-rendering-expected.txt: Added.
              * platform/win/media/audio-controls-rendering-expected.txt: Added.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@46288 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      b1a382bb
    • mrowe@apple.com's avatar
      Update layout test results for the addition of a new computed style property in r46285. · d8a4e4af
      mrowe@apple.com authored
      * fast/css/getComputedStyle/computed-style-expected.txt:
      * fast/css/getComputedStyle/computed-style-without-renderer-expected.txt:
      * platform/mac/fast/css/getComputedStyle/computed-style-expected.txt:
      * platform/mac/fast/css/getComputedStyle/computed-style-without-renderer-expected.txt:
      * platform/qt/fast/css/getComputedStyle/computed-style-expected.txt:
      * platform/qt/fast/css/getComputedStyle/computed-style-without-renderer-expected.txt:
      * platform/win/fast/css/getComputedStyle/computed-style-expected.txt:
      * platform/win/fast/css/getComputedStyle/computed-style-without-renderer-expected.txt:
      * svg/css/getComputedStyle-basic-expected.txt:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@46287 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      d8a4e4af
    • rniwa@webkit.org's avatar
      WebCore: · 5bd84ef3
      rniwa@webkit.org authored
      2009-07-22  Ryosuke Niwa  <rniwa@webkit.org>
      
              Reviewed by Eric Seidel.
      
              execCommand('underline') can't remove <U> underlines
              https://bugs.webkit.org/show_bug.cgi?id=20215
      
              This patch adds support for u, s, and strike to implicitlyStyledElementShouldBeRemovedWhenApplyingStyle so that
              WebKit can remove those presentational tags when necessary.
              It also modifies StyleChange::init not to add "text-decoration: none".  Not only is this style meaningless
              (does not override inherited styles) but it was also causing WebKit to generate extra spans with this style.
      
              * css/CSSValueList.cpp:
              (WebCore::CSSValueList::hasValue): True if the property contains the specified value
              * css/CSSValueList.h: Updated prototype
              * editing/ApplyStyleCommand.cpp:
              (WebCore::StyleChange::init): No longer adds "text-decoration: none"
              (WebCore::ApplyStyleCommand::implicitlyStyledElementShouldBeRemovedWhenApplyingStyle): Supports text-decoration-related elements
      
      LayoutTests:
      
      2009-07-22  Ryosuke Niwa  <rniwa@webkit.org>
      
              Reviewed by Eric Seidel.
      
              execCommand('underline') can't remove <U> underlines
              https://bugs.webkit.org/show_bug.cgi?id=20215
      
              This patch rebaselines toggle-styles.html because WebKit now passes three tests it used to fail.
              toggle-style-2.html is added to test cases in which multiple styles are specified with tags.
              We still fail some tests because WebKit doesn't properly support non-CSS mode but they are visually correct.
      
              * editing/execCommand/resources/toggle-style-2.js: Added.
              (testSingleToggle):
              (testDoubleToggle):
              * editing/execCommand/toggle-style-2-expected.txt: Added.
              * editing/execCommand/toggle-style-2.html: Added.
              * editing/execCommand/toggle-styles-expected.txt: Passes all the tests
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@46286 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      5bd84ef3
    • jberlin@apple.com's avatar
      2009-07-23 Jessie Berlin <jberlin@apple.com> · e5f53553
      jberlin@apple.com authored
              https://bugs.webkit.org/show_bug.cgi?id=27554
              Expose the value of text-overflow in getComputedStyle.
              
              Reviewed by Dan Bernstein.
      
              Test: fast/css/getComputedStyle/getComputedStyle-text-overflow.html
      
              * css/CSSComputedStyleDeclaration.cpp:
              (WebCore::):
              Add text-overflow to the list of computedProperties.
              (WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):
              Return the value of the text-overflow property.
      
              * fast/css/getComputedStyle/getComputedStyle-text-overflow-expected.txt: Added.
              * fast/css/getComputedStyle/getComputedStyle-text-overflow.html: Added.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@46285 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      e5f53553
    • hausmann@webkit.org's avatar
      2009-07-23 Yongjun Zhang <yongjun.zhang@nokia.com> · 096c6a95
      hausmann@webkit.org authored
              Reviewed by Simon Hausmann.
      
              https://bugs.webkit.org/show_bug.cgi?id=27510
      
              [S60 QtWebKit] Don't put some intermediate generated files into the final mmp project
              file for linking. This is a temporary workaround for qmake bug in Symbian port, should
              be reverted after qmake is fixed.
      
              * WebCore.pro:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@46284 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      096c6a95
    • jianli@chromium.org's avatar
      2009-07-23 Jian Li <jianli@chromium.org> · 10b1eaaf
      jianli@chromium.org authored
              Reviewed by David Levin.
      
              [V8] Fix an assert in running workers in Chrome.
              https://bugs.webkit.org/show_bug.cgi?id=27620
      
              The fix is to change V8DOMMap::removeAllDOMObjectsInCurrentThreadHelper
              to do not call removeObjectsFromWrapperMap for certain types of DOM
              objects that exist only in main thread.
      
              * bindings/v8/V8DOMMap.cpp:
              (WebCore::removeAllDOMObjectsInCurrentThreadHelper):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@46283 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      10b1eaaf
    • rniwa@webkit.org's avatar
      2009-07-23 Ryosuke Niwa <rniwa@webkit.org> · eee58410
      rniwa@webkit.org authored
              Reviewed by David Hyatt.
      
              Rebaseline for http://trac.webkit.org/changeset/46274
              (The changeset rebaselined the expected results for mac but not for windows)
      
              * platform/win/fast/css/getComputedStyle/computed-style-expected.txt:
              * platform/win/fast/css/getComputedStyle/computed-style-without-renderer-expected.txt:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@46282 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      eee58410
    • hyatt@apple.com's avatar
      WebCore: · b3f921e5
      hyatt@apple.com authored
      2009-07-23  David Hyatt  <hyatt@apple.com>
      
              Reviewed by Dan Bernstein.
      
              https://bugs.webkit.org/show_bug.cgi?id=27572
              Implement support for background-attachment:local.
      
              Added new test fast/overflow/overflow-with-local-attachment.html.
      
              * css/CSSComputedStyleDeclaration.cpp:
              (WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):
              * css/CSSParser.cpp:
              (WebCore::CSSParser::parseFillProperty):
              * css/CSSPrimitiveValueMappings.h:
              (WebCore::CSSPrimitiveValue::CSSPrimitiveValue):
              (WebCore::CSSPrimitiveValue::operator EFillAttachment):
              * css/CSSStyleSelector.cpp:
              (WebCore::CSSStyleSelector::mapFillAttachment):
              * css/CSSValueKeywords.in:
              * rendering/RenderBoxModelObject.cpp:
              (WebCore::RenderBoxModelObject::paintFillLayerExtended):
              (WebCore::RenderBoxModelObject::calculateBackgroundImageGeometry):
              * rendering/style/FillLayer.h:
              (WebCore::FillLayer::attachment):
              (WebCore::FillLayer::setAttachment):
              (WebCore::FillLayer::hasFixedImage):
              (WebCore::FillLayer::initialFillAttachment):
              * rendering/style/RenderStyle.h:
              (WebCore::InheritedFlags::backgroundAttachment):
              (WebCore::InheritedFlags::maskAttachment):
              * rendering/style/RenderStyleConstants.h:
              (WebCore::):
      
      LayoutTests:
      
      2009-07-23  David Hyatt  <hyatt@apple.com>
      
              Reviewed by Dan Bernstein.
      
              https://bugs.webkit.org/show_bug.cgi?id=27572
              Implement support for background-attachment:local.
      
              Added new test fast/overflow/overflow-with-local-attachment.html.
      
              * fast/overflow/overflow-with-local-background-attachment.html: Added.
              * platform/mac/fast/overflow/overflow-with-local-background-attachment-expected.checksum: Added.
              * platform/mac/fast/overflow/overflow-with-local-background-attachment-expected.png: Added.
              * platform/mac/fast/overflow/overflow-with-local-background-attachment-expected.txt: Added.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@46281 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      b3f921e5
    • rniwa@webkit.org's avatar
      2009-07-23 Ryosuke Niwa <rniwa@webkit.org> · e49e6734
      rniwa@webkit.org authored
              Reviewed by Eric Seidel.
      
              copyInheritableProperties and removeComputedInheritablePropertiesFrom should be deprecated
              https://bugs.webkit.org/show_bug.cgi?id=27325
      
              This patch deprecates copyInheritableProperties because it has been used for two different purposes:
              1.  Calculating the typing style.
              2.  Moving HTML subtrees and seeking to remove redundant styles.
              These tasks should be broken out into two separate functions.  New code should not use this function.
      
              It deletes removeComputedInheritablePropertiesFrom because it hasn't been used anywhere.
      
              There is no test since the patch does not change any behavior.
      
              * css/CSSComputedStyleDeclaration.cpp: removeComputedInheritablePropertiesFrom has been removed
              (WebCore::CSSComputedStyleDeclaration::deprecatedCopyInheritableProperties): has been renamed from copyInheritableProperties
              * css/CSSComputedStyleDeclaration.h: ditto
              * editing/DeleteSelectionCommand.cpp: ditto
              (WebCore::removeEnclosingAnchorStyle): ditto
              (WebCore::DeleteSelectionCommand::saveTypingStyleState): ditto
              * editing/EditCommand.cpp: ditto
              (WebCore::EditCommand::styleAtPosition): ditto
              * editing/RemoveFormatCommand.cpp: ditto
              (WebCore::RemoveFormatCommand::doApply): ditto
              * editing/ReplaceSelectionCommand.cpp: ditto
              (WebCore::handleStyleSpansBeforeInsertion): ditto
              (WebCore::ReplaceSelectionCommand::handleStyleSpans): ditto
              * editing/markup.cpp: ditto
              (WebCore::removeEnclosingMailBlockquoteStyle): ditto
              (WebCore::removeDefaultStyles): ditto
              (WebCore::createMarkup): ditto
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@46280 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      e49e6734
    • pdherbemont@apple.com's avatar
      WebCore: · 512d4de7
      pdherbemont@apple.com authored
          2009-07-22  Pierre d'Herbemont  <pdherbemont@apple.com>
      
              Reviewed by Simon Fraser.
      
              Audio element at default width shouldn't have time field.
              https://bugs.webkit.org/show_bug.cgi?id=27589
      
              * rendering/MediaControlElements.cpp:
              (WebCore::MediaControlTimeDisplayElement::setVisible): Make sure we don't
              forget to remember the visibility if there is no renderer.
      
      LayoutTests:
      
      2009-07-22  Pierre d'Herbemont  <pdherbemont@apple.com>
      
              Reviewed by Simon Fraser.
      
              Audio element at default width shouldn't have time field.
              https://bugs.webkit.org/show_bug.cgi?id=27589
      
              * platform/mac-snowleopard/Skipped: Enables back audio-controls-rendering.
              * platform/mac/media/audio-controls-rendering-expected.checksum:
              * platform/mac/media/audio-controls-rendering-expected.png:
              * platform/mac/media/audio-controls-rendering-expected.txt:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@46279 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      512d4de7
    • kenneth@webkit.org's avatar
      2009-07-23 Kenneth Rohde Christiansen <kenneth@webkit.org> · c38c84ee
      kenneth@webkit.org authored
              Reviewed by Adam Treat.
      
              Added expected results for tests that we pass.
      
              * platform/qt/editing/inserting/break-blockquote-after-delete-expected.txt: Added.
              * platform/qt/fast/backgrounds/body-generated-image-propagated-to-root-expected.txt: Added.
              * platform/qt/fast/box-shadow/transform-fringing-expected.txt: Added.
              * platform/qt/fast/canvas/drawImage-with-globalAlpha-expected.txt: Added.
              * platform/qt/fast/css/attribute-selector-dynamic-expected.txt: Added.
              * platform/qt/fast/css/nth-child-dynamic-expected.txt: Added.
              * platform/qt/fast/dom/HTMLTableColElement/resize-table-using-col-width-expected.txt: Added.
              * platform/qt/fast/dynamic/anchor-lock-expected.txt: Added.
              * platform/qt/fast/frames/frameset-style-recalc-expected.txt: Added.
              * platform/qt/fast/frames/iframe-text-contents-expected.txt: Added, equal to mac.
              * platform/qt/fast/frames/viewsource-on-image-file-expected.txt: Added.
              * platform/qt/fast/repaint/background-generated-expected.txt: Added, equal to mac.
              * platform/qt/fast/repaint/background-misaligned-expected.txt: Added, equal to mac.
              * platform/qt/fast/repaint/float-in-new-block-with-layout-delta-expected.txt: Added, equal to mac.
              * platform/qt/fast/text/international/hindi-whitespace-expected.txt: Added.
              * platform/qt/fast/transforms/bounding-rect-zoom-expected.txt: Added.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@46278 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      c38c84ee
    • kevino@webkit.org's avatar
      wx build fix, adding missing header. · 60f67ce9
      kevino@webkit.org authored
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@46277 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      60f67ce9
    • bdakin@apple.com's avatar
      2009-07-23 Beth Dakin <bdakin@apple.com> · ab05fc54
      bdakin@apple.com authored
              Reviewed by Darin Adler.
      
              Fix for https://bugs.webkit.org/show_bug.cgi?id=27598 Clean up the 
              AccessibilityObject class
      
              Mostly this is just moving empty stubs into the header rather than 
              muddying the cpp file with them. A few functions were made pure 
              virtual.
      
              * accessibility/AccessibilityObject.cpp:
              (WebCore::AccessibilityObject::isARIAControl):
              (WebCore::AccessibilityObject::clickPoint):
              (WebCore::AccessibilityObject::documentFrameView):
              (WebCore::AccessibilityObject::actionVerb):
              * accessibility/AccessibilityObject.h:
              (WebCore::AccessibilityObject::intValue):
              (WebCore::AccessibilityObject::layoutCount):
              (WebCore::AccessibilityObject::doAccessibilityHitTest):
              (WebCore::AccessibilityObject::focusedUIElement):
              (WebCore::AccessibilityObject::firstChild):
              (WebCore::AccessibilityObject::lastChild):
              (WebCore::AccessibilityObject::previousSibling):
              (WebCore::AccessibilityObject::nextSibling):
              (WebCore::AccessibilityObject::parentObjectIfExists):
              (WebCore::AccessibilityObject::observableObject):
              (WebCore::AccessibilityObject::linkedUIElements):
              (WebCore::AccessibilityObject::titleUIElement):
              (WebCore::AccessibilityObject::ariaRoleAttribute):
              (WebCore::AccessibilityObject::isPresentationalChildOfAriaRole):
              (WebCore::AccessibilityObject::ariaRoleHasPresentationalChildren):
              (WebCore::AccessibilityObject::roleValue):
              (WebCore::AccessibilityObject::ariaAccessiblityName):
              (WebCore::AccessibilityObject::ariaLabeledByAttribute):
              (WebCore::AccessibilityObject::ariaDescribedByAttribute):
              (WebCore::AccessibilityObject::accessibilityDescription):
              (WebCore::AccessibilityObject::ariaSelectedTextDOMRange):
              (WebCore::AccessibilityObject::axObjectCache):
              (WebCore::AccessibilityObject::axObjectID):
              (WebCore::AccessibilityObject::setAXObjectID):
              (WebCore::AccessibilityObject::anchorElement):
              (WebCore::AccessibilityObject::actionElement):
              (WebCore::AccessibilityObject::boundingBoxRect):
              (WebCore::AccessibilityObject::selectedTextRange):
              (WebCore::AccessibilityObject::selectionStart):
              (WebCore::AccessibilityObject::selectionEnd):
              (WebCore::AccessibilityObject::url):
              (WebCore::AccessibilityObject::selection):
              (WebCore::AccessibilityObject::stringValue):
              (WebCore::AccessibilityObject::title):
              (WebCore::AccessibilityObject::helpText):
              (WebCore::AccessibilityObject::textUnderElement):
              (WebCore::AccessibilityObject::text):
              (WebCore::AccessibilityObject::textLength):
              (WebCore::AccessibilityObject::selectedText):
              (WebCore::AccessibilityObject::accessKey):
              (WebCore::AccessibilityObject::widget):
              (WebCore::AccessibilityObject::widgetForAttachmentView):
              (WebCore::AccessibilityObject::setFocused):
              (WebCore::AccessibilityObject::setSelectedText):
              (WebCore::AccessibilityObject::setSelectedTextRange):
              (WebCore::AccessibilityObject::setValue):
              (WebCore::AccessibilityObject::setSelected):
              (WebCore::AccessibilityObject::makeRangeVisible):
              (WebCore::AccessibilityObject::childrenChanged):
              (WebCore::AccessibilityObject::addChildren):
              (WebCore::AccessibilityObject::hasChildren):
              (WebCore::AccessibilityObject::selectedChildren):
              (WebCore::AccessibilityObject::visibleChildren):
              (WebCore::AccessibilityObject::visiblePositionRange):
              (WebCore::AccessibilityObject::visiblePositionRangeForLine):
              (WebCore::AccessibilityObject::boundsForVisiblePositionRange):
              (WebCore::AccessibilityObject::setSelectedVisiblePositionRange):
              (WebCore::AccessibilityObject::visiblePositionForPoint):
              (WebCore::AccessibilityObject::nextVisiblePosition):
              (WebCore::AccessibilityObject::previousVisiblePosition):
              (WebCore::AccessibilityObject::visiblePositionForIndex):
              (WebCore::AccessibilityObject::indexForVisiblePosition):
              (WebCore::AccessibilityObject::index):
              (WebCore::AccessibilityObject::doAXRangeForLine):
              (WebCore::AccessibilityObject::doAXRangeForIndex):
              (WebCore::AccessibilityObject::doAXStringForRange):
              (WebCore::AccessibilityObject::doAXBoundsForRange):
              (WebCore::AccessibilityObject::updateBackingStore):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@46276 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      ab05fc54
    • bweinstein@apple.com's avatar
      Fix of <rdar://4877658> Dragging from the area between the horizontal/vertical... · 9f624e55
      bweinstein@apple.com authored
      Fix of <rdar://4877658> Dragging from the area between the horizontal/vertical scrollbars when status bar is showing starts a selection and autoscroll.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@46275 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      9f624e55
    • hyatt@apple.com's avatar
      WebCore: · 2dde470b
      hyatt@apple.com authored
      2009-07-23  David Hyatt  <hyatt@apple.com>
      
              Reviewed by Dan Bernstein.
      
              https://bugs.webkit.org/show_bug.cgi?id=27581
              Drop the prefix from the box-shadow property.
      
              * css/CSSComputedStyleDeclaration.cpp:
              (WebCore::):
              (WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):
              * css/CSSParser.cpp:
              (WebCore::CSSParser::parseValue):
              (WebCore::ShadowParseContext::commitLength):
              (WebCore::cssPropertyID):
              * css/CSSPropertyNames.in:
              * css/CSSStyleSelector.cpp:
              (WebCore::CSSStyleSelector::applyProperty):
              * page/animation/AnimationBase.cpp:
              (WebCore::ensurePropertyMap):
      
      LayoutTests:
      
      2009-07-23  David Hyatt  <hyatt@apple.com>
      
              Reviewed by Dan Bernstein.
              
              https://bugs.webkit.org/show_bug.cgi?id=27581
              Drop the prefix from the box-shadow property.
      
              * platform/mac/fast/css/getComputedStyle/computed-style-expected.txt:
              * platform/mac/fast/css/getComputedStyle/computed-style-without-renderer-expected.txt:
              * svg/css/getComputedStyle-basic-expected.txt:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@46274 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      2dde470b
    • treat@webkit.org's avatar
      WebCore: · bc00ddcf
      treat@webkit.org authored
      2009-07-22  Viet-Trung Luu  <viettrungluu@gmail.com>
      
              Reviewed by David Hyatt.
      
              https://bugs.webkit.org/show_bug.cgi?id=27289
              When a mouse click occurs on a scrollbar without a preceding mouse move
              onto it, the release isn't handled correctly (since
              EventHandler::m_lastScrollbarUnderMouse isn't set on mouse down, but
              only on mouse move). (Side comment: That scrollbar-handling code
              in EventHandler is ugly. It should be fixed properly.)
      
              Tests: scrollbars/scrollbar-miss-mousemove.html
                     scrollbars/scrollbar-miss-mousemove-disabled.html
      
              * page/EventHandler.cpp:
              (WebCore::EventHandler::handleMousePressEvent):
              (WebCore::EventHandler::handleMouseMoveEvent):
              (WebCore::EventHandler::updateLastScrollbarUnderMouse):
              * page/EventHandler.h:
      
      LayoutTests:
      2009-07-22  Viet-Trung Luu  <viettrungluu@gmail.com>
      
              Reviewed by David Hyatt.
      
              https://bugs.webkit.org/show_bug.cgi?id=27289
              Tests that mouse clicks/releases are handled properly on scrollbars
              even when there is no mouse move onto the scrollbar (two cases: enabled
              and disabled controls).
      
              * scrollbars/scrollbar-miss-mousemove-disabled-expected.txt: Added.
              * scrollbars/scrollbar-miss-mousemove-disabled.html: Added.
              * scrollbars/scrollbar-miss-mousemove-expected.txt: Added.
              * scrollbars/scrollbar-miss-mousemove.html: Added.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@46273 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      bc00ddcf
    • levin@chromium.org's avatar
      2009-07-23 Mike Fenton <mike.fenton@torchmobile.com> · 86403917
      levin@chromium.org authored
              Reviewed by David Levin.
      
              Update WebCore/page/BarInfo.cpp to conform to WebKit
              Style Guidelines as identified by cpplint.py.
              https://bugs.webkit.org/show_bug.cgi?id=27606
      
              * page/BarInfo.cpp:
              (WebCore::BarInfo::visible):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@46272 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      86403917
    • levin@chromium.org's avatar
      2009-07-23 Mike Fenton <mike.fenton@torchmobile.com> · 4e1469c8
      levin@chromium.org authored
              Reviewed by David Levin.
      
              Update WebCore/page/Console.cpp to conform to WebKit
              Style Guidelines as identified by cpplint.py.
              https://bugs.webkit.org/show_bug.cgi?id=27606
      
              * page/Console.cpp:
              (WebCore::printMessageSourceAndLevelPrefix):
              (WebCore::Console::profile):
              (WebCore::Console::time):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@46271 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      4e1469c8
    • treat@webkit.org's avatar
      2009-07-23 Eli Fidler <eli.fidler@torchmobile.com> · 1c86c8eb
      treat@webkit.org authored
               Reviewed by Adam Treat.
      
               Improve git workflow by populating commit messages with ChangeLog entries.
               https://bugs.webkit.org/show_bug.cgi?id=27605
      
               add --[no-]write option to optionally output new ChangeLog entries to
               stdout instead of modifying ChangeLog files
      
               fix Torch Mobile copyright
      
               * Scripts/prepare-ChangeLog:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@46270 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      1c86c8eb
    • treat@webkit.org's avatar
      2009-07-23 Jakob Petsovits <jakob.petsovits@torchmobile.com> · ecf71dc5
      treat@webkit.org authored
              Reviewed by Adam Treat.
      
              Enable cpplint for .c files.
              https://bugs.webkit.org/show_bug.cgi?id=27604
      
              Also make sure that the check for NULL does not apply to .c files.
      
              * Scripts/modules/cpplint.py:
              * Scripts/modules/cpplint_unittest.py:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@46269 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      ecf71dc5
    • treat@webkit.org's avatar
      2009-07-22 Yong Li <yong.li@torchmobile.com> · 383a10b5
      treat@webkit.org authored
              Reviewed by George Staikos.
      
              Add wince specific memory files into wtf/wince
              https://bugs.webkit.org/show_bug.cgi?id=27550
      
              * wtf/wince/FastMallocWince.h: Added.
              * wtf/wince/MemoryManager.cpp: Added.
              * wtf/wince/MemoryManager.h: Added.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@46268 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      383a10b5
    • hausmann@webkit.org's avatar
      2009-07-23 Laszlo Gombos <laszlo.1.gombos@nokia.com> · 98d09359
      hausmann@webkit.org authored
              Reviewed by Simon Hausmann.
      
              [Qt] Add simple proxy support for QtLauncher
              https://bugs.webkit.org/show_bug.cgi?id=27495
      
              Picks up proxy settings from the http_proxy environment
              variable.
      
              * QtLauncher/QtLauncher.pro: Add QtNetwork dependency for all
              platforms.
              * QtLauncher/main.cpp:
              (MainWindow::MainWindow):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@46267 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      98d09359
    • hausmann@webkit.org's avatar
      2009-07-23 Norbert Leser <norbert.leser@nokia.com> · 2411cb22
      hausmann@webkit.org authored
              Reviewed by Simon Hausmann.
      
              Fix for missing mmap features in Symbian
              https://bugs.webkit.org/show_bug.cgi?id=24540
      
              Fix, conditionally for PLATFORM(SYMBIAN), as an alternative
              to missing support for the MAP_ANON property flag in mmap.
              It utilizes Symbian specific memory allocation features.
      
              * runtime/Collector.cpp
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@46266 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      2411cb22
    • hausmann@webkit.org's avatar
      WebCore: · a20dc7d6
      hausmann@webkit.org authored
      2009-07-23  Simon Hausmann  <simon.hausmann@nokia.com>
      
              Reviewed by Holger Freyther.
      
              Fix crashes with the QObject bindings after garbage collection.
      
              There is one QtInstance per wrapped QObject, and that QtInstance keeps
              references to cached JSObjects for slots. When those objects get
              deleted due to GC, then they becoming dangling pointers.
      
              When a cached member dies, it is now removed from the QtInstance's
              cache.
      
              As we cannot track the lifetime of the children, we have to remove
              them from QtInstance alltogether. They are not cached and were
              only used for mark(), but we _want_ them to be subject to gc.
      
              * bridge/qt/qt_instance.cpp:
              (JSC::Bindings::QtInstance::~QtInstance): Minor coding style cleanup,
              use qDeleteAll().
              (JSC::Bindings::QtInstance::removeCachedMethod): New function, to
              clean m_methods and m_defaultMethod.
              (JSC::Bindings::QtInstance::mark): Avoid marking already marked objects.
              (JSC::Bindings::QtField::valueFromInstance): Don't save children for
              marking.
              * bridge/qt/qt_instance.h: Declare removeCachedMethod.
              * bridge/qt/qt_runtime.cpp:
              (JSC::Bindings::QtRuntimeMethod::~QtRuntimeMethod): Call removeCachedMethod
              with this on the instance.
      
      WebKit/qt:
      
      2009-07-23  Simon Hausmann  <simon.hausmann@nokia.com>
      
              Reviewed by Holger Freyther.
      
              Added a testcase to verify that cached methods in the QOBject bindings
              remain alife even after garbage collection.
      
              * tests/qwebpage/tst_qwebpage.cpp:
              (tst_QWebPage::protectBindingsRuntimeObjectsFromCollector):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@46265 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      a20dc7d6
    • hausmann@webkit.org's avatar
      2009-07-23 Zoltan Herczeg <zherczeg@inf.u-szeged.hu> · 2e363683
      hausmann@webkit.org authored
              Reviewed by Simon Hausmann.
      
              Fixing two issues related to QtLauncher
                - MainWindow objects are not always freed after close
                - JavaScript window.close() sometimes crashes
              https://bugs.webkit.org/show_bug.cgi?id=27601
      
              * QtLauncher/main.cpp:
              (MainWindow::MainWindow):
              (main):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@46264 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      2e363683
    • hausmann@webkit.org's avatar
      2009-07-23 Simon Hausmann <simon.hausmann@nokia.com> · be79664c
      hausmann@webkit.org authored
              Reviewed by Tor Arne Vestbø.
      
              Rebaseline the Qt results for computed-style.html and
              computed-style-without-rendered.html after r46240, similar to r46252.
      
              * platform/qt/fast/css/getComputedStyle/computed-style-expected.txt:
              * platform/qt/fast/css/getComputedStyle/computed-style-without-renderer-expected.txt:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@46263 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      be79664c
    • levin@chromium.org's avatar
      2009-07-23 David Levin <levin@chromium.org> · edf7a747
      levin@chromium.org authored
               Rubber-stamped by Oliver Hunt.
      
              Improve keyboard navigation of Select elements.
              Home/End and PageUp/PageDn buttons do not do anything in drop down lists,
              on non-Mac platforms.
              https://bugs.webkit.org/show_bug.cgi?id=22784
      
              One more round of speculative fixes:
               - Really fix the general and win expected results.  (They were missing a return.)
               - Disable the test for gtk (and remove the attempted workaround for that platform).
      
              * fast/forms/select-popup-pagekeys-expected.txt:
              * fast/forms/select-popup-pagekeys.html:
              * platform/gtk/Skipped:
              * platform/win/fast/forms/select-popup-pagekeys-expected.txt:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@46262 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      edf7a747