- 03 Dec, 2009 9 commits
-
-
ossy@webkit.org authored
Prevent DRT from showing the main view if these childs get deleted. This fixes https://bugs.webkit.org/show_bug.cgi?id=31591. Patch by Andras Becsi <abecsi@inf.u-szeged.hu> on 2009-12-03 Reviewed by Kenneth Rohde Christiansen. * DumpRenderTree/qt/DumpRenderTree.cpp: (WebCore::WebPage::WebPage): (WebCore::DumpRenderTree::DumpRenderTree): (WebCore::DumpRenderTree::~DumpRenderTree): (WebCore::DumpRenderTree::resetToConsistentStateBeforeTesting): (WebCore::DumpRenderTree::open): (WebCore::DumpRenderTree::closeRemainingWindows): (WebCore::DumpRenderTree::createWindow): (WebCore::DumpRenderTree::windowCount): * DumpRenderTree/qt/DumpRenderTree.h: LayoutTests: [Qt] Re-enable previously skipped tests. https://bugs.webkit.org/show_bug.cgi?id=31591 Patch by Andras Becsi <abecsi@inf.u-szeged.hu> on 2009-12-03 Reviewed by Kenneth Rohde Christiansen. * platform/qt/Skipped: git-svn-id: http://svn.webkit.org/repository/webkit/trunk@51634 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
jeremy@chromium.org authored
Switch Chrome/Mac to use Core Text APIs rather than ATSUI APIs. https://bugs.webkit.org/show_bug.cgi?id=31802 No test since this is already covered by existing pixel tests. * platform/graphics/SimpleFontData.h: Change #ifdef to define getNSFont() on Chrome/Mac . * platform/graphics/mac/ComplexTextControllerCoreText.cpp: Provide forward declarations of Core Text functions that are public on 10.6 but SPI on 10.5. git-svn-id: http://svn.webkit.org/repository/webkit/trunk@51633 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
ossy@webkit.org authored
* platform/qt/Skipped: - inspector/settings-set-get.html added. git-svn-id: http://svn.webkit.org/repository/webkit/trunk@51632 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
pfeldman@chromium.org authored
Reviewed by Timothy Hatcher. Web Inspector: Simplify the settings support in inspector controller. https://bugs.webkit.org/show_bug.cgi?id=32076 Test: inspector/settings-set-get.html * WebCore.Inspector.exp: * bindings/js/JSInspectorFrontendHostCustom.cpp: * bindings/v8/custom/V8InspectorFrontendHostCustom.cpp: * inspector/InspectorClient.h: * inspector/InspectorController.cpp: (WebCore::InspectorController::~InspectorController): (WebCore::InspectorController::setting): (WebCore::InspectorController::setSetting): (WebCore::InspectorController::setWindowVisible): (WebCore::InspectorController::attachWindow): (WebCore::InspectorController::setAttachedWindowHeight): (WebCore::InspectorController::storeLastActivePanel): (WebCore::InspectorController::scriptObjectReady): (WebCore::InspectorController::showWindow): (WebCore::InspectorController::enableResourceTracking): (WebCore::InspectorController::disableResourceTracking): (WebCore::InspectorController::ensureResourceTrackingSettingsLoaded): (WebCore::InspectorController::enableProfiler): (WebCore::InspectorController::disableProfiler): (WebCore::InspectorController::enableDebuggerFromFrontend): (WebCore::InspectorController::disableDebugger): * inspector/InspectorController.h: * inspector/InspectorFrontendHost.cpp: (WebCore::InspectorFrontendHost::setting): (WebCore::InspectorFrontendHost::setSetting): * inspector/InspectorFrontendHost.h: * inspector/InspectorFrontendHost.idl: * loader/EmptyClients.h: (WebCore::EmptyInspectorClient::populateSetting): (WebCore::EmptyInspectorClient::storeSetting): WebKit/chromium * src/InspectorClientImpl.cpp: (WebKit::InspectorClientImpl::hiddenPanels): (WebKit::InspectorClientImpl::populateSetting): (WebKit::InspectorClientImpl::storeSetting): (WebKit::InspectorClientImpl::loadSettings): (WebKit::InspectorClientImpl::saveSettings): * src/InspectorClientImpl.h: WebKit/cf * WebCoreSupport/WebInspectorClientCF.cpp: (WebInspectorClient::populateSetting): (WebInspectorClient::storeSetting): WebKit/gtk * WebCoreSupport/InspectorClientGtk.cpp: (WebKit::InspectorClient::populateSetting): (WebKit::InspectorClient::storeSetting): * WebCoreSupport/InspectorClientGtk.h: WebKit/haiku * WebCoreSupport/InspectorClientHaiku.cpp: (WebCore::InspectorClientHaiku::populateSetting): (WebCore::InspectorClientHaiku::storeSetting): * WebCoreSupport/InspectorClientHaiku.h: WebKit/mac * WebCoreSupport/WebInspectorClient.h: * WebCoreSupport/WebInspectorClient.mm: (-[WebInspectorWindowController showWindow:]): (-[WebInspectorWindowController attach]): (-[WebInspectorWindowController detach]): WebKit/qt * WebCoreSupport/InspectorClientQt.cpp: (WebCore::InspectorClientQt::populateSetting): (WebCore::InspectorClientQt::storeSetting): (WebCore::variantToSetting): (WebCore::settingToVariant): * WebCoreSupport/InspectorClientQt.h: WebKit/win * WebCoreSupport/WebInspectorClient.cpp: (WebInspectorClient::attachWindow): (WebInspectorClient::detachWindow): (WebInspectorClient::showWindowWithoutNotifications): * WebCoreSupport/WebInspectorClient.h: WebKit/wx * WebKitSupport/InspectorClientWx.cpp: (WebCore::InspectorClientWx::populateSetting): (WebCore::InspectorClientWx::storeSetting): * WebKitSupport/InspectorClientWx.h: git-svn-id: http://svn.webkit.org/repository/webkit/trunk@51631 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
benm@google.com authored
https://bugs.webkit.org/show_bug.cgi?id=31915 Reviewed by Brady Eidson. WebCore: No change in functionality so no new tests required. * history/HistoryItem.cpp: (WebCore::defaultNotifyHistoryItemChanged): Update this function to pass the HistoryItem that is being changed. (WebCore::HistoryItem::setAlternateTitle): Update call to notifyHistoryItemChanged to include the new parameter. (WebCore::HistoryItem::setURLString): ditto. (WebCore::HistoryItem::setOriginalURLString): ditto. (WebCore::HistoryItem::setReferrer): ditto. (WebCore::HistoryItem::setTitle): ditto. (WebCore::HistoryItem::setTarget): ditto. (WebCore::HistoryItem::setDocumentState): On Android, add a call to notifyHistoryItemChanged. See bug for a discussion of why this is needed. (WebCore::HistoryItem::clearDocumentState): ditto. (WebCore::HistoryItem::setIsTargetItem): ditto. (WebCore::HistoryItem::addChildItem): ditto. (WebCore::HistoryItem::setFormInfoFromRequest): ditto. * history/HistoryItem.h: Update signature of notifyHistoryItemChanged. WebKit/mac: * History/WebHistoryItem.mm: (WKNotifyHistoryItemChanged): Update WKNotifyHistoryItemChanged() to add the new HistoryItem parameter added in the WebCore portion of this patch. * History/WebHistoryItemInternal.h: ditto. git-svn-id: http://svn.webkit.org/repository/webkit/trunk@51630 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
benm@google.com authored
https://bugs.webkit.org/show_bug.cgi?id=31914 Reviewed by Brady Eidson. WebCore: This change adds three new methods on the FrameLoaderClient interface to receive notifications when the BackForwardList changes. No new tests required. Functionality on all platforms upstream remains the same. Android is the first platform to make use of these callbacks. * history/BackForwardList.cpp: (WebCore::BackForwardList::addItem): Execute the callback. (WebCore::BackForwardList::goBack): ditto. (WebCore::BackForwardList::goForward): ditto. (WebCore::BackForwardList::goToItem): ditto. (WebCore::BackForwardList::setCapacity): dito. * loader/EmptyClients.h: (WebCore::EmptyFrameLoaderClient::dispatchDidAddBackForwardItem): Add an empty implementation for the callback that does nothing. (WebCore::EmptyFrameLoaderClient::dispatchDidRemoveBackForwardItem): ditto. (WebCore::EmptyFrameLoaderClient::dispatchDidChangeBackForwardIndex): ditto. * loader/FrameLoaderClient.h: WebKit/chromium: * src/FrameLoaderClientImpl.cpp: (WebKit::FrameLoaderClientImpl::dispatchDidAddBackForwardItem): Add an empty implementation. Method added to FrameLoaderClient by Android (see bug). (WebKit::FrameLoaderClientImpl::dispatchDidRemoveBackForwardItem): ditto. (WebKit::FrameLoaderClientImpl::dispatchDidChangeBackForwardIndex): dito. * src/FrameLoaderClientImpl.h: WebKit/gtk: * WebCoreSupport/FrameLoaderClientGtk.cpp: (WebKit::FrameLoaderClient::dispatchDidAddBackForwardItem): Add an empty implementation. Method added to FrameLoaderClient by Android (see bug). (WebKit::FrameLoaderClient::dispatchDidRemoveBackForwardItem): ditto. (WebKit::FrameLoaderClient::dispatchDidChangeBackForwardIndex): ditto. * WebCoreSupport/FrameLoaderClientGtk.h: WebKit/haiku: * WebCoreSupport/FrameLoaderClientHaiku.cpp: (WebCore::FrameLoaderClientHaiku::dispatchDidAddBackForwardItem): Add an empty implementation. Method added to FrameLoaderClient by Android (see bug). (WebCore::FrameLoaderClientHaiku::dispatchDidRemoveBackForwardItem): ditto. (WebCore::FrameLoaderClientHaiku::dispatchDidChangeBackForwardIndex): ditto. * WebCoreSupport/FrameLoaderClientHaiku.h: WebKit/mac: * WebCoreSupport/WebFrameLoaderClient.h: * WebCoreSupport/WebFrameLoaderClient.mm: (WebFrameLoaderClient::dispatchDidAddBackForwardItem): Add an empty implementation. Method added to FrameLoaderClient by Android (see bug). (WebFrameLoaderClient::dispatchDidRemoveBackForwardItem): ditto. (WebFrameLoaderClient::dispatchDidChangeBackForwardIndex): ditto. WebKit/qt: * WebCoreSupport/FrameLoaderClientQt.cpp: (WebCore::FrameLoaderClientQt::dispatchDidAddBackForwardItem): Add an empty implementation. Method added to FrameLoaderClient by Android (see bug). (WebCore::FrameLoaderClientQt::dispatchDidRemoveBackForwardItem): ditto. (WebCore::FrameLoaderClientQt::dispatchDidChangeBackForwardIndex): ditto. * WebCoreSupport/FrameLoaderClientQt.h: WebKit/win: * WebCoreSupport/WebFrameLoaderClient.cpp: (WebFrameLoaderClient::dispatchDidAddBackForwardItem): Add an empty implementation. Method added to FrameLoaderClient by Android (see bug). (WebFrameLoaderClient::dispatchDidRemoveBackForwardItem): ditto. (WebFrameLoaderClient::dispatchDidChangeBackForwardIndex): ditto. * WebCoreSupport/WebFrameLoaderClient.h: WebKit/wx: * WebKitSupport/FrameLoaderClientWx.cpp: (WebCore::FrameLoaderClientWx::dispatchDidAddBackForwardItem): Add an empty implementation. Method added to FrameLoaderClient by Android (see bug). (WebCore::FrameLoaderClientWx::dispatchDidRemoveBackForwardItem): ditto. (WebCore::FrameLoaderClientWx::dispatchDidChangeBackForwardIndex): ditto. * WebKitSupport/FrameLoaderClientWx.h: git-svn-id: http://svn.webkit.org/repository/webkit/trunk@51629 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
benm@google.com authored
[Android] Upstream WebCore/history/android: Require some platform specific state attached to HistoryItem. https://bugs.webkit.org/show_bug.cgi?id=31913 Reviewed by Brady Eidson. Android stores information such as the zoom scale factor and bridge back to the Java counterpart with HistoryItem. No new tests required as this is Android specific code. * history/HistoryItem.h: Add Android specific member data to HistoryItem. * history/android: Added. * history/android/AndroidWebHistoryBridge.h: Added. * history/android/HistoryItemAndroid.cpp: Added, provides implementation for Android specific member functions in HistoryItem. (WebCore::HistoryItem::bridge): Added. (WebCore::HistoryItem::setBridge): Added. git-svn-id: http://svn.webkit.org/repository/webkit/trunk@51628 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
oliver@apple.com authored
https://bugs.webkit.org/show_bug.cgi?id=30313 Reviewed by Maciej Stachowiak. Add exception checks to SVGPathSegList's implementation to catch (and propagate) exceptions. Add null checks to SVGList's content manipulation functions to prevent null values from entering the list in the first place. Test: svg/dom/svgpath-out-of-bounds-getPathSeg.html git-svn-id: http://svn.webkit.org/repository/webkit/trunk@51627 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
eric@webkit.org authored
Reviewed by Darin Adler. Rewrite two tests with dumpAsText https://bugs.webkit.org/show_bug.cgi?id=32014 * fast/block/positioning/complex-percentage-height-expected.txt: Added. * fast/block/positioning/complex-percentage-height.html: * fast/lists/item-not-in-list-line-wrapping-expected.txt: Added. * fast/lists/item-not-in-list-line-wrapping.html: * platform/mac/fast/block/positioning/complex-percentage-height-expected.checksum: Removed. * platform/mac/fast/block/positioning/complex-percentage-height-expected.png: Removed. * platform/mac/fast/block/positioning/complex-percentage-height-expected.txt: Removed. * platform/mac/fast/lists/item-not-in-list-line-wrapping-expected.checksum: Removed. * platform/mac/fast/lists/item-not-in-list-line-wrapping-expected.png: Removed. * platform/mac/fast/lists/item-not-in-list-line-wrapping-expected.txt: Removed. * platform/qt/Skipped: * platform/qt/fast/block/positioning/complex-percentage-height-expected.txt: Removed. * platform/qt/fast/lists/item-not-in-list-line-wrapping-expected.txt: Removed. git-svn-id: http://svn.webkit.org/repository/webkit/trunk@51626 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
- 02 Dec, 2009 31 commits
-
-
oliver@apple.com authored
Reviewed by Gavin Barraclough. git-svn-id: http://svn.webkit.org/repository/webkit/trunk@51625 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
oliver@apple.com authored
https://bugs.webkit.org/show_bug.cgi?id=32103 Reviewed by Gavin Barraclough. Add a compile time flag to make the JSC collector replace "unreachable" objects with zombie objects. The zombie object is a JSCell subclass that ASSERTs on any attempt to use the JSCell methods. In addition there are a number of additional assertions in bottleneck code to catch zombie usage as quickly as possible. Grrr. Argh. Brains. git-svn-id: http://svn.webkit.org/repository/webkit/trunk@51624 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
eric@webkit.org authored
Reviewed by Eric Seidel. Sanitize web fonts using the OTS library https://bugs.webkit.org/show_bug.cgi?id=31106 Add support for OpenType sanitizer (OTS). It parses OpenType files (from @font-face) and attempts to validate and sanitize them. We hope this reduces the attack surface of the system font libraries. * WebCore.gyp/WebCore.gyp: Added dependency to (chromium_src_dir)/third_party/ots/ library. * WebCore.gypi: Added new files below. * WebCore.xcodeproj/project.pbxproj: Ditto. * platform/graphics/chromium/FontCustomPlatformData.cpp: Validate and transcode a web font. (WebCore::createFontCustomPlatformData): * platform/graphics/mac/FontCustomPlatformData.cpp: Ditto. (WebCore::createFontCustomPlatformData): * platform/graphics/opentype/OpenTypeSanitizer.cpp: Added. (WebCore::OpenTypeSanitizer::sanitize): * platform/graphics/opentype/OpenTypeSanitizer.h: Added. (WebCore::OpenTypeSanitizer::OpenTypeSanitizer): 2009-12-02 Yusuke Sato <yusukes@chromium.org> Reviewed by Eric Seidel. Sanitize web fonts using the OTS library https://bugs.webkit.org/show_bug.cgi?id=31106 * DEPS: Added dependency to the OpenType sanitizer library. * features.gypi: Added ENABLE_OPENTYPE_SANITIZER=1. git-svn-id: http://svn.webkit.org/repository/webkit/trunk@51623 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
eric@webkit.org authored
Reviewed by Adam Barth. REGRESSION(51595): commit-queue is throwing exceptions https://bugs.webkit.org/show_bug.cgi?id=32083 * Scripts/modules/commands/queues.py: - Don't use default value of [] as it ends up getting shared. - Make log_progress accept arrays of ints as well as strings. - Return an exit code from execute() * Scripts/modules/commands/queues_unittest.py: Added. - Test to make sure log_progress will accept ints. - Test to make sure run_bugzilla_tool will accept ints. * Scripts/modules/workqueue.py: - Print the stack trace on unexpected exceptions for easier debugging. * Scripts/run-webkit-unittests: - Add queues_unittest. * Scripts/modules/commands/queues.py: * Scripts/modules/commands/queues_unittest.py: Copied from WebKitTools/Scripts/modules/commands/commandtest.py. * Scripts/modules/mock_bugzillatool.py: * Scripts/modules/workqueue.py: * Scripts/run-webkit-unittests: git-svn-id: http://svn.webkit.org/repository/webkit/trunk@51622 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
oliver@apple.com authored
https://bugs.webkit.org/show_bug.cgi?id=32098 Reviewed by Sam Weinig. Fix is simply to make the ScriptFunctionCall stack allocated as nature intended Doing this required adding an appendArgument(char*) to ScriptFunctionCall so that an explicit String cast would not be necessary. To prevent something like this happening again in future i've added private operator new implementations to ScriptFunctionCall making this type of mistake produce errors when compiling. Test case: Inspector tests now pass with GC on every alloc enabled. git-svn-id: http://svn.webkit.org/repository/webkit/trunk@51621 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
mitz@apple.com authored
Reviewed by Mark Rowe. * WebView/WebView.mm: (+[WebView _viewClass:andRepresentationClass:forMIMEType:allowingPlugins:]): Make sure to include the image types’ view and representation classes even when plug-ins are not allowed. git-svn-id: http://svn.webkit.org/repository/webkit/trunk@51620 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
eric@webkit.org authored
Reviewed by Adam Barth. check-webkit-style is too noisy about namespace indenting issues. https://bugs.webkit.org/show_bug.cgi?id=32096 * Scripts/modules/cpp_style.py: Added a _FileState object to be able to track file level information. In this case, it simply tracks whether the error has already been given, so that it isn't done again. * Scripts/modules/cpp_style_unittest.py: Modified test cases to pass in the _FileState object and fix a test that expected to see the namespace error twice (now it only occurs once). No new tests because existing tests cover the change in functionality. git-svn-id: http://svn.webkit.org/repository/webkit/trunk@51619 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
kevino@webkit.org authored
[wx] Get DumpRenderTree building after waf switch. https://bugs.webkit.org/show_bug.cgi?id=32041 git-svn-id: http://svn.webkit.org/repository/webkit/trunk@51618 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
rdar://problem/7254127mitz@apple.com authored
plug-ins are disabled Reviewed by Anders Carlsson. Ensure that the shared WebPluginDatabase is not instantiated if no WebViews are used that have plug-ins enabled. * DefaultDelegates/WebDefaultPolicyDelegate.m: (-[WebDefaultPolicyDelegate webView:decidePolicyForMIMEType:request:frame:decisionListener:]): Call -[WebView _canShowMIMEType:] on the WebView instead of calling the class method. * WebCoreSupport/WebFrameLoaderClient.mm: (WebFrameLoaderClient::canShowMIMEType): Ditto. (WebFrameLoaderClient::transitionToCommittedForNewPage): Call -[WebFrameView _viewClassForMIMEType:] on the WebView instead of calling the class method. (WebFrameLoaderClient::objectContentType): Ditto. * WebView/WebDataSource.mm: (+[WebDataSource _representationClassForMIMEType:allowingPlugins:]): Added the allowPlugins parameter, which is passed through to +[WebView _viewClass:andRepresentationClass:forMIMEType:allowingPlugins:]. (-[WebDataSource _makeRepresentation]): Pass an allowPlugins value based on the WebView’s preferences. * WebView/WebFrameView.mm: (-[WebFrameView _makeDocumentViewForDataSource:]): Call -[WebFrameView _viewClassForMIMEType:] instead of calling the class method. (+[WebFrameView _viewClassForMIMEType:allowingPlugins:]): Added the allowPlugins parameter, which is passed through to +[WebView _viewClass:andRepresentationClass:forMIMEType:allowingPlugins:]. (-[WebFrameView _viewClassForMIMEType:]): Added. Passes an allowPlugins value based on the WebView’s preferences. * WebView/WebFrameViewInternal.h: * WebView/WebView.mm: (+[WebView _viewClass:andRepresentationClass:forMIMEType:allowingPlugins:]): Added the allowPlugins parameter. If false, skip the instantiation of the shared WebPluginDatabase. (-[WebView _viewClass:andRepresentationClass:forMIMEType:]): Pass an allowPlugins value based on the WebView’s preferences. (+[WebView _canShowMIMEType:allowingPlugins:]): Passes allowPlugins to +_viewClass:andRepresentationClass:forMIMEType:allowingPlugins:. (+[WebView canShowMIMEType:]): Changed to pass YES to +_canShowMIMEType:allowingPlugins:. (-[WebView _canShowMIMEType:]): Added. Passes an allowPlugins value based on the WebView’s preferences. (-[WebView _pluginForMIMEType:]): Return nil if plug-ins are disabled. (-[WebView _pluginForExtension:]): Ditto. (-[WebView _isMIMETypeRegisteredAsPlugin:]): Return NO if plug-ins are disabled. * WebView/WebViewInternal.h: git-svn-id: http://svn.webkit.org/repository/webkit/trunk@51617 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
timothy@apple.com authored
<rdar://problem/7400263> Reviewed by John Sullivan. * WebView/WebDynamicScrollBarsView.mm: (-[WebDynamicScrollBarsView scrollWheel:]): Retain self incase the last reference is released when calling super. git-svn-id: http://svn.webkit.org/repository/webkit/trunk@51616 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
ap@apple.com authored
https://bugs.webkit.org/show_bug.cgi?id=32089 Test that WebSocket.readyState is set correctly * websocket/tests/script-tests/simple.js: (ws.onopen): (ws.onmessage): (ws.onclose): * websocket/tests/simple-expected.txt: Added readyState logging. git-svn-id: http://svn.webkit.org/repository/webkit/trunk@51615 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
eric@webkit.org authored
Reviewed by Darin Fisher. https://bugs.webkit.org/show_bug.cgi?id=32029 Mousewheel event delta has reversed sign on Linux Chrome. No new tests (layout tests don't cover event conversion code). Manual test: http://www.switchonthecode.com/tutorials/javascript-tutorial-the-scroll-wheel * src/gtk/WebInputEventFactory.cpp: (WebKit::WebInputEventFactory::mouseWheelEvent): git-svn-id: http://svn.webkit.org/repository/webkit/trunk@51614 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
jparent@chromium.org authored
translating 100px, starting at 0, so it should be at 50px at 500ms, not 600ms. Reviewed by Darin Adler. https://bugs.webkit.org/show_bug.cgi?id=31997 * transitions/change-values-during-transition.html: isEqual: Remove unnecessary code - tolerance always passed in and always default value. getXPosition: Extract into a function, since it is duplicated twice. check2: Still run second check if the first fails, just give more debugging output. start: Remove final setTimeout - nothing changes between the end of check2 and here, so this is just making the test take 100ms longer. git-svn-id: http://svn.webkit.org/repository/webkit/trunk@51613 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
bweinstein@apple.com authored
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@51612 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
bweinstein@apple.com authored
Skip http/tests/cache/subresource-failover-to-network.html because it is flaky on Windows, fixing it is being tracked by https://bugs.webkit.org/show_bug.cgi?id=32038. * platform/win/Skipped: git-svn-id: http://svn.webkit.org/repository/webkit/trunk@51611 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
ossy@webkit.org authored
* platform/qt/Skipped: - inspector/elements-panel-selection-on-refresh.html added. - inspector/timeline-event-dispatch.html added. git-svn-id: http://svn.webkit.org/repository/webkit/trunk@51610 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
timothy@apple.com authored
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@51609 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
https://bugs.webkit.org/show_bug.cgi?id=32072hyatt@apple.com authored
pass more CSS test suite stuff. Make the grammar stop enforcing the ordering of @namespace vs. @variables vs. @import. Just let the parser handle that instead. This simplifies the grammar and makes error handling deal with more cases correctly. Reviewed by Darin Adler. Added fast/css/namespaces/namespaces-invalid-at-rules.xml * css/CSSGrammar.y: * css/CSSParser.cpp: (WebCore::CSSParser::CSSParser): (WebCore::CSSParser::parseRule): (WebCore::CSSParser::createCharsetRule): (WebCore::CSSParser::createImportRule): (WebCore::CSSParser::createMediaRule): (WebCore::CSSParser::createKeyframesRule): (WebCore::CSSParser::createStyleRule): (WebCore::CSSParser::createFontFaceRule): (WebCore::CSSParser::addNamespace): (WebCore::CSSParser::createVariablesRule): * css/CSSParser.h: git-svn-id: http://svn.webkit.org/repository/webkit/trunk@51608 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
timothy@apple.com authored
so it is fine for binary compatibility. Directed by Steve Falkenburg. * Interfaces/DOMHTML.idl: git-svn-id: http://svn.webkit.org/repository/webkit/trunk@51607 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
timothy@apple.com authored
<rdar://problem/6760590> Would like a way to detect a login form AutoFill from JavaScript Reviewed by Dan Bernstein. * DOMHTMLClasses.cpp: (DOMHTMLInputElement::setValueForUser): * Interfaces/DOMHTML.idl: git-svn-id: http://svn.webkit.org/repository/webkit/trunk@51606 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
eric@webkit.org authored
Reviewed by Dan Bernstein. Safari/Chromium for Windows fails to load CJK WebFonts https://bugs.webkit.org/show_bug.cgi?id=31804 * platform/graphics/opentype/OpenTypeUtilities.cpp: (WebCore::renameAndActivateFont): Load a remote font even if the font has 2 or more faces. git-svn-id: http://svn.webkit.org/repository/webkit/trunk@51605 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
eric@webkit.org authored
Reviewed by Pavel Feldman. Adds a timeline test for EventDispatch records. https://bugs.webkit.org/show_bug.cgi?id=31376 * inspector/timeline-event-dispatch-expected.txt: Added. * inspector/timeline-event-dispatch.html: Added. git-svn-id: http://svn.webkit.org/repository/webkit/trunk@51604 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
eric@webkit.org authored
Reviewed by Darin Fisher. Chromium: Need tickmarks in scrollbar https://bugs.webkit.org/show_bug.cgi?id=32069 * WebCore.gyp/WebCore.gyp: * WebCore.gypi: * platform/chromium/ScrollbarThemeChromiumMac.h: Added. * platform/chromium/ScrollbarThemeChromiumMac.mm: Added. git-svn-id: http://svn.webkit.org/repository/webkit/trunk@51603 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
timothy@apple.com authored
This function will dispatch the change event so the page is notified when autofill happens. Also dispatch a change event when a select element is changed by autofill. <rdar://problem/6760590> Would like a way to detect a login form AutoFill from JavaScript Reviewed by Darin Adler. * WebCore.xcodeproj/project.pbxproj: Added the DOMHTMLInputElementPrivate.h header. * bindings/objc/DOMHTML.mm: (-[DOMHTMLSelectElement _activateItemAtIndex:]): Call setSelectedIndexByUser instead so a change event is fired. This method is called by Safari autofill. * dom/Document.cpp: (WebCore::Document::setFocusedNode): Use dispatchFormControlChangeEvent instead of dispatching the change event directly to be consistent. * html/HTMLFormControlElement.cpp: (WebCore::HTMLInputElement::setValueForUser): Added. Calls setValue with the sendChangeEvent (WebCore::HTMLInputElement::setValue): Added the optional sendChangeEvent argument. Mimics setChecked. * html/HTMLInputElement.h: * html/HTMLInputElement.idl: Added setValueForUser for non-JS languages. * html/InputElement.h: Added setValueForUser. WebKit/mac: Migrate DOMHTMLInputElementPrivate.h as a private header. Reviewed by Darin Adler. * MigrateHeaders.make: git-svn-id: http://svn.webkit.org/repository/webkit/trunk@51602 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
pfeldman@chromium.org authored
Reviewed by Timothy Hatcher. Web Inspector: DOM tree selection disappears upon page refresh. https://bugs.webkit.org/show_bug.cgi?id=31142 Test: inspector/elements-panel-selection-on-refresh.html * inspector/InjectedScriptHost.cpp: (WebCore::InjectedScriptHost::pushNodeByPathToFrontend): * inspector/InjectedScriptHost.h: * inspector/InjectedScriptHost.idl: * inspector/InspectorBackend.h: * inspector/InspectorController.cpp: (WebCore::InspectorController::close): (WebCore::InspectorController::releaseDOMAgent): (WebCore::InspectorController::resetScriptObjects): * inspector/InspectorDOMAgent.cpp: (WebCore::InspectorDOMAgent::~InspectorDOMAgent): (WebCore::InspectorDOMAgent::reset): (WebCore::InspectorDOMAgent::setDocument): (WebCore::InspectorDOMAgent::pushDocumentToFrontend): (WebCore::InspectorDOMAgent::nodeForPath): (WebCore::InspectorDOMAgent::pushNodePathToFrontend): * inspector/InspectorDOMAgent.h: * inspector/front-end/DOMAgent.js: (WebInspector.DOMNode.prototype._renumber): (WebInspector.DOMAgent.prototype._setDocument): * inspector/front-end/ElementsPanel.js: (WebInspector.ElementsPanel.prototype.reset): (WebInspector.ElementsPanel.prototype.setDocument.selectDefaultNode): (WebInspector.ElementsPanel.prototype.setDocument.selectLastSelectedNode): (WebInspector.ElementsPanel.prototype.setDocument): * inspector/front-end/InjectedScript.js: (InjectedScript.pushNodeByPathToFrontend): * inspector/front-end/InjectedScriptAccess.js: git-svn-id: http://svn.webkit.org/repository/webkit/trunk@51601 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
https://bugs.webkit.org/show_bug.cgi?id=32045hyatt@apple.com authored
all the @-rules we support. When escape sequences are present, the lexical scanner just returns a generic token name: ATKEYWORD. We have to process the escape sequences and then recheck against the rules we support with the final processed name. If we find a match, we mutate the token value to the appropriate rule name token, e.g., NAMESPACE_SYM. Reviewed by Dan Bernstein. Added fast/css/namespaces/namespaces-escapes.xml * css/CSSParser.cpp: (WebCore::CSSParser::lex): (WebCore::CSSParser::recheckAtKeyword): (WebCore::CSSParser::text): * css/CSSParser.h: git-svn-id: http://svn.webkit.org/repository/webkit/trunk@51600 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
eric@webkit.org authored
Reviewed by Adam Barth.:w Allow to skip thread checks when accessing DOMDataStore for processes which run V8 in single thread mode. https://bugs.webkit.org/show_bug.cgi?id=31877 Should be covered by buildbots. * bindings/v8/V8DOMMap.cpp: (WebCore::getDOMDataStore): (WebCore::enableFasterDOMStoreAccess): (WebCore::getDOMNodeMap): (WebCore::getDOMObjectMap): (WebCore::getActiveDOMObjectMap): (WebCore::getDOMSVGElementInstanceMap): (WebCore::getDOMSVGObjectWithContextMap): * bindings/v8/V8DOMMap.h: 2009-12-02 Anton Muhin <antonm@chromium.org> Reviewed by Adam Barth. Allow to skip thread checks when accessing DOMDataStore for processes which run V8 in single thread mode. https://bugs.webkit.org/show_bug.cgi?id=31877 * src/WebScriptController.cpp: (WebKit::WebScriptController::enableV8SingleThreadMode): git-svn-id: http://svn.webkit.org/repository/webkit/trunk@51599 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
yurys@chromium.org authored
Reviewed by Pavel Feldman. Code clean up: remove ScriptObjectQuarantine.* as a whole. https://bugs.webkit.org/show_bug.cgi?id=32060 * GNUmakefile.am: * WebCore.gypi: * WebCore.pro: * WebCore.vcproj/WebCore.vcproj: * WebCore.xcodeproj/project.pbxproj: * WebCoreSources.bkl: * bindings/js/JSBindingsAllInOne.cpp: * bindings/js/ScriptObjectQuarantine.cpp: Removed. * bindings/js/ScriptObjectQuarantine.h: Removed. * bindings/js/ScriptValue.cpp: (WebCore::ScriptValue::quarantineValue): * bindings/js/ScriptValue.h: * bindings/v8/ScriptObjectQuarantine.cpp: Removed. * bindings/v8/ScriptObjectQuarantine.h: Removed. * bindings/v8/ScriptValue.h: (WebCore::ScriptValue::quarantineValue): * inspector/ConsoleMessage.cpp: (WebCore::ConsoleMessage::ConsoleMessage): * inspector/InspectorController.cpp: * inspector/InspectorDatabaseResource.cpp: (WebCore::InspectorDatabaseResource::bind): * inspector/InspectorFrontend.cpp: git-svn-id: http://svn.webkit.org/repository/webkit/trunk@51598 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
ossy@webkit.org authored
* platform/qt/Skipped: - fast/frames/sandboxed-iframe-navigation-windowopen.html added. (crasher) git-svn-id: http://svn.webkit.org/repository/webkit/trunk@51597 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
eric@webkit.org authored
Reviewed by Eric Seidel. [bzt] build-attachment shouldn't check whether the builders are red https://bugs.webkit.org/show_bug.cgi?id=32062 build-attachment doesn't touch the remote repository, so there isn't a need to hold off when the builders are red. * Scripts/modules/commands/download.py: * Scripts/modules/landingsequence.py: git-svn-id: http://svn.webkit.org/repository/webkit/trunk@51596 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
eric@webkit.org authored
Reviewed by Adam Barth. REGRESSION(51590): style-queue and build-queue think their empty when they are not https://bugs.webkit.org/show_bug.cgi?id=32061 * Scripts/modules/bugzilla.py: make all id lookups return ints instead of strings. * Scripts/modules/bugzilla_unittest.py: Add and update unit tests to use ints. git-svn-id: http://svn.webkit.org/repository/webkit/trunk@51595 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-