1. 22 Jan, 2011 22 commits
    • andersca@apple.com's avatar
      2011-01-22 Anders Carlsson <andersca@apple.com> · 4beeebf5
      andersca@apple.com authored
              Reviewed by Sam Weinig.
      
              Transparent windows with compositing WebKit2 content show garbage
              https://bugs.webkit.org/show_bug.cgi?id=52966
              <rdar://problem/8765051>
      
              * UIProcess/mac/LayerBackedDrawingAreaProxyMac.mm:
              (WebKit::LayerBackedDrawingAreaProxy::paint):
              If the WKView should draw transparent background, do so.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@76453 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      4beeebf5
    • andersca@apple.com's avatar
      2011-01-22 Anders Carlsson <andersca@apple.com> · f3248c7d
      andersca@apple.com authored
              Reviewed by Sam Weinig.
      
              Add an asynchronous WKPageForceRepaint
              https://bugs.webkit.org/show_bug.cgi?id=52964
              <rdar://problem/8898527>
      
              * UIProcess/API/C/WKPage.cpp:
              (WKPageForceRepaint):
              Call WebPageProxy::forceRepaint.
      
              * UIProcess/API/C/WKPage.h:
              Add WKPageForceRepaint.
      
              * UIProcess/GenericCallback.h:
              Add a "generic" VoidCallback class.
      
              * UIProcess/WebPageProxy.cpp:
              (WebKit::WebPageProxy::forceRepaint):
              Insert the callback in the m_voidCallbacks map and send a forceRepaint message.
      
              (WebKit::WebPageProxy::voidCallback):
              Call the right void callback.
      
              (WebKit::WebPageProxy::processDidCrash):
              Invalidate m_voidCallbacks.
      
              * UIProcess/WebPageProxy.messages.in:
              Add a VoidCallback message.
      
              * WebProcess/WebPage/ChunkedUpdateDrawingArea.cpp:
              (WebKit::ChunkedUpdateDrawingArea::forceRepaint):
              Force a repaint.
      
              * WebProcess/WebPage/ChunkedUpdateDrawingArea.h:
              Add forceRepaint.
      
              * WebProcess/WebPage/WebPage.cpp:
              (WebKit::WebPage::forceRepaint):
              Call forceRepaint on the drawing area.
      
              * WebProcess/WebPage/WebPage.messages.in:
              Add a ForceRepaint message.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@76452 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      f3248c7d
    • robert@webkit.org's avatar
      2011-01-22 Robert Hogan <robert@webkit.org> · 852ab546
      robert@webkit.org authored
              Reviewed by Andreas Kling.
      
              [Qt] Support layoutTestController.addURLToRedirect()
              https://bugs.webkit.org/show_bug.cgi?id=52956
      
              * platform/qt/Skipped:
      2011-01-22  Robert Hogan  <robert@webkit.org>
      
              Reviewed by Andreas Kling.
      
              [Qt] Support layoutTestController.addURLToRedirect()
              https://bugs.webkit.org/show_bug.cgi?id=52956
      
              * WebCoreSupport/DumpRenderTreeSupportQt.cpp:
              (DumpRenderTreeSupportQt::addURLToRedirect):
              * WebCoreSupport/DumpRenderTreeSupportQt.h:
              * WebCoreSupport/FrameLoaderClientQt.cpp:
              (WebCore::FrameLoaderClientQt::dispatchWillSendRequest):
              * WebCoreSupport/FrameLoaderClientQt.h:
      2011-01-22  Robert Hogan  <robert@webkit.org>
      
              Reviewed by Andreas Kling.
      
              [Qt] Support layoutTestController.addURLToRedirect()
              https://bugs.webkit.org/show_bug.cgi?id=52956
      
              * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
              (LayoutTestController::addURLToRedirect):
              * DumpRenderTree/qt/LayoutTestControllerQt.h:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@76451 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      852ab546
    • zimmermann@webkit.org's avatar
      2011-01-22 Nikolas Zimmermann <nzimmermann@rim.com> · 8ced7144
      zimmermann@webkit.org authored
              Not reviewed.
      
              REGRESSION: Vertical line metrics incorrect
              https://bugs.webkit.org/show_bug.cgi?id=52960
      
              Revert accidently landed mac baseline changes.
      
              * platform/mac/svg/W3C-SVG-1.1-SE/filters-image-03-f-expected.txt:
              * platform/mac/svg/W3C-SVG-1.1-SE/pservers-pattern-03-f-expected.txt:
              * platform/mac/svg/W3C-SVG-1.1/animate-elem-03-t-expected.txt:
              * platform/mac/svg/W3C-SVG-1.1/animate-elem-24-t-expected.txt:
              * platform/mac/svg/W3C-SVG-1.1/animate-elem-36-t-expected.txt:
              * platform/mac/svg/W3C-SVG-1.1/animate-elem-40-t-expected.txt:
              * platform/mac/svg/W3C-SVG-1.1/fonts-desc-02-t-expected.txt:
              * platform/mac/svg/W3C-SVG-1.1/fonts-elem-05-t-expected.txt:
              * platform/mac/svg/W3C-SVG-1.1/fonts-elem-06-t-expected.txt:
              * platform/mac/svg/W3C-SVG-1.1/masking-mask-01-b-expected.txt:
              * platform/mac/svg/W3C-SVG-1.1/render-groups-01-b-expected.txt:
              * platform/mac/svg/W3C-SVG-1.1/render-groups-03-t-expected.txt:
              * platform/mac/svg/W3C-SVG-1.1/text-text-04-t-expected.txt:
              * platform/mac/svg/batik/text/xmlSpace-expected.txt:
              * platform/mac/svg/custom/scrolling-embedded-svg-file-image-repaint-problem-expected.txt:
              * platform/mac/svg/custom/svg-fonts-in-html-expected.txt:
              * platform/mac/svg/custom/svg-fonts-with-no-element-reference-expected.txt:
              * platform/mac/svg/text/text-hkern-expected.txt:
              * platform/mac/svg/text/text-hkern-on-vertical-text-expected.txt:
              * platform/mac/svg/text/text-text-04-t-expected.txt:
              * platform/mac/svg/text/text-vkern-expected.txt:
              * platform/mac/svg/text/text-vkern-on-horizontal-text-expected.txt:
              * platform/mac/svg/transforms/text-with-mask-with-svg-transform-expected.txt:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@76450 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      8ced7144
    • zimmermann@webkit.org's avatar
      2011-01-22 Nikolas Zimmermann <nzimmermann@rim.com> · 9c4aceb1
      zimmermann@webkit.org authored
              Not reviewed.
      
              REGRESSION: Vertical line metrics incorrect
              https://bugs.webkit.org/show_bug.cgi?id=52960
      
              Rebaselined several text dumps from the bots, after the FontMetrics change.
              All show 1px diffs, but are progressions, since the lineSpacing calculation has been improved.
              Mac still has the old results - as it depends on a rounding trick at the moment.
      
              * platform/gtk/svg/W3C-SVG-1.1-SE/filters-image-03-f-expected.txt:
              * platform/gtk/svg/W3C-SVG-1.1-SE/pservers-pattern-03-f-expected.txt:
              * platform/gtk/svg/text/text-hkern-expected.txt:
              * platform/gtk/svg/text/text-hkern-on-vertical-text-expected.txt:
              * platform/gtk/svg/text/text-vkern-expected.txt:
              * platform/gtk/svg/text/text-vkern-on-horizontal-text-expected.txt:
              * platform/mac/svg/W3C-SVG-1.1-SE/filters-image-03-f-expected.txt:
              * platform/mac/svg/W3C-SVG-1.1-SE/pservers-pattern-03-f-expected.txt:
              * platform/mac/svg/W3C-SVG-1.1/animate-elem-03-t-expected.txt:
              * platform/mac/svg/W3C-SVG-1.1/animate-elem-24-t-expected.txt:
              * platform/mac/svg/W3C-SVG-1.1/animate-elem-36-t-expected.txt:
              * platform/mac/svg/W3C-SVG-1.1/animate-elem-40-t-expected.txt:
              * platform/mac/svg/W3C-SVG-1.1/fonts-desc-02-t-expected.txt:
              * platform/mac/svg/W3C-SVG-1.1/fonts-elem-05-t-expected.txt:
              * platform/mac/svg/W3C-SVG-1.1/fonts-elem-06-t-expected.txt:
              * platform/mac/svg/W3C-SVG-1.1/masking-mask-01-b-expected.txt:
              * platform/mac/svg/W3C-SVG-1.1/render-groups-01-b-expected.txt:
              * platform/mac/svg/W3C-SVG-1.1/render-groups-03-t-expected.txt:
              * platform/mac/svg/W3C-SVG-1.1/text-text-04-t-expected.txt:
              * platform/mac/svg/batik/text/xmlSpace-expected.txt:
              * platform/mac/svg/custom/scrolling-embedded-svg-file-image-repaint-problem-expected.txt:
              * platform/mac/svg/custom/svg-fonts-in-html-expected.txt:
              * platform/mac/svg/custom/svg-fonts-with-no-element-reference-expected.txt:
              * platform/mac/svg/text/text-hkern-expected.txt:
              * platform/mac/svg/text/text-hkern-on-vertical-text-expected.txt:
              * platform/mac/svg/text/text-text-04-t-expected.txt:
              * platform/mac/svg/text/text-vkern-expected.txt:
              * platform/mac/svg/text/text-vkern-on-horizontal-text-expected.txt:
              * platform/mac/svg/transforms/text-with-mask-with-svg-transform-expected.txt:
              * platform/qt/css2.1/t1507-c526-font-sz-02-b-a-expected.txt:
              * platform/qt/svg/W3C-SVG-1.1-SE/filters-image-03-f-expected.txt:
              * platform/qt/svg/W3C-SVG-1.1-SE/pservers-pattern-03-f-expected.txt:
              * platform/qt/svg/W3C-SVG-1.1/fonts-glyph-02-t-expected.txt:
              * platform/qt/svg/text/text-hkern-expected.txt:
              * platform/qt/svg/text/text-hkern-on-vertical-text-expected.txt:
              * platform/qt/svg/text/text-vkern-expected.txt:
              * platform/qt/svg/text/text-vkern-on-horizontal-text-expected.txt:
              * platform/qt/svg/transforms/text-with-mask-with-svg-transform-expected.txt:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@76449 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      9c4aceb1
    • andreip@google.com's avatar
      2011-01-22 Andrei Popescu <andreip@google.com> · d16c1587
      andreip@google.com authored
              Reviewed by Jeremy Orlow.
      
              IndexedDB corrupts data on disk
              https://bugs.webkit.org/show_bug.cgi?id=52890
      
              * storage/indexeddb/data-corruption-expected.txt: Added.
              * storage/indexeddb/data-corruption.html: Added.
      2011-01-22  Andrei Popescu  <andreip@google.com>
      
              Reviewed by Jeremy Orlow.
      
              IndexedDB corrupts data on disk
              https://bugs.webkit.org/show_bug.cgi?id=52890
      
              We need to store the SerializedScriptValues on disk in a BLOB column rather than TEXT.
              Test: storage/indexeddb/data-corruption.html
      
              * platform/sql/SQLiteStatement.cpp:
              (WebCore::SQLiteStatement::bindBlob):
              (WebCore::SQLiteStatement::getColumnBlobAsString):
              (WebCore::SQLiteStatement::getColumnBlobAsVector):
              * platform/sql/SQLiteStatement.h:
              * storage/IDBCursorBackendImpl.cpp:
              (WebCore::IDBCursorBackendImpl::loadCurrentRow):
              * storage/IDBFactoryBackendImpl.cpp:
              (WebCore::runCommands):
              (WebCore::createTables):
              (WebCore::createMetaDataTable):
              (WebCore::migrateDatabase):
              * storage/IDBObjectStoreBackendImpl.cpp:
              (WebCore::IDBObjectStoreBackendImpl::getInternal):
              (WebCore::putObjectStoreData):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@76448 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      d16c1587
    • zimmermann@webkit.org's avatar
      2011-01-22 Nikolas Zimmermann <nzimmermann@rim.com> · 7436a2ca
      zimmermann@webkit.org authored
              Not reviewed. Fix WinCE build.
      
              * platform/graphics/wince/GraphicsContextWinCE.cpp:
              (WebCore::GraphicsContext::drawText):
              * rendering/RenderThemeWinCE.cpp:
              (WebCore::RenderThemeWinCE::adjustMenuListButtonStyle):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@76447 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      7436a2ca
    • robert@webkit.org's avatar
      2011-01-22 Robert Hogan <robert@webkit.org> · d31455da
      robert@webkit.org authored
              Reviewed by Kenneth Rohde Christiansen.
      
              [Qt] REGRESSION (r72360): http/tests/security/aboutBlank/xss-DENIED-* tests fail
              https://bugs.webkit.org/show_bug.cgi?id=49802
      
              * platform/qt/Skipped:
              * platform/qt/http/tests/security/aboutBlank/xss-DENIED-navigate-opener-document-write-expected.txt: Added.
              * platform/qt/http/tests/security/aboutBlank/xss-DENIED-navigate-opener-javascript-url-expected.txt: Added.
              * platform/qt/http/tests/security/aboutBlank/xss-DENIED-set-opener-expected.txt: Added.
      2011-01-22  Robert Hogan  <robert@webkit.org>
      
              Reviewed by Kenneth Rohde Christiansen.
      
              [Qt] REGRESSION (r72360): http/tests/security/aboutBlank/xss-DENIED-* tests fail
              https://bugs.webkit.org/show_bug.cgi?id=49802
      
              * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
              (WebCore::DumpRenderTree::resetToConsistentStateBeforeTesting):
              (WebCore::DumpRenderTree::open):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@76446 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      d31455da
    • zimmermann@webkit.org's avatar
      2011-01-22 Nikolas Zimmermann <nzimmermann@rim.com> · d72d070d
      zimmermann@webkit.org authored
              Reviewed by Dirk Schulze.
      
              REGRESSION: Vertical line metrics incorrect
              https://bugs.webkit.org/show_bug.cgi?id=52960
      
              SimpleFontDataMac.mm contains a hack to modifiy lineGap/descent for the 'Hiragino' font.
              That didn't influence the lineSpacing so far, but does now, causing regressions.
      
              Restore old line spacing behaviour to fix the regression.
              Covered by existing fast/blockflow, fast/repaint and fast/text/international test cases.
      
              * platform/graphics/FontMetrics.h:
              (WebCore::FontMetrics::FontMetrics):
              (WebCore::FontMetrics::floatLineSpacing):
              (WebCore::FontMetrics::setLineSpacing):
              (WebCore::FontMetrics::lineSpacing):
              (WebCore::FontMetrics::reset):
              * platform/graphics/SimpleFontData.cpp:
              (WebCore::SimpleFontData::SimpleFontData):
              * platform/graphics/chromium/SimpleFontDataChromiumWin.cpp:
              (WebCore::SimpleFontData::platformInit):
              * platform/graphics/chromium/SimpleFontDataLinux.cpp:
              (WebCore::SimpleFontData::platformInit):
              * platform/graphics/freetype/SimpleFontDataFreeType.cpp:
              (WebCore::SimpleFontData::platformInit):
              * platform/graphics/haiku/SimpleFontDataHaiku.cpp:
              (WebCore::SimpleFontData::platformInit):
              * platform/graphics/mac/SimpleFontDataMac.mm:
              (WebCore::SimpleFontData::platformInit):
              * platform/graphics/pango/SimpleFontDataPango.cpp:
              (WebCore::SimpleFontData::platformInit):
              * platform/graphics/qt/SimpleFontDataQt.cpp:
              (WebCore::SimpleFontData::platformInit):
              * platform/graphics/win/SimpleFontDataCGWin.cpp:
              (WebCore::SimpleFontData::platformInit):
              * platform/graphics/win/SimpleFontDataCairoWin.cpp:
              (WebCore::SimpleFontData::platformInit):
              * platform/graphics/win/SimpleFontDataWin.cpp:
              (WebCore::SimpleFontData::initGDIFont):
              * platform/graphics/wince/SimpleFontDataWinCE.cpp:
              (WebCore::SimpleFontData::platformInit):
              * platform/graphics/wx/SimpleFontDataWx.cpp:
              (WebCore::SimpleFontData::platformInit):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@76445 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      d72d070d
    • andreas.kling@nokia.com's avatar
      2011-01-22 Andreas Kling <kling@webkit.org> · 3143b279
      andreas.kling@nokia.com authored
              Reviewed by Kenneth Rohde Christiansen.
      
              [Qt] fast/backgrounds/svg-as-mask.html fails
              https://bugs.webkit.org/show_bug.cgi?id=52906
      
              Transparency layers should start out with in SourceOver mode with
              alpha 1.0 (modeled after CGContextBeginTransparencyLayer.)
      
              * platform/graphics/qt/TransparencyLayer.h:
              (WebCore::TransparencyLayer::TransparencyLayer):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@76444 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      3143b279
    • zimmermann@webkit.org's avatar
      2011-01-22 Nikolas Zimmermann <nzimmermann@rim.com> · d0e7da80
      zimmermann@webkit.org authored
              Not reviewed.
      
              Introduce FontMetrics abstraction
              https://bugs.webkit.org/show_bug.cgi?id=51456
      
              Fix Chromium/Win build.
      
              * platform/graphics/chromium/UniscribeHelperTextRun.cpp: s/->/./
              (WebCore::UniscribeHelperTextRun::UniscribeHelperTextRun):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@76443 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      d0e7da80
    • zimmermann@webkit.org's avatar
      2011-01-21 Nikolas Zimmermann <nzimmermann@rim.com> · e8433cca
      zimmermann@webkit.org authored
              Reviewed by Dirk Schulze.
      
              Introduce FontMetrics abstraction
              https://bugs.webkit.org/show_bug.cgi?id=51456
      
              * src/ExternalPopupMenu.cpp: Use FontMetrics instead of Font to access the metrics.
              (WebKit::ExternalPopupMenu::getPopupMenuInfo):
              * src/WebFontImpl.cpp: Ditto.
              (WebKit::WebFontImpl::ascent):
              (WebKit::WebFontImpl::descent):
              (WebKit::WebFontImpl::height):
              (WebKit::WebFontImpl::lineSpacing):
              (WebKit::WebFontImpl::xHeight):
      2011-01-21  Nikolas Zimmermann  <nzimmermann@rim.com>
      
              Reviewed by Dirk Schulze.
      
              Introduce FontMetrics abstraction
              https://bugs.webkit.org/show_bug.cgi?id=51456
      
              * FullscreenVideoController.cpp: Use FontMetrics instead of Font to access the metrics.
              (FullscreenVideoController::draw):
              * WebCoreSupport/WebDragClient.cpp: Ditto.
              (WebDragClient::createDragImageForLink):
              * WebKitGraphics.cpp: Ditto.
              (FontMetrics):
      2011-01-21  Nikolas Zimmermann  <nzimmermann@rim.com>
      
              Reviewed by Dirk Schulze.
      
              Introduce FontMetrics abstraction
              https://bugs.webkit.org/show_bug.cgi?id=51456
      
              Encapsulate ascent/descent/lineHeight/lineGap methods in a single FontMetrics class, instead of
              having to define them in both Font & SimpleFontData. Changed to store floating point values
              as default, in order to get accurate information for small sized fonts. All these methods
              now have floating-point and integer versions. Whenever an integer variant of these functions
              is called, lroundf() is used to round the value.
      
              This makes it possible to support small font-sizes for SVG in a follow-up patch, as well
              as fixing rounding issues when using SVG Fonts.
              
              Shouldn't affect existing tests.
      
              * GNUmakefile.am: Add FontMetrics.h to build. 
              * WebCore.gypi: Ditto.
              * WebCore.pro: Ditto.
              * WebCore.vcproj/WebCore.vcproj: Ditto.
              * WebCore.xcodeproj/project.pbxproj: Ditto.
              * accessibility/gtk/AccessibilityObjectWrapperAtk.cpp: Use style->fontMetrics() instead of style->font() to access the metrics.
              (baselinePositionForAccessibilityRenderObject):
              * css/CSSPrimitiveValue.cpp:         
              (WebCore::CSSPrimitiveValue::computeLengthDouble):
              * html/canvas/CanvasRenderingContext2D.cpp: Ditto.
              (WebCore::CanvasRenderingContext2D::drawTextInternal):
              * inspector/InspectorController.cpp: Ditto.
              (WebCore::InspectorController::drawElementTitle):
              * platform/chromium/PopupMenuChromium.cpp: Ditto.
              (WebCore::PopupListBox::paintRow):
              (WebCore::PopupListBox::getRowHeight):
              * platform/graphics/Font.h: Remove ascent/descent/height/lineGap/lineSpacing/xHeight/unitsPerEm accessor...
              (WebCore::Font::fontMetrics): ... and only expose a single FontMetrics object here.
              * platform/graphics/FontFastPath.cpp: Use fontMetrics() to query metrics information.
              (WebCore::Font::emphasisMarkAscent):
              (WebCore::Font::emphasisMarkDescent):
              (WebCore::Font::emphasisMarkHeight):
              (WebCore::Font::floatWidthForSimpleText):
              * platform/graphics/FontMetrics.h: Added.
              (WebCore::FontMetrics::FontMetrics): Creates a FontMetrics object, stored in SimpleFontData.
              (WebCore::FontMetrics::unitsPerEm): Returns an unsigned describing the unitsPerEm.
              (WebCore::FontMetrics::setUnitsPerEm): Sets the unitsPerEm value.
              (WebCore::FontMetrics::floatAscent): Returns the stored m_ascent float.
              (WebCore::FontMetrics::setAscent): Sets the stored m_ascent float.
              (WebCore::FontMetrics::floatDescent): Returns the stored m_descent float.
              (WebCore::FontMetrics::setDescent): Sets the stored m_descent float.
              (WebCore::FontMetrics::floatHeight): Returns floatAscent() + floatDescent().
              (WebCore::FontMetrics::floatLineGap): Returns the stored m_lineGap float.
              (WebCore::FontMetrics::setLineGap): Sets the stored m_lineGap float.
              (WebCore::FontMetrics::floatLineSpacing): Returns the stored m_lineSpacing float.
              (WebCore::FontMetrics::setLineSpacing): Sets the stored m_lineSpacing float.
              (WebCore::FontMetrics::xHeight): Returns the stored m_xHeight float (no integer version available, hence no 'float' prefix).
              (WebCore::FontMetrics::setXHeight): Sets the stored m_xHeight float.
              (WebCore::FontMetrics::ascent): Returns a rounded version of ascent().
              (WebCore::FontMetrics::descent): Ditto (for descent).
              (WebCore::FontMetrics::height): Returns ascent() + descent().
              (WebCore::FontMetrics::lineGap): Returns a rounded version of lineGap().
              (WebCore::FontMetrics::lineSpacing): Ditto (for lineSpacing).
              (WebCore::FontMetrics::reset): Nulls all members, used only by the platform variants of SimpleFontData.
              * platform/graphics/SimpleFontData.cpp: Adapt SVG Fonts code, to initialize the FontMetrics object, as the m_ascent/etc.. members are gone.
              (WebCore::SimpleFontData::SimpleFontData):
              (WebCore::SimpleFontData::initCharWidths):
              * platform/graphics/SimpleFontData.h: Remove ascent/descent/height/lineSpacing/lineGap/xHeight/unitsPerEm accessors, and members, just store a FontMetrics object and expose it.
              (WebCore::SimpleFontData::fontMetrics):
              (WebCore::SimpleFontData::avgCharWidth):
              * platform/graphics/chromium/FontChromiumWin.cpp: Use fontMetrics() to query font metrics.
              (WebCore::TransparencyAwareFontPainter::TransparencyAwareGlyphPainter::estimateTextBounds):
              (WebCore::TransparencyAwareFontPainter::TransparencyAwareGlyphPainter::drawGlyphs):
              (WebCore::TransparencyAwareFontPainter::TransparencyAwareUniscribePainter::estimateTextBounds):
              (WebCore::Font::drawComplexText):
              * platform/graphics/chromium/SimpleFontDataChromiumWin.cpp: Adapt platform code, to initialize the FontMetrics object.
              (WebCore::SimpleFontData::platformInit):
              * platform/graphics/chromium/SimpleFontDataLinux.cpp: Ditto.
              (WebCore::SimpleFontData::platformInit):
              * platform/graphics/chromium/UniscribeHelperTextRun.cpp: Use fontMetrics() to query font metrics.
              (WebCore::UniscribeHelperTextRun::UniscribeHelperTextRun):
              (WebCore::UniscribeHelperTextRun::nextWinFontData):
              * platform/graphics/freetype/SimpleFontDataFreeType.cpp: Adapt platform code, to initialize the FontMetrics object.
              (WebCore::SimpleFontData::platformInit):
              * platform/graphics/haiku/SimpleFontDataHaiku.cpp: Ditto.
              (WebCore::SimpleFontData::platformInit):
              * platform/graphics/mac/FontComplexTextMac.cpp: Use fontMetrics() to query font metrics.
              (WebCore::Font::floatWidthForComplexText):
              * platform/graphics/mac/FontMac.mm: Ditto.
              (WebCore::showGlyphsWithAdvances):
              * platform/graphics/mac/SimpleFontDataMac.mm: Adapt platform code, to initialize the FontMetrics object.
              (WebCore::SimpleFontData::platformInit):
              (WebCore::SimpleFontData::platformCharWidthInit):
              * platform/graphics/pango/SimpleFontDataPango.cpp: Ditto.
              (WebCore::SimpleFontData::platformInit):
              * platform/graphics/qt/SimpleFontDataQt.cpp: Ditto. (+ Switch to QFontMetricsF to get floating-point accurancy.)
              (WebCore::SimpleFontData::platformInit):
              * platform/graphics/win/FontCGWin.cpp: Use fontMetrics() to query font metrics.
              (WebCore::drawGDIGlyphs):
              * platform/graphics/win/FontWin.cpp: Ditto.
              (WebCore::Font::floatWidthForComplexText):
              * platform/graphics/win/SimpleFontDataCGWin.cpp: Adapt platform code, to initialize the FontMetrics object.
              (WebCore::SimpleFontData::platformInit):
              (WebCore::SimpleFontData::platformBoundsForGlyph):
              * platform/graphics/win/SimpleFontDataCairoWin.cpp: Ditto.
              (WebCore::SimpleFontData::platformInit):
              * platform/graphics/win/SimpleFontDataWin.cpp: Ditto.
              (WebCore::SimpleFontData::initGDIFont):
              * platform/graphics/wince/GraphicsContextWinCE.cpp: Use fontMetrics() to query font metrics.
              (WebCore::GraphicsContext::drawText):
              * platform/graphics/wince/SimpleFontDataWinCE.cpp: Adapt platform code, to initialize the FontMetrics object.
              (WebCore::SimpleFontData::platformInit):
              * platform/graphics/wx/SimpleFontDataWx.cpp: Ditto.
              (WebCore::SimpleFontData::platformInit):
              * platform/win/PopupMenuWin.cpp: Use style->fontMetrics() instead of style->font() to access the metrics.
              (WebCore::PopupMenuWin::calculatePositionAndSize): 
              (WebCore::PopupMenuWin::paint):
              * rendering/EllipsisBox.cpp: Ditto.
              (WebCore::EllipsisBox::paint):
              (WebCore::EllipsisBox::nodeAtPoint):
              * rendering/InlineBox.cpp: Ditto.
              (WebCore::InlineBox::logicalHeight):
              * rendering/InlineFlowBox.cpp: Ditto.
              (WebCore::verticalPositionForBox):
              (WebCore::InlineFlowBox::computeLogicalBoxHeights):
              (WebCore::InlineFlowBox::placeBoxesInBlockDirection):
              * rendering/InlineTextBox.cpp: Ditto.
              (WebCore::InlineTextBox::paint):
              (WebCore::InlineTextBox::paintDecoration):
              (WebCore::InlineTextBox::paintSpellingOrGrammarMarker):
              (WebCore::InlineTextBox::paintCompositionUnderline):
              * rendering/RenderBlock.cpp: Ditto.
              (WebCore::RenderBlock::baselinePosition):
              (WebCore::RenderBlock::firstLineBoxBaseline):
              (WebCore::RenderBlock::lastLineBoxBaseline):
              * rendering/RenderBox.cpp: Ditto.
              (WebCore::RenderBox::localCaretRect):
              * rendering/RenderEmbeddedObject.cpp: Ditto.
              (WebCore::RenderEmbeddedObject::paintReplaced):
              * rendering/RenderImage.cpp: Ditto.
              (WebCore::RenderImage::setImageSizeForAltText):
              (WebCore::RenderImage::paintReplaced):
              * rendering/RenderInline.cpp: Ditto.
              (WebCore::RenderInline::baselinePosition):
              * rendering/RenderListBox.cpp: Ditto.
              (WebCore::RenderListBox::paintItemForeground):
              (WebCore::RenderListBox::itemHeight):
              * rendering/RenderListMarker.cpp: Ditto.
              (WebCore::RenderListMarker::paint):
              (WebCore::RenderListMarker::layout):
              (WebCore::RenderListMarker::computePreferredLogicalWidths):
              (WebCore::RenderListMarker::updateMargins):
              (WebCore::RenderListMarker::getRelativeMarkerRect):
              * rendering/RenderTextControl.cpp: Ditto.
              (WebCore::RenderTextControl::paintPlaceholder):
              * rendering/RenderTextControlSingleLine.cpp: Ditto.
              (WebCore::RenderTextControlSingleLine::createInnerTextStyle):
              * rendering/RenderThemeWin.cpp: Ditto.
              (WebCore::RenderThemeWin::adjustMenuListButtonStyle):
              * rendering/mathml/RenderMathMLFraction.cpp: Ditto.
              (WebCore::RenderMathMLFraction::baselinePosition):
              * rendering/style/RenderStyle.h: Add "const FontMetrics& fontMetrics() const" accessor.
              (WebCore::InheritedFlags::fontMetrics):
              (WebCore::InheritedFlags::computedLineHeight):
              * rendering/svg/RenderSVGInlineText.cpp: Use style->fontMetrics() instead of style->font() to access the metrics.
              (WebCore::RenderSVGInlineText::positionForPoint):
              * rendering/svg/SVGInlineTextBox.cpp: Ditto.
              (WebCore::SVGInlineTextBox::selectionRectForTextFragment):
              (WebCore::positionOffsetForDecoration):
              (WebCore::SVGInlineTextBox::paintDecorationWithStyle):
              (WebCore::SVGInlineTextBox::paintTextWithShadows):
              (WebCore::SVGInlineTextBox::calculateBoundaries):
              * rendering/svg/SVGTextLayoutEngineBaseline.cpp: Ditto.
              (WebCore::SVGTextLayoutEngineBaseline::calculateBaselineShift):
              (WebCore::SVGTextLayoutEngineBaseline::calculateAlignmentBaselineShift):
              (WebCore::SVGTextLayoutEngineBaseline::calculateGlyphAdvanceAndOrientation):
              * rendering/svg/SVGTextLayoutEngineSpacing.cpp: Ditto.
              (WebCore::SVGTextLayoutEngineSpacing::calculateSVGKerning):
              * rendering/svg/SVGTextMetrics.cpp: Ditto.
              (WebCore::SVGTextMetrics::SVGTextMetrics):
              * rendering/svg/SVGTextQuery.cpp: Ditto.
              (WebCore::calculateGlyphBoundaries):
              * svg/SVGFontFaceElement.cpp: 
              (WebCore::SVGFontFaceElement::unitsPerEm): Rename defaultUnitsPerEm global to gDefaultUnitsPerEm.
              * svg/SVGLength.cpp: Use style->fontMetrics() instead of style->font() to access the metrics.
              (WebCore::SVGLength::convertValueFromUserUnitsToEXS):
              (WebCore::SVGLength::convertValueFromEXSToUserUnits):
      2011-01-21  Nikolas Zimmermann  <nzimmermann@rim.com>
      
              Reviewed by Dirk Schulze.
      
              Introduce FontMetrics abstraction
              https://bugs.webkit.org/show_bug.cgi?id=51456
      
              * WebProcess/WebCoreSupport/win/WebPopupMenuWin.cpp: Use FontMetrics instead of Font to access the metrics.
              (WebKit::WebPopupMenu::setUpPlatformData):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@76442 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      e8433cca
    • paroga@webkit.org's avatar
      2011-01-22 Patrick Gansterer <paroga@webkit.org> · 95057d93
      paroga@webkit.org authored
              Unreviewed WinCE build fix for r76430.
      
              * runtime/MachineStackMarker.cpp:
              (JSC::swapIfBackwards):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@76441 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      95057d93
    • andreas.kling@nokia.com's avatar
      2011-01-22 Andreas Kling <kling@webkit.org> · 4c1aba83
      andreas.kling@nokia.com authored
              Unreviewed, add Qt-specific result for test added in r76414.
      
              * platform/qt/fast/text/justify-nbsp-expected.txt: Added.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@76440 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      4c1aba83
    • rniwa@webkit.org's avatar
      2011-01-22 Ryosuke Niwa <rniwa@webkit.org> · b9686378
      rniwa@webkit.org authored
              Unreviewed Chromium test expectation update.
      
              * platform/chromium/test_expectations.txt:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@76439 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      b9686378
    • rniwa@webkit.org's avatar
      2011-01-22 Ryosuke Niwa <rniwa@webkit.org> · 0798fc98
      rniwa@webkit.org authored
              Reviewed by Eric Seidel.
      
              Stop instantiating legacy editing positions in VisibleSelection, visible_units.cpp, Frame, and RenderBlock
              https://bugs.webkit.org/show_bug.cgi?id=52759
      
              Stopped instantiating legacy editing positions in the following files.
      
              * editing/VisibleSelection.cpp:
              (WebCore::VisibleSelection::adjustSelectionToAvoidCrossingEditingBoundaries):
              * editing/visible_units.cpp:
              (WebCore::previousBoundary):
              (WebCore::previousLinePosition):
              (WebCore::nextLinePosition):
              (WebCore::startOfBlock):
              * page/Frame.cpp:
              (WebCore::Frame::visiblePositionForPoint):
              * rendering/RenderBlock.cpp: Removed RenderBlock::positionForRenderer because it was not called anywhere.
              * rendering/RenderBlock.h: Ditto.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@76438 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      0798fc98
    • enne@google.com's avatar
      2011-01-22 Adrienne Walker <enne@google.com> · 54952b5b
      enne@google.com authored
              Reviewed by James Robinson.
      
              [chromium] Fix compositor repaints for offscreen fixed elements
              https://bugs.webkit.org/show_bug.cgi?id=52681
      
              The fast path scrolling was clipping offscreen invalidations.
              Additionally, the compositor was ignoring all invalidations that were
              entirely out of the content rect.
      
              Test: compositing/ to verify this caused no regressions.
              Tested fix manually in browser as I could not generate a LayoutTest that reproduced the bug in run-webkit-tests.
      
              * page/FrameView.cpp:
              (WebCore::FrameView::scrollContentsFastPath):
              * platform/graphics/chromium/LayerRendererChromium.cpp:
              (WebCore::LayerRendererChromium::invalidateRootLayerRect):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@76437 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      54952b5b
    • rniwa@webkit.org's avatar
      2011-01-22 Ryosuke Niwa <rniwa@webkit.org> · f6cc5153
      rniwa@webkit.org authored
              Unreviewed Chromium test expectation update.
      
              * platform/chromium/test_expectations.txt:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@76436 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      f6cc5153
    • ap@apple.com's avatar
      Reviewed by Darin Adler. · 7817d1c1
      ap@apple.com authored
              https://bugs.webkit.org/show_bug.cgi?id=52473
              Auto-scaling to avoid orphans is broken, remove dysfunctional code
      
              * WebView/WebHTMLView.mm:
              (-[WebHTMLView _setPrinting:minimumPageWidth:height:maximumPageWidth:adjustViewSize:paginateScreenContent:]):
              (-[WebHTMLView _scaleFactorForPrintOperation:]):
              (-[WebHTMLView knowsPageRange:]):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@76435 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      7817d1c1
    • ap@apple.com's avatar
      2011-01-22 Alexey Proskuryakov <ap@apple.com> · 92c70bde
      ap@apple.com authored
              Reviewed by Dan Bernstein.
      
              https://bugs.webkit.org/show_bug.cgi?id=52950
              Leak in WebPage::drawRectToPDF
      
              * WebProcess/WebPage/WebPage.cpp: (WebKit::WebPage::drawRectToPDF): Use RetainPtr here, too.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@76434 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      92c70bde
    • ap@apple.com's avatar
      2011-01-22 Alexey Proskuryakov <ap@apple.com> · 1260e1d1
      ap@apple.com authored
              Reviewed by Dan Bernstein.
      
              https://bugs.webkit.org/show_bug.cgi?id=52951
              WebKit2 generates a bad PDF for cross process messaging
      
              * page/PrintContext.cpp: (WebCore::PrintContext::spoolRect): Use a correct offset to actually
              draw inside the requested rectangle.
      2011-01-22  Alexey Proskuryakov  <ap@apple.com>
      
              Reviewed by Dan Bernstein.
      
              https://bugs.webkit.org/show_bug.cgi?id=52951
              WebKit2 generates a bad PDF for cross process messaging
      
              * UIProcess/API/mac/WKView.mm:
              (-[WKView _recursiveDisplayRectIfNeededIgnoringOpacity:isVisibleRect:rectIsVisibleRectForView:topView:]):
              Use a correct offset when flipping.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@76433 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      1260e1d1
    • ggaren@apple.com's avatar
      Reorganized MarkedSpace, making many of its functions private. · d95a475b
      ggaren@apple.com authored
      Reviewed by Beth Dakin.
      
      * runtime/JSCell.h:
      (JSC::JSCell::Heap::heap):
      * runtime/MarkedSpace.h:
      (JSC::MarkedSpace::globalData):
      (JSC::MarkedSpace::heap):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@76432 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      d95a475b
  2. 21 Jan, 2011 18 commits
    • ggaren@apple.com's avatar
      Try to fix build: moved helper function out of #ifdef. · 46903aba
      ggaren@apple.com authored
      * runtime/MachineStackMarker.cpp:
      (JSC::swapIfBackwards):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@76431 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      46903aba
    • ggaren@apple.com's avatar
      A few of Maciej's review suggestions for my last patch. · eda35d36
      ggaren@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=52946        
      
      Rubber-stamped by Maciej Stachowiak.
      
      SunSpider reports no change.
      
      * runtime/MachineStackMarker.cpp:
      (JSC::swapIfBackwards): Added a helper function for handling platforms
      where the stack can grow in any direction.
      
      (JSC::MachineStackMarker::markCurrentThreadConservativelyInternal):
      (JSC::MachineStackMarker::markOtherThreadConservatively): Use the helper
      function.
      
      (JSC::isPointerAligned): Use "!" instead of "==0" because a robot told me to.
      
      (JSC::MachineStackMarker::markConservatively): Changed to use a more
      standard looping idiom, and to use the helper function above.
      
      * runtime/MarkedSpace.h:
      (JSC::MarkedSpace::isCellAligned): Use "!" instead of "==0" because a robot told me to.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@76430 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      eda35d36
    • abarth@webkit.org's avatar
      2011-01-21 Yury Semikhatsky <yurys@chromium.org> · 3a2486e3
      abarth@webkit.org authored
              Reviewed by Adam Barth.
      
              Regression: new window.onerror() implementation leaks cross-origin Javascript errors
              https://bugs.webkit.org/show_bug.cgi?id=52903
      
              In case of an exception in a script from different domain only generic message
              will be passed to window.onerror hander.
      
              Tests: http/tests/security/cross-origin-script-window-onerror-redirected.html
                     http/tests/security/cross-origin-script-window-onerror.html
      
              * bindings/js/CachedScriptSourceProvider.h: use URL from the resource response to make sure we do all
              cross origin checks agains real script URL, not the original URL which may have resulted in a sequence
              of redirects to different domains.
              (WebCore::CachedScriptSourceProvider::CachedScriptSourceProvider):
              * bindings/v8/ScriptSourceCode.h: same for v8.
              (WebCore::ScriptSourceCode::url):
              * dom/ScriptExecutionContext.cpp:
              (WebCore::ScriptExecutionContext::dispatchErrorEvent): in case the error occurred in a script we cannot
              access provide concise "Script error." message without any information about the error source. This is
              what Firefox does in this case.
      2011-01-21  Yury Semikhatsky  <yurys@chromium.org>
      
              Reviewed by Adam Barth.
      
              Regression: new window.onerror() implementation leaks cross-origin Javascript errors
              https://bugs.webkit.org/show_bug.cgi?id=52903
      
              A couple of tests to check that window.onerror won't reveal any content of the resource
              from a different domain if the latter is referenced via <script src=...>
      
              * http/tests/security/cross-origin-script-window-onerror-expected.txt: Added.
              * http/tests/security/cross-origin-script-window-onerror-redirected-expected.txt: Added.
              * http/tests/security/cross-origin-script-window-onerror-redirected.html: Added.
              * http/tests/security/cross-origin-script-window-onerror.html: Added.
              * http/tests/security/resources/cross-origin-script.txt: Added.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@76429 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      3a2486e3
    • abarth@webkit.org's avatar
      2011-01-21 Adam Barth <abarth@webkit.org> · 1c5f9e4f
      abarth@webkit.org authored
              Reviewed by Maciej Stachowiak.
      
              Disable mac_unittest.py that fails on some of the Mac bots
              https://bugs.webkit.org/show_bug.cgi?id=52947
      
              As noted in the comment, this test does not appear to be correct
              because the function this test is testing returns different results
              depending on which flavor of Mac the test is run on.  This patch
              disable the test.  Hopefully we can re-enable the test once we've
              probably insulated the test from its environment.
      
              * Scripts/webkitpy/layout_tests/port/mac_unittest.py:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@76428 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      1c5f9e4f
    • mjs@apple.com's avatar
      2011-01-21 Maciej Stachowiak <mjs@apple.com> · e67eb938
      mjs@apple.com authored
              Reviewed by Geoffrey Garen.
      
              Humor the WebKit2 buildbot in its continuing hatred of forms tests
              https://bugs.webkit.org/show_bug.cgi?id=52944
      
              * platform/mac-wk2/Skipped:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@76427 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      e67eb938
    • mitz@apple.com's avatar
      Updated the results after r76414 fixed text justification in this test. · bfc9a4ae
      mitz@apple.com authored
      Rubber-stamped by Mark Rowe.
      
      * platform/mac/fast/text/justified-text-rect-expected.checksum:
      * platform/mac/fast/text/justified-text-rect-expected.png:
      * platform/mac/fast/text/justified-text-rect-expected.txt:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@76426 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      bfc9a4ae
    • ggaren@apple.com's avatar
      2011-01-21 Geoffrey Garen <ggaren@apple.com> · 86f21951
      ggaren@apple.com authored
              Reviewed by Maciej Stachowiak.
      
              Cleaned up some conservative marking code.
              https://bugs.webkit.org/show_bug.cgi?id=52946
              
              SunSpider reports no change.
      
              * interpreter/RegisterFile.h: No need for a special marking function,
              since we already expose a start() and end().
      
              * runtime/Heap.cpp:
              (JSC::Heap::registerFile):
              (JSC::Heap::markRoots):
              * runtime/Heap.h:
              (JSC::Heap::contains): Migrated markConservatively() to the machine stack
              marker class. Now, Heap just provides a contains() function, which the
              machine stack marker uses for checking whether a pointer points into the heap.
      
              * runtime/MachineStackMarker.cpp:
              (JSC::MachineStackMarker::markCurrentThreadConservativelyInternal):
              (JSC::MachineStackMarker::markOtherThreadConservatively):
              (JSC::isPointerAligned):
              (JSC::MachineStackMarker::markConservatively):
              * runtime/MachineStackMarker.h: Move the conservative marking code here.
      
              * runtime/MarkStack.h:
              (JSC::ConservativeSet::add):
              (JSC::ConservativeSet::mark): Changed to using a vector instead of hash
              set. Vector seems to be a bit faster, and it generates smaller code.
      
              * runtime/MarkedSpace.cpp:
              (JSC::MarkedSpace::containsSlowCase):
              * runtime/MarkedSpace.h:
              (JSC::MarkedSpace::isCellAligned):
              (JSC::MarkedSpace::isPossibleCell):
              (JSC::MarkedSpace::contains): Kept the code for determining whether a
              pointer pointed into marked space, and moved the code for marking
              a set of conservative pointers into the machine stack marker.
      
              * wtf/HashSet.h:
              (WTF::::add): Added two missing inlines that I noticed while testing
              vector vs hash set.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@76425 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      86f21951
    • jamesr@google.com's avatar
      2011-01-21 James Robinson <jamesr@chromium.org> · 190aecd5
      jamesr@google.com authored
              Update chromium test expectations. fast/animation tests should now pass on all chromium configurations.
      
              * platform/chromium/test_expectations.txt:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@76424 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      190aecd5
    • mrowe@apple.com's avatar
      Versioning. · 7c6a823f
      mrowe@apple.com authored
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@76423 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      7c6a823f
    • mitz@apple.com's avatar
      Fix test failure. · 119e1ca6
      mitz@apple.com authored
      * fast/text/justify-nbsp.html: Removed a contenteditable attribute
      that was added after generating results.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@76421 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      119e1ca6
    • andreas.kling@nokia.com's avatar
      2011-01-21 Andreas Kling <kling@webkit.org> · dcf20d9a
      andreas.kling@nokia.com authored
              Unreviewed, removing the Qt result for r76414 since the test
              was actually broken beyond the usual off-by-one metrics.
      
              * platform/qt/fast/text/justify-nbsp-expected.txt: Removed.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@76420 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      dcf20d9a
    • andreas.kling@nokia.com's avatar
      2011-01-21 Andreas Kling <kling@webkit.org> · 7cc6d595
      andreas.kling@nokia.com authored
              Unreviewed, add Qt-specific result for test added in r76414.
      
              * platform/qt/fast/text/justify-nbsp-expected.txt: Added.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@76419 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      7cc6d595
    • ap@apple.com's avatar
      Reviewed by Dan Bernstein. · 9d1b66c3
      ap@apple.com authored
              https://bugs.webkit.org/show_bug.cgi?id=52943
              Objective-C files should use #import, not #include
      
              * UIProcess/API/C/WebKit2.h: This is an interesting one, because it's cross-platform, and
              there is more than one WKView.h.
      
              * Platform/mac/ModuleMac.mm:
              * Platform/mac/RunLoopMac.mm:
              * PluginProcess/mac/PluginControllerProxyMac.mm:
              * PluginProcess/mac/PluginProcessMac.mm:
              * PluginProcess/mac/PluginProcessMainMac.mm:
              * Shared/API/c/mac/WKCertificateInfoMac.mm:
              * Shared/API/c/mac/WKURLRequestNS.mm:
              * Shared/API/c/mac/WKURLResponseNS.mm:
              * Shared/Plugins/Netscape/mac/NetscapePluginModuleMac.mm:
              * Shared/mac/PlatformCertificateInfo.mm:
              * Shared/mac/SandboxExtensionMac.mm:
              * Shared/mac/WebCoreArgumentCodersMac.mm:
              * Shared/mac/WebMemorySampler.mac.mm:
              * Shared/mac/WebURLRequestMac.mm:
              * Shared/mac/WebURLResponseMac.mm:
              * UIProcess/API/mac/FindIndicatorWindow.mm:
              * UIProcess/API/mac/WKTextInputWindowController.mm:
              * UIProcess/Launcher/mac/ProcessLauncherMac.mm:
              * UIProcess/Launcher/mac/ThreadLauncherMac.mm:
              * UIProcess/Plugins/mac/PluginInfoStoreMac.mm:
              * UIProcess/Plugins/mac/PluginProcessProxyMac.mm:
              * UIProcess/mac/BackingStoreMac.mm:
              * UIProcess/mac/ChunkedUpdateDrawingAreaProxyMac.mm:
              * UIProcess/mac/LayerBackedDrawingAreaProxyMac.mm:
              * UIProcess/mac/TextCheckerMac.mm:
              * UIProcess/mac/WebContextMac.mm:
              * UIProcess/mac/WebContextMenuProxyMac.mm:
              * UIProcess/mac/WebPageProxyMac.mm:
              * UIProcess/mac/WebPopupMenuProxyMac.mm:
              * UIProcess/mac/WebPreferencesMac.mm:
              * WebProcess/Downloads/mac/DownloadMac.mm:
              * WebProcess/Plugins/Netscape/mac/NetscapePluginMac.mm:
              * WebProcess/Plugins/Netscape/mac/PluginProxyMac.mm:
              * WebProcess/WebCoreSupport/mac/WebContextMenuClientMac.mm:
              * WebProcess/WebCoreSupport/mac/WebDatabaseManagerMac.mm:
              * WebProcess/WebCoreSupport/mac/WebEditorClientMac.mm:
              * WebProcess/WebCoreSupport/mac/WebErrorsMac.mm:
              * WebProcess/WebCoreSupport/mac/WebPopupMenuMac.mm:
              * WebProcess/WebPage/mac/LayerBackedDrawingAreaMac.mm:
              * WebProcess/WebPage/mac/WebPageMac.mm:
              * WebProcess/mac/WebProcessMac.mm:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@76418 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      9d1b66c3
    • mrowe@apple.com's avatar
      Fix the WebKit2 build with clang. · d82db12f
      mrowe@apple.com authored
      Reviewed by Sam Weinig.
      
      * Scripts/webkit2/messages.py: Add some more structs to the list.
      * UIProcess/DrawingAreaProxy.h: Forward-declare UpdateInfo as a class.
      * UIProcess/TextChecker.h: Forward-declare TextCheckerState as a struct.
      * UIProcess/WebPageProxy.h: Forward-declare ContextMenuState as a struct.
      * UIProcess/mac/TextCheckerMac.mm: Fix the type of the string constants so that they can be passed to
      functions expecting NSString* without generating warnings.
      * WebProcess/WebPage/DrawingArea.h: Forward-declare WebPageCreationParameters as a struct.
      * WebProcess/WebPage/DrawingAreaImpl.h: Forward-declare UpdateInfo as a class.
      * WebProcess/WebPage/WebPage.cpp:
      (WebKit::WebPage::getResourceDataFromFrame): Add parens around the assignment in the condition of
      the if statement to suppress a warning.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@76417 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      d82db12f
    • mrowe@apple.com's avatar
      Fix the build when using Clang by removing some unused variables. · c0e3af40
      mrowe@apple.com authored
      Rubber-stamped by Jon Honeycutt.
      
      * Plugins/Hosted/WebHostedNetscapePluginView.mm:
      (-[WebHostedNetscapePluginView updateAndSetWindow]):
      * WebView/WebFullScreenController.mm:
      (-[WebFullScreenController enterFullscreen:]):
      (-[WebFullScreenController exitFullscreen]):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@76416 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      c0e3af40
    • andreas.kling@nokia.com's avatar
      2011-01-21 Andreas Kling <kling@webkit.org> · bbef9f53
      andreas.kling@nokia.com authored
              Reviewed by Kenneth Rohde Christiansen.
      
              [Qt] Always set composition mode through GraphicsContext
              https://bugs.webkit.org/show_bug.cgi?id=52940
      
              GraphicsContext tracks the current composition mode so we should
              never call through to the QPainter directly.
      
              * platform/graphics/GraphicsContext.h:
              * platform/graphics/qt/GraphicsContextQt.cpp:
              (WebCore::toQtCompositionMode): Changed this method to a static inline
              since it's only used by GraphicsContextQt.cpp now.
      
              * platform/graphics/qt/ImageQt.cpp:
              (WebCore::Image::drawPattern):
              (WebCore::BitmapImage::draw):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@76415 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      bbef9f53
    • mitz@apple.com's avatar
      Inconsistent handling of no-break space in justification logic · 36b07b18
      mitz@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=52938
      
      Reviewed by Adele Peterson.
      
      Source/WebCore: 
      
      Test: fast/text/justify-nbsp.html
      
      * rendering/RenderBlockLineLayout.cpp:
      (WebCore::RenderBlock::computeInlineDirectionPositionsForLine): Count no-break space as a
      space when computing the distribution of space between text boxes on the line.
      
      LayoutTests: 
      
      * fast/text/justify-nbsp-expected.checksum: Added.
      * fast/text/justify-nbsp-expected.png: Added.
      * fast/text/justify-nbsp-expected.txt: Added.
      * fast/text/justify-nbsp.html: Added.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@76414 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      36b07b18
    • dpranke@chromium.org's avatar
      2011-01-21 Dirk Pranke <dpranke@chromium.org> · 10f3ebcc
      dpranke@chromium.org authored
              Reviewed by Mihai Parparita.
      
              Fix bug introduced in r76322 that caused NRWT to not actually
              read the Skipped files properly.
      
              https://bugs.webkit.org/show_bug.cgi?id=52771
      
              * Scripts/webkitpy/layout_tests/port/mac_unittest.py:
              * Scripts/webkitpy/layout_tests/port/webkit.py:
              * Scripts/webkitpy/layout_tests/port/webkit_unittest.py:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@76413 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      10f3ebcc