- 24 Jun, 2011 29 commits
-
-
mdelaney@apple.com authored
Reviewed by Simon Fraser. Change transforms/3d/point-mapping/3d-point-mapping{,-preserve-3d}.html to absolutely position divs https://bugs.webkit.org/show_bug.cgi?id=63327 * transforms/3d/point-mapping/3d-point-mapping-preserve-3d.html: * transforms/3d/point-mapping/3d-point-mapping.html: git-svn-id: http://svn.webkit.org/repository/webkit/trunk@89681 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
tony@chromium.org authored
Reviewed by Darin Adler. Refactor creation of primitive values in CSSParser https://bugs.webkit.org/show_bug.cgi?id=63270 Covered by existing tests. * css/CSSParser.cpp: (WebCore::CSSParser::createPrimitiveNumericValue): Helper method for creating numeric values to keep the cast in one place. (WebCore::CSSParser::createPrimitiveStringValue): Helper method for creating string values. (WebCore::CSSParser::parseValidPrimitive): (WebCore::CSSParser::parseValue): (WebCore::CSSParser::parseWCSSInputProperty): (WebCore::CSSParser::parsePage): (WebCore::CSSParser::parseSizeParameter): (WebCore::CSSParser::parseContent): (WebCore::CSSParser::parseFillPositionX): (WebCore::CSSParser::parseFillPositionY): (WebCore::CSSParser::parseFillPositionComponent): (WebCore::CSSParser::parseFillSize): (WebCore::CSSParser::parseAnimationDelay): (WebCore::CSSParser::parseAnimationDuration): (WebCore::CSSParser::parseAnimationIterationCount): (WebCore::CSSParser::parseAnimationName): (WebCore::CSSParser::parseTransformOriginShorthand): (WebCore::CSSParser::parseDashboardRegions): (WebCore::CSSParser::parseCounterContent): (WebCore::CSSParser::parseShape): (WebCore::CSSParser::parseFont): (WebCore::CSSParser::parseReflect): (WebCore::CSSParser::parseBorderRadius): (WebCore::CSSParser::parseCounter): (WebCore::CSSParser::parseDeprecatedGradient): (WebCore::CSSParser::parseLinearGradient): (WebCore::CSSParser::parseRadialGradient): (WebCore::CSSParser::parseGradientColorStops): (WebCore::CSSParser::parseTransform): (WebCore::CSSParser::parseTransformOrigin): (WebCore::CSSParser::parseTextEmphasisStyle): * css/CSSParser.h: * css/CSSPrimitiveValueCache.h: (WebCore::CSSPrimitiveValueCache::createValue): pass String by const reference git-svn-id: http://svn.webkit.org/repository/webkit/trunk@89680 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
jberlin@webkit.org authored
Release (WebKit2 Tests) https://bugs.webkit.org/show_bug.cgi?id=63328 Add win-wk2 expected results that match the mac, but not mac-wk2, results so that the test does not start failing on win-wk2. * platform/win-wk2/fast/forms: Added. * platform/win-wk2/fast/forms/textfield-overflow-expected.txt: Added. git-svn-id: http://svn.webkit.org/repository/webkit/trunk@89679 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
carlosgc@webkit.org authored
Reviewed by Martin Robinson. [X11] Do not call NPP_SetWindow with a null window handle on destroy https://bugs.webkit.org/show_bug.cgi?id=62981 * WebProcess/Plugins/Netscape/NetscapePlugin.cpp: (WebKit::NetscapePlugin::destroy): git-svn-id: http://svn.webkit.org/repository/webkit/trunk@89678 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
jberlin@webkit.org authored
Release (WebKit2 Tests) https://bugs.webkit.org/show_bug.cgi?id=63328 Add (failing?) expected results for mac-wk2 to get the bots green. * platform/mac-wk2/fast/forms/textfield-overflow-expected.txt: Added. git-svn-id: http://svn.webkit.org/repository/webkit/trunk@89677 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
eric.carlson@apple.com authored
Reviewed by Alexey Proskuryakov. Exit immediately if the last condition tested fails. Make <video> app cache test exit immediately on failure https://bugs.webkit.org/show_bug.cgi?id=63323 git-svn-id: http://svn.webkit.org/repository/webkit/trunk@89676 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
carlosgc@webkit.org authored
Reviewed by Martin Robinson. [GTK] Add more debug options to compilation https://bugs.webkit.org/show_bug.cgi?id=63318 Add --enable-debug-symbols to enable/disable compilation with debug symbols and --enable-debug-features to enable/disable debug features. Both options are unconditionally enabled for debug builds. * configure.ac: git-svn-id: http://svn.webkit.org/repository/webkit/trunk@89675 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
jberlin@webkit.org authored
http/tests/inspector/extensions-resources-redirect.html timing out on SnowLeopard Intel Release (WebKit2 Tests). https://bugs.webkit.org/show_bug.cgi?id=63325 Skip those tests to get the bots green. * platform/mac-wk2/Skipped: git-svn-id: http://svn.webkit.org/repository/webkit/trunk@89674 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
carlosgc@webkit.org authored
Reviewed by Martin Robinson. [GTK] Fix runtime critical warnings in WebKit2 https://bugs.webkit.org/show_bug.cgi?id=63256 Check whether there's a view widget before trying to use it in PlatformScreenGtk. If there isn't a view widget, which is the case in WebKit2, try to use the default GdkScreen and monitor. * platform/gtk/PlatformScreenGtk.cpp: (WebCore::getToplevel): Helper function to get the toplevel widget. (WebCore::getVisual): Use getToplevel(). (WebCore::getScreen): Helper funtion to get the screen of a widget. (WebCore::screenRect): Use getToplevel() and getScreen(). git-svn-id: http://svn.webkit.org/repository/webkit/trunk@89673 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
ossy@webkit.org authored
https://bugs.webkit.org/show_bug.cgi?id=63321 * platform/qt-wk2/Skipped: Skip fast/frames/iframe-plugin-load-remove-document-crash.html until fix. git-svn-id: http://svn.webkit.org/repository/webkit/trunk@89672 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
kbalazs@webkit.org authored
Unreviewed. Remove non-existent items from the qt-wk2 skipped list. * platform/qt-wk2/Skipped: git-svn-id: http://svn.webkit.org/repository/webkit/trunk@89671 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
ossy@webkit.org authored
https://bugs.webkit.org/show_bug.cgi?id=63320 Reviewed by Dirk Schulze. * Scripts/run-bindings-tests: git-svn-id: http://svn.webkit.org/repository/webkit/trunk@89670 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
yutak@chromium.org authored
Reviewed by Adam Barth. WebSocket: Add run-time flag for new HyBi protocol https://bugs.webkit.org/show_bug.cgi?id=60348 Add a flag in Setting so that WebSocket protocols can be switched dynamically. The protocol we have implemented so far is based on older Hixie-76 specification. A new protocol is being discussed in IETF HyBi working group, and I'm planning to implement the new protocol behind this Settings flag. I will add a method to LayoutTestController which flips this flag in a later patch. In this way, we can put tests for both protocols in the same place and test implementation for both protocols at the same time. This patch only adds a flag. The flag is not used yet, thus there is no change in functionality. Therefore, no tests were added. * page/Settings.cpp: (WebCore::Settings::Settings): * page/Settings.h: (WebCore::Settings::setUseHixie76WebSocketProtocol): (WebCore::Settings::useHixie76WebSocketProtocol): 2011-06-24 Yuta Kitamura <yutak@chromium.org> Reviewed by Adam Barth. WebSocket: Add run-time flag for new HyBi protocol https://bugs.webkit.org/show_bug.cgi?id=60348 Make a new flag (Setting::m_useHixie76WebSocketProtocol) switchable from WebView and WebPreferences. * WebView/WebPreferenceKeysPrivate.h: * WebView/WebPreferences.mm: (+[WebPreferences initialize]): (-[WebPreferences setHixie76WebSocketProtocolEnabled:]): (-[WebPreferences isHixie76WebSocketProtocolEnabled]): * WebView/WebPreferencesPrivate.h: * WebView/WebView.mm: (-[WebView _preferencesChanged:]): 2011-06-24 Yuta Kitamura <yutak@chromium.org> Reviewed by Adam Barth. WebSocket: Add run-time flag for new HyBi protocol https://bugs.webkit.org/show_bug.cgi?id=60348 Make a new flag (Setting::m_useHixie76WebSocketProtocol) switchable from WebView and WebPreferences. * Interfaces/IWebPreferencesPrivate.idl: * WebPreferenceKeysPrivate.h: * WebPreferences.cpp: (WebPreferences::initializeDefaultSettings): (WebPreferences::setHixie76WebSocketProtocolEnabled): (WebPreferences::hixie76WebSocketProtocolEnabled): * WebPreferences.h: * WebView.cpp: (WebView::notifyPreferencesChanged): git-svn-id: http://svn.webkit.org/repository/webkit/trunk@89669 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
tkent@chromium.org authored
Reviewed by Dimitri Glazkov. Clean up some tests for search cancel buttons. https://bugs.webkit.org/show_bug.cgi?id=63121 - Introduce a function to retrieve a reliable position of a search cancel button. - Convert two tests to dumpAsText(). * fast/forms/resources/common.js: (searchCancelButtonPosition): Added. * fast/forms/search-abs-pos-cancel-button.html: Use searchCancelButtonPosition(). * fast/forms/search-cancel-button-mouseup.html: Use searchCancelButtonPosition(). * fast/forms/search-transformed-expected.txt: Added. * fast/forms/search-transformed.html: - Use searchCancelButtonPosition(). - Convert to dumpAsText(). * fast/forms/search-zoomed-expected.txt: Added. * fast/forms/search-zoomed.html: - Use searchCancelButtonPosition(). - Convert to dumpAsText(). * platform/chromium/test_expectation.txt: search-transformed.html should pass. * platform/chromium-linux/fast/forms/search-zoomed-expected.png: Removed. * platform/chromium-mac-leopard/fast/forms/search-transformed-expected.png: Removed. * platform/chromium-mac-leopard/fast/forms/search-zoomed-expected.png: Removed. * platform/chromium-mac/fast/forms/search-transformed-expected.png: Removed. * platform/chromium-win/fast/forms/search-zoomed-expected.png: Removed. * platform/chromium-win/fast/forms/search-zoomed-expected.txt: Removed. * platform/gtk/fast/forms/search-transformed-expected.png: Removed. * platform/gtk/fast/forms/search-transformed-expected.txt: Removed. * platform/gtk/fast/forms/search-zoomed-expected.png: Removed. * platform/gtk/fast/forms/search-zoomed-expected.txt: Removed. * platform/mac-leopard/fast/forms/search-zoomed-expected.png: Removed. * platform/mac/fast/forms/search-transformed-expected.png: Removed. * platform/mac/fast/forms/search-transformed-expected.txt: Removed. * platform/mac/fast/forms/search-zoomed-expected.png: Removed. * platform/mac/fast/forms/search-zoomed-expected.txt: Removed. * platform/qt/fast/forms/search-transformed-expected.txt: Removed. * platform/qt/fast/forms/search-zoomed-expected.txt: Removed. git-svn-id: http://svn.webkit.org/repository/webkit/trunk@89668 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
tkent@chromium.org authored
Remove an JavaScript error in media-controls-clone.html. https://bugs.webkit.org/show_bug.cgi?id=63195 * media/media-controls-clone.html: Remove run() call. * platform/chromium-mac/media/media-controls-clone-expected.txt: Remove an error message. * platform/chromium-win/media/media-controls-clone-expected.txt: ditto. * platform/mac/media/media-controls-clone-expected.txt: ditto. * platform/win/media/media-controls-clone-expected.txt: ditto. git-svn-id: http://svn.webkit.org/repository/webkit/trunk@89667 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
mnaganov@chromium.org authored
Reviewed by Pavel Feldman. Web Inspector: [Chromium] Shorten DOMWindow URLs in heap profiles. https://bugs.webkit.org/show_bug.cgi?id=63238 * inspector/front-end/DetailedHeapshotGridNodes.js: (WebInspector.HeapSnapshotGridNode.prototype.hasHoverMessage.false.hoverMessage): (WebInspector.HeapSnapshotGenericObjectNode): (WebInspector.HeapSnapshotGenericObjectNode.prototype.hoverMessage): (WebInspector.HeapSnapshotGenericObjectNode.prototype._updateHasChildren): (WebInspector.HeapSnapshotGenericObjectNode.prototype.isDOMWindow): (WebInspector.HeapSnapshotGenericObjectNode.prototype.shortenWindowURL): * inspector/front-end/DetailedHeapshotView.js: (WebInspector.HeapSnapshotRetainingPathsList.prototype.showNext.pathFound): (WebInspector.DetailedHeapshotView.prototype._getHoverAnchor): (WebInspector.DetailedHeapshotView.prototype._showStringContentPopup.displayString): (WebInspector.DetailedHeapshotView.prototype._showStringContentPopup): * inspector/front-end/utilities.js: (): git-svn-id: http://svn.webkit.org/repository/webkit/trunk@89666 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
pfeldman@chromium.org authored
Not reviewed: uncommenting chromium devtools tests. * platform/chromium/inspector/timeline/timeline-layout-expected.txt: Added. * platform/chromium/test_expectations.txt: git-svn-id: http://svn.webkit.org/repository/webkit/trunk@89665 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
gyuyoung.kim@samsung.com authored
Reviewed by Kent Tamura. [EFL] Add ewk_auth.h to EWebKit.h https://bugs.webkit.org/show_bug.cgi?id=63311 * ewk/EWebKit.h: Add ewk_auth.h git-svn-id: http://svn.webkit.org/repository/webkit/trunk@89664 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
morrita@google.com authored
Reviewed by Kent Tamura. [Chromium] Invalid write inside WebKit::FrameLoaderClientImpl::dispatchDidClearWindowObjectInWorld https://bugs.webkit.org/show_bug.cgi?id=63216 Deleted m_webViewHost which looks leaked. * DumpRenderTree/chromium/TestShell.h: * DumpRenderTree/chromium/TestShell.cpp: (TestShell::~TestShell): git-svn-id: http://svn.webkit.org/repository/webkit/trunk@89663 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
commit-queue@webkit.org authored
Reviewed by Pavel Feldman. Web Inspector: HTML preview should delete old iframe on show(). https://bugs.webkit.org/show_bug.cgi?id=63170 * inspector/front-end/ResourceHTMLView.js: (WebInspector.ResourceHTMLView.prototype._createIFrame): * inspector/front-end/ResourcePreviewView.js: (WebInspector.ResourcePreviewView.prototype.contentLoaded): git-svn-id: http://svn.webkit.org/repository/webkit/trunk@89662 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
krit@webkit.org authored
Reviewed by Nikolas Zimmermann. Convert AnimatedString to SVGAnimatorFactory concept https://bugs.webkit.org/show_bug.cgi?id=63296 Follow up of "SVGAnimation should use direct unit animation for SVGLength": https://bugs.webkit.org/show_bug.cgi?id=61368 This patch continues the conversion to the new concept of SVGAnimatorFactory with SVGString. No new tests added. No change of functionality. * CMakeLists.txt: Added new file to build system. * GNUmakefile.list.am: Ditto. * WebCore.gypi: Ditto. * WebCore.pro: Ditto. * WebCore.xcodeproj/project.pbxproj: Ditto. * svg/SVGAllInOne.cpp: Ditto. * svg/SVGAnimateElement.cpp: (WebCore::SVGAnimateElement::calculateAnimatedValue): (WebCore::SVGAnimateElement::calculateFromAndToValues): (WebCore::SVGAnimateElement::calculateFromAndByValues): (WebCore::SVGAnimateElement::resetToBaseValue): (WebCore::SVGAnimateElement::applyResultsToTarget): (WebCore::SVGAnimateElement::calculateDistance): * svg/SVGAnimateElement.h: * svg/SVGAnimatedString.cpp: Added. Animator for SVGString. (WebCore::SVGAnimatedStringAnimator::SVGAnimatedStringAnimator): (WebCore::SVGAnimatedStringAnimator::constructFromString): (WebCore::SVGAnimatedStringAnimator::calculateFromAndToValues): (WebCore::SVGAnimatedStringAnimator::calculateFromAndByValues): (WebCore::SVGAnimatedStringAnimator::calculateAnimatedValue): (WebCore::SVGAnimatedStringAnimator::calculateDistance): * svg/SVGAnimatedString.h: (WebCore::SVGAnimatedStringAnimator::~SVGAnimatedStringAnimator): * svg/SVGAnimatedType.cpp: (WebCore::SVGAnimatedType::~SVGAnimatedType): (WebCore::SVGAnimatedType::createString): (WebCore::SVGAnimatedType::string): (WebCore::SVGAnimatedType::valueAsString): (WebCore::SVGAnimatedType::setValueAsString): * svg/SVGAnimatedType.h: * svg/SVGAnimatorFactory.h: (WebCore::SVGAnimatorFactory::create): git-svn-id: http://svn.webkit.org/repository/webkit/trunk@89661 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
mario@webkit.org authored
Reviewed by Chris Fleizach. [GTK] Consider rows being ignored when adding children to tables https://bugs.webkit.org/show_bug.cgi?id=62718 Unskip accessibility test that will be passing from now on. * platform/gtk/Skipped: Unskipped passing test. 2011-06-24 Mario Sanchez Prada <msanchez@igalia.com> Reviewed by Chris Fleizach. [GTK] Consider rows being ignored when adding children to tables https://bugs.webkit.org/show_bug.cgi?id=62718 Hide row objects in tables in GTK's accessibility wrapper. This is a different approach in the way WebCore's accessible rows are exposed to assistive technologies in the GTK port, since from now on those objects are kept in WebCore (they do not declare to ignore accessibility) and just bypassed in the mapping to ATK, allowing to hide them in the ATK hierarchy while, at the same time, keeping them internally to be able to provide enough information to determine tables related information, such as rows counting or finding an cell for specific coordinates. * accessibility/gtk/AccessibilityObjectAtk.cpp: (WebCore::AccessibilityObject::accessibilityPlatformIncludesObject): Do not ignore accessibility for table rows here. * accessibility/gtk/AccessibilityObjectWrapperAtk.cpp: (webkit_accessible_get_parent): Bypass rows when needed. (getNChildrenForTable): New, find the number of children for a table, which will be the addition of all cells for its rows. (webkit_accessible_get_n_children): Call to getNChildrenForTable for accessibility tables if needed. (getChildForTable): New, bypass rows when needed, retrieving cells as if they were direct children for tables. (webkit_accessible_ref_child): Call to refChildForTable if needed. (getIndexInParentForCellInRow): New, get the index for a given cell in its parent table, considering other rows' cells. (webkit_accessible_get_index_in_parent): Call to getIndexInParentForCellInRow if needed. git-svn-id: http://svn.webkit.org/repository/webkit/trunk@89660 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
caseq@chromium.org authored
Reviewed by Yury Semikhatsky. Web Inspector: extension panel iframes do not span entire panel client area https://bugs.webkit.org/show_bug.cgi?id=63165 * inspector/front-end/ExtensionServer.js: (WebInspector.ExtensionServer.prototype._onCreatePanel): (WebInspector.ExtensionServer.prototype.createClientIframe): * inspector/front-end/inspector.css: (iframe.extension): (iframe.panel.extension): 2011-06-24 Andrey Kosyakov <caseq@chromium.org> Reviewed by Yury Semikhatsky. Web Inspector: extension panel iframes do not span entire panel client area https://bugs.webkit.org/show_bug.cgi?id=63165 * http/tests/inspector/extensions-test.js: (initialize_ExtensionsTest.InspectorTest.showPanel): (): * http/tests/inspector/inspector-test.js: (): * http/tests/inspector/resources/extension-main.html: * http/tests/inspector/resources/extension-main.js: (dumpObject): (dumpArray): (evaluateOnFrontend.callbackWrapper): (evaluateOnFrontend): (): * http/tests/inspector/resources/extension-panel.html: * inspector/extensions/extensions-events.html: * inspector/extensions/extensions-expected.txt: * inspector/extensions/extensions.html: git-svn-id: http://svn.webkit.org/repository/webkit/trunk@89659 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
commit-queue@webkit.org authored
Reviewed by Darin Fisher. Web Inspector: [Chromium] Successfully prefetched page shows up as an error in console https://bugs.webkit.org/show_bug.cgi?id=62396 * public/WebURLError.h: (WebKit::WebURLError::WebURLError): * src/WebURLError.cpp: (WebKit::WebURLError::operator=): (WebKit::WebURLError::operator ResourceError): git-svn-id: http://svn.webkit.org/repository/webkit/trunk@89658 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
pfeldman@chromium.org authored
Reviewed by Pavel Feldman. Web Inspector: [REGRESSION r86838] line numbers do not scroll when script paused https://bugs.webkit.org/show_bug.cgi?id=61653 roll out r86838 No new tests - refactoring. * dom/Document.h: * dom/EventQueue.cpp: (WebCore::EventQueueTimer::EventQueueTimer): (WebCore::EventQueueTimer::fired): (WebCore::EventQueue::create): (WebCore::EventQueue::EventQueue): (WebCore::EventQueue::~EventQueue): (WebCore::EventQueue::enqueueEvent): (WebCore::EventQueue::cancelEvent): (WebCore::EventQueue::cancelQueuedEvents): (WebCore::EventQueue::pendingEventTimerFired): (WebCore::EventQueue::dispatchEvent): * dom/EventQueue.h: git-svn-id: http://svn.webkit.org/repository/webkit/trunk@89657 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
caseq@chromium.org authored
Reviewed by Yury Semikhatsky. Web Inspector: [refactoring] extension tests: replace dispatchOnFrontend with a more generic evaluateOnFrontend() https://bugs.webkit.org/show_bug.cgi?id=63160 * http/tests/inspector/extensions-test.js: (initialize_ExtensionsTest.InspectorTest._replyToExtension): (initialize_ExtensionsTest): * http/tests/inspector/resources/extension-main.html: * http/tests/inspector/resources/extension-main.js: (onError): (onTestsDone): * inspector/extensions/extensions-audits-tests.js: (extension_runAudits): (initialize_ExtensionsAuditsTest.InspectorTest.startExtensionAudits.onAuditsDone): (initialize_ExtensionsAuditsTest.InspectorTest.startExtensionAudits): (initialize_ExtensionsAuditsTest): * inspector/extensions/extensions-events.html: * inspector/extensions/extensions.html: git-svn-id: http://svn.webkit.org/repository/webkit/trunk@89656 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
commit-queue@webkit.org authored
Unreviewed, rolling out r89594. http://trac.webkit.org/changeset/89594 https://bugs.webkit.org/show_bug.cgi?id=63316 It broke 5 tests on the Qt bot (Requested by Ossy_DC on #webkit). * GNUmakefile.list.am: * JavaScriptCore.gypi: * icu/unicode/uscript.h: Removed. * wtf/unicode/ScriptCodesFromICU.h: Removed. * wtf/unicode/brew/UnicodeBrew.h: * wtf/unicode/glib/UnicodeGLib.h: * wtf/unicode/icu/UnicodeIcu.h: * wtf/unicode/qt4/UnicodeQt4.h: * wtf/unicode/wince/UnicodeWinCE.h: 2011-06-24 Sheriff Bot <webkit.review.bot@gmail.com> Unreviewed, rolling out r89594. http://trac.webkit.org/changeset/89594 https://bugs.webkit.org/show_bug.cgi?id=63316 It broke 5 tests on the Qt bot (Requested by Ossy_DC on #webkit). * icu/unicode/uscript.h: Removed. 2011-06-24 Sheriff Bot <webkit.review.bot@gmail.com> Unreviewed, rolling out r89594. http://trac.webkit.org/changeset/89594 https://bugs.webkit.org/show_bug.cgi?id=63316 It broke 5 tests on the Qt bot (Requested by Ossy_DC on #webkit). * WebCore.exp.in: * icu/unicode/uscript.h: * page/Settings.cpp: (WebCore::Settings::setStandardFontFamily): (WebCore::Settings::setFixedFontFamily): (WebCore::Settings::setSerifFontFamily): (WebCore::Settings::setSansSerifFontFamily): (WebCore::Settings::setCursiveFontFamily): (WebCore::Settings::setFantasyFontFamily): * page/Settings.h: (WebCore::Settings::standardFontFamily): (WebCore::Settings::fixedFontFamily): (WebCore::Settings::serifFontFamily): (WebCore::Settings::sansSerifFontFamily): (WebCore::Settings::cursiveFontFamily): (WebCore::Settings::fantasyFontFamily): git-svn-id: http://svn.webkit.org/repository/webkit/trunk@89655 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
carlosgc@webkit.org authored
Unreviewed. Fix WebKit2 GTK build. * WebKitTestRunner/GNUmakefile.am: git-svn-id: http://svn.webkit.org/repository/webkit/trunk@89654 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
tony@chromium.org authored
Reviewed by Kent Tamura. Pass Strings by const reference in bindings code https://bugs.webkit.org/show_bug.cgi?id=63302 Note that since Strings hold a RefPtr to StringImpl, passing Strings by value isn't horrible, but it does cause ref count churn and using const references is more consistent with the rest of the code base. * bindings/generic/BindingSecurity.h: (WebCore::::allowSettingFrameSrcToJavascriptUrl): (WebCore::::allowSettingSrcToJavascriptURL): * bindings/js/SerializedScriptValue.cpp: (WebCore::CloneSerializer::serialize): (WebCore::SerializedScriptValue::create): * bindings/js/SerializedScriptValue.h: * bindings/v8/SerializedScriptValue.cpp: (WebCore::SerializedScriptValue::createFromWire): (WebCore::SerializedScriptValue::create): (WebCore::SerializedScriptValue::SerializedScriptValue): * bindings/v8/SerializedScriptValue.h: * bindings/v8/V8Binding.h: (WebCore::V8ParameterBase::setString): git-svn-id: http://svn.webkit.org/repository/webkit/trunk@89653 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
- 23 Jun, 2011 11 commits
-
-
yurys@chromium.org authored
Reviewed by Pavel Feldman. [Chromium] Web Inspector: provide context menu item for enabling native worker inspection https://bugs.webkit.org/show_bug.cgi?id=63258 Added context menu checkbox item that allows to enable inspection of native workers. The value will be persisted as other inspector settings and will be restored after frontend/breowser reopening. * inspector/Inspector.json: * inspector/InspectorController.cpp: (WebCore::InspectorController::restoreInspectorStateFromCookie): * inspector/InspectorInstrumentation.h: (WebCore::InspectorInstrumentation::didStartWorkerContext): * inspector/InspectorWorkerAgent.cpp: (WebCore::InspectorWorkerAgent::setFrontend): (WebCore::InspectorWorkerAgent::restore): (WebCore::InspectorWorkerAgent::setWorkerInspectionEnabled): * inspector/InspectorWorkerAgent.h: * inspector/front-end/ScriptsPanel.js: (WebInspector.ScriptsPanel): (WebInspector.ScriptsPanel.prototype.reset): (WebInspector.ScriptsPanel.prototype._toggleFormatSourceFiles): (WebInspector.ScriptsPanel.prototype._contextMenu.enableWorkerInspection): (WebInspector.ScriptsPanel.prototype._contextMenu): * inspector/front-end/Settings.js: (WebInspector.Settings): * inspector/front-end/inspector.js: (WebInspector.didCreateWorker): (WebInspector.didDestroyWorker): * workers/Worker.cpp: (WebCore::Worker::notifyFinished): 2011-06-23 Yury Semikhatsky <yurys@chromium.org> Reviewed by Pavel Feldman. [Chromium] Web Inspector: provide context menu item for enabling native worker inspection https://bugs.webkit.org/show_bug.cgi?id=63258 * src/js/DevTools.js: (): git-svn-id: http://svn.webkit.org/repository/webkit/trunk@89652 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
simon.fraser@apple.com authored
Reviewed by Dan Bernstein. Need to turn off default animations for anchorPointZ in PlatformCALayer https://bugs.webkit.org/show_bug.cgi?id=63159 When the z-component of transform-origin changed, we ran an implicit animation of anchorPointZ on the CALayer. Turn this off. Test: transforms/3d/general/transform-origin-z-change.html * platform/graphics/ca/mac/PlatformCALayerMac.mm: (nullActionsDictionary): git-svn-id: http://svn.webkit.org/repository/webkit/trunk@89651 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
zmo@google.com authored
Reviewed by Kenneth Russell. Limit WebGL internal drawingBuffer size to 4k x 4k https://bugs.webkit.org/show_bug.cgi?id=63304 * html/canvas/WebGLRenderingContext.cpp: (WebCore::WebGLRenderingContext::reshape): Limit drawing buffer size to 4k x 4k. git-svn-id: http://svn.webkit.org/repository/webkit/trunk@89650 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
morrita@google.com authored
Reviewed by Dimitri Glazkov. [ShadowContentElement] should layout child whitespace between span. https://bugs.webkit.org/show_bug.cgi?id=62202 - Added a new test case. - Updated expectations, which missed necessary RnederText objects. * platform/chromium-win/fast/html/details-add-child-2-expected.txt: * platform/chromium-win/fast/html/details-add-details-child-2-expected.txt: * platform/chromium-win/fast/html/details-no-summary4-expected.txt: * platform/chromium-win/fast/html/details-open-javascript-expected.txt: * platform/chromium-win/fast/html/details-open2-expected.txt: * platform/chromium-win/fast/html/details-open4-expected.txt: * platform/chromium-win/fast/html/details-remove-child-2-expected.txt: * platform/chromium-win/fast/html/details-replace-text-expected.txt: * platform/gtk/fast/html/details-add-child-2-expected.txt: * platform/gtk/fast/html/details-add-details-child-2-expected.txt: * platform/gtk/fast/html/details-no-summary4-expected.txt: * platform/gtk/fast/html/details-open-javascript-expected.txt: * platform/gtk/fast/html/details-open2-expected.txt: * platform/gtk/fast/html/details-open4-expected.txt: * platform/gtk/fast/html/details-remove-child-2-expected.txt: * platform/gtk/fast/html/details-replace-text-expected.txt: * platform/mac/fast/html/details-add-child-2-expected.txt: * platform/mac/fast/html/details-add-details-child-2-expected.txt: * platform/mac/fast/html/details-no-summary4-expected.txt: * platform/mac/fast/html/details-open-javascript-expected.txt: * platform/mac/fast/html/details-open2-expected.txt: * platform/mac/fast/html/details-open4-expected.txt: * platform/mac/fast/html/details-remove-child-2-expected.txt: * platform/mac/fast/html/details-replace-text-expected.txt: * platform/qt/fast/html/details-add-child-2-expected.txt: * platform/qt/fast/html/details-add-details-child-2-expected.txt: * platform/qt/fast/html/details-no-summary4-expected.txt: * platform/qt/fast/html/details-open-javascript-expected.txt: * platform/qt/fast/html/details-open2-expected.txt: * platform/qt/fast/html/details-open4-expected.txt: * platform/qt/fast/html/details-remove-child-2-expected.txt: * platform/qt/fast/html/details-replace-text-expected.txt: * fast/dom/shadow/create-content-element-expected.txt: Added. * fast/dom/shadow/create-content-element.html: Added. 2011-06-20 MORITA Hajime <morrita@google.com> Reviewed by Dimitri Glazkov. [ShadowContentElement] should layout child whitespace between span. https://bugs.webkit.org/show_bug.cgi?id=62202 NodeRenderingContext::nextRenderer() and previousRenderer() ignored forwarded content tree hierarchies and used render-object hierarchies instead, that caused some wrong Text node rendering. This change uses ShadowContentElement::m_inclusions for the lookup. In this way, these methods can reflect hierarchies of forward light tree. * dom/NodeRenderingContext.cpp: (WebCore::NodeRenderingContext::NodeRenderingContext): (WebCore::nextRendererOf): Added. This traverses content element's children for searching neighboring renderer. (WebCore::previousRendererOf): Added. This traverses content element's children for searching neighboring renderer. (WebCore::NodeRenderingContext::nextRenderer): (WebCore::NodeRenderingContext::previousRenderer): * dom/NodeRenderingContext.h: * dom/ShadowContentElement.h: (ShadowContentElement::inclusionIndexOf): Added. * dom/ShadowContentSelector.cpp: (WebCore::ShadowContentSelector::activeElement): * dom/ShadowContentSelector.h: * dom/ShadowRoot.cpp: (WebCore::ShadowRoot::activeContentElement): * dom/ShadowRoot.h: * rendering/RenderTreeAsText.cpp: (WebCore::externalRepresentation): Fixed an apparent bug introduced at r89230. git-svn-id: http://svn.webkit.org/repository/webkit/trunk@89649 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
ryuan.choi@samsung.com authored
Unreviewed, add myself as committer. * Scripts/webkitpy/common/config/committers.py: git-svn-id: http://svn.webkit.org/repository/webkit/trunk@89648 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
jamesr@google.com authored
Reviewed by Kenneth Russell. [chromium] Fix ownership of PlatformImage for ImageLayerChromiums https://bugs.webkit.org/show_bug.cgi?id=61099 For a composited image, both the ImageLayerChromium and its associated LayerTilerChromium need access to a PlatformImage - the ImageLayerChromium has to update the PlatformImage's contents and the LayerTilerChromium has to upload pixels from it. This patch makes the ImageLayerTextureUpdater have exclusive ownership of the PlatformImage and moves ownership of the LayerTextureUpdater from the LayerTilerChromium to the owner of the tiler. The updater is passed in as a parameter to the relevant tiler calls. Patch also fixes a number of minor style issues (missing explicit keyword on constructor, etc). Refactor only, no new tests. * platform/graphics/chromium/ContentLayerChromium.cpp: (WebCore::ContentLayerPainter::create): (WebCore::ContentLayerPainter::ContentLayerPainter): (WebCore::ContentLayerChromium::paintContentsIfDirty): (WebCore::ContentLayerChromium::createTextureUpdaterIfNeeded): (WebCore::ContentLayerChromium::draw): (WebCore::ContentLayerChromium::createTilerIfNeeded): (WebCore::ContentLayerChromium::updateCompositorResources): * platform/graphics/chromium/ContentLayerChromium.h: * platform/graphics/chromium/ImageLayerChromium.cpp: (WebCore::ImageLayerTextureUpdater::create): (WebCore::ImageLayerTextureUpdater::updateFromImage): (WebCore::ImageLayerTextureUpdater::imageSize): (WebCore::ImageLayerTextureUpdater::ImageLayerTextureUpdater): (WebCore::ImageLayerChromium::~ImageLayerChromium): (WebCore::ImageLayerChromium::paintContentsIfDirty): (WebCore::ImageLayerChromium::updateCompositorResources): (WebCore::ImageLayerChromium::setLayerRenderer): (WebCore::ImageLayerChromium::createTextureUpdaterIfNeeded): (WebCore::ImageLayerChromium::layerBounds): * platform/graphics/chromium/ImageLayerChromium.h: * platform/graphics/chromium/LayerRendererChromium.cpp: (WebCore::LayerRendererChromium::LayerRendererChromium): (WebCore::LayerRendererChromium::updateRootLayerContents): (WebCore::LayerRendererChromium::drawRootLayer): (WebCore::LayerRendererChromium::updateLayers): * platform/graphics/chromium/LayerRendererChromium.h: * platform/graphics/chromium/LayerTextureUpdater.h: (WebCore::LayerTextureUpdater::LayerTextureUpdater): * platform/graphics/chromium/LayerTextureUpdaterCanvas.cpp: (WebCore::LayerTextureUpdaterBitmap::create): (WebCore::LayerTextureUpdaterSkPicture::create): * platform/graphics/chromium/LayerTextureUpdaterCanvas.h: * platform/graphics/chromium/LayerTilerChromium.cpp: (WebCore::LayerTilerChromium::create): (WebCore::LayerTilerChromium::LayerTilerChromium): (WebCore::LayerTilerChromium::prepareToUpdate): (WebCore::LayerTilerChromium::updateRect): (WebCore::LayerTilerChromium::draw): * platform/graphics/chromium/LayerTilerChromium.h: git-svn-id: http://svn.webkit.org/repository/webkit/trunk@89647 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
nduca@chromium.org authored
Unreviewed, add myself as committer. * Scripts/webkitpy/common/config/committers.py: git-svn-id: http://svn.webkit.org/repository/webkit/trunk@89646 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
enne@google.com authored
Unreviewed, rolling out r89632 and r89640. http://trac.webkit.org/changeset/89632 http://trac.webkit.org/changeset/89640 https://bugs.webkit.org/show_bug.cgi?id=60741 Breaks ancestor-overflow-change unexpectedly * compositing/rtl/rtl-absolute-expected.png: Removed. * compositing/rtl/rtl-absolute-expected.txt: Removed. * compositing/rtl/rtl-absolute-overflow-expected.png: Removed. * compositing/rtl/rtl-absolute-overflow-expected.txt: Removed. * compositing/rtl/rtl-absolute-overflow-scrolled-expected.png: Removed. * compositing/rtl/rtl-absolute-overflow-scrolled-expected.txt: Removed. * compositing/rtl/rtl-absolute-overflow-scrolled.html: Removed. * compositing/rtl/rtl-absolute-overflow.html: Removed. * compositing/rtl/rtl-absolute.html: Removed. * compositing/rtl/rtl-fixed-expected.png: Removed. * compositing/rtl/rtl-fixed-expected.txt: Removed. * compositing/rtl/rtl-fixed-overflow-expected.png: Removed. * compositing/rtl/rtl-fixed-overflow-expected.txt: Removed. * compositing/rtl/rtl-fixed-overflow-scrolled-expected.png: Removed. * compositing/rtl/rtl-fixed-overflow-scrolled-expected.txt: Removed. * compositing/rtl/rtl-fixed-overflow-scrolled.html: Removed. * compositing/rtl/rtl-fixed-overflow.html: Removed. * compositing/rtl/rtl-fixed.html: Removed. * compositing/rtl/rtl-iframe-absolute-expected.png: Removed. * compositing/rtl/rtl-iframe-absolute-expected.txt: Removed. * compositing/rtl/rtl-iframe-absolute-overflow-expected.png: Removed. * compositing/rtl/rtl-iframe-absolute-overflow-expected.txt: Removed. * compositing/rtl/rtl-iframe-absolute-overflow-scrolled-expected.png: Removed. * compositing/rtl/rtl-iframe-absolute-overflow-scrolled-expected.txt: Removed. * compositing/rtl/rtl-iframe-absolute-overflow-scrolled.html: Removed. * compositing/rtl/rtl-iframe-absolute-overflow.html: Removed. * compositing/rtl/rtl-iframe-absolute.html: Removed. * compositing/rtl/rtl-iframe-fixed-expected.png: Removed. * compositing/rtl/rtl-iframe-fixed-expected.txt: Removed. * compositing/rtl/rtl-iframe-fixed-overflow-expected.png: Removed. * compositing/rtl/rtl-iframe-fixed-overflow-expected.txt: Removed. * compositing/rtl/rtl-iframe-fixed-overflow-scrolled-expected.png: Removed. * compositing/rtl/rtl-iframe-fixed-overflow-scrolled-expected.txt: Removed. * compositing/rtl/rtl-iframe-fixed-overflow-scrolled.html: Removed. * compositing/rtl/rtl-iframe-fixed-overflow.html: Removed. * compositing/rtl/rtl-iframe-fixed.html: Removed. * compositing/rtl/rtl-iframe-relative-expected.png: Removed. * compositing/rtl/rtl-iframe-relative-expected.txt: Removed. * compositing/rtl/rtl-iframe-relative.html: Removed. * compositing/rtl/rtl-relative-expected.png: Removed. * compositing/rtl/rtl-relative-expected.txt: Removed. * compositing/rtl/rtl-relative.html: Removed. * platform/chromium/test_expectations.txt: * platform/mac/Skipped: 2011-06-23 Adrienne Walker <enne@google.com> Unreviewed, rolling out r89632 and r89640. http://trac.webkit.org/changeset/89632 http://trac.webkit.org/changeset/89640 https://bugs.webkit.org/show_bug.cgi?id=60741 Breaks ancestor-overflow-change unexpectedly * rendering/RenderLayerBacking.cpp: (WebCore::RenderLayerBacking::updateGraphicsLayerGeometry): git-svn-id: http://svn.webkit.org/repository/webkit/trunk@89645 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
commit-queue@webkit.org authored
Reviewed by Ryosuke Niwa. convert editing/deleting/5026848-1.html to dump-as-markup test https://bugs.webkit.org/show_bug.cgi?id=63289 Renamed editing/deleting/5026848* to editing/deleting/delete-across-editable-content-boundaries*, and converted editing/deleting/delete-across-editable-content-boundaries-1 to a dump-as-markup test. Removed old png/txt test results, and added new result. Also included radr number. * editing/deleting/delete-across-editable-content-boundaries-1.html: Added. * editing/deleting/delete-across-editable-content-boundaries-1-expected.txt: Added. * editing/deleting/delete-across-editable-content-boundaries-2.html: Added. * editing/deleting/delete-across-editable-content-boundaries-2-expected.txt: Added. * editing/deleting/delete-across-editable-content-boundaries-3.html: Added. * editing/deleting/delete-across-editable-content-boundaries-3-expected.txt: Added. * editing/deleting/5026848-1.html: Removed. * editing/deleting/5026848-2.html: Removed. * editing/deleting/5026848-2-expected.txt: Removed. * editing/deleting/5026848-3.html: Removed. * editing/deleting/5026848-3-expected.txt: Removed. * platform/chromium-linux/editing/deleting/5026848-1-expected.png: Removed. * platform/chromium-win/editing/deleting/5026848-1-expected.png: Removed. * platform/chromium-win/editing/deleting/5026848-1-expected.txt: Removed. * platform/gtk/editing/deleting/5026848-1-expected.txt: Removed. * platform/mac-leopard/editing/deleting/5026848-1-expected.png: Removed. * platform/mac/editing/deleting/5026848-1-expected.png: Removed. * platform/mac/editing/deleting/5026848-1-expected.txt: Removed. * platform/qt/editing/deleting/5026848-1-expected.png: Removed. * platform/qt/editing/deleting/5026848-1-expected.txt: Removed. git-svn-id: http://svn.webkit.org/repository/webkit/trunk@89644 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
commit-queue@webkit.org authored
Reviewed by Gavin Barraclough. DFG non-speculative JIT should have obvious optimizations for GetById and GetByVal https://bugs.webkit.org/show_bug.cgi?id=63173 * dfg/DFGJITCodeGenerator.cpp: (JSC::DFG::JITCodeGenerator::cachedGetById): * dfg/DFGJITCodeGenerator.h: * dfg/DFGNonSpeculativeJIT.cpp: (JSC::DFG::NonSpeculativeJIT::compile): * dfg/DFGSpeculativeJIT.cpp: (JSC::DFG::SpeculativeJIT::compile): git-svn-id: http://svn.webkit.org/repository/webkit/trunk@89643 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
dpranke@chromium.org authored
Reviewed by Tony Chang. nrwt: move http locking code into manager https://bugs.webkit.org/show_bug.cgi?id=63103 * Scripts/webkitpy/layout_tests/layout_package/manager.py: * Scripts/webkitpy/layout_tests/layout_package/worker.py: git-svn-id: http://svn.webkit.org/repository/webkit/trunk@89642 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-