1. 01 Mar, 2008 2 commits
    • weinig@apple.com's avatar
      WebCore: · 4ba897c4
      weinig@apple.com authored
              Reviewed by Darin Adler.
      
              Search the entire prototype chain when doing early prototype lookup in
              the Window's getOwnPropertySlot method.
      
              Makes fast/dom/Window/window-function-name-getter-precedence.html pass all tests.
      
              * bindings/js/kjs_window.cpp:
              (KJS::Window::getOwnPropertySlot):
      
      LayoutTests:
      
              Reviewed by Darin Adler.
      
              Update test result.
      
              * fast/dom/Window/window-function-name-getter-precedence-expected.txt:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@30696 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      4ba897c4
    • zimmermann@webkit.org's avatar
      Reviewed by Oliver. · 6238d76f
      zimmermann@webkit.org authored
      Fixes: http://bugs.webkit.org/show_bug.cgi?id=17568 (SVGForeignObjectElement can't react to width/height SVG DOM changes)
      
      As the bug title says, fix all dynamic update problems that occour with SVGForeignObjectElement.
      
      Tests: svg/dynamic-updates/SVGForeignObjectElement-dom-height-attr.html
      	   svg/dynamic-updates/SVGForeignObjectElement-dom-width-attr.html
      	   svg/dynamic-updates/SVGForeignObjectElement-dom-x-attr.html
      	   svg/dynamic-updates/SVGForeignObjectElement-dom-y-attr.html
      	   svg/dynamic-updates/SVGForeignObjectElement-svgdom-height-prop.html
      	   svg/dynamic-updates/SVGForeignObjectElement-svgdom-width-prop.html
      	   svg/dynamic-updates/SVGForeignObjectElement-svgdom-x-prop.html
      	   svg/dynamic-updates/SVGForeignObjectElement-svgdom-y-prop.html
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@30695 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      6238d76f
  2. 29 Feb, 2008 34 commits
    • beidson@apple.com's avatar
      Reviewed by build-fix karma · 43e8eb12
      beidson@apple.com authored
              Bonehead mistake.  Revert function to previous version for all non-Windows+CFNetwork platforms
      
              * platform/network/ProtectionSpace.cpp:
              (WebCore::ProtectionSpace::receivesCredentialSecurely): Make my previous change conditionally
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@30692 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      43e8eb12
    • mrowe@apple.com's avatar
      Update Tiger version of WebKitSystemInterface to match r30690. · 62398508
      mrowe@apple.com authored
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@30691 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      62398508
    • adele@apple.com's avatar
      Reviewed by Mark. · 4408767e
      adele@apple.com authored
              Auto-generate image arrays.
      
              * libWebKitSystemInterfaceLeopard.a:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@30690 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      4408767e
    • beidson@apple.com's avatar
      Reviewed by Darin · f2f7a395
      beidson@apple.com authored
              
              <rdar://problem/5771227> - Incorrect password handling text in credential sheet
      
              * platform/network/ProtectionSpace.cpp:
              (WebCore::ProtectionSpace::receivesCredentialSecurely): Call functional CFNetwork method to 
                get "secureness" of the auth challenge instead of figuring it out ourselves
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@30689 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      f2f7a395
    • mitz@apple.com's avatar
      Rubber-stamped by Sam Weinig. · 847345ef
      mitz@apple.com authored
              - update test results following r30649
      
              * svg/css/getComputedStyle-basic-expected.txt:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@30688 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      847345ef
    • pewtermoose@webkit.org's avatar
      2008-02-29 Brent Fulgham <bfulgham@gmail.com> · 47891e82
      pewtermoose@webkit.org authored
      JavaScriptCore:
      
              http://bugs.webkit.org/show_bug.cgi?id=17483
              Implement scrollbars on Windows (Cairo)
      
              Reviewed by Adam Roben.
      
              * wtf/Platform.h:
      
      WebCore:
      
              http://bugs.webkit.org/show_bug.cgi?id=17483
              Implement scrollbars on Windows (Cairo)
      
              Reviewed by Adam Roben.
      
              * platform/win/PlatfromScrollBarWin.cpp: Duplicate implementation
                from PlatformScrollBarWinSafari.cpp, then modify to use the
                native Windows theme engine.  Use SOFT_LINK.  Use platform
                'GetSystemMetrics' call to decide size of scrollbars and buttons.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@30687 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      47891e82
    • aroben@apple.com's avatar
      Delete an unused file · dbfa20e3
      aroben@apple.com authored
              Rubberstamped by Brady.
      
              * Interfaces/IWebScriptScope.idl: Removed.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@30685 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      dbfa20e3
    • aroben@apple.com's avatar
      Change WebPreferences to be backed by CFPreferences · f05ba60f
      aroben@apple.com authored
              Reviewed by Ada, Geoff, Steve, and Darin.
      
              * WebPreferenceKeysPrivate.h:
              * WebPreferences.cpp:
              (WebPreferences::sharedStandardPreferences): Changed to call
              setAutoSaves(TRUE) before calling load(). This ensures that the
              preferences being migrated to CFPreferences are saved to disk.
              (WebPreferences::valueForKey): Changed to return a RetainPtr to ensure
              that the refcount is managed properly. Now attempts to retrieve a
              value from CFPreferences before falling back to the default settings.
              (WebPreferences::setValueForKey): Now saves the value in
              CFPreferences if m_autoSaves is true.
              (WebPreferences::stringValueForKey): Updated for valueForKey changes.
              (WebPreferences::integerValueForKey): DItto.
              (WebPreferences::boolValueForKey): Ditto.
              (WebPreferences::floatValueForKey): Ditto.
              (WebPreferences::save): Now simply calls CFPreferencesAppSynchronize.
              (WebPreferences::load): Always initializes m_privatePrefs to an empty
              CFMutableDictionary.
              (WebPreferences::migrateWebKitPreferencesToCFPreferences): Migrates
              preferences from our old custom plist to CFPreferences and then
              deletes our custom plist, if the migration has never occurred before.
              (WebPreferences::copyWebKitPreferencesToCFPreferences): Copies
              preferences to CFPreferences. If we've never migrated the default
              settings from Safari 3 Beta before, we omit them from this copying
              procedure.
              * WebPreferences.h:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@30684 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      f05ba60f
    • aroben@apple.com's avatar
      Refactor value <-> CFNumber conversions into some helper functions · 24a7b69d
      aroben@apple.com authored
              Reviewed by Jon.
      
              * WebPreferences.cpp:
              (preferencesPath): Changed to return a const String&.
              (numberValueForPreferencesValue): Converts a value from preferences to
              a native numeric type.
              (cfNumber): Converts a native numeric value to a CFNumberRef.
              (booleanValueForPreferencesValue): Converts a value from preferences
              to a native boolean.
              (WebPreferences::integerValueForKey): Changed to call
              numberValueForPreferencesValue.
              (WebPreferences::floatValueForKey): Ditto.
              (WebPreferences::boolValueForKey): Changed to call
              booleanValueForPreferencesValue.
              (WebPreferences::setIntegerValue): Changed to call cfNumber.
              (WebPreferences::setLongLongValue): Ditto.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@30683 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      24a7b69d
    • aroben@apple.com's avatar
      Add WebPreferences::setValueForKey · 21c57934
      aroben@apple.com authored
              This is just a small refactoring of some duplicated logic into a
              shared method.
      
              Reviewed by Sam.
      
              * WebPreferences.cpp:
              (WebPreferences::setValueForKey): Added.
              (WebPreferences::setStringValue): Call setValueForKey.
              (WebPreferences::setIntegerValue): Ditto.
              (WebPreferences::setBoolValue): Ditto.
              (WebPreferences::setLongLongValue): Ditto.
              * WebPreferences.h:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@30682 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      21c57934
    • aroben@apple.com's avatar
      Remove WebPreferences' static members · b4f56e30
      aroben@apple.com authored
              s_defaultSettings is now a file-level static, and
              s_standardPreferences has been removed completely (it wasn't being
              used).
      
              Reviewed by Sam.
      
              * WebPreferences.cpp:
              (WebPreferences::initializeDefaultSettings):
              (WebPreferences::valueForKey):
              (WebPreferences::migrateDefaultSettingsFromSafari3Beta):
              (WebPreferences::removeValuesMatchingDefaultSettings):
              * WebPreferences.h:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@30681 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      b4f56e30
    • aroben@apple.com's avatar
      Windows build fix · 18a9e11f
      aroben@apple.com authored
              * WebCore.vcproj/WebCore.vcproj: Remove bridge/* from the include path
              and the post-build event, and add page/win to each. Also let VS have
              its way with the order of the files.
              * page/win/PageWin.cpp: Copied from bridge/win/PageWin.cpp in r30673
              * page/win/GlobalHistoryWin.cpp: Copied from
              bridge/win/GlobalHistoryWin.cpp in r30673
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@30680 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      18a9e11f
    • aroben@apple.com's avatar
      Remove unused DebuggerImp::abort and DebuggerImp::aborted · fa67fca9
      aroben@apple.com authored
              Reviewed by Tim and Sam.
      
              * kjs/function_object.cpp:
              (KJS::FunctionObjectImp::construct):
              * kjs/internal.h:
              (KJS::DebuggerImp::DebuggerImp):
              * kjs/nodes.cpp:
              (KJS::Node::handleException):
              (KJS::FunctionBodyNodeWithDebuggerHooks::execute):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@30679 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      fa67fca9
    • andersca@apple.com's avatar
      Build fix. · 1e3786a9
      andersca@apple.com authored
              * WebCore.xcodeproj/project.pbxproj:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@30678 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      1e3786a9
    • ggaren@apple.com's avatar
      Reviewed by David Harrison. · ce42daec
      ggaren@apple.com authored
              
              Fixed <rdar://problem/5765063> TOT REGRESSION: Software Update crash in
              KJS::Collector::collect() (missing JSLock)
      
              * JSValueWrapper.cpp:
              (unprotectGlobalObject): Added missing JSLock.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@30677 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      ce42daec
    • mrowe@apple.com's avatar
      2008-02-29 Mark Rowe <mrowe@apple.com> · ec839c97
      mrowe@apple.com authored
              Reviewed by Tim Hatcher.
      
              64-bit build fix.
      
              * platform/graphics/mac/SimpleFontDataMac.mm:
              (WebCore::pathFromFont): Provide stub implementation of pathFromFont for 64-bit as
              FMGetATSFontRefFromFont is not available.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@30676 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      ec839c97
    • mrowe@apple.com's avatar
    • andersca@apple.com's avatar
      Reviewed by Adam. · 80c66848
      andersca@apple.com authored
              
              Copy the remaining files in bridge/ over to page/
      
              * WebCore.vcproj/WebCore.vcproj:
              * WebCore.xcodeproj/project.pbxproj:
              * bridge: Removed.
              * bridge/AXObjectCache.h: Removed.
              * bridge/EditorClient.h: Removed.
              * bridge/GlobalHistory.h: Removed.
              * bridge/win: Removed.
              * bridge/win/FrameCGWin.cpp: Removed.
              * bridge/win/FrameCairoWin.cpp: Removed.
              * bridge/win/FrameWin.cpp: Removed.
              * bridge/win/FrameWin.h: Removed.
              * bridge/win/GlobalHistoryWin.cpp: Removed.
              * bridge/win/PageWin.cpp: Removed.
              * page/AXObjectCache.h: Copied from bridge/AXObjectCache.h.
              * page/EditorClient.h: Copied from bridge/EditorClient.h.
              * page/GlobalHistory.h: Copied from bridge/GlobalHistory.h.
              * page/win/FrameCGWin.cpp: Copied from bridge/win/FrameCGWin.cpp.
              * page/win/FrameCairoWin.cpp: Copied from bridge/win/FrameCairoWin.cpp.
              * page/win/FrameWin.cpp: Copied from bridge/win/FrameWin.cpp.
              * page/win/FrameWin.h: Copied from bridge/win/FrameWin.h.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@30674 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      80c66848
    • mrowe@apple.com's avatar
      2008-02-29 Robert Blaut <webkit@blaut.biz> · 94335d6c
      mrowe@apple.com authored
              Reviewed by Darin Adler.
      
              - fix http://bugs.webkit.org/show_bug.cgi?id=17532
                Webkit imports styles from <link> element which doesn't have rel=stylesheet defined
      
              Test: fast/html/link-rel-stylesheet.html
      
              * html/HTMLLinkElement.cpp:
              (WebCore::HTMLLinkElement::process):
      
      2008-02-29  Robert Blaut  <webkit@blaut.biz>
      
              Reviewed by Darin Adler.
      
              - Tests for http://bugs.webkit.org/show_bug.cgi?id=17532
                Webkit imports styles from <link> element which doesn't have rel=stylesheet defined
      
              * fast/html/link-rel-stylesheet.html: Added.
              * fast/media/mq-simple-query-02.html:
              * fast/media/mq-width-absolute-02.html:
              * platform/mac/fast/html/link-rel-stylesheet-expected.txt: Added.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@30673 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      94335d6c
    • mrowe@apple.com's avatar
      2008-02-29 Mark Rowe <mrowe@apple.com> · 68c3ec16
      mrowe@apple.com authored
              Reviewed by Anders Carlsson.
      
              Replace use of WKPathFromFont with implementation in terms of public API.
      
              * WebCore.base.exp: Remove unused symbol.
              * platform/graphics/mac/SimpleFontDataMac.mm:
              (WebCore::initFontData):
              (WebCore::pathFromFont): Implement pathFromFont in terms of public API.
              (WebCore::SimpleFontData::platformInit):
              * platform/mac/WebCoreSystemInterface.h: Remove unused symbol.
              * platform/mac/WebCoreSystemInterface.mm: Ditto.
      
      2008-02-29  Mark Rowe  <mrowe@apple.com>
      
              Reviewed by Anders Carlsson.
      
              Replace use of WKPathFromFont with implementation in terms of public API.
      
              * WebCoreSupport/WebSystemInterface.m:
              (InitWebCoreSystemInterface): Remove unused symbol.
      
      2008-02-29  Mark Rowe  <mrowe@apple.com>
      
              Reviewed by Anders Carlsson.
      
              Replace use of WKPathFromFont with implementation in terms of public API.
      
              * WebKitSystemInterface.h:  Remove unused symbol.
              * libWebKitSystemInterfaceLeopard.a:
              * libWebKitSystemInterfaceTiger.a:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@30672 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      68c3ec16
    • andersca@apple.com's avatar
      Reviewed by Adam. · a800c8f0
      andersca@apple.com authored
              Move a bunch of files from bridge/mac to page/mac.
              
              * WebCore.xcodeproj/project.pbxproj:
              * bridge/mac: Removed.
              * bridge/mac/AXObjectCacheMac.mm: Removed.
              * bridge/mac/GlobalHistoryMac.mm: Removed.
              * bridge/mac/WebCoreAXObject.h: Removed.
              * bridge/mac/WebCoreAXObject.mm: Removed.
              * bridge/mac/WebCoreScriptDebugger.h: Removed.
              * bridge/mac/WebCoreScriptDebugger.mm: Removed.
              * page/mac/AXObjectCacheMac.mm: Copied from bridge/mac/AXObjectCacheMac.mm.
              * page/mac/GlobalHistoryMac.mm: Copied from bridge/mac/GlobalHistoryMac.mm.
              * page/mac/WebCoreAXObject.h: Copied from bridge/mac/WebCoreAXObject.h.
              * page/mac/WebCoreAXObject.mm: Copied from bridge/mac/WebCoreAXObject.mm.
              * page/mac/WebCoreScriptDebugger.h: Copied from bridge/mac/WebCoreScriptDebugger.h.
              * page/mac/WebCoreScriptDebugger.mm: Copied from bridge/mac/WebCoreScriptDebugger.mm.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@30671 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      a800c8f0
    • hyatt@apple.com's avatar
      Fix for http://bugs.webkit.org/show_bug.cgi?id=17559, media query tests crashing under · b307f177
      hyatt@apple.com authored
              guard malloc.  Pass along the style selector so it can be accessed, since it has not yet
              been assigned into the document's member variable.
      
              Reviewed by aroben
      
              * css/CSSStyleSelector.cpp:
              (WebCore::CSSRuleSet::addRulesFromSheet):
              * css/MediaQueryEvaluator.cpp:
              (WebCore::MediaQueryEvaluator::eval):
              * css/MediaQueryEvaluator.h:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@30670 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      b307f177
    • sfalken@apple.com's avatar
      Don't free the VARIANT passed into Write, since it is an input... · 7499dd5a
      sfalken@apple.com authored
              Don't free the VARIANT passed into Write, since it is an input parameter owned by the caller.
              Found via code inspection.
              
              Reviewed by Adam.
      
              * WebActionPropertyBag.cpp:
              (WebActionPropertyBag::Write):
              * WebElementPropertyBag.cpp:
              (WebElementPropertyBag::Write):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@30669 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      7499dd5a
    • ddkilzer@apple.com's avatar
      Pass the correct configuration switch (--Debug|--Release) to build-testkjs. · 39912847
      ddkilzer@apple.com authored
              Reviewed by Dan.
      
              Originally broken in r26838.
      
              * Scripts/run-javascriptcore-tests: Push configuration switch onto @xcodeArgs
              not local, unused @args variable.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@30668 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      39912847
    • hyatt@apple.com's avatar
      <rdar://problem/5755916> REGRESSION: Loading HTML5 spec is 5x slower on TOT than in 3.0.4 · 723eb352
      hyatt@apple.com authored
              Improve the performance of dynamic sibling and CSS3 selectors so that there is no slowdown any more.
              Be more precise in terms of what nodes we mark dirty.
      
              Reviewed by Beth
      
              * css/CSSStyleSelector.cpp:
              (WebCore::CSSStyleSelector::checkSelector):
              * dom/Element.cpp:
              (WebCore::Element::recalcStyle):
              (WebCore::checkForSiblingStyleChanges):
              (WebCore::Element::childrenChanged):
              (WebCore::Element::finishParsingChildren):
              * rendering/RenderStyle.cpp:
              (WebCore::RenderStyle::RenderStyle):
              * rendering/RenderStyle.h:
              (WebCore::RenderStyle::childrenAffectedByPositionalRules):
              (WebCore::RenderStyle::childrenAffectedByDirectAdjacentRules):
              (WebCore::RenderStyle::setChildrenAffectedByDirectAdjacentRules):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@30667 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      723eb352
    • ddkilzer@apple.com's avatar
      Bug 15754: webarchive layout tests fail when WebKit directory path contains symlinks · 5e749f4b
      ddkilzer@apple.com authored
              <http://bugs.webkit.org/show_bug.cgi?id=15754>
      
              Reviewed by Geoff and Darin.
      
              We were using -[NSFileManager currentDirectoryPath] to get the current working directory,
              then removing that path from all file:/// URLs in the WebArchive output so these tests
              would pass no matter where they were run.
      
              The problem was that -[NSFileManager currentDirectoryPath] resolves symlinks in the
              current working directory, but the WebArchive does not.  This left the current working
              directory in all file:/// URLs in the test output, and thus all tests failed, for any
              developer that used symlinks to get to their WebKit source directory.
      
              The fix is to look backwards for "/LayoutTests/" in the URL we're passed, and simply
              remove the current working directory path (no matter what it is) after "file://" but
              before "/LayoutTests/".  
      
              * DumpRenderTree/mac/DumpRenderTree.mm:
              (normalizeWebResourceURL): Removed unused oldURLBase argument.  We now replace the
              current working directory as described above.
              (convertWebResourceResponseToDictionary): Remove unused oldURLBase argument.  Update
              calls to normalizeWebResourceURL().
              (serializeWebArchiveToXML): Removed now unused cwdURL variable.  Update calls to
              normalizeWebResourceURL() and convertWebResourceResponseToDictionary().
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@30666 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      5e749f4b
    • ap@webkit.org's avatar
      Reviewed by Darin. · 5b6da2c5
      ap@webkit.org authored
              <rdar://problem/5766352> REGRESSION (r27151): XMLHttpRequest.abort() resets response status
      
              Test: http/tests/xmlhttprequest/status-after-abort.html
      
              * xml/XMLHttpRequest.cpp:
              (WebCore::XMLHttpRequest::getStatus):
              (WebCore::XMLHttpRequest::getStatusText):
              Changed to match Firefox more closely (IE just raises an exception in most of those cases).
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@30665 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      5b6da2c5
    • mitz@apple.com's avatar
      WebCore: · 6fa3cd2c
      mitz@apple.com authored
              Reviewed by Darin Adler.
      
              - fix a bug where explicit embedding past the end of a line could
                affect text that line
      
              Test: fast/text/embed-at-end-of-pre-wrap-line.html
      
              * rendering/bidi.cpp:
              (WebCore::RenderBlock::skipWhitespace): Removed calls to
              setAdjustEmbedding().
              (WebCore::RenderBlock::findNextLineBreak): Added calls to
              setAdjustEmbedding() around skipWhitespace() only where needed.
      
      LayoutTests:
      
              Reviewed by Darin Adler.
      
              - test for a bug where explicit embedding past the end of a line could
                affect text that line
      
              * fast/text/embed-at-end-of-pre-wrap-line.html: Added.
              * platform/mac-leopard/fast/text/embed-at-end-of-pre-wrap-line-expected.checksum: Added.
              * platform/mac-leopard/fast/text/embed-at-end-of-pre-wrap-line-expected.png: Added.
              * platform/mac/fast/text/embed-at-end-of-pre-wrap-line-expected.txt: Added.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@30664 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      6fa3cd2c
    • mrowe@apple.com's avatar
      2008-02-29 Mark Rowe <mrowe@apple.com> · 44223d5d
      mrowe@apple.com authored
              Reviewed by Oliver Hunt.
      
              Fix spelling of "request" in name of WKNSURLProtocolClassForRequest.
      
              * Misc/WebNSURLExtras.mm:
              (-[NSURL _webkit_canonicalize]):
              * WebKit.order:
      
      2008-02-29  Mark Rowe  <mrowe@apple.com>
      
              Reviewed by Oliver Hunt.
      
              Fix spelling of "request" in name of WKNSURLProtocolClassForRequest.
      
              * WebKitSystemInterface.h:
              * libWebKitSystemInterfaceLeopard.a:
              * libWebKitSystemInterfaceTiger.a:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@30662 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      44223d5d
    • mrowe@apple.com's avatar
      2008-02-29 Mark Rowe <mrowe@apple.com> · 81b792ef
      mrowe@apple.com authored
              Reviewed by Oliver Hunt.
      
              Don't use WKSupportsMultipartXMixedReplace on Leopard as multipart/x-mixed-replace is always handled by NSURLRequest.
      
              * platform/mac/WebCoreSystemInterface.h: Don't declare WKSupportsMultipartXMixedReplace on Leopard.
              * platform/mac/WebCoreSystemInterface.mm: Ditto.
              * platform/network/mac/ResourceRequestMac.mm:
              (WebCore::ResourceRequest::doUpdatePlatformRequest): Don't call WKSupportsMultipartXMixedReplace on Leopard.
              * WebCore.Tiger.exp: Move Tiger-only symbol here.
              * WebCore.base.exp:
      
      2008-02-29  Mark Rowe  <mrowe@apple.com>
      
              Reviewed by Oliver Hunt.
      
              Don't use WKSupportsMultipartXMixedReplace on Leopard as multipart/x-mixed-replace is always handled by NSURLRequest.
      
              * WebKitSystemInterface.h:
              * libWebKitSystemInterfaceLeopard.a:
      
      2008-02-29  Mark Rowe  <mrowe@apple.com>
      
              Reviewed by Oliver Hunt.
      
              Don't use WKSupportsMultipartXMixedReplace on Leopard as multipart/x-mixed-replace is always handled by NSURLRequest.
      
              * WebCoreSupport/WebSystemInterface.m:
              (InitWebCoreSystemInterface):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@30661 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      81b792ef
    • mrowe@apple.com's avatar
      2008-02-29 Mark Rowe <mrowe@apple.com> · be150f9f
      mrowe@apple.com authored
              Reviewed by Oliver Hunt.
      
              Remove obsolete code that had been left intact to support users running WebKit with older versions of Safari.
      
              * Misc/WebNSViewExtras.m:  Remove _web_superviewOfClass:stoppingAtClass:.
              * Misc/WebNSWindowExtras.m:  Remove _webkit_displayThrottledWindows.
              * Misc/WebSearchableTextView.m:  Remove selectionImageForcingWhiteText:.
              * WebCoreSupport/WebImageRendererFactory.m:  Update comment to mention the last version of Safari that
              requires this class.
              * WebInspector/WebInspector.mm:  Remove sharedWebInspector and update comments to mention the last version
              of Safari that calls other obsolete methods.
              * WebView/WebDocumentPrivate.h:  Remove selectionImageForcingWhiteText:.
              * WebView/WebHTMLView.mm:  Ditto.
              * WebView/WebPDFView.mm:  Ditto.
              * WebView/WebView.mm:  Update comment to mentoin the last version of Safari that requires the obsolete method.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@30660 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      be150f9f
    • mrowe@apple.com's avatar
      2008-02-29 Mark Rowe <mrowe@apple.com> · 9022f9ae
      mrowe@apple.com authored
              Rubber-stamped by Eric Seidel.
      
              Remove unneeded includes of WebCoreSystemInterface.h.
      
              * loader/mac/LoaderNSURLExtras.m:
              * page/mac/FrameMac.mm:
              * page/mac/WebCoreFrameBridge.mm:
              * platform/MIMETypeRegistry.cpp:
              * platform/graphics/mac/ImageMac.mm:
              * platform/mac/PasteboardMac.mm:
      
      2008-02-29  Mark Rowe  <mrowe@apple.com>
      
              Rubber-stamped by Eric Seidel.
      
              Remove unneeded includes of WebKitSystemInterface.h.
      
              * History/WebHistoryItem.mm:
              * Misc/WebNSViewExtras.m:
              * WebCoreSupport/WebFrameLoaderClient.mm:
              * WebView/WebDataSource.mm:
              * WebView/WebPDFView.mm:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@30659 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      9022f9ae
    • mrowe@apple.com's avatar
      2008-02-29 Mark Rowe <mrowe@apple.com> · b7226d3d
      mrowe@apple.com authored
              Reviewed by Oliver Hunt and Oliver Hunt.
      
              <rdar://problem/4753845> WebKit should use CGEventSourceSecondsSinceLastEventType in place of WKSecondsSinceLastInputEvent SPI.
      
              * platform/mac/SystemTimeMac.cpp:  Replace use of WKSecondsSinceLastInputEvent with CGEventSourceSecondsSinceLastEventType.
              * platform/mac/WebCoreSystemInterface.h:  Remove unused symbol.
              * platform/mac/WebCoreSystemInterface.mm:  Ditto.
              * WebCore.base.exp:  Ditto.
      
      2008-02-29  Mark Rowe  <mrowe@apple.com>
      
              Reviewed by Oliver Hunt and Oliver Hunt.
      
              <rdar://problem/4753845> WebKit should use CGEventSourceSecondsSinceLastEventType in place of WKSecondsSinceLastInputEvent SPI.
      
              * WebCoreSupport/WebSystemInterface.m:
              (InitWebCoreSystemInterface):  Remove unused symbol.
              * WebKit.order:  Ditto.
      
      2008-02-29  Mark Rowe  <mrowe@apple.com>
      
              Reviewed by Oliver Hunt and Oliver Hunt.
      
              <rdar://problem/4753845> WebKit should use CGEventSourceSecondsSinceLastEventType in place of WKSecondsSinceLastInputEvent SPI.
      
              * WebKitSystemInterface.h:  Remove unused symbol.
              * libWebKitSystemInterfaceLeopard.a:
              * libWebKitSystemInterfaceTiger.a:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@30658 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      b7226d3d
    • mrowe@apple.com's avatar
      2008-02-28 Mark Rowe <mrowe@apple.com> · 043f50b1
      mrowe@apple.com authored
              Reviewed by Dan Bernstein.
      
              Remove two unused functions from WebKitSystemInterface.
      
              * WebKitSystemInterface.h:  Remove WKPreferRGB32Key and WKGetDefaultGlyphForChar as they are unused. Also remove
              a duplicate declaration of WKSecondsSinceLastInputEvent.
              * libWebKitSystemInterfaceLeopard.a:
              * libWebKitSystemInterfaceTiger.a:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@30657 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      043f50b1
  3. 28 Feb, 2008 4 commits
    • mrowe@apple.com's avatar
      2008-02-28 Mark Rowe <mrowe@apple.com> · 3d5e1528
      mrowe@apple.com authored
              Reviewed by Dave Hyatt.
      
              Make use of new CGFont APIs on Leopard rather than making a WebKitSystemInterface call.
      
              * DerivedSources.make:  Add Tiger-only symbols to the export file when running on Tiger.
              * WebCore.Tiger.exp:  Added.  Move Tiger-only symbol here from WebCore.base.exp.
              * WebCore.base.exp:
              * platform/graphics/mac/SimpleFontDataMac.mm:
              (WebCore::SimpleFontData::platformInit):  Use Leopard APIs when building on Leopard.
              * platform/mac/WebCoreSystemInterface.h:  Don't declare wkGetFontMetrics on Leopard as it is unused.
              * platform/mac/WebCoreSystemInterface.mm:  Ditto.
      
      2008-02-28  Mark Rowe  <mrowe@apple.com>
      
              Reviewed by Dave Hyatt.
      
              Make use of new CGFont APIs on Leopard rather than making a WebKitSystemInterface call.
      
              * WebKitSystemInterface.h:  Only declare WKGetFontMetrics on Tiger.
              * libWebKitSystemInterfaceLeopard.a:  Update for removal of WKGetFontMetrics.
      
      2008-02-28  Mark Rowe  <mrowe@apple.com>
      
              Reviewed by Dave Hyatt.
      
              Make use of new CGFont APIs on Leopard rather than making a WebKitSystemInterface call.
      
              * WebCoreSupport/WebSystemInterface.m:
              (InitWebCoreSystemInterface): Only initialize wkGetFontMetrics on Tiger.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@30656 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      3d5e1528
    • pewtermoose@webkit.org's avatar
      Reviewed by Tim Hatcher. · 6228e139
      pewtermoose@webkit.org authored
              Bug 16535: Stylesheets loaded with @import are not editable
              http://bugs.webkit.org/show_bug.cgi?id=16535
              <rdar://problem/5712899>
      
              Sheets loaded using @import were incorrectly being flagged as non-editable
              user agent sheets because their parent sheet doesn't have an ownerNode. We now
              check to make sure sheets also don't have a href before restricting their editability.
      
              * page/inspector/StylesSidebarPane.js:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@30654 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      6228e139
    • ggaren@apple.com's avatar
      Reviewed by Geoffrey Garen. · 925b7ed4
      ggaren@apple.com authored
              ** TOTAL **:          1.005x as fast    2867.6ms +/- 0.4%  2853.2ms +/- 0.3%    significant
      
              * kjs/nodes.cpp: Tell the compiler that exceptions are unexpected (for
              the sake of branch prediction and code organization).
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@30651 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      925b7ed4
    • pewtermoose@webkit.org's avatar
      2008-02-28 Rodney Dawes <dobey@wayofthemonkey.com> · fa3bc3f4
      pewtermoose@webkit.org authored
      
              Reviewed by Adam Roben.
      
              Copy PluginPackageWin.cpp to shared PluginPackage.cpp.
              Add PluginPackage.cpp to build configurations.
              Remove PluginPackage destructor from TemporaryLinkStubs.cpp.
              Use cross-platform pathGetFilename method.
              Remove platform-specific code from shared PluginPackage implementation.
              Remove shared code from PluginPackageWin.cpp.
      
              * GNUmakefile.am:
              * WebCore.pro:
              * WebCoreSources.bkl:
              * WebCore.vcproj/WebCore.vcproj:
              * platform/gtk/TemporaryLinkStubs.cpp:
              * platform/qt/TemporaryLinkStubs.cpp:
              * platform/wx/TemporaryLinkStubs.cpp:
              * plugins/PluginPackage.cpp:
              * plugins/win/PluginPackageWin.cpp:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@30650 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      fa3bc3f4