1. 20 May, 2010 1 commit
  2. 19 May, 2010 3 commits
  3. 18 May, 2010 8 commits
    • tkent@chromium.org's avatar
      [DRT/Chromium] Fix a repaint issue and textarea tests · d31b2683
      tkent@chromium.org authored
      https://bugs.webkit.org/show_bug.cgi?id=39054
      
      Reviewed by Dimitri Glazkov.
      
      WebKit/chromium:
      
      * DEPS: Update to Chromium r47248 to use a fix for CommandLine assertion
        and textAreaResizeCorner.png
      * WebKit.gyp: Add textAreaResizeCorner.png as a Mac resource
      
      WebKitTools:
      
      * DumpRenderTree/chromium/WebViewHost.cpp:
      (WebViewHost::canvas): Remove m_paintRect initialization in canvas().
       This line updated m_paintRect unexpectedly during paintRect().
       We don't need to initialize m_paintRect because show() does it.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@59744 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      d31b2683
    • tony@chromium.org's avatar
      2010-05-18 Tony Chang <tony@chromium.org> · 15099a32
      tony@chromium.org authored
              Reviewed by Kent Tamura.
      
              [chromium] new-run-webkit-tests --use-drt should run on Linux
              https://bugs.webkit.org/show_bug.cgi?id=37845
      
              * Scripts/webkitpy/layout_tests/port/chromium.py:
              * Scripts/webkitpy/layout_tests/port/chromium_linux.py:
              * Scripts/webkitpy/layout_tests/port/chromium_mac.py:
              * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
              * Scripts/webkitpy/layout_tests/port/chromium_win.py:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@59743 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      15099a32
    • tkent@chromium.org's avatar
      2010-05-18 Kent Tamura <tkent@chromium.org> · 97346b66
      tkent@chromium.org authored
              Reviewed by Dimitri Glazkov.
      
              [DRT/Chromium] Fix some initialization/reset issues
              https://bugs.webkit.org/show_bug.cgi?id=39281
      
              * DumpRenderTree/chromium/LayoutTestController.cpp:
              (LayoutTestController::reset): Reset m_userStyleSheetLocation.
              * DumpRenderTree/chromium/LayoutTestController.h:
                Remove unused variable, m_workQueueFrozen.
              (LayoutTestController::WorkQueue::WorkQueue): Initialize m_frozen.
              * DumpRenderTree/chromium/TestShell.cpp:
              (TestShell::resetTestController): Reset WebSettings too.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@59737 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      97346b66
    • dpranke@chromium.org's avatar
      2010-05-18 Dirk Pranke <dpranke@chromium.org> · 81d805cb
      dpranke@chromium.org authored
              Reviewed by Ojan Vafai.
      
              new-run-webkit-tests: implement '--reset-results' flag to complement
              the '--new-baseline' flag. '--new-baseline' will always write the
              results into the platform directory; '--reset-results' will update the
              existing baseline wherever it happens to be. Both sets of behavior
              are useful in different circumstances.
      
              https://bugs.webkit.org/show_bug.cgi?id=38879
      
              * Scripts/webkitpy/layout_tests/data/image/canvas-bg.html: Added.
              * Scripts/webkitpy/layout_tests/data/image/canvas-zoom-expected.checksum: Added.
              * Scripts/webkitpy/layout_tests/data/image/canvas-zoom-expected.png: Added.
              * Scripts/webkitpy/layout_tests/data/image/canvas-zoom-expected.txt: Added.
              * Scripts/webkitpy/layout_tests/data/image/canvas-zoom.html: Added.
              * Scripts/webkitpy/layout_tests/data/misc/crash-expected.txt: Added.
              * Scripts/webkitpy/layout_tests/data/misc/crash.html: Added.
              * Scripts/webkitpy/layout_tests/data/misc/missing-expectation.html: Added.
              * Scripts/webkitpy/layout_tests/data/misc/passing-expected.txt: Added.
              * Scripts/webkitpy/layout_tests/data/misc/passing.html: Added.
              * Scripts/webkitpy/layout_tests/data/platform/test/image/canvas-bg-expected.checksum: Added.
              * Scripts/webkitpy/layout_tests/data/platform/test/image/canvas-bg-expected.png: Added.
              * Scripts/webkitpy/layout_tests/data/platform/test/image/canvas-bg-expected.txt: Added.
              * Scripts/webkitpy/layout_tests/data/platform/test/test_expectations.txt: Added.
              * Scripts/webkitpy/layout_tests/data/text/article-element-expected.txt: Added.
              * Scripts/webkitpy/layout_tests/data/text/article-element.html: Added.
              * Scripts/webkitpy/layout_tests/layout_package/test_expectations_unittest.py:
              * Scripts/webkitpy/layout_tests/port/test.py:
              * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
              * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
              * Scripts/webkitpy/layout_tests/layout_package/printing_unittest.py:
              * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
              * Scripts/webkitpy/layout_tests/test_types/image_diff.py:
              * Scripts/webkitpy/layout_tests/test_types/test_type_base.py:
              * Scripts/webkitpy/layout_tests/test_types/text_diff.py:
              * Scripts/webkitpy/layout_tests/port/test.py:
              * Scripts/webkitpy/layout_tests/port/dryrun.py:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@59725 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      81d805cb
    • eric@webkit.org's avatar
      2010-05-18 Eric Seidel <eric@webkit.org> · c32e5c3a
      eric@webkit.org authored
              Reviewed by Adam Roben.
      
              Add an --html5-parser option to DumpRenderTree to allow testing the new HTML5Lexer
              https://bugs.webkit.org/show_bug.cgi?id=39311
      
              This flag allows us to run the new HTML5Lexer code.
              Right now all documents parse as empty documents, but
              now that we're able to run the code we can fix that.
      
              Once we're able to lex a few basic documents I'll add
              an --html5-parser flag to run-webkit-tests so that we test
              running all of the layout tests with the HTML5 parser.
      
              * DumpRenderTree/mac/DumpRenderTree.mm:
              (resetDefaultsToConsistentValues):
              (initializeGlobalsFromCommandLineOptions):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@59687 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      c32e5c3a
    • hausmann@webkit.org's avatar
      [Qt] Fix http/tests/xmlhttprequest/cross-origin-no-authorization.html · d64d36e5
      hausmann@webkit.org authored
      2010-05-08  Robert Hogan  <robert@roberthogan.net>
      
              Reviewed by Simon Hausmann.
      
              [Qt] Fix http/tests/xmlhttprequest/cross-origin-no-authorization.html
                   and http/tests/xmlhttprequest/cross-origin-authorization.html
      
              QHttpNetworkRequest adds Authorization and Cookie headers to XHRs
              without knowing if this is valid behaviour or not. In order to allow
              Qt to decide whether Cookie/Authorization headers should be added
              to an XHR QtWebKit needs to use an attribute added to QNetworkRequest.
              These new attributes are: QNetworkRequest::CookieLoadControlAttribute,
              QNetworkRequest::CookieSaveControlAttribute,and
              QNetworkRequest::AuthenticationReuseControlAttribute.
      
              QtWebKit will set QNetworkRequest::AuthenticationReuseControlAttribute to false
              unless withCredentials is set to true in the XHR.
      
              QtWebkit will set CookieLoad/SaveControlAttribute to false unless withCredentials
              is set to true in the XHR.
      
              Qt will pass the values onto QHttpNetworkRequest and this will permit
              the Qt network access processing to decide whether or not to add either
              or both of the Cookie/Authorisation headers, and whether to save cookies
              returned from such requests. By default the attribute
              will always be true so unless QtWebKit sets it to false normal
              header processing is unaffected.
      
              There are platform-specific results for cross-origin-no-authorization.html:
      
              1. Qt's DRT does not capture the final 'DONE'.
              2. QNetworkReplyHandler.cpp's ignoreHttpError() means that async requests
                 do not execute didFail() when they receive a 401 HTTP response. This
                 results in async tests passing with '401 Authorisation required' rather
                 than 'received error event'.
      
              The Qt part of these changes was merged at: http://gitorious.org/qt/qt/merge_requests/592
      
              In order to properly support the tests, Qt's DRT needs to use one
              NetworkAccessManager for all pages. This allows it to use cached
              credentials where appropriate.
      
              The tests now pass when run individually but there seems to be a problem with
              leaking the results of requests across tests when run with the others in
              http/tests. This will be addressed in a separate patch.
      
              https://bugs.webkit.org/show_bug.cgi?id=32967
      
              * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
              (WebCore::WebPage::WebPage):
              (WebCore::DumpRenderTree::DumpRenderTree):
              * DumpRenderTree/qt/DumpRenderTreeQt.h:
              * platform/network/qt/ResourceRequestQt.cpp:
              (WebCore::ResourceRequest::toNetworkRequest):
              * platform/qt/Skipped: Group together the tests that are waiting for 4.7 to be unskipped.
              * platform/qt/http/tests/xmlhttprequest/cross-origin-no-authorization-expected.txt: Added.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@59669 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      d64d36e5
    • ukai@chromium.org's avatar
      2010-05-18 Fumitoshi Ukai <ukai@chromium.org> · 4a2dce38
      ukai@chromium.org authored
              Reviewed by Eric Seidel.
      
              run_webkit_tests_unittest fails on SnowLeopard
              https://bugs.webkit.org/show_bug.cgi?id=39279
      
              * Scripts/webkitpy/layout_tests/port/base.py:
               Return copy of os.environ.
              * Scripts/webkitpy/layout_tests/port/chromium_win_unittest.py:
               Check os.environ was not modified.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@59666 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      4a2dce38
    • ukai@chromium.org's avatar
      2010-05-18 Fumitoshi Ukai <ukai@chromium.org> · 13b107bb
      ukai@chromium.org authored
              Reviewed by Eric Seidel.
      
              Chromium: new-run-webkit-httpd fails to setup_mount
              https://bugs.webkit.org/show_bug.cgi?id=39257
      
              * Scripts/webkitpy/common/system/executive.py:
               Assert type of args in run_command.
              * Scripts/webkitpy/common/system/executive_unittest.py:
               Add test_run_command_args_type
              * Scripts/webkitpy/layout_tests/port/chromium_win.py:
               Executive.run_command takes array for command line.
              * Scripts/webkitpy/layout_tests/port/chromium_win_unittest.py:
               Test if setup_environ_for_server() run setup_mount.bat.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@59661 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      13b107bb
  4. 17 May, 2010 8 commits
    • tkent@chromium.org's avatar
      Unreviewed. Roll out r59650. · dce59f86
      tkent@chromium.org authored
      A workaround of a buildbot issue triggered by r59650 wasn't resolved by r59646.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@59651 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      dce59f86
    • tkent@chromium.org's avatar
      [DRT/Chromium] Fix repaint, WebGL, textarea tests · 3865d551
      tkent@chromium.org authored
      https://bugs.webkit.org/show_bug.cgi?id=39054
      
      Reviewed by Dimitri Glazkov.
      
      WebKit/chromium:
      
      * DEPS: Update to Chromium r47248 to use a fix for CommandLine assertion
        and textAreaResizeCorner.png
      * WebKit.gyp: Add textAreaResizeCorner.png as a Mac resource
      * features.gypi: Enable ENABLE_3D_CANVAS.
      
      WebKitTools:
      
      * DumpRenderTree/chromium/WebViewHost.cpp:
      (WebViewHost::canvas): Remove m_paintRect initialization in canvas().
       This line updated m_paintRect unexpectedly during paintRect().
       We don't need to initialize m_paintRect because show() does it.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@59650 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      3865d551
    • tkent@chromium.org's avatar
      Chromium Windows build system does not rebuild correctly when · 5fa56bf3
      tkent@chromium.org authored
      enabling/disabling a feature
      https://bugs.webkit.org/show_bug.cgi?id=38926
      
      Reviewed by David Levin.
      
      Add a workaround of this issue.
      
      * Scripts/update-webkit:
        Chromium-Windows only: If WebKit/chromium/features.gyp has been
        updated, remove WebKit/chromium/Debug and WebKit/chromium/Release.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@59646 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      5fa56bf3
    • atwilson@chromium.org's avatar
      2010-05-17 Sheriff Bot <webkit.review.bot@gmail.com> · 10355dd6
      atwilson@chromium.org authored
              Unreviewed, rolling out r59631.
              http://trac.webkit.org/changeset/59631
              https://bugs.webkit.org/show_bug.cgi?id=39255
      
              chromium canaries can no longer run webkit_tests, suspect this
              change. (Requested by atwilson on #webkit).
      
              * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
              * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
              * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@59636 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      10355dd6
    • eric@webkit.org's avatar
      2010-05-17 Eric Seidel <eric@webkit.org> · 19c364c2
      eric@webkit.org authored
              Reviewed by Adam Barth.
      
              Attempt to make new-run-webkit-tests --help more sane
              https://bugs.webkit.org/show_bug.cgi?id=37836
      
              * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
               - Add a FIXME about options.singly and options.batch_size being different.
              * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
               - Add support for hidden options.
               - Add option groupings to attempt to simplify --help.
               - Fix a bunch of option helps to start with a capitalized verb.
               - Hide a bunch of options which make no sense to users.
               - Sort options in --help.
              * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
               - Add tests for option sorting.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@59631 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      19c364c2
    • robert@webkit.org's avatar
      2010-05-17 Robert Hogan <robert@webkit.org> · d08c8d81
      robert@webkit.org authored
              Reviewed by Kenneth Rohde Christiansen.
      
              [Qt] Disable Icon Database by default in Qt DRT
      
              Unskip:
               http/tests/misc/favicon-loads-with-images-disabled.html
               http/tests/security/XFrameOptions/x-frame-options-deny-meta-tag-in-body.html
               http/tests/security/XFrameOptions/x-frame-options-deny-meta-tag-parent-same-origin-deny.html
               http/tests/security/XFrameOptions/x-frame-options-deny-meta-tag.html
      
              Qt returns 5 (QNetworkReply::OperationCanceledError) instead of -999 for the XFrameOptions tests,
              so update accordingly.
      
              https://bugs.webkit.org/show_bug.cgi?id=37382
      
              * platform/qt/Skipped:
              * platform/qt/http/tests/security/XFrameOptions/x-frame-options-deny-meta-tag-expected.txt: Added. Qt returns 5 instead of -999.
              * platform/qt/http/tests/security/XFrameOptions/x-frame-options-deny-meta-tag-in-body-expected.txt: Added. Qt returns 5 instead of -999.
              * platform/qt/http/tests/security/XFrameOptions/x-frame-options-deny-meta-tag-parent-same-origin-deny-expected.txt: Added. Qt returns 5 instead of -999.
      2010-05-17  Robert Hogan  <robert@webkit.org>
      
              Reviewed by Kenneth Rohde Christiansen.
      
              [Qt] Disable Icon Database by default in Qt DRT
      
              Unskip:
               http/tests/misc/favicon-loads-with-images-disabled.html
               http/tests/security/XFrameOptions/x-frame-options-deny-meta-tag-in-body.html
               http/tests/security/XFrameOptions/x-frame-options-deny-meta-tag-parent-same-origin-deny.html
               http/tests/security/XFrameOptions/x-frame-options-deny-meta-tag.html
      
              https://bugs.webkit.org/show_bug.cgi?id=37382
      
              Add support for layoutTestController.setIconDatabaseEnabled and layoutTestController.disableImageLoading().
              The XFrameOptions tests were failing because of an extra resource load callback for favicon.ico requests.
              These extra callbacks are removed by supporting both of the above layoutTestContoller commands.
      
              * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
              (WebCore::WebPage::resetSettings):
              (WebCore::DumpRenderTree::DumpRenderTree):
              * DumpRenderTree/qt/DumpRenderTreeQt.h:
              (WebCore::DumpRenderTree::drtStoragePath):
              * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
              (LayoutTestController::reset):
              (LayoutTestController::disableImageLoading):
              (LayoutTestController::setIconDatabaseEnabled):
              * DumpRenderTree/qt/LayoutTestControllerQt.h:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@59623 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      d08c8d81
    • ukai@chromium.org's avatar
      2010-05-17 Fumitoshi Ukai <ukai@chromium.org> · cbf99024
      ukai@chromium.org authored
              Reviewed by Eric Seidel.
      
              Chromium: Add --chromium option to new-run-webkit-websocketserver
              https://bugs.webkit.org/show_bug.cgi?id=37664
      
              os.environ setup and setup_mount for cygwin are moved in ChromiumWinPort.setup_environ_for_server.
      
              * Scripts/new-run-webkit-httpd:
                Remove passing register_cygwin.
              * Scripts/new-run-webkit-websocketserver:
                Add --chromium flag.
                Remove passing register_cygwin.
                Create port object using options.
              * Scripts/webkitpy/layout_tests/port/base.py:
                Add setup_environ_for_server().
              * Scripts/webkitpy/layout_tests/port/chromium_win.py:
                Ditto.
              * Scripts/webkitpy/layout_tests/port/factory_unittest.py: Added.
              * Scripts/webkitpy/layout_tests/port/http_server.py:
                Remove register_cygwin_parameter.
                Call setup_environ_for_server().
              * Scripts/webkitpy/layout_tests/port/websocket_server.py:
                Ditto.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@59595 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      cbf99024
    • dbates@webkit.org's avatar
      2010-05-16 Daniel Bates <dbates@rim.com> · bf1e4daa
      dbates@webkit.org authored
              Reviewed by Chris Jerdonek.
      
              https://bugs.webkit.org/show_bug.cgi?id=39184
      
              Adds function VCSUtils::parseSvnProperty to parse an SVN property with
              either a single-line or multi-line value change.
      
              * Scripts/VCSUtils.pm:
                - Added function parseSvnProperty. We will use this function
                  towards resolving Bug #38885 <https://bugs.webkit.org/show_bug.cgi?id=38885>.
                - Removed FIXME comment above function parseSvnPropertyValue, since
                  it is being used by parseSvnProperty.
                - Modified function parseSvnPropertyValue to break out of "while (<$fileHandle>)"
                  loop when it encounters the start of the next property so that it can be
                  processed by its caller, parseSvnPropertyValue. We reference this bullet below
                  by (*).
              * Scripts/webkitperl/VCSUtils_unittest/parseSvnProperty.pl: Added.
                - Added unit tests.
              * Scripts/webkitperl/VCSUtils_unittest/parseSvnPropertyValue.pl:
                - Changed the name of the unit test "simple multi-line '-' change" to
                  "single-line '-' change followed by empty line" since the former was an
                  incorrect description of this test.
                - Added unit test "single-line '-' change followed by the next property", and
                  "multi-line '-' change followed by the next property" to test (*) above.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@59593 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      bf1e4daa
  5. 16 May, 2010 7 commits
    • tony@chromium.org's avatar
      2010-05-16 Tony Chang <tony@chromium.org> · 788d35e7
      tony@chromium.org authored
              Not reviewed, fixing layout test.
      
              Add tiger and SL results.  Remove Inspect Element from leopard results.
      
              * platform/mac-leopard/editing/spelling/context-menu-suggestions-expected.txt:
              * platform/mac-snowleopard/editing/spelling/context-menu-suggestions-expected.txt: Added.
              * platform/mac-tiger/editing/spelling/context-menu-suggestions-expected.txt: Added.
      2010-05-16  Tony Chang  <tony@chromium.org>
      
              Not reviewed, fixing layout test.
      
              Don't output Inspect Element since this is not enabled on the bots,
              but most developers probably have it installed.
      
              * DumpRenderTree/mac/EventSendingController.mm:
              (-[EventSendingController contextClick:]):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@59586 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      788d35e7
    • tony@chromium.org's avatar
      2010-05-12 Tony Chang <tony@chromium.org> · f0804e9d
      tony@chromium.org authored
              Reviewed by Darin Adler.
      
              Spellcheck disabling does not disable context menu
              https://bugs.webkit.org/show_bug.cgi?id=25639
      
              * editing/spelling/context-menu-suggestions.html: Added.
              * platform/chromium/test_expectations.txt:
              * platform/gtk/Skipped:
              * platform/mac-leopard/editing/spelling/context-menu-suggestions-expected.txt: Added.
              * platform/qt/Skipped:
              * platform/win/Skipped:
      2010-05-12  Tony Chang  <tony@chromium.org>
      
              Reviewed by Darin Adler.
      
              Spellcheck disabling does not disable context menu
              https://bugs.webkit.org/show_bug.cgi?id=25639
      
              Test: editing/spelling/context-menu-suggestions.html
      
              * platform/ContextMenu.cpp:
              (WebCore::ContextMenu::populate):
      2010-05-12  Tony Chang  <tony@chromium.org>
      
              Reviewed by Darin Adler.
      
              Spellcheck disabling does not disable context menu
              https://bugs.webkit.org/show_bug.cgi?id=25639
      
              * DumpRenderTree/mac/EventSendingController.mm:
              (+[EventSendingController isSelectorExcludedFromWebScript:]):
              (+[EventSendingController webScriptNameForSelector:]):
              (-[EventSendingController contextClick:]): add a bool parameter that
                    when true, dumps the context menu items to stdout.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@59585 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      f0804e9d
    • robert@webkit.org's avatar
      [Qt] Fix FrameLoaderClientQt.cpp to print relative filename paths correctly. · efa907a5
      robert@webkit.org authored
      2010-05-16  Robert Hogan  <robert@webkit.org>
      
              Reviewed by Kenneth Rohde Christiansen.
      
              Fix FrameLoaderClientQt.cpp to print relative filename paths correctly.
      
              Move qt_* functions in FrameLoaderClientQt, EditorClientQt, and NotificationPresenterClientQt
              to DumpRenderTreeSupportQt. Create new functions to replace them in DumpRenderTreeSupportQt.
              Support for the old function names is retained until confirmed that no one uses them outside
              QtWebKit.
      
              https://bugs.webkit.org/show_bug.cgi?id=38867
      
              * WebCoreSupport/DumpRenderTreeSupportQt.cpp:
              (DumpRenderTreeSupportQt::dumpFrameLoader):
              (DumpRenderTreeSupportQt::dumpResourceLoadCallbacks):
              (DumpRenderTreeSupportQt::dumpResourceLoadCallbacksPath):
              (DumpRenderTreeSupportQt::setWillSendRequestReturnsNullOnRedirect):
              (DumpRenderTreeSupportQt::setWillSendRequestReturnsNull):
              (DumpRenderTreeSupportQt::setWillSendRequestClearHeaders):
              (DumpRenderTreeSupportQt::dumpEditingCallbacks):
              (DumpRenderTreeSupportQt::dumpSetAcceptsEditing):
              (DumpRenderTreeSupportQt::dumpNotification):
              (qt_dump_frame_loader):
              (qt_dump_resource_load_callbacks):
              (qt_dump_resource_load_callbacks_path):
              (qt_set_will_send_request_returns_null_on_redirect):
              (qt_set_will_send_request_returns_null):
              (qt_set_will_send_request_clear_headers):
              (qt_dump_editing_callbacks):
              (qt_dump_set_accepts_editing):
              (qt_dump_notification):
              * WebCoreSupport/DumpRenderTreeSupportQt.h:
              * WebCoreSupport/EditorClientQt.cpp:
              * WebCoreSupport/EditorClientQt.h:
              * WebCoreSupport/FrameLoaderClientQt.cpp:
              (drtDescriptionSuitableForTestResult):
              * WebCoreSupport/FrameLoaderClientQt.h:
              * WebCoreSupport/NotificationPresenterClientQt.cpp:
              * WebCoreSupport/NotificationPresenterClientQt.h:
      
              Update Qt DRT to use frame loader, editor client and notificaiton presenter
              functions in DumpRenderTreeSupportQt.
      
              * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
              (WebCore::DumpRenderTree::open):
              (WebCore::DumpRenderTree::dump):
              * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
              (LayoutTestController::LayoutTestController):
              (LayoutTestController::reset):
              (LayoutTestController::dumpEditingCallbacks):
              (LayoutTestController::dumpFrameLoadCallbacks):
              (LayoutTestController::dumpResourceLoadCallbacks):
              (LayoutTestController::setWillSendRequestReturnsNullOnRedirect):
              (LayoutTestController::setWillSendRequestReturnsNull):
              (LayoutTestController::setWillSendRequestClearHeader):
      
              Unskip fast/loader/main-document-url-for-non-http-loads.html
      
              * platform/qt/Skipped:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@59580 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      efa907a5
    • eric@webkit.org's avatar
      2010-05-16 Eric Seidel <eric@webkit.org> · 280adb8d
      eric@webkit.org authored
              Unreviewed, rolling out r59571.
              http://trac.webkit.org/changeset/59571
              https://bugs.webkit.org/show_bug.cgi?id=39054
      
              Broke Cr Win, but we didn't notice immediately due to
              https://bugs.webkit.org/show_bug.cgi?id=38926.  It's possible
              that this didn't actually break Cr Win, but rather that bug
              38926 necessitates a clean compile after this and sucessive
              checkins only produced a partial recompile and thus failed to
              build.
      
              * DEPS:
              * WebKit.gyp:
              * features.gypi:
      2010-05-16  Eric Seidel  <eric@webkit.org>
      
              Unreviewed, rolling out r59571.
              http://trac.webkit.org/changeset/59571
              https://bugs.webkit.org/show_bug.cgi?id=39054
      
              Broke Cr Win, but we didn't notice immediately due to
              https://bugs.webkit.org/show_bug.cgi?id=38926.  It's possible
              that this didn't actually break Cr Win, but rather that bug
              38926 necessitates a clean compile after this and sucessive
              checkins only produced a partial recompile and thus failed to
              build.
      
              * DumpRenderTree/chromium/WebViewHost.cpp:
              (WebViewHost::canvas):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@59578 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      280adb8d
    • robert@webkit.org's avatar
      [Qt]Unskip security/set-form-autocomplete-attribute.html · 964241ed
      robert@webkit.org authored
      2010-05-16  Robert Hogan  <robert@webkit.org>
      
              Reviewed by Kenneth Rohde Christiansen.
      
              [Qt]Unskip security/set-form-autocomplete-attribute.html
      
              Add support for layoutTestController.elementDoesAutoCompleteForElementWithId().
      
              https://bugs.webkit.org/show_bug.cgi?id=38859
      
              * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
              (LayoutTestController::elementDoesAutoCompleteForElementWithId):
              * DumpRenderTree/qt/LayoutTestControllerQt.h:
              * WebCoreSupport/DumpRenderTreeSupportQt.cpp:
              (DumpRenderTreeSupportQt::elementDoesAutoCompleteForElementWithId):
              * WebCoreSupport/DumpRenderTreeSupportQt.h:
              * platform/qt/Skipped:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@59573 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      964241ed
    • eric@webkit.org's avatar
      2010-05-16 Kent Tamura <tkent@chromium.org> · f203e13d
      eric@webkit.org authored
              Reviewed by Dimitri Glazkov.
      
              [DRT/Chromium] Fix repaint, WebGL, textarea tests
              https://bugs.webkit.org/show_bug.cgi?id=39054
      
              * DEPS: Update to Chromium r47248 to use a fix for CommandLine assertion
                and textAreaResizeCorner.png
              * WebKit.gyp: Add textAreaResizeCorner.png as a Mac resource
              * features.gypi: Enable ENABLE_3D_CANVAS.
      2010-05-16  Kent Tamura  <tkent@chromium.org>
      
              Reviewed by Dimitri Glazkov.
      
              [DRT/Chromium] Fix repaint, WebGL, textarea tests
              https://bugs.webkit.org/show_bug.cgi?id=39054
      
              * DumpRenderTree/chromium/WebViewHost.cpp:
              (WebViewHost::canvas): Remove m_paintRect initialization in canvas().
               This line updated m_paintRect unexpectedly during paintRect().
               We don't need to initialize m_paintRect because show() does it.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@59571 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      f203e13d
    • eric@webkit.org's avatar
      2010-05-16 Sergio Villar Senin <svillar@igalia.com> · bf71a244
      eric@webkit.org authored
              Reviewed by Gustavo Noronha Silva.
      
              Removed 5 http/history tests from Skipped file
      
              [GTK] Improve reporting of frame loader callbacks in DRT
              https://bugs.webkit.org/show_bug.cgi?id=36454
      
              * platform/gtk/Skipped:
      2010-05-16  Sergio Villar Senin  <svillar@igalia.com>
      
              Reviewed by Gustavo Noronha Silva.
      
              [GTK] Improve reporting of frame loader callbacks in DRT
              https://bugs.webkit.org/show_bug.cgi?id=36454
      
              * DumpRenderTree/gtk/DumpRenderTree.cpp:
              (webViewLoadStatusNotified):
              (createWebView): added connection to notify::load-status and
              signal callback
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@59568 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      bf71a244
  6. 15 May, 2010 10 commits
  7. 14 May, 2010 3 commits
    • eric@webkit.org's avatar
      2010-05-14 Anton Muhin <antonm@chromium.org> · b2591952
      eric@webkit.org authored
              Reviewed by Darin Fisher.
      
              [Chromium] Consider implementing addOriginAccessWhitelistEntry method
              https://bugs.webkit.org/show_bug.cgi?id=37578
      
              Remove deprecated methods.
      
              * public/WebSecurityPolicy.h:
              * src/WebSecurityPolicy.cpp:
      2010-05-14  Anton Muhin  <antonm@chromium.org>
      
              Reviewed by Darin Fisher.
      
              [Chromium] Consider implementing addOriginAccessWhitelistEntry method
              https://bugs.webkit.org/show_bug.cgi?id=37578
      
              Remove deprecated methods.
      
              * DumpRenderTree/chromium/LayoutTestController.cpp
              * DumpRenderTree/chromium/LayoutTestController.h
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@59512 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      b2591952
    • kbr@google.com's avatar
      2010-05-14 Kenneth Russell <kbr@google.com> · 3706f9b1
      kbr@google.com authored
              Reviewed by Darin Adler.
      
              Rename WebGLArray types to TypedArray types
              https://bugs.webkit.org/show_bug.cgi?id=39091
      
              Extended functionality of do-webcore-rename script and used it to
              rename the WebGLArray types to the TypedArray naming convention.
              The only source files which were touched by hand, and which are
              being manually reviewed, are:
                  WebCore/page/DOMWindow.idl
                  WebCore/bindings/generic/RuntimeEnabledFeatures.h (script's changes undone)
                  WebKit/WebCore/bindings/js/JSDOMWindowCustom.cpp
                  WebKit/WebCore/bindings/v8/custom/V8DOMWindowCustom.cpp
              These only needed to be touched to update the aliases between the
              WebGLArray and TypedArray names introduced in bug 39036. (It was
              not feasible to have do-webcore-rename handle this as it would
              introduce circular renamings.) These aliases will be removed in
              roughly a month once existing WebGL content has been updated.
      
              No new tests; covered under existing WebGL tests. Updated
              constructed-objects-prototypes and prototype-inheritance-2 tests.
              Ran all layout tests in Safari and all WebGL tests in Chromium.
      
              * src/GraphicsContext3D.cpp:
              (WebCore::GraphicsContext3DInternal::bufferData):
              (WebCore::GraphicsContext3DInternal::bufferSubData):
      2010-05-14  Kenneth Russell  <kbr@google.com>
      
              Reviewed by Darin Adler.
      
              Rename WebGLArray types to TypedArray types
              https://bugs.webkit.org/show_bug.cgi?id=39091
      
              Extended functionality of do-webcore-rename script and used it to
              rename the WebGLArray types to the TypedArray naming convention.
              The only source files which were touched by hand, and which are
              being manually reviewed, are:
                  WebCore/page/DOMWindow.idl
                  WebCore/bindings/generic/RuntimeEnabledFeatures.h (script's changes undone)
                  WebKit/WebCore/bindings/js/JSDOMWindowCustom.cpp
                  WebKit/WebCore/bindings/v8/custom/V8DOMWindowCustom.cpp
              These only needed to be touched to update the aliases between the
              WebGLArray and TypedArray names introduced in bug 39036. (It was
              not feasible to have do-webcore-rename handle this as it would
              introduce circular renamings.) These aliases will be removed in
              roughly a month once existing WebGL content has been updated.
      
              No new tests; covered under existing WebGL tests. Updated
              constructed-objects-prototypes and prototype-inheritance-2 tests.
              Ran all layout tests in Safari and all WebGL tests in Chromium.
      
              * DerivedSources.make:
              * GNUmakefile.am:
              * WebCore.gypi:
              * WebCore.pri:
              * WebCore.pro:
              * WebCore.xcodeproj/project.pbxproj:
              * bindings/js/JSArrayBufferConstructor.cpp: Copied from WebCore/bindings/js/JSWebGLArrayBufferConstructor.cpp.
              (WebCore::):
              (WebCore::JSArrayBufferConstructor::JSArrayBufferConstructor):
              (WebCore::constructCanvasArrayBuffer):
              (WebCore::JSArrayBufferConstructor::getConstructData):
              * bindings/js/JSArrayBufferConstructor.h: Copied from WebCore/bindings/js/JSWebGLArrayBufferConstructor.h.
              (WebCore::construct):
              * bindings/js/JSArrayBufferViewCustom.cpp: Copied from WebCore/bindings/js/JSWebGLArrayCustom.cpp.
              (WebCore::toJS):
              (WebCore::JSArrayBufferView::slice):
              * bindings/js/JSArrayBufferViewHelper.h: Copied from WebCore/bindings/js/JSWebGLArrayHelper.h.
              * bindings/js/JSDOMWindowCustom.cpp:
              (WebCore::JSDOMWindow::arrayBuffer):
              (WebCore::JSDOMWindow::int8Array):
              (WebCore::JSDOMWindow::uint8Array):
              (WebCore::JSDOMWindow::int32Array):
              (WebCore::JSDOMWindow::uint32Array):
              (WebCore::JSDOMWindow::int16Array):
              (WebCore::JSDOMWindow::uint16Array):
              (WebCore::JSDOMWindow::floatArray):
              (WebCore::JSDOMWindow::webGLArrayBuffer):
              (WebCore::JSDOMWindow::webGLByteArray):
              (WebCore::JSDOMWindow::webGLUnsignedByteArray):
              (WebCore::JSDOMWindow::webGLIntArray):
              (WebCore::JSDOMWindow::webGLUnsignedIntArray):
              (WebCore::JSDOMWindow::webGLShortArray):
              (WebCore::JSDOMWindow::webGLUnsignedShortArray):
              (WebCore::JSDOMWindow::webGLFloatArray):
              * bindings/js/JSFloatArrayConstructor.cpp: Copied from WebCore/bindings/js/JSWebGLFloatArrayConstructor.cpp.
              (WebCore::):
              (WebCore::JSFloatArrayConstructor::JSFloatArrayConstructor):
              (WebCore::constructCanvasFloatArray):
              (WebCore::JSFloatArrayConstructor::getConstructData):
              * bindings/js/JSFloatArrayConstructor.h: Copied from WebCore/bindings/js/JSWebGLFloatArrayConstructor.h.
              * bindings/js/JSFloatArrayCustom.cpp: Copied from WebCore/bindings/js/JSWebGLFloatArrayCustom.cpp.
              (WebCore::JSFloatArray::indexSetter):
              (WebCore::toJS):
              (WebCore::JSFloatArray::set):
              * bindings/js/JSInt16ArrayConstructor.cpp: Copied from WebCore/bindings/js/JSWebGLShortArrayConstructor.cpp.
              (WebCore::):
              (WebCore::JSInt16ArrayConstructor::JSInt16ArrayConstructor):
              (WebCore::constructCanvasShortArray):
              (WebCore::JSInt16ArrayConstructor::getConstructData):
              * bindings/js/JSInt16ArrayConstructor.h: Copied from WebCore/bindings/js/JSWebGLShortArrayConstructor.h.
              * bindings/js/JSInt16ArrayCustom.cpp: Copied from WebCore/bindings/js/JSWebGLShortArrayCustom.cpp.
              (WebCore::JSInt16Array::indexSetter):
              (WebCore::toJS):
              (WebCore::JSInt16Array::set):
              * bindings/js/JSInt32ArrayConstructor.cpp: Copied from WebCore/bindings/js/JSWebGLIntArrayConstructor.cpp.
              (WebCore::):
              (WebCore::JSInt32ArrayConstructor::JSInt32ArrayConstructor):
              (WebCore::constructCanvasIntArray):
              (WebCore::JSInt32ArrayConstructor::getConstructData):
              * bindings/js/JSInt32ArrayConstructor.h: Copied from WebCore/bindings/js/JSWebGLIntArrayConstructor.h.
              * bindings/js/JSInt32ArrayCustom.cpp: Copied from WebCore/bindings/js/JSWebGLIntArrayCustom.cpp.
              (WebCore::JSInt32Array::indexSetter):
              (WebCore::toJS):
              (WebCore::JSInt32Array::set):
              * bindings/js/JSInt8ArrayConstructor.cpp: Copied from WebCore/bindings/js/JSWebGLByteArrayConstructor.cpp.
              (WebCore::):
              (WebCore::JSInt8ArrayConstructor::JSInt8ArrayConstructor):
              (WebCore::constructCanvasByteArray):
              (WebCore::JSInt8ArrayConstructor::getConstructData):
              * bindings/js/JSInt8ArrayConstructor.h: Copied from WebCore/bindings/js/JSWebGLByteArrayConstructor.h.
              * bindings/js/JSInt8ArrayCustom.cpp: Copied from WebCore/bindings/js/JSWebGLByteArrayCustom.cpp.
              (WebCore::JSInt8Array::indexSetter):
              (WebCore::toJS):
              (WebCore::JSInt8Array::set):
              * bindings/js/JSUint16ArrayConstructor.cpp: Copied from WebCore/bindings/js/JSWebGLUnsignedShortArrayConstructor.cpp.
              (WebCore::):
              (WebCore::JSUint16ArrayConstructor::JSUint16ArrayConstructor):
              (WebCore::constructCanvasUnsignedShortArray):
              (WebCore::JSUint16ArrayConstructor::getConstructData):
              * bindings/js/JSUint16ArrayConstructor.h: Copied from WebCore/bindings/js/JSWebGLUnsignedShortArrayConstructor.h.
              * bindings/js/JSUint16ArrayCustom.cpp: Copied from WebCore/bindings/js/JSWebGLUnsignedShortArrayCustom.cpp.
              (WebCore::JSUint16Array::indexSetter):
              (WebCore::toJS):
              (WebCore::JSUint16Array::set):
              * bindings/js/JSUint32ArrayConstructor.cpp: Copied from WebCore/bindings/js/JSWebGLUnsignedIntArrayConstructor.cpp.
              (WebCore::):
              (WebCore::JSUint32ArrayConstructor::JSUint32ArrayConstructor):
              (WebCore::constructCanvasUnsignedIntArray):
              (WebCore::JSUint32ArrayConstructor::getConstructData):
              * bindings/js/JSUint32ArrayConstructor.h: Copied from WebCore/bindings/js/JSWebGLUnsignedIntArrayConstructor.h.
              * bindings/js/JSUint32ArrayCustom.cpp: Copied from WebCore/bindings/js/JSWebGLUnsignedIntArrayCustom.cpp.
              (WebCore::JSUint32Array::indexSetter):
              (WebCore::toJS):
              (WebCore::JSUint32Array::set):
              * bindings/js/JSUint8ArrayConstructor.cpp: Copied from WebCore/bindings/js/JSWebGLUnsignedByteArrayConstructor.cpp.
              (WebCore::):
              (WebCore::JSUint8ArrayConstructor::JSUint8ArrayConstructor):
              (WebCore::constructCanvasUnsignedByteArray):
              (WebCore::JSUint8ArrayConstructor::getConstructData):
              * bindings/js/JSUint8ArrayConstructor.h: Copied from WebCore/bindings/js/JSWebGLUnsignedByteArrayConstructor.h.
              * bindings/js/JSUint8ArrayCustom.cpp: Copied from WebCore/bindings/js/JSWebGLUnsignedByteArrayCustom.cpp.
              (WebCore::JSUint8Array::indexSetter):
              (WebCore::toJS):
              (WebCore::JSUint8Array::set):
              * bindings/js/JSWebGLArrayBufferConstructor.cpp: Removed.
              * bindings/js/JSWebGLArrayBufferConstructor.h: Removed.
              * bindings/js/JSWebGLArrayCustom.cpp: Removed.
              * bindings/js/JSWebGLArrayHelper.h: Removed.
              * bindings/js/JSWebGLByteArrayConstructor.cpp: Removed.
              * bindings/js/JSWebGLByteArrayConstructor.h: Removed.
              * bindings/js/JSWebGLByteArrayCustom.cpp: Removed.
              * bindings/js/JSWebGLFloatArrayConstructor.cpp: Removed.
              * bindings/js/JSWebGLFloatArrayConstructor.h: Removed.
              * bindings/js/JSWebGLFloatArrayCustom.cpp: Removed.
              * bindings/js/JSWebGLIntArrayConstructor.cpp: Removed.
              * bindings/js/JSWebGLIntArrayConstructor.h: Removed.
              * bindings/js/JSWebGLIntArrayCustom.cpp: Removed.
              * bindings/js/JSWebGLRenderingContextCustom.cpp:
              (WebCore::JSWebGLRenderingContext::bufferData):
              (WebCore::JSWebGLRenderingContext::bufferSubData):
              (WebCore::JSWebGLRenderingContext::texImage2D):
              (WebCore::JSWebGLRenderingContext::texSubImage2D):
              (WebCore::dataFunctionf):
              (WebCore::dataFunctioni):
              (WebCore::dataFunctionMatrix):
              * bindings/js/JSWebGLShortArrayConstructor.cpp: Removed.
              * bindings/js/JSWebGLShortArrayConstructor.h: Removed.
              * bindings/js/JSWebGLShortArrayCustom.cpp: Removed.
              * bindings/js/JSWebGLUnsignedByteArrayConstructor.cpp: Removed.
              * bindings/js/JSWebGLUnsignedByteArrayConstructor.h: Removed.
              * bindings/js/JSWebGLUnsignedByteArrayCustom.cpp: Removed.
              * bindings/js/JSWebGLUnsignedIntArrayConstructor.cpp: Removed.
              * bindings/js/JSWebGLUnsignedIntArrayConstructor.h: Removed.
              * bindings/js/JSWebGLUnsignedIntArrayCustom.cpp: Removed.
              * bindings/js/JSWebGLUnsignedShortArrayConstructor.cpp: Removed.
              * bindings/js/JSWebGLUnsignedShortArrayConstructor.h: Removed.
              * bindings/js/JSWebGLUnsignedShortArrayCustom.cpp: Removed.
              * bindings/v8/V8DOMWrapper.cpp:
              * bindings/v8/custom/V8ArrayBufferCustom.cpp: Copied from WebCore/bindings/v8/custom/V8WebGLArrayBufferCustom.cpp.
              (WebCore::V8ArrayBuffer::constructorCallback):
              * bindings/v8/custom/V8ArrayBufferViewCustom.cpp: Copied from WebCore/bindings/v8/custom/V8WebGLArrayCustom.cpp.
              (WebCore::toV8):
              (WebCore::V8ArrayBufferView::sliceCallback):
              * bindings/v8/custom/V8ArrayBufferViewCustom.h: Copied from WebCore/bindings/v8/custom/V8WebGLArrayCustom.h.
              (WebCore::constructWebGLArray):
              * bindings/v8/custom/V8DOMWindowCustom.cpp:
              (WebCore::V8DOMWindow::WebGLArrayBufferAccessorGetter):
              (WebCore::V8DOMWindow::WebGLByteArrayAccessorGetter):
              (WebCore::V8DOMWindow::WebGLUnsignedByteArrayAccessorGetter):
              (WebCore::V8DOMWindow::WebGLShortArrayAccessorGetter):
              (WebCore::V8DOMWindow::WebGLUnsignedShortArrayAccessorGetter):
              (WebCore::V8DOMWindow::WebGLIntArrayAccessorGetter):
              (WebCore::V8DOMWindow::WebGLUnsignedIntArrayAccessorGetter):
              (WebCore::V8DOMWindow::WebGLFloatArrayAccessorGetter):
              * bindings/v8/custom/V8FloatArrayCustom.cpp: Copied from WebCore/bindings/v8/custom/V8WebGLFloatArrayCustom.cpp.
              (WebCore::V8FloatArray::constructorCallback):
              (WebCore::V8FloatArray::setCallback):
              (WebCore::toV8):
              * bindings/v8/custom/V8Int16ArrayCustom.cpp: Copied from WebCore/bindings/v8/custom/V8WebGLShortArrayCustom.cpp.
              (WebCore::V8Int16Array::constructorCallback):
              (WebCore::V8Int16Array::setCallback):
              (WebCore::toV8):
              * bindings/v8/custom/V8Int32ArrayCustom.cpp: Copied from WebCore/bindings/v8/custom/V8WebGLIntArrayCustom.cpp.
              (WebCore::V8Int32Array::constructorCallback):
              (WebCore::V8Int32Array::setCallback):
              (WebCore::toV8):
              * bindings/v8/custom/V8Int8ArrayCustom.cpp: Copied from WebCore/bindings/v8/custom/V8WebGLByteArrayCustom.cpp.
              (WebCore::V8Int8Array::constructorCallback):
              (WebCore::V8Int8Array::setCallback):
              (WebCore::toV8):
              * bindings/v8/custom/V8Uint16ArrayCustom.cpp: Copied from WebCore/bindings/v8/custom/V8WebGLUnsignedShortArrayCustom.cpp.
              (WebCore::V8Uint16Array::constructorCallback):
              (WebCore::V8Uint16Array::setCallback):
              (WebCore::toV8):
              * bindings/v8/custom/V8Uint32ArrayCustom.cpp: Copied from WebCore/bindings/v8/custom/V8WebGLUnsignedIntArrayCustom.cpp.
              (WebCore::V8Uint32Array::constructorCallback):
              (WebCore::V8Uint32Array::setCallback):
              (WebCore::toV8):
              * bindings/v8/custom/V8Uint8ArrayCustom.cpp: Copied from WebCore/bindings/v8/custom/V8WebGLUnsignedByteArrayCustom.cpp.
              (WebCore::V8Uint8Array::constructorCallback):
              (WebCore::V8Uint8Array::setCallback):
              (WebCore::toV8):
              * bindings/v8/custom/V8WebGLArrayBufferCustom.cpp: Removed.
              * bindings/v8/custom/V8WebGLArrayCustom.cpp: Removed.
              * bindings/v8/custom/V8WebGLArrayCustom.h: Removed.
              * bindings/v8/custom/V8WebGLByteArrayCustom.cpp: Removed.
              * bindings/v8/custom/V8WebGLFloatArrayCustom.cpp: Removed.
              * bindings/v8/custom/V8WebGLIntArrayCustom.cpp: Removed.
              * bindings/v8/custom/V8WebGLRenderingContextCustom.cpp:
              (WebCore::vertexAttribAndUniformHelperf):
              (WebCore::uniformHelperi):
              (WebCore::uniformMatrixHelper):
              * bindings/v8/custom/V8WebGLShortArrayCustom.cpp: Removed.
              * bindings/v8/custom/V8WebGLUnsignedByteArrayCustom.cpp: Removed.
              * bindings/v8/custom/V8WebGLUnsignedIntArrayCustom.cpp: Removed.
              * bindings/v8/custom/V8WebGLUnsignedShortArrayCustom.cpp: Removed.
              * html/canvas/ArrayBuffer.cpp: Copied from WebCore/html/canvas/WebGLArrayBuffer.cpp.
              (WebCore::ArrayBuffer::create):
              (WebCore::ArrayBuffer::ArrayBuffer):
              (WebCore::ArrayBuffer::data):
              (WebCore::ArrayBuffer::byteLength):
              (WebCore::ArrayBuffer::~ArrayBuffer):
              (WebCore::ArrayBuffer::tryAllocate):
              * html/canvas/ArrayBuffer.h: Copied from WebCore/html/canvas/WebGLArrayBuffer.h.
              * html/canvas/ArrayBuffer.idl: Copied from WebCore/html/canvas/WebGLArrayBuffer.idl.
              * html/canvas/ArrayBufferView.cpp: Copied from WebCore/html/canvas/WebGLArray.cpp.
              (WebCore::ArrayBufferView::ArrayBufferView):
              (WebCore::ArrayBufferView::~ArrayBufferView):
              (WebCore::ArrayBufferView::setImpl):
              (WebCore::ArrayBufferView::calculateOffsetAndLength):
              * html/canvas/ArrayBufferView.h: Copied from WebCore/html/canvas/WebGLArray.h.
              (WebCore::ArrayBufferView::buffer):
              (WebCore::ArrayBufferView::verifySubRange):
              (WebCore::ArrayBufferView::clampOffsetAndNumElements):
              * html/canvas/ArrayBufferView.idl: Copied from WebCore/html/canvas/WebGLArray.idl.
              * html/canvas/FloatArray.cpp: Copied from WebCore/html/canvas/WebGLFloatArray.cpp.
              (WebCore::FloatArray::create):
              (WebCore::FloatArray::FloatArray):
              (WebCore::FloatArray::slice):
              * html/canvas/FloatArray.h: Copied from WebCore/html/canvas/WebGLFloatArray.h.
              (WebCore::FloatArray::set):
              (WebCore::FloatArray::item):
              * html/canvas/FloatArray.idl: Copied from WebCore/html/canvas/WebGLFloatArray.idl.
              * html/canvas/Int16Array.cpp: Copied from WebCore/html/canvas/WebGLShortArray.cpp.
              (WebCore::Int16Array::create):
              (WebCore::Int16Array::Int16Array):
              (WebCore::Int16Array::slice):
              * html/canvas/Int16Array.h: Copied from WebCore/html/canvas/WebGLShortArray.h.
              * html/canvas/Int16Array.idl: Copied from WebCore/html/canvas/WebGLShortArray.idl.
              * html/canvas/Int32Array.cpp: Copied from WebCore/html/canvas/WebGLIntArray.cpp.
              (WebCore::Int32Array::create):
              (WebCore::Int32Array::Int32Array):
              (WebCore::Int32Array::slice):
              * html/canvas/Int32Array.h: Copied from WebCore/html/canvas/WebGLIntArray.h.
              * html/canvas/Int32Array.idl: Copied from WebCore/html/canvas/WebGLIntArray.idl.
              * html/canvas/Int8Array.cpp: Copied from WebCore/html/canvas/WebGLByteArray.cpp.
              (WebCore::Int8Array::create):
              (WebCore::Int8Array::Int8Array):
              (WebCore::Int8Array::slice):
              * html/canvas/Int8Array.h: Copied from WebCore/html/canvas/WebGLByteArray.h.
              * html/canvas/Int8Array.idl: Copied from WebCore/html/canvas/WebGLByteArray.idl.
              * html/canvas/IntegralTypedArrayBase.h: Copied from WebCore/html/canvas/WebGLIntegralTypedArrayBase.h.
              (WebCore::IntegralTypedArrayBase::set):
              (WebCore::IntegralTypedArrayBase::item):
              (WebCore::IntegralTypedArrayBase::IntegralTypedArrayBase):
              * html/canvas/TypedArrayBase.h: Copied from WebCore/html/canvas/WebGLTypedArrayBase.h.
              (WebCore::TypedArrayBase::set):
              (WebCore::TypedArrayBase::TypedArrayBase):
              (WebCore::TypedArrayBase::create):
              * html/canvas/Uint16Array.cpp: Copied from WebCore/html/canvas/WebGLUnsignedShortArray.cpp.
              (WebCore::Uint16Array::create):
              (WebCore::Uint16Array::Uint16Array):
              (WebCore::Uint16Array::slice):
              * html/canvas/Uint16Array.h: Copied from WebCore/html/canvas/WebGLUnsignedShortArray.h.
              * html/canvas/Uint16Array.idl: Copied from WebCore/html/canvas/WebGLUnsignedShortArray.idl.
              * html/canvas/Uint32Array.cpp: Copied from WebCore/html/canvas/WebGLUnsignedIntArray.cpp.
              (WebCore::Uint32Array::create):
              (WebCore::Uint32Array::Uint32Array):
              (WebCore::Uint32Array::slice):
              * html/canvas/Uint32Array.h: Copied from WebCore/html/canvas/WebGLUnsignedIntArray.h.
              * html/canvas/Uint32Array.idl: Copied from WebCore/html/canvas/WebGLUnsignedIntArray.idl.
              * html/canvas/Uint8Array.cpp: Copied from WebCore/html/canvas/WebGLUnsignedByteArray.cpp.
              (WebCore::Uint8Array::create):
              (WebCore::Uint8Array::Uint8Array):
              (WebCore::Uint8Array::slice):
              * html/canvas/Uint8Array.h: Copied from WebCore/html/canvas/WebGLUnsignedByteArray.h.
              * html/canvas/Uint8Array.idl: Copied from WebCore/html/canvas/WebGLUnsignedByteArray.idl.
              * html/canvas/WebGLArray.cpp: Removed.
              * html/canvas/WebGLArray.h: Removed.
              * html/canvas/WebGLArray.idl: Removed.
              * html/canvas/WebGLArrayBuffer.cpp: Removed.
              * html/canvas/WebGLArrayBuffer.h: Removed.
              * html/canvas/WebGLArrayBuffer.idl: Removed.
              * html/canvas/WebGLBuffer.cpp:
              (WebCore::WebGLBuffer::associateBufferData):
              (WebCore::WebGLBuffer::associateBufferSubData):
              * html/canvas/WebGLBuffer.h:
              (WebCore::WebGLBuffer::elementArrayBuffer):
              * html/canvas/WebGLByteArray.cpp: Removed.
              * html/canvas/WebGLByteArray.h: Removed.
              * html/canvas/WebGLByteArray.idl: Removed.
              * html/canvas/WebGLFloatArray.cpp: Removed.
              * html/canvas/WebGLFloatArray.h: Removed.
              * html/canvas/WebGLFloatArray.idl: Removed.
              * html/canvas/WebGLGetInfo.cpp:
              (WebCore::WebGLGetInfo::WebGLGetInfo):
              (WebCore::WebGLGetInfo::getWebGLFloatArray):
              (WebCore::WebGLGetInfo::getWebGLIntArray):
              (WebCore::WebGLGetInfo::getWebGLUnsignedByteArray):
              * html/canvas/WebGLGetInfo.h:
              * html/canvas/WebGLIntArray.cpp: Removed.
              * html/canvas/WebGLIntArray.h: Removed.
              * html/canvas/WebGLIntArray.idl: Removed.
              * html/canvas/WebGLIntegralTypedArrayBase.h: Removed.
              * html/canvas/WebGLRenderingContext.cpp:
              (WebCore::WebGLRenderingContext::bufferData):
              (WebCore::WebGLRenderingContext::bufferSubData):
              (WebCore::WebGLRenderingContext::getUniform):
              (WebCore::WebGLRenderingContext::getVertexAttrib):
              (WebCore::WebGLRenderingContext::readPixels):
              (WebCore::WebGLRenderingContext::texImage2D):
              (WebCore::WebGLRenderingContext::texSubImage2D):
              (WebCore::WebGLRenderingContext::uniform1fv):
              (WebCore::WebGLRenderingContext::uniform1iv):
              (WebCore::WebGLRenderingContext::uniform2fv):
              (WebCore::WebGLRenderingContext::uniform2iv):
              (WebCore::WebGLRenderingContext::uniform3fv):
              (WebCore::WebGLRenderingContext::uniform3iv):
              (WebCore::WebGLRenderingContext::uniform4fv):
              (WebCore::WebGLRenderingContext::uniform4iv):
              (WebCore::WebGLRenderingContext::uniformMatrix2fv):
              (WebCore::WebGLRenderingContext::uniformMatrix3fv):
              (WebCore::WebGLRenderingContext::uniformMatrix4fv):
              (WebCore::WebGLRenderingContext::vertexAttrib1fv):
              (WebCore::WebGLRenderingContext::vertexAttrib2fv):
              (WebCore::WebGLRenderingContext::vertexAttrib3fv):
              (WebCore::WebGLRenderingContext::vertexAttrib4fv):
              (WebCore::WebGLRenderingContext::getWebGLFloatArrayParameter):
              (WebCore::WebGLRenderingContext::getWebGLIntArrayParameter):
              (WebCore::WebGLRenderingContext::getWebGLUnsignedByteArrayParameter):
              * html/canvas/WebGLRenderingContext.h:
              * html/canvas/WebGLRenderingContext.idl:
              * html/canvas/WebGLShortArray.cpp: Removed.
              * html/canvas/WebGLShortArray.h: Removed.
              * html/canvas/WebGLShortArray.idl: Removed.
              * html/canvas/WebGLTypedArrayBase.h: Removed.
              * html/canvas/WebGLUnsignedByteArray.cpp: Removed.
              * html/canvas/WebGLUnsignedByteArray.h: Removed.
              * html/canvas/WebGLUnsignedByteArray.idl: Removed.
              * html/canvas/WebGLUnsignedIntArray.cpp: Removed.
              * html/canvas/WebGLUnsignedIntArray.h: Removed.
              * html/canvas/WebGLUnsignedIntArray.idl: Removed.
              * html/canvas/WebGLUnsignedShortArray.cpp: Removed.
              * html/canvas/WebGLUnsignedShortArray.h: Removed.
              * html/canvas/WebGLUnsignedShortArray.idl: Removed.
              * page/DOMWindow.idl:
              * platform/graphics/GraphicsContext3D.h:
              * platform/graphics/mac/GraphicsContext3DMac.cpp:
              (WebCore::GraphicsContext3D::bufferData):
              (WebCore::GraphicsContext3D::bufferSubData):
              * platform/graphics/qt/GraphicsContext3DQt.cpp:
              (WebCore::GraphicsContext3D::bufferData):
              (WebCore::GraphicsContext3D::bufferSubData):
      2010-05-14  Kenneth Russell  <kbr@google.com>
      
              Reviewed by Darin Adler.
      
              Rename WebGLArray types to TypedArray types
              https://bugs.webkit.org/show_bug.cgi?id=39091
      
              Extended functionality of do-webcore-rename script and used it to
              rename the WebGLArray types to the TypedArray naming convention.
              The only source files which were touched by hand, and which are
              being manually reviewed, are:
                  WebCore/page/DOMWindow.idl
                  WebCore/bindings/generic/RuntimeEnabledFeatures.h (script's changes undone)
                  WebKit/WebCore/bindings/js/JSDOMWindowCustom.cpp
                  WebKit/WebCore/bindings/v8/custom/V8DOMWindowCustom.cpp
              These only needed to be touched to update the aliases between the
              WebGLArray and TypedArray names introduced in bug 39036. (It was
              not feasible to have do-webcore-rename handle this as it would
              introduce circular renamings.) These aliases will be removed in
              roughly a month once existing WebGL content has been updated.
      
              No new tests; covered under existing WebGL tests. Updated
              constructed-objects-prototypes and prototype-inheritance-2 tests.
              Ran all layout tests in Safari and all WebGL tests in Chromium.
      
              * fast/dom/script-tests/constructed-objects-prototypes.js:
              (constructorPropertiesOnWindow):
              * fast/dom/script-tests/prototype-inheritance-2.js:
              (constructorNamesForWindow):
      2010-05-14  Kenneth Russell  <kbr@google.com>
      
              Reviewed by Darin Adler.
      
              Rename WebGLArray types to TypedArray types
              https://bugs.webkit.org/show_bug.cgi?id=39091
      
              Extended functionality of do-webcore-rename script and used it to
              rename the WebGLArray types to the TypedArray naming convention.
              The only source files which were touched by hand, and which are
              being manually reviewed, are:
                  WebCore/page/DOMWindow.idl
                  WebCore/bindings/generic/RuntimeEnabledFeatures.h (script's changes undone)
                  WebKit/WebCore/bindings/js/JSDOMWindowCustom.cpp
                  WebKit/WebCore/bindings/v8/custom/V8DOMWindowCustom.cpp
              These only needed to be touched to update the aliases between the
              WebGLArray and TypedArray names introduced in bug 39036. (It was
              not feasible to have do-webcore-rename handle this as it would
              introduce circular renamings.) These aliases will be removed in
              roughly a month once existing WebGL content has been updated.
      
              No new tests; covered under existing WebGL tests. Updated
              constructed-objects-prototypes and prototype-inheritance-2 tests.
              Ran all layout tests in Safari and all WebGL tests in Chromium.
      
              * Scripts/do-webcore-rename:
                Handle the case where some renames are substrings of others.
                Support renaming files containing custom JS bindings. If
                isDOMTypeRename is non-zero, expand the regexp which rewrites
                the file's contents in order to support custom JS bindings.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@59499 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      3706f9b1
    • eric@webkit.org's avatar
      2010-05-14 Eric Seidel <eric@webkit.org> · fd0eba42
      eric@webkit.org authored
              Reviewed by Adam Barth.
      
              webkit-patch rollout throws exception if bug is already open
              https://bugs.webkit.org/show_bug.cgi?id=38803
      
              This was caused by someone incorrectly wrapping the code. :p
              I'm going to have to start demanding unit tests for wrapping changes...
      
              I also fixed the code to be able to reopen bugs which were never confirmed.
              Before it regressed, the code would just log in that case.  Now it actually
              will reopen the bug, but there is a FIXME about how the logic is a bit backwards.
      
              * Scripts/webkitpy/common/net/bugzilla.py:
              * Scripts/webkitpy/common/net/bugzilla_unittest.py:
               - Yay testing!
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@59480 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      fd0eba42