1. 09 Dec, 2010 40 commits
    • beidson@apple.com's avatar
      <rdar://problem/8613779> and https://bugs.webkit.org/show_bug.cgi?id=50777 · 4b0f5936
      beidson@apple.com authored
      WebKit2 ContextMenuClient support
      
      Reviewed by Anders Carlsson.
      
      WebCore: 
      
      Export some symbols and headers needed by WebKit2 Mac:
      * WebCore.exp.in:
      * WebCore.xcodeproj/project.pbxproj:
      
      WebKit2: 
      
      Implement google search in a cross platform manner, and add a FIXME for download support:
      * WebProcess/WebCoreSupport/WebContextMenuClient.cpp:
      (WebKit::WebContextMenuClient::downloadURL):
      (WebKit::WebContextMenuClient::searchWithGoogle):
      
      Mac implementations for speaking and searching:
      * WebProcess/WebCoreSupport/mac/WebContextMenuClientMac.mm: Added.
      (WebKit::WebContextMenuClient::lookUpInDictionary): Add a FIXME for now.
      (WebKit::WebContextMenuClient::isSpeaking):
      (WebKit::WebContextMenuClient::speak):
      (WebKit::WebContextMenuClient::stopSpeaking):
      (WebKit::WebContextMenuClient::searchWithSpotlight):
      
      Stubs for Win and Qt:
      * WebProcess/WebCoreSupport/qt/WebContextMenuClientQt.cpp: Added.
      (WebKit::WebContextMenuClient::lookUpInDictionary):
      (WebKit::WebContextMenuClient::isSpeaking):
      (WebKit::WebContextMenuClient::speak):
      (WebKit::WebContextMenuClient::stopSpeaking):
      * WebProcess/WebCoreSupport/win/WebContextMenuClientWin.cpp: Added.
      (WebKit::WebContextMenuClient::lookUpInDictionary):
      (WebKit::WebContextMenuClient::isSpeaking):
      (WebKit::WebContextMenuClient::speak):
      (WebKit::WebContextMenuClient::stopSpeaking):
      
      Project file stuffs:
      * WebKit2.pro:
      * WebKit2.xcodeproj/project.pbxproj:
      * win/WebKit2.vcproj:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@73643 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      4b0f5936
    • commit-queue@webkit.org's avatar
      2010-12-09 Sheriff Bot <webkit.review.bot@gmail.com> · 7a1e73d4
      commit-queue@webkit.org authored
              Unreviewed, rolling out r73635.
              http://trac.webkit.org/changeset/73635
              https://bugs.webkit.org/show_bug.cgi?id=50778
      
              'Side-effects on 3 css tests needs closer review' (Requested
              by mwenge on #webkit).
      
              * platform/qt/Skipped:
      2010-12-09  Sheriff Bot  <webkit.review.bot@gmail.com>
      
              Unreviewed, rolling out r73635.
              http://trac.webkit.org/changeset/73635
              https://bugs.webkit.org/show_bug.cgi?id=50778
      
              'Side-effects on 3 css tests needs closer review' (Requested
              by mwenge on #webkit).
      
              * platform/graphics/qt/ImageQt.cpp:
              (loadResourcePixmap):
              * platform/qt/RenderThemeQt.cpp:
              (WebCore::RenderThemeQt::computeSizeBasedOnStyle):
              (WebCore::RenderThemeQt::paintSearchField):
              (WebCore::RenderThemeQt::adjustSearchFieldStyle):
              (WebCore::RenderThemeQt::adjustSearchFieldCancelButtonStyle):
              (WebCore::RenderThemeQt::paintSearchFieldCancelButton):
              * platform/qt/RenderThemeQt.h:
      2010-12-09  Sheriff Bot  <webkit.review.bot@gmail.com>
      
              Unreviewed, rolling out r73635.
              http://trac.webkit.org/changeset/73635
              https://bugs.webkit.org/show_bug.cgi?id=50778
      
              'Side-effects on 3 css tests needs closer review' (Requested
              by mwenge on #webkit).
      
              * Api/qwebsettings.cpp:
              (graphics):
              * Api/qwebsettings.h:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@73642 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      7a1e73d4
    • commit-queue@webkit.org's avatar
      2010-12-09 Alex Bredariol Grilo <abgrilo@profusion.mobi> · 44640aac
      commit-queue@webkit.org authored
              Reviewed by Antonio Gomes.
      
              [EFL] Add missing function in WebKit-EFL API
      
              Add ewk_tiled_backing_store_zoom_weak_smooth_scale_set function in
              WebKit-EFL API. This function was already implemented but missing in
              header file.
      
              * ewk/ewk_tiled_backing_store.h:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@73641 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      44640aac
    • msaboff@apple.com's avatar
      2010-12-09 Michael Saboff <msaboff@apple.com> · 29297b64
      msaboff@apple.com authored
              Reviewed by Gavin Barraclough.
      
              REGRESSION (r73065?): A regex no longer works 
              https://bugs.webkit.org/show_bug.cgi?id=50570
      
              Changed the handling of adjacent parentheses backtracks in two ways.
              First, only outer most paren backtracks default to back tracking
              to the "next character" looping code.  Second, added a jump around 
              backtracks that fall through to the next backtrack where the
              second backtrack has some greedy processing before the backtracking
              from outside the parentheses code.
              Also cleaned up extraneous white spce, removing white space at the
              end of or that makes up a whole line.
      
              * yarr/RegexJIT.cpp:
              (JSC::Yarr::RegexGenerator::GenerationState::GenerationState):
              (JSC::Yarr::RegexGenerator::GenerationState::incrementParenNestingLevel):
              (JSC::Yarr::RegexGenerator::GenerationState::decrementParenNestingLevel):
              (JSC::Yarr::RegexGenerator::GenerationState::addParenthesesTail):
              (JSC::Yarr::RegexGenerator::GenerationState::emitParenthesesTail):
              (JSC::Yarr::RegexGenerator::ParenthesesTail::ParenthesesTail):
              (JSC::Yarr::RegexGenerator::ParenthesesTail::setNextIteration):
              (JSC::Yarr::RegexGenerator::ParenthesesTail::generateCode):
              (JSC::Yarr::RegexGenerator::generateParenthesesSingle):
      2010-12-09  Michael Saboff  <msaboff@apple.com>
      
              Reviewed by Gavin Barraclough.
      
              REGRESSION (r73065?): A regex no longer works 
              https://bugs.webkit.org/show_bug.cgi?id=50570
      
              Added tests that came from submitter to validate change.
      
              * fast/regex/parentheses-expected.txt:
              * fast/regex/script-tests/parentheses.js:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@73640 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      29297b64
    • pkasting@chromium.org's avatar
      Unreviewed Chromium test expectations update. · 8f5d1a13
      pkasting@chromium.org authored
      * platform/chromium/test_expectations.txt:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@73639 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      8f5d1a13
    • tony@chromium.org's avatar
      2010-12-09 Tony Chang <tony@chromium.org> · e3e2d244
      tony@chromium.org authored
              Unreviewed, fix for windows code.  We were catching the wrong
              exception in Windows.
      
              * Scripts/webkitpy/common/system/filesystem.py:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@73638 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      e3e2d244
    • commit-queue@webkit.org's avatar
      2010-12-09 Cosmin Truta <ctruta@chromium.org> · 81849883
      commit-queue@webkit.org authored
              Reviewed by Adam Barth.
      
              Rebaseline svg/custom/text-linking.svg
              https://bugs.webkit.org/show_bug.cgi?id=50310
      
              * platform/chromium/test_expectations.txt:
              * platform/chromium-win/svg/custom/text-linking-expected.checksum: Added.
              * platform/chromium-win/svg/custom/text-linking-expected.png: Added.
              * platform/chromium-win/svg/custom/text-linking-expected.txt: Added.
              * platform/mac-leopard/svg/custom/text-linking-expected.checksum: Updated.
              * platform/mac-leopard/svg/custom/text-linking-expected.png: Updated.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@73637 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      81849883
    • pkasting@chromium.org's avatar
      Unreviewed Chromium test expectations update. · 970fdb6f
      pkasting@chromium.org authored
      * platform/chromium-gpu/test_expectations.txt:
      * platform/chromium/test_expectations.txt:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@73636 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      970fdb6f
    • robert@webkit.org's avatar
      2010-12-09 Robert Hogan <robert@webkit.org> · 03b42a08
      robert@webkit.org authored
              Reviewed by Andreas Kling.
      
              [Qt] Search input field doesn't have cancel button
              Add a cancel button to the search field and make it customizable
              by the client. For now, use the close dialog button associated
              with the application's style as the default.
      
              Unskip a bunch of search field related tests that pass now:
      
              fast/forms/search-cancel-button-mouseup.html
              fast/forms/search-rtl.html
              fast/forms/search-abs-pos-cancel-button.html
              fast/forms/search-styled.html
              fast/forms/search-transformed.html
              fast/forms/search-zoomed.html
              fast/forms/search-cancel-button-style-sharing.html
              fast/forms/search-display-none-cancel-button.html
              fast/forms/search-placeholder-value-changed.html
              fast/repaint/search-field-cancel.html
              fast/forms/search-cancel-button-events.html
      
              https://bugs.webkit.org/show_bug.cgi?id=42887
      
              * platform/qt/Skipped:
      2010-12-09  Robert Hogan  <robert@webkit.org>
      
              Reviewed by Andreas Kling.
      
              [Qt] Search input field doesn't have cancel button
      
              Add a cancel button to the search field and make it customizable
              by the client. For now, use the close dialog button associated
              with the application's style as the default.
      
              https://bugs.webkit.org/show_bug.cgi?id=42887
      
              * platform/graphics/qt/ImageQt.cpp:
              (loadResourcePixmap):
              * platform/qt/RenderThemeQt.cpp:
              (WebCore::RenderThemeQt::computeSizeBasedOnStyle):
              (WebCore::RenderThemeQt::paintSearchField):
              (WebCore::RenderThemeQt::adjustSearchFieldStyle):
              (WebCore::RenderThemeQt::adjustSearchFieldCancelButtonStyle):
              (WebCore::RenderThemeQt::convertToPaintingRect):
              (WebCore::RenderThemeQt::paintSearchFieldCancelButton):
              * platform/qt/RenderThemeQt.h:
      2010-12-09  Robert Hogan  <robert@webkit.org>
      
              Reviewed by Andreas Kling.
      
              [Qt] Search input field doesn't have cancel button
      
              Add a cancel button to the search field and make it customizable
              by the client. For now, use the close dialog button associated
              with the application's style as the default.
      
              https://bugs.webkit.org/show_bug.cgi?id=42887
      
              * Api/qwebsettings.cpp:
              (graphics):
              * Api/qwebsettings.h:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@73635 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      03b42a08
    • yael.aharon@nokia.com's avatar
      2010-12-09 Yael Aharon <yael.aharon@nokia.com> · a2bd2744
      yael.aharon@nokia.com authored
              Reviewed by Antonio Gomes.
      
              Spatial Navigation: Crash when handling iframe of size 0.
              https://bugs.webkit.org/show_bug.cgi?id=50730
      
              * fast/spatial-navigation/snav-hidden-iframe-zero-size-expected.txt: Added.
              * fast/spatial-navigation/snav-hidden-iframe-zero-size.html: Added.
      2010-12-09  Yael Aharon  <yael.aharon@nokia.com>
      
              Reviewed by Antonio Gomes.
      
              Spatial Navigation: Crash when handling iframe of size 0.
              https://bugs.webkit.org/show_bug.cgi?id=50730
      
              if we have a frame of size 0, we would get into infinite loop and eventually crash. The reason is
              that when the algorithm sees a starting rect of size 0, it assumes that there is no focused node,
              thus restarts itself. The solution is to avoid considering iframes with size 0 for the spatial
              navigation algorithm.
      
              Test: fast/spatial-navigation/snav-hidden-iframe-zero-size.html
      
              * page/FocusController.cpp:
              (WebCore::updateFocusCandidateIfNeeded):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@73634 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      a2bd2744
    • hans@chromium.org's avatar
      2010-12-09 Sheriff Bot <webkit.review.bot@gmail.com> · c60f78d5
      hans@chromium.org authored
              Unreviewed, rolling out r73616.
              http://trac.webkit.org/changeset/73616
              https://bugs.webkit.org/show_bug.cgi?id=50772
      
              Breaks chromium win build (Requested by hwennborg on #webkit).
      
              * public/WebIDBKey.h:
              (WebKit::WebIDBKey::WebIDBKey):
              * src/WebIDBKey.cpp:
              (WebKit::WebIDBKey::assign):
              (WebKit::WebIDBKey::number):
      2010-12-09  Sheriff Bot  <webkit.review.bot@gmail.com>
      
              Unreviewed, rolling out r73616.
              http://trac.webkit.org/changeset/73616
              https://bugs.webkit.org/show_bug.cgi?id=50772
      
              Breaks chromium win build (Requested by hwennborg on #webkit).
      
              * bindings/v8/IDBBindingUtilities.cpp:
              (WebCore::createIDBKeyFromValue):
              * bindings/v8/custom/V8IDBKeyCustom.cpp:
              (WebCore::toV8):
              * storage/IDBFactoryBackendImpl.cpp:
              (WebCore::createTables):
              (WebCore::IDBFactoryBackendImpl::open):
              * storage/IDBKey.cpp:
              (WebCore::IDBKey::IDBKey):
              (WebCore::IDBKey::fromQuery):
              (WebCore::IDBKey::bind):
              (WebCore::IDBKey::bindWithNulls):
              * storage/IDBKey.h:
              (WebCore::IDBKey::create):
              (WebCore::IDBKey::number):
      2010-12-09  Sheriff Bot  <webkit.review.bot@gmail.com>
      
              Unreviewed, rolling out r73616.
              http://trac.webkit.org/changeset/73616
              https://bugs.webkit.org/show_bug.cgi?id=50772
      
              Breaks chromium win build (Requested by hwennborg on #webkit).
      
              * storage/indexeddb/index-basics-expected.txt:
              * storage/indexeddb/index-basics.html:
              * storage/indexeddb/index-cursor.html:
              * storage/indexeddb/keyrange-expected.txt:
              * storage/indexeddb/keyrange.html:
              * storage/indexeddb/objectstore-cursor.html:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@73633 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      c60f78d5
    • bweinstein@apple.com's avatar
      Land failing expected results for editing tests that have been failing since they were · b75d23c9
      bweinstein@apple.com authored
      added in r73548.
              
      Fixing the failures is being tracked by: https://bugs.webkit.org/show_bug.cgi?id=50731.
      
      * platform/win/editing/selection/caret-ltr-right-expected.txt: Added.
      * platform/win/editing/selection/caret-rtl-2-left-expected.txt: Added.
      * platform/win/editing/selection/caret-rtl-right-expected.txt: Added.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@73632 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      b75d23c9
    • andersca@apple.com's avatar
      Don't leak the PDFDocument · 42ab217c
      andersca@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=50771
      
      Reviewed by Sam Weinig.
      
      * UIProcess/API/mac/PDFViewController.mm:
      (WebKit::PDFViewController::setPDFDocumentData):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@73631 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      42ab217c
    • andersca@apple.com's avatar
      Add a basic implementation of PDF support on Mac · 97ad4527
      andersca@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=50768
      
      Reviewed by Sam Weinig.
      
      * UIProcess/API/mac/PDFViewController.h:
      * UIProcess/API/mac/PDFViewController.mm: Added.
      (-[WKPDFView initWithFrame:PDFViewController:WebKit::]):
      Setup the view hierarchy.
      
      (-[WKPDFView invalidate]):
      Set the controller to null.
      
      (-[WKPDFView pdfView]):
      Return the PDF view.
      
      (WebKit::PDFViewController::create):
      (WebKit::PDFViewController::PDFViewController):
      Create a WKPDFView and insert it as a subview of the WKView.
      
      (WebKit::PDFViewController::~PDFViewController):
      Remove the WKPDFView from the view hierarchy and invalidate it.
      
      (WebKit::convertPostScriptDataSourceToPDF):
      Convert the data in the data reference to PDF and return it as a CFDataRef.
      
      (WebKit::PDFViewController::setPDFDocumentData):
      Create a PDFDocument and set it on the PDF view.
      
      (WebKit::PDFViewController::pdfDocumentClass):
      (WebKit::PDFViewController::pdfPreviewViewClass):
      (WebKit::PDFViewController::pdfKitBundle):
      Add soft-linking helper functions.
      
      * UIProcess/API/mac/PageClientImpl.mm:
      (WebKit::PageClientImpl::didCommitLoadForMainFrame):
      (WebKit::PageClientImpl::didFinishLoadingDataForCustomRepresentation):
      Call the WKView methods.
      
      * UIProcess/API/mac/WKView.mm:
      (-[WKView _setPageHasCustomRepresentation:]):
      Create a PDF view controller if necessary.
      
      (-[WKView _didFinishLoadingDataForCustomRepresentation:CoreIPC::]):
      Pass the data along to the PDF view controller.
      
      * WebKit2.xcodeproj/project.pbxproj:
      Add new files.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@73630 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      97ad4527
    • tonikitoo@webkit.org's avatar
      2010-12-09 Antonio Gomes <agomes@rim.com> · f382a754
      tonikitoo@webkit.org authored
              Rubber stamped by Gustavo Noronha.
      
              Buildfix for GTK+ with building with -no-video.
      
              paintStockIcon static function was implemented under the ENABLE(VIDEO) guard
              but used from outside the guard. See RenderThemeGtk::paintSearchFieldResultsDecoration()
              and RenderThemeGtk::paintSearchFieldCancelButton() methods.
      
              * platform/gtk/RenderThemeGtk.cpp:
              (WebCore::getMediaElementFromRenderObject):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@73629 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      f382a754
    • tonikitoo@webkit.org's avatar
      2010-12-09 Antonio Gomes <agomes@rim.com> · a537513b
      tonikitoo@webkit.org authored
              Reviewed by Martin Robinson.
      
              [Gtk] Populate DumpRenderTreeSupportGtk (part IV)
              https://bugs.webkit.org/show_bug.cgi?id=48429
      
              WebKit/gtk:
              Moved also webkit_worker_thread_count() to DumpRenderTreeSupportGtk,
              since it was only used by DRT for now.
      
              Since this method was the only one in webkitworker.cpp, the file was
              also removed.
      
              * GNUmakefile.am:
              * WebCoreSupport/DumpRenderTreeSupportGtk.cpp:
              (DumpRenderTreeSupportGtk::workerThreadCount):
              * WebCoreSupport/DumpRenderTreeSupportGtk.h:
              * webkit/webkitprivate.h:
              * webkit/webkitworkers.cpp: Removed.
      
              WebKitTools/DumpRenderTree/gtk:
              Adjust call sites of webkit_thread_count to use the DumpRenderTreeSupportGtk version now.
      
              * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
              (LayoutTestController::workerThreadCount):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@73628 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      a537513b
    • tonikitoo@webkit.org's avatar
      2010-12-07 Antonio Gomes <agomes@rim.com> · a2bb1224
      tonikitoo@webkit.org authored
              Reviewed by Daniel Bates.
      
              Spatial Navigation: code clean up
              https://bugs.webkit.org/show_bug.cgi?id=50666
      
              Patch unifies two FocusCandidate constructors, making caller sites
              simpler. Now the special handling HTMLAreaElement gets is done within
              the non default constructor (i.e. FocusCanditate(Node*, FocusDirection)).
      
              No new tests needed.
      
              * page/FocusController.cpp:
              (WebCore::FocusController::findFocusCandidateInContainer):
              * page/SpatialNavigation.cpp:
              (WebCore::FocusCandidate::FocusCandidate):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@73627 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      a2bb1224
    • philn@webkit.org's avatar
      2010-12-09 Philippe Normand <pnormand@igalia.com> · 646b03b1
      philn@webkit.org authored
              Reviewed by Eric Carlson.
      
              [GStreamer] disable fullscreen on MacOS Tiger and Leopard
              https://bugs.webkit.org/show_bug.cgi?id=50748
      
              Don't support fullscreen video on Tiger and Leopard, just like the
              QTKit player.
      
              * platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:
              (WebCore::MediaPlayerPrivateGStreamer::supportsFullscreen):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@73626 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      646b03b1
    • andersca@apple.com's avatar
      Add support for custom representation · 481efa35
      andersca@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=50767
      
      Reviewed by Sam Weinig.
      
      * Shared/WebProcessCreationParameters.cpp:
      (WebKit::WebProcessCreationParameters::encode):
      (WebKit::WebProcessCreationParameters::decode):
      * Shared/WebProcessCreationParameters.h:
      Add mimeTypesWithCustomRepresentation and encode and decode accordingly.
      
      * UIProcess/API/mac/PageClientImpl.h:
      * UIProcess/API/mac/PageClientImpl.mm:
      (WebKit::PageClientImpl::didCommitLoadForMainFrame):
      (WebKit::PageClientImpl::didFinishLoadingDataForCustomRepresentation):
      Add empty stubs for now.
      
      * UIProcess/API/qt/qwkpage.cpp:
      (QWKPagePrivate::didCommitLoadForMainFrame):
      (QWKPagePrivate::didFinishLoadingDataForCustomRepresentation):
      * UIProcess/API/qt/qwkpage_p.h:
      Add empty stubs.
      
      * UIProcess/PageClient.h:
      Add new functions for custom representations.
      
      * UIProcess/WebFrameProxy.cpp:
      (WebKit::WebFrameProxy::canShowMIMEType):
      Check that the mime type is not null.
      
      * UIProcess/WebPageProxy.cpp:
      (WebKit::WebPageProxy::didCommitLoadForFrame):
      This now takes an additional frameHasCustomRepresentation parameter.
      Call the page client function.
      
      (WebKit::WebPageProxy::didFinishLoadingDataForCustomRepresentation):
      Call the page client function.
      
      * UIProcess/WebPageProxy.messages.in:
      Change DidCommitLoadForFrame message, add DidFinishLoadingDataForCustomRepresentation message.
      
      * UIProcess/mac/WebContextMac.mm:
      (WebKit::WebContext::platformInitializeWebProcess):
      We want to use custom representations for PDF and PostScript MIME types.
      
      * UIProcess/win/WebView.cpp:
      (WebKit::WebView::didCommitLoadForMainFrame):
      (WebKit::WebView::didFinishLoadingDataForCustomRepresentation):
      * UIProcess/win/WebView.h:
      Add stubs.
      
      * WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:
      (WebKit::WebFrameLoaderClient::WebFrameLoaderClient):
      Initialize m_frameHasCustomRepresentation.
      
      (WebKit::WebFrameLoaderClient::hasHTMLView):
      The frame has a HTML view unless it has a custom representation.
      
      (WebKit::WebFrameLoaderClient::dispatchDidCommitLoad):
      Pass along whether the frame has a custom representation.
      
      (WebKit::WebFrameLoaderClient::committedLoad):
      Don't send data back to WebCore if the frame has a custom representation.
      
      (WebKit::WebFrameLoaderClient::finishedLoading):
      Send all the data to the UI process.
      
      (WebKit::WebFrameLoaderClient::transitionToCommittedForNewPage):
      Update the m_frameHasCustomRepresentation state based on the MIME type.
      
      * WebProcess/WebCoreSupport/WebFrameLoaderClient.h:
      (WebKit::WebFrameLoaderClient::frameHasCustomRepresentation):
      Add getter.
      
      * WebProcess/WebPage/mac/ChunkedUpdateDrawingAreaMac.cpp:
      (WebKit::ChunkedUpdateDrawingArea::paintIntoUpdateChunk):
      Don't do any painting if the main frame has a custom representation.
      
      * WebProcess/WebProcess.cpp:
      (WebKit::WebProcess::initializeWebProcess):
      Add all the MIME types with custom representations.
      
      * WebProcess/WebProcess.h:
      (WebKit::WebProcess::shouldUseCustomRepresentationForMIMEType):
      Add getter.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@73625 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      481efa35
    • philn@webkit.org's avatar
      2010-12-06 Philippe Normand <pnormand@igalia.com> · 9d37a571
      philn@webkit.org authored
              Reviewed by Martin Robinson.
      
              [GTK] Support the Mozilla-style Fullscreen Javascript API
              https://bugs.webkit.org/show_bug.cgi?id=50572
      
              * configure.ac: new configure flag to disable the new Javascript
              Fullscreen API build. It is enabled by default.
      
      WebCore:
      
              Reviewed by Martin Robinson.
      
              [GTK] Support the Mozilla-style Fullscreen Javascript API
              https://bugs.webkit.org/show_bug.cgi?id=50572
      
              * GNUmakefile.am: enable the Javascript Fullscreen API feature if
              it's been requested at configure time.
      
      WebKit/gtk:
      
              Reviewed by Martin Robinson.
      
              [GTK] Support the Mozilla-style Fullscreen Javascript API
              https://bugs.webkit.org/show_bug.cgi?id=50572
      
              Fullscreen API support. It is controlled at runtime using a new
              setting called enable-fullscreen, set to FALSE by default.
      
              * WebCoreSupport/ChromeClientGtk.cpp:
              (WebKit::ChromeClient::supportsFullScreenForElement):
              (WebKit::ChromeClient::enterFullScreenForElement):
              (WebKit::ChromeClient::exitFullScreenForElement):
              * WebCoreSupport/ChromeClientGtk.h:
              * webkit/webkitwebsettings.cpp:
              (webkit_web_settings_class_init):
              (webkit_web_settings_set_property):
              (webkit_web_settings_get_property):
              (webkit_web_settings_copy):
              * webkit/webkitwebview.cpp:
              (webkit_web_view_update_settings):
      
      WebKitTools:
      
              Reviewed by Martin Robinson.
      
              [GTK] Support the Mozilla-style Fullscreen Javascript API
              https://bugs.webkit.org/show_bug.cgi?id=50572
      
              Enable the Javascript Fullscreen support in the GtkLauncher. Also
              make DRT update the Chrome when the WebView settings have been
              reset to consistent values.
      
              * DumpRenderTree/gtk/DumpRenderTree.cpp:
              (resetDefaultsToConsistentValues):
              * GtkLauncher/main.c:
              (create_window):
              * Scripts/build-webkit:
      
      LayoutTests:
      
              Reviewed by Martin Robinson.
      
              [GTK] Support the Mozilla-style Fullscreen Javascript API
              https://bugs.webkit.org/show_bug.cgi?id=50572
      
              * platform/gtk/Skipped: Unskip now passing fullscreen tests.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@73624 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      9d37a571
    • msaboff@apple.com's avatar
      2010-12-09 Michael Saboff <msaboff@apple.com> · 86ea014e
      msaboff@apple.com authored
              Reviewed by Geoffrey Garen.
      
              Addressed the "FIXME" issues in array sort for toString() methods that
              mutate the array in either size or contents.  The change is to mark
              the temporary array contents so that they are not garbage collected
              and to make sure the array is large enough to hold the contents
              of the sorted temporary vector.
              https://bugs.webkit.org/show_bug.cgi?id=50718
      
              * runtime/Collector.cpp:
              (JSC::Heap::addTempSortVector):
              (JSC::Heap::removeTempSortVector):
              (JSC::Heap::markTempSortVectors):
              (JSC::Heap::markRoots):
              * runtime/Collector.h:
              * runtime/JSArray.cpp:
              (JSC::JSArray::sort):
              * runtime/JSValue.h:
      2010-12-09  Michael Saboff  <msaboff@apple.com>
      
              Reviewed by Geoffrey Garen.
      
              New test to verify that arrays sort per the standard even it
              there is an override for toString() that modifies the array.
              https://bugs.webkit.org/show_bug.cgi?id=50718
      
              * fast/js/array-sort-modifying-tostring-expected.txt: Added.
              * fast/js/array-sort-modifying-tostring.html: Added.
              * fast/js/script-tests/array-sort-modifying-tostring.js: Added.
              (do_gc):
              (Item):
              (toString_Mutate):
              (test):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@73623 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      86ea014e
    • commit-queue@webkit.org's avatar
      2010-12-09 Yong Li <yoli@rim.com> · a97d5476
      commit-queue@webkit.org authored
              Reviewed by Darin Adler.
      
              Check the return value of ImageBuffer::create()
              to avoid crash when ImageBuffer::create() fails.
              https://bugs.webkit.org/show_bug.cgi?id=50631
      
              No new test because it relies on the platform implementation
              of ImageBuffer. It is hard to make ImageBuffer::create() fail
              in most ports.
      
              * platform/graphics/GeneratedImage.cpp:
              (WebCore::GeneratedImage::drawPattern):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@73622 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      a97d5476
    • mjs@apple.com's avatar
      2010-12-09 Maciej Stachowiak <mjs@apple.com> · 32fd6197
      mjs@apple.com authored
              Reviewed by Dan Bernstein.
      
              Implement "Use Selection for Find" in WebKit2
              https://bugs.webkit.org/show_bug.cgi?id=50737
              <rdar://problem/8564881>
      
              Implement a TakeFindStringFromSelection editor command. This is
              used solely to implement the "Use Selection for Find" menu command
              on Mac, and is not made available to script. On WebKit2, it is
              very convenient to reuse the editing machinery since this command
              is very similar to Copy.
      
              * editing/Editor.h:
              * editing/EditorCommand.cpp:
              (WebCore::executeTakeFindStringFromSelection): Call to a mac-only Editor function.
              (WebCore::enabledTakeFindStringFromSelection): Check using Editor::canCopyExcludingStandaloneImage
              (WebCore::createCommandMap): Add "TakeFindStringFromSelection" command.
              * editing/mac/EditorMac.mm:
              (WebCore::Editor::canCopyExcludingStandaloneImages): Helper function; we can't use Editor::canCopy
              since it would make no sense to enable "Use Selection for Find" when viewing a standalone image
              document.
              (WebCore::Editor::takeFindStringFromSelection): Implement by copying the selected text
              to the special Find pasteboard.
      2010-12-09  Maciej Stachowiak  <mjs@apple.com>
      
              Reviewed by Dan Bernstein.
      
              Implement "Use Selection for Find" in WebKit2
              https://bugs.webkit.org/show_bug.cgi?id=50737
              <rdar://problem/8564881>
              
              * UIProcess/API/mac/WKView.mm: Add support for the takeFindStringFromSelection:
              selector as a command.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@73621 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      32fd6197
    • inferno@chromium.org's avatar
      2010-12-09 Abhishek Arya <inferno@chromium.org> · fd8e006e
      inferno@chromium.org authored
              Reviewed by Dimitri Glazkov.
      
              As part of r73559, I added the referenceNode check to validate whether the root
              node of the iterator matches the node which is getting moved to other document.
              referenceNode is initialized to root, however can get moved using previousNode
              and nextNode methods, so it is required to use root directly.
              https://bugs.webkit.org/show_bug.cgi?id=50764
      
              Test: fast/dom/node-iterator-reference-node-moved-crash.html
      
              * dom/Document.cpp:
              (WebCore::Document::moveNodeIteratorsToNewDocument): change referenceNode to root.
      2010-12-09  Abhishek Arya  <inferno@chromium.org>
      
              Reviewed by Dimitri Glazkov.
      
              Tests that we do not crash when we move the referenceNode using node iterator
              methods previousNode and nextNode.
              https://bugs.webkit.org/show_bug.cgi?id=50764
      
              * fast/dom/node-iterator-reference-node-moved-crash-expected.txt: Added.
              * fast/dom/node-iterator-reference-node-moved-crash.html: Added.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@73620 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      fd8e006e
    • dglazkov@chromium.org's avatar
      2010-12-08 Dimitri Glazkov <dglazkov@chromium.org> · e5cbec63
      dglazkov@chromium.org authored
              Reviewed by Darin Adler.
      
              Provide a generic way to store shadowParent on a Node.
              https://bugs.webkit.org/show_bug.cgi?id=50184
      
              This patch makes TreeShared::m_parent act as either parentNode() or
              shadowHost() for Node. The distinction is controlled by IsShadowRootFlag.
      
              Refactoring, so no new tests. See performance result testing in bug.
      
              * dom/Element.cpp:
              (WebCore::Element::recalcStyle): Changed to use parentOrHostNode().
              * dom/Node.cpp:
              (WebCore::Node::shadowHost): Added.
              (WebCore::Node::setShadowHost): Added.
              (WebCore::Node::isContentEditable): Changed to use parentOrHostNode().
              (WebCore::Node::isContentRichlyEditable): Ditto.
              (WebCore::Node::nextRenderer): Ditto.
              (WebCore::Node::virtualComputedStyle): Ditto.
              (WebCore::Node::canStartSelection): Ditto.
              (WebCore::Node::shadowTreeRootNode): Changed to use parentNodeGuaranteedHostFree().
              (WebCore::Node::getEventAncestors): Ditto.
              (WebCore::Node::defaultEventHandler): Changed to use parentOrHostNode().
              * dom/Node.h: Added an extra flag and adjusted bit counts.
              (WebCore::Node::isShadowNode): Made non-virtual, switched to use flag.
              (WebCore::Node::parentNode): Made to recognize flag.
              (WebCore::Node::parentOrHostNode): Changed to use straight parent() and made const.
              (WebCore::Node::parentNodeGuaranteedHostFree): Added.
              (WebCore::Node::shadowParentNode): Made non-virtual and const.
              * editing/TextIterator.cpp:
              (WebCore::depthCrossingShadowBoundaries): Changed to use parentOrHostNode();
              (WebCore::nextInPreOrderCrossingShadowBoundaries): Ditto.
              (WebCore::previousInPostOrderCrossingShadowBoundaries):  Ditto.
              (WebCore::setUpFullyClippedStack): Ditto.
              (WebCore::TextIterator::advance): Ditto.
              (WebCore::SimplifiedBackwardsTextIterator::advance): Ditto.
              * page/DOMSelection.cpp:
              (WebCore::DOMSelection::anchorNode): Changed to use parentNodeGuaranteedHostFree().
              (WebCore::DOMSelection::focusNode): Ditto.
              (WebCore::DOMSelection::baseNode): Ditto.
              (WebCore::DOMSelection::extentNode): Ditto.
              (WebCore::DOMSelection::getRangeAt): Ditto.
              * rendering/MediaControlElements.cpp:
              (WebCore::MediaControlShadowRootElement::MediaControlShadowRootElement):
                  Changed to setShadowHost().
              (WebCore::MediaControlShadowRootElement::updateStyle): Changed to use shadowHost().
              (WebCore::MediaControlShadowRootElement::detach): Added an override to
                  explicitly set shadowHost to 0. Otherwise, the element will leak.
              * rendering/MediaControlElements.h: Added detach def, removed members that are
                  no longer needed.
              * rendering/RenderSVGShadowTreeRootContainer.cpp:
              (WebCore::RenderSVGShadowTreeRootContainer::~RenderSVGShadowTreeRootContainer):
                  Added explicit clearing of shadowHost to avoid leaking and crashes,
                  because SVG shadow DOM can be dynamically attached/detached, producing
                  stale nodes in over/out event handling.
              * rendering/RenderSlider.cpp:
              (WebCore::SliderThumbElement::defaultEventHandler): Changed to use shadowHost().
              * rendering/RenderTextControlSingleLine.cpp:
              (WebCore::RenderTextControlSingleLine::~RenderTextControlSingleLine):
                  Added explicit clearing of shadowHost and explicit destruction to
                  avoid out-of-order removal of children.
              * rendering/RenderTreeAsText.cpp:
              (WebCore::nodePosition): Simplified code.
              * rendering/SVGShadowTreeElements.cpp:
              (WebCore::SVGShadowTreeRootElement::SVGShadowTreeRootElement): Added
                  setting of shadowHost.
              (WebCore::SVGShadowTreeRootElement::attachElement): Changed to use shadowHost().
              (WebCore::SVGShadowTreeRootElement::clearShadowHost): Added.
              * rendering/SVGShadowTreeElements.h: Added def, removed members that are
                   no longer needed.
              * rendering/ShadowElement.cpp:
              (WebCore::ShadowBlockElement::initAsPart): Changed to use shadowHost().
              * rendering/ShadowElement.h: Removed members that are no longer needed.
              (WebCore::ShadowElement::ShadowElement): Added setting of shadowHost.
              (WebCore::ShadowElement::detach): Added.
              * rendering/TextControlInnerElements.cpp:
              (WebCore::TextControlInnerElement::TextControlInnerElement): Added setting
                  of shadowHost.
              (WebCore::TextControlInnerElement::attachInnerElement): Changed to use
                  isShadowNode().
              (WebCore::TextControlInnerElement::detach): Added.
              * rendering/TextControlInnerElements.h: Removed members that are no
                  longer needed.
              * svg/SVGElement.cpp:
              (WebCore::SVGElement::ownerSVGElement): Simplified code.
              (WebCore::SVGElement::viewportElement): Ditto.
              * svg/SVGLocatable.cpp:
              (WebCore::SVGLocatable::computeCTM): Ditto.
              * svg/SVGStyledElement.cpp:
              (WebCore::SVGStyledElement::title): Ditto.
              * svg/SVGUseElement.cpp:
              (WebCore::ShadowTreeUpdateBlocker::while): Ditto.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@73618 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      e5cbec63
    • msaboff@apple.com's avatar
      2010-12-09 Michael Saboff <msaboff@apple.com> · 9068f350
      msaboff@apple.com authored
              Reviewed by Darin Adler.
      
              Changed setting of backtrack labels to not overwrite a prior
              label.  Where losing prior labe which then reverted back to 
              next character label.
              https://bugs.webkit.org/show_bug.cgi?id=50579
      
              * yarr/RegexJIT.cpp:
              (JSC::Yarr::RegexGenerator::BacktrackDestination::setBacktrackToLabel):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@73617 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      9068f350
    • hans@chromium.org's avatar
      2010-12-09 Hans Wennborg <hans@chromium.org> · 976f357f
      hans@chromium.org authored
              Reviewed by Jeremy Orlow.
      
              IndexedDB: Numeric keys are floats.
              https://bugs.webkit.org/show_bug.cgi?id=50674
      
              Update layout tests to use floating-point values for keys.
      
              * storage/indexeddb/keyrange-expected.txt:
              * storage/indexeddb/keyrange.html:
              Make sure creating the keys works.
              * storage/indexeddb/objectstore-cursor-expected.txt:
              * storage/indexeddb/objectstore-cursor.html:
              Make sure retrieving the keys from the DB objectstore works.
      2010-12-09  Hans Wennborg  <hans@chromium.org>
      
              Reviewed by Jeremy Orlow.
      
              IndexedDB: Numeric keys are floats.
              https://bugs.webkit.org/show_bug.cgi?id=50674
      
              Use floating point to represent numeric keys,
              add version meta data to the SQLite db,
              and migrate object stores that use integers.
      
              * bindings/v8/IDBBindingUtilities.cpp:
              (WebCore::createIDBKeyFromValue):
              * bindings/v8/custom/V8IDBKeyCustom.cpp:
              (WebCore::toV8):
              * storage/IDBFactoryBackendImpl.cpp:
              (WebCore::createTables):
              (WebCore::migrateDatabase):
              (WebCore::IDBFactoryBackendImpl::open):
              * storage/IDBKey.cpp:
              (WebCore::IDBKey::IDBKey):
              (WebCore::IDBKey::fromQuery):
              (WebCore::IDBKey::bind):
              (WebCore::IDBKey::bindWithNulls):
              * storage/IDBKey.h:
              (WebCore::IDBKey::create):
              (WebCore::IDBKey::number):
      2010-12-09  Hans Wennborg  <hans@chromium.org>
      
              Reviewed by Jeremy Orlow.
      
              IndexedDB: Numeric keys are floats.
              https://bugs.webkit.org/show_bug.cgi?id=50674
      
              Represent numeric keys as floating point values.
      
              * public/WebIDBKey.h:
              (WebKit::WebIDBKey::WebIDBKey):
              * src/WebIDBKey.cpp:
              (WebKit::WebIDBKey::assign):
              (WebKit::WebIDBKey::number):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@73616 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      976f357f
    • msaboff@apple.com's avatar
      2010-06-28 Michael Saboff <msaboff@apple.com> · 8bebb7df
      msaboff@apple.com authored
              Reviewed by Darin Adler.
      
              Bug 41238 - RegExp performance slow on Dromaeo benchmark
      
              Other javascript engines appear to cache prior results of regular 
              expression operations.
      
              Suggest adding some sort of caching mechanism to regular expression 
              processing.
      
              Added a single entry cache of match() results to RegExp class.
      
              Also added performance improvements to UString == operator.
              First check the impls for equality.  Then get the length of
              each of the non-null impls.  Next check the sizes for equality.
              Then check the data for the case of different impls that point 
              to the same data (most likely due to substrings from the beginning of
              another string).  Lastly we check the underlying data for equality.
      
              Refactored Vector<>::operator=() method into a separate copy() method 
              that it calls.  The copy() method is explicitly used for deep copying.
      
              * runtime/RegExp.cpp:
              (JSC::RegExp::RegExp):
              (JSC::RegExp::match):
              * runtime/RegExp.h:
              * runtime/UString.h:
              (JSC::operator==):
              * wtf/Vector.h:
              (WTF::::operator):
              (WTF::::copy):
      
      2010-12-09  Michael Saboff  <msaboff@apple.com>
      
              Reviewed by Darin Adler.
      
              Added test to verify proper operation of backtrack labels.
              https://bugs.webkit.org/show_bug.cgi?id=50579
      
              * fast/regex/parentheses-expected.txt:
              * fast/regex/script-tests/parentheses.js:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@73615 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      8bebb7df
    • beidson@apple.com's avatar
      <rdar://problem/7660733> and https://bugs.webkit.org/show_bug.cgi?id=50191 · 67dc2b25
      beidson@apple.com authored
      WebKit2 Authentication Support
      
      Reviewed by Maciej Stachowiak.
      
      WebCore: 
      
      * WebCore.exp.in:
      
      WebKit2: 
      
      Implement authentication-related coders:
      * Shared/WebCoreArgumentCoders.h:
      
      Allow the ResourceResponse coders to handle null responses:
      * Shared/mac/WebCoreArgumentCodersMac.mm:
      (CoreIPC::encodeResourceResponse):
      (CoreIPC::decodeResourceResponse):
      
      Add new API and Impl casts for ProtectionSpace and Credential enums:
      * UIProcess/API/C/WKAPICast.h:
      (WebKit::toAPI):
      (WebKit::toCredentialPersistence):
      
      Move the DecisionListener to be accessed off the challenge itself, and fill in other
      necessary API:
      * UIProcess/API/C/WKAuthenticationChallenge.cpp:
      (WKAuthenticationChallengeGetDecisionListener):
      (WKAuthenticationChallengeGetProtectionSpace):
      (WKAuthenticationChallengeGetProposedCredential):
      (WKAuthenticationChallengeGetPreviousFailureCount):
      * UIProcess/API/C/WKAuthenticationChallenge.h:
      * UIProcess/Authentication/AuthenticationChallengeProxy.cpp:
      (WebKit::AuthenticationChallengeProxy::~AuthenticationChallengeProxy):
      (WebKit::AuthenticationChallengeProxy::proposedCredential):
      (WebKit::AuthenticationChallengeProxy::protectionSpace):
      * UIProcess/Authentication/AuthenticationChallengeProxy.h:
      (WebKit::AuthenticationChallengeProxy::previousFailureCount):
      
      Fill in some credential API:
      * UIProcess/API/C/WKCredential.cpp:
      (WKCredentialCreate):
      (WKCredentialCopyUser):
      * UIProcess/API/C/WKCredential.h:
      * UIProcess/API/C/WKCredentialTypes.h: Added.
      * UIProcess/Authentication/WebCredential.cpp:
      (WebKit::WebCredential::WebCredential):
      (WebKit::WebCredential::user):
      * UIProcess/Authentication/WebCredential.h:
      (WebKit::WebCredential::create):
      
      Fill in some protection space API:
      * UIProcess/API/C/WKProtectionSpace.cpp:
      (WKProtectionSpaceCopyHost):
      (WKProtectionSpaceGetPort):
      (WKProtectionSpaceCopyRealm):
      (WKProtectionSpaceGetIsProxy):
      (WKProtectionSpaceGetServerType):
      (WKProtectionSpaceGetReceivesCredentialSecurely):
      (WKProtectionSpaceGetAuthenticationScheme):
      * UIProcess/API/C/WKProtectionSpace.h:
      * UIProcess/API/C/WKProtectionSpaceTypes.h: Added.
      * UIProcess/Authentication/WebProtectionSpace.cpp:
      (WebKit::WebProtectionSpace::WebProtectionSpace):
      (WebKit::WebProtectionSpace::host):
      (WebKit::WebProtectionSpace::port):
      (WebKit::WebProtectionSpace::realm):
      (WebKit::WebProtectionSpace::isProxy):
      (WebKit::WebProtectionSpace::serverType):
      (WebKit::WebProtectionSpace::receivesCredentialSecurely):
      (WebKit::WebProtectionSpace::authenticationScheme):
      * UIProcess/Authentication/WebProtectionSpace.h:
      
      Change the authentication challenge callback to reflect the new ownership of
      the DecisionListener:
      * UIProcess/API/C/WKPage.h:
      * UIProcess/WebLoaderClient.cpp:
      (WebKit::WebLoaderClient::didReceiveAuthenticationChallengeInFrame):
      * UIProcess/WebLoaderClient.h:
      * UIProcess/WebPageProxy.cpp:
      (WebKit::WebPageProxy::didReceiveAuthenticationChallenge):
      
      * WebKit2.pro:
      * WebKit2.xcodeproj/project.pbxproj:
      * win/WebKit2.vcproj:
      * win/WebKit2Generated.make:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@73614 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      67dc2b25
    • commit-queue@webkit.org's avatar
      2010-12-09 Peter Beverloo <peter@lvp-media.com> · ea4caf4e
      commit-queue@webkit.org authored
              Reviewed by Maciej Stachowiak.
      
              Default CSS definitions for the figure and figcaption elements.
      
              * fast/html/figcaption-element-expected.txt: Added.
              * fast/html/figcaption-element.html: Added.
              * fast/html/figure-element-expected.txt: Added.
              * fast/html/figure-element.html: Added.
              * fast/html/script-tests/figcaption-element.js: Added.
              * fast/html/script-tests/figure-element.js: Added.
      2010-12-09  Peter Beverloo  <peter@lvp-media.com>
      
              Reviewed by Maciej Stachowiak.
      
              Default CSS definitions for the figure and figcaption elements.
      
              Tests: fast/html/figcaption-element.html
                     fast/html/figure-element.html
      
              * css/html.css:
              (figure): The default figure-style equals a blockquote
              (figcaption): A non-sectioning block-level element
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@73613 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      ea4caf4e
    • yael.aharon@nokia.com's avatar
      2010-12-09 Yael Aharon <yael.aharon@nokia.com> · 37cf3292
      yael.aharon@nokia.com authored
              Reviewed by Antonio Gomes.
      
              Spatial Navigation: more tests.
              https://bugs.webkit.org/show_bug.cgi?id=50728
      
              * fast/spatial-navigation/snav-hidden-focusable-element-expected.txt: Added.
              * fast/spatial-navigation/snav-hidden-focusable-element.html: Added.
              * fast/spatial-navigation/snav-hidden-iframe-expected.txt: Added.
              * fast/spatial-navigation/snav-hidden-iframe.html: Added.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@73612 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      37cf3292
    • andreas.kling@nokia.com's avatar
      2010-12-09 Koan-Sin Tan <koansin.tan@gmail.com> · 99458a5a
      andreas.kling@nokia.com authored
              Reviewed by Tor Arne Vestbø
      
              [Qt] run-launcher doesn't start the browser on Mac OS X 10.6
              https://bugs.webkit.org/show_bug.cgi?id=50742
      
              check not only QtWebKit.framework/QtWebKit but also libQtWebKit.dylib
      
              * Scripts/webkitdirs.pm:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@73611 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      99458a5a
    • commit-queue@webkit.org's avatar
      2010-12-09 Alex Bredariol Grilo <abgrilo@profusion.mobi> · c6144972
      commit-queue@webkit.org authored
              Reviewed by Antonio Gomes.
      
              [EFL] Fix scroll operation in WebKit-EFL
              https://bugs.webkit.org/show_bug.cgi?id=50752
      
              Add the _ewk_view_scroll_add call in WebKit-EFL scroll function. This
              call was wrongly removed in previous commit and performs the scroll
              operation on the page.
      
              * ewk/ewk_view.cpp:
              (ewk_view_scroll):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@73610 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      c6144972
    • ossy@webkit.org's avatar
      Unreviewed. · 0085ba4b
      ossy@webkit.org authored
      Add Qt specific expected results for tests introduced in r73548.
      Compared to Mac png files and Mac expected files.
      
      * platform/qt/editing/selection/caret-ltr-2-expected.checksum: Added.
      * platform/qt/editing/selection/caret-ltr-2-expected.png: Added.
      * platform/qt/editing/selection/caret-ltr-2-expected.txt: Added.
      * platform/qt/editing/selection/caret-ltr-2-left-expected.checksum: Added.
      * platform/qt/editing/selection/caret-ltr-2-left-expected.png: Added.
      * platform/qt/editing/selection/caret-ltr-2-left-expected.txt: Added.
      * platform/qt/editing/selection/caret-ltr-expected.checksum: Added.
      * platform/qt/editing/selection/caret-ltr-expected.png: Added.
      * platform/qt/editing/selection/caret-ltr-expected.txt: Added.
      * platform/qt/editing/selection/caret-ltr-right-expected.checksum: Added.
      * platform/qt/editing/selection/caret-ltr-right-expected.png: Added.
      * platform/qt/editing/selection/caret-ltr-right-expected.txt: Added.
      * platform/qt/editing/selection/caret-rtl-2-left-expected.checksum: Added.
      * platform/qt/editing/selection/caret-rtl-2-left-expected.png: Added.
      * platform/qt/editing/selection/caret-rtl-2-left-expected.txt: Added.
      * platform/qt/editing/selection/caret-rtl-right-expected.checksum: Added.
      * platform/qt/editing/selection/caret-rtl-right-expected.png: Added.
      * platform/qt/editing/selection/caret-rtl-right-expected.txt: Added.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@73609 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      0085ba4b
    • commit-queue@webkit.org's avatar
      2010-12-09 Joone Hur <joone@kldp.org> · 7a9a1855
      commit-queue@webkit.org authored
              Reviewed by Martin Robinson.
      
              [GTK] Support for viewport meta tag
              https://bugs.webkit.org/show_bug.cgi?id=45443
      
              Included viewport test cases for WebKitGtk
      
              * platform/gtk/Skipped: Unskip fast/viewport except viewport-45.html.
      2010-12-09  Joone Hur  <joone@kldp.org>
      
              Reviewed by Martin Robinson.
      
              [GTK] Support for viewport meta tag
              https://bugs.webkit.org/show_bug.cgi?id=45443
      
              This patch adds a new gobject to offer the viewport properties to user agents.
              It is WebKitViewportAttributes that contains the viewport size, initial scale with limits,
              and information about whether a user is able to scale the contents in the viewport.
      
              This feature was introduced by Safari on the iPhone. For more information on
              the viewport properties, refer to the Safari reference library at
              http://developer.apple.com/safari/library/documentation/appleapplications/reference/safarihtmlref/articles/metatags.html
      
              * GNUmakefile.am: Added webkitviewportattributes.h webkitviewportattributes.cpp.
              * WebCoreSupport/ChromeClientGtk.cpp:
              (WebKit::ChromeClient::dispatchViewportDataDidChange): Added this callback to know whether the viewport arguments is available.
              * WebCoreSupport/ChromeClientGtk.h:
              * WebCoreSupport/DumpRenderTreeSupportGtk.cpp:
              (DumpRenderTreeSupportGtk::dumpConfigurationForViewport): Added this function to compute the viewport attributes with the given availableWidth and availableHeight.
              * WebCoreSupport/DumpRenderTreeSupportGtk.h:
              * WebCoreSupport/FrameLoaderClientGtk.cpp:
              (WebKit::postCommitFrameViewSetup): Invalidate the viewport attributes.
              * webkit/webkit.h:
              * webkit/webkitdefines.h:
              * webkit/webkitprivate.h: Added webkitViewportAttributesRecompute as a private function.
              * webkit/webkitviewportattributes.cpp: Added.
              (webkit_viewport_attributes_class_init):
              (webkit_viewport_attributes_init):
              (webkit_viewport_attributes_get_property):
              (webkit_viewport_attributes_set_property):
              (webkitViewportAttributesRecompute): Recompute the optimal viewport attributes and emit the viewport-attributes-changed signal.
              (webkit_viewport_attributes_recompute): a public API for calling webkitViewportAttributesRecompute.
              * webkit/webkitviewportattributes.h: Added.
              * webkit/webkitwebview.cpp:
              (webkit_web_view_get_property): Added PROP_VIEWPORT_ATTRIBUTES.
              (webkit_web_view_dispose): Deallocate the WebKitViewportAttributes instance.
              (webkit_web_view_class_init): Added the viewport-attributes-recompute-requested and viewport-attributes-changed signals.
              (webkit_web_view_init): Set the WebKitViewportAttributes instance.
              (webkit_web_view_get_viewport_attributes): Added a getter to obtain the WebKitViewportAttributes instance held by the given WebKitWebView.
              * webkit/webkitwebview.h:
              * webkit/webkitwebviewprivate.h: Added WebKitViewportAttributes as a private variable.
      2010-12-09  Joone Hur  <joone@kldp.org>
      
               Reviewed by Martin Robinson.
      
               [GTK] Support for viewport meta tag
               https://bugs.webkit.org/show_bug.cgi?id=45443
      
               Add support for testing the viewport properties for WebKitGtk.
      
               * DumpRenderTree/LayoutTestController.cpp:
               (dumpConfigurationForViewportCallback): Added this JS callback to set the size of the visible viewport.
               (LayoutTestController::staticFunctions):
               * DumpRenderTree/LayoutTestController.h:
               * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
               (LayoutTestController::dumpConfigurationForViewport): Added this function to test the viewport properties.
               * DumpRenderTree/mac/LayoutTestControllerMac.mm:
               (LayoutTestController::dumpConfigurationForViewport): Ditto.
               * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
               (LayoutTestController::dumpConfigurationForViewport): Ditto.
               * DumpRenderTree/win/LayoutTestControllerWin.cpp:
               (LayoutTestController::dumpConfigurationForViewport): Ditto.
               * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
               (LayoutTestController::dumpConfigurationForViewport): Ditto.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@73608 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      7a9a1855
    • yurys@chromium.org's avatar
      2010-12-09 Yury Semikhatsky <yurys@chromium.org> · bb594650
      yurys@chromium.org authored
              Reviewed by Pavel Feldman.
      
              Web Inspector: Console records for failed XHRs should contain call stack and request method
              https://bugs.webkit.org/show_bug.cgi?id=50390
      
              The expectations needed update ue to log format changes.
      
              * http/tests/inspector-enabled/console-log-before-frame-navigation-expected.txt:
              * http/tests/inspector/console-resource-errors-expected.txt:
              * http/tests/inspector/console-xhr-logging-expected.txt:
              * platform/chromium/http/tests/inspector/console-resource-errors-expected.txt: Added.
              * platform/chromium/http/tests/inspector/console-xhr-logging-expected.txt: Copied from LayoutTests/http/tests/inspector/console-xhr-logging-expected.txt.
      2010-12-09  Yury Semikhatsky  <yurys@chromium.org>
      
              Reviewed by Pavel Feldman.
      
              Web Inspector: Console records for failed XHRs should contain call stack and request method
              https://bugs.webkit.org/show_bug.cgi?id=50390
      
              When inspector front-end is open we capture call stack at the place where request is sent and
              pass the stack along with other request data. There is a new type of console messages which
              is NetworkErrorMessageType, all messages of that type will have requestId field initialized
              with the corresponding network request identifier so that later on when we need to display
              that message in the front-end we could pull request data from the Network panel using
              this identifier. If there are no data for given requestId message formatting falls back to
              the old implementation which lacks such things as call stack, request method and exact
              source location.
      
              * inspector/ConsoleMessage.cpp:
              (WebCore::ConsoleMessage::ConsoleMessage):
              (WebCore::ConsoleMessage::addToFrontend):
              (WebCore::ConsoleMessage::isEqual):
              * inspector/ConsoleMessage.h:
              * inspector/Inspector.idl:
              * inspector/InspectorController.cpp:
              (WebCore::InspectorController::didReceiveResponse):
              (WebCore::InspectorController::didFailLoading):
              * inspector/InspectorResourceAgent.cpp:
              (WebCore::InspectorResourceAgent::identifierForInitialRequest):
              * inspector/front-end/ConsoleView.js:
              (WebInspector.ConsoleView.prototype.updateMessageRepeatCount):
              (WebInspector.ConsoleMessage):
              (WebInspector.ConsoleMessage.prototype._formatMessage):
              (WebInspector.ConsoleMessage.prototype.toMessageElement):
              (WebInspector.ConsoleMessage.prototype.toString):
              (WebInspector.ConsoleMessage.prototype.isEqual):
              * inspector/front-end/ResourceManager.js:
              (WebInspector.ResourceManager.prototype.identifierForInitialRequest):
              * inspector/front-end/inspector.js:
              (WebInspector.addConsoleMessage):
              * page/Console.h:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@73607 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      bb594650
    • commit-queue@webkit.org's avatar
      2010-12-09 Dai Mikurube <dmikurube@google.com> · a259a13f
      commit-queue@webkit.org authored
              Reviewed by Kent Tamura.
      
              Implement "required" attribute for select tags
              https://bugs.webkit.org/show_bug.cgi?id=50380
      
              Added tests for require attributes, valueMissing and vadility check for select elements.
      
              * fast/forms/ValidityState-valueMissing-001-expected.txt:
              * fast/forms/ValidityState-valueMissing-001.html:
              * fast/forms/ValidityState-valueMissing-002-expected.txt:
              * fast/forms/ValidityState-valueMissing-002.html:
              * fast/forms/ValidityState-valueMissing-003-expected.txt:
              * fast/forms/ValidityState-valueMissing-003.html:
              * fast/forms/checkValidity-002-expected.txt:
              * fast/forms/checkValidity-002.html:
              * fast/forms/required-attribute-001-expected.txt:
              * fast/forms/required-attribute-001.html:
              * fast/forms/required-attribute-002-expected.txt:
              * fast/forms/required-attribute-002.html:
              * fast/forms/resources/select-live-pseudo-selectors.js: Added.
              (makeInvalid):
              (appendOption):
              (backgroundOf):
              * fast/forms/script-tests/validationMessage.js:
              * fast/forms/select-live-pseudo-selectors-expected.txt: Added.
              * fast/forms/select-live-pseudo-selectors.html: Added.
              * fast/forms/validationMessage-expected.txt:
              * platform/mac/fast/objc/dom-html-select-live-pseudo-selectors.html: Added.
              * platform/mac/fast/objc/dom-html-select-live-pseudo-selectors-expected.txt: Added.
      2010-12-09  Dai Mikurube  <dmikurube@google.com>
      
              Reviewed by Kent Tamura.
      
              Implement "required" attribute for select tags
              https://bugs.webkit.org/show_bug.cgi?id=50380
      
              Test: fast/forms/select-live-pseudo-selectors.html
                    platform/mac/fast/objc/dom-html-select-live-pseudo-selectors.html
      
              * dom/SelectElement.cpp:
              (WebCore::SelectElement::updateValidity): Added. It's a pure virtual function which is prepared so that HTMLSelectElement::updateValidity() calls HTMLSelectElement::setNeedsValidityCheck().
              (WebCore::SelectElement::parseMultipleAttribute): Added calling updateValidity().
              * html/HTMLSelectElement.cpp:
              (WebCore::HTMLSelectElement::deselectItems): Added calling setNeedsValidityCheck() to enable validity check after changing. No tests for this change since this function is not exposed to JavaScript or any web interface.
              (WebCore::HTMLSelectElement::setSelectedIndex): Added calling setNeedsValidityCheck().
              (WebCore::HTMLSelectElement::setSelectedIndexByUser): Added calling setNeedsValidityCheck().
              (WebCore::HTMLSelectElement::valueMissing): Added valueMissing() to check if selecting an invalid or placeholder label option when a valid required attribute is specified.
              (WebCore::HTMLSelectElement::listBoxSelectItem): Added calling setNeedsValidityCheck(). No tests for this change since it is not called yet. Look at the bug 36177 and the changeset 56180.
              (WebCore::HTMLSelectElement::add): Added calling setNeedsValidityCheck().
              (WebCore::HTMLSelectElement::remove): Added calling setNeedsValidityCheck().
              (WebCore::HTMLSelectElement::restoreFormControlState): Added calling setNeedsValidityCheck().
              (WebCore::HTMLSelectElement::parseMappedAttribute): Added calling setNeedsValidityCheck().
              (WebCore::HTMLSelectElement::selectAll): Added calling setNeedsValidityCheck().
              (WebCore::HTMLSelectElement::reset): Added calling setNeedsValidityCheck().
              (WebCore::HTMLSelectElement::updateListBoxSelection): Added calling setNeedsValidityCheck(). Skipped adding tests for this change as too complicated..
              (WebCore::HTMLSelectElement::setLength): Added calling setNeedsValidityCheck().
              (WebCore::HTMLSelectElement::isRequiredFormControl): Check if required or not.
              (WebCore::HTMLSelectElement::hasPlaceholderLabelOption): Added.
              (WebCore::HTMLSelectElement::updateValidity): Added. It calls setNeedsValidityCheck().
              * html/HTMLSelectElement.h:
              (WebCore::HTMLSelectElement::isOptionalFormControl): Check if not required.
              * html/HTMLSelectElement.idl: Added a required attribute to select elements..
              * html/ValidityState.cpp:
              (WebCore::ValidityState::valueMissing): Added valueMissing check for select elements into the global checker, ValidityState::valueMissing().
              * wml/WMLSelectElement.h:
              (WebCore::WMLSelectElement::updateValidity): Added. It does nothing.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@73606 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      a259a13f
    • jorlow@chromium.org's avatar
      2010-12-07 Jeremy Orlow <jorlow@chromium.org> · bc913b3c
      jorlow@chromium.org authored
              Reviewed by Steve Block.
      
              IndexedDB returns the wrong exceptions
              https://bugs.webkit.org/show_bug.cgi?id=50632
      
              * storage/indexeddb/constants-expected.txt:
              * storage/indexeddb/constants.html:
              * storage/indexeddb/objectstore-removeobjectstore-expected.txt:
              * storage/indexeddb/objectstore-removeobjectstore.html:
      2010-12-07  Jeremy Orlow  <jorlow@chromium.org>
      
              Reviewed by Steve Block.
      
              IndexedDB returns the wrong exceptions
              https://bugs.webkit.org/show_bug.cgi?id=50632
      
              IndexedDB exceptions need to have an offset so they can
              be distinguished from DOM exceptions.  We also need to
              add strings for the various exceptions.  Lastly, make
              IDBDatabaseException use the common exception base class.
      
              * bindings/js/JSDOMBinding.cpp:
              (WebCore::setDOMException):
              * bindings/v8/V8Proxy.cpp:
              (WebCore::V8Proxy::setDOMException):
              * dom/ExceptionCode.cpp:
              (WebCore::getExceptionCodeDescription):
              * dom/ExceptionCode.h:
              * storage/IDBDatabaseError.h:
              (WebCore::IDBDatabaseError::code):
              * storage/IDBDatabaseException.h:
              (WebCore::IDBDatabaseException::create):
              (WebCore::IDBDatabaseException::ErrorCodeToExceptionCode):
              (WebCore::IDBDatabaseException::IDBDatabaseException):
              * storage/IDBDatabaseException.idl:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@73605 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      bc913b3c
    • xan@webkit.org's avatar
      2010-12-09 Xan Lopez <xlopez@igalia.com> · baa76e9e
      xan@webkit.org authored
              Reviewed by Martin Robinson.
      
              Fix 'make install' woes with some versions of automake.
      
              * GNUmakefile.am: use $(top_builddir) instead of $(builddir),
              since we actually want a valid path for the file regardless of the
              place from where the script is called.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@73604 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      baa76e9e
    • kov@webkit.org's avatar
      2010-12-09 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk> · 3aaa4603
      kov@webkit.org authored
              Build fix for GTK+3. Use functions added for GTK+ 2.24 to get the
              GDK window size.
      
              * plugins/gtk/gtk2xtbin.c:
              (gtk_xtbin_realize):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@73603 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      3aaa4603