1. 12 May, 2011 1 commit
    • tonyg@chromium.org's avatar
      2011-05-10 Tony Gentilcore <tonyg@chromium.org> · 4b0a55f4
      tonyg@chromium.org authored
              Reviewed by Darin Adler.
      
              Perform some forward declarations suggested by include-what-you-use
              https://bugs.webkit.org/show_bug.cgi?id=60545
      
              * accessibility/AccessibilityObject.cpp:
              * accessibility/AccessibilityRenderObject.cpp:
              * accessibility/mac/AccessibilityObjectWrapper.mm:
              * dom/DocumentMarkerController.cpp:
              * dom/Position.cpp:
              * dom/PositionIterator.cpp:
              * dom/Range.cpp:
              * editing/ApplyBlockElementCommand.cpp:
              * editing/ApplyStyleCommand.cpp:
              * editing/Editor.cpp:
              * editing/EditorCommand.cpp:
              * editing/FrameSelection.cpp:
              * editing/HTMLInterchange.cpp:
              * editing/IndentOutdentCommand.cpp:
              * editing/ReplaceSelectionCommand.cpp:
              * editing/SpellChecker.h:
              * editing/SpellingCorrectionCommand.cpp:
              * editing/SpellingCorrectionController.h:
              * editing/TextCheckingHelper.cpp:
              * editing/TextIterator.h:
              * editing/htmlediting.h:
              * editing/markup.cpp:
              * editing/visible_units.cpp:
              * editing/visible_units.h:
              * fileapi/DOMFileSystem.cpp:
              * fileapi/DirectoryReaderSync.cpp:
              * fileapi/DirectoryReaderSync.h:
              * fileapi/FileEntry.h:
              * fileapi/FileWriter.h:
              * fileapi/FileWriterBase.h:
              * fileapi/FileWriterSync.h:
              * history/CachedFrame.cpp:
              * history/CachedPage.cpp:
              * history/HistoryItem.cpp:
              * history/HistoryItem.h:
              * history/PageCache.h:
              * loader/HistoryController.h:
              * loader/PingLoader.h:
              * loader/ResourceLoader.h:
              * loader/appcache/DOMApplicationCache.h:
              * loader/cache/CachedCSSStyleSheet.h:
              * loader/cache/CachedFont.cpp:
              * loader/cache/CachedFont.h:
              * loader/cache/CachedResourceRequest.cpp:
              * loader/cache/CachedResourceRequest.h:
              * loader/cache/MemoryCache.h:
              * notifications/Notification.cpp:
              * notifications/Notification.h:
              * notifications/NotificationCenter.cpp:
              * notifications/NotificationCenter.h:
              * page/Chrome.cpp:
              * page/Chrome.h:
              * page/DOMSelection.cpp:
              * page/DOMTimer.h:
              * page/DOMWindow.cpp:
              * page/EventHandler.cpp:
              * page/FocusController.h:
              * page/Geolocation.cpp:
              * page/Geolocation.h:
              * page/History.cpp:
              * rendering/RenderListBox.cpp:
              * workers/WorkerContext.cpp:
      2011-05-10  Tony Gentilcore  <tonyg@chromium.org>
      
              Reviewed by Darin Adler.
      
              Perform some forward declarations suggested by include-what-you-use
              https://bugs.webkit.org/show_bug.cgi?id=60545
      
              * src/WebHistoryItem.cpp:
              * src/WebNotification.cpp:
              * src/WebTextCheckingCompletionImpl.cpp:
              * src/mac/WebSubstringUtil.mm:
      2011-05-10  Tony Gentilcore  <tonyg@chromium.org>
      
              Reviewed by Darin Adler.
      
              Perform some forward declarations suggested by include-what-you-use
              https://bugs.webkit.org/show_bug.cgi?id=60545
      
              * Plugins/Hosted/WebHostedNetscapePluginView.mm:
              * WebView/WebFrame.mm:
      2011-05-10  Tony Gentilcore  <tonyg@chromium.org>
      
              Reviewed by Darin Adler.
      
              Perform some forward declarations suggested by include-what-you-use
              https://bugs.webkit.org/show_bug.cgi?id=60545
      
              * WebProcess/WebPage/mac/WebPageMac.mm:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@86325 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      4b0a55f4
  2. 05 Apr, 2011 1 commit
    • morrita@google.com's avatar
      2011-04-04 MORITA Hajime <morrita@google.com> · 8ee35ac4
      morrita@google.com authored
              Reviewed by Ryosuke Niwa.
      
              [Refactoring] SpellCheckingResult should be replaced with TextCheckingResult
              https://bugs.webkit.org/show_bug.cgi?id=56085
      
              Removed WebCore::SpellCheckingResult and replaced it with TextCheckingResult.
              This change also added TextCheckerClient::requestCheckingOfString() should have
              TextCheckingTypeMask as a parameter to control text checking type.
      
              * WebCore.exp.in:
              * editing/Editor.cpp:
              (WebCore::Editor::replaceSelectionWithFragment):
              (WebCore::Editor::markAllMisspellingsAndBadGrammarInRanges):
              (WebCore::Editor::textCheckingTypeMaskFor): Extracted from markAllMisspellingsAndBadGrammarInRanges()
              * editing/SpellChecker.cpp:
              (WebCore::SpellChecker::requestCheckingFor): Added a parameter.
              (WebCore::SpellChecker::markAt): Extracted from didCheck(), Added a check for the GrammarDetail object.
              (WebCore::SpellChecker::didCheck):
              * editing/SpellChecker.h:
              * loader/EmptyClients.h:
              (WebCore::EmptyTextCheckerClient::checkTextOfParagraph):
              (WebCore::EmptyTextCheckerClient::requestCheckingOfString):
              * platform/text/TextCheckerClient.h:
      2011-04-04  MORITA Hajime  <morrita@google.com>
      
              Reviewed by Ryosuke Niwa.
      
              [Refactoring] SpellCheckingResult should be replaced with TextCheckingResult
              https://bugs.webkit.org/show_bug.cgi?id=56085
      
              Followed the signature change.
      
              * src/EditorClientImpl.h:
              * src/EditorClientImpl.cpp:
              * src/WebTextCheckingCompletionImpl.cpp
      2011-04-04  MORITA Hajime  <morrita@google.com>
      
              Reviewed by Ryosuke Niwa.
      
              [Refactoring] SpellCheckingResult should be replaced with TextCheckingResult
              https://bugs.webkit.org/show_bug.cgi?id=56085
      
              * WebCoreSupport/EditorClientEfl.h:
              (WebCore::EditorClientEfl::requestCheckingOfString):
      2011-04-04  MORITA Hajime  <morrita@google.com>
      
              Reviewed by Ryosuke Niwa.
      
              [Refactoring] SpellCheckingResult should be replaced with TextCheckingResult
              https://bugs.webkit.org/show_bug.cgi?id=56085
      
              * WebCoreSupport/TextCheckerClientEnchant.h:
              (WebKit::TextCheckerClientEnchant::requestCheckingOfString):
      2011-04-04  MORITA Hajime  <morrita@google.com>
      
              Reviewed by Ryosuke Niwa.
      
              [Refactoring] SpellCheckingResult should be replaced with TextCheckingResult
              https://bugs.webkit.org/show_bug.cgi?id=56085
      
              * WebCoreSupport/EditorClientHaiku.h:
              (WebCore::EditorClientHaiku::requestCheckingOfString):
      2011-04-04  MORITA Hajime  <morrita@google.com>
      
              Reviewed by Ryosuke Niwa.
      
              [Refactoring] SpellCheckingResult should be replaced with TextCheckingResult
              https://bugs.webkit.org/show_bug.cgi?id=56085
      
              Removed NSTextCheckingResult to SpellCheckingResult convertion, and extracted
              NSTextCheckingResult to TextCheckingResult convertio from checkTextOfParagraph method.
              for requestCheckingOfString method.
      
              * WebCoreSupport/WebEditorClient.h:
              * WebCoreSupport/WebEditorClient.mm:
              (toCoreTextCheckingResults):
              (WebEditorClient::checkTextOfParagraph):
              (-[WebEditorSpellCheckResponder initWithSender:WebCore::sequence:types:WebCore::results:]):
              (-[WebEditorSpellCheckResponder perform]):
              (WebEditorClient::requestCheckingOfString):
              * WebView/WebFrame.mm:
              (-[WebFrame markersForSelectionStartAsText]):
              * WebView/WebFramePrivate.h:
      2011-04-04  MORITA Hajime  <morrita@google.com>
      
              Reviewed by Ryosuke Niwa.
      
              [Refactoring] SpellCheckingResult should be replaced with TextCheckingResult
              https://bugs.webkit.org/show_bug.cgi?id=56085
      
              * WebCoreSupport/EditorClientQt.h:
              (WebCore::EditorClientQt::requestCheckingOfString):
      2011-04-04  MORITA Hajime  <morrita@google.com>
      
              Reviewed by Ryosuke Niwa.
      
              [Refactoring] SpellCheckingResult should be replaced with TextCheckingResult
              https://bugs.webkit.org/show_bug.cgi?id=56085
      
              * WebCoreSupport/WebEditorClient.h:
              (WebEditorClient::requestCheckingOfString):
      2011-04-04  MORITA Hajime  <morrita@google.com>
      
              Reviewed by Ryosuke Niwa.
      
              [Refactoring] SpellCheckingResult should be replaced with TextCheckingResult
              https://bugs.webkit.org/show_bug.cgi?id=56085
      
              * WebCoreSupport/EditorClientWinCE.h:
              (WebKit::EditorClientWinCE::requestCheckingOfString):
      2011-04-04  MORITA Hajime  <morrita@google.com>
      
              Reviewed by Ryosuke Niwa.
      
              [Refactoring] SpellCheckingResult should be replaced with TextCheckingResult
              https://bugs.webkit.org/show_bug.cgi?id=56085
      
              * WebKitSupport/EditorClientWx.h:
              (WebCore::EditorClientWx::requestCheckingOfString):
      2011-04-04  MORITA Hajime  <morrita@google.com>
      
              Reviewed by Ryosuke Niwa.
      
              [Refactoring] SpellCheckingResult should be replaced with TextCheckingResult
              https://bugs.webkit.org/show_bug.cgi?id=56085
      
              * WebProcess/WebCoreSupport/WebEditorClient.cpp:
              (WebKit::WebEditorClient::requestCheckingOfString):
              * WebProcess/WebCoreSupport/WebEditorClient.h:
              * WebProcess/WebCoreSupport/mac/WebEditorClientMac.mm:
              (WebKit::WebEditorClient::checkTextOfParagraph):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@82952 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      8ee35ac4
  3. 24 Mar, 2011 1 commit
    • morrita@google.com's avatar
      2011-03-23 MORITA Hajime <morrita@google.com> · 102429ef
      morrita@google.com authored
              Reviewed by Kent Tamura.
      
              Spellcheck feature specific symbols should be defined.
              https://bugs.webkit.org/show_bug.cgi?id=56818
      
              * Introduced USE(UNIFIED_TEXT_CHECKING), USE(GRAMMAR_CHECKING) and USE(AUTOMATIC_TEXT_REPLACEMENT)
              * Replaced a part of of BUILDING_ON_* conditionals with them.
      
              Note that small amount of code path on Editor.cpp is now compiled under USE(GRAMMAR_CHECKING)
              because these code path is already built under non-Mac ports and
              Keeping them buildable for such platforms reduces the build breakage risk.
              These path is guarded by Settings thus should never get reached.
      
              No new tests. No behavioral change.
      
              * WebCore.gypi:
              * WebCore.pro:
              * WebCore.vcproj/WebCore.vcproj:
              * WebCore.xcodeproj/project.pbxproj:
              * editing/Editor.cpp:
              (WebCore::Editor::advanceToNextMisspelling):
              (WebCore::Editor::isSelectionUngrammatical):
              (WebCore::Editor::guessesForUngrammaticalSelection):
              (WebCore::Editor::guessesForMisspelledOrUngrammaticalSelection):
              (WebCore::Editor::markMisspellingsAfterTypingToWord):
              (WebCore::Editor::markMisspellingsOrBadGrammar):
              (WebCore::Editor::markBadGrammar):
              (WebCore::Editor::markAllMisspellingsAndBadGrammarInRanges):
              (WebCore::Editor::changeBackToReplacedString):
              (WebCore::Editor::markMisspellingsAndBadGrammar):
              * editing/Editor.h:
              * editing/TextCheckingHelper.cpp:
              (WebCore::TextCheckingHelper::findFirstMisspellingOrBadGrammar):
              (WebCore::TextCheckingHelper::findFirstGrammarDetail):
              (WebCore::TextCheckingHelper::findFirstBadGrammar):
              (WebCore::TextCheckingHelper::isUngrammatical):
              (WebCore::TextCheckingHelper::guessesForMisspelledOrUngrammaticalRange):
              (WebCore::TextCheckingHelper::markAllBadGrammar):
              * loader/EmptyClients.h:
              * platform/text/TextCheckerClient.h:
              * platform/text/TextChecking.h: Added.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@81855 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      102429ef
  4. 15 Feb, 2011 1 commit
    • morrita@google.com's avatar
      2011-01-26 MORITA Hajime <morrita@google.com> · 7692b428
      morrita@google.com authored
              Reviewed by Ryosuke Niwa.
      
              Refactoring: Extract TextCheckerClient from EditorClient
              https://bugs.webkit.org/show_bug.cgi?id=53213
      
              Created new abstract class TextCheckerClient. The class has
              spellcheck related API which is split.
              This is the first step for sharing spell-checking codebase
              between ports. A standalone TextCheckerClient implementation
              should be done in future changes.
      
              No new tests. No behavioral change.
      
              * GNUmakefile.am:
              * WebCore.gypi:
              * WebCore.pro:
              * WebCore.vcproj/WebCore.vcproj:
              * WebCore.xcodeproj/project.pbxproj:
              * accessibility/mac/AccessibilityObjectWrapper.mm:
              (AXAttributeStringSetSpelling):
              * editing/Editor.cpp: Replacing some client() call with textChecker().
              (WebCore::Editor::textChecker): Added.
              (WebCore::Editor::ignoreSpelling):
              (WebCore::Editor::learnSpelling):
              (WebCore::Editor::isSelectionMisspelled):
              (WebCore::Editor::guessesForMisspelledSelection):
              (WebCore::Editor::markMisspellingsAfterTypingToWord):
              (WebCore::Editor::markAllMisspellingsAndBadGrammarInRanges):
              (WebCore::Editor::correctionPanelTimerFired):
              * editing/Editor.h:
              * editing/SpellChecker.cpp:
              (WebCore::SpellChecker::SpellChecker):
              * editing/TextCheckingHelper.cpp: Replacing some client() call with textChecker().
              (WebCore::TextCheckingHelper::findFirstMisspelling):
              (WebCore::TextCheckingHelper::findFirstMisspellingOrBadGrammar):
              (WebCore::TextCheckingHelper::findFirstBadGrammar):
              (WebCore::TextCheckingHelper::guessesForMisspelledOrUngrammaticalRange):
              * loader/EmptyClients.h: Added EmptyTextCheckerClient.
              (WebCore::EmptyTextCheckerClient::ignoreWordInSpellDocument):
              (WebCore::EmptyTextCheckerClient::learnWord):
              (WebCore::EmptyTextCheckerClient::checkSpellingOfString):
              (WebCore::EmptyTextCheckerClient::getAutoCorrectSuggestionForMisspelledWord):
              (WebCore::EmptyTextCheckerClient::checkGrammarOfString):
              (WebCore::EmptyTextCheckerClient::checkTextOfParagraph):
              (WebCore::EmptyTextCheckerClient::getGuessesForWord):
              (WebCore::EmptyTextCheckerClient::requestCheckingOfString):
              (WebCore::EmptyEditorClient::textChecker):
              * page/EditorClient.h: Extracted TextCheckerClient.
              * page/Page.h:
              * platform/text/TextCheckerClient.h: Added.
              (WebCore::TextCheckerClient::~TextCheckerClient):
      2011-01-26  MORITA Hajime  <morrita@google.com>
      
              Reviewed by Ryosuke Niwa.
      
              Refactoring: Extract TextCheckerClient from EditorClient
              https://bugs.webkit.org/show_bug.cgi?id=53213
      
              * src/EditorClientImpl.h:
              (WebKit::EditorClientImpl::textChecker):
      2011-01-26  MORITA Hajime  <morrita@google.com>
      
              Reviewed by Ryosuke Niwa.
      
              Refactoring: Extract TextCheckerClient from EditorClient
              https://bugs.webkit.org/show_bug.cgi?id=53213
      
              * WebCoreSupport/EditorClientEfl.h:
              (WebCore::EditorClientEfl::textChecker):
      2011-01-26  MORITA Hajime  <morrita@google.com>
      
              Reviewed by Ryosuke Niwa.
      
              Refactoring: Extract TextCheckerClient from EditorClient
              https://bugs.webkit.org/show_bug.cgi?id=53213
      
              * WebCoreSupport/EditorClientGtk.h:
              (WebKit::EditorClient::textChecker):
      2011-01-26  MORITA Hajime  <morrita@google.com>
      
              Reviewed by Ryosuke Niwa.
      
              Refactoring: Extract TextCheckerClient from EditorClient
              https://bugs.webkit.org/show_bug.cgi?id=53213
      
              * WebCoreSupport/EditorClientHaiku.h:
              (WebCore::EditorClientHaiku::textChecker):
      2011-01-26  MORITA Hajime  <morrita@google.com>
      
              Reviewed by Ryosuke Niwa.
      
              Refactoring: Extract TextCheckerClient from EditorClient
              https://bugs.webkit.org/show_bug.cgi?id=53213
      
              * WebCoreSupport/WebEditorClient.h:
              (WebEditorClient::textChecker):
      2011-01-26  MORITA Hajime  <morrita@google.com>
      
              Reviewed by Ryosuke Niwa.
      
              Refactoring: Extract TextCheckerClient from EditorClient
              https://bugs.webkit.org/show_bug.cgi?id=53213
      
              * WebCoreSupport/EditorClientQt.h:
              (WebCore::EditorClientQt::textChecker):
      2011-01-26  MORITA Hajime  <morrita@google.com>
      
              Reviewed by Ryosuke Niwa.
      
              Refactoring: Extract TextCheckerClient from EditorClient
              https://bugs.webkit.org/show_bug.cgi?id=53213
      
              * WebCoreSupport/WebEditorClient.h:
              (WebEditorClient::textChecker):
      2011-01-26  MORITA Hajime  <morrita@google.com>
      
              Reviewed by Ryosuke Niwa.
      
              Refactoring: Extract TextCheckerClient from EditorClient
              https://bugs.webkit.org/show_bug.cgi?id=53213
      
              * WebCoreSupport/EditorClientWinCE.h:
              (WebKit::EditorClientWinCE::textChecker):
      2011-01-26  MORITA Hajime  <morrita@google.com>
      
              Reviewed by Ryosuke Niwa.
      
              Refactoring: Extract TextCheckerClient from EditorClient
              https://bugs.webkit.org/show_bug.cgi?id=53213
      
              * WebKitSupport/EditorClientWx.h:
              (WebCore::EditorClientWx::textChecker):
      2011-01-26  MORITA Hajime  <morrita@google.com>
      
              Reviewed by Ryosuke Niwa.
      
              Refactoring: Extract TextCheckerClient from EditorClient
              https://bugs.webkit.org/show_bug.cgi?id=53213
      
              * Shared/WebCoreArgumentCoders.h:
              * UIProcess/TextChecker.h:
              * WebProcess/WebCoreSupport/WebEditorClient.h:
              (WebKit::WebEditorClient::textChecker):
              * Scripts/webkit2/messages.py: Re-arranged the include file
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@78533 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      7692b428
  5. 08 Jan, 2011 1 commit
  6. 04 Jan, 2011 1 commit
  7. 01 Dec, 2010 1 commit
    • darin@apple.com's avatar
      2010-12-01 Jia Pu <jpu@apple.com> · a5f05c0a
      darin@apple.com authored
              Reviewed by Darin Adler.
      
              Support multiple correction candidates panel for misspelled word on Mac OS X.
              https://bugs.webkit.org/show_bug.cgi?id=50137
              <rdar://problem/8568059>
      
              Adopted new function signature defined in base class.
      
              * src/EditorClientImpl.cpp:
              (WebKit::EditorClientImpl::getGuessesForWord):
              * src/EditorClientImpl.h:
      2010-12-01  Jia Pu  <jpu@apple.com>
      
              Reviewed by Darin Adler.
      
              Support multiple correction candidates panel for misspelled word on Mac OS X.
              https://bugs.webkit.org/show_bug.cgi?id=50137
              <rdar://problem/8568059>
      
              Adopted new function signature defined in base class.
      
              * WebCoreSupport/EditorClientQt.cpp:
              (WebCore::EditorClientQt::getGuessesForWord):
              * WebCoreSupport/EditorClientQt.h:
      2010-12-01  Jia Pu  <jpu@apple.com>
      
              Reviewed by Darin Adler.
      
              Support multiple correction candidates panel for misspelled word on Mac OS X.
              https://bugs.webkit.org/show_bug.cgi?id=50137
              <rdar://problem/8568059>
      
              Adopted new function signature defined in base class.
      
              * WebCoreSupport/EditorClientGtk.cpp:
              (WebKit::EditorClient::getGuessesForWord):
              * WebCoreSupport/EditorClientGtk.h:
      2010-12-01  Jia Pu  <jpu@apple.com>
      
              Reviewed by Darin Adler.
      
              Support multiple correction candidates panel for misspelled word on Mac OS X.
              https://bugs.webkit.org/show_bug.cgi?id=50137
              <rdar://problem/8568059>
      
              Adopted new function signature defined in base class.
      
              * WebCoreSupport/WebEditorClient.cpp:
              (WebEditorClient::getGuessesForWord):
              * WebCoreSupport/WebEditorClient.h:
      2010-12-01  Jia Pu  <jpu@apple.com>
      
              Reviewed by Darin Adler.
      
              Support multiple correction candidates panel for misspelled word on Mac OS X.
              https://bugs.webkit.org/show_bug.cgi?id=50137
              <rdar://problem/8568059>
      
              Adopted new function signature defined in base class.
      
              * WebKitSupport/EditorClientWx.cpp:
              (WebCore::EditorClientWx::getGuessesForWord):
              * WebKitSupport/EditorClientWx.h:
      2010-12-01  Jia Pu  <jpu@apple.com>
      
              Reviewed by Darin Adler.
      
              Support multiple correction candidates panel for misspelled word on Mac OS X.
              https://bugs.webkit.org/show_bug.cgi?id=50137
              <rdar://problem/8568059>
      
              This patch is for supporting multiple correction suggestion panel on Mac OS X.
              The behavior and implementation is similar to that of reversion candiate panel.
      
              * WebCoreSupport/WebEditorClient.h: Adopted new signatures defined in base class.
      
              * WebCoreSupport/WebEditorClient.mm:  Adopted new signatures defined in base class.
                Added code to handle new multiple suggestion canidate panel type.
              (WebEditorClient::showCorrectionPanel):
              (WebEditorClient::getGuessesForWord):
      2010-12-01  Jia Pu  <jpu@apple.com>
      
              Reviewed by Darin Adler.
      
              Support multiple correction candidates panel for misspelled word on Mac OS X.
              https://bugs.webkit.org/show_bug.cgi?id=50137
              <rdar://problem/8568059>
      
              Adopted new function signature defined in base class.
      
              * WebCoreSupport/EditorClientHaiku.cpp:
              (WebCore::EditorClientHaiku::getGuessesForWord):
              * WebCoreSupport/EditorClientHaiku.h:
      2010-12-01  Jia Pu  <jpu@apple.com>
      
              Reviewed by Darin Adler.
      
              Support multiple correction candidates panel for misspelled word on Mac OS X.
              https://bugs.webkit.org/show_bug.cgi?id=50137
              <rdar://problem/8568059>
      
              Adopted new function signature defined in base class.
      
              * WebCoreSupport/EditorClientWinCE.cpp:
              (WebKit::EditorClientWinCE::getGuessesForWord):
              * WebCoreSupport/EditorClientWinCE.h:
      2010-12-01  Jia Pu  <jpu@apple.com>
      
              Reviewed by Darin Adler.
      
              Support multiple correction candidates panel for misspelled word on Mac OS X.
              https://bugs.webkit.org/show_bug.cgi?id=50137
              <rdar://problem/8568059>
      
              Adopted new function signature defined in base class.
      
              * WebCoreSupport/EditorClientEfl.cpp:
              (WebCore::EditorClientEfl::getGuessesForWord):
              * WebCoreSupport/EditorClientEfl.h:
      2010-12-01  Jia Pu  <jpu@apple.com>
      
              Reviewed by Darin Adler.
      
              Support multiple correction candidates panel for misspelled word on Mac OS X.
              https://bugs.webkit.org/show_bug.cgi?id=50137
              <rdar://problem/8568059>
      
              Test: platform/mac/editing/spelling/delete-autocorrected-word-1.html
              Manual test: WebCore/manual-tests/autocorrection/dismiss-multiple-guesses.html
                           WebCore/manual-tests/autocorrection/select-from-multiple-guesses.html
      
              This patch is for supporting multiple correction suggestion panel on Mac OS X.
              The behavior and implementation is similar to that of reversion candiate panel.
      
              * WebCore.exp.in: Added and removed symbols.
      
              * editing/CorrectionPanelInfo.h: Added new correction panel type, PanelTypeSpellingSuggestions.
      
              * editing/Editor.cpp:
              (WebCore::markerTypesForAutocorrection): Convenient function for getting marker types to
                be added to autocorrected word.
              (WebCore::boundingBoxForRange): Convenient function for calculating the bounding box of a range.
              (WebCore::markerTypesForReplacement): Convenient function for getting marker types to
                be added to word that has been replaced by various correction panel.
              (WebCore::Editor::respondToChangedSelection): Added code to trigger timer for multiple
                suggestion panel.
              (WebCore::Editor::guessesForMisspelledSelection): Adopted new signature of EditorClient::getGuessesForWord().
              (WebCore::Editor::markMisspellingsAfterTypingToWord): Adopted new signature of applyCorrectionPanelInfo().
              (WebCore::Editor::markAllMisspellingsAndBadGrammarInRanges): Ditto.
              (WebCore::Editor::correctionPanelTimerFired): Added code to handle new multiple suggestion panel.
              (WebCore::Editor::handleCorrectionPanelResult): Replaced handleRejectedCorrection(), since
                with new AppKit correction panel API, not only rejection, but also confirmation can be
                handled in callback.
              (WebCore::Editor::stopCorrectionPanelTimer): Moved the code that clears correction panel info
                from dismissCorrectionPanel() to this function to fix a bug that would occur when deleting
                autocorrected word.
              (WebCore::Editor::dismissCorrectionPanel): Ditto.
              (WebCore::Editor::applyCorrectionPanelInfo): Added code to handle new multiple suggestion panel.
      
              * editing/Editor.h: Replaced handleRejectedCorrection() with handleCorrectionPanelResult().
                Changed the signature of applyCorrectionPanelInfo() to hanlde new correction panel type.
      
              * editing/TextCheckingHelper.cpp:
              (WebCore::TextCheckingHelper::guessesForMisspelledOrUngrammaticalRange): Adopted new EditorClient::getGuessesForWord().
      
              * editing/TextCheckingHelper.h: Made paragraphRange() public.
      
              * loader/EmptyClients.h:
              (WebCore::EmptyEditorClient::showCorrectionPanel): Adopted new signature defined in base class.
              (WebCore::EmptyEditorClient::getGuessesForWord): Ditto.
      
              * manual-tests/autocorrection/dismiss-multiple-guesses.html: Added.
      
              * manual-tests/autocorrection/select-from-multiple-guesses.html: Added.
      
              * page/EditorClient.h:  Changed showCorrectionPanel() to allow passing multiple correction
                candidates. Changed getGuessesForWord() to allow passing in contextual text for better
                correction suggestions (for those spellcheckers that utilizes such contextual information).
      2010-12-01  Jia Pu  <jpu@apple.com>
      
              Reviewed by Darin Adler.
      
              Support multiple correction candidates panel for misspelled word on Mac OS X.
              https://bugs.webkit.org/show_bug.cgi?id=50137
              <rdar://problem/8568059>
      
              * platform/mac-leopard/Skipped:
              * platform/mac-snowleopard/Skipped:
              * platform/mac-tiger/Skipped:
              * platform/mac-wk2/Skipped:
              * platform/mac/editing/spelling/delete-autocorrected-word-1-expected.txt: Added.
              * platform/mac/editing/spelling/delete-autocorrected-word-1.html: Added.
      2010-12-01  Jia Pu  <jpu@apple.com>
      
              Reviewed by Darin Adler.
      
              Support multiple correction candidates panel for misspelled word on Mac OS X.
              https://bugs.webkit.org/show_bug.cgi?id=50137
              <rdar://problem/8568059>
      
              Adopted new function signatures defined in base class.
      
              * WebProcess/WebCoreSupport/WebEditorClient.cpp:
              (WebKit::WebEditorClient::getGuessesForWord):
              * WebProcess/WebCoreSupport/WebEditorClient.h:
              * WebProcess/WebCoreSupport/mac/WebEditorClientMac.mm:
              (WebKit::WebEditorClient::showCorrectionPanel):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@73088 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      a5f05c0a
  8. 12 Nov, 2010 1 commit
    • morrita@google.com's avatar
      2010-11-05 MORITA Hajime <morrita@google.com> · 13e1e1cf
      morrita@google.com authored
              Reviewed by Kent Tamura.
      
              Refactoring: Return values of TextCheckingHelper::paragraphAlignedRange should form a class.
              https://bugs.webkit.org/show_bug.cgi?id=49053
      
              Replaced paragraphAlignedRange() function call into
              TextCheckingParagraph class. The class encapsulates a range of a
              paragraph, and its relation within associated checking range.
              Instance variables of the class are computed lazily. So we can save unnecessary
              memory allocation and DOM tree traversal.
      
              No new tests, no behavior change.
      
              * editing/Editor.cpp:
              (WebCore::Editor::markAllMisspellingsAndBadGrammarInRanges): Replaced paragraphAlignedRange() call.
              (WebCore::Editor::changeBackToReplacedString): Replaced paragraphAlignedRange() call.
              * editing/TextCheckingHelper.cpp:
              (WebCore::expandToParagraphBoundary):
              (WebCore::TextCheckingParagraph::TextCheckingParagraph):
              (WebCore::TextCheckingParagraph::~TextCheckingParagraph):
              (WebCore::TextCheckingParagraph::expandRangeToNextEnd):
              (WebCore::TextCheckingParagraph::invalidateParagraphRangeValues):
              (WebCore::TextCheckingParagraph::rangeLength):
              (WebCore::TextCheckingParagraph::paragraphRange):
              (WebCore::TextCheckingParagraph::subrange):
              (WebCore::TextCheckingParagraph::offsetTo):
              (WebCore::TextCheckingParagraph::isEmpty):
              (WebCore::TextCheckingParagraph::offsetAsRange):
              (WebCore::TextCheckingParagraph::text):
              (WebCore::TextCheckingParagraph::checkingStart):
              (WebCore::TextCheckingParagraph::checkingEnd):
              (WebCore::TextCheckingParagraph::checkingLength):
              (WebCore::TextCheckingHelper::findFirstBadGrammar): Replaced paragraphAlignedRange() call.
              (WebCore::TextCheckingHelper::guessesForMisspelledOrUngrammaticalRange): Replaced paragraphAlignedRange() call.
              * editing/TextCheckingHelper.h:
              (WebCore::TextCheckingParagraph::textLength):
              (WebCore::TextCheckingParagraph::textSubstring):
              (WebCore::TextCheckingParagraph::textCharacters):
              (WebCore::TextCheckingParagraph::textCharAt):
              (WebCore::TextCheckingParagraph::checkingSubstring):
              (WebCore::TextCheckingParagraph::checkingRangeMatches):
              (WebCore::TextCheckingParagraph::isCheckingRangeCoveredBy):
              (WebCore::TextCheckingParagraph::checkingRangeCovers):
              (WebCore::TextCheckingParagraph::checkingRange):
              (WebCore::TextCheckingParagraph::isTextEmpty):
              (WebCore::TextCheckingParagraph::isRangeEmpty):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@71898 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      13e1e1cf
  9. 01 Nov, 2010 1 commit
    • morrita@google.com's avatar
      2010-10-26 MORITA Hajime <morrita@google.com> · dc25904a
      morrita@google.com authored
              Reviewed by Kent Tamura.
      
              Refactoring: Spellchecking related static functions could form a class
              https://bugs.webkit.org/show_bug.cgi?id=48287
      
              Extracted spellcheck related static functions to TextCheckingHelper class,
              which has EditorClient and Range as its member.
      
              No new tests. Just a refactoring.
      
              * CMakeLists.txt:
              * GNUmakefile.am:
              * WebCore.gypi:
              * WebCore.pro:
              * WebCore.vcproj/WebCore.vcproj:
              * WebCore.xcodeproj/project.pbxproj:
              * editing/EditingAllInOne.cpp
              * editing/Editor.cpp:
              (WebCore::Editor::advanceToNextMisspelling):
              (WebCore::Editor::isSelectionUngrammatical):
              (WebCore::Editor::guessesForUngrammaticalSelection):
              (WebCore::Editor::guessesForMisspelledOrUngrammaticalSelection):
              (WebCore::Editor::markMisspellingsAfterTypingToPosition):
              (WebCore::Editor::markMisspellingsOrBadGrammar):
              (WebCore::Editor::markMisspellings):
              (WebCore::Editor::markBadGrammar):
              (WebCore::Editor::markAllMisspellingsAndBadGrammarInRanges):
              (WebCore::Editor::changeBackToReplacedString):
              * editing/Editor.h:
              * editing/TextCheckingHelper.cpp: Added.
              (WebCore::TextCheckingHelper::TextCheckingHelper):
              (WebCore::TextCheckingHelper::~TextCheckingHelper):
              (WebCore::TextCheckingHelper::paragraphAlignedRange):
              (WebCore::TextCheckingHelper::findFirstMisspelling):
              (WebCore::TextCheckingHelper::findFirstMisspellingOrBadGrammar):
              (WebCore::TextCheckingHelper::findFirstGrammarDetail):
              (WebCore::TextCheckingHelper::findFirstBadGrammar):
              (WebCore::TextCheckingHelper::isUngrammatical):
              (WebCore::TextCheckingHelper::guessesForMisspelledOrUngrammaticalRange):
              (WebCore::TextCheckingHelper::markAllMisspellings):
              (WebCore::TextCheckingHelper::markAllBadGrammar):
              * editing/TextCheckingHelper.h: Added.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@71009 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      dc25904a
  10. 29 Oct, 2010 2 commits
    • mrowe@apple.com's avatar
      Roll out r70847 as it causes crashes when typing text in both Safari and Mail:... · 856d3c12
      mrowe@apple.com authored
      Roll out r70847 as it causes crashes when typing text in both Safari and Mail: <http://webkit.org/b/48708>.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@70970 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      856d3c12
    • morrita@google.com's avatar
      2010-10-26 MORITA Hajime <morrita@google.com> · e8fba76f
      morrita@google.com authored
              Reviewed by Kent Tamura.
      
              Refactoring: Spellchecking related static functions could form a class
              https://bugs.webkit.org/show_bug.cgi?id=48287
      
              Extracted spellcheck related static functions to TextCheckingHelper class,
              which has EditorClient and Range as its member.
      
              No new tests. Just a refactoring.
      
              * CMakeLists.txt:
              * GNUmakefile.am:
              * WebCore.gypi:
              * WebCore.pro:
              * WebCore.vcproj/WebCore.vcproj:
              * WebCore.xcodeproj/project.pbxproj:
              * editing/Editor.cpp:
              (WebCore::Editor::advanceToNextMisspelling):
              (WebCore::Editor::isSelectionUngrammatical):
              (WebCore::Editor::guessesForUngrammaticalSelection):
              (WebCore::Editor::guessesForMisspelledOrUngrammaticalSelection):
              (WebCore::Editor::markMisspellingsAfterTypingToPosition):
              (WebCore::Editor::markMisspellingsOrBadGrammar):
              (WebCore::Editor::markMisspellings):
              (WebCore::Editor::markBadGrammar):
              (WebCore::Editor::markAllMisspellingsAndBadGrammarInRanges):
              (WebCore::Editor::changeBackToReplacedString):
              * editing/Editor.h:
              * editing/TextCheckingHelper.cpp: Added.
              (WebCore::TextCheckingHelper::TextCheckingHelper):
              (WebCore::TextCheckingHelper::~TextCheckingHelper):
              (WebCore::TextCheckingHelper::paragraphAlignedRange):
              (WebCore::TextCheckingHelper::findFirstMisspelling):
              (WebCore::TextCheckingHelper::findFirstMisspellingOrBadGrammar):
              (WebCore::TextCheckingHelper::findFirstGrammarDetail):
              (WebCore::TextCheckingHelper::findFirstBadGrammar):
              (WebCore::TextCheckingHelper::isUngrammatical):
              (WebCore::TextCheckingHelper::guessesForMisspelledOrUngrammaticalRange):
              (WebCore::TextCheckingHelper::markAllMisspellings):
              (WebCore::TextCheckingHelper::markAllBadGrammar):
              * editing/TextCheckingHelper.h: Added.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@70847 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      e8fba76f