1. 12 May, 2011 1 commit
    • tonyg@chromium.org's avatar
      2011-05-10 Tony Gentilcore <tonyg@chromium.org> · 4b0a55f4
      tonyg@chromium.org authored
              Reviewed by Darin Adler.
      
              Perform some forward declarations suggested by include-what-you-use
              https://bugs.webkit.org/show_bug.cgi?id=60545
      
              * accessibility/AccessibilityObject.cpp:
              * accessibility/AccessibilityRenderObject.cpp:
              * accessibility/mac/AccessibilityObjectWrapper.mm:
              * dom/DocumentMarkerController.cpp:
              * dom/Position.cpp:
              * dom/PositionIterator.cpp:
              * dom/Range.cpp:
              * editing/ApplyBlockElementCommand.cpp:
              * editing/ApplyStyleCommand.cpp:
              * editing/Editor.cpp:
              * editing/EditorCommand.cpp:
              * editing/FrameSelection.cpp:
              * editing/HTMLInterchange.cpp:
              * editing/IndentOutdentCommand.cpp:
              * editing/ReplaceSelectionCommand.cpp:
              * editing/SpellChecker.h:
              * editing/SpellingCorrectionCommand.cpp:
              * editing/SpellingCorrectionController.h:
              * editing/TextCheckingHelper.cpp:
              * editing/TextIterator.h:
              * editing/htmlediting.h:
              * editing/markup.cpp:
              * editing/visible_units.cpp:
              * editing/visible_units.h:
              * fileapi/DOMFileSystem.cpp:
              * fileapi/DirectoryReaderSync.cpp:
              * fileapi/DirectoryReaderSync.h:
              * fileapi/FileEntry.h:
              * fileapi/FileWriter.h:
              * fileapi/FileWriterBase.h:
              * fileapi/FileWriterSync.h:
              * history/CachedFrame.cpp:
              * history/CachedPage.cpp:
              * history/HistoryItem.cpp:
              * history/HistoryItem.h:
              * history/PageCache.h:
              * loader/HistoryController.h:
              * loader/PingLoader.h:
              * loader/ResourceLoader.h:
              * loader/appcache/DOMApplicationCache.h:
              * loader/cache/CachedCSSStyleSheet.h:
              * loader/cache/CachedFont.cpp:
              * loader/cache/CachedFont.h:
              * loader/cache/CachedResourceRequest.cpp:
              * loader/cache/CachedResourceRequest.h:
              * loader/cache/MemoryCache.h:
              * notifications/Notification.cpp:
              * notifications/Notification.h:
              * notifications/NotificationCenter.cpp:
              * notifications/NotificationCenter.h:
              * page/Chrome.cpp:
              * page/Chrome.h:
              * page/DOMSelection.cpp:
              * page/DOMTimer.h:
              * page/DOMWindow.cpp:
              * page/EventHandler.cpp:
              * page/FocusController.h:
              * page/Geolocation.cpp:
              * page/Geolocation.h:
              * page/History.cpp:
              * rendering/RenderListBox.cpp:
              * workers/WorkerContext.cpp:
      2011-05-10  Tony Gentilcore  <tonyg@chromium.org>
      
              Reviewed by Darin Adler.
      
              Perform some forward declarations suggested by include-what-you-use
              https://bugs.webkit.org/show_bug.cgi?id=60545
      
              * src/WebHistoryItem.cpp:
              * src/WebNotification.cpp:
              * src/WebTextCheckingCompletionImpl.cpp:
              * src/mac/WebSubstringUtil.mm:
      2011-05-10  Tony Gentilcore  <tonyg@chromium.org>
      
              Reviewed by Darin Adler.
      
              Perform some forward declarations suggested by include-what-you-use
              https://bugs.webkit.org/show_bug.cgi?id=60545
      
              * Plugins/Hosted/WebHostedNetscapePluginView.mm:
              * WebView/WebFrame.mm:
      2011-05-10  Tony Gentilcore  <tonyg@chromium.org>
      
              Reviewed by Darin Adler.
      
              Perform some forward declarations suggested by include-what-you-use
              https://bugs.webkit.org/show_bug.cgi?id=60545
      
              * WebProcess/WebPage/mac/WebPageMac.mm:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@86325 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      4b0a55f4
  2. 10 May, 2011 1 commit
    • tonyg@chromium.org's avatar
      2011-05-06 Tony Gentilcore <tonyg@chromium.org> · 8d183cb0
      tonyg@chromium.org authored
              Reviewed by Darin Adler.
      
              Fix some unnecessary includes in headers
              https://bugs.webkit.org/show_bug.cgi?id=60388
      
              These were all found using the include-what-you-use clang plugin.
      
              * css/CSSFontFaceSrcValue.h:
              * css/CSSImageGeneratorValue.h:
              * css/CSSParser.h:
              * css/CSSPrimitiveValueCache.cpp:
              * css/CSSPrimitiveValueCache.h:
              * css/CSSStyleSelector.cpp:
              * css/CSSStyleSelector.h:
              * css/RGBColor.cpp:
              * css/RGBColor.h:
              * dom/EventTarget.h:
              * dom/ExceptionBase.cpp:
              * dom/ExceptionBase.h:
              * dom/MessagePort.cpp:
              * dom/Range.cpp:
              * dom/Range.h:
              * dom/SelectElement.cpp:
              * dom/SelectElement.h:
              * dom/TextEvent.cpp:
              * dom/TextEvent.h:
              * dom/Touch.cpp:
              * dom/Touch.h:
              * dom/TouchEvent.cpp:
              * dom/TouchEvent.h:
              * dom/XMLDocumentParser.h:
              * dom/XMLDocumentParserScope.h:
              * editing/AppendNodeCommand.cpp:
              * editing/ApplyBlockElementCommand.h:
              * editing/DeleteFromTextNodeCommand.cpp:
              * editing/EditCommand.h:
              * editing/Editor.h:
              * editing/FormatBlockCommand.h:
              * editing/IndentOutdentCommand.h:
              * editing/InsertIntoTextNodeCommand.cpp:
              * editing/InsertNodeBeforeCommand.cpp:
              * editing/ReplaceSelectionCommand.h:
              * editing/SetNodeAttributeCommand.h:
              * html/HTMLSelectElement.h:
              * html/canvas/CanvasRenderingContext2D.cpp:
              * loader/appcache/DOMApplicationCache.cpp:
              * page/EventSource.cpp:
              * rendering/RenderListBox.cpp:
              * rendering/RenderMenuList.cpp:
              * rendering/RenderTextControlSingleLine.cpp:
              * rendering/svg/RenderSVGInlineText.cpp:
              * svg/SVGMatrix.h:
              * websockets/WebSocket.cpp:
              * workers/AbstractWorker.cpp:
              * xml/XMLHttpRequest.cpp:
              * xml/XPathExpression.cpp:
      2011-05-06  Tony Gentilcore  <tonyg@chromium.org>
      
              Reviewed by Darin Adler.
      
              Fix some unnecessary includes in headers
              https://bugs.webkit.org/show_bug.cgi?id=60388
      
              * WebProcess/FullScreen/WebFullScreenManager.cpp:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@86135 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      8d183cb0
  3. 21 Apr, 2011 1 commit
    • rolandsteiner@chromium.org's avatar
      2011-04-20 Roland Steiner <rolandsteiner@chromium.org> · 6d944b84
      rolandsteiner@chromium.org authored
              Reviewed by Dimitri Glazkov.
      
              Bug 58704 - Decide on node type for ShadowRoot
              https://bugs.webkit.org/show_bug.cgi?id=58704
      
              Test node types of shadow host, shadow root and first shadow child.
      
              * fast/dom/shadow/nodetype-expected.txt: Added.
              * fast/dom/shadow/nodetype.html: Added.
      2011-04-21  Roland Steiner  <rolandsteiner@chromium.org>
      
              Reviewed by Dimitri Glazkov.
      
              Bug 58704 - Decide on node type for ShadowRoot
              https://bugs.webkit.org/show_bug.cgi?id=58704
      
              Add a new node type SHADOW_ROOT_NODE.
              Adapt all calling sites of nodeType().
      
              Test: fast/dom/shadow/nodetype.html
      
              * bindings/js/JSNodeCustom.cpp:
              (WebCore::createWrapperInline):
              * bindings/objc/DOM.mm:
              (kitClass):
              * bindings/v8/custom/V8NodeCustom.cpp:
              (WebCore::toV8Slow):
              * dom/Document.cpp:
              (WebCore::Document::importNode):
              (WebCore::Document::childTypeAllowed):
              (WebCore::Document::canReplaceChild):
              * dom/Node.cpp:
              (WebCore::Node::dumpStatistics):
              (WebCore::Node::isDefaultNamespace):
              (WebCore::Node::lookupPrefix):
              (WebCore::Node::lookupNamespaceURI):
              (WebCore::appendTextContent):
              (WebCore::Node::setTextContent):
              * dom/Node.h:
              * dom/Range.cpp:
              (WebCore::lengthOfContentsInNode):
              (WebCore::Range::processContentsBetweenOffsets):
              (WebCore::Range::insertNode):
              (WebCore::Range::checkNodeWOffset):
              (WebCore::Range::checkNodeBA):
              (WebCore::Range::selectNode):
              (WebCore::Range::selectNodeContents):
              (WebCore::Range::surroundContents):
              * dom/ShadowRoot.cpp:
              (WebCore::ShadowRoot::nodeType):
              * dom/Traversal.cpp:
              (WebCore::Traversal::acceptNode):
              * editing/MarkupAccumulator.cpp:
              (WebCore::MarkupAccumulator::appendStartMarkup):
              * html/parser/HTMLElementStack.cpp:
              (WebCore::HTMLNames::isRootNode):
              (WebCore::HTMLElementStack::pushRootNode):
              * html/parser/HTMLElementStack.h:
              (WebCore::isInHTMLNamespace):
              * xml/XPathUtil.cpp:
              (WebCore::XPath::isValidContextNode):
      2011-04-21  Roland Steiner  <rolandsteiner@chromium.org>
      
              Reviewed by Dimitri Glazkov.
      
              Bug 58704 - Decide on node type for ShadowRoot
              https://bugs.webkit.org/show_bug.cgi?id=58704
      
              Add a new enum entry to WebNode::NodeType for shadow roots.
              Adapt calling sites for new SHADOW_ROOT_NODE node type.
      
              * public/WebNode.h:
              * src/WebPageSerializerImpl.cpp:
              (WebKit::WebPageSerializerImpl::buildContentForNode):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@84520 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      6d944b84
  4. 19 Apr, 2011 1 commit
    • rniwa@webkit.org's avatar
      2011-04-19 Ryosuke Niwa <rniwa@webkit.org> · 77a1ed7c
      rniwa@webkit.org authored
              Reviewed by Dimitri Glazkov.
      
              REGRESSION(r74228-75294): removing nodes is 200+ times slower when selection is inside a shadow DOM
              https://bugs.webkit.org/show_bug.cgi?id=57061
      
              The bug was caused by Range::compareNode's incorrectly returning NODE_INSIDE when the selection is inside
              a shadow DOM and the node is outside of the shadow DOM. This caused respondToNodeModification to call
              RenderView::clearSelection every time a node is removed when selection is in a shadow DOM and resulted in
              a significant performance regression.
      
              Fixed Ranged::compareNode by making Range::compareBoundaryPoints throw a WRONG_DOCUMENT_ERR when there are
              no common ancestors between containerA and containerB. This will force compareNode to also throw an exception
              and prevents respondToNodeModification from clearing selection.
      
              No new tests because this is a performance improvement and the fix in Range cannot be tested since shadow DOM
              isn't exposed to JavaScript.
      
              * dom/Range.cpp:
              (WebCore::Range::setStart): Calls compareBoundaryPoints; since we ensures that the root container noes of
              start and end nodes are same, we should never get an exception from compareBoundaryPoints.
              (WebCore::Range::setEnd): Ditto.
              (WebCore::Range::isPointInRange): Calls compareBoundaryPoints; returns false when compareBoundaryPoints
              throws an exception.
              (WebCore::Range::comparePoint): Calls compareBoundaryPoints; exit early when an exception is thrown by
              compareBoundaryPoints.
              (WebCore::Range::compareBoundaryPoints): Throws an exception when two containers do not have a common ancestor.
              (WebCore::Range::boundaryPointsValid): Calls compareBoundaryPoints and checks that it didn't throw an exception.
              * dom/Range.h:
              * editing/SelectionController.cpp:
              (WebCore::SelectionController::respondToNodeModification):
              * editing/htmlediting.cpp:
              (WebCore::comparePositions): Calls compareBoundaryPoints.
              * editing/markup.cpp:
              (WebCore::createMarkup): Calls compareBoundaryPoints; since startNode and pastEnd are both in the same document
              and neither are in a shadow DOM, it should never throw an exception.
              * page/DOMSelection.cpp:
              (WebCore::DOMSelection::containsNode): Calls compareBoundaryPoints; node is fully selected only if no exception
              was thrown.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@84265 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      77a1ed7c
  5. 02 Apr, 2011 1 commit
    • bdakin@apple.com's avatar
      https://bugs.webkit.org/show_bug.cgi?id=57605 · 5c30e409
      bdakin@apple.com authored
      Frame::pageScaleFactor() should not affect getBoundingClientRect() or 
      getClientRects()
      -and corresponding-
      <rdar://problem/9194541>
      
      Reviewed by Sam Weinig.
      
      New functions adjust*ForPageScale() are analogous to adjust*ForAbsoluteZoom().
      * dom/Element.cpp:
      (WebCore::Element::getClientRects):
      (WebCore::Element::getBoundingClientRect):
      * dom/Range.cpp:
      (WebCore::adjustFloatQuadsForScrollAndAbsoluteZoomAndPageScale):
      (WebCore::Range::getBorderAndTextQuads):
      * rendering/RenderObject.h:
      (WebCore::adjustFloatPointForPageScale):
      (WebCore::adjustFloatQuadForPageScale):
      (WebCore::adjustFloatRectForPageScale):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@82778 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      5c30e409
  6. 30 Mar, 2011 1 commit
    • commit-queue@webkit.org's avatar
      2011-03-30 Jia Pu <jpu@apple.com> · 2bc9780b
      commit-queue@webkit.org authored
              Reviewed by Darin Adler.
      
              Autocorrection panel isn't positioned correctly in Safari (mac) when the zooming is not 1x.
              https://bugs.webkit.org/show_bug.cgi?id=57353
              <rdar://problem/9163983>
      
              Updated following test in response to recent change in AppKit spell checker.
      
              * platform/mac/editing/spelling/delete-autocorrected-word-1-expected.txt:
              * platform/mac/editing/spelling/delete-autocorrected-word-1.html:
      2011-03-30  Jia Pu  <jpu@apple.com>
      
              Reviewed by Darin Adler.
      
              Autocorrection panel isn't positioned correctly in Safari (mac) when the zooming is not 1x.
              https://bugs.webkit.org/show_bug.cgi?id=57353
              <rdar://problem/9163983>
      
              We use Range::textQuads() instead of Range::boundingRect() to compute the position of correction
              panel. The latter function compensates for zooming, which we don't need in this case. We also
              dismiss correction panel when zooming factor is changed. This is done in Frame::setPageAndTextZoomFactors().
      
              * WebCore.exp.in:
              * dom/Range.cpp:
              (WebCore::Range::textQuads):
              * dom/Range.h:
              * editing/Editor.cpp:
              (WebCore::Editor::windowRectForRange):
              * editing/Editor.h:
              * page/Frame.cpp:
              (WebCore::Frame::setPageAndTextZoomFactors):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@82533 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      2bc9780b
  7. 10 Mar, 2011 1 commit
    • ojan@chromium.org's avatar
      2011-03-10 Ojan Vafai <ojan@chromium.org> · 4a97b027
      ojan@chromium.org authored
              Reviewed by Darin Adler.
      
              Able to move nodes across documents
              https://bugs.webkit.org/show_bug.cgi?id=19524
      
              Makes cross-document appendChild, insertBefore, Range.insertNode and Range.surroundContents work.
              This matches Gecko and the new Dom Core spec. There are a number of Range methods where we don't
              match Gecko or the spec that will need to be updated in a following patch.
      
              * dom/html/level1/core/hc_elementwrongdocumenterr-expected.txt:
              * dom/html/level1/core/hc_namednodemapwrongdocumenterr-expected.txt:
              * dom/xhtml/level1/core/hc_elementwrongdocumenterr-expected.txt:
              * dom/xhtml/level1/core/hc_namednodemapwrongdocumenterr-expected.txt:
              * fast/dom/move-nodes-across-documents-expected.txt: Added.
              * fast/dom/move-nodes-across-documents.html: Added.
      2011-03-10  Ojan Vafai  <ojan@chromium.org>
      
              Reviewed by Darin Adler.
      
              Able to move nodes across documents
              https://bugs.webkit.org/show_bug.cgi?id=19524
      
              Makes cross-document appendChild, insertBefore, Range.insertNode and Range.surroundContents work.
              This matches Gecko and the new Dom Core spec. There are a number of Range methods where we don't
              match Gecko or the spec that will need to be updated in a following patch.
      
              Test: fast/dom/move-nodes-across-documents.html
      
              * dom/Element.cpp:
              (WebCore::Element::removeAttributeNode):
              * dom/NamedNodeMap.cpp:
              (WebCore::NamedNodeMap::setNamedItem):
              * dom/Node.cpp:
              (WebCore::Node::setDocumentRecursively):
              (WebCore::checkAcceptChild):
              (WebCore::Node::checkReplaceChild):
              * dom/Range.cpp:
              (WebCore::Range::insertNode):
              (WebCore::Range::surroundContents):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@80696 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      4a97b027
  8. 04 Mar, 2011 1 commit
    • commit-queue@webkit.org's avatar
      2011-03-04 Jia Pu <jpu@apple.com> · 8e5ed4ad
      commit-queue@webkit.org authored
              Reviewed by Darin Adler.
      
              On Mac, the bounding box sent to EditorClient::showCorrectionPanel() is incorrect when the correction occurs in an iframe.
              https://bugs.webkit.org/show_bug.cgi?id=55717
              <rdar://problem/9018127>
      
              manual-test: manual-tests/platforms/mac/autocorrection/autocorrection-in-iframe.html
      
              Previously, the bounding box passed into EditorClient::showCorrectionPanel() is in the frame's
              coordinate. This is incorrect when the correction occurs in an iframe. This patch added code
              to convert the bounding box to window coordinate using ScrollView::contentToWindow().
      
              * dom/Range.cpp:
              (WebCore::Range::getBoundingClientRect):
              (WebCore::Range::boundingRect):
              * dom/Range.h:
              * editing/Editor.cpp:
              (WebCore::Editor::markAllMisspellingsAndBadGrammarInRanges):
              (WebCore::Editor::correctionPanelTimerFired):
              (WebCore::Editor::windowRectForRange):
              * editing/Editor.h:
              * manual-tests/autocorrection/autocorrection-in-iframe.html: Added.
              * manual-tests/autocorrection/document-for-iframe-test.html: Added.
      2011-03-04  Jia Pu  <jpu@apple.com>
      
              Reviewed by Darin Adler.
      
              On Mac, the bounding box sent to EditorClient::showCorrectionPanel() is incorrect when the correction occurs in an iframe.
              https://bugs.webkit.org/show_bug.cgi?id=55717
              <rdar://problem/9018127>
      
              With the change in WebCore, the bounding box passed into EditorClient::showCorrectionPanel()
              is already in window coordinate. We don't need to do further conversion anymore.
      
              * WebCoreSupport/WebEditorClient.mm:
              (WebEditorClient::showCorrectionPanel):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@80408 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      8e5ed4ad
  9. 01 Mar, 2011 1 commit
    • leviw@chromium.org's avatar
      2011-03-01 Levi Weintraub <leviw@chromium.org> · ca40abff
      leviw@chromium.org authored
              Reviewed by Ryosuke Niwa.
      
              Stop instantiating legacy editing Positions in VisiblePosition
              https://bugs.webkit.org/show_bug.cgi?id=52919
      
              Changing usage of legacy VisiblePosition constructor. Since we were dealing
              with positions from DOM Ranges, we're guaranteed a parent-anchored position.
      
              * WebView/WebFrame.mm:
              (-[WebFrame _caretRectAtPosition:affinity:]):
              * WebView/WebFrameInternal.h:
              * WebView/WebTextCompletionController.mm:
              (-[WebTextCompletionController doCompletion]):
      2011-03-01  Levi Weintraub  <leviw@chromium.org>
      
              Reviewed by Ryosuke Niwa.
      
              Stop instantiating legacy editing Positions in VisiblePosition
              https://bugs.webkit.org/show_bug.cgi?id=52919
      
              Changing VisiblePosition completely away from legacy positions.
      
              No new tests since this is functionaly equivalent.
      
              * WebCore.exp.in: Removing the legacy VisiblePosition constructor and
              adding the PositionIsOffsetInAnchor symbol. If we must create VisiblePositions
              outside of WebCore, they should be parent anchored.
              * accessibility/AXObjectCache.cpp:
              (WebCore::AXObjectCache::visiblePositionForTextMarkerData):
              * accessibility/AccessibilityObject.cpp:
              (WebCore::startOfStyleRange):
              (WebCore::endOfStyleRange):
              * accessibility/AccessibilityRenderObject.cpp:
              (WebCore::AccessibilityRenderObject::visiblePositionForIndex):
              * accessibility/gtk/AccessibilityObjectWrapperAtk.cpp:
              (objectAndOffsetUnignored):
              * dom/Position.cpp:
              (WebCore::Position::document): Added this inline function to avoid the necessity
              of calling anchorNode to assure a document from a Position.
              (WebCore::Position::upstream): Fixed to correctly respect PositionIsAfterAnchor
              (WebCore::Position::downstream): ditto
              * dom/Range.cpp:
              (WebCore::Range::editingStartPosition):
              * editing/Editor.cpp:
              (WebCore::Editor::canDeleteRange):
              * editing/ReplaceSelectionCommand.cpp:
              (WebCore::ReplaceSelectionCommand::doApply):
              * editing/SelectionController.cpp:
              (WebCore::SelectionController::selectFrameElementInParentIfFullySelected):
              (WebCore::SelectionController::setSelectedRange):
              * editing/TextIterator.cpp:
              (WebCore::TextIterator::shouldRepresentNodeOffsetZero):
              * editing/TypingCommand.cpp:
              (WebCore::TypingCommand::deleteKeyPressed):
              * editing/VisiblePosition.cpp:
              (WebCore::VisiblePosition::leftVisuallyDistinctCandidate):
              (WebCore::VisiblePosition::rightVisuallyDistinctCandidate):
              (WebCore::VisiblePosition::canonicalPosition):
              (WebCore::VisiblePosition::characterAfter):
              (WebCore::VisiblePosition::localCaretRect):
              (WebCore::makeRange):
              (WebCore::startVisiblePosition):
              (WebCore::endVisiblePosition):
              (WebCore::setStart):
              (WebCore::setEnd):
              (WebCore::isFirstVisiblePositionInNode):
              (WebCore::isLastVisiblePositionInNode):
              * editing/VisiblePosition.h:
              (WebCore::VisiblePosition::VisiblePosition):
              * editing/htmlediting.cpp:
              (WebCore::firstInSpecialElement):
              (WebCore::lastInSpecialElement):
              (WebCore::visiblePositionBeforeNode):
              (WebCore::visiblePositionAfterNode):
              * editing/visible_units.cpp:
              (WebCore::startPositionForLine):
              (WebCore::endPositionForLine):
              (WebCore::previousLinePosition):
              (WebCore::nextLinePosition):
              (WebCore::startOfParagraph):
              (WebCore::endOfParagraph):
              (WebCore::endOfBlock):
              (WebCore::startOfDocument):
              (WebCore::endOfDocument):
              (WebCore::logicalStartPositionForLine):
              (WebCore::logicalEndPositionForLine):
              * page/DOMSelection.cpp:
              (WebCore::DOMSelection::collapse):
              (WebCore::DOMSelection::setBaseAndExtent):
              (WebCore::DOMSelection::setPosition):
              (WebCore::DOMSelection::extend):
              * page/EventHandler.cpp:
              (WebCore::EventHandler::handleMousePressEventSingleClick):
              * rendering/RenderObject.cpp:
              (WebCore::RenderObject::createVisiblePosition):
              * rendering/RenderTextControl.cpp:
              (WebCore::RenderTextControl::visiblePositionForIndex):
              * svg/SVGTextContentElement.cpp:
              (WebCore::SVGTextContentElement::selectSubString):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@80059 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      ca40abff
  10. 28 Feb, 2011 1 commit
    • rniwa@webkit.org's avatar
      2011-02-28 Ryosuke Niwa <rniwa@webkit.org> · b256204c
      rniwa@webkit.org authored
              Reviewed by Kent Tamura.
      
              Range::processContents needs cleanup
              https://bugs.webkit.org/show_bug.cgi?id=51006
      
              Refactored Range::processContents.  Extracted childOfCommonRootBeforeOffset from processContents
              which is used to find processStart and processEnd respectively.  In the case of processStart,
              we use the next sibling of the node returned by childOfCommonRootBeforeOffset when m_start is not
              the common root because copying m_start's ancestors will result in processing too much contents.
      
              Also extracted processNodes and deleteCharacterData from processContents and processContentsBetweenOffsets.
      
              In addition, lengthOfContentsInNode was modified to return the correct length instead of
              numeric_limits<unsigned>::max() because the convention that processContentsBetweenOffsets automatically
              corrects the length when endOffset is numeric_limits<unsigned>::max() seemed more confusing than
              having two switch statements that need to be consistent.
      
              Historically, lengthOfContentsInNode was introduced in r78413 as a build fix because unsigned const
              LengthOfContentsInNode added in r78409 violated WebKit C++ rules and caused build failures on Mac and
              other ports.
      
              * dom/Range.cpp:
              (WebCore::childOfCommonRootBeforeOffset): Extracted from processContents.
              (WebCore::lengthOfContentsInNode): Added.
              (WebCore::Range::processContents): Calls childOfCommonRootBeforeOffset, lengthOfContentsInNode,
              and processNodes.
              (WebCore::deleteCharacterData): Added.
              (WebCore::Range::processContentsBetweenOffsets): Calls deleteCharacterData and processNodes.
              (WebCore::Range::processNodes): Extracted from processContents and processContentsBetweenOffsets.
              (WebCore::Range::processAncestorsAndTheirSiblings):
              * dom/Range.h:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@79854 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      b256204c
  11. 16 Feb, 2011 1 commit
    • rniwa@webkit.org's avatar
      2011-02-16 Ryosuke Niwa <rniwa@webkit.org> · 4c4be9cf
      rniwa@webkit.org authored
              Reviewed by Kent Tamura.
      
              Improve showTree of Range, Position, and VisiblePosition
              https://bugs.webkit.org/show_bug.cgi?id=54536
      
              Enhanced showTree of Range, Position, and VisiblePosition.
      
              * dom/Position.cpp:
              (WebCore::Position::showAnchorTypeAndOffset): Added; dumps "legacy" if the position
              is a legacy position and also dumps anchor type.
              (WebCore::Position::showTreeForThis): Calls showAnchorTypeAndOffset.
              * dom/Position.h:
              * dom/Range.cpp:
              (showTree): No longer calls deprecatedEditingOffset.
              * editing/VisiblePosition.cpp:
              (WebCore::VisiblePosition::debugPosition): No longer included in release build.
              Calls Position::showAnchorTypeAndOffset instead of manually calling deprecatedEditingOffset.
              * editing/VisiblePosition.h:
              * editing/VisibleSelection.cpp:
              (WebCore::VisibleSelection::debugPosition): Ditto.
              (WebCore::VisibleSelection::showTreeForThis): Ditto.
              * editing/VisibleSelection.h:
              * page/EventHandler.cpp:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@78761 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      4c4be9cf
  12. 15 Feb, 2011 1 commit
  13. 12 Feb, 2011 2 commits
    • rniwa@webkit.org's avatar
      2011-02-12 Ryosuke Niwa <rniwa@webkit.org> · 47e188f9
      rniwa@webkit.org authored
              Unreviewed build fix.
      
              * dom/Range.cpp:
              (WebCore::lengthOfContentsInNode): Replaced static const unsigned LengthOfContentsInNode.
              (WebCore::Range::processContents):
              (WebCore::Range::processContentsBetweenOffsets):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@78413 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      47e188f9
    • rniwa@webkit.org's avatar
      2011-02-11 Ryosuke Niwa <rniwa@webkit.org> · ea75851d
      rniwa@webkit.org authored
              Reviewed by Darin Adler.
      
              Extract a function to process contents for one node from Range::processContents
              https://bugs.webkit.org/show_bug.cgi?id=54282
      
              Extracted Range::processContentsBetweenOffsets, which process contents of a node
              between two offsets. This function is used for the simple case where the start
              and the end containers are of the same node, and to process start and end containers
              in the complex case.
      
              When the function takes a non-null fragment (simple case), it appends the processed
              contents to the fragment; character data and processing instruction's contents are copied
              between the offsets, and descendants are copied for node of other types (not node itself).
      
              When the fragment is null (complex case), the function copies contents of character data,
              processing instruction, and node of other types (including node itself).
      
              No new tests are added since this is a refactoring.
      
              * dom/Range.cpp:
              (WebCore::highestAncestorUnderCommonRoot): Added.
              (WebCore::Range::processContents): Calls highestAncestorUnderCommonRoot and
              processContentsBetweenOffsets.
              (WebCore::Range::processContentsBetweenOffsets): Added.
              * dom/Range.h:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@78409 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      ea75851d
  14. 09 Feb, 2011 1 commit
    • yael.aharon@nokia.com's avatar
      2011-02-09 Yael Aharon <yael.aharon@nokia.com> · 3be82c17
      yael.aharon@nokia.com authored
              Reviewed by Darin Adler.
      
              Replace static_cast<HTMLElement*> with toHTMLElement
              https://bugs.webkit.org/show_bug.cgi?id=54117
      
              No new tests since no new functionality was introduced.
      
              * accessibility/AccessibilityListBox.cpp:
              (WebCore::AccessibilityListBox::addChildren):
              * accessibility/AccessibilityMenuListPopup.cpp:
              (WebCore::AccessibilityMenuListPopup::addChildren):
              * accessibility/AccessibilityRenderObject.cpp:
              (WebCore::accessibleNameForNode):
              (WebCore::AccessibilityRenderObject::accessibilityDescription):
              * accessibility/gtk/AccessibilityObjectWrapperAtk.cpp:
              (webkit_accessible_get_name):
              (webkit_accessible_get_description):
              * bindings/gobject/WebKitDOMBinding.cpp:
              (WebKit::createWrapper):
              (WebKit::kit):
              * bindings/js/JSElementCustom.cpp:
              (WebCore::toJSNewlyCreated):
              * bindings/js/JSHTMLFrameSetElementCustom.cpp:
              (WebCore::JSHTMLFrameSetElement::nameGetter):
              * bindings/js/JSNodeCustom.cpp:
              (WebCore::createWrapperInline):
              * bindings/v8/custom/V8ElementCustom.cpp:
              (WebCore::toV8):
              * dom/Document.cpp:
              (WebCore::Document::body):
              * dom/Element.cpp:
              (WebCore::Element::deprecatedCreateContextualFragment):
              * dom/Range.cpp:
              (WebCore::Range::createContextualFragment):
              * editing/ApplyStyleCommand.cpp:
              (WebCore::ApplyStyleCommand::applyBlockStyle):
              (WebCore::ApplyStyleCommand::applyRelativeFontStyleChange):
              (WebCore::ApplyStyleCommand::splitAncestorsWithUnicodeBidi):
              (WebCore::ApplyStyleCommand::applyInlineStyleToNodeRange):
              (WebCore::ApplyStyleCommand::removeStyleFromRunBeforeApplyingStyle):
              (WebCore::ApplyStyleCommand::highestAncestorWithConflictingInlineStyle):
              (WebCore::ApplyStyleCommand::applyInlineStyleToPushDown):
              (WebCore::ApplyStyleCommand::pushDownInlineStyleAroundNode):
              (WebCore::ApplyStyleCommand::removeInlineStyle):
              (WebCore::ApplyStyleCommand::shouldSplitTextElement):
              (WebCore::ApplyStyleCommand::addInlineStyleIfNeeded):
              * editing/DeleteButtonController.cpp:
              (WebCore::enclosingDeletableElement):
              (WebCore::DeleteButtonController::show):
              * editing/Editor.cpp:
              (WebCore::Editor::setBaseWritingDirection):
              * editing/InsertListCommand.cpp:
              (WebCore::InsertListCommand::mergeWithNeighboringLists):
              * editing/ReplaceSelectionCommand.cpp:
              (WebCore::ReplaceSelectionCommand::negateStyleRulesThatAffectAppearance):
              (WebCore::ReplaceSelectionCommand::handleStyleSpans):
              (WebCore::ReplaceSelectionCommand::copyStyleToChildren):
              * editing/SelectionController.cpp:
              (WebCore::scanForForm):
              (WebCore::SelectionController::currentForm):
              * editing/htmlediting.cpp:
              (WebCore::enclosingList):
              (WebCore::enclosingListChild):
              (WebCore::embeddedSublist):
              (WebCore::appendedSublist):
              * editing/markup.cpp:
              (WebCore::StyledMarkupAccumulator::appendElement):
              * html/HTMLCollection.cpp:
              (WebCore::HTMLCollection::checkForNameMatch):
              (WebCore::HTMLCollection::updateNameCache):
              * html/HTMLElement.cpp:
              (WebCore::HTMLElement::setOuterHTML):
              (WebCore::HTMLElement::shadowAncestorOwnerForm):
              * html/HTMLFormElement.cpp:
              (WebCore::HTMLFormElement::formElementIndex):
              * html/HTMLSelectElement.cpp:
              (WebCore::HTMLSelectElement::setOption):
              (WebCore::HTMLSelectElement::setLength):
              * inspector/InspectorDOMAgent.cpp:
              (WebCore::InspectorDOMAgent::getOuterHTML):
              (WebCore::InspectorDOMAgent::setOuterHTML):
              * page/EventHandler.cpp:
              (WebCore::EventHandler::handleMouseMoveEvent):
              * rendering/RenderMeter.cpp:
              (WebCore::RenderMeter::createPart):
              * rendering/RenderTextControl.cpp:
              (WebCore::RenderTextControl::createSubtreeIfNeeded):
              * rendering/RenderTextControlSingleLine.cpp:
              (WebCore::RenderTextControlSingleLine::createSubtreeIfNeeded):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@78150 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      3be82c17
  15. 08 Feb, 2011 2 commits
    • leviw@chromium.org's avatar
      2011-02-08 Sheriff Bot <webkit.review.bot@gmail.com> · 0f9d6132
      leviw@chromium.org authored
              Unreviewed, rolling out r77980.
              http://trac.webkit.org/changeset/77980
              https://bugs.webkit.org/show_bug.cgi?id=54043
      
              "Crashes on Windows and Linux..." (Requested by leviw on
              #webkit).
      
              * WebView/WebFrame.mm:
              (-[WebFrame _caretRectAtNode:offset:affinity:]):
              * WebView/WebFrameInternal.h:
              * WebView/WebTextCompletionController.mm:
              (-[WebTextCompletionController doCompletion]):
      2011-02-08  Sheriff Bot  <webkit.review.bot@gmail.com>
      
              Unreviewed, rolling out r77980.
              http://trac.webkit.org/changeset/77980
              https://bugs.webkit.org/show_bug.cgi?id=54043
      
              "Crashes on Windows and Linux..." (Requested by leviw on
              #webkit).
      
              * WebCore.exp.in:
              * accessibility/AXObjectCache.cpp:
              (WebCore::AXObjectCache::visiblePositionForTextMarkerData):
              * accessibility/AccessibilityObject.cpp:
              (WebCore::startOfStyleRange):
              (WebCore::endOfStyleRange):
              * accessibility/AccessibilityRenderObject.cpp:
              (WebCore::AccessibilityRenderObject::visiblePositionForIndex):
              * accessibility/gtk/AccessibilityObjectWrapperAtk.cpp:
              (objectAndOffsetUnignored):
              * dom/Position.cpp:
              (WebCore::Position::upstream):
              (WebCore::Position::downstream):
              * dom/Range.cpp:
              (WebCore::Range::editingStartPosition):
              * editing/Editor.cpp:
              (WebCore::Editor::canDeleteRange):
              * editing/ReplaceSelectionCommand.cpp:
              (WebCore::ReplaceSelectionCommand::doApply):
              * editing/SelectionController.cpp:
              (WebCore::SelectionController::selectFrameElementInParentIfFullySelected):
              (WebCore::SelectionController::setSelectedRange):
              * editing/TextIterator.cpp:
              (WebCore::TextIterator::shouldRepresentNodeOffsetZero):
              * editing/TypingCommand.cpp:
              (WebCore::TypingCommand::deleteKeyPressed):
              * editing/VisiblePosition.cpp:
              (WebCore::VisiblePosition::VisiblePosition):
              (WebCore::VisiblePosition::leftVisuallyDistinctCandidate):
              (WebCore::VisiblePosition::rightVisuallyDistinctCandidate):
              (WebCore::VisiblePosition::canonicalPosition):
              (WebCore::VisiblePosition::characterAfter):
              (WebCore::VisiblePosition::localCaretRect):
              (WebCore::makeRange):
              (WebCore::startVisiblePosition):
              (WebCore::endVisiblePosition):
              (WebCore::setStart):
              (WebCore::setEnd):
              (WebCore::isFirstVisiblePositionInNode):
              (WebCore::isLastVisiblePositionInNode):
              * editing/VisiblePosition.h:
              * editing/htmlediting.cpp:
              (WebCore::firstInSpecialElement):
              (WebCore::lastInSpecialElement):
              (WebCore::visiblePositionBeforeNode):
              (WebCore::visiblePositionAfterNode):
              * editing/visible_units.cpp:
              (WebCore::startPositionForLine):
              (WebCore::endPositionForLine):
              (WebCore::previousLinePosition):
              (WebCore::nextLinePosition):
              (WebCore::startOfParagraph):
              (WebCore::endOfParagraph):
              (WebCore::endOfBlock):
              (WebCore::startOfDocument):
              (WebCore::endOfDocument):
              (WebCore::logicalStartPositionForLine):
              (WebCore::logicalEndPositionForLine):
              * page/DOMSelection.cpp:
              (WebCore::DOMSelection::collapse):
              (WebCore::DOMSelection::setBaseAndExtent):
              (WebCore::DOMSelection::setPosition):
              (WebCore::DOMSelection::extend):
              * page/EventHandler.cpp:
              (WebCore::EventHandler::handleMousePressEventSingleClick):
              * rendering/RenderObject.cpp:
              (WebCore::RenderObject::createVisiblePosition):
              * rendering/RenderTextControl.cpp:
              (WebCore::RenderTextControl::visiblePositionForIndex):
              * svg/SVGTextContentElement.cpp:
              (WebCore::SVGTextContentElement::selectSubString):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@77997 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      0f9d6132
    • leviw@chromium.org's avatar
      2011-02-08 Levi Weintraub <leviw@chromium.org> · ddcb501f
      leviw@chromium.org authored
              Reviewed by Ryosuke Niwa.
      
              Stop instantiating legacy editing Positions in VisiblePosition
              https://bugs.webkit.org/show_bug.cgi?id=52919
      
              Changing usage of legacy VisiblePosition constructor. Since we were dealing
              with positions from DOM Ranges, we're guaranteed a parent-anchored position.
      
              * WebView/WebFrame.mm:
              (-[WebFrame _caretRectAtPosition:affinity:]):
              * WebView/WebFrameInternal.h:
              * WebView/WebTextCompletionController.mm:
              (-[WebTextCompletionController doCompletion]):
      2011-02-08  Levi Weintraub  <leviw@chromium.org>
      
              Reviewed by Ryosuke Niwa.
      
              Stop instantiating legacy editing Positions in VisiblePosition
              https://bugs.webkit.org/show_bug.cgi?id=52919
      
              Changing VisiblePosition completely away from legacy positions.
      
              No new tests since this is functionaly equivalent.
      
              * WebCore.exp.in: Removing the legacy VisiblePosition constructor and
              adding the PositionIsOffsetInAnchor symbol. If we must create VisiblePositions
              outside of WebCore, they should be parent anchored.
              * accessibility/AXObjectCache.cpp:
              (WebCore::AXObjectCache::visiblePositionForTextMarkerData):
              * accessibility/AccessibilityObject.cpp:
              (WebCore::startOfStyleRange):
              (WebCore::endOfStyleRange):
              * accessibility/AccessibilityRenderObject.cpp:
              (WebCore::AccessibilityRenderObject::visiblePositionForIndex):
              * accessibility/gtk/AccessibilityObjectWrapperAtk.cpp:
              (objectAndOffsetUnignored):
              * dom/Position.cpp:
              (WebCore::Position::upstream): Fixed to correctly respect PositionIsAfterAnchor
              (WebCore::Position::downstream): ditto
              * dom/Range.cpp:
              (WebCore::Range::editingStartPosition):
              * editing/Editor.cpp:
              (WebCore::Editor::canDeleteRange):
              * editing/ReplaceSelectionCommand.cpp:
              (WebCore::ReplaceSelectionCommand::doApply):
              * editing/SelectionController.cpp:
              (WebCore::SelectionController::selectFrameElementInParentIfFullySelected):
              (WebCore::SelectionController::setSelectedRange):
              * editing/TextIterator.cpp:
              (WebCore::TextIterator::shouldRepresentNodeOffsetZero):
              * editing/TypingCommand.cpp:
              (WebCore::TypingCommand::deleteKeyPressed):
              * editing/VisiblePosition.cpp:
              (WebCore::VisiblePosition::leftVisuallyDistinctCandidate):
              (WebCore::VisiblePosition::rightVisuallyDistinctCandidate):
              (WebCore::VisiblePosition::canonicalPosition):
              (WebCore::VisiblePosition::characterAfter):
              (WebCore::VisiblePosition::localCaretRect):
              (WebCore::makeRange):
              (WebCore::startVisiblePosition):
              (WebCore::endVisiblePosition):
              (WebCore::setStart):
              (WebCore::setEnd):
              (WebCore::isFirstVisiblePositionInNode):
              (WebCore::isLastVisiblePositionInNode):
              * editing/VisiblePosition.h:
              (WebCore::VisiblePosition::VisiblePosition):
              * editing/htmlediting.cpp:
              (WebCore::firstInSpecialElement):
              (WebCore::lastInSpecialElement):
              (WebCore::visiblePositionBeforeNode):
              (WebCore::visiblePositionAfterNode):
              * editing/visible_units.cpp:
              (WebCore::startPositionForLine):
              (WebCore::endPositionForLine):
              (WebCore::previousLinePosition):
              (WebCore::nextLinePosition):
              (WebCore::startOfParagraph):
              (WebCore::endOfParagraph):
              (WebCore::endOfBlock):
              (WebCore::startOfDocument):
              (WebCore::endOfDocument):
              (WebCore::logicalStartPositionForLine):
              (WebCore::logicalEndPositionForLine):
              * page/DOMSelection.cpp:
              (WebCore::DOMSelection::collapse):
              (WebCore::DOMSelection::setBaseAndExtent):
              (WebCore::DOMSelection::setPosition):
              (WebCore::DOMSelection::extend):
              * page/EventHandler.cpp:
              (WebCore::EventHandler::handleMousePressEventSingleClick):
              * rendering/RenderObject.cpp:
              (WebCore::RenderObject::createVisiblePosition):
              * rendering/RenderTextControl.cpp:
              (WebCore::RenderTextControl::visiblePositionForIndex):
              * svg/SVGTextContentElement.cpp:
              (WebCore::SVGTextContentElement::selectSubString):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@77980 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      ddcb501f
  16. 15 Jan, 2011 1 commit
    • ddkilzer@apple.com's avatar
      <http://webkit.org/b/52512> REGRESSION(r73818): range.cloneContents() ignores end offset · d673f252
      ddkilzer@apple.com authored
      Reviewed by Adele Peterson.
      
      WebCore:
      
      The fix for Bug 50710 in r73799 introduced an off-by-one error
      when copying nodes to a local NodeVector for processing.  A fix
      was attempted for Bug 50854 in r73818, but instead of stopping
      at the end offset, it iterates through all the sibling nodes
      because the loop variable (i) is never incremented.  To clean
      this up, revert back to the code in r73799 and fix the
      off-by-one error.
      
      Test: fast/dom/Range/range-clone-contents.html
      
      * dom/Range.cpp:
      (WebCore::Range::processContents): Fix the loop that copies
      nodes to a local NodeVector by restoring the code from r73799
      and fixing the off-by-one error.
      
      LayoutTests:
      
      * fast/dom/Range/range-clone-contents-expected.txt: Added.
      * fast/dom/Range/range-clone-contents.html: Added.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@75882 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      d673f252
  17. 08 Jan, 2011 1 commit
  18. 21 Dec, 2010 1 commit
    • commit-queue@webkit.org's avatar
      2010-12-21 Dominic Cooney <dominicc@google.com> · 3fa5e11c
      commit-queue@webkit.org authored
              Reviewed by Adam Barth.
      
              Rename Node::isShadowNode to isShadowRoot
              https://bugs.webkit.org/show_bug.cgi?id=51060
      
              The method gets whether the node is the root of a shadow tree;
              renamed to reflect intent.
      
              A simple rename--no new tests needed.
      
              * css/CSSStyleSelector.cpp:
              (WebCore::CSSStyleSelector::initForStyleResolve):
              (WebCore::CSSStyleSelector::SelectorChecker::checkSelector):
              * dom/Node.cpp:
              (WebCore::Node::shadowTreeRootNode):
              (WebCore::Node::isInShadowTree):
              (WebCore::eventTargetRespectingSVGTargetRules):
              (WebCore::Node::getEventAncestors):
              * dom/Node.h:
              (WebCore::Node::isShadowRoot):
              * dom/Range.cpp:
              (WebCore::Range::checkNodeBA):
              * page/DragController.cpp:
              (WebCore::asFileInput):
              * page/EventHandler.cpp:
              (WebCore::EventHandler::handleMousePressEvent):
              (WebCore::EventHandler::dispatchMouseEvent):
              * rendering/RenderBlock.cpp:
              (WebCore::RenderBlock::hasLineIfEmpty):
              * rendering/TextControlInnerElements.cpp:
              (WebCore::TextControlInnerElement::attachInnerElement):
              * svg/SVGStyledElement.cpp:
              (WebCore::SVGStyledElement::title):
              * svg/SVGUseElement.cpp:
              (WebCore::ShadowTreeUpdateBlocker::while):
              * svg/animation/SVGSMILElement.cpp:
              (WebCore::SVGSMILElement::insertedIntoDocument):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@74406 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      3fa5e11c
  19. 10 Dec, 2010 3 commits
  20. 29 Nov, 2010 1 commit
    • commit-queue@webkit.org's avatar
      2010-11-29 Cosmin Truta <ctruta@chromium.org> · 8028c060
      commit-queue@webkit.org authored
              Reviewed by Nikolas Zimmermann.
      
              getBoundingClientRect: Do not truncate the coordinates to integers
              https://bugs.webkit.org/show_bug.cgi?id=48110
      
              Enhanced some of the tests for getBoundingClientRect, and added zooming tests.
      
              * css3/zoom-coords-expected.txt: Updated.
              * css3/zoom-coords.xhtml: Wrapped the <svg> elements in a <div>,
              to avoid re-layout on zooming or resizing.
              Added a test for getBoundingClientRect on unzoomed elements.
              * fast/dom/Element/getBoundingClientRect-expected.txt: Updated.
              * fast/dom/Element/getBoundingClientRect.html: Accounted for non-integer coordinates;
              used the Ahem font for uniform results; removed the hard-coded dependencies on font metrics.
              * fast/dom/Range/getBoundingClientRect-expected.txt: Updated.
              * fast/dom/Range/getBoundingClientRect.html: Accounted for non-integer coordinates;
              used the Ahem font for uniform results; removed the hard-coded dependencies on font metrics.
              * platform/chromium-win/fast/dom/Element/getBoundingClientRect-expected.txt: Deleted.
              * platform/chromium-win/fast/dom/Range/getBoundingClientRect-expected.txt: Deleted.
              * svg/custom/getBBox-js.svg: Fixed indentation.
              * svg/custom/getBoundingClientRect.xhtml: Wrapped the <svg> elements in a <div>,
              to avoid re-layout on zooming or resizing.
              * svg/zoom/page/zoom-getBoundingClientRect-expected.txt: Added.
              * svg/zoom/page/zoom-getBoundingClientRect.xhtml: Added.
              * svg/zoom/page/zoom-zoom-coords-expected.txt: Added.
              * svg/zoom/page/zoom-zoom-coords.xhtml: Added.
              * svg/zoom/resources/testPageZoom.js: Added call to completeDynamicTest on post-zoom.
              (completeDynamicTest): Added.
      2010-11-29  Cosmin Truta  <ctruta@chromium.org>
      
              Reviewed by Nikolas Zimmermann.
      
              getBoundingClientRect: Do not truncate the coordinates to integers
              https://bugs.webkit.org/show_bug.cgi?id=48110
      
              Remove the float-to-int coordinate conversions inside getBoundingClientRect,
              to comply with the CSSOM View Module API.
      
              Tests: fast/dom/Element/getBoundingClientRect.html
                     fast/dom/Range/getBoundingClientRect.html
                     svg/zoom/page/zoom-getBoundingClientRect.xhtml
                     svg/zoom/page/zoom-zoom-coords.xhtml
      
              * dom/ClientRect.cpp:
              (WebCore::ClientRect::ClientRect): Added overload to allow a FloatRect argument.
              * dom/ClientRect.h:
              (WebCore::ClientRect::create): Ditto.
              * dom/Element.cpp:
              (Element::getBoundingClientRect): Removed conversion from FloatRect to IntRect.
              * dom/Range.cpp:
              (WebCore::Range::getBoundingClientRect): Ditto.
              * rendering/RenderObject.h:
              (adjustIntRectForAbsoluteZoom): Removed.
              (adjustFloatRectForAbsoluteZoom): Added.
              * rendering/style/RenderStyle.h:
              (adjustFloatForAbsoluteZoom): Added.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@72826 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      8028c060
  21. 15 Oct, 2010 1 commit
    • darin@apple.com's avatar
      2010-10-14 Darin Adler <darin@apple.com> · 601d44bd
      darin@apple.com authored
              Reviewed by Alexey Proskuryakov.
      
              Use more specific types for node pointers, especially when calling node insertion and removal functions
              https://bugs.webkit.org/show_bug.cgi?id=47702
      
              Refactoring. No new tests.
      
              While developing this patch I temporarily removed the node insertion and
              removal member functions from the Node class and fixed almost all call sites
              so they call it directly on the ContainerNode class, which will be important
              once we make the functions non-virtual.
      
              * css/CSSStyleSelector.cpp:
              (WebCore::CSSStyleSelector::SelectorChecker::checkSelector):
              * dom/ContainerNode.cpp:
              (WebCore::ContainerNode::insertBefore):
              (WebCore::ContainerNode::replaceChild):
              (WebCore::ContainerNode::appendChild):
              * dom/Document.cpp:
              (WebCore::Document::caretRangeFromPoint):
              * dom/DynamicNodeList.cpp:
              (WebCore::DynamicNodeList::itemWithName):
              * dom/Position.cpp:
              (WebCore::Position::previous):
              (WebCore::Position::next):
              * dom/Text.cpp:
              (WebCore::Text::replaceWholeText):
              * dom/TreeWalker.cpp:
              (WebCore::TreeWalker::firstChild):
              (WebCore::TreeWalker::lastChild):
              (WebCore::TreeWalker::previousNode):
              * dom/XMLDocumentParserLibxml2.cpp:
              (WebCore::XMLDocumentParser::XMLDocumentParser):
              * editing/BreakBlockquoteCommand.cpp:
              (WebCore::BreakBlockquoteCommand::doApply):
              * editing/CompositeEditCommand.h:
              * editing/DeleteButtonController.cpp:
              (WebCore::isDeletableElement):
              * editing/IndentOutdentCommand.cpp:
              (WebCore::IndentOutdentCommand::outdentParagraph):
              * editing/InsertNodeBeforeCommand.cpp:
              (WebCore::InsertNodeBeforeCommand::doApply):
              * editing/JoinTextNodesCommand.cpp:
              (WebCore::JoinTextNodesCommand::doApply):
              (WebCore::JoinTextNodesCommand::doUnapply):
              * editing/MergeIdenticalElementsCommand.cpp:
              (WebCore::MergeIdenticalElementsCommand::doUnapply):
              * editing/RemoveNodeCommand.cpp:
              (WebCore::RemoveNodeCommand::doApply):
              (WebCore::RemoveNodeCommand::doUnapply):
              * editing/RemoveNodeCommand.h:
              * editing/SplitElementCommand.cpp:
              (WebCore::SplitElementCommand::executeApply):
              * editing/SplitTextNodeCommand.cpp:
              (WebCore::SplitTextNodeCommand::doApply):
              (WebCore::SplitTextNodeCommand::doReapply):
              * editing/TextIterator.cpp:
              (WebCore::parentCrossingShadowBoundaries):
              * editing/htmlediting.cpp:
              (WebCore::enclosingList):
              * editing/markup.cpp:
              (WebCore::serializeNodes):
              (WebCore::ancestorToRetainStructureAndAppearance):
              (WebCore::createMarkup):
              * html/HTMLAreaElement.cpp:
              (WebCore::HTMLAreaElement::updateFocusAppearance):
              * html/HTMLEmbedElement.cpp:
              (WebCore::HTMLEmbedElement::rendererIsNeeded):
              * html/HTMLFormElement.cpp:
              (WebCore::HTMLFormElement::rendererIsNeeded):
              * html/HTMLFrameSetElement.cpp:
              (WebCore::HTMLFrameSetElement::attach):
              * html/HTMLImageElement.cpp:
              (WebCore::HTMLImageElement::insertedIntoTree):
              * html/HTMLLegendElement.cpp:
              (WebCore::HTMLLegendElement::associatedControl):
              * html/HTMLOptGroupElement.cpp:
              (WebCore::HTMLOptGroupElement::recalcSelectOptions):
              (WebCore::HTMLOptGroupElement::ownerSelectElement):
              * html/HTMLOptionElement.cpp:
              (WebCore::HTMLOptionElement::ownerSelectElement):
              * html/HTMLTableCellElement.cpp:
              (WebCore::HTMLTableCellElement::additionalAttributeStyleDecls):
              * html/HTMLTableColElement.cpp:
              (WebCore::HTMLTableColElement::additionalAttributeStyleDecls):
              * html/HTMLTableElement.cpp:
              (WebCore::HTMLTableElement::insertRow):
              * html/HTMLTableRowElement.cpp:
              (WebCore::HTMLTableRowElement::rowIndex):
              * html/HTMLTableSectionElement.cpp:
              (WebCore::HTMLTableSectionElement::additionalAttributeStyleDecls):
              * page/DOMSelection.cpp:
              (WebCore::DOMSelection::getRangeAt):
              (WebCore::DOMSelection::containsNode):
              * rendering/RenderSVGGradientStop.cpp:
              (WebCore::RenderSVGGradientStop::gradientElement):
              * svg/SVGElement.cpp:
              (WebCore::SVGElement::ownerSVGElement):
              (WebCore::SVGElement::viewportElement):
              * svg/SVGFELightElement.cpp:
              (WebCore::SVGFELightElement::svgAttributeChanged):
              (WebCore::SVGFELightElement::childrenChanged):
              * svg/SVGFEMergeNodeElement.cpp:
              (WebCore::SVGFEMergeNodeElement::svgAttributeChanged):
              * svg/SVGFontFaceFormatElement.cpp:
              (WebCore::SVGFontFaceFormatElement::childrenChanged):
              * svg/SVGFontFaceUriElement.cpp:
              (WebCore::SVGFontFaceUriElement::childrenChanged):
              * svg/SVGGlyphElement.cpp:
              (WebCore::SVGGlyphElement::invalidateGlyphCache):
              * svg/SVGHKernElement.cpp:
              (WebCore::SVGHKernElement::insertedIntoDocument):
              (WebCore::SVGHKernElement::removedFromDocument):
              * svg/SVGLocatable.cpp:
              (WebCore::SVGLocatable::nearestViewportElement):
              (WebCore::SVGLocatable::farthestViewportElement):
              * svg/SVGUseElement.cpp:
              (WebCore::SVGUseElement::updateContainerOffsets):
              * svg/SVGVKernElement.cpp:
              (WebCore::SVGVKernElement::insertedIntoDocument):
              (WebCore::SVGVKernElement::removedFromDocument):
              * svg/animation/SVGSMILElement.cpp:
              (WebCore::SVGSMILElement::targetElement):
              * wml/WMLDoElement.cpp:
              (WebCore::WMLDoElement::insertedIntoDocument):
              (WebCore::WMLDoElement::removedFromDocument):
              * wml/WMLNoopElement.cpp:
              (WebCore::WMLNoopElement::insertedIntoDocument):
              * wml/WMLOptionElement.cpp:
              (WebCore::ownerSelectElement):
              * wml/WMLPostfieldElement.cpp:
              (WebCore::WMLPostfieldElement::insertedIntoDocument):
              (WebCore::WMLPostfieldElement::removedFromDocument):
              * wml/WMLSetvarElement.cpp:
              (WebCore::WMLSetvarElement::insertedIntoDocument):
              (WebCore::WMLSetvarElement::removedFromDocument):
              * wml/WMLTaskElement.cpp:
              (WebCore::WMLTaskElement::insertedIntoDocument):
              (WebCore::WMLTaskElement::removedFromDocument):
              * wml/WMLTimerElement.cpp:
              (WebCore::WMLTimerElement::insertedIntoDocument):
              (WebCore::WMLTimerElement::removedFromDocument):
              * xml/XPathStep.cpp:
              (WebCore::XPath::Step::nodesInAxis):
              Use ContainerNode* for the result of the parentNode function now that
              it returns a ContainerNode*. In the past it used to return just Node*.
      
              * dom/ContainerNode.h: Added toContainerNode.
      
              * dom/Element.h: Use ContainerNode*. Added toElement.
      
              * dom/Element.cpp:
              (WebCore::Element::deprecatedCreateContextualFragment): Explcitly
              cast to HTMLElement* in the case that handles <html> and <body>
              elements.
              (WebCore::Element::baseURI): Use ContainerNode*.
      
              * dom/Node.cpp:
              (WebCore::Node::markAncestorsWithChildNeedsStyleRecalc): Use ContainerNode*.
              (WebCore::Node::isDescendantOf): Ditto.
              (WebCore::Node::createRendererIfNeeded): Ditto.
              (WebCore::Node::setTextContent): Use already-typecast pointer in a call to
              appendChild.
              (WebCore::Node::ancestorElement): Use ContainerNode*.
      
              * dom/Range.cpp:
              (WebCore::Range::compareNode): Use ContainerNode*.
              (WebCore::Range::intersectsNode): Ditto.
              (WebCore::Range::processContents): Cast to ContainerNode* in a couple cases
              where we previously checked that the node in question has a child. Any node
              that returns a non-zero value for firstChild is a ContainerNode.
              (WebCore::Range::checkNodeBA): Ditto.
              (WebCore::Range::selectNode): Ditto.
              (WebCore::Range::surroundContents): Ditto.
      
              * dom/XMLDocumentParser.cpp:
              (WebCore::XMLDocumentParser::insertErrorMessageBlock): Rewrote code to use
              more specific types, document instead of doc, and paragraph instead of par.
      
              * editing/ApplyStyleCommand.cpp:
              (WebCore::ApplyStyleCommand::removeStyleFromRunBeforeApplyingStyle):
              Use ContainerNode*.
              (WebCore::ApplyStyleCommand::replaceWithSpanOrRemoveIfWithoutAttributes):
              Use replaceElementWithSpanPreservingChildrenAndAttributes; the old function
              took a Node argument and had Node in its name.
      
              * editing/CompositeEditCommand.cpp:
              (WebCore::CompositeEditCommand::removeNodeAndPruneAncestors): Use ContainerNode.
              (WebCore::CompositeEditCommand::replaceElementWithSpanPreservingChildrenAndAttributes):
              Renamed and changed to take HTMLElement. Also use ContainerNode.
              (WebCore::CompositeEditCommand::prune): Ditto.
              (WebCore::CompositeEditCommand::breakOutOfEmptyListItem): Ditto.
              (WebCore::CompositeEditCommand::breakOutOfEmptyMailBlockquotedParagraph): Ditto.
      
              * editing/ReplaceNodeWithSpanCommand.cpp:
              (WebCore::ReplaceNodeWithSpanCommand::ReplaceNodeWithSpanCommand): Take an
              HTMLElement instead of a Node. Call it m_elementToReplace instead of m_node.
              (WebCore::swapInNodePreservingAttributesAndChildren): Take HTMLElement.
              (WebCore::ReplaceNodeWithSpanCommand::doApply): Updated for name changes.
              (WebCore::ReplaceNodeWithSpanCommand::doUnapply): Ditto.
              * editing/ReplaceNodeWithSpanCommand.h: Ditto.
      
              * editing/ReplaceSelectionCommand.cpp:
              (WebCore::ReplacementFragment::ReplacementFragment): Use StyledElement for result
              of insertFragmentForTestRendering since that's what it returns.
              (WebCore::ReplacementFragment::removeNode): Use ContainerNode.
              (WebCore::ReplacementFragment::insertNodeBefore): Ditto.
              (WebCore::ReplacementFragment::insertFragmentForTestRendering): Return StyledElement.
              Use HTMLElement for body.
              (WebCore::ReplacementFragment::restoreTestRenderingNodesToFragment): Take
              StyledElement.
              (WebCore::ReplaceSelectionCommand::handleStyleSpans): Use ContainerNode.
              (WebCore::ReplaceSelectionCommand::copyStyleToChildren): Use HTMLElement for
              the cloned span, since the clone will be a sspan too.
              (WebCore::ReplaceSelectionCommand::insertAsListItems): Use ContainerNode since
              the list item has a child, and that proves it is a ContainerNode.
      
              * editing/SelectionController.cpp:
              (WebCore::SelectionController::selectFrameElementInParentIfFullySelected):
              Use ContainerNode and also removed an unnneded local variable.
      
              * html/HTMLElement.cpp:
              (WebCore::HTMLElement::setOuterText): Use ContainerNode.
              (WebCore::HTMLElement::insertAdjacent): Use ContainerNode and also use && to make
              the logic a little simpler.
              (WebCore::contextElementForInsertion): Use ContainerNode.
              (WebCore::HTMLElement::findFormAncestor): Ditto.
      
              * inspector/InspectorDOMAgent.cpp:
              (WebCore::InspectorDOMAgent::removeNode): Use ContainerNode.
              (WebCore::InspectorDOMAgent::changeTagName): Ditto.
              (WebCore::InspectorDOMAgent::setOuterHTML): Ditto.
              (WebCore::InspectorDOMAgent::innerParentNode): Use isDocumentNode instead of
              nodeType. We should almost never use nodeType inside the engine.
              (WebCore::InspectorDOMAgent::didInsertDOMNode): Use ContainerNode.
              (WebCore::InspectorDOMAgent::didRemoveDOMNode): Ditto.
      
              * wml/WMLOptGroupElement.cpp: Removed unneeded overrides of insertBefore,
              replaceChild, removeChild, appendChild, and removeChildren functions.
              Ths already overrides childrenChanged, that is called by all of the above,
              and it does the same thing these functions did.
              (WebCore::ownerSelectElement): Use ContainerNode.
              * wml/WMLOptGroupElement.h: Ditto.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@69868 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      601d44bd
  22. 16 Sep, 2010 1 commit
  23. 14 Aug, 2010 1 commit
    • eric@webkit.org's avatar
      2010-08-14 Eric Seidel <eric@webkit.org> · 5debb0f9
      eric@webkit.org authored
              Reviewed by Adam Barth.
      
              Move innerHTML off of Range::createContextualFragment
              https://bugs.webkit.org/show_bug.cgi?id=44011
      
              This makes all the editing tests stop failing under the
              HTML5 TreeBuilder.
      
              In a previous patch Adam disabled some of the (wrong) code
              in createContextualFragment when in html5 treebuilder mode.
              The problem is that the editing code depends on
              createContextualFragment (as well as the Range DOM API),
              so we have to leave this code in until we can figure
              out if it's right or wrong behavior for the Range API.
      
              This patch moves innerHTML/outerHTML off of using
              createContextualFragment and instead calls
              DocumentFragment::parseHTML directly (which is much simpler).
      
              I expect Adam and I will end up turning on the HTML5 TreeBuilder
              in the next couple days, and most of the if branches I added
              here will go away for good.
      
              I renamed Element::createContextualFragment to
              deprecatedCreateContextualFragment, to indicate that it's a
              dead API.  The editing code should move off of it and consider
              using DocumentFragment::parseHTML instead.
      
              * dom/Element.cpp:
              (WebCore::Element::deprecatedCreateContextualFragment):
              * dom/Element.h:
              * dom/Range.cpp:
              (WebCore::Range::createContextualFragment):
              * editing/markup.cpp:
              (WebCore::createFragmentFromMarkup):
              * html/HTMLElement.cpp:
              (WebCore::useLegacyTreeBuilder):
              (WebCore::HTMLElement::deprecatedCreateContextualFragment):
              (WebCore::HTMLElement::setInnerHTML):
              (WebCore::HTMLElement::setOuterHTML):
              * html/HTMLElement.h:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@65372 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      5debb0f9
  24. 02 Aug, 2010 1 commit
  25. 10 May, 2010 1 commit
    • ap@apple.com's avatar
      Reviewed by Darin Adler. · 748d5222
      ap@apple.com authored
              Based on a patch by Eric Seidel.
      
              https://bugs.webkit.org/show_bug.cgi?id=28697
              <rdar://problem/7946578> WebKit crash on WebCore::Node::nodeIndex()
      
              It's not OK to call ContainerNode::willRemoveChild() in a loop, because Range code assumes
              that it can adjust start and end position to any node except for the one being removed -
              so these notifications cannot be batched.
      
              Test: fast/dom/Range/remove-all-children-crash.html
      
              * dom/ContainerNode.cpp:
              (WebCore::willRemoveChild): Removed unused ExceptionCode.
              (WebCore::willRemoveChildren): New function, used in removeChildren() case.
              (WebCore::ContainerNode::removeChild): ExceptionCode return was always 0, don't bother with it.
              (WebCore::ContainerNode::removeChildren): Call willRemoveChildrenFromNode.
              (WebCore::dispatchChildRemovalEvents): Moved some logic out into willRemoveChildrenFromNode
              and willRemoveChild.
      
              * dom/Document.cpp:
              (WebCore::Document::nodeChildrenWillBeRemoved): New function, used in removeChildren() case.
      
              * dom/Document.h: 
              (WebCore::Document::nodeChildrenWillBeRemoved): New function, used in removeChildren() case.
      
              * dom/Range.h:
              * dom/Range.cpp:
              (WebCore::boundaryNodeChildrenWillBeRemoved): New function, used in removeChildren() case.
              (WebCore::Range::nodeChildrenWillBeRemoved): Ditto.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@59098 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      748d5222
  26. 01 Apr, 2010 1 commit
    • dbates@webkit.org's avatar
      2010-04-01 Daniel Bates <dbates@rim.com> · e2d62cfc
      dbates@webkit.org authored
              Reviewed by Darin Adler.
      
              https://bugs.webkit.org/show_bug.cgi?id=36901
      
              Removed functions Range::operator == and Range::operator != as they
              were using C++ code that was not sound and hence may have undefined
              behavior.
      
              Test case: manual-tests/crash-on-find-with-no-selection.html
      
              * dom/Range.cpp:
              (WebCore::areRangesEqual): Added.
              * dom/Range.h:
              * editing/markup.cpp:
              (WebCore::createMarkup): Modified to call WebCore::areRangesEqual.
              * manual-tests/crash-on-find-with-no-selection.html: Added.
              * page/Frame.cpp:
              (WebCore::Frame::findString): Modified to call WebCore::areRangesEqual.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@56940 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      e2d62cfc
  27. 30 Mar, 2010 1 commit
    • barraclough@apple.com's avatar
      Rubber stamped by Sam Weinig. · 00b7992e
      barraclough@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=36866
      Move CString to WTF
      
      JavaScriptCore: 
      
      * Android.mk:
      * GNUmakefile.am:
      * JavaScriptCore.exp:
      * JavaScriptCore.gypi:
      * JavaScriptCore.pro:
      * JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:
      * JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj:
      * JavaScriptCore.vcproj/WTF/WTF.vcproj:
      * JavaScriptCore.xcodeproj/project.pbxproj:
      * wtf/text: Added.
      * wtf/text/CString.cpp: Copied from WebCore/platform/text/CString.cpp.
      * wtf/text/CString.h: Copied from WebCore/platform/text/CString.h.
      (WTF::CStringBuffer::data):
      (WTF::CStringBuffer::length):
      (WTF::CStringBuffer::create):
      (WTF::CStringBuffer::CStringBuffer):
      (WTF::CStringBuffer::mutableData):
      (WTF::CString::CString):
      (WTF::CString::isNull):
      (WTF::CString::buffer):
      (WTF::operator!=):
      
      WebCore: 
      
      * Android.mk:
      * ForwardingHeaders/wtf/text: Added.
      * ForwardingHeaders/wtf/text/CString.h: Added.
      * GNUmakefile.am:
      * WebCore.base.exp:
      * WebCore.gypi:
      * WebCore.order:
      * WebCore.pro:
      * WebCore.vcproj/WebCore.vcproj:
      * WebCore.xcodeproj/project.pbxproj:
      * accessibility/gtk/AccessibilityObjectWrapperAtk.cpp:
      * bindings/js/JSDOMWindowBase.cpp:
      * bindings/js/ScheduledAction.cpp:
      * bindings/js/ScriptController.cpp:
      * bindings/v8/ScriptController.cpp:
      * bindings/v8/V8Binding.cpp:
      * bindings/v8/V8DOMWindowShell.cpp:
      * bridge/jni/JNIBridge.cpp:
      * bridge/jni/v8/JavaStringV8.h:
      (JSC::Bindings::JavaStringImpl::init):
      * css/CSSParser.cpp:
      * dom/CharacterData.cpp:
      * dom/Document.cpp:
      * dom/Element.cpp:
      * dom/Node.cpp:
      * dom/Position.cpp:
      * dom/Range.cpp:
      * dom/Text.cpp:
      * dom/XMLTokenizer.cpp:
      * dom/XMLTokenizerLibxml2.cpp:
      * dom/XMLTokenizerQt.cpp:
      * editing/SelectionController.cpp:
      * editing/VisiblePosition.cpp:
      * editing/VisibleSelection.cpp:
      * history/CachedFrame.cpp:
      * history/HistoryItem.cpp:
      * history/qt/HistoryItemQt.cpp:
      * html/FormDataList.h:
      (WebCore::FormDataList::appendData):
      (WebCore::FormDataList::Item::Item):
      (WebCore::FormDataList::Item::data):
      * html/HTMLDocument.cpp:
      * html/PreloadScanner.cpp:
      * inspector/InspectorController.cpp:
      * inspector/InspectorDOMAgent.cpp:
      * loader/DocLoader.cpp:
      * loader/FTPDirectoryDocument.cpp:
      * loader/FrameLoader.cpp:
      * loader/HistoryController.cpp:
      * loader/ProgressTracker.cpp:
      * loader/appcache/ApplicationCacheStorage.cpp:
      * loader/archive/cf/LegacyWebArchive.cpp:
      * loader/icon/wince/IconDatabaseWince.cpp:
      * loader/loader.cpp:
      * page/Console.cpp:
      * page/DOMWindow.cpp:
      * page/SecurityOrigin.cpp:
      * page/XSSAuditor.cpp:
      * page/animation/AnimationBase.cpp:
      * platform/ContextMenu.cpp:
      * platform/FileSystem.h:
      * platform/KURL.cpp:
      * platform/KURLGoogle.cpp:
      * platform/KURLGooglePrivate.h:
      * platform/Pasteboard.h:
      * platform/android/FileSystemAndroid.cpp:
      * platform/android/TemporaryLinkStubs.cpp:
      * platform/brew/KURLBrew.cpp:
      * platform/cf/FileSystemCF.cpp:
      * platform/chromium/MIMETypeRegistryChromium.cpp:
      * platform/efl/FileSystemEfl.cpp:
      * platform/efl/PasteboardEfl.cpp:
      * platform/efl/PlatformKeyboardEventEfl.cpp:
      * platform/efl/PlatformScreenEfl.cpp:
      * platform/efl/RenderThemeEfl.cpp:
      * platform/efl/ScrollbarEfl.cpp:
      * platform/efl/SharedBufferEfl.cpp:
      * platform/efl/WidgetEfl.cpp:
      * platform/graphics/GlyphPageTreeNode.cpp:
      * platform/graphics/cairo/FontPlatformDataCairo.cpp:
      * platform/graphics/cg/ImageBufferCG.cpp:
      * platform/graphics/chromium/FontCacheLinux.cpp:
      * platform/graphics/chromium/FontPlatformDataLinux.h:
      * platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:
      * platform/graphics/gstreamer/WebKitWebSourceGStreamer.cpp:
      * platform/graphics/gtk/FontPlatformDataPango.cpp:
      * platform/graphics/gtk/IconGtk.cpp:
      * platform/graphics/gtk/ImageGtk.cpp:
      * platform/graphics/haiku/GraphicsContextHaiku.cpp:
      * platform/graphics/mac/GraphicsContext3DMac.cpp:
      * platform/graphics/mac/GraphicsLayerCA.mm:
      * platform/graphics/qt/GraphicsContext3DQt.cpp:
      * platform/graphics/qt/ImageBufferQt.cpp:
      * platform/graphics/qt/MediaPlayerPrivatePhonon.cpp:
      * platform/graphics/qt/MediaPlayerPrivateQt.cpp:
      * platform/graphics/skia/GraphicsLayerSkia.cpp:
      * platform/graphics/win/GraphicsLayerCACF.cpp:
      * platform/graphics/win/WKCACFLayer.cpp:
      * platform/graphics/wx/FontPlatformData.h:
      * platform/gtk/ClipboardGtk.cpp:
      * platform/gtk/ContextMenuItemGtk.cpp:
      * platform/gtk/DataObjectGtk.h:
      * platform/gtk/FileChooserGtk.cpp:
      * platform/gtk/FileSystemGtk.cpp:
      * platform/gtk/GeolocationServiceGtk.cpp:
      * platform/gtk/KURLGtk.cpp:
      * platform/gtk/Language.cpp:
      * platform/gtk/LocalizedStringsGtk.cpp:
      * platform/gtk/PasteboardGtk.cpp:
      * platform/gtk/PopupMenuGtk.cpp:
      * platform/gtk/RenderThemeGtk.cpp:
      * platform/gtk/SharedBufferGtk.cpp:
      * platform/haiku/FileSystemHaiku.cpp:
      * platform/haiku/PlatformKeyboardEventHaiku.cpp:
      * platform/network/CredentialStorage.cpp:
      * platform/network/FormData.cpp:
      * platform/network/FormData.h:
      * platform/network/FormDataBuilder.cpp:
      * platform/network/FormDataBuilder.h:
      * platform/network/HTTPParsers.cpp:
      * platform/network/android/ResourceHandleAndroid.cpp:
      * platform/network/cf/FormDataStreamCFNet.cpp:
      * platform/network/cf/ResourceHandleCFNet.cpp:
      * platform/network/chromium/ResourceResponse.h:
      * platform/network/curl/FormDataStreamCurl.cpp:
      * platform/network/curl/ResourceHandleManager.cpp:
      * platform/network/curl/ResourceHandleManager.h:
      * platform/network/mac/FormDataStreamMac.mm:
      * platform/network/mac/ResourceHandleMac.mm:
      * platform/network/qt/QNetworkReplyHandler.cpp:
      * platform/network/soup/CookieJarSoup.cpp:
      * platform/network/soup/ResourceHandleSoup.cpp:
      * platform/network/soup/ResourceRequestSoup.cpp:
      * platform/network/soup/ResourceResponseSoup.cpp:
      * platform/network/win/ResourceHandleWin.cpp:
      * platform/posix/FileSystemPOSIX.cpp:
      * platform/qt/FileSystemQt.cpp:
      * platform/qt/KURLQt.cpp:
      * platform/qt/TemporaryLinkStubs.cpp:
      * platform/sql/chromium/SQLiteFileSystemChromium.cpp:
      * platform/text/CString.cpp: Removed.
      * platform/text/CString.h: Removed.
      * platform/text/PlatformString.h:
      * platform/text/String.cpp:
      * platform/text/StringImpl.cpp:
      * platform/text/TextCodec.h:
      * platform/text/TextCodecICU.cpp:
      * platform/text/TextCodecLatin1.cpp:
      * platform/text/TextCodecUTF16.cpp:
      * platform/text/TextCodecUserDefined.cpp:
      * platform/text/TextEncoding.cpp:
      * platform/text/TextEncoding.h:
      * platform/text/chromium/TextBreakIteratorInternalICUChromium.cpp:
      * platform/text/gtk/TextCodecGtk.cpp:
      * platform/text/haiku/StringHaiku.cpp:
      * platform/text/mac/TextCodecMac.cpp:
      * platform/text/qt/TextCodecQt.cpp:
      * platform/text/wx/StringWx.cpp:
      * platform/win/ClipboardUtilitiesWin.cpp:
      * platform/win/ClipboardWin.cpp:
      * platform/win/ContextMenuItemWin.cpp:
      * platform/win/ContextMenuWin.cpp:
      * platform/win/FileSystemWin.cpp:
      * platform/win/GDIObjectCounter.cpp:
      * platform/win/Language.cpp:
      * platform/win/PasteboardWin.cpp:
      * platform/wince/FileSystemWince.cpp:
      * platform/wince/KeygenWince.cpp:
      * platform/wince/PasteboardWince.cpp:
      * platform/wx/FileSystemWx.cpp:
      * platform/wx/LoggingWx.cpp:
      * plugins/PluginDebug.h:
      * plugins/PluginPackage.cpp:
      * plugins/PluginStream.cpp:
      * plugins/PluginStream.h:
      * plugins/PluginView.h:
      * plugins/gtk/PluginPackageGtk.cpp:
      * plugins/mac/PluginPackageMac.cpp:
      * plugins/qt/PluginPackageQt.cpp:
      * plugins/symbian/PluginPackageSymbian.cpp:
      * plugins/win/PluginPackageWin.cpp:
      * rendering/RenderLayer.cpp:
      * rendering/RenderLayerCompositor.cpp:
      * rendering/RenderTreeAsText.cpp:
      * storage/Database.cpp:
      * storage/SQLTransactionCoordinator.cpp:
      * storage/SQLTransactionCoordinator.h:
      * storage/StorageAreaSync.cpp:
      * storage/StorageSyncManager.cpp:
      * storage/chromium/DatabaseTrackerChromium.cpp:
      * storage/chromium/QuotaTracker.cpp:
      * storage/chromium/QuotaTracker.h:
      * svg/SVGFontFaceElement.cpp:
      * svg/SVGStyledElement.cpp:
      * svg/SVGUseElement.cpp:
      * websockets/WebSocket.cpp:
      * websockets/WebSocketChannel.cpp:
      * websockets/WebSocketHandshake.cpp:
      * wml/WMLErrorHandling.cpp:
      * wml/WMLGoElement.cpp:
      * wml/WMLPageState.cpp:
      * wml/WMLPostfieldElement.cpp:
      * wml/WMLSelectElement.cpp:
      * xml/XMLHttpRequest.cpp:
      * xml/XSLStyleSheetLibxslt.cpp:
      * xml/XSLTProcessorLibxslt.cpp:
      
      WebKit: 
      
      * efl/WebCoreSupport/ChromeClientEfl.cpp:
      * efl/ewk/ewk_frame.cpp:
      (ewk_frame_name_get):
      (ewk_frame_selection_get):
      (ewk_frame_uri_changed):
      * efl/ewk/ewk_history.cpp:
      * efl/ewk/ewk_settings.cpp:
      
      WebKit/chromium: 
      
      * public/WebCString.h:
      * src/FrameLoaderClientImpl.cpp:
      * src/GraphicsContext3D.cpp:
      * src/WebCString.cpp:
      (WebKit::WebCString::assign):
      (WebKit::WebCString::WebCString):
      (WebKit::WebCString::operator=):
      (WebKit::WebCString::operator WTF::CString):
      * src/WebMediaPlayerClientImpl.cpp:
      * src/WebString.cpp:
      * src/WebURLError.cpp:
      
      WebKit/gtk: 
      
      * WebCoreSupport/ChromeClientGtk.cpp:
      * WebCoreSupport/ContextMenuClientGtk.cpp:
      * WebCoreSupport/EditorClientGtk.cpp:
      * WebCoreSupport/FrameLoaderClientGtk.cpp:
      * WebCoreSupport/InspectorClientGtk.cpp:
      * gdom/ConvertToGCharPrivate.h:
      * webkit/webkitdownload.cpp:
      * webkit/webkithittestresult.cpp:
      * webkit/webkitnetworkrequest.cpp:
      * webkit/webkitprivate.h:
      * webkit/webkitsecurityorigin.cpp:
      * webkit/webkitwebdatabase.cpp:
      * webkit/webkitwebframe.cpp:
      * webkit/webkitwebhistoryitem.cpp:
      (webkit_web_history_item_finalize):
      (webkit_web_history_item_get_target):
      * webkit/webkitwebresource.cpp:
      * webkit/webkitwebsettings.cpp:
      * webkit/webkitwebview.cpp:
      
      WebKit/mac: 
      
      * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
      (WebKit::NetscapePluginInstanceProxy::getCookies):
      (WebKit::NetscapePluginInstanceProxy::getProxy):
      (WebKit::NetscapePluginInstanceProxy::getAuthenticationInfo):
      (WebKit::NetscapePluginInstanceProxy::resolveURL):
      * Plugins/WebBaseNetscapePluginView.h:
      * Plugins/WebBaseNetscapePluginView.mm:
      * Plugins/WebNetscapePluginView.mm:
      (-[WebNetscapePluginView resolveURL:forTarget:]):
      
      WebKit/qt: 
      
      * Api/qwebelement.cpp:
      
      WebKit/win: 
      
      * WebDownload.cpp:
      * WebDownloadCFNet.cpp:
      * WebDownloadCurl.cpp:
      * WebHistoryItem.cpp:
      * WebLocalizableStrings.cpp:
      * WebMutableURLRequest.cpp:
      * WebPreferences.cpp:
      (WebPreferences::migrateWebKitPreferencesToCFPreferences):
      * WebView.cpp:
      
      WebKit/wx: 
      
      * WebFrame.cpp:
      * WebView.cpp:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@56825 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      00b7992e
  28. 29 Jan, 2010 1 commit
  29. 25 Jan, 2010 1 commit
    • dbates@webkit.org's avatar
      2010-01-25 Daniel Bates <dbates@webkit.org> · ef42d386
      dbates@webkit.org authored
              Reviewed by Adam Barth.
      
              https://bugs.webkit.org/show_bug.cgi?id=34073
      
              Fixes misspelled words in comments.
      
              * accessibility/AccessibilityListBox.cpp:
              (WebCore::AccessibilityListBox::addChildren):
              (WebCore::AccessibilityListBox::doAccessibilityHitTest):
              * accessibility/mac/AccessibilityObjectWrapper.mm:
              (-[AccessibilityObjectWrapper detach]):
              (AXAttributeStringSetElement):
              * bindings/js/JSDOMBinding.cpp:
              (WebCore::completeURL):
              * bindings/js/JSDOMWindowBase.cpp:
              * bindings/js/JSDOMWindowBase.h:
              * bindings/js/JSDOMWindowCustom.cpp:
              (WebCore::JSDOMWindow::getOwnPropertySlot):
              * bindings/js/JSSVGPODTypeWrapper.h:
              * bindings/js/ScriptController.cpp:
              (WebCore::ScriptController::evaluateInWorld):
              * bridge/NP_jsobject.cpp:
              (_NPN_SetException):
              * bridge/jni/jsc/JavaInstanceJSC.cpp:
              (JavaInstance::invokeMethod):
              (JObjectWrapper::JObjectWrapper):
              * bridge/objc/objc_instance.mm:
              (ObjcInstance::setValueOfUndefinedField):
              (ObjcInstance::getValueOfUndefinedField):
              * css/CSSFontSelector.cpp:
              (WebCore::CSSFontSelector::addFontFaceRule):
              * css/CSSStyleSelector.cpp:
              (WebCore::CSSStyleSelector::CSSStyleSelector):
              (WebCore::CSSStyleSelector::sortMatchedRules):
              (WebCore::CSSStyleSelector::applyDeclarations):
              (WebCore::CSSStyleSelector::applyProperty):
              * dom/Document.cpp:
              (WebCore::Document::updateLayoutIgnorePendingStylesheets):
              (WebCore::Document::detach):
              * dom/Document.h:
              * dom/Element.cpp:
              (WebCore::Element::updateFocusAppearance):
              * dom/Element.h:
              * dom/MessagePortChannel.h:
              * dom/MouseRelatedEvent.cpp:
              (WebCore::MouseRelatedEvent::receivedTarget):
              * dom/Node.cpp:
              (WebCore::Node::isFocusable):
              (WebCore::Node::shadowAncestorNode):
              * dom/Node.h:
              * dom/Position.cpp:
              (WebCore::Position::upstream):
              * dom/Position.h:
              * dom/Range.cpp:
              (WebCore::Range::processContents):
              * dom/StyledElement.cpp:
              (WebCore::StyledElement::addCSSColor):
              * editing/ApplyStyleCommand.cpp:
              (WebCore::StyleChange::reconcileTextDecorationProperties):
              (WebCore::StyleChange::extractTextStyles):
              (WebCore::prepareEditingStyleToApplyAt):
              * editing/DeleteButtonController.cpp:
              (WebCore::isDeletableElement):
              * editing/DeleteSelectionCommand.cpp:
              (WebCore::DeleteSelectionCommand::initializeStartEnd):
              * editing/Editor.cpp:
              (WebCore::Editor::learnSpelling):
              * inspector/front-end/ConsoleView.js:
              (WebInspector.ConsoleMessage.prototype._format):
              * loader/Cache.cpp:
              (WebCore::Cache::pruneLiveResources):
              (WebCore::Cache::pruneDeadResources):
              * loader/Cache.h:
              * loader/CachedResource.cpp:
              (WebCore::CachedResource::makePurgeable):
              * loader/CachedResource.h:
              * loader/CachedResourceHandle.h:
              * loader/DocumentLoader.h:
              * loader/FTPDirectoryParser.cpp:
              (WebCore::parseOneFTPLine):
              * loader/FrameLoader.cpp:
              (WebCore::FrameLoader::didExplicitOpen):
              * loader/ResourceLoader.cpp:
              (WebCore::ResourceLoader::didCancel):
              * loader/WorkerThreadableLoader.h:
              * loader/appcache/ApplicationCacheStorage.cpp:
              (WebCore::ApplicationCacheStorage::spaceNeeded):
              * notifications/NotificationPresenter.h:
              (WebCore::NotificationPresenter::):
              * page/animation/AnimationController.cpp:
              (WebCore::AnimationController::updateAnimations):
              * platform/LinkHash.cpp:
              (WebCore::cleanPath):
              * platform/graphics/cg/GraphicsContextCG.cpp:
              (WebCore::calculateDrawingMode):
              * platform/graphics/cg/PatternCG.cpp:
              (WebCore::Pattern::createPlatformPattern):
              * platform/graphics/mac/ComplexTextController.cpp:
              (WebCore::ComplexTextController::offsetForPosition):
              * platform/graphics/mac/GraphicsLayerCA.h:
              * platform/graphics/mac/GraphicsLayerCA.mm:
              (WebCore::GraphicsLayerCA::ensureStructuralLayer):
              * platform/graphics/mac/MediaPlayerPrivateQTKit.mm:
              (WebCore::MediaPlayerPrivate::doSeek):
              (WebCore::MediaPlayerPrivate::setClosedCaptionsVisible):
              (WebCore::MediaPlayerPrivate::hasAvailableVideoFrame):
              * platform/mac/PasteboardMac.mm:
              (WebCore::Pasteboard::writeSelection):
              (WebCore::Pasteboard::writePlainText):
              (WebCore::Pasteboard::writeURL):
              * platform/text/TextCodecICU.cpp:
              (WebCore::TextCodecICU::registerExtendedEncodingNames):
              * platform/text/TextEncodingDetectorICU.cpp:
              (WebCore::detectTextEncoding):
              * rendering/AutoTableLayout.cpp:
              (WebCore::AutoTableLayout::calcEffectiveWidth):
              (WebCore::AutoTableLayout::layout):
              * rendering/RenderBox.cpp:
              (WebCore::RenderBox::calcAbsoluteHorizontalValues):
              (WebCore::RenderBox::calcAbsoluteVerticalValues):
              (WebCore::RenderBox::calcAbsoluteHorizontalReplaced):
              (WebCore::RenderBox::calcAbsoluteVerticalReplaced):
              * rendering/RenderLayer.cpp:
              (WebCore::RenderLayer::scrollByRecursively):
              (WebCore::RenderLayer::paintLayer):
              (WebCore::RenderLayer::hitTestLayer):
              * rendering/RenderObject.cpp:
              (WebCore::RenderObject::destroy):
              * rendering/RenderTextControl.cpp:
              (WebCore::RenderTextControl::setInnerTextValue):
              * rendering/RenderTheme.cpp:
              (WebCore::RenderTheme::stateChanged):
              * rendering/SVGRenderSupport.cpp:
              (WebCore::SVGRenderBase::mapLocalToContainer):
              * rendering/SVGRootInlineBox.cpp:
              (WebCore::SVGRootInlineBox::buildTextChunks):
              * rendering/TransformState.cpp:
              (WebCore::TransformState::flattenWithTransform):
              * wml/WMLInputElement.cpp:
              (WebCore::WMLInputElement::dispatchBlurEvent):
              (WebCore::WMLInputElement::suggestedValue):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@53809 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      ef42d386
  30. 19 Dec, 2009 1 commit
  31. 23 Nov, 2009 1 commit
    • simon.fraser@apple.com's avatar
      2009-11-23 Simon Fraser <simon.fraser@apple.com> · 0365603a
      simon.fraser@apple.com authored
              Reviewed by Dan Bernstein.
      
              DocumentMarkers need to be educated about transforms
              https://bugs.webkit.org/show_bug.cgi?id=31751
      
              Find highlight is incorrect with transforms
              <rdar://problem/6358394>
      
              Allow callers to specify that Frame::selectionTextRects() takes transforms into account
              when computing the set of rects that encompass a selection. For transformed elemenets, the
              selection rect will be the bounding box of the selected content.
      
              Fix DocumentMarkers to cache rects in absolute coordinates, rather than painting coordinates.
      
              Test: editing/selection/transformed-selection-rects.html
      
              * WebCore.base.exp:
              Frame::selectionTextRects() has a new parameter.
      
              * dom/Document.cpp:
              (WebCore::Document::setRenderedRectForMarker):
              * dom/Document.h:
              Pass the marker as a const reference.
      
              * dom/Range.h:
              * dom/Range.cpp:
              (WebCore::Range::textQuads):
              Add a new method, textQuads(), which returns a list of quads, respecting transforms.
      
              * page/Frame.h:
              * page/Frame.cpp:
              (WebCore::Frame::selectionTextRects):
              Add a new parameter, respectTransforms, and when that is RespectTransforms, use the quad
              method to get quads for ranges, and then take their bounding boxes.
      
              * rendering/InlineTextBox.h:
              * rendering/InlineTextBox.cpp:
              (WebCore::InlineTextBox::paintSpellingOrGrammarMarker):
              (WebCore::InlineTextBox::paintTextMatchMarker):
              (WebCore::InlineTextBox::computeRectForReplacementMarker):
              (WebCore::InlineTextBox::paintDocumentMarkers):
              (WebCore::InlineTextBox::textPos):
              (WebCore::InlineTextBox::offsetForPosition):
      
              Pass DocumentMarkers as a const references.
              Convert the argument to setRenderedRectForMarker() into absolute coordinates.
      
              * rendering/RenderView.cpp:
              (WebCore::RenderView::selectionBounds):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@51324 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      0365603a
  32. 27 Sep, 2009 1 commit
    • weinig@apple.com's avatar
      WebCore: Fix for https://bugs.webkit.org/show_bug.cgi?id=29760 · a09f5201
      weinig@apple.com authored
      Implement CSSOM Range.getClientRects/getBoundingClientRect 
      
      Reviewed by Dan Bernstein.
      
      Tests: fast/dom/Range/getBoundingClientRect-getClientRects-relative-to-viewport.html
             fast/dom/Range/getBoundingClientRect.html
             fast/dom/Range/getClientRects.html
      
      * dom/Range.cpp:
      (WebCore::Range::getClientRects):
      (WebCore::Range::getBoundingClientRect):
      (WebCore::adjustFloatQuadsForScrollAndAbsoluteZoom):
      (WebCore::Range::getBorderAndTextQuads):
      * dom/Range.h:
      * dom/Range.idl:
      Implement Range.getClientRects/getBoundingClientRect.
      
      * dom/Element.cpp:
      * rendering/RenderObject.h: 
      (WebCore::adjustForAbsoluteZoom):
      (WebCore::adjustIntRectForAbsoluteZoom):
      (WebCore::adjustFloatPointForAbsoluteZoom):
      (WebCore::adjustFloatQuadForAbsoluteZoom):
      Move point/quad adjustment methods from Element.cpp to RenderObject.h
      so that Range.cpp can use them as well.
      
      LayoutTests: Tests for https://bugs.webkit.org/show_bug.cgi?id=29760
      Implement CSSOM Range.getClientRects/getBoundingClientRect 
      
      Reviewed by Dan Bernstein.
      
      * fast/dom/Element/getBoundingClientRect-expected.txt: Copied from LayoutTests/fast/dom/getBoundingClientRect-expected.txt.
      * fast/dom/Element/getBoundingClientRect-getClientRects-relative-to-viewport-expected.txt: Copied from LayoutTests/fast/dom/getBoundingClientRect-getClientRects-relative-to-viewport-expected.txt.
      * fast/dom/Element/getBoundingClientRect-getClientRects-relative-to-viewport.html: Copied from LayoutTests/fast/dom/getBoundingClientRect-getClientRects-relative-to-viewport.html.
      * fast/dom/Element/getBoundingClientRect.html: Copied from LayoutTests/fast/dom/getBoundingClientRect.html.
      * fast/dom/Element/getClientRects-expected.txt: Copied from LayoutTests/fast/dom/getClientRects-expected.txt.
      * fast/dom/Element/getClientRects.html: Copied from LayoutTests/fast/dom/getClientRects.html.
      * fast/dom/Range/getBoundingClientRect-expected.txt: Added.
      * fast/dom/Range/getBoundingClientRect-getClientRects-relative-to-viewport-expected.txt: Added.
      * fast/dom/Range/getBoundingClientRect-getClientRects-relative-to-viewport.html: Added.
      * fast/dom/Range/getBoundingClientRect.html: Added.
      * fast/dom/Range/getClientRects-expected.txt: Added.
      * fast/dom/Range/getClientRects.html: Added.
      * fast/dom/Window/window-properties-expected.txt:
      * fast/dom/getBoundingClientRect-expected.txt: Removed.
      * fast/dom/getBoundingClientRect-getClientRects-relative-to-viewport-expected.txt: Removed.
      * fast/dom/getBoundingClientRect-getClientRects-relative-to-viewport.html: Removed.
      * fast/dom/getBoundingClientRect.html: Removed.
      * fast/dom/getClientRects-expected.txt: Removed.
      * fast/dom/getClientRects.html: Removed.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@48806 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      a09f5201
  33. 10 Sep, 2009 1 commit
  34. 15 Aug, 2009 1 commit
    • darin@apple.com's avatar
      Make DOM classes start with a reference count of 1, like all other RefCounted · 7e131b6d
      darin@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=28068
      
      Patch by Darin Adler <darin@apple.com> on 2009-08-14
      Reviewed by Sam Weinig.
      
      First half, everything except for element classes.
      
      * GNUmakefile.am: Removed DocPtr.h.
      * WebCore.gypi: Ditto.
      * WebCore.vcproj/WebCore.vcproj: Ditto.
      * WebCore.xcodeproj/project.pbxproj: Ditto.
      
      * dom/Attr.cpp:
      (WebCore::Attr::Attr): Added a call to createTextChild here so callers don't
      have to call it explicitly.
      (WebCore::Attr::create): Added.
      (WebCore::Attr::setValue): Changed to take AtomicString.
      (WebCore::Attr::cloneNode): Use create.
      
      * dom/Attr.h: Added a create function. Made the constructor private,
      and a lot of other functions private as well.
      
      * dom/Attribute.cpp:
      (WebCore::Attribute::createAttrIfNeeded): Use Attr::create.
      
      * dom/CDATASection.cpp:
      (WebCore::CDATASection::create): Added.
      (WebCore::CDATASection::cloneNode): Use create.
      (WebCore::CDATASection::virtualCreate): Ditto.
      
      * dom/CDATASection.h: Added a create function. Made everything private.
      Removed unneeded destructor declaration.
      
      * dom/CharacterData.cpp:
      (WebCore::CharacterData::CharacterData): Replaced the multiple constructors
      with a single one that takes ConstructionType.
      
      * dom/CharacterData.h: Made more functions be protected and private.
      Made m_data be private.
      
      * dom/Comment.cpp:
      (WebCore::Comment::Comment): Got rid of an extra constructor.
      (WebCore::Comment::create): Added.
      (WebCore::Comment::cloneNode): Call create.
      
      * dom/Comment.h: Added a create function. Made everything private.
      
      * dom/ContainerNode.cpp:
      (WebCore::dispatchChildInsertionEvents): Use RefPtr instead of DocPtr.
      (WebCore::dispatchChildRemovalEvents): Ditto.
      
      * dom/ContainerNode.h: Made the constructor protected and passed
      ConstructionType instead of an isElement boolean.
      
      * dom/DocPtr.h: Removed.
      
      * dom/Document.cpp:
      (WebCore::Document::Document): Simplified the code that sets m_document
      since it's no longer a smart pointer.
      (WebCore::Document::removedLastRef): Use explicit calls to selfOnlyRef
      and selfOnlyDeref instead of a DocPtr in here.
      (WebCore::Document::~Document): Simplified the code that sets m_document
      since it's no longer a smart pointer.
      (WebCore::Document::createDocumentFragment): Call create.
      (WebCore::Document::createTextNode): Ditto.
      (WebCore::Document::createComment): Ditto.
      (WebCore::Document::createCDATASection): Ditto.
      (WebCore::Document::createProcessingInstruction): Ditto.
      (WebCore::Document::createEntityReference): Ditto.
      (WebCore::Document::createEditingTextNode): Ditto.
      (WebCore::Document::importNode): Call Attr::create.
      (WebCore::Document::createAttributeNS): Ditto.
      
      * dom/Document.h: Call adoptRef. Made a lot of functions private and
      protected and sorted them so public functions come first.
      
      * dom/DocumentFragment.cpp:
      (WebCore::DocumentFragment::create): Added.
      (WebCore::DocumentFragment::cloneNode): Call create.
      * dom/DocumentFragment.h: Added create.
      
      * dom/DocumentType.cpp:
      (WebCore::DocumentType::DocumentType): Pass type to Node constructor.
      (WebCore::DocumentType::cloneNode): Use create.
      * dom/DocumentType.h:
      (WebCore::DocumentType::create): Call adoptRef.
      
      * dom/EditingText.cpp:
      (WebCore::EditingText::create): Added.
      * dom/EditingText.h: Added a create function. Made everything private.
      
      * dom/Element.cpp:
      (WebCore::Element::Element): Pass CreateElementZeroRefCount to preserve
      the zero reference count behavior for classes derived from Element.
      
      * dom/EntityReference.cpp:
      (WebCore::EntityReference::create): Added.
      (WebCore::EntityReference::cloneNode): Call create.
      * dom/EntityReference.h: Added create. Made everything private.
      
      * dom/Node.cpp:
      (WebCore::Node::initialRefCount): Added. Inline helper function for
      the constructor.
      (WebCore::Node::isContainer): Ditto.
      (WebCore::Node::isElement): Ditto.
      (WebCore::Node::isText): Ditto.
      (WebCore::Node::Node): Changed to take a construction type argument.
      Since m_document is now a normal pointer, added a call to selfOnlyRef.
      (WebCore::Node::~Node): Ditto, but selfOnlyDeref.
      (WebCore::Node::setDocument): Added selfOnlyRef/Deref calls.
      (WebCore::Node::appendTextContent): Use the data function instead of
      calling nodeValue functions, which do the same thing in a roundabout way.
      
      * dom/Node.h: Made the constructor protected and replaced the multiple
      arguments iwth a single ConstructionType argument. Sorted the public
      things first.
      
      * dom/Notation.h: Made most things private.
      * dom/Notation.cpp: Removed extra constructor.
      
      * dom/ProcessingInstruction.cpp:
      (WebCore::ProcessingInstruction::create): Added.
      (WebCore::ProcessingInstruction::cloneNode): Call create.
      * dom/ProcessingInstruction.h: Added create function. Made many other
      members private.
      
      * dom/Range.cpp:
      (WebCore::Range::processContents): Use DocumentFragment::create.
      
      * dom/Text.cpp:
      (WebCore::Text::Text): Updated for base class change.
      (WebCore::Text::create): Added.
      (WebCore::Text::splitText): Changed to not require access to m_data.
      (WebCore::Text::cloneNode): Call create.
      (WebCore::Text::createRenderer): Call dataImpl.
      (WebCore::Text::attach): Call data.
      (WebCore::Text::recalcStyle): Call dataImpl.
      (WebCore::Text::virtualCreate): Call create.
      (WebCore::Text::createWithLengthLimit): Call create.
      (WebCore::Text::formatForDebugger): Call data.
      
      * dom/Text.h: Added a create function. Made many other members private.
      Renamed createNew to virtualCreate.
      
      * dom/XMLTokenizer.cpp:
      (WebCore::XMLTokenizer::enterText): Call Text::create.
      
      * dom/XMLTokenizerLibxml2.cpp:
      (WebCore::XMLTokenizer::cdataBlock): Call CDATASection::create.
      (WebCore::XMLTokenizer::comment): Call Comment::create.
      
      * editing/CompositeEditCommand.cpp:
      (WebCore::CompositeEditCommand::deleteInsignificantText):
      Call data instead of string.
      
      * editing/CreateLinkCommand.cpp:
      (WebCore::CreateLinkCommand::doApply): Call Text::create.
      
      * editing/EditorCommand.cpp:
      (WebCore::executeInsertNode): Call DocumentFragment::create.
      
      * editing/SplitTextNodeCommand.cpp:
      (WebCore::SplitTextNodeCommand::doApply): Call Text::create.
      
      * editing/markup.cpp:
      (WebCore::appendStartMarkup): Call data instead of nodeValue.
      
      * html/HTMLDocument.h:
      (WebCore::HTMLDocument::create): Call adoptRef.
      
      * html/HTMLElement.cpp:
      (WebCore::HTMLElement::createContextualFragment): Call DocumentFragment::create.
      (WebCore::replaceChildrenWithFragment): Call data instead of string.
      (WebCore::replaceChildrenWithText): Call Text::create.
      (WebCore::HTMLElement::setInnerText): Call DocumentFragment::create and
      Text::create.
      (WebCore::HTMLElement::setOuterText): Call Text::create.
      
      * html/HTMLKeygenElement.cpp:
      (WebCore::HTMLKeygenElement::HTMLKeygenElement): Call Text::create.
      
      * html/HTMLOptionElement.cpp:
      (WebCore::HTMLOptionElement::setText): Call Text::create.
      
      * html/HTMLParser.cpp:
      (WebCore::HTMLParser::textCreateErrorCheck): Call Text::create.
      (WebCore::HTMLParser::commentCreateErrorCheck): Call Comment::create.
      (WebCore::HTMLParser::handleIsindex): Call Text::create.
      
      * html/HTMLViewSourceDocument.cpp:
      (WebCore::HTMLViewSourceDocument::addText): Call Text::create.
      
      * html/HTMLViewSourceDocument.h:
      (WebCore::HTMLViewSourceDocument::create): Call adoptRef.
      
      * loader/FTPDirectoryDocument.cpp:
      (WebCore::FTPDirectoryTokenizer::appendEntry): Call Text::create.
      (WebCore::FTPDirectoryTokenizer::createTDForFilename): Call Text::create.
      
      * loader/FTPDirectoryDocument.h:
      (WebCore::FTPDirectoryDocument::create): Call adoptRef.
      * loader/ImageDocument.h:
      (WebCore::ImageDocument::create): Ditto.
      * loader/MediaDocument.h:
      (WebCore::MediaDocument::create): Ditto.
      * loader/PlaceholderDocument.h:
      (WebCore::PlaceholderDocument::create): Ditto.
      * loader/PluginDocument.h:
      (WebCore::PluginDocument::create): Ditto.
      * loader/TextDocument.h:
      (WebCore::TextDocument::create): Ditto.
      
      * loader/loader.cpp:
      (WebCore::Loader::Host::didFinishLoading): Use RefPtr instead of DocPtr.
      (WebCore::Loader::Host::didFail): Ditto.
      
      * platform/TreeShared.h:
      (WebCore::TreeShared::TreeShared): Added an initialRefCount argument,
      defaulting to 1. Node still sometimes initializes it to 0 instead for now.
      
      * rendering/RenderText.cpp:
      (WebCore::RenderText::originalText): Use dataImpl instead of string.
      
      * rendering/RenderTextFragment.cpp:
      (WebCore::RenderTextFragment::originalText): Use dataImpl instead of string.
      (WebCore::RenderTextFragment::previousCharacter): Ditto.
      
      * svg/SVGDocument.h:
      (WebCore::SVGDocument::create): Use adoptRef.
      
      * svg/SVGElementInstance.cpp:
      (WebCore::SVGElementInstance::SVGElementInstance): Updated to take a
      PassRefPtr.
      
      * svg/SVGElementInstance.h: Made everything private.
      
      * wml/WMLDocument.h:
      (WebCore::WMLDocument::create): Called adoptRef.
      
      * xml/XPathNamespace.cpp:
      (WebCore::XPathNamespace::XPathNamespace): Take AtomicString arguments.
      * xml/XPathNamespace.h: Made everything private.
      
      * xml/XSLTProcessor.cpp:
      (WebCore::createFragmentFromSource): Use DocumentFragment::create and
      Text::create.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@47313 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      7e131b6d
  35. 17 Jul, 2009 1 commit
    • jparent@chromium.org's avatar
      2009-07-17 Ryosuke Niwa <ryosuke.niwa@gmail.com> · 14959eab
      jparent@chromium.org authored
              Reviewed by Eric Seidel.
      
              htmlediting.cpp needs more utility functions to fix the bug 26816
              https://bugs.webkit.org/show_bug.cgi?id=27038
      
              In order to fix the bug 26816, we need several utility functions be added to htmlediting.cpp
      
              No tests because functions haven't been used anywhere yet.
      
              * dom/Range.cpp:
              (WebCore::Range::create):
              (WebCore::Range::comparePoint): added const qualifier
              (WebCore::Range::compareNode): added const qualifier
              * dom/Range.h:
              * editing/htmlediting.cpp:
              (WebCore::unsplittableElementForPosition): find the enclosing unsplittable element (editing root & table cell)
              (WebCore::positionBeforeNode): added ASSERT(node)
              (WebCore::positionAfterNode): added ASSERT(node)
              (WebCore::visiblePositionBeforeNode):
              (WebCore::visiblePositionAfterNode):
              (WebCore::createRange): create a range object from two visible positions
              (WebCore::extendRangeToWrappingNodes): extend range to include nodes that starts and ends at the boundaries
              (WebCore::canMergeLists): typo
              (WebCore::indexForVisiblePosition): added const qualifier
              (WebCore::isVisiblyAdjacent): typo
              (WebCore::isNodeVisiblyContainedWithin): determine if a node is inside a range or within the visible boundaries of the range
              * editing/htmlediting.h:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@46063 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      14959eab
  36. 10 Jul, 2009 1 commit
    • ddkilzer@apple.com's avatar
      2009-07-10 Shinichiro Hamaji <hamaji@chromium.org> · 9c4dacca
      ddkilzer@apple.com authored
              Reviewed by David Kilzer.
      
              WebKit needs a style linting tool
              https://bugs.webkit.org/show_bug.cgi?id=25884
      
              Fix bunch of style issues by autofix of cpplint.
              This patch is created to demonstrate the autofix of cpplint.py.
      
              No new testcases because it's a style fix
      
              * css/CSSParser.cpp:
              (WebCore::CSSParser::parseMediaQuery):
              (WebCore::CSSParser::validUnit):
              (WebCore::CSSParser::parseValue):
              (WebCore::skipCommaInDashboardRegion):
              (WebCore::CSSParser::parseDashboardRegions):
              (WebCore::ShadowParseContext::commitValue):
              (WebCore::ShadowParseContext::commitLength):
              (WebCore::ShadowParseContext::commitColor):
              (WebCore::BorderImageParseContext::commitNumber):
              (WebCore::BorderImageParseContext::commitWidth):
              (WebCore::BorderImageParseContext::commitRule):
              (WebCore::BorderImageParseContext::commitBorderImage):
              (WebCore::CSSParser::lex):
              (WebCore::CSSParser::text):
              * css/CSSStyleSelector.cpp:
              (WebCore::CSSStyleSelector::applyProperty):
              * css/MediaList.cpp:
              (WebCore::MediaList::deleteMedium):
              * css/MediaQuery.h:
              * css/MediaQueryEvaluator.cpp:
              (WebCore::parseAspectRatio):
              * css/MediaQueryEvaluator.h:
              * css/MediaQueryExp.h:
              (WebCore::MediaQueryExp::operator==):
              * css/WebKitCSSMatrix.h:
              * dom/Comment.h:
              * dom/Document.cpp:
              (WebCore::Document::setFocusedNode):
              * dom/Document.h:
              (WebCore::Document::setHasDashboardRegions):
              * dom/DocumentFragment.cpp:
              (WebCore::DocumentFragment::nodeName):
              * dom/DocumentFragment.h:
              * dom/DynamicNodeList.h:
              * dom/EditingText.h:
              * dom/Element.cpp:
              (WebCore::Element::dispatchAttrAdditionEvent):
              * dom/NamedAttrMap.cpp:
              (WebCore::NamedNodeMap::item):
              * dom/Node.cpp:
              (WebCore::Node::nodeValue):
              (WebCore::Node::nodeIndex):
              * dom/NodeRareData.h:
              (WebCore::NodeListsNodeData::create):
              * dom/Notation.h:
              * dom/ProcessingInstruction.h:
              * dom/Range.cpp:
              (WebCore::Range::processContents):
              * dom/StyledElement.cpp:
              (WebCore::toHex):
              * dom/XMLTokenizerLibxml2.cpp:
              (WebCore::PendingCallbacks::PendingStartElementNSCallback::~PendingStartElementNSCallback):
              (WebCore::PendingCallbacks::PendingStartElementNSCallback::call):
              (WebCore::PendingCallbacks::):
              (WebCore::OffsetBuffer::readOutBytes):
              (WebCore::handleElementNamespaces):
              (WebCore::handleElementAttributes):
              (WebCore::attributesStartElementNsHandler):
              * dom/XMLTokenizerQt.cpp:
              (WebCore::attributesStartElementNsHandler):
              (WebCore::XMLTokenizer::parseStartElement):
              * editing/ApplyStyleCommand.cpp:
              (WebCore::ApplyStyleCommand::applyInlineStyle):
              * editing/DeleteSelectionCommand.cpp:
              (WebCore::DeleteSelectionCommand::removeNode):
              * editing/Editor.cpp:
              (WebCore::Editor::pasteAsPlainText):
              * editing/SelectionController.cpp:
              (WebCore::SelectionController::directionOfEnclosingBlock):
              * editing/SmartReplaceICU.cpp:
              (WebCore::addAllCodePoints):
              * history/HistoryItem.cpp:
              (WebCore::HistoryItem::icon):
              (WebCore::HistoryItem::adoptVisitCounts):
              * html/CanvasStyle.cpp:
              (WebCore::CanvasStyle::applyFillColor):
              * html/HTMLAnchorElement.cpp:
              (WebCore::HTMLAnchorElement::setActive):
              (WebCore::HTMLAnchorElement::isLiveLink):
              * html/HTMLAppletElement.h:
              * html/HTMLAudioElement.h:
              * html/HTMLBRElement.h:
              * html/HTMLBaseElement.h:
              * html/HTMLBaseFontElement.h:
              * html/HTMLDListElement.h:
              * html/HTMLDirectoryElement.h:
              * html/HTMLFieldSetElement.cpp:
              (WebCore::HTMLFieldSetElement::HTMLFieldSetElement):
              * html/HTMLFormElement.cpp:
              (WebCore::HTMLFormElement::reset):
              * html/HTMLHRElement.cpp:
              (WebCore::HTMLHRElement::parseMappedAttribute):
              * html/HTMLHeadElement.h:
              * html/HTMLHtmlElement.h:
              * html/HTMLImageElement.h:
              (WebCore::HTMLImageElement::setLoadManually):
              * html/HTMLInputElement.cpp:
              (WebCore::HTMLInputElement::selection):
              * html/HTMLIsIndexElement.h:
              * html/HTMLMarqueeElement.cpp:
              * html/HTMLMediaElement.h:
              (WebCore::HTMLMediaElement::):
              * html/HTMLMenuElement.h:
              * html/HTMLMetaElement.h:
              * html/HTMLModElement.h:
              * html/HTMLOListElement.h:
              * html/HTMLOptionElement.cpp:
              (WebCore::HTMLOptionElement::childrenChanged):
              * html/HTMLParamElement.h:
              * html/HTMLQuoteElement.h:
              * html/HTMLStyleElement.h:
              * html/HTMLTableCaptionElement.h:
              * html/HTMLTableCellElement.h:
              * html/HTMLTableColElement.h:
              * html/HTMLTableSectionElement.cpp:
              (WebCore::HTMLTableSectionElement::deleteRow):
              * html/HTMLTitleElement.h:
              * html/HTMLTokenizer.cpp:
              (WebCore::HTMLTokenizer::parseNonHTMLText):
              (WebCore::HTMLTokenizer::parseEntity):
              (WebCore::HTMLTokenizer::parseTag):
              (WebCore::HTMLTokenizer::write):
              * html/HTMLUListElement.h:
              * html/HTMLVideoElement.h:
              * html/TimeRanges.h:
              (WebCore::TimeRanges::Range::Range):
              * inspector/InspectorController.cpp:
              (WebCore::InspectorController::enableResourceTracking):
              (WebCore::InspectorController::disableResourceTracking):
              * inspector/InspectorFrontend.cpp:
              (WebCore::InspectorFrontend::newInspectorJSONObject):
              * page/Console.cpp:
              (WebCore::Console::addMessage):
              * page/EventHandler.cpp:
              (WebCore::EventHandler::handleMousePressEvent):
              (WebCore::EventHandler::selectCursor):
              (WebCore::EventHandler::defaultKeyboardEventHandler):
              * page/Frame.cpp:
              (WebCore::Frame::jsDefaultStatusBarText):
              * page/android/DragControllerAndroid.cpp:
              (WebCore::DragController::dragOperation):
              * page/android/EventHandlerAndroid.cpp:
              (WebCore::EventHandler::tabsToAllControls):
              (WebCore::EventHandler::eventActivatedView):
              * page/animation/AnimationController.cpp:
              (WebCore::AnimationControllerPrivate::updateStyleIfNeededDispatcherFired):
              * page/gtk/DragControllerGtk.cpp:
              (WebCore::DragController::dragOperation):
              * page/qt/DragControllerQt.cpp:
              * page/win/DragControllerWin.cpp:
              (WebCore::DragController::isCopyKeyDown):
              * page/win/FrameWin.h:
              * rendering/RenderSlider.cpp:
              (WebCore::RenderSlider::mouseEventOffsetToThumb):
              * rendering/style/RenderStyle.h:
              (WebCore::InheritedFlags::setVerticalAlignLength):
              (WebCore::InheritedFlags::setUnicodeBidi):
              (WebCore::InheritedFlags::setCursor):
              * rendering/style/RenderStyleConstants.h:
              (WebCore::):
              * rendering/style/SVGRenderStyleDefs.h:
              * rendering/style/StyleInheritedData.h:
              (WebCore::StyleInheritedData::operator!=):
              * storage/DatabaseTask.h:
              * svg/GradientAttributes.h:
              * svg/LinearGradientAttributes.h:
              * svg/PatternAttributes.h:
              * svg/RadialGradientAttributes.h:
              * svg/SVGAnimatedPathData.h:
              * svg/SVGAnimatedPoints.h:
              * svg/SVGAnimationElement.h:
              * svg/SVGClipPathElement.h:
              * svg/SVGElementInstance.h:
              * svg/SVGFEBlendElement.cpp:
              (WebCore::SVGFEBlendElement::build):
              * svg/SVGFEBlendElement.h:
              * svg/SVGFEColorMatrixElement.cpp:
              (WebCore::SVGFEColorMatrixElement::build):
              * svg/SVGFEComponentTransferElement.cpp:
              (WebCore::SVGFEComponentTransferElement::build):
              * svg/SVGFECompositeElement.cpp:
              (WebCore::SVGFECompositeElement::build):
              * svg/SVGFEDiffuseLightingElement.cpp:
              (WebCore::SVGFEDiffuseLightingElement::build):
              * svg/SVGFEDisplacementMapElement.cpp:
              (WebCore::SVGFEDisplacementMapElement::build):
              * svg/SVGFEDistantLightElement.h:
              * svg/SVGFEFloodElement.cpp:
              (WebCore::SVGFEFloodElement::build):
              * svg/SVGFEFloodElement.h:
              * svg/SVGFEFuncAElement.h:
              * svg/SVGFEFuncBElement.h:
              * svg/SVGFEFuncGElement.h:
              * svg/SVGFEFuncRElement.h:
              * svg/SVGFEGaussianBlurElement.cpp:
              (WebCore::SVGFEGaussianBlurElement::build):
              * svg/SVGFEImageElement.cpp:
              (WebCore::SVGFEImageElement::build):
              * svg/SVGFEMergeElement.cpp:
              (WebCore::SVGFEMergeElement::build):
              * svg/SVGFEOffsetElement.cpp:
              (WebCore::SVGFEOffsetElement::build):
              * svg/SVGFEPointLightElement.h:
              * svg/SVGFESpecularLightingElement.cpp:
              (WebCore::SVGFESpecularLightingElement::build):
              * svg/SVGFESpotLightElement.h:
              * svg/SVGFETileElement.cpp:
              (WebCore::SVGFETileElement::build):
              * svg/SVGLineElement.cpp:
              (WebCore::SVGLineElement::parseMappedAttribute):
              * svg/SVGList.h:
              * svg/SVGListTraits.h:
              (WebCore::):
              * svg/SVGMPathElement.h:
              * svg/SVGMetadataElement.h:
              * svg/SVGParserUtilities.cpp:
              (WebCore::SVGPathParser::parseSVG):
              (WebCore::SVGPathParser::calculateArc):
              * svg/SVGPathElement.h:
              * svg/SVGPathSegClosePath.h:
              * svg/SVGSVGElement.h:
              * svg/SVGSetElement.h:
              * svg/SVGSwitchElement.h:
              * svg/SVGTextPathElement.cpp:
              (WebCore::SVGTextPathElement::parseMappedAttribute):
              * svg/SVGTextPathElement.h:
              * svg/SVGTitleElement.h:
              * svg/SVGTransformable.cpp:
              (WebCore::):
              * svg/SVGViewSpec.cpp:
              (WebCore::):
              * svg/animation/SMILTime.cpp:
              (WebCore::operator+):
              (WebCore::operator-):
              (WebCore::operator*):
              * svg/animation/SVGSMILElement.h:
              * svg/graphics/SVGResource.cpp:
              (WebCore::clientMap):
              * wml/WMLPostfieldElement.cpp:
              (WebCore::WMLPostfieldElement::value):
              * wml/WMLSetvarElement.cpp:
              (WebCore::WMLSetvarElement::value):
              * workers/WorkerRunLoop.cpp:
              * xml/XMLHttpRequest.cpp:
              (WebCore::XMLHttpRequest::dropProtection):
              * xml/XPathPath.h:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@45747 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      9c4dacca