1. 12 May, 2011 1 commit
    • tonyg@chromium.org's avatar
      2011-05-10 Tony Gentilcore <tonyg@chromium.org> · 4b0a55f4
      tonyg@chromium.org authored
              Reviewed by Darin Adler.
      
              Perform some forward declarations suggested by include-what-you-use
              https://bugs.webkit.org/show_bug.cgi?id=60545
      
              * accessibility/AccessibilityObject.cpp:
              * accessibility/AccessibilityRenderObject.cpp:
              * accessibility/mac/AccessibilityObjectWrapper.mm:
              * dom/DocumentMarkerController.cpp:
              * dom/Position.cpp:
              * dom/PositionIterator.cpp:
              * dom/Range.cpp:
              * editing/ApplyBlockElementCommand.cpp:
              * editing/ApplyStyleCommand.cpp:
              * editing/Editor.cpp:
              * editing/EditorCommand.cpp:
              * editing/FrameSelection.cpp:
              * editing/HTMLInterchange.cpp:
              * editing/IndentOutdentCommand.cpp:
              * editing/ReplaceSelectionCommand.cpp:
              * editing/SpellChecker.h:
              * editing/SpellingCorrectionCommand.cpp:
              * editing/SpellingCorrectionController.h:
              * editing/TextCheckingHelper.cpp:
              * editing/TextIterator.h:
              * editing/htmlediting.h:
              * editing/markup.cpp:
              * editing/visible_units.cpp:
              * editing/visible_units.h:
              * fileapi/DOMFileSystem.cpp:
              * fileapi/DirectoryReaderSync.cpp:
              * fileapi/DirectoryReaderSync.h:
              * fileapi/FileEntry.h:
              * fileapi/FileWriter.h:
              * fileapi/FileWriterBase.h:
              * fileapi/FileWriterSync.h:
              * history/CachedFrame.cpp:
              * history/CachedPage.cpp:
              * history/HistoryItem.cpp:
              * history/HistoryItem.h:
              * history/PageCache.h:
              * loader/HistoryController.h:
              * loader/PingLoader.h:
              * loader/ResourceLoader.h:
              * loader/appcache/DOMApplicationCache.h:
              * loader/cache/CachedCSSStyleSheet.h:
              * loader/cache/CachedFont.cpp:
              * loader/cache/CachedFont.h:
              * loader/cache/CachedResourceRequest.cpp:
              * loader/cache/CachedResourceRequest.h:
              * loader/cache/MemoryCache.h:
              * notifications/Notification.cpp:
              * notifications/Notification.h:
              * notifications/NotificationCenter.cpp:
              * notifications/NotificationCenter.h:
              * page/Chrome.cpp:
              * page/Chrome.h:
              * page/DOMSelection.cpp:
              * page/DOMTimer.h:
              * page/DOMWindow.cpp:
              * page/EventHandler.cpp:
              * page/FocusController.h:
              * page/Geolocation.cpp:
              * page/Geolocation.h:
              * page/History.cpp:
              * rendering/RenderListBox.cpp:
              * workers/WorkerContext.cpp:
      2011-05-10  Tony Gentilcore  <tonyg@chromium.org>
      
              Reviewed by Darin Adler.
      
              Perform some forward declarations suggested by include-what-you-use
              https://bugs.webkit.org/show_bug.cgi?id=60545
      
              * src/WebHistoryItem.cpp:
              * src/WebNotification.cpp:
              * src/WebTextCheckingCompletionImpl.cpp:
              * src/mac/WebSubstringUtil.mm:
      2011-05-10  Tony Gentilcore  <tonyg@chromium.org>
      
              Reviewed by Darin Adler.
      
              Perform some forward declarations suggested by include-what-you-use
              https://bugs.webkit.org/show_bug.cgi?id=60545
      
              * Plugins/Hosted/WebHostedNetscapePluginView.mm:
              * WebView/WebFrame.mm:
      2011-05-10  Tony Gentilcore  <tonyg@chromium.org>
      
              Reviewed by Darin Adler.
      
              Perform some forward declarations suggested by include-what-you-use
              https://bugs.webkit.org/show_bug.cgi?id=60545
      
              * WebProcess/WebPage/mac/WebPageMac.mm:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@86325 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      4b0a55f4
  2. 05 May, 2011 1 commit
    • rniwa@webkit.org's avatar
      2011-05-05 Ryosuke Niwa <rniwa@webkit.org> · 78bbc94c
      rniwa@webkit.org authored
              Reviewed by Eric Seidel.
      
              Rename SelectionController to FrameSelection
              https://bugs.webkit.org/show_bug.cgi?id=60234
      
              * src/WebFrameImpl.cpp:
              (WebKit::WebFrameImpl::selectWordAroundCaret):
              * src/WebViewImpl.cpp:
              (WebKit::WebViewImpl::textInputType):
              (WebKit::WebViewImpl::caretOrSelectionBounds):
              (WebKit::WebViewImpl::caretOrSelectionRange):
              (WebKit::WebViewImpl::clearFocusedNode):
      2011-05-05  Ryosuke Niwa  <rniwa@webkit.org>
      
              Reviewed by Eric Seidel.
      
              Rename SelectionController to FrameSelection
              https://bugs.webkit.org/show_bug.cgi?id=60234
      
              * Api/qwebframe.cpp:
      2011-05-05  Ryosuke Niwa  <rniwa@webkit.org>
      
              Reviewed by Eric Seidel.
      
              Rename SelectionController to FrameSelection
              https://bugs.webkit.org/show_bug.cgi?id=60234
      
              * webkit/webkitwebview.cpp:
              (getLocationForKeyboardGeneratedContextMenu):
      2011-05-05  Ryosuke Niwa  <rniwa@webkit.org>
      
              Reviewed by Eric Seidel.
      
              Rename SelectionController to FrameSelection
              https://bugs.webkit.org/show_bug.cgi?id=60234
      
              * WebView.cpp:
      2011-05-05  Ryosuke Niwa  <rniwa@webkit.org>
      
              Reviewed by Eric Seidel.
      
              Rename SelectionController to FrameSelection
              https://bugs.webkit.org/show_bug.cgi?id=60234
      
              * WebDOMSelection.cpp:
              * WebDOMSelection.h:
              * WebKitSupport/EditorClientWx.cpp:
              * WebView.cpp:
      2011-05-05  Ryosuke Niwa  <rniwa@webkit.org>
      
              Reviewed by Eric Seidel.
      
              Rename SelectionController to FrameSelection
              https://bugs.webkit.org/show_bug.cgi?id=60234
      
              * WebView/WebFrame.mm:
              (-[WebFrame _rangeByAlteringCurrentSelection:FrameSelection::direction:granularity:]):
              * WebView/WebFrameInternal.h:
              * WebView/WebHTMLView.mm:
              * WebView/WebTextCompletionController.mm:
              (-[WebTextCompletionController doCompletion]):
              * WebView/WebView.mm:
      2011-05-05  Ryosuke Niwa  <rniwa@webkit.org>
      
              Reviewed by Eric Seidel.
      
              Rename SelectionController to FrameSelection
              https://bugs.webkit.org/show_bug.cgi?id=60234
      
              * WebCoreSupport/EditorClientHaiku.cpp:
              (WebCore::EditorClientHaiku::handleKeyboardEvent):
      2011-05-05  Ryosuke Niwa  <rniwa@webkit.org>
      
              Reviewed by Eric Seidel.
      
              Rename SelectionController to FrameSelection
              https://bugs.webkit.org/show_bug.cgi?id=60234
      
              * WebCoreSupport/EditorClientWinCE.cpp:
              (WebKit::EditorClientWinCE::handleEditingKeyboardEvent):
      2011-05-05  Ryosuke Niwa  <rniwa@webkit.org>
      
              Reviewed by Eric Seidel.
      
              Rename SelectionController to FrameSelection
              https://bugs.webkit.org/show_bug.cgi?id=60234
      
              * WebCoreSupport/EditorClientEfl.cpp:
              (WebCore::EditorClientEfl::handleEditingKeyboardEvent):
      2011-05-05  Ryosuke Niwa  <rniwa@webkit.org>
      
              Reviewed by Eric Seidel.
      
              Rename SelectionController to FrameSelection
              https://bugs.webkit.org/show_bug.cgi?id=60234
      
              * CMakeLists.txt:
              * GNUmakefile.list.am:
              * WebCore.exp.in:
              * WebCore.gypi:
              * WebCore.pro:
              * WebCore.vcproj/WebCore.vcproj:
              * WebCore.xcodeproj/project.pbxproj:
              * accessibility/AccessibilityObject.cpp:
              * accessibility/AccessibilityRenderObject.cpp:
              (WebCore::AccessibilityRenderObject::visiblePositionRangeForLine):
              * accessibility/mac/AccessibilityObjectWrapper.mm:
              * bindings/objc/ExceptionHandlers.h:
              * css/CSSStyleSelector.cpp:
              * dom/ContainerNode.cpp:
              (WebCore::ContainerNode::cloneChildNodes):
              * dom/Document.cpp:
              * dom/InputElement.cpp:
              * editing/DeleteButtonController.cpp:
              * editing/EditCommand.cpp:
              * editing/EditingAllInOne.cpp:
              * editing/EditingStyle.cpp:
              * editing/Editor.cpp:
              (WebCore::Editor::canCopy):
              (WebCore::Editor::canDelete):
              (WebCore::Editor::markMisspellingsAfterTypingToWord):
              (WebCore::Editor::markAllMisspellingsAndBadGrammarInRanges):
              (WebCore::Editor::changeSelectionAfterCommand):
              (WebCore::Editor::respondToChangedSelection):
              * editing/Editor.h:
              * editing/EditorCommand.cpp:
              (WebCore::executeDeleteToMark):
              (WebCore::executeMoveBackward):
              (WebCore::executeMoveBackwardAndModifySelection):
              (WebCore::executeMoveDown):
              (WebCore::executeMoveDownAndModifySelection):
              (WebCore::executeMoveForward):
              (WebCore::executeMoveForwardAndModifySelection):
              (WebCore::executeMoveLeft):
              (WebCore::executeMoveLeftAndModifySelection):
              (WebCore::executeMovePageDown):
              (WebCore::executeMovePageDownAndModifySelection):
              (WebCore::executeMovePageUp):
              (WebCore::executeMovePageUpAndModifySelection):
              (WebCore::executeMoveRight):
              (WebCore::executeMoveRightAndModifySelection):
              (WebCore::executeMoveToBeginningOfDocument):
              (WebCore::executeMoveToBeginningOfDocumentAndModifySelection):
              (WebCore::executeMoveToBeginningOfLine):
              (WebCore::executeMoveToBeginningOfLineAndModifySelection):
              (WebCore::executeMoveToBeginningOfParagraph):
              (WebCore::executeMoveToBeginningOfParagraphAndModifySelection):
              (WebCore::executeMoveToBeginningOfSentence):
              (WebCore::executeMoveToBeginningOfSentenceAndModifySelection):
              (WebCore::executeMoveToEndOfDocument):
              (WebCore::executeMoveToEndOfDocumentAndModifySelection):
              (WebCore::executeMoveToEndOfSentence):
              (WebCore::executeMoveToEndOfSentenceAndModifySelection):
              (WebCore::executeMoveToEndOfLine):
              (WebCore::executeMoveToEndOfLineAndModifySelection):
              (WebCore::executeMoveToEndOfParagraph):
              (WebCore::executeMoveToEndOfParagraphAndModifySelection):
              (WebCore::executeMoveParagraphBackwardAndModifySelection):
              (WebCore::executeMoveParagraphForwardAndModifySelection):
              (WebCore::executeMoveUp):
              (WebCore::executeMoveUpAndModifySelection):
              (WebCore::executeMoveWordBackward):
              (WebCore::executeMoveWordBackwardAndModifySelection):
              (WebCore::executeMoveWordForward):
              (WebCore::executeMoveWordForwardAndModifySelection):
              (WebCore::executeMoveWordLeft):
              (WebCore::executeMoveWordLeftAndModifySelection):
              (WebCore::executeMoveWordRight):
              (WebCore::executeMoveWordRightAndModifySelection):
              (WebCore::executeMoveToLeftEndOfLine):
              (WebCore::executeMoveToLeftEndOfLineAndModifySelection):
              (WebCore::executeMoveToRightEndOfLine):
              (WebCore::executeMoveToRightEndOfLineAndModifySelection):
              * editing/FrameSelection.cpp: Copied from Source/WebCore/editing/SelectionController.cpp.
              (WebCore::FrameSelection::FrameSelection):
              (WebCore::FrameSelection::moveTo):
              (WebCore::FrameSelection::setSelection):
              (WebCore::FrameSelection::nodeWillBeRemoved):
              (WebCore::FrameSelection::respondToNodeModification):
              (WebCore::FrameSelection::textWillBeReplaced):
              (WebCore::FrameSelection::setIsDirectional):
              (WebCore::FrameSelection::directionOfEnclosingBlock):
              (WebCore::FrameSelection::willBeModified):
              (WebCore::FrameSelection::positionForPlatform):
              (WebCore::FrameSelection::startForPlatform):
              (WebCore::FrameSelection::endForPlatform):
              (WebCore::FrameSelection::modifyExtendingRight):
              (WebCore::FrameSelection::modifyExtendingForward):
              (WebCore::FrameSelection::modifyMovingRight):
              (WebCore::FrameSelection::modifyMovingForward):
              (WebCore::FrameSelection::modifyExtendingLeft):
              (WebCore::FrameSelection::modifyExtendingBackward):
              (WebCore::FrameSelection::modifyMovingLeft):
              (WebCore::FrameSelection::modifyMovingBackward):
              (WebCore::FrameSelection::modify):
              (WebCore::FrameSelection::xPosForVerticalArrowNavigation):
              (WebCore::FrameSelection::clear):
              (WebCore::FrameSelection::setStart):
              (WebCore::FrameSelection::setEnd):
              (WebCore::FrameSelection::setBase):
              (WebCore::FrameSelection::setExtent):
              (WebCore::FrameSelection::setCaretRectNeedsUpdate):
              (WebCore::FrameSelection::updateCaretRect):
              (WebCore::FrameSelection::caretRenderer):
              (WebCore::FrameSelection::localCaretRect):
              (WebCore::FrameSelection::absoluteBoundsForLocalRect):
              (WebCore::FrameSelection::absoluteCaretBounds):
              (WebCore::FrameSelection::caretRepaintRect):
              (WebCore::FrameSelection::recomputeCaretRect):
              (WebCore::FrameSelection::shouldRepaintCaret):
              (WebCore::FrameSelection::invalidateCaretRect):
              (WebCore::FrameSelection::paintCaret):
              (WebCore::FrameSelection::debugRenderer):
              (WebCore::FrameSelection::contains):
              (WebCore::FrameSelection::selectFrameElementInParentIfFullySelected):
              (WebCore::FrameSelection::selectAll):
              (WebCore::FrameSelection::setSelectedRange):
              (WebCore::FrameSelection::isInPasswordField):
              (WebCore::FrameSelection::caretRendersInsideNode):
              (WebCore::FrameSelection::focusedOrActiveStateChanged):
              (WebCore::FrameSelection::pageActivationChanged):
              (WebCore::FrameSelection::updateSecureKeyboardEntryIfActive):
              (WebCore::FrameSelection::setUseSecureKeyboardEntry):
              (WebCore::FrameSelection::setFocused):
              (WebCore::FrameSelection::isFocusedAndActive):
              (WebCore::FrameSelection::updateAppearance):
              (WebCore::FrameSelection::setCaretVisible):
              (WebCore::FrameSelection::clearCaretRectIfNeeded):
              (WebCore::FrameSelection::caretBlinkTimerFired):
              (WebCore::FrameSelection::notifyRendererOfSelectionChange):
              (WebCore::FrameSelection::setFocusedNodeIfNeeded):
              (WebCore::FrameSelection::paintDragCaret):
              (WebCore::FrameSelection::copyTypingStyle):
              (WebCore::FrameSelection::shouldDeleteSelection):
              (WebCore::FrameSelection::bounds):
              (WebCore::FrameSelection::getClippedVisibleTextRectangles):
              (WebCore::FrameSelection::currentForm):
              (WebCore::FrameSelection::revealSelection):
              (WebCore::FrameSelection::setSelectionFromNone):
              (WebCore::FrameSelection::shouldChangeSelection):
              (WebCore::FrameSelection::formatForDebugger):
              (WebCore::FrameSelection::showTreeForThis):
              (showTree):
              * editing/FrameSelection.h: Copied from Source/WebCore/editing/SelectionController.h.
              (WebCore::FrameSelection::typingStyle):
              (WebCore::FrameSelection::clearTypingStyle):
              (WebCore::FrameSelection::setTypingStyle):
              (WebCore::FrameSelection::notifyAccessibilityForSelectionChange):
              * editing/ModifySelectionListLevel.cpp:
              * editing/RemoveFormatCommand.cpp:
              * editing/ReplaceSelectionCommand.cpp:
              * editing/SelectionController.cpp: Removed.
              * editing/SelectionController.h: Removed.
              * editing/SetSelectionCommand.cpp:
              (WebCore::SetSelectionCommand::SetSelectionCommand):
              (WebCore::SetSelectionCommand::doApply):
              (WebCore::SetSelectionCommand::doUnapply):
              * editing/SetSelectionCommand.h:
              (WebCore::SetSelectionCommand::create):
              * editing/SpellingCorrectionCommand.cpp:
              (WebCore::SpellingCorrectionCommand::doApply):
              * editing/SpellingCorrectionController.cpp:
              (WebCore::SpellingCorrectionController::respondToUnappliedSpellCorrection):
              * editing/TypingCommand.cpp:
              (WebCore::TypingCommand::deleteKeyPressed):
              (WebCore::TypingCommand::forwardDeleteKeyPressed):
              * editing/chromium/FrameSelectionChromium.cpp: Copied from Source/WebCore/editing/chromium/SelectionControllerChromium.cpp.
              (WebCore::FrameSelection::notifyAccessibilityForSelectionChange):
              * editing/chromium/SelectionControllerChromium.cpp: Removed.
              * editing/gtk/FrameSelectionGtk.cpp: Copied from Source/WebCore/editing/gtk/SelectionControllerGtk.cpp.
              (WebCore::FrameSelection::notifyAccessibilityForSelectionChange):
              * editing/gtk/SelectionControllerGtk.cpp: Removed.
              * editing/mac/EditorMac.mm:
              (WebCore::Editor::canCopyExcludingStandaloneImages):
              * editing/mac/FrameSelectionMac.mm: Copied from Source/WebCore/editing/mac/SelectionControllerMac.mm.
              (WebCore::FrameSelection::notifyAccessibilityForSelectionChange):
              * editing/mac/SelectionControllerMac.mm: Removed.
              * editing/qt/EditorQt.cpp:
              * loader/archive/cf/LegacyWebArchive.cpp:
              * page/ContextMenuController.cpp:
              (WebCore::ContextMenuController::populate):
              * page/DOMSelection.cpp:
              (WebCore::DOMSelection::type):
              (WebCore::DOMSelection::modify):
              (WebCore::DOMSelection::addRange):
              (WebCore::DOMSelection::deleteFromDocument):
              (WebCore::DOMSelection::containsNode):
              * page/DragController.cpp:
              (WebCore::DragController::dragIsMove):
              * page/DragController.h:
              * page/EventHandler.cpp:
              (WebCore::setSelectionIfNeeded):
              (WebCore::setNonDirectionalSelectionIfNeeded):
              (WebCore::EventHandler::sendContextMenuEventForKey):
              (WebCore::EventHandler::handleKeyboardSelectionMovement):
              * page/EventHandler.h:
              * page/FocusController.cpp:
              (WebCore::clearSelectionIfNeeded):
              * page/Frame.cpp:
              (WebCore::Frame::Frame):
              * page/Frame.h:
              (WebCore::Frame::selection):
              * page/Page.cpp:
              (WebCore::Page::Page):
              * page/Page.h:
              (WebCore::Page::dragCaretController):
              * page/chromium/DragControllerChromium.cpp:
              * page/chromium/EventHandlerChromium.cpp:
              * page/win/DragControllerWin.cpp:
              * page/win/EventHandlerWin.cpp:
              * rendering/HitTestResult.cpp:
              * rendering/RenderBlock.cpp:
              (WebCore::RenderBlock::destroy):
              (WebCore::RenderBlock::paintCaret):
              * rendering/RenderImage.cpp:
              * rendering/RenderInline.cpp:
              (WebCore::RenderInline::destroy):
              * rendering/RenderLayer.cpp:
              * rendering/RenderListBox.cpp:
              * rendering/RenderObjectChildList.cpp:
              (WebCore::RenderObjectChildList::removeChildNode):
              * rendering/RenderTextControl.cpp:
              * rendering/RenderTextControlSingleLine.cpp:
              * rendering/RenderTheme.cpp:
              * rendering/RenderTreeAsText.cpp:
              * svg/SVGSVGElement.cpp:
              * svg/SVGTextContentElement.cpp:
              (WebCore::SVGTextContentElement::selectSubString):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@85864 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      78bbc94c
  3. 27 Apr, 2011 1 commit
  4. 26 Apr, 2011 1 commit
  5. 12 Apr, 2011 2 commits
  6. 01 Apr, 2011 2 commits
  7. 30 Mar, 2011 1 commit
    • mario@webkit.org's avatar
      2011-03-30 Mario Sanchez Prada <msanchez@igalia.com> · 56f6bf20
      mario@webkit.org authored
              Reviewed by Chris Fleizach.
      
              AX: GTK: ARIA role is not respected on <p> <label> <div> and <form>
              https://bugs.webkit.org/show_bug.cgi?id=47636
      
              Added new layout test to check that roles are correct in GTK.
      
              * platform/gtk/accessibility/aria-roles-unignored-expected.txt: Added.
              * platform/gtk/accessibility/aria-roles-unignored.html: Added.
      2011-03-30  Mario Sanchez Prada  <msanchez@igalia.com>
      
              Reviewed by Chris Fleizach.
      
              AX: GTK: ARIA role is not respected on <p> <label> <div> and <form>
              https://bugs.webkit.org/show_bug.cgi?id=47636
      
              Define new roles in WebCore and map them to ATK accordingly.
      
              Test: platform/gtk/accessibility/aria-roles-unignored.html
      
              * accessibility/AccessibilityObject.h: Added new roles to
              represent paragraphs, labels, forms and div sections.
              * accessibility/AccessibilityRenderObject.cpp:
              (WebCore::AccessibilityRenderObject::determineAccessibilityRole):
              Return ParagraphRole, LabelRole, FormRole and DivRole when needed
              for the GTK platform only.
              * accessibility/gtk/AccessibilityObjectAtk.cpp:
              (WebCore::AccessibilityObject::allowsTextRanges): Consider the new
              roles now that those kind of nodes won't return true to isGroup().
              * accessibility/gtk/AccessibilityObjectWrapperAtk.cpp:
              (atkRole): Map new WebCore roles to ATK Roles.
              (webkit_accessible_get_role): Remove code to define roles for
              paragraphs, labels, forms and divs based on node's tag name.
      
              Update mappings for the Mac platform.
      
              * accessibility/mac/AccessibilityObjectWrapper.mm:
              (createAccessibilityRoleMap): Add explicit mappings from the new
              roles introduced to NSAccessibilityGroupRole.
      2011-03-30  Mario Sanchez Prada  <msanchez@igalia.com>
      
              Reviewed by Chris Fleizach.
      
              AX: GTK: ARIA role is not respected on <p> <label> <div> and <form>
              https://bugs.webkit.org/show_bug.cgi?id=47636
      
              Duplicate new internal WebCore roles in the Chromium port.
      
              * public/WebAccessibilityRole.h: Update enumeration
              WebAccessibilityRole to reflect newly added roles in WebCore.
              * src/AssertMatchingEnums.cpp: Added new assertions.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@82459 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      56f6bf20
  8. 29 Mar, 2011 2 commits
  9. 21 Mar, 2011 1 commit
    • cfleizach@apple.com's avatar
      AX: showContextMenu not working in WK2 · b46f9b01
      cfleizach@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=56734
      
      Reviewed by Darin Adler.
      
      ../WebCore: 
      
      WebKit2 is not able to directly open a context menu because the UI is in the other process.
      Instead the chrome client should be used. This also means implementing showContextMenu() in WebKit1
      code.
              
      * accessibility/mac/AccessibilityObjectWrapper.mm:
      (-[AccessibilityObjectWrapper accessibilityShowContextMenu]):
      
      ../WebKit/mac: 
      
      Implement showContextMenu() so accessibility related code can call this
      independent of whether WK1 or WK2 is running.
      
      * WebCoreSupport/WebChromeClient.h:
      * WebCoreSupport/WebChromeClient.mm:
      (WebChromeClient::showContextMenu):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@81619 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      b46f9b01
  10. 07 Mar, 2011 1 commit
    • cfleizach@apple.com's avatar
      Source/WebCore: AX: WK1 needs to use ScrollView attachment for AXScrollArea, WK2 does not · 1ed16911
      cfleizach@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=55706
      
      Reviewed by Beth Dakin.
      
      * WebCore.exp.in:
      * accessibility/AXObjectCache.cpp:
      (WebCore::AXObjectCache::rootObjectForFrame):
      * accessibility/AXObjectCache.h:
      * accessibility/AccessibilityScrollView.cpp:
      (WebCore::AccessibilityScrollView::isAttachment):
      (WebCore::AccessibilityScrollView::widgetForAttachmentView):
      * accessibility/AccessibilityScrollView.h:
      (WebCore::AccessibilityScrollView::firstChild):
      * accessibility/mac/AccessibilityObjectWrapper.mm:
      (-[AccessibilityObjectWrapper accessibilityAttributeValue:]):
      
      Source/WebKit/mac: AX: WK1 needs to use ScrollView attachment for AXScrollArea, WK2 does not
      https://bugs.webkit.org/show_bug.cgi?id=55706
      
      Reviewed by Beth Dakin.
      
      Make sure WebDynamicScrollBarsView appear in the AX tree in WK1 (since this object
      returns the scroll bar objects).
      Make the accessibilityRoot object be the web area in WK1 because WebDynamicScrollBarsView
      will expect that as its child, instead of the WebCore ScrollView object.
      
      * WebView/WebDynamicScrollBarsView.mm:
      (-[WebDynamicScrollBarsView accessibilityIsIgnored]):
      * WebView/WebFrame.mm:
      (-[WebFrame accessibilityRoot]):
      
      Tools: AX: WK1 needs to use the ScrollView attachment for AXScrollArea, WK2 should not use this element.
      https://bugs.webkit.org/show_bug.cgi?id=55706
      
      Reviewed by Beth Dakin.
      
      The rootElement in DRT should point to the scroll view. In WK1, that will be the parent of the rootObject.
      
      * DumpRenderTree/mac/AccessibilityControllerMac.mm:
      (AccessibilityController::focusedElement):
         Remove FIXME comment about caching the focusedElement. In fact, we shouldn't cache this 
         because it could change at any time.
      (AccessibilityController::rootElement):
      
      LayoutTests: AX: WK1 needs to use ScrollView attachment for AXScrollArea, WK2 does not
      https://bugs.webkit.org/show_bug.cgi?id=55706
      
      Reviewed by Beth Dakin.
      
      * platform/mac/accessibility/webkit-scrollarea-expected.txt:
      * platform/mac/accessibility/webkit-scrollarea-position-expected.txt:
      * platform/mac/accessibility/webkit-scrollarea-position.html:
      * platform/mac/accessibility/webkit-scrollarea.html:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@80498 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      1ed16911
  11. 28 Feb, 2011 1 commit
  12. 16 Feb, 2011 1 commit
    • commit-queue@webkit.org's avatar
      2011-02-16 Dominic Mazzoni <dmazzoni@google.com> · 93c90455
      commit-queue@webkit.org authored
              Reviewed by Chris Fleizach.
      
              Add new test for canvas fallback content and update existing text for new canvas role.
              https://bugs.webkit.org/show_bug.cgi?id=50126
      
              * accessibility/canvas-fallback-content-expected.txt: Added.
              * accessibility/canvas-fallback-content.html: Added.
              * accessibility/canvas.html:
      2011-02-16  Dominic Mazzoni  <dmazzoni@google.com>
      
              Reviewed by Chris Fleizach.
      
              Add support for canvas fallback content.
              https://bugs.webkit.org/show_bug.cgi?id=50126
      
              Test: accessibility/canvas-fallback-content.html
      
              * accessibility/AccessibilityObject.h:
              * accessibility/AccessibilityRenderObject.cpp:
              (WebCore::AccessibilityRenderObject::determineAccessibilityRole):
              (WebCore::AccessibilityRenderObject::canHaveChildren):
              * accessibility/gtk/AccessibilityObjectWrapperAtk.cpp:
              (atkRole):
              * accessibility/mac/AccessibilityObjectWrapper.mm:
              * html/HTMLFormControlElement.cpp:
              (WebCore::HTMLFormControlElement::isFocusable):
              * rendering/RenderHTMLCanvas.cpp:
              (WebCore::RenderHTMLCanvas::recursiveSetNoNeedsLayout):
              (WebCore::RenderHTMLCanvas::layout):
              (WebCore::RenderHTMLCanvas::nodeAtPoint):
              * rendering/RenderHTMLCanvas.h:
              (WebCore::RenderHTMLCanvas::children):
              (WebCore::RenderHTMLCanvas::canHaveChildren):
              (WebCore::RenderHTMLCanvas::virtualChildren):
              * rendering/RenderObject.cpp:
              (WebCore::RenderObject::repaint):
              * rendering/RenderTreeAsText.cpp:
              (WebCore::write):
      2011-02-16  Dominic Mazzoni  <dmazzoni@google.com>
      
              Reviewed by Chris Fleizach.
      
              Add new role for canvas elements.
      
              https://bugs.webkit.org/show_bug.cgi?id=50126
      
              * public/WebAccessibilityRole.h:
              * src/AssertMatchingEnums.cpp:
      2011-02-16  Dominic Mazzoni  <dmazzoni@google.com>
      
              Reviewed by Chris Fleizach.
      
              Add new role for canvas elements.
      
              https://bugs.webkit.org/show_bug.cgi?id=50126
      
              Test: accessibility/canvas-fallback-content.html
      
              * AccessibleBase.cpp:
              (MSAARole):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@78789 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      93c90455
  13. 15 Feb, 2011 1 commit
    • morrita@google.com's avatar
      2011-01-26 MORITA Hajime <morrita@google.com> · 7692b428
      morrita@google.com authored
              Reviewed by Ryosuke Niwa.
      
              Refactoring: Extract TextCheckerClient from EditorClient
              https://bugs.webkit.org/show_bug.cgi?id=53213
      
              Created new abstract class TextCheckerClient. The class has
              spellcheck related API which is split.
              This is the first step for sharing spell-checking codebase
              between ports. A standalone TextCheckerClient implementation
              should be done in future changes.
      
              No new tests. No behavioral change.
      
              * GNUmakefile.am:
              * WebCore.gypi:
              * WebCore.pro:
              * WebCore.vcproj/WebCore.vcproj:
              * WebCore.xcodeproj/project.pbxproj:
              * accessibility/mac/AccessibilityObjectWrapper.mm:
              (AXAttributeStringSetSpelling):
              * editing/Editor.cpp: Replacing some client() call with textChecker().
              (WebCore::Editor::textChecker): Added.
              (WebCore::Editor::ignoreSpelling):
              (WebCore::Editor::learnSpelling):
              (WebCore::Editor::isSelectionMisspelled):
              (WebCore::Editor::guessesForMisspelledSelection):
              (WebCore::Editor::markMisspellingsAfterTypingToWord):
              (WebCore::Editor::markAllMisspellingsAndBadGrammarInRanges):
              (WebCore::Editor::correctionPanelTimerFired):
              * editing/Editor.h:
              * editing/SpellChecker.cpp:
              (WebCore::SpellChecker::SpellChecker):
              * editing/TextCheckingHelper.cpp: Replacing some client() call with textChecker().
              (WebCore::TextCheckingHelper::findFirstMisspelling):
              (WebCore::TextCheckingHelper::findFirstMisspellingOrBadGrammar):
              (WebCore::TextCheckingHelper::findFirstBadGrammar):
              (WebCore::TextCheckingHelper::guessesForMisspelledOrUngrammaticalRange):
              * loader/EmptyClients.h: Added EmptyTextCheckerClient.
              (WebCore::EmptyTextCheckerClient::ignoreWordInSpellDocument):
              (WebCore::EmptyTextCheckerClient::learnWord):
              (WebCore::EmptyTextCheckerClient::checkSpellingOfString):
              (WebCore::EmptyTextCheckerClient::getAutoCorrectSuggestionForMisspelledWord):
              (WebCore::EmptyTextCheckerClient::checkGrammarOfString):
              (WebCore::EmptyTextCheckerClient::checkTextOfParagraph):
              (WebCore::EmptyTextCheckerClient::getGuessesForWord):
              (WebCore::EmptyTextCheckerClient::requestCheckingOfString):
              (WebCore::EmptyEditorClient::textChecker):
              * page/EditorClient.h: Extracted TextCheckerClient.
              * page/Page.h:
              * platform/text/TextCheckerClient.h: Added.
              (WebCore::TextCheckerClient::~TextCheckerClient):
      2011-01-26  MORITA Hajime  <morrita@google.com>
      
              Reviewed by Ryosuke Niwa.
      
              Refactoring: Extract TextCheckerClient from EditorClient
              https://bugs.webkit.org/show_bug.cgi?id=53213
      
              * src/EditorClientImpl.h:
              (WebKit::EditorClientImpl::textChecker):
      2011-01-26  MORITA Hajime  <morrita@google.com>
      
              Reviewed by Ryosuke Niwa.
      
              Refactoring: Extract TextCheckerClient from EditorClient
              https://bugs.webkit.org/show_bug.cgi?id=53213
      
              * WebCoreSupport/EditorClientEfl.h:
              (WebCore::EditorClientEfl::textChecker):
      2011-01-26  MORITA Hajime  <morrita@google.com>
      
              Reviewed by Ryosuke Niwa.
      
              Refactoring: Extract TextCheckerClient from EditorClient
              https://bugs.webkit.org/show_bug.cgi?id=53213
      
              * WebCoreSupport/EditorClientGtk.h:
              (WebKit::EditorClient::textChecker):
      2011-01-26  MORITA Hajime  <morrita@google.com>
      
              Reviewed by Ryosuke Niwa.
      
              Refactoring: Extract TextCheckerClient from EditorClient
              https://bugs.webkit.org/show_bug.cgi?id=53213
      
              * WebCoreSupport/EditorClientHaiku.h:
              (WebCore::EditorClientHaiku::textChecker):
      2011-01-26  MORITA Hajime  <morrita@google.com>
      
              Reviewed by Ryosuke Niwa.
      
              Refactoring: Extract TextCheckerClient from EditorClient
              https://bugs.webkit.org/show_bug.cgi?id=53213
      
              * WebCoreSupport/WebEditorClient.h:
              (WebEditorClient::textChecker):
      2011-01-26  MORITA Hajime  <morrita@google.com>
      
              Reviewed by Ryosuke Niwa.
      
              Refactoring: Extract TextCheckerClient from EditorClient
              https://bugs.webkit.org/show_bug.cgi?id=53213
      
              * WebCoreSupport/EditorClientQt.h:
              (WebCore::EditorClientQt::textChecker):
      2011-01-26  MORITA Hajime  <morrita@google.com>
      
              Reviewed by Ryosuke Niwa.
      
              Refactoring: Extract TextCheckerClient from EditorClient
              https://bugs.webkit.org/show_bug.cgi?id=53213
      
              * WebCoreSupport/WebEditorClient.h:
              (WebEditorClient::textChecker):
      2011-01-26  MORITA Hajime  <morrita@google.com>
      
              Reviewed by Ryosuke Niwa.
      
              Refactoring: Extract TextCheckerClient from EditorClient
              https://bugs.webkit.org/show_bug.cgi?id=53213
      
              * WebCoreSupport/EditorClientWinCE.h:
              (WebKit::EditorClientWinCE::textChecker):
      2011-01-26  MORITA Hajime  <morrita@google.com>
      
              Reviewed by Ryosuke Niwa.
      
              Refactoring: Extract TextCheckerClient from EditorClient
              https://bugs.webkit.org/show_bug.cgi?id=53213
      
              * WebKitSupport/EditorClientWx.h:
              (WebCore::EditorClientWx::textChecker):
      2011-01-26  MORITA Hajime  <morrita@google.com>
      
              Reviewed by Ryosuke Niwa.
      
              Refactoring: Extract TextCheckerClient from EditorClient
              https://bugs.webkit.org/show_bug.cgi?id=53213
      
              * Shared/WebCoreArgumentCoders.h:
              * UIProcess/TextChecker.h:
              * WebProcess/WebCoreSupport/WebEditorClient.h:
              (WebKit::WebEditorClient::textChecker):
              * Scripts/webkit2/messages.py: Re-arranged the include file
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@78533 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      7692b428
  14. 10 Feb, 2011 1 commit
    • cfleizach@apple.com's avatar
      AX: AX needs to stop using WebCoreViewFactory · 8727ce9d
      cfleizach@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=54153
      
      Reviewed by Anders Carlsson.
      
      ../WebCore: 
      
      WebKit2 no longer uses WebCoreViewFactory, which means that accessibility code needs
      to get off of it and use WebCoreSystemInterface, like other clients.
      
      * WebCore.exp.in:
      * accessibility/AXObjectCache.h:
      * accessibility/mac/AXObjectCacheMac.mm:
      (WebCore::AXObjectCache::handleFocusedUIElementChanged):
      * accessibility/mac/AccessibilityObjectWrapper.h:
      * accessibility/mac/AccessibilityObjectWrapper.mm:
      (-[AccessibilityObjectWrapper unregisterUniqueIdForUIElement]):
      (CFAutoreleaseHelper):
      (AXObjectIsTextMarker):
      (AXObjectIsTextMarkerRange):
      (AXTextMarkerRange):
      (AXTextMarkerRangeStart):
      (AXTextMarkerRangeEnd):
      (textMarkerForVisiblePosition):
      (-[AccessibilityObjectWrapper textMarkerForVisiblePosition:]):
      (visiblePositionForTextMarker):
      (-[AccessibilityObjectWrapper visiblePositionForTextMarker:]):
      (visiblePositionForStartOfTextMarkerRange):
      (visiblePositionForEndOfTextMarkerRange):
      (textMarkerRangeFromMarkers):
      (AXAttributeStringSetElement):
      (-[AccessibilityObjectWrapper doAXAttributedStringForTextMarkerRange:]):
      (textMarkerRangeFromVisiblePositions):
      (-[AccessibilityObjectWrapper textMarkerRangeFromVisiblePositions:endPosition:]):
      (-[AccessibilityObjectWrapper visiblePositionRangeForTextMarkerRange:]):
      (-[AccessibilityObjectWrapper textMarkerRangeForSelection]):
      (-[AccessibilityObjectWrapper accessibilitySetValue:forAttribute:]):
      (-[AccessibilityObjectWrapper accessibilityAttributeValue:forParameter:]):
      * editing/mac/SelectionControllerMac.mm:
      (WebCore::accessibilityConvertScreenRect):
      (WebCore::SelectionController::notifyAccessibilityForSelectionChange):
      * platform/mac/WebCoreSystemInterface.h:
      * platform/mac/WebCoreSystemInterface.mm:
      
      ../WebKit/mac: 
      
      * WebCoreSupport/WebSystemInterface.mm:
      (InitWebCoreSystemInterface):
      
      ../WebKit2: 
      
      * WebProcess/WebCoreSupport/mac/WebSystemInterface.mm:
      (InitWebCoreSystemInterface):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@78241 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      8727ce9d
  15. 09 Feb, 2011 1 commit
  16. 07 Feb, 2011 1 commit
  17. 04 Feb, 2011 1 commit
  18. 01 Feb, 2011 1 commit
    • hyatt@apple.com's avatar
      https://bugs.webkit.org/show_bug.cgi?id=53520 · aa0cba07
      hyatt@apple.com authored
              
      Reviewed by Oliver Hunt.
      
      Remove the physical terminology from IntRect and FloatRect.
              
      Now that we have flipped RenderBlocks for vertical-rl and horizontal-bt writing modes,
      we need to update our terminology to be more accurate.
      
      I'm borrowing a page from AppKit here (which also supports flipped NSViews) and
      renaming right() and bottom() to maxX() and maxY().  These terms remain accurate
      even for flipped rectangles.
      
      ../WebCore: 
      
      * accessibility/AccessibilityRenderObject.cpp:
      (WebCore::AccessibilityRenderObject::boundsForVisiblePositionRange):
      * accessibility/mac/AccessibilityObjectWrapper.mm:
      (-[AccessibilityObjectWrapper position]):
      * dom/ClientRect.h:
      (WebCore::ClientRect::right):
      (WebCore::ClientRect::bottom):
      * html/HTMLCanvasElement.cpp:
      (WebCore::HTMLCanvasElement::convertLogicalToDevice):
      * html/canvas/CanvasRenderingContext2D.cpp:
      (WebCore::normalizeRect):
      * inspector/InspectorAgent.cpp:
      (WebCore::InspectorAgent::drawElementTitle):
      * page/DOMWindow.cpp:
      (WebCore::DOMWindow::adjustWindowRect):
      * page/DragController.cpp:
      (WebCore::dragLocForSelectionDrag):
      * page/EventHandler.cpp:
      (WebCore::EventHandler::sendContextMenuEventForKey):
      * page/PrintContext.cpp:
      (WebCore::PrintContext::computePageRectsWithPageSizeInternal):
      (WebCore::PrintContext::pageNumberForElement):
      * page/SpatialNavigation.cpp:
      (WebCore::end):
      (WebCore::areRectsFullyAligned):
      (WebCore::areRectsMoreThanFullScreenApart):
      (WebCore::below):
      (WebCore::rightOf):
      (WebCore::isRectInDirection):
      (WebCore::entryAndExitPointsForDirection):
      (WebCore::virtualRectForDirection):
      * page/WindowFeatures.cpp:
      (WebCore::WindowFeatures::WindowFeatures):
      * platform/ScrollView.cpp:
      (WebCore::ScrollView::wheelEvent):
      * platform/Scrollbar.cpp:
      (WebCore::Scrollbar::setFrameRect):
      * platform/ScrollbarThemeComposite.cpp:
      (WebCore::ScrollbarThemeComposite::splitTrack):
      * platform/chromium/ScrollbarThemeChromium.cpp:
      (WebCore::ScrollbarThemeChromium::paintTickmarks):
      * platform/graphics/FloatQuad.h:
      (WebCore::FloatQuad::FloatQuad):
      * platform/graphics/FloatRect.cpp:
      (WebCore::FloatRect::intersects):
      (WebCore::FloatRect::contains):
      (WebCore::FloatRect::intersect):
      (WebCore::FloatRect::unite):
      (WebCore::enclosingIntRect):
      * platform/graphics/FloatRect.h:
      (WebCore::FloatRect::maxX):
      (WebCore::FloatRect::maxY):
      (WebCore::FloatRect::contains):
      * platform/graphics/IntRect.cpp:
      (WebCore::IntRect::intersects):
      (WebCore::IntRect::contains):
      (WebCore::IntRect::intersect):
      (WebCore::IntRect::unite):
      * platform/graphics/IntRect.h:
      (WebCore::IntRect::maxX):
      (WebCore::IntRect::maxY):
      (WebCore::IntRect::shiftXEdgeTo):
      (WebCore::IntRect::shiftMaxXEdgeTo):
      (WebCore::IntRect::shiftYEdgeTo):
      (WebCore::IntRect::shiftMaxYEdgeTo):
      (WebCore::IntRect::contains):
      * platform/graphics/WidthIterator.cpp:
      (WebCore::WidthIterator::advance):
      * platform/graphics/cg/GraphicsContextCG.cpp:
      (WebCore::GraphicsContext::drawRect):
      (WebCore::GraphicsContext::fillPath):
      (WebCore::GraphicsContext::fillRect):
      * platform/graphics/cg/ImageBufferCG.cpp:
      (WebCore::getImageData):
      (WebCore::putImageData):
      * platform/graphics/cg/ImageCG.cpp:
      (WebCore::BitmapImage::draw):
      * platform/graphics/filters/FilterEffect.cpp:
      (WebCore::FilterEffect::copyImageBytes):
      * platform/graphics/mac/ComplexTextController.cpp:
      (WebCore::ComplexTextController::adjustGlyphsAndAdvances):
      * platform/graphics/mac/SimpleFontDataMac.mm:
      (WebCore::SimpleFontData::platformBoundsForGlyph):
      * platform/graphics/transforms/AffineTransform.cpp:
      (WebCore::AffineTransform::mapRect):
      * platform/graphics/win/FontCGWin.cpp:
      (WebCore::drawGDIGlyphs):
      * platform/graphics/win/MediaPlayerPrivateQuickTimeWin.cpp:
      (WebCore::MediaPlayerPrivate::paint):
      * platform/gtk/RenderThemeGtk.cpp:
      (WebCore::centerRectVerticallyInParentInputElement):
      * platform/mac/WidgetMac.mm:
      (WebCore::Widget::paint):
      * rendering/InlineFlowBox.cpp:
      (WebCore::InlineFlowBox::addBoxShadowVisualOverflow):
      (WebCore::InlineFlowBox::addTextBoxVisualOverflow):
      * rendering/InlineTextBox.cpp:
      (WebCore::InlineTextBox::selectionRect):
      (WebCore::InlineTextBox::paint):
      (WebCore::InlineTextBox::positionForOffset):
      * rendering/RenderBlock.cpp:
      (WebCore::RenderBlock::addOverflowFromChildren):
      (WebCore::RenderBlock::paintChildren):
      (WebCore::RenderBlock::paintEllipsisBoxes):
      (WebCore::RenderBlock::inlineSelectionGaps):
      (WebCore::RenderBlock::adjustPointToColumnContents):
      (WebCore::RenderBlock::flipForWritingModeIncludingColumns):
      (WebCore::RenderBlock::adjustForColumns):
      * rendering/RenderBlock.h:
      (WebCore::RenderBlock::FloatingObject::right):
      (WebCore::RenderBlock::FloatingObject::bottom):
      * rendering/RenderBox.cpp:
      (WebCore::RenderBox::reflectedRect):
      (WebCore::RenderBox::localCaretRect):
      (WebCore::RenderBox::addShadowOverflow):
      (WebCore::RenderBox::addLayoutOverflow):
      (WebCore::RenderBox::visualOverflowRectForPropagation):
      (WebCore::RenderBox::layoutOverflowRectForPropagation):
      (WebCore::RenderBox::flipForWritingMode):
      * rendering/RenderFrameSet.cpp:
      (WebCore::RenderFrameSet::paintColumnBorder):
      (WebCore::RenderFrameSet::paintRowBorder):
      * rendering/RenderInline.cpp:
      (WebCore::RenderInline::paintOutlineForLine):
      * rendering/RenderLayer.cpp:
      (WebCore::RenderLayer::getRectToExpose):
      (WebCore::cornerRect):
      (WebCore::RenderLayer::positionOverflowControls):
      (WebCore::RenderLayer::overflowBottom):
      (WebCore::RenderLayer::overflowRight):
      (WebCore::RenderLayer::paintResizer):
      * rendering/RenderLineBoxList.cpp:
      (WebCore::RenderLineBoxList::rangeIntersectsRect):
      (WebCore::RenderLineBoxList::paint):
      * rendering/RenderListItem.cpp:
      (WebCore::RenderListItem::positionListMarker):
      * rendering/RenderListMarker.cpp:
      (WebCore::RenderListMarker::paint):
      * rendering/RenderObject.cpp:
      (WebCore::RenderObject::repaintAfterLayoutIfNeeded):
      * rendering/RenderOverflow.h:
      (WebCore::RenderOverflow::RenderOverflow):
      (WebCore::RenderOverflow::addLayoutOverflow):
      (WebCore::RenderOverflow::addVisualOverflow):
      (WebCore::RenderOverflow::setLayoutOverflow):
      (WebCore::RenderOverflow::setVisualOverflow):
      (WebCore::RenderOverflow::resetLayoutOverflow):
      * rendering/RenderReplaced.cpp:
      (WebCore::RenderReplaced::shouldPaint):
      * rendering/RenderScrollbarTheme.cpp:
      (WebCore::RenderScrollbarTheme::constrainTrackRectToTrackPieces):
      * rendering/RenderTable.cpp:
      (WebCore::RenderTable::paint):
      * rendering/RenderTableCell.cpp:
      (WebCore::RenderTableCell::paint):
      * rendering/RenderTableSection.cpp:
      (WebCore::RenderTableSection::paintObject):
      * rendering/RenderText.cpp:
      (WebCore::RenderText::absoluteQuads):
      * rendering/RenderTextControlSingleLine.cpp:
      (WebCore::RenderTextControlSingleLine::forwardEvent):
      * rendering/RenderThemeMac.mm:
      (WebCore::RenderThemeMac::paintMenuListButtonGradients):
      (WebCore::RenderThemeMac::paintMenuListButton):
      (WebCore::RenderThemeMac::paintSliderTrack):
      * rendering/RenderView.cpp:
      (WebCore::RenderView::computeRectForRepaint):
      (WebCore::RenderView::docBottom):
      (WebCore::RenderView::docRight):
      * rendering/RootInlineBox.cpp:
      (WebCore::RootInlineBox::paddedLayoutOverflowRect):
      * rendering/svg/RenderSVGInlineText.cpp:
      (WebCore::RenderSVGInlineText::localCaretRect):
      
      ../WebKit/mac: 
      
      * WebView/WebHTMLView.mm:
      (setNeedsDisplayInRect):
      
      ../WebKit2: 
      
      * Platform/Region.cpp:
      (WebKit::Region::Shape::Shape):
      * UIProcess/API/mac/WKPrintingView.mm:
      (pageDidComputePageRects):
      * UIProcess/FindIndicator.cpp:
      (WebKit::FindIndicator::draw):
      * UIProcess/TiledDrawingAreaProxy.cpp:
      (WebKit::TiledDrawingAreaProxy::invalidate):
      (WebKit::TiledDrawingAreaProxy::paint):
      (WebKit::TiledDrawingAreaProxy::createTiles):
      * UIProcess/mac/ChunkedUpdateDrawingAreaProxyMac.mm:
      (WebKit::ChunkedUpdateDrawingAreaProxy::drawUpdateChunkIntoBackingStore):
      * WebProcess/Plugins/Netscape/NetscapePlugin.cpp:
      (WebKit::NetscapePlugin::callSetWindow):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@77286 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      aa0cba07
  19. 18 Jan, 2011 1 commit
    • cfleizach@apple.com's avatar
      REGRESSION: A problem with Voiceover and finding links · 99abb088
      cfleizach@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=52324
      
      Reviewed by Darin Adler.
      
      Source/WebCore: 
      
      Fallout from recent change to make WebCore return its own scroll view.
         1) There were two scroll views in the hierarchy, one which no needed to be ignored.
         2) Hit tests for sub frames needed to be offset.
         3) The check for whether an attachment is ignored must happen earlier than using
            the helpText to determine if an element should be ignored.
      
      Test: platform/mac/accessibility/iframe-with-title-correct-hierarchy.html
      
      * accessibility/AccessibilityObject.cpp:
      (WebCore::AccessibilityObject::elementAccessibilityHitTest):
      * accessibility/AccessibilityRenderObject.cpp:
      (WebCore::AccessibilityRenderObject::accessibilityIsIgnored):
      * accessibility/mac/AccessibilityObjectWrapper.mm:
      (-[AccessibilityObjectWrapper scrollViewParent]):
      
      Source/WebKit/mac: 
      
      * WebView/WebDynamicScrollBarsView.mm:
      (-[WebDynamicScrollBarsView accessibilityIsIgnored]):
      
      LayoutTests: 
      
      * platform/mac/accessibility/iframe-with-title-correct-hierarchy-expected.txt: Added.
      * platform/mac/accessibility/iframe-with-title-correct-hierarchy.html: Added.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@76044 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      99abb088
  20. 08 Jan, 2011 1 commit
  21. 06 Jan, 2011 1 commit
    • cfleizach@apple.com's avatar
      AX: "AXExpanded" not exposed on most ARIA roles that use aria-expanded · 603b034c
      cfleizach@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=51995
      
      Reviewed by Beth Dakin.
      
      WebCore: 
      
      Test: platform/mac/accessibility/aria-expanded-standard-items.html
      
      * accessibility/AccessibilityObject.cpp:
      (WebCore::AccessibilityObject::supportsARIAExpanded):
      (WebCore::AccessibilityObject::isExpanded):
      * accessibility/AccessibilityObject.h:
      * accessibility/AccessibilityRenderObject.cpp:
      (WebCore::AccessibilityRenderObject::isVisited):
      * accessibility/AccessibilityRenderObject.h:
      * accessibility/mac/AccessibilityObjectWrapper.mm:
      (-[AccessibilityObjectWrapper additionalAccessibilityAttributeNames]):
      
      LayoutTests: 
      
      * platform/mac/accessibility/aria-expanded-standard-items-expected.txt: Added.
      * platform/mac/accessibility/aria-expanded-standard-items.html: Added.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@75179 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      603b034c
  22. 04 Jan, 2011 1 commit
    • cfleizach@apple.com's avatar
      WK2: Support Accessibility · aa50410b
      cfleizach@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=51859
      
      Reviewed by Sam Weinig.
      
      Tools: 
      
      Use rootObject() method to get top of accessibility tree.
      
      * DumpRenderTree/mac/AccessibilityControllerMac.mm:
      (AccessibilityController::focusedElement):
      (AccessibilityController::rootElement):
      
      WebCore: 
      
      WK2 doesn't use platform scroll views anymore. Accessibility code
      needs to have its own scroll views. 
      
      Test: platform/mac/accessibility/webkit-scrollarea.html
      
      * CMakeLists.txt:
      * GNUmakefile.am:
      * WebCore.exp.in:
      * WebCore.gypi:
      * WebCore.pro:
      * WebCore.vcproj/WebCore.vcproj:
      * WebCore.xcodeproj/project.pbxproj:
      * accessibility/AXObjectCache.cpp:
      (WebCore::AXObjectCache::AXObjectCache):
      (WebCore::AXObjectCache::get):
      (WebCore::AXObjectCache::getOrCreate):
      (WebCore::AXObjectCache::rootObject):
      (WebCore::AXObjectCache::remove):
      (WebCore::AXObjectCache::handleScrollbarUpdate):
      * accessibility/AXObjectCache.h:
      (WebCore::AXObjectCache::handleScrollbarUpdate):
      * accessibility/AccessibilityARIAGrid.h:
      * accessibility/AccessibilityAllInOne.cpp:
      * accessibility/AccessibilityImageMapLink.cpp:
      * accessibility/AccessibilityImageMapLink.h:
      * accessibility/AccessibilityListBoxOption.cpp:
      * accessibility/AccessibilityListBoxOption.h:
      * accessibility/AccessibilityObject.cpp:
      (WebCore::AccessibilityObject::updateChildrenIfNecessary):
      (WebCore::AccessibilityObject::elementAccessibilityHitTest):
      (WebCore::AccessibilityObject::axObjectCache):
      (WebCore::AccessibilityObject::focusedUIElement):
      * accessibility/AccessibilityObject.h:
      (WebCore::AccessibilityObject::isAccessibilityScrollView):
      (WebCore::AccessibilityObject::isScrollView):
      (WebCore::AccessibilityObject::canSetNumericValue):
      (WebCore::AccessibilityObject::scrollBar):
      (WebCore::AccessibilityObject::size):
      (WebCore::AccessibilityObject::setValue):
      * accessibility/AccessibilityRenderObject.cpp:
      (WebCore::AccessibilityRenderObject::parentObject):
      (WebCore::AccessibilityRenderObject::accessibilityHitTest):
      (WebCore::AccessibilityRenderObject::updateChildrenIfNecessary):
      (WebCore::AccessibilityRenderObject::addChildren):
      * accessibility/AccessibilityRenderObject.h:
      * accessibility/AccessibilityScrollView.cpp: Added.
      (WebCore::AccessibilityScrollView::AccessibilityScrollView):
      (WebCore::AccessibilityScrollView::create):
      (WebCore::AccessibilityScrollView::scrollBar):
      (WebCore::AccessibilityScrollView::children):
      (WebCore::AccessibilityScrollView::updateChildrenIfNecessary):
      (WebCore::AccessibilityScrollView::removeChildScrollbar):
      (WebCore::AccessibilityScrollView::addChildScrollbar):
      (WebCore::AccessibilityScrollView::addChildren):
      (WebCore::AccessibilityScrollView::webAreaObject):
      (WebCore::AccessibilityScrollView::accessibilityHitTest):
      (WebCore::AccessibilityScrollView::document):
      (WebCore::AccessibilityScrollView::elementRect):
      (WebCore::AccessibilityScrollView::parentObject):
      * accessibility/AccessibilityScrollView.h: Added.
      (WebCore::AccessibilityScrollView::roleValue):
      (WebCore::AccessibilityScrollView::scrollView):
      (WebCore::AccessibilityScrollView::accessibilityIsIgnored):
      (WebCore::AccessibilityScrollView::isAccessibilityScrollView):
      (WebCore::toAccessibilityScrollView):
      * accessibility/AccessibilityScrollbar.cpp:
      (WebCore::AccessibilityScrollbar::AccessibilityScrollbar):
      (WebCore::AccessibilityScrollbar::create):
      (WebCore::AccessibilityScrollbar::elementRect):
      (WebCore::AccessibilityScrollbar::document):
      (WebCore::AccessibilityScrollbar::orientation):
      (WebCore::AccessibilityScrollbar::isEnabled):
      (WebCore::AccessibilityScrollbar::valueForRange):
      (WebCore::AccessibilityScrollbar::setValue):
      * accessibility/AccessibilityScrollbar.h:
      (WebCore::AccessibilityScrollbar::setParent):
      (WebCore::AccessibilityScrollbar::canSetValueAttribute):
      (WebCore::AccessibilityScrollbar::canSetNumericValue):
      (WebCore::AccessibilityScrollbar::isAccessibilityScrollbar):
      (WebCore::AccessibilityScrollbar::parentObject):
      (WebCore::AccessibilityScrollbar::roleValue):
      * accessibility/mac/AccessibilityObjectMac.mm:
      (WebCore::AccessibilityObject::accessibilityIgnoreAttachment):
      * accessibility/mac/AccessibilityObjectWrapper.mm:
      (-[AccessibilityObjectWrapper accessibilityAttributeNames]):
      (-[AccessibilityObjectWrapper remoteAccessibilityParentObject]):
      (-[AccessibilityObjectWrapper position]):
      (-[AccessibilityObjectWrapper scrollViewParent]):
      (-[AccessibilityObjectWrapper accessibilityAttributeValue:]):
      (-[AccessibilityObjectWrapper accessibilityHitTest:]):
      (-[AccessibilityObjectWrapper accessibilitySetValue:forAttribute:]):
      * dom/Document.cpp:
      (WebCore::Document::axObjectCache):
      * loader/EmptyClients.h:
      (WebCore::EmptyFrameLoaderClient::accessibilityRemoteObject):
      * loader/FrameLoaderClient.h:
      * page/FrameView.cpp:
      (WebCore::FrameView::~FrameView):
      (WebCore::FrameView::axObjectCache):
      * page/FrameView.h:
      * platform/ScrollView.cpp:
      (WebCore::ScrollView::setHasHorizontalScrollbar):
      (WebCore::ScrollView::setHasVerticalScrollbar):
      * platform/Scrollbar.cpp:
      (WebCore::Scrollbar::~Scrollbar):
      (WebCore::Scrollbar::scroll):
      (WebCore::Scrollbar::axObjectCache):
      * platform/Scrollbar.h:
      * platform/Widget.h:
      (WebCore::Widget::axObjectCache):
      
      WebKit/gtk: 
      
      Use rootObject() method to get top of ax tree.
      
      * WebCoreSupport/DumpRenderTreeSupportGtk.cpp:
      (DumpRenderTreeSupportGtk::getFocusedAccessibleElement):
      * webkit/webkitwebview.cpp:
      (webkit_web_view_get_accessible):
      
      WebKit/mac: 
      
      Use rootObject() method to get top of AX tree.
      
      * WebCoreSupport/WebFrameLoaderClient.h:
      (WebFrameLoaderClient::accessibilityRemoteObject):
      * WebView/WebFrame.mm:
      (-[WebFrame setAccessibleName:]):
      (-[WebFrame accessibilityRoot]):
      * WebView/WebFrameInternal.h:
      * WebView/WebFramePrivate.h:
      * WebView/WebHTMLView.mm:
      (-[WebHTMLView accessibilityAttributeValue:]):
      (-[WebHTMLView accessibilityFocusedUIElement]):
      (-[WebHTMLView accessibilityHitTest:]):
      (-[WebHTMLView _accessibilityParentForSubview:]):
      
      WebKit/win: 
      
      Use rootObject() method to get the top of the AX tree.
      
      * AccessibleDocument.cpp:
      (AccessibleDocument::AccessibleDocument):
      
      WebKit2: 
      
      Implement remote accessibility API to support cross process accessibility
      on the Mac platform.
      
      * Shared/WebProcessCreationParameters.cpp:
      (WebKit::WebProcessCreationParameters::encode):
      (WebKit::WebProcessCreationParameters::decode):
      * Shared/WebProcessCreationParameters.h:
      * UIProcess/API/mac/PageClientImpl.h:
      * UIProcess/API/mac/PageClientImpl.mm:
      (WebKit::PageClientImpl::accessibilityChildTokenReceived):
      * UIProcess/API/mac/WKView.mm:
      (-[WKView initWithFrame:contextRef:pageGroupRef:]):
      (-[WKView _updateWindowAndViewFrames]):
      (-[WKView _setAccessibilityChildToken:]):
      (-[WKView accessibilityIsIgnored]):
      (-[WKView accessibilityHitTest:]):
      (-[WKView accessibilityAttributeValue:]):
      * UIProcess/API/mac/WKViewInternal.h:
      * UIProcess/PageClient.h:
      * UIProcess/WebContext.cpp:
      (WebKit::WebContext::ensureWebProcess):
      * UIProcess/WebPageProxy.cpp:
      (WebKit::WebPageProxy::windowAndViewFramesChanged):
      (WebKit::WebPageProxy::didReceiveAccessibilityPageToken):
      (WebKit::WebPageProxy::sendAccessibilityPresenterToken):
      * UIProcess/WebPageProxy.h:
      * UIProcess/WebPageProxy.messages.in:
      * WebKit2.xcodeproj/project.pbxproj:
      * WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:
      (WebKit::WebFrameLoaderClient::accessibilityRemoteObject):
      * WebProcess/WebCoreSupport/WebFrameLoaderClient.h:
      * WebProcess/WebPage/WebPage.cpp:
      (WebKit::WebPage::windowAndViewFramesChanged):
      * WebProcess/WebPage/WebPage.h:
      (WebKit::WebPage::accessibilityPosition):
      * WebProcess/WebPage/WebPage.messages.in:
      * WebProcess/WebPage/mac/AccessibilityWebPageObject.h: Added.
      * WebProcess/WebPage/mac/AccessibilityWebPageObject.mm: Added.
      (-[AccessibilityWebPageObject setWebPage:]):
      (-[AccessibilityWebPageObject setRemoteParent:]):
      (-[AccessibilityWebPageObject dealloc]):
      (-[AccessibilityWebPageObject accessibilityIsIgnored]):
      (-[AccessibilityWebPageObject accessibilityAttributeNames]):
      (-[AccessibilityWebPageObject accessibilityIsAttributeSettable:]):
      (-[AccessibilityWebPageObject accessibilitySetValue:forAttribute:]):
      (-[AccessibilityWebPageObject accessibilityActionNames]):
      (-[AccessibilityWebPageObject accessibilityChildren]):
      (-[AccessibilityWebPageObject accessibilityAttributeValue:]):
      (-[AccessibilityWebPageObject accessibilityShouldUseUniqueId]):
      (-[AccessibilityWebPageObject accessibilityHitTest:]):
      (-[AccessibilityWebPageObject accessibilityFocusedUIElement]):
      * WebProcess/WebPage/mac/WebPageMac.mm:
      (WebKit::WebPage::platformInitialize):
      (WebKit::WebPage::sendAccessibilityPresenterToken):
      (WebKit::WebPage::accessibilityRemoteObject):
      * WebProcess/WebProcess.cpp:
      (WebKit::WebProcess::initializeWebProcess):
      * WebProcess/WebProcess.h:
      (WebKit::WebProcess::presenterApplicationPid):
      * WebProcess/mac/WebProcessMainMac.mm:
      (WebKit::WebProcessMain):
      
      LayoutTests: 
      
      * platform/mac/accessibility/webkit-scrollarea-expected.txt: Added.
      * platform/mac/accessibility/webkit-scrollarea.html: Added.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@75031 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      aa50410b
  23. 13 Dec, 2010 2 commits
    • cfleizach@apple.com's avatar
      AX: aria-invalid should be supported. · 4f5eb1cc
      cfleizach@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=50573
      
      Reviewed by Beth Dakin.
      
      WebCore: 
      
      Test: platform/mac/accessibility/aria-invalid.html
      
      * accessibility/AXObjectCache.h:
      * accessibility/AccessibilityObject.cpp:
      (WebCore::AccessibilityObject::invalidStatus):
      * accessibility/AccessibilityObject.h:
      * accessibility/chromium/AXObjectCacheChromium.cpp
      (WebCore::AXObjectCache::postPlatformNotification):
      * accessibility/mac/AXObjectCacheMac.mm:
      (WebCore::AXObjectCache::postPlatformNotification):
      * accessibility/mac/AccessibilityObjectWrapper.mm:
      (-[AccessibilityObjectWrapper accessibilityAttributeNames]):
      (-[AccessibilityObjectWrapper accessibilityAttributeValue:]):
      * dom/Element.cpp:
      (WebCore::Element::updateAfterAttributeChanged):
      * html/HTMLAttributeNames.in:
      
      LayoutTests: 
      
      * platform/mac/accessibility/aria-invalid-expected.txt: Added.
      * platform/mac/accessibility/aria-invalid.html: Added.
      * platform/mac/accessibility/radio-button-group-members-expected.txt:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@73983 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      4f5eb1cc
    • cfleizach@apple.com's avatar
      2010-12-13 Chris Fleizach <cfleizach@apple.com> · 271495a4
      cfleizach@apple.com authored
              Reviewed by Beth Dakin.
      
              AX: lists and list boxes need different attributes
              https://bugs.webkit.org/show_bug.cgi?id=50978
      
              Separate out the attributes being returned for lists (<ul>) and listboxes (<select multiple>).
      
              * accessibility/mac/AccessibilityObjectWrapper.mm:
              (-[AccessibilityObjectWrapper accessibilityAttributeNames]):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@73971 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      271495a4
  24. 10 Dec, 2010 1 commit
    • cfleizach@apple.com's avatar
      AX: refactor AccessibilityRenderObject::doAccessibilityHitTest · 8665fa25
      cfleizach@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=50574
      
      Reviewed by Darin Adler.
      
      WebCore: 
      
      Refactors accessibility hit testing to allow for a more flexible model when handling elements
      with fake sub-elements (like sliders or list boxes).
      
      Renamed doAccessibilityHitTest -> accessibilityHitTest, which is called on the root
      accessibility render object. Then subclassers are able to override 
      elementAccessibilityHitTest to return their own specific elements.
      
      * accessibility/AccessibilityListBox.cpp:
      (WebCore::AccessibilityListBox::elementAccessibilityHitTest):
      * accessibility/AccessibilityListBox.h:
      * accessibility/AccessibilityObject.h:
      (WebCore::AccessibilityObject::accessibilityHitTest):
      (WebCore::AccessibilityObject::elementAccessibilityHitTest):
      * accessibility/AccessibilityRenderObject.cpp:
      (WebCore::AccessibilityRenderObject::accessibilityHitTest):
      * accessibility/AccessibilityRenderObject.h:
      * accessibility/AccessibilitySlider.cpp:
      (WebCore::AccessibilitySlider::elementAccessibilityHitTest):
      * accessibility/AccessibilitySlider.h:
      * accessibility/gtk/AccessibilityObjectWrapperAtk.cpp:
      (webkit_accessible_component_ref_accessible_at_point):
      * accessibility/mac/AccessibilityObjectWrapper.mm:
      (-[AccessibilityObjectWrapper accessibilityHitTest:]):
      
      WebKit/chromium: 
      
      * src/WebAccessibilityObject.cpp:
      (WebKit::WebAccessibilityObject::hitTest):
      
      WebKit/win: 
      
      * AccessibleBase.cpp:
      (AccessibleBase::accHitTest):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@73825 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      8665fa25
  25. 06 Dec, 2010 1 commit
    • cfleizach@apple.com's avatar
      HTML5 Slider does not work correctly with VoiceOver · 583ba85b
      cfleizach@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=50505
      
      Reviewed by Darin Adler.
      
      Address a few problems with the Mac implementation for the accessibility slider.
          1) The value indicator is not hit testable.
          2) The value indicator does not return an AXValue.
          3) In the slider, the min/max values are not correct when min/max attributes are not present.
          4) When you change the value with the keyboard, it doesn't send out the right notification.
          5) Sliders were returning AXValue and AXTopLevelUIElement attributes twice in their list of attributes.
      
      Test: platform/mac/accessibility/html-slider-indicator.html
      
      WebCore: 
      
      * accessibility/AccessibilityObject.cpp:
      (WebCore::AccessibilityObject::getAttribute):
          Use fastGetAttribute on Element, instead of getAttribute.
      * accessibility/AccessibilityObject.h:
      (WebCore::AccessibilityObject::isInputSlider):
      * accessibility/AccessibilityRenderObject.cpp:
      (WebCore::AccessibilityRenderObject::doAccessibilityHitTest):
      * accessibility/AccessibilitySlider.cpp:
      (WebCore::AccessibilitySlider::doAccessibilityHitTest):
      (WebCore::AccessibilitySlider::maxValueForRange):
      (WebCore::AccessibilitySlider::minValueForRange):
      * accessibility/AccessibilitySlider.h:
      (WebCore::AccessibilitySlider::isInputSlider):
      * accessibility/mac/AccessibilityObjectWrapper.mm:
      (-[AccessibilityObjectWrapper accessibilityAttributeNames]):
      (-[AccessibilityObjectWrapper accessibilityAttributeValue:]):
      * html/HTMLInputElement.cpp:
      (WebCore::HTMLInputElement::applyStep):
      
      LayoutTests: 
      
      * platform/mac/accessibility/html-slider-indicator-expected.txt: Added.
      * platform/mac/accessibility/html-slider-indicator.html: Added.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@73388 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      583ba85b
  26. 17 Nov, 2010 1 commit
    • dglazkov@chromium.org's avatar
      Converge means of querying a parent node into one way, which is Node::parentNode. · e43caa78
      dglazkov@chromium.org authored
      https://bugs.webkit.org/show_bug.cgi?id=49686
      
      Reviewed by Darin Adler.
      
      WebCore:
      
      No change in behavior, so no new tests.
      
      * accessibility/AccessibilityObject.cpp:
      (WebCore::renderListItemContainerForNode): Changed to use parentNode.
      * accessibility/AccessibilityRenderObject.cpp:
      (WebCore::AccessibilityRenderObject::mouseButtonListener): Ditto.
      (WebCore::siblingWithAriaRole): Ditto.
      (WebCore::AccessibilityRenderObject::getDocumentLinks): Ditto.
      (WebCore::AccessibilityRenderObject::accessibilityImageMapHitTest): Ditto.
      * accessibility/mac/AccessibilityObjectWrapper.mm: Ditto.
      (blockquoteLevel): Ditto.
      * bindings/v8/V8GCController.cpp:
      (WebCore::ObjectGrouperVisitor::visitDOMWrapper): Ditto.
      * dom/ContainerNode.cpp: Ditto.
      (WebCore::ContainerNode::insertBefore): Ditto.
      (WebCore::ContainerNode::insertBeforeCommon): Ditto.
      (WebCore::ContainerNode::replaceChild): Ditto.
      (WebCore::ContainerNode::removeChild): Ditto.
      (WebCore::ContainerNode::appendChild): Ditto.
      (WebCore::ContainerNode::parserAddChild): Ditto.
      * dom/DocumentType.cpp:
      (WebCore::DocumentType::insertedIntoDocument): Ditto.
      * dom/Element.cpp:
      (WebCore::Element::computeInheritedLanguage): Ditto.
      * dom/MouseRelatedEvent.cpp:
      (WebCore::MouseRelatedEvent::receivedTarget): Ditto.
      * dom/Position.cpp:
      (WebCore::Position::isCandidate): Changed to use parentNode.
      * dom/PositionIterator.cpp:
      (WebCore::PositionIterator::isCandidate): Ditto.
      * editing/AppendNodeCommand.cpp:
      (WebCore::AppendNodeCommand::AppendNodeCommand): Ditto.
      * editing/ApplyStyleCommand.cpp:
      (WebCore::dummySpanAncestorForNode): Ditto.
      (WebCore::ApplyStyleCommand::splitAncestorsWithUnicodeBidi): Ditto.
      (WebCore::ApplyStyleCommand::removeEmbeddingUpToEnclosingBlock): Ditto.
      (WebCore::highestEmbeddingAncestor): Ditto.
      (WebCore::ApplyStyleCommand::splitTextElementAtEnd): Ditto.
      (WebCore::ApplyStyleCommand::mergeStartWithPreviousIfIdentical): Ditto.
      (WebCore::ApplyStyleCommand::mergeEndWithNextIfIdentical): Ditto.
      * editing/CompositeEditCommand.cpp:
      (WebCore::CompositeEditCommand::splitTreeToNode): Ditto.
      * editing/DeleteSelectionCommand.cpp:
      (WebCore::updatePositionForNodeRemoval): Ditto.
      * editing/Editor.cpp:
      (WebCore::Editor::textDirectionForSelection): Ditto.
      * editing/MergeIdenticalElementsCommand.cpp:
      (WebCore::MergeIdenticalElementsCommand::doUnapply): Ditto.
      * editing/htmlediting.cpp:
      (WebCore::isEmptyTableCell): Ditto.
      * editing/markup.cpp:
      (WebCore::StyledMarkupAccumulator::serializeNodes): Ditto.
      * editing/visible_units.cpp:
      (WebCore::previousLinePosition): Ditto.
      (WebCore::nextLinePosition): Ditto.
      * html/HTMLAreaElement.cpp:
      (WebCore::HTMLAreaElement::imageElement): Ditto.
      * html/HTMLElement.cpp:
      (WebCore::HTMLElement::setOuterHTML): Ditto.
      (WebCore::HTMLElement::insertAdjacent): Ditto.
      (WebCore::HTMLElement::supportsFocus): Ditto.
      * html/HTMLEmbedElement.cpp:
      (WebCore::HTMLEmbedElement::insertedIntoDocument): Ditto.
      (WebCore::HTMLEmbedElement::attributeChanged): Ditto.
      * html/HTMLTableElement.cpp:
      (WebCore::HTMLTableElement::insertRow): Ditto.
      * html/HTMLTableRowsCollection.cpp: Ditto.
      (WebCore::isInHead): Ditto.
      (WebCore::isInBody): Ditto.
      (WebCore::isInFoot): Ditto.
      (WebCore::HTMLTableRowsCollection::rowAfter): Ditto.
      * html/HTMLViewSourceDocument.cpp:
      (WebCore::HTMLViewSourceDocument::addRange): Ditto.
      * html/MediaDocument.cpp:
      (WebCore::MediaDocument::replaceMediaElementTimerFired): Ditto.
      * html/parser/HTMLConstructionSite.cpp:
      (WebCore::HTMLConstructionSite::attach): Ditto.
      (WebCore::HTMLConstructionSite::findFosterSite): Ditto.
      * html/parser/HTMLTreeBuilder.cpp:
      * page/FocusController.cpp:
      (WebCore::FocusController::findFocusableNodeInDirection): Ditto.
      * rendering/MediaControlElements.cpp:
      (WebCore::MediaControlElement::rendererIsNeeded): Ditto.
      (WebCore::MediaControlElement::attach): Ditto.
      (WebCore::MediaControlElement::updateStyle): Ditto.
      (WebCore::MediaControlInputElement::rendererIsNeeded): Ditto.
      (WebCore::MediaControlInputElement::attach): Ditto.
      (WebCore::MediaControlInputElement::updateStyle): Ditto.
      * rendering/RenderSVGGradientStop.cpp:
      (WebCore::RenderSVGGradientStop::gradientElement): Ditto.
      * svg/SVGAElement.cpp:
      (WebCore::SVGAElement::createRenderer): Ditto.
      (WebCore::SVGAElement::childShouldCreateRenderer): Ditto.
      * svg/SVGFELightElement.cpp:
      (WebCore::SVGFELightElement::svgAttributeChanged): Ditto.
      (WebCore::SVGFELightElement::childrenChanged): Ditto.
      * svg/SVGFEMergeNodeElement.cpp:
      (WebCore::SVGFEMergeNodeElement::svgAttributeChanged): Ditto.
      * svg/SVGLength.cpp:
      (WebCore::SVGLength::determineViewport): Ditto.
      * svg/SVGStyledElement.cpp:
      (WebCore::SVGStyledElement::updateRelativeLengthsInformation): Ditto.
      * svg/SVGUseElement.cpp:
      (WebCore::SVGUseElement::removeDisallowedElementsFromSubtree): Ditto.
      * svg/animation/SVGSMILElement.cpp:
      (WebCore::SVGSMILElement::insertedIntoDocument): Ditto.
      * xml/XPathNodeSet.cpp:
      (WebCore::XPath::NodeSet::sort): Ditto.
      * xml/XPathStep.cpp:
      (WebCore::XPath::Step::nodesInAxis): Ditto.
      * xml/XSLTProcessorLibxslt.cpp:
      (WebCore::xsltStylesheetPointer): Ditto.
      
      WebKit/chromium:
      
      * src/WebFrameImpl.cpp:
      (WebKit::WebFrameImpl::insertStyleText): Changed to use parentNode.
      (WebKit::WebFrameImpl::setFindEndstateFocusAndSelection): Ditto.
      
      WebKit/qt:
      
      * Api/qwebelement.cpp:
      (QWebElement::prependOutside): Changed to use parentNode.
      (QWebElement::appendOutside): Ditto.
      (QWebElement::encloseContentsWith): Ditto.
      (QWebElement::encloseWith): Ditto.
      
      WebKit2:
      
      * WebProcess/WebPage/WebPage.cpp: Changed to use parentNode.
      (WebKit::WebPage::findZoomableAreaForPoint): Ditto.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@72259 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      e43caa78
  27. 26 Oct, 2010 1 commit
    • commit-queue@webkit.org's avatar
      2010-10-26 Mario Sanchez Prada <msanchez@igalia.com> · a9398ddd
      commit-queue@webkit.org authored
              Reviewed by Chris Fleizach.
      
              [Gtk] Layout tables should indicate that they are not data tables via an object attribute
              https://bugs.webkit.org/show_bug.cgi?id=35422
      
              Set the 'layout-guess' attribute to 'true' for data tables.
      
              Reorganized some code in AccessibilityTable so now the function
              isDataTable() is more coherent by just answering that very
              specific question, regardless of whether the table is being
              exposed or not to Assistive Technologies.
      
              Hence, now it's possible to make two questions separately instead
              of just one, meaning that the new function isAccessibleTable() is
              now what we formerly defined as the isDataTable() function.
      
              * accessibility/AccessibilityObject.h:
              (WebCore::AccessibilityObject::isAccessibilityTable):
                 New function to allow asking tables both whether they are
                 exposed and whether they are data tables, which are different
                 questions whose answers might be the same in many situations,
                 but different sometimes (as it can happen in the GTK port).
              * accessibility/AccessibilityTable.h:
              * accessibility/AccessibilityTable.cpp:
              (WebCore::AccessibilityTable::hasARIARole):
                 New, checks whether the table has a valid ARIA role.
              (WebCore::AccessibilityTable::isAccessibilityTable):
                 New, returns the value of m_isAccessibilityTable. It's
                 basically the former isDataTable() function renamed.
              (WebCore::AccessibilityTable::isDataTable):
                 Changed behaviour. Instead of just returning the value of
                 m_isAccessibilityTable as it did so far (which was confusing
                 because of that's not what the name suggests), focus on
                 checking whether it's a data table or not and return a bool
                 value accordingly. It's basically a rename of the former
                 isTableExposableThroughAccessibility() function, but withouth
                 the GTK-specific if-endif region (which didn't make sense
                 here now, because that was answering the question "is the table
                 exposed in the GTK port?", instead of "is it a data table?").
              (WebCore::AccessibilityTable::isTableExposableThroughAccessibility):
                 Uses the hasAriaRole(), and isDataTable() to determine whether
                 a table should be exposed or not. Also includes the GTK-specific
                 if-region coming from the former implementation of the function
                 isTableExposableThroughAccessibility() not to check whether it's
                 a data table in case the rest of the checks succeeded (all
                 tables are exposed in the GTK port).
              (WebCore::AccessibilityTable::addChildren):
                 Replace usage of isDataTable() with isAccessibilityTable(), to
                 keep exactly the same behaviour happening before this patch.
              (WebCore::AccessibilityTable::roleValue): Ditto.
              (WebCore::AccessibilityTable::accessibilityIsIgnored): Ditto.
              (WebCore::AccessibilityTable::title): Ditto.
      
              Updated usage of the former function isDataTable() everywhere
              else, replacing it with the new isAccessibilityTable(), so keeping
              exactly the same behaviour happening before this patch.
      
              * accessibility/AccessibilityARIAGrid.cpp:
              (WebCore::AccessibilityARIAGrid::addChildren):
                 Use isAccessibilityTable() instead of isDataTable().
              * accessibility/AccessibilityARIAGridCell.cpp:
              (WebCore::AccessibilityARIAGridCell::parentTable): Ditto.
              * accessibility/AccessibilityARIAGridRow.cpp:
              (WebCore::AccessibilityARIAGridRow::disclosedRows): Ditto.
              (WebCore::AccessibilityARIAGridRow::disclosedByRow): Ditto.
              (WebCore::AccessibilityARIAGridRow::parentTable): Ditto.
              * accessibility/AccessibilityTableCell.cpp:
              (WebCore::AccessibilityTableCell::isTableCell):
                 Use isAccessibilityTable() instead of isDataTable().
              * accessibility/AccessibilityTableHeaderContainer.cpp:
              (WebCore::AccessibilityTableHeaderContainer::addChildren): Ditto.
              * accessibility/AccessibilityTableRow.cpp:
              (WebCore::AccessibilityTableRow::isTableRow): Ditto
              * accessibility/mac/AccessibilityObjectWrapper.mm:
              (-[AccessibilityObjectWrapper additionalAccessibilityAttributeNames]):
                 Use isAccessibilityTable() instead of isDataTable().
              (-[AccessibilityObjectWrapper accessibilityAttributeNames]): Ditto.
              (-[AccessibilityObjectWrapper accessibilityAttributeValue:]): Ditto.
              (-[AccessibilityObjectWrapper accessibilityParameterizedAttributeNames]): Ditto.
              (-[AccessibilityObjectWrapper accessibilitySetValue:forAttribute:]): Ditto.
              (-[AccessibilityObjectWrapper accessibilityAttributeValue:forParameter:]): Ditto.
      
              Use the new function isAccessibilityTable() together with the
              modified implementation of isDataTable() to set the 'layout-guess'
              attribute when needed.
      
              * accessibility/gtk/AccessibilityObjectWrapperAtk.cpp:
              (webkit_accessible_get_attributes):
                 Set the 'layout-guess' attribute to 'true' to help Assistive
                 Technologies guessing which tables are not data tables.
      2010-10-26  Mario Sanchez Prada  <msanchez@igalia.com>
      
              Reviewed by Chris Fleizach.
      
              [Gtk] Layout tables should indicate that they are not data tables via an object attribute
              https://bugs.webkit.org/show_bug.cgi?id=35422
      
              New unit test to check the 'layout-guess' attribute in tables.
      
              * tests/testatk.c:
              (atkAttributeSetAttributeNameHasValue): New, looks for a attribute
              with a specific value, by the name of attribute.
              (atkAttributeSetContainsAttributeName): New, just checks whether
              an attribute with a specified name is present in the set.
              (atkAttributeSetAttributeHasValue): Modified to relay on the new
              function atkAttributeSetAttributeNameHasValue().
              (testWebkitAtkLayoutAndDataTables): New test.
              (main): Added the new test.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@70554 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      a9398ddd
  28. 29 Sep, 2010 1 commit
    • cfleizach@apple.com's avatar
      AX: implement CSS3 Speech "speak" · edd8483e
      cfleizach@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=46827
      
      Reviewed by Darin Adler.
      
      WebCore: 
      
      Support the "speak" style as defined in
      http://www.w3.org/TR/css3-speech/#speak
      
      This puts all the pieces in place for a platform to support this ability, but there's no platform implementation yet.
      
      Test: platform/mac/accessibility/css-speech-speak.html
      
      * accessibility/AccessibilityObject.h:
      (WebCore::AccessibilityObject::speakProperty):
      * accessibility/AccessibilityRenderObject.cpp:
      (WebCore::AccessibilityRenderObject::speakProperty):
      * accessibility/AccessibilityRenderObject.h:
      * accessibility/mac/AccessibilityObjectWrapper.mm:
      (-[AccessibilityObjectWrapper accessibilityAttributeValue:]):
      * css/CSSComputedStyleDeclaration.cpp:
      (WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):
      * css/CSSPrimitiveValueMappings.h:
      (WebCore::CSSPrimitiveValue::CSSPrimitiveValue):
      (WebCore::CSSPrimitiveValue::operator ESpeak):
      * css/CSSPropertyNames.in:
      * css/CSSStyleSelector.cpp:
      (WebCore::CSSStyleSelector::applyProperty):
      * css/CSSValueKeywords.in:
      * rendering/style/RenderStyle.h:
      (WebCore::InheritedFlags::speak):
      (WebCore::InheritedFlags::setSpeak):
      (WebCore::InheritedFlags::initialSpeak):
      * rendering/style/RenderStyleConstants.h:
      * rendering/style/StyleRareInheritedData.cpp:
      (WebCore::StyleRareInheritedData::StyleRareInheritedData):
      (WebCore::StyleRareInheritedData::operator==):
      * rendering/style/StyleRareInheritedData.h:
      
      WebKitTools: 
      
      * DumpRenderTree/AccessibilityUIElement.cpp:
      (speakCallback):
      (AccessibilityUIElement::speak):
      (AccessibilityUIElement::getJSClass):
      * DumpRenderTree/AccessibilityUIElement.h:
      * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
      (AccessibilityUIElement::speak):
      
      LayoutTests: 
      
      * platform/mac/accessibility/css-speech-speak-expected.txt: Added.
      * platform/mac/accessibility/css-speech-speak.html: Added.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@68680 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      edd8483e
  29. 28 Sep, 2010 1 commit
    • cfleizach@apple.com's avatar
      CrashTracer: 1,382 crashes in Safari at com.apple.WebCore:... · c6d72ecf
      cfleizach@apple.com authored
      CrashTracer: 1,382 crashes in Safari at com.apple.WebCore: WebCore::VisiblePosition::canonicalPosition + 78
      https://bugs.webkit.org/show_bug.cgi?id=45927
      
      Reviewed by Beth Dakin.
      
      WebCore: 
      
      AXTextMarkers store pointers to Nodes without any retain or reference. If a Node is deallocated and then
      a client tries to use a text marker that references that node, it leads to this crash.
      
      The AXObjectCache instance now keeps a HashSet of Node's being used. When a node becomes deallocated, it removes itself
      from the HashSet. When creating a VisiblePosition from an AXTextMarker, the cache can then check if the node is valid
      before proceeding.
      
      Test: platform/mac/accessibility/crash-invalid-text-marker-node.html
      
      * accessibility/AXObjectCache.cpp:
      (WebCore::AXObjectCache::visiblePositionForTextMarkerData):
      (WebCore::AXObjectCache::textMarkerDataForVisiblePosition):
          Modify to check whether a node is valid before proceeeding.
      * accessibility/AXObjectCache.h:
      (WebCore::AXObjectCache::setNodeInUse):
      (WebCore::AXObjectCache::removeNodeForUse):
      (WebCore::AXObjectCache::isNodeInUse):
          Methods for managing whether a node is in use by text markers.
      * accessibility/mac/AccessibilityObjectWrapper.mm:
      (textMarkerForVisiblePosition):
      (-[AccessibilityObjectWrapper textMarkerForVisiblePosition:]):
      (visiblePositionForTextMarker):
      (-[AccessibilityObjectWrapper visiblePositionForTextMarker:]):
      (visiblePositionForStartOfTextMarkerRange):
      (visiblePositionForEndOfTextMarkerRange):
      (-[AccessibilityObjectWrapper doAXAttributedStringForTextMarkerRange:]):
      (textMarkerRangeFromVisiblePositions):
      (-[AccessibilityObjectWrapper textMarkerRangeFromVisiblePositions:endPosition:]):
      (-[AccessibilityObjectWrapper visiblePositionRangeForTextMarkerRange:]):
      (-[AccessibilityObjectWrapper textMarkerRangeForSelection]):
      (-[AccessibilityObjectWrapper accessibilityAttributeValue:]):
      (-[AccessibilityObjectWrapper doAXAttributedStringForRange:]):
      (-[AccessibilityObjectWrapper accessibilityAttributeValue:forParameter:]):
           Change these calls so that the axObjectCache() can be passed in to create the visible position.
      * dom/Document.cpp:
      (WebCore::Document::axObjectCacheExists):
      * dom/Document.h:
      * dom/Node.cpp:
      (WebCore::Node::~Node):
           If accessibility is enabled, inform the axObjectCache() that this node is disappearing.
      
      LayoutTests: 
      
      * platform/mac/accessibility/crash-invalid-text-marker-node-expected.txt: Added.
      * platform/mac/accessibility/crash-invalid-text-marker-node.html: Added.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@68541 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      c6d72ecf
  30. 27 Sep, 2010 1 commit
    • cfleizach@apple.com's avatar
      CrashTracer: 1,803 crashes in Safari at com.apple.WebCore:... · b38d055e
      cfleizach@apple.com authored
      CrashTracer: 1,803 crashes in Safari at com.apple.WebCore: -[AccessibilityObjectWrapper accessibilityIsIgnored] + 56
      https://bugs.webkit.org/show_bug.cgi?id=46662
      
      Reviewed by Beth Dakin.
      
      WebCore: 
      
      Before calling updateBackingStore(), the wrapper object needs to be retained, lest it be invalidated during
      the updateBackingStore call. This consolidates all calls to updateBackingStore().
      
      Test: platform/mac/accessibility/removing-textarea-after-edit-crash.html
      
      * accessibility/mac/AXObjectCacheMac.mm:
      (WebCore::AXObjectCache::postPlatformNotification):
          Use an ASSERT here to catch the crash because DRT won't cause AppKit to post notifications.
      * accessibility/mac/AccessibilityObjectWrapper.mm:
      (-[AccessibilityObjectWrapper prepareAccessibilityMethod]):
      (-[AccessibilityObjectWrapper accessibilityActionNames]):
      (-[AccessibilityObjectWrapper accessibilityAttributeNames]):
      (-[AccessibilityObjectWrapper accessibilityAttributeValue:]):
      (-[AccessibilityObjectWrapper accessibilityFocusedUIElement]):
      (-[AccessibilityObjectWrapper accessibilityHitTest:]):
      (-[AccessibilityObjectWrapper accessibilityIsAttributeSettable:]):
      (-[AccessibilityObjectWrapper accessibilityIsIgnored]):
      (-[AccessibilityObjectWrapper accessibilityParameterizedAttributeNames]):
      (-[AccessibilityObjectWrapper accessibilityPerformPressAction]):
      (-[AccessibilityObjectWrapper accessibilityPerformIncrementAction]):
      (-[AccessibilityObjectWrapper accessibilityPerformDecrementAction]):
      (-[AccessibilityObjectWrapper accessibilityPerformAction:]):
      (-[AccessibilityObjectWrapper accessibilitySetValue:forAttribute:]):
      (-[AccessibilityObjectWrapper accessibilityAttributeValue:forParameter:]):
      (-[AccessibilityObjectWrapper accessibilityIndexOfChild:]):
      (-[AccessibilityObjectWrapper accessibilityArrayAttributeCount:]):
      (-[AccessibilityObjectWrapper accessibilityArrayAttributeValues:index:maxCount:]):
      
      LayoutTests: 
      
      * platform/mac/accessibility/removing-textarea-after-edit-crash-expected.txt: Added.
      * platform/mac/accessibility/removing-textarea-after-edit-crash.html: Added.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@68461 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      b38d055e
  31. 13 Sep, 2010 1 commit
    • cfleizach@apple.com's avatar
      AX: accessibilityIsIgnored is returning nil when return value expects a BOOL · 9403f0c0
      cfleizach@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=45548
      
      Reviewed by David Kilzer.
      
      WebCore: 
      
      Test: platform/mac/accessibility/element-is-ignored.html
      
      * accessibility/mac/AccessibilityObjectWrapper.mm:
      (-[AccessibilityObjectWrapper accessibilityIsIgnored]):
      
      WebKitTools: 
      
      * DumpRenderTree/AccessibilityUIElement.cpp:
      (isIgnoredCallback):
      (AccessibilityUIElement::getJSClass):
      * DumpRenderTree/AccessibilityUIElement.h:
      * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
      (AccessibilityUIElement::isIgnored):
      * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
      (AccessibilityUIElement::isIgnored):
      * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
      (AccessibilityUIElement::isIgnored):
      
      LayoutTests: 
      
      * platform/mac/accessibility/element-is-ignored-expected.txt: Added.
      * platform/mac/accessibility/element-is-ignored.html: Added.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@67408 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      9403f0c0
  32. 10 Sep, 2010 1 commit
  33. 09 Sep, 2010 1 commit
    • cfleizach@apple.com's avatar
      AX: Support AccessibilityTextMarkers in DRT · b60fc942
      cfleizach@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=44778
      
      Reviewed by David Kilzer.
      
      WebCore: 
      
      Provide support in DRT for accessing and manipulating the text marker system that AX exposes.
      This will allow future bug fixes in the text marker system to be adequately tested.
      
      Tests: platform/mac/accessibility/element-for-text-marker.html
             platform/mac/accessibility/text-marker-length.html
      
      * accessibility/mac/AccessibilityObjectWrapper.mm:
      (-[AccessibilityObjectWrapper accessibilityAttributeValue:forParameter:]):
      
      WebKitTools: 
      
      Add AccessibilityTextMarker and AccessibilityTextMarkerRange which encapsulate the AXTextMarkers 
      that WebCore uses when vending information about its VisiblePositions through AX.
      
      There are a few new methods in AccessibilityUIElement to retrieve and use text markers, and some basic
      methods for encapsulating and checking equality.
      
      This will allow future bug fixes in the text marker system to be adequately tested.
      
      * DumpRenderTree/AccessibilityTextMarker.cpp: Added.
      (toTextMarker):
      (isMarkerEqualCallback):
      (markerFinalize):
      (AccessibilityTextMarker::makeJSAccessibilityTextMarker):
      (AccessibilityTextMarker::getJSClass):
      (toTextMarkerRange):
      (isMarkerRangeEqualCallback):
      (markerRangeFinalize):
      (AccessibilityTextMarkerRange::makeJSAccessibilityTextMarkerRange):
      (AccessibilityTextMarkerRange::getJSClass):
      * DumpRenderTree/AccessibilityTextMarker.h: Added.
      (AccessibilityTextMarker::platformTextMarker):
      (AccessibilityTextMarkerRange::platformTextMarkerRange):
      (AccessibilityTextMarker::AccessibilityTextMarker):
      (AccessibilityTextMarker::~AccessibilityTextMarker):
      (AccessibilityTextMarker::isEqual):
      (AccessibilityTextMarkerRange::AccessibilityTextMarkerRange):
      (AccessibilityTextMarkerRange::~AccessibilityTextMarkerRange):
      (AccessibilityTextMarkerRange::isEqual):
      * DumpRenderTree/AccessibilityUIElement.cpp:
      (textMarkerRangeForElementCallback):
      (textMarkerRangeLengthCallback):
      (textMarkerRangeForMarkersCallback):
      (startTextMarkerForTextMarkerRangeCallback):
      (endTextMarkerForTextMarkerRangeCallback):
      (accessibilityElementForTextMarkerCallback):
      (AccessibilityUIElement::textMarkerRangeForElement):
      (AccessibilityUIElement::textMarkerRangeLength):
      (AccessibilityUIElement::startTextMarkerForTextMarkerRange):
      (AccessibilityUIElement::endTextMarkerForTextMarkerRange):
      (AccessibilityUIElement::accessibilityElementForTextMarker):
      (AccessibilityUIElement::getJSClass):
      * DumpRenderTree/AccessibilityUIElement.h:
      * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
      * DumpRenderTree/mac/AccessibilityTextMarkerMac.mm: Added.
      (AccessibilityTextMarker::AccessibilityTextMarker):
      (AccessibilityTextMarker::~AccessibilityTextMarker):
      (AccessibilityTextMarker::isEqual):
      (AccessibilityTextMarkerRange::AccessibilityTextMarkerRange):
      (AccessibilityTextMarkerRange::~AccessibilityTextMarkerRange):
      (AccessibilityTextMarkerRange::isEqual):
      * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
      (AccessibilityUIElement::textMarkerRangeForElement):
      (AccessibilityUIElement::textMarkerRangeLength):
      (AccessibilityUIElement::textMarkerRangeForMarkers):
      (AccessibilityUIElement::startTextMarkerForTextMarkerRange):
      (AccessibilityUIElement::endTextMarkerForTextMarkerRange):
      (AccessibilityUIElement::accessibilityElementForTextMarker):
      * DumpRenderTree/win/DumpRenderTree.vcproj:
      
      LayoutTests: 
      
      Add basic text marker tests to validate functions are working.
      
      * platform/mac/accessibility/element-for-text-marker-expected.txt: Added.
      * platform/mac/accessibility/element-for-text-marker.html: Added.
      * platform/mac/accessibility/text-marker-length-expected.txt: Added.
      * platform/mac/accessibility/text-marker-length.html: Added.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@67095 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      b60fc942
  34. 09 Aug, 2010 1 commit
  35. 27 Jul, 2010 1 commit
    • cfleizach@apple.com's avatar
      AX: Misspellings not shown in AXAttributedStringForTextMarkerRange when selection is on word · 75c49bbf
      cfleizach@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=41817
      
      Reviewed by David Kilzer.
      
      WebCore: 
      
      Change how misspelled words are identified for accessibility. No longer rely on the 
      cached markers in Document. Calculate on the fly, which is more accurate in a variety of 
      circumstances (like when selection has not moved across words, of if the cursor is in the middle
      of a misspelled word). 
      
      Test: platform/mac/accessibility/attributed-string-includes-misspelled-with-selection.html
      
      * accessibility/mac/AccessibilityObjectWrapper.mm:
      (AXAttributeStringSetSpelling):
      (AXAttributedStringAppendText):
      (-[AccessibilityObjectWrapper doAXAttributedStringForTextMarkerRange:]):
      
      LayoutTests: 
      
      * platform/mac/accessibility/attributed-string-includes-misspelled-with-selection-expected.txt: Added.
      * platform/mac/accessibility/attributed-string-includes-misspelled-with-selection.html: Added.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@64149 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      75c49bbf
  36. 26 Jul, 2010 1 commit
    • cfleizach@apple.com's avatar
      AX: Safari does not support ARIA mixed checkboxes · 4186694d
      cfleizach@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=43016
      
      Reviewed by Darin Adler.
      
      WebCore: 
      
      Test: platform/mac/accessibility/mixed-checkbox.html
      
      * accessibility/AccessibilityObject.cpp:
      (WebCore::AccessibilityObject::checkboxOrRadioValue):
      * accessibility/AccessibilityObject.h:
      * accessibility/AccessibilityRenderObject.cpp:
      (WebCore::AccessibilityRenderObject::isNativeCheckboxOrRadio):
      (WebCore::AccessibilityRenderObject::checkboxOrRadioValue):
      * accessibility/AccessibilityRenderObject.h:
      * accessibility/mac/AccessibilityObjectWrapper.mm:
      (-[AccessibilityObjectWrapper accessibilityAttributeValue:]):
      
      LayoutTests: 
      
      * platform/mac/accessibility/mixed-checkbox-expected.txt: Added.
      * platform/mac/accessibility/mixed-checkbox.html: Added.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@64088 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      4186694d