1. 12 May, 2011 1 commit
    • tonyg@chromium.org's avatar
      2011-05-10 Tony Gentilcore <tonyg@chromium.org> · 4b0a55f4
      tonyg@chromium.org authored
              Reviewed by Darin Adler.
      
              Perform some forward declarations suggested by include-what-you-use
              https://bugs.webkit.org/show_bug.cgi?id=60545
      
              * accessibility/AccessibilityObject.cpp:
              * accessibility/AccessibilityRenderObject.cpp:
              * accessibility/mac/AccessibilityObjectWrapper.mm:
              * dom/DocumentMarkerController.cpp:
              * dom/Position.cpp:
              * dom/PositionIterator.cpp:
              * dom/Range.cpp:
              * editing/ApplyBlockElementCommand.cpp:
              * editing/ApplyStyleCommand.cpp:
              * editing/Editor.cpp:
              * editing/EditorCommand.cpp:
              * editing/FrameSelection.cpp:
              * editing/HTMLInterchange.cpp:
              * editing/IndentOutdentCommand.cpp:
              * editing/ReplaceSelectionCommand.cpp:
              * editing/SpellChecker.h:
              * editing/SpellingCorrectionCommand.cpp:
              * editing/SpellingCorrectionController.h:
              * editing/TextCheckingHelper.cpp:
              * editing/TextIterator.h:
              * editing/htmlediting.h:
              * editing/markup.cpp:
              * editing/visible_units.cpp:
              * editing/visible_units.h:
              * fileapi/DOMFileSystem.cpp:
              * fileapi/DirectoryReaderSync.cpp:
              * fileapi/DirectoryReaderSync.h:
              * fileapi/FileEntry.h:
              * fileapi/FileWriter.h:
              * fileapi/FileWriterBase.h:
              * fileapi/FileWriterSync.h:
              * history/CachedFrame.cpp:
              * history/CachedPage.cpp:
              * history/HistoryItem.cpp:
              * history/HistoryItem.h:
              * history/PageCache.h:
              * loader/HistoryController.h:
              * loader/PingLoader.h:
              * loader/ResourceLoader.h:
              * loader/appcache/DOMApplicationCache.h:
              * loader/cache/CachedCSSStyleSheet.h:
              * loader/cache/CachedFont.cpp:
              * loader/cache/CachedFont.h:
              * loader/cache/CachedResourceRequest.cpp:
              * loader/cache/CachedResourceRequest.h:
              * loader/cache/MemoryCache.h:
              * notifications/Notification.cpp:
              * notifications/Notification.h:
              * notifications/NotificationCenter.cpp:
              * notifications/NotificationCenter.h:
              * page/Chrome.cpp:
              * page/Chrome.h:
              * page/DOMSelection.cpp:
              * page/DOMTimer.h:
              * page/DOMWindow.cpp:
              * page/EventHandler.cpp:
              * page/FocusController.h:
              * page/Geolocation.cpp:
              * page/Geolocation.h:
              * page/History.cpp:
              * rendering/RenderListBox.cpp:
              * workers/WorkerContext.cpp:
      2011-05-10  Tony Gentilcore  <tonyg@chromium.org>
      
              Reviewed by Darin Adler.
      
              Perform some forward declarations suggested by include-what-you-use
              https://bugs.webkit.org/show_bug.cgi?id=60545
      
              * src/WebHistoryItem.cpp:
              * src/WebNotification.cpp:
              * src/WebTextCheckingCompletionImpl.cpp:
              * src/mac/WebSubstringUtil.mm:
      2011-05-10  Tony Gentilcore  <tonyg@chromium.org>
      
              Reviewed by Darin Adler.
      
              Perform some forward declarations suggested by include-what-you-use
              https://bugs.webkit.org/show_bug.cgi?id=60545
      
              * Plugins/Hosted/WebHostedNetscapePluginView.mm:
              * WebView/WebFrame.mm:
      2011-05-10  Tony Gentilcore  <tonyg@chromium.org>
      
              Reviewed by Darin Adler.
      
              Perform some forward declarations suggested by include-what-you-use
              https://bugs.webkit.org/show_bug.cgi?id=60545
      
              * WebProcess/WebPage/mac/WebPageMac.mm:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@86325 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      4b0a55f4
  2. 05 May, 2011 1 commit
    • rniwa@webkit.org's avatar
      2011-05-05 Ryosuke Niwa <rniwa@webkit.org> · 78bbc94c
      rniwa@webkit.org authored
              Reviewed by Eric Seidel.
      
              Rename SelectionController to FrameSelection
              https://bugs.webkit.org/show_bug.cgi?id=60234
      
              * src/WebFrameImpl.cpp:
              (WebKit::WebFrameImpl::selectWordAroundCaret):
              * src/WebViewImpl.cpp:
              (WebKit::WebViewImpl::textInputType):
              (WebKit::WebViewImpl::caretOrSelectionBounds):
              (WebKit::WebViewImpl::caretOrSelectionRange):
              (WebKit::WebViewImpl::clearFocusedNode):
      2011-05-05  Ryosuke Niwa  <rniwa@webkit.org>
      
              Reviewed by Eric Seidel.
      
              Rename SelectionController to FrameSelection
              https://bugs.webkit.org/show_bug.cgi?id=60234
      
              * Api/qwebframe.cpp:
      2011-05-05  Ryosuke Niwa  <rniwa@webkit.org>
      
              Reviewed by Eric Seidel.
      
              Rename SelectionController to FrameSelection
              https://bugs.webkit.org/show_bug.cgi?id=60234
      
              * webkit/webkitwebview.cpp:
              (getLocationForKeyboardGeneratedContextMenu):
      2011-05-05  Ryosuke Niwa  <rniwa@webkit.org>
      
              Reviewed by Eric Seidel.
      
              Rename SelectionController to FrameSelection
              https://bugs.webkit.org/show_bug.cgi?id=60234
      
              * WebView.cpp:
      2011-05-05  Ryosuke Niwa  <rniwa@webkit.org>
      
              Reviewed by Eric Seidel.
      
              Rename SelectionController to FrameSelection
              https://bugs.webkit.org/show_bug.cgi?id=60234
      
              * WebDOMSelection.cpp:
              * WebDOMSelection.h:
              * WebKitSupport/EditorClientWx.cpp:
              * WebView.cpp:
      2011-05-05  Ryosuke Niwa  <rniwa@webkit.org>
      
              Reviewed by Eric Seidel.
      
              Rename SelectionController to FrameSelection
              https://bugs.webkit.org/show_bug.cgi?id=60234
      
              * WebView/WebFrame.mm:
              (-[WebFrame _rangeByAlteringCurrentSelection:FrameSelection::direction:granularity:]):
              * WebView/WebFrameInternal.h:
              * WebView/WebHTMLView.mm:
              * WebView/WebTextCompletionController.mm:
              (-[WebTextCompletionController doCompletion]):
              * WebView/WebView.mm:
      2011-05-05  Ryosuke Niwa  <rniwa@webkit.org>
      
              Reviewed by Eric Seidel.
      
              Rename SelectionController to FrameSelection
              https://bugs.webkit.org/show_bug.cgi?id=60234
      
              * WebCoreSupport/EditorClientHaiku.cpp:
              (WebCore::EditorClientHaiku::handleKeyboardEvent):
      2011-05-05  Ryosuke Niwa  <rniwa@webkit.org>
      
              Reviewed by Eric Seidel.
      
              Rename SelectionController to FrameSelection
              https://bugs.webkit.org/show_bug.cgi?id=60234
      
              * WebCoreSupport/EditorClientWinCE.cpp:
              (WebKit::EditorClientWinCE::handleEditingKeyboardEvent):
      2011-05-05  Ryosuke Niwa  <rniwa@webkit.org>
      
              Reviewed by Eric Seidel.
      
              Rename SelectionController to FrameSelection
              https://bugs.webkit.org/show_bug.cgi?id=60234
      
              * WebCoreSupport/EditorClientEfl.cpp:
              (WebCore::EditorClientEfl::handleEditingKeyboardEvent):
      2011-05-05  Ryosuke Niwa  <rniwa@webkit.org>
      
              Reviewed by Eric Seidel.
      
              Rename SelectionController to FrameSelection
              https://bugs.webkit.org/show_bug.cgi?id=60234
      
              * CMakeLists.txt:
              * GNUmakefile.list.am:
              * WebCore.exp.in:
              * WebCore.gypi:
              * WebCore.pro:
              * WebCore.vcproj/WebCore.vcproj:
              * WebCore.xcodeproj/project.pbxproj:
              * accessibility/AccessibilityObject.cpp:
              * accessibility/AccessibilityRenderObject.cpp:
              (WebCore::AccessibilityRenderObject::visiblePositionRangeForLine):
              * accessibility/mac/AccessibilityObjectWrapper.mm:
              * bindings/objc/ExceptionHandlers.h:
              * css/CSSStyleSelector.cpp:
              * dom/ContainerNode.cpp:
              (WebCore::ContainerNode::cloneChildNodes):
              * dom/Document.cpp:
              * dom/InputElement.cpp:
              * editing/DeleteButtonController.cpp:
              * editing/EditCommand.cpp:
              * editing/EditingAllInOne.cpp:
              * editing/EditingStyle.cpp:
              * editing/Editor.cpp:
              (WebCore::Editor::canCopy):
              (WebCore::Editor::canDelete):
              (WebCore::Editor::markMisspellingsAfterTypingToWord):
              (WebCore::Editor::markAllMisspellingsAndBadGrammarInRanges):
              (WebCore::Editor::changeSelectionAfterCommand):
              (WebCore::Editor::respondToChangedSelection):
              * editing/Editor.h:
              * editing/EditorCommand.cpp:
              (WebCore::executeDeleteToMark):
              (WebCore::executeMoveBackward):
              (WebCore::executeMoveBackwardAndModifySelection):
              (WebCore::executeMoveDown):
              (WebCore::executeMoveDownAndModifySelection):
              (WebCore::executeMoveForward):
              (WebCore::executeMoveForwardAndModifySelection):
              (WebCore::executeMoveLeft):
              (WebCore::executeMoveLeftAndModifySelection):
              (WebCore::executeMovePageDown):
              (WebCore::executeMovePageDownAndModifySelection):
              (WebCore::executeMovePageUp):
              (WebCore::executeMovePageUpAndModifySelection):
              (WebCore::executeMoveRight):
              (WebCore::executeMoveRightAndModifySelection):
              (WebCore::executeMoveToBeginningOfDocument):
              (WebCore::executeMoveToBeginningOfDocumentAndModifySelection):
              (WebCore::executeMoveToBeginningOfLine):
              (WebCore::executeMoveToBeginningOfLineAndModifySelection):
              (WebCore::executeMoveToBeginningOfParagraph):
              (WebCore::executeMoveToBeginningOfParagraphAndModifySelection):
              (WebCore::executeMoveToBeginningOfSentence):
              (WebCore::executeMoveToBeginningOfSentenceAndModifySelection):
              (WebCore::executeMoveToEndOfDocument):
              (WebCore::executeMoveToEndOfDocumentAndModifySelection):
              (WebCore::executeMoveToEndOfSentence):
              (WebCore::executeMoveToEndOfSentenceAndModifySelection):
              (WebCore::executeMoveToEndOfLine):
              (WebCore::executeMoveToEndOfLineAndModifySelection):
              (WebCore::executeMoveToEndOfParagraph):
              (WebCore::executeMoveToEndOfParagraphAndModifySelection):
              (WebCore::executeMoveParagraphBackwardAndModifySelection):
              (WebCore::executeMoveParagraphForwardAndModifySelection):
              (WebCore::executeMoveUp):
              (WebCore::executeMoveUpAndModifySelection):
              (WebCore::executeMoveWordBackward):
              (WebCore::executeMoveWordBackwardAndModifySelection):
              (WebCore::executeMoveWordForward):
              (WebCore::executeMoveWordForwardAndModifySelection):
              (WebCore::executeMoveWordLeft):
              (WebCore::executeMoveWordLeftAndModifySelection):
              (WebCore::executeMoveWordRight):
              (WebCore::executeMoveWordRightAndModifySelection):
              (WebCore::executeMoveToLeftEndOfLine):
              (WebCore::executeMoveToLeftEndOfLineAndModifySelection):
              (WebCore::executeMoveToRightEndOfLine):
              (WebCore::executeMoveToRightEndOfLineAndModifySelection):
              * editing/FrameSelection.cpp: Copied from Source/WebCore/editing/SelectionController.cpp.
              (WebCore::FrameSelection::FrameSelection):
              (WebCore::FrameSelection::moveTo):
              (WebCore::FrameSelection::setSelection):
              (WebCore::FrameSelection::nodeWillBeRemoved):
              (WebCore::FrameSelection::respondToNodeModification):
              (WebCore::FrameSelection::textWillBeReplaced):
              (WebCore::FrameSelection::setIsDirectional):
              (WebCore::FrameSelection::directionOfEnclosingBlock):
              (WebCore::FrameSelection::willBeModified):
              (WebCore::FrameSelection::positionForPlatform):
              (WebCore::FrameSelection::startForPlatform):
              (WebCore::FrameSelection::endForPlatform):
              (WebCore::FrameSelection::modifyExtendingRight):
              (WebCore::FrameSelection::modifyExtendingForward):
              (WebCore::FrameSelection::modifyMovingRight):
              (WebCore::FrameSelection::modifyMovingForward):
              (WebCore::FrameSelection::modifyExtendingLeft):
              (WebCore::FrameSelection::modifyExtendingBackward):
              (WebCore::FrameSelection::modifyMovingLeft):
              (WebCore::FrameSelection::modifyMovingBackward):
              (WebCore::FrameSelection::modify):
              (WebCore::FrameSelection::xPosForVerticalArrowNavigation):
              (WebCore::FrameSelection::clear):
              (WebCore::FrameSelection::setStart):
              (WebCore::FrameSelection::setEnd):
              (WebCore::FrameSelection::setBase):
              (WebCore::FrameSelection::setExtent):
              (WebCore::FrameSelection::setCaretRectNeedsUpdate):
              (WebCore::FrameSelection::updateCaretRect):
              (WebCore::FrameSelection::caretRenderer):
              (WebCore::FrameSelection::localCaretRect):
              (WebCore::FrameSelection::absoluteBoundsForLocalRect):
              (WebCore::FrameSelection::absoluteCaretBounds):
              (WebCore::FrameSelection::caretRepaintRect):
              (WebCore::FrameSelection::recomputeCaretRect):
              (WebCore::FrameSelection::shouldRepaintCaret):
              (WebCore::FrameSelection::invalidateCaretRect):
              (WebCore::FrameSelection::paintCaret):
              (WebCore::FrameSelection::debugRenderer):
              (WebCore::FrameSelection::contains):
              (WebCore::FrameSelection::selectFrameElementInParentIfFullySelected):
              (WebCore::FrameSelection::selectAll):
              (WebCore::FrameSelection::setSelectedRange):
              (WebCore::FrameSelection::isInPasswordField):
              (WebCore::FrameSelection::caretRendersInsideNode):
              (WebCore::FrameSelection::focusedOrActiveStateChanged):
              (WebCore::FrameSelection::pageActivationChanged):
              (WebCore::FrameSelection::updateSecureKeyboardEntryIfActive):
              (WebCore::FrameSelection::setUseSecureKeyboardEntry):
              (WebCore::FrameSelection::setFocused):
              (WebCore::FrameSelection::isFocusedAndActive):
              (WebCore::FrameSelection::updateAppearance):
              (WebCore::FrameSelection::setCaretVisible):
              (WebCore::FrameSelection::clearCaretRectIfNeeded):
              (WebCore::FrameSelection::caretBlinkTimerFired):
              (WebCore::FrameSelection::notifyRendererOfSelectionChange):
              (WebCore::FrameSelection::setFocusedNodeIfNeeded):
              (WebCore::FrameSelection::paintDragCaret):
              (WebCore::FrameSelection::copyTypingStyle):
              (WebCore::FrameSelection::shouldDeleteSelection):
              (WebCore::FrameSelection::bounds):
              (WebCore::FrameSelection::getClippedVisibleTextRectangles):
              (WebCore::FrameSelection::currentForm):
              (WebCore::FrameSelection::revealSelection):
              (WebCore::FrameSelection::setSelectionFromNone):
              (WebCore::FrameSelection::shouldChangeSelection):
              (WebCore::FrameSelection::formatForDebugger):
              (WebCore::FrameSelection::showTreeForThis):
              (showTree):
              * editing/FrameSelection.h: Copied from Source/WebCore/editing/SelectionController.h.
              (WebCore::FrameSelection::typingStyle):
              (WebCore::FrameSelection::clearTypingStyle):
              (WebCore::FrameSelection::setTypingStyle):
              (WebCore::FrameSelection::notifyAccessibilityForSelectionChange):
              * editing/ModifySelectionListLevel.cpp:
              * editing/RemoveFormatCommand.cpp:
              * editing/ReplaceSelectionCommand.cpp:
              * editing/SelectionController.cpp: Removed.
              * editing/SelectionController.h: Removed.
              * editing/SetSelectionCommand.cpp:
              (WebCore::SetSelectionCommand::SetSelectionCommand):
              (WebCore::SetSelectionCommand::doApply):
              (WebCore::SetSelectionCommand::doUnapply):
              * editing/SetSelectionCommand.h:
              (WebCore::SetSelectionCommand::create):
              * editing/SpellingCorrectionCommand.cpp:
              (WebCore::SpellingCorrectionCommand::doApply):
              * editing/SpellingCorrectionController.cpp:
              (WebCore::SpellingCorrectionController::respondToUnappliedSpellCorrection):
              * editing/TypingCommand.cpp:
              (WebCore::TypingCommand::deleteKeyPressed):
              (WebCore::TypingCommand::forwardDeleteKeyPressed):
              * editing/chromium/FrameSelectionChromium.cpp: Copied from Source/WebCore/editing/chromium/SelectionControllerChromium.cpp.
              (WebCore::FrameSelection::notifyAccessibilityForSelectionChange):
              * editing/chromium/SelectionControllerChromium.cpp: Removed.
              * editing/gtk/FrameSelectionGtk.cpp: Copied from Source/WebCore/editing/gtk/SelectionControllerGtk.cpp.
              (WebCore::FrameSelection::notifyAccessibilityForSelectionChange):
              * editing/gtk/SelectionControllerGtk.cpp: Removed.
              * editing/mac/EditorMac.mm:
              (WebCore::Editor::canCopyExcludingStandaloneImages):
              * editing/mac/FrameSelectionMac.mm: Copied from Source/WebCore/editing/mac/SelectionControllerMac.mm.
              (WebCore::FrameSelection::notifyAccessibilityForSelectionChange):
              * editing/mac/SelectionControllerMac.mm: Removed.
              * editing/qt/EditorQt.cpp:
              * loader/archive/cf/LegacyWebArchive.cpp:
              * page/ContextMenuController.cpp:
              (WebCore::ContextMenuController::populate):
              * page/DOMSelection.cpp:
              (WebCore::DOMSelection::type):
              (WebCore::DOMSelection::modify):
              (WebCore::DOMSelection::addRange):
              (WebCore::DOMSelection::deleteFromDocument):
              (WebCore::DOMSelection::containsNode):
              * page/DragController.cpp:
              (WebCore::DragController::dragIsMove):
              * page/DragController.h:
              * page/EventHandler.cpp:
              (WebCore::setSelectionIfNeeded):
              (WebCore::setNonDirectionalSelectionIfNeeded):
              (WebCore::EventHandler::sendContextMenuEventForKey):
              (WebCore::EventHandler::handleKeyboardSelectionMovement):
              * page/EventHandler.h:
              * page/FocusController.cpp:
              (WebCore::clearSelectionIfNeeded):
              * page/Frame.cpp:
              (WebCore::Frame::Frame):
              * page/Frame.h:
              (WebCore::Frame::selection):
              * page/Page.cpp:
              (WebCore::Page::Page):
              * page/Page.h:
              (WebCore::Page::dragCaretController):
              * page/chromium/DragControllerChromium.cpp:
              * page/chromium/EventHandlerChromium.cpp:
              * page/win/DragControllerWin.cpp:
              * page/win/EventHandlerWin.cpp:
              * rendering/HitTestResult.cpp:
              * rendering/RenderBlock.cpp:
              (WebCore::RenderBlock::destroy):
              (WebCore::RenderBlock::paintCaret):
              * rendering/RenderImage.cpp:
              * rendering/RenderInline.cpp:
              (WebCore::RenderInline::destroy):
              * rendering/RenderLayer.cpp:
              * rendering/RenderListBox.cpp:
              * rendering/RenderObjectChildList.cpp:
              (WebCore::RenderObjectChildList::removeChildNode):
              * rendering/RenderTextControl.cpp:
              * rendering/RenderTextControlSingleLine.cpp:
              * rendering/RenderTheme.cpp:
              * rendering/RenderTreeAsText.cpp:
              * svg/SVGSVGElement.cpp:
              * svg/SVGTextContentElement.cpp:
              (WebCore::SVGTextContentElement::selectSubString):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@85864 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      78bbc94c
  3. 27 Apr, 2011 1 commit
  4. 05 Apr, 2011 1 commit
  5. 01 Mar, 2011 1 commit
    • leviw@chromium.org's avatar
      2011-03-01 Levi Weintraub <leviw@chromium.org> · ca40abff
      leviw@chromium.org authored
              Reviewed by Ryosuke Niwa.
      
              Stop instantiating legacy editing Positions in VisiblePosition
              https://bugs.webkit.org/show_bug.cgi?id=52919
      
              Changing usage of legacy VisiblePosition constructor. Since we were dealing
              with positions from DOM Ranges, we're guaranteed a parent-anchored position.
      
              * WebView/WebFrame.mm:
              (-[WebFrame _caretRectAtPosition:affinity:]):
              * WebView/WebFrameInternal.h:
              * WebView/WebTextCompletionController.mm:
              (-[WebTextCompletionController doCompletion]):
      2011-03-01  Levi Weintraub  <leviw@chromium.org>
      
              Reviewed by Ryosuke Niwa.
      
              Stop instantiating legacy editing Positions in VisiblePosition
              https://bugs.webkit.org/show_bug.cgi?id=52919
      
              Changing VisiblePosition completely away from legacy positions.
      
              No new tests since this is functionaly equivalent.
      
              * WebCore.exp.in: Removing the legacy VisiblePosition constructor and
              adding the PositionIsOffsetInAnchor symbol. If we must create VisiblePositions
              outside of WebCore, they should be parent anchored.
              * accessibility/AXObjectCache.cpp:
              (WebCore::AXObjectCache::visiblePositionForTextMarkerData):
              * accessibility/AccessibilityObject.cpp:
              (WebCore::startOfStyleRange):
              (WebCore::endOfStyleRange):
              * accessibility/AccessibilityRenderObject.cpp:
              (WebCore::AccessibilityRenderObject::visiblePositionForIndex):
              * accessibility/gtk/AccessibilityObjectWrapperAtk.cpp:
              (objectAndOffsetUnignored):
              * dom/Position.cpp:
              (WebCore::Position::document): Added this inline function to avoid the necessity
              of calling anchorNode to assure a document from a Position.
              (WebCore::Position::upstream): Fixed to correctly respect PositionIsAfterAnchor
              (WebCore::Position::downstream): ditto
              * dom/Range.cpp:
              (WebCore::Range::editingStartPosition):
              * editing/Editor.cpp:
              (WebCore::Editor::canDeleteRange):
              * editing/ReplaceSelectionCommand.cpp:
              (WebCore::ReplaceSelectionCommand::doApply):
              * editing/SelectionController.cpp:
              (WebCore::SelectionController::selectFrameElementInParentIfFullySelected):
              (WebCore::SelectionController::setSelectedRange):
              * editing/TextIterator.cpp:
              (WebCore::TextIterator::shouldRepresentNodeOffsetZero):
              * editing/TypingCommand.cpp:
              (WebCore::TypingCommand::deleteKeyPressed):
              * editing/VisiblePosition.cpp:
              (WebCore::VisiblePosition::leftVisuallyDistinctCandidate):
              (WebCore::VisiblePosition::rightVisuallyDistinctCandidate):
              (WebCore::VisiblePosition::canonicalPosition):
              (WebCore::VisiblePosition::characterAfter):
              (WebCore::VisiblePosition::localCaretRect):
              (WebCore::makeRange):
              (WebCore::startVisiblePosition):
              (WebCore::endVisiblePosition):
              (WebCore::setStart):
              (WebCore::setEnd):
              (WebCore::isFirstVisiblePositionInNode):
              (WebCore::isLastVisiblePositionInNode):
              * editing/VisiblePosition.h:
              (WebCore::VisiblePosition::VisiblePosition):
              * editing/htmlediting.cpp:
              (WebCore::firstInSpecialElement):
              (WebCore::lastInSpecialElement):
              (WebCore::visiblePositionBeforeNode):
              (WebCore::visiblePositionAfterNode):
              * editing/visible_units.cpp:
              (WebCore::startPositionForLine):
              (WebCore::endPositionForLine):
              (WebCore::previousLinePosition):
              (WebCore::nextLinePosition):
              (WebCore::startOfParagraph):
              (WebCore::endOfParagraph):
              (WebCore::endOfBlock):
              (WebCore::startOfDocument):
              (WebCore::endOfDocument):
              (WebCore::logicalStartPositionForLine):
              (WebCore::logicalEndPositionForLine):
              * page/DOMSelection.cpp:
              (WebCore::DOMSelection::collapse):
              (WebCore::DOMSelection::setBaseAndExtent):
              (WebCore::DOMSelection::setPosition):
              (WebCore::DOMSelection::extend):
              * page/EventHandler.cpp:
              (WebCore::EventHandler::handleMousePressEventSingleClick):
              * rendering/RenderObject.cpp:
              (WebCore::RenderObject::createVisiblePosition):
              * rendering/RenderTextControl.cpp:
              (WebCore::RenderTextControl::visiblePositionForIndex):
              * svg/SVGTextContentElement.cpp:
              (WebCore::SVGTextContentElement::selectSubString):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@80059 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      ca40abff
  6. 21 Feb, 2011 1 commit
    • rniwa@webkit.org's avatar
      2011-02-17 Ryosuke Niwa <rniwa@webkit.org> · 62b16970
      rniwa@webkit.org authored
              Reviewed by Kent Tamura.
      
              Rename Position::node() to Position::deprecatedNode()
              https://bugs.webkit.org/show_bug.cgi?id=54622
      
              Done the rename. All calls to node() are replaced by calls to deprecatedNode().
      
              * src/WebViewImpl.cpp:
              (WebKit::WebViewImpl::setComposition): Check the nullity of startContainer() instead of startPosition()->node().
              (WebKit::WebViewImpl::confirmComposition): Ditto.
              (WebKit::WebViewImpl::textInputType):
              (WebKit::WebViewImpl::caretOrSelectionBounds):
      2011-02-17  Ryosuke Niwa  <rniwa@webkit.org>
      
              Reviewed by Kent Tamura.
      
              Rename Position::node() to Position::deprecatedNode()
              https://bugs.webkit.org/show_bug.cgi?id=54622
      
              Replaced the call to node() by a call to containerNode() because the returned node is
              used to determine whether or not the selected contents are editable and such a check
              must be done against the container node.
      
              * WebCoreSupport/EditorClientQt.cpp:
              (WebCore::EditorClientQt::handleKeyboardEvent):
      2011-02-17  Ryosuke Niwa  <rniwa@webkit.org>
      
              Reviewed by Kent Tamura.
      
              Rename Position::node() to Position::deprecatedNode()
              https://bugs.webkit.org/show_bug.cgi?id=54622
      
              Done the rename. All calls to node() are replaced by calls to deprecatedNode().
      
              * webkit/webkitwebview.cpp:
              (webkit_web_view_popup_menu_handler):
      2011-02-17  Ryosuke Niwa  <rniwa@webkit.org>
      
              Reviewed by Kent Tamura.
      
              Rename Position::node() to Position::deprecatedNode()
              https://bugs.webkit.org/show_bug.cgi?id=54622
      
              * WebView/WebFrame.mm:
              (-[WebFrame _smartDeleteRangeForProposedRange:]):
      2011-02-17  Ryosuke Niwa  <rniwa@webkit.org>
      
              Reviewed by Kent Tamura.
      
              Rename Position::node() to Position::deprecatedNode()
              https://bugs.webkit.org/show_bug.cgi?id=54622
      
              Replaced the call to node() by a call to containerNode() because the returned node is
              used to determine whether or not the selected contents are editable and such a check
              must be done against the container node.
      
              * WebCoreSupport/EditorClientHaiku.cpp:
              (WebCore::EditorClientHaiku::handleKeyboardEvent):
      2011-02-17  Ryosuke Niwa  <rniwa@webkit.org>
      
              Reviewed by Kent Tamura.
      
              Rename Position::node() to Position::deprecatedNode()
              https://bugs.webkit.org/show_bug.cgi?id=54622
      
              Done the rename. All calls to node() are replaced by calls to deprecatedNode() except when
              calls were of the form node()->document() and node()->inDocument() in which case they were
              replaced by anchorNode()->document() and anchorNode()->inDocument() respectively.
      
              * WebCore.exp.in: Added Position::containerNode.
      
              The rest abbreviated for simplicity. Please see svn log.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@79196 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      62b16970
  7. 08 Feb, 2011 2 commits
    • leviw@chromium.org's avatar
      2011-02-08 Sheriff Bot <webkit.review.bot@gmail.com> · 0f9d6132
      leviw@chromium.org authored
              Unreviewed, rolling out r77980.
              http://trac.webkit.org/changeset/77980
              https://bugs.webkit.org/show_bug.cgi?id=54043
      
              "Crashes on Windows and Linux..." (Requested by leviw on
              #webkit).
      
              * WebView/WebFrame.mm:
              (-[WebFrame _caretRectAtNode:offset:affinity:]):
              * WebView/WebFrameInternal.h:
              * WebView/WebTextCompletionController.mm:
              (-[WebTextCompletionController doCompletion]):
      2011-02-08  Sheriff Bot  <webkit.review.bot@gmail.com>
      
              Unreviewed, rolling out r77980.
              http://trac.webkit.org/changeset/77980
              https://bugs.webkit.org/show_bug.cgi?id=54043
      
              "Crashes on Windows and Linux..." (Requested by leviw on
              #webkit).
      
              * WebCore.exp.in:
              * accessibility/AXObjectCache.cpp:
              (WebCore::AXObjectCache::visiblePositionForTextMarkerData):
              * accessibility/AccessibilityObject.cpp:
              (WebCore::startOfStyleRange):
              (WebCore::endOfStyleRange):
              * accessibility/AccessibilityRenderObject.cpp:
              (WebCore::AccessibilityRenderObject::visiblePositionForIndex):
              * accessibility/gtk/AccessibilityObjectWrapperAtk.cpp:
              (objectAndOffsetUnignored):
              * dom/Position.cpp:
              (WebCore::Position::upstream):
              (WebCore::Position::downstream):
              * dom/Range.cpp:
              (WebCore::Range::editingStartPosition):
              * editing/Editor.cpp:
              (WebCore::Editor::canDeleteRange):
              * editing/ReplaceSelectionCommand.cpp:
              (WebCore::ReplaceSelectionCommand::doApply):
              * editing/SelectionController.cpp:
              (WebCore::SelectionController::selectFrameElementInParentIfFullySelected):
              (WebCore::SelectionController::setSelectedRange):
              * editing/TextIterator.cpp:
              (WebCore::TextIterator::shouldRepresentNodeOffsetZero):
              * editing/TypingCommand.cpp:
              (WebCore::TypingCommand::deleteKeyPressed):
              * editing/VisiblePosition.cpp:
              (WebCore::VisiblePosition::VisiblePosition):
              (WebCore::VisiblePosition::leftVisuallyDistinctCandidate):
              (WebCore::VisiblePosition::rightVisuallyDistinctCandidate):
              (WebCore::VisiblePosition::canonicalPosition):
              (WebCore::VisiblePosition::characterAfter):
              (WebCore::VisiblePosition::localCaretRect):
              (WebCore::makeRange):
              (WebCore::startVisiblePosition):
              (WebCore::endVisiblePosition):
              (WebCore::setStart):
              (WebCore::setEnd):
              (WebCore::isFirstVisiblePositionInNode):
              (WebCore::isLastVisiblePositionInNode):
              * editing/VisiblePosition.h:
              * editing/htmlediting.cpp:
              (WebCore::firstInSpecialElement):
              (WebCore::lastInSpecialElement):
              (WebCore::visiblePositionBeforeNode):
              (WebCore::visiblePositionAfterNode):
              * editing/visible_units.cpp:
              (WebCore::startPositionForLine):
              (WebCore::endPositionForLine):
              (WebCore::previousLinePosition):
              (WebCore::nextLinePosition):
              (WebCore::startOfParagraph):
              (WebCore::endOfParagraph):
              (WebCore::endOfBlock):
              (WebCore::startOfDocument):
              (WebCore::endOfDocument):
              (WebCore::logicalStartPositionForLine):
              (WebCore::logicalEndPositionForLine):
              * page/DOMSelection.cpp:
              (WebCore::DOMSelection::collapse):
              (WebCore::DOMSelection::setBaseAndExtent):
              (WebCore::DOMSelection::setPosition):
              (WebCore::DOMSelection::extend):
              * page/EventHandler.cpp:
              (WebCore::EventHandler::handleMousePressEventSingleClick):
              * rendering/RenderObject.cpp:
              (WebCore::RenderObject::createVisiblePosition):
              * rendering/RenderTextControl.cpp:
              (WebCore::RenderTextControl::visiblePositionForIndex):
              * svg/SVGTextContentElement.cpp:
              (WebCore::SVGTextContentElement::selectSubString):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@77997 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      0f9d6132
    • leviw@chromium.org's avatar
      2011-02-08 Levi Weintraub <leviw@chromium.org> · ddcb501f
      leviw@chromium.org authored
              Reviewed by Ryosuke Niwa.
      
              Stop instantiating legacy editing Positions in VisiblePosition
              https://bugs.webkit.org/show_bug.cgi?id=52919
      
              Changing usage of legacy VisiblePosition constructor. Since we were dealing
              with positions from DOM Ranges, we're guaranteed a parent-anchored position.
      
              * WebView/WebFrame.mm:
              (-[WebFrame _caretRectAtPosition:affinity:]):
              * WebView/WebFrameInternal.h:
              * WebView/WebTextCompletionController.mm:
              (-[WebTextCompletionController doCompletion]):
      2011-02-08  Levi Weintraub  <leviw@chromium.org>
      
              Reviewed by Ryosuke Niwa.
      
              Stop instantiating legacy editing Positions in VisiblePosition
              https://bugs.webkit.org/show_bug.cgi?id=52919
      
              Changing VisiblePosition completely away from legacy positions.
      
              No new tests since this is functionaly equivalent.
      
              * WebCore.exp.in: Removing the legacy VisiblePosition constructor and
              adding the PositionIsOffsetInAnchor symbol. If we must create VisiblePositions
              outside of WebCore, they should be parent anchored.
              * accessibility/AXObjectCache.cpp:
              (WebCore::AXObjectCache::visiblePositionForTextMarkerData):
              * accessibility/AccessibilityObject.cpp:
              (WebCore::startOfStyleRange):
              (WebCore::endOfStyleRange):
              * accessibility/AccessibilityRenderObject.cpp:
              (WebCore::AccessibilityRenderObject::visiblePositionForIndex):
              * accessibility/gtk/AccessibilityObjectWrapperAtk.cpp:
              (objectAndOffsetUnignored):
              * dom/Position.cpp:
              (WebCore::Position::upstream): Fixed to correctly respect PositionIsAfterAnchor
              (WebCore::Position::downstream): ditto
              * dom/Range.cpp:
              (WebCore::Range::editingStartPosition):
              * editing/Editor.cpp:
              (WebCore::Editor::canDeleteRange):
              * editing/ReplaceSelectionCommand.cpp:
              (WebCore::ReplaceSelectionCommand::doApply):
              * editing/SelectionController.cpp:
              (WebCore::SelectionController::selectFrameElementInParentIfFullySelected):
              (WebCore::SelectionController::setSelectedRange):
              * editing/TextIterator.cpp:
              (WebCore::TextIterator::shouldRepresentNodeOffsetZero):
              * editing/TypingCommand.cpp:
              (WebCore::TypingCommand::deleteKeyPressed):
              * editing/VisiblePosition.cpp:
              (WebCore::VisiblePosition::leftVisuallyDistinctCandidate):
              (WebCore::VisiblePosition::rightVisuallyDistinctCandidate):
              (WebCore::VisiblePosition::canonicalPosition):
              (WebCore::VisiblePosition::characterAfter):
              (WebCore::VisiblePosition::localCaretRect):
              (WebCore::makeRange):
              (WebCore::startVisiblePosition):
              (WebCore::endVisiblePosition):
              (WebCore::setStart):
              (WebCore::setEnd):
              (WebCore::isFirstVisiblePositionInNode):
              (WebCore::isLastVisiblePositionInNode):
              * editing/VisiblePosition.h:
              (WebCore::VisiblePosition::VisiblePosition):
              * editing/htmlediting.cpp:
              (WebCore::firstInSpecialElement):
              (WebCore::lastInSpecialElement):
              (WebCore::visiblePositionBeforeNode):
              (WebCore::visiblePositionAfterNode):
              * editing/visible_units.cpp:
              (WebCore::startPositionForLine):
              (WebCore::endPositionForLine):
              (WebCore::previousLinePosition):
              (WebCore::nextLinePosition):
              (WebCore::startOfParagraph):
              (WebCore::endOfParagraph):
              (WebCore::endOfBlock):
              (WebCore::startOfDocument):
              (WebCore::endOfDocument):
              (WebCore::logicalStartPositionForLine):
              (WebCore::logicalEndPositionForLine):
              * page/DOMSelection.cpp:
              (WebCore::DOMSelection::collapse):
              (WebCore::DOMSelection::setBaseAndExtent):
              (WebCore::DOMSelection::setPosition):
              (WebCore::DOMSelection::extend):
              * page/EventHandler.cpp:
              (WebCore::EventHandler::handleMousePressEventSingleClick):
              * rendering/RenderObject.cpp:
              (WebCore::RenderObject::createVisiblePosition):
              * rendering/RenderTextControl.cpp:
              (WebCore::RenderTextControl::visiblePositionForIndex):
              * svg/SVGTextContentElement.cpp:
              (WebCore::SVGTextContentElement::selectSubString):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@77980 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      ddcb501f
  8. 07 Feb, 2011 1 commit
  9. 01 Feb, 2011 1 commit
    • cfleizach@apple.com's avatar
      AX: AXPosition of AXScrollArea is wrong · a0d34a3c
      cfleizach@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=53511
      
      Reviewed by Darin Adler.
      
      Source/WebCore: 
      
      AccessibilityScrollView needed to return a valid documentFrameView() object.
      At the same time, the code from document() should be consolidated in 
      AccessibilityObject, so all objects can use it.
      
      Test: platform/mac/accessibility/webkit-scrollarea-position.html
      
      * accessibility/AccessibilityObject.cpp:
      (WebCore::AccessibilityObject::document):
      * accessibility/AccessibilityObject.h:
      * accessibility/AccessibilityScrollView.cpp:
      (WebCore::AccessibilityScrollView::accessibilityHitTest):
      (WebCore::AccessibilityScrollView::documentFrameView):
      * accessibility/AccessibilityScrollView.h:
      
      LayoutTests: 
      
      * platform/mac/accessibility/webkit-scrollarea-position-expected.txt: Added.
      * platform/mac/accessibility/webkit-scrollarea-position.html: Added.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@77308 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      a0d34a3c
  10. 29 Jan, 2011 1 commit
    • paroga@webkit.org's avatar
      2011-01-29 Patrick Gansterer <paroga@webkit.org> · 10c9e1b0
      paroga@webkit.org authored
              Reviewed by David Kilzer.
      
              Move CharacterNames.h into WTF directory
              https://bugs.webkit.org/show_bug.cgi?id=49618
      
              * GNUmakefile.am:
              * JavaScriptCore.gypi:
              * JavaScriptCore.vcproj/WTF/WTF.vcproj:
              * JavaScriptCore.xcodeproj/project.pbxproj:
              * wtf/CMakeLists.txt:
              * wtf/unicode/CharacterNames.h: Renamed from WebCore/platform/text/CharacterNames.h.
              * wtf/unicode/UTF8.cpp:
      2011-01-29  Patrick Gansterer  <paroga@webkit.org>
      
              Reviewed by David Kilzer.
      
              Move CharacterNames.h into WTF directory
              https://bugs.webkit.org/show_bug.cgi?id=49618
      
              * ForwardingHeaders/wtf/unicode/CharacterNames.h: Added.
              * GNUmakefile.am:
              * WebCore.gypi:
              * WebCore.vcproj/WebCore.vcproj:
              * WebCore.xcodeproj/project.pbxproj:
              * accessibility/AccessibilityObject.cpp:
              * accessibility/AccessibilityRenderObject.cpp:
              * bindings/cpp/WebDOMHTMLDocumentCustom.cpp:
              * bindings/js/JSHTMLDocumentCustom.cpp:
              * dom/Position.cpp:
              * dom/SelectElement.cpp:
              * editing/CompositeEditCommand.cpp:
              * editing/Editor.cpp:
              * editing/HTMLInterchange.cpp:
              * editing/InsertTextCommand.cpp:
              * editing/MarkupAccumulator.cpp:
              * editing/TextIterator.cpp:
              * editing/VisibleSelection.cpp:
              * editing/htmlediting.cpp:
              * editing/htmlediting.h:
              * editing/markup.cpp:
              * html/FTPDirectoryDocument.cpp:
              * html/HTMLFormControlElement.cpp:
              * html/parser/HTMLTreeBuilder.cpp:
              * loader/appcache/ManifestParser.cpp:
              * platform/chromium/PopupMenuChromium.cpp:
              * platform/graphics/Font.h:
              * platform/graphics/FontFastPath.cpp:
              * platform/graphics/GlyphPageTreeNode.cpp:
              * platform/graphics/StringTruncator.cpp:
              * platform/graphics/mac/ComplexTextController.cpp:
              * platform/graphics/mac/ComplexTextControllerATSUI.cpp:
              * platform/graphics/wince/GraphicsContextWinCE.cpp:
              * platform/mac/PasteboardMac.mm:
              * platform/text/TextCodecICU.cpp:
              * platform/text/mac/TextCodecMac.cpp:
              * platform/text/transcoder/FontTranscoder.cpp:
              * rendering/RenderBlockLineLayout.cpp:
              * rendering/RenderFlexibleBox.cpp:
              * rendering/RenderListMarker.cpp:
              * rendering/RenderText.cpp:
              * rendering/RenderTextControl.cpp:
              * rendering/RenderTreeAsText.cpp:
              * rendering/break_lines.cpp:
              * rendering/mathml/RenderMathMLOperator.h:
              * websockets/WebSocketHandshake.cpp:
              * wml/WMLTableElement.cpp:
      2011-01-29  Patrick Gansterer  <paroga@webkit.org>
      
              Reviewed by David Kilzer.
      
              Move CharacterNames.h into WTF directory
              https://bugs.webkit.org/show_bug.cgi?id=49618
      
              * src/ChromeClientImpl.cpp:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@77062 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      10c9e1b0
  11. 18 Jan, 2011 1 commit
    • cfleizach@apple.com's avatar
      REGRESSION: A problem with Voiceover and finding links · 99abb088
      cfleizach@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=52324
      
      Reviewed by Darin Adler.
      
      Source/WebCore: 
      
      Fallout from recent change to make WebCore return its own scroll view.
         1) There were two scroll views in the hierarchy, one which no needed to be ignored.
         2) Hit tests for sub frames needed to be offset.
         3) The check for whether an attachment is ignored must happen earlier than using
            the helpText to determine if an element should be ignored.
      
      Test: platform/mac/accessibility/iframe-with-title-correct-hierarchy.html
      
      * accessibility/AccessibilityObject.cpp:
      (WebCore::AccessibilityObject::elementAccessibilityHitTest):
      * accessibility/AccessibilityRenderObject.cpp:
      (WebCore::AccessibilityRenderObject::accessibilityIsIgnored):
      * accessibility/mac/AccessibilityObjectWrapper.mm:
      (-[AccessibilityObjectWrapper scrollViewParent]):
      
      Source/WebKit/mac: 
      
      * WebView/WebDynamicScrollBarsView.mm:
      (-[WebDynamicScrollBarsView accessibilityIsIgnored]):
      
      LayoutTests: 
      
      * platform/mac/accessibility/iframe-with-title-correct-hierarchy-expected.txt: Added.
      * platform/mac/accessibility/iframe-with-title-correct-hierarchy.html: Added.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@76044 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      99abb088
  12. 08 Jan, 2011 1 commit
  13. 06 Jan, 2011 1 commit
    • cfleizach@apple.com's avatar
      AX: "AXExpanded" not exposed on most ARIA roles that use aria-expanded · 603b034c
      cfleizach@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=51995
      
      Reviewed by Beth Dakin.
      
      WebCore: 
      
      Test: platform/mac/accessibility/aria-expanded-standard-items.html
      
      * accessibility/AccessibilityObject.cpp:
      (WebCore::AccessibilityObject::supportsARIAExpanded):
      (WebCore::AccessibilityObject::isExpanded):
      * accessibility/AccessibilityObject.h:
      * accessibility/AccessibilityRenderObject.cpp:
      (WebCore::AccessibilityRenderObject::isVisited):
      * accessibility/AccessibilityRenderObject.h:
      * accessibility/mac/AccessibilityObjectWrapper.mm:
      (-[AccessibilityObjectWrapper additionalAccessibilityAttributeNames]):
      
      LayoutTests: 
      
      * platform/mac/accessibility/aria-expanded-standard-items-expected.txt: Added.
      * platform/mac/accessibility/aria-expanded-standard-items.html: Added.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@75179 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      603b034c
  14. 04 Jan, 2011 1 commit
    • cfleizach@apple.com's avatar
      WK2: Support Accessibility · aa50410b
      cfleizach@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=51859
      
      Reviewed by Sam Weinig.
      
      Tools: 
      
      Use rootObject() method to get top of accessibility tree.
      
      * DumpRenderTree/mac/AccessibilityControllerMac.mm:
      (AccessibilityController::focusedElement):
      (AccessibilityController::rootElement):
      
      WebCore: 
      
      WK2 doesn't use platform scroll views anymore. Accessibility code
      needs to have its own scroll views. 
      
      Test: platform/mac/accessibility/webkit-scrollarea.html
      
      * CMakeLists.txt:
      * GNUmakefile.am:
      * WebCore.exp.in:
      * WebCore.gypi:
      * WebCore.pro:
      * WebCore.vcproj/WebCore.vcproj:
      * WebCore.xcodeproj/project.pbxproj:
      * accessibility/AXObjectCache.cpp:
      (WebCore::AXObjectCache::AXObjectCache):
      (WebCore::AXObjectCache::get):
      (WebCore::AXObjectCache::getOrCreate):
      (WebCore::AXObjectCache::rootObject):
      (WebCore::AXObjectCache::remove):
      (WebCore::AXObjectCache::handleScrollbarUpdate):
      * accessibility/AXObjectCache.h:
      (WebCore::AXObjectCache::handleScrollbarUpdate):
      * accessibility/AccessibilityARIAGrid.h:
      * accessibility/AccessibilityAllInOne.cpp:
      * accessibility/AccessibilityImageMapLink.cpp:
      * accessibility/AccessibilityImageMapLink.h:
      * accessibility/AccessibilityListBoxOption.cpp:
      * accessibility/AccessibilityListBoxOption.h:
      * accessibility/AccessibilityObject.cpp:
      (WebCore::AccessibilityObject::updateChildrenIfNecessary):
      (WebCore::AccessibilityObject::elementAccessibilityHitTest):
      (WebCore::AccessibilityObject::axObjectCache):
      (WebCore::AccessibilityObject::focusedUIElement):
      * accessibility/AccessibilityObject.h:
      (WebCore::AccessibilityObject::isAccessibilityScrollView):
      (WebCore::AccessibilityObject::isScrollView):
      (WebCore::AccessibilityObject::canSetNumericValue):
      (WebCore::AccessibilityObject::scrollBar):
      (WebCore::AccessibilityObject::size):
      (WebCore::AccessibilityObject::setValue):
      * accessibility/AccessibilityRenderObject.cpp:
      (WebCore::AccessibilityRenderObject::parentObject):
      (WebCore::AccessibilityRenderObject::accessibilityHitTest):
      (WebCore::AccessibilityRenderObject::updateChildrenIfNecessary):
      (WebCore::AccessibilityRenderObject::addChildren):
      * accessibility/AccessibilityRenderObject.h:
      * accessibility/AccessibilityScrollView.cpp: Added.
      (WebCore::AccessibilityScrollView::AccessibilityScrollView):
      (WebCore::AccessibilityScrollView::create):
      (WebCore::AccessibilityScrollView::scrollBar):
      (WebCore::AccessibilityScrollView::children):
      (WebCore::AccessibilityScrollView::updateChildrenIfNecessary):
      (WebCore::AccessibilityScrollView::removeChildScrollbar):
      (WebCore::AccessibilityScrollView::addChildScrollbar):
      (WebCore::AccessibilityScrollView::addChildren):
      (WebCore::AccessibilityScrollView::webAreaObject):
      (WebCore::AccessibilityScrollView::accessibilityHitTest):
      (WebCore::AccessibilityScrollView::document):
      (WebCore::AccessibilityScrollView::elementRect):
      (WebCore::AccessibilityScrollView::parentObject):
      * accessibility/AccessibilityScrollView.h: Added.
      (WebCore::AccessibilityScrollView::roleValue):
      (WebCore::AccessibilityScrollView::scrollView):
      (WebCore::AccessibilityScrollView::accessibilityIsIgnored):
      (WebCore::AccessibilityScrollView::isAccessibilityScrollView):
      (WebCore::toAccessibilityScrollView):
      * accessibility/AccessibilityScrollbar.cpp:
      (WebCore::AccessibilityScrollbar::AccessibilityScrollbar):
      (WebCore::AccessibilityScrollbar::create):
      (WebCore::AccessibilityScrollbar::elementRect):
      (WebCore::AccessibilityScrollbar::document):
      (WebCore::AccessibilityScrollbar::orientation):
      (WebCore::AccessibilityScrollbar::isEnabled):
      (WebCore::AccessibilityScrollbar::valueForRange):
      (WebCore::AccessibilityScrollbar::setValue):
      * accessibility/AccessibilityScrollbar.h:
      (WebCore::AccessibilityScrollbar::setParent):
      (WebCore::AccessibilityScrollbar::canSetValueAttribute):
      (WebCore::AccessibilityScrollbar::canSetNumericValue):
      (WebCore::AccessibilityScrollbar::isAccessibilityScrollbar):
      (WebCore::AccessibilityScrollbar::parentObject):
      (WebCore::AccessibilityScrollbar::roleValue):
      * accessibility/mac/AccessibilityObjectMac.mm:
      (WebCore::AccessibilityObject::accessibilityIgnoreAttachment):
      * accessibility/mac/AccessibilityObjectWrapper.mm:
      (-[AccessibilityObjectWrapper accessibilityAttributeNames]):
      (-[AccessibilityObjectWrapper remoteAccessibilityParentObject]):
      (-[AccessibilityObjectWrapper position]):
      (-[AccessibilityObjectWrapper scrollViewParent]):
      (-[AccessibilityObjectWrapper accessibilityAttributeValue:]):
      (-[AccessibilityObjectWrapper accessibilityHitTest:]):
      (-[AccessibilityObjectWrapper accessibilitySetValue:forAttribute:]):
      * dom/Document.cpp:
      (WebCore::Document::axObjectCache):
      * loader/EmptyClients.h:
      (WebCore::EmptyFrameLoaderClient::accessibilityRemoteObject):
      * loader/FrameLoaderClient.h:
      * page/FrameView.cpp:
      (WebCore::FrameView::~FrameView):
      (WebCore::FrameView::axObjectCache):
      * page/FrameView.h:
      * platform/ScrollView.cpp:
      (WebCore::ScrollView::setHasHorizontalScrollbar):
      (WebCore::ScrollView::setHasVerticalScrollbar):
      * platform/Scrollbar.cpp:
      (WebCore::Scrollbar::~Scrollbar):
      (WebCore::Scrollbar::scroll):
      (WebCore::Scrollbar::axObjectCache):
      * platform/Scrollbar.h:
      * platform/Widget.h:
      (WebCore::Widget::axObjectCache):
      
      WebKit/gtk: 
      
      Use rootObject() method to get top of ax tree.
      
      * WebCoreSupport/DumpRenderTreeSupportGtk.cpp:
      (DumpRenderTreeSupportGtk::getFocusedAccessibleElement):
      * webkit/webkitwebview.cpp:
      (webkit_web_view_get_accessible):
      
      WebKit/mac: 
      
      Use rootObject() method to get top of AX tree.
      
      * WebCoreSupport/WebFrameLoaderClient.h:
      (WebFrameLoaderClient::accessibilityRemoteObject):
      * WebView/WebFrame.mm:
      (-[WebFrame setAccessibleName:]):
      (-[WebFrame accessibilityRoot]):
      * WebView/WebFrameInternal.h:
      * WebView/WebFramePrivate.h:
      * WebView/WebHTMLView.mm:
      (-[WebHTMLView accessibilityAttributeValue:]):
      (-[WebHTMLView accessibilityFocusedUIElement]):
      (-[WebHTMLView accessibilityHitTest:]):
      (-[WebHTMLView _accessibilityParentForSubview:]):
      
      WebKit/win: 
      
      Use rootObject() method to get the top of the AX tree.
      
      * AccessibleDocument.cpp:
      (AccessibleDocument::AccessibleDocument):
      
      WebKit2: 
      
      Implement remote accessibility API to support cross process accessibility
      on the Mac platform.
      
      * Shared/WebProcessCreationParameters.cpp:
      (WebKit::WebProcessCreationParameters::encode):
      (WebKit::WebProcessCreationParameters::decode):
      * Shared/WebProcessCreationParameters.h:
      * UIProcess/API/mac/PageClientImpl.h:
      * UIProcess/API/mac/PageClientImpl.mm:
      (WebKit::PageClientImpl::accessibilityChildTokenReceived):
      * UIProcess/API/mac/WKView.mm:
      (-[WKView initWithFrame:contextRef:pageGroupRef:]):
      (-[WKView _updateWindowAndViewFrames]):
      (-[WKView _setAccessibilityChildToken:]):
      (-[WKView accessibilityIsIgnored]):
      (-[WKView accessibilityHitTest:]):
      (-[WKView accessibilityAttributeValue:]):
      * UIProcess/API/mac/WKViewInternal.h:
      * UIProcess/PageClient.h:
      * UIProcess/WebContext.cpp:
      (WebKit::WebContext::ensureWebProcess):
      * UIProcess/WebPageProxy.cpp:
      (WebKit::WebPageProxy::windowAndViewFramesChanged):
      (WebKit::WebPageProxy::didReceiveAccessibilityPageToken):
      (WebKit::WebPageProxy::sendAccessibilityPresenterToken):
      * UIProcess/WebPageProxy.h:
      * UIProcess/WebPageProxy.messages.in:
      * WebKit2.xcodeproj/project.pbxproj:
      * WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:
      (WebKit::WebFrameLoaderClient::accessibilityRemoteObject):
      * WebProcess/WebCoreSupport/WebFrameLoaderClient.h:
      * WebProcess/WebPage/WebPage.cpp:
      (WebKit::WebPage::windowAndViewFramesChanged):
      * WebProcess/WebPage/WebPage.h:
      (WebKit::WebPage::accessibilityPosition):
      * WebProcess/WebPage/WebPage.messages.in:
      * WebProcess/WebPage/mac/AccessibilityWebPageObject.h: Added.
      * WebProcess/WebPage/mac/AccessibilityWebPageObject.mm: Added.
      (-[AccessibilityWebPageObject setWebPage:]):
      (-[AccessibilityWebPageObject setRemoteParent:]):
      (-[AccessibilityWebPageObject dealloc]):
      (-[AccessibilityWebPageObject accessibilityIsIgnored]):
      (-[AccessibilityWebPageObject accessibilityAttributeNames]):
      (-[AccessibilityWebPageObject accessibilityIsAttributeSettable:]):
      (-[AccessibilityWebPageObject accessibilitySetValue:forAttribute:]):
      (-[AccessibilityWebPageObject accessibilityActionNames]):
      (-[AccessibilityWebPageObject accessibilityChildren]):
      (-[AccessibilityWebPageObject accessibilityAttributeValue:]):
      (-[AccessibilityWebPageObject accessibilityShouldUseUniqueId]):
      (-[AccessibilityWebPageObject accessibilityHitTest:]):
      (-[AccessibilityWebPageObject accessibilityFocusedUIElement]):
      * WebProcess/WebPage/mac/WebPageMac.mm:
      (WebKit::WebPage::platformInitialize):
      (WebKit::WebPage::sendAccessibilityPresenterToken):
      (WebKit::WebPage::accessibilityRemoteObject):
      * WebProcess/WebProcess.cpp:
      (WebKit::WebProcess::initializeWebProcess):
      * WebProcess/WebProcess.h:
      (WebKit::WebProcess::presenterApplicationPid):
      * WebProcess/mac/WebProcessMainMac.mm:
      (WebKit::WebProcessMain):
      
      LayoutTests: 
      
      * platform/mac/accessibility/webkit-scrollarea-expected.txt: Added.
      * platform/mac/accessibility/webkit-scrollarea.html: Added.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@75031 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      aa50410b
  15. 22 Dec, 2010 2 commits
  16. 13 Dec, 2010 1 commit
    • cfleizach@apple.com's avatar
      AX: aria-invalid should be supported. · 4f5eb1cc
      cfleizach@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=50573
      
      Reviewed by Beth Dakin.
      
      WebCore: 
      
      Test: platform/mac/accessibility/aria-invalid.html
      
      * accessibility/AXObjectCache.h:
      * accessibility/AccessibilityObject.cpp:
      (WebCore::AccessibilityObject::invalidStatus):
      * accessibility/AccessibilityObject.h:
      * accessibility/chromium/AXObjectCacheChromium.cpp
      (WebCore::AXObjectCache::postPlatformNotification):
      * accessibility/mac/AXObjectCacheMac.mm:
      (WebCore::AXObjectCache::postPlatformNotification):
      * accessibility/mac/AccessibilityObjectWrapper.mm:
      (-[AccessibilityObjectWrapper accessibilityAttributeNames]):
      (-[AccessibilityObjectWrapper accessibilityAttributeValue:]):
      * dom/Element.cpp:
      (WebCore::Element::updateAfterAttributeChanged):
      * html/HTMLAttributeNames.in:
      
      LayoutTests: 
      
      * platform/mac/accessibility/aria-invalid-expected.txt: Added.
      * platform/mac/accessibility/aria-invalid.html: Added.
      * platform/mac/accessibility/radio-button-group-members-expected.txt:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@73983 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      4f5eb1cc
  17. 06 Dec, 2010 1 commit
    • cfleizach@apple.com's avatar
      HTML5 Slider does not work correctly with VoiceOver · 583ba85b
      cfleizach@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=50505
      
      Reviewed by Darin Adler.
      
      Address a few problems with the Mac implementation for the accessibility slider.
          1) The value indicator is not hit testable.
          2) The value indicator does not return an AXValue.
          3) In the slider, the min/max values are not correct when min/max attributes are not present.
          4) When you change the value with the keyboard, it doesn't send out the right notification.
          5) Sliders were returning AXValue and AXTopLevelUIElement attributes twice in their list of attributes.
      
      Test: platform/mac/accessibility/html-slider-indicator.html
      
      WebCore: 
      
      * accessibility/AccessibilityObject.cpp:
      (WebCore::AccessibilityObject::getAttribute):
          Use fastGetAttribute on Element, instead of getAttribute.
      * accessibility/AccessibilityObject.h:
      (WebCore::AccessibilityObject::isInputSlider):
      * accessibility/AccessibilityRenderObject.cpp:
      (WebCore::AccessibilityRenderObject::doAccessibilityHitTest):
      * accessibility/AccessibilitySlider.cpp:
      (WebCore::AccessibilitySlider::doAccessibilityHitTest):
      (WebCore::AccessibilitySlider::maxValueForRange):
      (WebCore::AccessibilitySlider::minValueForRange):
      * accessibility/AccessibilitySlider.h:
      (WebCore::AccessibilitySlider::isInputSlider):
      * accessibility/mac/AccessibilityObjectWrapper.mm:
      (-[AccessibilityObjectWrapper accessibilityAttributeNames]):
      (-[AccessibilityObjectWrapper accessibilityAttributeValue:]):
      * html/HTMLInputElement.cpp:
      (WebCore::HTMLInputElement::applyStep):
      
      LayoutTests: 
      
      * platform/mac/accessibility/html-slider-indicator-expected.txt: Added.
      * platform/mac/accessibility/html-slider-indicator.html: Added.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@73388 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      583ba85b
  18. 21 Nov, 2010 1 commit
    • paroga@webkit.org's avatar
      2010-11-21 Patrick Gansterer <paroga@webkit.org> · f27e2eb1
      paroga@webkit.org authored
              Reviewed by Csaba Osztrogonác.
      
              Use WTF_ARRAY_LENGTH in WebCore directory
              https://bugs.webkit.org/show_bug.cgi?id=49882
      
              * accessibility/AccessibilityObject.cpp:
              (WebCore::createARIARoleMap):
              * bindings/js/JSDOMWindowBase.cpp:
              (WebCore::JSDOMWindowBase::JSDOMWindowBase):
              * bindings/scripts/CodeGeneratorV8.pm:
              * bindings/scripts/test/V8/V8TestObj.cpp:
              (WebCore::ConfigureV8TestObjTemplate):
              * css/CSSComputedStyleDeclaration.cpp:
              * css/CSSMutableStyleDeclaration.cpp:
              (WebCore::CSSMutableStyleDeclaration::getPropertyValue):
              * css/CSSParser.cpp:
              (WebCore::CSSParser::parseAnimationShorthand):
              (WebCore::CSSParser::parseTransitionShorthand):
              * css/CSSPropertyLonghand.cpp:
              (WebCore::initShorthandMap):
              * dom/ExceptionCode.cpp:
              (WebCore::getExceptionCodeDescription):
              * editing/ApplyStyleCommand.cpp:
              (WebCore::ApplyStyleCommand::removeImplicitlyStyledElement):
              * editing/EditingStyle.cpp:
              * editing/Editor.cpp:
              (WebCore::triStateOfStyle):
              * editing/EditorCommand.cpp:
              (WebCore::createCommandMap):
              * editing/MarkupAccumulator.cpp:
              (WebCore::appendCharactersReplacingEntities):
              * html/canvas/WebGLBuffer.cpp:
              (WebCore::WebGLBuffer::getCachedMaxIndex):
              (WebCore::WebGLBuffer::setCachedMaxIndex):
              * loader/FTPDirectoryParser.cpp:
              (WebCore::parseOneFTPLine):
              * mathml/RenderMathMLOperator.cpp:
              (WebCore::RenderMathMLOperator::updateFromElement):
              * page/animation/AnimationBase.cpp:
              (WebCore::addShorthandProperties):
              * rendering/RenderTextControl.cpp:
              (WebCore::RenderTextControl::hasValidAvgCharWidth):
              * rendering/break_lines.cpp:
              * svg/SVGTransformable.cpp:
              (WebCore::parseAndSkipType):
              * svg/SVGViewSpec.cpp:
              (WebCore::SVGViewSpec::parseViewSpec):
              * svg/SVGZoomAndPan.cpp:
              (WebCore::SVGZoomAndPan::parseZoomAndPan):
              * xml/XPathFunctions.cpp:
              (WebCore::XPath::createFunctionMap):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@72500 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      f27e2eb1
  19. 17 Nov, 2010 1 commit
    • dglazkov@chromium.org's avatar
      Converge means of querying a parent node into one way, which is Node::parentNode. · e43caa78
      dglazkov@chromium.org authored
      https://bugs.webkit.org/show_bug.cgi?id=49686
      
      Reviewed by Darin Adler.
      
      WebCore:
      
      No change in behavior, so no new tests.
      
      * accessibility/AccessibilityObject.cpp:
      (WebCore::renderListItemContainerForNode): Changed to use parentNode.
      * accessibility/AccessibilityRenderObject.cpp:
      (WebCore::AccessibilityRenderObject::mouseButtonListener): Ditto.
      (WebCore::siblingWithAriaRole): Ditto.
      (WebCore::AccessibilityRenderObject::getDocumentLinks): Ditto.
      (WebCore::AccessibilityRenderObject::accessibilityImageMapHitTest): Ditto.
      * accessibility/mac/AccessibilityObjectWrapper.mm: Ditto.
      (blockquoteLevel): Ditto.
      * bindings/v8/V8GCController.cpp:
      (WebCore::ObjectGrouperVisitor::visitDOMWrapper): Ditto.
      * dom/ContainerNode.cpp: Ditto.
      (WebCore::ContainerNode::insertBefore): Ditto.
      (WebCore::ContainerNode::insertBeforeCommon): Ditto.
      (WebCore::ContainerNode::replaceChild): Ditto.
      (WebCore::ContainerNode::removeChild): Ditto.
      (WebCore::ContainerNode::appendChild): Ditto.
      (WebCore::ContainerNode::parserAddChild): Ditto.
      * dom/DocumentType.cpp:
      (WebCore::DocumentType::insertedIntoDocument): Ditto.
      * dom/Element.cpp:
      (WebCore::Element::computeInheritedLanguage): Ditto.
      * dom/MouseRelatedEvent.cpp:
      (WebCore::MouseRelatedEvent::receivedTarget): Ditto.
      * dom/Position.cpp:
      (WebCore::Position::isCandidate): Changed to use parentNode.
      * dom/PositionIterator.cpp:
      (WebCore::PositionIterator::isCandidate): Ditto.
      * editing/AppendNodeCommand.cpp:
      (WebCore::AppendNodeCommand::AppendNodeCommand): Ditto.
      * editing/ApplyStyleCommand.cpp:
      (WebCore::dummySpanAncestorForNode): Ditto.
      (WebCore::ApplyStyleCommand::splitAncestorsWithUnicodeBidi): Ditto.
      (WebCore::ApplyStyleCommand::removeEmbeddingUpToEnclosingBlock): Ditto.
      (WebCore::highestEmbeddingAncestor): Ditto.
      (WebCore::ApplyStyleCommand::splitTextElementAtEnd): Ditto.
      (WebCore::ApplyStyleCommand::mergeStartWithPreviousIfIdentical): Ditto.
      (WebCore::ApplyStyleCommand::mergeEndWithNextIfIdentical): Ditto.
      * editing/CompositeEditCommand.cpp:
      (WebCore::CompositeEditCommand::splitTreeToNode): Ditto.
      * editing/DeleteSelectionCommand.cpp:
      (WebCore::updatePositionForNodeRemoval): Ditto.
      * editing/Editor.cpp:
      (WebCore::Editor::textDirectionForSelection): Ditto.
      * editing/MergeIdenticalElementsCommand.cpp:
      (WebCore::MergeIdenticalElementsCommand::doUnapply): Ditto.
      * editing/htmlediting.cpp:
      (WebCore::isEmptyTableCell): Ditto.
      * editing/markup.cpp:
      (WebCore::StyledMarkupAccumulator::serializeNodes): Ditto.
      * editing/visible_units.cpp:
      (WebCore::previousLinePosition): Ditto.
      (WebCore::nextLinePosition): Ditto.
      * html/HTMLAreaElement.cpp:
      (WebCore::HTMLAreaElement::imageElement): Ditto.
      * html/HTMLElement.cpp:
      (WebCore::HTMLElement::setOuterHTML): Ditto.
      (WebCore::HTMLElement::insertAdjacent): Ditto.
      (WebCore::HTMLElement::supportsFocus): Ditto.
      * html/HTMLEmbedElement.cpp:
      (WebCore::HTMLEmbedElement::insertedIntoDocument): Ditto.
      (WebCore::HTMLEmbedElement::attributeChanged): Ditto.
      * html/HTMLTableElement.cpp:
      (WebCore::HTMLTableElement::insertRow): Ditto.
      * html/HTMLTableRowsCollection.cpp: Ditto.
      (WebCore::isInHead): Ditto.
      (WebCore::isInBody): Ditto.
      (WebCore::isInFoot): Ditto.
      (WebCore::HTMLTableRowsCollection::rowAfter): Ditto.
      * html/HTMLViewSourceDocument.cpp:
      (WebCore::HTMLViewSourceDocument::addRange): Ditto.
      * html/MediaDocument.cpp:
      (WebCore::MediaDocument::replaceMediaElementTimerFired): Ditto.
      * html/parser/HTMLConstructionSite.cpp:
      (WebCore::HTMLConstructionSite::attach): Ditto.
      (WebCore::HTMLConstructionSite::findFosterSite): Ditto.
      * html/parser/HTMLTreeBuilder.cpp:
      * page/FocusController.cpp:
      (WebCore::FocusController::findFocusableNodeInDirection): Ditto.
      * rendering/MediaControlElements.cpp:
      (WebCore::MediaControlElement::rendererIsNeeded): Ditto.
      (WebCore::MediaControlElement::attach): Ditto.
      (WebCore::MediaControlElement::updateStyle): Ditto.
      (WebCore::MediaControlInputElement::rendererIsNeeded): Ditto.
      (WebCore::MediaControlInputElement::attach): Ditto.
      (WebCore::MediaControlInputElement::updateStyle): Ditto.
      * rendering/RenderSVGGradientStop.cpp:
      (WebCore::RenderSVGGradientStop::gradientElement): Ditto.
      * svg/SVGAElement.cpp:
      (WebCore::SVGAElement::createRenderer): Ditto.
      (WebCore::SVGAElement::childShouldCreateRenderer): Ditto.
      * svg/SVGFELightElement.cpp:
      (WebCore::SVGFELightElement::svgAttributeChanged): Ditto.
      (WebCore::SVGFELightElement::childrenChanged): Ditto.
      * svg/SVGFEMergeNodeElement.cpp:
      (WebCore::SVGFEMergeNodeElement::svgAttributeChanged): Ditto.
      * svg/SVGLength.cpp:
      (WebCore::SVGLength::determineViewport): Ditto.
      * svg/SVGStyledElement.cpp:
      (WebCore::SVGStyledElement::updateRelativeLengthsInformation): Ditto.
      * svg/SVGUseElement.cpp:
      (WebCore::SVGUseElement::removeDisallowedElementsFromSubtree): Ditto.
      * svg/animation/SVGSMILElement.cpp:
      (WebCore::SVGSMILElement::insertedIntoDocument): Ditto.
      * xml/XPathNodeSet.cpp:
      (WebCore::XPath::NodeSet::sort): Ditto.
      * xml/XPathStep.cpp:
      (WebCore::XPath::Step::nodesInAxis): Ditto.
      * xml/XSLTProcessorLibxslt.cpp:
      (WebCore::xsltStylesheetPointer): Ditto.
      
      WebKit/chromium:
      
      * src/WebFrameImpl.cpp:
      (WebKit::WebFrameImpl::insertStyleText): Changed to use parentNode.
      (WebKit::WebFrameImpl::setFindEndstateFocusAndSelection): Ditto.
      
      WebKit/qt:
      
      * Api/qwebelement.cpp:
      (QWebElement::prependOutside): Changed to use parentNode.
      (QWebElement::appendOutside): Ditto.
      (QWebElement::encloseContentsWith): Ditto.
      (QWebElement::encloseWith): Ditto.
      
      WebKit2:
      
      * WebProcess/WebPage/WebPage.cpp: Changed to use parentNode.
      (WebKit::WebPage::findZoomableAreaForPoint): Ditto.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@72259 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      e43caa78
  20. 13 Sep, 2010 1 commit
    • commit-queue@webkit.org's avatar
      2010-09-13 Mario Sanchez Prada <msanchez@igalia.com> · 25c82ab7
      commit-queue@webkit.org authored
              Reviewed by Martin Robinson.
      
              [GTK] ATs should be able to select/unselect text
              https://bugs.webkit.org/show_bug.cgi?id=25673
      
              Implement AtkText's setSelection and removeSelection functions
      
              * accessibility/AccessibilityObject.cpp:
              (WebCore::AccessibilityObject::visiblePositionRangeForRange):
              Moved some GTK specific code from a ifdef-endif region to
              AccessibilityObjectAtk.cpp
              * accessibility/AccessibilityObject.h:
              * accessibility/gtk/AccessibilityObjectAtk.cpp:
              (WebCore::AccessibilityObject::getLengthForTextRange): New.
              * accessibility/gtk/AccessibilityObjectWrapperAtk.cpp:
              (webkit_accessible_text_remove_selection): Implemented following
              the lead of GAIL's implementation of the AtkText interface.
              (webkit_accessible_text_set_selection): Implemented following
              the lead of GAIL's implementation of the AtkText interface.
              (webkit_accessible_text_set_caret_offset): Changed to directly use
              visiblePositionRangeForRange now that there's no longer a problem
              with that, as it was in the past (only worked for text controls).
      2010-09-13  Mario Sanchez Prada  <msanchez@igalia.com>
      
              Reviewed by Martin Robinson.
      
              [GTK] Provide unit tests for AtkText's text selection functions
              https://bugs.webkit.org/show_bug.cgi?id=43919
      
              New tests to check getting, setting and removing text selections
      
              * tests/testatk.c:
              (testWekitAtkTextSelections): New unit tests to check all the text
              selection related functions altogether through a single test
              function.
              (main):
      
              Make sure that code dependant on getting information from the
              clipboard gets executed only when there's a GDK window associated
              to the webview widget, as that's not the case when executing the
              unit tests (the wedbview is not inside of any toplevel window) and
              will make the tests crash if not taken into account.
      
              * WebCoreSupport/EditorClientGtk.cpp:
              (WebKit::EditorClient::respondToChangedSelection):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@67383 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      25c82ab7
  21. 09 Aug, 2010 1 commit
  22. 06 Aug, 2010 1 commit
    • eric@webkit.org's avatar
      2010-08-06 Eric Seidel <eric@webkit.org> · 6f428d17
      eric@webkit.org authored
              Reviewed by Chris Fleizach.
      
              Make AX Code use more specific RenderObject subclass types
              https://bugs.webkit.org/show_bug.cgi?id=43632
      
              No functional change, thus no tests.
      
              * accessibility/AXObjectCache.cpp:
              (WebCore::nodeHasRole):
               - Make this take a String instead of AtomicString, to avoid
                 thrashing the atomic string hash.
                 It would be better to take a const char* here, except
                 one caller passes nullAtom.
              (WebCore::createFromRenderer):
               - Split this out from getOrCreate to make it simpler.
               - No longer needs to deal with setting a "result"
                 pointer and can instead just return.
               - I've also made this function use RenderBoxModelObject*
                 where appropriate.
              (WebCore::AXObjectCache::getOrCreate):
              * accessibility/AXObjectCache.h:
              * accessibility/AccessibilityImageMapLink.cpp:
              (WebCore::AccessibilityImageMapLink::AccessibilityImageMapLink):
               - Fix style.
              * accessibility/AccessibilityMenuList.cpp:
              (WebCore::AccessibilityMenuList::AccessibilityMenuList):
               - Use a more specific type.
              (WebCore::AccessibilityMenuList::renderer):
              * accessibility/AccessibilityMenuList.h:
              (WebCore::AccessibilityMenuList::create):
              * accessibility/AccessibilityMenuListPopup.cpp:
               - Need RenderMenuList.h since renderer() is a RenderMenuList*
              * accessibility/AccessibilityObject.cpp:
              (WebCore::renderListItemContainerForNode):
              * accessibility/AccessibilityRenderObject.cpp:
              (WebCore::AccessibilityRenderObject::renderBoxModelObject):
               - New helper function, similar to Node::renderBoxModelObject()
              (WebCore::isInlineWithContinuation):
              (WebCore::AccessibilityRenderObject::isNativeImage):
              (WebCore::AccessibilityRenderObject::isAttachment):
              (WebCore::AccessibilityRenderObject::isMultiSelectable):
              (WebCore::AccessibilityRenderObject::isReadOnly):
              (WebCore::AccessibilityRenderObject::isFieldset):
              (WebCore::AccessibilityRenderObject::actionElement):
              (WebCore::AccessibilityRenderObject::stringValue):
              (WebCore::AccessibilityRenderObject::accessibilityIsIgnored):
              (WebCore::AccessibilityRenderObject::setValue):
              (WebCore::AccessibilityRenderObject::widget):
              (WebCore::AccessibilityRenderObject::visiblePositionForPoint):
              (WebCore::AccessibilityRenderObject::doAccessibilityHitTest):
              (WebCore::AccessibilityRenderObject::renderObjectIsObservable):
              (WebCore::AccessibilityRenderObject::determineAccessibilityRole):
              (WebCore::AccessibilityRenderObject::addChildren):
              (WebCore::msaaRoleForRenderer):
              * accessibility/AccessibilityRenderObject.h:
              * accessibility/AccessibilityTable.cpp:
              (WebCore::AccessibilityTable::isTableExposableThroughAccessibility):
              * accessibility/AccessibilityTable.h:
               - Remove unneeded "using namespace std".
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@64874 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      6f428d17
  23. 05 Aug, 2010 1 commit
  24. 02 Aug, 2010 1 commit
    • commit-queue@webkit.org's avatar
      2010-08-02 Mario Sanchez Prada <msanchez@igalia.com> · d9f3d817
      commit-queue@webkit.org authored
              Reviewed by Chris Fleizach.
      
              [GTK] Implement support for get_character_extents and get_range_extents
              https://bugs.webkit.org/show_bug.cgi?id=25677
      
              Implement get_range_extents() and modify get_character_extents()
              to properly work after "The Great Flattening" occurred in the ATK
              objects hierarchy, some months ago.
      
              In the case of the GTK port, not just the text controls should be
              considered when it comes to these functions but also those
              composite objects that would also allow to work with text ranges,
              such as headings and links. To take care of this, a new function
              AccessibilityObject::allowsTextRanges() was defined with a default
              implementation in the header file and an specific one for GTK in
              AccessibilityObjectAtk.cpp.
      
              Based on a previous patch by Joanmarie Diggs.
      
              * accessibility/AccessibilityObject.cpp:
              (WebCore::AccessibilityObject::visiblePositionRangeForRange):
              * accessibility/AccessibilityObject.h:
              (WebCore::AccessibilityObject::allowsTextRanges): New
              * accessibility/AccessibilityRenderObject.cpp:
              (WebCore::AccessibilityRenderObject::visiblePositionForIndex):
              (WebCore::AccessibilityRenderObject::doAXBoundsForRange):
              * accessibility/gtk/AccessibilityObjectAtk.cpp:
              (WebCore::AccessibilityObject::allowsTextRanges): New
              * accessibility/gtk/AccessibilityObjectWrapperAtk.cpp:
              (textExtents):
              (webkit_accessible_text_get_character_extents):
              (webkit_accessible_text_get_range_extents):
              (atk_text_interface_init):
      2010-08-02  Mario Sanchez Prada  <msanchez@igalia.com>
      
              Reviewed by Chris Fleizach.
      
              [GTK] Implement support for get_character_extents and get_range_extents
              https://bugs.webkit.org/show_bug.cgi?id=25677
      
              Added new unit tests to check get_character_extents and
              get_range_extents functions for the ATK_TEXT interface
      
              Based on a previous patch by Joanmarie Diggs.
      
              * tests/testatk.c:
              (test_webkit_atk_get_extents):
              (main):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@64475 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      d9f3d817
  25. 26 Jul, 2010 2 commits
    • cfleizach@apple.com's avatar
      AX: Safari does not support ARIA mixed checkboxes · 4186694d
      cfleizach@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=43016
      
      Reviewed by Darin Adler.
      
      WebCore: 
      
      Test: platform/mac/accessibility/mixed-checkbox.html
      
      * accessibility/AccessibilityObject.cpp:
      (WebCore::AccessibilityObject::checkboxOrRadioValue):
      * accessibility/AccessibilityObject.h:
      * accessibility/AccessibilityRenderObject.cpp:
      (WebCore::AccessibilityRenderObject::isNativeCheckboxOrRadio):
      (WebCore::AccessibilityRenderObject::checkboxOrRadioValue):
      * accessibility/AccessibilityRenderObject.h:
      * accessibility/mac/AccessibilityObjectWrapper.mm:
      (-[AccessibilityObjectWrapper accessibilityAttributeValue:]):
      
      LayoutTests: 
      
      * platform/mac/accessibility/mixed-checkbox-expected.txt: Added.
      * platform/mac/accessibility/mixed-checkbox.html: Added.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@64088 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      4186694d
    • cfleizach@apple.com's avatar
      AX: remove intValue() hasIntValue() from AccessibilityObject · 23edd85f
      cfleizach@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=43006
      
      Reviewed by Darin Adler.
      
      These methods are very Mac centric. The mac centric code should be moved into the Mac wrapper.
      
      No new tests, existing tests cover changes to logic.
      
      * accessibility/AccessibilityObject.cpp:
      (WebCore::AccessibilityObject::checkboxOrRadioValue):
      * accessibility/AccessibilityObject.h:
      (WebCore::):
      * accessibility/AccessibilityRenderObject.cpp:
      (WebCore::AccessibilityRenderObject::selectedRadioButton):
      (WebCore::AccessibilityRenderObject::selectedTabItem):
      (WebCore::AccessibilityRenderObject::checkboxOrRadioValue):
      * accessibility/AccessibilityRenderObject.h:
      * accessibility/mac/AccessibilityObjectWrapper.mm:
      (-[AccessibilityObjectWrapper accessibilityAttributeValue:]):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@64084 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      23edd85f
  26. 14 Jul, 2010 1 commit
    • cfleizach@apple.com's avatar
      AX: aria-checked not recognized on image map radio buttons · 214aaaea
      cfleizach@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=42055
      
      Reviewed by Darin Adler.
      
      WebCore: 
      
      Moves some code from AccessibilityRenderObject to AccessibilityObject so that
      elements that do not have render objects, but do have Nodes (like image map links 
      and list box options) can still make use of certain aria attributes.
      
      Test: platform/mac/accessibility/image-map-link-used-as-radiobutton.html
      
      * accessibility/AccessibilityImageMapLink.cpp:
      (WebCore::AccessibilityImageMapLink::roleValue):
      (WebCore::AccessibilityImageMapLink::accessibilityDescription):
      (WebCore::AccessibilityImageMapLink::title):
         Make imageMap use standard AccessibilityObject methods for getAttribute()
      * accessibility/AccessibilityImageMapLink.h:
      (WebCore::AccessibilityImageMapLink::node):
      * accessibility/AccessibilityListBoxOption.cpp:
      (WebCore::AccessibilityListBoxOption::accessibilityIsIgnored):
      (WebCore::AccessibilityListBoxOption::stringValue):
      * accessibility/AccessibilityListBoxOption.h:
      (WebCore::AccessibilityListBoxOption::node):
             * accessibility/AccessibilityObject.cpp:
      (WebCore::AccessibilityObject::language):
           Language method doesn't need a node() anymore, it can use the node from AccessibilityObject.
      (WebCore::renderListItemContainerForNode):
      (WebCore::AccessibilityObject::getAttribute):
      (WebCore::AccessibilityObject::intValue):
         Move intValue into AccessibilityObject.
      (WebCore::AccessibilityObject::hasIntValue):
      * accessibility/AccessibilityObject.h:
      (WebCore::AccessibilityObject::isCheckbox):
      (WebCore::AccessibilityObject::isRadioButton):
      (WebCore::AccessibilityObject::isCheckboxOrRadio):
         Consolidate what defines a checkbox and radio button into AccessibilityObject.
      (WebCore::AccessibilityObject::node):
      (WebCore::AccessibilityObject::headingLevel):
             (WebCore::AccessibilityObject::isDetached):
      * accessibility/AccessibilityRenderObject.cpp:
      (WebCore::AccessibilityRenderObject::isPasswordField):
      (WebCore::AccessibilityRenderObject::headingLevel):
      (WebCore::AccessibilityRenderObject::selectedTabItem):
      (WebCore::AccessibilityRenderObject::hierarchicalLevel):
      (WebCore::AccessibilityRenderObject::node):
      (WebCore::AccessibilityRenderObject::intValue):
      * accessibility/AccessibilityRenderObject.h:
      * rendering/RenderMenuList.cpp:
      (WebCore::RenderMenuList::itemAccessibilityText):
          Stop using AccessibilityObjects getAttribute (no reason to use it really).
      
      LayoutTests: 
      
      * platform/mac/accessibility/image-map-link-used-as-radiobutton-expected.txt: Added.
      * platform/mac/accessibility/image-map-link-used-as-radiobutton.html: Added.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@63358 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      214aaaea
  27. 14 Jun, 2010 1 commit
    • cfleizach@apple.com's avatar
      AX: need ListItemRole and PresentationalRole · 798f528e
      cfleizach@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=40133
      
      Reviewed by Darin Adler.
      
      WebCore: 
      
      * accessibility/AccessibilityObject.cpp:
      (WebCore::createARIARoleMap):
      * accessibility/AccessibilityObject.h:
      (WebCore::AccessibilityObject::isListItem):
      * accessibility/AccessibilityRenderObject.cpp:
      (WebCore::AccessibilityRenderObject::accessibilityIsIgnored):
      (WebCore::AccessibilityRenderObject::determineAccessibilityRole):
      * accessibility/mac/AccessibilityObjectWrapper.mm:
      (-[AccessibilityObjectWrapper accessibilityAttributeNames]):
      
      WebKit/chromium: 
      
      * public/WebAccessibilityRole.h:
      * src/AssertMatchingEnums.cpp:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@61151 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      798f528e
  28. 11 Mar, 2010 1 commit
    • cfleizach@apple.com's avatar
      support lang attribute on <option> elements · 93e0080f
      cfleizach@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=36021
      
      Reviewed by Darin Adler.
      
      WebCore: 
      
      Allow non AccessibilityRenderObject classes to access the lang
      attribute by moving the useful code into AccessibilityObject.
      
      Test: platform/mac/accessibility/option-with-lang.html
      
      * accessibility/AccessibilityListBoxOption.cpp:
      (WebCore::AccessibilityListBoxOption::language):
      * accessibility/AccessibilityListBoxOption.h:
      * accessibility/AccessibilityObject.cpp:
      (WebCore::AccessibilityObject::language):
      * accessibility/AccessibilityObject.h:
      * accessibility/AccessibilityRenderObject.cpp:
      (WebCore::AccessibilityRenderObject::language):
      * accessibility/AccessibilityRenderObject.h:
      
      LayoutTests: 
      
      * platform/mac/accessibility/option-with-lang-expected.txt: Added.
      * platform/mac/accessibility/option-with-lang.html: Added.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@55848 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      93e0080f
  29. 05 Mar, 2010 1 commit
    • eric@webkit.org's avatar
      2010-03-05 Chris Fleizach <cfleizach@apple.com> · 9b038500
      eric@webkit.org authored
              Reviewed by Eric Seidel.
      
              WAI-ARIA live region doesn't appear when <div> only has a <div> child
              https://bugs.webkit.org/show_bug.cgi?id=35751
      
              * platform/mac/accessibility/div-containing-div-with-aria-expected.txt: Added.
              * platform/mac/accessibility/div-containing-div-with-aria.html: Added.
      2010-03-05  Chris Fleizach  <cfleizach@apple.com>
      
              Reviewed by Eric Seidel.
      
              WAI-ARIA live region doesn't appear when <div> only has a <div> child
              https://bugs.webkit.org/show_bug.cgi?id=35751
      
              Elements should not be ignored if they carry ARIA attributes in them.
      
              Test: platform/mac/accessibility/div-containing-div-with-aria.html
      
              * accessibility/AccessibilityObject.cpp:
              (WebCore::AccessibilityObject::supportsARIAAttributes):
              * accessibility/AccessibilityObject.h:
              (WebCore::AccessibilityObject::supportsARIADropping):
              (WebCore::AccessibilityObject::supportsARIADragging):
              * accessibility/AccessibilityRenderObject.cpp:
              (WebCore::AccessibilityRenderObject::supportsARIADropping):
              (WebCore::AccessibilityRenderObject::supportsARIADragging):
              (WebCore::AccessibilityRenderObject::accessibilityIsIgnored):
              * accessibility/AccessibilityRenderObject.h:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@55611 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      9b038500
  30. 02 Mar, 2010 1 commit
    • cfleizach@apple.com's avatar
      aria-label isn't respected on option elements · 7a5d26ff
      cfleizach@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=35400
      
      Reviewed by Beth Dakin.
      
      WebCore: 
      
      When aria-label is used on an <option> element, it can take three forms.
      An option in a multi-select list, a popup button and the menu that is displayed 
      from the popup button. This patches the three requisite locations so that if
      aria-label is used, the correct accessibility text is returned.
      
      Test: platform/mac/accessibility/option-with-arialabel.html
      
      * accessibility/AccessibilityListBoxOption.cpp:
      (WebCore::AccessibilityListBoxOption::stringValue):
      * accessibility/AccessibilityObject.cpp:
      (WebCore::AccessibilityObject::getAttribute):
      * accessibility/AccessibilityObject.h:
      * accessibility/AccessibilityRenderObject.cpp:
      (WebCore::AccessibilityRenderObject::getAttribute):
      (WebCore::AccessibilityRenderObject::stringValue):
      * platform/PopupMenuClient.h:
      * platform/mac/PopupMenuMac.mm:
      (WebCore::PopupMenu::populate):
      * rendering/RenderMenuList.cpp:
      (WebCore::RenderMenuList::itemAccessibilityText):
      * rendering/RenderMenuList.h:
      * rendering/RenderTextControlSingleLine.h:
      (WebCore::RenderTextControlSingleLine::itemAccessibilityText):
      
      WebKit/chromium: 
      
      * src/SuggestionsPopupMenuClient.h:
      (WebKit::SuggestionsPopupMenuClient::itemAccessibilityText):
      
      LayoutTests: 
      
      * platform/mac/accessibility/option-with-arialabel-expected.txt: Added.
      * platform/mac/accessibility/option-with-arialabel.html: Added.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@55425 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      7a5d26ff
  31. 01 Mar, 2010 1 commit
    • cfleizach@apple.com's avatar
      AX: changes to WAI-ARIA grid aren't perceived correctly by VoiceOver · e4893cbb
      cfleizach@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=35514
      
      Reviewed by Darin Adler.
      
      WebCore: 
      
      When a table's DOM is changed and an AX Table is not asked first for its children,
      it would return wrong information. A table needs to make sure children are up to date in
      all methods that can be called from the outside.
      
      Test: platform/mac/accessibility/stale-table-rows.html
      
      * accessibility/AccessibilityARIAGrid.cpp:
      (WebCore::AccessibilityARIAGrid::cellForColumnAndRow):
      * accessibility/AccessibilityObject.cpp:
      (WebCore::AccessibilityObject::clearChildren):
      * accessibility/AccessibilityRenderObject.cpp:
      (WebCore::AccessibilityRenderObject::clearChildren):
      (WebCore::AccessibilityRenderObject::updateChildrenIfNecessary):
      (WebCore::AccessibilityRenderObject::children):
      * accessibility/AccessibilityRenderObject.h:
      (WebCore::AccessibilityRenderObject::needsToUpdateChildren):
      (WebCore::AccessibilityRenderObject::setNeedsToUpdateChildren):
      * accessibility/AccessibilityTable.cpp:
      (WebCore::AccessibilityTable::clearChildren):
      (WebCore::AccessibilityTable::columns):
      (WebCore::AccessibilityTable::rows):
      (WebCore::AccessibilityTable::rowHeaders):
      (WebCore::AccessibilityTable::columnHeaders):
      (WebCore::AccessibilityTable::cells):
      (WebCore::AccessibilityTable::columnCount):
      (WebCore::AccessibilityTable::rowCount):
      (WebCore::AccessibilityTable::cellForColumnAndRow):
      
      WebKitTools: 
      
      Add rowCount, columnCount for tables.
      
      * DumpRenderTree/AccessibilityUIElement.cpp:
      (rowCountCallback):
      (columnCountCallback):
      (AccessibilityUIElement::getJSClass):
      * DumpRenderTree/AccessibilityUIElement.h:
      * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
      (AccessibilityUIElement::rowCount):
      (AccessibilityUIElement::columnCount):
      * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
      (AccessibilityUIElement::rowCount):
      (AccessibilityUIElement::columnCount):
      * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
      (AccessibilityUIElement::rowCount):
      (AccessibilityUIElement::columnCount):
      
      LayoutTests: 
      
      * platform/mac/accessibility/stale-table-rows-expected.txt: Added.
      * platform/mac/accessibility/stale-table-rows.html: Added.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@55390 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      e4893cbb
  32. 19 Jan, 2010 1 commit
    • jhoneycutt@apple.com's avatar
      MSAA: The child <option> elements of a non-multiple <select> are not · c344ece4
      jhoneycutt@apple.com authored
      exposed
      
      https://bugs.webkit.org/show_bug.cgi?id=33773
      <rdar://problem/7550556>
      
      WebCore:
      
      Reviewed by Alice Liu.
      
      This exposes the child <option> elements in a format similar to
      Firefox's: the <select> element has one child, a hidden list object,
      and this list has as its children the <option> elements.
      
      * GNUmakefile.am:
      * WebCore.gypi:
      * WebCore.vcproj/WebCore.vcproj:
      * WebCore.xcodeproj/project.pbxproj:
      Add new files to project.
      
      * accessibility/AXObjectCache.cpp:
      (WebCore::AXObjectCache::getOrCreate):
      If the element is a RenderMenuList, create an AccessibilityMenuList.
      (WebCore::AXObjectCache::getOrCreate):
      Add new types to create by role value.
      
      * accessibility/AccessibilityMenuList.cpp: Added.
      (WebCore::AccessibilityMenuList::AccessibilityMenuList):
      Call the base class constructor. Assert that the RenderObject passed
      is a RenderMenuList.
      (WebCore::AccessibilityMenuList::press):
      Show or hide the popup menu.
      (WebCore::AccessibilityMenuList::addChildren):
      Create an AccessibilityMenuListPopup. If the platform ignores its
      accessibility, remove it from the object cache and return early.
      Otherwise, set its parent object to this object, add it to our list of
      children, and tell it to add its children.
      (WebCore::AccessibilityMenuList::childrenChanged):
      Tell our child hidden list that its children changed.
      (WebCore::AccessibilityMenuList::isCollapsed):
      Return whether the popup menu is visible.
      
      * accessibility/AccessibilityMenuList.h: Added.
      (WebCore::AccessibilityMenuList::create):
      Adopt and return a new RenderMenuList.
      (WebCore::AccessibilityMenuList::isMenuList):
      (WebCore::AccessibilityMenuList::roleValue):
      (WebCore::AccessibilityMenuList::accessibilityIsIgnored):
      (WebCore::AccessibilityMenuList::canSetFocusAttribute):
      
      * accessibility/AccessibilityMenuListOption.cpp: Added.
      (WebCore::AccessibilityMenuListOption::AccessibilityMenuListOption):
      Initialize the pointer to our parent popup menu.
      (WebCore::AccessibilityMenuListOption::setElement):
      Assert that the element is an <option> element.
      (WebCore::AccessibilityMenuListOption::actionElement):
      Return our element.
      (WebCore::AccessibilityMenuListOption::parentObject):
      Return our parent popup menu.
      (WebCore::AccessibilityMenuListOption::isEnabled):
      Return true if the element itself is enabled.
      (WebCore::AccessibilityMenuListOption::isVisible):
      Return true if the popup is visible, or return true if the popup is
      collapsed but the element is selected.
      (WebCore::AccessibilityMenuListOption::isOffScreen):
      Return true if the object is invisible.
      (WebCore::AccessibilityMenuListOption::isSelected):
      (WebCore::AccessibilityMenuListOption::setSelected):
      (WebCore::AccessibilityMenuListOption::nameForMSAA):
      Return the <option> element's text.
      (WebCore::AccessibilityMenuListOption::canSetSelectedAttribute):
      Return true if enabled.
      (WebCore::AccessibilityMenuListOption::elementRect):
      Return the AccessibilityMenuList's rect.
      
      * accessibility/AccessibilityMenuListOption.h: Added.
      (WebCore::AccessibilityMenuListOption::create):
      Adopt and return a new AccessibilityMenuListOption.
      (WebCore::AccessibilityMenuListOption::setParent):
      (WebCore::AccessibilityMenuListOption::isMenuListOption):
      (WebCore::AccessibilityMenuListOption::roleValue):
      (WebCore::AccessibilityMenuListOption::canHaveChildren):
      (WebCore::AccessibilityMenuListOption::size):
      
      * accessibility/AccessibilityMenuListPopup.cpp: Added.
      (WebCore::AccessibilityMenuListPopup::AccessibilityMenuListPopup):
      Initialize the pointer to our parent list.
      (WebCore::AccessibilityMenuListPopup::isVisible):
      Return false; we're never considered visible.
      (WebCore::AccessibilityMenuListPopup::isOffScreen):
      Return true if the popup is collapsed.
      (WebCore::AccessibilityMenuListPopup::parentObject):
      Return our parent AccessibilityMenuList.
      (WebCore::AccessibilityMenuListPopup::isEnabled):
      Return true if our parent is enabled.
      (WebCore::AccessibilityMenuListPopup::menuListOptionAccessibilityObject):
      If the element is an <option> element, create a list item for it, and
      set the object's element to this element.
      (WebCore::AccessibilityMenuListPopup::press):
      Call our parent's press() function to show or hide the popup menu.
      (WebCore::AccessibilityMenuListPopup::addChildren):
      Walk the select element's children, and create list items for them. Add
      them to our list of children.
      (WebCore::AccessibilityMenuListPopup::childrenChanged):
      If any of our children have been detached from the document, remove
      them from the AXObjectCache and from our child list.
      (WebCore::AccessibilityMenuListPopup::setMenuList):
      
      * accessibility/AccessibilityMenuListPopup.h: Added.
      (WebCore::AccessibilityMenuListPopup::create):
      Adopt and return an AccessibilityMenuListPopup.
      (WebCore::AccessibilityMenuListPopup::isMenuListPopup):
      (WebCore::AccessibilityMenuListPopup::elementRect):
      (WebCore::AccessibilityMenuListPopup::size):
      (WebCore::AccessibilityMenuListPopup::roleValue):
      
      * accessibility/AccessibilityObject.cpp:
      (WebCore::AccessibilityObject::actionVerb):
      Add the menuListAction and menuListPopupAction verbs.
      
      * accessibility/AccessibilityObject.h:
      (WebCore::):
      Add new roles.
      (WebCore::AccessibilityObject::isMenuList):
      Stubbed.
      (WebCore::AccessibilityObject::isMenuListHiddenList):
      Stubbed.
      (WebCore::AccessibilityObject::isMenuListOption):
      Stubbed.
      (WebCore::AccessibilityObject::isVisible):
      Stubbed.
      
      * accessibility/chromium/AccessibilityObjectChromium.cpp:
      (WebCore::AccessibilityObject::accessibilityPlatformIncludesObject):
      Ignore the new object type.
      
      * accessibility/gtk/AccessibilityObjectAtk.cpp:
      (WebCore::AccessibilityObject::accessibilityPlatformIncludesObject):
      Ditto.
      
      * accessibility/mac/AccessibilityObjectMac.mm:
      (WebCore::AccessibilityObject::accessibilityPlatformIncludesObject):
      Ditto.
      
      * accessibility/qt/AccessibilityObjectQt.cpp:
      (WebCore::AccessibilityObject::accessibilityPlatformIncludesObject):
      Ditto.
      
      * accessibility/win/AccessibilityObjectWin.cpp:
      (WebCore::AccessibilityObject::accessibilityPlatformIncludesObject):
      Allow the new object types.
      
      * accessibility/wx/AccessibilityObjectWx.cpp:
      (WebCore::AccessibilityObject::accessibilityPlatformIncludesObject):
      Ignore the new object type.
      
      * accessibility/win/AccessibilityObjectWin.cpp:
      (WebCore::AccessibilityObject::accessibilityPlatformIncludesObject):
      If the object is an AccessibilityMenuListHiddenList or
      AccessibilityMenuListOption, include it.
      
      * html/HTMLOptionElement.cpp:
      (WebCore::HTMLOptionElement::disabled):
      Call ownElementDisabled().
      
      * html/HTMLOptionElement.h:
      (WebCore::HTMLOptionElement::ownElementDisabled):
      Return the base class implementation of disabled, which returns
      whether this <option> itself is disabled.
      
      * platform/LocalizedStrings.h:
      Declare new localized string functions.
      
      * platform/gtk/LocalizedStringsGtk.cpp:
      (WebCore::AXMenuListPopupActionVerb):
      Stubbed.
      (WebCore::AXMenuListActionVerb):
      Stubbed.
      
      * platform/haiku/LocalizedStringsHaiku.cpp:
      (WebCore::AXMenuListPopupActionVerb):
      Stubbed.
      (WebCore::AXMenuListActionVerb):
      Stubbed.
      
      * platform/mac/LocalizedStringsMac.mm:
      (WebCore::AXMenuListPopupActionVerb):
      Call the view factory's method.
      (WebCore::AXMenuListActionVerb):
      Ditto.
      
      * platform/qt/Localizations.cpp:
      (WebCore::AXMenuListPopupActionVerb):
      Stubbed.
      (WebCore::AXMenuListActionVerb):
      Stubbed.
      
      * platform/wx/LocalizedStringsWx.cpp:
      (WebCore::AXMenuListPopupActionVerb):
      Stubbed.
      (WebCore::AXMenuListActionVerb):
      Stubbed.
      
      WebKit:
      
      Reviewed by Alice Liu.
      
      * English.lproj/Localizable.strings:
      Add new localized strings.
      
      WebKit/mac:
      
      * WebCoreSupport/WebViewFactory.mm:
      (-[WebViewFactory AXMenuListPopupActionVerb]):
      Stubbed.
      (-[WebViewFactory AXMenuListActionVerb]):
      Stubbed.
      
      WebKit/win:
      
      Reviewed by Alice Liu.
      
      * AccessibleBase.cpp:
      (AccessibleBase::get_accState):
      If the object is invisible, set the invisible state flag. If the object
      is collapsed, set the collapsed state. If the object is a combo box,
      set the has popup flag, and if it's not collapsed, set the expanded
      flag.
      (MSAARole):
      Add new WebCore to MSAA role mappings.
      
      * WebCoreLocalizedStrings.cpp:
      (WebCore::AXMenuListActionVerb):
      Return the action verb that Firefox uses for <select> elements with
      popups.
      (WebCore::AXMenuListPopupActionVerb):
      Return the verb that Firefox uses for a popup list.
      
      WebKitTools:
      
      Reviewed by Alice Liu.
      
      * DumpRenderTree/AccessibilityUIElement.cpp:
      (getIsVisibleCallback):
      Call the object's isVisible() function.
      (getIsOffScreenCallback):
      Ditto, for isOffScreen().
      (getIsCollapsedCallback):
      Ditto, for isCollapsed().
      (getHasPopupCallback):
      Ditto, for hasPopup().
      (AccessibilityUIElement::getJSClass):
      Add isVisible and isOffScreen attributes.
      
      * DumpRenderTree/AccessibilityUIElement.h:
      Declare new functions.
      
      * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
      (AccessibilityUIElement::isVisible):
      Stubbed.
      (AccessibilityUIElement::isOffScreen):
      Stubbed.
      (AccessibilityUIElement::isCollapsed):
      Stubbed.
      (AccessibilityUIElement::hasPopup):
      Stubbed.
      
      * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
      (AccessibilityUIElement::isVisible):
      Stubbed.
      (AccessibilityUIElement::isOffScreen):
      Stubbed.
      (AccessibilityUIElement::isCollapsed):
      Stubbed.
      (AccessibilityUIElement::hasPopup):
      Stubbed.
      
      * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
      (AccessibilityUIElement::showMenu):
      Call the object's accDoDefaultAction() to show its popup menu.
      (AccessibilityUIElement::isEnabled):
      Check that the object does not have the "unavailable" state.
      (AccessibilityUIElement::isVisible):
      Check that the object does not have the "invisible" state.
      (AccessibilityUIElement::isOffScreen):
      Check whether the object has the "offscreen" state.
      (AccessibilityUIElement::isCollapsed):
      Check whether the object has the "collapsed" state.
      (AccessibilityUIElement::hasPopup):
      Check whether the object has the "has popup" state.
      
      LayoutTests:
      
      Reviewed by Alice Liu.
      
      * platform/win/accessibility/single-select-children-expected.txt: Added.
      * platform/win/accessibility/single-select-children.html: Added.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@53512 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      c344ece4
  33. 05 Jan, 2010 1 commit
    • cfleizach@apple.com's avatar
      Add ARIA "Live Region" support · e7600b28
      cfleizach@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=33117
      
      Reviewed by Darin Adler.
      
      WebCore: 
      
      Tests: platform/mac/accessibility/aria-liveregions-attributes.html
             platform/mac/accessibility/aria-liveregions-notifications.html
      
      * accessibility/AXObjectCache.cpp:
      (WebCore::AXObjectCache::contentChanged):
      * accessibility/AXObjectCache.h:
      (WebCore::AXObjectCache::):
      * accessibility/AccessibilityObject.cpp:
      (WebCore::AccessibilityObject::isChildOfARIALiveRegion):
      (WebCore::AccessibilityObject::supportsARIALiveRegion):
      * accessibility/AccessibilityObject.h:
      (WebCore::AccessibilityObject::contentChanged):
      (WebCore::AccessibilityObject::ariaLiveRegionStatus):
      (WebCore::AccessibilityObject::ariaLiveRegionRelevant):
      (WebCore::AccessibilityObject::ariaLiveRegionAtomic):
      (WebCore::AccessibilityObject::ariaLiveRegionBusy):
      * accessibility/AccessibilityRenderObject.cpp:
      (WebCore::AccessibilityRenderObject::elementAttributeValue):
      (WebCore::AccessibilityRenderObject::contentChanged):
      (WebCore::AccessibilityRenderObject::childrenChanged):
      (WebCore::AccessibilityRenderObject::ariaLiveRegionStatus):
      (WebCore::AccessibilityRenderObject::ariaLiveRegionRelevant):
      (WebCore::AccessibilityRenderObject::ariaLiveRegionAtomic):
      (WebCore::AccessibilityRenderObject::ariaLiveRegionBusy):
      * accessibility/AccessibilityRenderObject.h:
      (WebCore::AccessibilityRenderObject::areChildrenDirty):
      * accessibility/mac/AXObjectCacheMac.mm:
      (WebCore::AXObjectCache::postPlatformNotification):
      * accessibility/mac/AccessibilityObjectWrapper.h:
      * accessibility/mac/AccessibilityObjectWrapper.mm:
      (-[AccessibilityObjectWrapper additionalAccessibilityAttributeNames]):
      (-[AccessibilityObjectWrapper accessibilityAttributeValue:]):
      (-[AccessibilityObjectWrapper accessibilitySetPostedNotificationCallback:]):
      (-[AccessibilityObjectWrapper accessibilityPostedNotification:]):
      * dom/Element.cpp:
      (WebCore::Element::updateAfterAttributeChanged):
      * html/HTMLAttributeNames.in:
      * rendering/RenderText.cpp:
      (WebCore::RenderText::setText):
      
      WebKitTools: 
      
      * DumpRenderTree/AccessibilityUIElement.cpp:
      (indexOfChildCallback):
      (boolAttributeValueCallback):
      (stringAttributeValueCallback):
      (addNotificationListenerCallback):
      (AccessibilityUIElement::getJSClass):
      * DumpRenderTree/AccessibilityUIElement.h:
      * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
      (AccessibilityUIElement::indexOfChild):
      (AccessibilityUIElement::stringAttributeValue):
      (AccessibilityUIElement::boolAttributeValue):
      (AccessibilityUIElement::addNotificationListener):
      * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
      (AccessibilityUIElement::indexOfChild):
      (AccessibilityUIElement::stringAttributeValue):
      (AccessibilityUIElement::boolAttributeValue):
      (_accessibilityNotificationCallback):
      (AccessibilityUIElement::addNotificationListener):
      * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
      (AccessibilityUIElement::indexOfChild):
      (AccessibilityUIElement::stringAttributeValue):
      (AccessibilityUIElement::boolAttributeValue):
      (AccessibilityUIElement::addNotificationListener):
      
      LayoutTests: 
      
      * accessibility/aria-activedescendant-crash.html:
      * platform/mac/accessibility/aria-liveregions-attributes-expected.txt: Added.
      * platform/mac/accessibility/aria-liveregions-attributes.html: Added.
      * platform/mac/accessibility/aria-liveregions-notifications-expected.txt: Added.
      * platform/mac/accessibility/aria-liveregions-notifications.html: Added.
      * platform/mac/accessibility/aria-menu-role-descriptions.html:
      * platform/mac/accessibility/slider-supports-actions.html:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@52786 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      e7600b28
  34. 15 Dec, 2009 3 commits
    • cfleizach@apple.com's avatar
      WAI-ARIA: implement treegrid · b33e652c
      cfleizach@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=31299
      
      Reviewed by Darin Adler.
      
      WebCore: 
      
      Test: platform/mac/accessibility/aria-treegrid.html
      
      * accessibility/AXObjectCache.cpp:
      (WebCore::AXObjectCache::getOrCreate):
      * accessibility/AccessibilityARIAGrid.h:
      (WebCore::AccessibilityARIAGrid::supportsSelectedRows):
      * accessibility/AccessibilityARIAGridRow.cpp:
      (WebCore::AccessibilityARIAGridRow::isARIATreeGridRow):
      (WebCore::AccessibilityARIAGridRow::disclosedRows):
      (WebCore::AccessibilityARIAGridRow::disclosedByRow):
      * accessibility/AccessibilityARIAGridRow.h:
      * accessibility/AccessibilityObject.cpp:
      (WebCore::createARIARoleMap):
      * accessibility/AccessibilityObject.h:
      (WebCore::):
      (WebCore::AccessibilityObject::isARIATreeGridRow):
      * accessibility/AccessibilityRenderObject.cpp:
      (WebCore::AccessibilityRenderObject::isMultiSelectable):
      (WebCore::AccessibilityRenderObject::setIsExpanded):
      (WebCore::AccessibilityRenderObject::setSelectedRows):
      (WebCore::AccessibilityRenderObject::ariaSelectedRows):
      (WebCore::AccessibilityRenderObject::ariaListboxSelectedChildren):
      (WebCore::AccessibilityRenderObject::selectedChildren):
      * accessibility/AccessibilityRenderObject.h:
      * accessibility/AccessibilityTable.h:
      (WebCore::AccessibilityTable::supportsSelectedRows):
      * accessibility/mac/AccessibilityObjectWrapper.mm:
      (-[AccessibilityObjectWrapper additionalAccessibilityAttributeNames]):
      (-[AccessibilityObjectWrapper accessibilityAttributeNames]):
      (-[AccessibilityObjectWrapper accessibilityAttributeValue:]):
      (-[AccessibilityObjectWrapper accessibilitySetValue:forAttribute:]):
      
      LayoutTests: 
      
      * platform/mac-leopard/Skipped:
      * platform/mac/accessibility/aria-treegrid-expected.txt: Added.
      * platform/mac/accessibility/aria-treegrid.html: Added.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@52159 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      b33e652c
    • eric@webkit.org's avatar
      2009-12-15 Eric Seidel <eric@webkit.org> · d1693206
      eric@webkit.org authored
              No review, rolling out r52140.
              http://trac.webkit.org/changeset/52140
              https://bugs.webkit.org/show_bug.cgi?id=31299
      
              The commit broke the Leopard bots and unfortunately
              Chris wasn't around to fix them, so I'm rolling the change
              out after 3 hours so that the bots can roll green again. :)
      
              * platform/mac/accessibility/aria-treegrid-expected.txt: Removed.
              * platform/mac/accessibility/aria-treegrid.html: Removed.
      2009-12-15  Eric Seidel  <eric@webkit.org>
      
              No review, rolling out r52140.
              http://trac.webkit.org/changeset/52140
              https://bugs.webkit.org/show_bug.cgi?id=31299
      
              The commit broke the Leopard bots and unfortunately
              Chris wasn't around to fix them, so I'm rolling the change
              out after 3 hours so that the bots can roll green again. :)
      
              * accessibility/AXObjectCache.cpp:
              (WebCore::AXObjectCache::getOrCreate):
              * accessibility/AccessibilityARIAGrid.h:
              * accessibility/AccessibilityARIAGridRow.cpp:
              * accessibility/AccessibilityARIAGridRow.h:
              * accessibility/AccessibilityObject.cpp:
              (WebCore::createARIARoleMap):
              * accessibility/AccessibilityObject.h:
              (WebCore::):
              * accessibility/AccessibilityRenderObject.cpp:
              (WebCore::AccessibilityRenderObject::isMultiSelect):
              (WebCore::AccessibilityRenderObject::setIsExpanded):
              (WebCore::AccessibilityRenderObject::setSelectedRows):
              (WebCore::AccessibilityRenderObject::ariaTreeSelectedRows):
              (WebCore::AccessibilityRenderObject::ariaListboxSelectedChildren):
              (WebCore::AccessibilityRenderObject::selectedChildren):
              * accessibility/AccessibilityRenderObject.h:
              * accessibility/AccessibilityTable.h:
              * accessibility/mac/AccessibilityObjectWrapper.mm:
              (-[AccessibilityObjectWrapper additionalAccessibilityAttributeNames]):
              (-[AccessibilityObjectWrapper accessibilityAttributeNames]):
              (-[AccessibilityObjectWrapper accessibilityAttributeValue:]):
              (-[AccessibilityObjectWrapper accessibilitySetValue:forAttribute:]):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@52146 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      d1693206
    • cfleizach@apple.com's avatar
      WAI-ARIA: implement treegrid · 48e3c88a
      cfleizach@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=31299
      
      Reviewed by Darin Adler.
      
      WebCore: 
      
      Test: platform/mac/accessibility/aria-treegrid.html
      
      * accessibility/AXObjectCache.cpp:
      (WebCore::AXObjectCache::getOrCreate):
      * accessibility/AccessibilityARIAGrid.h:
      (WebCore::AccessibilityARIAGrid::supportsSelectedRows):
      * accessibility/AccessibilityARIAGridRow.cpp:
      (WebCore::AccessibilityARIAGridRow::isARIATreeGridRow):
      (WebCore::AccessibilityARIAGridRow::disclosedRows):
      (WebCore::AccessibilityARIAGridRow::disclosedByRow):
      * accessibility/AccessibilityARIAGridRow.h:
      * accessibility/AccessibilityObject.cpp:
      (WebCore::createARIARoleMap):
      * accessibility/AccessibilityObject.h:
      (WebCore::AccessibilityObject::isARIATreeGridRow):
      * accessibility/AccessibilityRenderObject.cpp:
      (WebCore::AccessibilityRenderObject::isMultiSelectable):
      (WebCore::AccessibilityRenderObject::setIsExpanded):
      (WebCore::AccessibilityRenderObject::setSelectedRows):
      (WebCore::AccessibilityRenderObject::ariaSelectedRows):
      (WebCore::AccessibilityRenderObject::ariaListboxSelectedChildren):
      (WebCore::AccessibilityRenderObject::selectedChildren):
      * accessibility/AccessibilityRenderObject.h:
      * accessibility/AccessibilityTable.h:
      (WebCore::AccessibilityTable::supportsSelectedRows):
      * accessibility/mac/AccessibilityObjectWrapper.mm:
      (-[AccessibilityObjectWrapper additionalAccessibilityAttributeNames]):
      (-[AccessibilityObjectWrapper accessibilityAttributeNames]):
      (-[AccessibilityObjectWrapper accessibilityAttributeValue:]):
      (-[AccessibilityObjectWrapper accessibilitySetValue:forAttribute:]):
      
      LayoutTests: 
      
      * platform/mac/accessibility/aria-treegrid-expected.txt: Added.
      * platform/mac/accessibility/aria-treegrid.html: Added.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@52140 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      48e3c88a
  35. 03 Dec, 2009 1 commit
    • cfleizach@apple.com's avatar
      Implement WAI-ARIA scrollbar role and related property aria-orientation · 18b2b7c3
      cfleizach@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=32126
      
      Reviewed by Beth Dakin.
      
      WebCore: 
      
      Test: accessibility/aria-scrollbar-role.html
      
      * accessibility/AccessibilityObject.cpp:
      (WebCore::createARIARoleMap):
      * accessibility/AccessibilityObject.h:
      (WebCore::AccessibilityObject::isScrollbar):
      * accessibility/AccessibilityRenderObject.cpp:
      (WebCore::AccessibilityRenderObject::valueForRange):
      (WebCore::AccessibilityRenderObject::orientation):
      (WebCore::AccessibilityRenderObject::canHaveChildren):
      * accessibility/AccessibilityRenderObject.h:
      * accessibility/mac/AccessibilityObjectWrapper.mm:
      (-[AccessibilityObjectWrapper additionalAccessibilityAttributeNames]):
      (-[AccessibilityObjectWrapper accessibilityAttributeValue:]):
      * html/HTMLAttributeNames.in:
      
      WebKitTools: 
      
      * DumpRenderTree/AccessibilityUIElement.cpp:
      (getOrientationCallback):
      (AccessibilityUIElement::getJSClass):
      * DumpRenderTree/AccessibilityUIElement.h:
      * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
      (AccessibilityUIElement::orientation):
      * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
      (AccessibilityUIElement::orientation):
      * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
      (AccessibilityUIElement::orientation):
      
      LayoutTests: 
      
      * accessibility/aria-scrollbar-role-expected.txt: Added.
      * accessibility/aria-scrollbar-role.html: Added.
      * platform/gtk/Skipped:
      * platform/win/Skipped:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@51669 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      18b2b7c3