- 12 May, 2011 13 commits
-
-
tonyg@chromium.org authored
Reviewed by Darin Adler. Perform some forward declarations suggested by include-what-you-use https://bugs.webkit.org/show_bug.cgi?id=60545 * accessibility/AccessibilityObject.cpp: * accessibility/AccessibilityRenderObject.cpp: * accessibility/mac/AccessibilityObjectWrapper.mm: * dom/DocumentMarkerController.cpp: * dom/Position.cpp: * dom/PositionIterator.cpp: * dom/Range.cpp: * editing/ApplyBlockElementCommand.cpp: * editing/ApplyStyleCommand.cpp: * editing/Editor.cpp: * editing/EditorCommand.cpp: * editing/FrameSelection.cpp: * editing/HTMLInterchange.cpp: * editing/IndentOutdentCommand.cpp: * editing/ReplaceSelectionCommand.cpp: * editing/SpellChecker.h: * editing/SpellingCorrectionCommand.cpp: * editing/SpellingCorrectionController.h: * editing/TextCheckingHelper.cpp: * editing/TextIterator.h: * editing/htmlediting.h: * editing/markup.cpp: * editing/visible_units.cpp: * editing/visible_units.h: * fileapi/DOMFileSystem.cpp: * fileapi/DirectoryReaderSync.cpp: * fileapi/DirectoryReaderSync.h: * fileapi/FileEntry.h: * fileapi/FileWriter.h: * fileapi/FileWriterBase.h: * fileapi/FileWriterSync.h: * history/CachedFrame.cpp: * history/CachedPage.cpp: * history/HistoryItem.cpp: * history/HistoryItem.h: * history/PageCache.h: * loader/HistoryController.h: * loader/PingLoader.h: * loader/ResourceLoader.h: * loader/appcache/DOMApplicationCache.h: * loader/cache/CachedCSSStyleSheet.h: * loader/cache/CachedFont.cpp: * loader/cache/CachedFont.h: * loader/cache/CachedResourceRequest.cpp: * loader/cache/CachedResourceRequest.h: * loader/cache/MemoryCache.h: * notifications/Notification.cpp: * notifications/Notification.h: * notifications/NotificationCenter.cpp: * notifications/NotificationCenter.h: * page/Chrome.cpp: * page/Chrome.h: * page/DOMSelection.cpp: * page/DOMTimer.h: * page/DOMWindow.cpp: * page/EventHandler.cpp: * page/FocusController.h: * page/Geolocation.cpp: * page/Geolocation.h: * page/History.cpp: * rendering/RenderListBox.cpp: * workers/WorkerContext.cpp: 2011-05-10 Tony Gentilcore <tonyg@chromium.org> Reviewed by Darin Adler. Perform some forward declarations suggested by include-what-you-use https://bugs.webkit.org/show_bug.cgi?id=60545 * src/WebHistoryItem.cpp: * src/WebNotification.cpp: * src/WebTextCheckingCompletionImpl.cpp: * src/mac/WebSubstringUtil.mm: 2011-05-10 Tony Gentilcore <tonyg@chromium.org> Reviewed by Darin Adler. Perform some forward declarations suggested by include-what-you-use https://bugs.webkit.org/show_bug.cgi?id=60545 * Plugins/Hosted/WebHostedNetscapePluginView.mm: * WebView/WebFrame.mm: 2011-05-10 Tony Gentilcore <tonyg@chromium.org> Reviewed by Darin Adler. Perform some forward declarations suggested by include-what-you-use https://bugs.webkit.org/show_bug.cgi?id=60545 * WebProcess/WebPage/mac/WebPageMac.mm: git-svn-id: http://svn.webkit.org/repository/webkit/trunk@86325 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
ossy@webkit.org authored
* platform/qt-arm/fast/transforms/transform-positioned-ancestor-expected.txt: Added. * platform/qt-arm/transforms/2d/transform-borderbox-expected.txt: Added. * platform/qt-arm/transforms/2d/transform-origin-borderbox-expected.txt: Added. * platform/qt-arm/transforms/2d/zoom-menulist-expected.txt: Added. * platform/qt-arm/transforms/no_transform_hit_testing-expected.txt: Added. * platform/qt-arm/transforms/svg-vs-css-expected.txt: Added. * platform/qt-mac/Skipped: Add plugins/get-targeted-javascript-url.html because of missing plugin.getURLNotify() implementation * platform/qt-mac/fast/transforms/transform-positioned-ancestor-expected.txt: Added. * platform/qt-mac/transforms/2d/transform-borderbox-expected.txt: Added. * platform/qt-mac/transforms/2d/transform-origin-borderbox-expected.txt: Added. * platform/qt-mac/transforms/2d/zoom-menulist-expected.txt: Added. * platform/qt-mac/transforms/no_transform_hit_testing-expected.txt: Added. * platform/qt-mac/transforms/svg-vs-css-expected.txt: Added. git-svn-id: http://svn.webkit.org/repository/webkit/trunk@86324 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
philn@webkit.org authored
Unreviewed, GTK rebaseline after r86307. * platform/gtk/fast/dom/HTMLMeterElement/meter-styles-expected.txt: * platform/gtk/fast/dom/HTMLMeterElement/meter-styles-expected.png: git-svn-id: http://svn.webkit.org/repository/webkit/trunk@86323 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
yutak@chromium.org authored
Unreviewed. Update Qt test expectations affected in r86320. * platform/qt/fast/dom/Window/window-properties-expected.txt: * platform/qt/fast/dom/Window/window-property-descriptors-expected.txt: * platform/qt/fast/dom/prototype-inheritance-expected.txt: * platform/qt/fast/js/global-constructors-expected.txt: git-svn-id: http://svn.webkit.org/repository/webkit/trunk@86322 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
yutak@chromium.org authored
Unreviewed, another attempt of build fix. * websockets/CloseEvent.h: * websockets/CloseEvent.idl: git-svn-id: http://svn.webkit.org/repository/webkit/trunk@86321 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
yutak@chromium.org authored
Unreviewed, trying to fix Qt minimal compile. * websockets/CloseEvent.idl: git-svn-id: http://svn.webkit.org/repository/webkit/trunk@86320 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
commit-queue@webkit.org authored
Reviewed by Eric Seidel. Fix build with --disable-video --enable-fullscreen-api https://bugs.webkit.org/show_bug.cgi?id=60542 * css/CSSStyleSelector.cpp: (WebCore::CSSStyleSelector::SelectorChecker::checkOneSelector): git-svn-id: http://svn.webkit.org/repository/webkit/trunk@86319 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
philn@webkit.org authored
Unreviewed, GTK build fix. * wtf/Platform.h: git-svn-id: http://svn.webkit.org/repository/webkit/trunk@86318 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
carlosgc@webkit.org authored
Reviewed by Martin Robinson. Fix the build with ENABLE_PLUGIN_PROCESS https://bugs.webkit.org/show_bug.cgi?id=60628 * WebProcess/Plugins/PluginProxy.cpp: (WebKit::PluginProxy::initialize): Move the call to pluginController->isAcceleratedCompositingEnabled() to a #ifdef block. * WebProcess/Plugins/PluginProxy.h: Add include for <WebCore/IntRect.h>. git-svn-id: http://svn.webkit.org/repository/webkit/trunk@86317 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
commit-queue@webkit.org authored
Reviewed by Csaba Osztrogonác. [Qt] Arm debug build failing on ARMAssembler::debugOffset() https://bugs.webkit.org/show_bug.cgi?id=60688 Related to svn rev 85523 * assembler/ARMAssembler.h: (JSC::ARMAssembler::debugOffset): git-svn-id: http://svn.webkit.org/repository/webkit/trunk@86316 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
yutak@chromium.org authored
Reviewed by Kent Tamura. WebSocket add new event: CloseEvent https://bugs.webkit.org/show_bug.cgi?id=35573 Original patch was written by Fumitoshi Ukai <ukai@chromium.org>. I modified the test close-event.html slightly so that it passes on Chromium. I also updated a few test results that are affected by this change. * fast/dom/Window/window-properties-expected.txt: * fast/dom/Window/window-property-descriptors-expected.txt: * fast/dom/prototype-inheritance-expected.txt: * fast/js/global-constructors-expected.txt: * http/tests/websocket/tests/close-event-expected.txt: Added. * http/tests/websocket/tests/close-event.html: Added. * platform/chromium/fast/dom/prototype-inheritance-expected.txt: 2011-05-12 Yuta Kitamura <yutak@chromium.org> Reviewed by Kent Tamura. WebSocket add new event: CloseEvent https://bugs.webkit.org/show_bug.cgi?id=35573 Original patch was written by Fumitoshi Ukai <ukai@chromium.org>. I added CloseEvent constructor to DOMWindow, so it can be referred in the new test (close-event.html). Test: http/tests/websocket/tests/close-event.html * CMakeLists.txt: * CodeGenerators.pri: * DerivedSources.cpp: * DerivedSources.make: * GNUmakefile.list.am: * WebCore.gypi: * WebCore.pro: * WebCore.vcproj/WebCore.vcproj: * WebCore.xcodeproj/project.pbxproj: * bindings/js/JSEventCustom.cpp: (WebCore::toJS): * bindings/v8/custom/V8EventCustom.cpp: (WebCore::toV8): * dom/Event.cpp: (WebCore::Event::isCloseEvent): * dom/Event.h: * page/DOMWindow.idl: Add CloseEvent constructor. * websockets/CloseEvent.h: Added. (WebCore::CloseEvent::isCloseEvent): (WebCore::CloseEvent::create): (WebCore::CloseEvent::initCloseEvent): (WebCore::CloseEvent::wasClean): (WebCore::CloseEvent::CloseEvent): * websockets/CloseEvent.idl: Added. * websockets/WebSocket.cpp: (WebCore::WebSocket::didClose): git-svn-id: http://svn.webkit.org/repository/webkit/trunk@86315 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
commit-queue@webkit.org authored
Reviewed by Simon Fraser. RGBA colors in outlines show overpainting at the corners https://bugs.webkit.org/show_bug.cgi?id=58999 * fast/borders/outline-alpha-block.html: Added. * fast/borders/outline-alpha-inline.html: Added. * platform/chromium/test_expectations.txt: * platform/mac/fast/borders/outline-alpha-block-expected.png: Added. * platform/mac/fast/borders/outline-alpha-block-expected.txt: Added. * platform/mac/fast/borders/outline-alpha-inline-expected.png: Added. * platform/mac/fast/borders/outline-alpha-inline-expected.txt: Added. * platform/mac/fast/box-shadow/box-shadow-radius-expected.png: Rebaselined as this test had rgba outlines. * platform/mac/fast/layers/self-painting-outline-expected.png: Rebaselined as this test had rgba outlines. 2011-05-12 Ben Wells <benwells@chromium.org> Reviewed by Simon Fraser. RGBA colors in outlines show overpainting at the corners https://bugs.webkit.org/show_bug.cgi?id=58999 Tests: fast/borders/outline-alpha-block.html fast/borders/outline-alpha-inline.html Updated baseline images for tests with rgba outlines: fast/box-shadow/box-shadow-radius.html fast/layers/self-painting-outline.html * rendering/RenderInline.cpp: (WebCore::RenderInline::paintOutline): (WebCore::RenderInline::paintOutlineForLine): * rendering/RenderInline.h: * rendering/RenderObject.cpp: (WebCore::RenderObject::paintOutline): git-svn-id: http://svn.webkit.org/repository/webkit/trunk@86314 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
commit-queue@webkit.org authored
Reviewed by Eric Seidel. [Qt] Expected results for 6 new CSS3 transforms tests and the updated skipped list https://bugs.webkit.org/show_bug.cgi?id=60654 * platform/qt/Skipped: * platform/qt/fast/transforms/transform-positioned-ancestor-expected.png: Added. * platform/qt/fast/transforms/transform-positioned-ancestor-expected.txt: Added. * platform/qt/transforms/2d/transform-borderbox-expected.png: Added. * platform/qt/transforms/2d/transform-borderbox-expected.txt: Added. * platform/qt/transforms/2d/transform-origin-borderbox-expected.png: Added. * platform/qt/transforms/2d/transform-origin-borderbox-expected.txt: Added. * platform/qt/transforms/2d/zoom-menulist-expected.png: Added. * platform/qt/transforms/2d/zoom-menulist-expected.txt: Added. * platform/qt/transforms/no_transform_hit_testing-expected.png: Added. * platform/qt/transforms/no_transform_hit_testing-expected.txt: Added. * platform/qt/transforms/svg-vs-css-expected.png: Added. * platform/qt/transforms/svg-vs-css-expected.txt: Added. git-svn-id: http://svn.webkit.org/repository/webkit/trunk@86313 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
- 11 May, 2011 27 commits
-
-
leviw@chromium.org authored
Reviewed by Eric Seidel. Rename Widget::pos() https://bugs.webkit.org/show_bug.cgi?id=60575 Renaming Widget::pos() to the more-descriptive location(). No new tests as this is a simple rename * page/FrameView.cpp: (WebCore::FrameView::create): * platform/Widget.h: (WebCore::Widget::location): (WebCore::Widget::resize): 2011-05-11 Levi Weintraub <leviw@chromium.org> Reviewed by Eric Seidel. Rename Widget::pos() https://bugs.webkit.org/show_bug.cgi?id=60575 Renaming Widget::pos() to the more-descriptive location(). * src/WebInputEventConversion.cpp: (WebKit::WebMouseEventBuilder::WebMouseEventBuilder): (WebKit::WebMouseWheelEventBuilder::WebMouseWheelEventBuilder): git-svn-id: http://svn.webkit.org/repository/webkit/trunk@86312 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
morrita@google.com authored
Reviewed by Kent Tamura. Crashes if the document inside iframe is removed during pasting some text into it. https://bugs.webkit.org/show_bug.cgi?id=60534 * editing/pasteboard/paste-removing-iframe-expected.txt: Added. * editing/pasteboard/paste-removing-iframe.html: Added. * editing/pasteboard/resources/paste-removing-iframe-child.html: Added. 2011-05-10 MORITA Hajime <morrita@google.com> Reviewed by Kent Tamura. Crashes if the document inside iframe is removed during pasting some text into it. https://bugs.webkit.org/show_bug.cgi?id=60534 Added missing null check. Test: editing/pasteboard/paste-removing-iframe.html * editing/Editor.cpp: (WebCore::Editor::shouldChangeSelection): git-svn-id: http://svn.webkit.org/repository/webkit/trunk@86311 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
commit-queue@webkit.org authored
Reviewed by Eric Seidel. Handle case when GrContext creation fails https://bugs.webkit.org/show_bug.cgi?id=60410 Exercised by all canvas tests when DRT is run with skia-gpu * platform/graphics/gpu/SharedGraphicsContext3D.cpp: (WebCore::SharedGraphicsContext3D::grContext): git-svn-id: http://svn.webkit.org/repository/webkit/trunk@86310 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
psolanki@apple.com authored
Reviewed by Andreas Kling. Remove empty class CallbackGuard https://bugs.webkit.org/show_bug.cgi?id=60610 CallbackGuard was only ever used on Tiger and it is now an empty class. Remove all uses of it. * platform/network/mac/ResourceHandleMac.mm: (-[WebCoreResourceHandleAsDelegate connection:willSendRequest:redirectResponse:]): (-[WebCoreResourceHandleAsDelegate connectionShouldUseCredentialStorage:]): (-[WebCoreResourceHandleAsDelegate connection:didReceiveAuthenticationChallenge:]): (-[WebCoreResourceHandleAsDelegate connection:didCancelAuthenticationChallenge:]): (-[WebCoreResourceHandleAsDelegate connection:canAuthenticateAgainstProtectionSpace:]): (-[WebCoreResourceHandleAsDelegate connection:didReceiveResponse:]): (-[WebCoreResourceHandleAsDelegate connection:didReceiveData:lengthReceived:]): (-[WebCoreResourceHandleAsDelegate connection:willStopBufferingData:]): (-[WebCoreResourceHandleAsDelegate connection:didSendBodyData:totalBytesWritten:totalBytesExpectedToWrite:]): (-[WebCoreResourceHandleAsDelegate connectionDidFinishLoading:]): (-[WebCoreResourceHandleAsDelegate connection:didFailWithError:]): (-[WebCoreResourceHandleAsDelegate connection:willCacheResponse:]): git-svn-id: http://svn.webkit.org/repository/webkit/trunk@86309 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
commit-queue@webkit.org authored
Reviewed by Eric Seidel. Implement CSSPropertyMargin and CSSPropertyPadding in CSSStyleApplyProperty. https://bugs.webkit.org/show_bug.cgi?id=60609 No new tests - refactoring only. * css/CSSStyleApplyProperty.cpp: (WebCore::CSSStyleApplyProperty::CSSStyleApplyProperty): Initialise CSSPropertyMargin and CSSPropertyPadding handlers. * css/CSSStyleSelector.cpp: (WebCore::CSSStyleSelector::applyProperty): Remove unused implementations. git-svn-id: http://svn.webkit.org/repository/webkit/trunk@86308 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
morrita@google.com authored
Reviewed by Kent Tamura. Some elements in meter-styles.html are hiding its content part with non-content-area. https://bugs.webkit.org/show_bug.cgi?id=58149 - Resized the border and padding values - Gave "-webkit-appearance: none" to test that is intended to be painted using shadows. * fast/dom/HTMLMeterElement/meter-styles.html: * platform/mac/fast/dom/HTMLMeterElement/meter-styles-expected.checksum: * platform/mac/fast/dom/HTMLMeterElement/meter-styles-expected.png: * platform/mac/fast/dom/HTMLMeterElement/meter-styles-expected.txt: git-svn-id: http://svn.webkit.org/repository/webkit/trunk@86307 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
kevino@webkit.org authored
[wx] Implement more clipping functions for wxWebKit. https://bugs.webkit.org/show_bug.cgi?id=60662 git-svn-id: http://svn.webkit.org/repository/webkit/trunk@86306 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
commit-queue@webkit.org authored
Reviewed by Brady Eidson. Need a new API that will try to restore the scrollbars' position, when navigating in the back/forward history https://bugs.webkit.org/show_bug.cgi?id=60674 * WebCore.exp.in: Export restoreScrollPositionAndViewState() 2011-05-11 Damian Kaleta <dkaleta@apple.com> Reviewed by Brady Eidson. Need a new API that will try to restore the scrollbars' position, when navigating in the back/forward history https://bugs.webkit.org/show_bug.cgi?id=60674 * UIProcess/API/C/WKPage.cpp: (WKPageTryRestoreScrollPosition): * UIProcess/API/C/WKPage.h: * UIProcess/WebPageProxy.cpp: (WebKit::WebPageProxy::tryRestoreScrollPosition): * UIProcess/WebPageProxy.h: * WebProcess/WebPage/WebPage.cpp: (WebKit::WebPage::tryRestoreScrollPosition): * WebProcess/WebPage/WebPage.h: * WebProcess/WebPage/WebPage.messages.in: git-svn-id: http://svn.webkit.org/repository/webkit/trunk@86305 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
commit-queue@webkit.org authored
Reviewed by Eric Seidel. WebKit does not build with GCCE https://bugs.webkit.org/show_bug.cgi?id=60667 Allow compile WebKit with GCCE * wtf/Alignment.h: * wtf/Platform.h: git-svn-id: http://svn.webkit.org/repository/webkit/trunk@86304 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
leviw@chromium.org authored
Reviewed by Eric Seidel. Switch paintFillLayer and its progeny to use IntRect instead of four ints https://bugs.webkit.org/show_bug.cgi?id=60596 Changing integers passed into paintFillLayer and other derivatives to IntRects and IntSizes that reflect their function. No new tests since this is just refactoring. * rendering/InlineFlowBox.cpp: (WebCore::InlineFlowBox::paintFillLayers): (WebCore::InlineFlowBox::paintFillLayer): (WebCore::InlineFlowBox::paintBoxDecorations): (WebCore::InlineFlowBox::paintMask): * rendering/InlineFlowBox.h: * rendering/RenderBox.cpp: (WebCore::RenderBox::paintRootBoxFillLayers): (WebCore::RenderBox::paintBoxDecorationsWithSize): (WebCore::RenderBox::paintMaskImages): (WebCore::RenderBox::paintFillLayers): (WebCore::RenderBox::paintFillLayer): * rendering/RenderBox.h: * rendering/RenderBoxModelObject.cpp: (WebCore::RenderBoxModelObject::paintFillLayerExtended): * rendering/RenderBoxModelObject.h: * rendering/RenderFieldset.cpp: (WebCore::RenderFieldset::paintBoxDecorations): * rendering/RenderTable.cpp: (WebCore::RenderTable::paintBoxDecorations): * rendering/RenderTableCell.cpp: (WebCore::RenderTableCell::paintBackgroundsBehindCell): git-svn-id: http://svn.webkit.org/repository/webkit/trunk@86303 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
abarth@webkit.org authored
Reviewed by Eric Seidel. Enable strict PassOwnPtr on Mac https://bugs.webkit.org/show_bug.cgi?id=60684 This should build cleanly now. * wtf/PassOwnPtr.h: git-svn-id: http://svn.webkit.org/repository/webkit/trunk@86302 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
commit-queue@webkit.org authored
Reviewed by James Robinson. [chromium] Use mapTexSubImage2D for tile uploads if available https://bugs.webkit.org/show_bug.cgi?id=60008 * platform/graphics/chromium/LayerTilerChromium.cpp: (WebCore::LayerTilerChromium::LayerTilerChromium): (WebCore::LayerTilerChromium::update): (WebCore::LayerTilerChromium::updateFromPixels): * platform/graphics/chromium/LayerTilerChromium.h: git-svn-id: http://svn.webkit.org/repository/webkit/trunk@86301 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
oliver@apple.com authored
Reviewed by Darin Adler. Protect JSC from WebCore executing JS during JS wrapper finalization https://bugs.webkit.org/show_bug.cgi?id=60672 <rdar://problem/9350997> Detect when we're trying to execute JS during GC and prevent the execution from happening. We also assert that this isn't happening as it implies incorrect behaviour of an object's destructor. * JavaScriptCore.exp: * heap/Heap.cpp: * heap/Heap.h: (JSC::Heap::isBusy): * interpreter/Interpreter.cpp: (JSC::Interpreter::execute): (JSC::Interpreter::executeCall): (JSC::Interpreter::executeConstruct): * runtime/JSGlobalData.h: (JSC::JSGlobalData::isCollectorBusy): git-svn-id: http://svn.webkit.org/repository/webkit/trunk@86300 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
alexis.menard@openbossa.org authored
Reviewed by Kenneth Rohde Christiansen. [Qt] Implements a disable appearance for Media Elements of Qt port. https://bugs.webkit.org/show_bug.cgi?id=60561 Implements a disable appearance for the media controls of the Qt port when the media is not yet available. * platform/qt/RenderThemeQt.cpp: (WebCore::mediaElementCanPlay): (WebCore::RenderThemeQt::getMediaControlForegroundColor): (WebCore::RenderThemeQt::paintMediaSliderThumb): git-svn-id: http://svn.webkit.org/repository/webkit/trunk@86299 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
tkent@chromium.org authored
Reviewed by Dimitri Glazkov. input type=email is too strict https://bugs.webkit.org/show_bug.cgi?id=55988 * fast/forms/resources/ValidityState-typeMismatch-email.js: * fast/forms/ValidityState-typeMismatch-email-expected.txt: 2011-05-11 Kent Tamura <tkent@chromium.org> Reviewed by Dimitri Glazkov. input type=email is too strict https://bugs.webkit.org/show_bug.cgi?id=55988 Follow the updated specification. * html/EmailInputType.cpp: Update the pattern to allow a domain part without periods. git-svn-id: http://svn.webkit.org/repository/webkit/trunk@86298 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
cdn@chromium.org authored
Reviewed by David Levin. Adding Cris Neckar to the Webkit Security Group site. https://bugs.webkit.org/show_bug.cgi?id=60668 * security/security-group-members.html: git-svn-id: http://svn.webkit.org/repository/webkit/trunk@86297 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
weinig@apple.com authored
Reviewed by Gavin Barraclough. WebKit2 doesn't build on Mac with strict PassOwnPtr https://bugs.webkit.org/show_bug.cgi?id=60655 * Platform/CoreIPC/HandleMessage.h: (CoreIPC::handleMessageDelayed): Add explicit adoptPtr to indicate that the constructor is taking ownership. git-svn-id: http://svn.webkit.org/repository/webkit/trunk@86296 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
jpu@apple.com authored
Reviewed by Darin Adler. Autocorrection persists after deleting and retyping the same word at same location. https://bugs.webkit.org/show_bug.cgi?id=60555 <rdar://problem/9373915> See WebCore/ChangeLog for detail. * platform/mac-leopard/Skipped: * platform/mac-snowleopard/Skipped: * platform/mac/editing/spelling/delete-autocorrected-word-2-expected.png: Added. * platform/mac/editing/spelling/delete-autocorrected-word-2-expected.txt: Added. * platform/mac/editing/spelling/delete-autocorrected-word-2.html: Added. 2011-05-11 Jia Pu <jpu@apple.com> Reviewed by Darin Adler. Autocorrection persists after deleting and retyping the same word at same location. https://bugs.webkit.org/show_bug.cgi?id=60555 <rdar://problem/9373915> This patch intends to alleviate the issue of repetitively applying the same autocorrection when user delete and retype the same word at the same location. This scenario is especially common when autocorrection modifies the first letter of the word. This patch consists following major changes: 1. Added a new marker type, DeletedAutocorrection. This marker is added to the whitespace that precedes a deleted autocorrection. If the user later types the same original word at after this whitespace, the autocorrection will not be applied again. 2. In DeleteSelectionCommand, added code to notify SpellingCorrectionController about the autocorrection that has just been deleted. 3. In Editor and SpellingCorrectionController, added code to apply the marker and to suppress autocorrection when necessary. 4. The change in CompositeEditCommand::replaceTextInNode is necessary for preserving markers. Otherwise, we will loose the DeletedAutocorrection on the whitespace, when inserting text after the whitespace. Test: platform/mac/editing/spelling/delete-autocorrected-word-2.html * dom/DocumentMarker.h: Added new marker type DeletedAutocorrection. (WebCore::DocumentMarker::AllMarkers::AllMarkers): * dom/DocumentMarkerController.cpp: (WebCore::DocumentMarkerController::markersInRange): Support querying multiple marker types. * dom/DocumentMarkerController.h: * editing/CompositeEditCommand.cpp: (WebCore::CompositeEditCommand::replaceTextInNodeAndPreserveMarkers): (WebCore::CompositeEditCommand::rebalanceWhitespaceOnTextSubstring): (WebCore::CompositeEditCommand::prepareWhitespaceAtPositionForSplit): * editing/CompositeEditCommand.h: * editing/DeleteSelectionCommand.cpp: (WebCore::DeleteSelectionCommand::DeleteSelectionCommand): (WebCore::DeleteSelectionCommand::fixupWhitespace): (WebCore::DeleteSelectionCommand::originalStringForAutocorrectionAtBeginningOfSelection): Extracting the original string if we are deleting an autocorrection. (WebCore::DeleteSelectionCommand::doApply): Notify editor about the deleted autocorrection and its position. * editing/DeleteSelectionCommand.h: * editing/Editor.cpp: (WebCore::Editor::markAllMisspellingsAndBadGrammarInRanges): Moved all logic of determining when to suppress an autocorrection into SpellingCorrectionController. (WebCore::Editor::deletedAutocorrectionAtPosition): * editing/Editor.h: * editing/InsertParagraphSeparatorCommand.cpp: (WebCore::InsertParagraphSeparatorCommand::doApply): * editing/SpellingCorrectionController.cpp: (WebCore::SpellingCorrectionController::respondToAppliedEditing): (WebCore::SpellingCorrectionController::deletedAutocorrectionAtPosition): (WebCore::SpellingCorrectionController::markPrecedingWhitespaceForDeletedAutocorrectionAfterCommand): (WebCore::SpellingCorrectionController::processMarkersOnTextToBeReplacedByResult): * editing/SpellingCorrectionController.h: (WebCore::SpellingCorrectionController::UNLESS_ENABLED): * editing/visible_units.cpp: (WebCore::isStartOfWord): * editing/visible_units.h: * manual-tests/autocorrection/spell-checking-after-reversion.html: git-svn-id: http://svn.webkit.org/repository/webkit/trunk@86295 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
oliver@apple.com authored
Reviewed by Gavin Barraclough. Enable gc mark validation in temporarily in release builds https://bugs.webkit.org/show_bug.cgi?id=60678 Make it easier to turn the gc mark validation on and off, and temporarily turn it on for all builds. * heap/MarkStack.cpp: * heap/MarkStack.h: (JSC::MarkStack::append): (JSC::MarkStack::internalAppend): * runtime/WriteBarrier.h: (JSC::MarkStack::appendValues): * wtf/Platform.h: git-svn-id: http://svn.webkit.org/repository/webkit/trunk@86294 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
rdar://problem/9414874mitz@apple.com authored
https://bugs.webkit.org/show_bug.cgi?id=60677 Reviewed by Darin Adler. * platform/ScrollView.cpp: (WebCore::ScrollView::updateScrollbars): Only perform an immediate scroll, aborting any running animation, if the new scroll offset computed here is different from the current scroll offset. git-svn-id: http://svn.webkit.org/repository/webkit/trunk@86293 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
tkent@chromium.org authored
Reviewed by Dimitri Glazkov. <input pattern="1|10" value="10"> doesn't work correctly. https://bugs.webkit.org/show_bug.cgi?id=60619 Add test cases and update the result. * fast/forms/ValidityState-patternMismatch-expected.txt: * fast/forms/ValidityState-patternMismatch.html: 2011-05-11 Kent Tamura <tkent@chromium.org> Reviewed by Dimitri Glazkov. <input pattern="1|10" value="10"> doesn't work correctly. https://bugs.webkit.org/show_bug.cgi?id=60619 Fixes a bug that patternMismatch returns a wrong result if - a whole value matches to a pattern, - a sub-string of the value also matches to the pattern, and - the sub-string matching has priority. * html/BaseTextInputType.cpp: (WebCore::BaseTextInputType::patternMismatch): Enclose the specified pattern with ^( and )$. git-svn-id: http://svn.webkit.org/repository/webkit/trunk@86292 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
commit-queue@webkit.org authored
Reviewed by David Levin. Prevented DOMFileSystemBase from imposing file naming restrictions on external file systems. https://bugs.webkit.org/show_bug.cgi?id=60583 There are no new tests for this change since it requires the presence of external file system provider which is specific to the platform host process. Chromium implementation will test this within its extension API test suite. * fileapi/DOMFileSystemBase.cpp: (WebCore::pathToAbsolutePath): (WebCore::DOMFileSystemBase::getFile): (WebCore::DOMFileSystemBase::getDirectory): git-svn-id: http://svn.webkit.org/repository/webkit/trunk@86291 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
commit-queue@webkit.org authored
Reviewed by David Levin. Expose shouldBufferData to ThreadableLoaderOptions to be able to disable buffering of the loaded resource. https://bugs.webkit.org/show_bug.cgi?id=60656 * loader/DocumentThreadableLoader.cpp: (WebCore::DocumentThreadableLoader::loadRequest): Pass the shouldBufferData to the resource load scheduler, forcing it to true for the preflight request. * loader/ResourceLoadScheduler.cpp: (WebCore::ResourceLoadScheduler::scheduleSubresourceLoad): Pass through shouldBufferData to SubresourceLoader::create * loader/ResourceLoadScheduler.h: * loader/SubresourceLoader.cpp: (WebCore::SubresourceLoader::create): Set shouldBufferData on the newly created loader * loader/SubresourceLoader.h: * loader/ThreadableLoader.h: (WebCore::ThreadableLoaderOptions::ThreadableLoaderOptions): Add shouldBufferData to the options, defaulting to true. 2011-05-11 Antoine Labour <piman@chromium.org> Reviewed by David Levin. Don't buffer data for resources loaded by AssociatedURLLoader. https://bugs.webkit.org/show_bug.cgi?id=60656 * src/AssociatedURLLoader.cpp: (WebKit::AssociatedURLLoader::loadAsynchronously): set shouldBufferData to false in ThreadableLoaderOptions git-svn-id: http://svn.webkit.org/repository/webkit/trunk@86290 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
jcivelli@chromium.org authored
Reviewed by Adam Barth. Adding a Content-Type parser. This is needed for MHTML support. https://bugs.webkit.org/show_bug.cgi?id=60637 (WebCore::ScriptController::disableEval): * platform/network/ContentTypeParser.cpp: Added. * platform/network/ContentTypeParser.h: Added. git-svn-id: http://svn.webkit.org/repository/webkit/trunk@86289 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
eric@webkit.org authored
Reviewed by David Levin. Teach validate-committer-lists how to validate committers bugzilla_email() https://bugs.webkit.org/show_bug.cgi?id=60651 It turns out we currently have 9 committers with invalid values for their bugzilla_email field (meaning we don't know what email is their bugzilla account). "Alexander Kellett" <lypanov@mac.com> "Andre Boule" <aboule@apple.com> "Cameron McCormack" <cam@webkit.org> "Chris Petersen" <cpetersen@apple.com> "Eli Fidler" <eli@staikos.net> "Matt Lilek" <webkit@mattlilek.com> "Pierre d'Herbemont" <pdherbemont@free.fr> "Scott Violet" <sky@chromium.org> "Adam Treat" <treat@kde.org> Most of those haven't committed in a very long time, so it's not suprising that we haven't noticed that their bugzilla emails are bogus. * Scripts/validate-committer-lists: * Scripts/webkitpy/common/net/bugzilla/bugzilla.py: * Scripts/webkitpy/common/net/bugzilla/bugzilla_unittest.py: git-svn-id: http://svn.webkit.org/repository/webkit/trunk@86288 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
levin@chromium.org authored
Switch TestWebKitAPI to GTest Patch by Dmitry Lomov <dslomov@google.com> on 2011-05-11 Reviewed by David Levin. Fixes Makefiles and WinCairo build as well .: * Source/ThirdParty/gtest/README.WebKit: * Source/ThirdParty/gtest/msvc/gtest-md.vcproj: * Source/ThirdParty/gtest/xcode/Config/General.xcconfig: * Source/ThirdParty/gtest/xcode/Makefile: Added. Source/WebKit/win: * WebKit.vcproj/WebKit.sln: Tools: * Makefile: * Scripts/build-api-tests: * Scripts/run-api-tests: * TestWebKitAPI/Configurations/TestWebKitAPICommon.vsprops: * TestWebKitAPI/Test.h: * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: * TestWebKitAPI/Tests/WTF/VectorBasic.cpp: (TestWebKitAPI::TEST): * TestWebKitAPI/TestsController.cpp: (TestWebKitAPI::TestsController::TestsController): (TestWebKitAPI::TestsController::dumpTestNames): (TestWebKitAPI::TestsController::runTestNamed): (TestWebKitAPI::TestsController::runAllTests): * TestWebKitAPI/TestsController.h: * TestWebKitAPI/mac/main.mm: (main): git-svn-id: http://svn.webkit.org/repository/webkit/trunk@86287 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
ademar.reis@openbossa.org authored
Reviewed by Mark Rowe. Update Qt/Nokia Security contacts https://bugs.webkit.org/show_bug.cgi?id=60650 Ademar (me) replaced Simon as the release manager and primary security contact for QtWebKit. See: http://lists.webkit.org/mailman/private.cgi/webkit-security/2011-February/000584.html * security/security-group-members.html: git-svn-id: http://svn.webkit.org/repository/webkit/trunk@86286 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-