- 14 May, 2009 11 commits
-
-
kov@webkit.org authored
Reviewed by Darin Adler. Add more ENABLE_DATABASE guards. https://bugs.webkit.org/show_bug.cgi?id=25616 See also https://bugs.webkit.org/show_bug.cgi?id=24776 (original set of guards) * bindings/js/JSSQLResultSetRowListCustom.cpp: * bindings/v8/custom/V8CustomSQLStatementCallback.cpp: * bindings/v8/custom/V8CustomSQLStatementCallback.h: * bindings/v8/custom/V8CustomSQLStatementErrorCallback.cpp: * bindings/v8/custom/V8CustomSQLStatementErrorCallback.h: * bindings/v8/custom/V8CustomSQLTransactionCallback.cpp: * bindings/v8/custom/V8CustomSQLTransactionCallback.h: * bindings/v8/custom/V8CustomSQLTransactionErrorCallback.cpp: * bindings/v8/custom/V8CustomSQLTransactionErrorCallback.h: * bindings/v8/custom/V8DatabaseCustom.cpp: * bindings/v8/custom/V8SQLResultSetRowListCustom.cpp: * bindings/v8/custom/V8SQLTransactionCustom.cpp: * storage/Database.cpp: * storage/DatabaseDetails.h: * storage/OriginUsageRecord.cpp: * storage/OriginUsageRecord.h: * storage/SQLError.h: * storage/SQLError.idl: * storage/SQLResultSet.cpp: * storage/SQLResultSet.h: * storage/SQLResultSet.idl: * storage/SQLResultSetRowList.cpp: * storage/SQLResultSetRowList.h: * storage/SQLResultSetRowList.idl: * storage/SQLStatementCallback.h: * storage/SQLStatementErrorCallback.h: * storage/SQLTransactionCallback.h: * storage/SQLTransactionErrorCallback.h: git-svn-id: http://svn.webkit.org/repository/webkit/trunk@43699 268f45cc-cd09-0410-ab3c-d52691b4dbfc -
zecke@webkit.org authored
Reviewed by Darin Adler. https://bugs.webkit.org/show_bug.cgi?id=25325 Make sure pthread_self() is declared before it gets called in Collector.cpp * runtime/Collector.cpp: Include pthread.h in most Unix-like platforms (not just for OPENBSD) git-svn-id: http://svn.webkit.org/repository/webkit/trunk@43698 268f45cc-cd09-0410-ab3c-d52691b4dbfc -
zecke@webkit.org authored
Reviewed by Darin Adler. https://bugs.webkit.org/show_bug.cgi?id=25787 Gtk was the last platform to not unregister plugins when the plugin is stopped. Catch up with r43550. * plugins/gtk/PluginViewGtk.cpp: (WebCore::PluginView::stop): git-svn-id: http://svn.webkit.org/repository/webkit/trunk@43697 268f45cc-cd09-0410-ab3c-d52691b4dbfc -
ariya@webkit.org authored
Reviewed by Ariya Hidayat. Add a test case for the signal urlChanged(). * tests/qwebframe/tst_qwebframe.cpp: git-svn-id: http://svn.webkit.org/repository/webkit/trunk@43696 268f45cc-cd09-0410-ab3c-d52691b4dbfc -
aroben@apple.com authored
* WebCore.vcproj/WebCore.vcproj: Removed empty override of the pre-build event that was accidentally left in when the pre-build event was moved to WebCoreCommon.vsprops. git-svn-id: http://svn.webkit.org/repository/webkit/trunk@43695 268f45cc-cd09-0410-ab3c-d52691b4dbfc -
aroben@apple.com authored
Beth made the tests text-only in r43677 but forgot to remove these Windows-specific render tree dumps. Rubber-stamped by Dave Hyatt. * platform/win/http/tests/navigation/anchor-basic-expected.txt: Removed. * platform/win/http/tests/navigation/anchor-goback-expected.txt: Removed. * platform/win/http/tests/navigation/anchor-subframeload-expected.txt: Removed. * platform/win/http/tests/navigation/javascriptlink-basic-expected.txt: Removed. * platform/win/http/tests/navigation/javascriptlink-goback-expected.txt: Removed. * platform/win/http/tests/navigation/javascriptlink-subframeload-expected.txt: Removed. * platform/win/http/tests/navigation/metaredirect-basic-expected.txt: Removed. * platform/win/http/tests/navigation/metaredirect-frames-expected.txt: Removed. * platform/win/http/tests/navigation/metaredirect-goback-expected.txt: Removed. * platform/win/http/tests/navigation/metaredirect-subframeload-expected.txt: Removed. * platform/win/http/tests/navigation/post-goback2-expected.txt: Removed. * platform/win/http/tests/navigation/postredirect-goback2-expected.txt: Removed. * platform/win/http/tests/navigation/redirect302-basic-expected.txt: Removed. * platform/win/http/tests/navigation/redirect302-frames-expected.txt: Removed. * platform/win/http/tests/navigation/redirect302-goback-expected.txt: Removed. * platform/win/http/tests/navigation/redirect302-subframeload-expected.txt: Removed. * platform/win/http/tests/navigation/relativeanchor-basic-expected.txt: Removed. * platform/win/http/tests/navigation/relativeanchor-frames-expected.txt: Removed. * platform/win/http/tests/navigation/relativeanchor-goback-expected.txt: Removed. * platform/win/http/tests/navigation/slowmetaredirect-basic-expected.txt: Removed. * platform/win/http/tests/navigation/slowtimerredirect-basic-expected.txt: Removed. * platform/win/http/tests/navigation/success200-basic-expected.txt: Removed. * platform/win/http/tests/navigation/success200-frames-expected.txt: Removed. * platform/win/http/tests/navigation/success200-frames-loadsame-expected.txt: Removed. * platform/win/http/tests/navigation/success200-goback-expected.txt: Removed. * platform/win/http/tests/navigation/success200-loadsame-expected.txt: Removed. * platform/win/http/tests/navigation/success200-reload-expected.txt: Removed. * platform/win/http/tests/navigation/success200-subframeload-expected.txt: Removed. * platform/win/http/tests/navigation/timerredirect-basic-expected.txt: Removed. * platform/win/http/tests/navigation/timerredirect-frames-expected.txt: Removed. * platform/win/http/tests/navigation/timerredirect-goback-expected.txt: Removed. * platform/win/http/tests/navigation/timerredirect-subframeload-expected.txt: Removed. git-svn-id: http://svn.webkit.org/repository/webkit/trunk@43694 268f45cc-cd09-0410-ab3c-d52691b4dbfc -
darin@apple.com authored
2009-05-14 Darin Adler <darin@apple.com> * manual-tests/right-click-crash.html: Added. WebKit/mac: 2009-05-14 Darin Adler <darin@apple.com> Reviewed by John Sullivan. Bug 24049: Second right-click crashes safari when alert invoked https://bugs.webkit.org/show_bug.cgi?id=24049 rdar://problem/6878977 * WebView/WebHTMLView.mm: (-[WebHTMLView rightMouseUp:]): Added a retain/autorelease of the event. (-[WebHTMLView menuForEvent:]): Ditto. Also cleaned up the logic here and eliminated some use of pointers that might be invalid after calling through to WebCore. (-[WebHTMLView scrollWheel:]): Ditto. (-[WebHTMLView acceptsFirstMouse:]): Ditto. (-[WebHTMLView shouldDelayWindowOrderingForEvent:]): Ditto. (-[WebHTMLView mouseDown:]): Ditto. (-[WebHTMLView mouseDragged:]): Ditto. (-[WebHTMLView mouseUp:]): Ditto. (-[WebHTMLView keyDown:]): Ditto. (-[WebHTMLView keyUp:]): Ditto. (-[WebHTMLView flagsChanged:]): Ditto. (-[WebHTMLView performKeyEquivalent:]): Ditto. git-svn-id: http://svn.webkit.org/repository/webkit/trunk@43693 268f45cc-cd09-0410-ab3c-d52691b4dbfc -
https://bugs.webkit.org/show_bug.cgi?id=25785mrowe@apple.com authored
Fix <https://bugs.webkit.org/show_bug.cgi?id=25785>. Bug 25785: Segfault in mark when using JSObjectMakeConstructor Reviewed by Oliver Hunt. * API/JSObjectRef.cpp: (JSObjectMakeConstructor): OpaqueJSClass::prototype can return 0. We need to use the default object prototype when it does. * API/tests/testapi.c: (main): Add a test case. * runtime/JSObject.h: (JSC::JSObject::putDirect): Add a clearer assertion for a null value. The assertion on the next line does catch this, but the cause of the failure is not clear from the assertion itself. git-svn-id: http://svn.webkit.org/repository/webkit/trunk@43692 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
rdar://problem/6681868mrowe@apple.com authored
Rubber-stamped by Darin Adler. The meaning of XCODE_VERSION_ACTUAL is more sensible in newer versions of Xcode. Update our logic to select the compiler version to use the more appropriate XCODE_VERSION_MINOR if the version of Xcode supports it, and fall back to XCODE_VERSION_ACTUAL if not. git-svn-id: http://svn.webkit.org/repository/webkit/trunk@43691 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
darin@apple.com authored
* platform/gtk/Skipped: Added new tests to the skipped list. git-svn-id: http://svn.webkit.org/repository/webkit/trunk@43690 268f45cc-cd09-0410-ab3c-d52691b4dbfc -
barraclough@apple.com authored
Reviewed by Geoff Garen. Checking register file bounds should be a ptr comparison (m_end is a Register*). Also, the compare should be unsigned, pointers don'ts go negative. * jit/JIT.cpp: (JSC::JIT::privateCompile): git-svn-id: http://svn.webkit.org/repository/webkit/trunk@43689 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
- 13 May, 2009 29 commits
-
-
simon.fraser@apple.com authored
No review. Fix pixel result after test was changed in r43664. * platform/mac/fast/css/text-overflow-ellipsis-expected.checksum: * platform/mac/fast/css/text-overflow-ellipsis-expected.png: git-svn-id: http://svn.webkit.org/repository/webkit/trunk@43686 268f45cc-cd09-0410-ab3c-d52691b4dbfc -
andersca@apple.com authored
Fix build. * WebCore.NPAPI.exp: git-svn-id: http://svn.webkit.org/repository/webkit/trunk@43681 268f45cc-cd09-0410-ab3c-d52691b4dbfc -
eric@webkit.org authored
Fix invalid memory write seen in HTMLCanvasElement by Valgrind https://bugs.webkit.org/show_bug.cgi?id=25759 I can't think of any way to catch this with a layout test, so no test. * css/CSSCanvasValue.cpp: (WebCore::CSSCanvasValue::canvasDestroyed): * css/CSSCanvasValue.h: * html/HTMLCanvasElement.cpp: (WebCore::HTMLCanvasElement::~HTMLCanvasElement): * html/HTMLCanvasElement.h: git-svn-id: http://svn.webkit.org/repository/webkit/trunk@43678 268f45cc-cd09-0410-ab3c-d52691b4dbfc -
bdakin@apple.com authored
Rubber-stamped by Oliver Hunt. Change a bunch of http tests to dumpAsText(). They are currently failing on the Windown Build Bot because of textarea metrics changes, and we have decided that these tests are most valuable as text test anyway. * http/tests/navigation/anchor-basic-expected.txt: Added. * http/tests/navigation/anchor-basic.html: * http/tests/navigation/anchor-goback-expected.txt: Added. * http/tests/navigation/anchor-goback.html: * http/tests/navigation/anchor-subframeload-expected.txt: Added. * http/tests/navigation/anchor-subframeload.html: * http/tests/navigation/javascriptlink-basic-expected.txt: Added. * http/tests/navigation/javascriptlink-basic.html: * http/tests/navigation/javascriptlink-goback-expected.txt: Added. * http/tests/navigation/javascriptlink-goback.html: * http/tests/navigation/javascriptlink-subframeload-expected.txt: Added. * http/tests/navigation/javascriptlink-subframeload.html: * http/tests/navigation/metaredirect-basic-expected.txt: Added. * http/tests/navigation/metaredirect-basic.html: * http/tests/navigation/metaredirect-frames-expected.txt: Added. * http/tests/navigation/metaredirect-frames.html: * http/tests/navigation/metaredirect-goback-expected.txt: Added. * http/tests/navigation/metaredirect-goback.html: * http/tests/navigation/metaredirect-subframeload-expected.txt: Added. * http/tests/navigation/metaredirect-subframeload.html: * http/tests/navigation/post-goback2-expected.txt: Added. * http/tests/navigation/post-goback2.html: * http/tests/navigation/postredirect-goback2-expected.txt: Added. * http/tests/navigation/postredirect-goback2.html: * http/tests/navigation/redirect302-basic-expected.txt: Added. * http/tests/navigation/redirect302-basic.html: * http/tests/navigation/redirect302-frames-expected.txt: Added. * http/tests/navigation/redirect302-frames.html: * http/tests/navigation/redirect302-goback-expected.txt: Added. * http/tests/navigation/redirect302-goback.html: * http/tests/navigation/redirect302-subframeload-expected.txt: Added. * http/tests/navigation/redirect302-subframeload.html: * http/tests/navigation/relativeanchor-basic-expected.txt: Added. * http/tests/navigation/relativeanchor-basic.html: * http/tests/navigation/relativeanchor-frames-expected.txt: Added. * http/tests/navigation/relativeanchor-frames.html: * http/tests/navigation/relativeanchor-goback-expected.txt: Added. * http/tests/navigation/relativeanchor-goback.html: * http/tests/navigation/slowmetaredirect-basic-expected.txt: Added. * http/tests/navigation/slowmetaredirect-basic.html: * http/tests/navigation/slowtimerredirect-basic-expected.txt: Added. * http/tests/navigation/slowtimerredirect-basic.html: * http/tests/navigation/success200-basic-expected.txt: Added. * http/tests/navigation/success200-basic.html: * http/tests/navigation/success200-frames-expected.txt: Added. * http/tests/navigation/success200-frames-loadsame-expected.txt: Added. * http/tests/navigation/success200-frames-loadsame.html: * http/tests/navigation/success200-frames.html: * http/tests/navigation/success200-goback-expected.txt: Added. * http/tests/navigation/success200-goback.html: * http/tests/navigation/success200-loadsame-expected.txt: Added. * http/tests/navigation/success200-loadsame.html: * http/tests/navigation/success200-reload-expected.txt: Added. * http/tests/navigation/success200-reload.html: * http/tests/navigation/success200-subframeload-expected.txt: Added. * http/tests/navigation/success200-subframeload.html: * http/tests/navigation/timerredirect-basic-expected.txt: Added. * http/tests/navigation/timerredirect-basic.html: * http/tests/navigation/timerredirect-frames-expected.txt: Added. * http/tests/navigation/timerredirect-frames.html: * http/tests/navigation/timerredirect-goback-expected.txt: Added. * http/tests/navigation/timerredirect-goback.html: * http/tests/navigation/timerredirect-subframeload-expected.txt: Added. * http/tests/navigation/timerredirect-subframeload.html: * platform/mac/http/tests/navigation/anchor-basic-expected.checksum: Removed. * platform/mac/http/tests/navigation/anchor-basic-expected.png: Removed. * platform/mac/http/tests/navigation/anchor-basic-expected.txt: Removed. * platform/mac/http/tests/navigation/anchor-goback-expected.checksum: Removed. * platform/mac/http/tests/navigation/anchor-goback-expected.png: Removed. * platform/mac/http/tests/navigation/anchor-goback-expected.txt: Removed. * platform/mac/http/tests/navigation/anchor-subframeload-expected.checksum: Removed. * platform/mac/http/tests/navigation/anchor-subframeload-expected.png: Removed. * platform/mac/http/tests/navigation/anchor-subframeload-expected.txt: Removed. * platform/mac/http/tests/navigation/javascriptlink-basic-expected.checksum: Removed. * platform/mac/http/tests/navigation/javascriptlink-basic-expected.png: Removed. * platform/mac/http/tests/navigation/javascriptlink-basic-expected.txt: Removed. * platform/mac/http/tests/navigation/javascriptlink-goback-expected.checksum: Removed. * platform/mac/http/tests/navigation/javascriptlink-goback-expected.png: Removed. * platform/mac/http/tests/navigation/javascriptlink-goback-expected.txt: Removed. * platform/mac/http/tests/navigation/javascriptlink-subframeload-expected.checksum: Removed. * platform/mac/http/tests/navigation/javascriptlink-subframeload-expected.png: Removed. * platform/mac/http/tests/navigation/javascriptlink-subframeload-expected.txt: Removed. * platform/mac/http/tests/navigation/metaredirect-basic-expected.checksum: Removed. * platform/mac/http/tests/navigation/metaredirect-basic-expected.png: Removed. * platform/mac/http/tests/navigation/metaredirect-basic-expected.txt: Removed. * platform/mac/http/tests/navigation/metaredirect-frames-expected.checksum: Removed. * platform/mac/http/tests/navigation/metaredirect-frames-expected.png: Removed. * platform/mac/http/tests/navigation/metaredirect-frames-expected.txt: Removed. * platform/mac/http/tests/navigation/metaredirect-goback-expected.checksum: Removed. * platform/mac/http/tests/navigation/metaredirect-goback-expected.png: Removed. * platform/mac/http/tests/navigation/metaredirect-goback-expected.txt: Removed. * platform/mac/http/tests/navigation/metaredirect-subframeload-expected.checksum: Removed. * platform/mac/http/tests/navigation/metaredirect-subframeload-expected.png: Removed. * platform/mac/http/tests/navigation/metaredirect-subframeload-expected.txt: Removed. * platform/mac/http/tests/navigation/post-goback2-expected.checksum: Removed. * platform/mac/http/tests/navigation/post-goback2-expected.png: Removed. * platform/mac/http/tests/navigation/post-goback2-expected.txt: Removed. * platform/mac/http/tests/navigation/postredirect-goback2-expected.checksum: Removed. * platform/mac/http/tests/navigation/postredirect-goback2-expected.png: Removed. * platform/mac/http/tests/navigation/postredirect-goback2-expected.txt: Removed. * platform/mac/http/tests/navigation/redirect302-basic-expected.checksum: Removed. * platform/mac/http/tests/navigation/redirect302-basic-expected.png: Removed. * platform/mac/http/tests/navigation/redirect302-basic-expected.txt: Removed. * platform/mac/http/tests/navigation/redirect302-frames-expected.checksum: Removed. * platform/mac/http/tests/navigation/redirect302-frames-expected.png: Removed. * platform/mac/http/tests/navigation/redirect302-frames-expected.txt: Removed. * platform/mac/http/tests/navigation/redirect302-goback-expected.checksum: Removed. * platform/mac/http/tests/navigation/redirect302-goback-expected.png: Removed. * platform/mac/http/tests/navigation/redirect302-goback-expected.txt: Removed. * platform/mac/http/tests/navigation/redirect302-subframeload-expected.checksum: Removed. * platform/mac/http/tests/navigation/redirect302-subframeload-expected.png: Removed. * platform/mac/http/tests/navigation/redirect302-subframeload-expected.txt: Removed. * platform/mac/http/tests/navigation/relativeanchor-basic-expected.checksum: Removed. * platform/mac/http/tests/navigation/relativeanchor-basic-expected.png: Removed. * platform/mac/http/tests/navigation/relativeanchor-basic-expected.txt: Removed. * platform/mac/http/tests/navigation/relativeanchor-frames-expected.checksum: Removed. * platform/mac/http/tests/navigation/relativeanchor-frames-expected.png: Removed. * platform/mac/http/tests/navigation/relativeanchor-frames-expected.txt: Removed. * platform/mac/http/tests/navigation/relativeanchor-goback-expected.checksum: Removed. * platform/mac/http/tests/navigation/relativeanchor-goback-expected.png: Removed. * platform/mac/http/tests/navigation/relativeanchor-goback-expected.txt: Removed. * platform/mac/http/tests/navigation/slowmetaredirect-basic-expected.checksum: Removed. * platform/mac/http/tests/navigation/slowmetaredirect-basic-expected.png: Removed. * platform/mac/http/tests/navigation/slowmetaredirect-basic-expected.txt: Removed. * platform/mac/http/tests/navigation/slowtimerredirect-basic-expected.checksum: Removed. * platform/mac/http/tests/navigation/slowtimerredirect-basic-expected.png: Removed. * platform/mac/http/tests/navigation/slowtimerredirect-basic-expected.txt: Removed. * platform/mac/http/tests/navigation/success200-basic-expected.checksum: Removed. * platform/mac/http/tests/navigation/success200-basic-expected.png: Removed. * platform/mac/http/tests/navigation/success200-basic-expected.txt: Removed. * platform/mac/http/tests/navigation/success200-frames-expected.checksum: Removed. * platform/mac/http/tests/navigation/success200-frames-expected.png: Removed. * platform/mac/http/tests/navigation/success200-frames-expected.txt: Removed. * platform/mac/http/tests/navigation/success200-frames-loadsame-expected.checksum: Removed. * platform/mac/http/tests/navigation/success200-frames-loadsame-expected.png: Removed. * platform/mac/http/tests/navigation/success200-frames-loadsame-expected.txt: Removed. * platform/mac/http/tests/navigation/success200-goback-expected.checksum: Removed. * platform/mac/http/tests/navigation/success200-goback-expected.png: Removed. * platform/mac/http/tests/navigation/success200-goback-expected.txt: Removed. * platform/mac/http/tests/navigation/success200-loadsame-expected.checksum: Removed. * platform/mac/http/tests/navigation/success200-loadsame-expected.png: Removed. * platform/mac/http/tests/navigation/success200-loadsame-expected.txt: Removed. * platform/mac/http/tests/navigation/success200-reload-expected.checksum: Removed. * platform/mac/http/tests/navigation/success200-reload-expected.png: Removed. * platform/mac/http/tests/navigation/success200-reload-expected.txt: Removed. * platform/mac/http/tests/navigation/success200-subframeload-expected.checksum: Removed. * platform/mac/http/tests/navigation/success200-subframeload-expected.png: Removed. * platform/mac/http/tests/navigation/success200-subframeload-expected.txt: Removed. * platform/mac/http/tests/navigation/timerredirect-basic-expected.checksum: Removed. * platform/mac/http/tests/navigation/timerredirect-basic-expected.png: Removed. * platform/mac/http/tests/navigation/timerredirect-basic-expected.txt: Removed. * platform/mac/http/tests/navigation/timerredirect-frames-expected.checksum: Removed. * platform/mac/http/tests/navigation/timerredirect-frames-expected.png: Removed. * platform/mac/http/tests/navigation/timerredirect-frames-expected.txt: Removed. * platform/mac/http/tests/navigation/timerredirect-goback-expected.checksum: Removed. * platform/mac/http/tests/navigation/timerredirect-goback-expected.png: Removed. * platform/mac/http/tests/navigation/timerredirect-goback-expected.txt: Removed. * platform/mac/http/tests/navigation/timerredirect-subframeload-expected.checksum: Removed. * platform/mac/http/tests/navigation/timerredirect-subframeload-expected.png: Removed. * platform/mac/http/tests/navigation/timerredirect-subframeload-expected.txt: Removed. git-svn-id: http://svn.webkit.org/repository/webkit/trunk@43677 268f45cc-cd09-0410-ab3c-d52691b4dbfc -
andersca@apple.com authored
Reviewed by Sam Weinig. WebKit side of <rdar://problem/6884476>. * Plugins/Hosted/NetscapePluginHostProxy.mm: (WKPCGetLocation): Forward this to the plug-in instance proxy. * Plugins/Hosted/NetscapePluginInstanceProxy.h: * Plugins/Hosted/NetscapePluginInstanceProxy.mm: (WebKit::NetscapePluginInstanceProxy::getLocation): Ask the plug-in view for the location. * Plugins/Hosted/WebKitPluginClient.defs: Add MIG definition. * Plugins/WebBaseNetscapePluginView.h: * Plugins/WebBaseNetscapePluginView.mm: (-[WebBaseNetscapePluginView locationStringForTarget:]): Return the URL for a given frame. * Plugins/WebNetscapeContainerCheckPrivate.h: Bump version. Add new declaration to the vtable. * Plugins/WebNetscapeContainerCheckPrivate.mm: (browserContainerCheckFuncs): Add new declaration to the vtable. * Plugins/WebNetscapePluginView.h: * Plugins/WebNetscapePluginView.mm: (-[WebNetscapePluginView locationForTarget:]): Call the base class method. * Plugins/npapi.mm: (WKN_GetLocation): Forward this to the plug-in view. git-svn-id: http://svn.webkit.org/repository/webkit/trunk@43676 268f45cc-cd09-0410-ab3c-d52691b4dbfc -
darin@apple.com authored
Reviewed by Darin Adler. <rdar://problem/6871587> Smart Copy/Paste setting should persist as continuous spell checking setting does * WebView/WebPreferenceKeysPrivate.h: Added WebSmartInsertDeleteEnabled. * WebView/WebView.mm: (-[WebViewPrivate init]): Initialize based on WebSmartInsertDeleteEnabled default. (-[WebView _commonInitializationWithFrameName:groupName:usesDocumentViews:]): Removed code that initialized here. (-[WebView setSmartInsertDeleteEnabled:]): Set default here was with continuous spell checking setting. git-svn-id: http://svn.webkit.org/repository/webkit/trunk@43675 268f45cc-cd09-0410-ab3c-d52691b4dbfc -
mitz@apple.com authored
Reviewed by Anders Carlsson. - fix <rdar://problem/5483015> Replies in Mail are drawn first without the user style sheet and then redrawn with the style sheet Test: platform/mac/fast/loader/user-stylesheet-fast-path.html * page/mac/FrameMac.mm: (WebCore::Frame::setUserStyleSheetLocation): For data URLs with base64-encoded UTF-8 data, just decode the style sheet here an apply it synchronously instead of invoking an asynchronous loader. LayoutTests: Reviewed by Anders Carlsson. - test for <rdar://problem/5483015> Replies in Mail are drawn first without the user style sheet and then redrawn with the style sheet * platform/mac/fast/loader/user-stylesheet-fast-path-expected.txt: Added. * platform/mac/fast/loader/user-stylesheet-fast-path.html: Added. git-svn-id: http://svn.webkit.org/repository/webkit/trunk@43672 268f45cc-cd09-0410-ab3c-d52691b4dbfc -
cfleizach@apple.com authored
https://bugs.webkit.org/show_bug.cgi?id=25755 Fix windows build bustage git-svn-id: http://svn.webkit.org/repository/webkit/trunk@43670 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
cfleizach@apple.com authored
https://bugs.webkit.org/show_bug.cgi?id=25755 git-svn-id: http://svn.webkit.org/repository/webkit/trunk@43669 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
barraclough@apple.com authored
Reviewed by Oliver Hunt. Fix <rdar://problem/6882919> REGRESSION: page at Metroauto site crashes in cti_op_loop_if_less (25730) op_loop_if_less (imm < op) was loading op into regT1, but in the slow path spills regT0. This leads to bad happen. * jit/JITOpcodes.cpp: (JSC::JIT::emit_op_loop_if_less): (JSC::JIT::emitSlow_op_loop_if_less): git-svn-id: http://svn.webkit.org/repository/webkit/trunk@43667 268f45cc-cd09-0410-ab3c-d52691b4dbfc -
levin@chromium.org authored
Reviewed by Dimitri Glazkov. Bug 25763: Need to move v8 custom binding to the custom directory. https://bugs.webkit.org/show_bug.cgi?id=25763 No test due to no change in behavior. * bindings/v8/custom/V8CanvasPixelArrayCustom.cpp: Renamed from WebCore/bindings/v8/V8CanvasPixelArrayCustom.cpp. git-svn-id: http://svn.webkit.org/repository/webkit/trunk@43666 268f45cc-cd09-0410-ab3c-d52691b4dbfc -
dglazkov@chromium.org authored
Reviewed by Dimitri Glazkov. Fix LayoutTests/fast/dom/Element/attr-param-typechecking.html crashing with V8. https://bugs.webkit.org/show_bug.cgi?id=25758 * bindings/v8/custom/V8ElementCustom.cpp: (WebCore::CALLBACK_FUNC_DECL): return the result of throwError() if it is called. git-svn-id: http://svn.webkit.org/repository/webkit/trunk@43665 268f45cc-cd09-0410-ab3c-d52691b4dbfc -
dglazkov@chromium.org authored
2009-05-13 Jeremy Moskovich <jeremy@chromium.org> Reviewed by Dave Hyatt. Fix a number of bugs relating to RTL and text-overflow:ellipsis. Also refactor the relevant code to make it a little clearer. This CL fixes 3 fundamental issues: - Corrects behavior if the truncated InlineTextBox's directionality is different from the overall flow direction - bug 25135. - Make decoration drawing in InlineFlowbox RTL-aware - bug 24206. - Full truncation on InlineBoxes in RTL flow - bug 24186 - Add tests for the above + reorder/cleanup tests for easier interpretation of outcome. The code for placing ellipsis has been refactored to use left/right notation rather than a single variable whose meaning could differ based on flow directionality. To support differing inline directionality vs flow directionality, different variables are now used in InlineTextBox::placeEllipsisBox to track the two. The drawing mode for underlines in standards mode now correctly handles RTL truncation and relevant test where added. https://bugs.webkit.org/show_bug.cgi?id=24186 https://bugs.webkit.org/show_bug.cgi?id=25135 https://bugs.webkit.org/show_bug.cgi?id=24206 Tests: fast/css/text-overflow-ellipsis-bidi.html fast/css/text-overflow-ellipsis-strict.html * rendering/InlineBox.cpp: (WebCore::InlineBox::placeEllipsisBox): * rendering/InlineBox.h: * rendering/InlineFlowBox.cpp: (WebCore::InlineFlowBox::paintTextDecorations): (WebCore::InlineFlowBox::placeEllipsisBox): * rendering/InlineFlowBox.h: * rendering/InlineTextBox.cpp: (WebCore::InlineTextBox::placeEllipsisBox): (WebCore::InlineTextBox::paint): * rendering/InlineTextBox.h: * rendering/RenderFlexibleBox.cpp: (WebCore::RenderFlexibleBox::layoutVerticalBox): * rendering/RootInlineBox.cpp: (WebCore::RootInlineBox::placeEllipsis): (WebCore::RootInlineBox::placeEllipsisBox): * rendering/RootInlineBox.h: * rendering/bidi.cpp: (WebCore::RenderBlock::checkLinesForTextOverflow): LayoutTests: 2009-05-13 Jeremy Moskovich <jeremy@chromium.org> Reviewed by Dave Hyatt. Fix a number of bugs relating to RTL and text-overflow:ellipsis. Also refactor the relevant code to make it a little clearer. This CL fixes 3 fundamental issues: - Corrects behavior if the truncated InlineTextBox's directionality is different from the overall flow direction - bug 25135. - Make decoration drawing in InlineFlowbox RTL-aware - bug 24206. - Full truncation on InlineBoxes in RTL flow - bug 24186 - Add tests for the above + reorder/cleanup tests for easier interpretation of outcome. The code for placing ellipsis has been refactored to use left/right notation rather than a single variable whose meaning could differ based on flow directionality. To support differing inline directionality vs flow directionality, different variables are now used in InlineTextBox::placeEllipsisBox to track the two. The drawing mode for underlines in standards mode now correctly handles RTL truncation and relevant test where added. https://bugs.webkit.org/show_bug.cgi?id=24186 https://bugs.webkit.org/show_bug.cgi?id=25135 https://bugs.webkit.org/show_bug.cgi?id=24206 * fast/css/text-overflow-ellipsis-bidi.html: Added. * fast/css/text-overflow-ellipsis-strict.html: Added. * fast/css/text-overflow-ellipsis.html: * platform/mac/fast/css/text-overflow-ellipsis-bidi-expected.checksum: Added. * platform/mac/fast/css/text-overflow-ellipsis-bidi-expected.png: Added. * platform/mac/fast/css/text-overflow-ellipsis-bidi-expected.txt: Added. * platform/mac/fast/css/text-overflow-ellipsis-expected.txt: * platform/mac/fast/css/text-overflow-ellipsis-strict-expected.checksum: Added. * platform/mac/fast/css/text-overflow-ellipsis-strict-expected.png: Added. * platform/mac/fast/css/text-overflow-ellipsis-strict-expected.txt: Added. git-svn-id: http://svn.webkit.org/repository/webkit/trunk@43664 268f45cc-cd09-0410-ab3c-d52691b4dbfc -
dimich@chromium.org authored
2009-05-13 Dmitry Titov <dimich@chromium.org> Rubber-stamped by Mark Rowe. https://bugs.webkit.org/show_bug.cgi?id=25746 Revert http://trac.webkit.org/changeset/43507 which caused crash in PPC nightlies with Safari 4. * JavaScriptCore.exp: * JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def: * JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore_debug.def: * bytecode/SamplingTool.cpp: (JSC::SamplingThread::start): (JSC::SamplingThread::stop): * bytecode/SamplingTool.h: * wtf/CrossThreadRefCounted.h: (WTF::CrossThreadRefCounted::CrossThreadRefCounted): (WTF::::ref): (WTF::::deref): * wtf/Threading.h: * wtf/ThreadingNone.cpp: * wtf/ThreadingPthreads.cpp: (WTF::threadMapMutex): (WTF::initializeThreading): (WTF::threadMap): (WTF::identifierByPthreadHandle): (WTF::establishIdentifierForPthreadHandle): (WTF::pthreadHandleForIdentifier): (WTF::clearPthreadHandleForIdentifier): (WTF::createThreadInternal): (WTF::waitForThreadCompletion): (WTF::detachThread): (WTF::currentThread): * wtf/ThreadingWin.cpp: (WTF::threadMapMutex): (WTF::initializeThreading): (WTF::threadMap): (WTF::storeThreadHandleByIdentifier): (WTF::threadHandleForIdentifier): (WTF::clearThreadHandleForIdentifier): (WTF::createThreadInternal): (WTF::waitForThreadCompletion): (WTF::detachThread): (WTF::currentThread): * wtf/gtk/ThreadingGtk.cpp: (WTF::threadMapMutex): (WTF::initializeThreading): (WTF::threadMap): (WTF::identifierByGthreadHandle): (WTF::establishIdentifierForThread): (WTF::threadForIdentifier): (WTF::clearThreadForIdentifier): (WTF::createThreadInternal): (WTF::waitForThreadCompletion): (WTF::currentThread): * wtf/qt/ThreadingQt.cpp: (WTF::threadMapMutex): (WTF::threadMap): (WTF::identifierByQthreadHandle): (WTF::establishIdentifierForThread): (WTF::clearThreadForIdentifier): (WTF::threadForIdentifier): (WTF::initializeThreading): (WTF::createThreadInternal): (WTF::waitForThreadCompletion): (WTF::currentThread): WebCore: 2009-05-13 Dmitry Titov <dimich@chromium.org> Rubber-stamped by Mark Rowe. https://bugs.webkit.org/show_bug.cgi?id=25746 Revert http://trac.webkit.org/changeset/43507 which caused crash in PPC nightlies with Safari 4. * dom/XMLTokenizerLibxml2.cpp: (WebCore::matchFunc): (WebCore::openFunc): (WebCore::createStringParser): (WebCore::createMemoryParser): * loader/icon/IconDatabase.cpp: (WebCore::IconDatabase::open): * platform/sql/SQLiteDatabase.cpp: (WebCore::SQLiteDatabase::SQLiteDatabase): (WebCore::SQLiteDatabase::close): * storage/DatabaseThread.cpp: (WebCore::DatabaseThread::DatabaseThread): (WebCore::DatabaseThread::start): (WebCore::DatabaseThread::databaseThread): * storage/LocalStorageThread.cpp: (WebCore::LocalStorageThread::LocalStorageThread): (WebCore::LocalStorageThread::start): (WebCore::LocalStorageThread::localStorageThread): (WebCore::LocalStorageThread::scheduleImport): (WebCore::LocalStorageThread::scheduleSync): (WebCore::LocalStorageThread::terminate): * workers/WorkerThread.cpp: (WebCore::WorkerThread::WorkerThread): (WebCore::WorkerThread::start): WebKit/win: 2009-05-13 Dmitry Titov <dimich@chromium.org> Rubber-stamped by Mark Rowe. https://bugs.webkit.org/show_bug.cgi?id=25746 Revert http://trac.webkit.org/changeset/43507 which caused crash in PPC nightlies with Safari 4. * WebKit.vcproj/WebKit.def: * WebKit.vcproj/WebKit_debug.def: git-svn-id: http://svn.webkit.org/repository/webkit/trunk@43663 268f45cc-cd09-0410-ab3c-d52691b4dbfc -
hyatt@apple.com authored
2009-05-13 David Hyatt <hyatt@apple.com> Reviewed by Beth Dakin. Fix for <rdar://problem/6872894> REGRESSION (r41896-42143): First letter cut off in styled select menus Make sure to do rounded clipping for overflow and controls relative to the border box and not to the overflow/control clip rect (which is typically clipped to the padding or content box). Doing so was causing rounded clips to be incorrectly applied to padding and content. Added fast/overflow/border-radius-clipping.html * rendering/RenderBox.cpp: (WebCore::RenderBox::pushContentsClip): LayoutTests: 2009-05-13 David Hyatt <hyatt@apple.com> Reviewed by Beth Dakin. Add layout test for <rdar://problem/6872894> REGRESSION (r41896-42143): First letter cut off in styled select menus. * fast/overflow/border-radius-clipping.html: Added. * platform/mac/fast/overflow/border-radius-clipping-expected.checksum: Added. * platform/mac/fast/overflow/border-radius-clipping-expected.png: Added. * platform/mac/fast/overflow/border-radius-clipping-expected.txt: Added. git-svn-id: http://svn.webkit.org/repository/webkit/trunk@43662 268f45cc-cd09-0410-ab3c-d52691b4dbfc -
darin@apple.com authored
2009-05-13 Darin Adler <darin@apple.com> Revert the parser arena change. It was a slowdown, not a speedup. Better luck next time (I'll break it up into pieces). WebCore: 2009-05-13 Darin Adler <darin@apple.com> Revert the parser arena change. It was a slowdown, not a speedup. Better luck next time (I'll break it up into pieces). WebKit/mac: 2009-05-13 Darin Adler <darin@apple.com> Revert the parser arena change. It was a slowdown, not a speedup. Better luck next time (I'll break it up into pieces). git-svn-id: http://svn.webkit.org/repository/webkit/trunk@43661 268f45cc-cd09-0410-ab3c-d52691b4dbfc -
alice.liu@apple.com authored
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@43658 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
hyatt@apple.com authored
2009-05-13 David Hyatt <hyatt@apple.com> Reviewed by Beth Dakin and Darin Adler. Fix for <rdar://problem/6869687> REGRESSION (r41203): Facebook friend suggestions disappear on update. Make sure that renderers are marked for layout if a style change causes them to switch from having a self-painting layer to a non-self-painting layer (and vice versa). Move misplaced layer repainting code that was in RenderBox up into RenderBoxModelObject so that inlines with layers repaint properly on opacity changes, etc. Added fast/repaint/opacity-change-on-overflow-float.html. * rendering/RenderBox.cpp: (WebCore::RenderBox::styleWillChange): * rendering/RenderBoxModelObject.cpp: (WebCore::RenderBoxModelObject::styleWillChange): (WebCore::RenderBoxModelObject::styleDidChange): * rendering/RenderBoxModelObject.h: LayoutTests: 2009-05-13 David Hyatt <hyatt@apple.com> Reviewed by Beth Dakin and Darin Adler. Add a repaint test for <rdar://problem/6869687> REGRESSION (r41203): Facebook friend suggestions disappear on update. * fast/repaint/opacity-change-on-overflow-float.html: Added. * platform/mac/fast/repaint/opacity-change-on-overflow-float-expected.checksum: Added. * platform/mac/fast/repaint/opacity-change-on-overflow-float-expected.png: Added. * platform/mac/fast/repaint/opacity-change-on-overflow-float-expected.txt: Added. git-svn-id: http://svn.webkit.org/repository/webkit/trunk@43657 268f45cc-cd09-0410-ab3c-d52691b4dbfc -
kov@webkit.org authored
Disable new tests. We are not going to be adding more new test results for now, for we want to better sort out things such as fixed DPI, and easily reproducible font configuration. * platform/gtk/Skipped: git-svn-id: http://svn.webkit.org/repository/webkit/trunk@43655 268f45cc-cd09-0410-ab3c-d52691b4dbfc -
darin@apple.com authored
Tiger build fix. * parser/Grammar.y: Add back empty code blocks, needed by older versions of bison on certain rules. git-svn-id: http://svn.webkit.org/repository/webkit/trunk@43654 268f45cc-cd09-0410-ab3c-d52691b4dbfc -
dglazkov@chromium.org authored
Not reviewed, build fix. Move an include, needed by Debugger under the corresponding guard. * inspector/InspectorController.cpp: Moved parser/SourceCode under JAVASCRIPT_DEBUGGER guard. git-svn-id: http://svn.webkit.org/repository/webkit/trunk@43652 268f45cc-cd09-0410-ab3c-d52691b4dbfc -
levin@chromium.org authored
2009-05-13 David Levin <levin@chromium.org> Reviewed by Darin Adler. Bug 25394: REGRESSION: crash in DocumentLoader::addResponse due to bad |this| pointer https://bugs.webkit.org/show_bug.cgi?id=25394 Test: http/tests/xmlhttprequest/frame-unload-abort-crash.html * loader/SubresourceLoader.cpp: (WebCore::SubresourceLoader::create): Add another check to subresource loader to avoid doing any loads in frames when the loaders are being stopped. LayoutTests: 2009-05-13 David Levin <levin@chromium.org> Reviewed by Darin Adler. Bug 25394: REGRESSION: crash in DocumentLoader::addResponse due to bad |this| pointer https://bugs.webkit.org/show_bug.cgi?id=25394 Request a subresource load for an IMG after 'unload' and before the next page load completes to expose the crash. * http/tests/xmlhttprequest/frame-unload-abort-crash-expected.txt: Added. * http/tests/xmlhttprequest/frame-unload-abort-crash.html: Added. * http/tests/xmlhttprequest/resources/xmlhttprequest-in-unload.html: Added. git-svn-id: http://svn.webkit.org/repository/webkit/trunk@43650 268f45cc-cd09-0410-ab3c-d52691b4dbfc -
kov@webkit.org authored
Reviewed by Gustavo Noronha. Wrong handling of file upload if no file selected https://bugs.webkit.org/show_bug.cgi?id=25649 Fixed returned path if path is empty * WebCore/platform/gtk/FileSystemGtk.cpp: git-svn-id: http://svn.webkit.org/repository/webkit/trunk@43649 268f45cc-cd09-0410-ab3c-d52691b4dbfc -
sfalken@apple.com authored
* JavaScriptCore.vcproj/jsc/jsc.vcproj: git-svn-id: http://svn.webkit.org/repository/webkit/trunk@43648 268f45cc-cd09-0410-ab3c-d52691b4dbfc -
aroben@apple.com authored
* JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def: * JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore_debug.def: Updated. * debugger/Debugger.cpp: * runtime/ArrayConstructor.cpp: * runtime/JSArray.cpp: * runtime/RegExp.cpp: * runtime/RegExpConstructor.cpp: * runtime/RegExpPrototype.cpp: * runtime/StringPrototype.cpp: Added missing #includes. git-svn-id: http://svn.webkit.org/repository/webkit/trunk@43647 268f45cc-cd09-0410-ab3c-d52691b4dbfc -
mitz@apple.com authored
Reviewed by Dave Hyatt. - fix <rdar://problem/6805567> REGRESSION (r42348): Notes flicker white when loading Tests: fast/frames/content-opacity-1.html fast/frames/content-opacity-2.html * page/FrameView.cpp: (WebCore::FrameView::reset): Reset m_contentIsOpaque to false. (WebCore::FrameView::useSlowRepaints): Use slow repaints if the content is not known to be opaque. (WebCore::FrameView::setContentIsOpaque): Added. Sets m_contentIsOpaque and enables or disables fast repaints accordingly. * page/FrameView.h: * rendering/RenderBoxModelObject.cpp: (WebCore::RenderBoxModelObject::paintFillLayerExtended): Removed the document()->haveStylesheetsLoaded() condition in determining whether the root is opaque. This is what was causing the bug, as iframes were considered to be opaque, and thus painted an opaque white background, whenever they were pending a style sheet load. Changed to call FrameView::setContentIsOpaqe() instead of setUseSlowRepaints(), which allows the frame to go back to fast repaints if the content becomes opaque. Corrected the check for background color opacity: any alpha value other than 255--not just zero--is not opaque. LayoutTests: Reviewed by Dave Hyatt. - tests for <rdar://problem/6805567> REGRESSION (r42348): Notes flicker white when loading * fast/frames/content-opacity-1.html: Added. * fast/frames/content-opacity-2.html: Added. * platform/mac/fast/frames/content-opacity-1-expected.checksum: Added. * platform/mac/fast/frames/content-opacity-1-expected.png: Added. * platform/mac/fast/frames/content-opacity-1-expected.txt: Added. * platform/mac/fast/frames/content-opacity-2-expected.checksum: Added. * platform/mac/fast/frames/content-opacity-2-expected.png: Added. * platform/mac/fast/frames/content-opacity-2-expected.txt: Added. git-svn-id: http://svn.webkit.org/repository/webkit/trunk@43646 268f45cc-cd09-0410-ab3c-d52691b4dbfc -
ariya@webkit.org authored
Reviewed by Sam Weinig. [Qt] Fix "lighther" composition mode. QPainter::CompositionMode_Plus is the right match. * platform/graphics/qt/GraphicsContextQt.cpp: (WebCore::toQtCompositionMode): git-svn-id: http://svn.webkit.org/repository/webkit/trunk@43645 268f45cc-cd09-0410-ab3c-d52691b4dbfc -
xan@webkit.org authored
Reviewed by Gustavo Noronha. Do not handle KeyEvents with Ctrl or Alt modifiers that we otherwise know nothing about. Otherwise shortcuts defined in the WebView will never be executed. * WebCoreSupport/EditorClientGtk.cpp: (WebKit::handleEditingKeyboardEvent): git-svn-id: http://svn.webkit.org/repository/webkit/trunk@43644 268f45cc-cd09-0410-ab3c-d52691b4dbfc -
darin@apple.com authored
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@43643 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
