- 09 Jan, 2014 10 commits
-
-
commit-queue@webkit.org authored
http://trac.webkit.org/changeset/161540 https://bugs.webkit.org/show_bug.cgi?id=126704 Caused assertion failures on multiple tests (Requested by ap on #webkit). Source/JavaScriptCore: * bytecode/CodeBlock.cpp: (JSC::CodeBlock::visitAggregate): * bytecode/CodeBlock.h: (JSC::CodeBlockSet::mark): * dfg/DFGOperations.cpp: * heap/CodeBlockSet.cpp: (JSC::CodeBlockSet::add): (JSC::CodeBlockSet::traceMarked): * heap/CodeBlockSet.h: * heap/CopiedBlockInlines.h: (JSC::CopiedBlock::reportLiveBytes): * heap/CopiedSpace.cpp: * heap/CopiedSpace.h: * heap/Heap.cpp: (JSC::Heap::Heap): (JSC::Heap::didAbandon): (JSC::Heap::markRoots): (JSC::Heap::copyBackingStores): (JSC::Heap::collectAllGarbage): (JSC::Heap::collect): (JSC::Heap::didAllocate): * heap/Heap.h: (JSC::Heap::shouldCollect): (JSC::Heap::isCollecting): (JSC::Heap::isWriteBarrierEnabled): (JSC::Heap::writeBarrier): * heap/HeapOperation.h: * heap/MarkStack.cpp: (JSC::MarkStackArray::~MarkStackArray): * heap/MarkStack.h: * heap/MarkedAllocator.cpp: (JSC::MarkedAllocator::isPagedOut): (JSC::MarkedAllocator::tryAllocateHelper): (JSC::MarkedAllocator::addBlock): (JSC::MarkedAllocator::removeBlock): * heap/MarkedAllocator.h: (JSC::MarkedAllocator::MarkedAllocator): (JSC::MarkedAllocator::reset): * heap/MarkedBlock.cpp: * heap/MarkedBlock.h: (JSC::MarkedBlock::lastChanceToFinalize): (JSC::MarkedBlock::didConsumeEmptyFreeList): (JSC::MarkedBlock::clearMarks): * heap/MarkedSpace.cpp: (JSC::MarkedSpace::~MarkedSpace): (JSC::MarkedSpace::resetAllocators): (JSC::MarkedSpace::visitWeakSets): (JSC::MarkedSpace::reapWeakSets): * heap/MarkedSpace.h: (JSC::ClearMarks::operator()): (JSC::MarkedSpace::clearMarks): * heap/SlotVisitor.cpp: (JSC::SlotVisitor::~SlotVisitor): * heap/SlotVisitor.h: (JSC::SlotVisitor::sharedData): * heap/SlotVisitorInlines.h: (JSC::SlotVisitor::internalAppend): (JSC::SlotVisitor::copyLater): (JSC::SlotVisitor::reportExtraMemoryUsage): * jit/Repatch.cpp: * runtime/JSGenericTypedArrayViewInlines.h: (JSC::JSGenericTypedArrayView<Adaptor>::visitChildren): * runtime/JSPropertyNameIterator.h: (JSC::StructureRareData::setEnumerationCache): * runtime/JSString.cpp: (JSC::JSString::visitChildren): * runtime/StructureRareDataInlines.h: (JSC::StructureRareData::setPreviousID): (JSC::StructureRareData::setObjectToStringValue): * runtime/WeakMapData.cpp: (JSC::WeakMapData::visitChildren): Source/WTF: * wtf/Bitmap.h: (WTF::WordType>::count): git-svn-id: http://svn.webkit.org/repository/webkit/trunk@161557 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
seokju@webkit.org authored
https://bugs.webkit.org/show_bug.cgi?id=126630 Reviewed by Timothy Hatcher. Source/WebCore: No new tests, No change in behavior. Remove unused overriding protocols as these are not used anymore in Frontned. -Page.setGeolocationOverride -Page.clearGeolocationOverride -Page.canOverrideGeolocation -Page.setDeviceOrientationOverride -Page.clearDeviceOrientationOverride -Page.canOverrideGeolocation -Network.setUserAgentOverride * Modules/geolocation/GeolocationController.cpp: (WebCore::GeolocationController::GeolocationController): (WebCore::GeolocationController::create): (WebCore::GeolocationController::positionChanged): (WebCore::provideGeolocationTo): * Modules/geolocation/GeolocationController.h: * dom/DeviceOrientationController.cpp: (WebCore::DeviceOrientationController::DeviceOrientationController): (WebCore::DeviceOrientationController::create): (WebCore::DeviceOrientationController::didChangeDeviceOrientation): (WebCore::provideDeviceOrientationTo): * dom/DeviceOrientationController.h: * inspector/InspectorInstrumentation.cpp: * inspector/InspectorInstrumentation.h: * inspector/InspectorPageAgent.cpp: (WebCore::InspectorPageAgent::InspectorPageAgent): * inspector/InspectorPageAgent.h: * inspector/InspectorResourceAgent.cpp: (WebCore::InspectorResourceAgent::disable): * inspector/InspectorResourceAgent.h: * inspector/protocol/Network.json: * inspector/protocol/Page.json: * loader/FrameLoader.cpp: (WebCore::FrameLoader::userAgent): Source/WebInspectorUI: Update InspectorWebBackendCommands.js after removing unused overriding protocols. * UserInterface/InspectorWebBackendCommands.js: * UserInterface/Legacy/6.0/InspectorWebBackendCommands.js: * UserInterface/Legacy/7.0/InspectorWebBackendCommands.js: * Versions/Inspector-iOS-6.0.json: * Versions/Inspector-iOS-7.0.json: LayoutTests: * http/tests/inspector/extensions-useragent-expected.txt: Removed. * http/tests/inspector/extensions-useragent.html: Removed. * inspector/device-orientation-success-expected.txt: Removed. * inspector/device-orientation-success.html: Removed. * inspector/geolocation-error-expected.txt: Removed. * inspector/geolocation-error.html: Removed. * inspector/geolocation-success-expected.txt: Removed. * inspector/geolocation-success.html: Removed. * inspector/geolocation-watchPosition-expected.txt: Removed. * inspector/geolocation-watchPosition.html: Removed. git-svn-id: http://svn.webkit.org/repository/webkit/trunk@161556 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
carlosgc@webkit.org authored
https://bugs.webkit.org/show_bug.cgi?id=126686 Reviewed by Martin Robinson. Source/WebKit2: We are currently writing the downloads directly into the destination, and when a download fails or is cancelled after the destination has been decided, the partial file is left on the disk. Deleting the final file is not safe because there might be a race condition, so we can use an intermediate file like other browsers do, a file in the same directory than the target destination but with .wkdownload suffix, that is removed when the download fails or is cancelled. If the download finishes successfully the intermediate file is renamed to the final destination. * Shared/Downloads/soup/DownloadSoup.cpp: (WebKit::DownloadClient::deleteIntermediateFileInNeeded): Delete the intermdiate file if it's been created already. (WebKit::DownloadClient::downloadFailed): Call deleteIntermediateFileInNeeded. (WebKit::DownloadClient::didReceiveResponse): Do not create a SoupMessage for the given ResourceResponse that is not used, cache the ResourceResponse instead. Create the intermediate file and use it instead of the final destination. (WebKit::DownloadClient::didReceiveData): Use the cached ResourceResponse directly. (WebKit::DownloadClient::didFinishLoading): Rename the intermediate file to the final destination and write the metadata in the final target destination. (WebKit::DownloadClient::cancel): Handle the download cancellation here, removing the intermediate file is needed and cancelling the ResourceHandle and the download. (WebKit::DownloadClient::handleResponseLater): (WebKit::Download::cancel): Let the client handle the cancellation. Tools: Test that partial files are not left on disk after a download has been cancelled after the destination has been decided. To make sure the download is cancelled after the destination has been decided and before the operation finishes, we cancel the download in the destination decided callback, and we use an infinite resource that writes chunks to the response body and never completes the body. * TestWebKitAPI/Tests/WebKit2Gtk/TestDownloads.cpp: (addContentDispositionHTTPHeaderToResponse): Helper function to add the Content-Disposition to the response headers. (writeNextChunkIdle): Write next chunk to response body. (writeNextChunk): Write next chunk in an idle to avoid flooding the network with the inifnite resource. (serverCallback): Add an inifinite resource. (testDownloadRemoteFileError): Check that partial file is not present after the download has been cancelled. git-svn-id: http://svn.webkit.org/repository/webkit/trunk@161555 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
akling@apple.com authored
<https://webkit.org/b/126694> Reorder the members of WatchpointSet, shrinking it by 8 bytes. 767 kB progression on Membuster3. Reviewed by Antti Koivisto. * bytecode/Watchpoint.h: git-svn-id: http://svn.webkit.org/repository/webkit/trunk@161554 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
abucur@adobe.com authored
https://bugs.webkit.org/show_bug.cgi?id=122959 Reviewed by Mihnea Ovidenie. Move the auto-height logic from RenderRegion to RenderNamedFlowFragment because it's used only by the CSS Regions implementation. Bug 126642 covers the auto-height logic move from RenderFlowThread to RenderNamedFlowThread. Tests: No new tests, just refactorings. * rendering/RenderFlowThread.cpp: (WebCore::RenderFlowThread::styleDidChange): (WebCore::RenderFlowThread::validateRegions): (WebCore::RenderFlowThread::isAutoLogicalHeightRegionsCountConsistent): (WebCore::RenderFlowThread::initializeRegionsComputedAutoHeight): (WebCore::RenderFlowThread::markAutoLogicalHeightRegionsForLayout): (WebCore::RenderFlowThread::updateRegionsFlowThreadPortionRect): (WebCore::RenderFlowThread::addForcedRegionBreak): * rendering/RenderMultiColumnSet.h: * rendering/RenderNamedFlowFragment.cpp: (WebCore::RenderNamedFlowFragment::RenderNamedFlowFragment): (WebCore::RenderNamedFlowFragment::styleDidChange): (WebCore::RenderNamedFlowFragment::incrementAutoLogicalHeightCount): (WebCore::RenderNamedFlowFragment::decrementAutoLogicalHeightCount): (WebCore::RenderNamedFlowFragment::updateRegionHasAutoLogicalHeightFlag): (WebCore::RenderNamedFlowFragment::updateLogicalHeight): (WebCore::RenderNamedFlowFragment::pageLogicalHeight): (WebCore::RenderNamedFlowFragment::layoutBlock): (WebCore::RenderNamedFlowFragment::attachRegion): (WebCore::RenderNamedFlowFragment::detachRegion): * rendering/RenderNamedFlowFragment.h: * rendering/RenderRegion.cpp: (WebCore::RenderRegion::RenderRegion): (WebCore::RenderRegion::pageLogicalHeight): (WebCore::RenderRegion::logicalHeightOfAllFlowThreadContent): (WebCore::RenderRegion::isLastRegion): (WebCore::RenderRegion::styleDidChange): (WebCore::RenderRegion::attachRegion): (WebCore::RenderRegion::detachRegion): * rendering/RenderRegion.h: * rendering/RenderRegionSet.h: * rendering/RenderTreeAsText.cpp: (WebCore::writeRenderRegionList): git-svn-id: http://svn.webkit.org/repository/webkit/trunk@161553 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
rtakacs@inf.u-szeged.hu authored
Unreviewed. * Scripts/webkitpy/common/config/contributors.json: git-svn-id: http://svn.webkit.org/repository/webkit/trunk@161552 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
antti@apple.com authored
https://bugs.webkit.org/show_bug.cgi?id=126684 Reviewed by Andreas Kling. This is the last remaining client of Traversal<> outside the iterator implementation. * dom/ElementChildIterator.h: (WebCore::ElementChildIteratorAdapter<ElementType>::find): (WebCore::ElementChildConstIteratorAdapter<ElementType>::find): Add find with the same semantics as ElementDescendantIterator::find. * html/HTMLTableRowsCollection.cpp: (WebCore::HTMLTableRowsCollection::rowAfter): (WebCore::HTMLTableRowsCollection::lastRow): git-svn-id: http://svn.webkit.org/repository/webkit/trunk@161551 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
zandobersek@gmail.com authored
* platform/gtk/css1/text_properties/letter_spacing-expected.png: * platform/gtk/css1/text_properties/letter_spacing-expected.txt: * platform/gtk/css1/text_properties/word_spacing-expected.png: * platform/gtk/css1/text_properties/word_spacing-expected.txt: * platform/gtk/css2.1/t1604-c542-letter-sp-00-b-a-expected.txt: * platform/gtk/fast/text/basic/013-expected.png: * platform/gtk/fast/text/basic/013-expected.txt: * platform/gtk/fast/text/text-letter-spacing-expected.txt: * platform/gtk/svg/W3C-SVG-1.1/text-spacing-01-b-expected.png: * platform/gtk/svg/W3C-SVG-1.1/text-spacing-01-b-expected.txt: Added. * platform/gtk/svg/batik/text/textLayout-expected.txt: Added. * platform/gtk/svg/custom/text-letter-spacing-expected.png: * platform/gtk/svg/custom/text-letter-spacing-expected.txt: * platform/gtk/svg/text/text-spacing-01-b-expected.png: * platform/gtk/svg/text/text-spacing-01-b-expected.txt: Added. git-svn-id: http://svn.webkit.org/repository/webkit/trunk@161550 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
carlosgc@webkit.org authored
REGRESSION(r161176): http/tests/misc/authentication-redirect-3/authentication-sent-to-redirect-same-origin-with-location-credentials.html is failing on GTK https://bugs.webkit.org/show_bug.cgi?id=126518 Reviewed by Martin Robinson. Source/WebCore: Clear the credentials before calling willSendRequest on the client to avoid sending the credentials to the API layer, but apply them again to the request right before creating the new SoupRequest. * platform/network/soup/ResourceHandleSoup.cpp: (WebCore::continueAfterWillSendRequest): (WebCore::doRedirect): LayoutTests: Unskip http/tests/misc/authentication-redirect-3/authentication-sent-to-redirect-same-origin-with-location-credentials.html and http/tests/security/redirect-BLOCKED-to-localURL.html. * platform/gtk/TestExpectations: git-svn-id: http://svn.webkit.org/repository/webkit/trunk@161549 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
jinwoo7.song@samsung.com authored
https://bugs.webkit.org/show_bug.cgi?id=126678 Reviewed by Tim Horton. Add PLATFORM(MAC) guards around setExposedRect() and exposedRect() in DrawingArea and WebFrameLoaderClient. * WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp: (WebKit::WebFrameLoaderClient::transitionToCommittedForNewPage): * WebProcess/WebPage/DrawingArea.h: git-svn-id: http://svn.webkit.org/repository/webkit/trunk@161548 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
- 08 Jan, 2014 30 commits
-
-
seokju@webkit.org authored
* TestWebKitAPI/GNUmakefile.am: Remove WKConnection.cpp and WKConnection_Bundle.cpp. git-svn-id: http://svn.webkit.org/repository/webkit/trunk@161545 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
mhahnenberg@apple.com authored
* heap/Heap.cpp: git-svn-id: http://svn.webkit.org/repository/webkit/trunk@161544 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
commit-queue@webkit.org authored
https://bugs.webkit.org/show_bug.cgi?id=126626 Patch by Martin Hock <mhock@apple.com> on 2014-01-08 Reviewed by Sam Weinig. * Shared/API/c/WKBase.h: * Shared/API/c/WKSharedAPICast.h: * Shared/APIObject.h: * UIProcess/API/C/WKSessionRef.cpp: Added. (WKSessionGetTypeID): (WKSessionGetEphemeral): * UIProcess/API/C/WKSessionRef.h: Added. * UIProcess/API/Cocoa/WKSession.h: Added. * UIProcess/API/Cocoa/WKSession.mm: Added. (-[WKSession dealloc]): (-[WKSession ephemeral]): (-[WKSession API::]): * UIProcess/API/Cocoa/WKSessionInternal.h: Added. (WebKit::wrapper): * UIProcess/APISession.cpp: Added. (API::Session::Session): (API::Session::create): (API::Session::isEphemeral): (API::Session::~Session): * UIProcess/APISession.h: Added. * WebKit2.xcodeproj/project.pbxproj: git-svn-id: http://svn.webkit.org/repository/webkit/trunk@161542 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
commit-queue@webkit.org authored
http://trac.webkit.org/changeset/161532 https://bugs.webkit.org/show_bug.cgi?id=126677 Caused lots of assertion failures (Requested by ap on #webkit). Source/WebCore: * xml/XMLHttpRequest.cpp: (WebCore::XMLHttpRequest::callReadyStateChangeListener): (WebCore::XMLHttpRequest::createRequest): (WebCore::XMLHttpRequest::abort): (WebCore::XMLHttpRequest::networkError): (WebCore::XMLHttpRequest::abortError): (WebCore::XMLHttpRequest::didSendData): (WebCore::XMLHttpRequest::didReceiveData): (WebCore::XMLHttpRequest::didTimeout): * xml/XMLHttpRequest.h: * xml/XMLHttpRequestProgressEventThrottle.cpp: (WebCore::XMLHttpRequestProgressEventThrottle::XMLHttpRequestProgressEventThrottle): (WebCore::XMLHttpRequestProgressEventThrottle::dispatchProgressEvent): (WebCore::XMLHttpRequestProgressEventThrottle::dispatchEventAndLoadEnd): (WebCore::XMLHttpRequestProgressEventThrottle::flushProgressEvent): (WebCore::XMLHttpRequestProgressEventThrottle::fired): (WebCore::XMLHttpRequestProgressEventThrottle::hasEventToDispatch): (WebCore::XMLHttpRequestProgressEventThrottle::suspend): * xml/XMLHttpRequestProgressEventThrottle.h: * xml/XMLHttpRequestUpload.cpp: (WebCore::XMLHttpRequestUpload::XMLHttpRequestUpload): (WebCore::XMLHttpRequestUpload::dispatchEventAndLoadEnd): * xml/XMLHttpRequestUpload.h: LayoutTests: * fast/xmlhttprequest/xmlhttprequest-get-expected.txt: * http/tests/xmlhttprequest/loadstart-event-init-expected.txt: Removed. * http/tests/xmlhttprequest/loadstart-event-init.html: Removed. * http/tests/xmlhttprequest/onabort-progressevent-attributes-expected.txt: Removed. * http/tests/xmlhttprequest/onabort-progressevent-attributes.html: Removed. * http/tests/xmlhttprequest/onload-progressevent-attributes-expected.txt: Removed. * http/tests/xmlhttprequest/onload-progressevent-attributes.html: Removed. * http/tests/xmlhttprequest/upload-onabort-progressevent-attributes-expected.txt: Removed. * http/tests/xmlhttprequest/upload-onabort-progressevent-attributes.html: Removed. * http/tests/xmlhttprequest/upload-onload-progressevent-attributes-expected.txt: Removed. * http/tests/xmlhttprequest/upload-onload-progressevent-attributes.html: Removed. git-svn-id: http://svn.webkit.org/repository/webkit/trunk@161541 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
mhahnenberg@apple.com authored
https://bugs.webkit.org/show_bug.cgi?id=126552 Reviewed by Geoffrey Garen. Source/JavaScriptCore: Re-marking the same objects over and over is a waste of effort. This patch implements the sticky mark bit algorithm (along with our already-present write barriers) to reduce overhead during garbage collection caused by rescanning objects. There are now two collection modes, EdenCollection and FullCollection. EdenCollections only visit new objects or objects that were added to the remembered set by a write barrier. FullCollections are normal collections that visit all objects regardless of their generation. In this patch EdenCollections do not do anything in CopiedSpace. This will be fixed in https://bugs.webkit.org/show_bug.cgi?id=126555. * bytecode/CodeBlock.cpp: (JSC::CodeBlock::visitAggregate): * bytecode/CodeBlock.h: (JSC::CodeBlockSet::mark): * dfg/DFGOperations.cpp: * heap/CodeBlockSet.cpp: (JSC::CodeBlockSet::add): (JSC::CodeBlockSet::traceMarked): (JSC::CodeBlockSet::rememberCurrentlyExecutingCodeBlocks): * heap/CodeBlockSet.h: * heap/CopiedBlockInlines.h: (JSC::CopiedBlock::reportLiveBytes): * heap/CopiedSpace.cpp: (JSC::CopiedSpace::didStartFullCollection): * heap/CopiedSpace.h: (JSC::CopiedSpace::heap): * heap/Heap.cpp: (JSC::Heap::Heap): (JSC::Heap::didAbandon): (JSC::Heap::markRoots): (JSC::Heap::copyBackingStores): (JSC::Heap::addToRememberedSet): (JSC::Heap::collectAllGarbage): (JSC::Heap::collect): (JSC::Heap::didAllocate): (JSC::Heap::writeBarrier): * heap/Heap.h: (JSC::Heap::isInRememberedSet): (JSC::Heap::operationInProgress): (JSC::Heap::shouldCollect): (JSC::Heap::isCollecting): (JSC::Heap::isWriteBarrierEnabled): (JSC::Heap::writeBarrier): * heap/HeapOperation.h: * heap/MarkStack.cpp: (JSC::MarkStackArray::~MarkStackArray): (JSC::MarkStackArray::clear): (JSC::MarkStackArray::fillVector): * heap/MarkStack.h: * heap/MarkedAllocator.cpp: (JSC::isListPagedOut): (JSC::MarkedAllocator::isPagedOut): (JSC::MarkedAllocator::tryAllocateHelper): (JSC::MarkedAllocator::addBlock): (JSC::MarkedAllocator::removeBlock): (JSC::MarkedAllocator::reset): * heap/MarkedAllocator.h: (JSC::MarkedAllocator::MarkedAllocator): * heap/MarkedBlock.cpp: (JSC::MarkedBlock::clearMarks): (JSC::MarkedBlock::clearRememberedSet): (JSC::MarkedBlock::clearMarksWithCollectionType): (JSC::MarkedBlock::lastChanceToFinalize): * heap/MarkedBlock.h: Changed atomSize to 16 bytes because we have no objects smaller than 16 bytes. This is also to pay for the additional Bitmap for the remembered set. (JSC::MarkedBlock::didConsumeEmptyFreeList): (JSC::MarkedBlock::setRemembered): (JSC::MarkedBlock::clearRemembered): (JSC::MarkedBlock::atomicClearRemembered): (JSC::MarkedBlock::isRemembered): * heap/MarkedSpace.cpp: (JSC::MarkedSpace::~MarkedSpace): (JSC::MarkedSpace::resetAllocators): (JSC::MarkedSpace::visitWeakSets): (JSC::MarkedSpace::reapWeakSets): (JSC::VerifyMarked::operator()): (JSC::MarkedSpace::clearMarks): * heap/MarkedSpace.h: (JSC::ClearMarks::operator()): (JSC::ClearRememberedSet::operator()): (JSC::MarkedSpace::didAllocateInBlock): (JSC::MarkedSpace::clearRememberedSet): * heap/SlotVisitor.cpp: (JSC::SlotVisitor::~SlotVisitor): (JSC::SlotVisitor::clearMarkStack): * heap/SlotVisitor.h: (JSC::SlotVisitor::markStack): (JSC::SlotVisitor::sharedData): * heap/SlotVisitorInlines.h: (JSC::SlotVisitor::internalAppend): (JSC::SlotVisitor::unconditionallyAppend): (JSC::SlotVisitor::copyLater): (JSC::SlotVisitor::reportExtraMemoryUsage): (JSC::SlotVisitor::heap): * jit/Repatch.cpp: * runtime/JSGenericTypedArrayViewInlines.h: (JSC::JSGenericTypedArrayView<Adaptor>::visitChildren): * runtime/JSPropertyNameIterator.h: (JSC::StructureRareData::setEnumerationCache): * runtime/JSString.cpp: (JSC::JSString::visitChildren): * runtime/StructureRareDataInlines.h: (JSC::StructureRareData::setPreviousID): (JSC::StructureRareData::setObjectToStringValue): * runtime/WeakMapData.cpp: (JSC::WeakMapData::visitChildren): Source/WTF: * wtf/Bitmap.h: (WTF::WordType>::count): Added a cast that became necessary when Bitmap is used with smaller types than int32_t. git-svn-id: http://svn.webkit.org/repository/webkit/trunk@161540 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
jinwoo7.song@samsung.com authored
* platform/efl/css1/text_properties/letter_spacing-expected.png: * platform/efl/css1/text_properties/letter_spacing-expected.txt: * platform/efl/css1/text_properties/word_spacing-expected.png: * platform/efl/css1/text_properties/word_spacing-expected.txt: * platform/efl/fast/text/basic/013-expected.png: * platform/efl/fast/text/basic/013-expected.txt: * platform/efl/fast/text/text-letter-spacing-expected.txt: * platform/efl/svg/W3C-SVG-1.1/text-spacing-01-b-expected.png: * platform/efl/svg/W3C-SVG-1.1/text-spacing-01-b-expected.txt: Added. * platform/efl/svg/batik/text/textLayout-expected.txt: Added. * platform/efl/svg/custom/text-letter-spacing-expected.png: Added. * platform/efl/svg/custom/text-letter-spacing-expected.txt: Added. * platform/efl/svg/text/text-spacing-01-b-expected.png: * platform/efl/svg/text/text-spacing-01-b-expected.txt: Added. git-svn-id: http://svn.webkit.org/repository/webkit/trunk@161539 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
commit-queue@webkit.org authored
https://bugs.webkit.org/show_bug.cgi?id=126561 Patch by Sam Weinig <sam@webkit.org> on 2014-01-08 Reviewed by Geoffrey Garen. Source/JavaScriptCore: * runtime/JSPromiseConstructor.cpp: (JSC::JSPromiseConstructor::getCallData): Add support for calling the Promise constructor as a function (e.g. var p = Promise(...), note the missing "new"). LayoutTests: * js/dom/Promise-types-expected.txt: * js/dom/Promise-types.html: Add test for using calling a Promise constructor as a function. git-svn-id: http://svn.webkit.org/repository/webkit/trunk@161538 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
bburg@apple.com authored
https://bugs.webkit.org/show_bug.cgi?id=126661 Reviewed by Timothy Hatcher. No new tests. * page/DragController.cpp: (WebCore::DragController::doImageDrag): rename variables and simplify the calculation of the image's scaled origin. * platform/DragImage.cpp: (WebCore::fitDragImageToMaxSize): rename variables. git-svn-id: http://svn.webkit.org/repository/webkit/trunk@161537 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
csaavedra@igalia.com authored
https://bugs.webkit.org/show_bug.cgi?id=126638 Reviewed by Carlos Garcia Campos. This is proposed by fdo in http://www.freedesktop.org/wiki/CommonExtendedAttributes/ Source/WebKit/gtk: * webkit/webkitdownload.cpp: (webkit_download_open_stream_for_uri): Source/WebKit2: * Shared/Downloads/soup/DownloadSoup.cpp: (WebKit::DownloadClient::didReceiveResponse): git-svn-id: http://svn.webkit.org/repository/webkit/trunk@161536 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
commit-queue@webkit.org authored
https://bugs.webkit.org/show_bug.cgi?id=126564 Patch by Gergo Balogh <geryxyz@inf.u-szeged.hu> on 2014-01-08 Reviewed by Ryosuke Niwa. * Scripts/webkitpy/style/checkers/cpp.py: (check_include_line): * Scripts/webkitpy/style/checkers/cpp_unittest.py: (OrderOfIncludesTest.test_check_alphabetical_include_order): (OrderOfIncludesTest.test_public_primary_header): git-svn-id: http://svn.webkit.org/repository/webkit/trunk@161535 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
seokju@webkit.org authored
https://bugs.webkit.org/show_bug.cgi?id=126616 Reviewed by Joseph Pecoraro. No new tests, No change in behavior. Remove leftover mothod as Page.captureScreenshot API was removed in r160202. * inspector/InspectorClient.h: git-svn-id: http://svn.webkit.org/repository/webkit/trunk@161534 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
simon.fraser@apple.com authored
https://bugs.webkit.org/show_bug.cgi?id=126675 Reviewed by Tim Horton. We need a stub RemoteScrollingCoordinatorTransaction outside the #ifdef so that RemoteLayerTreeDrawingAreaProxy messages work. * Shared/Scrolling/RemoteScrollingCoordinatorTransaction.cpp: (WebKit::RemoteScrollingCoordinatorTransaction::encode): (WebKit::RemoteScrollingCoordinatorTransaction::decode): * Shared/Scrolling/RemoteScrollingCoordinatorTransaction.h: * UIProcess/mac/RemoteLayerTreeDrawingAreaProxy.mm: (WebKit::RemoteLayerTreeDrawingAreaProxy::commitLayerTree): * WebProcess/WebPage/mac/RemoteLayerTreeDrawingArea.mm: (WebKit::RemoteLayerTreeDrawingArea::flushLayers): git-svn-id: http://svn.webkit.org/repository/webkit/trunk@161533 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
commit-queue@webkit.org authored
https://bugs.webkit.org/show_bug.cgi?id=120828 Patch by Youenn Fablet <youennf@gmail.com> on 2014-01-08 Reviewed by Alexey Proskuryakov. Added correct initialization of lengthComputable, loaded and total attributes to XHR ProgressEvent events (load, loadstart, loadend, abort, error and timeout). XMLHttpRequestProgressEventThrottle and XMLHttpRequestUpload now keep persistent knowledge of m_loaded and m_total values with this patch. Code refactoring to handle event dispatching in case of error in a single manner. XMLHttpRequestProgressEventThrottle::dispatchProgressEvent is renamed as dispatchThrottledProgressEvent XMLHttpRequestProgressEventThrottle::dispatchEventAndLoadend is replaced by dispatchProgressEvent(const AtomicString&) Tests: http/tests/xmlhttprequest/loadstart-event-init.html http/tests/xmlhttprequest/onabort-progressevent-attributes.html http/tests/xmlhttprequest/onload-progressevent-attributes.html http/tests/xmlhttprequest/upload-onabort-progressevent-attributes.html http/tests/xmlhttprequest/upload-onload-progressevent-attributes.html * xml/XMLHttpRequest.cpp: (WebCore::XMLHttpRequest::callReadyStateChangeListener): changed readystatechange event from ProgressEvent to Event (not cancellable, not bubblable) to better match the spec (WebCore::XMLHttpRequest::createRequest): (WebCore::XMLHttpRequest::abort): code refactoring to handle error event dispatching in a single way (WebCore::XMLHttpRequest::networkError): code refactoring to handle error event dispatching in a single way (WebCore::XMLHttpRequest::abortError): code refactoring to handle error event dispatching in a single way (WebCore::XMLHttpRequest::didSendData): (WebCore::XMLHttpRequest::didReceiveData): (WebCore::XMLHttpRequest::dispatchErrorEvents): dispatch progress events in case of error (WebCore::XMLHttpRequest::didTimeout): code refactoring to handle error event dispatching in a single way * xml/XMLHttpRequest.h: * xml/XMLHttpRequestProgressEventThrottle.cpp: before the patch, the fact that a progress event is being throttled is stored indirectly (m_loaded or m_total not equal to zero). With the patch, this information is stored in m_hasThrottledProgressEvent. The m_loaded and m_total values are no longer set back to zero after a progress event is dispatched. This allows using these values to correctly initialize other ProgressEvent events (in particular loadend, abort, timeout...) (WebCore::XMLHttpRequestProgressEventThrottle::XMLHttpRequestProgressEventThrottle): (WebCore::XMLHttpRequestProgressEventThrottle::dispatchThrottledProgressEvent): always update the new m_loaded and m_total values. If progress event is not sent as part of the function call, store the fact that a progress event is being throttled through m_hasThrottledProgressEvent. (WebCore::XMLHttpRequestProgressEventThrottle::dispatchProgressEvent): used to send any ProgressEvent event that is not be throttled (WebCore::XMLHttpRequestProgressEventThrottle::flushProgressEvent): after the call, no progress event is throttled anymore (WebCore::XMLHttpRequestProgressEventThrottle::fired): after the call, no progress event is throttled anymore (WebCore::XMLHttpRequestProgressEventThrottle::hasEventToDispatch): (WebCore::XMLHttpRequestProgressEventThrottle::suspend): * xml/XMLHttpRequestProgressEventThrottle.h: introduced m_hasThrottledProgressEvent which stores whether a progress event is being throttled and m_computableLength which is used to initialize ProgressEvent computableLength * xml/XMLHttpRequestUpload.cpp: (WebCore::XMLHttpRequestUpload::XMLHttpRequestUpload): (WebCore::XMLHttpRequestUpload::dispatchProgressEvent): * xml/XMLHttpRequestUpload.h: introduced m_loaded, m_total and m_lengthComputable, similarly to XMLHttpRequestProgressEventThrottle LayoutTests: Correctly set XHR loadend event attributes (loaded and total). https://bugs.webkit.org/show_bug.cgi?id=120828 Patch by Youenn Fablet <youennf@gmail.com> on 2014-01-08 Reviewed by Alexey Proskuryakov. Tests for abort, load, loadstart and loadend ProgressEvent events for XMLHttpRequest and XMLHttpRequestUpload * fast/xmlhttprequest/xmlhttprequest-get-expected.txt: Changed to correct event values * http/tests/xmlhttprequest/loadstart-event-init-expected.txt: Added. * http/tests/xmlhttprequest/loadstart-event-init.html: Added. * http/tests/xmlhttprequest/onabort-progressevent-attributes-expected.txt: Added. * http/tests/xmlhttprequest/onabort-progressevent-attributes.html: Added. * http/tests/xmlhttprequest/onload-progressevent-attributes-expected.txt: Added. * http/tests/xmlhttprequest/onload-progressevent-attributes.html: Added. * http/tests/xmlhttprequest/upload-onabort-progressevent-attributes-expected.txt: Added. * http/tests/xmlhttprequest/upload-onabort-progressevent-attributes.html: Added. * http/tests/xmlhttprequest/upload-onload-progressevent-attributes-expected.txt: Added. * http/tests/xmlhttprequest/upload-onload-progressevent-attributes.html: Added. git-svn-id: http://svn.webkit.org/repository/webkit/trunk@161532 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
timothy_horton@apple.com authored
https://bugs.webkit.org/show_bug.cgi?id=126536 Reviewed by Simon Fraser. * Configurations/WebKit2.xcconfig: * UIProcess/API/mac/WKView.mm: (-[WKView _updateViewExposedRect]): * UIProcess/DrawingAreaProxy.cpp: (WebKit::DrawingAreaProxy::DrawingAreaProxy): (WebKit::DrawingAreaProxy::setExposedRect): (WebKit::DrawingAreaProxy::exposedRectChangedTimerFired): * UIProcess/DrawingAreaProxy.h: (WebKit::DrawingAreaProxy::exposedRect): * UIProcess/WebPageProxy.cpp: (WebKit::WebPageProxy::WebPageProxy): (WebKit::WebPageProxy::close): * UIProcess/WebPageProxy.h: Move exposedRect stuff from WebPageProxy to DrawingAreaProxy. * WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp: (WebKit::WebFrameLoaderClient::transitionToCommittedForNewPage): Push the exposedRect down into WebCore. * WebProcess/WebPage/DrawingArea.h: * WebProcess/WebPage/DrawingArea.messages.in: * WebProcess/WebPage/WebPage.cpp: * WebProcess/WebPage/WebPage.h: * WebProcess/WebPage/WebPage.messages.in: * WebProcess/WebPage/mac/RemoteLayerTreeDrawingArea.h: * WebProcess/WebPage/mac/RemoteLayerTreeDrawingArea.mm: (WebKit::RemoteLayerTreeDrawingArea::RemoteLayerTreeDrawingArea): (WebKit::RemoteLayerTreeDrawingArea::updateScrolledExposedRect): * WebProcess/WebPage/mac/TiledCoreAnimationDrawingArea.h: * WebProcess/WebPage/mac/TiledCoreAnimationDrawingArea.mm: (WebKit::TiledCoreAnimationDrawingArea::TiledCoreAnimationDrawingArea): (WebKit::TiledCoreAnimationDrawingArea::flushLayers): (WebKit::TiledCoreAnimationDrawingArea::updateScrolledExposedRect): (WebKit::TiledCoreAnimationDrawingArea::setRootCompositingLayer): (WebKit::TiledCoreAnimationDrawingArea::createPageOverlayLayer): (WebKit::TiledCoreAnimationDrawingArea::didCommitChangesForLayer): Get rid of "clipsToExposedRect", we just use infinite-ness of the rect to indicate that now. Don't scroll an infinite rect; it won't work. * WebCore.exp.in: Export some things. * page/FrameView.cpp: (WebCore::FrameView::FrameView): (WebCore::FrameView::setExposedRect): Store the exposed rect on FrameView. When it changes, if the main frame has a TiledBacking, inform it of the change. * page/FrameView.h: * platform/graphics/TiledBacking.h: * platform/graphics/ca/mac/TileController.h: * platform/graphics/ca/mac/TileController.mm: (WebCore::TileController::TileController): (WebCore::TileController::tilesWouldChangeForVisibleRect): (WebCore::TileController::computeTileCoverageRect): (WebCore::TileController::revalidateTiles): (WebCore::TileController::updateTileCoverageMap): Make use of the fact that we can test if a rect is infinite instead of having a separate boolean property for that. * rendering/RenderLayerBacking.cpp: (WebCore::RenderLayerBacking::RenderLayerBacking): (WebCore::computeTileCoverage): Push the FrameView's cached exposed rect down into the TiledBacking when it is created. We only support clipping for the main frame TileController for now. git-svn-id: http://svn.webkit.org/repository/webkit/trunk@161530 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
simon.fraser@apple.com authored
https://bugs.webkit.org/show_bug.cgi?id=126672 Reviewed by Tim Horton. Protected WK2 scrolling files with ENABLE(ASYNC_SCROLLING) guards. * Shared/Scrolling/RemoteScrollingCoordinatorTransaction.cpp: * Shared/Scrolling/RemoteScrollingCoordinatorTransaction.h: * UIProcess/Scrolling/RemoteScrollingCoordinatorProxy.cpp: * UIProcess/Scrolling/RemoteScrollingCoordinatorProxy.h: * UIProcess/Scrolling/RemoteScrollingTree.cpp: * UIProcess/Scrolling/RemoteScrollingTree.h: * WebProcess/Scrolling/RemoteScrollingCoordinator.h: * WebProcess/Scrolling/RemoteScrollingCoordinator.messages.in: * WebProcess/Scrolling/RemoteScrollingCoordinator.mm: git-svn-id: http://svn.webkit.org/repository/webkit/trunk@161529 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
mrobinson@webkit.org authored
https://bugs.webkit.org/show_bug.cgi?id=126671 Reviewed by Gustavo Noronha Silva. * Source/cmake/OptionsGTK.cmake: Explicitly specify the output locations. git-svn-id: http://svn.webkit.org/repository/webkit/trunk@161528 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
ryuan.choi@samsung.com authored
https://bugs.webkit.org/show_bug.cgi?id=101904 Reviewed by Gyuyoung Kim. Add ewk_view_script_execute() which provides a way to execute user script. * UIProcess/API/efl/ewk_context.cpp: Added JS Global Contexta which is required to deserialize to the script value from the callback. (EwkContext::EwkContext): (EwkContext::~EwkContext): (EwkContext::jsGlobalContext): * UIProcess/API/efl/ewk_context_private.h: * UIProcess/API/efl/ewk_view.cpp: (Ewk_View_Script_Execute_Callback_Context::Ewk_View_Script_Execute_Callback_Context): (runJavaScriptCallback): (ewk_view_script_execute): * UIProcess/API/efl/ewk_view.h: * UIProcess/API/efl/tests/test_ewk2_view.cpp: Added unit test for ewk_view_script_execute. (scriptExecuteCallback): (TEST_F): git-svn-id: http://svn.webkit.org/repository/webkit/trunk@161527 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
ryuan.choi@samsung.com authored
https://bugs.webkit.org/show_bug.cgi?id=126508 Reviewed by Gyuyoung Kim. Source/WebKit: * PlatformEfl.cmake: Removed ewk_view_single.cpp. Source/WebKit/efl: Since ewk_view_tiled is removed at r161134, we don't need to keep ewk_view_single out of ewk_view.cpp. This patch moves the logic of ewk_view_single to ewk_view and refactors it. In addition, replaces 0.00001 to episilon. * ewk/ewk_view.cpp: (_ewk_view_smart_add): (_ewk_view_smart_resize): Merged with the logic of ewk_view_single. (_ewk_view_screen_move): Moved from ewk_view_single.cpp. (_ewk_view_scroll_process): Ditto. (_ewk_view_smart_scrolls_process): Ditto. (_ewk_view_smart_repaints_process): Ditto. (_ewk_view_smart_calculate): Removed unnecessary check routine for scrolls_process. (_ewk_view_smart_zoom_weak_set): (_ewk_view_smart_zoom_weak_smooth_scale_set): (ewk_view_base_smart_set): Merged smart method of ewk_view_single. (ewk_view_single_smart_set): (_ewk_view_single_smart_class_new): (ewk_view_single_add): (ewk_view_bg_color_set): (ewk_view_pre_render_region): (ewk_view_scrolls_process): * ewk/ewk_view.h: * ewk/ewk_view_private.h: Removed unncessary functions. * ewk/ewk_view_single.cpp: Removed. git-svn-id: http://svn.webkit.org/repository/webkit/trunk@161526 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
gyuyoung.kim@samsung.com authored
https://bugs.webkit.org/show_bug.cgi?id=126615 Reviewed by Martin Robinson. Now EFL API test binaries created in *bin* directory with other executables. It would be good to move them to their folder. This patch moves them to *TestWebKitAPI/EWebKit|EWebKit2* directories. Source/WebKit: * PlatformEfl.cmake: Source/WebKit2: * PlatformEfl.cmake: git-svn-id: http://svn.webkit.org/repository/webkit/trunk@161525 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
seokju@webkit.org authored
* TestWebKitAPI/CMakeLists.txt: * TestWebKitAPI/PlatformEfl.cmake: git-svn-id: http://svn.webkit.org/repository/webkit/trunk@161524 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
andersca@apple.com authored
https://bugs.webkit.org/show_bug.cgi?id=126666 Reviewed by Dan Bernstein. The WKConnectionRef is poorly designed but thankfully not used anywhere. Remove the API tests as a first step towards killing the entire thing. * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: * TestWebKitAPI/Tests/WebKit2/WKConnection.cpp: Removed. * TestWebKitAPI/Tests/WebKit2/WKConnection_Bundle.cpp: Removed. git-svn-id: http://svn.webkit.org/repository/webkit/trunk@161522 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
mmaxfield@apple.com authored
https://bugs.webkit.org/show_bug.cgi?id=20606 Reviewed by Simon Fraser. Source/WebCore: This turns on fractional letter-spacing and word-spacing CSS values. It is taken mostly from Blink r153727 and iOS. Updating the relevant types is all that is necessary Existing tests have been updated. * css/DeprecatedStyleBuilder.cpp: (WebCore::DeprecatedStyleBuilder::DeprecatedStyleBuilder): * page/animation/CSSPropertyAnimation.cpp: (WebCore::CSSPropertyAnimationWrapperMap::CSSPropertyAnimationWrapperMap): * platform/graphics/Font.cpp: (WebCore::Font::Font): (WebCore::Font::width): * platform/graphics/Font.h: (WebCore::Font::wordSpacing): (WebCore::Font::letterSpacing): (WebCore::Font::setWordSpacing): (WebCore::Font::setLetterSpacing): * rendering/style/RenderStyle.cpp: (WebCore::RenderStyle::wordSpacing): (WebCore::RenderStyle::letterSpacing): (WebCore::RenderStyle::setWordSpacing): (WebCore::RenderStyle::setLetterSpacing): * rendering/style/RenderStyle.h: LayoutTests: Manually verified that these tests are correct after enabling fractional letter-spacing and word spacing * platform/mac/css1/text_properties/letter_spacing-expected.png: * platform/mac/css1/text_properties/letter_spacing-expected.txt: * platform/mac/css1/text_properties/word_spacing-expected.png: * platform/mac/css1/text_properties/word_spacing-expected.txt: * platform/mac/fast/text/basic/013-expected.png: * platform/mac/fast/text/basic/013-expected.txt: * platform/mac/fast/text/text-letter-spacing-expected.txt: * platform/mac/svg/W3C-SVG-1.1/text-spacing-01-b-expected.png: * platform/mac/svg/W3C-SVG-1.1/text-spacing-01-b-expected.txt: * platform/mac/svg/batik/text/textLayout-expected.txt: * platform/mac/svg/custom/text-letter-spacing-expected.png: * platform/mac/svg/custom/text-letter-spacing-expected.txt: * platform/mac/svg/text/text-spacing-01-b-expected.png: * platform/mac/svg/text/text-spacing-01-b-expected.txt: git-svn-id: http://svn.webkit.org/repository/webkit/trunk@161521 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
zandobersek@gmail.com authored
http://trac.webkit.org/changeset/161512 https://bugs.webkit.org/show_bug.cgi?id=126655 Broke webkitpy tests (Requested by ap on #webkit). Patch by Commit Queue <commit-queue@webkit.org> on 2014-01-08 * Scripts/webkitpy/port/gtk.py: (GtkPort.__init__): (GtkPort.setup_test_run): (GtkPort._port_specific_expectations_files): * Scripts/webkitpy/port/leakdetector_valgrind.py: Removed. * Scripts/webkitpy/port/leakdetector_valgrind_unittest.py: Removed. git-svn-id: http://svn.webkit.org/repository/webkit/trunk@161520 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
zandobersek@gmail.com authored
http://trac.webkit.org/changeset/161517 https://bugs.webkit.org/show_bug.cgi?id=126659 The fix didn't completely remove the problem and is now standing in the way of the rollout of the offending patch (Requested by zdobersek on #webkit). Patch by Commit Queue <commit-queue@webkit.org> on 2014-01-08 * Scripts/webkitpy/port/gtk.py: (GtkPort.__init__): git-svn-id: http://svn.webkit.org/repository/webkit/trunk@161519 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
andersca@apple.com authored
https://bugs.webkit.org/show_bug.cgi?id=126644 Reviewed by Antti Koivisto. Source/WebCore: Use a StringView in TextCheckerClient::checkTextOfParagraph to avoid upconverting strings unnecessarily. * editing/TextCheckingHelper.cpp: (WebCore::checkTextOfParagraph): Pass a StringView to TextCheckerClient::checkTextOfParagraph. * loader/EmptyClients.h: Update for TextCheckerClient changes. * platform/text/TextCheckerClient.h: Change TextCheckerClient::checkTextOfParagraph to take a StringView. Source/WebKit/efl: Update to match WebCore changes. * WebCoreSupport/EditorClientEfl.h: (WebCore::EditorClientEfl::checkTextOfParagraph): Source/WebKit/mac: * WebCoreSupport/WebEditorClient.h: * WebCoreSupport/WebEditorClient.mm: (WebEditorClient::checkTextOfParagraph): Update to match the new signature. (nsStringWithoutCopying): New function that creates an NSString that references StringView data without copying the data. (If this function proves to be useful elsewhere, it could potentially be added to StringView). Source/WebKit2: Use a StringView and remove a FIXME. * WebProcess/WebCoreSupport/WebEditorClient.cpp: (WebKit::WebEditorClient::checkTextOfParagraph): * WebProcess/WebCoreSupport/WebEditorClient.h: Source/WTF: Add a new StringView class which is an immutable reference to either an 8-bit or a 16-bit string. This makes it easier to pass substrings around without having to either copy string data or upconvert and use UChar pointers. The StringView class is very loosely based on the std::string_view class which is proposed for a future version of C++, see http://www.open-std.org/jtc1/sc22/wg21/docs/papers/2013/n3609.html for more details. * GNUmakefile.list.am: * WTF.vcxproj/WTF.vcxproj: * WTF.vcxproj/WTF.vcxproj.filters: * WTF.xcodeproj/project.pbxproj: * wtf/CMakeLists.txt: * wtf/Forward.h: * wtf/text/StringView.h: Added. (WTF::StringView::StringView): (WTF::StringView::empty): (WTF::StringView::characters8): (WTF::StringView::characters16): (WTF::StringView::isEmpty): (WTF::StringView::length): (WTF::StringView::is8Bit): (WTF::StringView::substring): (WTF::StringView::toString): (WTF::StringView::toStringWithoutCopying): (WTF::StringView::encodedCharacters): git-svn-id: http://svn.webkit.org/repository/webkit/trunk@161518 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
zandobersek@gmail.com authored
* Scripts/webkitpy/port/gtk.py: (GtkPort.__init__): Construct LeakDetectorValgrin only if leak detection is enabled. git-svn-id: http://svn.webkit.org/repository/webkit/trunk@161517 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
ap@apple.com authored
https://bugs.webkit.org/show_bug.cgi?id=52016 * platform/mac/TestExpectations: Mark it as such. git-svn-id: http://svn.webkit.org/repository/webkit/trunk@161516 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
commit-queue@webkit.org authored
https://bugs.webkit.org/show_bug.cgi?id=126534 Patch by peavo@outlook.com <peavo@outlook.com> on 2014-01-08 Reviewed by Brent Fulgham. * WebKitPrefix.h: Define __STDC_LIMIT_MACROS, so INTMAX_MAX will be defined (needed by std C++ library). git-svn-id: http://svn.webkit.org/repository/webkit/trunk@161513 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
brian.holt@samsung.com authored
https://bugs.webkit.org/show_bug.cgi?id=119446 Reviewed by Alejandro G. Castro. Parse the xml files generated by Valgrind to yield useful information about the memory leaks. * Scripts/webkitpy/port/gtk.py: (GtkPort.__init__): (GtkPort.setup_test_run): Clear the previous output files before new run. (GtkPort.print_leaks_summary): * Scripts/webkitpy/port/leakdetector_valgrind.py: Added. Parse the xml files generated by Valgrind and summarise leaks into an easily understandable list. (get_text_of): (get_CDATA_of): (gather_frames): (ValgrindError): (ValgrindError.__init__): (ValgrindError.__str__): (ValgrindError.unique_string): (ValgrindError.error_hash): (ValgrindError.__hash__): (ValgrindError.__eq__): (LeakDetectorValgrind): (LeakDetectorValgrind.__init__): (LeakDetectorValgrind._parse_leaks_output): (LeakDetectorValgrind.leaks_files_in_results_directory): (LeakDetectorValgrind.clean_leaks_files_from_results_directory): (LeakDetectorValgrind.parse_and_print_leaks_detail): * Scripts/webkitpy/port/leakdetector_valgrind_unittest.py: Added. (make_mock_valgrind_output): (make_mock_incomplete_valgrind_output): (make_mock_valgrind_results): (make_mock_valgrind_results_incomplete): (make_mock_valgrind_results_empty): (make_mock_valgrind_results_misformatted): (LeakDetectorValgrindTest): (LeakDetectorValgrindTest.test_parse_and_print_leaks_detail_pass): (LeakDetectorValgrindTest.test_parse_and_print_leaks_detail_incomplete): (LeakDetectorValgrindTest.test_parse_and_print_leaks_detail_empty): (LeakDetectorValgrindTest.test_parse_and_print_leaks_detail_misformatted): (LeakDetectorValgrindTest.test_parse_and_print_leaks_detail_pass): (LeakDetectorValgrindTest.test_parse_and_print_leaks_detail_incomplete): (LeakDetectorValgrindTest.test_parse_and_print_leaks_detail_empty): (LeakDetectorValgrindTest.test_parse_and_print_leaks_detail_misformatted): git-svn-id: http://svn.webkit.org/repository/webkit/trunk@161512 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
bfulgham@apple.com authored
* WebKit.vcxproj/WebKitExportGenerator/WebKitExports.def.in: Add missing exports needed for Windows build. git-svn-id: http://svn.webkit.org/repository/webkit/trunk@161511 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-