1. 18 Jan, 2011 1 commit
    • podivilov@chromium.org's avatar
      2011-01-17 Pavel Podivilov <podivilov@chromium.org> · 49f4cb5f
      podivilov@chromium.org authored
              Reviewed by Yury Semikhatsky.
      
              Web Inspector: add source column field to debugger call frames.
              https://bugs.webkit.org/show_bug.cgi?id=52443
      
              * bindings/js/JavaScriptCallFrame.cpp:
              (WebCore::JavaScriptCallFrame::JavaScriptCallFrame):
              * bindings/js/JavaScriptCallFrame.h:
              (WebCore::JavaScriptCallFrame::create):
              (WebCore::JavaScriptCallFrame::line):
              (WebCore::JavaScriptCallFrame::column):
              (WebCore::JavaScriptCallFrame::update):
              * bindings/js/ScriptDebugServer.cpp:
              (WebCore::ScriptDebugServer::createCallFrameAndPauseIfNeeded):
              (WebCore::ScriptDebugServer::updateCallFrameAndPauseIfNeeded):
              (WebCore::ScriptDebugServer::callEvent):
              (WebCore::ScriptDebugServer::atStatement):
              (WebCore::ScriptDebugServer::returnEvent):
              (WebCore::ScriptDebugServer::exception):
              (WebCore::ScriptDebugServer::willExecuteProgram):
              (WebCore::ScriptDebugServer::didExecuteProgram):
              (WebCore::ScriptDebugServer::didReachBreakpoint):
              * bindings/js/ScriptDebugServer.h:
              * bindings/v8/DebuggerScript.js:
              ():
              * bindings/v8/JavaScriptCallFrame.cpp:
              (WebCore::JavaScriptCallFrame::column):
              * bindings/v8/JavaScriptCallFrame.h:
              * inspector/InjectedScriptSource.js:
              ():
              * inspector/JavaScriptCallFrame.idl:
      
       2011-01-18  Antti Koivisto  <antti@apple.com>
      
              Reviewed by Dave Hyatt.
      
              https://bugs.webkit.org/show_bug.cgi?id=52370
              <rdar://problem/8856808>
              Style sharing optimization no longer works on major web sites
      
              The code in CSSStyleSelector::locateSharedStyle() that tries to share style information between element has been defeated
              by widespread use of certain CSS selectors (:first-child pseudo class and similar). The current implementation disables
              the sharing optimization for the whole page if one of these constructs is seen in any style sheet used by the page.
      
              This patch gets the style sharing back to 25-40% range on most web sites.
      
              * css/CSSMutableStyleDeclaration.h:
              (WebCore::CSSMutableStyleDeclaration::propertiesEqual):
      
                  Needed to improve equality checking in NamedNodeMap::mappedMapsEquivalent.
      
              * css/CSSSelector.h:
              (WebCore::CSSSelector::isSiblingSelector):
      
                  Test for selectors that are affected by the sibling elements.
      
              * css/CSSStyleSelector.cpp:
              (WebCore::elementCanUseSimpleDefaultStyle):
              (WebCore::collectSiblingRulesInDefaultStyle):
              (WebCore::assertNoSiblingRulesInDefaultStyle):
      
                  Extract sibling rules from the MathML default stylesheet.
                  Assert that no other default stylesheet has them.
      
              (WebCore::CSSStyleSelector::CSSStyleSelector):
              (WebCore::CSSStyleSelector::locateCousinList):
              (WebCore::CSSStyleSelector::matchesSiblingRules):
              (WebCore::CSSStyleSelector::canShareStyleWithElement):
              (WebCore::CSSStyleSelector::locateSharedStyle):
              (WebCore::CSSStyleSelector::styleForElement):
              (WebCore::collectIdsAndSiblingRulesFromList):
              (WebCore::CSSRuleSet::collectIdsAndSiblingRules):
      
                  Track sibling rules and ids used in the stylesheets to allow much more fine-grained rejection of cases
                  where style sharing can't be used.
      
              * css/CSSStyleSelector.h:
              * dom/NamedNodeMap.cpp:
              (WebCore::NamedNodeMap::mappedMapsEquivalent):
      
                  Check also for CSSValue mutation from DOM.
      
              * mathml/MathMLMathElement.cpp:
              (WebCore::MathMLMathElement::insertedIntoDocument):
              * mathml/MathMLMathElement.h:
      
                  MathML default style sheet has sibling rules which don't get noticed by the normal document
                  stylesheet parsing.
      
              * rendering/style/RenderStyle.h:
              (WebCore::InheritedFlags::setFirstChildState):
              (WebCore::InheritedFlags::setLastChildState):
              (WebCore::InheritedFlags::setChildIndex):
      
                  These all make style non-shareable (unique).
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@76013 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      49f4cb5f
  2. 08 Jan, 2011 1 commit
  3. 14 Jul, 2010 1 commit
    • bulach@chromium.org's avatar
      2010-07-14 Marcus Bulach <bulach@chromium.org> · f190c7e6
      bulach@chromium.org authored
              Reviewed by Jeremy Orlow.
      
              Code generator: ensure generated constants match their corresponding enums.
              https://bugs.webkit.org/show_bug.cgi?id=42250
      
              Specific interfaces can use DontCheckEnums attribute to avoid generating the compile-time check.
      
              Tests: updated bindings tests. Generated code should compile.
      
              * bindings/scripts/CodeGenerator.pm:
              * bindings/scripts/CodeGeneratorJS.pm:
              * bindings/scripts/CodeGeneratorV8.pm:
              * bindings/scripts/test/CPP/WebDOMTestObj.h:
              (WebDOMTestObj::):
              * bindings/scripts/test/JS/JSTestObj.cpp:
              (WebCore::):
              (WebCore::JSTestObjPrototype::getOwnPropertySlot):
              (WebCore::JSTestObjPrototype::getOwnPropertyDescriptor):
              (WebCore::jsTestObjCONST_VALUE_0):
              (WebCore::jsTestObjCONST_VALUE_1):
              (WebCore::jsTestObjCONST_VALUE_2):
              (WebCore::jsTestObjCONST_VALUE_4):
              (WebCore::jsTestObjCONST_VALUE_8):
              * bindings/scripts/test/JS/JSTestObj.h:
              * bindings/scripts/test/ObjC/DOMTestObj.h:
              * bindings/scripts/test/TestObj.idl:
              * bindings/scripts/test/V8/V8TestObj.cpp:
              (WebCore::):
              (WebCore::ConfigureV8TestObjTemplate):
              * css/WebKitCSSTransformValue.idl:
              * dom/DOMCoreException.idl:
              * dom/EventException.idl:
              * dom/Node.idl:
              * dom/OverflowEvent.idl:
              * dom/RangeException.idl:
              * html/FileError.idl:
              * html/FileReader.idl:
              * html/canvas/Float32Array.idl:
              * html/canvas/Int16Array.idl:
              * html/canvas/Int32Array.idl:
              * html/canvas/Int8Array.idl:
              * html/canvas/Uint16Array.idl:
              * html/canvas/Uint32Array.idl:
              * html/canvas/Uint8Array.idl:
              * html/canvas/WebGLRenderingContext.idl:
              * inspector/JavaScriptCallFrame.idl:
              * loader/appcache/DOMApplicationCache.idl:
              * storage/SQLException.idl:
              * svg/SVGComponentTransferFunctionElement.idl:
              * svg/SVGException.idl:
              * svg/SVGFEBlendElement.idl:
              * svg/SVGFEColorMatrixElement.idl:
              * svg/SVGFECompositeElement.idl:
              * svg/SVGFEConvolveMatrixElement.idl:
              * svg/SVGFEDisplacementMapElement.idl:
              * svg/SVGFEMorphologyElement.idl:
              * svg/SVGFETurbulenceElement.idl:
              * svg/SVGGradientElement.idl:
              * xml/XMLHttpRequestException.idl:
              * xml/XPathException.idl:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@63331 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      f190c7e6
  4. 19 Apr, 2010 1 commit
    • yurys@chromium.org's avatar
      2010-04-19 Yury Semikhatsky <yurys@chromium.org> · 537da0c3
      yurys@chromium.org authored
              Reviewed by Pavel Feldman.
      
              Web Inspector: implement JavaScriptCallFrame that works for v8.
              Implementing this binding for v8 allows to make evaluations on
              call frames and protects access to the debugger context from
              inspected context.
      
              https://bugs.webkit.org/show_bug.cgi?id=37755
      
              * WebCore.gyp/WebCore.gyp:
              * WebCore.gypi:
              * bindings/js/JSJavaScriptCallFrameCustom.cpp:
              (WebCore::JSJavaScriptCallFrame::scopeType):
              * bindings/v8/JavaScriptCallFrame.cpp: Added.
              (WebCore::JavaScriptCallFrame::JavaScriptCallFrame):
              (WebCore::JavaScriptCallFrame::~JavaScriptCallFrame):
              (WebCore::JavaScriptCallFrame::caller):
              (WebCore::JavaScriptCallFrame::sourceID):
              (WebCore::JavaScriptCallFrame::line):
              (WebCore::JavaScriptCallFrame::functionName):
              (WebCore::JavaScriptCallFrame::scopeChain):
              (WebCore::JavaScriptCallFrame::scope...
      537da0c3
  5. 23 Dec, 2009 1 commit
    • zimmermann@webkit.org's avatar
      2009-12-23 Nikolas Zimmermann <nzimmermann@rim.com> · 0794fbb6
      zimmermann@webkit.org authored
              Reviewed by Eric Seidel.
      
              Reverse JS GenerateConstructor logic
              https://bugs.webkit.org/show_bug.cgi?id=32910
      
              Make 'GenerateConstructor' the default setting for all classes, defined in IDL files. The flag is now obsolete and
              can be removed from all IDL files in a follow-up patch. Add new 'OmitConstructor' flag, that allows to restore the
              old default behaviour: do not generate JSFoobarConstructor class.
      
              No change in functionality, despite the fact that we're generating a lot more constructors now, as they have to
              be exposed through DOMWindow.idl -- this can be done per affected class in follow-up patches. Especially the SVG
              classes have to be exposed, most of them are missing JS constructors so far.
      
              As side effect HTMLOptionsCollection is now correctly exposing its constructor, thus fixing a test in fast/dom/wrapper-classes.html
      
      
      git-svn-id: http://svn.webkit.org/reposito...
      0794fbb6
  6. 15 May, 2009 1 commit
    • eric@webkit.org's avatar
      2009-05-15 Laszlo Gombos <laszlo.1.gombos@nokia.com> · 8faeadeb
      eric@webkit.org authored
              Reviewed by Darin Adler.
      
              Finish support for disabling the JavaScript Debugger and Profiler
              at compile time in WebCore
              https://bugs.webkit.org/show_bug.cgi?id=24917
      
              * bindings/js/JSInspectorControllerCustom.cpp: ENABLE_JAVASCRIPT_DEBUGGER guard
              * bindings/js/JSJavaScriptCallFrameCustom.cpp: Ditto.
              * inspector/JavaScriptCallFrame.cpp: Ditto.
              * inspector/JavaScriptCallFrame.h: Ditto.
              * inspector/JavaScriptCallFrame.idl: Ditto.
              * inspector/JavaScriptDebugListener.h: Ditto.
              * inspector/JavaScriptDebugServer.cpp: Ditto.
              * inspector/JavaScriptDebugServer.h: Ditto.
              * inspector/JavaScriptProfile.cpp: Ditto.
              * inspector/JavaScriptProfile.h: Ditto.
              * inspector/JavaScriptProfileNode.cpp: Ditto.
              * inspector/JavaScriptProfileNode.h: Ditto.
              * page/Console.cpp: Use guard ENABLE(JAVASCRIPT_DEBUGGER) instead of USE(JSC)
              * page/Console.h: Ditto.
              * page/Console.idl: Use guard ENABLE(JAVASCRIPT_DEBUGGER) instead of !defined(V8_BINDING)
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@43761 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      8faeadeb
  7. 04 Oct, 2008 1 commit
    • timothy@apple.com's avatar
      Move the Web Inspector files into a top-level "inspector" folder. · 9c94f6b0
      timothy@apple.com authored
              https://bugs.webkit.org/show_bug.cgi?id=21359
      
              Reviewed by Dave Hyatt.
      
              * GNUmakefile.am:
              * WebCore.pro:
              * WebCore.vcproj/WebCore.vcproj:
              * WebCore.xcodeproj/project.pbxproj:
              * WebCoreSources.bkl:
              * inspector/InspectorClient.h: Renamed from WebCore/page/InspectorClient.h.
              * inspector/InspectorController.cpp: Renamed from WebCore/page/InspectorController.cpp.
              * inspector/InspectorController.h: Renamed from WebCore/page/InspectorController.h.
              * inspector/JavaScriptCallFrame.cpp: Renamed from WebCore/page/JavaScriptCallFrame.cpp.
              * inspector/JavaScriptCallFrame.h: Renamed from WebCore/page/JavaScriptCallFrame.h.
              * inspector/JavaScriptCallFrame.idl: Renamed from WebCore/page/JavaScriptCallFrame.idl.
              * inspector/JavaScriptDebugListener.h: Renamed from WebCore/page/JavaScriptDebugListener.h.
              * inspector/JavaScriptDebugServer.cpp: Renamed from WebCore/page/JavaScriptDebugServer.cpp.
              * inspector/JavaScriptDebugServer.h: Renamed from WebCore/page/JavaScriptDebugServer.h.
              * inspector/JavaScriptProfile.cpp: Renamed from WebCore/page/JavaScriptProfile.cpp.
              * inspector/JavaScriptProfile.h: Renamed from WebCore/page/JavaScriptProfile.h.
              * inspector/JavaScriptProfileNode.cpp: Renamed from WebCore/page/JavaScriptProfileNode.cpp.
              * inspector/JavaScriptProfileNode.h: Renamed from WebCore/page/JavaScriptProfileNode.h.
              * inspector/front-end/Breakpoint.js: Renamed from WebCore/page/inspector/Breakpoint.js.
              * inspector/front-end/BreakpointsSidebarPane.js: Renamed from WebCore/page/inspector/BreakpointsSidebarPane.js.
              * inspector/front-end/CallStackSidebarPane.js: Renamed from WebCore/page/inspector/CallStackSidebarPane.js.
              * inspector/front-end/Console.js: Renamed from WebCore/page/inspector/Console.js.
              * inspector/front-end/DataGrid.js: Renamed from WebCore/page/inspector/DataGrid.js.
              * inspector/front-end/Database.js: Renamed from WebCore/page/inspector/Database.js.
              * inspector/front-end/DatabaseQueryView.js: Renamed from WebCore/page/inspector/DatabaseQueryView.js.
              * inspector/front-end/DatabaseTableView.js: Renamed from WebCore/page/inspector/DatabaseTableView.js.
              * inspector/front-end/DatabasesPanel.js: Renamed from WebCore/page/inspector/DatabasesPanel.js.
              * inspector/front-end/ElementsPanel.js: Renamed from WebCore/page/inspector/ElementsPanel.js.
              * inspector/front-end/ElementsTreeOutline.js: Renamed from WebCore/page/inspector/ElementsTreeOutline.js.
              * inspector/front-end/FontView.js: Renamed from WebCore/page/inspector/FontView.js.
              * inspector/front-end/ImageView.js: Renamed from WebCore/page/inspector/ImageView.js.
              * inspector/front-end/Images/back.png: Renamed from WebCore/page/inspector/Images/back.png.
              * inspector/front-end/Images/checker.png: Renamed from WebCore/page/inspector/Images/checker.png.
              * inspector/front-end/Images/clearConsoleButtons.png: Renamed from WebCore/page/inspector/Images/clearConsoleButtons.png.
              * inspector/front-end/Images/closeButtons.png: Renamed from WebCore/page/inspector/Images/closeButtons.png.
              * inspector/front-end/Images/consoleButtons.png: Renamed from WebCore/page/inspector/Images/consoleButtons.png.
              * inspector/front-end/Images/database.png: Renamed from WebCore/page/inspector/Images/database.png.
              * inspector/front-end/Images/databaseTable.png: Renamed from WebCore/page/inspector/Images/databaseTable.png.
              * inspector/front-end/Images/databasesIcon.png: Renamed from WebCore/page/inspector/Images/databasesIcon.png.
              * inspector/front-end/Images/debuggerContinue.png: Renamed from WebCore/page/inspector/Images/debuggerContinue.png.
              * inspector/front-end/Images/debuggerPause.png: Renamed from WebCore/page/inspector/Images/debuggerPause.png.
              * inspector/front-end/Images/debuggerStepInto.png: Renamed from WebCore/page/inspector/Images/debuggerStepInto.png.
              * inspector/front-end/Images/debuggerStepOut.png: Renamed from WebCore/page/inspector/Images/debuggerStepOut.png.
              * inspector/front-end/Images/debuggerStepOver.png: Renamed from WebCore/page/inspector/Images/debuggerStepOver.png.
              * inspector/front-end/Images/debuggingButtons.png: Renamed from WebCore/page/inspector/Images/debuggingButtons.png.
              * inspector/front-end/Images/disclosureTriangleSmallDown.png: Renamed from WebCore/page/inspector/Images/disclosureTriangleSmallDown.png.
              * inspector/front-end/Images/disclosureTriangleSmallDownBlack.png: Renamed from WebCore/page/inspector/Images/disclosureTriangleSmallDownBlack.png.
              * inspector/front-end/Images/disclosureTriangleSmallDownWhite.png: Renamed from WebCore/page/inspector/Images/disclosureTriangleSmallDownWhite.png.
              * inspector/front-end/Images/disclosureTriangleSmallRight.png: Renamed from WebCore/page/inspector/Images/disclosureTriangleSmallRight.png.
              * inspector/front-end/Images/disclosureTriangleSmallRightBlack.png: Renamed from WebCore/page/inspector/Images/disclosureTriangleSmallRightBlack.png.
              * inspector/front-end/Images/disclosureTriangleSmallRightDown.png: Renamed from WebCore/page/inspector/Images/disclosureTriangleSmallRightDown.png.
              * inspector/front-end/Images/disclosureTriangleSmallRightDownBlack.png: Renamed from WebCore/page/inspector/Images/disclosureTriangleSmallRightDownBlack.png.
              * inspector/front-end/Images/disclosureTriangleSmallRightDownWhite.png: Renamed from WebCore/page/inspector/Images/disclosureTriangleSmallRightDownWhite.png.
              * inspector/front-end/Images/disclosureTriangleSmallRightWhite.png: Renamed from WebCore/page/inspector/Images/disclosureTriangleSmallRightWhite.png.
              * inspector/front-end/Images/dockButtons.png: Renamed from WebCore/page/inspector/Images/dockButtons.png.
              * inspector/front-end/Images/elementsIcon.png: Renamed from WebCore/page/inspector/Images/elementsIcon.png.
              * inspector/front-end/Images/errorIcon.png: Renamed from WebCore/page/inspector/Images/errorIcon.png.
              * inspector/front-end/Images/errorMediumIcon.png: Renamed from WebCore/page/inspector/Images/errorMediumIcon.png.
              * inspector/front-end/Images/excludeButtons.png: Renamed from WebCore/page/inspector/Images/excludeButtons.png.
              * inspector/front-end/Images/focusButtons.png: Renamed from WebCore/page/inspector/Images/focusButtons.png.
              * inspector/front-end/Images/forward.png: Renamed from WebCore/page/inspector/Images/forward.png.
              * inspector/front-end/Images/glossyHeader.png: Renamed from WebCore/page/inspector/Images/glossyHeader.png.
              * inspector/front-end/Images/glossyHeaderPressed.png: Renamed from WebCore/page/inspector/Images/glossyHeaderPressed.png.
              * inspector/front-end/Images/glossyHeaderSelected.png: Renamed from WebCore/page/inspector/Images/glossyHeaderSelected.png.
              * inspector/front-end/Images/glossyHeaderSelectedPressed.png: Renamed from WebCore/page/inspector/Images/glossyHeaderSelectedPressed.png.
              * inspector/front-end/Images/goArrow.png: Renamed from WebCore/page/inspector/Images/goArrow.png.
              * inspector/front-end/Images/largerResourcesButtons.png: Renamed from WebCore/page/inspector/Images/largerResourcesButtons.png.
              * inspector/front-end/Images/nodeSearchButtons.png: Renamed from WebCore/page/inspector/Images/nodeSearchButtons.png.
              * inspector/front-end/Images/paneBottomGrow.png: Renamed from WebCore/page/inspector/Images/paneBottomGrow.png.
              * inspector/front-end/Images/paneBottomGrowActive.png: Renamed from WebCore/page/inspector/Images/paneBottomGrowActive.png.
              * inspector/front-end/Images/paneGrowHandleLine.png: Renamed from WebCore/page/inspector/Images/paneGrowHandleLine.png.
              * inspector/front-end/Images/pauseOnExceptionButtons.png: Renamed from WebCore/page/inspector/Images/pauseOnExceptionButtons.png.
              * inspector/front-end/Images/percentButtons.png: Renamed from WebCore/page/inspector/Images/percentButtons.png.
              * inspector/front-end/Images/profileGroupIcon.png: Renamed from WebCore/page/inspector/Images/profileGroupIcon.png.
              * inspector/front-end/Images/profileIcon.png: Renamed from WebCore/page/inspector/Images/profileIcon.png.
              * inspector/front-end/Images/profileSmallIcon.png: Renamed from WebCore/page/inspector/Images/profileSmallIcon.png.
              * inspector/front-end/Images/profilesIcon.png: Renamed from WebCore/page/inspector/Images/profilesIcon.png.
              * inspector/front-end/Images/recordButtons.png: Renamed from WebCore/page/inspector/Images/recordButtons.png.
              * inspector/front-end/Images/reloadButtons.png: Renamed from WebCore/page/inspector/Images/reloadButtons.png.
              * inspector/front-end/Images/resourceCSSIcon.png: Renamed from WebCore/page/inspector/Images/resourceCSSIcon.png.
              * inspector/front-end/Images/resourceDocumentIcon.png: Renamed from WebCore/page/inspector/Images/resourceDocumentIcon.png.
              * inspector/front-end/Images/resourceDocumentIconSmall.png: Renamed from WebCore/page/inspector/Images/resourceDocumentIconSmall.png.
              * inspector/front-end/Images/resourceJSIcon.png: Renamed from WebCore/page/inspector/Images/resourceJSIcon.png.
              * inspector/front-end/Images/resourcePlainIcon.png: Renamed from WebCore/page/inspector/Images/resourcePlainIcon.png.
              * inspector/front-end/Images/resourcePlainIconSmall.png: Renamed from WebCore/page/inspector/Images/resourcePlainIconSmall.png.
              * inspector/front-end/Images/resourcesIcon.png: Renamed from WebCore/page/inspector/Images/resourcesIcon.png.
              * inspector/front-end/Images/resourcesSizeGraphIcon.png: Renamed from WebCore/page/inspector/Images/resourcesSizeGraphIcon.png.
              * inspector/front-end/Images/resourcesTimeGraphIcon.png: Renamed from WebCore/page/inspector/Images/resourcesTimeGraphIcon.png.
              * inspector/front-end/Images/scriptsIcon.png: Renamed from WebCore/page/inspector/Images/scriptsIcon.png.
              * inspector/front-end/Images/searchSmallBlue.png: Renamed from WebCore/page/inspector/Images/searchSmallBlue.png.
              * inspector/front-end/Images/searchSmallBrightBlue.png: Renamed from WebCore/page/inspector/Images/searchSmallBrightBlue.png.
              * inspector/front-end/Images/searchSmallGray.png: Renamed from WebCore/page/inspector/Images/searchSmallGray.png.
              * inspector/front-end/Images/searchSmallWhite.png: Renamed from WebCore/page/inspector/Images/searchSmallWhite.png.
              * inspector/front-end/Images/segment.png: Renamed from WebCore/page/inspector/Images/segment.png.
              * inspector/front-end/Images/segmentEnd.png: Renamed from WebCore/page/inspector/Images/segmentEnd.png.
              * inspector/front-end/Images/segmentHover.png: Renamed from WebCore/page/inspector/Images/segmentHover.png.
              * inspector/front-end/Images/segmentHoverEnd.png: Renamed from WebCore/page/inspector/Images/segmentHoverEnd.png.
              * inspector/front-end/Images/segmentSelected.png: Renamed from WebCore/page/inspector/Images/segmentSelected.png.
              * inspector/front-end/Images/segmentSelectedEnd.png: Renamed from WebCore/page/inspector/Images/segmentSelectedEnd.png.
              * inspector/front-end/Images/splitviewDimple.png: Renamed from WebCore/page/inspector/Images/splitviewDimple.png.
              * inspector/front-end/Images/splitviewDividerBackground.png: Renamed from WebCore/page/inspector/Images/splitviewDividerBackground.png.
              * inspector/front-end/Images/statusbarBackground.png: Renamed from WebCore/page/inspector/Images/statusbarBackground.png.
              * inspector/front-end/Images/statusbarBottomBackground.png: Renamed from WebCore/page/inspector/Images/statusbarBottomBackground.png.
              * inspector/front-end/Images/statusbarButtons.png: Renamed from WebCore/page/inspector/Images/statusbarButtons.png.
              * inspector/front-end/Images/statusbarMenuButton.png: Renamed from WebCore/page/inspector/Images/statusbarMenuButton.png.
              * inspector/front-end/Images/statusbarMenuButtonSelected.png: Renamed from WebCore/page/inspector/Images/statusbarMenuButtonSelected.png.
              * inspector/front-end/Images/statusbarResizerHorizontal.png: Renamed from WebCore/page/inspector/Images/statusbarResizerHorizontal.png.
              * inspector/front-end/Images/statusbarResizerVertical.png: Renamed from WebCore/page/inspector/Images/statusbarResizerVertical.png.
              * inspector/front-end/Images/timelinePillBlue.png: Renamed from WebCore/page/inspector/Images/timelinePillBlue.png.
              * inspector/front-end/Images/timelinePillGray.png: Renamed from WebCore/page/inspector/Images/timelinePillGray.png.
              * inspector/front-end/Images/timelinePillGreen.png: Renamed from WebCore/page/inspector/Images/timelinePillGreen.png.
              * inspector/front-end/Images/timelinePillOrange.png: Renamed from WebCore/page/inspector/Images/timelinePillOrange.png.
              * inspector/front-end/Images/timelinePillPurple.png: Renamed from WebCore/page/inspector/Images/timelinePillPurple.png.
              * inspector/front-end/Images/timelinePillRed.png: Renamed from WebCore/page/inspector/Images/timelinePillRed.png.
              * inspector/front-end/Images/timelinePillYellow.png: Renamed from WebCore/page/inspector/Images/timelinePillYellow.png.
              * inspector/front-end/Images/tipBalloon.png: Renamed from WebCore/page/inspector/Images/tipBalloon.png.
              * inspector/front-end/Images/tipBalloonBottom.png: Renamed from WebCore/page/inspector/Images/tipBalloonBottom.png.
              * inspector/front-end/Images/tipIcon.png: Renamed from WebCore/page/inspector/Images/tipIcon.png.
              * inspector/front-end/Images/tipIconPressed.png: Renamed from WebCore/page/inspector/Images/tipIconPressed.png.
              * inspector/front-end/Images/toolbarItemSelected.png: Renamed from WebCore/page/inspector/Images/toolbarItemSelected.png.
              * inspector/front-end/Images/treeDownTriangleBlack.png: Renamed from WebCore/page/inspector/Images/treeDownTriangleBlack.png.
              * inspector/front-end/Images/treeDownTriangleWhite.png: Renamed from WebCore/page/inspector/Images/treeDownTriangleWhite.png.
              * inspector/front-end/Images/treeRightTriangleBlack.png: Renamed from WebCore/page/inspector/Images/treeRightTriangleBlack.png.
              * inspector/front-end/Images/treeRightTriangleWhite.png: Renamed from WebCore/page/inspector/Images/treeRightTriangleWhite.png.
              * inspector/front-end/Images/treeUpTriangleBlack.png: Renamed from WebCore/page/inspector/Images/treeUpTriangleBlack.png.
              * inspector/front-end/Images/treeUpTriangleWhite.png: Renamed from WebCore/page/inspector/Images/treeUpTriangleWhite.png.
              * inspector/front-end/Images/userInputIcon.png: Renamed from WebCore/page/inspector/Images/userInputIcon.png.
              * inspector/front-end/Images/userInputPreviousIcon.png: Renamed from WebCore/page/inspector/Images/userInputPreviousIcon.png.
              * inspector/front-end/Images/warningIcon.png: Renamed from WebCore/page/inspector/Images/warningIcon.png.
              * inspector/front-end/Images/warningMediumIcon.png: Renamed from WebCore/page/inspector/Images/warningMediumIcon.png.
              * inspector/front-end/Images/warningsErrors.png: Renamed from WebCore/page/inspector/Images/warningsErrors.png.
              * inspector/front-end/MetricsSidebarPane.js: Renamed from WebCore/page/inspector/MetricsSidebarPane.js.
              * inspector/front-end/Object.js: Renamed from WebCore/page/inspector/Object.js.
              * inspector/front-end/ObjectPropertiesSection.js: Renamed from WebCore/page/inspector/ObjectPropertiesSection.js.
              * inspector/front-end/Panel.js: Renamed from WebCore/page/inspector/Panel.js.
              * inspector/front-end/Placard.js: Renamed from WebCore/page/inspector/Placard.js.
              * inspector/front-end/ProfileView.js: Renamed from WebCore/page/inspector/ProfileView.js.
              * inspector/front-end/ProfilesPanel.js: Renamed from WebCore/page/inspector/ProfilesPanel.js.
              * inspector/front-end/PropertiesSection.js: Renamed from WebCore/page/inspector/PropertiesSection.js.
              * inspector/front-end/PropertiesSidebarPane.js: Renamed from WebCore/page/inspector/PropertiesSidebarPane.js.
              * inspector/front-end/Resource.js: Renamed from WebCore/page/inspector/Resource.js.
              * inspector/front-end/ResourceCategory.js: Renamed from WebCore/page/inspector/ResourceCategory.js.
              * inspector/front-end/ResourceView.js: Renamed from WebCore/page/inspector/ResourceView.js.
              * inspector/front-end/ResourcesPanel.js: Renamed from WebCore/page/inspector/ResourcesPanel.js.
              * inspector/front-end/ScopeChainSidebarPane.js: Renamed from WebCore/page/inspector/ScopeChainSidebarPane.js.
              * inspector/front-end/Script.js: Renamed from WebCore/page/inspector/Script.js.
              * inspector/front-end/ScriptView.js: Renamed from WebCore/page/inspector/ScriptView.js.
              * inspector/front-end/ScriptsPanel.js: Renamed from WebCore/page/inspector/ScriptsPanel.js.
              * inspector/front-end/SidebarPane.js: Renamed from WebCore/page/inspector/SidebarPane.js.
              * inspector/front-end/SidebarTreeElement.js: Renamed from WebCore/page/inspector/SidebarTreeElement.js.
              * inspector/front-end/SourceFrame.js: Renamed from WebCore/page/inspector/SourceFrame.js.
              * inspector/front-end/SourceView.js: Renamed from WebCore/page/inspector/SourceView.js.
              * inspector/front-end/StylesSidebarPane.js: Renamed from WebCore/page/inspector/StylesSidebarPane.js.
              * inspector/front-end/TextPrompt.js: Renamed from WebCore/page/inspector/TextPrompt.js.
              * inspector/front-end/View.js: Renamed from WebCore/page/inspector/View.js.
              * inspector/front-end/WebKit.qrc: Renamed from WebCore/page/inspector/WebKit.qrc.
              * inspector/front-end/inspector.css: Renamed from WebCore/page/inspector/inspector.css.
              * inspector/front-end/inspector.html: Renamed from WebCore/page/inspector/inspector.html.
              * inspector/front-end/inspector.js: Renamed from WebCore/page/inspector/inspector.js.
              * inspector/front-end/treeoutline.js: Renamed from WebCore/page/inspector/treeoutline.js.
              * inspector/front-end/utilities.js: Renamed from WebCore/page/inspector/utilities.js.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@37289 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      9c94f6b0
  8. 02 Oct, 2008 1 commit
  9. 17 Jun, 2008 1 commit
    • timothy@apple.com's avatar
      Use accurate call frame title's based on the call frame type. · c14b52ce
      timothy@apple.com authored
      Added a type to DebuggerCallFrame so the under interface can
      distinguish anonymous functions and program call frames.
      
      JavaScriptCore:
      
      2008-06-16  Timothy Hatcher  <timothy@apple.com>
      
              Added a type to DebuggerCallFrame so the under interface can
              distinguish anonymous functions and program call frames.
      
              https://bugs.webkit.org/show_bug.cgi?id=19585
      
              Reviewed by Geoff Garen.
      
              * JavaScriptCore.exp: Export the DebuggerCallFrame::type symbol.
              * kjs/DebuggerCallFrame.cpp:
              (KJS::DebuggerCallFrame::type): Added.
              * kjs/DebuggerCallFrame.h:
      
      WebCore:
      
      2008-06-16  Timothy Hatcher  <timothy@apple.com>
      
              Use accurate call frame title's based on the call frame type.
      
              https://bugs.webkit.org/show_bug.cgi?id=19585
      
              Reviewed by Geoff Garen.
      
              * English.lproj/localizedStrings.js: Updated strings.
              * bindings/js/JSJavaScriptCallFrameCustom.cpp:
              (WebCore::JSJavaScriptCallFrame::evaluate): Removed the isValid()
              check since the evaluate() functiondoes the check already.
              (WebCore::JSJavaScriptCallFrame::thisObject): Removed the isValid()
              check, since thisObject() does the check and returns null if invalid.
              (WebCore::JSJavaScriptCallFrame::type): Return a string
              based on the enum value of the type.
              (WebCore::JSJavaScriptCallFrame::scopeChain): Removed the isValid()
              check, since scopeChain() does the check and returns null if invalid.
              So just null check scopeChain().
              * page/JavaScriptCallFrame.cpp:
              (WebCore::JavaScriptCallFrame::type): Return the DebuggerCallFrame::Type.
              Return DebuggerCallFrame::UnknownType if the call frame is invalid.
              * page/JavaScriptCallFrame.h:
              * page/JavaScriptCallFrame.idl: Add the type property.
              * page/inspector/CallStackSidebarPane.js:
              (WebInspector.CallStackSidebarPane.prototype.update): Check the type
              of the call frame to create the correct title.
              * page/inspector/ScriptsPanel.js:
              (WebInspector.ScriptsPanel.prototype._addScriptToFilesMenu): Use the
              "(program)" title for the file menu to match the call frames.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@34634 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      c14b52ce
  10. 16 May, 2008 1 commit
    • timothy@apple.com's avatar
      Adds the "this" object to the Local scope section of the · 79564f99
      timothy@apple.com authored
      Scope Variables pane.
      
      <rdar://problem/5774773> Web Inspector doesn't show the "this"
      object in its variables list (10438)
      
      Reviewed by Oliver Hunt.
      
      * bindings/js/JSJavaScriptCallFrameCustom.cpp:
      (WebCore::JSJavaScriptCallFrame::thisObject): Returns the thisObject
      of the JavaScriptCallFrame impl. Returns jsNull if the impl is invalid.
      * page/JavaScriptCallFrame.cpp:
      (WebCore::JavaScriptCallFrame::thisObject): Return the thisValue from
      the ExecState. Return 0 if m_exec is null.
      * page/JavaScriptCallFrame.h:
      * page/JavaScriptCallFrame.idl: Add thisObject.
      * page/inspector/ObjectPropertiesSection.js:
      (WebInspector.ObjectPropertiesSection): Adds two new arguments.
      The ignoreHasOwnProperty tells the section to show all properties,
      including inherited ones. And extraProperties is an object of
      additional properties to show.
      (WebInspector.ObjectPropertiesSection.prototype): Honor the
      extraProperties and ignoreHasOwnProperty properties.
      * page/inspector/ScopeChainSidebarPane.js:
      (WebInspector.ScopeChainSidebarPane.prototype.update): Add a this
      property to an extra object that is passed to the ObjectPropertiesSection.
      Also pass true for ignoreHasOwnProperty since we want to show all properties.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@33534 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      79564f99
  11. 13 May, 2008 1 commit
    • timothy@apple.com's avatar
      Adds a JavaScriptCallFrame object and JavaScript binding with an IDL. · dec8c517
      timothy@apple.com authored
      This object will expose the stack to the Inspector's debugger.
      
      Reviewed by Adam Roben.
      
      * DerivedSources.make: Add JavaScriptCallFrame.
      * bindings/js/JSJavaScriptCallFrameCustom.cpp: Added.
      (WebCore::JSJavaScriptCallFrame::evaluate): Calls impl evaluate and returns the result.
      (WebCore::JSJavaScriptCallFrame::scopeChain): Makes an array of the ScopeChain.
      * page/JavaScriptCallFrame.cpp: Added.
      (WebCore::JavaScriptCallFrame::JavaScriptCallFrame):
      (WebCore::JavaScriptCallFrame::caller): Returns m_caller.
      (WebCore::JavaScriptCallFrame::functionName): Returns the function
      name from the ExecState if this is not global code or anonymous.
      (WebCore::JavaScriptCallFrame::evaluate): Evaluates a script string
      in the scope of the call frame.
      * page/JavaScriptCallFrame.h: Added.
      (WebCore::JavaScriptCallFrame::create): Call the ctor can return in a PassRefPtr.
      (WebCore::JavaScriptCallFrame::invalidate): Sets m_mexec to 0. This prevents a
      stale ExecState from being accessed after the lifetime of the ExecState.
      (WebCore::JavaScriptCallFrame::isValid): Checks if m_exec is 0.
      (WebCore::JavaScriptCallFrame::execState): Returns m_exec.
      (WebCore::JavaScriptCallFrame::sourceIdentifier): Returns m_sourceID.
      (WebCore::JavaScriptCallFrame::line): Returns m_line.
      (WebCore::JavaScriptCallFrame::setLine): Sets m_line.
      (WebCore::JavaScriptCallFrame::scopeChain): Returns by reference m_exec->scopeChain().
      * page/JavaScriptCallFrame.idl: Added.
      * WebCore.xcodeproj/project.pbxproj: Add new files.
      * WebCore.vcproj/WebCore.vcproj: Ditto.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@33397 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      dec8c517
  12. 21 Apr, 2008 1 commit
    • timothy@apple.com's avatar
      Adds the UI portions of the Scripts panel to the Web Inspector. · fd501dfc
      timothy@apple.com authored
      The Scripts panel has not been added to the toolbar yet.
      
      https://bugs.webkit.org/show_bug.cgi?id=18601
      
      Reviewed by Adam Roben.
      
      * English.lproj/InspectorLocalizedStrings.js: Changed "Show inherited properties"
      to "Show inherited". Adds new strings for the Scripts' panel tooltips.
      * page/inspector/BreakpointsSidebarPane.js: Added.
      * page/inspector/CallStackSidebarPane.js: Added.
      * page/inspector/Images/back.png: Added.
      * page/inspector/Images/debuggerContinue.png: Added.
      * page/inspector/Images/debuggerPause.png: Added.
      * page/inspector/Images/debuggerStepInto.png: Added.
      * page/inspector/Images/debuggerStepOut.png: Added.
      * page/inspector/Images/debuggerStepOver.png: Added.
      * page/inspector/Images/forward.png: Added.
      * page/inspector/Images/statusbarResizerHorizontal.png: Added.
      * page/inspector/PropertiesSection.js:
      (WebInspector.PropertiesSection): Flip the order the subtile is appended
      so it can float right in the CSS.
      * page/inspector/Sc...
      fd501dfc
  13. 18 Apr, 2008 1 commit
    • jhoneycutt@apple.com's avatar
      2008-04-17 Jon Honeycutt <jhoneycutt@apple.com> · 2904f97b
      jhoneycutt@apple.com authored
              Reviewed by Darin.
      
              Return an AccessibleDocument when our root accessible object is queried
              for.
      
              * AccessibleDocument.cpp: Added; represents an AccessibilityObject that
              itself represents a Document.
              (AccessibleDocument::AccessibleDocument): Initialize AccessibleBase with
              the AccessibilityObject for this Document.
              * AccessibleDocument.h: Added.
              * WebFrame.cpp:
              (WebFrame::accessible): If m_accessible is 0, or if Document in this
              frame does not match the Document in the cached m_accessible object,
              create a new AccessibleDocument for this frame's Document.
              * WebFrame.h: Swap AccessibleBase.h for AccessibleDocument.h
              * WebKit.vcproj/WebKit.vcproj: Add AccessibleDocument.{h,cpp}
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@32250 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      2904f97b
  14. 16 Apr, 2008 1 commit
    • andersca@apple.com's avatar
      2008-04-16 Anders Carlsson <andersca@apple.com> · c6839d1c
      andersca@apple.com authored
              Reviewed by Adam.
      
              Generate the DOMApplicationCache JS wrapper, add JSDOMApplicationCacheCustom.cpp and 
              fix typos in the #if line.
              
              * DerivedSources.make:
              * WebCore.vcproj/WebCore.vcproj:
              * WebCore.xcodeproj/project.pbxproj:
              * bindings/js/JSDOMApplicationCacheCustom.cpp: Added.
              * loader/appcache/ApplicationCache.cpp:
              * loader/appcache/ApplicationCache.h:
              * loader/appcache/ApplicationCacheGroup.cpp:
              * loader/appcache/ApplicationCacheGroup.h:
              * loader/appcache/ApplicationCacheResource.cpp:
              * loader/appcache/ApplicationCacheResource.h:
              * loader/appcache/DOMApplicationCache.cpp:
              * loader/appcache/DOMApplicationCache.h:
              * loader/appcache/DOMApplicationCache.idl:
              * loader/appcache/ManifestParser.cpp:
              * loader/appcache/ManifestParser.h:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@31963 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      c6839d1c
  15. 15 Apr, 2008 1 commit
    • andersca@apple.com's avatar
      JavaScriptCore: · b8666938
      andersca@apple.com authored
      2008-04-15  Anders Carlsson  <andersca@apple.com>
      
              Reviewed by Adam.
      
              Add ENABLE_OFFLINE_WEB_APPLICATIONS to FEATURE_DEFINES.
              
              * Configurations/JavaScriptCore.xcconfig:
      
      WebCore:
      
      2008-04-15  Anders Carlsson  <andersca@apple.com>
      
              Reviewed by Adam.
      
              Add empty files for the application cache.
              
              * Configurations/WebCore.xcconfig:
              * WebCore.vcproj/WebCore.vcproj:
              * WebCore.vcproj/build-generated-files.sh:
              Add ENABLE_OFFLINE_WEB_APPLICATIONS to FEATURE_DEFINES.
              
              * WebCore.xcodeproj/project.pbxproj:
              * loader/appcache: Added.
              * loader/appcache/ApplicationCache.cpp: Added.
              * loader/appcache/ApplicationCache.h: Added.
              * loader/appcache/ApplicationCacheGroup.cpp: Added.
              * loader/appcache/ApplicationCacheGroup.h: Added.
              * loader/appcache/ApplicationCacheResource.cpp: Added.
              * loader/appcache/ApplicationCacheResource.h: Added.
              * loader/...
      b8666938
  16. 23 Feb, 2008 1 commit
    • ddkilzer@apple.com's avatar
      WebCore: · 267da135
      ddkilzer@apple.com authored
              Please clarify licensing for some files
              <http://bugs.webkit.org/show_bug.cgi?id=14970>
      
              Reviewed by Darin.
      
              * bindings/objc/WebScriptObject.h: Added Apple BSD-style license.
              * bindings/objc/WebScriptObjectPrivate.h: Ditto.
              * platform/text/mac/ShapeArabic.c: Added ICU license from WebCore/icu/LICENSE.
      
      WebKit/mac:
      
              Please clarify licensing for some files
              <http://bugs.webkit.org/show_bug.cgi?id=14970>
      
              Reviewed by Darin.
      
              * Plugins/WebNetscapeDeprecatedFunctions.c: Updated copyright statement
              and added Apple BSD-style license.
              * Plugins/WebNetscapeDeprecatedFunctions.h: Ditto.
      
      WebKitTools:
      
              Please clarify licensing for some files
              <http://bugs.webkit.org/show_bug.cgi?id=14970>
      
              Reviewed by Darin.
      
              * DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.cpp: Added
              copyright statement.  Replaced license with newer Apple BSD-style license.
              * DumpRenderTree/Te...
      267da135
  17. 30 Mar, 2007 2 commits
    • andersca's avatar
      Reviewed by Geoff. · b5e193f8
      andersca authored
              * DumpRenderTree/TestNetscapePlugIn.subproj/TestObject.c:
              (testAllocate):
              (testEnumerate):
              Add casts.
              
              * DumpRenderTree/TestNetscapePlugIn.subproj/TestObject.h:
              Don't use #import, use #include.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@20619 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      b5e193f8
    • andersca's avatar
      JavaScriptCore: · 77d5e0d0
      andersca authored
              Reviewed by Geoff.
      
              Implement _NPN_Enumerate support.
              
              * JavaScriptCore.exp:
              * bindings/NP_jsobject.cpp:
              (_NPN_Enumerate):
              * bindings/c/c_instance.cpp:
              (KJS::Bindings::CInstance::getPropertyNames):
              * bindings/c/c_instance.h:
              * bindings/npapi.h:
              * bindings/npruntime.h:
              * bindings/npruntime_impl.h:
              * bindings/runtime.h:
              (KJS::Bindings::Instance::getPropertyNames):
              * bindings/runtime_object.cpp:
              (RuntimeObjectImp::getPropertyNames):
              * bindings/runtime_object.h:
              (KJS::RuntimeObjectImp::getInternalInstance):
      
      LayoutTests:
      
              Reviewed by Geoff.
      
              Add enumeration test.
              
              * plugins/netscape-enumerate-expected.txt: Added.
              * plugins/netscape-enumerate.html: Added.
      
      WebKit:
      
              Reviewed by Geoff.
      
              * Plugins/WebNetscapePluginPackage.m:
              (-[WebNetscapePluginPackage load]):
              Initialize pushpopupsenab...
      77d5e0d0
  18. 29 Mar, 2007 1 commit
    • ggaren's avatar
      LayoutTests: · 2663f9a7
      ggaren authored
              Reviewed by Beth Dakin.
              
              Layout test for <rdar://problem/5091330> REGRESSION: Repro crash in 
              -[WebBaseNetscapePluginView(WebNPPCallbacks) destroyStream:reason:] 
              navigating away from page with DivX movie plug-in (13203)
      
              * plugins/destroy-stream-twice-expected.txt: Added.
              * plugins/destroy-stream-twice.html: Added.
      
      WebKit:
      
              Reviewed by Beth Dakin, reviewed by Maciej Stachowiak.
              
              Layout test for <rdar://problem/5091330> REGRESSION: Repro crash in 
              -[WebBaseNetscapePluginView(WebNPPCallbacks) destroyStream:reason:] 
              navigating away from page with DivX movie plug-in (13203)
              
              Changed LOG_ERROR to LOG so the layout test doesn't produce console spew
              every time you run it.
      
              * Plugins/WebBaseNetscapePluginView.mm:
              (-[WebBaseNetscapePluginView destroyStream:reason:]):
      
      WebKitTools:
      
              Reviewed by Beth Dakin.
              
              Layout test for <rdar://problem/5091330> REGRESSION: Repro crash in 
              -[WebBaseNetscapePluginView(WebNPPCallbacks) destroyStream:reason:] 
              navigating away from page with DivX movie plug-in (13203)
              
              Added hasStream property and destroyStream function, used by layout test.
      
              * DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.c:
              (pluginGetProperty):
              (pluginInvoke):
              (pluginAllocate):
              * DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.h:
              * DumpRenderTree/TestNetscapePlugIn.subproj/main.c:
              (NPP_NewStream):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@20597 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      2663f9a7
  19. 05 Mar, 2007 1 commit
    • andersca's avatar
      LayoutTests: · 526c36f0
      andersca authored
              Reviewed by Adam, Darin.
      
              <rdar://problem/5025212>
              In Mail, a crash occurs at WebCore::Frame::tree() when clicking on embedded flash object
      
              * plugins/get-url-with-blank-target-expected.txt: Added.
              * plugins/get-url-with-blank-target.html: Added.
      
      WebKit:
      
              Reviewed by Adam, Darin.
       
              <rdar://problem/5025212>
              In Mail, a crash occurs at WebCore::Frame::tree() when clicking on embedded flash object
      
              * Plugins/WebBaseNetscapePluginView.mm:
              (-[WebBaseNetscapePluginView loadPluginRequest:]):
              Handle the case where the web view returned from the delegate method is null. Also, send out an error notification
              in that case so we can catch it.
      
      WebKitTools:
      
              Reviewed by Adam, Darin.
      
              <rdar://problem/5025212>
              In Mail, a crash occurs at WebCore::Frame::tree() when clicking on embedded flash object
              
              Add a "getURLNotify" method to the plugin object. This lets you pass a URL, a target and a callback function
              to be run when the URL has finished (or failed) loading.
              
              * DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.c:
              (pluginInvoke):
              (handleCallback):
              * DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.h:
              * DumpRenderTree/TestNetscapePlugIn.subproj/main.c:
              (NPP_URLNotify):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@19966 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      526c36f0
  20. 06 Nov, 2006 1 commit
    • ap's avatar
      Reviewed by Maciej. · fdfb9d6f
      ap authored
              http://bugs.webkit.org/show_bug.cgi?id=11517
              REGRESSION: Flash clicks/interactivity not working properly
      
      WebCore:
              * bridge/mac/FrameMac.mm:
              (WebCore::FrameMac::handleMouseMoveEvent):
              (WebCore::FrameMac::handleMouseReleaseEvent):
              Restore parts of event dispatching that were removed when fixing
              bug 7323 - just bypass those for subframes.
      
      WebKitTools:
              Teach TestNetscapePlugin to log events passed to it. To enable, set eventLoggingEnabled to true:
      
              <embed name="plg" type="application/x-webkit-test-netscape" width=100 height=100></embed>
              <script>
                  plg.eventLoggingEnabled = true;
                  // use eventSender to simulate events...
              </script>
      
              * DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.c:
              (pluginGetProperty):
              (pluginSetProperty):
              (pluginAllocate):
              * DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.h:
              * DumpRenderTree/TestNetscapePlugIn.subproj/main.c:
              (NPP_HandleEvent):
      
      LayoutTests:
              * plugins/mouse-events-expected.txt: Added.
              * plugins/mouse-events.html: Added.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@17611 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      fdfb9d6f
  21. 09 Mar, 2006 1 commit
    • darin's avatar
      Reviewed by John Sullivan. · 24fbf130
      darin authored
              - fix http://bugzilla.opendarwin.org/show_bug.cgi?id=7681
                memory leak in the plug-in tests
      
              * DumpRenderTree/TestNetscapePlugIn.subproj/main.c:
              (NPP_Destroy): Added code to release the plug-in object. This is the leak fix.
              (NPP_SetWindow): Remove unneeded code to store the window pointer.
      
              * DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.c:
              Moved the browser global in here since it's declared in this file's header.
              Changed the code to set up the pluginClass structure to not use function
              pointer casts. Those are dangerous because they can hide many types of mismatch.
              And indeed when I did this I discovered that many functions were missing their
              boolean return values or had parameter declarations with the wrong types.
              (pluginGetProperty): Use STRINGZ_TO_NPVARIANT macro for greater simplicity and
              clarity. Added boolean return value: return true when successful and false when not.
              (pluginSetProperty): Added boolean return value, return false since we have no
              properties we can set.
              (pluginInvoke): Added boolean return value. Return true when successful and false
              when not. Use NPVARIANT macros where appropriate. Added a missing release for the
              return value from calling the browser. Changed code to put the strings in malloc
              buffers instead of relying on GCC's extension that allows variable-sized arrays
              on the stack.
              (pluginInvokeDefault): Added boolean return value, return false since we have no
              default function to call.
              (pluginInvalidate): Added missing parameter. Removed comment.
              (pluginAllocate): Removed unneeded cast. This is C code, not C++, so you don't have
              to cast the result of malloc.
              (pluginDeallocate): Removed uneeded cast.
      
              * DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.h: Removed some unneeded
              includes. Changed our PluginObject to use NPObject instead of re-declaring fields
              that match NPObject's fields. Removed unused NPWindow pointer.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@13233 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      24fbf130
  22. 05 Jan, 2006 1 commit
    • ggaren's avatar
      LayoutTests: · 7dd73f87
      ggaren authored
              Layout test for http://bugzilla.opendarwin.org/show_bug.cgi?id=6318
              REGRESSION: Repro crash in JS called from Flash on bdash.net.nz
      
              * fast/plugins/netscape-back-forward-expected.txt: Added.
              * fast/plugins/netscape-back-forward.html: Added.
              * fast/plugins/resources/go-back.html: Added.
      
      WebKit:
      
              Reviewed by Darin.
      
              - Fixed http://bugzilla.opendarwin.org/show_bug.cgi?id=6361
              Add plugin support to DumpRenderTree
      
              * WebKit.exp: export WebPluginDatabase class, which DumpRenderTree
              needs to add plugins to the runtime.
      
      WebKitTools:
      
              Reviewed by darin.
      
              - Fixed http://bugzilla.opendarwin.org/show_bug.cgi?id=6361
              Add plugin support to DumpRenderTree
      
              Also wrote first test plugin.
      
              * DumpRenderTree/DumpRenderTree.m:
              (main):
              (1) Put the WebView in an invisible window, because PlugIns are
              optimized not to load if there's no parent window.
              (2) Tell WebKit to load any PlugIns in the directory from which we
              loaded. This means we can build nasty PlugIns alongside DumpRenderTree
              and they'll load automagically during layout testing, but they won't be
              added to the user's system, hosing apps like Safari.
      
              * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj: Added new
              test PlugIn to project.
      
              PlugIn added to project:
      
              * DumpRenderTree/TestNetscapePlugIn.subproj/Info.plist: Added.
              * DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.c: Added.
              (getPluginClass):
              (initializeIdentifiers):
              (pluginHasProperty):
              (pluginHasMethod):
              (pluginGetProperty):
              (pluginSetProperty):
              (pluginInvoke):
              (pluginInvokeDefault):
              (pluginInvalidate):
              (pluginAllocate):
              (pluginDeallocate):
              * DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.h: Added.
              * DumpRenderTree/TestNetscapePlugIn.subproj/main.c: Added.
              (NP_Initialize):
              (NP_GetEntryPoints):
              (NP_Shutdown):
              (NPP_New):
              (NPP_Destroy):
              (NPP_SetWindow):
              (NPP_NewStream):
              (NPP_DestroyStream):
              (NPP_WriteReady):
              (NPP_Write):
              (NPP_StreamAsFile):
              (NPP_Print):
              (NPP_HandleEvent):
              (NPP_URLNotify):
              (NPP_GetValue):
              (NPP_SetValue):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@11885 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      7dd73f87