- 19 May, 2010 40 commits
-
-
barraclough@apple.com authored
Reviewed by NOBODY (build fix). * JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def: git-svn-id: http://svn.webkit.org/repository/webkit/trunk@59813 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
barraclough@apple.com authored
Reviewed by NOBODY (build fix). * JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def: git-svn-id: http://svn.webkit.org/repository/webkit/trunk@59812 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
barraclough@apple.com authored
Reviewed by Oliver Hunt. re-landing r59800. * JavaScriptCore.exp: * interpreter/Interpreter.cpp: (JSC::Interpreter::retrieveCaller): (JSC::Interpreter::findFunctionCallFrame): * interpreter/Interpreter.h: * profiler/Profiler.cpp: (JSC::Profiler::createCallIdentifier): * runtime/FunctionPrototype.cpp: (JSC::functionProtoFuncToString): * runtime/JSFunction.cpp: (JSC::): (JSC::JSFunction::JSFunction): (JSC::JSFunction::name): (JSC::JSFunction::displayName): (JSC::JSFunction::calculatedDisplayName): * runtime/JSFunction.h: * runtime/JSObject.cpp: (JSC::JSObject::putDirectFunction): (JSC::JSObject::putDirectFunctionWithoutTransition): * runtime/JSObject.h: * runtime/Lookup.cpp: (JSC::setUpStaticFunctionSlot): WebCore: Rubber Stamped by Sam Weinig. JSFunctions are no longer a subclass of InternalFunction. * bindings/js/ScriptCallStack.cpp: (WebCore::ScriptCallStack::ScriptCallStack): (WebCore::ScriptCallStack::initialize): * bindings/js/ScriptCallStack.h: git-svn-id: http://svn.webkit.org/repository/webkit/trunk@59811 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
barraclough@apple.com authored
Reviewed by NOBODY (build fix). * JavaScriptCore.exp: * interpreter/Interpreter.cpp: (JSC::Interpreter::retrieveCaller): (JSC::Interpreter::findFunctionCallFrame): * interpreter/Interpreter.h: * profiler/Profiler.cpp: (JSC::Profiler::createCallIdentifier): * runtime/FunctionPrototype.cpp: (JSC::functionProtoFuncToString): * runtime/JSFunction.cpp: (JSC::): (JSC::JSFunction::JSFunction): * runtime/JSFunction.h: * runtime/JSObject.cpp: * runtime/JSObject.h: * runtime/Lookup.cpp: (JSC::setUpStaticFunctionSlot): git-svn-id: http://svn.webkit.org/repository/webkit/trunk@59801 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
barraclough@apple.com authored
Reviewed by Oliver Hunt. This may prevent us from introducing a more useful parent class to JSFunction, e.g. a JSObject that holds an executable, which could also reference an eval or program executable. * JavaScriptCore.exp: * interpreter/Interpreter.cpp: (JSC::Interpreter::retrieveCaller): (JSC::Interpreter::findFunctionCallFrame): * interpreter/Interpreter.h: * profiler/Profiler.cpp: (JSC::Profiler::createCallIdentifier): * runtime/FunctionPrototype.cpp: (JSC::functionProtoFuncToString): * runtime/JSFunction.cpp: (JSC::): (JSC::JSFunction::JSFunction): (JSC::JSFunction::name): (JSC::JSFunction::displayName): (JSC::JSFunction::calculatedDisplayName): * runtime/JSFunction.h: * runtime/JSObject.cpp: (JSC::JSObject::putDirectFunction): (JSC::JSObject::putDirectFunctionWithoutTransition): * runtime/JSObject.h: * runtime/Lookup.cpp: (JSC::setUpStaticFunctionSlot): git-svn-id: http://svn.webkit.org/repository/webkit/trunk@59800 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
victorw@chromium.org authored
Unreviewed. Update Chromium test expectations. * platform/chromium-linux/fast/multicol/layers-split-across-columns-expected.checksum: Added. * platform/chromium-linux/fast/multicol/layers-split-across-columns-expected.png: Added. * platform/chromium-mac/fast/multicol/layers-in-multicol-expected.checksum: * platform/chromium-mac/fast/multicol/layers-in-multicol-expected.png: Removed. * platform/chromium-mac/fast/multicol/layers-split-across-columns-expected.checksum: Added. * platform/chromium-win/fast/multicol/layers-in-multicol-expected.txt: * platform/chromium-win/fast/multicol/layers-split-across-columns-expected.checksum: Added. * platform/chromium-win/fast/multicol/layers-split-across-columns-expected.png: Added. * platform/chromium-win/fast/multicol/layers-split-across-columns-expected.txt: Added. * platform/chromium-win/fast/multicol/nested-columns-expected.txt: git-svn-id: http://svn.webkit.org/repository/webkit/trunk@59799 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
oliver@apple.com authored
Reviewed by Geoffrey Garen. emitJumpIfNotJSCell should special case constant immediate values https://bugs.webkit.org/show_bug.cgi?id=39392 <rdar://problem/8001324> Make emitJumpSlowCaseIfNotJSCell special case constant immediate values, in addition to the immediate JSCell optimisation. Also add assertions to make sure no one else produces code that attempts to load constants from the register file. * jit/JITInlineMethods.h: (JSC::JIT::emitJumpSlowCaseIfNotJSCell): * jit/JSInterfaceJIT.h: (JSC::JSInterfaceJIT::emitJumpIfNotJSCell): (JSC::JSInterfaceJIT::emitLoadInt32): (JSC::JSInterfaceJIT::tagFor): (JSC::JSInterfaceJIT::payloadFor): (JSC::JSInterfaceJIT::emitLoadDouble): (JSC::JSInterfaceJIT::addressFor): * jit/ThunkGenerators.cpp: 2010-05-19 Oliver Hunt <oliver@apple.com> Reviewed by Geoffrey Garen. emitJumpIfNotJSCell should special case constant immediate values https://bugs.webkit.org/show_bug.cgi?id=39392 Add tests for immediate constants being used where cells are expected. * fast/js/immediate-constant-instead-of-cell-expected.txt: Added. * fast/js/immediate-constant-instead-of-cell.html: Added. * fast/js/script-tests/immediate-constant-instead-of-cell.js: Added. (): git-svn-id: http://svn.webkit.org/repository/webkit/trunk@59798 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
jianli@chromium.org authored
https://bugs.webkit.org/show_bug.cgi?id=39131 Reviewed by Alexey Proskuryakov. WebCore: Changed FileReader::convertToText to call TextResourceDecoder::decode to detect the encoding from BOM and decode the text. Though the File API spec says that the supplied encoding should be used if it is valid, we choose to ignore this requirement in order to be consistent with how WebKit decodes the web content: always has the BOM override the provided encoding. * html/FileReader.cpp: (WebCore::FileReader::convertToText): * html/FileReader.h: LayoutTests: Add more test coverage for FileReader. * fast/files/file-reader-expected.txt: * fast/files/file-reader.html: * fast/files/resources/binary-file: Added. git-svn-id: http://svn.webkit.org/repository/webkit/trunk@59797 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
mrobinson@webkit.org authored
https://bugs.webkit.org/show_bug.cgi?id=39388 Disabling geolocation tests until blockers are fixed. * platform/gtk/Skipped: Skipping geolocation tests for now. git-svn-id: http://svn.webkit.org/repository/webkit/trunk@59796 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
yaar@chromium.org authored
Reviewed by David Hyatt. Check that the node is a text node before doing a static cast to a Text class pointer. https://bugs.webkit.org/show_bug.cgi?id=38626 Test: fast/text/text-transform-nontext-node-crash.xhtml * rendering/RenderText.cpp: (WebCore::RenderText::originalText): * rendering/RenderTextFragment.cpp: (WebCore::RenderTextFragment::originalText): (WebCore::RenderTextFragment::previousCharacter): 2010-05-19 Abhishek Arya <inferno@chromium.org> Reviewed by David Hyatt. Tests that text transformation applied to a non-text node does not result in crash. https://bugs.webkit.org/show_bug.cgi?id=38626 * fast/text/text-transform-nontext-node-crash-expected.txt: Added. * fast/text/text-transform-nontext-node-crash.xhtml: Added. git-svn-id: http://svn.webkit.org/repository/webkit/trunk@59795 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
yaar@chromium.org authored
Reviewed by Eric Seidel. Fixed warnings by JSC overloads changes. Also updated the binding reference files for JSC. https://bugs.webkit.org/show_bug.cgi?id=39390 * bindings/scripts/CodeGeneratorJS.pm: * bindings/scripts/test/JS/JSTestInterface.cpp: (WebCore::): * bindings/scripts/test/JS/JSTestObj.cpp: (WebCore::): git-svn-id: http://svn.webkit.org/repository/webkit/trunk@59794 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
rdar://problem/8004528andersca@apple.com authored
REGRESSION: Coordinate system for Core Animation NPAPI plug-ins is flipped with accelerated compositing turned on Reviewed by Kevin Decker and Simon Fraser. When needed, create a new CALayer and set it's geometry to be flipped. Add the plug-in layer as a sublayer and then return the newly created layer. * Plugins/Hosted/WebHostedNetscapePluginView.mm: (-[WebHostedNetscapePluginView createPlugin]): * Plugins/WebNetscapePluginView.mm: (-[WebNetscapePluginView createPlugin]): git-svn-id: http://svn.webkit.org/repository/webkit/trunk@59793 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
mrobinson@webkit.org authored
Not reviewed. Updated multi-column test baselines. * platform/gtk/fast/multicol/layers-in-multicol-expected.txt: Updated. * platform/gtk/fast/multicol/layers-split-across-columns-expected.txt: Added. * platform/gtk/fast/multicol/nested-columns-expected.txt: Updated. git-svn-id: http://svn.webkit.org/repository/webkit/trunk@59792 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
ggaren@apple.com authored
Reviewed by Sam Weinig. Slight refactoring to CodeBlock bytecode access https://bugs.webkit.org/show_bug.cgi?id=39384 * bytecode/CodeBlock.h: (JSC::CodeBlock::bytecodeOffset): * interpreter/CallFrame.h: (JSC::ExecState::returnPC): * interpreter/Interpreter.cpp: (JSC::Interpreter::unwindCallFrame): (JSC::Interpreter::retrieveLastCaller): Moved bytecode access into a CodeBlock helper function. Changed CallFrame to accurately represent how the returnPC is stored in JIT vs Interpreter. git-svn-id: http://svn.webkit.org/repository/webkit/trunk@59791 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
darin@chromium.org authored
Reviewed by Nate Chapin. [chromium] Provide a way to catch exceptions thrown while interacting with a NPObject via WebBindings methods. https://bugs.webkit.org/show_bug.cgi?id=39378 This change also includes a small bit of cleanup in V8NPObject and friends. I moved code into the WebCore namespace where appropriate. In _NPN_Invoke, I also moved the call to _NPN_Evaluate outside of the context scope. I did this to avoid having nested ExceptionCatcher objects, which is not strictly necessary, but it seemed cleaner. _NPN_Evaluate already takes care of creating a context scope. * bindings/v8/NPV8Object.cpp: (WebCore::v8ObjectToNPObject): (WebCore::npCreateV8ScriptObject): (_NPN_Invoke): (_NPN_InvokeDefault): (_NPN_Evaluate): (_NPN_EvaluateHelper): (_NPN_GetProperty): (_NPN_SetProperty): (_NPN_RemoveProperty): (_NPN_HasProperty): (_NPN_HasMethod): (_NPN_SetException): (_NPN_Enumerate): (_NPN_Construct): * bindings/v8/NPV8Object.h: * bindings/v8/V8NPObject.cpp: * bindings/v8/V8NPObject.h: * bindings/v8/V8NPUtils.cpp: (WebCore::convertV8ObjectToNPVariant): (WebCore::pushExceptionHandler): (WebCore::popExceptionHandler): (WebCore::ExceptionCatcher::~ExceptionCatcher): * bindings/v8/V8NPUtils.h: * bindings/v8/npruntime.cpp: git-svn-id: http://svn.webkit.org/repository/webkit/trunk@59790 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
dpranke@chromium.org authored
Unreviewed, build fix. * DumpRenderTree/chromium/NotificationPresenter.cpp: (NotificationPresenter::show): git-svn-id: http://svn.webkit.org/repository/webkit/trunk@59789 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
yaar@chromium.org authored
Unreviewed, rolling out r59769. http://trac.webkit.org/changeset/59769 https://bugs.webkit.org/show_bug.cgi?id=37815 Broke GTK again * Android.jscbindings.mk: * CMakeLists.txt: * GNUmakefile.am: * WebCore.gypi: * WebCore.pro: * WebCore.vcproj/WebCore.vcproj: * WebCore.xcodeproj/project.pbxproj: * bindings/js/JSBindingsAllInOne.cpp: * bindings/js/JSCallbackData.cpp: (WebCore::JSCallbackData::invokeCallback): * bindings/js/JSEventListener.cpp: (WebCore::JSEventListener::handleEvent): * bindings/js/JSInjectedScriptHostCustom.cpp: (WebCore::InjectedScriptHost::createInjectedScript): * bindings/js/JSMainThreadExecState.cpp: Removed. * bindings/js/JSMainThreadExecState.h: Removed. * bindings/js/ScheduledAction.cpp: (WebCore::ScheduledAction::executeFunctionInContext): (WebCore::ScheduledAction::execute): * bindings/js/ScheduledAction.h: * bindings/js/ScriptController.cpp: (WebCore::ScriptController::evaluateInWorld): * bindings/js/ScriptController.h: * bindings/js/ScriptFunctionCall.cpp: (WebCore::ScriptFunctionCall::call): * bindings/objc/ObjCEventListener.mm: * bindings/objc/WebScriptObject.mm: (-[WebScriptObject callWebScriptMethod:withArguments:]): (-[WebScriptObject evaluateWebScript:]): * bindings/scripts/CodeGeneratorObjC.pm: * bindings/scripts/test/ObjC/DOMTestCallback.mm: (-[DOMTestCallback callbackWithClass1Param:]): (-[DOMTestCallback callbackWithClass2Param:strArg:]): (-[DOMTestCallback callbackWithNonBoolReturnType:]): (-[DOMTestCallback customCallback:class6Param:]): * bindings/scripts/test/ObjC/DOMTestInterface.mm: * bindings/scripts/test/ObjC/DOMTestObj.mm: (-[DOMTestObj readOnlyIntAttr]): (-[DOMTestObj readOnlyStringAttr]): (-[DOMTestObj readOnlyTestObjAttr]): (-[DOMTestObj intAttr]): (-[DOMTestObj setIntAttr:]): (-[DOMTestObj longLongAttr]): (-[DOMTestObj setLongLongAttr:]): (-[DOMTestObj unsignedLongLongAttr]): (-[DOMTestObj setUnsignedLongLongAttr:]): (-[DOMTestObj stringAttr]): (-[DOMTestObj setStringAttr:]): (-[DOMTestObj testObjAttr]): (-[DOMTestObj setTestObjAttr:]): (-[DOMTestObj attrWithException]): (-[DOMTestObj setAttrWithException:]): (-[DOMTestObj attrWithSetterException]): (-[DOMTestObj setAttrWithSetterException:]): (-[DOMTestObj attrWithGetterException]): (-[DOMTestObj setAttrWithGetterException:]): (-[DOMTestObj customAttr]): (-[DOMTestObj setCustomAttr:]): (-[DOMTestObj scriptStringAttr]): (-[DOMTestObj voidMethod]): (-[DOMTestObj voidMethodWithArgs:strArg:objArg:]): (-[DOMTestObj intMethod]): (-[DOMTestObj intMethodWithArgs:strArg:objArg:]): (-[DOMTestObj objMethod]): (-[DOMTestObj objMethodWithArgs:strArg:objArg:]): (-[DOMTestObj methodThatRequiresAllArgs:objArg:]): (-[DOMTestObj methodThatRequiresAllArgsAndThrows:objArg:]): (-[DOMTestObj serializedValue:]): (-[DOMTestObj methodWithException]): (-[DOMTestObj customMethod]): (-[DOMTestObj customMethodWithArgs:strArg:objArg:]): (-[DOMTestObj customArgsAndException:]): (-[DOMTestObj addEventListener:listener:useCapture:]): (-[DOMTestObj removeEventListener:listener:useCapture:]): (-[DOMTestObj withDynamicFrame]): (-[DOMTestObj withDynamicFrameAndArg:]): (-[DOMTestObj withDynamicFrameAndOptionalArg:optionalArg:]): (-[DOMTestObj withDynamicFrameAndUserGesture:]): (-[DOMTestObj withDynamicFrameAndUserGestureASAD:optionalArg:]): (-[DOMTestObj withScriptStateVoid]): (-[DOMTestObj withScriptStateObj]): (-[DOMTestObj withScriptStateVoidException]): (-[DOMTestObj withScriptStateObjException]): (-[DOMTestObj methodWithOptionalArg:]): (-[DOMTestObj methodWithNonOptionalArgAndOptionalArg:opt:]): (-[DOMTestObj methodWithNonOptionalArgAndTwoOptionalArgs:opt1:opt2:]): * bindings/v8/ScriptController.cpp: * bindings/v8/ScriptController.h: * html/HTMLFrameElementBase.cpp: (WebCore::HTMLFrameElementBase::isURLAllowed): 2010-05-19 Yaar Schnitman <yaar@chromium.org> Unreviewed, rolling out r59769. http://trac.webkit.org/changeset/59769 https://bugs.webkit.org/show_bug.cgi?id=37815 Broke GTK again * http/tests/security/xss-DENIED-iframe-src-alias-expected.txt: * http/tests/security/xss-DENIED-iframe-src-alias.html: git-svn-id: http://svn.webkit.org/repository/webkit/trunk@59788 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
dpranke@chromium.org authored
Try again to roll out r58765 * fast/notifications/notifications-replace-expected.txt: Removed. * fast/notifications/notifications-replace.html: Removed. * fast/notifications/notifications-rtl-expected.txt: Removed. * fast/notifications/notifications-rtl.html: Removed. 2010-05-19 Dirk Pranke <dpranke@chromium.org> Try again to roll out r58675. * notifications/Notification.h: * notifications/Notification.idl: 2010-05-19 Dirk Pranke <dpranke@chromium.org> Try again to roll out r58765. * public/WebNotification.h: * src/WebNotification.cpp: git-svn-id: http://svn.webkit.org/repository/webkit/trunk@59787 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
enrica@apple.com authored
https://bugs.webkit.org/show_bug.cgi?id=39143 <rdar://problem/8003662> Reviewed by Dave Hyatt. The goal of r59385 was to make sure that the layout of block after all its children had been removed produced the identical result as the one of a newly created empty block. In order to do so, we had to make sure that the m_inlineChildren flag was reset to true when the block had no children (as it is upon creation). I discovered that, by doing that for anonymous blocks it leads removeChild to conclude that the anonymous children can be removed, without considering that the anonymous block could be part of a continuation chain. For this reason, when RenderInline::destroy() tries to remove the continuations we are effectively deleting a renderer that had been deleted already. Test: fast/inline-block/anonymous-block-crash.html * rendering/RenderBlock.cpp: (WebCore::RenderBlock::layoutBlock): resetting the flag m_inlineChildren only for non anonymous blocks otherwise we incurr in a double deletion of the renderer that causes the crash. LayoutTests: REGRESSION (r59385) crash destroying inline renderers https://bugs.webkit.org/show_bug.cgi?id=39143 <rdar://problem/8003662> Reviewed by Dave Hyatt. * fast/inline-block/anonymous-block-crash-expected.txt: Added. * fast/inline-block/anonymous-block-crash.html: Added. git-svn-id: http://svn.webkit.org/repository/webkit/trunk@59786 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
dpranke@chromium.org authored
Unreviewed, rolling out r59782. http://trac.webkit.org/changeset/59782 https://bugs.webkit.org/show_bug.cgi?id=39379 broke DRT build (Requested by dpranke on #webkit). * fast/notifications/notifications-replace-expected.txt: Added. * fast/notifications/notifications-replace.html: Added. * fast/notifications/notifications-rtl-expected.txt: Added. * fast/notifications/notifications-rtl.html: Added. 2010-05-19 Sheriff Bot <webkit.review.bot@gmail.com> Unreviewed, rolling out r59782. http://trac.webkit.org/changeset/59782 https://bugs.webkit.org/show_bug.cgi?id=39379 broke DRT build (Requested by dpranke on #webkit). * notifications/Notification.h: (WebCore::Notification::dir): (WebCore::Notification::setDir): (WebCore::Notification::replaceId): (WebCore::Notification::setReplaceId): * notifications/Notification.idl: 2010-05-19 Sheriff Bot <webkit.review.bot@gmail.com> Unreviewed, rolling out r59782. http://trac.webkit.org/changeset/59782 https://bugs.webkit.org/show_bug.cgi?id=39379 broke DRT build (Requested by dpranke on #webkit). * public/WebNotification.h: * src/WebNotification.cpp: (WebKit::WebNotification::dir): (WebKit::WebNotification::replaceId): git-svn-id: http://svn.webkit.org/repository/webkit/trunk@59785 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
https://bugs.webkit.org/show_bug.cgi?id=21049hyatt@apple.com authored
https://bugs.webkit.org/show_bug.cgi?id=21049, opacity and position:relative fail in multi-column layouts. Reviewed by Oliver Hunt. Make layers split painting across columns just as normal flow content does. This is actually very challenging, since intermediate multicol layers can exist between a child that has to be split and its enclosing stacking context. In order to properly paginate layers, a bit is set on all pagination roots, i.e., layers that will get split and thus split any descendant layers that they are also responsible for painting. For a paginated root, we walk up the layer hierarchy and collect all intermediate multicol blocks between the child and the enclosing stacking context. We then recur from the outside in, applying clipping and translation as we break up the layer into strips. Composited layers remain unsplittable and have a hacked offset still in order to be placed in the right column. Painting and hit testing of columns has been simplified in all of the functions to use the x position of the column rect instead of trying to increment an x offset by adding in widths and column gaps. This makes those functions directionality-independent (and the LTR/RTL code paths are now the same). Fix repainting of columns as well to make sure rects are split across columns only after relative position and transforms have been applied. Added fast/multicol/layers-split-across-columns.html * rendering/RenderBlock.cpp: (WebCore::RenderBlock::paintColumnContents): (WebCore::RenderBlock::adjustRectForColumns): (WebCore::RenderBlock::adjustForColumns): * rendering/RenderBlock.h: * rendering/RenderBox.cpp: (WebCore::RenderBox::computeRectForRepaint): * rendering/RenderLayer.cpp: (WebCore::RenderLayer::RenderLayer): (WebCore::RenderLayer::updateLayerPositions): (WebCore::RenderLayer::updatePagination): (WebCore::RenderLayer::updateLayerPosition): (WebCore::RenderLayer::paintLayer): (WebCore::RenderLayer::paintList): (WebCore::RenderLayer::paintPaginatedChildLayer): (WebCore::RenderLayer::paintChildLayerIntoColumns): (WebCore::RenderLayer::hitTestLayer): (WebCore::RenderLayer::hitTestList): (WebCore::RenderLayer::hitTestPaginatedChildLayer): (WebCore::RenderLayer::hitTestChildLayerColumns): * rendering/RenderLayer.h: (WebCore::RenderLayer::): (WebCore::RenderLayer::isPaginated): git-svn-id: http://svn.webkit.org/repository/webkit/trunk@59784 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
eric@webkit.org authored
Unreviewed, rolling out r59240. http://trac.webkit.org/changeset/59240 https://bugs.webkit.org/show_bug.cgi?id=39377 "Might cause crashes in GTK+ bots" (Requested by xan_ on #webkit). * WebCoreSupport/ContextMenuClientGtk.cpp: (WebKit::inputMethodsMenuItem): * WebCoreSupport/EditorClientGtk.cpp: (WebKit::EditorClient::setInputMethodState): (WebKit::EditorClient::respondToChangedSelection): (WebKit::EditorClient::handleInputMethodKeydown): (WebKit::EditorClient::EditorClient): (WebKit::EditorClient::~EditorClient): * WebCoreSupport/FrameLoaderClientGtk.cpp: (WebKit::postCommitFrameViewSetup): * webkit/webkitprivate.h: * webkit/webkitwebview.cpp: (destroy_menu_cb): (webkit_web_view_forward_context_menu_event): (webkit_web_view_key_release_event): (webkit_web_view_button_release_event): (webkit_web_view_focus_in_event): (webkit_web_view_focus_out_event): (webkit_web_view_realize): (webkit_web_view_set_scroll_adjustments): (webkit_web_view_dispose): (webkit_web_view_finalize): (webViewGetDPI): (webkit_web_view_screen_changed): (webkit_web_view_query_tooltip): (webkit_web_view_get_im_context): (webkit_web_view_update_settings): (webkit_web_view_init): (webkit_web_view_set_settings): (webkit_web_view_get_settings): (webkit_web_view_get_inspector): (webkit_web_view_set_window_features): (webkit_web_view_get_window_features): (webkit_web_view_get_back_forward_list): (webkit_web_view_zoom_in): (webkit_web_view_zoom_out): (webkit_web_view_get_encoding): (webkit_web_view_get_custom_encoding): (webkit_web_view_add_resource): (webkit_web_view_get_resource): (webkit_web_view_get_main_resource): (webkit_web_view_clear_resources): (webkit_web_view_get_subresources): (webkit_web_view_set_tooltip_text): (webkit_web_view_get_icon_uri): git-svn-id: http://svn.webkit.org/repository/webkit/trunk@59783 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
dpranke@chromium.org authored
Reviewed by Dimitri Glazkov. Attempt to revert r58765 to see if it was causing a performance regression. https://bugs.webkit.org/show_bug.cgi?id=39328 * fast/notifications/notifications-replace-expected.txt: Removed. * fast/notifications/notifications-replace.html: Removed. * fast/notifications/notifications-rtl-expected.txt: Removed. * fast/notifications/notifications-rtl.html: Removed. 2010-05-18 Dirk Pranke <dpranke@chromium.org> Reviewed by Dimitri Glazkov. Attempt to revert r58765 to see if it was causing a performance regression. https://bugs.webkit.org/show_bug.cgi?id=39328 * notifications/Notification.h: * notifications/Notification.idl: 2010-05-18 Dirk Pranke <dpranke@chromium.org> Reviewed by Dimitri Glazkov. Attempt to revert r58765 to see if it was causing a performance regression. https://bugs.webkit.org/show_bug.cgi?id=39328 * public/WebNotification.h: * src/WebNotification.cpp: git-svn-id: http://svn.webkit.org/repository/webkit/trunk@59782 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
ggaren@apple.com authored
Reviewed by Sam Weinig. Don't build the Interpreter into JIT builds. https://bugs.webkit.org/show_bug.cgi?id=39373 SunSpider says no change. * interpreter/Interpreter.cpp: (JSC::Interpreter::privateExecute): * interpreter/Interpreter.h: * wtf/Platform.h: git-svn-id: http://svn.webkit.org/repository/webkit/trunk@59781 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
kevino@webkit.org authored
[wx] Ensure m_nsFont is initialized properly, and tweak fallback font handling to handle more cases. https://bugs.webkit.org/show_bug.cgi?id=39365 git-svn-id: http://svn.webkit.org/repository/webkit/trunk@59780 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
eric@webkit.org authored
Reviewed by Eric Seidel. Fixes Windows Qt Release post r59772. https://bugs.webkit.org/show_bug.cgi?id=39369 * platform/GeolocationService.cpp: git-svn-id: http://svn.webkit.org/repository/webkit/trunk@59779 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
eric@webkit.org authored
Reviewed by Adam Barth. Add support for handling basic <script> tags in the HTML5 Parser https://bugs.webkit.org/show_bug.cgi?id=39350 WebKit currently executes scripts from HTMLTokenizer in one giagantic hack. HTML 5 requires that we execute scripts from the tree-builders/parser. It will take me a while to re-factor enough of HTMLTokenizer to be able to move the script execution logic without breaking things. In the interest of allowing Adam to continue improving the HTML 5 lexer I've added this very basic (and very incomplete) <script> support to the HTML 5 parser code path so the he can run the HTML5 parser test suite. <script> support is tested by most of the layout tests. * dom/ScriptElement.cpp: (WebCore::useHTML5Parser): (WebCore::ScriptElement::finishParsingChildren): git-svn-id: http://svn.webkit.org/repository/webkit/trunk@59778 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
ggaren@apple.com authored
Reviewed by Gavin Barraclough. Also renamed getBytecodeOffset to bytecodeOffset, to match the WebKit naming style. * bytecode/CodeBlock.h: (JSC::CallReturnOffsetToBytecodeOffset::CallReturnOffsetToBytecodeOffset): (JSC::getCallReturnOffset): (JSC::CodeBlock::bytecodeOffset): (JSC::CodeBlock::callReturnIndexVector): * interpreter/Interpreter.cpp: (JSC::bytecodeOffsetForPC): * jit/JIT.cpp: (JSC::JIT::JIT): (JSC::JIT::privateCompileMainPass): (JSC::JIT::privateCompileLinkPass): (JSC::JIT::privateCompileSlowCases): (JSC::JIT::privateCompile): * jit/JIT.h: (JSC::CallRecord::CallRecord): (JSC::JumpTable::JumpTable): (JSC::SwitchRecord::SwitchRecord): * jit/JITCall.cpp: (JSC::JIT::compileOpCallVarargsSlowCase): (JSC::JIT::compileOpCall): * jit/JITInlineMethods.h: (JSC::JIT::emitNakedCall): (JSC::JIT::addSlowCase): (JSC::JIT::addJump): (JSC::JIT::emitJumpSlowToHot): (JSC::JIT::isLabeled): (JSC::JIT::map): (JSC::JIT::unmap): (JSC::JIT::isMapped): (JSC::JIT::getMappedPayload): (JSC::JIT::getMappedTag): (JSC::JIT::emitGetVirtualRegister): * jit/JITOpcodes.cpp: (JSC::JIT::emit_op_switch_imm): (JSC::JIT::emit_op_switch_char): (JSC::JIT::emit_op_switch_string): (JSC::JIT::emit_op_new_error): * jit/JITOpcodes32_64.cpp: (JSC::JIT::emit_op_mov): (JSC::JIT::emit_op_get_global_var): (JSC::JIT::emit_op_put_global_var): (JSC::JIT::emit_op_get_scoped_var): (JSC::JIT::emit_op_put_scoped_var): (JSC::JIT::emit_op_to_primitive): (JSC::JIT::emit_op_resolve_global): (JSC::JIT::emit_op_to_jsnumber): (JSC::JIT::emit_op_catch): (JSC::JIT::emit_op_switch_imm): (JSC::JIT::emit_op_switch_char): (JSC::JIT::emit_op_switch_string): (JSC::JIT::emit_op_new_error): (JSC::JIT::emit_op_convert_this): * jit/JITPropertyAccess.cpp: (JSC::JIT::emit_op_method_check): (JSC::JIT::emitSlow_op_method_check): * jit/JITPropertyAccess32_64.cpp: (JSC::JIT::emit_op_method_check): (JSC::JIT::emitSlow_op_method_check): (JSC::JIT::emit_op_get_by_val): (JSC::JIT::emit_op_get_by_id): (JSC::JIT::emit_op_get_by_pname): * jit/JITStubCall.h: (JSC::JITStubCall::call): * jit/JITStubs.cpp: (JSC::DEFINE_STUB_FUNCTION): git-svn-id: http://svn.webkit.org/repository/webkit/trunk@59777 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
andersca@apple.com authored
Reviewed by Sam Weinig. Move member variables from NamedMappedAttrMap to its base class NamedNodeMap https://bugs.webkit.org/show_bug.cgi?id=39367 <rdar://problem/8003304> This lets us get rid of the vtable pointer in NamedNodeMap which saves 8 bytes, and also allows us to fit the m_mappedAttributeCount unsigned int in the RefCounted padding (in 64-bit). The net result is that we shrink the NamedMappedAttrMap size by 16 bytes, while keeping the size of NamedNodeMap the same. * dom/Element.cpp: (WebCore::Element::createAttributeMap): * dom/Element.h: * dom/NamedMappedAttrMap.cpp: * dom/NamedMappedAttrMap.h: (WebCore::NamedMappedAttrMap::NamedMappedAttrMap): * dom/NamedNodeMap.cpp: (WebCore::NamedNodeMap::clearAttributes): * dom/NamedNodeMap.h: (WebCore::NamedNodeMap::NamedNodeMap): * dom/Node.cpp: (WebCore::Node::dumpStatistics): * dom/StyledElement.cpp: * dom/StyledElement.h: git-svn-id: http://svn.webkit.org/repository/webkit/trunk@59776 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
weinig@apple.com authored
Reviewed by Anders Carlsson. * dom/Attribute.cpp: (WebCore::Attribute::unbindAttr): git-svn-id: http://svn.webkit.org/repository/webkit/trunk@59775 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
jianli@chromium.org authored
https://bugs.webkit.org/show_bug.cgi?id=39332 Reviewed by Darin Fisher. * public/WebKitClient.h: * src/ChromiumBridge.cpp: (WebCore::ChromiumBridge::fileExists): (WebCore::ChromiumBridge::deleteFile): (WebCore::ChromiumBridge::deleteEmptyDirectory): (WebCore::ChromiumBridge::getFileSize): (WebCore::ChromiumBridge::getFileModificationTime): (WebCore::ChromiumBridge::directoryName): (WebCore::ChromiumBridge::pathByAppendingComponent): (WebCore::ChromiumBridge::makeAllDirectories): (WebCore::ChromiumBridge::getAbsolutePath): (WebCore::ChromiumBridge::isDirectory): (WebCore::ChromiumBridge::filePathToURL): git-svn-id: http://svn.webkit.org/repository/webkit/trunk@59774 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
weinig@apple.com authored
Rubber-stamped by Anders Carlsson. Files elided for brevity. git-svn-id: http://svn.webkit.org/repository/webkit/trunk@59773 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
eric@webkit.org authored
Reviewed by Steve Block. [chromium] Adds supports for layout tests using GeolocationServiceMock. https://bugs.webkit.org/show_bug.cgi?id=39081 Allows injection of GeolocationServiceMock factory. Tests: existing fast/dom/Geolocation/* * platform/GeolocationService.cpp: (WebCore::GeolocationService::useMock): (WebCore::GeolocationService::useMockFactory): * platform/GeolocationService.h: * platform/chromium/GeolocationServiceChromium.cpp: (WebCore::GeolocationServiceChromium::GeolocationServiceChromium): 2010-05-19 Marcus Bulach <bulach@chromium.org> Reviewed by Steve Block. [chromium] Adds supports for layout tests using GeolocationServiceMock. https://bugs.webkit.org/show_bug.cgi?id=39081 Allows injection of GeolocationServiceMock factory. Tests: existing fast/dom/Geolocation/* * WebKit.gyp: * public/WebGeolocationServiceMock.h: Added. * src/WebGeolocationServiceMock.cpp: Added. (WebCore::GeolocationServiceChromiumMock::create): (WebCore::GeolocationServiceChromiumMock::GeolocationServiceChromiumMock): (WebCore::GeolocationServiceChromiumMock::startUpdating): (WebCore::GeolocationServiceChromiumMock::stopUpdating): (WebCore::GeolocationServiceChromiumMock::lastPosition): (WebCore::GeolocationServiceChromiumMock::lastError): (WebCore::GeolocationServiceChromiumMock::geolocationServicePositionChanged): (WebCore::GeolocationServiceChromiumMock::geolocationServiceErrorOccurred): (WebKit::WebGeolocationServiceMock::setMockGeolocationPosition): (WebKit::WebGeolocationServiceMock::setMockGeolocationError): git-svn-id: http://svn.webkit.org/repository/webkit/trunk@59772 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
eric@webkit.org authored
Reviewed by Adam Barth. user.py throws exception when readline module is missing https://bugs.webkit.org/show_bug.cgi?id=39239 * Scripts/webkitpy/common/system/user.py: - The error handling path requires the "sys" module, so added an import sys at the top of the file. git-svn-id: http://svn.webkit.org/repository/webkit/trunk@59771 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
mrobinson@webkit.org authored
Not reviewed. Add baselines for new multi-column tests. * platform/gtk/fast/multicol/column-count-with-rules-expected.txt: Added. * platform/gtk/fast/multicol/layers-in-multicol-expected.txt: Added. * platform/gtk/fast/multicol/nested-columns-expected.txt: Added. git-svn-id: http://svn.webkit.org/repository/webkit/trunk@59770 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
yaar@chromium.org authored
Reviewed by Adam Barth. Moving frame.src checks out of the bindings https://bugs.webkit.org/show_bug.cgi?id=37815 Moved JavaScript frame.src checks out of bindings and into HTMLFrameElementBase. Added main thread state stack to JavaScriptCore so ExecState is available inside core DOM. Updated affected bindings (except for GObject, which will need to be updated to avoid origin failures inside native code). * Android.jscbindings.mk: * CMakeLists.txt: * GNUmakefile.am: * WebCore.gypi: * WebCore.pro: * WebCore.vcproj/WebCore.vcproj: * WebCore.xcodeproj/project.pbxproj: * bindings/js/JSBindingsAllInOne.cpp: * bindings/js/JSCallbackData.cpp: (WebCore::JSCallbackData::invokeCallback): * bindings/js/JSEventListener.cpp: (WebCore::JSEventListener::handleEvent): * bindings/js/JSInjectedScriptHostCustom.cpp: (WebCore::InjectedScriptHost::createInjectedScript): * bindings/js/JSMainThreadExecState.cpp: Added. * bindings/js/JSMainThreadExecState.h: Added. (WebCore::JSMainThreadExecState::currentState): (WebCore::JSMainThreadExecState::call): (WebCore::JSMainThreadExecState::evaluate): (WebCore::JSMainThreadExecState::JSMainThreadExecState): (WebCore::JSMainThreadExecState::~JSMainThreadExecState): (WebCore::JSMainThreadNullState::JSMainThreadNullState): * bindings/js/ScheduledAction.cpp: (WebCore::ScheduledAction::executeFunctionInContext): (WebCore::ScheduledAction::execute): * bindings/js/ScheduledAction.h: * bindings/js/ScriptController.cpp: (WebCore::ScriptController::evaluateInWorld): (WebCore::ScriptController::canAccessFromCurrentOrigin): * bindings/js/ScriptController.h: * bindings/js/ScriptFunctionCall.cpp: (WebCore::ScriptFunctionCall::call): * bindings/objc/ObjCEventListener.mm: * bindings/objc/WebScriptObject.mm: (-[WebScriptObject callWebScriptMethod:withArguments:]): (-[WebScriptObject evaluateWebScript:]): * bindings/scripts/CodeGeneratorObjC.pm: * bindings/scripts/test/ObjC/DOMTestCallback.mm: (-[DOMTestCallback callbackWithClass1Param:]): (-[DOMTestCallback callbackWithClass2Param:strArg:]): (-[DOMTestCallback callbackWithNonBoolReturnType:]): (-[DOMTestCallback customCallback:class6Param:]): * bindings/scripts/test/ObjC/DOMTestInterface.mm: * bindings/scripts/test/ObjC/DOMTestObj.mm: (-[DOMTestObj readOnlyIntAttr]): (-[DOMTestObj readOnlyStringAttr]): (-[DOMTestObj readOnlyTestObjAttr]): (-[DOMTestObj intAttr]): (-[DOMTestObj setIntAttr:]): (-[DOMTestObj longLongAttr]): (-[DOMTestObj setLongLongAttr:]): (-[DOMTestObj unsignedLongLongAttr]): (-[DOMTestObj setUnsignedLongLongAttr:]): (-[DOMTestObj stringAttr]): (-[DOMTestObj setStringAttr:]): (-[DOMTestObj testObjAttr]): (-[DOMTestObj setTestObjAttr:]): (-[DOMTestObj attrWithException]): (-[DOMTestObj setAttrWithException:]): (-[DOMTestObj attrWithSetterException]): (-[DOMTestObj setAttrWithSetterException:]): (-[DOMTestObj attrWithGetterException]): (-[DOMTestObj setAttrWithGetterException:]): (-[DOMTestObj customAttr]): (-[DOMTestObj setCustomAttr:]): (-[DOMTestObj scriptStringAttr]): (-[DOMTestObj voidMethod]): (-[DOMTestObj voidMethodWithArgs:strArg:objArg:]): (-[DOMTestObj intMethod]): (-[DOMTestObj intMethodWithArgs:strArg:objArg:]): (-[DOMTestObj objMethod]): (-[DOMTestObj objMethodWithArgs:strArg:objArg:]): (-[DOMTestObj methodThatRequiresAllArgs:objArg:]): (-[DOMTestObj methodThatRequiresAllArgsAndThrows:objArg:]): (-[DOMTestObj serializedValue:]): (-[DOMTestObj methodWithException]): (-[DOMTestObj customMethod]): (-[DOMTestObj customMethodWithArgs:strArg:objArg:]): (-[DOMTestObj customArgsAndException:]): (-[DOMTestObj addEventListener:listener:useCapture:]): (-[DOMTestObj removeEventListener:listener:useCapture:]): (-[DOMTestObj withDynamicFrame]): (-[DOMTestObj withDynamicFrameAndArg:]): (-[DOMTestObj withDynamicFrameAndOptionalArg:optionalArg:]): (-[DOMTestObj withDynamicFrameAndUserGesture:]): (-[DOMTestObj withDynamicFrameAndUserGestureASAD:optionalArg:]): (-[DOMTestObj withScriptStateVoid]): (-[DOMTestObj withScriptStateObj]): (-[DOMTestObj withScriptStateVoidException]): (-[DOMTestObj withScriptStateObjException]): (-[DOMTestObj methodWithOptionalArg:]): (-[DOMTestObj methodWithNonOptionalArgAndOptionalArg:opt:]): (-[DOMTestObj methodWithNonOptionalArgAndTwoOptionalArgs:opt1:opt2:]): * bindings/v8/ScriptController.cpp: (WebCore::ScriptController::canAccessFromCurrentOrigin): * bindings/v8/ScriptController.h: * html/HTMLFrameElementBase.cpp: (WebCore::HTMLFrameElementBase::isURLAllowed): 2010-05-19 Justin Schuh <jschuh@chromium.org> Reviewed by Adam Barth. Moving frame.src checks out of the bindings https://bugs.webkit.org/show_bug.cgi?id=37815 * http/tests/security/xss-DENIED-iframe-src-alias-expected.txt: * http/tests/security/xss-DENIED-iframe-src-alias.html: git-svn-id: http://svn.webkit.org/repository/webkit/trunk@59769 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
chang.shu@nokia.com authored
Reviewed by Darin Adler. CanvasRenderingContext2D's property getters that return colors should serialize them in accordance with the HTML5 spec (4.8.11.1.4) Setters should ignore invalid colors. Also, shadowColor should initially be transparent black (4.8.11.1.6) https://bugs.webkit.org/show_bug.cgi?id=38845 Refactored CanvasStyle to store an RGBA32 instead of RGBA components and/or the color string. Spec links: http://www.whatwg.org/specs/web-apps/current-work/#serialization-of-a-color http://www.whatwg.org/specs/web-apps/current-work/#dom-context-2d-shadowcolor * html/canvas/CanvasRenderingContext2D.cpp: (WebCore::CanvasRenderingContext2D::State::State): (WebCore::CanvasRenderingContext2D::shadowColor): (WebCore::CanvasRenderingContext2D::setShadowColor): (WebCore::CanvasRenderingContext2D::setShadow): (WebCore::CanvasRenderingContext2D::clearShadow): (WebCore::CanvasRenderingContext2D::applyShadow): * html/canvas/CanvasRenderingContext2D.h: * html/canvas/CanvasStyle.cpp: (WebCore::CanvasStyle::CanvasStyle): (WebCore::CanvasStyle::create): (WebCore::CanvasStyle::applyStrokeColor): (WebCore::CanvasStyle::applyFillColor): * html/canvas/CanvasStyle.h: (WebCore::CanvasStyle::create): (WebCore::CanvasStyle::color): (WebCore::CanvasStyle::): (WebCore::CanvasStyle::CMYKAValues::CMYKAValues): * platform/graphics/Color.cpp: (WebCore::Color::serialized): * platform/graphics/Color.h: 2010-05-19 Andreas Kling <andreas.kling@nokia.com> Reviewed by Darin Adler. Added a test to verify proper color serialization in CanvasRenderingContext2D's getters. https://bugs.webkit.org/show_bug.cgi?id=38845 Spec link: http://www.whatwg.org/specs/web-apps/current-work/#serialization-of-a-color * fast/canvas/canvas-color-serialization-expected.txt: Added. * fast/canvas/canvas-color-serialization.html: Added. * fast/canvas/canvas-set-properties-with-non-invertible-ctm-expected.txt: Updated baseline. * fast/canvas/script-tests/canvas-color-serialization.js: Added. (trySettingStrokeStyle): (trySettingFillStyle): (trySettingShadowColor): (trySettingColor): (trySettingStrokeColorWithSetter): (trySettingFillColorWithSetter): (trySettingShadowWithSetter): (trySettingColorWithSetter): (trySettingFillColorRGBA): (trySettingStrokeColorRGBA): (trySettingShadowRGBA): (trySettingRGBA): (trySettingFillColorCMYKA): (trySettingStrokeColorCMYKA): (trySettingShadowCMYKA): (trySettingCMYKA): (trySettingFillColorWithOverrideAlpha): (trySettingStrokeColorWithOverrideAlpha): (trySettingShadowWithOverrideAlpha): (trySettingColorWithOverrideAlpha): (trySettingFillColorGrayLevel): (trySettingStrokeColorGrayLevel): (trySettingShadowGrayLevel): (trySettingGrayLevel): (trySettingFillColorGrayLevelWithAlpha): (trySettingStrokeColorGrayLevelWithAlpha): (trySettingShadowGrayLevelWithAlpha): (trySettingGrayLevelWithAlpha): (tryClearShadowAfterSettingColor): (checkDefaultValue): * fast/canvas/script-tests/canvas-set-properties-with-non-invertible-ctm.js: * fast/dom/canvasContext2d-element-attribute-js-null-expected.txt: Updated baseline. * fast/dom/canvasContext2d-element-attribute-js-null.html: git-svn-id: http://svn.webkit.org/repository/webkit/trunk@59768 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
chang.shu@nokia.com authored
Reviewed by Simon Hausmann. [Qt] REGRESSION: CoolClock isn't rendered properly https://bugs.webkit.org/show_bug.cgi?id=38526 CanvasRenderingContext2D's arc() should connect to the previous point with a straight line (HTML5 spec 4.8.11.1.8), but if the path is empty to begin with, we don't want a line back to (0,0) This also fixes the rendering artifact discussed in bug 36226. Spec link: http://www.whatwg.org/specs/web-apps/current-work/#dom-context-2d-arc Test: fast/canvas/canvas-arc-connecting-line.html * platform/graphics/qt/PathQt.cpp: (WebCore::Path::addArc): 2010-05-19 Andreas Kling <andreas.kling@nokia.com> Reviewed by Simon Hausmann. Add test to verify that CanvasRenderingContext2D's arc() connects arcs by a straight line (unless it's the first element in the path.) https://bugs.webkit.org/show_bug.cgi?id=38526 * fast/canvas/canvas-arc-connecting-line-expected.txt: Added. * fast/canvas/canvas-arc-connecting-line.html: Added. * fast/canvas/script-tests/canvas-arc-connecting-line.js: Added. (deg2rad): git-svn-id: http://svn.webkit.org/repository/webkit/trunk@59767 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
abecsi@webkit.org authored
of the subpattern's non-greedy match at the place of the subpattern's start index in the output array instead of the place of the subpattern's end index. Add layout test for checking of non-greedy matching of subpattern in regular expressions. https://bugs.webkit.org/show_bug.cgi?id=39289 Patch by Peter Varga <pvarga@inf.u-szeged.hu> on 2010-05-19 Reviewed by Darin Adler. JavaScriptCore: * yarr/RegexInterpreter.cpp: (JSC::Yarr::Interpreter::backtrackParenthesesOnceEnd): LayoutTests: * fast/js/regexp-non-greedy-parentheses-expected.txt: Added. * fast/js/regexp-non-greedy-parentheses.html: Added. * fast/js/script-tests/regexp-non-greedy-parentheses.js: Added. git-svn-id: http://svn.webkit.org/repository/webkit/trunk@59766 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
antti.j.koivisto@nokia.com authored
https://bugs.webkit.org/show_bug.cgi?id=39359 Rubber-stamped by Kenneth Rohde Christiansen. Put the back logic that was lost in refactoring. * WebCoreSupport/ChromeClientQt.cpp: (WebCore::ChromeClientQt::visibleRectForTiledBackingStore): * WebCoreSupport/PageClientQt.cpp: (WebCore::PageClientQGraphicsWidget::graphicsItemVisibleRect): * WebCoreSupport/PageClientQt.h: (WebCore::PageClientQWidget::viewResizesToContentsEnabled): (WebCore::PageClientQGraphicsWidget::viewResizesToContentsEnabled): git-svn-id: http://svn.webkit.org/repository/webkit/trunk@59765 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-