1. 16 Aug, 2011 40 commits
    • commit-queue@webkit.org's avatar
      Unmatrix algorithm implementation is wrong · 47875751
      commit-queue@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=66080
      
      Patch by Mihnea Ovidenie <mihnea@adobe.com> on 2011-08-16
      Reviewed by Dean Jackson.
      
      Source/WebCore:
      
      Current version of the algorithm negates only the scaleX while
      it should negate also scaleY and scaleZ when appropriate.
      
      Test: animations/animation-matrix-negative-scale-unmatrix.html
      
      * platform/graphics/transforms/TransformationMatrix.cpp:
      (WebCore::decompose):
      
      LayoutTests:
      
      * animations/animation-matrix-negative-scale-unmatrix-expected.txt: Added.
      * animations/animation-matrix-negative-scale-unmatrix.html: Added.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@93150 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      47875751
    • joepeck@webkit.org's avatar
      Unreviewed Chromium Windows build fix after r93140. · d3eed0f4
      joepeck@webkit.org authored
      * platform/graphics/FontCache.h:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@93149 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      d3eed0f4
    • eric.carlson@apple.com's avatar
      Make video-controls-no-scripting.html results platform independent. · 1a42260e
      eric.carlson@apple.com authored
      * media/video-controls-no-scripting-expected.txt:
      * media/video-controls-no-scripting.html:
      * platform/chromium/media/video-controls-no-scripting-expected.txt: Removed.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@93148 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      1a42260e
    • joepeck@webkit.org's avatar
      Unreviewed Windows and Chromium Windows build fix after r93140. · 40b939c0
      joepeck@webkit.org authored
      * platform/graphics/FontCache.h:
      * platform/graphics/chromium/FontCacheChromiumWin.cpp:
      (WebCore::FontCache::fontDataFromDescriptionAndLogFont):
      (WebCore::getLastResortFallbackFontProc):
      (WebCore::FontCache::getLastResortFallbackFont):
      * platform/graphics/win/FontCacheWin.cpp:
      (WebCore::FontCache::fontDataFromDescriptionAndLogFont):
      (WebCore::FontCache::getLastResortFallbackFont):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@93147 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      40b939c0
    • aroben@apple.com's avatar
      Make placeholder text remain visible until a character is typed on Windows · ed44d1b1
      aroben@apple.com authored
      Fixes <http://webkit.org/b/66319> Placeholder text in text fields disappears when the field
      is focused on Windows, which doesn't match Lion or Windows native text fields
      
      Covered by existing tests (which are currently failing on the bots until this patch lands).
      
      Reviewed by Dave Hyatt.
      
      * rendering/RenderThemeSafari.h:
      (WebCore::RenderThemeSafari::shouldShowPlaceholderWhenFocused):
      * rendering/RenderThemeWin.h:
      (WebCore::RenderThemeWin::shouldShowPlaceholderWhenFocused):
      Added overrides to return true.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@93146 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      ed44d1b1
    • dino@apple.com's avatar
      Adding Ted "hober" O'Connor as a non-committing contributor. · a3671976
      dino@apple.com authored
      * Scripts/webkitpy/common/config/committers.py:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@93145 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      a3671976
    • hyatt@apple.com's avatar
      https://bugs.webkit.org/show_bug.cgi?id=66254 · aa8cc6c0
      hyatt@apple.com authored
      Source/WebCore: 
      
      Make region invalidation and repainting work properly. We do this by making RenderFlowThreads into
      repaint containers and then issuing new repaints in the regions that contain the invalidated flow thread
      content.
      
      Reviewed by Simon Fraser.
      
      Added new tests in fast/repaint.
      
      * rendering/RenderFlowThread.cpp:
      (WebCore::RenderFlowThread::repaintRectangleInRegions):
      * rendering/RenderFlowThread.h:
      * rendering/RenderObject.cpp:
      (WebCore::RenderObject::enclosingRenderFlowThread):
      (WebCore::RenderObject::containerForRepaint):
      (WebCore::RenderObject::repaintUsingContainer):
      * rendering/RenderObject.h:
      * rendering/RenderView.cpp:
      (WebCore::RenderView::RenderView):
      (WebCore::RenderView::renderFlowThreadWithName):
      * rendering/RenderView.h:
      (WebCore::RenderView::hasRenderFlowThreads):
      
      LayoutTests: 
      
      Make regions repaint properly. Added new repaint tests.
      
      Reviewed by Simon Fraser.
      
      * fast/repaint/japanese-rl-selection-repaint-in-regions.html: Added.
      * fast/repaint/line-flow-with-floats-in-regions.html: Added.
      * fast/repaint/overflow-flipped-writing-mode-block-in-regions.html: Added.
      * platform/mac/fast/repaint/japanese-rl-selection-repaint-in-regions-expected.png: Added.
      * platform/mac/fast/repaint/japanese-rl-selection-repaint-in-regions-expected.txt: Added.
      * platform/mac/fast/repaint/line-flow-with-floats-in-regions-expected.png: Added.
      * platform/mac/fast/repaint/line-flow-with-floats-in-regions-expected.txt: Added.
      * platform/mac/fast/repaint/overflow-flipped-writing-mode-block-in-regions-expected.png: Added.
      * platform/mac/fast/repaint/overflow-flipped-writing-mode-block-in-regions-expected.txt: Added.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@93144 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      aa8cc6c0
    • joepeck@webkit.org's avatar
      Abandoned Memory: Temporary CSS Fonts May Never Be Purged · 116d5d9e
      joepeck@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=66153
      
      Reviewed by Dan Bernstein.
      
      While a remote CSS font face is loading we fallback to a
      temporary font. We don't want to retain the fallback font
      because noone takes ownership of the temporary font. This
      patch adds a way to get an uncached fallback font, which
      plumbs the ShouldRetain enum through the different platform
      implementations of getLastResortFallbackFont.
      
      No new tests, no functional change.
      
      * css/CSSFontFaceSource.cpp:
      (WebCore::CSSFontFaceSource::getFontData):
      * platform/graphics/FontCache.cpp:
      (WebCore::FontCache::getNonRetainedLastResortFallbackFont):
      * platform/graphics/FontCache.h:
      * platform/graphics/chromium/FontCacheChromiumWin.cpp:
      (WebCore::fontDataFromDescriptionAndLogFont):
      (WebCore::GetLastResortFallbackFontProcData::GetLastResortFallbackFontProcData):
      (WebCore::getLastResortFallbackFontProc):
      (WebCore::FontCache::getLastResortFallbackFont):
      * platform/graphics/chromium/FontCacheLinux.cpp:
      (WebCore::FontCache::getLastResortFallbackFont):
      * platform/graphics/freetype/FontCacheFreeType.cpp:
      (WebCore::FontCache::getLastResortFallbackFont):
      * platform/graphics/haiku/FontCacheHaiku.cpp:
      (WebCore::FontCache::getLastResortFallbackFont):
      * platform/graphics/mac/FontCacheMac.mm:
      (WebCore::FontCache::getLastResortFallbackFont):
      * platform/graphics/pango/FontCachePango.cpp:
      (WebCore::FontCache::getLastResortFallbackFont):
      * platform/graphics/qt/FontCacheQt.cpp:
      (WebCore::FontCache::getLastResortFallbackFont):
      * platform/graphics/win/FontCacheWin.cpp:
      (WebCore::fontDataFromDescriptionAndLogFont):
      (WebCore::FontCache::getLastResortFallbackFont):
      * platform/graphics/wince/FontCacheWinCE.cpp:
      * platform/graphics/wx/FontCacheWx.cpp:
      (WebCore::FontCache::getLastResortFallbackFont):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@93140 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      116d5d9e
    • aroben@apple.com's avatar
      Add Windows expected results for some <canvas> tests · bf436097
      aroben@apple.com authored
      <canvas> doesn't use accelerated compositing on Windows like it does on Lion.
      
      * platform/win/compositing/layer-creation/spanOverlapsCanvas-expected.txt: Copied from platform/mac-snowleopard/compositing/layer-creation/spanOverlapsCanvas-expected.txt.
      * platform/win/fast/repaint/canvas-putImageData-expected.txt: Copied from platform/mac-snowleopard/fast/repaint/canvas-putImageData-expected.txt.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@93139 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      bf436097
    • dbates@webkit.org's avatar
      2011-08-16 Daniel Bates <dbates@webkit.org> · 02b7d87f
      dbates@webkit.org authored
              Add myself to the list of individual members in the WebKit Security Group.
      
              Rubber-stamped by Eric Seidel.
      
              * security/security-group-members.html:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@93138 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      02b7d87f
    • commit-queue@webkit.org's avatar
      Chromium Mac: Rubber banding gutter drawing · f6a1fd2b
      commit-queue@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=66226
      
      Make ScrollView::paintOverhangAreas() use the ScrollbarTheme::nativeTheme() to
      draw the overhang areas.
      Move default implementation to ScrollbarThemeComposite::paintOverhangAreas().
      Add a different implementation for Chromium Mac.
      
      Patch by Alexei Svitkine <asvitkine@chromium.org> on 2011-08-16
      Reviewed by Dimitri Glazkov.
      
      No new tests since this is just refactoring code and adding a Chromium-specific path for overhang drawing.
      
      * platform/ScrollView.cpp:
      (WebCore::ScrollView::wheelEvent):
      * platform/ScrollbarTheme.h:
      (WebCore::ScrollbarTheme::paintOverhangAreas):
      * platform/ScrollbarThemeComposite.cpp:
      (WebCore::ScrollbarThemeComposite::paintOverhangAreas):
      * platform/ScrollbarThemeComposite.h:
      * platform/chromium/ScrollbarThemeChromiumMac.h:
      * platform/chromium/ScrollbarThemeChromiumMac.mm:
      (WebCore::ScrollbarThemeChromiumMac::ScrollbarThemeChromiumMac):
      (WebCore::scrollbarStateToThemeState):
      (WebCore::ScrollbarThemeChromiumMac::paintTickmarks):
      (WebCore::ScrollbarThemeChromiumMac::paintOverhangAreas):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@93136 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      f6a1fd2b
    • rniwa@webkit.org's avatar
      Programmatically set selection should not have direction on Mac · eccfd3f0
      rniwa@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=60529
      
      Patch by Wyatt Carss <wcarss@chromium.org> on 2011-08-12
      Reviewed by Ryosuke Niwa.
      
      Source/WebCore: 
      
      Modified default value of VisibleSelection->m_isDirectional from 'true'
      to 'false' by adding a defaulted argument to several VisibleSelection 
      constructors to make programmatic selection be directionless by default 
      on Mac. Also modified several calls to VisibleSelection's constructors
      to correctly preserve directionality.
              
      Near the end of FrameSelection::modify (presently FrameSelection.cpp:869)
      a call to setExtent triggers an editing delegate that uses the
      FrameSelection. The direction here should have been preserved from before,
      but setIsDirectional was not called until after FrameSelection.cpp:869. It
      has been moved up to make things behave.
      
      * WebCore.exp.in:
      * editing/ApplyBlockElementCommand.cpp:
      (WebCore::ApplyBlockElementCommand::doApply):
      (WebCore::ApplyBlockElementCommand::formatSelection):
      * editing/ApplyStyleCommand.cpp:
      (WebCore::ApplyStyleCommand::updateStartEnd):
      * editing/BreakBlockquoteCommand.cpp:
      (WebCore::BreakBlockquoteCommand::doApply):
      * editing/CompositeEditCommand.cpp:
      (WebCore::CompositeEditCommand::moveParagraphWithClones):
      (WebCore::CompositeEditCommand::moveParagraphs):
      (WebCore::CompositeEditCommand::breakOutOfEmptyListItem):
      (WebCore::CompositeEditCommand::breakOutOfEmptyMailBlockquotedParagraph):
      * editing/CreateLinkCommand.cpp:
      (WebCore::CreateLinkCommand::doApply):
      * editing/DeleteSelectionCommand.cpp:
      (WebCore::DeleteSelectionCommand::setStartingSelectionOnSmartDelete):
      (WebCore::DeleteSelectionCommand::doApply):
      * editing/Editor.cpp:
      (WebCore::Editor::selectionForCommand):
      * editing/FrameSelection.cpp:
      (WebCore::shouldAlwaysUseDirectionalSelection):
      (WebCore::FrameSelection::FrameSelection):
      (WebCore::FrameSelection::moveTo):
      (WebCore::FrameSelection::setNonDirectionalSelectionIfNeeded):
      (WebCore::FrameSelection::modify):
      (WebCore::FrameSelection::setBase):
      (WebCore::FrameSelection::setExtent):
      * editing/FrameSelection.h:
      * editing/InsertLineBreakCommand.cpp:
      (WebCore::InsertLineBreakCommand::doApply):
      * editing/InsertListCommand.cpp:
      (WebCore::InsertListCommand::doApply):
      * editing/InsertParagraphSeparatorCommand.cpp:
      (WebCore::InsertParagraphSeparatorCommand::doApply):
      * editing/InsertTextCommand.cpp:
      (WebCore::InsertTextCommand::performTrivialReplace):
      (WebCore::InsertTextCommand::doApply):
      * editing/MoveSelectionCommand.cpp:
      (WebCore::MoveSelectionCommand::doApply):
      * editing/ReplaceSelectionCommand.cpp:
      (WebCore::ReplaceSelectionCommand::completeHTMLReplacement):
      * editing/TypingCommand.cpp:
      (WebCore::TypingCommand::makeEditableRootEmpty):
      (WebCore::TypingCommand::deleteKeyPressed):
      (WebCore::TypingCommand::forwardDeleteKeyPressed):
      * editing/VisibleSelection.cpp:
      (WebCore::VisibleSelection::VisibleSelection):
      * editing/VisibleSelection.h:
      * page/EventHandler.cpp:
      (WebCore::EventHandler::updateSelectionForMouseDownDispatchingSelectStart):
      (WebCore::EventHandler::updateSelectionForMouseDrag):
      
      LayoutTests: 
      
      Added editing/selection/programmatic-selection-on-mac-is-directionless
      to test selection direction in programmatically set selections on
      windows, unix, and mac, in plain text, editable divs, text-input
      fields, and textareas. Modified text baselines for many editing tests,
      which had a delegate change as a result of the cpp patch.
      
      * editing/deleting/delete-ligature-003-expected.txt:
      * editing/deleting/paragraph-in-preserveNewline-expected.txt:
      * editing/deleting/whitespace-pre-1-expected.txt:
      * editing/selection/after-line-break-expected.txt:
      * platform/mac/editing/deleting/delete-all-text-in-text-field-assertion-expected.txt:
      * platform/mac/editing/deleting/delete-and-undo-expected.txt:
      * platform/mac/editing/deleting/delete-at-paragraph-boundaries-008-expected.txt:
      * platform/mac/editing/deleting/delete-br-002-expected.txt:
      * platform/mac/editing/deleting/delete-br-004-expected.txt:
      * platform/mac/editing/deleting/delete-br-005-expected.txt:
      * platform/mac/editing/deleting/delete-br-006-expected.txt:
      * platform/mac/editing/deleting/delete-br-009-expected.txt:
      * platform/mac/editing/deleting/delete-br-010-expected.txt:
      * platform/mac/editing/deleting/delete-br-011-expected.txt:
      * platform/mac/editing/deleting/delete-ws-fixup-003-expected.txt:
      * platform/mac/editing/deleting/delete-ws-fixup-004-expected.txt:
      * platform/mac/editing/deleting/smart-delete-002-expected.txt:
      * platform/mac/editing/inserting/insert-3800346-fix-expected.txt:
      * platform/mac/editing/inserting/insert-at-end-01-expected.txt:
      * platform/mac/editing/inserting/insert-at-end-02-expected.txt:
      * platform/mac/editing/inserting/insert-div-010-expected.txt:
      * platform/mac/editing/inserting/insert-div-013-expected.txt:
      * platform/mac/editing/inserting/insert-div-015-expected.txt:
      * platform/mac/editing/inserting/insert-div-019-expected.txt:
      * platform/mac/editing/inserting/insert-paragraph-03-expected.txt:
      * platform/mac/editing/pasteboard/3976872-expected.txt:
      * platform/mac/editing/pasteboard/4076267-2-expected.txt:
      * platform/mac/editing/pasteboard/4076267-expected.txt:
      * platform/mac/editing/pasteboard/drag-selected-image-to-contenteditable-expected.txt:
      * platform/mac/editing/pasteboard/emacs-ctrl-a-k-y-expected.txt:
      * platform/mac/editing/pasteboard/emacs-ctrl-k-y-001-expected.txt:
      * platform/mac/editing/pasteboard/paste-text-014-expected.txt:
      * platform/mac/editing/pasteboard/paste-text-015-expected.txt:
      * platform/mac/editing/pasteboard/smart-paste-008-expected.txt:
      * platform/mac/editing/selection/4932260-1-expected.txt:
      * platform/mac/editing/selection/anchor-focus2-expected.txt:
      * platform/mac/editing/selection/anchor-focus3-expected.txt:
      * platform/mac/editing/selection/expanding-selections-expected.txt:
      * platform/mac/editing/selection/expanding-selections2-expected.txt:
      * platform/mac/editing/selection/fake-drag-expected.txt:
      * platform/mac/editing/selection/move-by-word-001-expected.txt:
      * platform/mac/editing/selection/transformed-selection-rects-expected.txt:
      * platform/mac/editing/selection/triple-click-in-pre-expected.txt:
      * platform/mac/editing/style/create-block-for-style-008-expected.txt:
      * platform/mac/editing/undo/4063751-expected.txt:
      * platform/mac/editing/undo/undo-forward-delete-boundary-expected.txt:
      * platform/mac/editing/undo/undo-forward-delete-expected.txt:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@93134 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      eccfd3f0
    • jpfau@apple.com's avatar
      New XML parser: Add document fragment parser · b5b87ec2
      jpfau@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=66317
      
      Reviewed by Adam Barth.
      
      * dom/DocumentFragment.cpp:
      (WebCore::DocumentFragment::parseXML):
      * xml/parser/NewXMLDocumentParser.cpp:
      (WebCore::NewXMLDocumentParser::NewXMLDocumentParser):
      (WebCore::NewXMLDocumentParser::parseDocumentFragment):
      * xml/parser/NewXMLDocumentParser.h:
      (WebCore::NewXMLDocumentParser::create):
      * xml/parser/XMLTokenizer.h:
      * xml/parser/XMLTreeBuilder.cpp:
      (WebCore::XMLTreeBuilder::XMLTreeBuilder):
      (WebCore::XMLTreeBuilder::pushCurrentNode):
      * xml/parser/XMLTreeBuilder.h:
      (WebCore::XMLTreeBuilder::create):
      (WebCore::XMLTreeBuilder::NodeStackItem::node):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@93133 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      b5b87ec2
    • tony@chromium.org's avatar
      [chromium] Mark svg/wicd/test-rightsizing-a.xhtml as flakey. · 2bfedee9
      tony@chromium.org authored
      * platform/chromium/test_expectations.txt:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@93132 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      2bfedee9
    • senorblanco@chromium.org's avatar
      GraphicsContext3D should allow its hostWindow to be NULL · f52181ab
      senorblanco@chromium.org authored
      https://bugs.webkit.org/show_bug.cgi?id=66305
      
      Allow the hostWindow param (and m_webViewImpl) to be NULL.  This
      makes it much easier to enable GPU acceleration at a lower level
      in WebKit's platform/graphics layer, without needing access to the
      Page* or HostWindow*.  Also bump the chromium DEPS to chrome r96940,
      which includes a similar change for the in-process GraphicsContext3D
      implementations.
      
      Reviewed by James Robinson.
      
      * DEPS:
      * src/GraphicsContext3DChromium.cpp:
      (WebCore::GraphicsContext3DInternal::initialize):
      (WebCore::GraphicsContext3DInternal::platformTexture):
      (WebCore::GraphicsContext3DInternal::paintsIntoCanvasBuffer):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@93131 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      f52181ab
    • jpfau@apple.com's avatar
      New XML parser: Replace assertions regarding character data in the prolog with proper checks · d83ca59c
      jpfau@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=66269
      
      Reviewed by Adam Barth.
      
      This patch checks for character data in the prolog (which is illegal in XML) and discards it, instead of failing an assertion.
      
      * xml/parser/XMLTreeBuilder.cpp:
      (WebCore::XMLTreeBuilder::processProcessingInstruction):
      (WebCore::XMLTreeBuilder::processXMLDeclaration):
      (WebCore::XMLTreeBuilder::processDOCTYPE):
      (WebCore::XMLTreeBuilder::enterText):
      (WebCore::XMLTreeBuilder::failOnText):
      * xml/parser/XMLTreeBuilder.h:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@93130 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      d83ca59c
    • tony@chromium.org's avatar
      [chromium] Mark fast/css/last-of-type-pseudo-class.html as flaky in · 75704c79
      tony@chromium.org authored
      debug (not just snowleopard).
      
      * platform/chromium/test_expectations.txt:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@93129 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      75704c79
    • aroben@apple.com's avatar
      Add Windows expected results for resource-har-conversion.html · 1df9cdd5
      aroben@apple.com authored
      While Windows and Lion both agree on the MIME type of the cached .js files, Windows has some
      extra fields in the request objects.
      
      * platform/win/http/tests/inspector/resource-har-conversion-expected.txt: Added.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@93128 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      1df9cdd5
    • apavlov@chromium.org's avatar
      Web Inspector: word wrap long edits · 9bb266df
      apavlov@chromium.org authored
      https://bugs.webkit.org/show_bug.cgi?id=65512
      
      Reviewed by Pavel Feldman.
      
      * inspector/front-end/inspector.css:
      (.styles-section .properties li.child-editing):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@93127 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      9bb266df
    • mnaganov@chromium.org's avatar
      829efb38
    • pfeldman@chromium.org's avatar
      Web Inspector: convert DOM breakpoint types to strings. · 0a9bc1ca
      pfeldman@chromium.org authored
      https://bugs.webkit.org/show_bug.cgi?id=66304
      
      Reviewed by Yury Semikhatsky.
      
      * inspector/Inspector.json:
      * inspector/InspectorDOMDebuggerAgent.cpp:
      (WebCore::domTypeForName):
      (WebCore::InspectorDOMDebuggerAgent::setDOMBreakpoint):
      (WebCore::InspectorDOMDebuggerAgent::removeDOMBreakpoint):
      * inspector/InspectorDOMDebuggerAgent.h:
      * inspector/front-end/DOMBreakpointsSidebarPane.js:
      (WebInspector.DOMBreakpointsSidebarPane):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@93125 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      0a9bc1ca
    • tony@chromium.org's avatar
      Copy the results of http/tests/inspector/resource-har-conversion.html · 5cd2054f
      tony@chromium.org authored
      to the chromium platform dir.  The mac result (r93112) was getting
      picked up by the chromium port.
      
      * platform/chromium/http/tests/inspector/resource-har-conversion-expected.txt: Added.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@93124 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      5cd2054f
    • tony@chromium.org's avatar
      Move media/video-controls-no-scripting-iframe.html into the resources · 1764da05
      tony@chromium.org authored
      subdir since it's not a standalone test.
      
      Also add chromium baseline (the top of the video control is in a
      different place).
      
      * media/resources/video-controls-no-scripting-iframe.html: Renamed from LayoutTests/media/video-controls-no-scripting-iframe.html.
      * media/video-controls-no-scripting.html:
      * platform/chromium/media/video-controls-no-scripting-expected.txt: Added.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@93123 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      1764da05
    • pfeldman@chromium.org's avatar
      Web Inspector: force pseudo element state when checking it in the styles sidebar. · efb43866
      pfeldman@chromium.org authored
      https://bugs.webkit.org/show_bug.cgi?id=66292
      
      This reverts http://trac.webkit.org/changeset/89132 and introduces InspectorInstrumentation
      calls from the CSSStyleSelector for pseudo state processing. These calls are very fast:
      they are guarded with the inline checks for the front-end count.
      
      Reviewed by David Hyatt.
      
      * css/CSSStyleSelector.cpp:
      (WebCore::CSSStyleSelector::initForStyleResolve):
      (WebCore::CSSStyleSelector::styleRulesForElement):
      (WebCore::CSSStyleSelector::pseudoStyleRulesForElement):
      (WebCore::CSSStyleSelector::checkSelector):
      (WebCore::CSSStyleSelector::SelectorChecker::checkSelector):
      (WebCore::CSSStyleSelector::SelectorChecker::checkOneSelector):
      * css/CSSStyleSelector.h:
      * inspector/InspectorCSSAgent.cpp:
      (WebCore::computePseudoClassMask):
      (WebCore::InspectorCSSAgent::InspectorCSSAgent):
      (WebCore::InspectorCSSAgent::clearFrontend):
      (WebCore::InspectorCSSAgent::forcePseudoState):
      (WebCore::InspectorCSSAgent::getStylesForNode):
      (WebCore::InspectorCSSAgent::didRemoveDocument):
      (WebCore::InspectorCSSAgent::didRemoveDOMNode):
      (WebCore::InspectorCSSAgent::clearPseudoState):
      * inspector/InspectorCSSAgent.h:
      * inspector/InspectorController.cpp:
      (WebCore::InspectorController::disconnectFrontend):
      * inspector/InspectorInstrumentation.cpp:
      (WebCore::InspectorInstrumentation::forcePseudoStateImpl):
      * inspector/InspectorInstrumentation.h:
      (WebCore::InspectorInstrumentation::forcePseudoState):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@93122 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      efb43866
    • tony@chromium.org's avatar
      Unreviewed, rolling out r93114. · 8fbad4ee
      tony@chromium.org authored
      http://trac.webkit.org/changeset/93114
      https://bugs.webkit.org/show_bug.cgi?id=66226
      
      broke the chromium mac compile
      
      * platform/ScrollView.cpp:
      (WebCore::ScrollView::wheelEvent):
      * platform/ScrollbarTheme.h:
      * platform/ScrollbarThemeComposite.cpp:
      * platform/ScrollbarThemeComposite.h:
      * platform/chromium/ScrollbarThemeChromiumMac.h:
      * platform/chromium/ScrollbarThemeChromiumMac.mm:
      (WebCore::ScrollbarThemeChromiumMac::ScrollbarThemeChromiumMac):
      (WebCore::scrollbarStateToThemeState):
      (WebCore::ScrollbarThemeChromiumMac::paintTickmarks):
      * platform/mac/ScrollbarThemeMac.h:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@93120 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      8fbad4ee
    • aroben@apple.com's avatar
      Update Windows results for a fast/text test for Safari 5.1's AAS · 96d679a9
      aroben@apple.com authored
      The results are now more like Mac's. Dan Bernstein says this is probably a progression.
      
      * platform/win/fast/text/justify-ideograph-leading-expansion-expected.txt:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@93119 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      96d679a9
    • tony@chromium.org's avatar
      [chromium] Mark media/video-source-error.html as flaky in Debug. · 9089ae7b
      tony@chromium.org authored
      * platform/chromium/test_expectations.txt:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@93117 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      9089ae7b
    • aroben@apple.com's avatar
      Update Windows results after r92890 · 2c2b2517
      aroben@apple.com authored
      * platform/win/fast/dom/Window/window-property-descriptors-expected.txt:
      * platform/win/fast/js/global-constructors-expected.txt:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@93116 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      2c2b2517
    • aroben@apple.com's avatar
      Remove Windows-specific hyphenation test results now that hyphenation works on Windows · c492d5f5
      aroben@apple.com authored
      * platform/win/fast/text/hyphenate-first-word-expected.txt: Removed.
      * platform/win/fast/text/hyphenate-limit-before-after-expected.txt: Removed.
      * platform/win/fast/text/hyphenate-locale-expected.txt: Removed.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@93115 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      c492d5f5
    • commit-queue@webkit.org's avatar
      Chromium Mac: Rubber banding gutter drawing · 24f095bd
      commit-queue@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=66226
      
      Make ScrollView::paintOverhangAreas() use the ScrollbarTheme::nativeTheme() to
      draw the overhang areas.
      Move default implementation to ScrollbarThemeComposite::paintOverhangAreas().
      Add a different implementation for Chromium Mac.
      
      Patch by Alexei Svitkine <asvitkine@chromium.org> on 2011-08-16
      Reviewed by Dimitri Glazkov.
      
      No new tests since this is just refactoring code and adding a Chromium-specific path for overhang drawing.
      
      * platform/ScrollView.cpp:
      (WebCore::ScrollView::wheelEvent):
      * platform/ScrollbarTheme.h:
      (WebCore::ScrollbarTheme::paintOverhangAreas):
      * platform/ScrollbarThemeComposite.cpp:
      (WebCore::ScrollbarThemeComposite::paintOverhangAreas):
      * platform/ScrollbarThemeComposite.h:
      * platform/chromium/ScrollbarThemeChromiumMac.h:
      * platform/chromium/ScrollbarThemeChromiumMac.mm:
      (WebCore::ScrollbarThemeChromiumMac::ScrollbarThemeChromiumMac):
      (WebCore::scrollbarStateToThemeState):
      (WebCore::ScrollbarThemeChromiumMac::paintTickmarks):
      (WebCore::ScrollbarThemeChromiumMac::paintOverhangAreas):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@93114 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      24f095bd
    • tony@chromium.org's avatar
      Copy the results of http/tests/xmlhttprequest/web-apps/01[23].html · 73a77380
      tony@chromium.org authored
      to the chromium platform dir.  The mac failing results (r93105) were
      getting picked up by the chromium port.
      
      * platform/chromium/http/tests/xmlhttprequest/web-apps/012-expected.txt: Added.
      * platform/chromium/http/tests/xmlhttprequest/web-apps/013-expected.txt: Added.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@93113 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      73a77380
    • aroben@apple.com's avatar
      Add Lion/Windows expected results for an Inspector test · bb794a9f
      aroben@apple.com authored
      The only difference from the cross-platform results is that the .js resources are now given
      a MIME type of "text/plain".
      
      This test reloads the page before dumping it in HAR format. In Lion (and Safari 5.1 on
      Windows), CFNetwork no longer uses the file extension as a fallback when determining the
      MIME type for 304 cached responses. This matches Chrome. See <rdar://problem/9313303>.
      
      * platform/mac-snowleopard/http/tests/inspector/resource-har-conversion-expected.txt: Copied from http/tests/inspector/resource-har-conversion-expected.txt.
      * platform/mac/http/tests/inspector/resource-har-conversion-expected.txt: Added.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@93112 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      bb794a9f
    • aroben@apple.com's avatar
      Teach TestFailures how to interpret unfinished test runs · 60d3ef43
      aroben@apple.com authored
      Fixes <http://webkit.org/b/66309> TestFailures thinks all tests passed in
      http://build.webkit.org/builders/Lion%20Intel%20Debug%20(Tests)/builds/136
      
      Reviewed by David Kilzer.
      
      * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Builder.js:
      (Builder.prototype.getNumberOfFailingTests): Look for "isFinished" in the layout-test step
      rather than "isStarted" so that we don't count builds for which the test run never finished.
      Bumped the cache version to evict old, buggy cached data.
      
      * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Builder_unittests.js:
      Added a test for the above, and made a somewhat synthetic test more realistic by including
      more of the actual JSON data from build.webkit.org.
      
      * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/LayoutTestResultsLoader.js:
      (LayoutTestResultsLoader.prototype.start): Bumped the cache version to evict old, buggy
      cached data.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@93111 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      60d3ef43
    • macpherson@chromium.org's avatar
      Support cast between CSSPrimitiveValue and ETransformStyle3D and use in CSSStyleSelector. · 0c24a2e2
      macpherson@chromium.org authored
      https://bugs.webkit.org/show_bug.cgi?id=66273
      
      Reviewed by Simon Fraser.
      
      No new tests - no functionality changed - refactoring only.
      
      * css/CSSPrimitiveValueMappings.h:
      (WebCore::CSSPrimitiveValue::CSSPrimitiveValue):
      Define cast from CSSPrimitiveValue to ETransformStyle3D.
      (WebCore::CSSPrimitiveValue::operator ETransformStyle3D):
      Define cast from ETransformStyle3D to CSSPrimitiveValue.
      * css/CSSStyleSelector.cpp:
      (WebCore::CSSStyleSelector::applyProperty):
      Use appropriate macro to handle CSSPropertyWebkitTransformStyle.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@93110 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      0c24a2e2
    • macpherson@chromium.org's avatar
      Use appropriate macro to handle CSSPropertyWebkitContentOrder in CSSStyleSelector::applyProperty() · 94df2f04
      macpherson@chromium.org authored
      https://bugs.webkit.org/show_bug.cgi?id=66279
      
      Reviewed by Simon Fraser.
      
      No new tests - no functionality changed - simple refactoring only.
      
      * css/CSSStyleSelector.cpp:
      (WebCore::CSSStyleSelector::applyProperty):
      Use HANDLE_INHERIT_AND_INITIAL_AND_PRIMITIVE macro to handle CSSPropertyWebkitContentOrder.
      This works because PrimitiveValue now supports cast to int.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@93109 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      94df2f04
    • eric.carlson@apple.com's avatar
      2011-08-16 Eric Carlson <eric.carlson@apple.com> · dd166d77
      eric.carlson@apple.com authored
              [REGRESSION] Media controls should always be enabled when scripting is disabled
              https://bugs.webkit.org/show_bug.cgi?id=66303
      
              Reviewed by Dimitri Glazkov.
      
              Tests: media/video-controls-no-scripting-iframe.html
                     media/video-controls-no-scripting.html
      
              * html/HTMLMediaElement.cpp:
              (WebCore::HTMLMediaElement::attributeChanged): Move the controls enabling/disabling code
                  to configureMediaControls.
              (WebCore::HTMLMediaElement::prepareForLoad): Call configureMediaControls.
              (WebCore::HTMLMediaElement::configureMediaControls): New, move code duplicated in 
                  attributeChanged and preDispatchEventHandler here.
              (WebCore::HTMLMediaElement::preDispatchEventHandler): Move the controls enabling/disabling code
                  to configureMediaControls.
              * html/HTMLMediaElement.h:
      
      2011-08-16  Eric Carlson  <eric.carlson@apple.com>
      
              [REGRESSION] Media controls should always be enabled when scripting is disabled
              https://bugs.webkit.org/show_bug.cgi?id=66303
      
              Reviewed by Dimitri Glazkov.
      
              * media/video-controls-no-scripting-expected.txt: Added.
              * media/video-controls-no-scripting-iframe.html: Added.
              * media/video-controls-no-scripting.html: Added.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@93108 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      dd166d77
    • aroben@apple.com's avatar
      Make Apple's Windows port fall back to Lion results instead of SnowLeopard · c167f77b
      aroben@apple.com authored
      Apple's Windows port now uses Lion-era versions of CoreFoundation, ICU, etc., so in theory
      should match Lion's behavior.
      
      Fixes <http://webkit.org/b/66302> Apple's Windows port matches Lion for some test results,
      but doesn't use Lion results
      
      Reviewed by David Kilzer.
      
      * Scripts/old-run-webkit-tests:
      (expectedDirectoryForTest):
      * Scripts/webkitpy/layout_tests/port/win.py:
      (WinPort.baseline_search_path):
      * Scripts/webkitpy/layout_tests/port/win_unittest.py:
      (WinPortTest.test_baseline_search_path):
      Replaced mac-snowleopard with mac-lion.
      
      * Scripts/webkitpy/common/config/build.py:
      (_should_file_trigger_build): Added an entry for the LayoutTests/platform/mac-lion
      directory, which all Apple Mac platforms and Apple Win platforms could potentially use
      results from. Removed Apple Win from being affected by mac-snowleopard changes, since it
      will no longer look there for results.
      
      * Scripts/webkitpy/common/config/build_unittest.py:
      (ShouldBuildTest.test_should_build): Tests for the above changes.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@93107 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      c167f77b
    • aroben@apple.com's avatar
      Stop skipping the web-apps tests I just landed results for on Lion · 2a9a76cb
      aroben@apple.com authored
      * platform/mac-lion/Skipped:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@93106 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      2a9a76cb
    • aroben@apple.com's avatar
      Check in expected failure results for some web-apps tests on Lion and Windows · f26ff7cc
      aroben@apple.com authored
      Since these failures are likely due to bugs in non-WebKit components, they are tracked by
      <rdar://problem/9313271>.
      
      * platform/mac-snowleopard/http/tests/xmlhttprequest/web-apps/012-expected.txt: Copied from http/tests/xmlhttprequest/web-apps/012-expected.txt.
      * platform/mac-snowleopard/http/tests/xmlhttprequest/web-apps/013-expected.txt: Copied from http/tests/xmlhttprequest/web-apps/013-expected.txt.
      * platform/mac/http/tests/xmlhttprequest/web-apps/012-expected.txt: Added.
      * platform/mac/http/tests/xmlhttprequest/web-apps/013-expected.txt: Added.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@93105 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      f26ff7cc
    • aroben@apple.com's avatar
      Share Sputnik Unicode results between Lion and Windows · c208a35f
      aroben@apple.com authored
      Both Lion and Windows use ICU 4.6, so they have the same behavior on these tests.
      
      * platform/mac-lion/Skipped: Removed these tests.
      
      * platform/mac-snowleopard/sputnik/Unicode/Unicode_510/S7.6_A3.1-expected.txt: Copied from LayoutTests/sputnik/Unicode/Unicode_510/S7.6_A3.1-expected.txt.
      * platform/mac-snowleopard/sputnik/Unicode/Unicode_510/S7.6_A3.2-expected.txt: Copied from LayoutTests/sputnik/Unicode/Unicode_510/S7.6_A3.2-expected.txt.
      * platform/mac-snowleopard/sputnik/Unicode/Unicode_510/S7.6_A5.3_T1-expected.txt: Copied from LayoutTests/sputnik/Unicode/Unicode_510/S7.6_A5.3_T1-expected.txt.
      * platform/mac-snowleopard/sputnik/Unicode/Unicode_510/S7.6_A5.3_T2-expected.txt: Copied from LayoutTests/sputnik/Unicode/Unicode_510/S7.6_A5.3_T2-expected.txt.
      * platform/mac/sputnik/Unicode/Unicode_510/S7.6_A3.1-expected.txt: Renamed from LayoutTests/platform/win/sputnik/Unicode/Unicode_510/S7.6_A3.1-expected.txt.
      * platform/mac/sputnik/Unicode/Unicode_510/S7.6_A3.2-expected.txt: Renamed from LayoutTests/platform/win/sputnik/Unicode/Unicode_510/S7.6_A3.2-expected.txt.
      * platform/mac/sputnik/Unicode/Unicode_510/S7.6_A5.3_T1-expected.txt: Renamed from LayoutTests/platform/win/sputnik/Unicode/Unicode_510/S7.6_A5.3_T1-expected.txt.
      * platform/mac/sputnik/Unicode/Unicode_510/S7.6_A5.3_T2-expected.txt: Renamed from LayoutTests/platform/win/sputnik/Unicode/Unicode_510/S7.6_A5.3_T2-expected.txt.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@93104 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      c208a35f