1. 05 Nov, 2010 1 commit
    • andersca@apple.com's avatar
      Implement NP_RemoveProperty and NP_Enumerate · 46e6d372
      andersca@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=49046
      
      Reviewed by Oliver Hunt.
      
      WebKit2:
      
      * Shared/Plugins/NPObjectMessageReceiver.cpp:
      (WebKit::NPObjectMessageReceiver::removeProperty):
      Call the removeProperty NPClass function.
      
      (WebKit::NPObjectMessageReceiver::enumerate):
      Call the enumerate NPClass function.
      
      * Shared/Plugins/NPObjectMessageReceiver.messages.in:
      Add RemoveProperty and Enumerate messages.
      
      * Shared/Plugins/NPObjectProxy.cpp:
      (WebKit::NPObjectProxy::removeProperty):
      Send the RemoveProperty message.
      
      (WebKit::NPObjectProxy::enumerate):
      Send the Enumerate message.
      
      (WebKit::NPObjectProxy::NP_RemoveProperty):
      Call removeProperty.
      
      (WebKit::NPObjectProxy::NP_Enumerate):
      Call enumerate.
      
      LayoutTests:
      
      Remove now passing tests.
      
      * platform/mac-wk2/Skipped:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@71430 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      46e6d372
  2. 03 Nov, 2010 1 commit
    • andersca@apple.com's avatar
      Implement NP_SetProperty · f8ce5158
      andersca@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=48956
      
      Reviewed by Adam Roben.
      
      WebKit2:
      
      * Shared/Plugins/NPObjectMessageReceiver.cpp:
      (WebKit::NPObjectMessageReceiver::setProperty):
      Call the NPClass setProperty function.
      
      * Shared/Plugins/NPObjectMessageReceiver.messages.in:
      Add SetProperty message.
      
      * Shared/Plugins/NPObjectProxy.cpp:
      (WebKit::NPObjectProxy::setProperty):
      Send a SetProperty message.
      
      (WebKit::NPObjectProxy::NP_SetProperty):
      Call NPObjectProxy::setProperty.
      
      LayoutTests:
      
      Remove now passing test.
      
      * platform/mac-wk2/Skipped:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@71273 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      f8ce5158
  3. 02 Nov, 2010 3 commits
  4. 01 Nov, 2010 1 commit
  5. 28 Oct, 2010 2 commits
    • commit-queue@webkit.org's avatar
      2010-10-28 Jia Pu <jpu@apple.com> · 08abac67
      commit-queue@webkit.org authored
              Reviewed by Dan Bernstein.
      
              Editing a word with misspell or autocorrection underline should remove the underline when the editing changes the word.
              https://bugs.webkit.org/show_bug.cgi?id=48078
              <rdar://problem/8579155>
      
              * platform/mac-leopard/Skipped: New tests don't apply to this platform.
              * platform/mac-snowleopard/Skipped: Ditto.
              * platform/mac-tiger/Skipped: Ditto.
              * platform/mac-wk2/Skipped: Ditto.
              * platform/mac/editing/spelling/autocorrection-delete-expected.checksum: Updated expected test result.
              * platform/mac/editing/spelling/autocorrection-delete-expected.png: Ditto.
              * platform/mac/editing/spelling/editing-multiple-words-with-markers-expected.txt: Added.
              * platform/mac/editing/spelling/editing-multiple-words-with-markers.html: Added.
              * platform/mac/editing/spelling/editing-word-with-marker-1-expected.txt: Added.
              * platform/mac/editing/spelling/editing-word-with-marker-1.html: Added.
              * platform/mac/editing/spelling/editing-word-with-marker-2-expected.txt: Added.
              * platform/mac/editing/spelling/editing-word-with-marker-2.html: Added.
      2010-10-28  Jia Pu  <jpu@apple.com>
      
              Reviewed by Dan Bernstein.
      
              Editing a word with misspell or autocorrection underline should remove the underline when the editing changes the word.
              https://bugs.webkit.org/show_bug.cgi?id=48078
              <rdar://problem/8579155>
      
              Tests: platform/mac/editing/spelling/editing-multiple-words-with-markers.html
                     platform/mac/editing/spelling/editing-word-with-marker-1.html
                     platform/mac/editing/spelling/editing-word-with-marker-2.html
      
              This patch is part of on-going improvement of autocorrection feature on Mac OS X. When an editing
              occurs, if it affects words (by deleting/inserting characters, spliting word, merging words) that
              have Spelling and/or CorrectionIndicator markers, we want to remove the markers. If subsequntial
              spelling checking finds spelling error in newlly formed words, it will add the markers back in.
      
              * dom/DocumentMarker.h: Changed MarkerType to bit masks to make search multiple types easier.
      
              * dom/DocumentMarkerController.cpp: Refactored two removeMarkers() methods to support remove
                markers with specific type from a node.
              (WebCore::DocumentMarkerController::removeMarkers): Changed signature to remove marker with specific type.
              (WebCore::DocumentMarkerController::removeMarkersFromMarkerMapVectorPair): Refactoring.
              (WebCore::DocumentMarkerController::hasMarkers): Convenience method to search markers in range.
      
              * dom/DocumentMarkerController.h: Added new methods and matched new signature of removeMarkers().
      
              * editing/Editor.cpp:
              (WebCore::Editor::respondToChangedContents): Remove existing markers if the change formed new word.
              (WebCore::Editor::cut): Remove markers on words that will be modified by this editing.
              (WebCore::Editor::paste): Ditto.
              (WebCore::Editor::pasteAsPlainText): Ditto.
              (WebCore::Editor::removeSpellAndCorrectionMarkersFromWordsToBeEdited): Main logic for removing
                markers on words affected by editing.
      
              * editing/Editor.h: Added removeSpellAndCorrectionMarkersFromWordsToBeEdited().  Added
                REMOVE_MARKERS_UPON_EDITING and SUPPORT_AUTOCORRECTION_PANEL macro to improve readability.
      
              * editing/TypingCommand.cpp:
              (WebCore::TypingCommand::insertText): Remove markers on words that will be modified by this editing.
              (WebCore::TypingCommand::deleteKeyPressed): Ditto.
              (WebCore::TypingCommand::forwardDeleteKeyPressed): Ditto.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@70826 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      08abac67
    • aroben@apple.com's avatar
      Recategorize the failure of plugins/mouse-events.html for WebKit2 · 5ee06660
      aroben@apple.com authored
      This should have been done in r70685.
      
      * platform/mac-wk2/Skipped: Moved plugins/mouse-events.html into the
      "Need eventSender" category...
      * platform/win-wk2/Skipped: ...from here.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@70779 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      5ee06660
  6. 27 Oct, 2010 1 commit
    • darin@apple.com's avatar
      2010-10-26 Darin Adler <darin@apple.com> · 3c320e40
      darin@apple.com authored
              Reviewed by Sam Weinig.
      
              WebKitTestRunner needs to support layoutTestController.dumpBackForwardList
              https://bugs.webkit.org/show_bug.cgi?id=42322
              rdar://problem/8193631
      
              WebKitTestRunner needs to support layoutTestController.clearBackForwardList
              https://bugs.webkit.org/show_bug.cgi?id=42333
              rdar://problem/8193643
      
              * History/WebBackForwardList.mm:
              (core): Return BackForwardListImpl.
              (kit): Take BackForwardListImpl.
              (-[WebBackForwardList initWithBackForwardList:]): Use BackForwardListImpl.
              (-[WebBackForwardList dealloc]): Ditto.
              (-[WebBackForwardList finalize]): Ditto.
              (-[WebBackForwardList description]): Ditto.
              (-[WebBackForwardList setPageCacheSize:]): Ditto.
              (-[WebBackForwardList pageCacheSize]): Ditto.
              * History/WebBackForwardListInternal.h: Ditto.
              * WebView/WebFrameView.mm:
              (-[WebFrameView keyDown:]): Ditto.
              * WebView/WebView.mm:
              (-[WebView initWithCoder:]): Ditto.
              (-[WebView encodeWithCoder:]): Ditto.
              (-[WebView backForwardList]): Ditto.
              (-[WebView setMaintainsBackForwardList:]): Ditto.
      2010-10-26  Darin Adler  <darin@apple.com>
      
              Reviewed by Sam Weinig.
      
              WebKitTestRunner needs to support layoutTestController.dumpBackForwardList
              https://bugs.webkit.org/show_bug.cgi?id=42322
              rdar://problem/8193631
      
              WebKitTestRunner needs to support layoutTestController.clearBackForwardList
              https://bugs.webkit.org/show_bug.cgi?id=42333
              rdar://problem/8193643
      
              * WebCore.exp.in: Updated exports.
      
              * history/BackForwardList.h: Added comments about future refactoring.
              Moved functions that are not called inside WebCore into a separate
              section, to be removed later. Added an isActive function to replace the
              use of enabled() and entries().
      
              * history/BackForwardListImpl.h: Removed isBackForwardListImpl.
              Marked virtual function overrides virtual explicitly, except for the
              ones that will be non-virtual once we make the changes above.
              Added the isActive function.
      
              * history/PageCache.cpp:
              (WebCore::logCanCachePageDecision): Use isActive.
              (WebCore::PageCache::canCache): Ditto.
      
              * loader/FrameLoader.cpp:
              (WebCore::FrameLoader::checkDidPerformFirstNavigation): Check
              using currentItem, backItem, and forwardItem instead of
              using entries.
      
              * page/Settings.cpp:
              (WebCore::Settings::setUsesPageCache): Loop through the back/forward
              list entries using backListCount and forwardListCount instead of
              using entries.
      2010-10-26  Darin Adler  <darin@apple.com>
      
              Reviewed by Sam Weinig.
      
              WebKitTestRunner needs to support layoutTestController.dumpBackForwardList
              https://bugs.webkit.org/show_bug.cgi?id=42322
              rdar://problem/8193631
      
              WebKitTestRunner needs to support layoutTestController.clearBackForwardList
              https://bugs.webkit.org/show_bug.cgi?id=42333
              rdar://problem/8193643
      
              * platform/mac-wk2/Skipped: Resorted some test lists. Removed the section
              listing all the tests that were blocked by dumpBackForwardList.
      2010-10-26  Darin Adler  <darin@apple.com>
      
              Reviewed by Sam Weinig.
      
              WebKitTestRunner needs to support layoutTestController.dumpBackForwardList
              https://bugs.webkit.org/show_bug.cgi?id=42322
              rdar://problem/8193631
      
              WebKitTestRunner needs to support layoutTestController.clearBackForwardList
              https://bugs.webkit.org/show_bug.cgi?id=42333
              rdar://problem/8193643
      
              * WebKitTestRunner/Configurations/InjectedBundle.xcconfig:
              Renamed the product to WebKitTestRunnerInjectedBundle to avoid
              name conflicts in the build directory.
      
              * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl:
              Added dumpBackForwardList and clearBackForwardList.
      
              * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
              (WTR::InjectedBundle::InjectedBundle): Removed initialization of m_mainPage.
              (WTR::InjectedBundle::didCreatePage): Removed unneeded underscore.
              (WTR::InjectedBundle::willDestroyPage): Ditto.
              (WTR::InjectedBundle::didReceiveMessage): Ditto.
              (WTR::InjectedBundle::initialize): Ditto.
              (WTR::InjectedBundle::didCreatePage): Changed code to use m_pages
              instead of m_mainPage and m_otherPages.
              (WTR::InjectedBundle::willDestroyPage): Ditto.
              (WTR::InjectedBundle::page): Ditto.
              (WTR::InjectedBundle::beginTesting): Ditto.
              (WTR::InjectedBundle::done): Ditto.
              (WTR::InjectedBundle::closeOtherPages): Ditto.
              (WTR::InjectedBundle::dumpBackForwardListsForAllPages): Added.
      
              * WebKitTestRunner/InjectedBundle/InjectedBundle.h: Changed
              page function to longer be inline, and pageCount function
              to use m_pages. Added dumpBackForwardListsForAllPages, and
              removed some underscores. Replaced m_mainPage and m_otherPageas
              with m_pages.
      
              * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
              (WTR::adoptWK): Added.
              (WTR::hasPrefix): Added.
              (WTR::InjectedBundlePage::reset): Added code to set up
              m_previousTestBackForwardListItem.
              (WTR::InjectedBundlePage::dump): Added code to call
              dumpBackForwardListsForAllPages.
              (WTR::compareByTargetName): Added.
              (WTR::dumpBackForwardListItem): Added.
              (WTR::InjectedBundlePage::dumpBackForwardList): Added.
      
              * WebKitTestRunner/InjectedBundle/InjectedBundlePage.h: Added
              dumpBackForwardList and m_previousTestBackForwardListItem.
      
              * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
              (WTR::LayoutTestController::LayoutTestController): Initialize
              m_shouldDumpBackForwardListsForAllWindows to false.
              (WTR::LayoutTestController::clearBackForwardList): Added.
      
              * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
              Added dumpBackForwardList, clearBackForwardList,
              shouldDumpBackForwardListsForAllWindows, and
              m_shouldDumpBackForwardListsForAllWindows.
      
              * WebKitTestRunner/TestController.cpp:
              (WTR::TestController::initialize): Set up
              didReceiveSynchronousMessageFromInjectedBundle.
              (WTR::TestController::didReceiveSynchronousMessageFromInjectedBundle):
              Added.
              * WebKitTestRunner/TestController.h: Ditto.
      
              * WebKitTestRunner/TestInvocation.cpp:
              (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
              Added.
              * WebKitTestRunner/TestInvocation.h: Ditto.
      
              * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
              Renamed bundle to WebKitTestRunnerInjectedBundle (see above).
              * WebKitTestRunner/mac/TestControllerMac.mm:
              (WTR::TestController::initializeInjectedBundlePath): Ditto.
      2010-10-26  Darin Adler  <darin@apple.com>
      
              Reviewed by Sam Weinig.
      
              WebKitTestRunner needs to support layoutTestController.dumpBackForwardList
              https://bugs.webkit.org/show_bug.cgi?id=42322
              rdar://problem/8193631
      
              WebKitTestRunner needs to support layoutTestController.clearBackForwardList
              https://bugs.webkit.org/show_bug.cgi?id=42333
              rdar://problem/8193643
      
              * Shared/API/c/WKBase.h: Added WKBundleBackForwardListRef and
              WKBundleBackForwardListItemRef.
      
              * Shared/API/c/WKURL.cpp:
              (WKURLCopyString): Added.
              * Shared/API/c/WKURL.h: Added WKURLCopyString.
      
              * Shared/API/c/cf/WKURLCF.h: Fixed incorrect argument name.
      
              * Shared/APIObject.h: Added TypeBundleBackForwardList and
              TypeBundleBackForwardListItem.
      
              * Shared/ImmutableArray.h: Marked destructor virtual explicitly.
              * Shared/ImmutableDictionary.h: Ditto.
              * UIProcess/WebBackForwardListItem.h: Ditto.
              * UIProcess/WebContext.h: Ditto.
              * UIProcess/WebFrameProxy.h: Ditto.
              * UIProcess/WebNavigationData.h: Ditto.
              * UIProcess/WebPageNamespace.h: Ditto.
              * UIProcess/WebPreferences.h: Ditto.
              * WebProcess/InjectedBundle/InjectedBundleScriptWorld.h: Ditto.
              * WebProcess/InjectedBundle/DOM/InjectedBundleNodeHandle.h: Ditto.
              * WebProcess/InjectedBundle/DOM/InjectedBundleRangeHandle.h: Ditto.
      
              * UIProcess/WebBackForwardList.cpp: Removed unneeded backListWithLimit
              and forwardListWithLimit functions.
              (WebKit::WebBackForwardList::clear): Added.
              * UIProcess/WebBackForwardList.h: Marked destructor virtual explicitly.
              Added clear, removed backListWithLimit and forwardListWithLimit functions.
      
              * UIProcess/WebPageProxy.cpp: Removed unneeded backForwardBackItem,
              backForwardCurrentItem, and backForwardForwardItem functions.
              (WebKit::WebPageProxy::backForwardClear): Added.
              * UIProcess/WebPageProxy.h: Ditto.
              * UIProcess/WebPageProxy.messages.in: Ditto.
      
              * WebKit2.pro: Added new files.
              * WebKit2.xcodeproj/project.pbxproj: Ditto.
              * win/WebKit2.vcproj: Ditto.
      
              * WebProcess/InjectedBundle/API/c/WKBundleAPICast.h: Added
              WKBundleBackForwardListRef and WKBundleBackForwardListItemRef.
      
              * WebProcess/InjectedBundle/API/c/WKBundleBackForwardList.cpp:
              Started with a copy of from WebKit2/UIProcess/API/C/WKBackForwardList.cpp.
              * WebProcess/InjectedBundle/API/c/WKBundleBackForwardList.h:
              Started with a copy of WebKit2/UIProcess/API/C/WKBackForwardList.h.
      
              * WebProcess/InjectedBundle/API/c/WKBundleBackForwardListItem.cpp:
              Started with a copy of WebKit2/UIProcess/API/C/WKBackForwardListItem.cpp.
              * WebProcess/InjectedBundle/API/c/WKBundleBackForwardListItem.h:
              Started with a copy of WebKit2/UIProcess/API/C/WKBackForwardListItem.h.
      
              * WebProcess/InjectedBundle/API/c/WKBundlePage.cpp:
              (WKBundlePageGetBackForwardList): Added.
              * WebProcess/InjectedBundle/API/c/WKBundlePage.h: Ditto.
      
      
              * WebProcess/InjectedBundle/InjectedBundleBackForwardList.cpp:
              Started with a copy of WebKit2/UIProcess/WebBackForwardList.cpp.
              * WebProcess/InjectedBundle/InjectedBundleBackForwardList.h:
              Started with a copy of WebKit2/UIProcess/WebBackForwardList.h.
      
              * WebProcess/InjectedBundle/InjectedBundleBackForwardListItem.cpp:
              Started with a copy of WebKit2/UIProcess/WebBackForwardListItem.cpp.
              * WebProcess/InjectedBundle/InjectedBundleBackForwardListItem.h:
              Started with a copy of WebKit2/UIProcess/WebBackForwardListItem.h.
      
              * WebProcess/WebPage/WebBackForwardListProxy.cpp: Removed
              many unneeded functions.
              (WebKit::WebBackForwardListProxy::WebBackForwardListProxy):
              Removed unneeded initialization of m_closed.
              (WebKit::WebBackForwardListProxy::addItem): Added a check for
              the case of a capacity of 0.
              (WebKit::WebBackForwardListProxy::goToItem): Added a check for
              when the proxy outlives its page.
              (WebKit::WebBackForwardListProxy::itemAtIndex): Ditto.
              (WebKit::WebBackForwardListProxy::backListCount): Ditto.
              (WebKit::WebBackForwardListProxy::forwardListCount): Ditto.
              (WebKit::WebBackForwardListProxy::close): Removed unneeded code
              setting m_closed.
              (WebKit::WebBackForwardListProxy::isActive): Added.
              (WebKit::WebBackForwardListProxy::clear): Added.
      
              * WebProcess/WebPage/WebBackForwardListProxy.h: Added clear,
              isActive, and detach functions. Removed many other unneeded
              function and data members.
      
              * WebProcess/WebPage/WebPage.cpp:
              (WebKit::WebPage::~WebPage): Added call to detach on the
              back/forward list.
              (WebKit::WebPage::backForwardList): Added.
              * WebProcess/WebPage/WebPage.h: Added backForwardList function
              and m_backForwardList data member.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@70723 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      3c320e40
  7. 26 Oct, 2010 2 commits
    • simon.fraser@apple.com's avatar
      2010-10-26 Simon Fraser <simon.fraser@apple.com> · c738b67f
      simon.fraser@apple.com authored
              Reviewed by Sam Weinig.
      
              Support layoutTestController.layerTreeAsText in WebKitTestRunner
              https://bugs.webkit.org/show_bug.cgi?id=42145
      
              Implement layerTreeAsText() in WebKitTestRunner.
      
              * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl:
              * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
              (WTR::LayoutTestController::layerTreeAsText):
              * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
      
      2010-10-26  Simon Fraser  <simon.fraser@apple.com>
      
              Reviewed by Sam Weinig.
      
              Support layoutTestController.layerTreeAsText in WebKitTestRunner
              https://bugs.webkit.org/show_bug.cgi?id=42145
      
              Expose layerTreeAsText() as private API so that
              WebKitTestRunner can use it.
      
              * WebProcess/InjectedBundle/API/c/WKBundleFrame.cpp:
              (WKBundleFrameCopyLayerTreeAsText):
              * WebProcess/InjectedBundle/API/c/WKBundleFramePrivate.h:
              * WebProcess/WebPage/WebFrame.cpp:
              (WebKit::WebFrame::numberOfActiveAnimations):
              (WebKit::WebFrame::layerTreeAsText):
              (WebKit::WebFrame::pendingUnloadCount):
              * WebProcess/WebPage/WebFrame.h:
      
      2010-10-26  Simon Fraser  <simon.fraser@apple.com>
      
              Reviewed by Sam Weinig.
      
              Support layoutTestController.layerTreeAsText in WebKitTestRunner
              https://bugs.webkit.org/show_bug.cgi?id=42145
      
              Unskip tests that relied on layerTreeAsText(), but skip
              two compositing tests that continue to be flakey.
      
              * platform/mac-wk2/Skipped:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@70548 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      c738b67f
    • andersca@apple.com's avatar
      Enable the plug-in process on Mac · ef1e82ef
      andersca@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=48350
      
      Reviewed by Sam Weinig.
      
      WebKit2:
      
      * WebKit2Prefix.h:
      Flip the switch and enable the plug-in process on Mac.
      
      * WebProcess/Plugins/Netscape/mac/NetscapePluginMac.mm:
      (WebKit::NetscapePlugin::platformDestroy):
      Fix a bogus assert.
      
      LayoutTests:
      
      * platform/mac-wk2/Skipped:
      Update WebKit2 mac skipped list.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@70544 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      ef1e82ef
  8. 25 Oct, 2010 2 commits
  9. 23 Oct, 2010 1 commit
    • commit-queue@webkit.org's avatar
      2010-10-23 Sheriff Bot <webkit.review.bot@gmail.com> · 3cdd815a
      commit-queue@webkit.org authored
              Unreviewed, rolling out r70367.
              http://trac.webkit.org/changeset/70367
              https://bugs.webkit.org/show_bug.cgi?id=48176
      
              It made 8-10 tests crash on Qt bot (Requested by Ossy on
              #webkit).
      
              * fast/loader/decide-policy-for-mime-type-async-expected.txt: Removed.
              * fast/loader/decide-policy-for-mime-type-async.html: Removed.
              * platform/gtk/Skipped:
              * platform/mac-wk2/Skipped:
              * platform/qt-wk2/Skipped:
              * platform/qt/Skipped:
              * platform/win/Skipped:
      2010-10-23  Sheriff Bot  <webkit.review.bot@gmail.com>
      
              Unreviewed, rolling out r70367.
              http://trac.webkit.org/changeset/70367
              https://bugs.webkit.org/show_bug.cgi?id=48176
      
              It made 8-10 tests crash on Qt bot (Requested by Ossy on
              #webkit).
      
              * loader/MainResourceLoader.cpp:
              (WebCore::MainResourceLoader::MainResourceLoader):
              (WebCore::MainResourceLoader::continueAfterContentPolicy):
              (WebCore::MainResourceLoader::didReceiveResponse):
              (WebCore::MainResourceLoader::setDefersLoading):
              * loader/MainResourceLoader.h:
      2010-10-23  Sheriff Bot  <webkit.review.bot@gmail.com>
      
              Unreviewed, rolling out r70367.
              http://trac.webkit.org/changeset/70367
              https://bugs.webkit.org/show_bug.cgi?id=48176
      
              It made 8-10 tests crash on Qt bot (Requested by Ossy on
              #webkit).
      
              * DumpRenderTree/LayoutTestController.cpp:
              (setCustomPolicyDelegateCallback):
              * DumpRenderTree/LayoutTestController.h:
              * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
              (LayoutTestController::setCustomPolicyDelegate):
              * DumpRenderTree/mac/LayoutTestControllerMac.mm:
              (LayoutTestController::setCustomPolicyDelegate):
              * DumpRenderTree/mac/PolicyDelegate.h:
              * DumpRenderTree/mac/PolicyDelegate.mm:
              (-[PolicyDelegate webView:decidePolicyForNavigationAction:request:frame:decisionListener:]):
              (-[PolicyDelegate setPermissive:]):
              (-[PolicyDelegate setControllerToNotifyDone:]):
              * DumpRenderTree/win/LayoutTestControllerWin.cpp:
              (LayoutTestController::setCustomPolicyDelegate):
              * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
              (LayoutTestController::setCustomPolicyDelegate):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@70385 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      3cdd815a
  10. 22 Oct, 2010 1 commit
    • andersca@apple.com's avatar
      WebCore: Using the decidePolicyForMIMEType delegate message in an asynchronous manner does not work · b600db87
      andersca@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=48014
      <rdar://problem/8202716>
      
      Reviewed by Adam Barth and Darin Adler.
      
      * loader/MainResourceLoader.cpp:
      (WebCore::MainResourceLoader::continueAfterContentPolicy):
      Resume loading.
      
      (WebCore::MainResourceLoader::didReceiveResponse):
      Defer loading until we hear back from the policy client.
      
      WebKitTools: Using the decidePolicyForMIMEType delegate message in an asynchronous manner does not work
      https://bugs.webkit.org/show_bug.cgi?id=48014
      <rdar://problem/8202716>
      
      Reviewed by Adam Barth and Darin Adler.
      
      * DumpRenderTree/LayoutTestController.cpp:
      (setCustomPolicyDelegateCallback):
      Add callIgnoreInDecidePolicyForMIMETypeAfterOneSecond argument.
      
      * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
      (LayoutTestController::setCustomPolicyDelegate):
      Add callIgnoreInDecidePolicyForMIMETypeAfterOneSecond argument.
      
      * DumpRenderTree/mac/LayoutTestControllerMac.mm:
      (LayoutTestController::setCustomPolicyDelegate):
      Add callIgnoreInDecidePolicyForMIMETypeAfterOneSecond argument.
      
      * DumpRenderTree/mac/PolicyDelegate.h:
      * DumpRenderTree/mac/PolicyDelegate.mm:
      (-[PolicyDelegate webView:decidePolicyForMIMEType:request:frame:decisionListener:]):
      If _callIgnoreInDecidePolicyForMIMETypeAfterOneSecond is true, call [listener ignore] after one second.
      
      (-[PolicyDelegate setCallIgnoreInDecidePolicyForMIMETypeAfterOneSecond:]):
      Update _callIgnoreInDecidePolicyForMIMETypeAfterOneSecond.
      
      * DumpRenderTree/win/LayoutTestControllerWin.cpp:
      (LayoutTestController::setCustomPolicyDelegate):
      Add callIgnoreInDecidePolicyForMIMETypeAfterOneSecond argument.
      
      * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
      (LayoutTestController::setCustomPolicyDelegate):
      Add callIgnoreInDecidePolicyForMIMETypeAfterOneSecond argument.
      
      LayoutTests: Using the decidePolicyForMIMEType delegate message in an asynchronous manner does not work
      https://bugs.webkit.org/show_bug.cgi?id=48014
      <rdar://problem/8202716>
      
      Reviewed by Adam Barth and Darin Adler.
      
      Add tests and update the skipped list.
      
      * fast/loader/decide-policy-for-mime-type-async-expected.txt: Added.
      * fast/loader/decide-policy-for-mime-type-async.html: Added.
      * platform/gtk/Skipped:
      * platform/mac-wk2/Skipped:
      * platform/qt/Skipped:
      * platform/qt-wk2/Skipped:
      * platform/win/Skipped:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@70367 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      b600db87
  11. 21 Oct, 2010 1 commit
  12. 19 Oct, 2010 1 commit
    • commit-queue@webkit.org's avatar
      2010-10-19 Jia Pu <jpu@apple.com> · 55ac1ae2
      commit-queue@webkit.org authored
              Reviewed by Adele Peterson.
      
              Moving cursor back to autocorrected word in the same line shouldn't remove the underline
              https://bugs.webkit.org/show_bug.cgi?id=47629
              <rdar://problem/8546758>
      
              * platform/mac-leopard/Skipped: New tests don't apply to this Mac OSX version.
              * platform/mac-snowleopard/Skipped: Ditto.
              * platform/mac-tiger/Skipped: Ditto.
              * platform/mac-wk2/Skipped: Ditto.
              * platform/mac/editing/spelling/autocorrection-delete-expected.checksum:
              * platform/mac/editing/spelling/autocorrection-delete-expected.png:
              * platform/mac/editing/spelling/click-autocorrected-word-expected.checksum: Added.
              * platform/mac/editing/spelling/click-autocorrected-word-expected.png: Added.
              * platform/mac/editing/spelling/click-autocorrected-word-expected.txt: Added.
              * platform/mac/editing/spelling/click-autocorrected-word.html: Added.
              * platform/mac/editing/spelling/delete-into-autocorrected-word-expected.checksum: Added.
              * platform/mac/editing/spelling/delete-into-autocorrected-word-expected.png: Added.
              * platform/mac/editing/spelling/delete-into-autocorrected-word-expected.txt: Added.
              * platform/mac/editing/spelling/delete-into-autocorrected-word.html: Added.
              * platform/mac/editing/spelling/delete-into-misspelled-word-expected.txt: Added.
              * platform/mac/editing/spelling/delete-into-misspelled-word.html: Added.
              * platform/mac/editing/spelling/forward-delete-into-autocorrected-word-expected.checksum: Added.
              * platform/mac/editing/spelling/forward-delete-into-autocorrected-word-expected.png: Added.
              * platform/mac/editing/spelling/forward-delete-into-autocorrected-word-expected.txt: Added.
              * platform/mac/editing/spelling/forward-delete-into-autocorrected-word.html: Added.
              * platform/mac/editing/spelling/move-cursor-around-misspelled-word-expected.txt: Added.
              * platform/mac/editing/spelling/move-cursor-around-misspelled-word.html: Added.
              * platform/mac/editing/spelling/move-cursor-to-autocorrected-word-expected.checksum: Added.
              * platform/mac/editing/spelling/move-cursor-to-autocorrected-word-expected.png: Added.
              * platform/mac/editing/spelling/move-cursor-to-autocorrected-word-expected.txt: Added.
              * platform/mac/editing/spelling/move-cursor-to-autocorrected-word.html: Added.
              * platform/mac/editing/spelling/move-cursor-to-beginning-of-autocorrected-word-expected.checksum: Added.
              * platform/mac/editing/spelling/move-cursor-to-beginning-of-autocorrected-word-expected.png: Added.
              * platform/mac/editing/spelling/move-cursor-to-beginning-of-autocorrected-word-expected.txt: Added.
              * platform/mac/editing/spelling/move-cursor-to-beginning-of-autocorrected-word.html: Added.
      2010-10-19  Jia Pu  <jpu@apple.com>
      
              Reviewed by Adele Peterson.
      
              Moving cursor back to autocorrected word in the same line shouldn't remove the underline
              https://bugs.webkit.org/show_bug.cgi?id=47629
              <rdar://problem/8546758>
      
              Tests: platform/mac/editing/spelling/click-autocorrected-word.html
                     platform/mac/editing/spelling/delete-into-autocorrected-word.html
                     platform/mac/editing/spelling/delete-into-misspelled-word.html
                     platform/mac/editing/spelling/forward-delete-into-autocorrected-word.html
                     platform/mac/editing/spelling/move-cursor-around-misspelled-word.html
                     platform/mac/editing/spelling/move-cursor-to-autocorrected-word.html
                     platform/mac/editing/spelling/move-cursor-to-beginning-of-autocorrected-word.html
      
              * editing/Editor.cpp:
              (WebCore::Editor::respondToChangedSelection): Don't remove misspelling or autocorrection
                underlines when cursor is moved onto a word.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@70071 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      55ac1ae2
  13. 14 Oct, 2010 1 commit
    • commit-queue@webkit.org's avatar
      2010-10-14 Adrienne Walker <enne@google.com> · a80aea80
      commit-queue@webkit.org authored
              Reviewed by James Robinson.
      
              Add a test for very large image layers.  Skip this test for mac-wk2
              because of the use of layerTreeAsText().
              https://bugs.webkit.org/show_bug.cgi?id=47016
      
              * compositing/tiling/huge-layer-img.html: Added.
              * platform/chromium-gpu/compositing/tiling/huge-layer-img-expected.txt: Added.
              * platform/mac-wk2/Skipped:
              * platform/mac/compositing/tiling/huge-layer-img-expected.txt: Added.
      2010-10-14  Adrienne Walker  <enne@google.com>
      
              Reviewed by James Robinson.
      
              Add a short-term solution for large layers.  Layers that are too
              large to be contained in a single texture just upload the portion of
              the layer that is within the content rect.  A longer-term solution
              is still tiling with proper memory management.  Layers that have full
              3D transforms (more than just translations) are still not drawn.
              https://bugs.webkit.org/show_bug.cgi?id=47016
      
              Test: compositing/tiling
      
              * platform/graphics/chromium/ContentLayerChromium.cpp:
              (WebCore::ContentLayerChromium::ContentLayerChromium):
              (WebCore::ContentLayerChromium::requiresClippedUpdateRect):
              (WebCore::ContentLayerChromium::calculateClippedUpdateRect):
              (WebCore::ContentLayerChromium::updateContents):
              (WebCore::ContentLayerChromium::updateTextureRect):
              (WebCore::ContentLayerChromium::draw):
              * platform/graphics/chromium/ContentLayerChromium.h:
              * platform/graphics/chromium/ImageLayerChromium.cpp:
              (WebCore::ImageLayerChromium::updateContents):
              * platform/graphics/chromium/LayerRendererChromium.cpp:
              (WebCore::LayerRendererChromium::drawLayers):
              * platform/graphics/chromium/LayerRendererChromium.h:
              (WebCore::LayerRendererChromium::rootLayerContentRect):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@69747 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      a80aea80
  14. 07 Oct, 2010 2 commits
  15. 06 Oct, 2010 1 commit
    • commit-queue@webkit.org's avatar
      2010-10-06 Jia Pu <jpu@apple.com> · 17a21c69
      commit-queue@webkit.org authored
              Reviewed by Adele Peterson.
      
              Add regression tests for autocorrection panel
              https://bugs.webkit.org/show_bug.cgi?id=47308
              <rdar://problem/8521243>
      
              Added regression tests for recently added autocorrection panel on Mac platform, as implemented in <https://bugs.webkit.org/show_bug.cgi?id=44958>.
      
              * editing/spelling/autocorrection-delete.html: Added.
              * editing/spelling/autocorrection-removing-underline-after-paste.html: Added.
              * editing/spelling/autocorrection-removing-underline.html: Added.
              * editing/spelling/autocorrection-simple.html: Added.
              * platform/mac-leopard/Skipped:
              * platform/mac-snowleopard/Skipped:
              * platform/mac-tiger/Skipped:
              * platform/mac-wk2/Skipped:
              * platform/mac/editing/spelling/autocorrection-delete-expected.checksum: Added.
              * platform/mac/editing/spelling/autocorrection-delete-expected.png: Added.
              * platform/mac/editing/spelling/autocorrection-delete-expected.txt: Added.
              * platform/mac/editing/spelling/autocorrection-removing-underline-after-paste-expected.checksum: Added.
              * platform/mac/editing/spelling/autocorrection-removing-underline-after-paste-expected.png: Added.
              * platform/mac/editing/spelling/autocorrection-removing-underline-after-paste-expected.txt: Added.
              * platform/mac/editing/spelling/autocorrection-removing-underline-expected.checksum: Added.
              * platform/mac/editing/spelling/autocorrection-removing-underline-expected.png: Added.
              * platform/mac/editing/spelling/autocorrection-removing-underline-expected.txt: Added.
              * platform/mac/editing/spelling/autocorrection-simple-expected.checksum: Added.
              * platform/mac/editing/spelling/autocorrection-simple-expected.png: Added.
              * platform/mac/editing/spelling/autocorrection-simple-expected.txt: Added.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@69269 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      17a21c69
  16. 24 Sep, 2010 1 commit
  17. 20 Sep, 2010 1 commit
    • aestes@apple.com's avatar
      2010-09-20 Andy Estes <aestes@apple.com> · 7fb43f6f
      aestes@apple.com authored
              Reviewed by Adam Barth.
      
              REGRESSION (HTML5 Parser): Pages broken due to <tag<tag> parsing changes
              https://bugs.webkit.org/show_bug.cgi?id=40961
      
              Implement WebKitUsePreHTML5ParserQuirks preference.
      
              * WebView/WebPreferenceKeysPrivate.h:
              * WebView/WebPreferences.mm:
              (+[WebPreferences initialize]): Default WebKitUsePreHTML5ParserQuirks to
              false.
              (-[WebPreferences usePreHTML5ParserQuirks]):
              (-[WebPreferences setUsePreHTML5ParserQuirks:]):
              * WebView/WebPreferencesPrivate.h:
              * WebView/WebView.mm:
              (-[WebView _preferencesChangedNotification:]): Update WebCore::Settings
              with the value of WebKitUsePreHTML5ParserQuirks when a preference
              changes.
      2010-09-20  Andy Estes  <aestes@apple.com>
      
              Reviewed by Adam Barth.
      
              REGRESSION (HTML5 Parser): Pages broken due to <tag<tag> parsing changes
              https://bugs.webkit.org/show_bug.cgi?id=40961
      
              Add an optional quirk to the HTML5 tokenizer that reverts it to WebKit's
              legacy behavior when the start of a new token is encountered before the
              current token is finished parsing. The legacy behavior is to emit the
              current token as if it were properly closed and being parsing the new
              token.
      
              Test: fast/parser/pre-html5-parser-quirks.html
      
              * html/parser/HTMLDocumentParser.cpp:
              (WebCore::HTMLDocumentParser::HTMLDocumentParser): Instantiate
              m_tokenizer with the value of Settings::usePreHTML5ParserQuirks().
              (WebCore::usePreHTMLParserQuirks): Add a helper function to return the
              value of Settings::usePreHTML5ParserQuirks() if Settings is non-NULL.
              * html/parser/HTMLPreloadScanner.cpp:
              (WebCore::HTMLPreloadScanner::HTMLPreloadScanner): Instantiate
              m_tokenizer with the value of Settings::usePreHTML5ParserQuirks().
              * html/parser/HTMLTokenizer.cpp:
              (WebCore::HTMLTokenizer::HTMLTokenizer):
              (WebCore::HTMLTokenizer::nextToken): If the quirk is enabled and an
              unexpected '<' is encountered in certain states, emit the current token
              and reprocess the '<' as the start of a new token.
              * html/parser/HTMLTokenizer.h:
              (WebCore::HTMLTokenizer::create):
              * html/parser/HTMLViewSourceParser.cpp:
              (WebCore::HTMLViewSourceParser::HTMLViewSourceParser): Instantiate
              m_tokenizer with the value of Settings::usePreHTML5ParserQuirks().
              * page/Settings.cpp:
              (WebCore::Settings::Settings):
              * page/Settings.h:
              (WebCore::Settings::setUsePreHTML5ParserQuirks):
              (WebCore::Settings::usePreHTML5ParserQuirks):
      2010-09-20  Andy Estes  <aestes@apple.com>
      
              Reviewed by Adam Barth.
      
              REGRESSION (HTML5 Parser): Pages broken due to <tag<tag> parsing changes
              https://bugs.webkit.org/show_bug.cgi?id=40961
      
              * fast/parser/pre-html5-parser-quirks-expected.txt: Added.
              * fast/parser/pre-html5-parser-quirks.html: Added.
              * fast/parser/resources/pre-html5-parser-quirk-after-attribute-name-state.html: Added.
              * fast/parser/resources/pre-html5-parser-quirk-after-attribute-value-quoted-state.html: Added.
              * fast/parser/resources/pre-html5-parser-quirk-after-attribute-value-unquoted-state.html: Added.
              * fast/parser/resources/pre-html5-parser-quirk-attribute-name-state.html: Added.
              * fast/parser/resources/pre-html5-parser-quirk-before-attribute-name-state.html: Added.
              * fast/parser/resources/pre-html5-parser-quirk-document-fragment.html: Added.
              * fast/parser/resources/pre-html5-parser-quirk-tag-name-state.html: Added.
              * platform/chromium/test_expectations.txt: Skip pre-html5-parser-quirks.html.
              * platform/gtk/Skipped: Skip pre-html5-parser-quirks.html.
              * platform/mac-wk2/Skipped: Skip pre-html5-parser-quirks.html.
              * platform/qt/Skipped: Skip pre-html5-parser-quirks.html.
              * platform/win/Skipped: Skip pre-html5-parser-quirks.html.
      2010-09-20  Andy Estes  <aestes@apple.com>
      
              Reviewed by Adam Barth.
      
              REGRESSION (HTML5 Parser): Pages broken due to <tag<tag> parsing changes
              https://bugs.webkit.org/show_bug.cgi?id=40961
      
              Implement WebKitUsePreHTML5ParserQuirks preference.
      
              * DumpRenderTree/mac/DumpRenderTree.mm:
              (resetDefaultsToConsistentValues): Reset WebKitUsePreHTML5ParserQuirks
              to false after a test finishes.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@67890 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      7fb43f6f
  18. 17 Sep, 2010 1 commit
  19. 13 Sep, 2010 1 commit
  20. 12 Sep, 2010 2 commits
  21. 11 Sep, 2010 2 commits
  22. 10 Sep, 2010 1 commit
  23. 08 Sep, 2010 3 commits
  24. 01 Sep, 2010 1 commit
  25. 31 Aug, 2010 4 commits
    • ap@apple.com's avatar
      Reviewed by Sam Weinig. · 65ffad3f
      ap@apple.com authored
              https://bugs.webkit.org/show_bug.cgi?id=42195
              <rdar://problem/8186761> WebKitTestRunner needs to support layoutTestController.setXSSAuditorEnabled
      
      LayoutTests:
              * platform/mac-wk2/Skipped: Unskip XSS Auditor tests.
      
      WebKitTools:
              * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl:
              * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp: (WTR::LayoutTestController::setXSSAuditorEnabled):
              * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
              Added setXSSAuditorEnabled, calling through to an WKBundle private method. Calling this method
              makes WebProcess use a different value for this preference than UIProcess thinks it uses.
      
              * WebKitTestRunner/TestController.cpp: (WTR::TestController::resetStateToConsistentValues):
              Reset xssAuditorEnabled. Even though the value doesn't change, this calls through to WebProcess,
              which forgets its override.
      
      WebKit2:
              * Shared/WebPreferencesStore.cpp:
              (WebKit::WebPreferencesStore::WebPreferencesStore): Initialize xssAuditorEnabled.
              (WebKit::WebPreferencesStore::decode): Moved from header, added xssAuditorEnabled.
              (WebKit::WebPreferencesStore::encode): Ditto.
              (WebKit::WebPreferencesStore::overrideXSSAuditorEnabledForTestRunner): Set an override, so
              that decoding a WebPreferencesStore in the process will give the override result. WebProcess
              doesn't hold to WebPreferencesStore, so there are no existing ones to patch.
              (WebKit::WebPreferencesStore::removeTestRunnerOverrides): Remove the override.
      
              * Shared/WebPreferencesStore.h: Added xssAuditorEnabled.
      
              * UIProcess/API/C/WKPreferences.cpp:
              (WKPreferencesSetXSSAuditorEnabled):
              (WKPreferencesGetXSSAuditorEnabled):
              * UIProcess/API/C/WKPreferences.h:
              Added an API method to change xssAuditorEnabled preference.
      
              * UIProcess/WebPageProxy.cpp: (WebKit::WebPageProxy::preferencesDidChange): Added a comment
              explaining how making this method smarter could affect WebKitTestRunner.
      
              * UIProcess/WebPreferences.cpp:
              (WebKit::WebPreferences::setXSSAuditorEnabled):
              (WebKit::WebPreferences::xssAuditorEnabled):
              * UIProcess/WebPreferences.h:
              Implemented xssAuditorEnabled preference accessors.
      
              * WebProcess/InjectedBundle/API/c/WKBundle.cpp: (WKBundleOverrideXSSAuditorEnabledForTestRunner):
              * WebProcess/InjectedBundle/API/c/WKBundlePrivate.h:
              Added a private methods to temporarily change xssAuditor setting from an injected bundle,
              not notifying UIProcess about the change.
      
              * WebProcess/InjectedBundle/InjectedBundle.cpp: (WebKit::InjectedBundle::overrideXSSAuditorEnabledForTestRunner):
              * WebProcess/InjectedBundle/InjectedBundle.h:
              Change the setting in existing pages, and override it for future ones.
      
              * WebProcess/WebPage/WebPage.cpp:
              (WebKit::WebPage::WebPage): Take xssAuditorEnabled from preferences store.
              (WebKit::WebPage::preferencesDidChange): If preferences change, forget our override. This only
              happens in WKRT when the next test begins.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@66551 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      65ffad3f
    • weinig@apple.com's avatar
      WebKitTestRunner needs layoutTestController.addUserStyleSheet · 211fe6e2
      weinig@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=42680
      
      Reviewed by Gavin Barraclough.
      
      WebKitTestRunner needs layoutTestController.addUserScript
      https://bugs.webkit.org/show_bug.cgi?id=42681
      
      WebKit2: 
      
      Improve UserContent APIs to allow passing null in the same places
      the WebKit1 API allowed. Add convenience function toWTFString to do
      WKStringRef conversion with correct null string behavior.
      
      * UIProcess/API/C/WKAPICast.h:
      (toWTFString):
      * WebProcess/InjectedBundle/API/c/WKBundle.cpp:
      (WKBundleAddUserScript):
      (WKBundleAddUserStyleSheet):
      (WKBundleRemoveUserScript):
      (WKBundleRemoveUserStyleSheet):
      * WebProcess/InjectedBundle/InjectedBundle.cpp:
      (WebKit::toStringVector):
      
      WebKitTools: 
      
      * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl:
      * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
      (WTR::InjectedBundle::beginTesting):
      * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
      (WTR::LayoutTestController::addUserScript):
      (WTR::LayoutTestController::addUserStyleSheet):
      * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
      
      LayoutTests: 
      
      * platform/mac-wk2/Skipped: Update skipped list.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@66548 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      211fe6e2
    • jianli@chromium.org's avatar
      Expose window.createBlobURL and window.revokeBlobURL. · a1450b37
      jianli@chromium.org authored
      https://bugs.webkit.org/show_bug.cgi?id=44908
      
      Reviewed by David Levin.
      
      WebCore:
      
      Tests: fast/files/apply-blob-url-to-img.html
             fast/files/apply-blob-url-to-xhr.html
      
      * page/DOMWindow.cpp:
      (WebCore::DOMWindow::createBlobURL):
      (WebCore::DOMWindow::revokeBlobURL):
      * page/DOMWindow.h:
      * page/DOMWindow.idl:
      * xml/XMLHttpRequest.cpp:
      (WebCore::XMLHttpRequest::createRequest):
      
      LayoutTests:
      
      * fast/dom/Window/script-tests/window-property-descriptors.js:
      * fast/dom/Window/window-properties.html:
      * fast/dom/script-tests/prototype-inheritance.js:
      * fast/files/apply-blob-url-to-img.html: Added.
      * fast/files/apply-blob-url-to-xhr-expected.txt: Added.
      * fast/files/apply-blob-url-to-xhr.html: Added.
      * fast/files/resources/abe.png: Copied from LayoutTests/editing/resources/abe.png.
      * platform/chromium/test_expectations.txt:
      * platform/gtk/Skipped:
      * platform/mac-wk2/Skipped:
      * platform/mac/fast/files/apply-blob-url-to-img-expected.checksum: Added.
      * platform/mac/fast/files/apply-blob-url-to-img-expected.png: Added.
      * platform/mac/fast/files/apply-blob-url-to-img-expected.txt: Added.
      * platform/qt/Skipped:
      * platform/win/Skipped:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@66462 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      a1450b37
    • jianli@chromium.org's avatar
      Support FileReaderSync in workers. · f3b91d69
      jianli@chromium.org authored
      https://bugs.webkit.org/show_bug.cgi?id=44657
      
      Reviewed by David Levin.
      
      WebCore:
      
      Also add FileException interface and make Blob/File/FileError useable in
      workers.
      
      Tests: fast/files/workers/worker-read-blob-async.html
             fast/files/workers/worker-read-blob-sync.html
             fast/files/workers/worker-read-file-async.html
             fast/files/workers/worker-read-file-sync.html
      
      * DerivedSources.cpp:
      * DerivedSources.make:
      * WebCore.gypi:
      * WebCore.pro:
      * WebCore.vcproj/WebCore.vcproj:
      * WebCore.xcodeproj/project.pbxproj:
      * fileapi/Blob.idl: Added NoStaticTables attribute.
      * fileapi/File.idl: Added NoStaticTables attribute.
      * fileapi/FileError.idl: Added NoStaticTables attribute.
      * fileapi/FileException.h: Added.
      * fileapi/FileException.idl: Added.
      * fileapi/FileReaderSync.cpp: Added.
      * fileapi/FileReaderSync.h: Added.
      * fileapi/FileReaderSync.idl: Added.
      * workers/WorkerContext.idl: Expose FileReaderSync and BlodBuilder in workers.
      
      LayoutTests:
      
      Added 4 test files to test FileReaderSync in workers.
      
      * fast/files/read-blob-async.html:
      * fast/files/read-file-async.html:
      * fast/files/resources/read-common.js:
      (readBlobAsBinaryString):
      (readBlobAsText):
      (readBlobAsDataURL):
      (_readBlobAsBinaryStringAsync):
      (_readBlobAsTextAsync):
      (_readBlobAsDataURLAsync):
      (_readBlobAsBinaryStringSync):
      (_readBlobAsTextSync):
      (_readBlobAsDataURLSync):
      (createReaderSync):
      * fast/files/resources/read-blob-test-cases.js:
      (runNextTest):
      * fast/files/resources/read-file-test-cases.js:
      (runNextTest):
      (testMultipleReads):
      * fast/files/resources/setup-for-read-common.js:
      (log):
      (startWorker.worker.onmessage):
      (startWorker.worker.onerror):
      (startWorker):
      * fast/files/workers/resources/worker-read-blob-async.js: Added.
      * fast/files/workers/resources/worker-read-blob-sync.js: Added.
      * fast/files/workers/resources/worker-read-common.js: Added.
      * fast/files/workers/resources/worker-read-file-async.js: Added.
      * fast/files/workers/resources/worker-read-file-sync.js: Added.
      * fast/files/workers/worker-read-blob-async-expected.txt: Added.
      * fast/files/workers/worker-read-blob-async.html: Added.
      * fast/files/workers/worker-read-blob-sync-expected.txt: Added.
      * fast/files/workers/worker-read-blob-sync.html: Added.
      * fast/files/workers/worker-read-file-async-expected.txt: Added.
      * fast/files/workers/worker-read-file-async.html: Added.
      * fast/files/workers/worker-read-file-sync-expected.txt: Added.
      * fast/files/workers/worker-read-file-sync.html: Added.
      * platform/chromium/test_expectations.txt:
      * platform/gtk/Skipped:
      * platform/mac-wk2/Skipped:
      * platform/qt/Skipped:
      * platform/win/Skipped:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@66461 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      f3b91d69
  26. 30 Aug, 2010 1 commit
    • jianli@chromium.org's avatar
      Switch the Blob implementation to using the blob data registration model · 42e36c71
      jianli@chromium.org authored
      https://bugs.webkit.org/show_bug.cgi?id=44389
      
      Reviewed by Darin Fisher.
      
      WebCore:
      
      Tests: fast/files/read-blob-async.html
             fast/files/read-file-async.html
      
      With this switch, File/Blob/BlobBuilder are changed to register the blob
      data. FileReader is changed to route through loading the blob resource.
      FormData is also updated to take BlobData. The WebKit mac implementation
      is updated to resolve the blob references in the BlobData.
      
      * CMakeLists.txt: Update the project file to remove BlobItem.*.
      * GNUmakefile.am: Update the project file to remove BlobItem.*.
      * WebCore.gypi: Update the project file to remove BlobItem.*.
      * WebCore.pro: Update the project file to remove BlobItem.*.
      * WebCore.vcproj/WebCore.vcproj: Update the project file to remove BlobItem.*.
      * WebCore.xcodeproj/project.pbxproj: Update the project file to remove BlobItem.*.
      * fileapi/Blob.cpp: Switch to using BlobData.
      (WebCore::Blob::Blob):
      (WebCore::Blob::slice):
      * fileapi/Blob.h: Switch to using BlobData.
      (WebCore::Blob::create):
      (WebCore::Blob::size):
      (WebCore::Blob::isFile):
      * fileapi/BlobBuilder.cpp: Switch to using BlobData.
      (WebCore::BlobBuilder::BlobBuilder):
      (WebCore::BlobBuilder::append):
      (WebCore::BlobBuilder::getBlob):
      * fileapi/BlobBuilder.h: Switch to using BlobData.
      * fileapi/BlobURL.cpp: Add a new helper method used in FormData.
      (WebCore::BlobURL::getIdentifier):
      * fileapi/BlobURL.h:
      * fileapi/File.cpp: Switch to using BlobData.
      (WebCore::createBlobDataForFile):
      (WebCore::File::File):
      (WebCore::File::size):
      (WebCore::File::captureSnapshot):
      * fileapi/File.h: Switch to using BlobData.
      (WebCore::File::create):
      (WebCore::File::path):
      (WebCore::File::name):
      (WebCore::File::webkitRelativePath):
      * fileapi/FileReader.cpp: Change the reading to route through blob resource loading.
      (WebCore::FileReader::FileReader):
      (WebCore::FileReader::readAsBinaryString):
      (WebCore::FileReader::readAsText):
      (WebCore::FileReader::readAsDataURL):
      (WebCore::delayedStart):
      (WebCore::FileReader::readInternal):
      (WebCore::FileReader::terminate):
      (WebCore::FileReader::start):
      (WebCore::FileReader::didReceiveResponse):
      (WebCore::FileReader::didReceiveData):
      (WebCore::FileReader::didFinishLoading):
      (WebCore::FileReader::didFail):
      (WebCore::FileReader::failed):
      (WebCore::FileReader::httpStatusCodeToExceptionCode):
      (WebCore::FileReader::result):
      (WebCore::FileReader::convertToDataURL):
      * fileapi/FileReader.h:
      * html/FormDataList.cpp: Account to BlobData change.
      (WebCore::FormDataList::appendString):
      (WebCore::FormDataList::appendBlob):
      * html/FormDataList.h: Account to BlobData change.
      (WebCore::FormDataList::appendBlob):
      (WebCore::FormDataList::Item::Item):
      (WebCore::FormDataList::Item::data):
      (WebCore::FormDataList::Item::blob):
      (WebCore::FormDataList::items):
      * loader/FormSubmission.cpp: Account to BlobData change.
      (WebCore::FormSubmission::create):
      * platform/BlobItem.cpp: Removed.
      * platform/BlobItem.h: Removed.
      * platform/network/BlobRegistryImpl.cpp: Add the implementations for resource loading.
      (WebCore::BlobRegistryImpl::createResourceHandle):
      (WebCore::BlobRegistryImpl::loadResourceSynchronously):
      * platform/network/BlobResourceHandle.cpp: Fix a bug that the ref is not added.
      (WebCore::BlobResourceHandle::BlobResourceHandle):
      * platform/network/FormData.cpp: Account to BlobData change.
      (WebCore::FormData::create):
      (WebCore::FormData::createMultiPart):
      (WebCore::FormData::deepCopy):
      (WebCore::FormData::appendFile):
      (WebCore::FormData::appendKeyValuePairItems):
      * platform/network/FormData.h: Account to BlobData change.
      * platform/network/mac/FormDataStreamMac.mm: Resolve blob references in the form data.
      (WebCore::closeCurrentStream):
      (WebCore::advanceCurrentStream):
      (WebCore::formCreate):
      (WebCore::formRead):
      (WebCore::setHTTPBody):
      * xml/XMLHttpRequest.cpp: Account to BlobData change.
      (WebCore::XMLHttpRequest::send):
      
      WebKit/chromium:
      
      * src/WebSearchableFormData.cpp:
      (WebCore::HasSuitableTextElement):
      
      LayoutTests:
      
      Add a new test and change an existing test. Both tests are written in
      better organized utility files and modules.
      
      * fast/files/file-reader-expected.txt: Removed.
      * fast/files/file-reader.html: Removed.
      * fast/files/read-blob-async-expected.txt: Added.
      * fast/files/read-blob-async.html: Added.
      * fast/files/read-file-async-expected.txt: Added.
      * fast/files/read-file-async.html: Added.
      * fast/files/resources/UTF8-2.txt: Added.
      * fast/files/resources/UTF8-3.txt: Added.
      * fast/files/resources/read-blob-test-cases.js: Added.
      * fast/files/resources/read-common.js: Added.
      * fast/files/resources/read-file-test-cases.js: Added.
      * fast/files/resources/setup-for-read-common.js: Added.
      * platform/gtk/Skipped: Account to the test changes for gtk.
      * platform/mac-wk2/Skipped: Account to the test changes for mac-wk2.
      * platform/qt/Skipped: Account to the test changes for qt.
      * platform/win/Skipped: Account to the test changes for win.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@66452 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      42e36c71
  27. 28 Aug, 2010 1 commit