1. 18 Jan, 2011 26 commits
    • dimich@chromium.org's avatar
      [Chromium] Not reviewed, updated expectations for tests · 4668a0de
      dimich@chromium.org authored
      affected by http://trac.webkit.org/changeset/76047
      
      * platform/chromium-mac/fast/backgrounds/size/backgroundSize22-expected.checksum:
      * platform/chromium-mac/fast/backgrounds/size/backgroundSize22-expected.png:
      * platform/chromium-win/fast/backgrounds/size/backgroundSize22-expected.checksum:
      * platform/chromium-win/fast/backgrounds/size/backgroundSize22-expected.png:
      * platform/chromium-win/fast/css/background-clip-values-expected.checksum: Added.
      * platform/chromium-win/fast/css/background-clip-values-expected.png: Added.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@76070 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      4668a0de
    • kbr@google.com's avatar
      2011-01-18 Kenneth Russell <kbr@google.com> · 592c4269
      kbr@google.com authored
              Reviewed by David Levin.
      
              Must strip comments from WebGL shaders before enforcing character set
              https://bugs.webkit.org/show_bug.cgi?id=52390
      
              Strip comments from incoming shaders, preserving line numbers,
              before validating that they conform to the ESSL character set.
              Revert changes from http://trac.webkit.org/changeset/75735 which
              allowed invalid characters to be passed to certain APIs.
      
              Tested with WebGL layout tests, conformance test suite and several
              WebGL demos in both Safari and Chromium.
      
              * html/canvas/WebGLRenderingContext.cpp:
              (WebCore::StripComments::StripComments::process):
              (WebCore::WebGLRenderingContext::shaderSource):
      2011-01-18  Kenneth Russell  <kbr@google.com>
      
              Reviewed by David Levin.
      
              Must strip comments from WebGL shaders before enforcing character set
              https://bugs.webkit.org/show_bug.cgi?id=52390
      
              Incorporated non-ASCII GLSL conformance tests from Khronos
              repository. Updated and synchronized invalid-passed-params.html
              with Khronos repository, undoing changes from
              http://trac.webkit.org/changeset/75735 .
      
              * fast/canvas/webgl/glsl-conformance-expected.txt:
              * fast/canvas/webgl/invalid-passed-params-expected.txt:
              * fast/canvas/webgl/invalid-passed-params.html:
              * fast/canvas/webgl/shaders/00_shaders.txt:
              * fast/canvas/webgl/shaders/misc: Added.
              * fast/canvas/webgl/shaders/misc/00_shaders.txt: Added.
              * fast/canvas/webgl/shaders/misc/non-ascii-comments.vert: Added.
              * fast/canvas/webgl/shaders/misc/non-ascii.vert: Added.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@76063 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      592c4269
    • cmarrin@apple.com's avatar
      2011-01-18 Chris Marrin <cmarrin@apple.com> · c1e6b6bb
      cmarrin@apple.com authored
              Reviewed by Simon Fraser.
      
              Add LayoutTests for new compositing layer logic
              https://bugs.webkit.org/show_bug.cgi?id=52657
      
              Add 4 tests checking that the layer tree is properly constructed with nested
              layers. The first test is a simple static test of a layer with a 3D transform
              with a non-layered parent. It is a pixel test and is just looking for a correct
              image. The second test is similar but has a 4 deep hierarchy of <div> element where 
              only the innermost layer has a 3D transform. It is also a pixel test.
              The other 2 tests are the same except that they add and then remove the innermost
              layer's transform. It makes sure the layer tree is correct before and after
              these changes.
      
              * compositing/geometry/layer-due-to-layer-children-deep-switch-expected.txt: Added.
              * compositing/geometry/layer-due-to-layer-children-deep-switch.html: Added.
              * compositing/geometry/layer-due-to-layer-children-deep.html: Added.
              * compositing/geometry/layer-due-to-layer-children-switch-expected.txt: Added.
              * compositing/geometry/layer-due-to-layer-children-switch.html: Added.
              * compositing/geometry/layer-due-to-layer-children.html: Added.
              * platform/mac/compositing/geometry/layer-due-to-layer-children-deep-expected.checksum: Added.
              * platform/mac/compositing/geometry/layer-due-to-layer-children-deep-expected.png: Added.
              * platform/mac/compositing/geometry/layer-due-to-layer-children-deep-expected.txt: Added.
              * platform/mac/compositing/geometry/layer-due-to-layer-children-expected.checksum: Added.
              * platform/mac/compositing/geometry/layer-due-to-layer-children-expected.png: Added.
              * platform/mac/compositing/geometry/layer-due-to-layer-children-expected.txt: Added.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@76058 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      c1e6b6bb
    • mihaip@chromium.org's avatar
      2011-01-18 Mihai Parparita <mihaip@chromium.org> · 019aefe5
      mihaip@chromium.org authored
              Reviewed by Ojan Vafai.
      
              [Chromium] Update Sputnik test expectations
              https://bugs.webkit.org/show_bug.cgi?id=52656
      
              Mark Sputnik tests as WONTFIX, so that they don't artificially inflate
              our failing test count.
      
              * platform/chromium/test_expectations.txt:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@76056 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      019aefe5
    • dimich@chromium.org's avatar
      [Chromium] Not reviewed, test expectations update. · 618afe57
      dimich@chromium.org authored
      Added exclusion for new test fast/canvas/canvas-fillPath-alpha-shadow.html
      
      * platform/chromium-gpu/test_expectations.txt:
      * platform/chromium/test_expectations.txt:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@76051 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      618afe57
    • oliver@apple.com's avatar
      2011-01-18 Oliver Hunt <oliver@apple.com> · 536fb9cb
      oliver@apple.com authored
              Reviewed by Antti Koivisto.
      
              [jsfunfuzz] Assertion in codegen for array of NaN constants
              https://bugs.webkit.org/show_bug.cgi?id=52643
      
              Add a testcase to ensure we handle a large number of NaN literals
              in (0/0 is folded to NaN automatically during parsing).
      
              * fast/js/codegen-temporaries-expected.txt:
              * fast/js/script-tests/codegen-temporaries.js:
      2011-01-18  Oliver Hunt  <oliver@apple.com>
      
              Reviewed by Antti Koivisto.
      
              [jsfunfuzz] Assertion in codegen for array of NaN constants
              https://bugs.webkit.org/show_bug.cgi?id=52643
      
              Don't cache NaN literals in the code generator, as NaN doesn't compare
              as equal to itself it causes problems when rehashing the number cache.
      
              * bytecompiler/BytecodeGenerator.cpp:
              (JSC::BytecodeGenerator::emitLoad):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@76049 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      536fb9cb
    • commit-queue@webkit.org's avatar
      2011-01-18 Krithigassree Sambamurthy <krithigassree.sambamurthy@nokia.com> · 24d88faf
      commit-queue@webkit.org authored
              Reviewed by Simon Fraser.
      
              Support background-clip: content-box
              https://bugs.webkit.org/show_bug.cgi?id=48771
      
              Addded content-box as a valid background-clip value.
      
              * WebCore/css/CSSParser.cpp:
              (WebCore::parseBackgroundClip):
      2011-01-18  Krithigassree Sambamurthy  <krithigassree.sambamurthy@nokia.com>
      
              Reviewed by Simon Fraser.
      
              Support background-clip: content-box
              https://bugs.webkit.org/show_bug.cgi?id=48771
      
              Added test cases to check the various valid background-clip values.
      
              * fast/css/background-clip-text-expected.txt:
              * fast/css/background-clip-values-expected.checksum: Added.
              * fast/css/background-clip-values-expected.txt: Added.
              * fast/css/background-clip-values.html: Added.
              * fast/css/script-tests/background-clip-text.js:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@76047 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      24d88faf
    • cfleizach@apple.com's avatar
      REGRESSION: A problem with Voiceover and finding links · 99abb088
      cfleizach@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=52324
      
      Reviewed by Darin Adler.
      
      Source/WebCore: 
      
      Fallout from recent change to make WebCore return its own scroll view.
         1) There were two scroll views in the hierarchy, one which no needed to be ignored.
         2) Hit tests for sub frames needed to be offset.
         3) The check for whether an attachment is ignored must happen earlier than using
            the helpText to determine if an element should be ignored.
      
      Test: platform/mac/accessibility/iframe-with-title-correct-hierarchy.html
      
      * accessibility/AccessibilityObject.cpp:
      (WebCore::AccessibilityObject::elementAccessibilityHitTest):
      * accessibility/AccessibilityRenderObject.cpp:
      (WebCore::AccessibilityRenderObject::accessibilityIsIgnored):
      * accessibility/mac/AccessibilityObjectWrapper.mm:
      (-[AccessibilityObjectWrapper scrollViewParent]):
      
      Source/WebKit/mac: 
      
      * WebView/WebDynamicScrollBarsView.mm:
      (-[WebDynamicScrollBarsView accessibilityIsIgnored]):
      
      LayoutTests: 
      
      * platform/mac/accessibility/iframe-with-title-correct-hierarchy-expected.txt: Added.
      * platform/mac/accessibility/iframe-with-title-correct-hierarchy.html: Added.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@76044 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      99abb088
    • mrobinson@webkit.org's avatar
      2011-01-18 Martin Robinson <mrobinson@igalia.com> · d418a3a1
      mrobinson@webkit.org authored
              Reviewed by Eric Seidel.
      
              [GTK] Filenames are converted to URLs during edit drags
              https://bugs.webkit.org/show_bug.cgi?id=52096
      
              * platform/gtk/Skipped: Unskip passing test. Fix a misspelled
              drag and drop test on the list as well.
      2011-01-18  Martin Robinson  <mrobinson@igalia.com>
      
              Reviewed by Eric Seidel.
      
              [GTK] Filenames are converted to URLs during edit drags
              https://bugs.webkit.org/show_bug.cgi?id=52096
      
              * platform/gtk/DragDataGtk.cpp: Only advertise and deliver filenames as URLs if the
              conversion policy allows it.
              (WebCore::DragData::containsURL): Ditto.
              (WebCore::DragData::asURL): Ditto.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@76039 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      d418a3a1
    • jorlow@chromium.org's avatar
      2011-01-18 Jeremy Orlow <jorlow@chromium.org> · 9b84d5f3
      jorlow@chromium.org authored
              [Chromium] Create baselines for svg/css/text-gradient-shadow.svg
              https://bugs.webkit.org/show_bug.cgi?id=52640
      
              * platform/chromium-linux/svg/css/text-gradient-shadow-expected.checksum: Added.
              * platform/chromium-linux/svg/css/text-gradient-shadow-expected.png: Added.
              * platform/chromium-mac/svg/css/text-gradient-shadow-expected.checksum: Added.
              * platform/chromium-win/svg/css/text-gradient-shadow-expected.checksum: Added.
              * platform/chromium-win/svg/css/text-gradient-shadow-expected.png: Added.
              * platform/chromium-win/svg/css/text-gradient-shadow-expected.txt: Added.
              * platform/chromium/test_expectations.txt:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@76038 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      9b84d5f3
    • mrobinson@webkit.org's avatar
      2011-01-18 Martin Robinson <mrobinson@igalia.com> · 6492a44c
      mrobinson@webkit.org authored
              Skip two tests which were incorrectly passing before GTK+
              had support for beginDragWithFiles.
      
              * platform/gtk/Skipped: Skip failing tests.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@76037 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      6492a44c
    • jknotten@chromium.org's avatar
      2011-01-18 John Knottenbelt <jknotten@chromium.org> · 775c7bc1
      jknotten@chromium.org authored
              Reviewed by Jeremy Orlow.
      
              [Chromium] Adjust test expectations fast/files/revoke-blob-url.html is flaky on linux.
              https://bugs.webkit.org/show_bug.cgi?id=52633
      
              Combine test expectations for the test into one line.
      
              * platform/chromium/test_expectations.txt:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@76035 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      775c7bc1
    • commit-queue@webkit.org's avatar
      2011-01-18 Helder Correia <helder@sencha.com> · 6f93041c
      commit-queue@webkit.org authored
              Reviewed by Kenneth Rohde Christiansen.
      
              [Qt] Incorrect shadow alpha with semi-transparent solid fillStyle
              https://bugs.webkit.org/show_bug.cgi?id=52611
      
              This is related to bug 52559. The shadow color alpha must be multiplied
              by the context brush alpha.
      
              New test to ensure correct behavior of canvas with fillPath using a
              semi-transparent fillStyle color and a shadow.
      
              * fast/canvas/canvas-fillPath-alpha-shadow-expected.txt: Added.
              * fast/canvas/canvas-fillPath-alpha-shadow.html: Added.
              * fast/canvas/script-tests/canvas-fillPath-alpha-shadow.js: Added.
      2011-01-18  Helder Correia  <helder@sencha.com>
      
              Reviewed by Kenneth Rohde Christiansen.
      
              [Qt] Incorrect shadow alpha with semi-transparent solid fillStyle
              https://bugs.webkit.org/show_bug.cgi?id=52611
      
              This is related to bug 52559. The shadow color alpha must be multiplied
              by the context brush alpha.
      
              Test: fast/canvas/canvas-fillPath-alpha-shadow.html
      
              * platform/graphics/qt/GraphicsContextQt.cpp:
              (WebCore::GraphicsContext::fillPath):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@76033 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      6f93041c
    • jknotten@chromium.org's avatar
      2011-01-18 John Knottenbelt <jknotten@chromium.org> · 30d4f8e3
      jknotten@chromium.org authored
              Unreviewed; updated chromium test expectations.
      
              [Chromium] Adjust test expectations fast/files/revoke-blob-url.html is flaky on linux.
              https://bugs.webkit.org/show_bug.cgi?id=52633
      
              * platform/chromium/test_expectations.txt:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@76032 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      30d4f8e3
    • mrobinson@webkit.org's avatar
      2011-01-18 Adam Bergkvist <adam.bergkvist@ericsson.com> and Martin Robinson ... · ed7744cb
      mrobinson@webkit.org authored
      2011-01-18  Adam Bergkvist  <adam.bergkvist@ericsson.com> and Martin Robinson  <mrobinson@igalia.com>
      
              Reviewed by Gustavo Noronha Silva.
      
              [GTK] The GTK+ EventSender needs support for beginDragWithFiles
              https://bugs.webkit.org/show_bug.cgi?id=40833
      
              Unskip passing tests, add in a GTK+-specific result and one more result
              which is necessary because GTK+ tests run in Xvfb.
      
              * platform/gtk/Skipped: Unskip tests that are now passing and organize
              the remaining skipped tests.
              * platform/gtk/fast/forms/input-file-re-render-expected.txt: Added.
              * platform/gtk/http/tests/security/clipboard/clipboard-file-access-expected.txt: Added.
      2011-01-18  Adam Bergkvist  <adam.bergkvist@ericsson.com> and Martin Robinson  <mrobinson@igalia.com>
      
              Reviewed by Gustavo Noronha Silva.
      
              [GTK] The GTK+ EventSender needs support for beginDragWithFiles
              https://bugs.webkit.org/show_bug.cgi?id=40833
      
              * DumpRenderTree/gtk/EventSender.cpp: Add a beginDragWithFiles implementation for the
              GTK+ event sender.
              (dragWithFilesDragDataGetCallback): Added.
              (dragWithFilesDragEndCallback): Added.
              (beginDragWithFilesCallback): Added.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@76031 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      ed7744cb
    • caseq@chromium.org's avatar
      2011-01-18 Andrey Kosyakov <caseq@chromium.org> · d4c0590f
      caseq@chromium.org authored
              Reviewed by Yury Semikhatsky.
      
              Web Inspector: fail resource.requestContent() immediately for WebSocket resources
              Remove webInspector.resources.Types from test expectations.
              https://bugs.webkit.org/show_bug.cgi?id=52628
      
              * inspector/extensions-api-expected.txt:
      2011-01-18  Andrey Kosyakov  <caseq@chromium.org>
      
              Reviewed by Yury Semikhatsky.
      
              Web Inspector: fail resource.requestContent() immediately for WebSocket resources
              https://bugs.webkit.org/show_bug.cgi?id=52628
      
              * English.lproj/localizedStrings.js: Rename WebSocket -> WebSockets in resource catetegories (rest are in plural, too)
              * inspector/front-end/ExtensionServer.js: Do not expose webInspector.resources.Types in extensions API (obsolete)
              (WebInspector.ExtensionServer.prototype._buildExtensionAPIInjectedScript):
              * inspector/front-end/Resource.js:
              (WebInspector.Resource.Type.toUIString): Remove ResourceType.Media as it's not used.
              (WebInspector.Resource.Type.toString): ditto.
              (WebInspector.Resource.prototype.requestContent): Fail immediately for WebSocket resources.
              * inspector/front-end/inspector.js: Rename WebSocket -> WebSockets in resource catetegories (rest are in plural, too)
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@76030 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      d4c0590f
    • commit-queue@webkit.org's avatar
      2011-01-18 Helder Correia <helder@sencha.com> · f5812287
      commit-queue@webkit.org authored
              Reviewed by Dirk Schulze.
      
              REGRESSION(75139): SVG gradients are not applied to texts
              https://bugs.webkit.org/show_bug.cgi?id=52531
      
              r75139 caused a problem with filling and stroking text with a gradient
              fill in SVG. The order of CGContextConcatCTM and CGContextClipToRect
              was mixed up.
      
              * platform/mac/svg/css/text-gradient-shadow-expected.checksum: Added.
              * platform/mac/svg/css/text-gradient-shadow-expected.png: Added.
              * platform/mac/svg/css/text-gradient-shadow-expected.txt: Added.
              * svg/css/text-gradient-shadow.svg: Added.
      2011-01-18  Helder Correia  <helder@sencha.com>
      
              Reviewed by Dirk Schulze.
      
              REGRESSION(75139): SVG gradients are not applied to texts
              https://bugs.webkit.org/show_bug.cgi?id=52531
      
              r75139 caused a problem with filling and stroking text with a gradient
              fill in SVG. The order of CGContextConcatCTM and CGContextClipToRect
              was mixed up.
      
              Test: svg/css/text-gradient-shadow.svg
      
              * platform/graphics/cg/GraphicsContextCG.cpp:
              (WebCore::GraphicsContext::fillRect):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@76029 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      f5812287
    • jknotten@chromium.org's avatar
      2011-01-18 John Knottenbelt <jknotten@chromium.org> · 964064a2
      jknotten@chromium.org authored
              Reviewed by Jeremy Orlow.
      
              Add pixel test baseline for svg/custom/use-inherit-style.svg
              https://bugs.webkit.org/show_bug.cgi?id=52630
      
              * svg/custom/use-inherit-style-expected.checksum: Added.
              * svg/custom/use-inherit-style-expected.png: Added.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@76028 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      964064a2
    • commit-queue@webkit.org's avatar
      2011-01-18 Leo Yang <leo.yang@torchmobile.com.cn> · 2d2bdd50
      commit-queue@webkit.org authored
              Reviewed by Nikolas Zimmermann.
      
              Unable to indirectly animate visibility of SVGUseElement
              https://bugs.webkit.org/show_bug.cgi?id=50240
      
              Test case to verify if SVGUseElement inherits parent's
              style change.
      
              * svg/custom/use-inherit-style-expected.txt: Added.
              * svg/custom/use-inherit-style.svg: Added.
      2011-01-18  Leo Yang  <leo.yang@torchmobile.com.cn>
      
              Reviewed by Nikolas Zimmermann.
      
              Unable to indirectly animate visibility of SVGUseElement
              https://bugs.webkit.org/show_bug.cgi?id=50240
      
              SVGUseElement::recalcStyle should take care of its shadow
              tree's style recalculation when it is called with change >= Inherit
              or when childNeedsStyleRecalc() is true because in these two
              cases needStyleRecalc() may not be true.
      
              Test: svg/custom/use-inherit-style.svg
      
              * svg/SVGUseElement.cpp:
              (WebCore::SVGUseElement::recalcStyle):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@76027 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      2d2bdd50
    • podivilov@chromium.org's avatar
      2011-01-18 Pavel Podivilov <podivilov@chromium.org> · 7d9eb55d
      podivilov@chromium.org authored
              Unreviewed, remove wrong chromium expectation for console-xhr-logging test.
      
              * platform/chromium/http/tests/inspector/console-xhr-logging-expected.txt: Removed.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@76025 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      7d9eb55d
    • podivilov@chromium.org's avatar
      2011-01-18 Pavel Podivilov <podivilov@chromium.org> · cc9a61db
      podivilov@chromium.org authored
              Unreviewed, test fix for r76019.
      
              * http/tests/inspector-enabled/console-log-before-frame-navigation-expected.txt:
              * http/tests/inspector-enabled/console-log-before-frame-navigation.html:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@76023 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      cc9a61db
    • podivilov@chromium.org's avatar
      2011-01-18 Pavel Podivilov <podivilov@chromium.org> · 37dda3c5
      podivilov@chromium.org authored
              Reviewed by Yury Semikhatsky.
      
              Web Inspector: fix flaky debugger tests.
              https://bugs.webkit.org/show_bug.cgi?id=51320
      
              * http/tests/inspector/debugger-test2.js:
              (initialize_DebuggerTest.InspectorTest.setBreakpoint):
              (initialize_DebuggerTest.InspectorTest.showScriptSource):
              (initialize_DebuggerTest.InspectorTest._showScriptSource):
              * inspector/debugger-pause-on-breakpoint-expected.txt:
              * inspector/debugger-pause-on-breakpoint.html:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@76020 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      37dda3c5
    • antti@apple.com's avatar
      Source/WebCore: 2011-01-18 Antti Koivisto <antti@apple.com> · 84c087a0
      antti@apple.com authored
      Reviewed by Dave Hyatt.
      
      https://bugs.webkit.org/show_bug.cgi?id=52370
      <rdar://problem/8856808>
      Style sharing optimization no longer works on major web sites
              
      The code in CSSStyleSelector::locateSharedStyle() that tries to share style information between element has been defeated 
      by widespread use of certain CSS selectors (:first-child pseudo class and similar). The current implementation disables
      the sharing optimization for the whole page if one of these constructs is seen in any style sheet used by the page.  
              
      This patch gets the style sharing back to 25-40% range on most web sites.
      
      * css/CSSMutableStyleDeclaration.h:
      (WebCore::CSSMutableStyleDeclaration::propertiesEqual):
                  
          Needed to improve equality checking in NamedNodeMap::mappedMapsEquivalent.
              
      * css/CSSSelector.h:
      (WebCore::CSSSelector::isSiblingSelector):
              
          Test for selectors that are affected by the sibling elements.
              
      * css/CSSStyleSelector.cpp:
      (WebCore::elementCanUseSimpleDefaultStyle):
      (WebCore::collectSiblingRulesInDefaultStyle):
      (WebCore::assertNoSiblingRulesInDefaultStyle):
                  
          Extract sibling rules from the MathML default stylesheet. 
          Assert that no other default stylesheet has them.
                  
      (WebCore::CSSStyleSelector::CSSStyleSelector):
      (WebCore::CSSStyleSelector::locateCousinList):
      (WebCore::CSSStyleSelector::matchesSiblingRules):
      (WebCore::CSSStyleSelector::canShareStyleWithElement):
      (WebCore::CSSStyleSelector::locateSharedStyle):
      (WebCore::CSSStyleSelector::styleForElement):
      (WebCore::collectIdsAndSiblingRulesFromList):
      (WebCore::CSSRuleSet::collectIdsAndSiblingRules):
      
          Track sibling rules and ids used in the stylesheets to allow much more fine-grained rejection of cases
          where style sharing can't be used.
      
      * css/CSSStyleSelector.h:
      * dom/NamedNodeMap.cpp:
      (WebCore::NamedNodeMap::mappedMapsEquivalent):
                  
          Check also for CSSValue mutation from DOM. 
                  
      * mathml/MathMLMathElement.cpp:
      (WebCore::MathMLMathElement::insertedIntoDocument):
      * mathml/MathMLMathElement.h:
              
          MathML default style sheet has sibling rules which don't get noticed by the normal document
          stylesheet parsing.
              
      * rendering/style/RenderStyle.h:
      (WebCore::InheritedFlags::setFirstChildState):
      (WebCore::InheritedFlags::setLastChildState):
      (WebCore::InheritedFlags::setChildIndex):
              
          These all make style non-shareable (unique).
      
      LayoutTests: https://bugs.webkit.org/show_bug.cgi?id=52370
      Style sharing optimization no longer works on major web sites
              
      Reviewed by Dave Hyatt.
      
      These are progressions (with no noticable visual change). 
      MathML code was improperly sharing style.
      
      * platform/mac/mathml/presentation/fractions-vertical-alignment-expected.txt:
      * platform/mac/mathml/presentation/subsup-expected.txt:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@76012 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      84c087a0
    • philn@webkit.org's avatar
      2011-01-18 Philippe Normand <pnormand@igalia.com> · e4ac69da
      philn@webkit.org authored
              Unreviewed, rolling out r76002.
              http://trac.webkit.org/changeset/76002
              https://bugs.webkit.org/show_bug.cgi?id=49790
      
              breaks a bunch of fast/forms tests on mac and GTK
      
              * fast/forms/select-option-background-color-change.html: Removed.
              * fast/forms/select-option-color-change.html: Removed.
              * fast/forms/select-option-visibility-change.html: Removed.
              * platform/mac/fast/forms/select-option-background-color-change-expected.checksum: Removed.
              * platform/mac/fast/forms/select-option-background-color-change-expected.png: Removed.
              * platform/mac/fast/forms/select-option-background-color-change-expected.txt: Removed.
              * platform/mac/fast/forms/select-option-color-change-expected.checksum: Removed.
              * platform/mac/fast/forms/select-option-color-change-expected.png: Removed.
              * platform/mac/fast/forms/select-option-color-change-expected.txt: Removed.
              * platform/mac/fast/forms/select-option-visibility-change-expected.checksum: Removed.
              * platform/mac/fast/forms/select-option-visibility-change-expected.png: Removed.
              * platform/mac/fast/forms/select-option-visibility-change-expected.txt: Removed.
      2011-01-18  Philippe Normand  <pnormand@igalia.com>
      
              Unreviewed, rolling out r76002.
              http://trac.webkit.org/changeset/76002
              https://bugs.webkit.org/show_bug.cgi?id=49790
      
              breaks a bunch of fast/forms tests on mac and GTK
      
              * html/HTMLOptionElement.cpp:
              (WebCore::HTMLOptionElement::setRenderStyle):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@76006 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      e4ac69da
    • ossy@webkit.org's avatar
      Unreviewed. · 146ded8e
      ossy@webkit.org authored
      [Qt] Fix LoadHTMLStringItem::invoke() after r75966
      https://bugs.webkit.org/show_bug.cgi?id=52614
      
      * platform/qt/Skipped: http/tests/navigation/go-back-to-error-page.html added until fix.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@76003 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      146ded8e
    • rwlbuis@webkit.org's avatar
      2011-01-17 Rob Buis <rwlbuis@gmail.com> · f5461080
      rwlbuis@webkit.org authored
              Reviewed by Kent Tamura.
      
              Color changes to option elements in a select multiple aren't drawn immediately
              https://bugs.webkit.org/show_bug.cgi?id=49790
      
              Redirect style changes on <option> element to the owner <select> element.
      
              Tests: fast/forms/select-option-background-color-change.html
                     fast/forms/select-option-color-change.html
                     fast/forms/select-option-visibility-change.html
      
              * html/HTMLOptionElement.cpp:
              (WebCore::HTMLOptionElement::setRenderStyle):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@76002 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      f5461080
  2. 17 Jan, 2011 14 commits
    • commit-queue@webkit.org's avatar
      2011-01-17 Steve Lacey <sjl@chromium.org> · f939c8ad
      commit-queue@webkit.org authored
              Reviewed by David Levin.
      
              Rebaseline media/video-zoom-controls for chromium.
              https://bugs.webkit.org/show_bug.cgi?id=52415
      
              * platform/chromium-linux/media/video-zoom-controls-expected.checksum: Added.
              * platform/chromium-linux/media/video-zoom-controls-expected.png: Added.
              * platform/chromium-mac/media/video-zoom-controls-expected.checksum: Added.
              * platform/chromium-mac/media/video-zoom-controls-expected.png: Added.
              * platform/chromium-mac/media/video-zoom-controls-expected.txt: Added.
              * platform/chromium-win/media/video-zoom-controls-expected.checksum: Added.
              * platform/chromium-win/media/video-zoom-controls-expected.png: Added.
              * platform/chromium-win/media/video-zoom-controls-expected.txt: Added.
              * platform/chromium/test_expectations.txt:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@75996 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      f939c8ad
    • dimich@chromium.org's avatar
      [Chromium] Not reviewed, test expectations update. · 95d4bfae
      dimich@chromium.org authored
      Added TIMEOUT to  fast/canvas/canvas-fillPath-pattern-shadow.html
      
      * platform/chromium-gpu/test_expectations.txt:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@75993 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      95d4bfae
    • msaboff@apple.com's avatar
      2011-01-17 Michael Saboff <msaboff@apple.com> · b1155bd1
      msaboff@apple.com authored
              Reviewed by Oliver Hunt.
      
              [regexfuzz] Crash running regex with lookahead
              https://bugs.webkit.org/show_bug.cgi?id=52548
      
              Eliminated agressive chaining of backtracks.  This code was overwriting
              already valid backtrack information.
      
              * yarr/YarrJIT.cpp:
              (JSC::Yarr::YarrGenerator::ParenthesesTail::processBacktracks):
      2011-01-17  Michael Saboff  <msaboff@apple.com>
      
              Reviewed by Oliver Hunt.
      
              [regexfuzz] Crash running regex with lookahead
              https://bugs.webkit.org/show_bug.cgi?id=52548
      
              New tests from regex fuzzer.
      
              * fast/regex/parentheses-expected.txt:
              * fast/regex/script-tests/parentheses.js:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@75991 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      b1155bd1
    • dimich@chromium.org's avatar
      [Chromium] Not reviewed, test expectations update. · 212b8fc1
      dimich@chromium.org authored
      Same as previous patch, now for -gpu file.
      
      * platform/chromium-gpu/test_expectations.txt:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@75990 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      212b8fc1
    • dimich@chromium.org's avatar
      [Chromium] Not reviewed, test expectations update. · 5951b3da
      dimich@chromium.org authored
      fast/canvas/canvas-fillPath-pattern-shadow.html fails on Win and Linux.
      
      * platform/chromium/test_expectations.txt:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@75989 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      5951b3da
    • aroben@apple.com's avatar
      Don't access the CACFLayerRef's sublayers directly from PlatformCALayer · 7317c459
      aroben@apple.com authored
      There might be a secret extra sublayer (the tile parent layer) that
      PlatformCALayer doesn't know about. When PlatformCALayer would
      encounter this, it would try to use the tile parent layer's
      PlatformCALayer wrapper, which was null, and then would crash. We now
      ask PlatformCALayerWinInternal for the sublayer list, since that class
      knows about the tile parent layer and can exclude it from the sublayer
      list.
      
      Covered by compositing/tiling/huge-layer-resize.html.
      
      Fixes <http://webkit.org/b/52597> Crash beneath
      PlatformCALayer::adoptSublayers when switching out of tiling mode
      (null-dereference of a PlatformCALayer)
      
      Reviewed by Darin Adler and Chris Marrin.
      
      LayoutTests:
      
      Make compositing/tiling/huge-layer-resize.html faster, more reliable,
      and more crashy (when there's a WebKit bug)
      
      This test was trying to cause a layout/paint to happen by returning to
      the event loop for a certain amount of time via setTimeout. But this
      didn't always result in a layout/paint (at least on Windows). We now
      force the layout/paint explicitly, which also lets us speed up the test
      by removing the setTimeouts.
      
      * compositing/tiling/huge-layer-resize.html:
      (testOnLoad): Changed to use recordLayerTree, which forces a
      layout/paint, instead of hoping that setTimeout will do the trick.
      (recordLayerTree): Forces a layout/paint, then dumps the layer tree.
      
      Source/WebCore:
      
      * platform/graphics/ca/win/PlatformCALayerWin.cpp:
      (PlatformCALayer::adoptSublayers):
      (printLayer):
      Changed to use PlatformCALayerWinInternal::getSublayers.
      
      * platform/graphics/ca/win/PlatformCALayerWinInternal.cpp:
      (PlatformCALayerWinInternal::getSublayers): Added. Retrieves the list
      of PlatformCALayers that represent our sublayers. Significantly, this
      code knows about the tile parent layer and can thus exclude it.
      
      * platform/graphics/ca/win/PlatformCALayerWinInternal.h: Added
      getSublayers.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@75985 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      7317c459
    • mitz@apple.com's avatar
      Use of invalid hash map key in CSSFontFaceSource::getFontData() with 0-sized remote font · 78de1d02
      mitz@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=52598
      
      Reviewed by Darin Adler.
      
      Source/WebCore: 
      
      Test: fast/css/font-face-zero-hash-key.html
      
      * css/CSSFontFaceSource.cpp:
      (WebCore::CSSFontFaceSource::getFontData): Add 1 to the font size to avoid a 0 hash key.
      * css/CSSSegmentedFontFace.cpp:
      (WebCore::CSSSegmentedFontFace::getFontData): Ditto.
      
      LayoutTests: 
      
      * fast/css/font-face-zero-hash-key-expected.txt: Added.
      * fast/css/font-face-zero-hash-key.html: Added.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@75975 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      78de1d02
    • commit-queue@webkit.org's avatar
      2011-01-17 Helder Correia <helder@sencha.com> · 51fd6f02
      commit-queue@webkit.org authored
              Reviewed by Andreas Kling.
      
              [Qt] Incorrect shadow alpha with pattern fillStyle
              https://bugs.webkit.org/show_bug.cgi?id=52559
      
              The shadow color opacity needs to be set on the shadow painter.
              This is related to bug 52556.
      
              * fast/canvas/canvas-fillPath-pattern-shadow-expected.txt: Added.
              * fast/canvas/canvas-fillPath-pattern-shadow.html: Added.
              * fast/canvas/script-tests/canvas-fillPath-pattern-shadow.js: Added.
      2011-01-17  Helder Correia  <helder@sencha.com>
      
              Reviewed by Andreas Kling.
      
              [Qt] Incorrect shadow alpha with pattern fillStyle
              https://bugs.webkit.org/show_bug.cgi?id=52559
      
              The shadow color opacity needs to be set on the shadow painter.
              This is related to bug 52556.
      
              Test: fast/canvas/canvas-fillPath-pattern-shadow.html
      
              * platform/graphics/qt/GraphicsContextQt.cpp:
              (WebCore::GraphicsContext::fillPath):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@75973 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      51fd6f02
    • ddkilzer@apple.com's avatar
      2011-01-17 David Kilzer <ddkilzer@apple.com> · 5827990f
      ddkilzer@apple.com authored
              <http://webkit.org/b/52524> fast/dom/Range/range-clone-contents.html fails only on Windows
      
              Reviewed by Alexey Proskuryakov.
      
              * platform/win/Skipped: Removed
              fast/dom/Range/range-clone-contents.html.  It appears the
              Windows buildbots need a clean build.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@75970 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      5827990f
    • jberlin@webkit.org's avatar
      REGRESSION: Assertion failure in FrameLoader::continueLoadAfterWillSubmitForm() when · d617a3b2
      jberlin@webkit.org authored
      navigating back to an unreachable URL
      https://bugs.webkit.org/show_bug.cgi?id=52388
      
      Reviewed by Anders Carlsson.
      
      Source/WebCore: 
      
      Test: http/tests/navigation/go-back-to-error-page.html
      
      * history/PageCache.cpp:
      (WebCore::PageCache::canCachePageContainingThisFrame):
      Do not cache any error pages (which we can recognize as having substitute data and/or an
      unreachableURL).
      
      Tools: 
      
      Add a third parameter (unreachableURL) to queueLoadHTMLString.
      
      * DumpRenderTree/LayoutTestController.cpp:
      (queueLoadHTMLStringCallback):
      (LayoutTestController::queueLoadHTMLString):
      (LayoutTestController::queueLoadAlternateHTMLString):
      * DumpRenderTree/LayoutTestController.h:
      
      * DumpRenderTree/WorkQueueItem.h:
      (LoadHTMLStringItem::LoadHTMLStringItem):
      
      * DumpRenderTree/chromium/LayoutTestController.cpp:
      (WorkItemLoadHTMLString::WorkItemLoadHTMLString):
      (WorkItemLoadHTMLString::run):
      (LayoutTestController::queueLoadHTMLString):
      
      * DumpRenderTree/gtk/WorkQueueItemGtk.cpp:
      (LoadHTMLStringItem::invoke):
      * DumpRenderTree/mac/WorkQueueItemMac.mm:
      (LoadHTMLStringItem::invoke):
      * DumpRenderTree/win/WorkQueueItemWin.cpp:
      (LoadHTMLStringItem::invoke):
      
      LayoutTests: 
      
      Add a test that loads an alternate HTML String for an "unreachable" URL, loads another
      page, and then goes back to the "unreachable" URL, which is now reachable.
      
      This tests two things:
      1) No assertion failure when going back to an unreachable URL.
      2) There is no page cached for the unreachable URL.
      
      * http/tests/navigation/go-back-to-error-page-expected.txt: Added.
      * http/tests/navigation/go-back-to-error-page.html: Added.
      * http/tests/navigation/resources/page-to-go-back-from.html: Added.
      * http/tests/navigation/resources/page-treated-as-unreachable.html: Added.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@75966 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      d617a3b2
    • pfeldman@chromium.org's avatar
      2011-01-17 Pavel Feldman <pfeldman@chromium.org> · d55413b4
      pfeldman@chromium.org authored
              Not reviewed: skip flaky inspector test (will look at it tomorrow).
      
              * platform/mac-leopard/Skipped:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@75954 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      d55413b4
    • caseq@chromium.org's avatar
      2011-01-17 Andrey Kosyakov <caseq@chromium.org> · 0b0683cc
      caseq@chromium.org authored
              Reviewed by Pavel Feldman.
      
              Web Inspector: [Extensions API] webInspector.resources.onFinished is not fired for redirected resources
              Make resource start/finish hanlding more consistent.
              https://bugs.webkit.org/show_bug.cgi?id=52452
      
              * inspector/front-end/AuditLauncherView.js: Ignore WebSocket resources when displaying progress indicator
              (WebInspector.AuditLauncherView.prototype._resetResourceCount):
              (WebInspector.AuditLauncherView.prototype.resourceStarted):
              (WebInspector.AuditLauncherView.prototype.resourceFinished):
              * inspector/front-end/NetworkManager.js:
              (WebInspector.NetworkManager): Factor out resource start/finish logic to _startResource()/_finishResource()
              (WebInspector.NetworkManager.prototype.identifierForInitialRequest):
              (WebInspector.NetworkManager.prototype.willSendRequest):
              (WebInspector.NetworkManager.prototype.markResourceAsCached):
              (WebInspector.NetworkManager.prototype.didReceiveResponse):
              (WebInspector.NetworkManager.prototype.didReceiveContentLength):
              (WebInspector.NetworkManager.prototype.didFinishLoading):
              (WebInspector.NetworkManager.prototype.didFailLoading):
              (WebInspector.NetworkManager.prototype.didLoadResourceFromMemoryCache):
              (WebInspector.NetworkManager.prototype.didCreateWebSocket):
              (WebInspector.NetworkManager.prototype.willSendWebSocketHandshakeRequest):
              (WebInspector.NetworkManager.prototype.didReceiveWebSocketHandshakeResponse):
              (WebInspector.NetworkManager.prototype.didCloseWebSocket):
              (WebInspector.NetworkManager.prototype._appendRedirect):
              (WebInspector.NetworkManager.prototype._startResource):
              (WebInspector.NetworkManager.prototype._finishResource):
      
      2011-01-17  Andrey Kosyakov  <caseq@chromium.org>
      
              Reviewed by Pavel Feldman.
      
              Web Inspector: [Extensions API] webInspector.resources.onFinished is not fired for redirected resources
              Added test for finished event being sent for redirected resources.
              https://bugs.webkit.org/show_bug.cgi?id=52452
      
              * http/tests/inspector/extensions-resources-redirect-expected.txt:
              * http/tests/inspector/extensions-resources-redirect.html:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@75950 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      0b0683cc
    • pfeldman@chromium.org's avatar
      2011-01-17 Pavel Feldman <pfeldman@chromium.org> · 429bcf2c
      pfeldman@chromium.org authored
              Not reviewed: first timeline-network-resource flakiness.
      
              * inspector/timeline-network-resource.html:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@75947 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      429bcf2c
    • podivilov@chromium.org's avatar
      2011-01-17 Pavel Podivilov <podivilov@chromium.org> · 126363a4
      podivilov@chromium.org authored
              Reviewed by Yury Semikhatsky.
      
              Web Inspector: fix flaky debugger tests.
              https://bugs.webkit.org/show_bug.cgi?id=51320
      
              * http/tests/inspector/debugger-test2.js:
              (initialize_DebuggerTest.InspectorTest.setBreakpoint):
              * inspector/debugger-breakpoints-not-activated-on-reload.html:
              * inspector/debugger-pause-on-breakpoint-expected.txt:
              * inspector/debugger-pause-on-breakpoint.html:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@75943 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      126363a4