1. 04 Oct, 2006 15 commits
  2. 03 Oct, 2006 25 commits
    • hyatt's avatar
      Fix mac build bustage. · be71742c
      hyatt authored
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@16766 268f45cc-cd09-0410-ab3c-d52691b4dbfc
    • ap's avatar
      Reviewed by Tim H. · 7d6fd9e5
      ap authored
              Convert "undefined" to AE missing value
              * bridge/mac/WebCoreFrameBridge.mm:
              (aeDescFromJSValue): return missing value for UndefinedType.
              * fast/AppleScript/001-expected.txt:
              * fast/AppleScript/array-expected.txt:
              Updated the results.
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@16765 268f45cc-cd09-0410-ab3c-d52691b4dbfc
    • hyatt's avatar
      Scrolling work. · 45b37cda
      hyatt authored
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@16764 268f45cc-cd09-0410-ab3c-d52691b4dbfc
    • bdash's avatar
      2006-10-04 Mark Rowe <bdash@webkit.org> · 43bf1f0a
      bdash authored
              Reviewed by NOBODY (build fix).
              * WebView/WebView.m:
              (-[WebView scrollDOMRangeToVisible:]): Move scrollDOMRangeToVisible: into the correct category.
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@16763 268f45cc-cd09-0410-ab3c-d52691b4dbfc
    • bdash's avatar
      Update bug URLs in the two patches that I just landed. · 40ca6db0
      bdash authored
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@16762 268f45cc-cd09-0410-ab3c-d52691b4dbfc
    • bdash's avatar
      2006-09-26 David Smith <catfish.man@gmail.com> · 0a17c026
      bdash authored
              Reviewed by Timothy.
              Add -scrollDOMRangeToVisible:
              No automated tests are possible as this code path isn't reachable from JavaScript.
              * bridge/mac/WebCoreFrameBridge.h:
              * bridge/mac/WebCoreFrameBridge.mm:
              (-[WebCoreFrameBridge scrollDOMRangeToVisible:]):
      2006-09-26  David Smith  <catfish.man@gmail.com>
              Reviewed by Timothy.
              Add -scrollDOMRangeToVisible:
              * WebView/WebView.m:
              (-[WebView scrollDOMRangeToVisible:]):
              * WebView/WebViewPrivate.h:
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@16761 268f45cc-cd09-0410-ab3c-d52691b4dbfc
    • bdash's avatar
      2006-10-03 Graham Dennis <graham.dennis@gmail.com> · fb3f9561
      bdash authored
              Reviewed by Timothy.
              When contentEditable, cursor doesn't change to hand
              Allow the behaviour of editable links to be specified by a WebPreference
              The preference WebKitEditableLinkBehavior has four options:
               - AlwaysLive: Safari 2.0 behaviour
               - OnlyLiveWithShiftKey: Firefox/WinIE behaviour (and prior WebKit-ToT behaviour)
               - LiveWhenNotFocused: Editable links are live only when their editable block is not
                   focused, or when the shift key is pressed
               - DefaultBehavior: This is the same as OnlyLiveWithShiftKey.
              No layout tests, just a modification of a manual-test as it isn't possible to test
              this automatically.
              * bridge/mac/WebCoreSettings.h:
              * bridge/mac/WebCoreSettings.mm:
              (-[WebCoreSettings setEditableLinkBehavior:]):
              (-[WebCoreSettings editableLinkBehavior]):
              * html/HTMLAnchorElement.cpp:
              * html/HTMLAnchorElement.h:
              * manual-tests/contenteditable-link.html:
              * page/FrameView.cpp:
              * page/Settings.h:
      2006-10-03  Graham Dennis  <graham.dennis@gmail.com>
              Reviewed by Timothy.
              When contentEditable, cursor doesn't change to hand
              Allow the behaviour of editable links to be specified by a WebPreference
              The preference WebKitEditableLinkBehavior has four options:
               - AlwaysLive: Safari 2.0 behaviour
               - OnlyLiveWithShiftKey: Firefox/WinIE behaviour (and prior WebKit-ToT behaviour)
               - LiveWhenNotFocused: Editable links are live only when their editable block is not
                   focused, or when the shift key is pressed
               - DefaultBehavior: This is the same as OnlyLiveWithShiftKey.
              No layout tests, just a modification of a manual-test as it isn't possible to test
              this automatically.
              * WebView/WebPreferenceKeysPrivate.h:
              * WebView/WebPreferences.m:
              (+[WebPreferences initialize]):
              (-[WebPreferences editableLinkBehavior]):
              (-[WebPreferences setEditableLinkBehavior:]):
              * WebView/WebPreferencesPrivate.h:
              * WebView/WebView.m:
              (-[WebView _updateWebCoreSettingsFromPreferences:]):
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@16760 268f45cc-cd09-0410-ab3c-d52691b4dbfc
    • bdakin's avatar
      Reviewed Darin. · 9623e8d6
      bdakin authored
              No test cases needed.
              Implemented a version of StringImpl::append that takes a UChar* and 
              a length.
              * platform/StringImpl.cpp:
              (WebCore::StringImpl::insert): Call new append instead of making a 
              new StringImpl.
              * platform/StringImpl.h:
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@16759 268f45cc-cd09-0410-ab3c-d52691b4dbfc
    • andersca's avatar
      2006-10-03 Anders Carlsson <acarlsson@apple.com> · 231a03c1
      andersca authored
              Reviewed by Adam and Brady.
              * DumpRenderTree/DumpRenderTree.m:
              Update URL to Ahem.ttf
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@16758 268f45cc-cd09-0410-ab3c-d52691b4dbfc
    • bdash's avatar
      2006-10-03 MorganL <morganl.webkit@yahoo.com> · 2da2f6da
      bdash authored
              Reviewed by Darin.
              Fixes: http://bugs.webkit.org/show_bug.cgi?id=11099
              HttpSendRequestEx results in ERROR_HTTP_HEADER_NOT_FOUND
              * platform/win/ResourceLoaderWin.cpp:
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@16757 268f45cc-cd09-0410-ab3c-d52691b4dbfc
    • justing's avatar
      LayoutTests: · 6b59cee5
      justing authored
              Reviewed by harrison
              * editing/execCommand/paste-1-expected.checksum: Added.
              * editing/execCommand/paste-1-expected.png: Added.
              * editing/execCommand/paste-1-expected.txt: Added.
              * editing/execCommand/paste-1.html: Added.
              * editing/execCommand/paste-2-expected.checksum: Added.
              * editing/execCommand/paste-2-expected.png: Added.
              * editing/execCommand/paste-2-expected.txt: Added.
              * editing/execCommand/paste-2.html: Added.
              Reviewed by harrison
              execCommand("Cut"/"Copy"/"Paste") broken in editable subframes.
              * WebCoreSupport/WebFrameBridge.m:
              (-[WebFrameBridge issueCutCommand]): Issue the command on the WebHTMLView, not the WebView.
              (-[WebFrameBridge issueCopyCommand]): Ditto.
              (-[WebFrameBridge issuePasteCommand]): Ditto.
              (-[WebFrameBridge issuePasteAndMatchStyleCommand]): Ditto.
              (-[WebFrameBridge issueTransposeCommand]): Fixed formatting.
              (-[WebFrameBridge canPaste]): Ask the WebHTMLView, not the WebView.
              * WebView/WebHTMLView.m:
              (-[WebHTMLView copy:]): Moved to WebInternal
              (-[WebHTMLView cut:]): Ditto.
              (-[WebHTMLView paste:]): Ditto.
              (-[WebHTMLView pasteAsPlainText:]): Ditto.
              * WebView/WebHTMLViewInternal.h:
              * WebView/WebView.m: Removed the now unused _canPaste.
              * WebView/WebViewInternal.h: Ditto.
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@16752 268f45cc-cd09-0410-ab3c-d52691b4dbfc
    • bdakin's avatar
      Reviewed by Geoff. · 2630d92a
      bdakin authored
              Changing these two counters tests so they pass on the BuildBot.
              * fast/css/counters/counter04-expected.checksum:
              * fast/css/counters/counter04-expected.png:
              * fast/css/counters/counter04-expected.txt:
              * fast/css/counters/counter04.html:
              * fast/css/counters/counters04-expected.checksum:
              * fast/css/counters/counters04-expected.png:
              * fast/css/counters/counters04-expected.txt:
              * fast/css/counters/counters04.html:
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@16747 268f45cc-cd09-0410-ab3c-d52691b4dbfc
    • justing's avatar
      Reviewed by geoff · e1c0c1db
      justing authored
              Fixed a typo, updating expected results.
              * editing/execCommand/create-list-with-hr-expected.checksum:
              * editing/execCommand/create-list-with-hr-expected.png:
              * editing/execCommand/create-list-with-hr-expected.txt:
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@16746 268f45cc-cd09-0410-ab3c-d52691b4dbfc
    • ggaren's avatar
      Feared, loathed, reviewed by Darin. · 0cd3fe8a
      ggaren authored
              More frame/iframe merging. Merged IFRAME::willRemove and IFRAME::detach 
              into FRAME, plus other cleanup.
              No new behavior, so no new test. Layout tests pass. Basic browsing and
              Mail editing seem to work.
              * dom/Node.cpp:
              (WebCore::Node::detach): Removed random commented-out code.
              * html/HTMLFrameElement.cpp:
              (1) Removed reference to FrameView, to dissociate frame loading from rendering.
              (2) Renamed newURL to completeURL because the difference between newURL
              and URLString is that newURL is a KURL that is the complete version of URLString,
              not that it is new.
              (1) Removed close() call and moved close() code into willRemove(), also removing 
              close() call from detach(), since willRemove is the well-defined place 
              from DOM tear-down, not detach().
              (2) Removed manual renderer detach code because the DOM is not responsible
              for managing the render tree. I confirmed that this change not
              regress <rdar://problem/4132581>.
              (3) Removed questionable ASSERT. The ASSERT assumed that iframe elements
              lost their content frames after being removed from the DOM. That's our 
              current behavior, but it's going to change in future rounds of refactoring.
              This also fixes <rdar://problem/4750835>.
              (WebCore::HTMLFrameElement::setLocation): Removed wacky manual calls to
              attach/detach, because the render tree should not be in charge of deciding
              when to load.
              * html/HTMLFrameElement.h:
              * html/HTMLIFrameElement.cpp:
              (WebCore::HTMLIFrameElement::attach): Renamed renderPart to renderPartObject,
              because the renderer is a renderPartObject, not a renderPart.
              * html/HTMLIFrameElement.h:
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@16745 268f45cc-cd09-0410-ab3c-d52691b4dbfc
    • darin's avatar
      * Scripts/commit-log-editor: Added missing "close" call. Oops! · 6f2ed9b7
      darin authored
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@16744 268f45cc-cd09-0410-ab3c-d52691b4dbfc
    • bdash's avatar
      2006-10-03 Mark Rowe <bdash@webkit.org> · a5e25c4f
      bdash authored
              Reviewed by Mitz.
              Bug 11137: GdkLauncher dies with "pure virtual method called" if
              window is closed while page still loading
              * platform/gdk/FrameGdk.cpp:
              (WebCore::FrameGdk::~FrameGdk): Call cancelAndClear to allow virtual
              methods to be called before the FrameGdk portion of "this" is torn down.
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@16743 268f45cc-cd09-0410-ab3c-d52691b4dbfc
    • justing's avatar
      Reviewed by geoff · a858c2e3
      justing authored
              <rdar://problem/4763519> REGRESSION: Multipart/x-mixed-replace sub-resources fail to load
              * Loader/WebSubresourceLoader.m:
              (+[WebSubresourceLoader startLoadingResource:withRequest:customHeaders:referrer:forFrameLoader:]): 
              Enable multipart/x-mixed-replace support on the request.  This line was accidently removed during 
              some loader refactoring.
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@16742 268f45cc-cd09-0410-ab3c-d52691b4dbfc
    • aroben's avatar
      Reviewed by Darin. · b5b5841e
      aroben authored
              Handle tab key presses in the DOM.
              * dom/EventTargetNode.cpp:
              (WebCore::EventTargetNode::defaultEventHandler): Add tab key handling.
              * page/FrameView.cpp:
              (WebCore::FrameView::advanceFocus): Rename and reimplement
              focusNextPrevNode. Now we just call Element::focus().
              * page/FrameView.h: Rename focusNextPrevNode to advanceFocus and make
              it public.
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@16741 268f45cc-cd09-0410-ab3c-d52691b4dbfc
    • justing's avatar
      Reviewed by mjs · de22f921
      justing authored
              TOT REGRESSION: Repro assertion failure when forwarding draft in Range::compareBoundaryPoints
              No layout test possible, attributedStringFrom:(DOMNode*)...etc isn't available to DRT.
              * dom/Range.cpp:
              (WebCore::Range::boundaryPointsValid): compareBoundaryPoints asserts that the incoming 
              positions are non-null since most of it's callers would be in a bad state if the positions 
              were null.  boundaryPointsValid, which calls compareBoundaryPoints, is an exception.  
              Instead of removing the assert I've added nil checks in boundaryPointsValid, to keep it 
              from entering compareBoundaryPoints and hitting the assert.
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@16740 268f45cc-cd09-0410-ab3c-d52691b4dbfc
    • adele's avatar
      Reviewed by Geoff. · 02558203
      adele authored
              Make code for turning off new listbox implementation mac-only, since there's no implementation on other platforms.
              * html/HTMLSelectElement.cpp:
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@16739 268f45cc-cd09-0410-ab3c-d52691b4dbfc
    • darin's avatar
      2006-10-04 Darin Adler <darin@apple.com> · fd19bb38
      darin authored
              Reviewed by Geoff.
              - fix http://bugs.webkit.org/show_bug.cgi?id=11132
                Caret disappears when you're typing
              * editing/SelectionController.cpp:
              (WebCore::SelectionController::setSelection): Remove unnecessary call to
              clearCaretRectIfNeeded. The recomputeCaretRect now takes care of this.
              (WebCore::SelectionController::recomputeCaretRect): Explicitly set m_needsLayout
              to false so we can get the old caret repaint rect. Later we need to change the
              design so getting the rect doesn't have a side effect of causing a layout without
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@16738 268f45cc-cd09-0410-ab3c-d52691b4dbfc
    • harrison's avatar
      LayoutTests: · 01ad47aa
      harrison authored
              Reviewed by Maciej.
              <rdar://problem/4671286> Candidate Window isn't displayed and only first candidate is displayed at typing location.
              Updated test so that it actually shows the caret rect for the caret position.
              Before, it was showing the caret rect for the 9th character of the test description.
              * fast/text/justified-text-rect-expected.checksum:
              * fast/text/justified-text-rect-expected.png:
              * fast/text/justified-text-rect-expected.txt:
              * fast/text/justified-text-rect.html:
              Reviewed by Maciej.
              <rdar://problem/4671286> Candidate Window isn't displayed and only first candidate is displayed at typing location.
              Updated test:
              * fast/text/justified-text-rect.html
              * bridge/mac/WebCoreFrameBridge.mm:
              (-[WebCoreFrameBridge convertToNSRange:]):
              (-[WebCoreFrameBridge convertToDOMRange:]):
              Make the selection's root editable element (or the document itself) be
              the basis for NSRange conversions. This supports "shadow DOM" like
              that for text fields and text areas.
              * editing/CompositeEditCommand.cpp:
              Pass the document element as the scope.
              * editing/TextIterator.cpp:
              Make the first parameter the scope.
              * editing/TextIterator.h:
              Make the first parameter of rangeFromLocationAndLength() the scope.
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@16737 268f45cc-cd09-0410-ab3c-d52691b4dbfc
    • eseidel's avatar
      2006-10-03 Nikolas Zimmermann <zimmermann@kde.org> · 54b6b95a
      eseidel authored
              Reviewed by eseidel.  Landed by eseidel.
              Offer a way for BuildBot to not colorize the cmake output, when building
              with the 'build-webkit' script. Add "--color" / "--no-color" option pair.
              Default is colorize output, though only Qt platform handles this for now.
              * Scripts/build-dumprendertree:
              * Scripts/build-webkit:
              * Scripts/webkitdirs.pm:
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@16736 268f45cc-cd09-0410-ab3c-d52691b4dbfc
    • eseidel's avatar
      2006-10-03 Nikolas Zimmermann <zimmermann@kde.org> · 3b0d9c94
      eseidel authored
              Reviewed by eseidel.  Landed by eseidel.
              Make all important scripts work with Qt/Linux.
              You can safely use this now:
              set-configuration-release --debug && build-webkit && run-javascriptcore-tests && run-webkit-tests
              * Scripts/build-dumprendertree:
              * Scripts/run-javascriptcore-tests:
              * Scripts/run-webkit-tests:
              * Scripts/webkitdirs.pm:
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@16735 268f45cc-cd09-0410-ab3c-d52691b4dbfc
    • bdash's avatar
      2006-10-03 Nikolas Zimmermann <zimmermann@kde.org> · f0bb10da
      bdash authored
              Reviewed by Eric.
              build-webkit tweak: Use WebKitBuild/$config as output dir (Release/Debug).
              * Scripts/webkitdirs.pm:
      2006-10-03  Nikolas Zimmermann  <zimmermann@kde.org>
              Reviewed by Eric.
              Fix Qt/Linux build.
              * CMakeLists.txt: Add counter related files.
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@16734 268f45cc-cd09-0410-ab3c-d52691b4dbfc