1. 14 Nov, 2013 33 commits
    • mitz@apple.com's avatar
      [Cocoa] WKAction keys are not exported · 4617b9e6
      mitz@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=124378
      
      Reviewed by Anders Carlsson.
      
      * UIProcess/API/mac/WKBrowsingContextController.mm: Made the keys constant pointers.
      * UIProcess/API/mac/WKBrowsingContextPolicyDelegate.h: Exported the keys.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@159309 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      4617b9e6
    • commit-queue@webkit.org's avatar
      Web Inspector: Simply generated domain dispatch methods for domains with few commands · 416e3e9d
      commit-queue@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=124374
      
      Patch by Joseph Pecoraro <pecoraro@apple.com> on 2013-11-14
      Reviewed by Timothy Hatcher.
      
      * inspector/CodeGeneratorInspector.py:
      (Generator.go):
      (Generator.process_command):
      * inspector/CodeGeneratorInspectorStrings.py:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@159308 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      416e3e9d
    • betravis@adobe.com's avatar
      [CSS Shapes] Accept the new <box> value for shape-outside · edfb6516
      betravis@adobe.com authored
      https://bugs.webkit.org/show_bug.cgi?id=124227
      
      Reviewed by David Hyatt.
      
      Source/WebCore:
      
      The shape-outside property can now be set to the box values [margin/border/padding/content]-box.
      This patch adds the parsing code required to accept the new values, and the layout code
      to create a rectangle shape that has the size and position of the appropriate box.
      
      Tests: fast/shapes/shape-outside-floats/shape-outside-boxes-001.html
             fast/shapes/shape-outside-floats/shape-outside-boxes-002.html
             fast/shapes/shape-outside-floats/shape-outside-boxes-003.html
      
      * css/CSSComputedStyleDeclaration.cpp:
      (WebCore::ComputedStyleExtractor::propertyValue): Output the new box values.
      * css/CSSParser.cpp:
      (WebCore::CSSParser::parseValue): Accept the new box values.
      * css/CSSValueKeywords.in: Add margin-box value.
      * css/DeprecatedStyleBuilder.cpp:
      (WebCore::ApplyPropertyShape::applyValue): Accept the new box values.
      * rendering/RenderBoxModelObject.h:
      (WebCore::RenderBoxModelObject::borderLogicalWidth): Added new utility methods to help
      with box sizing.
      (WebCore::RenderBoxModelObject::borderLogicalHeight): Ditto.
      (WebCore::RenderBoxModelObject::paddingLogicalWidth): Ditto.
      (WebCore::RenderBoxModelObject::paddingLogicalHeight): Ditto.
      * rendering/shapes/Shape.cpp:
      (WebCore::Shape::createShape): You can create a shape from a box's dimensions, rather
      than always using a BasicShape or RasterShape value.
      * rendering/shapes/Shape.h:
      * rendering/shapes/ShapeInfo.cpp:
      (WebCore::::computedShape): Create the appropriate shape based on the box values.
      * rendering/shapes/ShapeInfo.h:
      (WebCore::ShapeInfo::setShapeSize): Adjust for the box size when using a box value.
      (WebCore::ShapeInfo::logicalTopOffset): Ditto.
      (WebCore::ShapeInfo::logicalLeftOffset): Ditto.
      * rendering/shapes/ShapeInsideInfo.cpp:
      (WebCore::ShapeInsideInfo::isEnabledFor): Enable for the box values.
      * rendering/shapes/ShapeOutsideInfo.cpp:
      (WebCore::ShapeOutsideInfo::isEnabledFor): Disable for shape-inside.
      * rendering/style/ShapeValue.h:
      (WebCore::ShapeValue::createBoxValue): Create the appropriate shape value for a box.
      (WebCore::ShapeValue::box): Return the box value for this ShapeValue.
      (WebCore::ShapeValue::ShapeValue): Create a ShapeValue from a box value.
      
      LayoutTests:
      
      Test the different box values with different writing modes.
      
      * fast/shapes/parsing/parsing-shape-inside-expected.html: Adding box values as invalid.
      * fast/shapes/parsing/parsing-shape-inside.html: Ditto.
      * fast/shapes/parsing/parsing-shape-outside-expected.html: Adding box values as valid.
      * fast/shapes/parsing/parsing-shape-outside.html: Ditto.
      * fast/shapes/shape-outside-floats/shape-outside-boxes-001-expected.html: Added.
      * fast/shapes/shape-outside-floats/shape-outside-boxes-001.html: Added.
      * fast/shapes/shape-outside-floats/shape-outside-boxes-002-expected.html: Added.
      * fast/shapes/shape-outside-floats/shape-outside-boxes-002.html: Added.
      * fast/shapes/shape-outside-floats/shape-outside-boxes-003-expected.html: Added.
      * fast/shapes/shape-outside-floats/shape-outside-boxes-003.html: Added.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@159307 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      edfb6516
    • jer.noble@apple.com's avatar
      Flaky Test: media/video-fast-seek.html · 61593d79
      jer.noble@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=124298
      
      Reviewed by Eric Carlson.
      
      Don't check for the precise results of currentTime, as MediaTime -> double
      rounding will occasionally result in errors.
      
      * media/video-fast-seek-expected.txt:
      * media/video-fast-seek.html:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@159306 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      61593d79
    • andersca@apple.com's avatar
      Stop using deprecated NSPropertyListSerialization methods · 831bbe53
      andersca@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=124377
      
      Reviewed by Mark Rowe.
      
      * History/WebHistory.mm:
      (-[WebHistoryPrivate loadHistoryGutsFromURL:savedItemsCount:collectDiscardedItemsInto:error:]):
      * Plugins/Hosted/NetscapePluginHostManager.mm:
      (WebKit::NetscapePluginHostManager::spawnPluginHost):
      (WebKit::NetscapePluginHostManager::instantiatePlugin):
      * Plugins/Hosted/NetscapePluginHostProxy.mm:
      (WKPCIdentifierInfo):
      * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
      (WebKit::NetscapePluginInstanceProxy::enumerate):
      (WebKit::NetscapePluginInstanceProxy::marshalValue):
      (WebKit::NetscapePluginInstanceProxy::marshalValues):
      (WebKit::NetscapePluginInstanceProxy::demarshalValue):
      (WebKit::NetscapePluginInstanceProxy::demarshalValues):
      * Plugins/Hosted/ProxyInstance.mm:
      (WebKit::ProxyInstance::getPropertyNames):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@159305 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      831bbe53
    • timothy_horton@apple.com's avatar
      fullscreen/anonymous-block-merge-crash.html often times out in WebKit1 · f6b179b7
      timothy_horton@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=124318
      
      * platform/mac/TestExpectations:
      Used the wrong kind of failure for a notifyDone timeout.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@159304 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      f6b179b7
    • bdakin@apple.com's avatar
      Rubber-stamped by Tim Horton. · 079d6fd7
      bdakin@apple.com authored
      Post-checkin review comment! StickToViewportBounds sounds better and more accurate 
      than StickToWindowBounds.
      
      * platform/ScrollTypes.h:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@159303 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      079d6fd7
    • bfulgham@apple.com's avatar
      Unreviewed build failure; update MediaPlayerPrivateAVFFoundationCF::seekToTime after r159208. · 4d1ad22f
      bfulgham@apple.com authored
      After r159208, seekToTime takes tolerance parameters.
      
      Patch by Jer Noble <jer.noble@apple.com> on 2013-11-13
      
      * platform/graphics/avfoundation/cf/MediaPlayerPrivateAVFoundationCF.cpp:
      (WebCore::MediaPlayerPrivateAVFoundationCF::seekToTime):
      (WebCore::AVFWrapper::seekToTime):
      * platform/graphics/avfoundation/cf/MediaPlayerPrivateAVFoundationCF.h:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@159302 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      4d1ad22f
    • timothy_horton@apple.com's avatar
      http/tests/security/frameNavigation/xss-DENIED-plugin-navigation.html is slow,... · 7cfe8de7
      timothy_horton@apple.com authored
      http/tests/security/frameNavigation/xss-DENIED-plugin-navigation.html is slow, frequently > 30 second timeout
      https://bugs.webkit.org/show_bug.cgi?id=124373
      
      * platform/mac/TestExpectations:
      Mark test as slow on Mountain Lion Release bot.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@159301 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      7cfe8de7
    • bdakin@apple.com's avatar
      Add a new mode where fixed elements don't constrain their positions during a · 817d70e7
      bdakin@apple.com authored
      rubber band
      https://bugs.webkit.org/show_bug.cgi?id=124260
      
      Reviewed by Tim Horton.
      
      This patch adds a new enum called ScrollBehaviorForFixedElements, which has
      two values, StickToDocumentBounds or StickToWindowBounds. StickToDocumentBounds 
      corresponds to our current behavior, where fixed elements constrain 
      their positions during a rubber-band so that they stay stuck to the document.
      The new mode, StickToWindowBounds, will cause fixed elements to always stay
      fixed relative to the window.
      
      scrollOffsetForFixedPosition() now takes a new parameter for the fixed behavior
      so that it knows whether or not to constrain the position.
      * page/FrameView.cpp:
      (WebCore::FrameView::scrollOffsetForFixedPosition):
              
      Right now, just return StickToDocumentBounds and retain existing behavior.
      (WebCore::FrameView::scrollBehaviorForFixedElements):
      * page/FrameView.h:
      
      The scrolling thread needs to know about the fixed element scroll behavior,
      so this code makes ScrollingStateScrollingNodes keep track of that 
      information to pass over to the scrolling thread.
      * page/scrolling/ScrollingStateScrollingNode.cpp:
      (WebCore::ScrollingStateScrollingNode::ScrollingStateScrollingNode):
      (WebCore::ScrollingStateScrollingNode::setScrollBehaviorForFixedElements):
      * page/scrolling/ScrollingStateScrollingNode.h:
      * page/scrolling/ScrollingTreeScrollingNode.cpp:
      (WebCore::ScrollingTreeScrollingNode::ScrollingTreeScrollingNode):
      (WebCore::ScrollingTreeScrollingNode::updateBeforeChildren):
      * page/scrolling/ScrollingTreeScrollingNode.h:
      (WebCore::ScrollingTreeScrollingNode::scrollBehaviorForFixedElements):
      * page/scrolling/mac/ScrollingCoordinatorMac.h:
      * page/scrolling/mac/ScrollingCoordinatorMac.mm:
      (WebCore::ScrollingCoordinatorMac::frameViewRootLayerDidChange):
      (WebCore::ScrollingCoordinatorMac::setScrollBehaviorForFixedElementsForNode):
      * page/scrolling/mac/ScrollingTreeScrollingNodeMac.mm:
      (WebCore::ScrollingTreeScrollingNodeMac::setScrollLayerPosition):
              
      Here is the new enum.
      * platform/ScrollTypes.h:
              
      Another place where we only want to constrain scroll position if that is the
      mode we are in.
      * rendering/RenderLayerCompositor.cpp:
      (WebCore::RenderLayerCompositor::customPositionForVisibleRectComputation):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@159300 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      817d70e7
    • ap@apple.com's avatar
      [Mac] HMAC sign/verify crashes when key is empty · 46bab23a
      ap@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=124372
      
      Reviewed by Sam Weinig.
      
      Source/WebCore: 
      
      Test: crypto/subtle/hmac-sign-verify-empty-key.html
      
      * crypto/mac/CryptoAlgorithmHMACMac.cpp: (WebCore::calculateSignature): Give it
      a non-null pointer then.
      
      LayoutTests: 
      
      * crypto/subtle/hmac-sign-verify-empty-key-expected.txt: Added.
      * crypto/subtle/hmac-sign-verify-empty-key.html: Added.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@159299 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      46bab23a
    • msaboff@apple.com's avatar
      REGRESSION (r159276): Fix lots of crashes for arm_traditional architecture. · f4bf72dc
      msaboff@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=124365
      
      Reviewed by Oliver Hunt.
      
      Crashes were caused by a mixup between regular registers and temporary registers in ARM_EXTRA_GPRS.
      
      * llint/LowLevelInterpreter32_64.asm: Warning, t3 != a3. It's safer to use an implementation using aX
      registers like the MIPS one for cCallX macros.
      * offlineasm/arm.rb: Rearrange ARM_EXTRA_GPRS according to the new register distribution in LLINT.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@159298 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      f4bf72dc
    • andersca@apple.com's avatar
      Remove duplicate entry. · 4986631c
      andersca@apple.com authored
      * Scripts/webkitpy/common/config/contributors.json:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@159297 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      4986631c
    • ap@apple.com's avatar
      Implement RSASSA-PKCS1-v1_5 sign/verify · 2062a132
      ap@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=124335
      
      Build fix.
      
      * crypto/CryptoAlgorithmRSASSA_PKCS1_v1_5Mac.cpp:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@159296 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      2062a132
    • samuel_white@apple.com's avatar
      AX: Calling NSAccessibilityColumnsAttribute and NSAccessibilityRowsAttribute... · 6c469be7
      samuel_white@apple.com authored
      AX: Calling NSAccessibilityColumnsAttribute and NSAccessibilityRowsAttribute simply to get column/row count can be very expensive.
      https://bugs.webkit.org/show_bug.cgi?id=124293
      
      Reviewed by Chris Fleizach.
      
      Source/WebCore:
      
      Added ability to get accessibility table column or row count without fetching all columns or rows.
      
      Test: platform/mac/accessibility/table-column-and-row-count.html
      
      * accessibility/mac/WebAccessibilityObjectWrapperMac.mm:
      (-[WebAccessibilityObjectWrapper accessibilityAttributeNames]):
      (-[WebAccessibilityObjectWrapper accessibilityAttributeValue:]):
      
      LayoutTests:
      
      Added test to ensure NSAccessibilityColumnsAttribute and NSAccessibilityRowsAttribute
      behave as expected. Also updated existing table tests to reflect this additional API.
      
      * platform/mac/accessibility/table-column-and-row-count-expected.txt: Added.
      * platform/mac/accessibility/table-column-and-row-count.html: Added.
      * platform/mac/accessibility/table-detection-expected.txt:
      * platform/mac/accessibility/table-with-rules-expected.txt:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@159295 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      6c469be7
    • lforschler@apple.com's avatar
      Versioning. · f27addbc
      lforschler@apple.com authored
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@159294 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      f27addbc
    • ap@apple.com's avatar
      Implement RSASSA-PKCS1-v1_5 sign/verify · cbf00156
      ap@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=124335
      
      Reviewed by Sam Weinig.
      
      Source/WebCore:
      
      Test: crypto/subtle/rsassa-pkcs1-v1_5-sign-verify.html
      
      * WebCore.xcodeproj/project.pbxproj: Added new files, removed Mac SHA algorithm files.
      
      * crypto/CryptoAlgorithmRSASSA_PKCS1_v1_5Mac.cpp:
      (WebCore::getCommonCryptoDigestAlgorithm):
      (WebCore::CryptoAlgorithmRSASSA_PKCS1_v1_5::sign):
      (WebCore::CryptoAlgorithmRSASSA_PKCS1_v1_5::verify):
      Implemented. These take two steps, first a digest is computed, and then it's signed.
      
      * crypto/CryptoDigest.h: Added.
      * crypto/mac/CryptoDigestMac.cpp: Added.
      (WebCore::CryptoDigest::CryptoDigest):
      (WebCore::CryptoDigest::~CryptoDigest):
      (WebCore::CryptoDigest::create):
      (WebCore::CryptoDigest::addBytes):
      (WebCore::CryptoDigest::computeHash):
      Added a cross-platform interface and Mac implementation to compute a digest. It
      should be possible to use it outside WebCrypto if we need to (perhaps even merge
      with  WTF SHA-1 class).
      The Mac implementation is kind of ugly, but at least it encapsulates the ugliness.
      
      * crypto/algorithms/CryptoAlgorithmSHA1.cpp: (WebCore::CryptoAlgorithmSHA1::digest):
      * crypto/algorithms/CryptoAlgorithmSHA224.cpp: (WebCore::CryptoAlgorithmSHA224::digest):
      * crypto/algorithms/CryptoAlgorithmSHA256.cpp: (WebCore::CryptoAlgorithmSHA256::digest):
      * crypto/algorithms/CryptoAlgorithmSHA384.cpp: (WebCore::CryptoAlgorithmSHA384::digest):
      * crypto/algorithms/CryptoAlgorithmSHA512.cpp: (WebCore::CryptoAlgorithmSHA512::digest):
      * crypto/mac/CryptoAlgorithmSHA1Mac.cpp: Removed.
      * crypto/mac/CryptoAlgorithmSHA224Mac.cpp: Removed.
      * crypto/mac/CryptoAlgorithmSHA256Mac.cpp: Removed.
      * crypto/mac/CryptoAlgorithmSHA384Mac.cpp: Removed.
      * crypto/mac/CryptoAlgorithmSHA512Mac.cpp: Removed.
      These are all cross-platform now.
      
      LayoutTests:
      
      * crypto/subtle/rsassa-pkcs1-v1_5-sign-verify-expected.txt: Added.
      * crypto/subtle/rsassa-pkcs1-v1_5-sign-verify.html: Added.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@159292 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      cbf00156
    • hmuller@adobe.com's avatar
      [CSS Shapes] Empty polygons with non-zero shape-padding cause an ASSERT crash · ae389127
      hmuller@adobe.com authored
      https://bugs.webkit.org/show_bug.cgi?id=124324
      
      Reviewed by Andreas Kling.
      
      Source/WebCore:
      
      PolygonShape::shapePaddingBounds() and PolygonShape::shapeMarginBounds() no
      longer attempt to compute a new FloatPolygon when the original is empty, i.e.
      when it has less than three vertices.
      
      Tests: fast/shapes/shape-inside/shape-inside-empty-polygon-crash.html
             fast/shapes/shape-outside-floats/shape-outside-floats-empty-polygon-crash.html
      
      * rendering/shapes/PolygonShape.cpp:
      (WebCore::PolygonShape::shapePaddingBounds): Don't compute a padding FloatPolygon if the original polygon is empty.
      (WebCore::PolygonShape::shapeMarginBounds): Don't compute a margin FloatPolygon if the original polygon is empty.
      
      LayoutTests:
      
      * fast/shapes/shape-inside/shape-inside-empty-polygon-crash-expected.txt: Added.
      * fast/shapes/shape-inside/shape-inside-empty-polygon-crash.html: Added.
      * fast/shapes/shape-outside-floats/shape-outside-floats-empty-polygon-crash-expected.txt: Added.
      * fast/shapes/shape-outside-floats/shape-outside-floats-empty-polygon-crash.html: Added.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@159291 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      ae389127
    • msaboff@apple.com's avatar
      REGRESSION (r159276): rbp register overwritten in Win 64 version of callToJavascript stub · bc79936b
      msaboff@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=124361
      
      Reviewed by Oliver Hunt.
      
      Swapped operand ordering to: mov rax, rbp
      
      * jit/JITStubsMSVC64.asm:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@159290 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      bc79936b
    • commit-queue@webkit.org's avatar
      Web Inspector: Cleaner Backend Method Calling Code Generation · 7e377a59
      commit-queue@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=124333
      
      Patch by Joseph Pecoraro <pecoraro@apple.com> on 2013-11-14
      Reviewed by Timothy Hatcher.
      
      No change in functionality, just improved generated code.
      
      * inspector/CodeGeneratorInspector.py:
      (Generator.process_command):
      * inspector/CodeGeneratorInspectorStrings.py:
      * inspector/InspectorBackendDispatcher.cpp:
      * inspector/InspectorBackendDispatcher.h:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@159289 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      7e377a59
    • commit-queue@webkit.org's avatar
      REGRESSION (r159276): Fix lots of crashes for sh4 architecture. · ea3fae7b
      commit-queue@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=124347
      
      Patch by Julien Brianceau <jbriance@cisco.com> on 2013-11-14
      Reviewed by Michael Saboff.
      
      Since r159276, we have (t4 == a0 == r4) and (t5 == a1 == r5) in LLINT for sh4.
      This leads to argument register trampling in cCallX macros, especially with cCall2
      macro when arg1 == t4.
      
      * llint/LowLevelInterpreter32_64.asm: Use a new "setargs" pseudo-op to setup arguments for sh4.
      * offlineasm/instructions.rb:
      * offlineasm/sh4.rb: Lower "setargs" pseudo-op to setup argument registers and prevent register trampling issues.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@159288 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      ea3fae7b
    • commit-queue@webkit.org's avatar
      [ATK] Change WKTR/DRT AX methods to use nullptr · a1caebad
      commit-queue@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=124352
      
      Patch by Krzysztof Czech <k.czech@samsung.com> on 2013-11-14
      Reviewed by Anders Carlsson.
      
      Change WKTR/DRT accessibility related methods to use nullptr.
      
      * DumpRenderTree/atk/AccessibilityControllerAtk.cpp:
      (AccessibilityController::AccessibilityController):
      (AccessibilityController::elementAtPoint):
      (AccessibilityController::removeNotificationListener):
      (AccessibilityController::childElementById):
      * DumpRenderTree/atk/AccessibilityNotificationHandlerAtk.cpp:
      (AccessibilityNotificationHandler::AccessibilityNotificationHandler):
      * DumpRenderTree/atk/AccessibilityUIElementAtk.cpp:
      (AccessibilityUIElement::elementAtPoint):
      (AccessibilityUIElement::linkedUIElementAtIndex):
      (AccessibilityUIElement::getChildAtIndex):
      (AccessibilityUIElement::titleUIElement):
      (AccessibilityUIElement::parentElement):
      (AccessibilityUIElement::subrole):
      (AccessibilityUIElement::roleDescription):
      (AccessibilityUIElement::orientation):
      (AccessibilityUIElement::ariaDropEffects):
      (AccessibilityUIElement::uiElementForSearchPredicate):
      (AccessibilityUIElement::cellForColumnAndRow):
      (AccessibilityUIElement::disclosedRowAtIndex):
      (AccessibilityUIElement::ariaOwnsElementAtIndex):
      (AccessibilityUIElement::ariaFlowToElementAtIndex):
      (AccessibilityUIElement::selectedRowAtIndex):
      (AccessibilityUIElement::rowAtIndex):
      (AccessibilityUIElement::disclosedByRow):
      (AccessibilityUIElement::removeNotificationListener):
      (AccessibilityUIElement::classList):
      * WebKitTestRunner/InjectedBundle/atk/AccessibilityControllerAtk.cpp:
      (WTR::AccessibilityController::logAccessibilityEvents):
      (WTR::AccessibilityController::resetToConsistentState):
      (WTR::childElementById):
      (WTR::AccessibilityController::accessibleElementById):
      (WTR::AccessibilityController::removeNotificationListener):
      * WebKitTestRunner/InjectedBundle/atk/AccessibilityNotificationHandlerAtk.cpp:
      (WTR::AccessibilityNotificationHandler::setNotificationFunctionCallback):
      (WTR::AccessibilityNotificationHandler::removeAccessibilityNotificationHandler):
      * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
      (WTR::AccessibilityUIElement::elementAtPoint):
      (WTR::AccessibilityUIElement::childAtIndex):
      (WTR::AccessibilityUIElement::linkedUIElementAtIndex):
      (WTR::AccessibilityUIElement::ariaOwnsElementAtIndex):
      (WTR::AccessibilityUIElement::ariaFlowToElementAtIndex):
      (WTR::AccessibilityUIElement::disclosedRowAtIndex):
      (WTR::AccessibilityUIElement::rowAtIndex):
      (WTR::AccessibilityUIElement::selectedChildAtIndex):
      (WTR::AccessibilityUIElement::selectedRowAtIndex):
      (WTR::AccessibilityUIElement::titleUIElement):
      (WTR::AccessibilityUIElement::parentElement):
      (WTR::AccessibilityUIElement::disclosedByRow):
      (WTR::AccessibilityUIElement::uiElementAttributeValue):
      (WTR::AccessibilityUIElement::orientation):
      (WTR::AccessibilityUIElement::uiElementForSearchPredicate):
      (WTR::AccessibilityUIElement::cellForColumnAndRow):
      (WTR::AccessibilityUIElement::horizontalScrollbar):
      (WTR::AccessibilityUIElement::verticalScrollbar):
      (WTR::AccessibilityUIElement::removeNotificationListener):
      (WTR::AccessibilityUIElement::textMarkerRangeForElement):
      (WTR::AccessibilityUIElement::previousTextMarker):
      (WTR::AccessibilityUIElement::nextTextMarker):
      (WTR::AccessibilityUIElement::textMarkerRangeForMarkers):
      (WTR::AccessibilityUIElement::startTextMarkerForTextMarkerRange):
      (WTR::AccessibilityUIElement::endTextMarkerForTextMarkerRange):
      (WTR::AccessibilityUIElement::endTextMarkerForBounds):
      (WTR::AccessibilityUIElement::startTextMarkerForBounds):
      (WTR::AccessibilityUIElement::textMarkerForPoint):
      (WTR::AccessibilityUIElement::accessibilityElementForTextMarker):
      (WTR::AccessibilityUIElement::textMarkerForIndex):
      (WTR::AccessibilityUIElement::supportedActions):
      (WTR::AccessibilityUIElement::pathDescription):
      (WTR::AccessibilityUIElement::mathPostscriptsDescription):
      (WTR::AccessibilityUIElement::mathPrescriptsDescription):
      (WTR::AccessibilityUIElement::classList):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@159287 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      a1caebad
    • graouts@apple.com's avatar
      Web Inspector: Popovers may shrink unnecessarily · a78bbcde
      graouts@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=124350
      
      Reviewed by Timothy Hatcher.
      
      Because we always get the intersection of the preferred frame and the container frame to
      ensure the popover fits within its container based on a preferred frame that would place
      the arrow within the center of the attachment edge, we get in situations where we may
      shrink the popover instead of shifting it to fit within the container frame. We now first
      shift the preferred frame before getting its intersection with the container frame to
      avoid such situations.
      
      * UserInterface/Popover.js:
      (WebInspector.Popover.prototype._bestMetricsForEdge):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@159286 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      a78bbcde
    • commit-queue@webkit.org's avatar
      run-perf-tests should warn loudly if you're using a Debug build. · b63a0aef
      commit-queue@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=105236
      
      Patch by Éva Balázsfalvi <balazsfalvi.eva@stud.u-szeged.hu> on 2013-11-14
      Reviewed by Csaba Osztrogonác.
      
      * Scripts/webkitpy/performance_tests/perftestsrunner.py:
      (PerfTestsRunner.run):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@159285 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      b63a0aef
    • seokju@webkit.org's avatar
      Use [ImplementedAs=defaultStatus] for Window.defaultstatus · b2e4bfca
      seokju@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=124334
      
      Reviewed by Christophe Dumez.
      
      No new tests, this is just refactoring.
      
      Use [ImplementedAs=defaultStatus] for Window.defaultstatus
      and remove unnecessary code from DOMWindow.
      Because 'defaultstatus' is an alias of defaultStatus.
      
      * page/DOMWindow.h:
      * page/DOMWindow.idl:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@159284 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      b2e4bfca
    • commit-queue@webkit.org's avatar
      Fix build for sh4 architectures (broken since r159276). · 1886381f
      commit-queue@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=124344
      
      Patch by Julien Brianceau <jbriance@cisco.com> on 2013-11-14
      Reviewed by Csaba Osztrogonác.
      
      * offlineasm/sh4.rb: There is no fp alias for r14 register for sh4.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@159283 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      1886381f
    • commit-queue@webkit.org's avatar
      Fix Tools/Scripts/webkitpy/port/factory.py --help to display which configuration is default · 7104b695
      commit-queue@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=124143
      
      Patch by Éva Balázsfalvi <balazsfalvi.eva@stud.u-szeged.hu> on 2013-11-14
      Reviewed by Csaba Osztrogonác.
      
      * Scripts/webkitpy/port/factory.py:
      (configuration_options):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@159282 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      7104b695
    • gyuyoung.kim@samsung.com's avatar
      Generate toSVGPolyline|gonElement() to replace static_cast<> · d9284ee2
      gyuyoung.kim@samsung.com authored
      https://bugs.webkit.org/show_bug.cgi?id=124341
      
      Reviewed by Andreas Kling.
      
      toSVGFoo() supports more plenty helper functions. So, toSVGFoo() needs
      to be used instead of static_cast<>.
      
      Additionally, cleanup other static_cast<> as well.
      
      No new tests, no behavior changes.
      
      * rendering/svg/SVGPathData.cpp:
      (WebCore::updatePathFromEllipseElement):
      (WebCore::updatePathFromLineElement):
      (WebCore::updatePathFromPolygonElement):
      (WebCore::updatePathFromPolylineElement):
      * svg/SVGPolygonElement.h:
      * svg/SVGPolylineElement.h:
      * svg/svgtags.in: Add *generateTypeHelpers* keyword to polygon, polyline
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@159281 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      d9284ee2
    • commit-queue@webkit.org's avatar
      [EFL] Layout tests with text areas need to be rebaselined. · 58f400b0
      commit-queue@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=124337
      
      Unreviewed, EFL gatdening.
      
      EFL text areas rebaselined after r129492.
      
      Patch by Sun-woo Nam <sunny.nam@samsung.com> on 2013-11-14
      
      * platform/efl/TestExpectations:
      * platform/efl/fast/forms/basic-textareas-expected.txt:
      * platform/efl/fast/forms/basic-textareas-quirks-expected.txt:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@159280 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      58f400b0
    • akling@apple.com's avatar
      FontDescription copies should share families list, not duplicate it. · f4dbca39
      akling@apple.com authored
      <https://webkit.org/b/124338>
      
      Source/WebCore:
      
      Turn FontDescription::m_families into a RefCountedArray<AtomicString>
      instead of a Vector<AtomicString, 1>. This allows FontDescription to
      share the families list between copies, instead of each object having
      its own Vector.
      
      Also, FontDescription itself shrinks by 16 bytes.
      
      Reviewed by Antti Koivisto.
      
      Source/WTF:
      
      Add RefCountedArray::operator==.
      
      Reviewed by Antti Koivisto.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@159279 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      f4dbca39
    • ryuan.choi@samsung.com's avatar
      [WK2] Move Coordinated Graphics related code out of DrawingAreaProxy · 0cde9237
      ryuan.choi@samsung.com authored
      https://bugs.webkit.org/show_bug.cgi?id=124328
      
      Reviewed by Andreas Kling.
      
      Refactored for DrawingAreaProxy not to include Coordinated Graphics specific code.
      
      * PlatformEfl.cmake:
      * UIProcess/CoordinatedGraphics/CoordinatedDrawingAreaProxy.cpp: Moved from DrawingAreaProxy.cpp.
      (WebKit::CoordinatedDrawingAreaProxy::updateViewport):
      (WebKit::CoordinatedDrawingAreaProxy::contentsRect):
      * UIProcess/CoordinatedGraphics/CoordinatedDrawingAreaProxy.h: Ditto.
      (WebKit::CoordinatedDrawingAreaProxy::coordinatedLayerTreeHostProxy): Refactored to return reference instead of pointer.
      (WebKit::CoordinatedDrawingAreaProxy::viewportVisibleRect):
      (WebKit::CoordinatedDrawingAreaProxy::page):
      * UIProcess/CoordinatedGraphics/CoordinatedLayerTreeHostProxy.cpp:
      (WebKit::CoordinatedLayerTreeHostProxy::CoordinatedLayerTreeHostProxy):
      * UIProcess/CoordinatedGraphics/CoordinatedLayerTreeHostProxy.h:
      * UIProcess/CoordinatedGraphics/PageViewportController.cpp:
      Renamed from Source/WebKit2/UIProcess/PageViewportController.cpp because it depends on Coordinated Graphics.
      (WebKit::fuzzyCompare):
      (WebKit::PageViewportController::PageViewportController):
      (WebKit::PageViewportController::innerBoundedViewportScale):
      (WebKit::PageViewportController::outerBoundedViewportScale):
      (WebKit::PageViewportController::deviceScaleFactor):
      (WebKit::isIntegral):
      (WebKit::PageViewportController::pixelAlignedFloatPoint):
      (WebKit::PageViewportController::boundContentsPositionAtScale):
      (WebKit::PageViewportController::boundContentsPosition):
      (WebKit::PageViewportController::didCommitLoad):
      (WebKit::PageViewportController::didChangeContentsSize):
      (WebKit::PageViewportController::didRenderFrame):
      (WebKit::PageViewportController::pageTransitionViewportReady):
      (WebKit::PageViewportController::pageDidRequestScroll):
      (WebKit::PageViewportController::didChangeViewportSize):
      (WebKit::PageViewportController::didChangeContentsVisibility):
      (WebKit::PageViewportController::syncVisibleContents): Added cast to access CoordinatedDrawingAreaProxy method.
      (WebKit::PageViewportController::didChangeViewportAttributes):
      (WebKit::PageViewportController::visibleContentsSize):
      (WebKit::PageViewportController::applyScaleAfterRenderingContents):
      (WebKit::PageViewportController::applyPositionAfterRenderingContents):
      (WebKit::PageViewportController::updateMinimumScaleToFit):
      * UIProcess/CoordinatedGraphics/PageViewportController.h:
      Renamed from Source/WebKit2/UIProcess/PageViewportController.cpp because it depends on Coordinated Graphics.
      (WebKit::PageViewportController::~PageViewportController):
      (WebKit::PageViewportController::hadUserInteraction):
      (WebKit::PageViewportController::allowsUserScaling):
      (WebKit::PageViewportController::contentsLayoutSize):
      (WebKit::PageViewportController::minimumScale):
      (WebKit::PageViewportController::maximumScale):
      (WebKit::PageViewportController::currentScale):
      (WebKit::PageViewportController::setHadUserInteraction):
      * UIProcess/CoordinatedGraphics/WebView.cpp: Added some casts to access CoordinatedDrawingAreaProxy methods.
      (WebKit::WebView::coordinatedGraphicsScene): Simplified code using reference.
      (WebKit::WebView::updateViewportSize):
      * UIProcess/DrawingAreaProxy.cpp: Removed Coordinated Graphics macro and related codes.
      * UIProcess/DrawingAreaProxy.h: Ditto.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@159278 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      0cde9237
    • gyuyoung.kim@samsung.com's avatar
      Introduce FILTER_TYPE_CASTS for child filter class · 19709355
      gyuyoung.kim@samsung.com authored
      https://bugs.webkit.org/show_bug.cgi?id=124332
      
      Reviewed by Andreas Kling.
      
      To use TYPE_CASTS_BASE, define FILTER_TYPE_CASTS macro. Thanks to
      it, static_cast<SVGFilter*> can be replaced by toSVGFilter().
      
      No new tests, no behavior changes.
      
      * platform/graphics/filters/Filter.h:
          Add isSVGFilter() to check if casting object is SVGFilter object.
      (WebCore::Filter::isSVGFilter):
      * rendering/svg/RenderSVGResourceFilterPrimitive.cpp:
      (WebCore::RenderSVGResourceFilterPrimitive::determineFilterPrimitiveSubregion):
      * svg/graphics/filters/SVGFEImage.cpp:
      (WebCore::FEImage::determineAbsolutePaintRect):
      (WebCore::FEImage::platformApplySoftware):
      * svg/graphics/filters/SVGFilter.h:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@159277 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      19709355
    • msaboff@apple.com's avatar
      Change callToJavaScript thunk into an offline assembled stub · 4655f790
      msaboff@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=124251
      
      Reviewed by Geoffrey Garen.
      
      Changed callToJavaScript and throwNotCaught into stubs generated by the offline assembler.
      Added popCalleeSaves and pushCalleeSaves pseudo ops to the offline assembler to handle
      the saving and restoring of callee save registers.  Fixed callFrameRegister differences
      between arm traditional (r11) and arm Thumb2 (r7) in GPRInfo.h.  Also fixed implementation
      of pop & push in arm.rb.
      
      Since the offline assembler and therefore the LLInt don't work on Windows, the Windows stubs
      are handled as inline assembly in JITStubsX86.h and JITStubsMSVC64.asm.
      
      * dfg/DFGDriver.cpp:
      (JSC::DFG::compileImpl):
      * jit/GPRInfo.h:
      (JSC::GPRInfo::toIndex):
      (JSC::GPRInfo::debugName):
      * jit/JITCode.cpp:
      (JSC::JITCode::execute):
      * jit/JITExceptions.cpp:
      (JSC::genericUnwind):
      * jit/JITStubs.h:
      * jit/JITStubsMSVC64.asm:
      * jit/JITStubsX86.h:
      * jit/ThunkGenerators.cpp:
      * jit/ThunkGenerators.h:
      * llint/LLIntThunks.h:
      * llint/LowLevelInterpreter.asm:
      * llint/LowLevelInterpreter32_64.asm:
      * llint/LowLevelInterpreter64.asm:
      * offlineasm/arm.rb:
      * offlineasm/arm64.rb:
      * offlineasm/instructions.rb:
      * offlineasm/mips.rb:
      * offlineasm/registers.rb:
      * offlineasm/sh4.rb:
      * offlineasm/x86.rb:
      * runtime/VM.cpp:
      (JSC::VM::VM):
      * runtime/VM.h:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@159276 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      4655f790
  2. 13 Nov, 2013 7 commits