1. 13 Oct, 2008 10 commits
    • hyatt@apple.com's avatar
      WebCore: · 456dd87f
      hyatt@apple.com authored
      2008-10-13  David Hyatt  <hyatt@apple.com>
      
              Make RenderListBox work with CSS scrollbars.  Refactoring this code to support creation/destruction in
              the same way RenderLayer does also fixes a bug where the PLT would assert on the next-to-last page (no
              idea how to make a test case for that, though, since I couldn't repro without running the whole PLT).
      
              Reviewed by Tim Hatcher
      
              Added scrollbars/listbox-scrollbar-combinations.html
      
              * rendering/RenderListBox.cpp:
              (WebCore::RenderListBox::~RenderListBox):
              (WebCore::RenderListBox::updateFromElement):
              (WebCore::RenderListBox::createScrollbar):
              (WebCore::RenderListBox::destroyScrollbar):
              (WebCore::RenderListBox::setHasVerticalScrollbar):
              * rendering/RenderListBox.h:
      
      LayoutTests:
      
      2008-10-13  David Hyatt  <hyatt@apple.com>
      
              Add test case for custom CSS listbox scrollbars.
      
              Reviewed by Tim Hatcher
      
              * platform/mac/scrollbars/listbox-scrollbar-combinations-expected.checksum: Added.
              * platform/mac/scrollbars/listbox-scrollbar-combinations-expected.png: Added.
              * platform/mac/scrollbars/listbox-scrollbar-combinations-expected.txt: Added.
              * scrollbars/listbox-scrollbar-combinations.html: Added.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@37566 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      456dd87f
    • timothy@apple.com's avatar
      Adds an complex styled scrollbar test that exercises all... · 3cd5ad92
      timothy@apple.com authored
              Adds an complex styled scrollbar test that exercises all pseudo-elements and pseudo-classes.
              Also uses positive and negative margins on the scrollbar track and track pieces.
              Tests all the combinations of scrollbars for overflow elements, with and without resizers.
      
              Rubber-stamped by Dave Hyatt.
      
              * platform/mac/scrollbars/overflow-scrollbar-combinations-expected.checksum: Added.
              * platform/mac/scrollbars/overflow-scrollbar-combinations-expected.png: Added.
              * platform/mac/scrollbars/overflow-scrollbar-combinations-expected.txt: Added.
              * scrollbars/overflow-scrollbar-combinations.html: Added.
              * scrollbars/resources: Added.
              * scrollbars/resources/corner-inactive.png: Added.
              * scrollbars/resources/corner.png: Added.
              * scrollbars/resources/horizontal-button-active.png: Added.
              * scrollbars/resources/horizontal-button-background-active.png: Added.
              * scrollbars/resources/horizontal-button-background-hover.png: Added.
              * scrollbars/resources/horizontal-button-background-inactive.png: Added.
              * scrollbars/resources/horizontal-button-background.png: Added.
              * scrollbars/resources/horizontal-button-hover.png: Added.
              * scrollbars/resources/horizontal-button-inactive.png: Added.
              * scrollbars/resources/horizontal-button.png: Added.
              * scrollbars/resources/horizontal-decrement-arrow.png: Added.
              * scrollbars/resources/horizontal-increment-arrow.png: Added.
              * scrollbars/resources/horizontal-thumb-active.png: Added.
              * scrollbars/resources/horizontal-thumb-hover.png: Added.
              * scrollbars/resources/horizontal-thumb-inactive.png: Added.
              * scrollbars/resources/horizontal-thumb.png: Added.
              * scrollbars/resources/horizontal-track-active.png: Added.
              * scrollbars/resources/horizontal-track-disabled.png: Added.
              * scrollbars/resources/horizontal-track-hover.png: Added.
              * scrollbars/resources/horizontal-track.png: Added.
              * scrollbars/resources/resizer-inactive.png: Added.
              * scrollbars/resources/resizer.png: Added.
              * scrollbars/resources/vertical-button-active.png: Added.
              * scrollbars/resources/vertical-button-background-active.png: Added.
              * scrollbars/resources/vertical-button-background-hover.png: Added.
              * scrollbars/resources/vertical-button-background-inactive.png: Added.
              * scrollbars/resources/vertical-button-background.png: Added.
              * scrollbars/resources/vertical-button-hover.png: Added.
              * scrollbars/resources/vertical-button-inactive.png: Added.
              * scrollbars/resources/vertical-button.png: Added.
              * scrollbars/resources/vertical-decrement-arrow.png: Added.
              * scrollbars/resources/vertical-increment-arrow.png: Added.
              * scrollbars/resources/vertical-thumb-active.png: Added.
              * scrollbars/resources/vertical-thumb-hover.png: Added.
              * scrollbars/resources/vertical-thumb-inactive.png: Added.
              * scrollbars/resources/vertical-thumb.png: Added.
              * scrollbars/resources/vertical-track-active.png: Added.
              * scrollbars/resources/vertical-track-disabled.png: Added.
              * scrollbars/resources/vertical-track-hover.png: Added.
              * scrollbars/resources/vertical-track.png: Added.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@37565 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      3cd5ad92
    • hyatt@apple.com's avatar
      2008-10-13 David Hyatt <hyatt@apple.com> · 59696acf
      hyatt@apple.com authored
              In order to always match the :corner-present pseudo-class properly, delay initial updating of
              scrollbar styles until the layer has the scrollbars in its member variables.
      
              Reviewed by Tim Hatcher
      
              * rendering/RenderLayer.cpp:
              (WebCore::RenderLayer::setHasHorizontalScrollbar):
              (WebCore::RenderLayer::setHasVerticalScrollbar):
              * rendering/RenderScrollbar.cpp:
              (WebCore::RenderScrollbar::RenderScrollbar):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@37564 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      59696acf
    • weinig@apple.com's avatar
      JavaScriptCore: · fe8ca436
      weinig@apple.com authored
      2008-10-13  Sam Weinig  <sam@webkit.org>
      
              Reviewed by Dan Bernstein.
      
              Fix for https://bugs.webkit.org/show_bug.cgi?id=21577
              5 false positive StructureID leaks
      
              - Add leak ignore set to StructureID to selectively ignore leaking some StructureIDs.
              - Add create method to JSGlolalData to be used when the data will be intentionally
                leaked and ignore all leaks caused the StructureIDs stored in it.
      
              * JavaScriptCore.exp:
              * kjs/JSGlobalData.cpp:
              (JSC::JSGlobalData::createLeaked):
              * kjs/JSGlobalData.h:
              * kjs/StructureID.cpp:
              (JSC::StructureID::StructureID):
              (JSC::StructureID::~StructureID):
              (JSC::StructureID::startIgnoringLeaks):
              (JSC::StructureID::stopIgnoringLeaks):
              * kjs/StructureID.h:
      
      WebCore:
      
      2008-10-13  Sam Weinig  <sam@webkit.org>
      
              Reviewed by Dan Bernstein.
      
              Fix for https://bugs.webkit.org/show_bug.cgi?id=21577
              5 false positive StructureID leaks
      
              In WebCore, we intentionally leak the common JSGlobalData which in turn
              leaks 5 StructureIDs.  Use the new JSGlobalData::createLeaked in order to
              ignore the StructureIDs leaked within.
      
              * bindings/js/JSDOMWindowBase.cpp:
              (WebCore::JSDOMWindowBase::commonJSGlobalData):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@37563 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      fe8ca436
    • hyatt@apple.com's avatar
      2008-10-13 David Hyatt <hyatt@apple.com> · e2a30fdd
      hyatt@apple.com authored
              Add support for the :corner-present pseudoclass, which enables scrollbar pieces to change their
              artwork based on whether there is a scrollbar corner present.
      
              Reviewed by Tim Hatcher
      
              * css/CSSSelector.cpp:
              (WebCore::CSSSelector::extractPseudoType):
              * css/CSSSelector.h:
              (WebCore::CSSSelector::):
              * css/CSSStyleSelector.cpp:
              (WebCore::CSSStyleSelector::SelectorChecker::checkScrollbarPseudoClass):
              * platform/ScrollView.cpp:
              (WebCore::ScrollView::scrollbarCornerPresent):
              * platform/ScrollView.h:
              * platform/ScrollbarClient.h:
              * rendering/RenderLayer.cpp:
              (WebCore::cornerRect):
              (WebCore::scrollCornerRect):
              (WebCore::resizerCornerRect):
              (WebCore::RenderLayer::scrollbarCornerPresent):
              (WebCore::RenderLayer::setHasHorizontalScrollbar):
              (WebCore::RenderLayer::setHasVerticalScrollbar):
              * rendering/RenderLayer.h:
              (WebCore::RenderLayer::horizontalScrollbar):
              (WebCore::RenderLayer::verticalScrollbar):
              * rendering/RenderListBox.h:
              (WebCore::RenderListBox::scrollbarCornerPresent):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@37562 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      e2a30fdd
    • hyatt@apple.com's avatar
      2008-10-13 David Hyatt <hyatt@apple.com> · 2c1832e5
      hyatt@apple.com authored
              Make resizers and scrollbar corners respect :window-inactive (one more bug fix and then Tim's master
              test case for all this can land).
      
              Reviewed by Tim Hatcher
      
              * css/CSSStyleSelector.cpp:
              (WebCore::CSSStyleSelector::SelectorChecker::checkSelector):
              (WebCore::CSSStyleSelector::SelectorChecker::checkOneSelector):
              (WebCore::CSSStyleSelector::SelectorChecker::checkScrollbarPseudoClass):
              * rendering/RenderLayer.cpp:
              (WebCore::RenderLayer::paintOverflowControls):
              (WebCore::RenderLayer::paintScrollCorner):
              (WebCore::RenderLayer::paintResizer):
              (WebCore::RenderLayer::styleChanged):
              (WebCore::RenderLayer::updateScrollCornerStyle):
              (WebCore::RenderLayer::updateResizerStyle):
              * rendering/RenderLayer.h:
              * rendering/RenderScrollbar.cpp:
              (WebCore::RenderScrollbar::paint):
              * rendering/RenderScrollbarPart.cpp:
              (WebCore::RenderScrollbarPart::paintIntoRect):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@37561 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      2c1832e5
    • hyatt@apple.com's avatar
      2008-10-13 David Hyatt <hyatt@apple.com> · 097c92db
      hyatt@apple.com authored
              Rework resizer and scroll corner painting so that custom resizers and scroll corners will paint
              and invalidate properly as images load, etc.
      
              Reviewed by Tim Hatcher
      
              * rendering/RenderLayer.cpp:
              (WebCore::cornerRect):
              (WebCore::scrollCornerRect):
              (WebCore::resizerCornerRect):
              (WebCore::RenderLayer::positionOverflowControls):
              (WebCore::RenderLayer::paintOverflowControls):
              (WebCore::RenderLayer::paintScrollCorner):
              (WebCore::RenderLayer::paintResizer):
              (WebCore::RenderLayer::isPointInResizeControl):
              (WebCore::RenderLayer::hitTestOverflowControls):
              (WebCore::RenderLayer::styleChanged):
              * rendering/RenderLayer.h:
              * rendering/RenderObject.h:
              (WebCore::RenderObject::setRect):
              * rendering/RenderScrollbarPart.cpp:
              (WebCore::RenderScrollbarPart::styleDidChange):
              (WebCore::RenderScrollbarPart::imageChanged):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@37560 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      097c92db
    • ddkilzer@apple.com's avatar
      Bug 21457: resolve-ChangeLogs should be able to operate on a git revision range · a5d52a5d
      ddkilzer@apple.com authored
              <https://bugs.webkit.org/show_bug.cgi?id=21457>
      
              Reviewed by Adam.
      
              * Scripts/resolve-ChangeLogs: Added optional parameter to
              -f|--fix-merged switch to run the script on a revision range.
              Updated command-line validation checks.
              (findChangeLog): Fixed long-standing bug that should have used
              $_[0] instead of $_.
              (fixMergedChangeLog): Renamed to fixOneMergedChangeLog($).  Updated
              to work when called from git filter-branch.  It always restores a
              copy of the previous revision before reapplying the patch.
              (fixMergedChangeLogs): Added.  Calls itself through git filter-branch
              to re-merge ChangeLog files across a revision range.  Removes
              .git/refs/original directory on success.
              (parseFixMerged): Added.  Custom method to parse the -f|--fix-merged
              switch.
              (removeChangeLogArguments): Added.  Removes items from @ARGV when
              they are ChangeLog paths, and return a list of paths.  This makes it
              easier to validate the command-line.
              (resolveChangeLog): Added.  Extracted from main code block.  Runs
              the traditional single-file merge algorithm.
              (usageAndExit): Added.  Extracted from main code block.  Prints
              usage statement and exits with error status.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@37559 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      a5d52a5d
    • sfalken@apple.com's avatar
      2008-10-13 Steve Falkenburg <sfalken@apple.com> · e31b6e28
      sfalken@apple.com authored
              Reorder methods to preserve compatibility.
              
              Rubber stamped by Oliver Hunt.
      
              * Interfaces/IWebViewPrivate.idl:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@37557 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      e31b6e28
    • jmalonzo@webkit.org's avatar
      2008-10-13 Marco Barisione <marco.barisione@collabora.co.uk> · 4d9c9527
      jmalonzo@webkit.org authored
              Reviewed by Darin Adler. Landed by Jan Alonzo.
      
              WebKit GTK Port needs a smartpointer to handle g_free (GFreePtr?)
              http://bugs.webkit.org/show_bug.cgi?id=20483
      
              Start the conversion to use GOwnPtr and fix a memory leak.
      
              * platform/graphics/gtk/MediaPlayerPrivateGStreamer.cpp:
              (WebCore::mediaPlayerPrivateErrorCallback):
      
      2008-10-13  Marco Barisione  <marco.barisione@collabora.co.uk>
      
              Reviewed by Darin Adler. Landed by Jan Alonzo.
      
              WebKit GTK Port needs a smartpointer to handle g_free (GFreePtr?)
              http://bugs.webkit.org/show_bug.cgi?id=20483
      
              Add a GOwnPtr smart pointer (similar to OwnPtr) to handle memory
              allocated by GLib and start the conversion to use it.
      
              * GNUmakefile.am:
              * wtf/GOwnPtr.cpp: Added.
              (WTF::GError):
              (WTF::GList):
              (WTF::GCond):
              (WTF::GMutex):
              (WTF::GPatternSpec):
              (WTF::GDir):
              * wtf/GOwnPtr.h: Added.
              (WTF::freeOwnedPtr):
              (WTF::GOwnPtr::GOwnPtr):
              (WTF::GOwnPtr::~GOwnPtr):
              (WTF::GOwnPtr::get):
              (WTF::GOwnPtr::release):
              (WTF::GOwnPtr::rawPtr):
              (WTF::GOwnPtr::set):
              (WTF::GOwnPtr::clear):
              (WTF::GOwnPtr::operator*):
              (WTF::GOwnPtr::operator->):
              (WTF::GOwnPtr::operator!):
              (WTF::GOwnPtr::operator UnspecifiedBoolType):
              (WTF::GOwnPtr::swap):
              (WTF::swap):
              (WTF::operator==):
              (WTF::operator!=):
              (WTF::getPtr):
              * wtf/Threading.h:
              * wtf/ThreadingGtk.cpp:
              (WTF::Mutex::~Mutex):
              (WTF::Mutex::lock):
              (WTF::Mutex::tryLock):
              (WTF::Mutex::unlock):
              (WTF::ThreadCondition::~ThreadCondition):
              (WTF::ThreadCondition::wait):
              (WTF::ThreadCondition::timedWait):
              (WTF::ThreadCondition::signal):
              (WTF::ThreadCondition::broadcast):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@37556 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      4d9c9527
  2. 12 Oct, 2008 30 commits