- 01 Oct, 2009 13 commits
-
-
vestbo@webkit.org authored
Patch by Alexis Menard <alexis.menard@nokia.com> on 2009-10-01 Reviewed by Tor Arne Vestbø. git-svn-id: http://svn.webkit.org/repository/webkit/trunk@48974 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
eric@webkit.org authored
Reviewed by Dimitri Glazkov. Read-only transactions do not change file sizes and therefore should not trigger quota updates. https://bugs.webkit.org/show_bug.cgi?id=29945 * storage/SQLTransaction.cpp: (WebCore::SQLTransaction::openTransactionAndPreflight): (WebCore::SQLTransaction::runStatements): git-svn-id: http://svn.webkit.org/repository/webkit/trunk@48973 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
tonikitoo@webkit.org authored
Reviewed by Simon Hausmann. https://bugs.webkit.org/show_bug.cgi?id=29248 [Qt] [API] Make it possible to have 'invisible' loads Make QWebFrame's setHtml and setContent methods to not change session and global history at all. * Api/qwebframe.cpp: (QWebFrame::setHtml): (QWebFrame::setContent): * tests/qwebframe/qwebframe.pro: * tests/qwebframe/tst_qwebframe.cpp: git-svn-id: http://svn.webkit.org/repository/webkit/trunk@48972 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
timothy@apple.com authored
function on RenderBox. <rdar://problem/7255440> REGRESSION (r48683): Mousewheel scrolling of listboxes is broken (29756) Reviewed by Dan Bernstein. * rendering/RenderListBox.cpp: (WebCore::RenderListBox::scroll): * rendering/RenderListBox.h: * rendering/RenderTextControlSingleLine.cpp: (WebCore::RenderTextControlSingleLine::scroll): * rendering/RenderTextControlSingleLine.h: git-svn-id: http://svn.webkit.org/repository/webkit/trunk@48971 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
eric@webkit.org authored
Reviewed by Timothy Hatcher. Make a copy of listeners array before dispatching an event in WebInspector.Object.prototype.dispatchEventToListeners. Otherwise if current listener removes itself from the array next listener will be skipped. https://bugs.webkit.org/show_bug.cgi?id=29920 * inspector/front-end/Object.js: (WebInspector.Object.prototype.dispatchEventToListeners): make a copy of listeners array before dispatching an event git-svn-id: http://svn.webkit.org/repository/webkit/trunk@48970 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
zoltan@webkit.org authored
Reviewed by Simon Hausmann. [Qt] Skip fast/table/008.html until a solution for the crash on the buildbot is found. * platform/qt/Skipped: git-svn-id: http://svn.webkit.org/repository/webkit/trunk@48969 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
hausmann@webkit.org authored
Patch by Kristian Amlie <kristian.amlie@nokia.com> on 2009-10-01 Reviewed by Simon Hausmann. Send the RequestSoftwareInputPanel event if the element supports focus and the element is clicked. * Api/qwebpage.cpp: (QWebPagePrivate::QWebPagePrivate): (QWebPagePrivate::mousePressEvent): (QWebPagePrivate::mouseReleaseEvent): * Api/qwebpage_p.h: git-svn-id: http://svn.webkit.org/repository/webkit/trunk@48968 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
hausmann@webkit.org authored
Patch by Joe Ligman <joseph.ligman@nokia.com> on 2009-10-01 Reviewed by Simon Hausmann. https://bugs.webkit.org/show_bug.cgi?id=29681 Some additional changes from Kristian Amlie <kristian.amlie@nokia.com>: * Fixed surrounding text to exclude preedit string * Avoid emission of microFocusChanged during setComposition() * Api/qwebpage.cpp: (QWebPagePrivate::inputMethodEvent): (QWebPage::inputMethodQuery): * WebCoreSupport/EditorClientQt.cpp: (WebCore::EditorClientQt::respondToChangedSelection): * tests/qwebpage/tst_qwebpage.cpp: (tst_QWebPage::inputMethods): git-svn-id: http://svn.webkit.org/repository/webkit/trunk@48967 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
eric@webkit.org authored
Reviewed by Simon Hausmann. [Qt] Implement eventSender.scheduleAsynchronousClick(). https://bugs.webkit.org/show_bug.cgi?id=29931 * platform/qt/Skipped: 2009-10-01 Jakub Wieczorek <faw217@gmail.com> Reviewed by Simon Hausmann. [Qt] Implement eventSender.scheduleAsynchronousClick(). https://bugs.webkit.org/show_bug.cgi?id=29931 * DumpRenderTree/qt/jsobjects.cpp: (EventSender::scheduleAsynchronousClick): * DumpRenderTree/qt/jsobjects.h: git-svn-id: http://svn.webkit.org/repository/webkit/trunk@48966 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
eric@webkit.org authored
Reviewed by Simon Hausmann. [Qt] Implement setPopupBlockingEnabled() in the LayoutTestController and remove fast/events/open-window-from-another-frame.html from the Skipped list. https://bugs.webkit.org/show_bug.cgi?id=29930 * platform/qt/Skipped: 2009-10-01 Jakub Wieczorek <faw217@gmail.com> Reviewed by Simon Hausmann. [Qt] Implement setPopupBlockingEnabled() in the LayoutTestController and remove fast/events/open-window-from-another-frame.html from the Skipped list. https://bugs.webkit.org/show_bug.cgi?id=29930 * DumpRenderTree/qt/jsobjects.cpp: (LayoutTestController::setPopupBlockingEnabled): * DumpRenderTree/qt/jsobjects.h: git-svn-id: http://svn.webkit.org/repository/webkit/trunk@48965 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
eric@webkit.org authored
Reviewed by Xan Lopez. [GTK] GtkIMContext filtering interferes with DOM key events https://bugs.webkit.org/show_bug.cgi?id=28733 Add new key event test ensuring that IME keypresses are handled. * GNUmakefile.am: 2009-10-01 Martin Robinson <martin.james.robinson@gmail.com> Reviewed by Xan Lopez. [GTK] GtkIMContext filtering interferes with DOM key events https://bugs.webkit.org/show_bug.cgi?id=28733 Re-enable skipped tests which were previously failing. * platform/gtk/Skipped: 2009-10-01 Martin Robinson <martin.james.robinson@gmail.com> Reviewed by Xan Lopez. [GTK] GtkIMContext filtering interferes with DOM key events https://bugs.webkit.org/show_bug.cgi?id=28733 Ensure that keyboard events filtered by the GtkIMContext still create the proper DOM events. No tests added. Instead previously skipped tests have been enabled. * platform/gtk/KeyEventGtk.cpp: (WebCore::keyIdentifierForGdkKeyCode): (WebCore::singleCharacterString): 2009-10-01 Martin Robinson <martin.james.robinson@gmail.com> Reviewed by Xan Lopez. [GTK] GtkIMContext filtering interferes with DOM key events https://bugs.webkit.org/show_bug.cgi?id=28733 Ensure that keyboard events filtered by the GtkIMContext still create the proper DOM events. * WebCoreSupport/EditorClientGtk.cpp: (WebKit::clearPendingIMData): (WebKit::imContextCommitted): (WebKit::imContextPreeditChanged): (WebKit::EditorClient::shouldBeginEditing): (WebKit::EditorClient::shouldEndEditing): (WebKit::interpretEditorCommandKeyEvent): (WebKit::handleCaretBrowsingKeyboardEvent): (WebKit::EditorClient::handleKeyboardEvent): (WebKit::EditorClient::handleInputMethodKeydown): * tests/testkeyevents.c: Added. (test_info_new): (test_info_destroy): (key_event_fixture_setup): (key_event_fixture_teardown): (key_press_event_cb): (key_release_event_cb): (load_status_cb): (map_event_cb): (test_keypress): (main): git-svn-id: http://svn.webkit.org/repository/webkit/trunk@48964 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
eric@webkit.org authored
Reviewed by Xan Lopez. [GTK] data: uri support in media player https://bugs.webkit.org/show_bug.cgi?id=29842 Check presence of gstreamer-pbutils-0.10. * configure.ac: 2009-10-01 Philippe Normand <pnormand@igalia.com> Reviewed by Xan Lopez. [GTK] data: uri support in media player https://bugs.webkit.org/show_bug.cgi?id=29842 Re-enable media/audio-data-url.html. * platform/gtk/Skipped: 2009-10-01 Philippe Normand <pnormand@igalia.com> Reviewed by Xan Lopez. [GTK] data: uri support in media player https://bugs.webkit.org/show_bug.cgi?id=29842 New GStreamer element to handle data: uris. For now only base64 encoded data is supported. Decoded data is handed over to giostreamsrc. * GNUmakefile.am: * platform/graphics/gtk/DataSourceGStreamer.cpp: Added. (_do_init): (webkit_data_src_base_init): (webkit_data_src_class_init): (webkit_data_src_reset): (webkit_data_src_init): (webkit_data_src_finalize): (webkit_data_src_uri_get_type): (webkit_data_src_uri_get_protocols): (webkit_data_src_uri_get_uri): (webkit_data_src_uri_set_uri): (webkit_data_src_uri_handler_init): * platform/graphics/gtk/DataSourceGStreamer.h: Added. * platform/graphics/gtk/MediaPlayerPrivateGStreamer.cpp: (WebCore::do_gst_init): (WebCore::MediaPlayerPrivate::MediaPlayerPrivate): (WebCore::MediaPlayerPrivate::mimeTypeCache): git-svn-id: http://svn.webkit.org/repository/webkit/trunk@48963 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
cam@webkit.org authored
Added myself to the list of committers. * Scripts/modules/committers.py: git-svn-id: http://svn.webkit.org/repository/webkit/trunk@48962 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
- 30 Sep, 2009 27 commits
-
-
dbates@webkit.org authored
Reviewed by Adam Barth. https://bugs.webkit.org/show_bug.cgi?id=29944 Reduces false positives in the XSSAuditor by explicitly allowing requests that do not contain illegal URI characters. As a side effect of this change, the tests property-inject.html, property-escape-noquotes.html, and property-escape-noquotes-tab-slash-chars.html fail because these attacks do not contain any illegal URI characters and thus are now allowed by the XSSAuditor, where previously they weren't. A future change may reinstate this functionality. Tests: http/tests/security/xssAuditor/script-tag-safe2.html http/tests/security/xssAuditor/script-tag-safe3.html * page/XSSAuditor.cpp: (WebCore::isIllegalURICharacter): Added method. (WebCore::XSSAuditor::canEvaluate): (WebCore::XSSAuditor::canCreateInlineEventListener): (WebCore::XSSAuditor::findInRequest): Added parameter allowRequestIfNoIllegalURICharacters. * page/XSSAuditor.h: 2009-09-30 Daniel Bates <dbates@webkit.org> Reviewed by Adam Barth. https://bugs.webkit.org/show_bug.cgi?id=29944 Tests that the XSSAuditor allows requests that do not contain illegal URI characters. Added a notice regarding the failure of tests property-inject.html, property-escape-noquotes.html and property-escape-noquotes-tab-slash-chars.html, and rebased the expected results of these tests. * http/tests/security/xssAuditor/property-escape-noquotes-expected.txt: * http/tests/security/xssAuditor/property-escape-noquotes-tab-slash-chars-expected.txt: * http/tests/security/xssAuditor/property-escape-noquotes-tab-slash-chars.html: * http/tests/security/xssAuditor/property-escape-noquotes.html: * http/tests/security/xssAuditor/property-inject-expected.txt: * http/tests/security/xssAuditor/property-inject.html: * http/tests/security/xssAuditor/resources/safe-script-noquotes.js: Added. * http/tests/security/xssAuditor/resources/script-tag-safe2.html: Added. * http/tests/security/xssAuditor/resources/script-tag-safe3.html: Added. * http/tests/security/xssAuditor/script-tag-safe2-expected.txt: Added. * http/tests/security/xssAuditor/script-tag-safe2.html: Added. * http/tests/security/xssAuditor/script-tag-safe3-expected.txt: Added. * http/tests/security/xssAuditor/script-tag-safe3.html: Added. git-svn-id: http://svn.webkit.org/repository/webkit/trunk@48961 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
oliver@apple.com authored
https://bugs.webkit.org/show_bug.cgi?id=28948 Reviewed by Maciej Stachowiak. showModalDialog calls getDirect on what is actually a window shell, so ends up not getting a value (since no value can ever be placed directly on the shell), which leads to incorrect behaviour. We use a manual test rather than automatic as it was not possible to get a modal run loop to work inside DRT. git-svn-id: http://svn.webkit.org/repository/webkit/trunk@48960 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
eric@webkit.org authored
Reviewed by Darin Adler. Add ValidityState.tooLong support for <input> and <textarea>. https://bugs.webkit.org/show_bug.cgi?id=27454 * fast/forms/ValidityState-tooLong-input-expected.txt: Added. * fast/forms/ValidityState-tooLong-input.html: Added. * fast/forms/ValidityState-tooLong-textarea-expected.txt: Added. * fast/forms/ValidityState-tooLong-textarea.html: Added. * fast/forms/script-tests/ValidityState-tooLong-input.js: Added. * fast/forms/script-tests/ValidityState-tooLong-textarea.js: Added. 2009-09-30 Kent Tamura <tkent@chromium.org> Reviewed by Darin Adler. Adds ValidityState.tooLong support for <input> and <textarea>. Introduces tooLong() in HTMLFormControlElement and it always returns false. HTMLInputElement and HTMLTextAreaElement overrides it and checks the text length and maxLength. tooLong() should work only for `dirty' values. So, introduces m_isDirty flag for HTMLTextAreaElement, and !m_data.value().isNull() works as a dirty flag for HTMLInputElement. Renames parameter names of setMaxLength(). https://bugs.webkit.org/show_bug.cgi?id=27454 Tests: fast/forms/ValidityState-tooLong-input.html fast/forms/ValidityState-tooLong-textarea.html * html/HTMLFormControlElement.h: (WebCore::HTMLFormControlElement::tooLong): * html/HTMLInputElement.cpp: (WebCore::HTMLInputElement::tooLong): (WebCore::HTMLInputElement::setMaxLength): * html/HTMLInputElement.h: * html/HTMLTextAreaElement.cpp: (WebCore::HTMLTextAreaElement::HTMLTextAreaElement): (WebCore::HTMLTextAreaElement::reset): (WebCore::HTMLTextAreaElement::updateValue): (WebCore::HTMLTextAreaElement::setMaxLength): (WebCore::HTMLTextAreaElement::tooLong): * html/HTMLTextAreaElement.h: * html/ValidityState.h: (WebCore::ValidityState::tooLong): git-svn-id: http://svn.webkit.org/repository/webkit/trunk@48959 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
abarth@webkit.org authored
Reviewed by Maciej Stachowiak. Factor RedirectScheduler out of FrameLoader https://bugs.webkit.org/show_bug.cgi?id=29948 This change introduces a new sub-object of Frame, redirectScheduler. The redirectScheduler is responsible for scheduling redirects. This change leaves the code for the redirectScheduler in FrameLoader.cpp. A future change will move the class into its own file. No behavior change (hopefully!). * loader/FrameLoader.cpp: (WebCore::RedirectScheduler::RedirectScheduler): (WebCore::RedirectScheduler::~RedirectScheduler): (WebCore::RedirectScheduler::redirectScheduledDuringLoad): (WebCore::RedirectScheduler::clear): (WebCore::FrameLoader::FrameLoader): (WebCore::FrameLoader::setDefersLoading): (WebCore::FrameLoader::stopLoading): (WebCore::FrameLoader::didOpenURL): (WebCore::FrameLoader::didExplicitOpen): (WebCore::FrameLoader::cancelAndClear): (WebCore::FrameLoader::clear): (WebCore::FrameLoader::checkCompleted): (WebCore::FrameLoader::isScheduledLocationChangePending): (WebCore::FrameLoader::scheduleHTTPRedirection): (WebCore::RedirectScheduler::scheduleRedirect): (WebCore::RedirectScheduler::mustLockBackForwardList): (WebCore::FrameLoader::scheduleLocationChange): (WebCore::RedirectScheduler::scheduleLocationChange): (WebCore::FrameLoader::scheduleFormSubmission): (WebCore::RedirectScheduler::scheduleFormSubmission): (WebCore::FrameLoader::scheduleRefresh): (WebCore::RedirectScheduler::scheduleRefresh): (WebCore::RedirectScheduler::locationChangePending): (WebCore::FrameLoader::scheduleHistoryNavigation): (WebCore::RedirectScheduler::scheduleHistoryNavigation): (WebCore::RedirectScheduler::timerFired): (WebCore::FrameLoader::provisionalLoadStarted): (WebCore::RedirectScheduler::schedule): (WebCore::RedirectScheduler::startTimer): (WebCore::RedirectScheduler::cancel): (WebCore::FrameLoader::completed): (WebCore::FrameLoader::open): * loader/FrameLoader.h: (WebCore::FrameLoader::committedFirstRealDocumentLoad): * page/Frame.cpp: (WebCore::Frame::Frame): (WebCore::Frame::redirectScheduler): * page/Frame.h: git-svn-id: http://svn.webkit.org/repository/webkit/trunk@48958 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
mjs@apple.com authored
More Windows build fixes for https://bugs.webkit.org/show_bug.cgi?id=29943 * platform/network/cf/ResourceHandleCFNet.cpp: (WebCore::willSendRequest): git-svn-id: http://svn.webkit.org/repository/webkit/trunk@48957 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
mjs@apple.com authored
Fix windows build for fix for https://bugs.webkit.org/show_bug.cgi?id=29943 * platform/network/cf/ResourceHandleCFNet.cpp: (WebCore::willSendRequest): git-svn-id: http://svn.webkit.org/repository/webkit/trunk@48956 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
dglazkov@chromium.org authored
Reviewed by Darin Fisher. [V8] HTMLAudioElement, HTMLImageElement, and HTMLOptionElement are constructable, but they shouldn't be. Only Audio, Image, and Option should be constructable. https://bugs.webkit.org/show_bug.cgi?id=29940 Test: fast/dom/dom-constructor.html * WebCore.gypi: Added new files to project. * bindings/scripts/CodeGeneratorV8.pm: Modified to generate custom constructors. * bindings/v8/V8DOMWrapper.cpp: (WebCore::V8DOMWrapper::getTemplate): Removed handling of HTMLImageElement, HTMLOptionElement and HTMLAudioElement construction. * bindings/v8/V8HTMLAudioElementConstructor.h: Added. * bindings/v8/V8HTMLImageElementConstructor.h: Added. * bindings/v8/V8HTMLOptionElementConstructor.h: Added. * bindings/v8/V8Index.cpp: Added new headers. * bindings/v8/V8Index.h: Added Audio, Image and Option decls. * bindings/v8/custom/V8CustomBinding.h: Ditto. * bindings/v8/custom/V8DOMWindowCustom.cpp: (WebCore::ACCESSOR_GETTER): Added custom constructors. * bindings/v8/custom/V8HTMLAudioElementConstructor.cpp: (WebCore::V8HTMLImageElementConstructor::GetTemplate): Added custom template creator. * bindings/v8/custom/V8HTMLOptionElementConstructor.cpp: (WebCore::V8HTMLOptionElementConstructor::GetTemplate): Ditto. * bindings/v8/custom/V8HTMLImageElementConstructor.cpp: (WebCore::V8HTMLImageElementConstructor::GetTemplate): Ditto. git-svn-id: http://svn.webkit.org/repository/webkit/trunk@48955 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
eric@webkit.org authored
Reviewed by George Staikos. Defines two pseudo-platforms for ARM and Thumb-2 instruction set. https://bugs.webkit.org/show_bug.cgi?id=29122 Introduces WTF_PLATFORM_ARM_TRADITIONAL and WTF_PLATFORM_ARM_THUMB2 macros on ARM platforms. The PLATFORM(ARM_THUMB2) should be used when Thumb-2 instruction set is the required target. The PLATFORM(ARM_TRADITIONAL) is for generic ARM instruction set. In case where the code is common the PLATFORM(ARM) have to be used. Modified by George Wright <gwright@rim.com> to correctly work with the RVCT-defined __TARGET_ARCH_ARM and __TARGET_ARCH_THUMB compiler macros, as well as adding readability changes. * wtf/Platform.h: git-svn-id: http://svn.webkit.org/repository/webkit/trunk@48954 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
mjs@apple.com authored
Reviewed by Brady Eidson. 307 redirects should pass along http body and Content-Type header https://bugs.webkit.org/show_bug.cgi?id=29943 Follow-up fix for: <rdar://problem/3802660> SAP: 307 (Temporary Redirect) responses should use POST, not GET Test: http/tests/loading/resources/redirect-methods-result.php * platform/network/cf/ResourceHandleCFNet.cpp: (WebCore::willSendRequest): Pass along http body and Content-Type header. * platform/network/mac/ResourceHandleMac.mm: (-[WebCoreResourceHandleAsDelegate connection:willSendRequest:redirectResponse:]): ditto 2009-09-30 Maciej Stachowiak <mjs@apple.com> Reviewed by Brady Eidson. 307 redirects should pass along http body and Content-Type header https://bugs.webkit.org/show_bug.cgi?id=29943 Follow-up fix for: <rdar://problem/3802660> SAP: 307 (Temporary Redirect) responses should use POST, not GET * http/tests/loading/redirect-methods.html: Updated test to show the http body and content-type header. * http/tests/loading/redirect-methods-expected.txt: * http/tests/loading/resources/redirect-methods-result.php: git-svn-id: http://svn.webkit.org/repository/webkit/trunk@48953 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
https://bugs.webkit.org/show_bug.cgi?id=29941ggaren@apple.com authored
REGRESSION (r48882-r48888): Many memory leaks on SnowLeopard leaks bot Patch by Geoffrey Garen <ggaren@apple.com> on 2009-09-30 Reviewed by Mark Rowe. Forgot to implement a destructor for JSDOMWindowBaseData, so it was leaking its RefPtr data member. * bindings/js/JSDOMWindowBase.cpp: (WebCore::JSDOMWindowBase::destroyJSDOMWindowBaseData): * bindings/js/JSDOMWindowBase.h: (WebCore::JSDOMWindowBase::JSDOMWindowBaseData::JSDOMWindowBaseData::JSDOMWindowBaseData): git-svn-id: http://svn.webkit.org/repository/webkit/trunk@48952 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
hyatt@apple.com authored
reflect the changes. Reviewed by Tim Hatcher. * page/PageGroup.cpp: (WebCore::PageGroup::removeUserContentWithURLForWorld): (WebCore::PageGroup::removeUserContentForWorld): git-svn-id: http://svn.webkit.org/repository/webkit/trunk@48951 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
jorlow@chromium.org authored
Reviewed by Dimitri Glazkov. Use a script-tests directory rather than a resources directory for DOM Storage https://bugs.webkit.org/show_bug.cgi?id=29938 Use a script-tests directory rather than a resources directory for DOM Storage. This matches up with what's been done elsewhere in the tree. * storage/domstorage/localstorage/clear.html: * storage/domstorage/resources: Removed. * storage/domstorage/resources/clear.js: Removed. * storage/domstorage/script-tests: Copied from LayoutTests/storage/domstorage/resources. * storage/domstorage/sessionstorage/clear.html: git-svn-id: http://svn.webkit.org/repository/webkit/trunk@48950 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
eric@webkit.org authored
No review, just adding Geoff to the list of reviewers. * Scripts/modules/committers.py: git-svn-id: http://svn.webkit.org/repository/webkit/trunk@48949 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
oliver@apple.com authored
Reviewed by Geoff Garen. Tweak the implementation of Array.prototype.toString to have a fast path when acting on a true JSArray. git-svn-id: http://svn.webkit.org/repository/webkit/trunk@48948 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
mitz@apple.com authored
https://bugs.webkit.org/show_bug.cgi?id=29209 Reviewed by Sam Weinig. WebCore: Test: fast/inline/relative-positioned-overflow.html * rendering/InlineFlowBox.cpp: (WebCore::InlineFlowBox::computeVerticalOverflow): Add self-painting inlines to overflow to ensure that they are included in hit-testing. LayoutTests: * fast/inline/relative-positioned-overflow-expected.txt: Added. * fast/inline/relative-positioned-overflow.html: Added. * platform/mac/fast/repaint/transform-absolute-in-positioned-container-expected.txt: git-svn-id: http://svn.webkit.org/repository/webkit/trunk@48947 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
rdar://problem/7259706weinig@apple.com authored
Need WebKit API or SPI on Mac and Windows to test whether it's safe to load a page in a new tab/window Reviewed by Dan Bernstein. WebKit/mac: * WebView/WebFrame.mm: (-[WebFrame _allowsFollowingLink:]): * WebView/WebFramePrivate.h: WebKit/win: * Interfaces/IWebFramePrivate.idl: * WebFrame.cpp: (WebFrame::allowsFollowingLink): * WebFrame.h: git-svn-id: http://svn.webkit.org/repository/webkit/trunk@48946 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
simon.fraser@apple.com authored
Reviewed by Mark Rowe. transforms/3d tests are not run in Release builds https://bugs.webkit.org/show_bug.cgi?id=29827 Make sure we export the WebCoreHas3DRendering symbol in Release builds, because this symbols is used by run-webkit-tests (via 'nm') to detect whether WebCore was built with ENABLE_3D_RENDERING turned on. * DerivedSources.make: * WebCore.3DRendering.exp: Added. * WebCore.xcodeproj/project.pbxproj: git-svn-id: http://svn.webkit.org/repository/webkit/trunk@48945 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
mitz@apple.com authored
LayoutTests/platform/win/css2.1/resources/Mac-compatible-font-fallback.css Reviewed by Sam Weinig. * DumpRenderTree/fonts/WebKit Layout Tests 2.ttf: Added. * DumpRenderTree/fonts/WebKit Layout Tests.ttf: Added. git-svn-id: http://svn.webkit.org/repository/webkit/trunk@48944 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
kenneth@webkit.org authored
useful for creating error pages. Patch by Kenneth Rohde Christiansen <kenneth@webkit.org> on 2009-09-30 Reviewed by David Hyatt. * Api/qwebpage.h: * WebCoreSupport/FrameLoaderClientQt.cpp: (WebCore::FrameLoaderClientQt::callErrorPageExtension): git-svn-id: http://svn.webkit.org/repository/webkit/trunk@48943 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
jorlow@chromium.org authored
Patch by Jeremy Orlow <jorlow@chromium.org> on 2009-09-30 * WebCore.pro: git-svn-id: http://svn.webkit.org/repository/webkit/trunk@48942 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
hyatt@apple.com authored
Reviewed by Adam Roben. * page/PageGroup.cpp: (WebCore::PageGroup::removeUserContentURLForWorld): * page/PageGroup.h: WebKit/mac: Add the ability to remove user stylesheets and scripts by URL. Reviewed by Adam Roben. * WebView/WebView.mm: (+[WebView _removeUserContentFromGroup:url:worldID:]): * WebView/WebViewPrivate.h: WebKit/win: Add the ability to remove user stylesheets and scripts by URL. Reviewed by Adam Roben. * Interfaces/IWebViewPrivate.idl: * WebView.cpp: (WebView::removeUserContentWithURLFromGroup): * WebView.h: git-svn-id: http://svn.webkit.org/repository/webkit/trunk@48941 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
eric@webkit.org authored
Reviewed by Dimitri Glazkov. Fix for conditionals in the WebCore gyp file, which contained two separate 'conditions' values for the webcore target. The first entry was ignored, resulting in some missine defines. https://bugs.webkit.org/show_bug.cgi?id=29907 * WebCore.gyp/WebCore.gyp: git-svn-id: http://svn.webkit.org/repository/webkit/trunk@48940 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
jorlow@chromium.org authored
Reviewed by Adam Barth. DOM Storage needs to be more careful about where "ThreadSafe" objects are destroyed. https://bugs.webkit.org/show_bug.cgi?id=29265 DOM Storage needs to be more careful about where "ThreadSafe" objects are destroyed. With the current code, there actually isn't a race condition, but it sure would be easy for someone to introduce one. A bunch of ThreadSafeShared objects have RefPtrs to objects that are NOT ThreadSafeShared objects. If it were possible any of these objects' destructors to be fired off the main thread, then the you'd have a race condition. The code should be more clear and self-documenting about how things related to each other. Since the lifetime of a LocalStorageTask is bounded by the LocalStorageThread which is bounded by the StorageSyncManager, StorageAreaImpl, and StorageAreaSync, there's no reason for LocalStorageTask to store anything other than pointers. By breaking this dependency, we can eliminate the risk. Note that we _could_ have LocalStorageThread's task queue just store LocalStorageTask*'s rather than RefPtr<LocalStorageTask>s but then we'd need to manually take care of deleting. It'd probably also be possible to change LocalStorageThread around so that it needn't hold onto a reference of itself and have a more deterministic shutdown, but my initial attempts to do so failed, and I decided it wasn't worth changing. The queue is killed before hand, so the thread is 100% impotent before the main thread continues anyway. The constructors and destructors of StorageSyncManager, StorageAreaImpl, and StorageAreaSync now have ASSERTs to verify they're running on the main thread. I'm fairly positive that it'd be impossible to hit these asserts and the fact that these classes are no longer ThreadSafeShared should make it clear how they're meant to be used, but I think it's worth it to be extra sure. Of course, ideally, we'd have such an assert every time a ref is incremented or decremented. Behavior should be unchanged and this is just an internal code cleanup, so no new tests. * storage/LocalStorageTask.cpp: (WebCore::LocalStorageTask::LocalStorageTask): (WebCore::LocalStorageTask::performTask): * storage/LocalStorageTask.h: (WebCore::LocalStorageTask::createImport): (WebCore::LocalStorageTask::createSync): (WebCore::LocalStorageTask::createTerminate): * storage/LocalStorageThread.cpp: (WebCore::LocalStorageThread::scheduleImport): (WebCore::LocalStorageThread::scheduleSync): * storage/LocalStorageThread.h: * storage/StorageArea.h: * storage/StorageAreaImpl.cpp: (WebCore::StorageAreaImpl::~StorageAreaImpl): (WebCore::StorageAreaImpl::StorageAreaImpl): * storage/StorageAreaSync.cpp: (WebCore::StorageAreaSync::StorageAreaSync): (WebCore::StorageAreaSync::~StorageAreaSync): * storage/StorageSyncManager.cpp: (WebCore::StorageSyncManager::StorageSyncManager): (WebCore::StorageSyncManager::~StorageSyncManager): (WebCore::StorageSyncManager::scheduleImport): (WebCore::StorageSyncManager::scheduleSync): * storage/StorageSyncManager.h: git-svn-id: http://svn.webkit.org/repository/webkit/trunk@48939 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
ggaren@apple.com authored
https://bugs.webkit.org/show_bug.cgi?id=29915 Patch by Csaba Osztrogonac <oszi@inf.u-szeged.hu> on 2009-09-30 Reviewed by Geoffrey Garen. After http://trac.webkit.org/changeset/48905 the build broke in JSVALUE32 case. Also removed unreachable code. * jit/JITArithmetic.cpp: (JSC::JIT::emit_op_add): - Declaration of "OperandTypes types" moved before first use. - Typos fixed: dst modified to result, regT2 added. - Unreachable code removed. (JSC::JIT::emitSlow_op_add): - Missing declaration of "OperandTypes types" added. git-svn-id: http://svn.webkit.org/repository/webkit/trunk@48938 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
jorlow@chromium.org authored
Reviewed by Darin Fisher. Chromium needs to be able to override the way storage events are delivered https://bugs.webkit.org/show_bug.cgi?id=29655 Chromium needs to be able to override the way storage events are delivered. This replaced https://bugs.webkit.org/show_bug.cgi?id=29257 because it'll be faster (no vtables and extra allocation) and somewhat cleaner (no dependency injection). This is necessary because Chromium needs to transport events across a process barrier and then dispatch them without use of a Frame*. Behavior should not change with this, so no updates to tests. * GNUmakefile.am: * WebCore.gypi: * WebCore.vcproj/WebCore.vcproj: * WebCore.xcodeproj/project.pbxproj: * WebCoreSources.bkl: * storage/StorageAreaImpl.cpp: (WebCore::StorageAreaImpl::setItem): (WebCore::StorageAreaImpl::removeItem): (WebCore::StorageAreaImpl::clear): * storage/StorageAreaImpl.h: * storage/StorageEventDispatcher.cpp: Copied from WebCore/storage/StorageAreaImpl.cpp. (WebCore::StorageEventDispatcher::dispatch): * storage/StorageEventDispatcher.h: Added. (Well, technically in the other half of this patch.) git-svn-id: http://svn.webkit.org/repository/webkit/trunk@48937 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
mrowe@apple.com authored
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@48936 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
jianli@chromium.org authored
https://bugs.webkit.org/show_bug.cgi?id=29929 Reviewed by Darin Adler. WebCore: Test: http/tests/misc/drag-over-iframe-invalid-source-crash.html * page/EventHandler.cpp: (WebCore::EventHandler::updateDragAndDrop): LayoutTests: Add a new test for the bug. * http/tests/misc/drag-over-iframe-invalid-source-crash-expected.txt: Added. * http/tests/misc/drag-over-iframe-invalid-source-crash.html: Added. git-svn-id: http://svn.webkit.org/repository/webkit/trunk@48934 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-