2009-07-30  Darin Adler  <darin@apple.com>

        Reviewed by David Levin.

        Use checked casts for render tree
        https://bugs.webkit.org/show_bug.cgi?id=23522

        Next step: Add casts for all the RenderTable classes and use them everywhere.

        Also added a few uses in places that were still using static_cast.
        Also made some virtual member functions private.
        Also changed RenderTable::m_tableLayout to use OwnPtr.

        * accessibility/AccessibilityTable.cpp:
        (WebCore::AccessibilityTable::isTableExposableThroughAccessibility):
        (WebCore::AccessibilityTable::addChildren):
        (WebCore::AccessibilityTable::cellForColumnAndRow):
        * accessibility/AccessibilityTableCell.cpp:
        (WebCore::AccessibilityTableCell::parentTable):
        (WebCore::AccessibilityTableCell::rowIndexRange):
        (WebCore::AccessibilityTableCell::columnIndexRange):
        (WebCore::AccessibilityTableCell::titleUIElement):
        * accessibility/AccessibilityTableColumn.cpp:
        (WebCore::AccessibilityTableColumn::headerObject):
        * accessibility/AccessibilityTableRow.cpp:
        (WebCore::AccessibilityTableRow::parentTable):
        * editing/DeleteSelectionCommand.cpp:
        (WebCore::DeleteSelectionCommand::removeNode):
        * editing/TextIterator.cpp:
        (WebCore::shouldEmitTabBeforeNode):
        (WebCore::shouldEmitNewlinesBeforeAndAfterNode):
        * html/HTMLTableCellElement.cpp:
        (WebCore::HTMLTableCellElement::parseMappedAttribute):
        * html/HTMLTableColElement.cpp:
        (WebCore::HTMLTableColElement::parseMappedAttribute):
        * page/Frame.cpp:
        (WebCore::Frame::searchForLabelsAboveCell):
        * page/mac/FrameMac.mm:
        (WebCore::Frame::searchForNSLabelsAboveCell):
        * rendering/AutoTableLayout.cpp:
        (WebCore::AutoTableLayout::recalcColumn):
        (WebCore::AutoTableLayout::fullRecalc):
        (WebCore::shouldScaleColumns):
        * rendering/FixedTableLayout.cpp:
        (WebCore::FixedTableLayout::calcWidthArray):
        * rendering/RenderBlock.cpp:
        (WebCore::RenderBlock::calcPrefWidths):
        * rendering/RenderBox.cpp:
        (WebCore::RenderBox::calcPercentageHeight):
        * rendering/RenderObject.cpp:
        (WebCore::RenderObject::addChild):
        (WebCore::RenderObject::containingBlock):
        * rendering/RenderTableCell.cpp:
        (WebCore::RenderTableCell::collapsedBottomBorder):
        * rendering/RenderTableCol.cpp:
        (WebCore::RenderTableCol::table):
        * rendering/RenderTableRow.cpp:
        (WebCore::RenderTableRow::addChild):
        (WebCore::RenderTableRow::layout):
        (WebCore::RenderTableRow::paint):
        * rendering/RenderTableSection.cpp:
        (WebCore::RenderTableSection::addChild):
        (WebCore::RenderTableSection::layoutRows):
        (WebCore::RenderTableSection::lowestPosition):
        (WebCore::RenderTableSection::rightmostPosition):
        (WebCore::RenderTableSection::leftmostPosition):
        (WebCore::RenderTableSection::paintObject):
        (WebCore::RenderTableSection::recalcCells):
        * rendering/RenderTreeAsText.cpp:
        (WebCore::operator<<):
        (WebCore::writeTextRun):
        Use checked casts.

        * rendering/RenderTable.cpp:
        (WebCore::RenderTable::styleDidChange): Updated to use OwnPtr.
        (WebCore::RenderTable::addChild): Use checked cast.
        (WebCore::RenderTable::layout): Ditto.
        (WebCore::RenderTable::setCellWidths): Ditto.
        (WebCore::RenderTable::paintObject): Ditto.
        (WebCore::RenderTable::splitColumn): Ditto.
        (WebCore::RenderTable::appendColumn): Ditto.
        (WebCore::RenderTable::colElement): Ditto.
        (WebCore::RenderTable::recalcSections): Ditto.
        (WebCore::RenderTable::outerBorderBottom): Ditto.
        (WebCore::RenderTable::outerBorderLeft): Ditto.
        (WebCore::RenderTable::outerBorderRight): Ditto.
        (WebCore::RenderTable::sectionAbove): Ditto.
        (WebCore::RenderTable::sectionBelow): Ditto.

        * rendering/RenderTable.h: Added checked cast. Made virtual
        functions private. Changed m_tableLayout to be a OwnPtr.

        * rendering/RenderTableCell.h: Added checked cast.
        * rendering/RenderTableCol.h: Ditto. Made virtual functions private.
        * rendering/RenderTableRow.h: Ditto.
        * rendering/RenderTableSection.h: Ditto.

WebKit/mac:

2009-07-30  Darin Adler  <darin@apple.com>

        Reviewed by David Levin.

        Use checked casts for render tree
        https://bugs.webkit.org/show_bug.cgi?id=23522

        * Misc/WebNSAttributedStringExtras.mm:
        (fileWrapperForElement):
        * Misc/WebNSPasteboardExtras.mm:
        (imageFromElement):
        (-[NSPasteboard _web_declareAndWriteDragImageForElement:URL:title:archive:source:]):
        * WebView/WebFrame.mm:
        (-[WebFrame _computePageRectsWithPrintWidthScaleFactor:printHeight:]):
        (-[WebFrame _accessibilityTree]):
        * WebView/WebRenderNode.mm:
        (copyRenderNode):
        Use checked casts.

WebKit/win:

2009-07-30  Darin Adler  <darin@apple.com>

        Reviewed by David Levin.

        Use checked casts for render tree
        https://bugs.webkit.org/show_bug.cgi?id=23522

        * DOMHTMLClasses.cpp:
        (DOMHTMLInputElement::isUserEdited):
        (DOMHTMLTextAreaElement::isUserEdited):
        Use checked casts.



git-svn-id: http://svn.webkit.org/repository/webkit/trunk@46647 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2009-07-31  Brady Eidson  <beidson@apple.com>

        Reviewed by John Sullivan.

        <rdar://problem/6973106> and https://bugs.webkit.org/show_bug.cgi?id=27896
        Favicons are still loaded when automatic image loading is disabled.

        People who want to avoid loading images generally want to avoid loading all images.

        Test: http/tests/misc/favicon-loads-with-images-disabled.html

        * loader/FrameLoader.cpp:
        (WebCore::FrameLoader::startIconLoader): After committing the URL mapping, don't actually 
          perform the load if images shouldn't be loading.

WebKitTools:

2009-07-31  Brady Eidson  <beidson@apple.com>

        Reviewed by John Sullivan.

        <rdar://problem/6973106> and https://bugs.webkit.org/show_bug.cgi?id=27896
        Favicons are still loaded when automatic image loading is disabled.

        * DumpRenderTree/LayoutTestController.cpp:
        (disableImageLoadingCallback):
        (LayoutTestController::staticFunctions):
        * DumpR...

        Reviewed by Anders Carlsson.

        Accelerated animations stutter on pages with lots of animations and 3d transforms
        https://bugs.webkit.org/show_bug.cgi?id=27884

        This patch changes the strategy for synchronizing painting view the view,
        and compositing layer updates. Previously the strategy was to disable screen
        updates between the time we updated the layer tree, and painted the view. That
        left screen updates disabled for too long (hundreds of milliseconds) in some
        cases, causing animation stutter.

        The new strategy is to batch up changes to the CA layer tree, and commit them
        all at once just before painting happens (referred to as a "sync" in the code).
        GraphicsLayerCA now keeps a bitmask of changed properties, and then migrates
        the values stored in GraphicsLayer into the CA layer tree at commit time.

        Compositing layers are then synced in FrameView::paintContents(). However, not
        all style/layout changes will result in painting; to deal with style changes that
        touch only compositing properties, we set up a runloop observer that takes care
        of comitting layer changes when no painting happens.

        * WebCore.base.exp: Export FrameView::syncCompositingStateRecursive()

        * loader/EmptyClients.h: scheduleViewUpdate() renamed to syncCompositingStateRecursive()
        * page/ChromeClient.h: scheduleViewUpdate() renamed to syncCompositingStateRecursive()

        * page/FrameView.h:
        * page/FrameView.cpp:
        (WebCore::FrameView::syncCompositingStateRecursive): syncCompositingState() on the
        view and all subviews. Like layoutIfNeededRecursive(). If layout is pending, does not
        sync and returns false, since we only want to sync when layout is done.

        (WebCore::FrameView::paintContents): syncCompositingState() before painting.

        * page/animation/KeyframeAnimation.cpp:
        (WebCore::KeyframeAnimation::endAnimation):
        Call animationPaused() to notify the graphics layers about animation pausing.

        * platform/graphics/FloatPoint3D.h:
        (WebCore::operator==):
        (WebCore::operator!=):
        Add missing comparison operators.

        * platform/graphics/GraphicsLayer.cpp:
        (WebCore::GraphicsLayer::setOpacity):
        (WebCore::GraphicsLayer::setBackgroundColor): Simple setters no longer care about animation info.

        (WebCore::GraphicsLayer::paintGraphicsLayerContents): Null-check client.

        * platform/graphics/GraphicsLayer.h:
        (WebCore::AnimationValue:):
        (WebCore::TransformAnimationValue:):
        (WebCore::KeyframeValueList:):
        (WebCore::KeyframeValueList::insert):
        Cleaned up versions of FloatValue and TransformValue, used to store information
        about keyframes values.

        (WebCore::GraphicsLayer::contentsRect):
        (WebCore::GraphicsLayer::setContentsRect):
        ContentsRect is now a simple setter.

        (WebCore::GraphicsLayer::addAnimation):
        (WebCore::GraphicsLayer::removeAnimationsForProperty):
        (WebCore::GraphicsLayer::removeAnimationsForKeyframes):
        (WebCore::GraphicsLayer::pauseAnimation):
        Simplified animation api.

        (WebCore::GraphicsLayer::setGeometryOrientation):
        (WebCore::GraphicsLayer::geometryOrientation):
        setGeometryOrientation is now just a normal member variable.

        (WebCore::GraphicsLayer::contentsOrientation): add a getter.
        (WebCore::GraphicsLayer::syncCompositingState): Entry into the layer sync code.

        * platform/graphics/GraphicsLayerClient.h: scheduleViewUpdate() renamed to syncCompositingStateRecursive)

        * platform/graphics/mac/GraphicsLayerCA.h:
        * platform/graphics/mac/GraphicsLayerCA.mm:
        Lots of cleanup and refactoring. Main points:
        - Layer changes are all batched, and only committed to the CA layer on syncCompositingState().
        - Bitmask is used to store which properties have changed. More efficient than before.
        - Simpler animation interface; simple setters are no longer confounded with animations.
        - Refactored code that creates CA animations, and stores which animations are running.

        * platform/graphics/transforms/TransformOperations.h:
        (WebCore::TransformOperations::size):
        (WebCore::TransformOperations::at): Useful accessors for size and indexed access.

        * rendering/RenderLayerBacking.h:
        * rendering/RenderLayerBacking.cpp:
        Renamed 'contentsLayer' to 'foregroundLayer' to avoid confusion with GraphicsLayer's
        contentsLayer.
        Adapt to GraphicsLayer's simpler animation API.
        Pass animation pausing through to the graphics layers.
        contentsBox() is no longer a callback via GraphicsLayerClient.

        * rendering/RenderLayerCompositor.h:
        * rendering/RenderLayerCompositor.cpp:
        (WebCore::RenderLayerCompositor::setCompositingLayersNeedRebuild):
        (WebCore::RenderLayerCompositor::scheduleSync):
        (WebCore::RenderLayerCompositor::rebuildCompositingLayerTree):
        scheduleViewUpdate() is no longer required. Instead, we plumb through "compositingLayerSync"
        notifications, which travel up to WebKit and set up a runloop observer.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@46645 268f45cc-cd09-0410-ab3c-d52691b4dbfc

        Reviewed by David Kilzer.

        bugzilla-tool post-commits trunk..head errors out
        https://bugs.webkit.org/show_bug.cgi?id=27847

        Rename commit_ids_from_range_arguments to commit_ids_from_commitish_arguments
        and make it handle the new arguments format proposed in the bug.

        * Scripts/bugzilla-tool:
        * Scripts/modules/scm.py:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@46644 268f45cc-cd09-0410-ab3c-d52691b4dbfc

        Change malloc to fastMalloc and free to fastFree in Yarr's RegexInterpreter.cpp
        https://bugs.webkit.org/show_bug.cgi?id=27874

        Use fastMalloc and fastFree instead of malloc and free in RegexInterpreter.cpp's methods.

        * yarr/RegexInterpreter.cpp:
        (JSC::Yarr::Interpreter::allocDisjunctionContext):
        (JSC::Yarr::Interpreter::freeDisjunctionContext):
        (JSC::Yarr::Interpreter::allocParenthesesDisjunctionContext):
        (JSC::Yarr::Interpreter::freeParenthesesDisjunctionContext):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@46643 268f45cc-cd09-0410-ab3c-d52691b4dbfc

        Reviewed by Eric Seidel.

        Geolocation clean up when no longer updating
        https://bugs.webkit.org/show_bug.cgi?id=27888

        When Geolocation::disconnectFrame() is called, need to call
        Document::setUsingGeolocation(false) to mirror the true call
        when it is set up.

        When handling an error, and there are no more listeners, call
        GeolocationService::stopUpdating().

        * page/Geolocation.cpp:
        (WebCore::Geolocation::disconnectFrame):
        (WebCore::Geolocation::handleError):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@46642 268f45cc-cd09-0410-ab3c-d52691b4dbfc

        Reviewed by David Levin.

        clean up build-webkit to use less copy/paste code and remove unneeded SVG warning
        https://bugs.webkit.org/show_bug.cgi?id=27857

        * Scripts/build-webkit:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@46641 268f45cc-cd09-0410-ab3c-d52691b4dbfc

        <http://webkit.org/b/27894> bugzilla-tool: Bugzilla.clear_attachment_review_flag() fails with ClientForm-0.2.10 and python-2.5

        Reviewed by Eric Seidel.

        * Scripts/modules/bugzilla.py:
        (Bugzilla.clear_attachment_review_flag): Specify which 'comment'
        form field to use when setting its value.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@46640 268f45cc-cd09-0410-ab3c-d52691b4dbfc

        Reviewed by Adam Barth.

        Add new LocalStorage layout tests.
        https://bugs.webkit.org/show_bug.cgi?id=27778

        These test behavior that I don't think was very well verified earlier.

        * storage/domstorage/localstorage/complex-keys-expected.txt: Added.
        * storage/domstorage/localstorage/complex-keys.html: Added.
              A bunch of corner cases related to keys.
        * storage/domstorage/localstorage/complex-values-expected.txt: Added.
        * storage/domstorage/localstorage/complex-values.html: Added.
              A bunch of corner cases related to values.
        * storage/domstorage/localstorage/remove-item-expected.txt: Added.
        * storage/domstorage/localstorage/remove-item.html: Added.
              Test basic removeItem functionality.



git-svn-id: http://svn.webkit.org/repository/webkit/trunk@46639 268f45cc-cd09-0410-ab3c-d52691b4dbfc

        Reviewed by Dan Bernstein.

        -Fix <rdar://problem/7104097>

        Make EmbeddedWidget::create return a PassRefPtr so it will have the correct ref count.
        
        * WebCoreSupport/EmbeddedWidget.cpp:
        (EmbeddedWidget::create):
        * WebCoreSupport/EmbeddedWidget.h:



git-svn-id: http://svn.webkit.org/repository/webkit/trunk@46638 268f45cc-cd09-0410-ab3c-d52691b4dbfc

        Reviewed by David Kilzer.

        bugzilla-tool post-commits obsoletes its own work :(
        https://bugs.webkit.org/show_bug.cgi?id=27849

        Simple fix.  Use .add() instead of .update()

        * Scripts/bugzilla-tool:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@46637 268f45cc-cd09-0410-ab3c-d52691b4dbfc

        Reviewed by David Levin.

        Guard needs //'s between #endif and ENABLE(DATAGRID)
        https://bugs.webkit.org/show_bug.cgi?id=27862

        Compiling this file causes a build break without this change.

        * bindings/v8/custom/V8DataGridColumnListCustom.cpp:



git-svn-id: http://svn.webkit.org/repository/webkit/trunk@46636 268f45cc-cd09-0410-ab3c-d52691b4dbfc

        Reviewed by Adam Treat.

        Re-Enable tests from Skipped that are passing correctly.

        https://bugs.webkit.org/show_bug.cgi?id=27890

        * platform/qt/Skipped:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@46635 268f45cc-cd09-0410-ab3c-d52691b4dbfc

        Reviewed by Adam Treat.

        Add LayoutTest results from BuildBot output for tests that currently lack results under Qt.

        https://bugs.webkit.org/show_bug.cgi?id=27882

        * platform/qt/fast/backgrounds/size/backgroundSize20-expected.txt: Copied from LayoutTests/platform/mac/fast/backgrounds/size/backgroundSize20-expected.txt.
        * platform/qt/fast/backgrounds/size/backgroundSize21-expected.txt: Copied from LayoutTests/platform/mac/fast/backgrounds/size/backgroundSize21-expected.txt.
        * platform/qt/fast/backgrounds/size/backgroundSize22-expected.txt: Copied from LayoutTests/platform/mac/fast/backgrounds/size/backgroundSize22-expected.txt.
        * platform/qt/fast/borders/border-radius-constraints-expected.txt: Added.
        * platform/qt/fast/box-shadow/inset-expected.txt: Added.
        * platform/qt/fast/box-shadow/spread-expected.txt: Copied from LayoutTests/platform/mac/fast/box-shadow/spread-expected.txt.
        * platform/qt/fast/canvas/image-pattern-rotate-expected.txt: Added.
        * platform/qt/fast/css/nested-floating-relative-position-percentages-expected.txt: Added.
        * platform/qt/fast/css/pseudo-cache-stale-expected.txt: Added.
        * platform/qt/fast/css/rem-dynamic-scaling-expected.txt: Added.
        * platform/qt/fast/css/rem-units-on-root-expected.txt: Added.
        * platform/qt/fast/dynamic/window-resize-scrollbars-test-expected.txt: Added.
        * platform/qt/fast/dynamic/window-scrollbars-test-expected.txt: Added.
        * platform/qt/fast/forms/isindex-placeholder-expected.txt: Added.
        * platform/qt/fast/forms/search-vertical-alignment-expected.txt: Added.
        * platform/qt/fast/frames/content-opacity-1-expected.txt: Copied from LayoutTests/platform/mac/fast/frames/content-opacity-1-expected.txt.
        * platform/qt/fast/frames/content-opacity-2-expected.txt: Copied from LayoutTests/platform/mac/fast/frames/content-opacity-2-expected.txt.
        * platform/qt/fast/frames/frame-navigation-expected.txt: Added.
        * platform/qt/fast/frames/frame-scrolling-attribute-expected.txt: Added.
        * platform/qt/fast/frames/iframe-scrolling-attribute-expected.txt: Added.
        * platform/qt/fast/gradients/crash-on-zero-radius-expected.txt: Added.
        * platform/qt/fast/lists/ol-start-parsing-expected.txt: Added.
        * platform/qt/fast/overflow/overflow-with-local-background-attachment-expected.txt: Added.
        * platform/qt/fast/repaint/float-new-in-block-expected.txt: Copied from LayoutTests/platform/mac/fast/repaint/float-new-in-block-expected.txt.
        * platform/qt/fast/text/international/khmer-selection-expected.txt: Added.
        * platform/qt/fast/text/shadow-translucent-fill-expected.txt: Added.
        * platform/qt/fast/text/text-letter-spacing-expected.txt: Added.
        * platform/qt/plugins/netscape-dom-access-expected.txt: Added.
        * platform/qt/svg/batik/filters/feTile-expected.txt: Added.
        * platform/qt/svg/custom/createImageElement-expected.txt: Copied from LayoutTests/platform/mac/svg/custom/createImageElement-expected.txt.
        * platform/qt/svg/custom/createImageElement2-expected.txt: Added.
        * platform/qt/svg/custom/js-update-image-and-display-expected.txt: Copied from LayoutTests/platform/mac/svg/custom/js-update-image-and-display-expected.txt.
        * platform/qt/svg/custom/js-update-image-and-display2-expected.txt: Copied from LayoutTests/platform/mac/svg/custom/js-update-image-and-display2-expected.txt.
        * platform/qt/svg/custom/js-update-image-and-display3-expected.txt: Copied from LayoutTests/platform/mac/svg/custom/js-update-image-and-display3-expected.txt.
        * platform/qt/svg/custom/outer-svg-unknown-feature-expected.txt: Copied from LayoutTests/platform/mac/svg/custom/outer-svg-unknown-feature-expected.txt.
        * platform/qt/svg/filters/feMerge-expected.txt: Added.
        * platform/qt/svg/filters/feOffset-expected.txt: Added.
        * platform/qt/svg/filters/feTile-expected.txt: Added.
        * platform/qt/svg/filters/subRegion-one-effect-expected.txt: Added.
        * platform/qt/svg/filters/subRegion-two-effects-expected.txt: Added.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@46634 268f45cc-cd09-0410-ab3c-d52691b4dbfc

        Reviewed by George Staikos.

        Consolidate GeoLocation code to send positions and errors
        https://bugs.webkit.org/show_bug.cgi?id=27863

        Create helper methods that will send positions and errors to either
        one shots or watchers.

        * page/Geolocation.cpp:
        (WebCore::Geolocation::sendError):
        (WebCore::Geolocation::sendErrorToOneShots):
        (WebCore::Geolocation::sendErrorToWatchers):
        (WebCore::Geolocation::sendPosition):
        (WebCore::Geolocation::sendPositionToOneShots):
        (WebCore::Geolocation::sendPositionToWatchers):
        * page/Geolocation.h:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@46633 268f45cc-cd09-0410-ab3c-d52691b4dbfc

        Reviewed by Adam Treat.

        Build QtWebKit without benchmark tests for Qt < 4.5.
        https://bugs.webkit.org/show_bug.cgi?id=27886

        The QBENCHMARK macro is only available from 4.5 on,
        so builds for Qt < 4.5 shouldn't try to build those.

        * tests/tests.pro:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@46632 268f45cc-cd09-0410-ab3c-d52691b4dbfc

        Reviewed by Anders Carlsson.

        Improve platform-detection in run-webkit-tests

        This prevents miss-detection of mac-* over Qt/Mac.

        * Scripts/run-webkit-tests:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@46631 268f45cc-cd09-0410-ab3c-d52691b4dbfc

        Reviewed by Adam Treat.

        Fix warning by migrating use of QString.sprintf(...) to
        QString.arg().arg()...

        * WebCoreSupport/EditorClientQt.cpp:
        (dumpRange):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@46630 268f45cc-cd09-0410-ab3c-d52691b4dbfc

        Reviewed by Tor Arne Vestbo.

        Adding -webkit-animation-play-state back in following r46547.

        * platform/qt/fast/css/getComputedStyle/computed-style-expected.txt:
        * platform/qt/fast/css/getComputedStyle/computed-style-without-renderer-expected.txt:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@46629 268f45cc-cd09-0410-ab3c-d52691b4dbfc

        Reviewed by Tor Arne Vestbø.

        Expose the Offline Web Application Cache in the Qt API.

        * Api/qwebsettings.cpp:
        (QWebSettings::QWebSettings):
        (QWebSettings::setOfflineWebApplicationCachePath):
        (QWebSettings::offlineWebApplicationCachePath):
        (QWebSettings::setOfflineWebApplicationCacheQuota):
        (QWebSettings::offlineWebApplicationCacheQuota):
        * Api/qwebsettings.h:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@46628 268f45cc-cd09-0410-ab3c-d52691b4dbfc

        Roll out previous change as it might be causing some weirdness in
        the bots.

        * platform/image-decoders/bmp/BMPImageDecoder.cpp:
        (WebCore::BMPImageDecoder::processFileHeader):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@46627 268f45cc-cd09-0410-ab3c-d52691b4dbfc

        Reviewed by Mark Rowe.

        Fix compiler warning.
        https://bugs.webkit.org/show_bug.cgi?id=27851

        GCC does not like multi-character character constants, so use the
        explicit numerical value of 'BM' in the enum.

        * platform/image-decoders/bmp/BMPImageDecoder.cpp:
        (WebCore::BMPImageDecoder::processFileHeader):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@46626 268f45cc-cd09-0410-ab3c-d52691b4dbfc

* http/tests/misc/meta-refresh-stray-single-quote.html:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@46625 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2009-07-30  Brady Eidson  <beidson@apple.com>

        Reviewed by Mark Rowe, but Dan Bernstein also reviewed and asked thoughtful questions.

        <rdar://problem/7106968> and https://bugs.webkit.org/show_bug.cgi?id=27868
        http://www.ruthhuntcandy.com/ goes into infinite refresh in WebKit, works in others.
        
        Test: http/tests/misc/meta-refresh-stray-single-quote.html

        * platform/network/HTTPParsers.cpp:
        (WebCore::parseHTTPRefresh): Allow for a stray quote character at the start of the URL string.

LayoutTests:

2009-07-30  Brady Eidson  <beidson@apple.com>

        Reviewed by Mark Rowe, but Dan Bernstein also reviewed and asked thoughtful questions.

        <rdar://problem/7106968> and https://bugs.webkit.org/show_bug.cgi?id=27868
        http://www.ruthhuntcandy.com/ goes into infinite refresh in WebKit, works in others.

        * http/tests/misc/meta-refresh-stray-single-quote-expected.txt: Added.
        * http/tests/misc/meta-refresh-stray-single-quote.html: Added.
        * http/tests/misc/resources/success-notify-done.html: Added.



git-svn-id: http://svn.webkit.org/repository/webkit/trunk@46624 268f45cc-cd09-0410-ab3c-d52691b4dbfc

        Reviewed by Jan Alonzo.

        Fix compiler warning.

        GCC does not like C++-style comments in preprocessor directives.

        * wtf/Platform.h:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@46623 268f45cc-cd09-0410-ab3c-d52691b4dbfc

        Reviewed by Xan Lopez, Gustavo Noronha and Jan Alonzo.

        [GTK] new-window-policy-decision-requested provides no information about the target frame
        https://bugs.webkit.org/show_bug.cgi?id=27792

        Add frameName property to the WebKitWebNavigation object.

        * WebCoreSupport/FrameLoaderClientGtk.cpp:
        (WebKit::getNavigationAction):
        (WebKit::FrameLoaderClient::dispatchDecidePolicyForNewWindowAction):
        (WebKit::FrameLoaderClient::dispatchDecidePolicyForNavigationAction):
        * webkit/webkitwebnavigationaction.cpp:
        (webkit_web_navigation_action_get_property):
        (webkit_web_navigation_action_set_property):
        (webkit_web_navigation_action_class_init):
        (webkit_web_navigation_action_get_target_frame):
        (webkit_web_navigation_action_set_target_frame):
        * webkit/webkitwebnavigationaction.h:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@46622 268f45cc-cd09-0410-ab3c-d52691b4dbfc

        Reviewed by Gavin Barraclough.

        Optimize the X86_64 trampolines: avoid the need for filler arguments
        and move the stub-args area closer to the stack pointer.

        * jit/JIT.h: adjust patch offsets because of slight code-size change 
        * jit/JITCode.h:
        (JSC::JITCode::execute): don't pass filler args
        * jit/JITStubs.cpp:
        (ctiTrampoline): (X86_64): push args onto stack, use args directly
        (ctiVMThrowTrampoline): (X86_64): adjust %rsp by correct displacement
        (ctiOpThrowNotCaught): (X86_64): adjust %rsp by correct displacement
        * jit/JITStubs.h:
        (JITStackFrame): (X86_64): move args area earlier
        (ctiTrampoline): remove filler args from prototype



git-svn-id: http://svn.webkit.org/repository/webkit/trunk@46621 268f45cc-cd09-0410-ab3c-d52691b4dbfc

        Reviewed by NOBODY (build fix).

        Temporarily revert r46618 since this is b0rking on Linux.



git-svn-id: http://svn.webkit.org/repository/webkit/trunk@46620 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Reviewed by Cameron Zwarich.

* BuildSlaveSupport/build.webkit.org-config/master.cfg:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@46619 268f45cc-cd09-0410-ab3c-d52691b4dbfc

        Reviewed by Oliver Hunt.

        Make get_by_id/put_by_id/method_check/call defer optimization using a data flag rather than a code modification.
        ( https://bugs.webkit.org/show_bug.cgi?id=27635 )

        This improves performance of ENABLE(ASSEMBLER_WX_EXCLUSIVE) builds by 2-2.5%, reducing the overhead to about 2.5%.
        (No performance impact with ASSEMBLER_WX_EXCLUSIVE disabled).

        * bytecode/CodeBlock.cpp:
        (JSC::printStructureStubInfo):
            - Make StructureStubInfo store the type as an integer, rather than an OpcodeID.

        * bytecode/CodeBlock.h:
        (JSC::):
        (JSC::CallLinkInfo::seenOnce):
        (JSC::CallLinkInfo::setSeen):
        (JSC::MethodCallLinkInfo::seenOnce):
        (JSC::MethodCallLinkInfo::setSeen):
            - Change a pointer in CallLinkInfo/MethodCallLinkInfo to use a PtrAndFlags, use a flag to track when an op has been executed once.

        * bytecode/StructureStubInfo.cpp:
        (JSC::StructureStubInfo::deref):
            - Make StructureStubInfo store the type as an integer, rather than an OpcodeID.

        * bytecode/StructureStubInfo.h:
        (JSC::StructureStubInfo::StructureStubInfo):
        (JSC::StructureStubInfo::initGetByIdSelf):
        (JSC::StructureStubInfo::initGetByIdProto):
        (JSC::StructureStubInfo::initGetByIdChain):
        (JSC::StructureStubInfo::initGetByIdSelfList):
        (JSC::StructureStubInfo::initGetByIdProtoList):
        (JSC::StructureStubInfo::initPutByIdTransition):
        (JSC::StructureStubInfo::initPutByIdReplace):
        (JSC::StructureStubInfo::seenOnce):
        (JSC::StructureStubInfo::setSeen):
            - Make StructureStubInfo store the type as an integer, rather than an OpcodeID, add a flag to track when an op has been executed once.

        * bytecompiler/BytecodeGenerator.cpp:
        (JSC::BytecodeGenerator::emitGetById):
        (JSC::BytecodeGenerator::emitPutById):
            - Make StructureStubInfo store the type as an integer, rather than an OpcodeID.

        * jit/JIT.cpp:
        (JSC::JIT::privateCompileCTIMachineTrampolines):
        (JSC::JIT::unlinkCall):
            - Remove the "don't lazy link" stage of calls.

        * jit/JIT.h:
        (JSC::JIT::compileCTIMachineTrampolines):
            - Remove the "don't lazy link" stage of calls.

        * jit/JITCall.cpp:
        (JSC::JIT::compileOpCallSlowCase):
            - Remove the "don't lazy link" stage of calls.

        * jit/JITStubs.cpp:
        (JSC::JITThunks::JITThunks):
        (JSC::JITThunks::tryCachePutByID):
        (JSC::JITThunks::tryCacheGetByID):
        (JSC::JITStubs::DEFINE_STUB_FUNCTION):
        (JSC::JITStubs::getPolymorphicAccessStructureListSlot):
            - Remove the "don't lazy link" stage of calls, and the "_second" stage of get_by_id/put_by_id/method_check.

        * jit/JITStubs.h:
        (JSC::JITThunks::ctiStringLengthTrampoline):
        (JSC::JITStubs::):
            - Remove the "don't lazy link" stage of calls, and the "_second" stage of get_by_id/put_by_id/method_check.

        * wtf/PtrAndFlags.h:
        (WTF::PtrAndFlags::PtrAndFlags):
        (WTF::PtrAndFlags::operator!):
        (WTF::PtrAndFlags::operator->):
            - Add ! and -> operators, add constuctor with pointer argument.



git-svn-id: http://svn.webkit.org/repository/webkit/trunk@46618 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Fix <https://bugs.webkit.org/show_bug.cgi?id=27828> for Mac.

Reviewed by Adele Peterson and Jon Honeycutt.

No tests added as it is not clear how to test a tool tip from DumpRenderTree.

* platform/PopupMenuClient.h: Add a method for retrieving the tool tip of an item.
* platform/mac/PopupMenuMac.mm:
(WebCore::PopupMenu::populate): Set the tool tip of the menu item to that of the represented item.
* rendering/RenderMenuList.cpp:
(WebCore::RenderMenuList::itemToolTip): Expose the title attribute of the element as the tool tip.
* rendering/RenderMenuList.h:
* rendering/RenderTextControlSingleLine.h:
(WebCore::RenderTextControlSingleLine::itemToolTip): Return an empty string, indicating no tool tip, for
the popup menu in RenderTextControlSingleLine.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@46617 268f45cc-cd09-0410-ab3c-d52691b4dbfc

* Scripts/run-webkit-tests:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@46616 268f45cc-cd09-0410-ab3c-d52691b4dbfc

* Scripts/run-webkit-tests:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@46615 268f45cc-cd09-0410-ab3c-d52691b4dbfc

        Add expected results file for new test.

        * platform/gtk/fast/forms/button-style-color-expected.txt: Added.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@46614 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Hopefully this will make the Windows build bot happy.

* Scripts/run-webkit-tests:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@46613 268f45cc-cd09-0410-ab3c-d52691b4dbfc

        Add expected results file for new test.

        * platform/mac/fast/forms/button-style-color-expected.txt: Added.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@46612 268f45cc-cd09-0410-ab3c-d52691b4dbfc

        Reviewed by Dan Bernstein.

        Remove ChromeClientChromium::setToolTip().
        https://bugs.webkit.org/show_bug.cgi?id=27861

        This patch is just to remove a temporarily introduced overloaded empty
        virtual function. No test is needed.

        * page/chromium/ChromeClientChromium.h:



git-svn-id: http://svn.webkit.org/repository/webkit/trunk@46611 268f45cc-cd09-0410-ab3c-d52691b4dbfc

        Reviewed by Gavin Barraclough.

        Fixed failing tests seen on Windows buildbot.

        * jit/JITStubs.cpp:
        (JSC::DEFINE_STUB_FUNCTION):
        * jit/JITStubs.h:
        (JSC::): Use "int" instead of "bool" to guarantee a 32-bit result,
        regardless of compiler. gcc on mac uses 32-bit values for bool,
        but gcc on linux and MSVC on Windows use 8-bit values.



git-svn-id: http://svn.webkit.org/repository/webkit/trunk@46610 268f45cc-cd09-0410-ab3c-d52691b4dbfc

        Reviewed by Darin Fisher.

        https://bugs.webkit.org/show_bug.cgi?id=27821

        ApplicationCacheHost refactoring.
        
        1) Better encapsulate the interfaces between webcore common code
        and the appcache system within a new class ApplicationCacheHost.

        2) Use that interface throughout the loader system, replacing inline appcache logic.

        3) Implement the interface in terms of webcore's appcache system.

        4) Add the new files to various makefiles.

        5) Implement protocolHostAndPortAreEqual() in KURLGoogle.cpp

        No new features, no new tests. The existing layout tests all pass.

        * GNUmakefile.am:
        * WebCore.base.exp:
        * WebCore.gypi:
        * WebCore.pro:
        * WebCore.vcproj/WebCore.vcproj:
        * WebCore.xcodeproj/project.pbxproj:
        * WebCoreSources.bkl:
        * html/HTMLHtmlElement.cpp:
        (WebCore::HTMLHtmlElement::insertedIntoDocument):
   ...

        Reviewed by Mark Rowe.

        Revert previous commit to test out new functionality of buildbots and
        run-webkit-tests made possible by r46607.

        * platform/gtk/Skipped:
        * platform/mac/Skipped:
        * platform/win/Skipped:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@46608 268f45cc-cd09-0410-ab3c-d52691b4dbfc