1. 31 Jan, 2012 40 commits
    • oliver@apple.com's avatar
      Implement Error.stack · 435c2e23
      oliver@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=66994
      
      Source/JavaScriptCore:
      
      Reviewed by Gavin Barraclough.
      
      Original patch by Juan Carlos Montemayor Elosua:
          This patch utilizes topCallFrame to create a stack trace when
          an error is thrown. Users will also be able to use the stack()
          command in jsc to get arrays with stack trace information.
      
      Modified to be correct on ToT, with a variety of correctness,
      performance, and security improvements.
      
      * JavaScriptCore.exp:
      * JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:
      * interpreter/Interpreter.cpp:
      (JSC::getCallerLine):
      (JSC::getSourceURLFromCallFrame):
      (JSC::getStackFrameCodeType):
      (JSC::Interpreter::getStackTrace):
      (JSC::Interpreter::throwException):
      * interpreter/Interpreter.h:
      (JSC::StackFrame::toString):
      * jsc.cpp:
      (GlobalObject::finishCreation):
      (functionJSCStack):
      * parser/Parser.h:
      (JSC::Parser::parse):
      * runtime/CommonIdentifiers.h:
      * runtime/Error.cpp:
      (JSC::addErrorInfo):
      * runtime/Error.h:
      
      LayoutTests:
      
      Reviewed by Gavin Barraclough
      
      Original patch by Juan Carlos Montemayor Elosua.
      
      Unit tests that contain both normal and special cases for stack trace
      generation.
      
      * fast/js/exception-properties-expected.txt:
      * fast/js/script-tests/exception-properties.js:
      * fast/js/script-tests/stack-trace.js: Added.
      (printStack):
      (hostThrower):
      (callbacker):
      (outer):
      (inner):
      (evaler):
      (normalOuter):
      (normalInner):
      (scripterInner):
      (scripterOuter):
      * fast/js/stack-trace-expected.txt: Added.
      * fast/js/stack-trace.html: Added.
      * platform/chromium/test_expectations.txt:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@106407 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      435c2e23
    • commit-queue@webkit.org's avatar
      [chromium] Compositor debug borders are not scaled correctly · 30cb5d6c
      commit-queue@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=77468
      
      Use CCLayerImpl::contentBounds() instead of CCLayerImpl::bounds() to calculate debug
      border geometry so that the borders are properly scaled.
      
      Patch by Sami Kyostila <skyostil@chromium.org> on 2012-01-31
      Reviewed by James Robinson.
      
      * platform/graphics/chromium/cc/CCLayerImpl.cpp:
      (WebCore::CCLayerImpl::appendDebugBorderQuad):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@106406 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      30cb5d6c
    • jsbell@chromium.org's avatar
      IndexedDB: Re-enable structured-clone test · f045391a
      jsbell@chromium.org authored
      https://bugs.webkit.org/show_bug.cgi?id=77239
      
      This test was landed disabled, since it was failing. Turns out Date serialization
      differs ("PST" vs. "Pacific Standard Time") across machines, so debug statements
      in the test were removed.
      
      Reviewed by Tony Chang.
      
      * platform/chromium/test_expectations.txt:
      * storage/indexeddb/structured-clone-expected.txt:
      * storage/indexeddb/structured-clone.html:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@106405 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      f045391a
    • commit-queue@webkit.org's avatar
      Fix the update_webgl_conformance_tests.py script in order to enable it · a9dfbe67
      commit-queue@webkit.org authored
      to detect the SCM being used correctly.
      https://bugs.webkit.org/show_bug.cgi?id=77462
      
      Patch by Ehsan Akhgari <ehsan.akhgari@gmail.com> on 2012-01-31
      Reviewed by Kenneth Russell.
      
      * Scripts/webkitpy/to_be_moved/update_webgl_conformance_tests.py:
      (default_out_dir):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@106404 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      a9dfbe67
    • kbalazs@webkit.org's avatar
      [Qt][WK2] bot lacks mobility · d50bf99d
      kbalazs@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=68243
      
      Unreviewed gardening.
      Removing tests from skipped list. These tests are no
      longer failing since the Qt5 tree we use includes
      the required modules that used to live in mobility.
      
      * platform/qt-wk2/Skipped:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@106403 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      d50bf99d
    • antti@apple.com's avatar
      Try to fix Qt build. · 82c7b400
      antti@apple.com authored
      Not reviewed.
      
      * Api/qwebelement.cpp:
      (QWebElement::styleProperty):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@106402 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      82c7b400
    • thakis@chromium.org's avatar
      [chromium] Expose windowResizerRectChanged() on WebWidget. · 0bc95091
      thakis@chromium.org authored
      https://bugs.webkit.org/show_bug.cgi?id=77453
      
      Needed for http://crbug.com/111266
      
      Reviewed by Darin Fisher.
      
      * public/WebWidget.h:
      (WebWidget):
      (WebKit::WebWidget::didChangeWindowResizerRect):
      * src/WebViewImpl.cpp:
      (WebKit::WebViewImpl::didChangeWindowResizerRect):
      (WebKit):
      * src/WebViewImpl.h:
      (WebViewImpl):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@106401 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      0bc95091
    • commit-queue@webkit.org's avatar
      Unreviewed, rolling out r106376. · 29026e7a
      commit-queue@webkit.org authored
      http://trac.webkit.org/changeset/106376
      https://bugs.webkit.org/show_bug.cgi?id=77481
      
      Broke WebGLLayerChromiumTest in webkit_unit_tests (Requested
      by kbr_google on #webkit).
      
      Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-01-31
      
      Source/WebCore:
      
      * platform/graphics/gpu/DrawingBuffer.cpp:
      (WebCore):
      (WebCore::DrawingBuffer::reset):
      
      LayoutTests:
      
      * platform/chromium/test_expectations.txt:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@106400 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      29026e7a
    • nduca@chromium.org's avatar
      [chromium] Import PaintAggregator · d43044ff
      nduca@chromium.org authored
      https://bugs.webkit.org/show_bug.cgi?id=53715
      
      Reviewed by Darin Fisher.
      
      * WebKit.gyp:
      * WebKit.gypi:
      * src/painting/PaintAggregator.cpp: Added.
      (WebKit::calculateArea):
      (WebKit::subtractIntersection):
      (WebKit::sharesEdge):
      (WebKit::PaintAggregator::PendingUpdate::PendingUpdate):
      (WebKit::PaintAggregator::PendingUpdate::~PendingUpdate):
      (WebKit::PaintAggregator::PendingUpdate::calculateScrollDamage):
      (WebKit::PaintAggregator::PendingUpdate::calculatePaintBounds):
      (WebKit::PaintAggregator::hasPendingUpdate):
      (WebKit::PaintAggregator::clearPendingUpdate):
      (WebKit::PaintAggregator::popPendingUpdate):
      (WebKit::PaintAggregator::invalidateRect):
      (WebKit::PaintAggregator::scrollRect):
      (WebKit::PaintAggregator::scrollPaintRect):
      (WebKit::PaintAggregator::shouldInvalidateScrollRect):
      (WebKit::PaintAggregator::invalidateScrollRect):
      (WebKit::PaintAggregator::combinePaintRects):
      * src/painting/PaintAggregator.h: Added.
      * tests/PaintAggregatorTest.cpp: Added.
      (WebKit::TEST):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@106399 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      d43044ff
    • mihnea@adobe.com's avatar
      [CSSRegions]Reduce the cases when the box style in region is computed · 7e2f2aaf
      mihnea@adobe.com authored
      https://bugs.webkit.org/show_bug.cgi?id=77446
      
      Reviewed by David Hyatt.
      
      Covered by existing region style tests.
      
      * rendering/RenderRegion.cpp:
      (WebCore::RenderRegion::setRegionBoxesRegionStyle):
      (WebCore::RenderRegion::restoreRegionBoxesOriginalStyle):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@106398 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      7e2f2aaf
    • andersca@apple.com's avatar
      Put tiles in a HashMap · cf93e0bc
      andersca@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=77480
      
      Reviewed by Antti Koivisto.
      
      Put tiles in a hash map keyed off the tile index.
      
      * platform/graphics/ca/mac/TileCache.h:
      Shuffle member variables around so the order makes more sense.
      Add the tile map.
      
      * platform/graphics/ca/mac/TileCache.mm:
      (WebCore::TileCache::TileCache):
      Update member initializers.
      
      (WebCore::TileCache::setNeedsDisplayInRect):
      Call tileLayerAtIndex instead of tileLayerAtPosition.
      
      (WebCore::TileCache::setAcceleratesDrawing):
      (WebCore::TileCache::setTileDebugBorderWidth):
      (WebCore::TileCache::setTileDebugBorderColor):
      Iterate over the hash map instead of the sublayers.
      
      (WebCore::TileCache::resizeTileGrid):
      Add the created layers to the map.
      
      (WebCore::TileCache::tileLayerAtIndex):
      Rename from tileLayerAtPoint to better reflect that this member function
      returns a tile layer at the given index and not the given point.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@106397 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      cf93e0bc
    • eric@webkit.org's avatar
      webkit-patch apply-from-bug should work regardless of your CWD · 809dfd6d
      eric@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=77482
      
      Reviewed by Adam Barth.
      
      webkit-patch only ever works with patches made from the root
      directory.  We should pass the CWD to svn-apply in the case
      where we're running not from the webkit root.  I believe
      this used to work in the past and regressed.
      
      * Scripts/webkitpy/common/checkout/checkout.py:
      (Checkout.apply_patch):
      * Scripts/webkitpy/common/checkout/checkout_unittest.py:
      (CheckoutTest.test_apply_patch):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@106396 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      809dfd6d
    • fsamuel@chromium.org's avatar
      [Chromium] ChromeClientImpl::dispatchViewportPropertiesDidChange is repeatedly... · 3bdd729a
      fsamuel@chromium.org authored
      [Chromium] ChromeClientImpl::dispatchViewportPropertiesDidChange is repeatedly called in Google News
      https://bugs.webkit.org/show_bug.cgi?id=77429
      
      Reviewed by Darin Fisher.
      
      m_webView->isPageScaleFactorSet() is tested in ChromeClientImpl::layoutUpdated, and it is never true,
      because WebViewImpl::setPageScaleFactorPreservingScrollOffset is called repeatedly and exits early
      and thus never calls WebViewImpl::setPageScaleFactor which sets the flag.
      
      The simplest solution is to simply get rid of the early return in
      WebViewImpl::setPageScaleFactorPreservingScrollOffset.
      
      * src/WebViewImpl.cpp:
      (WebKit::WebViewImpl::setPageScaleFactorPreservingScrollOffset):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@106395 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      3bdd729a
    • fsamuel@chromium.org's avatar
      [Chromium] Expose setLayoutFallbackWidth as a WebSetting · 0a03d722
      fsamuel@chromium.org authored
      https://bugs.webkit.org/show_bug.cgi?id=77431
      
      Reviewed by Darin Fisher.
      
      The layout fallback width is the default fixed layout width
      set for desktop web pages that lack a viewport tag. This width
      can vary from platform to platform and can depend on other factors,
      and so it should be a setting exposed to Chromium.
      
      * public/WebSettings.h:
      ():
      * src/WebSettingsImpl.cpp:
      (WebKit::WebSettingsImpl::setLayoutFallbackWidth):
      (WebKit):
      * src/WebSettingsImpl.h:
      (WebSettingsImpl):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@106394 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      0a03d722
    • antti@apple.com's avatar
      Make CSSOM style() return CSSStyleDeclaration* · 9ef12a29
      antti@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=77475
      
      Reviewed by Anders Carlsson
      
      CSSStyleRule::style() and some other places return CSSMutableStyleDeclaration. 
      They should return the plain CSSOM type instead.
              
      CSSMutableStyleDeclaration* should be available through non-CSSOM function.
      
      * css/CSSFontFaceRule.h:
      (WebCore::CSSFontFaceRule::style):
      (WebCore::CSSFontFaceRule::declaration):
      * css/CSSFontSelector.cpp:
      (WebCore::CSSFontSelector::addFontFaceRule):
      * css/CSSStyleRule.h:
      (WebCore::CSSStyleRule::style):
      (WebCore::CSSStyleRule::declaration):
      * css/CSSStyleSelector.cpp:
      (WebCore::CSSStyleSelector::styleForKeyframe):
      * css/WebKitCSSKeyframeRule.h:
      (WebCore):
      (WebCore::WebKitCSSKeyframeRule::style):
      (WebCore::WebKitCSSKeyframeRule::declaration):
      (WebKitCSSKeyframeRule):
      * editing/EditingStyle.cpp:
      (WebCore::styleFromMatchedRulesForElement):
      * inspector/InspectorStyleSheet.cpp:
      (WebCore::InspectorStyleSheet::revalidateStyle):
      * page/PageSerializer.cpp:
      (WebCore::PageSerializer::retrieveResourcesForCSSRule):
      * svg/SVGFontFaceElement.cpp:
      (WebCore::SVGFontFaceElement::parseMappedAttribute):
      (WebCore::SVGFontFaceElement::fontFamily):
      (WebCore::SVGFontFaceElement::rebuildFontFace):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@106393 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      9ef12a29
    • dgrogan@chromium.org's avatar
      IndexedDB: refactor basics layout test so that it can be run on workers. · d4a07657
      dgrogan@chromium.org authored
      https://bugs.webkit.org/show_bug.cgi?id=76683
      
      Reviewed by Tony Chang.
      
      * storage/indexeddb/basics-workers-expected.txt: Added.
      * storage/indexeddb/basics-workers.html: Added.
      * storage/indexeddb/basics.html:
      * storage/indexeddb/resources/basics.js: Copied from LayoutTests/storage/indexeddb/basics.html.
      (test):
      (openCallback):
      * storage/indexeddb/resources/idb-worker-common.js: Added.
      (debug):
      (finishJSTest):
      (description):
      (testPassed):
      (testFailed):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@106392 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      d4a07657
    • commit-queue@webkit.org's avatar
      [Chromium] Remove references to gyp cygwin build target · 821fd116
      commit-queue@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=77253
      
      Patch by Scott Graham <scottmg@chromium.org> on 2012-01-31
      Reviewed by Julien Chaffraix.
      
      Target dependency is no longer required, it's done earlier in the
      build process.
      
      Source/JavaScriptCore:
      
      * JavaScriptCore.gyp/JavaScriptCore.gyp:
      
      Source/WebCore:
      
      * WebCore.gyp/WebCore.gyp:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@106391 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      821fd116
    • eric@webkit.org's avatar
      Rebaseline results after http://trac.webkit.org/changeset/106373 · 998b7735
      eric@webkit.org authored
      Unreviewed.
      
      * fast/forms/implicit-submission-expected.txt:
      * platform/chromium-mac/fast/dom/Window/window-lookup-precedence-expected.txt: Removed.
      * platform/chromium-mac/fast/dom/wrapper-classes-expected.txt: Removed.
      * platform/chromium-win/fast/forms/implicit-submission-expected.txt:
      * platform/chromium/fast/dom/Window/element-constructors-on-window-expected.txt:
      * platform/chromium/fast/dom/Window/window-lookup-precedence-expected.txt:
      * platform/chromium/fast/dom/wrapper-classes-expected.txt:
      * platform/mac/fast/forms/implicit-submission-expected.txt: Copied from LayoutTests/fast/forms/implicit-submission-expected.txt.
      * platform/qt/fast/forms/implicit-submission-expected.txt: Removed.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@106390 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      998b7735
    • ojan@chromium.org's avatar
      Unreviewed, rolling out r106302. · 50853f75
      ojan@chromium.org authored
      http://trac.webkit.org/changeset/106302
      https://bugs.webkit.org/show_bug.cgi?id=77472
      
      Broke building DRT before running the tests (Requested by ojan
      on #webkit).
      
      Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-01-31
      
      * Scripts/webkit-build-directory:
      * Scripts/webkitpy/layout_tests/port/config.py:
      (Config.build_directory):
      * Scripts/webkitpy/layout_tests/port/config_standalone.py:
      (main):
      * Scripts/webkitpy/layout_tests/port/config_unittest.py:
      (ConfigTest.assert_configuration):
      (ConfigTest.test_build_directory.mock_webkit_build_directory):
      (ConfigTest.test_build_directory):
      (ConfigTest.test_default_configuration__notfound):
      * Scripts/webkitpy/layout_tests/port/webkit.py:
      (WebKitPort._build_path):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@106389 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      50853f75
    • jonlee@apple.com's avatar
      Hidden form elements do not save their state prior to form submission · 5687a0fe
      jonlee@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=77391
      <rdar://problem/10563108>
      
      Reviewed by Brady Eidson.
      
      Source/WebCore:
      
      Test: fast/forms/state-restore-hidden.html
      
      * html/HiddenInputType.cpp: Teach hidden inputs to save and restore their state.
      (WebCore::HiddenInputType::saveFormControlState):
      (WebCore::HiddenInputType::restoreFormControlState):
      * html/HiddenInputType.h:
      (HiddenInputType):
      
      LayoutTests:
      
      The test changes the value of the hidden input element via Javascript prior to
      submitting the form. The form action goes back one page, and we check to see
      that the hidden input value is what it was set to by Javascript, rather than what
      it was originally assigned.
      
      * fast/forms/state-restore-hidden-expected.txt: Added.
      * fast/forms/state-restore-hidden.html: Added.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@106388 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      5687a0fe
    • jsbell@chromium.org's avatar
      IndexedDB: IDBCursor.update() should raise exception if key changed · c410ea2f
      jsbell@chromium.org authored
      https://bugs.webkit.org/show_bug.cgi?id=76952
      
      Source/WebCore:
      
      Move the test from the async task to the synchronous call, per spec. Also re-ordered the tests
      done during the synchronous call and the asynchronous task to follow the spec order.
      
      Reviewed by Tony Chang.
      
      Tests: storage/indexeddb/cursor-update.html
      
      * storage/IDBObjectStoreBackendImpl.cpp:
      (WebCore::IDBObjectStoreBackendImpl::put): Added check during update() call, order checks per spec.
      (WebCore::IDBObjectStoreBackendImpl::putInternal): Move effective key calculation inline.
      * storage/IDBObjectStoreBackendImpl.h: Removed selectKeyForPut method.
      
      LayoutTests:
      
      Reviewed by Tony Chang.
      
      * storage/indexeddb/cursor-update-expected.txt:
      * storage/indexeddb/cursor-update.html:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@106387 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      c410ea2f
    • rniwa@webkit.org's avatar
      PerfTestRunner should automatically create pre#log · ef28db1a
      rniwa@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=77469
      
      Reviewed by Tony Chang.
      
      Automatically generate <pre id="log"></pre> if there isn't one.
      
      * Bindings/event-target-wrapper.html:
      * DOM/Accessors.html:
      * DOM/CloneNodes.html:
      * DOM/CreateNodes.html:
      * DOM/DOMDivWalk.html:
      * DOM/DOMTable.html:
      * DOM/DOMWalk.html:
      * DOM/Events.html:
      * DOM/GetElement.html:
      * DOM/GridSort.html:
      * DOM/Template.html:
      * Dromaeo/dom-query.html:
      * Dromaeo/resources/dromaeorunner.js:
      * Parser/html-parser.html:
      * Parser/html5-full-render.html:
      * Parser/simple-url.html:
      * Parser/tiny-innerHTML.html:
      * Parser/url-parser.html:
      * Parser/xml-parser.html:
      * resources/runner.js:
      (PerfTestRunner.log):
      (PerfTestRunner.printStatistics):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@106386 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      ef28db1a
    • andersca@apple.com's avatar
      Inform the tile cache whenever the visible rect changes · 861216b2
      andersca@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=77470
      
      Reviewed by Andreas Kling.
      
      * platform/graphics/GraphicsLayer.h:
      (WebCore::GraphicsLayer::visibleRectChanged):
      Add empty function.
      
      * platform/graphics/ca/GraphicsLayerCA.cpp:
      (WebCore::GraphicsLayerCA::visibleRectChanged):
      Call through to the PlatformCALayer.
      
      * platform/graphics/ca/mac/PlatformCALayerMac.mm:
      (PlatformCALayer::visibleRectChanged):
      Call through to the underlying WebTileCacheLayer.
      
      * platform/graphics/ca/mac/TileCache.mm:
      (WebCore::TileCache::visibleRectChanged):
      Add empty stub.
      
      (WebCore::TileCache::visibleRect):
      Add new (currently unused) helper function that returns the visible rect of the
      tile cache layer.
      
      * platform/graphics/ca/mac/WebTileCacheLayer.h:
      * platform/graphics/ca/mac/WebTileCacheLayer.mm:
      (-[WebTileCacheLayer visibleRectChanged]):
      Call through to the TielCache object.
      
      * platform/graphics/ca/win/PlatformCALayerWin.cpp:
      (PlatformCALayer::visibleRectChanged):
      Add stub.
      
      * rendering/RenderLayerCompositor.cpp:
      (WebCore::RenderLayerCompositor::frameViewDidScroll):
      Call GraphicsLayer::visibleRectChanged.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@106385 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      861216b2
    • antti@apple.com's avatar
      Remove CSSStyleDeclaration isElementStyleDeclaration bit · 8abe3290
      antti@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=77460
      
      Reviewed by Andreas Kling.
      
      Inline style declaration is now the only type of style declaration with element parent.
      We can remove the bit and the associated logic.
      
      * bindings/js/JSDOMBinding.h:
      (WebCore::root):
      * css/CSSMutableStyleDeclaration.cpp:
      (WebCore::CSSMutableStyleDeclaration::CSSMutableStyleDeclaration):
      (WebCore::CSSMutableStyleDeclaration::setNeedsStyleRecalc):
      * css/CSSMutableStyleDeclaration.h:
      (WebCore::CSSMutableStyleDeclaration::createInline):
      (CSSMutableStyleDeclaration):
      * css/CSSStyleDeclaration.cpp:
      (WebCore::CSSStyleDeclaration::CSSStyleDeclaration):
      (WebCore):
      (WebCore::CSSStyleDeclaration::parentStyleSheet):
      * css/CSSStyleDeclaration.h:
      (WebCore::CSSStyleDeclaration::parentRule):
      (WebCore::CSSStyleDeclaration::clearParentRule):
      (WebCore::CSSStyleDeclaration::parentElement):
      (WebCore::CSSStyleDeclaration::clearParentElement):
      (CSSStyleDeclaration):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@106384 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      8abe3290
    • commit-queue@webkit.org's avatar
      [chromium] Compute occlusion during paint loop · d5736250
      commit-queue@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=76858
      
      Patch by Dana Jansens <danakj@chromium.org> on 2012-01-31
      Reviewed by James Robinson.
      
      Source/WebCore:
      
      New unit tests in TiledLayerChromiumTest.cpp, CCLayerTreeHostCommonTest.cpp, CCLayerTreeHostTest.cpp
      
      * platform/graphics/FloatRect.cpp:
      (WebCore::enclosedIntRect):
      (WebCore):
      * platform/graphics/FloatRect.h:
      (WebCore):
      * platform/graphics/chromium/Canvas2DLayerChromium.cpp:
      (WebCore::Canvas2DLayerChromium::paintContentsIfDirty):
      * platform/graphics/chromium/Canvas2DLayerChromium.h:
      (Canvas2DLayerChromium):
      * platform/graphics/chromium/ContentLayerChromium.cpp:
      (WebCore::ContentLayerChromium::paintContentsIfDirty):
      * platform/graphics/chromium/ContentLayerChromium.h:
      (ContentLayerChromium):
      * platform/graphics/chromium/ImageLayerChromium.cpp:
      (WebCore::ImageLayerChromium::paintContentsIfDirty):
      * platform/graphics/chromium/ImageLayerChromium.h:
      (ImageLayerChromium):
      * platform/graphics/chromium/LayerChromium.cpp:
      (WebCore::LayerChromium::contentToScreenSpaceTransform):
      (WebCore):
      (WebCore::LayerChromium::addSelfToOccludedScreenSpace):
      (WebCore::LayerChromium::isPaintedAxisAlignedInScreen):
      * platform/graphics/chromium/LayerChromium.h:
      (WebCore):
      (WebCore::LayerChromium::paintContentsIfDirty):
      (LayerChromium):
      * platform/graphics/chromium/RenderSurfaceChromium.h:
      (RenderSurfaceChromium):
      * platform/graphics/chromium/TiledLayerChromium.cpp:
      (WebCore::TiledLayerChromium::addSelfToOccludedScreenSpace):
      * platform/graphics/chromium/TiledLayerChromium.h:
      (WebCore):
      ():
      * platform/graphics/chromium/cc/CCLayerTreeHost.cpp:
      (WebCore::CCLayerTreeHost::paintContentsIfDirty):
      (WebCore::CCLayerTreeHost::paintMaskAndReplicaForRenderSurface):
      (RenderSurfaceRegion):
      (WebCore):
      (WebCore::pushTargetRenderSurfaceRegion):
      (WebCore::popAndPushTargetRenderSurfaceRegion):
      (WebCore::CCLayerTreeHost::paintLayerContents):
      * platform/graphics/chromium/cc/CCLayerTreeHost.h:
      (WebCore):
      ():
      * platform/graphics/chromium/cc/CCQuadCuller.cpp:
      
      Source/WebKit/chromium:
      
      * tests/CCLayerTreeHostCommonTest.cpp:
      (WebCore::TEST):
      (WebCore):
      * tests/CCLayerTreeHostTest.cpp:
      (WTF::ContentLayerChromiumWithUpdateTracking::paintContentsIfDirty):
      (WTF):
      (TestLayerChromium):
      (WTF::TestLayerChromium::create):
      (WTF::TestLayerChromium::paintContentsIfDirty):
      (WTF::TestLayerChromium::drawsContent):
      (WTF::TestLayerChromium::occludedScreenSpace):
      (WTF::TestLayerChromium::clearOccludedScreenSpace):
      (WTF::TestLayerChromium::TestLayerChromium):
      (WTF::setLayerPropertiesForTesting):
      (CCLayerTreeHostTestLayerOcclusion):
      (WTF::CCLayerTreeHostTestLayerOcclusion::CCLayerTreeHostTestLayerOcclusion):
      (WTF::CCLayerTreeHostTestLayerOcclusion::beginTest):
      (WTF::CCLayerTreeHostTestLayerOcclusion::afterTest):
      * tests/Canvas2DLayerChromiumTest.cpp:
      (WebCore::Canvas2DLayerChromiumTest::fullLifecycleTest):
      * tests/TiledLayerChromiumTest.cpp:
      (WTF::FakeLayerTextureUpdater::setOpaquePaintRect):
      (FakeLayerTextureUpdater):
      (WTF::FakeTiledLayerChromium::paintContentsIfDirty):
      (WTF::FakeLayerTextureUpdater::prepareToUpdate):
      (WTF::TEST):
      (WTF):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@106383 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      d5736250
    • commit-queue@webkit.org's avatar
      [Chromium] Add chromium-style tracing support · 46cb5141
      commit-queue@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=76885
      
      Patch by John Bates <jbates@google.com> on 2012-01-31
      Reviewed by Darin Fisher.
      
      This code enables WebKit trace events to pass through more data to the
      chromium platform tracing API and generally to use the full tracing
      API provided by chromium.
      
      Source/WebCore:
      
      * bindings/v8/V8Proxy.cpp:
      (WebCore::V8Proxy::evaluate): Replace old tracing API.
      * page/Console.cpp:
      (WebCore::Console::time): Replace old tracing API.
      (WebCore::Console::timeEnd): Replace old tracing API.
      * platform/chromium/PlatformSupport.h:
      * platform/chromium/TraceEvent.h:
      (WebCore::TraceEvent::TraceID::TraceID):
      (WebCore::TraceEvent::TraceID::data):
      (WebCore::TraceEvent::TraceStringWithCopy::TraceStringWithCopy):
      (WebCore::TraceEvent::TraceStringWithCopy::operator const char* ):
      (WebCore::TraceEvent::setTraceValue):
      (WebCore::TraceEvent::addTraceEvent):
      (WebCore::TraceEvent::TraceEndOnScopeClose::TraceEndOnScopeClose):
      (WebCore::TraceEvent::TraceEndOnScopeClose::~TraceEndOnScopeClose):
      (WebCore::TraceEvent::TraceEndOnScopeClose::initialize):
      (WebCore::TraceEvent::TraceEndOnScopeClose::addEventIfEnabled):
      (WebCore::TraceEvent::TraceEndOnScopeCloseThreshold::TraceEndOnScopeCloseThreshold):
      (WebCore::TraceEvent::TraceEndOnScopeCloseThreshold::~TraceEndOnScopeCloseThreshold):
      (WebCore::TraceEvent::TraceEndOnScopeCloseThreshold::initialize):
      (WebCore::TraceEvent::TraceEndOnScopeCloseThreshold::addEventIfEnabled):
      
      Source/WebKit/chromium:
      
      * public/platform/WebKitPlatformSupport.h:
      (WebKit::WebKitPlatformSupport::getTraceCategoryEnabledFlag):
      (WebKit::WebKitPlatformSupport::addTraceEvent):
      * src/PlatformSupport.cpp:
      (WebCore::PlatformSupport::getTraceCategoryEnabledFlag):
      (WebCore::PlatformSupport::addTraceEvent):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@106382 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      46cb5141
    • piman@chromium.org's avatar
      Add back temporarily WebKitPlatformSupport::createGraphicsContext3D() to fix build · a0b79e2d
      piman@chromium.org authored
      https://bugs.webkit.org/show_bug.cgi?id=77467
      
      Rubber-stamped by Nate Chapin <japhet@chromium.org>.
      
      * public/platform/WebKitPlatformSupport.h:
      (WebKitPlatformSupport):
      (WebKit::WebKitPlatformSupport::createGraphicsContext3D):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@106381 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      a0b79e2d
    • rniwa@webkit.org's avatar
      Source/WebCore: Crash in DeleteSelectionCommand::handleGeneralDelete when... · 4df07a29
      rniwa@webkit.org authored
      Source/WebCore: Crash in DeleteSelectionCommand::handleGeneralDelete when attempting to delete the start block
      https://bugs.webkit.org/show_bug.cgi?id=77077
      
      Reviewed by Enrica Casucci.
      
      The crash was caused by a missing null check after removing the position out of the start block.
      Fixed the bug by adding an early return.
      
      Tests: editing/deleting/delete-start-block.html
             editing/selection/move-into-empty-root-inline-box.html
      
      * editing/DeleteSelectionCommand.cpp:
      (WebCore::DeleteSelectionCommand::handleGeneralDelete):
      
      LayoutTests: Crash in previousLinePosition when moving into a root inline box without leaves
      https://bugs.webkit.org/show_bug.cgi?id=76812
      
      Reviewed by Enrica Casucci.
      
      Add a regression test for the crash. Unfortunately, we can only test previousLinePosition.
      
      * editing/selection/move-into-empty-root-inline-box-expected.txt: Added.
      * editing/selection/move-into-empty-root-inline-box.html: Added.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@106380 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      4df07a29
    • rniwa@webkit.org's avatar
      runner.js in performance tests should define a class · e0cd0a9a
      rniwa@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=77074
      
      Reviewed by Eric Seidel.
      
      Wrap all functions in runner.js by PerfTestRunner and update tests that runner.js accordingly.
      Also replace compute* functions in runner.js by more robust code from dom-perf.js.
      
      * Bindings/event-target-wrapper.html:
      * DOM/DOMTable.html:
      * DOM/resources/dom-perf.js:
      (BenchmarkSuite.prototype.RunSingle):
      (runBenchmarkSuite):
      * Mutation/append-child-deep.html:
      * Mutation/append-child.html:
      * Mutation/inner-html.html:
      * Mutation/remove-child-deep.html:
      * Mutation/remove-child.html:
      * Parser/html-parser.html:
      * Parser/html5-full-render.html:
      * Parser/simple-url.html:
      * Parser/tiny-innerHTML.html:
      * Parser/url-parser.html:
      * Parser/xml-parser.html:
      * resources/runner.js:
      (PerfTestRunner.log):
      (PerfTestRunner.logInfo):
      (PerfTestRunner.loadFile):
      (PerfTestRunner.computeStatistics):
      (PerfTestRunner.logStatistics):
      (PerfTestRunner._runLoop.else):
      (PerfTestRunner._runLoop):
      (PerfTestRunner._runner):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@106379 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      e0cd0a9a
    • tony@chromium.org's avatar
      [chromium] Fix css3/flexbox/cross-axis-scrollbar-expected to work on · 97559abe
      tony@chromium.org authored
      chromium win.
      
      The scrollbars overflow the bounds of the scrollbar rect (see bug 77368).
      Work around this by using positioned elements and setting the z-index as
      negative.  It didn't work previously because when the scrollbar was
      positioned, it clipped the extra pixels.  Tested to verify that this works
      on Chromium Win and Chromium Linux.
      
      Unreviewed, test fix.
      
      * css3/flexbox/cross-axis-scrollbar-expected.html:
      * platform/chromium/test_expectations.txt:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@106378 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      97559abe
    • eric@webkit.org's avatar
      HTMLIsIndexElement should not expose HTMLInputElement properties · 0d303add
      eric@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=76095
      
      Patch by Rafael Brandao <rafael.lobo@openbossa.org> on 2012-01-31
      Reviewed by Eric Seidel.
      
      This is a buildfix for r106373.
      
      * DerivedSources.pri: Removed reference to HTMLIsIndexElement.idl
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@106377 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      0d303add
    • commit-queue@webkit.org's avatar
      WebGL must allocate smaller drawing buffer when the allocation fails. · b20e8a89
      commit-queue@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=76654
      
      Patch by Yongsheng Zhu <yongsheng.zhu@intel.com> on 2012-01-31
      Reviewed by Kenneth Russell.
      
      Test: fast/canvas/webgl/drawingbuffer-test.html
      
      * platform/graphics/gpu/DrawingBuffer.cpp:
      (WebCore):
      (WebCore::DrawingBuffer::create):
      (WebCore::DrawingBuffer::reset):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@106376 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      b20e8a89
    • ap@apple.com's avatar
      PluginProcess should be able to use remote open and save panels · 69e2a16f
      ap@apple.com authored
              https://bugs.webkit.org/show_bug.cgi?id=77461
              <rdar://problem/10783615>
      
              Reviewed by Mark Rowe.
      
              * PluginProcess/mac/PluginProcess.entitlements: Added.
              * PluginProcess/mac/add-entitlements.sh: Added.
              * WebKit2.xcodeproj/project.pbxproj:
              Add appropriate entitlement, plus ad hoc binary signing for it to work.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@106375 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      69e2a16f
    • eric@webkit.org's avatar
      HTMLIsIndexElement should not expose HTMLInputElement properties · c00f0a0c
      eric@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=76095
      
      Reviewed by Adam Barth.
      
      Source/WebCore:
      
      document.createElement("isindex") should produce an HTMLUnknownElement
      per the HTML5 spec.  The parser automagically translates <isindex> into
      a whole dom tree roughly representing what <isindex> used to do 15 years ago. :)
      
      This patch just removes our support for HTMLIsIndexElement.  The parser
      support was already in.  Having support for HTMLIsIndexElement was causing
      one of the IE TestCenter tests to fail.
      
      Test: fast/dom/HTMLIsIndexElement/prototype-chain.html
      
      * DerivedSources.cpp:
      * DerivedSources.make:
      * DerivedSources.pri:
      * GNUmakefile.list.am:
      * Target.pri:
      * WebCore.exp.in:
      * WebCore.gypi:
      * WebCore.order:
      * WebCore.vcproj/WebCore.vcproj:
      * WebCore.xcodeproj/project.pbxproj:
      * bindings/gobject/GNUmakefile.am:
      * bindings/gobject/WebKitHTMLElementWrapperFactory.cpp:
      (WebKit::createHTMLElementWrapper):
      * bindings/objc/DOM.mm:
      (WebCore::createElementClassMap):
      * bindings/objc/DOMHTML.h:
      * bindings/objc/PublicDOMInterfaces.h:
      * html/HTMLElementsAllInOne.cpp:
      * html/HTMLIsIndexElement.cpp: Removed.
      * html/HTMLIsIndexElement.h: Removed.
      * html/HTMLIsIndexElement.idl: Removed.
      * html/HTMLTagNames.in:
      * page/DOMWindow.idl:
      
      Source/WebKit/mac:
      
      * MigrateHeaders.make:
      
      LayoutTests:
      
      * fast/dom/HTMLIsIndexElement/prototype-chain-expected.txt: Added.
      * fast/dom/HTMLIsIndexElement/prototype-chain.html: Added.
      * fast/dom/HTMLIsIndexElement/script-tests/prototype-chain.js: Added.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@106373 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      c00f0a0c
    • commit-queue@webkit.org's avatar
      [Qt] Use ICU if available · 35bf5391
      commit-queue@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=76821
      
      Patch by Rafael Brandao <rafael.lobo@openbossa.org> on 2012-01-31
      Reviewed by Csaba Osztrogonác.
      
      After r105997, some tests had different expected results but they were passing
      like /fast/text/find-{kana|russian|soft-hyphen}.html and editing/execCommand/findString-diacriticals.html.
      The test editing/selection/regional-indicators.html had a false expected file,
      and the rest was moved to a more specific folder (i.e. some bugs skipped on qt5 and qt-wk2
      didn't need to be on qt-wk2 as well, etc.) and/or created specific bugs for further investigation.
      
      * platform/qt-4.8/Skipped:
      * platform/qt-4.8/css1/text_properties/text_transform-expected.txt: Copied from LayoutTests/platform/qt/css1/text_properties/text_transform-expected.txt.
      * platform/qt-4.8/editing/selection/regional-indicators-expected.txt: Renamed from LayoutTests/platform/qt/editing/selection/regional-indicators-expected.txt.
      * platform/qt-4.8/fast/text/find-kana-expected.txt: Renamed from LayoutTests/platform/qt/fast/text/find-kana-expected.txt.
      * platform/qt-4.8/fast/text/find-russian-expected.txt: Renamed from LayoutTests/platform/qt/fast/text/find-russian-expected.txt.
      * platform/qt-4.8/fast/text/find-soft-hyphen-expected.txt: Renamed from LayoutTests/platform/qt/fast/text/find-soft-hyphen-expected.txt.
      * platform/qt-5.0/Skipped:
      * platform/qt-5.0/css1/text_properties/text_transform-expected.txt: Renamed from LayoutTests/platform/qt/css1/text_properties/text_transform-expected.txt.
      * platform/qt-5.0/editing/execCommand/findString-diacriticals-expected.txt: Added.
      * platform/qt-wk2/Skipped:
      * platform/qt/Skipped:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@106372 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      35bf5391
    • piman@chromium.org's avatar
      Merge WebGraphicsContext3D creation and initialization, and move it to · f2b56878
      piman@chromium.org authored
      WebViewClient.
      https://bugs.webkit.org/show_bug.cgi?id=76593
      
      Reviewed by Darin Fisher.
      
      Source/WebKit/chromium:
      
      * public/WebViewClient.h:
      (WebKit::WebViewClient::createGraphicsContext3D):
      * public/platform/WebGraphicsContext3D.h:
      (WebKit::WebGraphicsContext3D::initialize):
      * public/platform/WebKitPlatformSupport.h:
      * src/GraphicsContext3DChromium.cpp:
      
      Tools:
      
      * DumpRenderTree/chromium/TestWebPlugin.cpp:
      (TestWebPlugin::TestWebPlugin):
      (TestWebPlugin::initialize):
      * DumpRenderTree/chromium/TestWebPlugin.h:
      * DumpRenderTree/chromium/WebViewHost.cpp:
      (WebViewHost::createGraphicsContext3D):
      (WebViewHost::createPlugin):
      * DumpRenderTree/chromium/WebViewHost.h:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@106371 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      f2b56878
    • msaboff@apple.com's avatar
      ASSERT(m_jumpsToLink.isEmpty()) failing in ARMv7Assembler dtor · a323c82f
      msaboff@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=77443
      
      Reviewed by Gavin Barraclough.
      
      Removed failing ASSERT() and thus destructor.  The ASSERT isn't needed.
      We are hitting it in the YARR JIT case where we bail out and go to the
      interpreter with a partially JIT'ed function.  Since we haven't linked
      the JIT'ed code, there is likely to be some unresolved jumps in the vector
      when the ARMv7Assembler destructor is called.  For the case where we
      complete the JIT process, we clear the vector at the end of
      LinkBuffer::linkCode (LinkBuffer.h:292).
      
      * assembler/ARMv7Assembler.h:
      (ARMv7Assembler):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@106370 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      a323c82f
    • rgabor@webkit.org's avatar
      [GTK] build-webkit warning. · 516488ac
      rgabor@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=77411
      
      Reviewed by Philippe Normand.
      
      * Scripts/webkitdirs.pm:
      (isCrossCompilation):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@106369 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      516488ac
    • andersca@apple.com's avatar
      Vector<T>::operator== shouldn't require T to have operator!= · 9fc4aeb5
      andersca@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=77448
      
      Reviewed by Andreas Kling.
      
      Change VectorComparer::compare to use !(a == b) instead of a != b since
      it makes more sense for Vector::operator== to use the element's operator==.
      
      * wtf/Vector.h:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@106368 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      9fc4aeb5
    • mitz@apple.com's avatar
      When generating derived sources, use the same compiler that is used to compile WebKitTestRunner. · 11be23e2
      mitz@apple.com authored
      Reviewed by Anders Carlsson.
      
      * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@106366 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      11be23e2