1. 10 Sep, 2010 40 commits
    • aroben@apple.com's avatar
      Land new expected results for some tests on Windows · 435069eb
      aroben@apple.com authored
      Rubber-stamped in advance by Simon Fraser.
      
      * platform/win/fast/text/hyphenate-first-word-actual.txt: Added.
      * platform/win/fast/text/hyphenate-locale-actual.txt: Added.
      Windows doesn't support hyphenation.
      
      * platform/win/html5lib/runner-actual.txt: Added.
      We don't implement <keygen> on Windows, so we pass some tests that
      expect <keygen> to have no child elements (on Mac, the child elements
      are real DOM elements, rather than living in the shadow DOM tree like
      HTML5 mandates, so the tests fail).
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@67217 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      435069eb
    • tony@chromium.org's avatar
      2010-09-10 Tony Chang <tony@chromium.org> · 57170687
      tony@chromium.org authored
              Reviewed by Ojan Vafai.
      
              deduplicate-tests should be runnable from any WebKit directory
              https://bugs.webkit.org/show_bug.cgi?id=44709
      
              * Scripts/webkitpy/layout_tests/deduplicate_tests.py:
              * Scripts/webkitpy/layout_tests/deduplicate_tests_unittest.py:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@67216 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      57170687
    • mrobinson@webkit.org's avatar
      2010-09-10 Martin Robinson <mrobinson@igalia.com> · 7aa9c774
      mrobinson@webkit.org authored
              Reviewed by Xan Lopez.
      
              [GTK] Placement new / manual destructor invocation should be used on private GObject memory
              https://bugs.webkit.org/show_bug.cgi?id=45550
      
              GLib allocates and deallocates GObject private data structs itself. When
              those structs contain C++ members, their constructors and destructors are not
              called. This is not only dangerous, it makes RefPtr-type smart pointers much
              less useful. We can fix this problem by calling placement new on the private
              data struct during instance initialization and calling the destructor during
              finalization.
      
              This patch takes that approach and switches plain char* members of
              WebKitWebView (with manual memory allocation) to use CString.
      
              * webkit/webkitprivate.h: Switch char* members to CString.
              * webkit/webkitwebview.cpp:
              (webkit_web_view_finalize): Manually call the destructor on the private
              data. Remove manual deallocation of members which are now CString.
              (webkit_web_view_query_tooltip): Update to reflect CString change.
              (webkit_web_view_init): Use placement new to initialize C++ members of
              the private data section.
              (webkit_web_view_get_encoding): Update to reflect CString change.
              (webkit_web_view_get_custom_encoding): Ditto.
              (webkit_web_view_add_resource): Ditto.
              (webkit_web_view_get_resource): Ditto.
              (webkit_web_view_clear_resources): Ditto.
              (webkit_web_view_set_tooltip_text): Ditto.
              (webkit_web_view_get_icon_uri): Ditto.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@67215 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      7aa9c774
    • commit-queue@webkit.org's avatar
      2010-09-10 Patrick Gansterer <paroga@paroga.com> · 181d1ee5
      commit-queue@webkit.org authored
              Reviewed by Darin Adler.
      
              Use String::fromUTF8 instead of UTF8Encoding().decode
              in the libxml XMLDocumentParser
              https://bugs.webkit.org/show_bug.cgi?id=45488
      
              * dom/XMLDocumentParserLibxml2.cpp:
              (WebCore::toString):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@67214 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      181d1ee5
    • joepeck@webkit.org's avatar
      2010-09-09 Joseph Pecoraro <joepeck@webkit.org> · 90e48393
      joepeck@webkit.org authored
              Reviewed by Andreas Kling.
      
              Clean Up Some Expected Results for Missing Tests
              https://bugs.webkit.org/show_bug.cgi?id=45489
      
                Test was removed in r35456 but expected results were missed.
      
              * http/tests/xmlhttprequest/access-control-basic-exclude-expected.txt: Removed.
      
                Results were added in r19036 but the test was never added. No record of the test.
      
              * editing/pasteboard/4944770-expected.txt: Removed.
              * platform/mac/editing/pasteboard/4944770-expected.checksum: Removed.
              * platform/mac/editing/pasteboard/4944770-expected.png: Removed.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@67213 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      90e48393
    • simon.fraser@apple.com's avatar
      2010-09-10 Simon Fraser <simon.fraser@apple.com> · 933e48fd
      simon.fraser@apple.com authored
              Reviewed by Chris Marrin.
      
              Update Windows LayoutTest/compositing results
              https://bugs.webkit.org/show_bug.cgi?id=45323
      
              Fix up some windows compositing test results.
      
              * platform/win/compositing/iframes/composited-parent-iframe-expected.txt: Removed.
              * platform/win/compositing/iframes/iframe-resize-expected.txt: Removed.
              * platform/win/compositing/iframes/leave-compositing-iframe-expected.txt: Removed.
              * platform/win/compositing/iframes/overlapped-iframe-expected.txt: Removed.
              * platform/win/compositing/plugins/composited-plugin-expected.txt: Added.
              * platform/win/compositing/plugins/small-to-large-composited-plugin-expected.txt: Copied from LayoutTests/compositing/iframes/leave-compositing-iframe-expected.txt.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@67212 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      933e48fd
    • kov@webkit.org's avatar
      2010-09-10 Gustavo Noronha Silva <gns@gnome.org> · 2b9514d7
      kov@webkit.org authored
              Reviewed by Martin Robinson.
      
              [GTK] Google sites do not like WebKitGTK+
              https://bugs.webkit.org/show_bug.cgi?id=39617
      
              Special-case Google domains, and spoof User-Agent when talking to
              them, to stop being treated as a second-class citizen.
      
              * WebCoreSupport/FrameLoaderClientGtk.cpp:
              (WebKit::initializeDomainsList):
              (WebKit::isGoogleDomain):
              (WebKit::FrameLoaderClient::userAgent): If enable-site-specific-quirks
              is enabled, send the standard WebKit User-Agent string, disregarding the
              custom one set by the browser for Google domains.
              * webkit/webkitprivate.h:
              * webkit/webkitwebsettings.cpp:
              (webkitPlatform): Fix style, and simplify.
              (webkitOSVersion): Ditto.
              (webkitUserAgent): Add the Version/x.y string Safari has been
              using since Safari 2.2.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@67211 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      2b9514d7
    • yurys@chromium.org's avatar
      2010-09-10 Pavel Podivilov <podivilov@chromium.org> · 948cf1a2
      yurys@chromium.org authored
              Reviewed by Yury Semikhatsky.
      
              [Chromium] rebaseline SVGFEDiffuseLightingElement-lighting-color-css-prop.html
              https://bugs.webkit.org/show_bug.cgi?id=45540
      
              * platform/chromium-linux/svg/dynamic-updates/SVGFEDiffuseLightingElement-lighting-color-css-prop-expected.checksum:
              * platform/chromium-linux/svg/dynamic-updates/SVGFEDiffuseLightingElement-lighting-color-css-prop-expected.png:
              * platform/chromium-win/svg/dynamic-updates/SVGFEDiffuseLightingElement-lighting-color-css-prop-expected.checksum:
              * platform/chromium-win/svg/dynamic-updates/SVGFEDiffuseLightingElement-lighting-color-css-prop-expected.png:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@67210 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      948cf1a2
    • cfleizach@apple.com's avatar
      Mail crashes with searching for next misspelled word with VoiceOver · fbca8294
      cfleizach@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=45501
      
      Reviewed by David Kilzer.
      
      WebCore: 
      
      Test: platform/mac/accessibility/crash-in-element-for-text-marker.html
      
      * accessibility/mac/AccessibilityObjectWrapper.mm:
      (-[AccessibilityObjectWrapper accessibilityAttributeValue:forParameter:]):
          Check that the AX object is not nil before asking for the wrapper().
      
      LayoutTests: 
      
      * platform/mac/accessibility/crash-in-element-for-text-marker-expected.txt: Added.
      * platform/mac/accessibility/crash-in-element-for-text-marker.html: Added.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@67209 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      fbca8294
    • commit-queue@webkit.org's avatar
      2010-09-10 Michael Nordman <michaeln@google.com> · fa990e91
      commit-queue@webkit.org authored
              Reviewed by Dumitru Daniliuc.
      
              Decouple Blob from ScriptExecutionContext.
              https://bugs.webkit.org/show_bug.cgi?id=45410
      
              - Removed ScriptExecutionContext pointers from Blob and File constructors.
              - Removed ScriptExecutionContext's collection of Blobs instance in that context.
              - Refactored BlobURL to make a distinction between 'public' blob urls and 'internal'
                urls that are used solely as identifiers. The former requires a SecurityOrigin to
                to manufacture, the latter does not.
              - Added a constant and accessor for the blob protocol scheme on the BlobURL class.
      
              No new tests are added since this is a cleanup.
      
              * bindings/js/SerializedScriptValue.cpp:
              (WebCore::CloneDeserializer::readFile):
              (WebCore::CloneDeserializer::readTerminal):
              * bindings/v8/SerializedScriptValue.cpp:
              (WebCore::ZigZag::Reader::readBlob):
              (WebCore::ZigZag::Reader::readFile):
              (WebCore::ZigZag::Reader::readFileList):
              * dom/ScriptExecutionContext.cpp:
              (WebCore::ScriptExecutionContext::~ScriptExecutionContext):
              (WebCore::ScriptExecutionContext::createPublicBlobURL):
              (WebCore::ScriptExecutionContext::revokePublicBlobURL):
              * dom/ScriptExecutionContext.h:
              * fileapi/Blob.cpp:
              (WebCore::Blob::Blob):
              (WebCore::Blob::~Blob):
              (WebCore::Blob::slice):
              * fileapi/Blob.h:
              (WebCore::Blob::create):
              (WebCore::Blob::url):
              * fileapi/Blob.idl:
              * fileapi/BlobBuilder.cpp:
              (WebCore::BlobBuilder::getBlob):
              * fileapi/BlobBuilder.h:
              * fileapi/BlobBuilder.idl:
              * fileapi/BlobURL.cpp:
              (WebCore::BlobURL::createPublicURL):
              (WebCore::BlobURL::createInternalURL):
              (WebCore::BlobURL::getOrigin):
              (WebCore::BlobURL::getIdentifier):
              (WebCore::BlobURL::createBlobURL):
              * fileapi/BlobURL.h:
              (WebCore::BlobURL::blobProtocol):
              (WebCore::BlobURL::BlobURL):
              * fileapi/File.cpp:
              (WebCore::File::File):
              * fileapi/File.h:
              (WebCore::File::create):
              * fileapi/FileReader.cpp: Register a public url to perform the read.
              (WebCore::FileReader::cleanup):
              (WebCore::FileReader::start):
              (WebCore::FileReader::didFinishLoading):
              (WebCore::FileReader::failed):
              * fileapi/FileReader.h: Added m_urlForReading data member.
              * fileapi/FileReaderSync.cpp:
              (WebCore::FileReaderSync::read): Register a public url to perform the read.
              * fileapi/ThreadableBlobRegistry.cpp:
              (WebCore::ThreadableBlobRegistry::registerBlobURL):
              (WebCore::ThreadableBlobRegistry::unregisterBlobURL):
              * fileapi/ThreadableBlobRegistry.h:
              * html/HTMLInputElement.cpp:
              (WebCore::HTMLInputElement::appendFormData):
              (WebCore::HTMLInputElement::setFileListFromRenderer):
              * page/SecurityOrigin.cpp: Use BlobURL.blobProtocol().
              (WebCore::SecurityOrigin::create):
              (WebCore::SecurityOrigin::canRequest):
              (WebCore::SecurityOrigin::canDisplay):
              * platform/chromium/ClipboardChromium.cpp:
              (WebCore::ClipboardChromium::files):
              * platform/gtk/ClipboardGtk.cpp:
              (WebCore::ClipboardGtk::files):
              * platform/mac/ClipboardMac.mm:
              (WebCore::ClipboardMac::files):
              * platform/win/ClipboardWin.cpp:
              (WebCore::ClipboardWin::files):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@67208 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      fa990e91
    • xan@webkit.org's avatar
      2010-09-10 Xan Lopez <xlopez@igalia.com> · da6ca9d9
      xan@webkit.org authored
              Reviewed by Martin Robinson.
      
              GDK_DISPLAY was removed in GTK+ 3.x, re-declare it when built
              against that.
      
              * platform/gtk/GtkVersioning.h:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@67207 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      da6ca9d9
    • xan@webkit.org's avatar
      WebCore: · ae0e2c64
      xan@webkit.org authored
      2010-09-10  Xan Lopez  <xlopez@igalia.com>
      
              Reviewed by Martin Robinson.
      
              Fix compilation with GTK+ 3.x.
      
              GDK key macros were renamed from GDK_FOO to GDK_KEY_FOO, we need
              to include the compat header provided if we want to keep using the
              old names.
      
              * platform/gtk/GtkVersioning.h: add the compatibility header.
              * platform/gtk/KeyEventGtk.cpp: include GtkVersioning.h
      
      WebKit/gtk:
      
      2010-09-10  Xan Lopez  <xlopez@igalia.com>
      
              Reviewed by Martin Robinson.
      
              Fix compilation with GTK+ 3.x.
      
              GDK key macros were renamed from GDK_FOO to GDK_KEY_FOO, we need
              to include the compat header provided if we want to keep using the
              old names.
      
              * WebCoreSupport/FullscreenVideoController.cpp: include GtkVersioning.h
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@67206 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      ae0e2c64
    • vestbo@webkit.org's avatar
      Skip a few media tests that started randomly failing after r66961 · 4796b841
      vestbo@webkit.org authored
      Reviewed by Eric Carlson.
      
      * platform/mac-leopard/Skipped:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@67205 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      4796b841
    • tonyg@chromium.org's avatar
      2010-09-09 Tony Gentilcore <tonyg@chromium.org> · 9fa4859d
      tonyg@chromium.org authored
              Reviewed by Eric Seidel.
      
              Factor out the NestingLevelIncrementer
              https://bugs.webkit.org/show_bug.cgi?id=45471
      
              No new tests because no new functionality.
      
              * GNUmakefile.am:
              * WebCore.gypi:
              * WebCore.vcproj/WebCore.vcproj:
              * WebCore.xcodeproj/project.pbxproj:
              * html/parser/HTMLDocumentParser.cpp:
              * html/parser/HTMLDocumentParser.h:
              * html/parser/HTMLScriptRunner.cpp:
              * html/parser/NestingLevelIncrementer.h: Added.
              (WebCore::NestingLevelIncrementer::NestingLevelIncrementer):
              (WebCore::NestingLevelIncrementer::~NestingLevelIncrementer):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@67204 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      9fa4859d
    • zimmermann@webkit.org's avatar
      2010-09-10 Nikolas Zimmermann <nzimmermann@rim.com> · 04f4596d
      zimmermann@webkit.org authored
              Not reviewed. Fix wrong gtk baseline for select-x-list-1.svg.
      
              * platform/gtk/svg/text/select-x-list-1-expected.txt:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@67203 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      04f4596d
    • aroben@apple.com's avatar
      Don't crash when a frame is destroyed after the UI process has disconnected · bf92439f
      aroben@apple.com authored
      Fixes <http://webkit.org/b/45535> <rdar://problem/8412928> Crash in
      WebProcess::removeWebFrame on exit with WebKit2 (Release builds only)
      
      Reviewed by Darin Adler.
      
      * WebProcess/WebProcess.cpp:
      (WebKit::WebProcess::removeWebFrame): Null-check m_connection before
      dereferencing it.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@67202 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      bf92439f
    • mrobinson@webkit.org's avatar
      2010-09-10 Martin Robinson <mrobinson@igalia.com> · 4f59c84d
      mrobinson@webkit.org authored
              Slight skipped list reorganization.
      
              * platform/gtk/Skipped: Group one more test in the beginDragWithFiles section.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@67201 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      4f59c84d
    • zimmermann@webkit.org's avatar
      2010-09-10 Nikolas Zimmermann <nzimmermann@rim.com> · 6e96afd5
      zimmermann@webkit.org authored
              Reviewed by Dirk Schulze.
      
              SVG text chunk concept needs to be integrated in the InlineBox structure
              https://bugs.webkit.org/show_bug.cgi?id=45533
      
              Begin rewriting the SVG text layout code. As first step move the text chunk concept right into the inline box structure.
              This obsoletes the whole text chunk part concept (see SVGTextChunkLayoutInfo.h for details), and will soon simplify the
              whole layout code a lot. Previously we hacked around the fact that a single InlineTextBox could contain multiple text chunks
              For example: <text x="20 30 40">ABC</text> only led to the creation of one InlineTextBox containing three chunks. When
              painting such an InlineTextBox, we had to do nasty hacks (same for text selection etc.)
              
              This is finally fixed by incorporating the knownledge about text chunks into the line layout algorithm.
              Note, this has no impact on HTML at all, no worries.
      
              It's even required to do it this way as BiDi reordering shouldn't happen across text chunks.
              These are only the first bits, and currently slows down text layouting. Follow-up patches will remove the old layout
              algorithm, and will rely on the stored SVGTextLayoutAttributes in the RenerSVGInlineText renderers (instead of computing again).
      
              * Android.mk: Add rendering/svg/SVGTextLayoutAttributes.* & rendering/svg/SVGTextLayoutBuilder.* to build.
              * CMakeLists.txt: Ditto.
              * GNUmakefile.am: Ditto.
              * WebCore.gyp/WebCore.gyp: Ditto.
              * WebCore.gypi: Ditto.
              * WebCore.pro: Ditto.
              * WebCore.vcproj/WebCore.vcproj: Ditto.
              * WebCore.vcproj/WebCoreCommon.vsprops: Ditto. (Recognize new rendering/svg directory.)
              * WebCore.vcproj/copyForwardingHeaders.cmd: Ditto. (Copy forwarding headers from rendering/svg directory.)
              * WebCore.xcodeproj/project.pbxproj: Ditto.
              * rendering/RenderBlockLineLayout.cpp: This is the key of the new concept, take text chunks into account when building the InlineBox structure.
              (WebCore::RenderBlock::findNextLineBreak): Split midpointState, if we encounter the beginning of a new text chunk.
              * rendering/RenderObject.h:
              (WebCore::RenderObject::isSVGInline): New method, which will be used to identify RenderSVGInline objects.
              * rendering/RenderSVGInline.h:
              (WebCore::RenderSVGInline::isSVGInline): Return true.
              * rendering/RenderSVGInlineText.cpp:
              (WebCore::RenderSVGInlineText::linesBoundingBox): Overriden, to simplify the calculations for SVG.
              (WebCore::RenderSVGInlineText::characterStartsNewTextChunk): Determines wheter the given position starts a new text chunk.
              * rendering/RenderSVGInlineText.h:
              (WebCore::RenderSVGInlineText::storeLayoutAttributes): Stores the layout attributes calculated in the text layout process (will be used everywhere in follow-up patches).
              * rendering/RenderSVGText.cpp:
              (WebCore::RenderSVGText::layout): Invoke SVGTextLayoutBuilder before creating the inline box tree, so we can decide which characters start new text chunks.
              * rendering/RenderText.h: Made linesBoundingBox() virtual so RenderSVGInlineText can override it.
              * rendering/svg: Added.
              * rendering/svg/SVGTextLayoutAttributes.cpp: Added. Holds x/y/dx/dy/rotate values and all kerning/ligature information used during layout.
              * rendering/svg/SVGTextLayoutAttributes.h: Added.
              * rendering/svg/SVGTextLayoutBuilder.cpp: Added.
              * rendering/svg/SVGTextLayoutBuilder.h: Added.
      2010-09-10  Nikolas Zimmermann  <nzimmermann@rim.com>
      
              Reviewed by Dirk Schulze.
      
              SVG text chunk concept needs to be integrated in the InlineBox structure
              https://bugs.webkit.org/show_bug.cgi?id=45533
      
              Updated all tests containing text chunks, to reflect the fact that more SVGInlineTextBoxes are created now.
              All 'startOffset' dumps now begin at 0, indicating that there's only one chunk contained in a single SVGInlineTextBox.
              These dumps will be removed in follow-up patches, as they don't make any sense anymore in the new concept.
      
              * platform/gtk/svg/text/select-x-list-1-expected.txt:
              * platform/gtk/svg/text/select-x-list-2-expected.txt:
              * platform/gtk/svg/text/select-x-list-3-expected.txt:
              * platform/gtk/svg/text/select-x-list-4-expected.txt:
              * platform/gtk/svg/text/select-x-list-with-tspans-1-expected.txt:
              * platform/gtk/svg/text/select-x-list-with-tspans-2-expected.txt:
              * platform/gtk/svg/text/select-x-list-with-tspans-3-expected.txt:
              * platform/gtk/svg/text/select-x-list-with-tspans-4-expected.txt: 
              * platform/mac/svg/W3C-SVG-1.1/animate-elem-40-t-expected.txt:
              * platform/mac/svg/W3C-SVG-1.1/text-text-04-t-expected.txt:
              * platform/mac/svg/W3C-SVG-1.1/text-text-05-t-expected.txt:
              * platform/mac/svg/W3C-SVG-1.1/text-text-06-t-expected.txt:
              * platform/mac/svg/W3C-SVG-1.1/text-text-07-t-expected.txt:
              * platform/mac/svg/W3C-SVG-1.1/text-tspan-01-b-expected.txt:
              * platform/mac/svg/batik/text/textAnchor2-expected.txt:
              * platform/mac/svg/batik/text/textAnchor3-expected.txt:
              * platform/mac/svg/batik/text/textLayout-expected.txt:
              * platform/mac/svg/batik/text/textLayout2-expected.txt:
              * platform/mac/svg/batik/text/textOnPathSpaces-expected.txt:
              * platform/mac/svg/batik/text/textPosition-expected.txt:
              * platform/mac/svg/batik/text/textPosition2-expected.txt:
              * platform/mac/svg/custom/text-letter-spacing-expected.txt:
              * platform/mac/svg/custom/text-x-dx-lists-expected.txt:
              * platform/mac/svg/custom/text-x-override-in-tspan-child-expected.txt:
              * platform/mac/svg/text/select-x-list-1-expected.txt:
              * platform/mac/svg/text/select-x-list-2-expected.txt:
              * platform/mac/svg/text/select-x-list-3-expected.txt:
              * platform/mac/svg/text/select-x-list-4-expected.txt:
              * platform/mac/svg/text/select-x-list-with-tspans-1-expected.txt:
              * platform/mac/svg/text/select-x-list-with-tspans-2-expected.txt:
              * platform/mac/svg/text/select-x-list-with-tspans-3-expected.txt:
              * platform/mac/svg/text/select-x-list-with-tspans-4-expected.txt:
              * platform/mac/svg/text/text-text-04-t-expected.txt:
              * platform/mac/svg/text/text-text-05-t-expected.txt:
              * platform/mac/svg/text/text-text-06-t-expected.txt:
              * platform/mac/svg/text/text-text-07-t-expected.txt:
              * platform/mac/svg/text/text-tspan-01-b-expected.txt:
              * svg/custom/glyph-transformation-with-hkern-expected.txt:
              * platform/qt/svg/text/select-x-list-1-expected.txt:
              * platform/qt/svg/text/select-x-list-2-expected.txt:
              * platform/qt/svg/text/select-x-list-3-expected.txt:
              * platform/qt/svg/text/select-x-list-4-expected.txt:
              * platform/qt/svg/text/select-x-list-with-tspans-1-expected.txt:
              * platform/qt/svg/text/select-x-list-with-tspans-2-expected.txt:
              * platform/qt/svg/text/select-x-list-with-tspans-3-expected.txt:
              * platform/qt/svg/text/select-x-list-with-tspans-4-expected.txt:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@67200 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      6e96afd5
    • ossy@webkit.org's avatar
      Unreviewed fix after r67085. · 152d2aa9
      ossy@webkit.org authored
      * WebCore.pro: Fix previously moved filenames.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@67199 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      152d2aa9
    • abarth@webkit.org's avatar
      2010-09-10 Adam Barth <abarth@webkit.org> · 02d22791
      abarth@webkit.org authored
              Reviewed by Eric Seidel.
      
              Inline FrameLoader::committedLoad into its one caller
              https://bugs.webkit.org/show_bug.cgi?id=45481
      
              This saves one round-trip through the FrameLoader when loading
              documents.
      
              * loader/DocumentLoader.cpp:
              (WebCore::DocumentLoader::commitLoad):
              * loader/FrameLoader.cpp:
              * loader/FrameLoader.h:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@67198 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      02d22791
    • commit-queue@webkit.org's avatar
      2010-09-10 Patrick Gansterer <paroga@paroga.com> · eec9b6cb
      commit-queue@webkit.org authored
              Reviewed by Adam Roben.
      
              [WINCE] Remove ImageBuffer::toDataURL implementation
              https://bugs.webkit.org/show_bug.cgi?id=45478
      
              At the moment ImageBuffer::toDataURL uses JPEGEncoder.h and PNGEncoder.h.
              Both files are not in the repository. So remove the implementation for now.
      
              * platform/graphics/wince/ImageBufferWince.cpp:
              (WebCore::ImageBuffer::toDataURL):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@67197 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      eec9b6cb
    • antonm@chromium.org's avatar
      2010-09-10 Anton Muhin <antonm@chromium.org> · 80058bb0
      antonm@chromium.org authored
              Unreview fixed.
      
              Remove duplicate test expectations for media/media-can-play-mpeg4-video.html.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@67196 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      80058bb0
    • apavlov@chromium.org's avatar
      2010-09-10 Alexander Pavlov <apavlov@chromium.org> · 951b3016
      apavlov@chromium.org authored
              Unreviewed, build fix.
      
              * inspector/elements-panel-rewrite-href.html:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@67195 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      951b3016
    • andreas.kling@nokia.com's avatar
      2010-09-10 Andreas Kling <andreas.kling@nokia.com> · 96c2cabe
      andreas.kling@nokia.com authored
              Reviewed by Antonio Gomes.
      
              WebGL: Fix GCC warnings about suggested parentheses around && within ||
              https://bugs.webkit.org/show_bug.cgi?id=45534
      
              * html/canvas/WebGLRenderingContext.cpp:
              (WebCore::WebGLRenderingContext::getVertexAttrib):
              (WebCore::WebGLRenderingContext::readPixels):
              (WebCore::WebGLRenderingContext::texParameter):
              (WebCore::WebGLRenderingContext::handleNPOTTextures):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@67194 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      96c2cabe
    • hans@chromium.org's avatar
      2010-09-10 Hans Wennborg <hans@chromium.org> · 27eea63b
      hans@chromium.org authored
              Reviewed by Jeremy Orlow.
      
              Un-skip DeviceOrientation layout tests for Chromium.
              https://bugs.webkit.org/show_bug.cgi?id=45531
      
              fast/dom/DeviceOrientation/window-property.html and
              fast/dom/Window/window-properties-device-orientation.html need to be
              rebaselined, which will be done in a subsequent patch.
      
              * platform/chromium/test_expectations.txt:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@67193 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      27eea63b
    • antonm@chromium.org's avatar
      2010-09-10 Anton Muhin <antonm@chromium.org> · 9154de25
      antonm@chromium.org authored
              Reviewed by Kent Tamura.
      
              [Chromium] media/media-can-play-mpeg4-video.html fails under Chromium
              https://bugs.webkit.org/show_bug.cgi?id=45102
      
              Chromium is not going to support mpeg, so media/media-can-play-mpeg4-video.html
              is expected to fail.
      
              * platform/chromium/test_expectations.txt:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@67192 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      9154de25
    • apavlov@chromium.org's avatar
      2010-09-09 Alexander Pavlov <apavlov@chromium.org> · 93691630
      apavlov@chromium.org authored
              Reviewed by Yury Semikhatsky.
      
              Web Inspector: Add navigation items into the Elements panel context menu.
      
              For all anchors that have the class of "webkit-html-resource-link" or "webkit-html-external-link",
              a custom context menu with the items "Open Link in New Window" (invokes InspectorBackend.openInInspectedWindow() with
              the related URL) and "Open Link in Resources Panel" (opens the related resource in the Resources panel) is shown
              (the latter item is displayed only if the corresponding resource is known to the Web Inspector).
              https://bugs.webkit.org/show_bug.cgi?id=34250
      
              * English.lproj/localizedStrings.js:
              * inspector/front-end/ElementsPanel.js:
              (WebInspector.ElementsPanel.prototype.populateHrefContextMenu):
              * inspector/front-end/ElementsTreeOutline.js:
              (WebInspector.ElementsTreeOutline.prototype._contextMenuEventFired):
              (WebInspector.ElementsTreeElement.prototype._attributeHTML):
              * inspector/front-end/StylesSidebarPane.js:
              (WebInspector.StylesSidebarPane.prototype._contextMenuEventFired):
              * inspector/front-end/inspector.js:
              (WebInspector.openResource):
              (WebInspector.resourceURLForRelatedNode):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@67191 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      93691630
    • andreas.kling@nokia.com's avatar
      2010-09-10 Andreas Kling <andreas.kling@nokia.com> · 795b8659
      andreas.kling@nokia.com authored
              Reviewed by Tor Arne Vestbø.
      
              [Qt] Unskip canvas/philip/tests/2d.text.draw.fontface.repeat.html
      
              This test was fixed by <http://trac.webkit.org/changeset/62016>
      
              * platform/qt/Skipped:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@67190 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      795b8659
    • zherczeg@webkit.org's avatar
      An individual renderer should be assigned to each SVGFE*Element class · 430f0406
      zherczeg@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=43954
      
      Reviewed by Nikolas Zimmermann.
      
      Updating the description of the following test (it does not fail anymore):
      
      * platform/mac/svg/dynamic-updates/SVGFEDiffuseLightingElement-lighting-color-css-prop-expected.checksum:
      * platform/mac/svg/dynamic-updates/SVGFEDiffuseLightingElement-lighting-color-css-prop-expected.png:
      * svg/dynamic-updates/SVGFEDiffuseLightingElement-lighting-color-css-prop-expected.txt:
      * svg/dynamic-updates/script-tests/SVGFEDiffuseLightingElement-lighting-color-css-prop.js:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@67189 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      430f0406
    • darin@apple.com's avatar
      2010-09-08 Darin Adler <darin@apple.com> · 137987a6
      darin@apple.com authored
              Reviewed by Adam Barth.
      
              Move functions from Frame to Editor as planned
              https://bugs.webkit.org/show_bug.cgi?id=45218
      
              * src/ContextMenuClientImpl.cpp:
              (WebKit::selectMisspelledWord):
              (WebKit::ContextMenuClientImpl::getCustomMenuFromDefaultItems):
              * src/WebFrameImpl.cpp:
              (WebKit::WebFrameImpl::find):
              (WebKit::WebFrameImpl::stopFinding):
              (WebKit::WebFrameImpl::scopeStringMatches):
              * src/WebViewImpl.cpp:
              (WebKit::WebViewImpl::caretOrSelectionBounds):
              Changed call sites to use editor().
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@67188 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      137987a6
    • commit-queue@webkit.org's avatar
      2010-09-10 Kwang Yul Seo <skyul@company100.net> · 6d23290e
      commit-queue@webkit.org authored
              Reviewed by James Robinson.
      
              Make sure skia is not Chromium specific
              https://bugs.webkit.org/show_bug.cgi?id=39672
      
              Move Image::loadPlatformResource to platform/graphics/chromium/ImageChromium.cpp.
              Other ports can use ImageSkia.cpp.
      
              No new tests because this is pure refacotring.
      
              * WebCore.gyp/WebCore.gyp:
              * WebCore.gypi:
              * platform/graphics/chromium/ImageChromium.cpp: Added.
              (WebCore::Image::loadPlatformResource):
              * platform/graphics/skia/ImageSkia.cpp:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@67187 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      6d23290e
    • ukai@chromium.org's avatar
      Unreviewed. expectations update. · 6ce06d86
      ukai@chromium.org authored
      fast/dom/replaceChild.html image failure.
      
      * platform/chromium/test_expectations.txt:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@67186 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      6ce06d86
    • loislo@chromium.org's avatar
      2010-09-09 Ilya Tikhonovsky <loislo@chromium.org> · 0e881294
      loislo@chromium.org authored
              Reviewed by Joseph Pecoraro.
      
              WebInspector: Selecting 'inspect element' always shows body in inspector instead of clicked element.
      
              1. Open any page
              2. Right-click on any element, select "Inspect Element"
              3. Web Inspector is opened but the <body> element (for HTML) is focused rather than the selected element
              4. Inspect the Web Inspector. An error message is logged in the console.
      
              The regression was introduced in http://trac.webkit.org/changeset/66012 - focusNode() is invoked in
              InspectorController::populateScriptObjects() before the main document is set for the InspectorDOMAgent
              instance (which makes focusNode() bail out prematurely).
      
              https://bugs.webkit.org/show_bug.cgi?id=45374
      
              * inspector/InspectorController.cpp:
              (WebCore::InspectorController::populateScriptObjects):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@67185 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      0e881294
    • commit-queue@webkit.org's avatar
      2010-09-10 Cris Neckar <cdn@chromium.org> · 9fc8b932
      commit-queue@webkit.org authored
              Reviewed by Chris Fleizach.
      
              Test for null deref in RenderBlock::updateFirstLetter().
              https://bugs.webkit.org/show_bug.cgi?id=45404
      
              * fast/dom/firstletter-tablecell-crash-expected.txt: Added.
              * fast/dom/firstletter-tablecell-crash.html: Added.
      2010-09-10  Cris Neckar  <cdn@chromium.org>
      
              Reviewed by Chris Fleizach.
      
              Null deref in RenderBlock::updateFirstLetter(). Check for null psuedo style.
              https://bugs.webkit.org/show_bug.cgi?id=45404
      
              Test: fast/dom/firstletter-tablecell-crash.html
      
              * rendering/RenderBlock.cpp:
              (WebCore::RenderBlock::updateFirstLetter):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@67184 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      9fc8b932
    • commit-queue@webkit.org's avatar
      2010-09-10 Cris Neckar <cdn@chromium.org> · 68bed278
      commit-queue@webkit.org authored
              Reviewed by Chris Fleizach.
      
              Test for null deref in RenderBlock::findNextLineBreak().
              https://bugs.webkit.org/show_bug.cgi?id=45350
      
              * fast/dom/firstline-fixed-crash-expected.txt: Added.
              * fast/dom/firstline-fixed-crash.html: Added.
      2010-09-10  Cris Neckar  <cdn@chromium.org>
      
              Reviewed by Chris Fleizach.
      
              Null deref in RenderBlock::findNextLineBreak(). Check for null style with
              first-line style and fixed position.
              https://bugs.webkit.org/show_bug.cgi?id=45350
      
              Test: fast/dom/firstline-fixed-crash.html
      
              * rendering/RenderBlockLineLayout.cpp:
              (WebCore::RenderBlock::findNextLineBreak):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@67183 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      68bed278
    • eric@webkit.org's avatar
      2010-09-10 Eric Seidel <eric@webkit.org> · 8cc44245
      eric@webkit.org authored
              Reviewed by Dimitri Glazkov.
      
              Remove support for non-lazy attach and fix frames to load from insertedIntoDocument instead of attach
              https://bugs.webkit.org/show_bug.cgi?id=45365
      
              * fast/dom/beforeload/remove-frame-in-beforeload-listener.html:
                - Add a comment to make clear that this test intentionally
                  does not cancel the load in the beforeload event, but rather
                  relies on WebCore's own Node::willRemove() implementation to
                  cancel the load when the frame is removed.
                  (The load is not actually directly canceled per say, but the
                  loading logic checks to see if the frame is still in the frame
                  tree right after creating the frame and aborts if its not.
                  HTMLFrameOwnerElement::willRemove clears the frame owner pointer
                  causing the frame to be removed from the tree.)
      2010-09-10  Eric Seidel  <eric@webkit.org>
      
              Reviewed by Dimitri Glazkov.
      
              Remove support for non-lazy attach and fix frames to load from insertedIntoDocument instead of attach
              https://bugs.webkit.org/show_bug.cgi?id=45365
      
              This change is the last piece of the puzzle which was preventing us from
              removing all eager-attach logic and moving WebCore to using an entirely
              recalcStyle-driven, on-demand renderer creation system, instead of every
              element being synchronously attached during parsing, regardless of whether
              it was ever going to be displayed or not.
      
              This does not change the places we call lazyAttach vs. attach.  This only
              changes the behavior of frame/plugin elements when lazyAttach is called.
              Previously lazyAttach would eager-attach those elements (and their ancestors)
              because they were marked as canLazyAttach() { return false; }.
      
              This is a very tricky change, please review carefully.
      
              Mostly I'm moving logic which used to be in attach() into
              insertedIntoDocument.  Once it was there, there was no longer any reason
              why frame elements couldn't lazyAttach, thus removing the need
              for the non-lazy attach code path entirely.
              We've not yet converted all callsites over to using lazyAttach() instead
              of attach() however.
      
              In order to move frame loading logic into insertedIntoDocument
              instead of attach, I needed to make sure that any javascript calls
              during the load would see an attached element.  Thus I needed to mark
              the element as needing style resolve so that it would attach itself
              if needed.
      
              I was not able to just call lazyAttach() from insertedIntoDocument directly
              due to two conflicting assumptions in the rendering tree:
               1. ContainerNode::attach() assumes its "safe" to call attach on all children
                  without checking first if the child is already attached.  This seems sane
                  since its strange to think of a subtree as being attached w/o ancestors
                  already being attached.  Although it is a hard rule that subtrees may not
                  have renderers w/o ancestors also having renderers, I do not believe it's
                  a hard rule that subtrees may not be attached.  Remember, attached() does
                  not imply renderer()!  It's possible ContainerNode::attach()'s assumption is wrong here.
               2. Node::attach() asserts !attached().  This makes sense and I would not
                  want to remove this assert, however it means that if insertedIntoDocument
                  were to call lazyAttach() (thus marking the element as attached()) then
                  all callers would need to check if the element was already attached after
                  insertedIntoDocument (called by appendChild, parserAppendChild, etc.)
                  before calling attach or lazyAttach().  The following example:
                  element.innerHTML = "<span><iframe></span>" is one case where this
                  ASSERT would be hit if insertedIntoDocument called lazyAttach, since
                  ContainerNode::attach() (called on the span by in appendChild(DocumentFragment) code)
                  does not check if iframe is already attached.
      
              Note: One subtle change here is that synchronous javascript which results
              from javascript: or beforeload is now run as part of insertedIntoDocument
              (thus any insert/append call *even* parserAddChild) instead of being
              run during attach (technically in the post-attach callbacks).
      
              This is covered by numerous layout tests.
      
              * dom/ContainerNode.cpp:
              (WebCore::willRemoveChild):
              (WebCore::willRemoveChildren):
               - Since insertedIntoDocument starts a load and yet does not mark the
                 element as attached, we need to always call willRemove().
                 See note above as to why we don't just mark attached() in insertedIntoDocument.
              * dom/Node.cpp:
              (WebCore::Node::markAncestorsWithChildNeedsStyleRecalc):
               - Share some code between lazyAttach and setNeedsStyleRecalc.
              (WebCore::Node::setNeedsStyleRecalc):
               - Use the new markAncestorsWithChildNeedsStyleRecalc
              (WebCore::Node::lazyAttach):
               - Remove the non-lazy code path, and use markAncestorsWithChildNeedsStyleRecalc.
               - Add an option to lazyAttach without marking attached(), used by HTMLFrameElementBase::insertedIntoDocument.
              * dom/Node.h:
              * html/HTMLFrameElementBase.cpp:
               - m_shouldOpenURLAfterAttach is no longer needed, yay!
               - m_checkAttachedTimer no longer has anything to do with attached(), so renamed it.
                 I also documented that the newly named m_checkInDocumentTimer is all about the
                 "magic iframe" performance quirk.  (Which is actually speced in HTML5).
                 I was initially baffled by this code, so I documented it.
              (WebCore::HTMLFrameElementBase::HTMLFrameElementBase)
              (WebCore::HTMLFrameElementBase::insertedIntoDocument):
               - This is the meat of this change, see discussion above.
              (WebCore::HTMLFrameElementBase::attach):
               - Code deleted or moved to insertedIntoDocument.
              (WebCore::HTMLFrameElementBase::width):
               - Fixed a bug in height()/width() which was probably causing crashes
                 and was causing incorrect behavior after this change.
                 renderBox() is not necessarily valid unless layout is up to date.
                 Updating layout, can cause renderBox() to go invalid, thus this
                 could have been a null-pointer crash.
              (WebCore::HTMLFrameElementBase::height): see width()
              (WebCore::HTMLFrameElementBase::setRemainsAliveOnRemovalFromTree): Timer rename.
              (WebCore::HTMLFrameElementBase::checkInDocumentTimerFired): Timer rename.
              * html/HTMLFrameElementBase.h:
              * html/HTMLFrameOwnerElement.cpp:
              (WebCore::HTMLFrameOwnerElement::willRemove):
               - Disconnecting the owner element removes the frame from the frame tree.
                 frameDetached() calls Page::frameCount which expects that the frame is
                 already gone at this point and asserts when it's not.  It's unclear how
                 this worked before, except that the frame removal was likely done in the
                 post-attach callback, so the frameCount was wrong (too high) during
                 frameDetached(), but was fixed up in the post-detach callback.
              * html/parser/HTMLConstructionSite.cpp:
              (WebCore::HTMLConstructionSite::attachAtSite):
                - Simplified this code, and added a check for the case when the node was already removed.
                  Since the load logic is now run during insertedIntoDocument instead of attach(),
                  synchronous javascript is now running during insertedIntoDocument and we need to
                  make sure that the child is still in the tree.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@67182 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      8cc44245
    • tkent@chromium.org's avatar
      2010-09-10 Kent Tamura <tkent@chromium.org> · 78429283
      tkent@chromium.org authored
              Unreviewed, test expectation update.
      
              * platform/chromium/drt_expectations.txt: Add some comments and sort.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@67181 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      78429283
    • rniwa@webkit.org's avatar
      2010-09-10 Ryosuke Niwa <rniwa@webkit.org> · a72b11da
      rniwa@webkit.org authored
              Unreviewed.
      
              Added editing/selection/doubleclick-inline-first-last-contenteditable.html to the qt's skipped list.
              See https://bugs.webkit.org/show_bug.cgi?id=45525 for the detail.
      
              * platform/qt/Skipped:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@67180 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      a72b11da
    • dpranke@chromium.org's avatar
      2010-09-10 Dirk Pranke <dpranke@chromium.org> · 9a91c979
      dpranke@chromium.org authored
              Unreviewed, rolling out r67178.
              http://trac.webkit.org/changeset/67178
              https://bugs.webkit.org/show_bug.cgi?id=45524
      
              re-roll-out patch to put original changes back in
      
              * fast/replaced/object-param-url-control-char.html:
              * fast/replaced/object-with-embed-url-param-expected.txt:
              * fast/replaced/object-with-embed-url-param.html:
      2010-09-10  Dirk Pranke  <dpranke@chromium.org>
      
              Unreviewed, rolling out r67178.
              http://trac.webkit.org/changeset/67178
              https://bugs.webkit.org/show_bug.cgi?id=45524
      
              re-roll-out patch to put original changes back in
      
              * html/HTMLObjectElement.cpp:
              (WebCore::HTMLObjectElement::parametersForPlugin):
              (WebCore::HTMLObjectElement::updateWidget):
              * loader/SubframeLoader.cpp:
              (WebCore::SubframeLoader::resourceWillUsePlugin):
              * loader/SubframeLoader.h:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@67179 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      9a91c979
    • dpranke@chromium.org's avatar
      2010-09-10 Dirk Pranke <dpranke@chromium.org> · 6e28f04b
      dpranke@chromium.org authored
              Reviewed by Kent Tamura.
      
              roll out r66992 and r66997 - possibly introduced a perf slowdown in chromium tests
              https://bugs.webkit.org/show_bug.cgi?id=45524
      
              * fast/replaced/object-param-url-control-char.html:
              * fast/replaced/object-with-embed-url-param-expected.txt:
              * fast/replaced/object-with-embed-url-param.html:
      2010-09-10  Dirk Pranke  <dpranke@chromium.org>
      
              Reviewed by Kent Tamura.
      
              roll out r66992 and r66997 - possibly introduced a perf slowdown in chromium tests
              https://bugs.webkit.org/show_bug.cgi?id=45524
      
              * html/HTMLObjectElement.cpp:
              (WebCore::HTMLObjectElement::parametersForPlugin):
              (WebCore::HTMLObjectElement::updateWidget):
              * loader/SubframeLoader.cpp:
              (WebCore::SubframeLoader::requestFrame):
              * loader/SubframeLoader.h:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@67178 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      6e28f04b