Commits · 42f4ea196041e64bd953996f4a350d48a2939495 · App_Technologies / webkit

25 Mar, 2010 20 commits

2010-03-25 Fumitoshi Ukai <ukai@chromium.org> · 42f4ea19

ukai@chromium.org authored Mar 25, 2010

        Reviewed by Eric Seidel.

        [Qt] websocket/tests/long-invalid-header.html fails
        https://bugs.webkit.org/show_bug.cgi?id=36492

        * websocket/tests/long-invalid-header-expected.txt: trim console message.
2010-03-25  Fumitoshi Ukai  <ukai@chromium.org>

        Reviewed by Eric Seidel.

        [Qt] websocket/tests/long-invalid-header.html fails
        https://bugs.webkit.org/show_bug.cgi?id=36492

        trim message at most 128 bytes from the current position.
        I believe it's enough data to investigate the error reason and
        it makes test not depend on buffered size.

        * websockets/WebSocketHandshake.cpp:
        (WebCore::trimConsoleMessage):
        (WebCore::WebSocketHandshake::readServerHandshake):
        (WebCore::WebSocketHandshake::readHTTPHeaders):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@56511 268f45cc-cd09-0410-ab3c-d52691b4dbfc

42f4ea19

2010-03-25 Adam Barth <abarth@webkit.org> · d78f1b45

abarth@webkit.org authored Mar 25, 2010

        Unreviewed.  Create webkitpy.common.checkout as described in
        https://bugs.webkit.org/show_bug.cgi?id=36093

        * Scripts/webkitpy/changelogs.py: Removed.
        * Scripts/webkitpy/changelogs_unittest.py: Removed.
        * Scripts/webkitpy/commitinfo.py: Removed.
        * Scripts/webkitpy/commitinfo_unittest.py: Removed.
        * Scripts/webkitpy/common/checkout: Added.
        * Scripts/webkitpy/common/checkout/__init__.py: Copied from Scripts/webkitpy/common/__init__.py.
        * Scripts/webkitpy/common/checkout/changelog.py: Copied from Scripts/webkitpy/changelogs.py.
        * Scripts/webkitpy/common/checkout/changelog_unittest.py: Copied from Scripts/webkitpy/changelogs_unittest.py.
        * Scripts/webkitpy/common/checkout/commitinfo.py: Copied from Scripts/webkitpy/commitinfo.py.
        * Scripts/webkitpy/common/checkout/commitinfo_unittest.py: Copied from Scripts/webkitpy/commitinfo_unittest.py.
        * Scripts/webkitpy/common/checkout/diff_parser.py: Copied from Scripts/webkitpy/diff_parser.py.
        * Scripts/webkitpy/common/checkout/diff_parser_unittest.py: Copied from Scripts/webkitpy/diff_parser_unittest.py.
        * Scripts/webkitpy/common/checkout/scm.py: Copied from Scripts/webkitpy/scm.py.
        * Scripts/webkitpy/common/checkout/scm_unittest.py: Copied from Scripts/webkitpy/scm_unittest.py.
        * Scripts/webkitpy/common/net/credentials.py:
        * Scripts/webkitpy/diff_parser.py: Removed.
        * Scripts/webkitpy/diff_parser_unittest.py: Removed.
        * Scripts/webkitpy/layout_tests/port/base.py:
        * Scripts/webkitpy/scm.py: Removed.
        * Scripts/webkitpy/scm_unittest.py: Removed.
        * Scripts/webkitpy/stepsequence.py:
        * Scripts/webkitpy/style_references.py:
        * Scripts/webkitpy/tool/commands/download.py:
        * Scripts/webkitpy/tool/commands/queries.py:
        * Scripts/webkitpy/tool/comments.py:
        * Scripts/webkitpy/tool/main.py:
        * Scripts/webkitpy/tool/mocktool.py:
        * Scripts/webkitpy/tool/steps/preparechangelogforrevert.py:
        * Scripts/webkitpy/tool/steps/updatechangelogswithreviewer.py:
        * Scripts/webkitpy/tool/steps/validatereviewer.py:
        * Scripts/webkitpy/unittests.py:
        * Scripts/webkitpy/webkitcheckout.py:


git-svn-id: http://svn.webkit.org/repository/webkit/trunk@56510 268f45cc-cd09-0410-ab3c-d52691b4dbfc

d78f1b45

In webkitpy, moved init/versioning.py to python24/. · 55b1f4ee

cjerdonek@webkit.org authored Mar 25, 2010

Reviewed by Adam Barth.

https://bugs.webkit.org/show_bug.cgi?id=36093

This is part of the master bug to reorganize webkitpy.

* Scripts/test-webkitpy:
* Scripts/webkit-patch:
* Scripts/webkitpy/init/unittests.py:
* Scripts/webkitpy/init/versioning.py: Removed.
* Scripts/webkitpy/init/versioning_unittest.py: Removed.
* Scripts/webkitpy/python24: Added.
* Scripts/webkitpy/python24/__init__.py: Copied from WebKitTools/Scripts/webkitpy/tool/__init__.py.
* Scripts/webkitpy/python24/versioning.py: Copied from WebKitTools/Scripts/webkitpy/init/versioning.py.
* Scripts/webkitpy/python24/versioning_unittest.py: Copied from WebKitTools/Scripts/webkitpy/init/versioning_unittest.py.
* Scripts/webkitpy/unittests.py:



git-svn-id: http://svn.webkit.org/repository/webkit/trunk@56509 268f45cc-cd09-0410-ab3c-d52691b4dbfc

55b1f4ee

2010-03-25 Adam Barth <abarth@webkit.org> · 9fad24e5

abarth@webkit.org authored Mar 25, 2010

        Unreviewed.

        Create webkitpy.common.net as described in
        https://bugs.webkit.org/show_bug.cgi?id=36093

        * Scripts/webkitpy/bugzilla.py: Removed.
        * Scripts/webkitpy/bugzilla_unittest.py: Removed.
        * Scripts/webkitpy/buildbot.py: Removed.
        * Scripts/webkitpy/buildbot_unittest.py: Removed.
        * Scripts/webkitpy/commitinfo.py:
        * Scripts/webkitpy/common/net: Added.
        * Scripts/webkitpy/common/net/__init__.py: Added.
        * Scripts/webkitpy/common/net/bugzilla.py: Copied from Scripts/webkitpy/bugzilla.py.
        * Scripts/webkitpy/common/net/bugzilla_unittest.py: Copied from Scripts/webkitpy/bugzilla_unittest.py.
        * Scripts/webkitpy/common/net/buildbot.py: Copied from Scripts/webkitpy/buildbot.py.
        * Scripts/webkitpy/common/net/buildbot_unittest.py: Copied from Scripts/webkitpy/buildbot_unittest.py.
        * Scripts/webkitpy/common/net/credentials.py: Copied from Scripts/webkitpy/credentials.py.
        * Scripts/webkitpy/common/net/credentials_unittest.py: Copied from Scripts/webkitpy/credentials_unittest.py.
        * Scripts/webkitpy/common/net/irc: Copied from Scripts/webkitpy/irc.
        * Scripts/webkitpy/common/net/irc/ircbot.py:
        * Scripts/webkitpy/common/net/irc/ircproxy.py:
        * Scripts/webkitpy/common/net/irc/messagepump_unittest.py:
        * Scripts/webkitpy/common/net/irc/threadedmessagequeue_unittest.py:
        * Scripts/webkitpy/common/net/irc/unittests.py:
        * Scripts/webkitpy/common/net/networktransaction.py: Copied from Scripts/webkitpy/networktransaction.py.
        * Scripts/webkitpy/common/net/networktransaction_unittest.py: Copied from Scripts/webkitpy/networktransaction_unittest.py.
        * Scripts/webkitpy/common/net/statusserver.py: Copied from Scripts/webkitpy/statusserver.py.
        * Scripts/webkitpy/credentials.py: Removed.
        * Scripts/webkitpy/credentials_unittest.py: Removed.
        * Scripts/webkitpy/irc: Removed.
        * Scripts/webkitpy/irc/__init__.py: Removed.
        * Scripts/webkitpy/irc/ircbot.py: Removed.
        * Scripts/webkitpy/irc/ircproxy.py: Removed.
        * Scripts/webkitpy/irc/messagepump.py: Removed.
        * Scripts/webkitpy/irc/messagepump_unittest.py: Removed.
        * Scripts/webkitpy/irc/threadedmessagequeue.py: Removed.
        * Scripts/webkitpy/irc/threadedmessagequeue_unittest.py: Removed.
        * Scripts/webkitpy/irc/unittests.py: Removed.
        * Scripts/webkitpy/networktransaction.py: Removed.
        * Scripts/webkitpy/networktransaction_unittest.py: Removed.
        * Scripts/webkitpy/scm_unittest.py:
        * Scripts/webkitpy/statusserver.py: Removed.
        * Scripts/webkitpy/tool/bot/queueengine.py:
        * Scripts/webkitpy/tool/commands/download.py:
        * Scripts/webkitpy/tool/commands/queries.py:
        * Scripts/webkitpy/tool/commands/queries_unittest.py:
        * Scripts/webkitpy/tool/commands/queues.py:
        * Scripts/webkitpy/tool/commands/queues_unittest.py:
        * Scripts/webkitpy/tool/commands/queuestest.py:
        * Scripts/webkitpy/tool/commands/upload.py:
        * Scripts/webkitpy/tool/main.py:
        * Scripts/webkitpy/tool/mocktool.py:
        * Scripts/webkitpy/tool/steps/postdiffforrevert.py:
        * Scripts/webkitpy/unittests.py:


git-svn-id: http://svn.webkit.org/repository/webkit/trunk@56508 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9fad24e5

<rdar://problem/7780798 > Missing plug-ins should be represented by text · b4560152

jhoneycutt@apple.com authored Mar 25, 2010

only, instead of lego block

https://bugs.webkit.org/show_bug.cgi?id=36583

Reviewed by Dan Bernstein.

WebCore:

* rendering/RenderEmbeddedObject.cpp:
(WebCore::RenderEmbeddedObject::paintReplaced):
Set the font rendering mode and the computed size, so that the text will
draw properly on Windows.

WebKit/win:

* WebCoreSupport/WebFrameLoaderClient.cpp:
(WebFrameLoaderClient::createPlugin):
Return 0 if we failed to initialize the plug-in, which causes the new
"missing plug-in" text to draw.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@56507 268f45cc-cd09-0410-ab3c-d52691b4dbfc

b4560152

2010-03-25 Kinuko Yasuda <kinuko@chromium.org> · 274ac6c1

eric@webkit.org authored Mar 25, 2010

        Reviewed by David Levin.

        Rewrite the layout test editing/inserting/6633727 to use dumpAsText
        https://bugs.webkit.org/show_bug.cgi?id=31579

        * editing/inserting/6633727-expected.txt: Added.
        * editing/inserting/6633727.html:
        * editing/inserting/script-tests/6633727.js: Added.
        * platform/gtk/editing/inserting/6633727-expected.txt: Removed.
        * platform/mac/editing/inserting/6633727-expected.checksum: Removed.
        * platform/mac/editing/inserting/6633727-expected.png: Removed.
        * platform/mac/editing/inserting/6633727-expected.txt: Removed.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@56506 268f45cc-cd09-0410-ab3c-d52691b4dbfc

274ac6c1

In webkitpy, renamed MockBugzillaTool to MockTool. · be166968

cjerdonek@webkit.org authored Mar 25, 2010

Reviewed by Adam Barth.

* Scripts/webkitpy/tool/commands/commandtest.py:
* Scripts/webkitpy/tool/commands/queries_unittest.py:
* Scripts/webkitpy/tool/commands/queues_unittest.py:
* Scripts/webkitpy/tool/commands/queuestest.py:
* Scripts/webkitpy/tool/commands/sheriffbot_unittest.py:
* Scripts/webkitpy/tool/commands/upload_unittest.py:
* Scripts/webkitpy/tool/mocktool.py:
* Scripts/webkitpy/tool/steps/closebugforlanddiff_unittest.py:
* Scripts/webkitpy/tool/steps/steps_unittest.py:
* Scripts/webkitpy/tool/steps/updatechangelogswithreview_unittests.py:



git-svn-id: http://svn.webkit.org/repository/webkit/trunk@56505 268f45cc-cd09-0410-ab3c-d52691b4dbfc

be166968

In Scripts/webkitpy, moved webkitport.py and committers.py into · b7de2bdc

cjerdonek@webkit.org authored Mar 25, 2010

common/config/ (also creating common/config/).

Reviewed by Adam Barth.

https://bugs.webkit.org/show_bug.cgi?id=36093

This is part of the master bug to reorganize webkitpy.

* Scripts/validate-committer-lists:
* Scripts/webkitpy/bugzilla.py:
* Scripts/webkitpy/bugzilla_unittest.py:
* Scripts/webkitpy/changelogs.py:
* Scripts/webkitpy/commitinfo.py:
* Scripts/webkitpy/commitinfo_unittest.py:
* Scripts/webkitpy/committers.py: Removed.
* Scripts/webkitpy/committers_unittest.py: Removed.
* Scripts/webkitpy/common: Added.
* Scripts/webkitpy/common/__init__.py: Copied from WebKitTools/Scripts/webkitpy/style/__init__.py.
* Scripts/webkitpy/common/config: Added.
* Scripts/webkitpy/common/config/__init__.py: Copied from WebKitTools/Scripts/webkitpy/style/__init__.py.
* Scripts/webkitpy/common/config/committers.py: Copied from WebKitTools/Scripts/webkitpy/committers.py.
* Scripts/webkitpy/common/config/committers_unittest.py: Copied from WebKitTools/Scripts/webkitpy/committers_unittest.py.
* Scripts/webkitpy/common/config/ports.py: Copied from WebKitTools/Scripts/webkitpy/webkitport.py.
* Scripts/webkitpy/common/config/ports_unittest.py: Copied from WebKitTools/Scripts/webkitpy/webkitport_unittest.py.
* Scripts/webkitpy/mock_bugzillatool.py:
* Scripts/webkitpy/tool/commands/early_warning_system.py:
* Scripts/webkitpy/tool/commands/queries.py:
* Scripts/webkitpy/tool/commands/sheriffbot.py:
* Scripts/webkitpy/tool/commands/upload.py:
* Scripts/webkitpy/tool/steps/abstractstep.py:
* Scripts/webkitpy/unittests.py:
* Scripts/webkitpy/webkitport.py: Removed.
* Scripts/webkitpy/webkitport_unittest.py: Removed.



git-svn-id: http://svn.webkit.org/repository/webkit/trunk@56504 268f45cc-cd09-0410-ab3c-d52691b4dbfc

b7de2bdc

2010-03-25 Adam Barth <abarth@webkit.org> · e6a80c6d

abarth@webkit.org authored Mar 25, 2010

        Unreviewed.  Move mock_bugzillatool.py to tool/mocktool.py.

        * Scripts/webkitpy/mock_bugzillatool.py: Removed.
        * Scripts/webkitpy/tool/commands/commandtest.py:
        * Scripts/webkitpy/tool/commands/queries_unittest.py:
        * Scripts/webkitpy/tool/commands/queues_unittest.py:
        * Scripts/webkitpy/tool/commands/queuestest.py:
        * Scripts/webkitpy/tool/commands/sheriffbot_unittest.py:
        * Scripts/webkitpy/tool/commands/upload_unittest.py:
        * Scripts/webkitpy/tool/mocktool.py: Copied from Scripts/webkitpy/mock_bugzillatool.py.
        * Scripts/webkitpy/tool/steps/closebugforlanddiff_unittest.py:
        * Scripts/webkitpy/tool/steps/steps_unittest.py:
        * Scripts/webkitpy/tool/steps/updatechangelogswithreview_unittests.py:


git-svn-id: http://svn.webkit.org/repository/webkit/trunk@56503 268f45cc-cd09-0410-ab3c-d52691b4dbfc

e6a80c6d

2010-03-24 Vangelis Kokkevis <vangelis@chromium.org> · f6a3c1b8

eric@webkit.org authored Mar 25, 2010

        Reviewed by Dimitri Glazkov.

        Removing unecessary redraws of LayerSkia contents:
        https://bugs.webkit.org/show_bug.cgi?id=36470

        Test: No new functionality added, no tests.

        * platform/graphics/skia/LayerRendererSkia.cpp:
        (WebCore::LayerRendererSkia::drawLayerInCanvasRecursive):
        Debug borders now rendered at composite time rather than update time.
        * platform/graphics/skia/LayerSkia.cpp:
        (WebCore::LayerSkia::updateContents):
        (WebCore::LayerSkia::drawDebugBorder):
        Debug border drawing removed from updateContents and split into a separate method that
        can be called at composite time.
        (WebCore::LayerSkia::setBounds):
        Resetting the bounds causes the layer to redraw its contents.
        (WebCore::LayerSkia::setNeedsDisplay):
        * platform/graphics/skia/LayerSkia.h:
        Added declaration for drawDebugBorders method.
2010-03-24  Vangelis Kokkevis  <vangelis@chromium.org>

        Reviewed by Dimitri Glazkov.

        Eliminate unecessary redraws of GraphicsLayer contents when doing accelerated compositing:
        https://bugs.webkit.org/show_bug.cgi?id=36470

        * src/WebViewImpl.cpp:
        (WebKit::WebViewImpl::paint):
        Remove call that forced redrawing the contents of the entire layer hierarchy.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@56502 268f45cc-cd09-0410-ab3c-d52691b4dbfc

f6a3c1b8

2010-03-24 Adam Barth <abarth@webkit.org> · a8401a43

abarth@webkit.org authored Mar 25, 2010

        Unreviewed.  Move comments.py and multicommandtool.py to their new
        home.

        * Scripts/webkitpy/comments.py: Removed.
        * Scripts/webkitpy/multicommandtool.py: Removed.
        * Scripts/webkitpy/multicommandtool_unittest.py: Removed.
        * Scripts/webkitpy/tool/commands/abstractsequencedcommand.py:
        * Scripts/webkitpy/tool/commands/download.py:
        * Scripts/webkitpy/tool/commands/openbugs.py:
        * Scripts/webkitpy/tool/commands/queries.py:
        * Scripts/webkitpy/tool/commands/queues.py:
        * Scripts/webkitpy/tool/commands/upload.py:
        * Scripts/webkitpy/tool/comments.py: Copied from Scripts/webkitpy/comments.py.
        * Scripts/webkitpy/tool/main.py:
        * Scripts/webkitpy/tool/multicommandtool.py: Copied from Scripts/webkitpy/multicommandtool.py.
        * Scripts/webkitpy/tool/multicommandtool_unittest.py: Copied from Scripts/webkitpy/multicommandtool_unittest.py.
        * Scripts/webkitpy/tool/steps/closebugforlanddiff.py:
        * Scripts/webkitpy/tool/steps/closepatch.py:
        * Scripts/webkitpy/tool/steps/reopenbugafterrollout.py:
        * Scripts/webkitpy/unittests.py:


git-svn-id: http://svn.webkit.org/repository/webkit/trunk@56501 268f45cc-cd09-0410-ab3c-d52691b4dbfc

a8401a43

2010-03-24 Adam Barth <abarth@webkit.org> · 37d2a9f1

abarth@webkit.org authored Mar 25, 2010

        Unreviewed.  Fixup one import statement I didn't find because the .pyc
        masked the error.

        * Scripts/webkitpy/stepsequence.py:


git-svn-id: http://svn.webkit.org/repository/webkit/trunk@56500 268f45cc-cd09-0410-ab3c-d52691b4dbfc

37d2a9f1

2010-03-24 Adam Barth <abarth@webkit.org> · 5ac6267b

abarth@webkit.org authored Mar 25, 2010

        Unreviewed.  Move queueengine.py to its new home.

        * Scripts/webkitpy/queueengine.py: Removed.
        * Scripts/webkitpy/queueengine_unittest.py: Removed.
        * Scripts/webkitpy/tool/bot/queueengine.py: Copied from Scripts/webkitpy/queueengine.py.
        * Scripts/webkitpy/tool/bot/queueengine_unittest.py: Copied from Scripts/webkitpy/queueengine_unittest.py.
        * Scripts/webkitpy/tool/commands/early_warning_system.py:
        * Scripts/webkitpy/tool/commands/queues.py:
        * Scripts/webkitpy/unittests.py:


git-svn-id: http://svn.webkit.org/repository/webkit/trunk@56499 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5ac6267b

2010-03-24 Adam Barth <abarth@webkit.org> · 4acdac24

abarth@webkit.org authored Mar 25, 2010

        Unreviewed.  Move patchcollection.py to its new home.

        * Scripts/webkitpy/patchcollection.py: Removed.
        * Scripts/webkitpy/patchcollection_unittest.py: Removed.
        * Scripts/webkitpy/tool/bot: Added.
        * Scripts/webkitpy/tool/bot/__init__.py: Added.
        * Scripts/webkitpy/tool/bot/patchcollection.py: Copied from WebKitTools/Scripts/webkitpy/patchcollection.py.
        * Scripts/webkitpy/tool/bot/patchcollection_unittest.py: Copied from WebKitTools/Scripts/webkitpy/patchcollection_unittest.py.
        * Scripts/webkitpy/tool/commands/queues.py:
        * Scripts/webkitpy/unittests.py:


git-svn-id: http://svn.webkit.org/repository/webkit/trunk@56498 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4acdac24

In Scripts/webkitpy, moved steps_references.py and the steps · 2f1406fe

cjerdonek@webkit.org authored Mar 25, 2010

folder into webkitpy/patch.

Reviewed by Adam Barth.

https://bugs.webkit.org/show_bug.cgi?id=36093

* Scripts/webkitpy/steps: Removed.
* Scripts/webkitpy/steps/__init__.py: Removed.
* Scripts/webkitpy/steps/abstractstep.py: Removed.
* Scripts/webkitpy/steps/applypatch.py: Removed.
* Scripts/webkitpy/steps/applypatchwithlocalcommit.py: Removed.
* Scripts/webkitpy/steps/build.py: Removed.
* Scripts/webkitpy/steps/checkstyle.py: Removed.
* Scripts/webkitpy/steps/cleanworkingdirectory.py: Removed.
* Scripts/webkitpy/steps/cleanworkingdirectorywithlocalcommits.py: Removed.
* Scripts/webkitpy/steps/closebug.py: Removed.
* Scripts/webkitpy/steps/closebugforlanddiff.py: Removed.
* Scripts/webkitpy/steps/closebugforlanddiff_unittest.py: Removed.
* Scripts/webkitpy/steps/closepatch.py: Removed.
* Scripts/webkitpy/steps/commit.py: Removed.
* Scripts/webkitpy/steps/confirmdiff.py: Removed.
* Scripts/webkitpy/steps/createbug.py: Removed.
* Scripts/webkitpy/steps/editchangelog.py: Removed.
* Scripts/webkitpy/steps/ensurebuildersaregreen.py: Removed.
* Scripts/webkitpy/steps/ensurelocalcommitifneeded.py: Removed.
* Scripts/webkitpy/steps/metastep.py: Removed.
* Scripts/webkitpy/steps/obsoletepatches.py: Removed.
* Scripts/webkitpy/steps/options.py: Removed.
* Scripts/webkitpy/steps/postdiff.py: Removed.
* Scripts/webkitpy/steps/postdiffforcommit.py: Removed.
* Scripts/webkitpy/steps/postdiffforrevert.py: Removed.
* Scripts/webkitpy/steps/preparechangelog.py: Removed.
* Scripts/webkitpy/steps/preparechangelogforrevert.py: Removed.
* Scripts/webkitpy/steps/promptforbugortitle.py: Removed.
* Scripts/webkitpy/steps/reopenbugafterrollout.py: Removed.
* Scripts/webkitpy/steps/revertrevision.py: Removed.
* Scripts/webkitpy/steps/runtests.py: Removed.
* Scripts/webkitpy/steps/steps_unittest.py: Removed.
* Scripts/webkitpy/steps/update.py: Removed.
* Scripts/webkitpy/steps/updatechangelogswithreview_unittests.py: Removed.
* Scripts/webkitpy/steps/updatechangelogswithreviewer.py: Removed.
* Scripts/webkitpy/steps/validatereviewer.py: Removed.
* Scripts/webkitpy/steps_references.py: Removed.
* Scripts/webkitpy/stepsequence.py:
* Scripts/webkitpy/tool/commands/download.py:
* Scripts/webkitpy/tool/commands/upload.py:
* Scripts/webkitpy/tool/steps: Copied from WebKitTools/Scripts/webkitpy/steps.
* Scripts/webkitpy/tool/steps/__init__.py:
* Scripts/webkitpy/tool/steps/applypatch.py:
* Scripts/webkitpy/tool/steps/applypatchwithlocalcommit.py:
* Scripts/webkitpy/tool/steps/build.py:
* Scripts/webkitpy/tool/steps/checkstyle.py:
* Scripts/webkitpy/tool/steps/cleanworkingdirectory.py:
* Scripts/webkitpy/tool/steps/cleanworkingdirectorywithlocalcommits.py:
* Scripts/webkitpy/tool/steps/closebug.py:
* Scripts/webkitpy/tool/steps/closebugforlanddiff.py:
* Scripts/webkitpy/tool/steps/closebugforlanddiff_unittest.py:
* Scripts/webkitpy/tool/steps/closepatch.py:
* Scripts/webkitpy/tool/steps/commit.py:
* Scripts/webkitpy/tool/steps/confirmdiff.py:
* Scripts/webkitpy/tool/steps/createbug.py:
* Scripts/webkitpy/tool/steps/editchangelog.py:
* Scripts/webkitpy/tool/steps/ensurebuildersaregreen.py:
* Scripts/webkitpy/tool/steps/ensurelocalcommitifneeded.py:
* Scripts/webkitpy/tool/steps/metastep.py:
* Scripts/webkitpy/tool/steps/obsoletepatches.py:
* Scripts/webkitpy/tool/steps/postdiff.py:
* Scripts/webkitpy/tool/steps/postdiffforcommit.py:
* Scripts/webkitpy/tool/steps/postdiffforrevert.py:
* Scripts/webkitpy/tool/steps/preparechangelog.py:
* Scripts/webkitpy/tool/steps/preparechangelogforrevert.py:
* Scripts/webkitpy/tool/steps/promptforbugortitle.py:
* Scripts/webkitpy/tool/steps/reopenbugafterrollout.py:
* Scripts/webkitpy/tool/steps/revertrevision.py:
* Scripts/webkitpy/tool/steps/runtests.py:
* Scripts/webkitpy/tool/steps/steps_unittest.py:
* Scripts/webkitpy/tool/steps/update.py:
* Scripts/webkitpy/tool/steps/updatechangelogswithreview_unittests.py:
* Scripts/webkitpy/tool/steps/updatechangelogswithreviewer.py:
* Scripts/webkitpy/tool/steps/validatereviewer.py:
* Scripts/webkitpy/tool/steps_references.py: Copied from WebKitTools/Scripts/webkitpy/steps_references.py.
* Scripts/webkitpy/unittests.py:



git-svn-id: http://svn.webkit.org/repository/webkit/trunk@56497 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2f1406fe

2010-03-24 Eric Seidel <eric@webkit.org> · 4ce856a1

eric@webkit.org authored Mar 25, 2010

        Unreviewed, build fix only.

        Abstract LayoutTestResults logic for easier reuse
        https://bugs.webkit.org/show_bug.cgi?id=36579

        * Scripts/webkitpy/buildbot_unittest.py: Add a missing import.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@56496 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4ce856a1

2010-03-24 Adam Barth <abarth@webkit.org> · 0d6ab7e1

abarth@webkit.org authored Mar 25, 2010

        Unreviewed.  Fix a stray comma to test landing an patch without review.

        * Scripts/webkitpy/commitinfo.py:


git-svn-id: http://svn.webkit.org/repository/webkit/trunk@56495 268f45cc-cd09-0410-ab3c-d52691b4dbfc

0d6ab7e1

In Scripts/webkitpy, moved commands_references.py and the commands · 4d7c5781

cjerdonek@webkit.org authored Mar 25, 2010

folder into webkitpy/patch.

Reviewed by Adam Barth.

https://bugs.webkit.org/show_bug.cgi?id=36483

This is part of master bug 36093 to organize webkitpy.

* Scripts/webkitpy/commands: Removed.
* Scripts/webkitpy/commands/__init__.py: Removed.
* Scripts/webkitpy/commands/abstractsequencedcommand.py: Removed.
* Scripts/webkitpy/commands/commandtest.py: Removed.
* Scripts/webkitpy/commands/download.py: Removed.
* Scripts/webkitpy/commands/download_unittest.py: Removed.
* Scripts/webkitpy/commands/early_warning_system.py: Removed.
* Scripts/webkitpy/commands/early_warning_system_unittest.py: Removed.
* Scripts/webkitpy/commands/openbugs.py: Removed.
* Scripts/webkitpy/commands/openbugs_unittest.py: Removed.
* Scripts/webkitpy/commands/queries.py: Removed.
* Scripts/webkitpy/commands/queries_unittest.py: Removed.
* Scripts/webkitpy/commands/queues.py: Removed.
* Scripts/webkitpy/commands/queues_unittest.py: Removed.
* Scripts/webkitpy/commands/queuestest.py: Removed.
* Scripts/webkitpy/commands/sheriffbot.py: Removed.
* Scripts/webkitpy/commands/sheriffbot_unittest.py: Removed.
* Scripts/webkitpy/commands/upload.py: Removed.
* Scripts/webkitpy/commands/upload_unittest.py: Removed.
* Scripts/webkitpy/commands_references.py: Removed.
* Scripts/webkitpy/tool/commands: Copied from WebKitTools/Scripts/webkitpy/commands.
* Scripts/webkitpy/tool/commands/commandtest.py:
* Scripts/webkitpy/tool/commands/download.py:
* Scripts/webkitpy/tool/commands/download_unittest.py:
* Scripts/webkitpy/tool/commands/early_warning_system.py:
* Scripts/webkitpy/tool/commands/early_warning_system_unittest.py:
* Scripts/webkitpy/tool/commands/openbugs_unittest.py:
* Scripts/webkitpy/tool/commands/queries_unittest.py:
* Scripts/webkitpy/tool/commands/queues_unittest.py:
* Scripts/webkitpy/tool/commands/queuestest.py:
* Scripts/webkitpy/tool/commands/sheriffbot.py:
* Scripts/webkitpy/tool/commands/sheriffbot_unittest.py:
* Scripts/webkitpy/tool/commands/upload.py:
* Scripts/webkitpy/tool/commands/upload_unittest.py:
* Scripts/webkitpy/tool/commands_references.py: Copied from WebKitTools/Scripts/webkitpy/commands_references.py.
* Scripts/webkitpy/tool/main.py:
* Scripts/webkitpy/unittests.py:



git-svn-id: http://svn.webkit.org/repository/webkit/trunk@56494 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4d7c5781

Build fix after r56474. · 159c605e

mrowe@apple.com authored Mar 25, 2010

* Plugins/Hosted/NetscapePluginHostProxy.mm:
(WKPCRunSyncOpenPanel):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@56493 268f45cc-cd09-0410-ab3c-d52691b4dbfc

159c605e

Revert the portion of r56489 that dealt with port zero as it introduced some test failures. · d92737e0

mrowe@apple.com authored Mar 25, 2010

WebCore:

* platform/KURL.cpp:
(WebCore::KURL::port): Use the "ok" argument to charactersToUIntStrict to determine whether
it was able to successfully parse the string as an unsigned integer, rather than relying on
the fact it returned zero when it failed.

LayoutTests:

* platform/mac/security/block-test-expected.txt:
* security/block-test.html:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@56492 268f45cc-cd09-0410-ab3c-d52691b4dbfc

d92737e0

24 Mar, 2010 20 commits

2010-03-24 Adam Barth <abarth@webkit.org> · 624d13a1

abarth@webkit.org authored Mar 25, 2010

        Reviewed by Eric Seidel.

        Rename webkitpy.patch to webkitpy.tool
        https://bugs.webkit.org/show_bug.cgi?id=36580

        This is in preparation for the great webkitpy naming cleanup.

        * Scripts/webkit-patch:
        * Scripts/webkitpy/patch: Removed.
        * Scripts/webkitpy/patch/__init__.py: Removed.
        * Scripts/webkitpy/patch/patcher.py: Removed.
        * Scripts/webkitpy/tool: Copied from WebKitTools/Scripts/webkitpy/patch.
        * Scripts/webkitpy/tool/main.py: Copied from WebKitTools/Scripts/webkitpy/patch/patcher.py.
        * Scripts/webkitpy/tool/patcher.py: Removed.


git-svn-id: http://svn.webkit.org/repository/webkit/trunk@56491 268f45cc-cd09-0410-ab3c-d52691b4dbfc

624d13a1

* platform/text/String.cpp: · 6bfa335d

barraclough@apple.com authored Mar 25, 2010

(WebCore::putUTF8Triple): Correct capitalization of function name.
(WebCore::String::utf8): Fix C-style casts.
(WebCore::String::fromUTF8): Remove unnecessary newline.
(WebCore::String::fromUTF8WithLatin1Fallback): Use early return.

Reviewed by Sam Weinig.



git-svn-id: http://svn.webkit.org/repository/webkit/trunk@56490 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6bfa335d

WebKit should treat port numbers outside the valid range as being blacklisted · 88ec8169

mrowe@apple.com authored Mar 25, 2010

<http://webkit.org/b/36571> / <rdar://problem/7790908>

Reviewed by Darin Adler.

WebCore:

* platform/KURL.cpp:
(WebCore::KURL::port): Map invalid port numbers to invalidPortNumber.
(WebCore::portAllowed): Add invalidPortNumber to the blacklist.
* platform/KURLGoogle.cpp:  invalid port numbers to invalidPortNumber.
(WebCore::KURL::port): Add invalidPortNumber to the blacklist.
Also bring this in to sync with KURL.  Having this identical code in two places is stupid.

LayoutTests:

* platform/mac/security/block-test-expected.txt:
* security/block-test.html: Add tests of a few invalid port numbers.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@56489 268f45cc-cd09-0410-ab3c-d52691b4dbfc

88ec8169

2010-03-24 Eric Seidel <eric@webkit.org> · 658b362b

eric@webkit.org authored Mar 25, 2010

        Reviewed by Adam Barth.

        Abstract LayoutTestResults logic for easier reuse
        https://bugs.webkit.org/show_bug.cgi?id=36579

        * Scripts/webkitpy/buildbot.py:
         - Split out logic into new LayoutTestResults class.
        * Scripts/webkitpy/buildbot_unittest.py:
         - Rename the testing class to match.
        * Scripts/webkitpy/commands/queries.py:
         - Use the new LayoutTestResults class.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@56488 268f45cc-cd09-0410-ab3c-d52691b4dbfc

658b362b

2010-03-24 Eric Seidel <eric@webkit.org> · 7ebd29a7

eric@webkit.org authored Mar 25, 2010

        Reviewed by Eric Seidel.

        Move Bugzilla.prompt_for_component to User.prompt_with_list for re-use
        https://bugs.webkit.org/show_bug.cgi?id=36577

        * Scripts/webkitpy/bugzilla.py:
         - Move prompt_for_component to User
        * Scripts/webkitpy/commands/queries.py:
         - Add a missing argument_names declaration.
        * Scripts/webkitpy/user.py:
         - Add prompt_with_list
         - Make staticmethods classmethods for easier mocking

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@56487 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7ebd29a7

2010-03-24 MORITA Hajime <morrita@google.com> · 48e5c951

eric@webkit.org authored Mar 25, 2010

        Reviewed by Eric Seidel.

        https://bugs.webkit.org/show_bug.cgi?id=36517
        svg/dom/frame-related-api-during-load.html shoud be more self-descriptive.

        * svg/dom/frame-related-api-during-load-expected.txt:
        * svg/dom/frame-related-api-during-load.html:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@56486 268f45cc-cd09-0410-ab3c-d52691b4dbfc

48e5c951

Fix bug URL. · 8cbbce7d

ddkilzer@apple.com authored Mar 25, 2010

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@56485 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8cbbce7d

<htp://webkit.org/b/36572 > commit-log-editor: thinks mergeChangeLogs.pl is a ChangeLog file · e33bfed0

ddkilzer@apple.com authored Mar 25, 2010

Reviewed by Eric Seidel.

Fixes the following error when committing a file with
"ChangeLog" in the name that isn't a ChangeLog (like
mergeChangeLogs.pl from r56471 and r56472):

    $ git commit .
    Can't open WebKitTools/Scripts/webkitperl/VCSUtils_unittest/mergeChangeLog at commit-log-editor line 132.
    error: There was a problem with the editor 'commit-log-editor'.
    Please supply the message using either -m or -F option.

* Scripts/commit-log-editor: Added '$' to anchor "ChangeLog" to
the end of the file name when searching for ChangeLog files in a
commit.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@56484 268f45cc-cd09-0410-ab3c-d52691b4dbfc

e33bfed0

<http://webkit.org/b/36570 > resolve-ChangeLogs: fall back to git-merge-file if... · 8cafd103

ddkilzer@apple.com authored Mar 25, 2010

<http://webkit.org/b/36570> resolve-ChangeLogs: fall back to git-merge-file if ChangeLog can't be merged

Reviewed by Eric Seidel.

* Scripts/resolve-ChangeLogs: Switched to exec git-merge-file if
the merge attempt fails.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@56483 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8cafd103

Switch String::latin1, String::utf8, String::fromUTF8 to · 58c9a3a5

barraclough@apple.com authored Mar 25, 2010

use WTF's Unicode conversion methods rather than TextEncoder.
These methods only perform simple conversion, and don't need
really require TextEncoder's full capability (to look up arbitrary
encodings by name), switching to only be dependent on WTF will
make it easier if we chose to move WebCore::String to WTF.

Reviewed by Sam Weinig.

* JavaScriptCore.exp:



git-svn-id: http://svn.webkit.org/repository/webkit/trunk@56482 268f45cc-cd09-0410-ab3c-d52691b4dbfc

58c9a3a5

2010-03-24 Andrew Scherkus <scherkus@chromium.org> · e6014201

scherkus@chromium.org authored Mar 25, 2010

        Reviewed by Eric Carlson, Eric Seidel and David Levin.

        Update a few more media layout tests to choose test clips based on codec support.

        https://bugs.webkit.org/show_bug.cgi?id=30435

        * media/audio-constructor-src.html: Switched to use findMediaFile().
        * media/audio-play-event-expected.txt: Updated results.
        * media/audio-play-event.html: Switched to use findMediaFile().
        * media/video-no-audio.html: Ditto.
        * media/video-source-add-src.html: Ditto.
        * media/video-src-change.html: Closed p tag.
        * platform/mac-leopard/media/video-no-audio-expected.checksum: New results due to changing source video.
        * platform/mac-leopard/media/video-no-audio-expected.png: Ditto.
        * platform/mac-leopard/media/video-no-audio-expected.txt: Ditto.
        * platform/mac/media/video-no-audio-expected.checksum: Ditto.
        * platform/mac/media/video-no-audio-expected.png: Ditto.
        * platform/mac/media/video-no-audio-expected.txt: Ditto.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@56481 268f45cc-cd09-0410-ab3c-d52691b4dbfc

e6014201

Switch String::latin1, String::utf8, String::fromUTF8 to · fc36118b

barraclough@apple.com authored Mar 25, 2010

use WTF's Unicode conversion methods rather than TextEncoder.
These methods only perform simple conversion, and don't need
really require TextEncoder's full capability (to look up arbitrary
encodings by name), switching to only be dependent on WTF will
make it easier if we chose to move WebCore::String to WTF.

Reviewed by Sam Weinig.

* JavaScriptCore.exp:



git-svn-id: http://svn.webkit.org/repository/webkit/trunk@56480 268f45cc-cd09-0410-ab3c-d52691b4dbfc

fc36118b

Add some missing exports. · b8032286

weinig@apple.com authored Mar 25, 2010

Reviewed by Mark Rowe.

* WebCore.base.exp:



git-svn-id: http://svn.webkit.org/repository/webkit/trunk@56479 268f45cc-cd09-0410-ab3c-d52691b4dbfc

b8032286

2010-03-24 Adam Barth <abarth@webkit.org> · fc1736e8

abarth@webkit.org authored Mar 25, 2010

        Reviewed by Eric Seidel.

        webkit-patch or pre-commit hook should validate reviewer lines before committing
        https://bugs.webkit.org/show_bug.cgi?id=26927

        Validate that patches have valid reivewers listed in their ChangeLogs
        before landing.  For patches without reviewers can be landed if their
        ChangeLogs state that they are unreviewed.

        * Scripts/webkitpy/changelogs.py:
        * Scripts/webkitpy/commands/download.py:
        * Scripts/webkitpy/commitinfo.py:
        * Scripts/webkitpy/commitinfo_unittest.py:
        * Scripts/webkitpy/mock_bugzillatool.py:
        * Scripts/webkitpy/steps/__init__.py:
        * Scripts/webkitpy/steps/validatereviewer.py: Added.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@56478 268f45cc-cd09-0410-ab3c-d52691b4dbfc

fc1736e8

Switch String::latin1, String::utf8, String::fromUTF8 to · 6b9f7275

barraclough@apple.com authored Mar 25, 2010

use WTF's Unicode conversion methods rather than TextEncoder.
These methods only perform simple conversion, and don't need
really require TextEncoder's full capability (to look up arbitrary
encodings by name), switching to only be dependent on WTF will
make it easier if we chose to move WebCore::String to WTF.

Reviewed by Sam Weinig.

* platform/text/String.cpp:
(WebCore::String::latin1):
(WebCore::putUTF8triple):
(WebCore::String::utf8):
(WebCore::String::fromUTF8):



git-svn-id: http://svn.webkit.org/repository/webkit/trunk@56477 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6b9f7275

Restore peace and justice to the universe. · 22b16429

eric@webkit.org authored Mar 25, 2010

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@56476 268f45cc-cd09-0410-ab3c-d52691b4dbfc

22b16429

Undefined names reported by pyflakes in python scripts · f4af1d0a

zecke@webkit.org authored Mar 25, 2010

ttps://bugs.webkit.org/show_bug.cgi?id=36403

Attempt to use names that exist or can exist in the lexical
scope instead of not being available at all.

* Scripts/webkitpy/changelogs.py: Use self._content.
* Scripts/webkitpy/layout_tests/port/base.py: Use os.stat
* Scripts/webkitpy/layout_tests/test_types/fuzzy_image_diff.py: Use self._port
* Scripts/webkitpy/style/processors/cpp_unittest.py: Use expected_message_re

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@56475 268f45cc-cd09-0410-ab3c-d52691b4dbfc

f4af1d0a

Reviewed by Anders Carlsson. · 52f9de72

ap@apple.com authored Mar 25, 2010

        https://bugs.webkit.org/show_bug.cgi?id=36563
        A plug-in makes Safari crash on http://www.itscodingtime.com/

        * Plugins/Hosted/NetscapePluginHostProxy.h:
        (WebKit::NetscapePluginHostProxy::port): Assert that the object is still alive. This isn't
        beautifully systemic, but helped catch a bug, and may help catch more.
        (WebKit::NetscapePluginHostProxy::clientPort): Ditto.
        (WebKit::NetscapePluginHostProxy::isProcessingRequests): Changed m_processingRequests to a
        static. This doesn't change behavior much, but helps avoid writing into deallocated memory.

        * Plugins/Hosted/NetscapePluginHostProxy.mm:
        (WebKit::NetscapePluginHostProxy::NetscapePluginHostProxy): Changed m_processingRequests
        to a static.
        (WebKit::NetscapePluginHostProxy::processRequests): Ditto. Changing m_processingRequests
        after destroying the object in pluginHostDied() was wrong, but reasonably harmless, as there
        wasn't much time for some other object to be allocated at this address.
        (WKPCEvaluate): Refetch host proxy, as it may have been destroyed.
        (WKPCInvoke): Ditto.
        (WKPCInvokeDefault): Ditto.
        (WKPCGetProperty): Ditto.
        (WKPCSetProperty): Ditto.
        (WKPCRemoveProperty): Ditto.
        (WKPCHasProperty): Ditto.
        (WKPCHasMethod): Ditto.
        (WKPCEnumerate): Ditto.
        (WKPCRunSyncOpenPanel): Ditto.

        * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
        (WebKit::NetscapePluginInstanceProxy::processRequestsAndWaitForReply): Bail out of the 
        "event loop" if host proxy went away while processing a request.



git-svn-id: http://svn.webkit.org/repository/webkit/trunk@56474 268f45cc-cd09-0410-ab3c-d52691b4dbfc

52f9de72

2010-03-24 Jesus Sanchez-Palencia <jesus.palencia@openbossa.org> · 1f13b6eb

eric@webkit.org authored Mar 25, 2010

        Reviewed by Kenneth Rohde Christiansen.

        Add the FrameFlatteningEnabled WebAttribute to QWebSettings.

        [Qt] Missing QWebSettings for Frame Flattening
        https://bugs.webkit.org/show_bug.cgi?id=36553

        * Api/qwebsettings.cpp:
        (QWebSettingsPrivate::apply):
        (QWebSettings::QWebSettings):
        * Api/qwebsettings.h:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@56473 268f45cc-cd09-0410-ab3c-d52691b4dbfc

1f13b6eb

<http://webkit.org/b/36560 > resolve-ChangeLogs: git-rebase fails when... · 3fd9a7dd

ddkilzer@apple.com authored Mar 24, 2010

<http://webkit.org/b/36560> resolve-ChangeLogs: git-rebase fails when resolve-ChangeLogs can't merge

Reviewed by Eric Seidel.

When resolve-ChangeLogs fails to merge a patch while running as
a git merge driver, it deletes the original file, which causes
an internal failure and stops git mid-merge:

    fatal: Failed to execute internal merge

The fix is to use the --force switch with patch so that it will
always attempt to apply the patch.  (The change in
mergeChangeLogs() for the previous commit also fixed this, but
adding --force also prevents any potential user interaction that
patch may want to display.)

* Scripts/VCSUtils.pm:
(mergeChangeLogs): Added --force switch to patch command.  Also
changed to use the exit status from the patch command to
determine the return value for this method.
* Scripts/webkitperl/VCSUtils_unittest/mergeChangeLogs.pl: Added
test to cover this bug.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@56472 268f45cc-cd09-0410-ab3c-d52691b4dbfc

3fd9a7dd