1. 19 Oct, 2007 36 commits
    • oliver's avatar
      Updating window properties to include new features from HTML5 database support · 429fda27
      oliver authored
      RS=Mark
      
      * fast/dom/Window/window-properties-expected.txt:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@26805 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      429fda27
    • thatcher's avatar
      Reviewed by Mark Rowe. · d48a55d3
      thatcher authored
              Fix a couple of exceptions for first time users.
      
              * misc/DatabaseExample.html:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@26804 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      d48a55d3
    • alp's avatar
      2007-10-19 Alp Toker <alp@atoker.com> · 6bea7fed
      alp authored
              Reviewed by Oliver.
      
              Use platform colors for text selection.
              Update the cache when the GTK style is changed.
      
              * platform/gtk/RenderThemeGtk.cpp:
              (WebCore::RenderThemeGtk::platformActiveSelectionBackgroundColor):
              (WebCore::RenderThemeGtk::platformInactiveSelectionBackgroundColor):
              (WebCore::RenderThemeGtk::platformActiveSelectionForegroundColor):
              (WebCore::RenderThemeGtk::platformInactiveSelectionForegroundColor):
              (WebCore::RenderThemeGtk::gtkStyleSet):
              (WebCore::RenderThemeGtk::gtkEntry):
              * platform/gtk/RenderThemeGtk.h:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@26803 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      6bea7fed
    • adele's avatar
      WebCore: · 0e02dc74
      adele authored
              Reviewed by Beth.
      
              Fix for: <rdar://problem/5518461> REGRESSION (2.0.4-3): Popup arrows are missing in small popups at homedepot.com
      
              Test: fast/forms/menulist-no-overflow.html
      
              * rendering/RenderMenuList.cpp: (WebCore::RenderMenuList::setStyle): Don't allow overflow on menu lists.
      
      LayoutTests:
      
              Reviewed by Beth.
      
              Test for <rdar://problem/5518461> REGRESSION (2.0.4-3): Popup arrows are missing in small popups at homedepot.com
      
              * fast/forms/menulist-no-overflow.html: Added.
              * platform/mac/fast/forms/menulist-no-overflow-expected.checksum: Added.
              * platform/mac/fast/forms/menulist-no-overflow-expected.png: Added.
              * platform/mac/fast/forms/menulist-no-overflow-expected.txt: Added.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@26802 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      0e02dc74
    • andersca's avatar
      Reviewed by Brady. · 1f21e614
      andersca authored
              Move some SQL-related classes to platform/sql.
              
              * WebCore.vcproj/WebCore.vcproj:
              * WebCore.xcodeproj/project.pbxproj:
              * loader/icon/SQLDatabase.cpp: Removed.
              * loader/icon/SQLDatabase.h: Removed.
              * loader/icon/SQLStatement.cpp: Removed.
              * loader/icon/SQLStatement.h: Removed.
              * loader/icon/SQLTransaction.cpp: Removed.
              * loader/icon/SQLTransaction.h: Removed.
              * platform/sql/SQLDatabase.cpp: Copied from loader/icon/SQLDatabase.cpp.
              * platform/sql/SQLDatabase.h: Copied from loader/icon/SQLDatabase.h.
              * platform/sql/SQLStatement.cpp: Copied from loader/icon/SQLStatement.cpp.
              * platform/sql/SQLStatement.h: Copied from loader/icon/SQLStatement.h.
              * platform/sql/SQLTransaction.cpp: Copied from loader/icon/SQLTransaction.cpp.
              * platform/sql/SQLTransaction.h: Copied from loader/icon/SQLTransaction.h.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@26801 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      1f21e614
    • andersca's avatar
      Reviewed by Brady. · b556628f
      andersca authored
              
              Make example actually work.
              
              * misc/DatabaseExample.html:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@26800 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      b556628f
    • andersca's avatar
      WebCore: · c4f862a8
      andersca authored
              Reviewed by Adam.
      
              Update to match the latest version of the spec. Now, executeSQL takes an array
              of SQL parameters instead of them being passed as arguments.
              
              * bindings/js/JSDatabaseCustom.cpp:
              (WebCore::JSDatabase::executeSql):
              * page/inspector/DatabasePanel.js:
              * storage/Database.idl:
      
      WebKitSite:
      
              Reviewed by Adam.
      
              Update example.
              
              * misc/DatabaseExample.html:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@26799 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      c4f862a8
    • kmccullo's avatar
      Reviewed by Adam. · b7f3e557
      kmccullo authored
              - This change should be identical but for some reason was not working
              on my machine.
      
              * Scripts/prepare-ChangeLog:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@26798 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      b7f3e557
    • beidson's avatar
      WebCore: · 8b3445a7
      beidson authored
              Reviewed by Tim
      
              Tiger's SQLite doesn't support CREATE TABLE IF NOT EXISTS :(
      
              * storage/Database.cpp:
              (WebCore::Database::performOpenAndVerify):
              * storage/DatabaseTracker.cpp:
              (WebCore::DatabaseTracker::DatabaseTracker):
      
      WebKitSite:
      
              Reviewed by Tim
      
              Tiger's SQLite doesn't support CREATE TABLE IF NOT EXISTS :(
      
              * misc/DatabaseExample.html:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@26797 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      8b3445a7
    • andersca's avatar
      Release build fix. · 578b1e9b
      andersca authored
              
              * WebCore.vcproj/WebCore.vcproj:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@26796 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      578b1e9b
    • beidson's avatar
      Remove stray printfs · 14ffbf13
      beidson authored
              * dom/Document.cpp:
              (WebCore::Document::Document):
              (WebCore::Document::~Document):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@26793 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      14ffbf13
    • andersca's avatar
      Reviewed by Brady. · 8462edf0
      andersca authored
              Apparently the Win32 pthreads impl we use does not allow unlocking a mutex that has not
              already been locked, so lock the mutex first.
              
              * storage/DatabaseThread.cpp:
              (WebCore::DatabaseThread::databaseThread):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@26792 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      8462edf0
    • beidson's avatar
      Better build fix · a09338e5
      beidson authored
              * loader/icon/SQLDatabase.cpp:
              (WebCore::SQLDatabase::authorizerFunction):  Definite works by 3.3.13
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@26791 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      a09338e5
    • beidson's avatar
      Build fix · c85d7f7e
      beidson authored
              * loader/icon/SQLDatabase.cpp:
              (WebCore::SQLDatabase::authorizerFunction): I don't know *when* these constants were
                added to SQLite, but I know they were by 3.4.0
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@26790 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      c85d7f7e
    • beidson's avatar
      JavaScriptCore: · e5def340
      beidson authored
      2007-10-19  Brady Eidson  <beidson@apple.com>
      
              Reviewed by Sam
      
              Queue -> Deque! and small style tweaks
      
              * JavaScriptCore.vcproj/WTF/WTF.vcproj:
              * JavaScriptCore/JavaScriptCore.xcodeproj/project.pbxproj
              * wtf/Deque.h: Added.
              (WTF::DequeNode::DequeNode):
              (WTF::Deque::Deque):
              (WTF::Deque::~Deque):
              (WTF::Deque::size):
              (WTF::Deque::isEmpty):
              (WTF::Deque::append):
              (WTF::Deque::prepend):
              (WTF::Deque::first):
              (WTF::Deque::last):
              (WTF::Deque::removeFirst):
              (WTF::Deque::clear):
              * wtf/Queue.h: Removed.
      
      2007-10-19  Brady Eidson <beidson@apple.com>
      
              Reviewed by Oliver
      
              Added a simple LinkedList based Queue to wtf
              We can make a better, more sophisticated an efficient one later, but have
              needed one for some time, now!
      
              * JavaScriptCore.xcodeproj/project.pbxproj:
              * wtf/Queue.h: Added.
              (WTF::QueueNode::QueueNode):
              (WTF::Queue::Queue):
              (WTF::Queue::~Queue):
              (WTF::Queue::size):
              (WTF::Queue::isEmpty):
              (WTF::Queue::append):
              (WTF::Queue::prepend):
              (WTF::Queue::first):
              (WTF::Queue::last):
              (WTF::Queue::removeFirst):
              (WTF::Queue::clear):
      
      WebCore:
      2007-10-19  Brady Eidson  <beidson@apple.com>
              Reviewed by Anders
      
              Windows specific changes, as well as renaming Queue -> Deque
      
              * ForwardingHeaders/wtf/Deque.h: Added.
              * ForwardingHeaders/wtf/Queue.h: Removed.
              * platform/win/FileSystemWin.cpp:
              (WebCore::fileSize):
              (WebCore::fileExists):
              (WebCore::deleteFile):
              (WebCore::pathByAppendingComponent):
              (WebCore::fileSystemRepresentation):
              (WebCore::makeAllDirectories):
              (WebCore::homeDirectoryPath):
              * storage/Database.h:
              * storage/DatabaseThread.cpp:
              (WebCore::DatabaseThread::documentGoingAway):
              (WebCore::DatabaseThread::databaseGoingAway):
              (WebCore::DatabaseThread::dispatchNextTaskIdentifier):
              (WebCore::DatabaseThread::scheduleTask):
              (WebCore::DatabaseThread::scheduleImmediateTask):
              * storage/DatabaseThread.h:
      
      2007-10-19  Brady Eidson <beidson@apple.com>
      
              Reviewed by Tim and Anders
      
              Preliminary support for HTML5 local database storage (http://www.whatwg.org/specs/web-apps/current-work/)
      
              The specification is still in flux but the fundamentals are pretty solid and we can start using and testing
              this implementation even while filing bugs to track changes in the spec as it becomes more final
      
              There are some implementation details in this patch that seem unused or useless, but they remain in place
              while the spec is in flux and might go one way or another.
      
              * platform/Logging.cpp: Add StorageAPI logging channel
              * platform/Logging.h:
      
              * storage/Database.cpp: Added.
              (WebCore::Database::databaseInfoTableName):
              (WebCore::databaseVersionKey):
              (WebCore::Database::openDatabase): C++ version of the window.openDatabase() javascript API
              (WebCore::Database::Database):
              (WebCore::Database::~Database):
              (WebCore::Database::openAndVerifyVersion):
              (WebCore::retrieveTextResultFromDatabase):
              (WebCore::Database::getVersionFromDatabase):
              (WebCore::setTextValueInDatabase):
              (WebCore::Database::setVersionInDatabase):
              (WebCore::Database::databaseThreadGoingAway): May be removed in the future
              (WebCore::Database::disableAuthorizer): For internal (WebInspector) use to get around the authorizer's restrictions
              (WebCore::Database::enableAuthorizer):
              (WebCore::Database::guidForOriginAndName): Candidate for refactoring and/or moving to the database tracker.
                The GUID for each database identifier is currently for tracking the database version, but might be rescoped in the future
              (WebCore::Database::resetAuthorizer):
              (WebCore::Database::performPolicyChecks): Currently, the only post-executeSql policy check planned is the origin size usage
              (WebCore::Database::scheduleDatabaseCallback):
              (WebCore::Database::performOpenAndVerify):
              (WebCore::Database::performChangeVersion):
              (WebCore::Database::performExecuteSql):
              (WebCore::Database::performCloseTransaction):
              (WebCore::Database::performGetTableNames):
              (WebCore::Database::version): C++ version of the javascript API
              (WebCore::Database::changeVersion): Ditto
              (WebCore::Database::executeSql): Ditto
              (WebCore::Database::closeTransaction): Ditto
              (WebCore::Database::tableNames): For internal (WebInspector) use
              (WebCore::Database::deliverAllPendingCallbacks):
              (WebCore::Database::deliverPendingCallbacks):
              * storage/Database.h: Added.
              (WebCore::Database::databaseDebugName): For debug logging purposes
              * storage/Database.idl: Added.
      
              * storage/DatabaseAuthorizer.cpp: Added.
                The DatabaseAuthorizer is used to both prevent the script from doing "illegal" things in sql as well as
                tracking when effects certain sql statements might have (such as increasing the size of the database)
              (WebCore::DatabaseAuthorizer::DatabaseAuthorizer):
              (WebCore::DatabaseAuthorizer::reset):
              (WebCore::DatabaseAuthorizer::createTable):
              (WebCore::DatabaseAuthorizer::createTempTable):
              (WebCore::DatabaseAuthorizer::dropTable):
              (WebCore::DatabaseAuthorizer::dropTempTable):
              (WebCore::DatabaseAuthorizer::allowAlterTable):
              (WebCore::DatabaseAuthorizer::createIndex):
              (WebCore::DatabaseAuthorizer::createTempIndex):
              (WebCore::DatabaseAuthorizer::dropIndex):
              (WebCore::DatabaseAuthorizer::dropTempIndex):
              (WebCore::DatabaseAuthorizer::createTrigger):
              (WebCore::DatabaseAuthorizer::createTempTrigger):
              (WebCore::DatabaseAuthorizer::dropTrigger):
              (WebCore::DatabaseAuthorizer::dropTempTrigger):
              (WebCore::DatabaseAuthorizer::createVTable):
              (WebCore::DatabaseAuthorizer::dropVTable):
              (WebCore::DatabaseAuthorizer::allowDelete):
              (WebCore::DatabaseAuthorizer::allowInsert):
              (WebCore::DatabaseAuthorizer::allowUpdate):
              (WebCore::DatabaseAuthorizer::allowRead):
              (WebCore::DatabaseAuthorizer::allowAnalyze):
              (WebCore::DatabaseAuthorizer::allowPragma):
              (WebCore::DatabaseAuthorizer::allowAttach):
              (WebCore::DatabaseAuthorizer::allowDetach):
              (WebCore::DatabaseAuthorizer::allowFunction):
              (WebCore::DatabaseAuthorizer::disable):
              (WebCore::DatabaseAuthorizer::enable):
              (WebCore::DatabaseAuthorizer::denyBasedOnTableName): Don't allow access to the __WebKit meta info table as
                it should be invisible to scripts
              * storage/DatabaseAuthorizer.h: Added.
              (WebCore::DatabaseAuthorizer::lastActionWasInsert):
              (WebCore::DatabaseAuthorizer::lastActionIncreasedSize):
      
              * storage/DatabaseCallback.cpp: Added.
                Generic item to queue up for callbacks on the main thread for database activities that take place on
                a secondary thread
              (WebCore::DatabaseChangeVersionCallback::DatabaseChangeVersionCallback):
              (WebCore::DatabaseChangeVersionCallback::performCallback):
              (WebCore::DatabaseExecuteSqlCallback::DatabaseExecuteSqlCallback):
              (WebCore::DatabaseExecuteSqlCallback::performCallback):
              * storage/DatabaseCallback.h: Added.
              (WebCore::DatabaseCallback::~DatabaseCallback):
              (WebCore::DatabaseChangeVersionCallback::~DatabaseChangeVersionCallback):
              (WebCore::DatabaseExecuteSqlCallback::~DatabaseExecuteSqlCallback):
      
              * storage/DatabaseTask.h: Added.
                Generic work-item to be queued up on the background database thread
              (WebCore::DatabaseTask::isComplete):
              (WebCore::DatabaseOpenTask::exceptionCode):
              (WebCore::DatabaseOpenTask::openSuccessful):
              (WebCore::DatabaseTableNamesTask::tableNames):
              * storage/DatabaseTask.cpp: Added.
              (WebCore::DatabaseTask::DatabaseTask):
              (WebCore::DatabaseTask::~DatabaseTask):
              (WebCore::DatabaseTask::performTask):
              (WebCore::DatabaseTask::lockForSynchronousScheduling): Used when the main thread needs this task accomplished
                synchronously
              (WebCore::DatabaseTask::waitForSynchronousCompletion):
      
              (WebCore::DatabaseOpenTask::DatabaseOpenTask):
              (WebCore::DatabaseOpenTask::doPerformTask):
      
              (WebCore::DatabaseExecuteSqlTask::DatabaseExecuteSqlTask):
              (WebCore::DatabaseExecuteSqlTask::doPerformTask):
      
              (WebCore::DatabaseChangeVersionTask::DatabaseChangeVersionTask):
              (WebCore::DatabaseChangeVersionTask::doPerformTask):
      
              (WebCore::DatabaseTableNamesTask::DatabaseTableNamesTask):
              (WebCore::DatabaseTableNamesTask::doPerformTask):
      
              * storage/DatabaseThread.cpp: Added.
                The current design is that each Document will have its own DatabaseThread.  This makes scripts on each
                individual document more response at the cost of adding more threads and potentially creating concurrency
                issues when the same database is open twice from two different documents
              (WebCore::DatabaseThread::DatabaseThread):
              (WebCore::DatabaseThread::~DatabaseThread):
              (WebCore::DatabaseThread::start):
              (WebCore::DatabaseThread::documentGoingAway): Called to shut the thread down when the document is destroyed
              (WebCore::DatabaseThread::databaseGoingAway): Remove all pending tasks for this database
              (WebCore::DatabaseThread::databaseThreadStart):
              (WebCore::DatabaseThread::databaseThread):
              (WebCore::DatabaseThread::dispatchNextTaskIdentifier):
              (WebCore::DatabaseThread::scheduleTask):
              (WebCore::DatabaseThread::scheduleImmediateTask): Schedule a task that gets to "cut to the front of the line" when
                the main thread requires a task be performed synchronously
              (WebCore::DatabaseThread::wakeWorkThread):
              * storage/DatabaseThread.h: Added.
      
              * storage/DatabaseTracker.cpp: Added.
                The DatabaseTracker is the master management of all databases.  It will keep track of the filename for a given
                unique database, keep track of the total disk usage per-origin, and policys per database/origin
              (WebCore::DatabaseTracker::setDatabasePath):
              (WebCore::DatabaseTracker::databasePath):
              (WebCore::DatabaseTracker::tracker):
              (WebCore::DatabaseTracker::DatabaseTracker):
              (WebCore::DatabaseTracker::fullPathForDatabase):
              (WebCore::DatabaseTracker::populateOrigins):
              (WebCore::DatabaseTracker::origins):
              (WebCore::DatabaseTracker::databaseNamesForOrigin):
              (WebCore::DatabaseTracker::addDatabase):
              (WebCore::DatabaseTracker::deleteAllDatabases):
              (WebCore::DatabaseTracker::deleteAllDatabasesForOrigin):
              * storage/DatabaseTracker.h: Added.
      
              * storage/SQLCallback.h: Added. C++ version of the javascript executeSql() callback
              (WebCore::SQLCallback::~SQLCallback):
              * storage/SQLCallback.idl: Added.
      
              * storage/SQLResultSet.cpp: Added. C++ version of the javascript SQLResultSet object
              (WebCore::SQLResultSet::SQLResultSet):
              (WebCore::SQLResultSet::insertId):
              (WebCore::SQLResultSet::rowsAffected):
              (WebCore::SQLResultSet::errorCode):
              (WebCore::SQLResultSet::error):
              (WebCore::SQLResultSet::rows):
              (WebCore::SQLResultSet::setInsertId):
              (WebCore::SQLResultSet::setRowsAffected):
              (WebCore::SQLResultSet::setErrorCode):
              (WebCore::SQLResultSet::setErrorMessage):
              * storage/SQLResultSet.h: Added.
              * storage/SQLResultSet.idl: Added.
      
              * storage/SQLResultSetRowList.cpp: Added. C++ version of the javascript SQLResultSetRowList object
              (WebCore::SQLResultSetRowList::length):
              * storage/SQLResultSetRowList.h: Added.
              (WebCore::SQLResultSetRowList::columnNames):
              (WebCore::SQLResultSetRowList::values):
              (WebCore::SQLResultSetRowList::addColumn):
              (WebCore::SQLResultSetRowList::addResult):
              * storage/SQLResultSetRowList.idl: Added.
      
              * storage/VersionChangeCallback.h: Added. C++ version of the javascript changeVersion() callback
              (WebCore::VersionChangeCallback::~VersionChangeCallback):
              * storage/VersionChangeCallback.idl: Added.
      
      2007-10-19  Brady Eidson <beidson@apple.com>
      
              Reviewed by Oliver + Same
      
              Forwarding header for the new wtf/Queue.h
      
              * ForwardingHeaders/wtf/Queue.h: Added.
      
      2007-10-19  Anders Carlsson <beidson@apple.com>
      
             	Reviewed by Sam Weinig
      
             	Most of the Javascript binding support for the Storage API
      
             	* bindings/js/JSCustomSQLCallback.cpp: Added.
             	(WebCore::JSCustomSQLCallback::JSCustomSQLCallback):
             	(WebCore::JSCustomSQLCallback::handleEvent):
             	* bindings/js/JSCustomSQLCallback.h: Added.
      		Add JSCustomSQLCallback which is an SQLCallback implementation that dispatches
      		handleEvent to a JS function or a JS object with a handleEvent function.
      
             	* bindings/js/JSCustomVersionChangeCallback.cpp: Added.
             	(WebCore::JSCustomVersionChangeCallback::JSCustomVersionChangeCallback):
             	(WebCore::JSCustomVersionChangeCallback::handleEvent):
             	* bindings/js/JSCustomVersionChangeCallback.h: Added.
      		Add JSCustomSQLCallback which is an SQLCallback implementation that dispatches
      		handleEvent to a JS function or a JS object with a handleEvent function.
      
             	* bindings/js/JSDatabaseCustom.cpp: Added.
             	(WebCore::JSDatabase::executeSql):
      		Custom implementation of executeSql that takes an array of parameters.
      
             	(WebCore::JSDatabase::changeVersion):
      		Custom implementation of changeVersion.
      
             	* bindings/js/JSSQLResultSetRowListCustom.cpp: Added.
             	(WebCore::JSSQLResultSetRowList::item):
      		Custom method that returns a JS object that corresponds to a given row in the database.
      
             	* bindings/scripts/CodeGeneratorJS.pm:
      
             	* page/DOMWindow.cpp:
             	(WebCore::DOMWindow::openDatabase):
             	* page/DOMWindow.h:
             	* page/DOMWindow.idl:
      		Add openDatabase implementation.
      
      2007-10-19  Brady Eidson <beidson@apple.com>
      
              Reviewed by Oliver
      
              Added tons of utility to the FileSystem abstractions, including moving
              some stuff over from IconDatabase
      
              * platform/FileSystem.h:
      
              * platform/cf/FileSystemCF.cpp: Added.
              (WebCore::fileSystemRepresentation):
      
              * platform/mac/FileSystemMac.mm:
      
              * platform/posix/FileSystemPOSIX.cpp: Added.
              (WebCore::fileExists):
              (WebCore::deleteFile):
              (WebCore::fileSize):
              (WebCore::pathByAppendingComponent):
              (WebCore::makeAllDirectories):
      
      2007-10-19  Timothy Hatcher  <timothy@apple.com>
      
              Reviewed by Adam Roben
      
              Preliminary Web Inspector support for the Storage API
              (This patch does not include the support artwork)
      
              * page/InspectorController.cpp:
              (WebCore::InspectorDatabaseResource::InspectorDatabaseResource):
              (WebCore::InspectorDatabaseResource::setScriptObject):
              (WebCore::databaseTableNames): Return the table names for a Database object.
              (WebCore::InspectorController::setWindowVisible):
              (WebCore::InspectorController::windowScriptObjectAvailable):
              (WebCore::InspectorController::populateScriptResources):
              (WebCore::InspectorController::addDatabaseScriptResource): Add the script object for the database.
              (WebCore::InspectorController::removeDatabaseScriptResource): Remove the script object for the database.
              (WebCore::InspectorController::clearDatabaseScriptResources): Remove all the database resources.
              (WebCore::InspectorController::didCommitLoad): Call clearDatabaseScriptResources().
              (WebCore::InspectorController::didOpenDatabase): Make a new InspectorDatabaseResource and add it to m_databaseResources.
              * page/InspectorController.h:
              * page/inspector/Database.js: Added.
              * page/inspector/DatabasePanel.js: Added.
              * page/inspector/ResourceCategory.js: Make resource categories assume less about the resource.
              * page/inspector/inspector.css: Add styles for the database panel.
              * page/inspector/inspector.html: Include DatabasePanel.js
              * page/inspector/inspector.js: Support for adding and removing Database resources.
      
      2007-10-19  Brady Eidson <beidson@apple.com>
      
              Reviewed by Tim Hatcher
      
              Added support for Chrome prompts required by the Storage API
      
              * page/Chrome.cpp:
              (WebCore::Chrome::runDatabaseSizeLimitPrompt):
              * page/Chrome.h:
              * page/ChromeClient.h:
              * platform/graphics/svg/SVGImageEmptyClients.h:
      
      2007-10-19  Brady Eidson <beidson@apple.com>
      
              Contributions and Review by Anders
      
              Various SQLite tweaks in preparation for the storage API
      
              * loader/icon/SQLDatabase.cpp:
              (WebCore::SQLDatabase::~SQLDatabase):
              (WebCore::SQLDatabase::authorizerFunction): Static callback from sqlite for authorizer functions
              (WebCore::SQLDatabase::setAuthorizer):
              (WebCore::SQLDatabase::lock):
              (WebCore::SQLDatabase::unlock):
              * loader/icon/SQLDatabase.h:
      
              * loader/icon/SQLStatement.cpp:
              (WebCore::SQLStatement::prepare): Switch to prepare16_v2
              (WebCore::SQLStatement::bindDouble): Added
              (WebCore::SQLStatement::bindValue): Bind a wrapped SQLValue object (described later)
              (WebCore::SQLStatement::bindParameterCount): Accessor to the sqlite3 API for validating statements
              * loader/icon/SQLStatement.h:
              (WebCore::SQLStatement::isPrepared):
      
              * platform/sql/SQLAuthorizer.cpp: Added.  Fully virtual interface to implement your own SQLite authorizer
              * platform/sql/SQLAuthorizer.h: Added.
              (WebCore::SQLAuthorizer::~SQLAuthorizer):
              (WebCore::SQLAuthorizer::createTable):
              (WebCore::SQLAuthorizer::createTempTable):
              (WebCore::SQLAuthorizer::dropTable):
              (WebCore::SQLAuthorizer::dropTempTable):
              (WebCore::SQLAuthorizer::allowAlterTable):
              (WebCore::SQLAuthorizer::createIndex):
              (WebCore::SQLAuthorizer::createTempIndex):
              (WebCore::SQLAuthorizer::dropIndex):
              (WebCore::SQLAuthorizer::dropTempIndex):
              (WebCore::SQLAuthorizer::createTrigger):
              (WebCore::SQLAuthorizer::createTempTrigger):
              (WebCore::SQLAuthorizer::dropTrigger):
              (WebCore::SQLAuthorizer::dropTempTrigger):
              (WebCore::SQLAuthorizer::createView):
              (WebCore::SQLAuthorizer::createTempView):
              (WebCore::SQLAuthorizer::dropView):
              (WebCore::SQLAuthorizer::dropTempView):
              (WebCore::SQLAuthorizer::createVTable):
              (WebCore::SQLAuthorizer::dropVTable):
              (WebCore::SQLAuthorizer::allowDelete):
              (WebCore::SQLAuthorizer::allowInsert):
              (WebCore::SQLAuthorizer::allowUpdate):
              (WebCore::SQLAuthorizer::allowTransaction):
              (WebCore::SQLAuthorizer::allowSelect):
              (WebCore::SQLAuthorizer::allowRead):
              (WebCore::SQLAuthorizer::allowAttach):
              (WebCore::SQLAuthorizer::allowDetach):
              (WebCore::SQLAuthorizer::allowReindex):
              (WebCore::SQLAuthorizer::allowAnalyze):
              (WebCore::SQLAuthorizer::allowFunction):
      
              * platform/sql/SQLValue.cpp: Added.  Contains a value for a SQLite database that can be one of a few types.
                For now, just a String or a double
              (WebCore::SQLValue::SQLValue):
              (WebCore::SQLValue::string):
              (WebCore::SQLValue::number):
              * platform/sql/SQLValue.h: Added.
              (WebCore::SQLValue::):
              (WebCore::SQLValue::SQLValue):
              (WebCore::SQLValue::type):
      
      2007-10-19  Brady Eidson <beidson@apple.com>
      
              Reviewed by Maciej
      
              Changed IconDatabase over to use new FileSystem apis
      
              * loader/icon/IconDatabase.cpp:
              (WebCore::IconDatabase::open):
      
      WebKit:
      
              Reviewed by Tim Hatcher
      
              Added support for Chrome prompts required by the Storage API
              Added support API for future managing of databases from the WebKit client
              Added preference and initialization for the databases path
      
              * Misc/WebDatabaseManager.h: Added.  WebDatabaseManager is how a WebKit application can list and
                remove the current available databases
              * Misc/WebDatabaseManager.mm: Added.
              (+[WebDatabaseManager origins]):
              (+[WebDatabaseManager databasesWithOrigin:]):
              (+[WebDatabaseManager deleteAllDatabases]):
              (+[WebDatabaseManager deleteAllDatabasesWithOrigin:]):
              (+[WebDatabaseManager deleteDatabaseWithOrigin:named:]):
              (WebKitSetWebDatabasesPathIfNecessary): Setup the database path
              * Misc/WebDatabaseManagerPrivate.h: Added.
      
              * WebCoreSupport/WebChromeClient.h: Support for calling the delegate to run the prompt for
                an origin exceeding its size limit
              * WebCoreSupport/WebChromeClient.mm:
              (WebChromeClient::runDatabaseSizeLimitPrompt):
              * WebKit.xcodeproj/project.pbxproj:
              * WebView/WebUIDelegate.h:
      
              * WebView/WebView.mm:
              (-[WebView _commonInitializationWithFrameName:groupName:]): Setup the database path
              * WebView/WebViewInternal.h:
      
      WebKitSite:
      
              Reviewed by Tim Hatcher
      
              Sample database API usage
      
              * misc/DatabaseExample.html: Added.
      
      WebKit/win:
      
              Reviewed by Anders
      
              Keep windows building with new Chrome additions
      
              * WebChromeClient.cpp:
              * WebChromeClient.h:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@26787 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      e5def340
    • kmccullo's avatar
      Reviewed by Oliver and Tim. · e76b26fb
      kmccullo authored
              - Made use of RetainPtr to avoid retain and release issues and moved the
              log function to DebuggerDocumentPlatform, which seems to be a more
              logical place for it to live.
              - Also moved knownServers from the ServerConnection to
              DebuggerApplication to match the Windows code and because it makes sense
              that a connection knows its own server but not all of them.
      
              * Drosera/mac/DebuggerClient.h: Moved the log function to
                DebuggerDocumentPlatform.
              * Drosera/mac/DebuggerClient.mm: Ditto. Also do not release the server
                Because it's owned by an own Ptr in DebuggerDocument.  Also moved the
                call for the server name up from the ServerConnection class.
              (-[DebuggerClient dealloc]):
              (-[DebuggerClient webView:didReceiveTitle:forFrame:]): Moved the call
                for the server name up from the ServerConnection.
              * Drosera/mac/DebuggerDocumentPlatform.mm: Made the server an OwnPtr.
              (DebuggerDocument::platformPause):
              (DebuggerDocument::platformResume):
              (DebuggerDocument::platformStepInto):
              (DebuggerDocument::platformEvaluateScript):
              (DebuggerDocument::getPlatformCurrentFunctionStack):
              (DebuggerDocument::getPlatformLocalScopeVariableNamesForCallFrame):
              (DebuggerDocument::platformValueForScopeVariableNamed):
              (DebuggerDocument::platformLog): Log directly from here. No need to call
                DebuggerClient.
              * Drosera/mac/ServerConnection.h: Removed the knownServers function. The
                way I see it, a ServerConnection should only know about its connection
                and the group of all possible servers should be kept by the
                application.
              * Drosera/mac/ServerConnection.mm: Removed knownServer but added
                currentServerName, it makes sense that the connection should know that
                name.
              (-[ServerConnection currentServerName]):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@26786 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      e76b26fb
    • hyatt's avatar
      Fix for ebay parser crash. · db02661d
      hyatt authored
              Reviewed by Beth
      
              fast/invalid/table-residual-style-crash.html added as a test
      
              * html/HTMLParser.cpp:
              (WebCore::HTMLParser::handleResidualStyleCloseTagAcrossBlocks):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@26785 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      db02661d
    • hyatt's avatar
      Add new layout test for parser crash. · 4ebb8f7a
      hyatt authored
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@26784 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      4ebb8f7a
    • zimmermann's avatar
      Reviewed by Anders. · 16837c37
      zimmermann authored
      Try to fix Qt/Win build slave, by including windows.h also on Qt/Win.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@26783 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      16837c37
    • weinig's avatar
      Fix Windows, Qt and GTK builds. · aba49b64
      weinig authored
              * WebCore.pro:
              * WebCore.vcproj/WebCore.vcproj:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@26782 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      aba49b64
    • zimmermann's avatar
      Rubberstamped by Oliver. · bc30e391
      zimmermann authored
      Land tiger baseline matching my MBP, as discussed with Oliver. 
      Mostly differences regarding the size of "(" / ")" characters.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@26781 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      bc30e391
    • weinig's avatar
      WebCore: · e06430af
      weinig authored
              Reviewed by Darin.
      
              Encapsulate the same origin check into the new SecurityOrigin class.
      
              * WebCore.xcodeproj/project.pbxproj:
              * bindings/js/kjs_window.cpp:
              (KJS::Window::isSafeScript):
              * dom/Document.cpp:
              (WebCore::Document::Document):
              (WebCore::Document::defaultEventHandler):
              * dom/Document.h:
              (WebCore::Document::securityOrigin):
              * loader/FrameLoader.cpp:
              (WebCore::FrameLoader::begin):
              (WebCore::FrameLoader::setOpener):
              * loader/FrameLoader.h:
              * platform/SecurityOrigin.cpp: Added.
              (WebCore::SecurityOrigin::SecurityOrigin):
              (WebCore::SecurityOrigin::clear):
              (WebCore::SecurityOrigin::isEmpty):
              (WebCore::SecurityOrigin::setForFrame):
              (WebCore::SecurityOrigin::setDomainFromDOM):
              (WebCore::SecurityOrigin::allowsAccessFrom):
              (WebCore::SecurityOrigin::isSecureTransitionTo):
              * platform/SecurityOrigin.h: Added.
      
      LayoutTests:
      
              Reviewed by Darin.
      
              Update results after changing the warning message in isSafeScript to print the frame URL 
              rather than the security domain URL.  This now also prints the warning when using data:
              URLs because we no longer return early.
      
              * http/tests/security/dataURL/xss-DENIED-from-data-url-sub-frame-2-level-expected.txt:
              * http/tests/security/dataURL/xss-DENIED-from-data-url-sub-frame-expected.txt:
              * http/tests/security/dataURL/xss-DENIED-from-data-url-sub-frame-to-data-url-sub-frame-expected.txt:
              * http/tests/security/dataURL/xss-DENIED-from-javascript-url-window-open-expected.txt:
              * http/tests/security/dataURL/xss-DENIED-to-data-url-from-data-url-expected.txt:
              * http/tests/security/dataURL/xss-DENIED-to-data-url-sub-frame-2-level-expected.txt:
              * http/tests/security/dataURL/xss-DENIED-to-data-url-sub-frame-expected.txt:
              * http/tests/security/dataURL/xss-DENIED-to-data-url-sub-frame-uppercase-expected.txt:
              * http/tests/security/dataURL/xss-DENIED-to-data-url-window-open-expected.txt:
              * http/tests/security/javascriptURL/xss-DENIED-from-javascipt-url-in-foreign-domain-subframe-expected.txt:
              * http/tests/security/javascriptURL/xss-DENIED-from-javascipt-url-in-foreign-domain-window-open-expected.txt:
              * http/tests/security/javascriptURL/xss-DENIED-to-javascipt-url-in-foreign-domain-subframe-expected.txt:
              * http/tests/security/javascriptURL/xss-DENIED-to-javascipt-url-in-foreign-domain-window-open-expected.txt:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@26780 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      e06430af
    • kmccullo's avatar
      Reviewed by Adam. · 4a850e9d
      kmccullo authored
              - Integrated changes from mac drosera.  Recently I've encapsulated
              out the server connection object from the rest of Drosera because
              it is very platform dependent right now and RPC is not implemented on
              windows.  This functionality, of communicating with the WebKit server
              is the next area I will be focusing on in Windows.
      
              - Other changes and cleanup were made to organize the code and add notes
              on which parts still need work.  Also some mac code is added and
              commented out, to act as pseudocode for the logic of those parts.
      
              * Drosera/DebuggerDocument.h: Make the ServerConnection live in a smart
                pointer.
              * Drosera/config.h: Added whitespace.
              * Drosera/win/DebuggerApplication.cpp: Removed. The functionality of
                these files got moved into Drosera.h/cpp
              * Drosera/win/DebuggerApplication.h: Removed.
              * Drosera/win/DebuggerClient.cpp: Lots of cleanup and restructuring 
                happened here to better match the logic flow of the same code on the 
                mac side and to use the new ServerConnection class.
              (DebuggerClient::DebuggerClient): Constructor that takes a server name.
              (DebuggerClient::initWithServerName): Initializer that will set up the
                class to use a ServerConnection object.  This was necessary so I could
                create a DebuggerClient without having to initilaize it at
                construction.
              (DebuggerClient::QueryInterface): Moved from Drosera.cpp, the Client
                will be the UIDelegate and FrameLoadDelegate.
              (DebuggerClient::AddRef): For IUnknown.
              (DebuggerClient::Release): For IUnknown.
              (DebuggerClient::didFinishLoadForFrame): Part of the FrameLoadDelegate
                this still needs to set the global context of the server, but
                IWebFrame does not have an accessor for the global context yet. 
              (DebuggerClient::windowScriptObjectAvailable): Part of FrameLoadDelegate
                this is a pass through for the same function in the document.
              (DebuggerClient::didReceiveTitle): Unimplemented part of
                FrameLoadDelegate this would change the title of the window.
              (DebuggerClient::createWebViewWithRequest): Part of the
                FrameLoadDelegate.  This is about new windows via Window.open() and
                how their delegates are set.
              (DebuggerClient::runJavaScriptAlertPanelWithMessage): Part of the
                UIDelegate.  Just a debug function for printing messages.
              * Drosera/win/DebuggerClient.h: Moved functionality from Drosera.h
                because the Client should be the UIDelegate and FrameLoadDelegate
                to match the delegates on mac.
              (DebuggerClient::webViewLoaded): Added accessor method.
              * Drosera/win/DebuggerDocumentPlatform.cpp: Added. I had apperently
                forgotten to add this file before.  This is where the platform
                dependent versions of the Documents functions live. Most of these are
                unimplemented because some piece of functionality does not exist on
                Windows yet.
              (DebuggerDocument::platformPause):
              (DebuggerDocument::platformResume):
              (DebuggerDocument::platformStepInto):
              (DebuggerDocument::platformEvaluateScript):
              (DebuggerDocument::getPlatformCurrentFunctionStack):
              (DebuggerDocument::getPlatformLocalScopeVariableNamesForCallFrame):
              (DebuggerDocument::platformValueForScopeVariableNamed):
              (DebuggerDocument::platformLog):
              * Drosera/win/Drosera.cpp: Removed UIDelegate and FrameLoadDelegate
                responsibilities becaue they belong in the Client. Also I laid the
                groundwork for attaching Drosera to a WebKit process
              (attachWndProc): Now if a server is selected the Client becomes it's
                delegate.
              (Drosera::Drosera): Added the construction of the Client and dictionary
                of server names. 
              (Drosera::initUI): This is no longer the delegates, the Client is.
              (Drosera::webViewLoaded): Now asks the Client instead of holding local
                state. 
              (Drosera::applicationDidFinishLaunching): Placeholder for needed
                notification registration when it's possible to implement.
              (Drosera::serverLoaded): Ditto
              (Drosera::serverUnloaded): Ditto
              (Drosera::attach): Attach Drosera to the WebKit server.
              * Drosera/win/Drosera.h: Ditto for Drosera.cpp comment.
              (Drosera::getInst): 
              (Drosera::setInst):
              (Drosera::knownServers):
              * Drosera/win/Drosera.vcproj/Drosera.vcproj: Removed DebuggerApplication
                and added the ServerConnection.
              * Drosera/win/DroseraPrefix.h: Added an ifndef check.
              * Drosera/win/ServerConnection.cpp: Added. This is the interesting part
                Most of the functions are completely unimlemented because they cannot
                connect with the WebKit server, because one does not exist on Windows
                yet.
              (ServerConnection::initWithServerName): 
              (ServerConnection::~ServerConnection):
              (ServerConnection::setGlobalContext):
              (ServerConnection::pause):
              (ServerConnection::resume):
              (ServerConnection::stepInto):
              (ServerConnection::switchToServerNamed):
              (ServerConnection::applicationTerminating):
              (ServerConnection::serverConnectionDidDie):
              (ServerConnection::currentFrame):
              * Drosera/win/ServerConnection.h: Added. Ditto.
              (ServerConnection::ServerConnection):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@26779 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      4a850e9d
    • aliceli1's avatar
      Reviewed by Darin. · 9875427a
      aliceli1 authored
              Fix for these broken layout tests on Windows:
              
              fast/forms/focus-selection-input.html
              fast/forms/focus-selection-textarea.html
              fast/forms/select-accesskey.html
              
              * DumpRenderTree/win/EventSender.cpp:
              (keyDownCallback):
              correct the VK code for alt key.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@26778 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      9875427a
    • aliceli1's avatar
      Reviewed by Darin. · 702680b6
      aliceli1 authored
              * DumpRenderTree/win/EventSender.cpp:
              (keyDownCallback):
              correct the VK code for alt key.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@26777 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      702680b6
    • sullivan's avatar
      Reviewed by Tim Hatcher · 5453b8c2
      sullivan authored
              
              - fixed <rdar://problem/5540325> REGRESSION (2.0.4-3): History menu looks odd after clearing history
      
              * History/WebHistory.mm:
              (-[WebHistoryPrivate removeAllItems]):
              This was fallout from r25275. We need to clear the orderedLastVisitedDays cache here, in addition
              to the other places where it's cleared.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@26776 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      5453b8c2
    • mitz's avatar
      Rubber-stamped by Sam Weinig. · faa55317
      mitz authored
              removing a commented-out test and a test that no longer fails
      
              * platform/mac-leopard/Skipped:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@26775 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      faa55317
    • ddkilzer's avatar
      LayoutTests: · 4b557aaf
      ddkilzer authored
              Reviewed by Darin.
      
              Provide the functionality of js-test-post.js in a function named isSuccessfullyParsed().
      
              * fast/encoding/char-encoding.html: Updated to use js-test-post-function.js instead of local hack.
              * fast/js/resources/js-test-post-function.js: Copied from LayoutTests/fast/js/resources/js-test-post.js.
              Modified to create isSuccessfullyParsed() function.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@26774 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      4b557aaf
    • hausmann's avatar
    • hausmann's avatar
      44c5bbfc
    • hausmann's avatar
      Fix compilation on Windows when wchar_t is a typedef instead of a native type... · cb69ec39
      hausmann authored
      Fix compilation on Windows when wchar_t is a typedef instead of a native type (triggered by -Zc:wchar_t-).
      Don't provide the wchar_t overloads then as they conflict with the unsigned short ones.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@26771 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      cb69ec39
    • hausmann's avatar
      Another build fix for the windows/qt build: Apply the same fix as in revision... · 94214d7e
      hausmann authored
      Another build fix for the windows/qt build: Apply the same fix as in revision 26686 also to kjs/config.h to disable the disallowctype feature.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@26770 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      94214d7e
    • hausmann's avatar
    • hausmann's avatar
      Fix the qt/windows build. · 8908e856
      hausmann authored
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@26768 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      8908e856
    • eseidel's avatar
      2007-10-19 Eric Seidel <eric@webkit.org> · 7b11a5c0
      eseidel authored
              Reviewed by Mark Rowe.
              
              Make the GtkLauncher code slightly more readable.
      
              * GtkLauncher/main.cpp:
              (setupMainMenu): Added.
              (setupMainWindowUI): Added.
              (main):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@26767 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      7b11a5c0
    • mjs's avatar
      Rubber stamped by Adam. · 0f155d6f
      mjs authored
              
              - don't delay-load WebKit in DumpRenderTree.
      
              * DumpRenderTree/win/DumpRenderTree.vcproj:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@26766 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      0f155d6f
  2. 18 Oct, 2007 4 commits
    • mitz's avatar
      Rubber-stamped by Mark Rowe. · 287b85ba
      mitz authored
              removing tests that no longer fail
      
              * platform/mac-leopard/Skipped:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@26762 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      287b85ba
    • justing's avatar
      WebCore: · a6c5dadd
      justing authored
              Reviewed by Kevin McCullough.
      
              <rdar://problem/5483526> 
              GoogleDocs: A hang occurs when applying list styling to a selection containing a table and line breaks
      
              * editing/TextIterator.cpp:
              (WebCore::TextIterator::exitNode): For selection preservation, we must emit a character
              between every VisiblePosition.  We weren't emitting a space after some tables, because
              we won't try to emit a space if shouldEmitNewlineAFterNode is true, even if no newline
              was emitted.
      
      LayoutTests:
      
              Reviewed by Kevin McCullough.
              
              <rdar://problem/5483526> 
              GoogleDocs: A hang occurs when applying list styling to a selection containing a table and line breaks
              
              Demonstrates fix for the hang:
              * editing/execCommand/5483526-expected.txt: Added.
              * editing/execCommand/5483526.html: Added.
              
              Fixed selection endpoint (problems with selection painting prevent this
              from being reflected in the pixel test results):
              * platform/mac/editing/execCommand/5432254-2-expected.txt:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@26761 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      a6c5dadd
    • mjs's avatar
      Reviewed by Adam. · b0b5cfe2
      mjs authored
              
              - use __declspec(thread) for fast thread-local storage on Windows
              
              - 2.2% speedup on sunspider (on Windows)
              - 7% speedup on the string section
              - 6% speedup on JS iBench
              
              - fixed <rdar://problem/5473084> PLT on Windows got 2.5% slower between r25406 and r25422
              - fixed at least some of <rdar://5527965? i-Bench JS was 14% slower in 310A11 than 310A10
              
              
              * wtf/FastMalloc.cpp:
              (WTF::getThreadHeap):
              (WTF::setThreadHeap):
              (WTF::TCMalloc_ThreadCache::GetCache):
              (WTF::TCMalloc_ThreadCache::GetCacheIfPresent):
              (WTF::TCMalloc_ThreadCache::CreateCacheIfNecessary):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@26760 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      b0b5cfe2
    • mitz's avatar
      Tiger build fix. · bda941d2
      mitz authored
              * WebView/WebDataSource.mm:
              (-[WebDataSource _MIMETypeOfResponse:]):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@26759 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      bda941d2