1. 21 May, 2007 10 commits
    • thatcher's avatar
      Reviewed by Adam. · 428cde24
      thatcher authored
              <rdar://problem/5084400> -[DOMRange lineBoxRects] returns an empty array when the DOM nodes have just been created
      
              Do a updateLayoutIgnorePendingStylesheets before asking the Node or Range for it's box rects.
      
              * bindings/objc/DOM.mm:
              (-[DOMNode boundingBox]):
              (-[DOMNode lineBoxRects]):
              (-[DOMRange boundingBox]):
              (-[DOMRange lineBoxRects]):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@21635 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      428cde24
    • weinig's avatar
      Reviewed by George Staikos. · 151497a0
      weinig authored
              Fix Qt build.
      
              * WebCore.pro: add missing IDL files.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@21634 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      151497a0
    • weinig's avatar
      LayoutTests: · 4d7ce9a5
      weinig authored
              Reviewed by Darin.
      
              - update tests and results for http://bugs.webkit.org/show_bug.cgi?id=13803
                to account for the new JSHTMLMarquee that is being autogenerated and
                can now produce a constructor.
      
              * fast/dom/Window/element-constructors-on-window-expected.txt:
              * fast/dom/Window/element-constructors-on-window.html:
              * fast/dom/Window/window-properties-expected.txt:
      
      WebCore:
      
              Reviewed by Darin.
      
              Patch for http://bugs.webkit.org/show_bug.cgi?id=13803
              Autogenerate the JS bindings for the HTMLMarqueeElement.
      
              * DerivedSources.make:
              * WebCore.xcodeproj/project.pbxproj:
              * bindings/js/JSHTMLElementWrapperFactory.cpp:
              * bindings/js/kjs_css.cpp:
              (KJS::DOMCSSRule::getOwnPropertySlot): Fix possible null pointer issue.
              (KJS::DOMCSSRule::put): Fix possible null pointer issue.
              * bindings/js/kjs_html.cpp:
              (KJS::):
              (KJS::JSHTMLElement::classInfo):
              (KJS::JSHTMLElement::accessors):
              (KJS::JSHTMLElement::getOwnPropertySlot): Fix null pointer issue.
              (KJS::HTMLElementFunction::callAsFunction):
              (KJS::JSHTMLElement::put):
              * bindings/js/kjs_html.h:
              (KJS::JSHTMLElement::):
              * html/HTMLMarqueeElement.cpp:
              (WebCore::HTMLMarqueeElement::start):
              (WebCore::HTMLMarqueeElement::stop):
              * html/HTMLMarqueeElement.h: Add start() and stop() functions.
              * html/HTMLMarqueeElement.idl: Added.
              * page/DOMWindow.idl: Add marquee constructor.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@21633 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      4d7ce9a5
    • adele's avatar
      WebCore: · dd237c40
      adele authored
              Fix by Darin, reviewed by me.
      
              Fix for <rdar://problem/5171145> Safari crashed closing tab in NSInputContext updateInputContexts
      
              * platform/mac/WidgetMac.mm:
              (WebCore::safeRemoveFromSuperview): Added. If the view is the window's first responder, then 
               set the window's first responder to nil so we don't leave the window pointing to a view that's no longer in it.
              (WebCore::Widget::setFocus): Don't attempt to focus the view if it has no window.
              (WebCore::Widget::removeFromSuperview): Call safeRemoveFromSuperview.
              (WebCore::Widget::afterMouseDown): ditto.
      
      WebKit:
      
              Fix by Darin, reviewed by me.
      
              Fix for <rdar://problem/5171145> Safari crashed closing tab in NSInputContext updateInputContexts
      
              * WebView/WebFrameView.mm: (-[WebFrameView _setDocumentView:]): If the old view is the first responder,
              then set the window's first responder to nil so we don't leave the window pointing to a view that's no longer in it.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@21632 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      dd237c40
    • hyatt's avatar
      Make a line gutter backdrop so that tiny view source docs don't look · 52b9b637
      hyatt authored
              bad.
      
              Reviewed by aroben
      
              * css/view-source.css:
              * html/HTMLViewSourceDocument.cpp:
              (WebCore::HTMLViewSourceDocument::createContainingTable):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@21630 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      52b9b637
    • hyatt's avatar
      Make sure to distinguish between links to internal resources and · 339df964
      hyatt authored
              real links (anchors) in view source mode.
      
              Reviewed by aroben
      
              * css/view-source.css:
              * html/HTMLViewSourceDocument.cpp:
              (WebCore::HTMLViewSourceDocument::addViewSourceToken):
              (WebCore::HTMLViewSourceDocument::addLink):
              * html/HTMLViewSourceDocument.h:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@21629 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      339df964
    • weinig's avatar
      LayoutTests: · 16885ff7
      weinig authored
              Reviewed by Adam and Darin.
      
              - update results for http://bugs.webkit.org/show_bug.cgi?id=13791
                to account for new JSHTMLElements that are being autogenerated and
                can now produce constructors.
      
              * fast/dom/Window/element-constructors-on-window-expected.txt:
              * fast/dom/Window/window-properties-expected.txt:
      
      WebCore:
      
              Reviewed by Adam and Darin.
      
              Patch for http://bugs.webkit.org/show_bug.cgi?id=13791
              Autogenerate the JS bindings for the HTMLIFrameElement and HTMLFrameElement.
      
              * DerivedSources.make:
              * WebCore.xcodeproj/project.pbxproj:
              * bindings/js/JSHTMLAnchorElementCustom.cpp:
              * bindings/js/JSHTMLElementWrapperFactory.cpp:
              * bindings/js/kjs_html.cpp:
              (KJS::):
              (KJS::JSHTMLElement::classInfo):
              (KJS::JSHTMLElement::accessors):
              (KJS::HTMLElementFunction::callAsFunction):
              * bindings/js/kjs_html.h:
              (KJS::JSHTMLElement::):
              * bindings/scripts/CodeGeneratorJS.pm:
              * html/HTMLFrameElement.idl:
              * html/HTMLFrameElementBase.cpp:
              (WebCore::HTMLFrameElementBase::location):
              * html/HTMLFrameElementBase.h:
              * html/HTMLFrameOwnerElement.h:
              (WebCore::HTMLFrameOwnerElement::contentWindow):
              * html/HTMLIFrameElement.idl:
              * page/DOMWindow.idl:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@21624 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      16885ff7
    • lars's avatar
      Reviewed by Zack. · 31303062
      lars authored
              Add an API layer for network downloads. Basically QWebnetworkInterface
              is an interface class for downloading resources. QWebnetworkJob describes
              the actual object to download.
      
              QWebNetworkInterface has a default implementation that replaces the
              old ResourceHandleManager class in the Qt port.
      
              Remove the ResourceHandleManager class, it is now part of 
              QWebNetworkInterface. Adapt ResourceHandle to the new way 
              of things.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@21619 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      31303062
    • hyatt's avatar
      Second half of fix for 13793, make sure rules=groups works properly with · 4699f527
      hyatt authored
              spanning colgroups.
      
              Also make sure colgroups get an actual span of 1 (instead of incorrectly
              giving them a span of 0).
      
              Reviewed by mitz
      
              fast/table/colgroup-spanning-groups-rules.html
      
              * html/HTMLTableColElement.cpp:
              (WebCore::HTMLTableColElement::HTMLTableColElement):
              * rendering/RenderTable.cpp:
              (WebCore::RenderTable::colElement):
              * rendering/RenderTable.h:
              * rendering/RenderTableCell.cpp:
              (WebCore::RenderTableCell::collapsedLeftBorder):
              (WebCore::RenderTableCell::collapsedRightBorder):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@21615 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      4699f527
    • hyatt's avatar
      Half of a fix for 13793, make sure rules=groups and border behave properly · f5fc941d
      hyatt authored
              together.
      
              Reviewed by mitz
      
              No tests added, two Mozilla table tests now pass that failed before.
      
              * html/HTMLTableElement.cpp:
              (WebCore::HTMLTableElement::getSharedCellDecl):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@21614 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      f5fc941d
  2. 20 May, 2007 4 commits
    • beidson's avatar
      Reviewed by Geoose Garen · 2e037c18
      beidson authored
              <rdar://problem/4758919> - Incorrect favicon shown for URL after going back
      
              When restoring a cached page, we'd try to kick off the icon load for it, which ended up causing 
              shenanigans with the icon url -> page url mapping.  
      
              * loader/FrameLoader.cpp:
              (WebCore::FrameLoader::endIfNotLoading): Only try an icon load if we're not restoring from the page cache
              (WebCore::FrameLoader::startIconLoader): Added helpful logging that helped me track this down
              (WebCore::FrameLoader::commitIconURLToIconDatabase): Ditto (and fixed a comment typo)
      
              * loader/icon/IconLoader.cpp:
              (WebCore::IconLoader::stopLoading): Don't null out the ResourceLoader here, as clearLoadingState() does that
              (WebCore::IconLoader::finishLoading): Added helpful logging that helped me track this down
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@21612 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      2e037c18
    • darin's avatar
      Reviewed by Oliver Hunt. · 29df4b01
      darin authored
              - fix <rdar://problem/5193416> REGRESSION: Selection on large pages extremely slow
      
              * dom/Document.cpp: (WebCore::Document::removeMarkers): Added an early exit for the common
              case where there are no markers. Changed code to iterate over all the nodes in the range
              instead of using TextIterator, which is more efficient.
              
              * page/Frame.cpp: (WebCore::Frame::respondToChangedSelection): Added checks for editable,
              so we don't bother doing work related to spell checking and grammar checking when changing
              the selection in non-editable text. Also rearranged the code so we only compute the old
              word boundaries and sentence boundaries when actually needed, and don't do the sentence
              range checks unless grammar checking is enabled.
      
              * platform/TextBreakIteratorICU.cpp:
              (WebCore::setUpIterator): Don't take a locale parameter. Always pass in currentTextBreakLocaleID.
              (WebCore::characterBreakIterator): Removed local parameter.
              (WebCore::wordBreakIterator): Ditto.
              (WebCore::lineBreakIterator): Ditto.
              (WebCore::sentenceBreakIterator): Ditto.
      
              * platform/mac/TextBreakIteratorInternalICUMac.mm:
              (WebCore::getTextBreakLocale): Broke out the code to actually get the locale.
              (WebCore::currentTextBreakLocaleID): This function now handles only the caching and calls
              getTextBreakLocale to actually figure it out.
      
              * editing/visible_units.cpp: Added lots of FIXME comments, but no code change.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@21611 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      29df4b01
    • staikos's avatar
      add -f to cp for some obscure build systems. · 685241da
      staikos authored
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@21610 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      685241da
    • staikos's avatar
      Add missing include for auto_ptr · d3ea845a
      staikos authored
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@21609 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      d3ea845a
  3. 19 May, 2007 8 commits
    • hyatt's avatar
      Fix for bug 13785, O(n^2) counter creation. · 3071affa
      hyatt authored
              Reviewed by darin
      
              * rendering/RenderCounter.cpp:
              (WebCore::findPlaceForCounter):
              (WebCore::RenderCounter::originalText):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@21606 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      3071affa
    • bdash's avatar
      2007-05-19 Mitz Pettel <mitz@webkit.org> · 97b9586a
      bdash authored
              Reviewed by Dave Hyatt.
      
              - fix http://bugs.webkit.org/show_bug.cgi?id=12729
                box-shadow disappears when scrolling a div that it falls on/under
      
              Tests: fast/repaint/box-shadow-dynamic.html
                     fast/repaint/box-shadow-h.html
                     fast/repaint/box-shadow-v.html
      
              * rendering/InlineFlowBox.cpp:
              (WebCore::InlineFlowBox::placeBoxesHorizontally): Factor in box shadow.
              (WebCore::InlineFlowBox::placeBoxesVertically): Ditto.
              (WebCore::InlineFlowBox::paint): Account for box shadow when checking if
              the damage rect intersects.
              * rendering/RenderBlock.cpp:
              (WebCore::RenderBlock::overflowHeight): For overflow areas, when asked
              for the "exterior" overflow, add box shadow overflow.
              (WebCore::RenderBlock::overflowWidth): Ditto.
              (WebCore::RenderBlock::overflowLeft): Ditto.
              (WebCore::RenderBlock::overflowTop): Ditto.
              (WebCore::RenderBlock::overflowRect): Ditto.
              (WebCore::RenderBlock::layoutBlock): Factor box shadow into visual overflow.
              * rendering/RenderFlexibleBox.cpp:
              (WebCore::RenderFlexibleBox::layoutBlock): Ditto.
              * rendering/RenderFlow.cpp:
              (WebCore::RenderFlow::lowestPosition): For overflow areas, when asked for
              the "exterior" extreme position, add box shadow.
              (WebCore::RenderFlow::rightmostPosition): Ditto.
              (WebCore::RenderFlow::leftmostPosition): Ditto.
              * rendering/RenderLayer.cpp:
              (WebCore::RenderLayer::calculateRects): Avoid clipping out box shadow.
              * rendering/RenderObject.cpp:
              (WebCore::RenderObject::repaintAfterLayoutIfNeeded): Make sure to paint
              the box shadow when an edge with a shadow moves.
              (WebCore::RenderObject::adjustRectForOutlineAndShadow): Helper function
              that expands a given rectangle to encompass outline and box shadow.
              (WebCore::RenderObject::absoluteOutlineBox): Changed to include box shadow.
              * rendering/RenderObject.h:
      
      2007-05-19  Mitz Pettel  <mitz@webkit.org>
      
              Reviewed by Dave Hyatt.
      
              - repaint tests and updated results for http://bugs.webkit.org/show_bug.cgi?id=12729
                box-shadow disappears when scrolling a div that it falls on/under
      
              * fast/box-shadow/basic-shadows-expected.checksum:
              * fast/box-shadow/basic-shadows-expected.png:
              * fast/box-shadow/basic-shadows-expected.txt:
              * fast/repaint/box-shadow-dynamic-expected.checksum: Added.
              * fast/repaint/box-shadow-dynamic-expected.png: Added.
              * fast/repaint/box-shadow-dynamic-expected.txt: Added.
              * fast/repaint/box-shadow-dynamic.html: Added.
              * fast/repaint/box-shadow-h-expected.checksum: Added.
              * fast/repaint/box-shadow-h-expected.png: Added.
              * fast/repaint/box-shadow-h-expected.txt: Added.
              * fast/repaint/box-shadow-h.html: Added.
              * fast/repaint/box-shadow-v-expected.checksum: Added.
              * fast/repaint/box-shadow-v-expected.png: Added.
              * fast/repaint/box-shadow-v-expected.txt: Added.
              * fast/repaint/box-shadow-v.html: Added.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@21605 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      97b9586a
    • bdash's avatar
      2007-05-19 Mitz Pettel <mitz@webkit.org> · 357ba6b5
      bdash authored
              Reviewed by Dave Hyatt.
      
              - fix http://bugs.webkit.org/show_bug.cgi?id=13783
                REGRESSION (r21120): Frame resizers not repainted properly when dragged
      
              * rendering/RenderFrameSet.cpp:
              (WebCore::RenderFrameSet::layout):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@21603 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      357ba6b5
    • bdash's avatar
      2007-05-19 Mitz Pettel <mitz@webkit.org> · 7746786d
      bdash authored
              Reviewed by Darin.
      
              - fix http://bugs.webkit.org/show_bug.cgi?id=13774
                REGRESSION: Crash emailing blog entry using Google Reader
      
              Test: fast/table/stale-grid-crash.html
      
              * rendering/RenderTable.cpp:
              (WebCore::RenderTable::recalcSections): Made const and replaced
              setNeedsLayout(true) with an assertion that the table is already
              marked for layout.
              (WebCore::RenderTable::sectionAbove): Added call to recalcSectionsIfNeeded().
              (WebCore::RenderTable::sectionBelow): Ditto.
              (WebCore::RenderTable::cellAbove): Ditto.
              (WebCore::RenderTable::cellBelow): Ditto.
              (WebCore::RenderTable::cellBefore): Ditto.
              (WebCore::RenderTable::cellAfter): Ditto.
              * rendering/RenderTable.h:
              Made some private member variables which are used in section recalc mutable.
              (WebCore::RenderTable::setNeedsSectionRecalc): Moved the call to
              setNeedsLayout() from recalcSections() into here, because I made
              recalcSections() const.
              (WebCore::RenderTable::recalcSectionsIfNeeded): Made const.
      
      2007-05-19  Mitz Pettel  <mitz@webkit.org>
      
              Reviewed by Darin.
      
              - test for http://bugs.webkit.org/show_bug.cgi?id=13774
                REGRESSION: Crash emailing blog entry using Google Reader
      
              * fast/table/stale-grid-crash-expected.checksum: Added.
              * fast/table/stale-grid-crash-expected.png: Added.
              * fast/table/stale-grid-crash-expected.txt: Added.
              * fast/table/stale-grid-crash.html: Added.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@21602 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      7746786d
    • bdash's avatar
      2007-05-19 Mitz Pettel <mitz@webkit.org> · 71b3ce0c
      bdash authored
              Reviewed by Darin.
      
              - http://bugs.webkit.org/show_bug.cgi?id=13320
                rounded corners with drop shadows are really slow
      
              Test for a rendering bug fixed by this patch:
                  fast/box-shadow/border-radius-big.html
      
              No test for the performance ingredient.
      
              * platform/graphics/GraphicsContext.cpp:
              (WebCore::GraphicsContext::addRoundedRectClip): Made cross-platform.
              Changed to use a single clipping path. If all the radii cannot be
              accommodated, clips to a rect.
              (WebCore::GraphicsContext::clipOutRoundedRect): Changed to use a single
              clipping path. If all the radii cannot be accommodated, clips out a rect.
              * platform/graphics/GraphicsContext.h: Added clipOut(const Path&).
              * platform/graphics/Path.cpp:
              (WebCore::Path::createRoundedRectangle): Added. Returns a rounded rectangle
              with the specified radii. If all the radii cannot be accommodated, returns
              a rectangular path.
              * platform/graphics/Path.h:
              * platform/graphics/cairo/GraphicsContextCairo.cpp:
              (WebCore::GraphicsContext::clipOut): Added.
              * platform/graphics/cg/GraphicsContextCG.cpp:
              (WebCore::GraphicsContext::fillRoundedRect): Changed to use a single path.
              (WebCore::GraphicsContext::clipOut): Added.
              * platform/graphics/qt/GraphicsContextQt.cpp:
              (WebCore::GraphicsContext::clipOut): Added.
      
      2007-05-19  Mitz Pettel  <mitz@webkit.org>
      
              Reviewed by Darin.
      
              - http://bugs.webkit.org/show_bug.cgi?id=13320
                rounded corners with drop shadows are really slow
      
              * fast/box-shadow/border-radius-big-expected.checksum: Added.
              * fast/box-shadow/border-radius-big-expected.png: Added.
              * fast/box-shadow/border-radius-big-expected.txt: Added.
              * fast/box-shadow/border-radius-big.html: Added.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@21601 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      71b3ce0c
    • andersca's avatar
      LayoutTests: · 44b89c45
      andersca authored
              Reviewed by Mitz.
      
              http://bugs.webkit.org/show_bug.cgi?id=13771
              Assertion failure ASSERT(m_layer) when running Hamachi fuzz tester
              
              * fast/frames/inline-object-inside-frameset-expected.txt: Added.
              * fast/frames/inline-object-inside-frameset.html: Added.
      
      WebCore:
      
              Reviewed by Mitz.
      
              Test: fast/frames/inline-object-inside-frameset.html
              
              http://bugs.webkit.org/show_bug.cgi?id=13771
              Assertion failure ASSERT(m_layer) when running Hamachi fuzz tester
      
              Don't paint inline objects.
              
              * rendering/RenderFrameSet.cpp:
              (WebCore::RenderFrameSet::paint):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@21600 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      44b89c45
    • hyatt's avatar
      Add support for plain text MIME types (CSS/JS/TXT) to view source mode. · f0935893
      hyatt authored
              CSS/JS will eventually tokenize via their own special tokenizers so that
              they can also be syntax-highlighted, but for now just treat them as
              plain text.
      
              Reviewed by aroben
      
              * dom/DOMImplementation.cpp:
              (WebCore::DOMImplementation::createDocument):
              * html/HTMLViewSourceDocument.cpp:
              (WebCore::HTMLViewSourceDocument::HTMLViewSourceDocument):
              (WebCore::HTMLViewSourceDocument::createTokenizer):
              (WebCore::HTMLViewSourceDocument::createContainingTable):
              (WebCore::HTMLViewSourceDocument::addViewSourceText):
              (WebCore::HTMLViewSourceDocument::addViewSourceToken):
              * html/HTMLViewSourceDocument.h:
              * loader/TextDocument.cpp:
              (WebCore::TextTokenizer::TextTokenizer):
              (WebCore::TextTokenizer::write):
              * loader/TextDocument.h:
              (WebCore::TextTokenizer::checkBuffer):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@21599 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      f0935893
    • hyatt's avatar
      Fix a glitch in view source mode attribute names. · 9cc9ebd7
      hyatt authored
              * html/HTMLViewSourceDocument.cpp:
              (WebCore::HTMLViewSourceDocument::addViewSourceToken):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@21598 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      9cc9ebd7
  4. 18 May, 2007 18 commits
    • hyatt's avatar
      "Linkify" view source mode links. · 3ab65053
      hyatt authored
              Reviewed by andersca
      
              * css/view-source.css:
              * html/HTMLViewSourceDocument.cpp:
              (WebCore::HTMLViewSourceDocument::addViewSourceToken):
              (WebCore::HTMLViewSourceDocument::addSpanWithClassName):
              (WebCore::HTMLViewSourceDocument::addLink):
              * html/HTMLViewSourceDocument.h:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@21597 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      3ab65053
    • oliver's avatar
      2007-05-18 Oliver Hunt <oliver@apple.com> · fada1d18
      oliver authored
      WebCore:
      
              Reviewed by Sam
      
              No longer need to pass HTMLImageElement and HTMLImageLoader on to WebKit
              Need to expose CachedResourceClient constructor
      
              * WebCore.exp:
              * WebCore.xcodeproj/project.pbxproj:
      
      WebKit:
      
              Reviewed by Sam.
      
              Fix for http://bugs.webkit.org/show_bug.cgi?id=13782 
              REGRESSION (r21528-r21533): Failing editing/selection/drag-in-iframe in pixel mode
              
              r21533 made used a DOMElement as the source for promise data, this meant it had to 
              clear the dragging pasteboard following the drag.  In DRT a drag is non-blocking
              so this resulted in us prematurely clearing the pasteboard.  
              
              This patch avoids this problem by referencing the source CachedImage rather than the
              DOMElement, so we don't need to worry about retaining an entire document forever, so
              we don't need to clear the dragging pasteboard following the drag.
              
              * Misc/WebNSPasteboardExtras.mm:
              (imageFromElement):
                Extract the underlying CachedImage from a DOMElement
              (-[NSPasteboard _web_writeImage:element:URL:title:archive:types:source:]):
                Use a CachedImage instead of a DOMElement
                
              * WebCoreSupport/WebDragClient.mm:
              (WebDragClient::startDrag):
              
              * WebKit.xcodeproj/project.pbxproj:
              
              * WebView/WebHTMLView.mm:
              (-[WebHTMLViewPrivate dealloc]):
              (-[WebHTMLViewPrivate clear]):
              (-[WebHTMLView pasteboardChangedOwner:]):
              (-[WebHTMLView pasteboard:provideDataForType:]):
              (-[WebHTMLView namesOfPromisedFilesDroppedAtDestination:]):
              (-[WebHTMLView WebCore::]):
              (-[WebHTMLView setPromisedDragTIFFDataSource:WebCore::]):
                Use CachedImage rather than DOMElement as promised data source
                
              * WebView/WebHTMLViewInternal.h:
              * WebView/WebHTMLViewPrivate.h:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@21596 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      fada1d18
    • hyatt's avatar
      Fix for <rdar://problem/5214338> REGRESSION: / mishandled in · 1abaea48
      hyatt authored
              HTML tokenization (13780).
      
              Reviewed by ggaren
      
              * html/HTMLTokenizer.cpp:
              (WebCore::Token::addAttribute):
              (WebCore::HTMLTokenizer::parseTag):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@21581 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      1abaea48
    • beidson's avatar
      Added bugzilla link · cd1a5729
      beidson authored
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@21580 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      cd1a5729
    • beidson's avatar
      Reviewed by Maciej · 9e87bdef
      beidson authored
              <rdar://problem/5166149> - window.open() causes server to be hit twice
      
              This regressed in http://trac.webkit.org/projects/webkit/changeset/14637
              That patch was to fix broken behavior when opening an already existant window.
              The unfortunate side effect was to cause the server to be hit twice.  
              Once during the call to frame->loader()->createWindow(), and again via a 
              scheduled redirection.
      
              I decided to restore the original de-facto behavior by making the new window
              open via a scheduled redirection - there is a FIXME that was already here that
              explains the reason why we have to do it this way for now.
      
              Additionally, there were two distinct places that had their own logic to open
              a new window - the logic for window.open() and the logic for 
              window.showModalDialog().  The logic was almost identical so I condensed them
              into one utility function that takes a flag to handle the slight difference.
      
              A layout test is not possible at this time since it would involve capturing 
              server logs (the 1st connection does not exist long enough to result in any
              delegate callbacks).  That task is documented in 
              http://bugs.webkit.org/show_bug.cgi?id=13769
      
              * bindings/js/kjs_window.cpp:
              (KJS::createWindow): Merged the two slightly different versions of "creating a window" 
                logic here.  For the modal dialog case the load is an immediate call to changeLocation(),
                which is triggered by the "immediate" flag, and the other cases load via scheduleLocationChange()
              (KJS::showModalDialog): Call createWindow()
              (KJS::WindowFunc::callAsFunction): Handle frame targets of _top or _parent immediately and call 
                createWindow() for all others
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@21578 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      9e87bdef
    • weinig's avatar
      LayoutTests: · a211a4ba
      weinig authored
              Reviewed by Geoff.
      
              - update results to account for new JSHTMLElements that are being
                auto-generated and can now produce Constructors.
      
              * fast/dom/Window/element-constructors-on-window-expected.txt:
              * fast/dom/Window/window-properties-expected.txt:
      
      WebCore:
      
              Reviewed by Geoff.
      
              Autogenerate the JS bindings for the HTMLTableElement, HTMLTableCaptionElement,
              HTMLTableCellElement, HTMLTableColElement, HTMLTableRowElement, HTMLTableSectionElement.
      
              * DerivedSources.make:
              * WebCore.pro:
              * WebCore.xcodeproj/project.pbxproj:
              * bindings/js/JSHTMLElementWrapperFactory.cpp:
              (WebCore::createJSHTMLWrapper):
              * bindings/js/kjs_html.cpp:
              (KJS::):
              (KJS::JSHTMLElement::classInfo):
              (KJS::JSHTMLElement::accessors):
              (KJS::HTMLElementFunction::callAsFunction):
              * bindings/js/kjs_html.h:
              (KJS::JSHTMLElement::):
              * html/HTMLTableCaptionElement.idl:
              * html/HTMLTableCellElement.idl:
              * html/HTMLTableColElement.idl:
              * html/HTMLTableElement.idl:
              * html/HTMLTableRowElement.idl:
              * html/HTMLTableSectionElement.idl:
              * page/DOMWindow.idl:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@21577 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      a211a4ba
    • oliver's avatar
      2007-05-18 Oliver Hunt <oliver@apple.com> · 1be0bf39
      oliver authored
              Reviewed by Sam.
      
              Fix for <rdar://problem/5211122> DRT crash below
              SVGTimer::applyAnimations when page cache is enabled 
              (SVG animation timers do not properly cancel themselves)
      
              There were still a few paths in the SVG Animation code
              that could cause timers to be created and used.  This 
              patch inserts addition SVG_EXPERIMENTAL blocks to prevent
              these timers from being used.
      
              * ksvg2/misc/SVGDocumentExtensions.cpp:
              (WebCore::SVGDocumentExtensions::startAnimations):
              * ksvg2/misc/SVGTimer.cpp:
              (WebCore::SVGTimer::animationsByElement):
              (WebCore::SVGTimer::applyAnimations):
              (WebCore::SVGTimer::notifyAll):
              (WebCore::SVGTimer::addNotify):
              (WebCore::SVGTimer::removeNotify):
              * ksvg2/misc/TimeScheduler.cpp:
              (WebCore::TimeScheduler::addTimer):
              (WebCore::TimeScheduler::connectIntervalTimer):
              (WebCore::TimeScheduler::disconnectIntervalTimer):
              (WebCore::TimeScheduler::startAnimations):
              (WebCore::TimeScheduler::toggleAnimations):
              (WebCore::TimeScheduler::timerFired):
              * ksvg2/svg/SVGAnimationElement.h:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@21572 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      1be0bf39
    • zack's avatar
      Patch from Marius Bugge Monsen to fix clipboard crash. · 52093102
      zack authored
      Return a valid pointer to a Clipboard object
      from newGeneralClipboard.
      r=me
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@21568 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      52093102
    • bdash's avatar
      2007-05-18 Mark Rowe <mrowe@apple.com> · 0d4ebb85
      bdash authored
              Attempt to fix the Gdk build after r21562.
      
              * platform/gdk/TemporaryLinkStubs.cpp:
              (Widget::isEnabled):
              * platform/gdk/WidgetGdk.cpp:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@21563 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      0d4ebb85
    • lars's avatar
      2007-05-18 Adam Treat <treat@kde.org> · c00a762f
      lars authored
              Reviewed by Lars
      
              Remove dead code.
      
              * platform/Widget.h:
              * platform/mac/WidgetMac.mm:
              * platform/qt/WidgetQt.cpp:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@21562 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      c00a762f
    • bdash's avatar
      2007-05-18 Holger Freyther <zecke@selfish.org> · d0c0d4ff
      bdash authored
              Reviewed by Maciej.
      
              Return true to make loading of pages working again
      
              * loader/gdk/FrameLoaderClientGdk.cpp:
              (WebCore::FrameLoaderClientGdk::canHandleRequest):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@21561 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      d0c0d4ff
    • bdash's avatar
      2007-05-18 Holger Freyther <zecke@selfish.org> · 2f045e58
      bdash authored
              Reviewed by Maciej.
      
              Make WebCore::Widget use GtkWidget to fix focus handling.
      
              * WebCore.pro: Add PlatformScrollBar
              * platform/ScrollView.h: Gtk stuff
              * platform/Widget.h: Take a GtkWidget
              * platform/gdk/PlatformScrollBarGdk.cpp: Added.
              (PlatformScrollbar::PlatformScrollbar):
              (PlatformScrollbar::~PlatformScrollbar):
              (PlatformScrollbar::width):
              (PlatformScrollbar::height):
              (PlatformScrollbar::setEnabled):
              (PlatformScrollbar::paint):
              (PlatformScrollbar::updateThumbPosition):
              (PlatformScrollbar::updateThumbProportion):
              (PlatformScrollbar::setRect):
              * platform/gdk/ScreenGdk.cpp: Implement depth handling
              (WebCore::screenDepth):
              * platform/gdk/ScrollViewGdk.cpp: use setGtkWidget, not setDrawable
              (WebCore::ScrollView::setGtkWidget):
              * platform/gdk/TemporaryLinkStubs.cpp:
              * platform/gdk/WidgetGdk.cpp:
              (WebCore::Widget::Widget):
              (WebCore::Widget::gtkWidget):
              (WebCore::Widget::setGtkWidget):
              (WebCore::Widget::hasFocus):
              (WebCore::Widget::setFocus):
      
      2007-05-18  Holger Freyther  <zecke@selfish.org>
      
              Reviewed by Maciej.
      
              * GdkLauncher/main.cpp: Call setGtkWidget
              (main):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@21560 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      2f045e58
    • lars's avatar
      Reviewed by Zack · f188d973
      lars authored
              Correctly implement initialiseSupportedImageMIMETypes.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@21559 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      f188d973
    • bdash's avatar
      2007-05-18 Holger Hans Peter Freyther <zecke@selfish.org> · ffaee62c
      bdash authored
              Reviewed by Maciej.
      
              Build fix for non-Qt and non-Mac ports.
      
              * html/HTMLCanvasElement.h:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@21558 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      ffaee62c
    • bdash's avatar
      2007-05-18 Holger Hans Peter Freyther <zecke@selfish.org> · 98f449d6
      bdash authored
              Reviewed by Mark Rowe.
      
              No test added as this is hard to time.
      
              * platform/gdk/FrameGdk.cpp: Use needsLayout() to decide if layout()
              is needed.
      
              (WebCore::FrameGdk::dumpRenderTree):
              (WebCore::FrameGdk::handleGdkEvent):
      
      2007-05-18  Holger Hans Peter Freyther  <zecke@selfish.org>
      
              Reviewed by Mark Rowe.
      
              * kjs/testkjs.pro: Make the Gdk port link to icu
      
      2007-05-18  Holger Hans Peter Freyther  <zecke@selfish.org>
      
              Reviewed by Mark Rowe.
      
              * WebKit.pro: Build testkjs for Gdk and Qt
      
      2007-05-18  Holger Hans Peter Freyther  <zecke@selfish.org>
      
              Reviewed by Mark Rowe.
      
              * GdkLauncher/main.cpp:
              (main): Call Frame::init to catch up with Maciej's changes.
              * Scripts/run-javascriptcore-tests: Remove --gdk from the command line
              passed to the helper scripts.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@21557 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      98f449d6
    • hausmann's avatar
      Generate pkgconfig files for the Qt build. · 8e319071
      hausmann authored
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@21556 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      8e319071
    • lars's avatar
      Reviewed by Hyatt. · 3a0dd51c
      lars authored
              Remove unused handleMouseEvent methods in the Widget
              and derived classes.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@21555 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      3a0dd51c
    • staikos's avatar
      Use the proper clipping algorithm · c01e4e0c
      staikos authored
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@21554 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      c01e4e0c