- 07 Feb, 2012 40 commits
-
-
commit-queue@webkit.org authored
https://bugs.webkit.org/show_bug.cgi?id=77948 Patch by Krzysztof Czech <k.czech@samsung.com> on 2012-02-07 Reviewed by Eric Seidel. The value of editable in Ewk_Frame_Smart_Data struct is not set. * ewk/ewk_frame.cpp: (ewk_frame_editable_set): git-svn-id: http://svn.webkit.org/repository/webkit/trunk@107010 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
leviw@chromium.org authored
https://bugs.webkit.org/show_bug.cgi?id=77914 Reviewed by Eric Seidel. Updating ColumnInfo and RenderFrameSet to use LayoutUnits instead of directly referencing integers for locations and distances. No new tests. No changed behavior. * rendering/ColumnInfo.h: (WebCore::ColumnInfo::forcedBreakOffset): (WebCore::ColumnInfo::maximumDistanceBetweenForcedBreaks): (ColumnInfo): * rendering/RenderFrameSet.cpp: (WebCore::RenderFrameSet::paintColumnBorder): (WebCore::RenderFrameSet::paintRowBorder): * rendering/RenderFrameSet.h: (RenderFrameSet): git-svn-id: http://svn.webkit.org/repository/webkit/trunk@107009 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
adamk@chromium.org authored
https://bugs.webkit.org/show_bug.cgi?id=70289 Reviewed by Eric Seidel. Source/WebCore: The meat of this change is in JSMainThreadExecState, where a counter is incremented every time WebCore calls into JSC and decremented every time it returns. When the counter reaches zero, any pending mutations are delivered (this mirrors very similar code in V8Proxy and V8RecursionScope). The rest of the changes are of two sorts: compilation/logic fixes for JSC code when ENABLE(MUTATION_OBSERVERS) is true, and additional usages of JSMainThreadExecState so as to trigger the above increment/decrements at the appropriate times. * bindings/js/JSCustomXPathNSResolver.cpp: (WebCore::JSCustomXPathNSResolver::lookupNamespaceURI): Use JSMainThreadExecState instead of JSC::call. * bindings/js/JSDictionary.cpp: (WebCore::JSDictionary::convertValue): Add support for tryGetProperty with a HashMap<AtomicString>. * bindings/js/JSDictionary.h: * bindings/js/JSErrorHandler.cpp: (WebCore::JSErrorHandler::handleEvent): Use JSMainThreadExecState instead of JSC::call. * bindings/js/JSHTMLDocumentCustom.cpp: (WebCore::JSHTMLDocument::open): Use JSMainThreadExecState instead of JSC::call. * bindings/js/JSMainThreadExecState.cpp: (WebCore::JSMainThreadExecState::didLeaveScriptContext): * bindings/js/JSMainThreadExecState.h: (WebCore::JSMainThreadExecState::JSMainThreadExecState): Increment a static recursion level counter. (WebCore::JSMainThreadExecState::~JSMainThreadExecState): Decrement a static recursion level counter and, if we are at zero (the outermost script invocation), deliver any outstanding mutation records. * bindings/js/JSNodeFilterCondition.cpp: (WebCore::JSNodeFilterCondition::acceptNode): Use JSMainThreadExecState instead of JSC::call. * bindings/js/JSWebKitMutationObserverCustom.cpp: (WebCore::JSWebKitMutationObserver::observe): Fix JSDictionary logic, add support for attributeFilter. Tools: * DumpRenderTree/mac/EventSendingController.mm: Add support for eventSender.scheduleAsynchronousKeyDown. (+[EventSendingController isSelectorExcludedFromWebScript:]): (+[EventSendingController webScriptNameForSelector:]): (-[EventSendingController keyDownWrapper:withModifiers:withLocation:]): (-[EventSendingController scheduleAsynchronousKeyDown:withModifiers:withLocation:]): * Scripts/build-webkit: Properly alphabetize --mutation-observers in the --help output. LayoutTests: With the various fixes in this change, 8/10 tests in fast/mutation pass under WebKit/Mac. Of the failing tests, only one is due to a deficiency in the Mac port's code (end-of-task-delivery.html); the other is due to lack of support for a feature (FILE_SYSTEM) exercised by the test (non-event-delivery.html). * fast/mutation/non-event-delivery.html: Made it fail fast if FileSystem support isn't available. * fast/mutation/observe-attributes.html: Fixed calls to removeEventListener. * fast/mutation/observe-characterdata.html: ditto. git-svn-id: http://svn.webkit.org/repository/webkit/trunk@107008 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
andersca@apple.com authored
* platform/ScrollableArea.h: (WebCore::ScrollableArea::scrollableAreaBoundingBox): git-svn-id: http://svn.webkit.org/repository/webkit/trunk@107006 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
leviw@chromium.org authored
https://bugs.webkit.org/show_bug.cgi?id=74392 Reviewed by Eric Seidel. Source/WebCore: Solution uncovered by Nikolas Zimmermann. Removing an early return that caused SVGUseElements to not update the shadow root's style, and therefor not render correctly. Test: svg/custom/use-disappears-after-style-update.svg * svg/SVGUseElement.cpp: (WebCore::SVGUseElement::didRecalcStyle): LayoutTests: * platform/mac-snowleopard/svg/custom/use-disappears-after-style-update-expected.png: Added. * platform/mac-snowleopard/svg/custom/use-disappears-after-style-update-expected.txt: Added. * svg/custom/use-disappears-after-style-update.svg: Added. git-svn-id: http://svn.webkit.org/repository/webkit/trunk@107005 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
haraken@chromium.org authored
https://bugs.webkit.org/show_bug.cgi?id=77973 Reviewed by Adam Barth. This patch renames [v8OnProto] to [V8OnProto], since V8 specific IDL attributes should be prefixed by "V8". No tests. No change in behavior. * bindings/scripts/CodeGeneratorV8.pm: (GenerateNormalAttrGetter): (GenerateNormalAttrSetter): (GenerateSingleBatchedAttribute): (GenerateImplementation): git-svn-id: http://svn.webkit.org/repository/webkit/trunk@107004 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
jer.noble@apple.com authored
https://bugs.webkit.org/show_bug.cgi?id=69779 Reviewed by Eric Carlson. Do not use "OpenForPlayback" attribute on data:// urls, as CoreMedia/QuickTime X cannot handle those URLs. * platform/graphics/mac/MediaPlayerPrivateQTKit.mm: (WebCore::MediaPlayerPrivateQTKit::createQTMovie): git-svn-id: http://svn.webkit.org/repository/webkit/trunk@107002 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
andersca@apple.com authored
https://bugs.webkit.org/show_bug.cgi?id=78050 Reviewed by Dan Bernstein. We currently won't do fast scrolling for subframes and other types of scrollable areas. Because of this, we'll have the scrolling tree keep a region of the page for which we can't do fast scrolling. This region will be updated after layout. * page/FrameView.cpp: (WebCore::FrameView::scrollableAreaBoundingBox): Return the bounding box. * page/scrolling/ScrollingCoordinator.cpp: (WebCore::ScrollingCoordinator::frameViewLayoutUpdated): Go through all the scrollable areas in this frame view and compute the region which we can't do fast scrolling for. * page/scrolling/ScrollingTree.cpp: (WebCore::ScrollingTree::commitNewTreeState): Update the non-fast-scrollable region. * page/scrolling/ScrollingTreeState.cpp: (WebCore::ScrollingTreeState::setNonFastScrollableRegion): Set the non-fast-scrollable region if it's changed. * platform/ScrollableArea.h: Add scrollableAreaBoundingBox member function. * rendering/RenderLayer.cpp: (WebCore::RenderLayer::scrollableAreaBoundingBox): Return the bounding box. * rendering/RenderListBox.cpp: (WebCore::RenderListBox::scrollableAreaBoundingBox): Return the bounding box. git-svn-id: http://svn.webkit.org/repository/webkit/trunk@107001 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
leviw@chromium.org authored
https://bugs.webkit.org/show_bug.cgi?id=73310 Reviewed by Eric Seidel. Source/WebCore: Adding support for unicode-bidi: plaintext as a property on inlines. These are treated like unicode-bidi: isolate with the addition of their directionality being determined by the UBA. Tests: fast/text/international/inline-plaintext-is-isolated-expected.html fast/text/international/inline-plaintext-is-isolated.html fast/text/international/inline-plaintext-relayout-with-leading-neutrals-expected.html fast/text/international/inline-plaintext-relayout-with-leading-neutrals.html fast/text/international/inline-plaintext-with-generated-content-expected.html fast/text/international/inline-plaintext-with-generated-content.html * platform/text/UnicodeBidi.h: (WebCore::isIsolated): Added this convenience function as Plaintext and Isolate Unicode-Bidi values are both treated as isolated content. * rendering/InlineIterator.h: (WebCore::notifyObserverEnteredObject): Inline now supports Unicode-Bidi Plaintext. (WebCore::notifyObserverWillExitObject): Ditto. (WebCore::bidiFirstSkippingEmptyInlines): Changed to support being called without a resolver. (WebCore::isIsolatedInline): Inline now supports Unicode-Bidi: Plaintext. * rendering/RenderBlockLineLayout.cpp: (WebCore::determineDirectionality): Generalized for inlines. (WebCore::constructBidiRuns): Added support for Unicode-Bidi: Plaintext as an isolated inline. (WebCore::RenderBlock::layoutRunsAndFloatsInRange): Fixed comment. (WebCore::RenderBlock::determineStartPosition): Fixed comment and switched to updated bidiFirstSkippingEmptyInlines. LayoutTests: Ref tests for unicode-bidi: plaintext on inlines. * fast/text/international/inline-plaintext-is-isolated-expected.html: Added. * fast/text/international/inline-plaintext-is-isolated.html: Added. * fast/text/international/inline-plaintext-relayout-with-leading-neutrals-expected.html: Added. * fast/text/international/inline-plaintext-relayout-with-leading-neutrals.html: Added. * fast/text/international/inline-plaintext-with-generated-content-expected.html: Added. * fast/text/international/inline-plaintext-with-generated-content.html: Added. git-svn-id: http://svn.webkit.org/repository/webkit/trunk@107000 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
http://www.rickshawbags.com/barraclough@apple.com authored
https://bugs.webkit.org/show_bug.cgi?id=78045 Reviewed by Darin Adler. Problem URL is: http://www.rickshawbags.com/customize/custom-bag#!thl=rickshaw/bag() This is a bug introduced by https://bugs.webkit.org/show_bug.cgi?id=71933, isVariableObject() checks were excluding StaticScopeObjects, this patch inadvertently changed them to be included. * runtime/JSType.h: - sort JSType enum such that StaticScopeObjectType comes before VariableObjectType, and thus is excluded from isVariableObject() checks. git-svn-id: http://svn.webkit.org/repository/webkit/trunk@106999 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
haraken@chromium.org authored
https://bugs.webkit.org/show_bug.cgi?id=77957 Reviewed by Adam Barth. This patch replaces IsSubType("WorkerContext") and something equivalent that with the [IsWorkerContext] IDL. No tests. No change in behavior. * bindings/scripts/CodeGeneratorV8.pm: (GetInternalFields): (GenerateConstructorGetter): (GenerateImplementation): git-svn-id: http://svn.webkit.org/repository/webkit/trunk@106998 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
commit-queue@webkit.org authored
https://bugs.webkit.org/show_bug.cgi?id=75715 Patch by David Reveman <reveman@chromium.org> on 2012-02-07 Reviewed by James Robinson. PlatformCanvas constructor on win32 expects forth argument to be a shared section handle. Passing a pointer to a system memory causes it to crash. Fix this by not using the PlatformCanvas API for SkCanvas construction in per-tile texture uploader. Tested with manual tests. * platform/graphics/chromium/BitmapSkPictureCanvasLayerTextureUpdater.cpp: (WebCore::BitmapSkPictureCanvasLayerTextureUpdater::Texture::prepareRect): (WebCore::BitmapSkPictureCanvasLayerTextureUpdater::Texture::updateRect): * platform/graphics/chromium/BitmapSkPictureCanvasLayerTextureUpdater.h: (Texture): git-svn-id: http://svn.webkit.org/repository/webkit/trunk@106997 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
jer.noble@apple.com authored
* platform/mac/PlatformClockCM.mm: git-svn-id: http://svn.webkit.org/repository/webkit/trunk@106996 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
jchaffraix@webkit.org authored
* platform/chromium/test_expectations.txt: We don't have at least one of the layoutTestController functions used in this test so we are receiving an exception and timing out. git-svn-id: http://svn.webkit.org/repository/webkit/trunk@106995 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
commit-queue@webkit.org authored
https://bugs.webkit.org/show_bug.cgi?id=78019 Patch by Dana Jansens <danakj@chromium.org> on 2012-02-07 Reviewed by James Robinson. * tests/CCLayerTreeHostTest.cpp: (CCLayerTreeHostTestManySurfaces): (WTF::CCLayerTreeHostTestManySurfaces::CCLayerTreeHostTestManySurfaces): (WTF::CCLayerTreeHostTestManySurfaces::beginTest): (WTF::CCLayerTreeHostTestManySurfaces::afterTest): (WTF): git-svn-id: http://svn.webkit.org/repository/webkit/trunk@106994 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
commit-queue@webkit.org authored
https://bugs.webkit.org/show_bug.cgi?id=77991 Patch by Rob Buis <rbuis@rim.com> on 2012-02-07 Reviewed by Antonio Gomes. No functionalities changed, no new tests. * blackberry/WebKitSupport/DumpRenderTreeSupport.cpp: Added. (toGeolocationClientMock): (DumpRenderTreeSupport::DumpRenderTreeSupport): (DumpRenderTreeSupport::~DumpRenderTreeSupport): (DumpRenderTreeSupport::javaScriptObjectsCount): (DumpRenderTreeSupport::garbageCollectorCollect): (DumpRenderTreeSupport::garbageCollectorCollectOnAlternateThread): (DumpRenderTreeSupport::setLinksIncludedInFocusChain): (DumpRenderTreeSupport::linksIncludedInFocusChain): (DumpRenderTreeSupport::dumpConfigurationForViewport): (DumpRenderTreeSupport::numberOfPendingGeolocationPermissionRequests): (DumpRenderTreeSupport::resetGeolocationMock): (DumpRenderTreeSupport::setMockGeolocationError): (DumpRenderTreeSupport::setMockGeolocationPermission): (DumpRenderTreeSupport::setMockGeolocationPosition): (DumpRenderTreeSupport::scalePageBy): (DumpRenderTreeSupport::computedStyleIncludingVisitedInfo): * blackberry/WebKitSupport/DumpRenderTreeSupport.h: Added. (WebKit): (WebCore): (WTF): (DumpRenderTreeSupport): git-svn-id: http://svn.webkit.org/repository/webkit/trunk@106993 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
jamesr@google.com authored
[chromium] Allow retaining texture across frames in composited video playback and correctly handle lost context https://bugs.webkit.org/show_bug.cgi?id=77923 Reviewed by Kenneth Russell. Thanks to r106840, we can improve the video playback mode a bit. Instead of creating a new texture on every frame, this attempts to reuse the texture from the previous frame unless the context is lost. Also improves error checking in case the TextureManager cannot successfully reserve memory for the texture. Tested manually by killing the GPU process with an html5 video playing and verifying that the video playback continues and that we don't create a new set of textures for each plane on each frame. * platform/graphics/chromium/cc/CCVideoLayerImpl.cpp: (WebCore::CCVideoLayerImpl::draw): (WebCore::CCVideoLayerImpl::reserveTextures): git-svn-id: http://svn.webkit.org/repository/webkit/trunk@106992 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
commit-queue@webkit.org authored
https://bugs.webkit.org/show_bug.cgi?id=58467 Patch by Eugene Girard <girard@chromium.org> on 2012-02-07 Reviewed by Tony Chang. This ticket was fixed as part of https://bugs.webkit.org/show_bug.cgi?id=58471 Adding unit tests to verify correct operation. * storage/indexeddb/index-basics-expected.txt: * storage/indexeddb/index-basics-workers-expected.txt: * storage/indexeddb/resources/index-basics.js: (deleteExisting): git-svn-id: http://svn.webkit.org/repository/webkit/trunk@106991 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
jchaffraix@webkit.org authored
* platform/chromium/test_expectations.txt: Mark those 2 tests as crashing in Debug as they seem to be hitting an ASSERT. git-svn-id: http://svn.webkit.org/repository/webkit/trunk@106990 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
ossy@webkit.org authored
* platform/qt/Skipped: Skip failing/crashing tests, because we like regressions in trunk. git-svn-id: http://svn.webkit.org/repository/webkit/trunk@106989 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
mdelaney@apple.com authored
Removing old CG shadow code. A CG-specific shadow offset hack was added in http://trac.webkit.org/changeset/34317 for this particular setShadow method. However, this shadow offset adjustment for CG has since moved down into platform specific code. Thus, this offset adjustment here is now redundant. The CG-only shadow setting code block in this setShadow method is now redundant. Since it sets the shadow values to the CGContext directly - and not to the State object - it will be overwritten later by any subsequent calls to setting shadow values such as blur, offset, or shadow color. Reviewed by Simon Fraser. No new tests. Current canvas tests cover this path. * html/canvas/CanvasRenderingContext2D.cpp: (WebCore::CanvasRenderingContext2D::setShadow): git-svn-id: http://svn.webkit.org/repository/webkit/trunk@106988 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
commit-queue@webkit.org authored
https://bugs.webkit.org/show_bug.cgi?id=77477 Patch by Sadrul Habib Chowdhury <sadrul@chromium.org> on 2012-02-07 Reviewed by James Robinson. * src/WebCompositorInputHandlerImpl.cpp: (WebKit::WebCompositorInputHandlerImpl::WebCompositorInputHandlerImpl): (WebKit::WebCompositorInputHandlerImpl::handleInputEvent): * src/WebCompositorInputHandlerImpl.h: (WebCompositorInputHandlerImpl): git-svn-id: http://svn.webkit.org/repository/webkit/trunk@106987 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
jamesr@google.com authored
https://bugs.webkit.org/show_bug.cgi?id=78013 Reviewed by Kenneth Russell. If compositor initialization fails it's not safe to proceed through the rest of the frame process. This adds some early outs. Tested manually by forcing the first makeContextCurrent() call fail. * platform/graphics/chromium/cc/CCLayerTreeHost.cpp: (WebCore::CCLayerTreeHost::updateLayers): * platform/graphics/chromium/cc/CCLayerTreeHost.h: (CCLayerTreeHost): * platform/graphics/chromium/cc/CCSingleThreadProxy.cpp: (WebCore::CCSingleThreadProxy::compositeAndReadback): (WebCore::CCSingleThreadProxy::compositeImmediately): (WebCore::CCSingleThreadProxy::commitIfNeeded): * platform/graphics/chromium/cc/CCSingleThreadProxy.h: (CCSingleThreadProxy): git-svn-id: http://svn.webkit.org/repository/webkit/trunk@106986 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
ap@apple.com authored
https://bugs.webkit.org/show_bug.cgi?id=78024 Reviewed by Anders Carlsson. * UIProcess/WebConnectionToWebProcess.cpp: (WebKit::WebConnectionToWebProcess::didReceiveInvalidMessage): git-svn-id: http://svn.webkit.org/repository/webkit/trunk@106985 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
crogers@google.com authored
https://bugs.webkit.org/show_bug.cgi?id=78016 Reviewed by Adam Barth. * Scripts/webkitpy/common/config/committers.py: git-svn-id: http://svn.webkit.org/repository/webkit/trunk@106984 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
zimmermann@webkit.org authored
https://bugs.webkit.org/show_bug.cgi?id=78021 Reviewed by Dan Bernstein. Fix race condition in repaint rect tracking. When running a test using the repaint.js harness right after a test starting with "svg/W3C-SVG-1.1" the repaint test will fail, the gray overlay isn't contained in the pixel dump anymore. This is because of a specific hack that forces 480x360 instead of 800x600 pixel test dumps for any test starting with svg/W3C-SVG-1.1. The resizing of the web view was done when dumping the render tree, after the repaint test already run, thus invalidating the previously tracked repaint rects. * DumpRenderTree/mac/DumpRenderTree.mm: (dump): (runTest): git-svn-id: http://svn.webkit.org/repository/webkit/trunk@106983 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
rdar://problem/9567286https://bugs.webkit.org/show_bug.cgi?id=78003beidson@apple.com authored
<rdar://problem/9567286> and https://bugs.webkit.org/show_bug.cgi?id=78003 WebKit associates credentials with the wrong site if the authentication challenge takes place after a redirect chain Reviewed by Alexey Proskuryakov. Source/WebCore: Test: http/tests/loading/authentication-after-redirect-stores-wrong-credentials/authentication-after-redirect-stores-wrong-credentials.html Associate the credential with the URL of the challenge itself, not the original request: * platform/network/cf/ResourceHandleCFNet.cpp: (WebCore::ResourceHandle::didReceiveAuthenticationChallenge): (WebCore::ResourceHandle::receivedCredential): * platform/network/mac/ResourceHandleMac.mm: (WebCore::ResourceHandle::didReceiveAuthenticationChallenge): (WebCore::ResourceHandle::receivedCredential): LayoutTests: * http/tests/loading/authentication-after-redirect-stores-wrong-credentials/authentication-after-redirect-stores-wrong-credentials-expected.txt: Added. * http/tests/loading/authentication-after-redirect-stores-wrong-credentials/authentication-after-redirect-stores-wrong-credentials.html: Added. * http/tests/loading/authentication-after-redirect-stores-wrong-credentials/resources/wrong-credential-1-redirect-to-auth.php: Added. * http/tests/loading/authentication-after-redirect-stores-wrong-credentials/resources/wrong-credential-2-auth-then-redirect-to-finish.php: Added. * http/tests/loading/authentication-after-redirect-stores-wrong-credentials/resources/wrong-credential-3-output-credentials-then-finish.php: Added. git-svn-id: http://svn.webkit.org/repository/webkit/trunk@106982 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
jchaffraix@webkit.org authored
* platform/chromium/test_expectations.txt: It was a mistake as the test is really flaky not slow, so now it is taking way longer to fail (see http://webkit.org/b/77997). git-svn-id: http://svn.webkit.org/repository/webkit/trunk@106981 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
tony@chromium.org authored
https://bugs.webkit.org/show_bug.cgi?id=78017 Reviewed by Darin Adler. Move the warning about keeping RenderStyleConstnats.h enums and CSSValueKeywords.in values in the same order closer to the properties that the warning applies to. The warning was easy to miss and was confusing since it doesn't apply to most values. Also refactor 2 conversion functions to enumerate the possible values so the order doesn't matter. No new tests, just refactoring and comment cleanup. * css/CSSPrimitiveValueMappings.h: (WebCore::CSSPrimitiveValue::operator EListStylePosition): Name all possible values and add a NOT_REACHED(). (WebCore::CSSPrimitiveValue::operator EUserModify): Name all possible values and add a NOT_REACHED(). * css/CSSValueKeywords.in: * css/SVGCSSPropertyNames.in: * css/SVGCSSValueKeywords.in: * rendering/style/RenderStyleConstants.h: git-svn-id: http://svn.webkit.org/repository/webkit/trunk@106980 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
jer.noble@apple.com authored
https://bugs.webkit.org/show_bug.cgi?id=77885 Reviewed by Eric Carlson. Source/JavaScriptCore: * wtf/Platform.h: Added WTF_USE_COREMEDIA. Source/WebCore: No new tests; performance improvement covered by existing test cases. * WebCore.xcodeproj/project.pbxproj: * platform/Clock.cpp: (Clock::create): Use PlatformClockCM if available. * platform/mac/PlatformClockCM.h: Added. (WebCore::PlatformClockCM::playRate): (WebCore::PlatformClockCM::isRunning): * platform/mac/PlatformClockCM.mm: Added. (PlatformClockCM::PlatformClockCM): (PlatformClockCM::initializeWithTimingSource): (PlatformClockCM::setCurrentTime): (PlatformClockCM::currentTime): (PlatformClockCM::setPlayRate): (PlatformClockCM::start): (PlatformClockCM::stop): git-svn-id: http://svn.webkit.org/repository/webkit/trunk@106978 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
andersca@apple.com authored
https://bugs.webkit.org/show_bug.cgi?id=62762 Reviewed by Beth Dakin. Source/WebCore: It makes more sense for the set of scrollable areas to be per frame view instead of per page; scrollable areas are associated with a containing frame view and their lifecycle follows the lifecycle of the frame view much more closely. This could even fix a bunch of crashes where a scrollable area outlived its containing page. * WebCore.exp.in: Replace the Page member functions with FrameView member functions instead. * page/EventHandler.cpp: (WebCore::EventHandler::mouseMoved): Check if the frame view contains the given layer. (WebCore::EventHandler::updateMouseEventTargetNode): Ditto. * page/FocusController.cpp: (WebCore::contentAreaDidShowOrHide): Add helper function. (WebCore::FocusController::setContainingWindowIsVisible): Call contentAreaDidShowOrHide for the main frame view, and for all scrollable areas inside all subframe views. * page/FrameView.cpp: (WebCore::FrameView::FrameView): Use early returns to make the code more clear. Also, don't add the scrollable area to the set here. (WebCore::FrameView::~FrameView): Don't remove the scrollable area here. (WebCore::FrameView::zoomAnimatorTransformChanged): m_page is gone so use m_frame->page() instead. (WebCore::FrameView::setAnimatorsAreActive): Call ScrollAnimator::setIsActive for all the scrollable areas in this frame view. Previously we used to do this for all scrollable areas on the page, but since setAnimatorsAreActive will be called for each document, this will be done implicitly. (WebCore::FrameView::notifyPageThatContentAreaWillPaint): Call ScrollableArea::contentDidPaint for this frame view and all its immediate scrollable areas. Previously, we used to do this for all scrollable areas on the page, but we only need to do it for this frame view. (WebCore::FrameView::scrollAnimatorEnabled): Get the page from m_frame since m_page is gone. (WebCore::FrameView::addScrollableArea): (WebCore::FrameView::removeScrollableArea): (WebCore::FrameView::containsScrollableArea): Move these member functions here from Page. (WebCore::FrameView::addChild): If we are adding a frame view, add it to the scrollable area set. (WebCore::FrameView::removeChild): If we are removing a frame view, remove it from the scrollable area set. * page/FrameView.h: Move the member function declarations and the scrollable area set member variable here from Page. * page/Page.cpp: (WebCore::Page::~Page): Don't call disconnectPage on the scrollable areas anymore. * platform/ScrollView.h: (ScrollView): Make addChild and removeChild virtual. * platform/ScrollableArea.h: Remove disconnectFromPage. * rendering/RenderLayer.cpp: (WebCore::RenderLayer::RenderLayer): (WebCore::RenderLayer::~RenderLayer): (WebCore::RenderLayer::styleChanged): The frame view now keeps track of the scrollable areas. * rendering/RenderLayer.h: Remove the page member variable and disconnectFromPage. * rendering/RenderListBox.cpp: (WebCore::RenderListBox::RenderListBox): (WebCore::RenderListBox::~RenderListBox): The frame view now keeps track of the scrollable areas. * rendering/RenderListBox.h: Remove the page member variable and disconnectFromPage. Source/WebKit/chromium: Update for changes to WebCore now that the scrollable area set is kept per frame view. * src/ScrollbarGroup.cpp: (WebKit::ScrollbarGroup::ScrollbarGroup): (WebKit::ScrollbarGroup::~ScrollbarGroup): * src/ScrollbarGroup.h: (WebCore): (ScrollbarGroup): * src/WebPluginContainerImpl.cpp: (WebKit::WebPluginContainerImpl::scrollbarGroup): Source/WebKit2: * WebProcess/Plugins/PDF/BuiltInPDFView.cpp: (WebKit::BuiltInPDFView::initialize): Call FrameView::addScrollableArea instead. (WebKit::BuiltInPDFView::destroy): Call FrameView::removeScrollableArea instead. * WebProcess/Plugins/PDF/BuiltInPDFView.h: Remove disconnectFromPage since it no longer exists on ScrollableArea. git-svn-id: http://svn.webkit.org/repository/webkit/trunk@106977 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
commit-queue@webkit.org authored
[BlackBerry] Upstream BlackBerry WebCoreSupport DeviceOrientationClientBlackBerry and DeviceMotionClientBlackBerry classes https://bugs.webkit.org/show_bug.cgi?id=77993 Patch by Jacky Jiang <zhajiang@rim.com> on 2012-02-07 Reviewed by Rob Buis. Initial upstream, no new tests. * blackberry/WebCoreSupport/DeviceMotionClientBlackBerry.cpp: Added. * blackberry/WebCoreSupport/DeviceMotionClientBlackBerry.h: Added. * blackberry/WebCoreSupport/DeviceOrientationClientBlackBerry.cpp: Added. * blackberry/WebCoreSupport/DeviceOrientationClientBlackBerry.h: Added. git-svn-id: http://svn.webkit.org/repository/webkit/trunk@106976 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
jchaffraix@webkit.org authored
* platform/chromium-linux/fast/forms/tabbing-input-iframe-expected.png: * platform/chromium-win/fast/events/frame-tab-focus-expected.txt: Removed. * platform/chromium/fast/events/frame-tab-focus-expected.txt: Added. * platform/chromium/test_expectations.txt: Rebaseline some old entries in test_expectations. git-svn-id: http://svn.webkit.org/repository/webkit/trunk@106975 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
commit-queue@webkit.org authored
https://bugs.webkit.org/show_bug.cgi?id=77665 Patch by Raymond Toy <rtoy@google.com> on 2012-02-07 Reviewed by Kenneth Russell. * webaudio/resources/audio-testing.js: (createImpulseBuffer): Fix bug so the buffer has the correct length. git-svn-id: http://svn.webkit.org/repository/webkit/trunk@106974 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
mdelaney@apple.com authored
https://bugs.webkit.org/show_bug.cgi?id=78000 Reviewed by Dan Bernstein. * html/canvas/CanvasRenderingContext2D.cpp: (WebCore::CanvasRenderingContext2D::setShadowColor): (WebCore::CanvasRenderingContext2D::setShadow): (WebCore::CanvasRenderingContext2D::drawImage): git-svn-id: http://svn.webkit.org/repository/webkit/trunk@106973 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
inferno@chromium.org authored
https://bugs.webkit.org/show_bug.cgi?id=77999 Reviewed by Ryosuke Niwa. Source/WebCore: Add RefPtr to protect premature deletion of this due to mutation events. Tests: fast/dom/remove-body-during-body-replacement.html fast/dom/remove-body-during-body-replacement2.html * dom/ContainerNode.cpp: (WebCore::ContainerNode::insertBefore): (WebCore::ContainerNode::replaceChild): (WebCore::ContainerNode::removeChild): (WebCore::ContainerNode::appendChild): LayoutTests: * fast/dom/remove-body-during-body-replacement-expected.txt: Added. * fast/dom/remove-body-during-body-replacement.html: Added. * fast/dom/remove-body-during-body-replacement2-expected.txt: Added. * fast/dom/remove-body-during-body-replacement2.html: Added. git-svn-id: http://svn.webkit.org/repository/webkit/trunk@106972 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
jsbell@chromium.org authored
https://bugs.webkit.org/show_bug.cgi?id=65862 Unreviewed test expectations change. Removed this expectation in r106857 but it's still timing out so restoring it for now. * platform/chromium/test_expectations.txt: git-svn-id: http://svn.webkit.org/repository/webkit/trunk@106971 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
commit-queue@webkit.org authored
https://bugs.webkit.org/show_bug.cgi?id=77996 Patch by Dana Jansens <danakj@chromium.org> on 2012-02-07 Reviewed by James Robinson. We're holding onto the last element in the Vector and then calling append(). If append() reallocates the Vector's buffer, the pointer is no longer valid. * platform/graphics/chromium/cc/CCLayerTreeHost.cpp: (WebCore::enterTargetRenderSurface): git-svn-id: http://svn.webkit.org/repository/webkit/trunk@106969 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
inferno@chromium.org authored
in splitInlines. https://bugs.webkit.org/show_bug.cgi?id=77939 Reviewed by Julien Chaffraix. Test: fast/multicol/span/split-inline-wrong-post-block-crash.html * rendering/RenderInline.cpp: (WebCore::RenderInline::splitFlow): LayoutTests: Crash due to column style not updated on post block in splitInlines. https://bugs.webkit.org/show_bug.cgi?id=77939 Reviewed by Julien Chaffraix. * fast/multicol/span/split-inline-wrong-post-block-crash-expected.txt: Added. * fast/multicol/span/split-inline-wrong-post-block-crash.html: Added. git-svn-id: http://svn.webkit.org/repository/webkit/trunk@106968 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
jchaffraix@webkit.org authored
* platform/chromium-mac-snowleopard/svg/carto.net/window-expected.txt: Removed. * platform/chromium/test_expectations.txt: Added a TEXT output to a test as seen on the bots. git-svn-id: http://svn.webkit.org/repository/webkit/trunk@106967 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-