1. 29 Oct, 2012 40 commits
    • achicu@adobe.com's avatar
      [CSS Shaders] Extract the CustomFilterParameterList to its own file · 416e51c7
      achicu@adobe.com authored
      https://bugs.webkit.org/show_bug.cgi?id=100548
      
      Reviewed by Dean Jackson.
      
      Moved all the CustomFilterParameterList related methods to their own file.
      Also made CustomFilterParameterList inherit from Vector instead of typedefing it,
      so that we can add a different operator== and a blend method to it.
      
      No new tests, just refactoring existing code.
      
      * CMakeLists.txt:
      * GNUmakefile.list.am:
      * Target.pri:
      * WebCore.gypi:
      * WebCore.xcodeproj/project.pbxproj:
      * css/StyleResolver.h:
      * platform/graphics/filters/CustomFilterOperation.cpp:
      (WebCore::CustomFilterOperation::CustomFilterOperation):
      (WebCore::CustomFilterOperation::blend):
      * platform/graphics/filters/CustomFilterOperation.h:
      (WebCore):
      (WebCore::CustomFilterOperation::operator==):
      * platform/graphics/filters/CustomFilterParameterList.cpp: Added.
      (WebCore):
      (WebCore::CustomFilterParameterList::operator==):
      (WebCore::CustomFilterParameterList::checkAlphabeticalOrder):
      (WebCore::CustomFilterParameterList::blend):
      * platform/graphics/filters/CustomFilterParameterList.h: Added.
      (WebCore):
      (CustomFilterParameterList):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@132808 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      416e51c7
    • beidson@apple.com's avatar
      Try to fix 32-bit builds after my incompletely tested m_identifier change. · 3b223845
      beidson@apple.com authored
      Not reviewed.
      
      * loader/ResourceLoader.h:
      (WebCore::ResourceLoader::identifier): Revert my "unsigned long" -> "uint64_t" change in two places.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@132807 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      3b223845
    • commit-queue@webkit.org's avatar
      [BlackBerry] Typo in WebPagePrivate::postponeDocumentRecalcStyle() · 2e90942e
      commit-queue@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=100377
      
      Patch by Mike Lattanzio <mlattanzio@rim.com> on 2012-10-29
      Reviewed by Adam Treat.
      
      Should be void, not bool.
      
      * Api/WebPage.cpp:
      (BlackBerry::WebKit::WebPagePrivate::postponeDocumentStyleRecalc):
      * Api/WebPage_p.h:
      (WebPagePrivate):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@132805 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      2e90942e
    • commit-queue@webkit.org's avatar
      [WK2][WKTR] Enable Shadow DOM at runtime if compiled with SHADOW_DOM support · d24927d6
      commit-queue@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=100668
      
      Patch by Christophe Dumez <christophe.dumez@intel.com> on 2012-10-29
      Reviewed by Kenneth Rohde Christiansen.
      
      Source/WebKit2:
      
      Add Bundle API to enable Shadow DOM functionality. This is
      now needed by WebKitTestRunner.
      
      * WebProcess/InjectedBundle/API/c/WKBundle.cpp:
      (WKBundleSetShadowDOMEnabled):
      * WebProcess/InjectedBundle/API/c/WKBundlePrivate.h:
      * WebProcess/InjectedBundle/InjectedBundle.cpp:
      (WebKit::InjectedBundle::setShadowDOMEnabled):
      (WebKit):
      * WebProcess/InjectedBundle/InjectedBundle.h:
      (InjectedBundle):
      
      Tools:
      
      Enable Shadow DOM functionality at run time in WebKitTestRunner
      if compiled with SHADOW_DOM flag set. This is needed to run
      the Shadow DOM layout tests.
      
      * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
      (WTR::InjectedBundle::beginTesting):
      
      LayoutTests:
      
      Remove Shadow DOM layout tests from the global wk2 TestExpectations
      and add it to the mac-wk2 one. EFL and GTK ports have Shadow DOM
      enabled so they don't need to be skipped for those ports. The Qt port
      is already skipping those tests in its global TestExpectations file.
      
      * platform/efl-wk2/TestExpectations:
      * platform/mac-wk2/TestExpectations:
      * platform/wk2/TestExpectations:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@132804 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      d24927d6
    • commit-queue@webkit.org's avatar
      [EFL][WK2] Fix cursor change detection in EwkViewImpl::setCursor() · 1ff348b1
      commit-queue@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=100662
      
      Patch by Christophe Dumez <christophe.dumez@intel.com> on 2012-10-29
      Reviewed by Kenneth Rohde Christiansen.
      
      Cursor change detection in EwkViewImpl::setCursor() relies on
      addresses returned by Cursor::platformCursor(). However, the
      value returned is currently assigned to a WKEinaSharedString
      instead of a raw pointer. Therefore, the address is always
      different and we keep recreating Evas Objects for the same
      cursor.
      
      * UIProcess/API/efl/EwkViewImpl.cpp:
      (EwkViewImpl::EwkViewImpl):
      (EwkViewImpl::setCursor): Call smartData() after same cursor
      detection since it is not needed if the cursor has not changed
      and it may affect performance.
      * UIProcess/API/efl/EwkViewImpl.h:
      (EwkViewImpl):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@132803 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      1ff348b1
    • ossy@webkit.org's avatar
      [Qt] Text with zero font size renders as X px sometimes, causing... · 64359240
      ossy@webkit.org authored
      [Qt] Text with zero font size renders as X px sometimes, causing fast/text/zero-font-size-2.html to fail
      https://bugs.webkit.org/show_bug.cgi?id=100115
      
      Reviewed by Noam Rosenthal.
      
      Source/WebCore:
      
      * platform/graphics/qt/FontQt.cpp:
      (WebCore::Font::drawGlyphs):
      
      LayoutTests:
      
      * platform/qt/TestExpectations: Unskip fast/text/zero-font-size-2.html.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@132802 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      64359240
    • jocelyn.turcotte@digia.com's avatar
      Coordinated Graphics: Make sure that we release images immediately when purging resources · 2e9ca0fb
      jocelyn.turcotte@digia.com authored
      https://bugs.webkit.org/show_bug.cgi?id=100661
      
      Reviewed by Noam Rosenthal.
      
      When we purge, we do both on the UI and web process at the same time,
      both are expected to release references of the other process.
      This creates problem when delaying the release of directly composited
      images.
      
      Release them immediately in that case.
      
      Fixes the tst_QQuickWebView::removeFromCanvas API test.
      
      * WebProcess/WebPage/CoordinatedGraphics/LayerTreeCoordinator.cpp:
      (WebKit::LayerTreeCoordinator::flushPendingLayerChanges):
      (WebKit::LayerTreeCoordinator::purgeReleasedImages):
      (WebKit):
      (WebKit::LayerTreeCoordinator::purgeBackingStores):
      * WebProcess/WebPage/CoordinatedGraphics/LayerTreeCoordinator.h:
      (LayerTreeCoordinator):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@132801 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      2e9ca0fb
    • commit-queue@webkit.org's avatar
      [EFL][WK2] Avoid useless assignment in EwkViewImpl::setCustomTextEncodingName() · f1fa3647
      commit-queue@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=100667
      
      Patch by Christophe Dumez <christophe.dumez@intel.com> on 2012-10-29
      Reviewed by Kenneth Rohde Christiansen.
      
      Remove useless m_customEncoding assignment in EwkViewImpl::setCustomTextEncodingName()
      since the member is anyway assigned in EwkViewImpl::customTextEncodingName().
      
      Have EwkViewImpl::setCustomTextEncodingName() take a String in argument instead
      of a const char* to make the API more C++ and since we don't need a const char*
      to assign to m_customEncoding anymore.
      
      * UIProcess/API/efl/EwkViewImpl.cpp:
      (EwkViewImpl::setCustomTextEncodingName):
      * UIProcess/API/efl/EwkViewImpl.h:
      (EwkViewImpl):
      * UIProcess/API/efl/ewk_view.cpp:
      (ewk_view_setting_encoding_custom_set):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@132800 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      f1fa3647
    • commit-queue@webkit.org's avatar
      [EFL][AC] Fix bugs preventing us from running layout tests with AC turned on · 654202a9
      commit-queue@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=100598
      
      Patch by Yael Aharon <yael.aharon@intel.com> on 2012-10-29
      Reviewed by Kenneth Rohde Christiansen.
      
      Make sure to use opengl_x11 engine when AC is turned on and X11 is in use.
      We cannot create a gl context otherwise.
      
      * MiniBrowser/efl/main.c:
      (elm_main):
      * WebKitTestRunner/efl/PlatformWebViewEfl.cpp:
      (WTR::initEcoreEvas):
      * DumpRenderTree/efl/DumpRenderTree.cpp:
      (initEcoreEvas):
      * EWebLauncher/efl/main.c:
      (windowCreate):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@132799 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      654202a9
    • commit-queue@webkit.org's avatar
      [TexMap] Make GraphicsLayerAnimation choose a proper timing function. · 2dec0842
      commit-queue@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=100623
      
      Patch by Huang Dongsung <luxtella@company100.net> on 2012-10-29
      Reviewed by Noam Rosenthal.
      
      Currently, GraphicsLayerAnimation chooses a timing function in the wrong
      way. Other GraphicsLayers choose a timing function in the similar way to
      GraphicsLayerCA::timingFunctionForAnimationValue(). The way consists of
      the following steps.
      1. Try to query the timing function of the current keyframe animation value.
      2. If the timing function of #1 is null, try to query the timing function of Animation.
      3. If the timing function of #2 is null, return CubicBezierTimingFunction::defaultTimingFunction().
      
      This patch makes GraphicsLayerAnimation choose a timing function in the same way
      to other implementations.
      
      Covered by existing animations tests.
      
      * platform/graphics/GraphicsLayerAnimation.cpp:
      (WebCore::timingFunctionForAnimationValue):
      (WebCore::GraphicsLayerAnimation::apply):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@132798 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      2dec0842
    • commit-queue@webkit.org's avatar
      Web Inspector: Toolbar overflow appears outside window · bc0112ac
      commit-queue@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=100663
      
      Patch by Patrick Dubroy <dubroy@chromium.org> on 2012-10-29
      Reviewed by Pavel Feldman.
      
      Since the search bar was removed from the toolbar, the overflow menu appears too far
      to the right, and is unreadable. Fixed this by aligning it relative to the right side
      of the window, rather than the left.
      
      * inspector/front-end/Toolbar.js:
      (WebInspector.ToolbarDropdown.prototype.show):
      * inspector/front-end/inspector.css:
      (#toolbar-dropdown .toolbar-label):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@132797 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      bc0112ac
    • rakuco@webkit.org's avatar
      [EFL][WK2] REGRESSION(r132342): fast/events/frame-tab-focus.html fails · 3015559a
      rakuco@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=100646
      
      Reviewed by Kenneth Rohde Christiansen.
      
      Tools: 
      
      * WebKitTestRunner/efl/PlatformWebViewEfl.cpp:
      (WTR::PlatformWebView::focus): Improve the check we perform to
      decide whether the focus should be taken out of the view before
      focusing it again so that we do not unnecessarily unfocus it and
      cause blur/focus events to be triggered. Instead of just verifying
      if the Evas_Object representing the view has focus, use the WK C
      API to check that the currently focused frame is not the main
      frame.
      
      LayoutTests: 
      
      * platform/efl-wk2/TestExpectations: Unskip
      fast/events/frame-tab-focus.html.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@132796 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      3015559a
    • michelangelo@webkit.org's avatar
      [CSS Shaders] Implement CustomFilterArrayParameter::blend · 187c9352
      michelangelo@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=96437
      
      Reviewed by Dean Jackson.
      
      Source/WebCore:
      
      This patch adds the missing code to blend values within
      an array() when using Custom Filters.
      
      Test: css3/filters/custom/custom-filter-array-blending.html
      
      * platform/graphics/filters/CustomFilterArrayParameter.h:
      (WebCore::CustomFilterArrayParameter::blend):
      
      LayoutTests:
      
      New tests to asses the correctness of CustomFilterArrayParameter::blend.
      
      * animations/resources/animation-test-helpers.js:
      (customFilterParameterMatch): A check for functions' parameters length has been added.
      * css3/filters/custom/custom-filter-array-blending-expected.txt: Added.
      * css3/filters/custom/custom-filter-array-blending.html: Added.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@132795 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      187c9352
    • apavlov@chromium.org's avatar
      Web Inspector: Drag and drop a URL in inspector is not working as expected · 59908921
      apavlov@chromium.org authored
      https://bugs.webkit.org/show_bug.cgi?id=100527
      
      Reviewed by Yury Semikhatsky.
      
      Inhibit custom dragstart handling when the active element is A.
      
      * inspector/front-end/ElementsTreeOutline.js:
      (WebInspector.ElementsTreeOutline.prototype._ondragstart):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@132794 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      59908921
    • mkwst@chromium.org's avatar
      Web Inspector: Error/warning count is one pixel off. · fdfff267
      mkwst@chromium.org authored
      https://bugs.webkit.org/show_bug.cgi?id=100660
      
      Reviewed by Pavel Feldman.
      
      The error/warning count div had a top padding of 6. That was one pixel
      too many.
      
      * inspector/front-end/inspector.css:
      (#error-warning-count):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@132793 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      fdfff267
    • commit-queue@webkit.org's avatar
      [BlackBerry] Fix a build error · d8495f91
      commit-queue@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=100649
      
      Patch by Robin Cao <robin.cao@torchmobile.com.cn> on 2012-10-29
      Reviewed by Kentaro Hara.
      
      r127876 changed the signature of WebCore::EventHandler::hitTestResultAtPoint()
      and this commit was later reverted. We need to update a call site in the
      BlackBerry port to make it build.
      
      * Api/WebPage.cpp:
      (BlackBerry::WebKit::WebPagePrivate::hitTestResult):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@132792 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      d8495f91
    • shinyak@chromium.org's avatar
      [Refactoring] Use isActiveInsertionPoint() instead of isInsertionPoint() · dc90debf
      shinyak@chromium.org authored
      https://bugs.webkit.org/show_bug.cgi?id=100459
      
      Reviewed by Hajime Morita.
      
      Checking InsertionPoint and its activeness with two if-statement is error-prone. We would like to
      use a utility function which checks both at once.
      
      We rewrite some lines with such function.
      
      No new tests, simple refactoring.
      
      * dom/ComposedShadowTreeWalker.cpp:
      (WebCore::ComposedShadowTreeWalker::traverseNode):
      * html/shadow/ContentDistributor.cpp:
      (WebCore::ContentDistributor::populate):
      (WebCore::ContentDistributor::distribute):
      (WebCore::ContentDistributor::distributeNodeChildrenTo):
      * html/shadow/InsertionPoint.h:
      (WebCore::isInsertionPoint): Since our convention is the argument of this kind of function should not be null,
      we would like to make it similar to the other functions.
      (WebCore::toInsertionPoint):
      (WebCore::isLowerEncapsulationBoundary):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@132791 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      dc90debf
    • commit-queue@webkit.org's avatar
      Web Inspector: Fix vertical alignment in toolbar backgrounds and overflow button. · 22a7263a
      commit-queue@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=100373
      
      Patch by Patrick Dubroy <dubroy@chromium.org> on 2012-10-29
      Reviewed by Pavel Feldman.
      
      Fix the background image for the selected toolbar item to be vertically centered.
      Make close button and toolbar overflow button vertically centered for any toolbar
      height.
      
      * inspector/front-end/Toolbar.js: Remove unused variable.
      * inspector/front-end/inspector.css:
      (.toolbar-item.toggleable):
      (body.compact .toolbar-item.toggleable):
      (.toolbar-item.toggleable.toggled-on):
      (body.compact .toolbar-label):
      (#toolbar-dropdown-arrow):
      (#close-button-left, #close-button-right):
      (.toolbar-item.close-left):
      * inspector/front-end/inspector.html:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@132790 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      22a7263a
    • commit-queue@webkit.org's avatar
      Web Inspector: Timeline: Overview bars do not correspond to timeline bars · d4e879c5
      commit-queue@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=100500
      
      Patch by Eugene Klyuchnikov <eustas.bug@gmail.com> on 2012-10-29
      Reviewed by Yury Semikhatsky.
      
      Fix: do not shorten bars by nested records of the same category.
      
      * inspector/front-end/TimelineOverviewPane.js: Check added.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@132789 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      d4e879c5
    • commit-queue@webkit.org's avatar
      Web Inspector: Timeline: make cpu-monitoring feature available only on capable browsers · a826e8b4
      commit-queue@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=100530
      
      Patch by Eugene Klyuchnikov <eustas.bug@gmail.com> on 2012-10-29
      Reviewed by Yury Semikhatsky.
      
      Motivation: cpu-monitoring feature looks like a glitch,
      when it is not supported by browser.
      
      Source/WebCore:
      
      * inspector/Inspector.json: Added capability getter to protocol.
      * inspector/InspectorClient.h: Added capability getter.
      * inspector/InspectorTimelineAgent.cpp: Proxy to request to client.
      * inspector/InspectorTimelineAgent.h: Added capability getter.
      * inspector/front-end/Settings.js: Added capability field.
      * inspector/front-end/TimelinePanel.js: Check capability.
      * inspector/front-end/inspector.js: Forward capability value.
      
      Source/WebKit/chromium:
      
      * src/InspectorClientImpl.cpp: Implemented capability getter.
      * src/InspectorClientImpl.h:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@132788 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      a826e8b4
    • antti@apple.com's avatar
      Move seamless stylesheet collecting to DocumentStyleSheetCollection · 169c61b0
      antti@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=100655
      
      Reviewed by Andreas Kling.
      
      Move the code from StyleResolver to DocumentStyleSheetCollection. StyleResolver should focus on resolving style.
      
      * css/StyleResolver.cpp:
      (WebCore::StyleResolver::StyleResolver):
              
          Use standard create() pattern.
      
      (WebCore):
      * css/StyleResolver.h:
      (StyleResolver):
      * dom/Document.cpp:
      (WebCore::Document::Document):
      * dom/DocumentStyleSheetCollection.cpp:
      (WebCore::collectActiveCSSStyleSheetsFromSeamlessParents):
              
          Since parent activeAuthorStyleSheets() contains all seamlessly inherited sheets too, this does not need to
          iterate to ancestors anymore.
      
      (WebCore):
      (WebCore::DocumentStyleSheetCollection::updateActiveStyleSheets):
      * dom/DocumentStyleSheetCollection.h:
      (WebCore::DocumentStyleSheetCollection::create):
      (DocumentStyleSheetCollection):
      (WebCore::DocumentStyleSheetCollection::styleSheetsForStyleSheetList):
      (WebCore::DocumentStyleSheetCollection::activeAuthorStyleSheets):
              
          activeAuthorStyleSheets() now includes the stylesheets inherited from the seamless parent too.
      
      (WebCore::DocumentStyleSheetCollection::needsUpdateActiveStylesheetsOnStyleRecalc):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@132787 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      169c61b0
    • kling@webkit.org's avatar
      Don't expose implementation details of StylePropertySet storage. · 07fe5a0a
      kling@webkit.org authored
      <http://webkit.org/b/100644>
      
      Reviewed by Antti Koivisto.
      
      Add a StylePropertySet::PropertyReference class, now returned by propertyAt(index).
      This will allow us to refactor the internal storage of StylePropertySet without
      breaking its API.
      
      A PropertyReference is a simple inlinable wrapper around a StylePropertySet&/index pair.
      
      * css/CSSComputedStyleDeclaration.cpp:
      * css/CSSParser.cpp:
      * css/CSSParser.h:
      * css/SVGCSSParser.cpp:
      * css/StylePropertySet.cpp:
      (WebCore::StylePropertySet::asText):
      (WebCore::StylePropertySet::mergeAndOverrideOnConflict):
      (WebCore::StylePropertySet::findPropertyWithId):
      (WebCore::StylePropertySet::reportMemoryUsage):
      * css/StylePropertySet.h:
      (StylePropertySet):
      (PropertyReference):
      (WebCore::StylePropertySet::PropertyReference::PropertyReference):
      (WebCore::StylePropertySet::PropertyReference::id):
      (WebCore::StylePropertySet::PropertyReference::isImportant):
      (WebCore::StylePropertySet::PropertyReference::isInherited):
      (WebCore::StylePropertySet::PropertyReference::cssName):
      (WebCore::StylePropertySet::PropertyReference::cssText):
      (WebCore::StylePropertySet::PropertyReference::value):
      (WebCore::StylePropertySet::PropertyReference::propertyInternal):
      (WebCore::StylePropertySet::propertyAt):
      (WebCore::StylePropertySet::propertyAtInternal):
      (WebCore):
      * css/StyleResolver.cpp:
      (WebCore::attributeStylesEqual):
      (WebCore::StyleResolver::applyProperties):
      (WebCore::StyleResolver::resolveVariables):
      * editing/ApplyStyleCommand.cpp:
      * editing/EditingStyle.cpp:
      (WebCore::EditingStyle::mergeStyle):
      (WebCore::EditingStyle::mergeStyleFromRulesForSerialization):
      * editing/Editor.cpp:
      * editing/markup.cpp:
      * page/Frame.cpp:
      * svg/SVGFontFaceElement.cpp:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@132786 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      07fe5a0a
    • ossy@webkit.org's avatar
      Unreviewed, rolling out r132782. · cbde819f
      ossy@webkit.org authored
      http://trac.webkit.org/changeset/132782
      https://bugs.webkit.org/show_bug.cgi?id=100653
      
      It made 400+ tests fail and 180 tests flakey on Qt (Requested
      by Ossy on #webkit).
      
      Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-10-29
      
      Tools:
      
      * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
      (WebCore::DumpRenderTree::resetToConsistentStateBeforeTesting):
      
      LayoutTests:
      
      * platform/qt/TestExpectations:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@132785 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      cbde819f
    • ossy@webkit.org's avatar
      Unreviewed, rolling out r132736. · 28fab5ba
      ossy@webkit.org authored
      http://trac.webkit.org/changeset/132736
      https://bugs.webkit.org/show_bug.cgi?id=100652
      
      It broke all plugin related tests on GTK and on Qt (Requested
      by Ossy on #webkit).
      
      Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-10-29
      
      * wtf/text/WTFString.cpp:
      (WTF::String::fromUTF8):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@132784 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      28fab5ba
    • tkent@chromium.org's avatar
      [Chromium] Merge LocalizedNumberICUTest into LocaleICUTest · 4a676a6c
      tkent@chromium.org authored
      https://bugs.webkit.org/show_bug.cgi?id=100648
      
      Reviewed by Kentaro Hara.
      
      LocalizedNumberICU was removed some months ago, and its features were
      merged to LocaleICU. We merge the test too.
      
      * WebKit.gypi: Remove LocalizedNumberICUTest.cpp
      * tests/LocaleICUTest.cpp:
      Move a #if because some headers are used unconditionally.
      (testDecimalSeparator): Moved from LocalizedNumberICUTest.cpp.
      (TEST_F): Ditto.
      (testNumberIsReversible): Ditto.
      (testNumbers): Ditto.
      * tests/LocalizedNumberICUTest.cpp: Removed.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@132783 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      4a676a6c
    • allan.jensen@digia.com's avatar
      [Qt] Flaky security tests · e726b583
      allan.jensen@digia.com authored
      https://bugs.webkit.org/show_bug.cgi?id=100388
      
      Reviewed by Jocelyn Turcotte.
      
      Tools:
      
      Disable text output and load a blank URL to ensure the documentLoader is cleared
      before we start dumping text for the new page. Otherwise messages from the old page
      may end up in the text output of the new test.
      
      * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
      (WebCore::DumpRenderTree::resetToConsistentStateBeforeTesting):
      
      LayoutTests:
      
      Unskip no longer flaky tests.
      
      * platform/qt/TestExpectations:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@132782 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      e726b583
    • jochen@chromium.org's avatar
      [chromium] remove remaining usages of webkit_support from the TestRunner library · 1afbceee
      jochen@chromium.org authored
      https://bugs.webkit.org/show_bug.cgi?id=100344
      
      Reviewed by Adam Barth.
      
      The most important part is to not rely on calling out to gdk/X11 to
      translate keycodes to hardware keycodes, as this is not possible inside
      the sandbox.
      
      * DumpRenderTree/DumpRenderTree.gypi:
      * DumpRenderTree/chromium/DRTTestRunner.h:
      (WebKit):
      (webkit_support):
      * DumpRenderTree/chromium/TestRunner/public/WebTestDelegate.h:
      (WebTestDelegate):
      * DumpRenderTree/chromium/TestRunner/src/CppVariant.h:
      * DumpRenderTree/chromium/TestRunner/src/EventSender.cpp:
      (WebTestRunner):
      (WebTestRunner::EventSender::doDragDrop):
      (WebTestRunner::EventSender::updateClickCountForButton):
      (WebTestRunner::EventSender::mouseDown):
      (WebTestRunner::EventSender::mouseUp):
      (WebTestRunner::EventSender::mouseMoveTo):
      (WebTestRunner::EventSender::keyDown):
      (WebTestRunner::EventSender::replaySavedEvents):
      (WebTestRunner::EventSender::contextClick):
      (WebTestRunner::EventSender::beginDragWithFiles):
      (WebTestRunner::EventSender::sendCurrentTouchEvent):
      (WebTestRunner::EventSender::handleMouseWheel):
      (WebTestRunner::EventSender::gestureEvent):
      (WebTestRunner::EventSender::gestureFlingCancel):
      (WebTestRunner::EventSender::gestureFlingStart):
      * DumpRenderTree/chromium/TestRunner/src/KeyCodeMapping.cpp: Added.
      (WebTestRunner):
      (WebTestRunner::NativeKeyCodeForWindowsKeyCode):
      * DumpRenderTree/chromium/TestRunner/src/KeyCodeMapping.h: Copied from Tools/DumpRenderTree/chromium/TestRunner/src/TestRunner.h.
      (WebTestRunner):
      * DumpRenderTree/chromium/TestRunner/src/TestDelegate.h:
      (TestDelegate):
      * DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp:
      * DumpRenderTree/chromium/TestRunner/src/TestRunner.h:
      * DumpRenderTree/chromium/TestRunner/src/WebTestInterfaces.cpp:
      (WebTestInterfaces::Internal):
      (WebTestRunner::WebTestInterfaces::Internal::getCurrentTimeInMillisecond):
      (WebTestRunner):
      (WebTestRunner::WebTestInterfaces::Internal::getAbsoluteWebStringFromUTF8Path):
      * DumpRenderTree/chromium/WebViewHost.cpp:
      (WebViewHost::getCurrentTimeInMillisecond):
      (WebViewHost::getAbsoluteWebStringFromUTF8Path):
      * DumpRenderTree/chromium/WebViewHost.h:
      (WebViewHost):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@132781 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      1afbceee
    • jocelyn.turcotte@digia.com's avatar
      [WK2] Enable delegated scrolling as soon as the FrameView is created when using fixed layout · 2a01b626
      jocelyn.turcotte@digia.com authored
      https://bugs.webkit.org/show_bug.cgi?id=100383
      
      Reviewed by Kenneth Rohde Christiansen.
      
      Scroll requests and PageTransitionViewportReady messages depend on
      delegated scrolling being set properly on the FrameView to behave
      properly. Since we were waiting for the viewport information to be
      ready before setting the flag this could cause those messages to be avoided.
      
      This patch takes most of the flag set by setResizesToContentsUsingLayoutSize
      and apply them as soon as possible in WebPage::setUseFixedLayout and
      WebFrameLoaderClient::transitionToCommittedForNewPage.
      
      The behavior should be the same except for the following settings which are
      now set outside of USE(TILED_BACKING_STORE) if we're using fixed layout:
      - setAcceleratedCompositingForFixedPositionEnabled
      - setFixedElementsLayoutRelativeToFrame
      - setFixedPositionCreatesStackingContext
      
      This fixes the tst_QQuickWebView::scrollRequest auto test and improves the
      reliability of the loadVisuallyCommitted signal with pages loaded from disk.
      
      * WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:
      (WebKit::WebFrameLoaderClient::transitionToCommittedForNewPage):
      * WebProcess/WebPage/WebPage.cpp:
      (WebKit::WebPage::sendViewportAttributesChanged):
      (WebKit::WebPage::setUseFixedLayout):
      (WebKit::WebPage::setFixedLayoutSize):
      * WebProcess/WebPage/WebPage.h:
      (WebPage):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@132780 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      2a01b626
    • podivilov@chromium.org's avatar
      2012-10-29 Pavel Podivilov <podivilov@google.com> · 7f5e172c
      podivilov@chromium.org authored
              [Chromium] Test expectation update.
      
              Unreviewed, mark recently added audiobuffersource-loop-points.html test as failing on windows.
      
              * platform/chromium/TestExpectations:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@132779 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      7f5e172c
    • tkent@chromium.org's avatar
      [Chromium] Rename LocalizedDateICUTest.cpp to LocaleICUTest.cpp · 6e29cdbf
      tkent@chromium.org authored
      https://bugs.webkit.org/show_bug.cgi?id=100643
      
      Reviewed by Kentaro Hara.
      
      LocalizedDateICU was removed some months ago, and LocalizedDateICUTest
      actually had tests for LocaleICU.
      
      * WebKit.gypi:
      * tests/LocaleICUTest.cpp:
      - Renamed from Source/WebKit/chromium/tests/LocalizedDateICUTest.cpp.
      - Rename LocalizedDateICUTest class to LocaleICUTest.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@132778 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      6e29cdbf
    • tkent@chromium.org's avatar
      Move LocaleWin.{cpp,h} to platform/text/win/ · 353f517d
      tkent@chromium.org authored
      https://bugs.webkit.org/show_bug.cgi?id=100641
      
      Reviewed by Kentaro Hara.
      
      We have platform/text/win/ directory. Windows-specific files should be
      in it.
      Note that these files are used only in Chromium-win for now.
      
      No new tests. This doesn't change any behavior.
      
      * WebCore.gyp/WebCore.gyp: Fix path names.
      * WebCore.gypi: Ditto.
      * platform/text/win/LocaleWin.cpp: Renamed from Source/WebCore/platform/text/LocaleWin.cpp.
      * platform/text/win/LocaleWin.h: Renamed from Source/WebCore/platform/text/LocaleWin.h.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@132777 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      353f517d
    • rakuco@webkit.org's avatar
      Unreviewed build fix after r132709. · 21f152bd
      rakuco@webkit.org authored
      * Shared/WebMemorySampler.cpp: Include unistd.h for getpid(3).
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@132776 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      21f152bd
    • tkent@chromium.org's avatar
      [Chromium-linux] Fix build. · 6388b4d1
      tkent@chromium.org authored
      * tests/LocalizedNumberICUTest.cpp:
      (testNumberIsReversible): Rename an argument.
      (testDecimalSeparator): Ditto.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@132775 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      6388b4d1
    • tkent@chromium.org's avatar
      Rename Localizer to Locale · 0c53f9c8
      tkent@chromium.org authored
      https://bugs.webkit.org/show_bug.cgi?id=100634
      
      Reviewed by Kentaro Hara.
      
      Source/WebCore:
      
      - Rename Localizer class to Locale
      - Rename localizer with locale in variable names
      - Rename localizer with locale in function names
      
      No new tests. This doesn't make any behavior changes.
      
      * dom/Document.h:
      (WebCore): Declare Locale instead of Localizer.
      (Document):
      - Rename getCachedLocalizer to getCachedLocale.
      - Rename LocaleToLocalizerMap to LocaleIdentifierToLocaleMap.
      - Rename m_localizerCache to m_localeCache.
      * dom/Document.cpp:
      (WebCore::Document::getCachedLocale): Follow renamings.
      * dom/Element.h:
      (WebCore): Declare Locale instead of Localizer.
      (Element): Rename localizer() to locale().
      * dom/Element.cpp:
      (WebCore::Element::locale): Follow renamings.
      
      * html/BaseDateAndTimeInputType.cpp:
      (WebCore::BaseDateAndTimeInputType::localizeValue): Ditto.
      (WebCore::BaseDateAndTimeInputType::convertFromVisibleValue): Ditto.
      * html/BaseMultipleFieldsDateAndTimeInputType.cpp:
      (WebCore::BaseMultipleFieldsDateAndTimeInputType::updateInnerTextValue): Ditto.
      * html/DateInputType.cpp:
      (WebCore::DateInputType::fixedPlaceholder): Ditto.
      (WebCore::DateInputType::setupLayoutParameters): Ditto.
      * html/DateTimeInputType.cpp:
      (WebCore::DateTimeInputType::setupLayoutParameters): Ditto.
      * html/DateTimeLocalInputType.cpp:
      (WebCore::DateTimeLocalInputType::setupLayoutParameters): Ditto.
      * html/MonthInputType.cpp:
      (WebCore::MonthInputType::setupLayoutParameters): Ditto.
      * html/NumberInputType.cpp:
      (WebCore::NumberInputType::localizeValue): Ditto.
      (WebCore::NumberInputType::convertFromVisibleValue): Ditto.
      * html/TimeInputType.cpp:
      (WebCore::TimeInputType::localizeValue): Ditto.
      (WebCore::TimeInputType::setupLayoutParameters): Ditto.
      
      * html/shadow/DateTimeEditElement.h:
      (WebCore): Declare Locale instead of Localizer.
      (LayoutParameters): Rename localizer data member to locale.
      (WebCore::DateTimeEditElement::LayoutParameters::LayoutParameters): Follow renamings.
      * html/shadow/DateTimeEditElement.cpp:
      (WebCore::DateTimeEditBuilder::visitField): Ditto.
      * html/shadow/DateTimeNumericFieldElement.h:
      (DateTimeNumericFieldElement): Rename localizerForOwner to localeForOwner.
      * html/shadow/DateTimeNumericFieldElement.cpp:
      (WebCore::DateTimeNumericFieldElement::formatValue): Follow renamings.
      (WebCore::DateTimeNumericFieldElement::handleKeyboardEvent): Ditto.
      (WebCore::DateTimeNumericFieldElement::localeForOwner): Ditto.
      * page/PagePopupClient.h:
      (WebCore): Declare Locale instead of Localizer.
      (PagePopupClient): Rename localizer member function to locale.
      * page/PagePopupController.cpp:
      (WebCore::PagePopupController::localizeNumberString): Follow renamings.
      
      * platform/text/PlatformLocale.cpp: Rename the Localizer class to Locale.
      (DateTimeStringBuilder):
      (WebCore::DateTimeStringBuilder::DateTimeStringBuilder):
      (WebCore::Locale::~Locale):
      (WebCore::Locale::setLocaleData): Renamed from setLocalizerData.
      (WebCore::Locale::convertToLocalizedNumber):
      (WebCore::Locale::detectSignAndGetDigitRange):
      (WebCore::Locale::matchedDecimalSymbolIndex):
      (WebCore::Locale::convertFromLocalizedNumber):
      (WebCore::Locale::localizedDecimalSeparator):
      (WebCore::Locale::dateTimeFormatWithSeconds):
      (WebCore::Locale::dateTimeFormatWithoutSeconds):
      (WebCore::Locale::formatDateTime):
      * platform/text/PlatformLocale.h: Update the ifndef macro.
      (Locale): Renamed from Localizer. Also, renamed the followings:
       - initializeLocalizerData -> initializeLocaleData
       - setLocalizerData -> setLocaleData
       - m_hasLocalizerData -> m_hasLocaleData
      (WebCore::Locale::Locale):
      (WebCore::Locale::createDefault):
      * platform/text/LocaleICU.cpp: Follow renamings.
      * platform/text/LocaleICU.h: Ditto.
      * platform/text/LocaleNone.cpp: Ditto.
      * platform/text/LocaleWin.cpp: Ditto.
      * platform/text/LocaleWin.h: Ditto.
      * platform/text/mac/LocaleMac.h: Ditto.
      * platform/text/mac/LocaleMac.mm: Ditto.
      
      Source/WebKit/chromium:
      
      * src/ColorChooserUIController.h:
      (ColorChooserUIController):
      Rename m_localizer to m_locale, and follow other renamings.
      * src/ColorChooserUIController.cpp:
      (WebKit::ColorChooserUIController::ColorChooserUIController): Follow renamings.
      (WebKit::ColorChooserUIController::locale): Ditto.
      * src/DateTimeChooserImpl.h:
      (DateTimeChooserImpl):
      Rename m_localizer to m_locale, and follow other renamings.
      * src/DateTimeChooserImpl.cpp:
      (WebKit::DateTimeChooserImpl::DateTimeChooserImpl): Follow renamings.
      (WebKit::DateTimeChooserImpl::writeDocument): Ditto.
      (WebKit::DateTimeChooserImpl::locale): Ditto.
      * tests/LocaleMacTest.cpp:
      (LocaleMacTest::formatTime): Ditto.
      (testNumberIsReversible): Ditto.
      * tests/LocalizedNumberICUTest.cpp:
      (testNumberIsReversible): Ditto.
      (testDecimalSeparator): Ditto.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@132774 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      0c53f9c8
    • mkwst@chromium.org's avatar
      Web Inspector: Error messages lines in console are 1px taller than regular messages · eedd4655
      mkwst@chromium.org authored
      https://bugs.webkit.org/show_bug.cgi?id=100521
      
      Reviewed by Pavel Feldman.
      
      The inspector is adding a 1px bottom border to list elements inside
      a disclosure list. This is unnecessary in the current layout; it's
      causing console messages with stack traces to be one pixel taller than
      other console messages, which this patch fixes.
      
      As a drive-by, this patch also adjusts the disclosure triangle's
      position to match.
      
      * inspector/front-end/inspector.css:
      (.outline-disclosure li):
      (.outline-disclosure li.parent::before):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@132773 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      eedd4655
    • mkwst@chromium.org's avatar
      Web Inspector: The bubble for repeated errors is misplaced. · 85a6730f
      mkwst@chromium.org authored
      https://bugs.webkit.org/show_bug.cgi?id=100525
      
      Reviewed by Pavel Feldman.
      
      The repeated-message bubble is displayed as an inline-block element,
      which works well as long as no stack trace is present. If present, the
      message is wrapped in an 'ol' element displayed as a block, which pushes
      itself down to the next line.
      
      To avoid that issue, this patch switches the wrapper element to flexbox,
      glorious flexbox.
      
      * inspector/front-end/inspector.css:
      (.console-message .bubble):
      (.repeated-message .outline-disclosure):
      (.filter-all .console-log-level.repeated-message, .filter-logs .console-log-level.repeated-message):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@132772 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      85a6730f
    • tkent@chromium.org's avatar
      [Chromium] Test expectation update. · 7a70ee47
      tkent@chromium.org authored
      https://bugs.webkit.org/show_bug.cgi?id=99818
      
      The failure of month-multiple-fields-keyboard-events.html on SnowLeopard
      and XP is expected.
      
      - OS X SnowLeopard
        The month forma is "yyyy MMMM" on SnowLoepard though it's "MMMM yyyy"
        on other platforms.
      
      - Windows XP
        It doesn't support the lang-attribute-aware-form-control-UI testing
      feature.
      
      * platform/chromium-mac-snowleopard/fast/forms/month-multiple-fields/month-multiple-fields-keyboard-events-expected.txt: Copied from LayoutTests/platform/chromium-win-xp/fast/forms/month-multiple-fields/month-multiple-fields-keyboard-events-expected.txt.
      * platform/chromium-win-xp/fast/forms/month-multiple-fields/month-multiple-fields-keyboard-events-expected.txt:
      * platform/chromium/TestExpectations:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@132771 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      7a70ee47
    • commit-queue@webkit.org's avatar
      [EFL] Skip 2 tests failing due to missing drag'n drop support · 46131ea6
      commit-queue@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=100638
      
      Unreviewed EFL gardening.
      
      Skip 2 test cases failing due to missing drag'n drop support
      in EFL port.
      
      Patch by Christophe Dumez <christophe.dumez@intel.com> on 2012-10-29
      
      * platform/efl/TestExpectations:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@132770 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      46131ea6
    • commit-queue@webkit.org's avatar
      [EFL] Skip 2 jquery tests crashing after r132757 · e34b24c0
      commit-queue@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=100637
      
      Unreviewed EFL gardening.
      
      Skip 2 jquery test cases that started crashing after
      r132757.
      
      Patch by Christophe Dumez <christophe.dumez@intel.com> on 2012-10-29
      
      * platform/efl/TestExpectations:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@132769 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      e34b24c0
    • apavlov@chromium.org's avatar
      Web Inspector: [Styles] Handle non-parsedOk properties as inactive ones · 4f3532d2
      apavlov@chromium.org authored
      https://bugs.webkit.org/show_bug.cgi?id=100119
      
      Reviewed by Vsevolod Vlasov.
      
      Source/WebCore:
      
      Test: inspector/styles/inactive-properties.html
      
      * inspector/front-end/StylesSidebarPane.js:
      (WebInspector.StylesSidebarPane.createExclamationMark):
      (WebInspector.ComputedStylePropertiesSection.prototype.rebuildComputedTrace):
      * inspector/front-end/elementsPanel.css:
      (.styles-section.computed-style .properties li.not-parsed-ok):
      (.styles-section.computed-style .properties li.not-parsed-ok img.exclamation-mark):
      (.styles-section .properties .not-parsed-ok):
      
      LayoutTests:
      
      * http/tests/inspector/elements-test.js:
      (initialize_ElementTest.InspectorTest.dumpStyleTreeItem):
      * inspector/styles/inactive-properties-expected.txt: Added.
      * inspector/styles/inactive-properties.html: Added.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@132768 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      4f3532d2