1. 19 Aug, 2013 1 commit
    • darin@apple.com's avatar
      <https://webkit.org/b/119949> Factor Clipboard into drag and non-drag parts · ec40fe3e
      darin@apple.com authored
      Reviewed by Sam Weinig.
      
      * dom/Clipboard.cpp:
      (WebCore::Clipboard::Clipboard): Move the ClipboardType argument to go after the pasteboard.
      Initialize strings more efficiently. Put drag-specific data members inside an if statement.
      Replace m_clipboardType with m_forDrag.
      (WebCore::Clipboard::createForCopyAndPaste): Moved function up to be close to constructor.
      Removed explicit clipboard type since constructor now defaults to copy and paste style.
      (WebCore::Clipboard::setAccessPolicy): Tweaked comment.
      (WebCore::Clipboard::getData): Put drag-specific code inside #if ENABLE(DRAG_SUPPORT).
      (WebCore::Clipboard::setData): Ditto.
      (WebCore::Clipboard::files): Ditto.
      (WebCore::Clipboard::dropEffect): Added trivial non-drag versions of these functions to
      be used when !ENABLE(DRAG_SUPPORT).
      (WebCore::Clipboard::setDropEffect): Ditto.
      (WebCore::Clipboard::effectAllowed): Ditto.
      (WebCore::Clipboard::setEffectAllowed): Ditto.
      (WebCore::Clipboard::createForDragAndDrop): Renamed Clipboard::create that takes DragData
      to this, and kep the overload that does not as well. Made the DragData argument a const&.
      (WebCore::Clipboard::canSetDragImage): Moved down here since it is drag-specific.
      (WebCore::Clipboard::updateDragImage): Use m_shouldUpdateDragImage directly insted of
      calling a dragStarted function.
      (WebCore::dragOpFromIEOp): Moved this function down here to the drag-specific section.
      (WebCore::IEOpFromDragOp): Ditto.
      (WebCore::Clipboard::sourceOperation): Ditto.
      (WebCore::Clipboard::destinationOperation): Ditto.
      (WebCore::Clipboard::setSourceOperation): Ditto.
      (WebCore::Clipboard::setDestinationOperation): Ditto.
      
      * dom/Clipboard.h: Removed unneeded include of "Node.h" and added and removed forward
      class declarations as required. Removed non-helpful comment. Made ClipboardType a private
      implementation detail. Moved functions that are not part of the DOM API down to a separate
      section lower down in the class, and sorted the functions to match the order they appear
      in the IDL file. Removed isForCopyAndPaste and isForDragAndDrop. Changed dropEffect and
      effectAllowed to not be inlined. Moved the long comment before canSetDragImage into the
      implementation since it's an implementation detail. Since this class is no longer polymorphic,
      use only private, not protected. Make m_dragImageElement an Element, not a Node.
      
      * dom/Clipboard.idl: Removed flags to tell bindings how to deal with null strings, since
      these string properties can never return null strings anyway.
      
      * page/DragController.cpp:
      (WebCore::DragController::dragExited): Updated to call the new createForDragAndDrop function.
      (WebCore::DragController::performDrag): Ditto.
      (WebCore::DragController::tryDHTMLDrag): Ditto.
      
      * platform/mac/ClipboardMac.mm: Added now-needed include of Element.h since Clipboard.h no
      longer includes it.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@154260 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      ec40fe3e
  2. 17 Aug, 2013 5 commits
    • akling@apple.com's avatar
      <https://webkit.org/b/119954> Page::dragCaretController() should return a reference. · b5297527
      akling@apple.com authored
      Reviewed by Antti Koivisto.
      
      Page::m_dragCaretController is never null.
      
      * dom/Document.cpp:
      (WebCore::Document::nodeChildrenWillBeRemoved):
      (WebCore::Document::nodeWillBeRemoved):
      * page/DragController.cpp:
      (WebCore::DragController::cancelDrag):
      (WebCore::DragController::dragEnded):
      (WebCore::DragController::tryDocumentDrag):
      (WebCore::DragController::dispatchTextInputEventFor):
      (WebCore::DragController::concludeEditDrag):
      (WebCore::DragController::placeDragCaret):
      * page/Page.h:
      (WebCore::Page::dragCaretController):
      * rendering/RenderBlock.cpp:
      (WebCore::RenderBlock::paintCaret):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@154238 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      b5297527
    • darin@apple.com's avatar
      <https://webkit.org/b/119948> Change drag-specific clipboard writing in... · 6535ea23
      darin@apple.com authored
      <https://webkit.org/b/119948> Change drag-specific clipboard writing in DragController to go straight to Pasteboard, not forward through Clipboard
      
      Reviewed by Andreas Kling.
      
      * dom/Clipboard.cpp: Removed writeRange, writePlainText, and writeURL functions.
      All three are just unneeded forwarding to pasteboard.
      * dom/Clipboard.h: Ditto.
      
      * page/DragController.cpp:
      (WebCore::DragController::startDrag): Move the logic in here. Later we might
      want to straighten this out a bit, perhaps using functions in Editor, but it's
      not much code so fine to just have it here for now.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@154231 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      6535ea23
    • darin@apple.com's avatar
      <https://webkit.org/b/119942> Remove unnecessary uses of Element::ownerDocument · a9232041
      darin@apple.com authored
      Reviewed by Andreas Kling.
      
      The Element::document is a simpler faster alternative to Element::ownerDocument.
      The only behavior difference between the two is that ownerDocument returns 0 when
      called on a Document.
      
      * html/HTMLMediaElement.cpp:
      (WebCore::HTMLMediaElement::supportsFocus): Call document instead of ownerDocument.
      (WebCore::HTMLMediaElement::mediaPlayerOwningDocument): Removed null checking of
      document and call to ownerDocument, since ownerDocument will never return non-null
      if document returns null.
      (WebCore::HTMLMediaElement::mediaPlayerSawUnsupportedTracks): Call document instead
      of ownerDocument.
      
      * inspector/DOMEditor.cpp:
      (WebCore::DOMEditor::SetOuterHTMLAction::perform): Call document instead of ownerDocument.
      
      * inspector/InspectorCSSAgent.cpp:
      (WebCore::InspectorCSSAgent::getMatchedStylesForNode): Call document instead of ownerDocument.
      (WebCore::InspectorCSSAgent::forcePseudoState): Call document instead of ownerDocument.
      (WebCore::InspectorCSSAgent::resetPseudoStates): Call document instead of ownerDocument.
      
      * inspector/InspectorDOMAgent.cpp:
      (WebCore::InspectorDOMAgent::setOuterHTML): Call document instead of expression that
      does the same thing in a roundabout way.
      (WebCore::InspectorDOMAgent::focusNode): Call document instead of ownerDocument.
      (WebCore::InspectorDOMAgent::resolveNode): Call document instead of expression that
      does the same thing in a roundabout way.
      
      * page/DragController.cpp:
      (WebCore::DragController::concludeEditDrag): Call document instead of ownerDocument.
      
      * svg/SVGElementInstance.cpp:
      (WebCore::SVGElementInstance::ownerDocument): Call document instead of ownerDocument.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@154225 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      a9232041
    • darin@apple.com's avatar
      <https://webkit.org/b/119941> Make Page::dragController return a reference · a5e48bb2
      darin@apple.com authored
      Reviewed by Andreas Kling.
      
      Source/WebCore:
      
      * page/Page.h:
      (WebCore::Page::dragController): Return a reference instead of a pointer.
      
      * page/DragController.cpp:
      (WebCore::DragController::concludeEditDrag):
      * page/EventHandler.cpp:
      (WebCore::EventHandler::eventMayStartDrag):
      (WebCore::EventHandler::updateDragSourceActionsAllowed):
      (WebCore::EventHandler::handleDrag):
      * page/mac/EventHandlerMac.mm:
      (WebCore::EventHandler::passSubframeEventToSubframe):
      Updated call sites.
      
      Source/WebKit/gtk:
      
      * webkit/webkitwebview.cpp:
      (dragExitedCallback):
      (webkit_web_view_drag_motion):
      (webkit_web_view_drag_data_received):
      (webkit_web_view_drag_drop):
      Updated call sites.
      
      Source/WebKit/mac:
      
      * WebView/WebFrameView.mm:
      (-[WebFrameView _setDocumentView:]):
      * WebView/WebHTMLView.mm:
      (-[WebHTMLView draggingSourceOperationMaskForLocal:]):
      (-[WebHTMLView namesOfPromisedFilesDroppedAtDestination:]):
      * WebView/WebView.mm:
      (-[WebView _setInitiatedDrag:]):
      (-[WebView draggingEntered:]):
      (-[WebView draggingUpdated:]):
      (-[WebView draggingExited:]):
      (-[WebView performDragOperation:]):
      (-[WebView moveDragCaretToPoint:]):
      (-[WebView removeDragCaret]):
      Updated call sites.
      
      Source/WebKit/qt:
      
      * WebCoreSupport/DragClientQt.cpp:
      (WebCore::DragClientQt::startDrag):
      * WebCoreSupport/QWebPageAdapter.cpp:
      (QWebPageAdapter::dragEntered):
      (QWebPageAdapter::dragLeaveEvent):
      (QWebPageAdapter::dragUpdated):
      (QWebPageAdapter::performDrag):
      Updated call sites.
      
      Source/WebKit/win:
      
      * WebCoreSupport/WebDragClient.cpp:
      (WebDragClient::startDrag):
      * WebView.cpp:
      (WebView::keyStateToDragOperation):
      (WebView::DragEnter):
      (WebView::DragOver):
      (WebView::DragLeave):
      (WebView::Drop):
      Updated call sites.
      
      Source/WebKit2:
      
      * WebProcess/WebPage/WebPage.cpp:
      (WebKit::WebPage::performDragControllerAction):
      (WebKit::WebPage::dragEnded):
      Updated call sites.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@154224 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      a5e48bb2
    • akling@apple.com's avatar
      <https://webkit.org/b/119903> Make Settings ref-counted (and let Frame keep a ref!) · 17523501
      akling@apple.com authored
      Reviewed by Geoff Garen.
      
      Let Frame hold a RefPtr<Settings> so Frame::settings() isn't forced to go through Page.
      It now also returns a reference, as it can never be null.
      
      Removed 8.8 million lines of null-checking as a result.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@154219 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      17523501
  3. 16 Aug, 2013 2 commits
    • akling@apple.com's avatar
      <https://webkit.org/b/119866> Frame::eventHandler() should return a reference. · d18f79bb
      akling@apple.com authored
      Reviewed by Anders Carlsson.
      
      Frame::m_eventHandler is never null.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@154178 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      d18f79bb
    • antti@apple.com's avatar
      <https://webkit.org/b/119865> Parent pointer and shadow root host pointer should not be shared · f269b27a
      antti@apple.com authored
      Reviewed by Andreas Kling.
      
      Node::m_parentOrShadowHostNode is currently used both as the parent pointer for regular nodes and as the host
      pointer for ShadowRoots. This is confusing. It is also slow as it introduces a branch to all code paths that 
      want to traverse ancestors normally, without leaving the shadow trees. This is much more popular than
      traversing through.
              
      This patch makes the Node have a pure parent pointer only and adds the host element pointer as a separate
      member in ShadowRoot. This eliminates the ShadowRoot test branch from Node::parentNode() as the pointer is
      now always null in the root node.
              
      ShadowRoot grows by a pointer. This is not significant as there are few ShadowRoots compared to Nodes.
      
      * css/StyleResolver.cpp:
      (WebCore::StyleResolver::pushParentShadowRoot):
      (WebCore::StyleResolver::popParentShadowRoot):
      * dom/Attr.cpp:
      (WebCore::Attr::createTextChild):
      * dom/ComposedShadowTreeWalker.cpp:
      (WebCore::ComposedShadowTreeWalker::traverseParentBackToShadowRootOrHost):
      * dom/ContainerNode.cpp:
      (WebCore::ContainerNode::insertBeforeCommon):
      (WebCore::ContainerNode::removeBetween):
      * dom/ContainerNodeAlgorithms.cpp:
      (WebCore::ChildNodeInsertionNotifier::notifyDescendantInsertedIntoDocument):
      (WebCore::ChildNodeRemovalNotifier::notifyDescendantRemovedFromDocument):
      * dom/ContainerNodeAlgorithms.h:
      (WebCore::appendChildToContainer):
      (WebCore::Private::addChildNodesToDeletionQueue):
      * dom/Document.h:
      (WebCore::Node::Node):
      * dom/Element.cpp:
      (WebCore::Element::addShadowRoot):
      (WebCore::Element::removeShadowRoot):
      * dom/ElementRareData.h:
      (WebCore::ElementRareData::releasePseudoElement):
      * dom/EventPathWalker.cpp:
      (WebCore::EventPathWalker::moveToParent):
      * dom/EventRetargeter.cpp:
      (WebCore::determineDispatchBehavior):
      * dom/EventRetargeter.h:
      (WebCore::EventRetargeter::eventTargetRespectingTargetRules):
      * dom/Node.cpp:
      (WebCore::Node::shadowHost):
      (WebCore::Node::deprecatedShadowAncestorNode):
      (WebCore::Node::parentOrShadowHostElement):
      * dom/Node.h:
      (WebCore::Node::hasTreeSharedParent):
              
          Shadow host elements refs the ShadowRoot. There is no reason to use TreeShared to keep it alive.
      
      (WebCore::Node::setParentNode):
      (WebCore::Node::parentNode):
      (WebCore::Node::parentNodeGuaranteedHostFree):
      * dom/PseudoElement.cpp:
      (WebCore::PseudoElement::PseudoElement):
      * dom/ShadowRoot.cpp:
      (WebCore::ShadowRoot::ShadowRoot):
      (WebCore::ShadowRoot::setInnerHTML):
      (WebCore::ShadowRoot::setApplyAuthorStyles):
      (WebCore::ShadowRoot::setResetStyleInheritance):
      * dom/ShadowRoot.h:
              
          Rename host() -> hostElement() for clarity.
      
      (WebCore::Node::parentOrShadowHostNode):
      * dom/Text.cpp:
      (WebCore::isSVGShadowText):
      * dom/TreeScope.cpp:
      (WebCore::TreeScope::focusedElement):
      * html/shadow/ContentDistributor.cpp:
      (WebCore::ContentDistributor::ensureDistribution):
      * html/shadow/InsertionPoint.cpp:
      (WebCore::InsertionPoint::insertedInto):
      (WebCore::InsertionPoint::removedFrom):
      (WebCore::InsertionPoint::parseAttribute):
      * page/DragController.cpp:
      (WebCore::asFileInput):
      * page/EventHandler.cpp:
      (WebCore::EventHandler::handleMousePressEvent):
      (WebCore::instanceAssociatedWithShadowTreeElement):
      * page/FocusController.cpp:
      (WebCore::FocusNavigationScope::owner):
      * rendering/RenderBlock.cpp:
      (WebCore::RenderBlock::hasLineIfEmpty):
      * rendering/RenderLayer.cpp:
      (WebCore::rendererForScrollbar):
      * svg/SVGElementInstance.h:
      (WebCore::SVGElementInstance::setParentNode):
                  
          Renamed so it works with appendChildToContainer template.
      
      * svg/SVGStyledElement.cpp:
      (WebCore::SVGStyledElement::title):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@154165 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      f269b27a
  4. 15 Aug, 2013 2 commits
    • andersca@apple.com's avatar
      <https://webkit.org/b/119859> Frame::loader() should return a reference · df550b96
      andersca@apple.com authored
      Reviewed by Andreas Kling.
      
      Source/WebCore:
      
      * Modules/websockets/WebSocketChannel.cpp:
      (WebCore::WebSocketChannel::willOpenSocketStream):
      * WebCore.xcodeproj/project.pbxproj:
      * accessibility/AccessibilityObject.cpp:
      (WebCore::AccessibilityObject::press):
      * accessibility/mac/WebAccessibilityObjectWrapperMac.mm:
      (-[WebAccessibilityObjectWrapper remoteAccessibilityParentObject]):
      * bindings/ScriptControllerBase.cpp:
      (WebCore::ScriptController::canExecuteScripts):
      * bindings/js/ScriptController.cpp:
      (WebCore::ScriptController::initScript):
      * css/CSSFontSelector.cpp:
      (WebCore::CSSFontSelector::beginLoadTimerFired):
      * dom/DOMImplementation.cpp:
      (WebCore::DOMImplementation::createDocument):
      * dom/Document.cpp:
      (WebCore::Document::Document):
      (WebCore::Document::setVisualUpdatesAllowed):
      (WebCore::Document::updateTitle):
      (WebCore::Document::open):
      (WebCore::Document::explicitClose):
      (WebCore::Document::implicitClose):
      (WebCore::Document::userAgent):
      (WebCore::Document::canNavigate):
      (WebCore::Document::processHttpEquiv):
      (WebCore::Document::referrer):
      (WebCore::Document::documentDidResumeFromPageCache):
      (WebCore::Document::openSearchDescriptionURL):
      (WebCore::Document::finishedParsing):
      (WebCore::Document::addIconURL):
      (WebCore::Document::initSecurityContext):
      (WebCore::Document::updateURLForPushOrReplaceState):
      (WebCore::Document::loadEventDelayTimerFired):
      (WebCore::Document::loader):
      (WebCore::Document::decrementActiveParserCount):
      * history/CachedFrame.cpp:
      (WebCore::CachedFrameBase::CachedFrameBase):
      (WebCore::CachedFrameBase::restore):
      (WebCore::CachedFrame::CachedFrame):
      (WebCore::CachedFrame::open):
      (WebCore::CachedFrame::destroy):
      * history/PageCache.cpp:
      (WebCore::logCanCacheFrameDecision):
      (WebCore::logCanCachePageDecision):
      (WebCore::PageCache::canCachePageContainingThisFrame):
      (WebCore::PageCache::canCache):
      * html/HTMLAnchorElement.cpp:
      (WebCore::HTMLAnchorElement::handleClick):
      * html/HTMLAppletElement.cpp:
      (WebCore::HTMLAppletElement::updateWidget):
      * html/HTMLElement.cpp:
      (WebCore::HTMLElement::rendererIsNeeded):
      * html/HTMLEmbedElement.cpp:
      (WebCore::HTMLEmbedElement::updateWidget):
      * html/HTMLFormElement.cpp:
      (WebCore::HTMLFormElement::prepareForSubmission):
      (WebCore::HTMLFormElement::submit):
      * html/HTMLFrameElementBase.cpp:
      (WebCore::HTMLFrameElementBase::openURL):
      * html/HTMLFrameOwnerElement.cpp:
      (WebCore::HTMLFrameOwnerElement::disconnectContentFrame):
      * html/HTMLFrameSetElement.cpp:
      (WebCore::HTMLFrameSetElement::insertedInto):
      (WebCore::HTMLFrameSetElement::removedFrom):
      * html/HTMLHtmlElement.cpp:
      (WebCore::HTMLHtmlElement::insertedByParser):
      * html/HTMLMediaElement.cpp:
      (WebCore::HTMLMediaElement::createRenderer):
      (WebCore::HTMLMediaElement::attach):
      (WebCore::HTMLMediaElement::loadResource):
      (WebCore::HTMLMediaElement::getPluginProxyParams):
      (WebCore::HTMLMediaElement::createMediaPlayerProxy):
      (WebCore::HTMLMediaElement::updateWidget):
      (WebCore::HTMLMediaElement::mediaPlayerReferrer):
      (WebCore::HTMLMediaElement::mediaPlayerUserAgent):
      * html/HTMLObjectElement.cpp:
      (WebCore::HTMLObjectElement::parametersForPlugin):
      (WebCore::HTMLObjectElement::updateWidget):
      * html/HTMLPlugInImageElement.cpp:
      (WebCore::HTMLPlugInImageElement::isImageType):
      (WebCore::HTMLPlugInImageElement::wouldLoadAsNetscapePlugin):
      (WebCore::HTMLPlugInImageElement::restartSimilarPlugIns):
      * html/HTMLVideoElement.cpp:
      (WebCore::HTMLVideoElement::setDisplayMode):
      * html/ImageDocument.cpp:
      (WebCore::ImageDocumentParser::appendBytes):
      (WebCore::ImageDocumentParser::finish):
      (WebCore::ImageDocument::createDocumentStructure):
      * html/MediaDocument.cpp:
      (WebCore::MediaDocumentParser::createDocumentStructure):
      * html/PluginDocument.cpp:
      (WebCore::PluginDocumentParser::createDocumentStructure):
      (WebCore::PluginDocumentParser::appendBytes):
      (WebCore::PluginDocument::detach):
      (WebCore::PluginDocument::cancelManualPluginLoad):
      * html/canvas/WebGLRenderingContext.cpp:
      (WebCore::WebGLRenderingContext::create):
      (WebCore::WebGLRenderingContext::loseContextImpl):
      (WebCore::WebGLRenderingContext::maybeRestoreContext):
      * html/parser/HTMLConstructionSite.cpp:
      (WebCore::HTMLConstructionSite::dispatchDocumentElementAvailableIfNeeded):
      (WebCore::HTMLConstructionSite::insertHTMLBodyElement):
      * html/parser/HTMLParserOptions.cpp:
      (WebCore::HTMLParserOptions::HTMLParserOptions):
      * html/parser/XSSAuditor.cpp:
      (WebCore::XSSAuditor::init):
      * html/parser/XSSAuditorDelegate.cpp:
      (WebCore::XSSAuditorDelegate::generateViolationReport):
      (WebCore::XSSAuditorDelegate::didBlockScript):
      * inspector/InspectorApplicationCacheAgent.cpp:
      (WebCore::InspectorApplicationCacheAgent::updateApplicationCacheStatus):
      (WebCore::InspectorApplicationCacheAgent::getFramesWithManifests):
      * inspector/InspectorFrontendClientLocal.cpp:
      (WebCore::InspectorFrontendClientLocal::openInNewTab):
      * inspector/InspectorFrontendHost.cpp:
      (WebCore::InspectorFrontendHost::loadResourceSynchronously):
      * inspector/InspectorOverlay.cpp:
      (WebCore::InspectorOverlay::overlayPage):
      * inspector/InspectorPageAgent.cpp:
      (WebCore::InspectorPageAgent::mainResourceContent):
      (WebCore::InspectorPageAgent::reload):
      (WebCore::InspectorPageAgent::navigate):
      (WebCore::allResourcesURLsForFrame):
      (WebCore::InspectorPageAgent::searchInResource):
      (WebCore::InspectorPageAgent::assertDocumentLoader):
      (WebCore::InspectorPageAgent::buildObjectForFrame):
      * inspector/InspectorResourceAgent.cpp:
      (WebCore::InspectorResourceAgent::didFailLoading):
      * loader/CookieJar.cpp:
      (WebCore::networkingContext):
      * loader/DocumentLoader.cpp:
      (WebCore::DocumentLoader::frameLoader):
      (WebCore::DocumentLoader::document):
      (WebCore::DocumentLoader::stopLoading):
      (WebCore::DocumentLoader::removeSubresourceLoader):
      (WebCore::DocumentLoader::subresourceLoaderFinishedLoadingOnePart):
      (WebCore::DocumentLoader::iconLoadDecisionAvailable):
      (WebCore::DocumentLoader::continueIconLoadWithDecision):
      * loader/DocumentThreadableLoader.cpp:
      (WebCore::DocumentThreadableLoader::didReceiveResponse):
      (WebCore::DocumentThreadableLoader::didFinishLoading):
      (WebCore::DocumentThreadableLoader::didFail):
      (WebCore::DocumentThreadableLoader::preflightFailure):
      (WebCore::DocumentThreadableLoader::loadRequest):
      * loader/DocumentWriter.cpp:
      (WebCore::DocumentWriter::replaceDocument):
      (WebCore::DocumentWriter::createDocument):
      (WebCore::DocumentWriter::begin):
      * loader/FrameLoader.cpp:
      (WebCore::FrameLoader::~FrameLoader):
      (WebCore::FrameLoader::allChildrenAreComplete):
      (WebCore::FrameLoader::allAncestorsAreComplete):
      (WebCore::FrameLoader::loadURLIntoChildFrame):
      (WebCore::FrameLoader::outgoingReferrer):
      (WebCore::FrameLoader::setOpener):
      (WebCore::FrameLoader::completed):
      (WebCore::FrameLoader::started):
      (WebCore::FrameLoader::loadFrameRequest):
      (WebCore::FrameLoader::loadURL):
      (WebCore::FrameLoader::load):
      (WebCore::FrameLoader::loadWithDocumentLoader):
      (WebCore::FrameLoader::stopAllLoaders):
      (WebCore::FrameLoader::closeOldDataSources):
      (WebCore::FrameLoader::subframeIsLoading):
      (WebCore::FrameLoader::subresourceCachePolicy):
      (WebCore::FrameLoader::checkLoadCompleteForThisFrame):
      (WebCore::FrameLoader::detachChildren):
      (WebCore::FrameLoader::checkLoadComplete):
      (WebCore::FrameLoader::detachFromParent):
      (WebCore::FrameLoader::loadPostRequest):
      (WebCore::FrameLoader::loadResourceSynchronously):
      (WebCore::FrameLoader::shouldClose):
      (WebCore::FrameLoader::handleBeforeUnloadEvent):
      (WebCore::FrameLoader::continueLoadAfterNavigationPolicy):
      (WebCore::FrameLoader::continueLoadAfterNewWindowPolicy):
      (WebCore::createWindow):
      * loader/HistoryController.cpp:
      (WebCore::HistoryController::saveScrollPositionAndViewStateToItem):
      (WebCore::HistoryController::restoreScrollPositionAndViewState):
      (WebCore::HistoryController::saveDocumentState):
      (WebCore::HistoryController::saveDocumentAndScrollState):
      (WebCore::isAssociatedToRequestedHistoryItem):
      (WebCore::HistoryController::restoreDocumentState):
      (WebCore::HistoryController::shouldStopLoadingForHistoryItem):
      (WebCore::HistoryController::goToItem):
      (WebCore::HistoryController::updateForBackForwardNavigation):
      (WebCore::HistoryController::updateForReload):
      (WebCore::HistoryController::updateForStandardLoad):
      (WebCore::HistoryController::updateForRedirectWithLockedBackForwardList):
      (WebCore::HistoryController::updateForClientRedirect):
      (WebCore::HistoryController::updateForCommit):
      (WebCore::HistoryController::recursiveUpdateForCommit):
      (WebCore::HistoryController::updateForSameDocumentNavigation):
      (WebCore::HistoryController::recursiveUpdateForSameDocumentNavigation):
      (WebCore::HistoryController::initializeItem):
      (WebCore::HistoryController::createItemTree):
      (WebCore::HistoryController::recursiveSetProvisionalItem):
      (WebCore::HistoryController::recursiveGoToItem):
      (WebCore::HistoryController::updateBackForwardListClippedAtTarget):
      (WebCore::HistoryController::updateCurrentItem):
      (WebCore::HistoryController::pushState):
      (WebCore::HistoryController::replaceState):
      * loader/ImageLoader.cpp:
      (WebCore::pageIsBeingDismissed):
      * loader/MixedContentChecker.cpp:
      (WebCore::MixedContentChecker::client):
      * loader/NavigationScheduler.cpp:
      (WebCore::ScheduledURLNavigation::fire):
      (WebCore::ScheduledURLNavigation::didStartTimer):
      (WebCore::ScheduledURLNavigation::didStopTimer):
      (WebCore::ScheduledRedirect::shouldStartTimer):
      (WebCore::ScheduledRedirect::fire):
      (WebCore::ScheduledRefresh::fire):
      (WebCore::ScheduledHistoryNavigation::fire):
      (WebCore::ScheduledFormSubmission::fire):
      (WebCore::ScheduledFormSubmission::didStartTimer):
      (WebCore::ScheduledFormSubmission::didStopTimer):
      (WebCore::NavigationScheduler::mustLockBackForwardList):
      (WebCore::NavigationScheduler::scheduleLocationChange):
      (WebCore::NavigationScheduler::scheduleFormSubmission):
      (WebCore::NavigationScheduler::scheduleRefresh):
      (WebCore::NavigationScheduler::schedule):
      * loader/PingLoader.cpp:
      (WebCore::PingLoader::loadImage):
      (WebCore::PingLoader::sendPing):
      (WebCore::PingLoader::sendViolationReport):
      (WebCore::PingLoader::PingLoader):
      * loader/PolicyChecker.cpp:
      (WebCore::PolicyChecker::checkNavigationPolicy):
      (WebCore::PolicyChecker::checkNewWindowPolicy):
      (WebCore::PolicyChecker::checkContentPolicy):
      (WebCore::PolicyChecker::cancelCheck):
      (WebCore::PolicyChecker::stopCheck):
      (WebCore::PolicyChecker::cannotShowMIMEType):
      (WebCore::PolicyChecker::continueLoadAfterWillSubmitForm):
      (WebCore::PolicyChecker::continueAfterNavigationPolicy):
      (WebCore::PolicyChecker::continueAfterNewWindowPolicy):
      (WebCore::PolicyChecker::handleUnimplementablePolicy):
      * loader/ProgressTracker.cpp:
      (WebCore::ProgressTracker::progressStarted):
      (WebCore::ProgressTracker::progressCompleted):
      (WebCore::ProgressTracker::finalProgressComplete):
      (WebCore::ProgressTracker::incrementProgress):
      (WebCore::ProgressTracker::progressHeartbeatTimerFired):
      * loader/ResourceLoadNotifier.cpp:
      (WebCore::ResourceLoadNotifier::didReceiveAuthenticationChallenge):
      (WebCore::ResourceLoadNotifier::didCancelAuthenticationChallenge):
      (WebCore::ResourceLoadNotifier::willSendRequest):
      (WebCore::ResourceLoadNotifier::didFailToLoad):
      (WebCore::ResourceLoadNotifier::assignIdentifierToInitialRequest):
      (WebCore::ResourceLoadNotifier::dispatchWillSendRequest):
      (WebCore::ResourceLoadNotifier::dispatchDidReceiveResponse):
      (WebCore::ResourceLoadNotifier::dispatchDidReceiveData):
      (WebCore::ResourceLoadNotifier::dispatchDidFinishLoading):
      (WebCore::ResourceLoadNotifier::dispatchDidFailLoading):
      * loader/ResourceLoader.cpp:
      (WebCore::ResourceLoader::ResourceLoader):
      (WebCore::ResourceLoader::start):
      (WebCore::ResourceLoader::frameLoader):
      (WebCore::ResourceLoader::willSendRequest):
      * loader/SubframeLoader.cpp:
      (WebCore::SubframeLoader::pluginIsLoadable):
      (WebCore::SubframeLoader::loadMediaPlayerProxyPlugin):
      (WebCore::SubframeLoader::createJavaAppletWidget):
      (WebCore::SubframeLoader::loadOrRedirectSubframe):
      (WebCore::SubframeLoader::loadSubframe):
      (WebCore::SubframeLoader::allowPlugins):
      (WebCore::SubframeLoader::shouldUsePlugin):
      (WebCore::SubframeLoader::loadPlugin):
      * loader/appcache/ApplicationCacheGroup.cpp:
      (WebCore::ApplicationCacheGroup::selectCache):
      (WebCore::ApplicationCacheGroup::selectCacheWithoutManifestURL):
      (WebCore::ApplicationCacheGroup::update):
      (WebCore::ApplicationCacheGroup::createResourceHandle):
      (WebCore::ApplicationCacheGroup::didReceiveResponse):
      (WebCore::ApplicationCacheGroup::didFinishLoading):
      (WebCore::ApplicationCacheGroup::didFail):
      (WebCore::ApplicationCacheGroup::addEntry):
      (WebCore::CallCacheListenerTask::performTask):
      (WebCore::ApplicationCacheGroup::postListenerTask):
      * loader/appcache/DOMApplicationCache.cpp:
      (WebCore::DOMApplicationCache::applicationCacheHost):
      * loader/archive/cf/LegacyWebArchive.cpp:
      (WebCore::LegacyWebArchive::create):
      (WebCore::LegacyWebArchive::createFromSelection):
      * loader/cache/CachedResource.cpp:
      (WebCore::CachedResource::addAdditionalRequestHeaders):
      (WebCore::CachedResource::load):
      * loader/cache/CachedResourceLoader.cpp:
      (WebCore::CachedResourceLoader::requestImage):
      (WebCore::CachedResourceLoader::checkInsecureContent):
      (WebCore::CachedResourceLoader::canRequest):
      (WebCore::CachedResourceLoader::shouldContinueAfterNotifyingLoadedFromMemoryCache):
      (WebCore::CachedResourceLoader::requestResource):
      (WebCore::CachedResourceLoader::clientDefersImage):
      (WebCore::CachedResourceLoader::cachePolicy):
      (WebCore::CachedResourceLoader::loadDone):
      * loader/icon/IconController.cpp:
      (WebCore::IconController::commitToDatabase):
      (WebCore::IconController::startLoader):
      (WebCore::IconController::continueLoadWithDecision):
      * loader/icon/IconLoader.cpp:
      (WebCore::IconLoader::startLoading):
      (WebCore::IconLoader::notifyFinished):
      * page/Chrome.cpp:
      (WebCore::canRunModalIfDuringPageDismissal):
      * page/ContextMenuController.cpp:
      (WebCore::openNewWindow):
      (WebCore::ContextMenuController::contextMenuItemSelected):
      (WebCore::ContextMenuController::populate):
      (WebCore::ContextMenuController::checkOrEnableIfNeeded):
      * page/DOMWindow.cpp:
      (WebCore::DOMWindow::dispatchAllPendingBeforeUnloadEvents):
      (WebCore::DOMWindow::postMessageTimerFired):
      (WebCore::DOMWindow::close):
      (WebCore::DOMWindow::print):
      (WebCore::DOMWindow::stop):
      (WebCore::DOMWindow::setName):
      (WebCore::DOMWindow::opener):
      (WebCore::DOMWindow::dispatchLoadEvent):
      (WebCore::DOMWindow::setLocation):
      (WebCore::DOMWindow::createWindow):
      (WebCore::DOMWindow::open):
      * page/DOMWindowExtension.cpp:
      (WebCore::DOMWindowExtension::disconnectFrameForPageCache):
      (WebCore::DOMWindowExtension::reconnectFrameFromPageCache):
      (WebCore::DOMWindowExtension::willDestroyGlobalObjectInCachedFrame):
      (WebCore::DOMWindowExtension::willDestroyGlobalObjectInFrame):
      (WebCore::DOMWindowExtension::willDetachGlobalObjectFromFrame):
      * page/DragController.cpp:
      (WebCore::DragController::performDrag):
      * page/EventHandler.cpp:
      (WebCore::EventHandler::handleMousePressEvent):
      (WebCore::EventHandler::keyEvent):
      * page/Frame.cpp:
      (WebCore::Frame::~Frame):
      (WebCore::Frame::setView):
      (WebCore::Frame::injectUserScripts):
      (WebCore::Frame::willDetachPage):
      * page/Frame.h:
      (WebCore::Frame::loader):
      * page/FrameView.cpp:
      (WebCore::FrameView::mediaType):
      (WebCore::FrameView::setFixedVisibleContentRect):
      (WebCore::FrameView::shouldUseLoadTimeDeferredRepaintDelay):
      (WebCore::FrameView::performPostLayoutTasks):
      (WebCore::FrameView::autoSizeIfEnabled):
      (WebCore::FrameView::scrollTo):
      (WebCore::FrameView::shouldSuspendScrollAnimations):
      (WebCore::FrameView::qualifiesAsVisuallyNonEmpty):
      (WebCore::FrameView::wheelEvent):
      (WebCore::FrameView::firePaintRelatedMilestones):
      * page/History.cpp:
      (WebCore::History::stateInternal):
      (WebCore::History::stateObjectAdded):
      * page/Location.cpp:
      (WebCore::Location::setLocation):
      * page/Navigator.cpp:
      (WebCore::Navigator::userAgent):
      * page/Page.cpp:
      (WebCore::Page::goToItem):
      (WebCore::Page::refreshPlugins):
      (WebCore::Page::setDefersLoading):
      (WebCore::Page::setMemoryCacheClientCallsEnabled):
      (WebCore::Page::addRelevantRepaintedObject):
      * page/Performance.cpp:
      (WebCore::Performance::now):
      * page/PerformanceNavigation.cpp:
      (WebCore::PerformanceNavigation::type):
      (WebCore::PerformanceNavigation::redirectCount):
      * page/PerformanceResourceTiming.cpp:
      (WebCore::monotonicTimeToDocumentMilliseconds):
      * page/mac/PageMac.cpp:
      (WebCore::Page::addSchedulePair):
      (WebCore::Page::removeSchedulePair):
      * platform/ios/PasteboardIOS.mm:
      (WebCore::documentFragmentWithImageResource):
      (WebCore::documentFragmentWithRTF):
      (WebCore::Pasteboard::documentFragmentForPasteboardItemAtIndex):
      * platform/mac/HTMLConverter.mm:
      (-[WebHTMLConverter _addAttachmentForElement:URL:needsParagraph:usePlaceholder:]):
      (-[WebHTMLConverter _loadFromDOMRange]):
      * platform/mac/PasteboardMac.mm:
      (WebCore::documentFragmentWithImageResource):
      (WebCore::documentFragmentWithRTF):
      (WebCore::fragmentFromWebArchive):
      * plugins/DOMMimeType.cpp:
      (WebCore::DOMMimeType::enabledPlugin):
      * rendering/RenderLayer.cpp:
      (WebCore::RenderLayer::scrollTo):
      * svg/SVGAElement.cpp:
      (WebCore::SVGAElement::defaultEventHandler):
      * svg/graphics/SVGImage.cpp:
      (WebCore::SVGImage::~SVGImage):
      (WebCore::SVGImage::dataChanged):
      * testing/Internals.cpp:
      (WebCore::Internals::formControlStateOfPreviousHistoryItem):
      (WebCore::Internals::setFormControlStateOfPreviousHistoryItem):
      (WebCore::Internals::getReferencedFilePaths):
      (WebCore::Internals::forceReload):
      * xml/XSLTProcessorLibxslt.cpp:
      (WebCore::docLoaderFunc):
      * xml/parser/XMLDocumentParserLibxml2.cpp:
      (WebCore::openFunc):
      (WebCore::XMLDocumentParser::startElementNs):
      
      Source/WebKit/blackberry:
      
      * Api/WebPage.cpp:
      (BlackBerry::WebKit::WebPagePrivate::load):
      (BlackBerry::WebKit::WebPagePrivate::loadString):
      (BlackBerry::WebKit::WebPagePrivate::stopCurrentLoad):
      (BlackBerry::WebKit::closeURLRecursively):
      (BlackBerry::WebKit::WebPage::dispatchBeforeUnloadEvent):
      (BlackBerry::WebKit::WebPagePrivate::shouldSendResizeEvent):
      (BlackBerry::WebKit::WebPagePrivate::zoomToInitialScaleOnLoad):
      (BlackBerry::WebKit::WebPage::reload):
      (BlackBerry::WebKit::WebPage::reloadFromCache):
      (BlackBerry::WebKit::WebPage::textEncoding):
      (BlackBerry::WebKit::WebPage::forcedTextEncoding):
      (BlackBerry::WebKit::WebPage::setForcedTextEncoding):
      (BlackBerry::WebKit::WebPage::title):
      * WebCoreSupport/ChromeClientBlackBerry.cpp:
      (WebCore::ChromeClientBlackBerry::createWindow):
      * WebCoreSupport/FrameLoaderClientBlackBerry.cpp:
      (WebCore::FrameLoaderClientBlackBerry::dispatchDidChangeLocationWithinPage):
      (WebCore::FrameLoaderClientBlackBerry::dispatchDecidePolicyForResponse):
      (WebCore::FrameLoaderClientBlackBerry::dispatchDecidePolicyForNavigationAction):
      (WebCore::FrameLoaderClientBlackBerry::delayPolicyCheckUntilFragmentExists):
      (WebCore::FrameLoaderClientBlackBerry::dispatchDecidePolicyForNewWindowAction):
      (WebCore::FrameLoaderClientBlackBerry::createPlugin):
      (WebCore::FrameLoaderClientBlackBerry::receivedData):
      (WebCore::FrameLoaderClientBlackBerry::createDocumentLoader):
      (WebCore::FrameLoaderClientBlackBerry::dispatchDidCommitLoad):
      (WebCore::FrameLoaderClientBlackBerry::dispatchDidFailProvisionalLoad):
      (WebCore::FrameLoaderClientBlackBerry::dispatchWillSubmitForm):
      (WebCore::FrameLoaderClientBlackBerry::createFrame):
      (WebCore::FrameLoaderClientBlackBerry::dispatchDidLayout):
      (WebCore::FrameLoaderClientBlackBerry::dispatchWillSendRequest):
      (WebCore::FrameLoaderClientBlackBerry::restoreViewState):
      (WebCore::FrameLoaderClientBlackBerry::startDownload):
      (WebCore::FrameLoaderClientBlackBerry::canCachePage):
      (WebCore::FrameLoaderClientBlackBerry::didRestoreFromPageCache):
      * WebKitSupport/PagePopup.cpp:
      (BlackBerry::WebKit::PagePopup::initialize):
      
      Source/WebKit/efl:
      
      * WebCoreSupport/ChromeClientEfl.cpp:
      (kit):
      * WebCoreSupport/DumpRenderTreeSupportEfl.cpp:
      (DumpRenderTreeSupportEfl::callShouldCloseOnWebView):
      (DumpRenderTreeSupportEfl::clearOpener):
      (DumpRenderTreeSupportEfl::frameChildren):
      (DumpRenderTreeSupportEfl::responseMimeType):
      (DumpRenderTreeSupportEfl::provisionalURL):
      * WebCoreSupport/FrameLoaderClientEfl.cpp:
      (WebCore::FrameLoaderClientEfl::callPolicyFunction):
      (WebCore::FrameLoaderClientEfl::dispatchDecidePolicyForNewWindowAction):
      (WebCore::FrameLoaderClientEfl::dispatchDecidePolicyForNavigationAction):
      (WebCore::FrameLoaderClientEfl::updateGlobalHistoryRedirectLinks):
      (WebCore::FrameLoaderClientEfl::updateGlobalHistory):
      * ewk/ewk_frame.cpp:
      (_ewk_frame_loader_efl_get):
      (_ewk_frame_smart_del):
      (_ewk_frame_contents_set_internal):
      (ewk_frame_stop):
      (ewk_frame_reload):
      (ewk_frame_reload_full):
      (ewk_frame_child_add):
      * ewk/ewk_view.cpp:
      (ewk_view_frame_focused_get):
      (ewk_view_setting_user_agent_set):
      (ewk_view_setting_encoding_custom_get):
      (ewk_view_setting_encoding_custom_set):
      
      Source/WebKit/gtk:
      
      * WebCoreSupport/DumpRenderTreeSupportGtk.cpp:
      (DumpRenderTreeSupportGtk::clearOpener):
      (DumpRenderTreeSupportGtk::shouldClose):
      * WebCoreSupport/FrameLoaderClientGtk.cpp:
      (WebKit::FrameLoaderClient::dispatchWillSubmitForm):
      (WebKit::FrameLoaderClient::committedLoad):
      (WebKit::FrameLoaderClient::dispatchDecidePolicyForResponse):
      (WebKit::FrameLoaderClient::dispatchDecidePolicyForNewWindowAction):
      (WebKit::FrameLoaderClient::dispatchDecidePolicyForNavigationAction):
      (WebKit::FrameLoaderClient::createFrame):
      (WebKit::FrameLoaderClient::dispatchDidCommitLoad):
      * webkit/webkitwebframe.cpp:
      (webkit_web_frame_finalize):
      (webkit_web_frame_load_uri):
      (webkit_web_frame_load_data):
      (webkit_web_frame_load_request):
      (webkit_web_frame_stop_loading):
      (webkit_web_frame_reload):
      (webkit_web_frame_get_data_source):
      (webkit_web_frame_get_provisional_data_source):
      (webkit_web_frame_get_response_mime_type):
      (webkit_web_frame_get_network_response):
      (WebKit::kit):
      * webkit/webkitwebpolicydecision.cpp:
      (webkit_web_policy_decision_use):
      (webkit_web_policy_decision_ignore):
      (webkit_web_policy_decision_download):
      * webkit/webkitwebview.cpp:
      (webkit_web_view_dispose):
      (webkit_web_view_reload):
      (webkit_web_view_reload_bypass_cache):
      (webkit_web_view_stop_loading):
      (webkit_web_view_can_show_mime_type):
      (webkit_web_view_set_custom_encoding):
      (webkit_web_view_get_custom_encoding):
      (webkit_web_view_get_subresources):
      
      Source/WebKit/mac:
      
      * Plugins/Hosted/HostedNetscapePluginStream.mm:
      (WebKit::HostedNetscapePluginStream::HostedNetscapePluginStream):
      * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
      (WebKit::NetscapePluginInstanceProxy::performRequest):
      (WebKit::NetscapePluginInstanceProxy::loadRequest):
      * Plugins/Hosted/WebHostedNetscapePluginView.mm:
      (-[WebHostedNetscapePluginView pluginView:receivedResponse:]):
      * Plugins/WebBaseNetscapePluginView.mm:
      (-[WebBaseNetscapePluginView requestWithURLCString:]):
      * Plugins/WebNetscapePluginStream.mm:
      (WebNetscapePluginStream::WebNetscapePluginStream):
      * Plugins/WebNetscapePluginView.mm:
      (-[WebNetscapePluginView loadStream]):
      (-[WebNetscapePluginView pluginView:receivedResponse:]):
      (-[WebNetscapePluginView loadPluginRequest:]):
      (-[WebNetscapePluginView loadRequest:inTarget:withNotifyData:sendNotification:]):
      * Plugins/WebPluginController.mm:
      * WebCoreSupport/WebFrameLoaderClient.mm:
      (WebFrameLoaderClient::dispatchDidReceiveServerRedirectForProvisionalLoad):
      (WebFrameLoaderClient::dispatchDidStartProvisionalLoad):
      (WebFrameLoaderClient::dispatchWillSubmitForm):
      (WebFrameLoaderClient::updateGlobalHistory):
      (WebFrameLoaderClient::updateGlobalHistoryRedirectLinks):
      (WebFrameLoaderClient::restoreViewState):
      (WebFrameLoaderClient::transitionToCommittedForNewPage):
      (WebFrameLoaderClient::createFrame):
      * WebCoreSupport/WebFrameNetworkingContext.mm:
      (WebFrameNetworkingContext::blockedError):
      * WebCoreSupport/WebPlatformStrategies.mm:
      (WebPlatformStrategies::getPluginInfo):
      * WebView/WebFrame.mm:
      (kit):
      (-[WebFrame _dataSource]):
      (-[WebFrame _canProvideDocumentSource]):
      (-[WebFrame _commitData:]):
      (-[WebFrame _firstLayoutDone]):
      (-[WebFrame _loadType]):
      (-[WebFrame _cacheabilityDictionary]):
      (-[WebFrame _clearOpener]):
      (-[WebFrame provisionalDataSource]):
      (-[WebFrame dataSource]):
      (-[WebFrame loadRequest:]):
      (-[WebFrame _loadData:MIMEType:textEncodingName:baseURL:unreachableURL:]):
      (-[WebFrame loadArchive:]):
      (-[WebFrame stopLoading]):
      (-[WebFrame reload]):
      (-[WebFrame reloadFromOrigin]):
      * WebView/WebHTMLRepresentation.mm:
      (-[WebHTMLRepresentation receivedData:withDataSource:]):
      * WebView/WebHTMLView.mm:
      (-[WebHTMLView validateUserInterfaceItemWithoutDelegate:]):
      * WebView/WebPDFView.mm:
      (-[WebPDFView PDFViewWillClickOnLink:withURL:]):
      * WebView/WebRenderLayer.mm:
      (-[WebRenderLayer initWithWebFrame:]):
      * WebView/WebRenderNode.mm:
      (-[WebRenderNode _initWithCoreFrame:]):
      * WebView/WebView.mm:
      (-[WebView _close]):
      (-[WebView _loadBackForwardListFromOtherView:]):
      (-[WebView _cachedResponseForURL:]):
      (-[WebView setCustomTextEncodingName:]):
      (-[WebView shouldClose]):
      
      Source/WebKit/qt:
      
      * WebCoreSupport/ChromeClientQt.cpp:
      (WebCore::ChromeClientQt::closeWindowSoon):
      * WebCoreSupport/DumpRenderTreeSupportQt.cpp:
      (DumpRenderTreeSupportQt::shouldClose):
      (DumpRenderTreeSupportQt::responseMimeType):
      (DumpRenderTreeSupportQt::clearOpener):
      (DumpRenderTreeSupportQt::thirdPartyCookiePolicyAllows):
      (DumpRenderTreeSupportQt::setAlternateHtml):
      * WebCoreSupport/FrameLoaderClientQt.cpp:
      (WebCore::FrameLoaderClientQt::callPolicyFunction):
      (WebCore::FrameLoaderClientQt::dispatchDidStartProvisionalLoad):
      (WebCore::FrameLoaderClientQt::updateGlobalHistory):
      (WebCore::FrameLoaderClientQt::updateGlobalHistoryRedirectLinks):
      (WebCore::FrameLoaderClientQt::callErrorPageExtension):
      (WebCore::FrameLoaderClientQt::dispatchDecidePolicyForNewWindowAction):
      (WebCore::FrameLoaderClientQt::dispatchDecidePolicyForNavigationAction):
      (WebCore::FrameLoaderClientQt::startDownload):
      (WebCore::FrameLoaderClientQt::createFrame):
      (WebCore::FrameLoaderClientQt::objectContentType):
      * WebCoreSupport/QWebFrameAdapter.cpp:
      (QWebFrameAdapter::load):
      (QWebFrameAdapter::setContent):
      (QWebFrameAdapter::setHtml):
      (QWebFrameAdapter::kit):
      (QWebFrameAdapter::title):
      (QWebFrameAdapter::clearCoreFrame):
      * WebCoreSupport/QWebPageAdapter.cpp:
      (frameLoadRequest):
      (openNewWindow):
      (QWebPageAdapter::triggerAction):
      (QWebPageAdapter::currentFrame):
      
      Source/WebKit/win:
      
      * WebCoreSupport/WebContextMenuClient.cpp:
      (WebContextMenuClient::searchWithGoogle):
      * WebCoreSupport/WebFrameLoaderClient.cpp:
      (WebFrameLoaderClient::updateGlobalHistory):
      (WebFrameLoaderClient::updateGlobalHistoryRedirectLinks):
      (WebFrameLoaderClient::savePlatformDataToCachedFrame):
      (WebFrameLoaderClient::createFrame):
      (WebFrameLoaderClient::dispatchDidFailToStartPlugin):
      * WebCoreSupport/WebFrameNetworkingContext.cpp:
      (WebFrameNetworkingContext::blockedError):
      (WebFrameNetworkingContext::referrer):
      * WebElementPropertyBag.cpp:
      (WebElementPropertyBag::Read):
      * WebFrame.cpp:
      (kit):
      (WebFrame::reloadFromOrigin):
      (WebFrame::loadRequest):
      (WebFrame::loadData):
      (WebFrame::dataSource):
      (WebFrame::provisionalDataSource):
      (WebFrame::stopLoading):
      (WebFrame::reload):
      (WebFrame::firstLayoutDone):
      (WebFrame::loadType):
      (WebFrame::clearOpener):
      (WebFrame::dispatchWillSubmitForm):
      (WebFrame::receivedPolicyDecision):
      (WebFrame::dispatchDecidePolicyForResponse):
      (WebFrame::dispatchDecidePolicyForNewWindowAction):
      (WebFrame::dispatchDecidePolicyForNavigationAction):
      (WebFrame::createJavaAppletWidget):
      * WebFramePolicyListener.cpp:
      (WebFramePolicyListener::receivedPolicyDecision):
      * WebView.cpp:
      (WebView::close):
      (WebView::canShowMIMEType):
      (WebView::setCustomTextEncodingName):
      (WebView::loadBackForwardListFromOtherView):
      (WebView::shouldClose):
      
      Source/WebKit/wince:
      
      * WebCoreSupport/FrameLoaderClientWinCE.cpp:
      (WebKit::FrameLoaderClientWinCE::dispatchDecidePolicyForResponse):
      (WebKit::FrameLoaderClientWinCE::dispatchDecidePolicyForNewWindowAction):
      (WebKit::FrameLoaderClientWinCE::dispatchDecidePolicyForNavigationAction):
      (WebKit::FrameLoaderClientWinCE::dispatchWillSubmitForm):
      * WebCoreSupport/FrameNetworkingContextWinCE.cpp:
      (WebKit::FrameNetworkingContextWinCE::referrer):
      * WebView.cpp:
      (WebView::createFrame):
      (WebView::load):
      (WebView::reload):
      (WebView::stop):
      
      Source/WebKit2:
      
      * Shared/WebRenderLayer.cpp:
      (WebKit::WebRenderLayer::create):
      * Shared/WebRenderObject.cpp:
      (WebKit::WebRenderObject::create):
      * WebProcess/Geolocation/GeolocationPermissionRequestManager.cpp:
      (WebKit::GeolocationPermissionRequestManager::startRequestForGeolocation):
      * WebProcess/InjectedBundle/API/c/WKBundleFrame.cpp:
      (WKBundleFrameGetFrameLoadState):
      (WKBundleFrameClearOpener):
      (WKBundleFrameCallShouldCloseOnWebView):
      * WebProcess/InjectedBundle/DOM/InjectedBundleNodeHandle.cpp:
      (WebKit::InjectedBundleNodeHandle::documentFrame):
      (WebKit::InjectedBundleNodeHandle::htmlFrameElementContentFrame):
      (WebKit::InjectedBundleNodeHandle::htmlIFrameElementContentFrame):
      * WebProcess/InjectedBundle/InjectedBundle.cpp:
      (WebKit::InjectedBundle::overrideBoolPreferenceForTestRunner):
      * WebProcess/InjectedBundle/InjectedBundleDOMWindowExtension.cpp:
      (WebKit::InjectedBundleDOMWindowExtension::frame):
      * WebProcess/InjectedBundle/InjectedBundleHitTestResult.cpp:
      (WebKit::InjectedBundleHitTestResult::frame):
      (WebKit::InjectedBundleHitTestResult::targetFrame):
      * WebProcess/Plugins/PDF/PDFPlugin.mm:
      (WebKit::PDFPlugin::clickedLink):
      * WebProcess/Plugins/PluginView.cpp:
      (WebKit::webPage):
      (WebKit::PluginView::didFailToInitializePlugin):
      (WebKit::PluginView::performFrameLoadURLRequest):
      (WebKit::PluginView::userAgent):
      (WebKit::PluginView::loadURL):
      (WebKit::PluginView::cancelManualStreamLoad):
      (WebKit::PluginView::proxiesForURL):
      * WebProcess/WebCoreSupport/WebChromeClient.cpp:
      (WebKit::WebChromeClient::focusedElementChanged):
      (WebKit::WebChromeClient::focusedFrameChanged):
      (WebKit::WebChromeClient::runBeforeUnloadConfirmPanel):
      (WebKit::WebChromeClient::closeWindowSoon):
      (WebKit::WebChromeClient::runJavaScriptAlert):
      (WebKit::WebChromeClient::runJavaScriptConfirm):
      (WebKit::WebChromeClient::runJavaScriptPrompt):
      (WebKit::WebChromeClient::unavailablePluginButtonClicked):
      (WebKit::WebChromeClient::print):
      (WebKit::WebChromeClient::exceededDatabaseQuota):
      (WebKit::WebChromeClient::runOpenPanel):
      * WebProcess/WebCoreSupport/WebContextMenuClient.cpp:
      (WebKit::WebContextMenuClient::searchWithGoogle):
      * WebProcess/WebCoreSupport/WebEditorClient.cpp:
      (WebKit::WebEditorClient::textFieldDidBeginEditing):
      (WebKit::WebEditorClient::textFieldDidEndEditing):
      (WebKit::WebEditorClient::textDidChangeInTextField):
      (WebKit::WebEditorClient::textDidChangeInTextArea):
      (WebKit::WebEditorClient::doTextFieldCommandFromEvent):
      (WebKit::WebEditorClient::textWillBeDeletedInTextField):
      * WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:
      (WebKit::WebFrameLoaderClient::dispatchDidReceiveServerRedirectForProvisionalLoad):
      (WebKit::WebFrameLoaderClient::dispatchDidStartProvisionalLoad):
      (WebKit::WebFrameLoaderClient::dispatchDidCommitLoad):
      (WebKit::WebFrameLoaderClient::dispatchDecidePolicyForResponse):
      (WebKit::WebFrameLoaderClient::dispatchDecidePolicyForNewWindowAction):
      (WebKit::WebFrameLoaderClient::dispatchDecidePolicyForNavigationAction):
      (WebKit::WebFrameLoaderClient::dispatchWillSendSubmitEvent):
      (WebKit::WebFrameLoaderClient::dispatchWillSubmitForm):
      (WebKit::WebFrameLoaderClient::updateGlobalHistory):
      (WebKit::WebFrameLoaderClient::updateGlobalHistoryRedirectLinks):
      (WebKit::WebFrameLoaderClient::restoreViewState):
      (WebKit::WebFrameLoaderClient::createFrame):
      (WebKit::WebFrameLoaderClient::createJavaAppletWidget):
      (WebKit::WebFrameLoaderClient::objectContentType):
      * WebProcess/WebCoreSupport/WebPlatformStrategies.cpp:
      (WebKit::WebPlatformStrategies::getPluginInfo):
      * WebProcess/WebCoreSupport/mac/WebFrameNetworkingContext.mm:
      (WebKit::WebFrameNetworkingContext::blockedError):
      * WebProcess/WebPage/WebFrame.cpp:
      (WebKit::WebFrame::didReceivePolicyDecision):
      (WebKit::WebFrame::startDownload):
      (WebKit::WebFrame::source):
      (WebKit::WebFrame::contentsAsString):
      (WebKit::WebFrame::url):
      (WebKit::WebFrame::parentFrame):
      (WebKit::WebFrame::childFrames):
      (WebKit::WebFrame::stopLoading):
      (WebKit::WebFrame::frameForContext):
      (WebKit::WebFrame::provisionalURL):
      (WebKit::WebFrame::suggestedFilenameForResourceWithURL):
      (WebKit::WebFrame::mimeTypeForResourceWithURL):
      (WebKit::WebFrameFilter::shouldIncludeSubframe):
      * WebProcess/WebPage/WebPage.cpp:
      (WebKit::WebPage::createPlugin):
      (WebKit::WebPage::close):
      (WebKit::WebPage::tryClose):
      (WebKit::WebPage::loadURLRequest):
      (WebKit::WebPage::loadDataImpl):
      (WebKit::WebPage::linkClicked):
      (WebKit::WebPage::stopLoadingFrame):
      (WebKit::WebPage::stopLoading):
      (WebKit::WebPage::reload):
      (WebKit::WebPage::tryRestoreScrollPosition):
      (WebKit::WebPage::getMainResourceDataOfFrame):
      (WebKit::resourceDataForFrame):
      (WebKit::shouldReuseCommittedSandboxExtension):
      (WebKit::WebPage::SandboxExtensionTracker::didStartProvisionalLoad):
      (WebKit::WebPage::hasLocalDataForURL):
      (WebKit::WebPage::setCustomTextEncodingName):
      (WebKit::WebPage::canPluginHandleResponse):
      (WebKit::WebPage::canShowMIMEType):
      (WebKit::WebPage::didCommitLoad):
      * WebProcess/WebPage/mac/WebPageMac.mm:
      (WebKit::WebPage::platformHasLocalDataForURL):
      (WebKit::cachedResponseForURL):
      * WebProcess/WebProcess.cpp:
      (WebKit::WebProcess::downloadRequest):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@154142 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      df550b96
    • gyuyoung.kim@samsung.com's avatar
      [CSS] Introduce new structure to pass image orientation values. · 0d92f4d6
      gyuyoung.kim@samsung.com authored
      https://bugs.webkit.org/show_bug.cgi?id=119418
      
      Reviewed by Beth Dakin.
      
      Add a ImageOrientationDescription struct in order to reduce count of argument for
      image orientation.
      
      No new tests, no behavior change.
      
      * html/HTMLCanvasElement.cpp:
      (WebCore::HTMLCanvasElement::paint):
      * page/DragController.cpp:
      (WebCore::DragController::doImageDrag):
      * page/Frame.cpp:
      (WebCore::Frame::nodeImage):
      (WebCore::Frame::dragImageForSelection):
      * platform/DragImage.h:
      * platform/blackberry/DragImageBlackBerry.cpp:
      (WebCore::createDragImageFromImage):
      * platform/efl/DragImageEfl.cpp:
      (WebCore::createDragImageFromImage):
      * platform/graphics/BitmapImage.cpp:
      (WebCore::BitmapImage::updateSize):
      * platform/graphics/BitmapImage.h:
      * platform/graphics/GraphicsContext.cpp:
      (WebCore::GraphicsContext::drawImage):
      * platform/graphics/GraphicsContext.h:
      * platform/graphics/Image.cpp:
      (WebCore::Image::draw):
      * platform/graphics/Image.h:
      * platform/graphics/ImageOrientation.h:
      (WebCore::ImageOrientationDescription::ImageOrientationDescription):
      (WebCore::ImageOrientationDescription::respectImageOrientation):
      (WebCore::ImageOrientationDescription::imageOrientation):
      * platform/graphics/ImageSource.cpp:
      (WebCore::ImageSource::size):
      (WebCore::ImageSource::frameSizeAtIndex):
      * platform/graphics/ImageSource.h:
      * platform/graphics/blackberry/ImageBlackBerry.cpp:
      (WebCore::BitmapImage::draw):
      * platform/graphics/cairo/BitmapImageCairo.cpp:
      (WebCore::BitmapImage::draw):
      * platform/graphics/cairo/ImageBufferCairo.cpp:
      (WebCore::ImageBuffer::draw):
      * platform/graphics/cg/BitmapImageCG.cpp:
      (WebCore::BitmapImage::draw):
      * platform/graphics/cg/ImageSourceCG.cpp:
      (WebCore::ImageSource::frameSizeAtIndex):
      (WebCore::ImageSource::size):
      (WebCore::ImageSource::frameBytesAtIndex):
      * platform/graphics/gstreamer/MediaPlayerPrivateGStreamerBase.cpp:
      (WebCore::MediaPlayerPrivateGStreamerBase::paint):
      * platform/graphics/qt/ImageBufferQt.cpp:
      (WebCore::ImageBuffer::draw):
      * platform/graphics/wince/ImageBufferWinCE.cpp:
      (WebCore::ImageBuffer::draw):
      * platform/gtk/ClipboardGtk.cpp:
      (WebCore::Clipboard::createDragImage):
      * platform/gtk/DragImageGtk.cpp:
      (WebCore::createDragImageFromImage):
      * platform/mac/DragImageMac.mm:
      (WebCore::createDragImageFromImage):
      * platform/qt/ClipboardQt.cpp:
      (WebCore::Clipboard::createDragImage):
      * platform/qt/DragImageQt.cpp:
      (WebCore::createDragImageFromImage):
      * platform/win/ClipboardWin.cpp:
      (WebCore::Clipboard::createDragImage):
      * platform/win/DragImageCGWin.cpp:
      (WebCore::createDragImageFromImage):
      * platform/win/DragImageCairoWin.cpp:
      (WebCore::createDragImageFromImage):
      * rendering/RenderEmbeddedObject.cpp:
      (WebCore::RenderEmbeddedObject::paintSnapshotImage):
      * rendering/RenderImage.cpp:
      (WebCore::RenderImage::paintReplaced):
      (WebCore::RenderImage::paintIntoRect):
      * rendering/RenderSnapshottedPlugIn.cpp:
      (WebCore::RenderSnapshottedPlugIn::paintSnapshot):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@154088 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      0d92f4d6
  5. 13 Aug, 2013 1 commit
    • darin@apple.com's avatar
      Move Clipboard::declareAndWriteDragImage to DragController · 5ae15617
      darin@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=117683
      
      Reviewed by Brent Fulgham.
      
      * dom/Clipboard.h: Removed declareAndWriteDragImage.
      
      * page/DragController.cpp:
      (WebCore::selectImageBeforeDragging): Half of the old prepareClipboardForImageDrag
      is now refactored into this function.
      (WebCore::DragController::startDrag): Where we called prepareClipboardForImageDrag,
      instead call selectImageBeforeDragging and declareAndWriteDragImage. This is needed
      because declareAndWriteDragImage needs to be a member function, for Mac at least.
      
      * page/DragController.h: Added declareAndWriteDragImage.
      
      * page/efl/DragControllerEfl.cpp:
      (WebCore::DragController::declareAndWriteDragImage): Added empty placeholder.
      It would be better to delete this file rather than having these placeholders.
      I don't think EFL actually has drag support, and it makes work to have to keep
      source files up to date that are really unused.
      
      * page/gtk/DragControllerGtk.cpp:
      (WebCore::DragController::declareAndWriteDragImage): Added. Calls Pasteboard::writeImage.
      * page/mac/DragControllerMac.mm:
      (WebCore::DragController::declareAndWriteDragImage): Added. Calls to DragClient, which
      does the work.
      * page/qt/DragControllerQt.cpp:
      (WebCore::DragController::declareAndWriteDragImage): Added. Calls Pasteboard::writeImage.
      * page/win/DragControllerWin.cpp:
      (WebCore::DragController::declareAndWriteDragImage): Added. Uses Pasteboard functions to
      do the work.
      
      * platform/Clipboard.h: Changed the pasteboard function to return a non-const reference.
      For now, it's not clear what const will mean for pasteboards, and it's currently not
      possible to write to a const pasteboard, which we need to do in the new
      DragController::declareAndWriteDragImage functions.
      
      * platform/Pasteboard.h: Added a new writeMarkup function, implemented only for Windows
      at this time.
      
      * platform/efl/ClipboardEfl.cpp: Deleted declareAndWriteDragImage.
      * platform/gtk/ClipboardGtk.cpp: Ditto.
      * platform/ios/ClipboardIOS.h: Ditto.
      * platform/ios/ClipboardIOS.mm: Ditto.
      * platform/mac/ClipboardMac.mm: Ditto.
      * platform/qt/ClipboardQt.cpp: Ditto.
      * platform/win/ClipboardWin.cpp: Ditto.
      
      * platform/win/PasteboardWin.cpp:
      (WebCore::Pasteboard::writePlainTextToDataObject): Took out a pointless line of code.
      (WebCore::Pasteboard::writeMarkup): Added. Currently implemented only for Windows.
      This factors out a significant piece of DragController::declareAndWriteDragImage,
      and will probably be handy for other platforms later.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@153978 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      5ae15617
  6. 18 Jul, 2013 1 commit
  7. 29 Jun, 2013 1 commit
    • kangil.han@samsung.com's avatar
      Adopt is/toHTMLImageElement for code cleanup · 2489e830
      kangil.han@samsung.com authored
      https://bugs.webkit.org/show_bug.cgi?id=118182
      
      Reviewed by Andreas Kling.
      
      To enhance readability, this patch adopts is/toHTMLImageElement.
      This also helps out to reduce duplicated use of static_cast.
      
      Source/WebCore:
      
      * accessibility/AccessibilityNodeObject.cpp:
      (WebCore::AccessibilityNodeObject::isNativeImage):
      * accessibility/AccessibilityRenderObject.cpp:
      (WebCore::AccessibilityRenderObject::url):
      * bindings/js/JSNodeCustom.cpp:
      (WebCore::isReachableFromDOM):
      * bridge/qt/qt_pixmapruntime.cpp:
      (JSC::Bindings::assignToHTMLImageElement):
      (JSC::Bindings::QtPixmapRuntime::toQt):
      * dom/Clipboard.cpp:
      (WebCore::Clipboard::setDragImage):
      * dom/Node.cpp:
      (WebCore::Node::enclosingLinkEventParentOrSelf):
      * editing/Editor.cpp:
      (WebCore::imageElementFromImageDocument):
      * html/HTMLAnchorElement.cpp:
      (WebCore::appendServerMapMousePosition):
      * html/HTMLImageElement.h:
      (WebCore::isHTMLImageElement):
      (WebCore::toHTMLImageElement):
      * html/HTMLMapElement.cpp:
      (WebCore::HTMLMapElement::imageElement):
      * html/HTMLNameCollection.cpp:
      (WebCore::WindowNameCollection::nodeMatchesIfNameAttributeMatch):
      (WebCore::DocumentNameCollection::nodeMatchesIfIdAttributeMatch):
      (WebCore::DocumentNameCollection::nodeMatchesIfNameAttributeMatch):
      (WebCore::DocumentNameCollection::nodeMatches):
      * page/DragController.cpp:
      (WebCore::DragController::draggableElement):
      * page/PageSerializer.cpp:
      (WebCore::PageSerializer::serializeFrame):
      * platform/gtk/PasteboardGtk.cpp:
      (WebCore::getURLForImageNode):
      * platform/mac/HTMLConverter.mm:
      (+[WebHTMLConverter editingAttributedStringFromRange:]):
      * rendering/HitTestResult.cpp:
      (WebCore::HitTestResult::altDisplayString):
      (WebCore::HitTestResult::absoluteImageURL):
      * rendering/RenderImage.cpp:
      (WebCore::RenderImage::paintIntoRect):
      (WebCore::RenderImage::imageMap):
      (WebCore::RenderImage::updateAltText):
      * rendering/RenderObject.cpp:
      (WebCore::RenderObject::shouldRespectImageOrientation):
      
      Source/WebKit/blackberry:
      
      * Api/WebPage.cpp:
      (BlackBerry::WebKit::WebPagePrivate::webContext):
      (BlackBerry::WebKit::WebPagePrivate::blockZoomRectForNode):
      (BlackBerry::WebKit::WebPage::blockZoom):
      * WebKitSupport/FatFingers.cpp:
      (BlackBerry::WebKit::FatFingers::isElementClickable):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@152203 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      2489e830
  8. 26 Jun, 2013 1 commit
    • kangil.han@samsung.com's avatar
      Adopt is/toHTMLAnchorElement for code cleanup · 1147c5b2
      kangil.han@samsung.com authored
      https://bugs.webkit.org/show_bug.cgi?id=117973
      
      Reviewed by Andreas Kling.
      
      To enhance readibility, this patch adopts is/toHTMLAnchorElement.
      This also helps out to reduce duplicated use of static_cast.
      
      Source/WebCore:
      
      * accessibility/AccessibilityNodeObject.cpp:
      (WebCore::AccessibilityNodeObject::anchorElement):
      * accessibility/AccessibilityRenderObject.cpp:
      (WebCore::AccessibilityRenderObject::anchorElement):
      (WebCore::AccessibilityRenderObject::internalLinkElement):
      (WebCore::AccessibilityRenderObject::url):
      (WebCore::AccessibilityRenderObject::stringValueForMSAA):
      (WebCore::AccessibilityRenderObject::isLinked):
      * css/CSSDefaultStyleSheets.cpp:
      (WebCore::elementCanUseSimpleDefaultStyle):
      * css/SelectorChecker.cpp:
      (WebCore::SelectorChecker::checkOne):
      * dom/Document.cpp:
      (WebCore::Document::updateBaseURL):
      * dom/TreeScope.cpp:
      (WebCore::TreeScope::findAnchor):
      * dom/VisitedLinkState.cpp:
      (WebCore::linkHashForElement):
      (WebCore::VisitedLinkState::determineLinkStateSlowCase):
      * html/HTMLAnchorElement.h:
      (WebCore::isHTMLAnchorElement):
      (WebCore::toHTMLAnchorElement):
      * page/DragController.cpp:
      (WebCore::DragController::draggableElement):
      * rendering/HitTestResult.cpp:
      (WebCore::HitTestResult::absoluteLinkURL):
      (WebCore::HitTestResult::isLiveLink):
      * rendering/RenderObject.cpp:
      (WebCore::RenderObject::getTextDecorationColors):
      
      Source/WebKit/blackberry:
      
      * WebKitSupport/FatFingers.cpp:
      (BlackBerry::WebKit::FatFingers::isElementClickable):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@151975 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      1147c5b2
  9. 06 Jun, 2013 1 commit
    • commit-queue@webkit.org's avatar
      :hover style not applied on hover if its display property is different from original style's · 83fb9b9a
      commit-queue@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=7555
      
      Source/WebCore:
      
      Properly apply the :hover pseudo-class when reattaching is required (e.g. when changing the display type)
      
      A new AttachContext class was created to be passed along as an optional parameter to the attach/detach/reattach methods.
      This new parameter is used to:
          - prevent the element from being removed from the list of hovered/active elements upon detach when a reattach is in progress
          - prevent the style from being incorrectly computed (due to the previous point)
          - prevent the style from being computed twice (the attach() method used to recompute it)
      
      Special care was required to the case when display:none is specified in the :hover class. Enabling the :hover style
      was leaving the element without a renderer, which was causing it to remain stuck in the :hover state (subsequent mouseMove
      events were not able to reset the element to its normal style due to the fact that it had no renderer).
      
      The DragController::startDrag method was updated to properly handle the case when dragImage is NULL
      (for instance by setting display:none inside the -webkit-drag pseudo-class).
      
      Patch by Radu Stavila <stavila@adobe.com> on 2013-06-06
      Reviewed by Antti Koivisto.
      
      Tests: fast/regions/hover-display-block-inline.html
             fast/regions/hover-display-block-none.html
      
      * page/DragController.cpp:
      (WebCore::DragController::startDrag):
      * dom/ContainerNode.cpp:
      (WebCore::ContainerNode::attach):
      (WebCore::ContainerNode::detach):
      * dom/ContainerNode.h:
      * dom/Document.cpp:
      (WebCore::Document::attach):
      (WebCore::Document::detach):
      (WebCore::Document::updateHoverActiveState):
      * dom/Document.h:
      * dom/Element.cpp:
      (WebCore::Element::setHovered):
      (WebCore::Element::createRendererIfNeeded):
      (WebCore::Element::attach):
      (WebCore::Element::detach):
      (WebCore::Element::recalcStyle):
      * dom/Element.h:
      * dom/Node.cpp:
      (WebCore::Node::AttachDetachContext::AttachDetachContext):
      (WebCore::Node::AttachDetachContext::~AttachDetachContext):
      (WebCore::Node::attach):
      (WebCore::Node::detach):
      * dom/Node.h:
      (WebCore::Node::reattach):
      (WebCore::Node::reattachIfAttached):
      * dom/NodeRenderingContext.cpp:
      (WebCore::NodeRenderingContext::NodeRenderingContext):
      * dom/PseudoElement.cpp:
      (WebCore::PseudoElement::attach):
      * dom/PseudoElement.h:
      * dom/ShadowRoot.cpp:
      (WebCore::ShadowRoot::attach):
      * dom/ShadowRoot.h:
      * dom/Text.cpp:
      (WebCore::Text::attach):
      * dom/Text.h:
      * html/HTMLCanvasElement.cpp:
      (WebCore::HTMLCanvasElement::attach):
      * html/HTMLCanvasElement.h:
      * html/HTMLFormControlElement.cpp:
      (WebCore::HTMLFormControlElement::attach):
      * html/HTMLFormControlElement.h:
      * html/HTMLFrameElement.cpp:
      (WebCore::HTMLFrameElement::attach):
      * html/HTMLFrameElement.h:
      * html/HTMLFrameElementBase.cpp:
      (WebCore::HTMLFrameElementBase::attach):
      * html/HTMLFrameElementBase.h:
      * html/HTMLFrameSetElement.cpp:
      (WebCore::HTMLFrameSetElement::attach):
      * html/HTMLFrameSetElement.h:
      * html/HTMLImageElement.cpp:
      (WebCore::HTMLImageElement::attach):
      * html/HTMLImageElement.h:
      * html/HTMLInputElement.cpp:
      (WebCore::HTMLInputElement::attach):
      (WebCore::HTMLInputElement::detach):
      * html/HTMLInputElement.h:
      * html/HTMLLIElement.cpp:
      (WebCore::HTMLLIElement::attach):
      * html/HTMLLIElement.h:
      * html/HTMLMediaElement.cpp:
      (WebCore::HTMLMediaElement::attach):
      * html/HTMLMediaElement.h:
      * html/HTMLOptGroupElement.cpp:
      (WebCore::HTMLOptGroupElement::attach):
      (WebCore::HTMLOptGroupElement::detach):
      * html/HTMLOptGroupElement.h:
      * html/HTMLOptionElement.cpp:
      (WebCore::HTMLOptionElement::attach):
      (WebCore::HTMLOptionElement::detach):
      * html/HTMLOptionElement.h:
      * html/HTMLPlugInElement.cpp:
      (WebCore::HTMLPlugInElement::detach):
      * html/HTMLPlugInElement.h:
      * html/HTMLPlugInImageElement.cpp:
      (WebCore::HTMLPlugInImageElement::attach):
      (WebCore::HTMLPlugInImageElement::detach):
      * html/HTMLPlugInImageElement.h:
      * html/HTMLProgressElement.cpp:
      (WebCore::HTMLProgressElement::attach):
      * html/HTMLProgressElement.h:
      * html/HTMLTextAreaElement.cpp:
      (WebCore::HTMLTextAreaElement::attach):
      * html/HTMLTextAreaElement.h:
      * html/HTMLVideoElement.cpp:
      (WebCore::HTMLVideoElement::attach):
      * html/HTMLVideoElement.h:
      * html/PluginDocument.cpp:
      (WebCore::PluginDocument::detach):
      * html/PluginDocument.h:
      * html/shadow/InsertionPoint.cpp:
      (WebCore::InsertionPoint::attach):
      (WebCore::InsertionPoint::detach):
      * html/shadow/InsertionPoint.h:
      * html/shadow/SliderThumbElement.cpp:
      (WebCore::SliderThumbElement::detach):
      * html/shadow/SliderThumbElement.h:
      * html/shadow/SpinButtonElement.cpp:
      (WebCore::SpinButtonElement::detach):
      * html/shadow/SpinButtonElement.h:
      * html/shadow/TextControlInnerElements.cpp:
      (WebCore::SearchFieldCancelButtonElement::detach):
      (WebCore::InputFieldSpeechButtonElement::attach):
      (WebCore::InputFieldSpeechButtonElement::detach):
      * html/shadow/TextControlInnerElements.h:
      * loader/PlaceholderDocument.cpp:
      (WebCore::PlaceholderDocument::attach):
      * loader/PlaceholderDocument.h:
      * svg/SVGImageElement.cpp:
      (WebCore::SVGImageElement::attach):
      * svg/SVGImageElement.h:
      
      LayoutTests:
      
      Patch by Radu Stavila <stavila@adobe.com> on 2013-06-06
      Reviewed by Antti Koivisto.
      
      * fast/regions/hover-display-block-inline-expected.txt: Added.
      * fast/regions/hover-display-block-inline.html: Added.
      * fast/regions/hover-display-block-none-expected.txt: Added.
      * fast/regions/hover-display-block-none.html: Added.
      * fast/events/drag-display-none-element-expected.txt:
      * fast/events/drag-display-none-element:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@151282 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      83fb9b9a
  10. 19 May, 2013 1 commit
    • darin@apple.com's avatar
      Use Element instead of Node in DragState, also redo DragState struct · fd6ff3dc
      darin@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=116411
      
      Reviewed by Sam Weinig.
      
      The drag source is an element, so use RefPtr<Element> instead of RefPtr<Node>.
      
      Also, the entire drag state is about dragging, so no need for the word "drag" in the
      name of its members. Also, it's a struct, so the members don't need m_ prefixes.
      
      * page/DragController.cpp: Removed unneeded include of Node.h since it's included by
      Element.h, which is also included.
      (WebCore::DragController::draggableElement): Renamed from Node to Element and changed
      the types and names of arguments accordingly. Also made this function handle a
      startElement of 0 so callers don't need to. Also updated for changes to DragState members.
      (WebCore::DragController::startDrag): Updated for changes to DragState members.
      Since dragSource can only be an element, was able to get rid of isElementNode checks.
      
      * page/DragController.h: Fixed style of forward declarations of structs. Updated for
      change of draggableNode to draggableElement. Also removed declarations of nonexistent
      selectionDraggingRect and doDrag functions.
      
      * page/DragState.h: Rewrote practically this whole header. Added an include of Element
      instead of Node since that's what we use now. Removed includes that are redundant.
      There's no problem copying a DragState, so removed WTF_MAKE_NONCOPYABLE. There's no need
      to allocate a DragState on the heap, so removed WTF_MAKE_FAST_ALLOCATED. The event dispatch
      boolean is never set to a constant, so there's no need for a policy enum; it can just be
      a boolean. Removed the "m_" prefixes from the struct members, since this is a struct with
      public members and we don't use the prefix in those cases. Removed the word "drag" from the
      struct member names since this entire struct is about dragging and has drag in its name.
      Left the comments mostly intact, even though I'm not certain of their value.
      
      * page/EventHandler.cpp:
      (WebCore::EventHandler::handleMousePressEvent): Updated for changes to DragState.
      (WebCore::EventHandler::eventMayStartDrag):
      Use innerElement instead of innerNode to call draggableElement instead of draggableNode.
      (WebCore::EventHandler::updateDragAndDrop): Updated for changes to DragState.
      (WebCore::EventHandler::cancelDragAndDrop): Ditto.
      (WebCore::EventHandler::handleWheelEvent): Added FIXME.
      (WebCore::EventHandler::dragHysteresisExceeded): Updated for changes to DragState.
      (WebCore::EventHandler::freeClipboard): Updated for changes to DragState. Also re-added
      code to release the clipboard object, which is needed here to avoid keeping it around in
      memory until the next drag.
      (WebCore::EventHandler::dragSourceEndedAt): Updated for changes to DragState.
      (WebCore::EventHandler::updateDragStateAfterEditDragIfNeeded): Ditto.
      (WebCore::EventHandler::dispatchDragSrcEvent): Ditto.
      (WebCore::EventHandler::handleDrag): Updated for changes to DragState. Use innerElement
      instead of innerNode to call draggableElement instead of draggableNode. No longer need to
      null check innerElement because draggableElement does that. Removed unneeded else that was
      setting m_dragSrc to zero since it's guaranteed to already be zero.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@150354 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      fd6ff3dc
  11. 15 May, 2013 1 commit
    • andersca@apple.com's avatar
      Frame::editor() should return a reference · b4170928
      andersca@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=116037
      
      Reviewed by Darin Adler.
      
      Source/WebCore:
      
      A frame's editor can never be null. Change Frame::editor() to return a reference to reflect this.
      Also, make Frame::m_editor a const member variable so nobody will accidentally set it to null.
      
      * accessibility/AccessibilityObject.cpp:
      (WebCore::AccessibilityObject::hasMisspelling):
      * accessibility/mac/WebAccessibilityObjectWrapperMac.mm:
      (AXAttributeStringSetSpelling):
      * dom/ContainerNode.cpp:
      (WebCore::ContainerNode::cloneChildNodes):
      * dom/Document.cpp:
      (WebCore::acceptsEditingFocus):
      (WebCore::Document::setFocusedNode):
      (WebCore::command):
      * editing/AlternativeTextController.cpp:
      (WebCore::AlternativeTextController::timerFired):
      (WebCore::AlternativeTextController::applyDictationAlternative):
      * editing/CompositeEditCommand.cpp:
      (WebCore::EditCommandComposition::unapply):
      (WebCore::EditCommandComposition::reapply):
      (WebCore::CompositeEditCommand::apply):
      (WebCore::CompositeEditCommand::moveParagraphs):
      * editing/DeleteButton.cpp:
      (WebCore::DeleteButton::defaultEventHandler):
      * editing/DeleteButtonController.cpp:
      (WebCore::DeleteButtonController::show):
      * editing/DeleteButtonController.h:
      (WebCore::DeleteButtonControllerDisableScope::DeleteButtonControllerDisableScope):
      (WebCore::DeleteButtonControllerDisableScope::~DeleteButtonControllerDisableScope):
      * editing/DeleteSelectionCommand.cpp:
      (WebCore::DeleteSelectionCommand::mergeParagraphs):
      (WebCore::DeleteSelectionCommand::doApply):
      * editing/EditCommand.cpp:
      (WebCore::EditCommand::EditCommand):
      * editing/EditingStyle.cpp:
      (WebCore::StyleChange::StyleChange):
      * editing/Editor.cpp:
      (WebCore::Editor::markMisspellingsAfterTypingToWord):
      * editing/EditorCommand.cpp:
      (WebCore::applyCommandToFrame):
      (WebCore::executeToggleStyle):
      (WebCore::executeApplyParagraphStyle):
      (WebCore::expandSelectionToGranularity):
      (WebCore::stateStyle):
      (WebCore::valueStyle):
      (WebCore::executeCopy):
      (WebCore::executeCut):
      (WebCore::executeDefaultParagraphSeparator):
      (WebCore::executeDelete):
      (WebCore::executeDeleteBackward):
      (WebCore::executeDeleteBackwardByDecomposingPreviousCharacter):
      (WebCore::executeDeleteForward):
      (WebCore::executeDeleteToBeginningOfLine):
      (WebCore::executeDeleteToBeginningOfParagraph):
      (WebCore::executeDeleteToEndOfLine):
      (WebCore::executeDeleteToEndOfParagraph):
      (WebCore::executeDeleteToMark):
      (WebCore::executeDeleteWordBackward):
      (WebCore::executeDeleteWordForward):
      (WebCore::executeFindString):
      (WebCore::executeForwardDelete):
      (WebCore::executeIgnoreSpelling):
      (WebCore::executeInsertNewline):
      (WebCore::executeMakeTextWritingDirectionLeftToRight):
      (WebCore::executeMakeTextWritingDirectionNatural):
      (WebCore::executeMakeTextWritingDirectionRightToLeft):
      (WebCore::executeToggleOverwrite):
      (WebCore::executePaste):
      (WebCore::executePasteGlobalSelection):
      (WebCore::executePasteAndMatchStyle):
      (WebCore::executePasteAsPlainText):
      (WebCore::executeRedo):
      (WebCore::executeRemoveFormat):
      (WebCore::executeSelectToMark):
      (WebCore::executeSetMark):
      (WebCore::executeStyleWithCSS):
      (WebCore::executeUseCSS):
      (WebCore::executeSwapWithMark):
      (WebCore::executeTakeFindStringFromSelection):
      (WebCore::executeTranspose):
      (WebCore::executeUndo):
      (WebCore::executeYank):
      (WebCore::executeYankAndSelect):
      (WebCore::supportedCopyCut):
      (WebCore::supportedPaste):
      (WebCore::enabledVisibleSelection):
      (WebCore::enabledVisibleSelectionAndMark):
      (WebCore::enableCaretInEditableText):
      (WebCore::enabledCopy):
      (WebCore::enabledCut):
      (WebCore::enabledInEditableText):
      (WebCore::enabledDelete):
      (WebCore::enabledPaste):
      (WebCore::enabledRedo):
      (WebCore::enabledTakeFindStringFromSelection):
      (WebCore::enabledUndo):
      (WebCore::stateOrderedList):
      (WebCore::stateStyleWithCSS):
      (WebCore::stateUnorderedList):
      (WebCore::valueDefaultParagraphSeparator):
      * editing/FrameSelection.cpp:
      (WebCore::shouldAlwaysUseDirectionalSelection):
      (WebCore::FrameSelection::setSelection):
      (WebCore::FrameSelection::nextWordPositionForPlatform):
      (WebCore::FrameSelection::modifyMovingRight):
      (WebCore::FrameSelection::modifyMovingLeft):
      (WebCore::FrameSelection::modify):
      (WebCore::shouldStopBlinkingDueToTypingCommand):
      (WebCore::FrameSelection::shouldDeleteSelection):
      (WebCore::FrameSelection::shouldChangeSelection):
      * editing/InsertTextCommand.cpp:
      (WebCore::InsertTextCommand::doApply):
      * editing/SpellChecker.cpp:
      (WebCore::SpellChecker::didCheck):
      * editing/SpellingCorrectionCommand.cpp:
      * editing/TypingCommand.cpp:
      (WebCore::TypingCommand::insertText):
      (WebCore::TypingCommand::lastTypingCommandIfStillOpenForTyping):
      (WebCore::TypingCommand::markMisspellingsAfterTyping):
      (WebCore::TypingCommand::typingAddedToOpenCommand):
      (WebCore::TypingCommand::deleteKeyPressed):
      (WebCore::TypingCommand::forwardDeleteKeyPressed):
      * editing/htmlediting.cpp:
      (WebCore::createDefaultParagraphElement):
      * editing/mac/EditorMac.mm:
      (WebCore::Editor::pasteWithPasteboard):
      * editing/markup.cpp:
      (WebCore::createMarkup):
      * html/HTMLInputElement.cpp:
      (WebCore::HTMLInputElement::endEditing):
      * html/HTMLTextAreaElement.cpp:
      (WebCore::HTMLTextAreaElement::subtreeHasChanged):
      * html/TextFieldInputType.cpp:
      (WebCore::TextFieldInputType::handleKeydownEvent):
      (WebCore::TextFieldInputType::didSetValueByUserEdit):
      * loader/FrameLoader.cpp:
      (WebCore::FrameLoader::closeURL):
      (WebCore::FrameLoader::didOpenURL):
      (WebCore::FrameLoader::clear):
      * page/ContextMenuController.cpp:
      (WebCore::insertUnicodeCharacter):
      (WebCore::ContextMenuController::contextMenuItemSelected):
      (WebCore::ContextMenuController::populate):
      (WebCore::ContextMenuController::checkOrEnableIfNeeded):
      * page/DOMWindow.cpp:
      (WebCore::DOMWindow::find):
      * page/DragController.cpp:
      (WebCore::DragController::dispatchTextInputEventFor):
      (WebCore::DragController::concludeEditDrag):
      (WebCore::DragController::startDrag):
      * page/EventHandler.cpp:
      (WebCore::EventHandler::selectClosestWordFromMouseEvent):
      (WebCore::EventHandler::handleMousePressEventSingleClick):
      (WebCore::EventHandler::handlePasteGlobalSelection):
      (WebCore::EventHandler::sendContextMenuEvent):
      (WebCore::EventHandler::sendContextMenuEventForKey):
      (WebCore::EventHandler::keyEvent):
      (WebCore::EventHandler::defaultKeyboardEventHandler):
      (WebCore::EventHandler::defaultTextInputEventHandler):
      (WebCore::EventHandler::defaultBackspaceEventHandler):
      * page/FocusController.cpp:
      (WebCore::relinquishesEditingFocus):
      * page/Frame.cpp:
      (WebCore::Frame::rangeForPoint):
      * page/Frame.h:
      (Frame):
      (WebCore::Frame::editor):
      * page/Page.cpp:
      (WebCore::Page::findString):
      (WebCore::Page::findStringMatchingRanges):
      (WebCore::Page::rangeOfString):
      (WebCore::Page::markAllMatchesForText):
      (WebCore::Page::setDeviceScaleFactor):
      * platform/mac/ClipboardMac.mm:
      (WebCore::ClipboardMac::writeRange):
      * platform/mac/DragDataMac.mm:
      (WebCore::DragData::asURL):
      * platform/mac/PasteboardMac.mm:
      (WebCore::Pasteboard::getStringSelection):
      (WebCore::Pasteboard::getDataSelection):
      (WebCore::Pasteboard::writeSelectionForTypes):
      (WebCore::writeURLForTypes):
      (WebCore::Pasteboard::plainText):
      (WebCore::documentFragmentWithRTF):
      (WebCore::Pasteboard::documentFragment):
      * rendering/HitTestResult.cpp:
      (WebCore::HitTestResult::dictationAlternatives):
      * rendering/InlineTextBox.cpp:
      (WebCore::InlineTextBox::paint):
      (WebCore::InlineTextBox::paintTextMatchMarker):
      * rendering/RenderBlock.cpp:
      (WebCore::RenderBlock::positionForPointWithInlineChildren):
      * testing/Internals.cpp:
      (WebCore::spellchecker):
      (WebCore::Internals::resetToConsistentState):
      (WebCore::Internals::hasSpellingMarker):
      (WebCore::Internals::hasAutocorrectedMarker):
      (WebCore::Internals::setContinuousSpellCheckingEnabled):
      (WebCore::Internals::setAutomaticQuoteSubstitutionEnabled):
      (WebCore::Internals::setAutomaticLinkDetectionEnabled):
      (WebCore::Internals::setAutomaticDashSubstitutionEnabled):
      (WebCore::Internals::setAutomaticTextReplacementEnabled):
      (WebCore::Internals::setAutomaticSpellingCorrectionEnabled):
      (WebCore::Internals::isOverwriteModeEnabled):
      (WebCore::Internals::toggleOverwriteModeEnabled):
      (WebCore::Internals::hasGrammarMarker):
      
      Source/WebKit/blackberry:
      
      * WebCoreSupport/EditorClientBlackBerry.cpp:
      (WebCore::EditorClientBlackBerry::shouldSpellCheckFocusedField):
      (WebCore::EditorClientBlackBerry::handleKeyboardEvent):
      * WebKitSupport/DOMSupport.cpp:
      (BlackBerry::WebKit::DOMSupport::elementHasContinuousSpellCheckingEnabled):
      * WebKitSupport/InPageSearchManager.cpp:
      (BlackBerry::WebKit::InPageSearchManager::findAndMarkText):
      (BlackBerry::WebKit::InPageSearchManager::scopeStringMatches):
      * WebKitSupport/SelectionHandler.cpp:
      (BlackBerry::WebKit::SelectionHandler::selectedText):
      
      Source/WebKit/efl:
      
      * WebCoreSupport/DumpRenderTreeSupportEfl.cpp:
      (DumpRenderTreeSupportEfl::executeCoreCommandByName):
      (DumpRenderTreeSupportEfl::isCommandEnabled):
      * WebCoreSupport/EditorClientEfl.cpp:
      (WebCore::EditorClientEfl::respondToChangedSelection):
      (WebCore::EditorClientEfl::handleEditingKeyboardEvent):
      * ewk/ewk_frame.cpp:
      (ewk_frame_editable_set):
      (ewk_frame_selection_get):
      (ewk_frame_text_search):
      (ewk_frame_text_matches_mark):
      (ewk_frame_text_matches_highlight_set):
      (ewk_frame_text_matches_highlight_get):
      * ewk/ewk_view.cpp:
      (ewk_view_selection_get):
      (ewk_view_editor_command_execute):
      
      Source/WebKit/gtk:
      
      * WebCoreSupport/ChromeClientGtk.cpp:
      (WebKit::ChromeClient::paint):
      * WebCoreSupport/DumpRenderTreeSupportGtk.cpp:
      (DumpRenderTreeSupportGtk::executeCoreCommandByName):
      (DumpRenderTreeSupportGtk::isCommandEnabled):
      * WebCoreSupport/EditorClientGtk.cpp:
      (WebKit::EditorClient::respondToChangedSelection):
      (WebKit::EditorClient::executePendingEditorCommands):
      (WebKit::EditorClient::handleKeyboardEvent):
      * WebCoreSupport/WebViewInputMethodFilter.cpp:
      (WebKit::WebViewInputMethodFilter::canEdit):
      (WebKit::WebViewInputMethodFilter::confirmCompositionText):
      (WebKit::WebViewInputMethodFilter::confirmCurrentComposition):
      (WebKit::WebViewInputMethodFilter::cancelCurrentComposition):
      (WebKit::WebViewInputMethodFilter::setPreedit):
      * webkit/webkitwebframe.cpp:
      (webkit_web_frame_replace_selection):
      * webkit/webkitwebview.cpp:
      (getLocationForKeyboardGeneratedContextMenu):
      (webkit_web_view_focus_in_event):
      (webkit_web_view_real_select_all):
      (webkit_web_view_real_cut_clipboard):
      (webkit_web_view_real_copy_clipboard):
      (webkit_web_view_real_undo):
      (webkit_web_view_real_redo):
      (webkit_web_view_real_paste_clipboard):
      (webkit_web_view_set_highlight_text_matches):
      (webkit_web_view_can_cut_clipboard):
      (webkit_web_view_can_copy_clipboard):
      (webkit_web_view_can_paste_clipboard):
      (webkit_web_view_delete_selection):
      (webkit_web_view_set_editable):
      (webkit_web_view_can_undo):
      (webkit_web_view_can_redo):
      
      Source/WebKit/mac:
      
      * WebView/WebFrame.mm:
      (-[WebFrame _selectedString]):
      (-[WebFrame _firstRectForDOMRange:]):
      (-[WebFrame _markDOMRange]):
      (-[WebFrame _insertParagraphSeparatorInQuotedContent]):
      (-[WebFrame _setTypingStyle:withUndoAction:]):
      (-[WebFrame _replaceSelectionWithFragment:selectReplacement:smartReplace:matchStyle:]):
      * WebView/WebHTMLRepresentation.mm:
      (-[WebHTMLRepresentation finishedLoadingWithDataSource:]):
      * WebView/WebHTMLView.mm:
      (-[WebHTMLView _pasteWithPasteboard:allowPlainText:]):
      (-[WebHTMLView _shouldDeleteRange:]):
      (-[WebHTMLView _canEdit]):
      (-[WebHTMLView _canEditRichly]):
      (-[WebHTMLView _insertOrderedList]):
      (-[WebHTMLView _insertUnorderedList]):
      (-[WebHTMLView _canIncreaseSelectionListLevel]):
      (-[WebHTMLView _canDecreaseSelectionListLevel]):
      (-[WebHTMLView _increaseSelectionListLevel]):
      (-[WebHTMLView _increaseSelectionListLevelOrdered]):
      (-[WebHTMLView _increaseSelectionListLevelUnordered]):
      (-[WebHTMLView _decreaseSelectionListLevel]):
      (-[WebHTMLView Editor::coreCommandBySelector:]):
      (-[WebHTMLView Editor::coreCommandByName:]):
      (-[WebHTMLView validateUserInterfaceItemWithoutDelegate:]):
      (-[WebHTMLView becomeFirstResponder]):
      (-[WebHTMLView _selectionStartFontAttributesAsRTF]):
      (-[WebHTMLView _applyStyleToSelection:withUndoAction:]):
      (-[WebHTMLView _changeCSSColorUsingSelector:inRange:]):
      (-[WebHTMLView checkSpelling:]):
      (-[WebHTMLView showGuessPanel:]):
      (-[WebHTMLView toggleBaseWritingDirection:]):
      (-[WebHTMLView changeBaseWritingDirection:]):
      (-[WebHTMLView _changeBaseWritingDirectionTo:]):
      (-[WebHTMLView _updateFontPanel]):
      (-[WebHTMLView markedRange]):
      (-[WebHTMLView hasMarkedText]):
      (-[WebHTMLView unmarkText]):
      (-[WebHTMLView setMarkedText:selectedRange:]):
      (-[WebHTMLView doCommandBySelector:]):
      (-[WebHTMLView insertText:]):
      (-[WebHTMLView _updateSelectionForInputManager]):
      (-[WebHTMLView countMatchesForText:inDOMRange:options:limit:markMatches:]):
      (-[WebHTMLView setMarkedTextMatchesAreHighlighted:]):
      (-[WebHTMLView markedTextMatchesAreHighlighted]):
      (-[WebHTMLView _findString:options:]):
      * WebView/WebView.mm:
      (-[WebView _executeCoreCommandByName:value:]):
      (-[WebView editableDOMRangeForPoint:]):
      (-[WebView setEditable:]):
      (-[WebView deleteSelection]):
      (-[WebView applyStyle:]):
      (-[WebView typingAttributes]):
      (-[WebView _simplifyMarkup:endNode:]):
      (-[WebView handleAcceptedAlternativeText:]):
      
      Source/WebKit/qt:
      
      * WebCoreSupport/DumpRenderTreeSupportQt.cpp:
      (DumpRenderTreeSupportQt::executeCoreCommandByName):
      (DumpRenderTreeSupportQt::isCommandEnabled):
      (DumpRenderTreeSupportQt::firstRectForCharacterRange):
      * WebCoreSupport/EditorClientQt.cpp:
      (WebCore::EditorClientQt::respondToChangedSelection):
      (WebCore::EditorClientQt::registerUndoStep):
      (WebCore::EditorClientQt::handleKeyboardEvent):
      * WebCoreSupport/QWebPageAdapter.cpp:
      (QWebPageAdapter::selectedText):
      (QWebPageAdapter::selectedHtml):
      (QWebPageAdapter::setContentEditable):
      
      Source/WebKit/win:
      
      * WebCoreSupport/WebContextMenuClient.cpp:
      (WebContextMenuClient::searchWithGoogle):
      * WebFrame.cpp:
      (WebFrame::hasSpellingMarker):
      (WebFrame::setTextDirection):
      (WebFrame::selectedString):
      (WebFrame::selectAll):
      * WebView.cpp:
      (WebView::execCommand):
      (WebView::handleEditingKeyboardEvent):
      (WebView::executeCoreCommandByName):
      (WebView::selectedText):
      (WebView::deleteEnabled):
      (WebView::editingEnabled):
      (WebView::replaceSelectionWithText):
      (WebView::copy):
      (WebView::cut):
      (WebView::paste):
      (WebView::copyURL):
      (WebView::delete_):
      (WebView::checkSpelling):
      (WebView::showGuessPanel):
      (WebView::clearUndoRedoOperations):
      (WebView::prepareCandidateWindow):
      (WebView::resetIME):
      (WebView::updateSelectionForIME):
      (WebView::onIMEComposition):
      (WebView::onIMEEndComposition):
      (WebView::onIMERequestCharPosition):
      (WebView::onIMERequest):
      (WebView::setCompositionForTesting):
      (WebView::hasCompositionForTesting):
      (WebView::confirmCompositionForTesting):
      (WebView::compositionRangeForTesting):
      (WebView::firstRectForCharacterRangeForTesting):
      (WebView::selectedRangeForTesting):
      
      Source/WebKit/wince:
      
      * WebCoreSupport/EditorClientWinCE.cpp:
      (WebKit::EditorClientWinCE::handleEditingKeyboardEvent):
      
      Source/WebKit2:
      
      * WebProcess/WebCoreSupport/WebContextMenuClient.cpp:
      (WebKit::WebContextMenuClient::searchWithGoogle):
      * WebProcess/WebCoreSupport/WebEditorClient.cpp:
      (WebKit::WebEditorClient::updateGlobalSelection):
      * WebProcess/WebCoreSupport/efl/WebEditorClientEfl.cpp:
      (WebKit::WebEditorClient::handleInputMethodKeydown):
      * WebProcess/WebCoreSupport/gtk/WebEditorClientGtk.cpp:
      (WebKit::WebEditorClient::executePendingEditorCommands):
      (WebKit::WebEditorClient::handleKeyboardEvent):
      * WebProcess/WebCoreSupport/mac/WebContextMenuClientMac.mm:
      (WebKit::WebContextMenuClient::searchWithGoogle):
      (WebKit::WebContextMenuClient::searchWithSpotlight):
      * WebProcess/WebCoreSupport/mac/WebEditorClientMac.mm:
      (WebKit::changeWordCase):
      * WebProcess/WebPage/WebFrame.cpp:
      (WebKit::WebFrame::selectionAsString):
      (WebKit::WebFrame::setTextDirection):
      * WebProcess/WebPage/WebPage.cpp:
      (WebKit::WebPage::editorState):
      (WebKit::WebPage::executeEditingCommand):
      (WebKit::WebPage::isEditingCommandEnabled):
      (WebKit::WebPage::validateCommand):
      (WebKit::WebPage::handleEditingKeyboardEvent):
      (WebKit::WebPage::advanceToNextMisspelling):
      (WebKit::WebPage::uppercaseWord):
      (WebKit::WebPage::lowercaseWord):
      (WebKit::WebPage::capitalizeWord):
      (WebKit::WebPage::replaceSelectionWithText):
      (WebKit::WebPage::handleAlternativeTextUIResult):
      (WebKit::WebPage::setCompositionForTesting):
      (WebKit::WebPage::hasCompositionForTesting):
      (WebKit::WebPage::confirmCompositionForTesting):
      (WebKit::WebPage::setComposition):
      (WebKit::WebPage::cancelComposition):
      * WebProcess/WebPage/efl/WebPageEfl.cpp:
      (WebKit::WebPage::confirmComposition):
      (WebKit::WebPage::setComposition):
      (WebKit::WebPage::cancelComposition):
      * WebProcess/WebPage/mac/WebPageMac.mm:
      (WebKit::WebPage::executeKeypressCommandsInternal):
      (WebKit::WebPage::handleEditingKeyboardEvent):
      (WebKit::WebPage::setComposition):
      (WebKit::WebPage::confirmComposition):
      (WebKit::WebPage::cancelComposition):
      (WebKit::WebPage::insertText):
      (WebKit::WebPage::insertDictatedText):
      (WebKit::WebPage::getMarkedRange):
      (WebKit::WebPage::firstRectForCharacterRange):
      (WebKit::WebPage::readSelectionFromPasteboard):
      (WebKit::WebPage::getStringSelectionForPasteboard):
      (WebKit::WebPage::getDataSelectionForPasteboard):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@150140 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      b4170928
  12. 14 Apr, 2013 1 commit
    • akling@apple.com's avatar
      Move create() methods from StylePropertySet to MutableStylePropertySet. · 1290708b
      akling@apple.com authored
      <http://webkit.org/b/114574>
      
      Reviewed by Antti Koivisto.
      
      Move the two create() methods that create MutableStylePropertySets from StylePropertySet
      to MutableStylePropertySet, and make them actually return MutableStylePropertySets.
      Switch to using {Pass,}RefPtr<MutableStylePropertySet> where appropriate to keep things building.
      
      * css/CSSComputedStyleDeclaration.cpp:
      (WebCore::CSSComputedStyleDeclaration::copyPropertiesInSet):
      * css/CSSParser.cpp:
      (WebCore::CSSParser::parseFontFaceValue):
      * css/DOMWindowCSS.cpp:
      (WebCore::DOMWindowCSS::supports):
      * css/ElementRuleCollector.cpp:
      (WebCore::leftToRightDeclaration):
      (WebCore::rightToLeftDeclaration):
      * css/FontLoader.cpp:
      (WebCore::FontLoader::resolveFontStyle):
      * css/StylePropertySet.cpp:
      (WebCore::StylePropertySet::copyPropertiesInSet):
      (WebCore::MutableStylePropertySet::create):
      * css/StylePropertySet.h:
      (StylePropertySet):
      (MutableStylePropertySet):
      * css/StyleResolver.cpp:
      (WebCore::StyleResolver::resolveVariables):
      * css/WebKitCSSMatrix.cpp:
      (WebCore::WebKitCSSMatrix::setMatrixValue):
      * dom/Attr.cpp:
      (WebCore::Attr::style):
      * dom/Document.cpp:
      (WebCore::Document::createCSSStyleDeclaration):
      * dom/StyledElement.cpp:
      (WebCore::StyledElement::ensureMutableInlineStyle):
      (WebCore::StyledElement::rebuildPresentationAttributeStyle):
      * editing/ApplyStyleCommand.cpp:
      (WebCore::copyStyleOrCreateEmpty):
      * editing/EditingStyle.cpp:
      (WebCore::editingStyleFromComputedStyle):
      (WebCore::HTMLAttributeEquivalent::attributeValueAsCSSValue):
      (WebCore::EditingStyle::setProperty):
      (WebCore::EditingStyle::extractAndRemoveTextDirection):
      (WebCore::styleFromMatchedRulesForElement):
      (WebCore::EditingStyle::mergeStyleFromRulesForSerialization):
      (WebCore::EditingStyle::forceInline):
      * editing/Editor.cpp:
      (WebCore::Editor::setBaseWritingDirection):
      * editing/EditorCommand.cpp:
      (WebCore::executeApplyStyle):
      (WebCore::executeToggleStyleInList):
      (WebCore::executeApplyParagraphStyle):
      (WebCore::executeMakeTextWritingDirectionLeftToRight):
      (WebCore::executeMakeTextWritingDirectionNatural):
      (WebCore::executeMakeTextWritingDirectionRightToLeft):
      * html/HTMLTableElement.cpp:
      (WebCore::leakBorderStyle):
      (WebCore::HTMLTableElement::createSharedCellStyle):
      (WebCore::leakGroupBorderStyle):
      * html/canvas/CanvasRenderingContext2D.cpp:
      (WebCore::CanvasRenderingContext2D::setFont):
      * inspector/InspectorStyleSheet.cpp:
      (WebCore::InspectorStyle::setPropertyText):
      (WebCore::InspectorStyleSheetForInlineStyle::getStyleAttributeRanges):
      * page/DragController.cpp:
      (WebCore::DragController::concludeEditDrag):
      * svg/SVGElementRareData.h:
      (WebCore::SVGElementRareData::ensureAnimatedSMILStyleProperties):
      * svg/SVGFontFaceElement.cpp:
      (WebCore::SVGFontFaceElement::SVGFontFaceElement):
      * svg/SVGStyledElement.cpp:
      (WebCore::SVGStyledElement::getPresentationAttribute):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@148395 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      1290708b
  13. 08 Apr, 2013 2 commits
    • abecsi@webkit.org's avatar
      Fix the build with strict GCC 4.8 · a42ddd32
      abecsi@webkit.org authored
      Unreviewed build fix.
      
      Initialize dragImage to suppress GCC's warning about it being possibly used uninitialized,
      which results is a build failure with GCC 4.8 that sets -Werror=maybe-uninitialized.
      
      No new tests needed.
      
      * page/DragController.cpp:
      (WebCore::DragController::doImageDrag):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@147922 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      a42ddd32
    • carlosgc@webkit.org's avatar
      DragImage should not depend on Frame and CachedImage · baf91e99
      carlosgc@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=21357
      
      Reviewed by Sam Weinig.
      
      Remove Frame and CachedImage dependencies from DragImage.
      
      * dom/Clipboard.h:
      (WebCore): Add forward delcaration for CacheImage since it's not
      included anymore in DragImage.h.
      * page/DragController.cpp:
      (WebCore::DragController::startDrag): Use
      Frame::dragImageForSelection() and call
      dissolveDragImageToFraction() for the returned DragImage. Pass the
      font rendering mode to createDragImageForLink, instead of a Frame
      that is only used to get the font rendering mode.
      (WebCore::DragController::doImageDrag): Get the suggested filename
      for the cached image and pass it to
      createDragImageIconForCachedImageFilename().
      * platform/DragImage.cpp:
      (WebCore::createDragImageForLink): Receive a FontRenderingMode
      instead of a Frame.
      * platform/DragImage.h:
      (WebCore): Remove createDragImageForSelection, change
      createDragImageForLink to receive a FontRenderingMode instead of a
      frame, and rename createDragImageIconForCachedImage as
      createDragImageIconForCachedImageFilename since it nows received
      the suggested filename of the cached image.
      * platform/blackberry/DragImageBlackBerry.cpp:
      (WebCore::createDragImageIconForCachedImageFilename): Adapt to API
      changes.
      * platform/efl/DragImageEfl.cpp:
      (WebCore::createDragImageIconForCachedImageFilename): Ditto.
      * platform/gtk/DragImageGtk.cpp:
      (WebCore::createDragImageIconForCachedImageFilename): Ditto.
      * platform/mac/DragImageMac.mm:
      (WebCore::dissolveDragImageToFraction): Return early if the passed
      image is NULL.
      (WebCore::createDragImageIconForCachedImageFilename): Adapt to API
      changes.
      (WebCore::createDragImageForLink): Ditto.
      * platform/qt/DragImageQt.cpp:
      (WebCore::createDragImageIconForCachedImageFilename): Ditto.
      * platform/win/DragImageWin.cpp:
      (WebCore::createDragImageIconForCachedImageFilename): Ditto.
      (WebCore::createDragImageForLink): Ditto.
      * platform/wx/DragImageWx.cpp:
      (WebCore::createDragImageIconForCachedImageFilename): Ditto.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@147912 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      baf91e99
  14. 28 Mar, 2013 1 commit
    • falken@chromium.org's avatar
      Refactoring: Replace Element::disabled and isEnabledFormControl with isDisabledFormControl · 2113254c
      falken@chromium.org authored
      https://bugs.webkit.org/show_bug.cgi?id=113273
      
      Reviewed by Kent Tamura.
      
      Element::disabled is about form controls and Element::isEnabledFormControl
      is redundant with it, so replace them with a single function
      Element::isDisabledFormControl.
      
      Source/WebCore:
      
      No new tests, there should be no behavior change.
      
      * accessibility/AccessibilityListBox.cpp:
      (WebCore::AccessibilityListBox::canSetSelectedChildrenAttribute):
      * accessibility/AccessibilityListBoxOption.cpp:
      (WebCore::AccessibilityListBoxOption::canSetSelectedAttribute):
      * accessibility/AccessibilityMenuList.cpp:
      (WebCore::AccessibilityMenuList::canSetFocusAttribute):
      * accessibility/AccessibilityMenuListOption.cpp:
      (WebCore::AccessibilityMenuListOption::isEnabled):
      * accessibility/AccessibilityNodeObject.cpp:
      (WebCore::AccessibilityNodeObject::isEnabled):
      (WebCore::AccessibilityNodeObject::actionElement):
      (WebCore::AccessibilityNodeObject::canSetFocusAttribute):
      * css/SelectorChecker.cpp:
      (WebCore::SelectorChecker::checkOne):
      * css/StyleResolver.cpp:
      (WebCore::StyleResolver::canShareStyleWithControl):
      * dom/Element.cpp:
      (WebCore::Element::isDisabledFormControl):
      * dom/Element.h:
      (Element):
      (WebCore::isDisabledFormControl): Add helper function for convenience.
      (WebCore):
      * dom/EventDispatcher.cpp:
      (WebCore::EventDispatcher::dispatchSimulatedClick):
      * dom/GestureEvent.cpp:
      (WebCore::GestureEventDispatchMediator::dispatchEvent):
      * dom/MouseEvent.cpp:
      (WebCore::MouseEventDispatchMediator::dispatchEvent):
      * dom/Node.cpp:
      (WebCore::Node::handleLocalEvents):
      (WebCore::Node::willRespondToMouseMoveEvents):
      (WebCore::Node::willRespondToMouseClickEvents):
      (WebCore::Node::willRespondToTouchEvents):
      * html/BaseMultipleFieldsDateAndTimeInputType.cpp:
      (WebCore::BaseMultipleFieldsDateAndTimeInputType::isEditControlOwnerDisabled):
      * html/DOMFormData.cpp:
      (WebCore::DOMFormData::DOMFormData):
      * html/FileInputType.cpp:
      (WebCore::FileInputType::handleDOMActivateEvent):
      (WebCore::FileInputType::disabledAttributeChanged):
      * html/HTMLButtonElement.cpp:
      (WebCore::HTMLButtonElement::defaultEventHandler):
      (WebCore::HTMLButtonElement::willRespondToMouseClickEvents):
      (WebCore::HTMLButtonElement::isSuccessfulSubmitButton):
      * html/HTMLCollection.cpp:
      (WebCore::isMatchingElement):
      * html/HTMLFormControlElement.cpp:
      (WebCore::HTMLFormControlElement::updateAncestorDisabledState):
      (WebCore::HTMLFormControlElement::isDisabledFormControl):
      (WebCore::HTMLFormControlElement::supportsFocus):
      * html/HTMLFormControlElement.h:
      (HTMLFormControlElement):
      (WebCore::HTMLFormControlElement::isDisabledOrReadOnly):
      * html/HTMLInputElement.cpp:
      (WebCore::HTMLInputElement::isSuccessfulSubmitButton):
      (WebCore::HTMLInputElement::willRespondToMouseClickEvents):
      * html/HTMLOptGroupElement.cpp:
      (WebCore::HTMLOptGroupElement::isDisabledFormControl):
      * html/HTMLOptGroupElement.h:
      (HTMLOptGroupElement):
      * html/HTMLOptionElement.cpp:
      (WebCore::HTMLOptionElement::isDisabledFormControl):
      * html/HTMLOptionElement.h:
      (HTMLOptionElement):
      * html/HTMLPlugInElement.cpp:
      (WebCore::HTMLPlugInElement::willRespondToMouseClickEvents):
      * html/HTMLSelectElement.cpp:
      (WebCore::HTMLSelectElement::nextValidIndex):
      (WebCore::HTMLSelectElement::updateListBoxSelection):
      (WebCore::HTMLSelectElement::recalcListItems):
      (WebCore::HTMLSelectElement::appendFormData):
      (WebCore::HTMLSelectElement::updateSelectedState):
      (WebCore::HTMLSelectElement::listBoxDefaultEventHandler):
      (WebCore::HTMLSelectElement::defaultEventHandler):
      (WebCore::HTMLSelectElement::optionAtIndex):
      * html/ImageInputType.cpp:
      (WebCore::ImageInputType::handleDOMActivateEvent):
      * html/ResetInputType.cpp:
      (WebCore::ResetInputType::handleDOMActivateEvent):
      * html/SubmitInputType.cpp:
      (WebCore::SubmitInputType::handleDOMActivateEvent):
      * html/shadow/SliderThumbElement.cpp:
      (WebCore::SliderThumbElement::isDisabledFormControl):
      (WebCore::SliderThumbElement::defaultEventHandler):
      (WebCore::SliderThumbElement::willRespondToMouseMoveEvents):
      (WebCore::SliderThumbElement::willRespondToMouseClickEvents):
      * html/shadow/SliderThumbElement.h:
      (SliderThumbElement):
      * html/shadow/SpinButtonElement.h:
      * html/shadow/TextFieldDecorationElement.cpp:
      (WebCore::TextFieldDecorationElement::updateImage):
      * loader/FormSubmission.cpp:
      (WebCore::FormSubmission::create):
      * page/DragController.cpp:
      (WebCore::DragController::tryDocumentDrag):
      (WebCore::DragController::concludeEditDrag):
      * rendering/RenderListBox.cpp:
      (WebCore::RenderListBox::addFocusRingRects):
      (WebCore::RenderListBox::paintItemForeground):
      * rendering/RenderMenuList.cpp:
      (WebCore::RenderMenuList::itemIsEnabled):
      * rendering/RenderTextControl.cpp:
      (WebCore::updateUserModifyProperty):
      * rendering/RenderTheme.cpp:
      (WebCore::RenderTheme::isEnabled):
      * rendering/RenderThemeMac.mm:
      (WebCore::getMediaUIPartStateFlags):
      * rendering/RenderThemeMacShared.mm:
      (WebCore::RenderThemeMacShared::adjustMenuListStyle):
      (WebCore::RenderThemeMacShared::paintSearchFieldCancelButton):
      * rendering/RenderThemeSafari.cpp:
      (WebCore::RenderThemeSafari::adjustMenuListStyle):
      
      Source/WebKit/blackberry:
      
      * WebCoreSupport/CredentialTransformData.cpp:
      (WebCore::CredentialTransformData::findPasswordFormFields):
      * WebKitSupport/DOMSupport.cpp:
      (BlackBerry::WebKit::DOMSupport::isTextBasedContentEditableElement):
      * WebKitSupport/InputHandler.cpp:
      (BlackBerry::WebKit::InputHandler::openSelectPopup):
      
      Source/WebKit/chromium:
      
      * src/WebFormControlElement.cpp:
      (WebKit::WebFormControlElement::isEnabled):
      * src/WebOptionElement.cpp:
      (WebKit::WebOptionElement::isEnabled):
      * src/WebPasswordFormUtils.cpp:
      (WebKit::findPasswordFormFields):
      * src/WebSearchableFormData.cpp:
      (HTMLNames::findSuitableSearchInputElement):
      (HTMLNames::buildSearchString):
      
      Source/WebKit/win:
      
      * DOMHTMLClasses.cpp:
      (DOMHTMLInputElement::disabled):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@147135 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      2113254c
  15. 27 Mar, 2013 1 commit
    • hayato@chromium.org's avatar
      Allow ShadowContents in HitTests by default. · af1544e8
      hayato@chromium.org authored
      https://bugs.webkit.org/show_bug.cgi?id=113171
      
      Reviewed by Dimitri Glazkov.
      
      Source/WebCore:
      
      HitTestRequest is widely used in WebCore, but AllowShadowContents
      flag is not turned on by default.  In most places, we can set the
      flag on.
      
      This change makes HitTests allow shadow contents by default.
      
      To track all existing HitTests which do not allow shadow contents,
      and discourage such a HitTest in the future, I've introduced
      disallowShadowContenet flag so that callers must turn on this flag
      explicitly if they want to disallow shadow contents in their HitTests.
      
      This change should be refactoring and should not include any
      behavior changes.  After this change, we'll investigate each place
      where disallowShadowContents is used step by step and get rid of
      the flag if it is okay to remove.
      
      No new tests, no behavior change.
      
      * dom/Document.h:
      (Document):
      * dom/TreeScope.cpp:
      (WebCore::nodeFromPoint):
      * editing/FrameSelection.cpp:
      (WebCore::FrameSelection::contains):
      * page/DragController.cpp:
      (WebCore::elementUnderMouse):
      (WebCore::DragController::canProcessDrag):
      (WebCore::DragController::startDrag):
      * page/EventHandler.cpp:
      (WebCore::EventHandler::handleMouseDraggedEvent):
      (WebCore::EventHandler::eventMayStartDrag):
      (WebCore::EventHandler::updateSelectionForMouseDrag):
      (WebCore::EventHandler::hitTestResultAtPoint):
      (WebCore::EventHandler::handleMousePressEvent):
      (WebCore::EventHandler::handleMouseDoubleClickEvent):
      (WebCore::EventHandler::handleMouseMoveEvent):
      (WebCore::EventHandler::handleMouseReleaseEvent):
      (WebCore::EventHandler::updateDragAndDrop):
      (WebCore::EventHandler::isInsideScrollbar):
      (WebCore::EventHandler::handleWheelEvent):
      (WebCore::EventHandler::handleGestureEvent):
      (WebCore::EventHandler::handleGestureLongPress):
      (WebCore::EventHandler::handleGestureScrollBegin):
      (WebCore::EventHandler::bestClickableNodeForTouchPoint):
      (WebCore::EventHandler::bestContextMenuNodeForTouchPoint):
      (WebCore::EventHandler::bestZoomableAreaForTouchPoint):
      (WebCore::EventHandler::sendContextMenuEvent):
      (WebCore::EventHandler::sendContextMenuEventForKey):
      (WebCore::EventHandler::hoverTimerFired):
      (WebCore::EventHandler::dragSourceEndedAt):
      (WebCore::EventHandler::handleDrag):
      (WebCore::EventHandler::handleTouchEvent):
      (WebCore::EventHandler::dispatchSyntheticTouchEventIfEnabled):
      * page/EventHandler.h:
      (EventHandler):
      * page/FocusController.cpp:
      (WebCore::updateFocusCandidateIfNeeded):
      * page/Frame.cpp:
      (WebCore::Frame::visiblePositionForPoint):
      * page/TouchDisambiguation.cpp:
      (WebCore::findGoodTouchTargets):
      * rendering/HitTestRequest.h:
      (WebCore::HitTestRequest::disallowsShadowContent):
      * rendering/HitTestResult.cpp:
      (WebCore::HitTestResult::addNodeToRectBasedTestResult):
      * rendering/RenderFlowThread.cpp:
      (WebCore::RenderFlowThread::hitTestFlowThreadPortionInRegion):
      * rendering/svg/RenderSVGResourceClipper.cpp:
      (WebCore::RenderSVGResourceClipper::hitTestClipContent):
      * testing/Internals.cpp:
      (WebCore::Internals::nodesFromRect):
      
      Source/WebKit/blackberry:
      
      * Api/WebPage.cpp:
      (BlackBerry::WebKit::WebPagePrivate::hitTestResult):
      * WebKitSupport/FatFingers.cpp:
      (BlackBerry::WebKit::FatFingers::getNodesFromRect):
      * WebKitSupport/ProximityDetector.cpp:
      (BlackBerry::WebKit::ProximityDetector::findBestPoint):
      * WebKitSupport/SelectionHandler.cpp:
      (BlackBerry::WebKit::visiblePositionForPointIgnoringClipping):
      
      Source/WebKit/chromium:
      
      * src/ContextMenuClientImpl.cpp:
      (WebKit::selectMisspelledWord):
      * src/WebFrameImpl.cpp:
      (WebKit::WebFrameImpl::visiblePositionForWindowPoint):
      * src/WebPluginContainerImpl.cpp:
      (WebKit::WebPluginContainerImpl::isRectTopmost):
      * src/WebViewImpl.cpp:
      (WebKit::WebViewImpl::computeBlockBounds):
      (WebKit::WebViewImpl::bestTapNode):
      
      Source/WebKit/efl:
      
      * ewk/ewk_frame.cpp:
      (ewk_frame_hit_test_new):
      
      Source/WebKit/gtk:
      
      * webkit/webkitwebinspector.cpp:
      (webkit_web_inspector_inspect_coordinates):
      * webkit/webkitwebview.cpp:
      (prepareMouseEventForFrame):
      (webkit_web_view_get_hit_test_result):
      
      Source/WebKit/mac:
      
      * WebView/WebFrame.mm:
      (-[WebFrame elementAtPoint:]):
      * WebView/WebHTMLView.mm:
      (-[WebHTMLView elementAtPoint:allowShadowContent:]):
      
      Source/WebKit/qt:
      
      * WebCoreSupport/QWebFrameAdapter.cpp:
      (QWebFrameAdapter::hitTestContent):
      
      Source/WebKit/win:
      
      * WebView.cpp:
      (WebView::gestureNotify):
      
      Source/WebKit2:
      
      * WebProcess/WebPage/WebFrame.cpp:
      (WebKit::WebFrame::hitTest):
      * WebProcess/WebPage/WebPage.cpp:
      (WebKit::WebPage::highlightPotentialActivation):
      (WebKit::WebPage::findZoomableAreaForPoint):
      (WebKit::WebPage::determinePrimarySnapshottedPlugIn):
      * WebProcess/WebPage/mac/WebPageMac.mm:
      (WebKit::WebPage::shouldDelayWindowOrderingEvent):
      (WebKit::WebPage::acceptsFirstMouse):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@146961 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      af1544e8
  16. 26 Mar, 2013 1 commit
    • tony@chromium.org's avatar
      Image alt text not included in plain-text version when copying · f2ff2775
      tony@chromium.org authored
      https://bugs.webkit.org/show_bug.cgi?id=11200
      
      Reviewed by Ryosuke Niwa.
      
      Source/WebCore:
      
      Add a setting to enable copying image alt text to the clipboard and drag and drop pasteboard.
      This setting is disabled by default, so each port can enable if they want to match IE10 and
      Firefox's behavior.
      
      Test: editing/pasteboard/copy-image-with-alt-text.html
      
      * editing/Editor.cpp:
      (WebCore::Editor::cut): Explicitly ask that the selection on the pasteboard as being for the clipboard.
      (WebCore::Editor::copy): Explicitly ask that the selection on the pasteboard as being for the clipboard.
      (WebCore::Editor::selectedText): Add a private version of selectedText() that can choose between having image alt text or not.
      (WebCore::Editor::selectedTextForClipboard): Ask for image alt text if the setting is enabled.
      * editing/Editor.h:
      * editing/TextIterator.cpp:
      (WebCore::TextIterator::TextIterator): Add a bool to keep track of whether or not to emit image alt text.
      (WebCore::TextIterator::handleReplacedElement): If there's alt text, point the iterator to it.
      * editing/TextIterator.h:
      (TextIterator):
      * editing/mac/EditorMac.mm:
      (WebCore::Editor::takeFindStringFromSelection): Use the same text as on the clipboard.
      (WebCore::Editor::writeSelectionToPasteboard): Don't include image alt text since this is
      used by Services.
      (WebCore::Editor::stringSelectionForPasteboard): Don't include image alt text since this is
      used by Services.
      * page/DragController.cpp:
      (WebCore::DragController::startDrag): Use image alt text (matches Firefox).
      * page/Settings.in: Add a setting that disables image alt text by default.
      * platform/Pasteboard.h:
      * platform/blackberry/PasteboardBlackBerry.cpp:
      (WebCore::Pasteboard::writeSelection): Add ShouldSerializeSelectedTextForClipboard parameter.
      * platform/chromium/ClipboardChromium.cpp:
      (WebCore::ClipboardChromium::writeRange): Use clipboard text when writing ranges (used by d&d).
      * platform/chromium/PasteboardChromium.cpp:
      (WebCore::Pasteboard::writeSelection): Add ShouldSerializeSelectedTextForClipboard parameter.
      * platform/efl/PasteboardEfl.cpp:
      (WebCore::Pasteboard::writeSelection): Update function param.
      * platform/gtk/ClipboardGtk.cpp:
      (WebCore::ClipboardGtk::writeRange): Use clipboard text when writing ranges (used by d&d).
      * platform/gtk/PasteboardGtk.cpp:
      (WebCore::Pasteboard::writeSelection): Add ShouldSerializeSelectedTextForClipboard parameter.
      * platform/mac/ClipboardMac.mm:
      (WebCore::ClipboardMac::writeRange): Use clipboard text when writing ranges (used by d&d).
      * platform/mac/PasteboardMac.mm:
      (WebCore::Pasteboard::getStringSelection): Use ShouldSerializeSelectedTextForClipboard to determine whether the selected
      text is for the clipboard or not.
      (WebCore::Pasteboard::writeSelectionForTypes): Pass ShouldSerializeSelectedTextForClipboard through.
      (WebCore::Pasteboard::writeSelection): Add ShouldSerializeSelectedTextForClipboard parameter.
      * platform/qt/ClipboardQt.cpp:
      (WebCore::ClipboardQt::writeRange): Use clipboard text when writing ranges (used by d&d).
      * platform/qt/PasteboardQt.cpp:
      (WebCore::Pasteboard::writeSelection): Add ShouldSerializeSelectedTextForClipboard parameter.
      * platform/win/ClipboardWin.cpp:
      (WebCore::ClipboardWin::writeRange): Use clipboard text when writing ranges (used by d&d).
      * platform/win/PasteboardWin.cpp:
      (WebCore::Pasteboard::writeSelection): Add ShouldSerializeSelectedTextForClipboard parameter.
      * platform/wince/PasteboardWinCE.cpp:
      (WebCore::Pasteboard::writeSelection): Add ShouldSerializeSelectedTextForClipboard parameter.
      * platform/wx/PasteboardWx.cpp:
      (WebCore::Pasteboard::writeSelection): Add ShouldSerializeSelectedTextForClipboard parameter.
      * rendering/RenderImage.h:
      (WebCore::RenderImage::altText): Add a getter for the alt text.
      
      LayoutTests:
      
      * editing/pasteboard/copy-image-with-alt-text-expected.txt: Added.
      * editing/pasteboard/copy-image-with-alt-text.html: Added.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@146835 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      f2ff2775
  17. 14 Mar, 2013 1 commit
    • inferno@chromium.org's avatar
      Replace static_casts with to* helper functions. · 9aa9e8d7
      inferno@chromium.org authored
      https://bugs.webkit.org/show_bug.cgi?id=112296
      
      Reviewed by Kentaro Hara.
      
      to* helper functions are preferred over static_cast calls since they
      help to catch bad casts easily on the testing infrastructure.
      
      Source/WebCore:
      
      * accessibility/AXObjectCache.cpp:
      (WebCore::nodeHasRole):
      * accessibility/AccessibilityObject.cpp:
      (WebCore::AccessibilityObject::hasAttribute):
      (WebCore::AccessibilityObject::getAttribute):
      * accessibility/AccessibilityRenderObject.cpp:
      (WebCore::AccessibilityRenderObject::anchorElement):
      (WebCore::AccessibilityRenderObject::helpText):
      (WebCore::AccessibilityRenderObject::checkboxOrRadioRect):
      (WebCore::AccessibilityRenderObject::titleUIElement):
      (WebCore::AccessibilityRenderObject::computeAccessibilityIsIgnored):
      (WebCore::AccessibilityRenderObject::accessKey):
      (WebCore::AccessibilityRenderObject::setElementAttributeValue):
      (WebCore::AccessibilityRenderObject::setValue):
      (WebCore::AccessibilityRenderObject::activeDescendant):
      (WebCore::AccessibilityRenderObject::handleActiveDescendantChanged):
      (WebCore::AccessibilityRenderObject::correspondingLabelForControlElement):
      (WebCore::AccessibilityRenderObject::inheritsPresentationalRole):
      (WebCore::AccessibilityRenderObject::setAccessibleName):
      (WebCore::AccessibilityRenderObject::stringRoleForMSAA):
      * bindings/gobject/WebKitDOMBinding.cpp:
      (WebKit::createWrapper):
      * bindings/js/JSClipboardCustom.cpp:
      (WebCore::JSClipboard::setDragImage):
      * bindings/js/JSElementCustom.cpp:
      (WebCore::toJSNewlyCreated):
      * bindings/js/JSNodeCustom.cpp:
      (WebCore::createWrapperInline):
      * bindings/v8/custom/V8ClipboardCustom.cpp:
      (WebCore::V8Clipboard::setDragImageMethodCustom):
      * bindings/v8/custom/V8ElementCustom.cpp:
      (WebCore::wrap):
      * bindings/v8/custom/V8NodeCustom.cpp:
      (WebCore::wrap):
      * dom/Document.cpp:
      (WebCore::Document::importNode):
      (WebCore::Document::recalcStyle):
      (WebCore::Document::setFocusedNode):
      (WebCore::Document::updateFocusAppearanceTimerFired):
      * dom/DocumentStyleSheetCollection.cpp:
      (WebCore::DocumentStyleSheetCollection::collectActiveStyleSheets):
      * dom/Element.cpp:
      (WebCore::Element::offsetParent):
      (WebCore::Element::boundsInRootViewSpace):
      (WebCore::Element::getBoundingClientRect):
      (WebCore::Element::recalcStyle):
      (WebCore::Element::computeInheritedLanguage):
      (WebCore::Element::lastElementChild):
      * dom/LiveNodeList.cpp:
      (WebCore::LiveNodeList::namedItem):
      * dom/Node.cpp:
      (WebCore::Node::dumpStatistics):
      (WebCore::Node::normalize):
      (WebCore::Node::rootEditableElement):
      (WebCore::Node::isDefaultNamespace):
      (WebCore::Node::ancestorElement):
      (WebCore::appendAttributeDesc):
      * dom/Position.cpp:
      (WebCore::Position::element):
      * dom/Range.cpp:
      (WebCore::Range::getBorderAndTextQuads):
      * dom/SelectorQuery.cpp:
      (WebCore::SelectorDataList::queryFirst):
      (WebCore::SelectorDataList::execute):
      * dom/ShadowRoot.cpp:
      (WebCore::ShadowRoot::recalcStyle):
      * dom/StaticHashSetNodeList.cpp:
      (WebCore::StaticHashSetNodeList::namedItem):
      * editing/ApplyStyleCommand.cpp:
      (WebCore::ApplyStyleCommand::splitAncestorsWithUnicodeBidi):
      (WebCore::ApplyStyleCommand::pushDownInlineStyleAroundNode):
      (WebCore::ApplyStyleCommand::mergeStartWithPreviousIfIdentical):
      (WebCore::ApplyStyleCommand::surroundNodeRangeWithElement):
      * editing/Editor.cpp:
      (WebCore::Editor::applyEditingStyleToBodyElement):
      * editing/FrameSelection.cpp:
      (WebCore::removingNodeRemovesPosition):
      * editing/IndentOutdentCommand.cpp:
      (WebCore::IndentOutdentCommand::outdentParagraph):
      * editing/MarkupAccumulator.cpp:
      (WebCore::MarkupAccumulator::entityMaskForText):
      (WebCore::MarkupAccumulator::appendStartMarkup):
      (WebCore::MarkupAccumulator::appendEndMarkup):
      * editing/ModifySelectionListLevel.cpp:
      (WebCore::IncreaseSelectionListLevelCommand::doApply):
      * editing/ReplaceSelectionCommand.cpp:
      (WebCore::haveSameTagName):
      (WebCore::handleStyleSpansBeforeInsertion):
      (WebCore::ReplaceSelectionCommand::doApply):
      * editing/SplitTextNodeContainingElementCommand.cpp:
      (WebCore::SplitTextNodeContainingElementCommand::doApply):
      * editing/TextIterator.cpp:
      (WebCore::TextIterator::advance):
      * editing/htmlediting.cpp:
      (WebCore::unsplittableElementForPosition):
      (WebCore::enclosingTableCell):
      * editing/markup.cpp:
      (WebCore::StyledMarkupAccumulator::wrapWithNode):
      (WebCore::createMarkupInternal):
      (WebCore::createFragmentFromMarkupWithContext):
      (WebCore::isPlainTextMarkup):
      (WebCore::createFragmentFromText):
      * html/HTMLElement.cpp:
      (WebCore::HTMLElement::insertAdjacentElement):
      (WebCore::contextElementForInsertion):
      * html/HTMLFormControlElement.cpp:
      (WebCore::focusPostAttach):
      (WebCore::updateFromElementCallback):
      * html/HTMLFormElement.cpp:
      (WebCore::submitElementFromEvent):
      * html/HTMLObjectElement.cpp:
      (WebCore::HTMLObjectElement::updateDocNamedItem):
      * html/HTMLPlugInImageElement.cpp:
      (WebCore::HTMLPlugInImageElement::updateSnapshotInfo):
      * html/HTMLViewSourceDocument.cpp:
      (WebCore::HTMLViewSourceDocument::addRange):
      * html/parser/HTMLTreeBuilder.cpp:
      (WebCore::closestFormAncestor):
      * html/shadow/MediaControlElementTypes.cpp:
      (WebCore::toParentMediaElement):
      * html/shadow/TextFieldDecorationElement.h:
      (WebCore::toTextFieldDecorationElement):
      * inspector/DOMPatchSupport.cpp:
      (WebCore::DOMPatchSupport::createDigest):
      * inspector/InspectorDOMAgent.cpp:
      (WebCore::InspectorDOMAgent::buildObjectForNode):
      (WebCore::InspectorDOMAgent::didInvalidateStyleAttr):
      * inspector/InspectorStyleSheet.cpp:
      (WebCore::InspectorStyleSheet::inlineStyleSheetText):
      * mathml/MathMLElement.h:
      (WebCore::toMathMLElement):
      * page/ContextMenuController.cpp:
      (WebCore::ContextMenuController::populate):
      * page/DragController.cpp:
      (WebCore::elementUnderMouse):
      (WebCore::DragController::startDrag):
      * page/FocusController.cpp:
      (WebCore::FocusController::advanceFocusInDocumentOrder):
      * page/Frame.cpp:
      (WebCore::Frame::searchForLabelsBeforeElement):
      * page/FrameView.cpp:
      (WebCore::FrameView::updateWidget):
      * page/SpatialNavigation.cpp:
      (WebCore::rectToAbsoluteCoordinates):
      * page/animation/ImplicitAnimation.cpp:
      (WebCore::ImplicitAnimation::sendTransitionEvent):
      * page/animation/KeyframeAnimation.cpp:
      (WebCore::KeyframeAnimation::KeyframeAnimation):
      (WebCore::KeyframeAnimation::sendAnimationEvent):
      * platform/efl/RenderThemeEfl.cpp:
      (WebCore::RenderThemeEfl::paintMediaFullscreenButton):
      (WebCore::RenderThemeEfl::paintMediaMuteButton):
      * rendering/FilterEffectRenderer.cpp:
      (WebCore::FilterEffectRenderer::buildReferenceFilter):
      * rendering/svg/RenderSVGViewportContainer.cpp:
      (WebCore::RenderSVGViewportContainer::calcViewport):
      * svg/SVGSVGElement.cpp:
      (WebCore::SVGSVGElement::getElementById):
      * svg/SVGUseElement.cpp:
      (WebCore::isDisallowedElement):
      * svg/animation/SVGSMILElement.cpp:
      (WebCore::SVGSMILElement::buildPendingResource):
      * xml/XPathStep.cpp:
      (WebCore::XPath::nodeMatchesBasicTest):
      * xml/parser/XMLDocumentParserQt.cpp:
      (WebCore::XMLDocumentParser::XMLDocumentParser):
      (WebCore::XMLDocumentParser::parseEndElement):
      
      Source/WebKit/blackberry:
      
      * Api/WebPage.cpp:
      (BlackBerry::WebKit::WebPagePrivate::webContext):
      (BlackBerry::WebKit::WebPagePrivate::handleMouseEvent):
      (BlackBerry::WebKit::WebPage::setNodeFocus):
      (BlackBerry::WebKit::WebPagePrivate::adjustFullScreenElementDimensionsIfNeeded):
      * WebCoreSupport/EditorClientBlackBerry.cpp:
      (WebCore::EditorClientBlackBerry::shouldSpellCheckFocusedField):
      (WebCore::EditorClientBlackBerry::shouldChangeSelectedRange):
      * WebKitSupport/BackingStoreClient.cpp:
      (BlackBerry::WebKit::BackingStoreClient::absoluteRect):
      * WebKitSupport/DOMSupport.cpp:
      (BlackBerry::WebKit::DOMSupport::toTextControlElement):
      (BlackBerry::WebKit::DOMSupport::selectionContainerElement):
      * WebKitSupport/FatFingers.cpp:
      (BlackBerry::WebKit::FatFingers::getRelevantInfoFromCachedHitTest):
      (BlackBerry::WebKit::FatFingers::setSuccessfulFatFingersResult):
      * WebKitSupport/InputHandler.cpp:
      (BlackBerry::WebKit::InputHandler::focusedNodeChanged):
      (BlackBerry::WebKit::InputHandler::willOpenPopupForNode):
      * WebKitSupport/SelectionHandler.cpp:
      (BlackBerry::WebKit::SelectionHandler::inputNodeOverridesTouch):
      * WebKitSupport/TouchEventHandler.cpp:
      (BlackBerry::WebKit::elementForTapHighlight):
      
      Source/WebKit/chromium:
      
      * src/WebDocument.cpp:
      (WebKit::WebDocument::images):
      * src/WebElement.cpp:
      (WebKit::WebElement::operator PassRefPtr<Element>):
      * src/WebPageSerializer.cpp:
      (WebCore::retrieveResourcesForFrame):
      * src/WebViewImpl.cpp:
      (WebKit::WebViewImpl::setFocus):
      (WebKit::WebViewImpl::clearFocusedNode):
      (WebKit::WebViewImpl::scrollFocusedNodeIntoView):
      (WebKit::WebViewImpl::scrollFocusedNodeIntoRect):
      
      Source/WebKit/gtk:
      
      * webkit/webkitwebview.cpp:
      (webkit_web_view_query_tooltip):
      
      Source/WebKit/mac:
      
      * WebCoreSupport/WebFrameLoaderClient.mm:
      (applyAppleDictionaryApplicationQuirkNonInlinePart):
      * WebView/WebHTMLRepresentation.mm:
      (searchForLabelsBeforeElement):
      
      Source/WebKit/qt:
      
      * Api/qwebelement.cpp:
      (QWebElement::firstChild):
      (QWebElement::lastChild):
      (QWebElement::nextSibling):
      (QWebElement::previousSibling):
      (QWebElementCollection::at):
      (QWebElementCollection::toList):
      * WebCoreSupport/QWebFrameAdapter.cpp:
      (QWebHitTestResultPrivate::elementForInnerNode):
      
      Source/WebKit/win:
      
      * WebView.cpp:
      (WebView::enterFullscreenForNode):
      
      Source/WebKit2:
      
      * WebProcess/InjectedBundle/DOM/InjectedBundleNodeHandle.cpp:
      (WebKit::InjectedBundleNodeHandle::elementBounds):
      * WebProcess/WebPage/WebFrame.cpp:
      (WebKit::WebFrame::containsAnyFormElements):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@145818 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      9aa9e8d7
  18. 13 Mar, 2013 1 commit
  19. 03 Mar, 2013 1 commit
    • darin@apple.com's avatar
      Cut down the number of source files that depend on Clipboard.h · 569b13f7
      darin@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=110030
      
      Reviewed by Ryosuke Niwa.
      
      Source/WebCore:
      
      I am doing some work on Clipboard and it's better to recompile 50 files
      each time we touch the header instead of 700. Also cut down on includes
      of DragState.h.
      
      * WebCore.exp.in: Updated for new MouseEvent::create function.
      
      * dom/ClipboardEvent.cpp: Added include of Clipboard.h since we use it
      here and the world no longer includes it everywhere.
      
      * dom/ClipboardEvent.h: Forward declared Clipboard instead of including
      Clipboard.h. Also made some overrides private because they can be.
      
      * dom/DataTransferItem.h: Removed unneeded include of Clipboard.h.
      
      * dom/MouseEvent.cpp: Added include of Clipboard.h since we use it
      here and the world no longer includes it everywhere.
      (WebCore::MouseEvent::create): Made the create function non-inline
      since we can't compile it without including Clipboard.h and we don't
      want to include Clipboard.h in the header. This is not so commonly
      used or so hot that this needs to be inlined.
      
      * dom/MouseEvent.h: Forward declared Clipboard instead of including
      Clipboard.h. Made MouseEvent::create a non-inline function and also
      used overloading instead of default arguments, since we can't compile
      a default argument of type PassRefPtr<Clipboard> without including
      Clipboard.h.
      
      * dom/WheelEvent.cpp: Added include of Clipboard.h since we use it
      here and the world no longer includes it everywhere.
      
      * dom/WheelEvent.h: Forward declare PlatformWheelEvent since it is used
      in this header. Previously we'd get it indirectly from including a header
      that included Clipboard.h.
      
      * editing/Editor.cpp: Added include of Clipboard.h since we use it here
      and the world no longer includes it everywhere.
      
      * inspector/InspectorDebuggerAgent.cpp: Added include of CachedResource.h.
      We used to get this indirectly through Clipboard.h.
      
      * inspector/InspectorFrontendHost.cpp: Added includes of ResourceError.h
      and ResourceResponse.h. We used to get these indirectly through Clipboard.h.
      Also removed unneeded include of <wtf/RefPtr.h>.
      
      * inspector/NetworkResourcesData.cpp: Added include of CachedResource.h.
      We used to get this indirectly through Clipboard.h.
      
      * loader/PingLoader.cpp: Added include of ResourceResponse.h.
      We used to get this indirectly through Clipboard.h.
      
      * page/DragController.cpp: Added include of DragState.h.
      We used to get this indirectly through EventHandler.h
      
      * page/EventHandler.h: Forward declared DragState and Element instead of
      including DragState.h. Also added an include of LayoutPoint.h, which we
      used to get indirectly through DragState.h.
      
      Source/WebKit/chromium:
      
      * src/SharedWorkerRepository.cpp: Add include of ResourceResponse.h
      here. We used to get this indirectly through Clipboard.h.
      
      Source/WebKit/mac:
      
      * WebView/WebPDFView.mm: Add include of Clipboard.h since we use it
      here and the world no longer includes it everywhere.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@144553 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      569b13f7
  20. 02 Mar, 2013 1 commit
    • ap@apple.com's avatar
      Reduce amount of rebuilding when touching networking headers · fc363ce1
      ap@apple.com authored
              https://bugs.webkit.org/show_bug.cgi?id=111035
      
              Reviewed by Eric Seidel.
      
              This uses a number of common unsurprising techniques. One interesting observation
              is that including CachedResource related headers is very expensive. We can usually
              get away with their Client counterparts, and with CachedResourceHandle.
      
              * page/Frame.cpp:
              * page/Frame.h:
              Don't include FrameLoader, greatly reducing include graph for most non-loader files.
              This required making Frame::init() non-inline - I'm not sure why it ever was.
      
              * loader/FrameLoader.cpp:
              * loader/FrameLoader.h:
              Even though FrameLoader is logically on loading side of WebCore, it's included in
              too many places. Not including PolicyChecker.h and ResourceHandle.h was among the
              largest wins. As a future improvement, we should probably convert other members
              to OwnPtrs.
      
              * css/CSSCrossfadeValue.h: Initializing CachedResourceHandle with 0 requires a
              definition of a class it holds, but default construction does not.
      
              * loader/CrossOriginAccessControl.h: This file among others only needs ResourceHandleTypes.h,
              not ResourceHandle.h. This header is semi-recent, so not all include sites were updated.
      
              * loader/cache/CachedFont.h:
              * loader/cache/CachedFontClient.h: Added.
              * loader/cache/CachedRawResource.h:
              * loader/cache/CachedRawResourceClient.h: Added.
              * loader/cache/CachedSVGDocument.h:
              * loader/cache/CachedSVGDocumentClient.h: Added.
              These types were defining client types in the same headers, making it impossible
              to avoid including networking headers through CachedResource. Moved clients into
              separate files.
      
              * plugins/PluginStream.h:
              * plugins/PluginStreamClient.h: Added.
              Similar situation here.
      
              * loader/cache/CachedResourceHandle.cpp:
              * loader/cache/CachedResourceHandle.h:
              Moved functions that need to know about CachedResource to .cpp file. This is another
              huge win. Added a destructor, so that CachedResource woudn't be needed in all files
              that include CachedResourceHandle.
      
              * loader/cache/CachedSVGDocumentReference.cpp: Added.
              * loader/cache/CachedSVGDocumentReference.h:
              Moved constructor and virtual function implementations to a .cpp file - they need
              not inlining, and this lets us avoid including CachedSVGDocument.h in the header.
      
              * platform/graphics/filters/FilterOperation.cpp:
              * platform/graphics/filters/FilterOperation.h:
              Avoid including CachedSVGDocumentReference.h. This is not such a big win now that
              CachedSVGDocumentReference.h itself is smaller, but FilterOperation is so clearly
              rendering code that it seems best to cut any ties with resources and loading.
              Added a virtual destrutor in .cpp file, because inline destructors in polymorphic
              classes are generally harmful (due to code bloat).
      
              * plugins/PluginRequest.h: Added.
              * plugins/PluginView.h:
              Moved PluginRequest into a separate file, it was out of place in a view hierarchy
              class file.
      
              * rendering/RenderImageResource.cpp:
              * rendering/RenderImageResource.h:
              Moved definitions of virtual functions to a .cpp file. Thre is no win from having
              them inline, and now we don't need CachedImage.h in the header.
      
              * rendering/style/StyleCustomFilterProgram.cpp: Added.
              * rendering/style/StyleCustomFilterProgram.h:
              Ditto.
      
              * CMakeLists.txt:
              * GNUmakefile.list.am:
              * Modules/mediastream/RTCPeerConnection.cpp:
              * Modules/notifications/Notification.cpp:
              * Target.pri:
              * WebCore.exp.in:
              * WebCore.gypi:
              * WebCore.vcproj/WebCore.vcproj:
              * WebCore.vcxproj/WebCore.vcxproj:
              * WebCore.vcxproj/WebCore.vcxproj.filters:
              * WebCore.xcodeproj/project.pbxproj:
              * bindings/ScriptControllerBase.cpp:
              * bindings/js/JSNodeCustom.cpp:
              * bindings/js/ScriptController.cpp:
              * bindings/js/ScriptSourceCode.h:
              * bindings/objc/DOM.mm:
              * bindings/v8/ScriptController.cpp:
              * bindings/v8/V8DOMWindowShell.cpp:
              * bindings/v8/custom/V8DOMWindowCustom.cpp:
              * css/CSSFontFaceSource.h:
              * css/CSSFontSelector.cpp:
              * css/WebKitCSSSVGDocumentValue.cpp:
              * css/WebKitCSSSVGDocumentValue.h:
              * dom/Clipboard.cpp:
              * dom/ContainerNode.cpp:
              * dom/DOMImplementation.cpp:
              * dom/PendingScript.h:
              * dom/ScriptElement.cpp:
              * dom/ScriptElement.h:
              * history/CachedFrame.cpp:
              * html/DOMURL.cpp:
              * html/HTMLAnchorElement.cpp:
              * html/HTMLAppletElement.cpp:
              * html/HTMLElement.cpp:
              * html/HTMLEmbedElement.cpp:
              * html/HTMLFrameSetElement.cpp:
              * html/HTMLHtmlElement.cpp:
              * html/HTMLImageElement.cpp:
              * html/HTMLObjectElement.cpp:
              * html/HTMLPlugInElement.cpp:
              * html/ImageDocument.cpp:
              * html/ImageInputType.cpp:
              * html/MediaDocument.cpp:
              * html/PluginDocument.cpp:
              * html/canvas/WebGLRenderingContext.cpp:
              * html/parser/HTMLConstructionSite.cpp:
              * html/parser/HTMLParserOptions.cpp:
              * html/parser/HTMLScriptRunner.h:
              * html/parser/XSSAuditor.cpp:
              * html/parser/XSSAuditorDelegate.cpp:
              * inspector/InspectorDebuggerAgent.cpp:
              * inspector/InspectorFileSystemAgent.cpp:
              * inspector/InspectorFrontendHost.cpp:
              * inspector/InspectorInstrumentation.h:
              * inspector/InspectorPageAgent.cpp:
              * inspector/NetworkResourcesData.cpp:
              * inspector/NetworkResourcesData.h:
              * loader/CookieJar.cpp:
              * loader/CrossOriginAccessControl.cpp:
              * loader/CrossOriginPreflightResultCache.h:
              * loader/DocumentThreadableLoader.h:
              * loader/ImageLoader.cpp:
              * loader/ImageLoader.h:
              * loader/LinkLoader.h:
              * loader/MainResourceLoader.cpp:
              * loader/MainResourceLoader.h:
              * loader/MixedContentChecker.cpp:
              * loader/PingLoader.cpp:
              * loader/PolicyChecker.h:
              * loader/ProgressTracker.cpp:
              * loader/SubframeLoader.cpp:
              * loader/SubresourceLoader.cpp:
              * loader/TextTrackLoader.cpp:
              * loader/TextTrackLoader.h:
              * loader/ThreadableLoader.h:
              * loader/appcache/ApplicationCacheGroup.cpp:
              * loader/appcache/ApplicationCacheGroup.h:
              * loader/appcache/ApplicationCacheHost.cpp:
              * loader/archive/cf/LegacyWebArchive.cpp:
              * loader/cache/CachedFont.cpp:
              * loader/cache/CachedImage.cpp:
              * loader/cache/CachedRawResource.cpp:
              * loader/cache/CachedResource.cpp:
              * loader/cache/CachedStyleSheetClient.h:
              * loader/cache/MemoryCache.cpp:
              * loader/cache/MemoryCache.h:
              * loader/chromium/CachedRawResourceChromium.cpp:
              * loader/icon/IconController.cpp:
              * loader/icon/IconLoader.h:
              * loader/mac/ResourceLoaderMac.mm:
              * page/DOMWindowExtension.cpp:
              * page/DragController.cpp:
              * page/PerformanceNavigation.cpp:
              * page/PerformanceTiming.cpp:
              * page/PointerLockController.cpp:
              * page/Settings.cpp:
              * page/animation/CSSPropertyAnimation.cpp:
              * platform/chromium/PasteboardChromium.cpp:
              * platform/efl/ErrorsEfl.cpp:
              * platform/graphics/avfoundation/MediaPlayerPrivateAVFoundation.cpp:
              * platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.h:
              * platform/graphics/gstreamer/WebKitWebSourceGStreamer.cpp:
              * platform/gtk/ErrorsGtk.cpp:
              * platform/gtk/PasteboardGtk.cpp:
              * platform/gtk/PasteboardHelper.h:
              * platform/mac/ClipboardMac.h:
              * platform/mac/ClipboardMac.mm:
              * platform/mac/HTMLConverter.mm:
              * platform/mac/PasteboardMac.mm:
              * platform/network/AuthenticationChallengeBase.cpp:
              * platform/network/cf/CookieJarCFNet.cpp:
              * platform/network/cf/ResourceRequestCFNet.cpp:
              * platform/network/mac/CookieStorageMac.mm:
              * platform/qt/PasteboardQt.cpp:
              * plugins/DOMMimeType.cpp:
              * plugins/PluginView.cpp:
              * rendering/HitTestResult.cpp:
              * rendering/InlineFlowBox.cpp:
              * rendering/RenderBox.cpp:
              * rendering/RenderEmbeddedObject.cpp:
              * rendering/RenderImage.cpp:
              * rendering/RenderImageResourceStyleImage.cpp:
              * rendering/RenderLayer.cpp:
              * rendering/RenderLayerBacking.cpp:
              * rendering/RenderLayerFilterInfo.h:
              * rendering/RenderListItem.cpp:
              * rendering/RenderListMarker.cpp:
              * rendering/RenderSnapshottedPlugIn.cpp:
              * rendering/RenderTableCol.cpp:
              * rendering/RenderTableRow.cpp:
              * rendering/RenderTableSection.cpp:
              * rendering/style/StyleCachedShader.h:
              * svg/SVGFEImageElement.h:
              * svg/SVGFontFaceUriElement.h:
              * svg/SVGImageLoader.cpp:
              * svg/SVGUseElement.cpp:
              * svg/SVGUseElement.h:
              * svg/graphics/SVGImageCache.cpp:
              * testing/MockPagePopupDriver.cpp:
              * xml/XSLStyleSheet.h:
              * xml/XSLTProcessorLibxslt.cpp:
              * xml/parser/XMLDocumentParser.cpp:
              * xml/parser/XMLDocumentParser.h:
              * xml/parser/XMLDocumentParserLibxml2.cpp:
              Many self-evident changes - removing unnecessary header includes, adding smaller
              more local ones that are now necessary.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@144530 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      fc363ce1
  21. 01 Mar, 2013 2 commits
    • commit-queue@webkit.org's avatar
      Unreviewed, rolling out r144422 and r144424. · 0b87a6c7
      commit-queue@webkit.org authored
      http://trac.webkit.org/changeset/144422
      http://trac.webkit.org/changeset/144424
      https://bugs.webkit.org/show_bug.cgi?id=111167
      
      Caused over 20 tests to fail assertion on Chromium Win port as
      ASSERTION FAILED: m_platformRequestUpdated (Requested by
      toyoshim on #webkit).
      
      Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2013-03-01
      
      Source/WebCore:
      
      * CMakeLists.txt:
      * GNUmakefile.list.am:
      * Modules/mediastream/RTCPeerConnection.cpp:
      * Modules/notifications/Notification.cpp:
      * Target.pri:
      * WebCore.exp.in:
      * WebCore.gypi:
      * WebCore.vcproj/WebCore.vcproj:
      * WebCore.vcxproj/WebCore.vcxproj:
      * WebCore.vcxproj/WebCore.vcxproj.filters:
      * WebCore.xcodeproj/project.pbxproj:
      * bindings/ScriptControllerBase.cpp:
      * bindings/js/JSNodeCustom.cpp:
      * bindings/js/ScriptController.cpp:
      * bindings/js/ScriptSourceCode.h:
      * bindings/objc/DOM.mm:
      * bindings/v8/ScriptController.cpp:
      * bindings/v8/V8DOMWindowShell.cpp:
      * bindings/v8/custom/V8DOMWindowCustom.cpp:
      * css/CSSCrossfadeValue.h:
      (WebCore::CSSCrossfadeValue::CSSCrossfadeValue):
      (WebCore::CSSCrossfadeValue::CrossfadeSubimageObserverProxy::CrossfadeSubimageObserverProxy):
      * css/CSSFontFaceSource.h:
      * css/CSSFontSelector.cpp:
      * css/WebKitCSSSVGDocumentValue.cpp:
      * css/WebKitCSSSVGDocumentValue.h:
      (WebCore):
      * dom/Clipboard.cpp:
      (WebCore::Clipboard::Clipboard):
      * dom/ContainerNode.cpp:
      * dom/DOMImplementation.cpp:
      * dom/PendingScript.h:
      * dom/ScriptElement.cpp:
      * dom/ScriptElement.h:
      * history/CachedFrame.cpp:
      * html/DOMURL.cpp:
      * html/HTMLAnchorElement.cpp:
      * html/HTMLAppletElement.cpp:
      * html/HTMLElement.cpp:
      * html/HTMLEmbedElement.cpp:
      * html/HTMLFrameSetElement.cpp:
      * html/HTMLHtmlElement.cpp:
      * html/HTMLImageElement.cpp:
      * html/HTMLObjectElement.cpp:
      * html/HTMLPlugInElement.cpp:
      * html/ImageDocument.cpp:
      * html/ImageInputType.cpp:
      * html/MediaDocument.cpp:
      * html/PluginDocument.cpp:
      * html/canvas/WebGLRenderingContext.cpp:
      (WebCore):
      * html/parser/HTMLConstructionSite.cpp:
      * html/parser/HTMLParserOptions.cpp:
      * html/parser/HTMLScriptRunner.h:
      * html/parser/XSSAuditor.cpp:
      * html/parser/XSSAuditorDelegate.cpp:
      * inspector/InspectorDebuggerAgent.cpp:
      * inspector/InspectorFileSystemAgent.cpp:
      * inspector/InspectorFrontendHost.cpp:
      * inspector/InspectorInstrumentation.h:
      (WebCore):
      * inspector/InspectorPageAgent.cpp:
      * inspector/NetworkResourcesData.cpp:
      * inspector/NetworkResourcesData.h:
      (WebCore):
      * loader/CookieJar.cpp:
      * loader/CrossOriginAccessControl.cpp:
      * loader/CrossOriginAccessControl.h:
      (WebCore):
      * loader/CrossOriginPreflightResultCache.h:
      * loader/DocumentThreadableLoader.h:
      * loader/FrameLoader.cpp:
      (WebCore::FrameLoader::FrameLoader):
      * loader/FrameLoader.h:
      (WebCore):
      (WebCore::FrameLoader::policyChecker):
      * loader/ImageLoader.cpp:
      * loader/ImageLoader.h:
      * loader/LinkLoader.h:
      * loader/MainResourceLoader.cpp:
      * loader/MainResourceLoader.h:
      * loader/MixedContentChecker.cpp:
      * loader/PingLoader.cpp:
      * loader/PolicyChecker.h:
      (WebCore):
      * loader/ProgressTracker.cpp:
      * loader/SubframeLoader.cpp:
      * loader/SubresourceLoader.cpp:
      * loader/TextTrackLoader.cpp:
      * loader/TextTrackLoader.h:
      * loader/ThreadableLoader.h:
      * loader/appcache/ApplicationCacheGroup.cpp:
      * loader/appcache/ApplicationCacheGroup.h:
      (WebCore):
      * loader/appcache/ApplicationCacheHost.cpp:
      * loader/archive/cf/LegacyWebArchive.cpp:
      * loader/cache/CachedFont.cpp:
      * loader/cache/CachedFont.h:
      (CachedFontClient):
      (WebCore::CachedFontClient::~CachedFontClient):
      (WebCore::CachedFontClient::expectedType):
      (WebCore::CachedFontClient::resourceClientType):
      (WebCore::CachedFontClient::fontLoaded):
      (WebCore):
      * loader/cache/CachedFontClient.h: Removed.
      * loader/cache/CachedImage.cpp:
      * loader/cache/CachedRawResource.cpp:
      * loader/cache/CachedRawResource.h:
      (WebCore):
      (CachedRawResourceClient):
      (WebCore::CachedRawResourceClient::~CachedRawResourceClient):
      (WebCore::CachedRawResourceClient::expectedType):
      (WebCore::CachedRawResourceClient::resourceClientType):
      (WebCore::CachedRawResourceClient::dataSent):
      (WebCore::CachedRawResourceClient::responseReceived):
      (WebCore::CachedRawResourceClient::dataReceived):
      (WebCore::CachedRawResourceClient::redirectReceived):
      (WebCore::CachedRawResourceClient::dataDownloaded):
      * loader/cache/CachedRawResourceClient.h: Removed.
      * loader/cache/CachedResource.cpp:
      * loader/cache/CachedResourceHandle.cpp:
      * loader/cache/CachedResourceHandle.h:
      (WebCore::CachedResourceHandleBase::~CachedResourceHandleBase):
      (WebCore::CachedResourceHandleBase::CachedResourceHandleBase):
      * loader/cache/CachedSVGDocument.h:
      (CachedSVGDocumentClient):
      (WebCore::CachedSVGDocumentClient::~CachedSVGDocumentClient):
      (WebCore::CachedSVGDocumentClient::expectedType):
      (WebCore::CachedSVGDocumentClient::resourceClientType):
      (WebCore):
      * loader/cache/CachedSVGDocumentClient.h: Removed.
      * loader/cache/CachedSVGDocumentReference.cpp: Removed.
      * loader/cache/CachedSVGDocumentReference.h:
      (WebCore::CachedSVGDocumentReference::CachedSVGDocumentReference):
      (WebCore::CachedSVGDocumentReference::~CachedSVGDocumentReference):
      * loader/cache/CachedStyleSheetClient.h:
      * loader/cache/MemoryCache.cpp:
      * loader/cache/MemoryCache.h:
      (WebCore):
      (MemoryCache):
      * loader/chromium/CachedRawResourceChromium.cpp:
      * loader/icon/IconController.cpp:
      * loader/icon/IconLoader.h:
      * loader/mac/ResourceLoaderMac.mm:
      * page/DOMWindowExtension.cpp:
      * page/DragController.cpp:
      * page/Frame.cpp:
      (WebCore::Frame::Frame):
      (WebCore::Frame::reportMemoryUsage):
      * page/Frame.h:
      (WebCore):
      (Frame):
      (WebCore::Frame::init):
      (WebCore::Frame::loader):
      * page/PerformanceNavigation.cpp:
      * page/PerformanceTiming.cpp:
      * page/PointerLockController.cpp:
      * page/Settings.cpp:
      * page/animation/CSSPropertyAnimation.cpp:
      * platform/chromium/PasteboardChromium.cpp:
      * platform/efl/ErrorsEfl.cpp:
      * platform/graphics/avfoundation/MediaPlayerPrivateAVFoundation.cpp:
      * platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.h:
      * platform/graphics/filters/FilterOperation.cpp:
      * platform/graphics/filters/FilterOperation.h:
      (WebCore::FilterOperation::ReferenceFilterOperation::setCachedSVGDocumentReference):
      (WebCore::FilterOperation::ReferenceFilterOperation::ReferenceFilterOperation):
      * platform/graphics/gstreamer/WebKitWebSourceGStreamer.cpp:
      * platform/gtk/ErrorsGtk.cpp:
      * platform/gtk/PasteboardGtk.cpp:
      * platform/gtk/PasteboardHelper.h:
      * platform/mac/ClipboardMac.h:
      * platform/mac/ClipboardMac.mm:
      * platform/mac/HTMLConverter.mm:
      * platform/mac/PasteboardMac.mm:
      * platform/network/AuthenticationChallengeBase.cpp:
      * platform/network/cf/CookieJarCFNet.cpp:
      * platform/network/cf/ResourceRequestCFNet.cpp:
      * platform/network/mac/CookieStorageMac.mm:
      * platform/qt/PasteboardQt.cpp:
      * plugins/DOMMimeType.cpp:
      * plugins/PluginRequest.h: Removed.
      * plugins/PluginStream.h:
      (PluginStreamClient):
      (WebCore::PluginStreamClient::~PluginStreamClient):
      (WebCore::PluginStreamClient::streamDidFinishLoading):
      (WebCore):
      * plugins/PluginStreamClient.h: Removed.
      * plugins/PluginView.cpp:
      * plugins/PluginView.h:
      (WebCore):
      (PluginRequest):
      (WebCore::PluginRequest::PluginRequest):
      (WebCore::PluginRequest::frameLoadRequest):
      (WebCore::PluginRequest::notifyData):
      (WebCore::PluginRequest::sendNotification):
      (WebCore::PluginRequest::shouldAllowPopups):
      * rendering/HitTestResult.cpp:
      * rendering/InlineFlowBox.cpp:
      * rendering/RenderBox.cpp:
      * rendering/RenderEmbeddedObject.cpp:
      * rendering/RenderImage.cpp:
      * rendering/RenderImageResource.cpp:
      (WebCore::RenderImageResource::RenderImageResource):
      * rendering/RenderImageResource.h:
      (WebCore::RenderImageResource::image):
      (WebCore::RenderImageResource::errorOccurred):
      (WebCore::RenderImageResource::usesImageContainerSize):
      (WebCore::RenderImageResource::imageHasRelativeWidth):
      (WebCore::RenderImageResource::imageHasRelativeHeight):
      (WebCore::RenderImageResource::imageSize):
      * rendering/RenderImageResourceStyleImage.cpp:
      * rendering/RenderLayer.cpp:
      * rendering/RenderLayerBacking.cpp:
      * rendering/RenderLayerFilterInfo.h:
      * rendering/RenderListItem.cpp:
      * rendering/RenderListMarker.cpp:
      * rendering/RenderSnapshottedPlugIn.cpp:
      * rendering/RenderTableCol.cpp:
      * rendering/RenderTableRow.cpp:
      * rendering/RenderTableSection.cpp:
      * rendering/style/StyleCachedShader.h:
      * rendering/style/StyleCustomFilterProgram.cpp: Removed.
      * rendering/style/StyleCustomFilterProgram.h:
      (WebCore):
      (WebCore::StyleCustomFilterProgram::vertexShaderString):
      (StyleCustomFilterProgram):
      (WebCore::StyleCustomFilterProgram::fragmentShaderString):
      (WebCore::StyleCustomFilterProgram::isLoaded):
      (WebCore::StyleCustomFilterProgram::willHaveClients):
      (WebCore::StyleCustomFilterProgram::didRemoveLastClient):
      (WebCore::StyleCustomFilterProgram::notifyFinished):
      * svg/SVGFEImageElement.h:
      * svg/SVGFontFaceUriElement.h:
      (SVGFontFaceUriElement):
      * svg/SVGImageLoader.cpp:
      * svg/SVGUseElement.cpp:
      * svg/SVGUseElement.h:
      * svg/graphics/SVGImageCache.cpp:
      * testing/MockPagePopupDriver.cpp:
      * xml/XSLStyleSheet.h:
      * xml/XSLTProcessorLibxslt.cpp:
      * xml/parser/XMLDocumentParser.cpp:
      * xml/parser/XMLDocumentParser.h:
      * xml/parser/XMLDocumentParserLibxml2.cpp:
      
      Source/WebKit/chromium:
      
      * src/ApplicationCacheHost.cpp:
      * src/AssociatedURLLoader.cpp:
      * src/EditorClientImpl.cpp:
      * src/SharedWorkerRepository.cpp:
      * src/WebDataSourceImpl.cpp:
      * src/WebFrameImpl.h:
      (WebCore):
      * src/WebNode.cpp:
      * src/WebSharedWorkerImpl.cpp:
      * tests/FrameLoaderClientImplTest.cpp:
      
      Source/WebKit/efl:
      
      * WebCoreSupport/DumpRenderTreeSupportEfl.cpp:
      * ewk/ewk_frame.cpp:
      
      Source/WebKit/gtk:
      
      * webkit/webkitwebpolicydecision.cpp:
      
      Source/WebKit/mac:
      
      * DOM/WebDOMOperations.mm:
      * Misc/WebNSPasteboardExtras.mm:
      * WebCoreSupport/WebFrameNetworkingContext.mm:
      * WebView/WebRenderLayer.mm:
      * WebView/WebRenderNode.mm:
      
      Source/WebKit/qt:
      
      * WebCoreSupport/NotificationPresenterClientQt.cpp:
      * WebCoreSupport/QWebPageAdapter.cpp:
      
      Source/WebKit2:
      
      * NetworkProcess/HostRecord.h:
      * NetworkProcess/NetworkResourceLoadScheduler.h:
      * NetworkProcess/NetworkResourceLoader.h:
      (WebCore):
      * Shared/WebRenderLayer.cpp:
      * Shared/WebRenderObject.cpp:
      * WebProcess/Geolocation/GeolocationPermissionRequestManager.cpp:
      * WebProcess/InjectedBundle/API/c/WKBundleFrame.cpp:
      * WebProcess/InjectedBundle/DOM/InjectedBundleNodeHandle.cpp:
      * WebProcess/InjectedBundle/InjectedBundle.cpp:
      * WebProcess/InjectedBundle/InjectedBundleDOMWindowExtension.cpp:
      * WebProcess/Plugins/PDF/PDFPlugin.mm:
      * WebProcess/Plugins/PluginView.cpp:
      * WebProcess/WebCoreSupport/WebContextMenuClient.cpp:
      * WebProcess/WebCoreSupport/WebEditorClient.cpp:
      * WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:
      * WebProcess/WebCoreSupport/mac/WebFrameNetworkingContext.mm:
      * WebProcess/WebPage/mac/WebPageMac.mm:
      * WebProcess/WebProcess.cpp:
      * WebProcess/soup/WebProcessSoup.cpp:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@144446 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      0b87a6c7
    • ap@apple.com's avatar
      Reduce amount of rebuilding when touching networking headers · b2f13721
      ap@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=111035
      
      Reviewed by Eric Seidel.
      
      Source/WebCore:
      
      This uses a number of common unsurprising techniques. One interesting observation
      is that including CachedResource related headers is very expensive. We can usually
      get away with their Client counterparts, and with CachedResourceHandle.
      
      * page/Frame.cpp:
      * page/Frame.h:
      Don't include FrameLoader, greatly reducing include graph for most non-loader files.
      This required making Frame::init() non-inline - I'm not sure why it ever was.
      
      * loader/FrameLoader.cpp:
      * loader/FrameLoader.h:
      Even though FrameLoader is logically on loading side of WebCore, it's included in
      too many places. Not including PolicyChecker.h and ResourceHandle.h was among the
      largest wins. As a future improvement, we should probably convert other members
      to OwnPtrs.
      
      * css/CSSCrossfadeValue.h: Initializing CachedResourceHandle with 0 requires a
      definition of a class it holds, but default construction does not.
      
      * loader/CrossOriginAccessControl.h: This file among others only needs ResourceHandleTypes.h,
      not ResourceHandle.h. This header is semi-recent, so not all include sites were updated.
      
      * loader/cache/CachedFont.h:
      * loader/cache/CachedFontClient.h: Added.
      * loader/cache/CachedRawResource.h:
      * loader/cache/CachedRawResourceClient.h: Added.
      * loader/cache/CachedSVGDocument.h:
      * loader/cache/CachedSVGDocumentClient.h: Added.
      These types were defining client types in the same headers, making it impossible
      to avoid including networking headers through CachedResource. Moved clients into
      separate files.
      
      * plugins/PluginStream.h:
      * plugins/PluginStreamClient.h: Added.
      Similar situation here.
      
      * loader/cache/CachedResourceHandle.cpp:
      * loader/cache/CachedResourceHandle.h:
      Moved functions that need to know about CachedResource to .cpp file. This is another
      huge win. Added a destructor, so that CachedResource woudn't be needed in all files
      that include CachedResourceHandle.
      
      * loader/cache/CachedSVGDocumentReference.cpp: Added.
      * loader/cache/CachedSVGDocumentReference.h:
      Moved constructor and virtual function implementations to a .cpp file - they need
      not inlining, and this lets us avoid including CachedSVGDocument.h in the header.
      
      * platform/graphics/filters/FilterOperation.cpp:
      * platform/graphics/filters/FilterOperation.h:
      Avoid including CachedSVGDocumentReference.h. This is not such a big win now that
      CachedSVGDocumentReference.h itself is smaller, but FilterOperation is so clearly
      rendering code that it seems best to cut any ties with resources and loading.
      Added a virtual destrutor in .cpp file, because inline destructors in polymorphic
      classes are generally harmful (due to code bloat).
      
      * plugins/PluginRequest.h: Added.
      * plugins/PluginView.h:
      Moved PluginRequest into a separate file, it was out of place in a view hierarchy
      class file.
      
      * rendering/RenderImageResource.cpp:
      * rendering/RenderImageResource.h:
      Moved definitions of virtual functions to a .cpp file. Thre is no win from having
      them inline, and now we don't need CachedImage.h in the header.
      
      * rendering/style/StyleCustomFilterProgram.cpp: Added.
      * rendering/style/StyleCustomFilterProgram.h:
      Ditto.
      
      * CMakeLists.txt:
      * GNUmakefile.list.am:
      * Modules/mediastream/RTCPeerConnection.cpp:
      * Modules/notifications/Notification.cpp:
      * Target.pri:
      * WebCore.exp.in:
      * WebCore.gypi:
      * WebCore.vcproj/WebCore.vcproj:
      * WebCore.vcxproj/WebCore.vcxproj:
      * WebCore.vcxproj/WebCore.vcxproj.filters:
      * WebCore.xcodeproj/project.pbxproj:
      * bindings/ScriptControllerBase.cpp:
      * bindings/js/JSNodeCustom.cpp:
      * bindings/js/ScriptController.cpp:
      * bindings/js/ScriptSourceCode.h:
      * bindings/objc/DOM.mm:
      * bindings/v8/ScriptController.cpp:
      * bindings/v8/V8DOMWindowShell.cpp:
      * bindings/v8/custom/V8DOMWindowCustom.cpp:
      * css/CSSFontFaceSource.h:
      * css/CSSFontSelector.cpp:
      * css/WebKitCSSSVGDocumentValue.cpp:
      * css/WebKitCSSSVGDocumentValue.h:
      * dom/Clipboard.cpp:
      * dom/ContainerNode.cpp:
      * dom/DOMImplementation.cpp:
      * dom/PendingScript.h:
      * dom/ScriptElement.cpp:
      * dom/ScriptElement.h:
      * history/CachedFrame.cpp:
      * html/DOMURL.cpp:
      * html/HTMLAnchorElement.cpp:
      * html/HTMLAppletElement.cpp:
      * html/HTMLElement.cpp:
      * html/HTMLEmbedElement.cpp:
      * html/HTMLFrameSetElement.cpp:
      * html/HTMLHtmlElement.cpp:
      * html/HTMLImageElement.cpp:
      * html/HTMLObjectElement.cpp:
      * html/HTMLPlugInElement.cpp:
      * html/ImageDocument.cpp:
      * html/ImageInputType.cpp:
      * html/MediaDocument.cpp:
      * html/PluginDocument.cpp:
      * html/canvas/WebGLRenderingContext.cpp:
      * html/parser/HTMLConstructionSite.cpp:
      * html/parser/HTMLParserOptions.cpp:
      * html/parser/HTMLScriptRunner.h:
      * html/parser/XSSAuditor.cpp:
      * html/parser/XSSAuditorDelegate.cpp:
      * inspector/InspectorDebuggerAgent.cpp:
      * inspector/InspectorFileSystemAgent.cpp:
      * inspector/InspectorFrontendHost.cpp:
      * inspector/InspectorInstrumentation.h:
      * inspector/InspectorPageAgent.cpp:
      * inspector/NetworkResourcesData.cpp:
      * inspector/NetworkResourcesData.h:
      * loader/CookieJar.cpp:
      * loader/CrossOriginAccessControl.cpp:
      * loader/CrossOriginPreflightResultCache.h:
      * loader/DocumentThreadableLoader.h:
      * loader/ImageLoader.cpp:
      * loader/ImageLoader.h:
      * loader/LinkLoader.h:
      * loader/MainResourceLoader.cpp:
      * loader/MainResourceLoader.h:
      * loader/MixedContentChecker.cpp:
      * loader/PingLoader.cpp:
      * loader/PolicyChecker.h:
      * loader/ProgressTracker.cpp:
      * loader/SubframeLoader.cpp:
      * loader/SubresourceLoader.cpp:
      * loader/TextTrackLoader.cpp:
      * loader/TextTrackLoader.h:
      * loader/ThreadableLoader.h:
      * loader/appcache/ApplicationCacheGroup.cpp:
      * loader/appcache/ApplicationCacheGroup.h:
      * loader/appcache/ApplicationCacheHost.cpp:
      * loader/archive/cf/LegacyWebArchive.cpp:
      * loader/cache/CachedFont.cpp:
      * loader/cache/CachedImage.cpp:
      * loader/cache/CachedRawResource.cpp:
      * loader/cache/CachedResource.cpp:
      * loader/cache/CachedStyleSheetClient.h:
      * loader/cache/MemoryCache.cpp:
      * loader/cache/MemoryCache.h:
      * loader/chromium/CachedRawResourceChromium.cpp:
      * loader/icon/IconController.cpp:
      * loader/icon/IconLoader.h:
      * loader/mac/ResourceLoaderMac.mm:
      * page/DOMWindowExtension.cpp:
      * page/DragController.cpp:
      * page/PerformanceNavigation.cpp:
      * page/PerformanceTiming.cpp:
      * page/PointerLockController.cpp:
      * page/Settings.cpp:
      * page/animation/CSSPropertyAnimation.cpp:
      * platform/chromium/PasteboardChromium.cpp:
      * platform/efl/ErrorsEfl.cpp:
      * platform/graphics/avfoundation/MediaPlayerPrivateAVFoundation.cpp:
      * platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.h:
      * platform/graphics/gstreamer/WebKitWebSourceGStreamer.cpp:
      * platform/gtk/ErrorsGtk.cpp:
      * platform/gtk/PasteboardGtk.cpp:
      * platform/gtk/PasteboardHelper.h:
      * platform/mac/ClipboardMac.h:
      * platform/mac/ClipboardMac.mm:
      * platform/mac/HTMLConverter.mm:
      * platform/mac/PasteboardMac.mm:
      * platform/network/AuthenticationChallengeBase.cpp:
      * platform/network/cf/CookieJarCFNet.cpp:
      * platform/network/cf/ResourceRequestCFNet.cpp:
      * platform/network/mac/CookieStorageMac.mm:
      * platform/qt/PasteboardQt.cpp:
      * plugins/DOMMimeType.cpp:
      * plugins/PluginView.cpp:
      * rendering/HitTestResult.cpp:
      * rendering/InlineFlowBox.cpp:
      * rendering/RenderBox.cpp:
      * rendering/RenderEmbeddedObject.cpp:
      * rendering/RenderImage.cpp:
      * rendering/RenderImageResourceStyleImage.cpp:
      * rendering/RenderLayer.cpp:
      * rendering/RenderLayerBacking.cpp:
      * rendering/RenderLayerFilterInfo.h:
      * rendering/RenderListItem.cpp:
      * rendering/RenderListMarker.cpp:
      * rendering/RenderSnapshottedPlugIn.cpp:
      * rendering/RenderTableCol.cpp:
      * rendering/RenderTableRow.cpp:
      * rendering/RenderTableSection.cpp:
      * rendering/style/StyleCachedShader.h:
      * svg/SVGFEImageElement.h:
      * svg/SVGFontFaceUriElement.h:
      * svg/SVGImageLoader.cpp:
      * svg/SVGUseElement.cpp:
      * svg/SVGUseElement.h:
      * svg/graphics/SVGImageCache.cpp:
      * testing/MockPagePopupDriver.cpp:
      * xml/XSLStyleSheet.h:
      * xml/XSLTProcessorLibxslt.cpp:
      * xml/parser/XMLDocumentParser.cpp:
      * xml/parser/XMLDocumentParser.h:
      * xml/parser/XMLDocumentParserLibxml2.cpp:
      Many self-evident changes - removing unnecessary header includes, adding smaller
      more local ones that are now necessary.
      
      Source/WebKit/chromium:
      
      Adding includes that are now necessary because WebCore headers don't have them
      any more.
      
      * src/ApplicationCacheHost.cpp:
      * src/AssociatedURLLoader.cpp:
      * src/EditorClientImpl.cpp:
      * src/SharedWorkerRepository.cpp:
      * src/WebDataSourceImpl.cpp:
      * src/WebFrameImpl.h:
      * src/WebNode.cpp:
      * src/WebSharedWorkerImpl.cpp:
      * tests/FrameLoaderClientImplTest.cpp:
      
      Source/WebKit/efl:
      
      Adding includes that are now necessary because WebCore headers don't have them
      any more.
      
      * WebCoreSupport/DumpRenderTreeSupportEfl.cpp:
      * ewk/ewk_frame.cpp:
      
      Source/WebKit/gtk:
      
      Adding includes that are now necessary because WebCore headers don't have them
      any more.
      
      * webkit/webkitwebpolicydecision.cpp:
      
      Source/WebKit/mac:
      
      Adding includes that are now necessary because WebCore headers don't have them
      any more.
      
      * DOM/WebDOMOperations.mm:
      * Misc/WebNSPasteboardExtras.mm:
      * WebCoreSupport/WebFrameNetworkingContext.mm:
      * WebView/WebRenderLayer.mm:
      * WebView/WebRenderNode.mm:
      
      Source/WebKit/qt:
      
      Adding includes that are now necessary because WebCore headers don't have them
      any more.
      
      * WebCoreSupport/NotificationPresenterClientQt.cpp:
      * WebCoreSupport/QWebPageAdapter.cpp:
      
      Source/WebKit2:
      
      Adding includes that are now necessary because WebCore headers don't have them
      any more.
      
      * NetworkProcess/HostRecord.h:
      * NetworkProcess/NetworkResourceLoadScheduler.h:
      * NetworkProcess/NetworkResourceLoader.h:
      * Shared/WebRenderLayer.cpp:
      * Shared/WebRenderObject.cpp:
      * WebProcess/Geolocation/GeolocationPermissionRequestManager.cpp:
      * WebProcess/InjectedBundle/API/c/WKBundleFrame.cpp:
      * WebProcess/InjectedBundle/DOM/InjectedBundleNodeHandle.cpp:
      * WebProcess/InjectedBundle/InjectedBundle.cpp:
      * WebProcess/InjectedBundle/InjectedBundleDOMWindowExtension.cpp:
      * WebProcess/Plugins/PDF/PDFPlugin.mm:
      * WebProcess/Plugins/PluginView.cpp:
      * WebProcess/WebCoreSupport/WebContextMenuClient.cpp:
      * WebProcess/WebCoreSupport/WebEditorClient.cpp:
      * WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:
      * WebProcess/WebCoreSupport/mac/WebFrameNetworkingContext.mm:
      * WebProcess/WebPage/mac/WebPageMac.mm:
      * WebProcess/WebProcess.cpp:
      * WebProcess/soup/WebProcessSoup.cpp:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@144422 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      b2f13721
  22. 15 Feb, 2013 1 commit
    • allan.jensen@digia.com's avatar
      Simplify hitTestResultAtPoint and nodesFromRect APIs · eb0e1f9f
      allan.jensen@digia.com authored
      https://bugs.webkit.org/show_bug.cgi?id=95720
      
      .:
      
      Reviewed by Julien Chaffraix.
      
      Update exported symbols.
      
      * Source/autotools/symbols.filter:
      
      Source/WebCore:
      
      Reviewed by Julien Chaffraix.
      
      The existing API was overloaded and could be simplified by passing all the bool arguments in
      a HitTestRequest argument. This should also help clarify the call as the enum values explicitely
      state what they do.
      
      * WebCore.exp.in:
      * WebCore.order:
      * dom/Document.cpp:
      (WebCore::Document::nodesFromRect):
      * dom/Document.h:
      (Document):
      * page/ContextMenuController.cpp:
      (WebCore::ContextMenuController::createContextMenu):
      * page/DragController.cpp:
      (WebCore::DragController::canProcessDrag):
      (WebCore::DragController::startDrag):
      * page/EventHandler.cpp:
      (WebCore::EventHandler::hitTestResultAtPoint):
      (WebCore::EventHandler::handleMousePressEvent):
      (WebCore::EventHandler::handleGestureEvent):
      (WebCore::EventHandler::handleGestureForTextSelectionOrContextMenu):
      (WebCore::EventHandler::bestClickableNodeForTouchPoint):
      (WebCore::EventHandler::bestContextMenuNodeForTouchPoint):
      (WebCore::EventHandler::bestZoomableAreaForTouchPoint):
      (WebCore::EventHandler::handleTouchEvent):
      * page/EventHandler.h:
      (WebCore):
      (EventHandler):
      * page/FocusController.cpp:
      (WebCore::updateFocusCandidateIfNeeded):
      * page/Frame.cpp:
      (WebCore::Frame::visiblePositionForPoint):
      (WebCore::Frame::documentAtPoint):
      * page/TouchDisambiguation.cpp:
      (WebCore::findGoodTouchTargets):
      * rendering/HitTestRequest.h:
      (WebCore::HitTestRequest::allowsFrameScrollbars):
      * testing/Internals.cpp:
      (WebCore::Internals::nodesFromRect):
      
      Source/WebKit/blackberry:
      
      Reviewed by Julien Chaffraix.
      
      Update calls to new API.
      
      * Api/WebPage.cpp:
      (BlackBerry::WebKit::WebPagePrivate::contextNode):
      (BlackBerry::WebKit::WebPagePrivate::nodeForZoomUnderPoint):
      (BlackBerry::WebKit::WebPagePrivate::handleMouseEvent):
      (BlackBerry::WebKit::WebPage::nodeAtDocumentPoint):
      (BlackBerry::WebKit::WebPagePrivate::hitTestResult):
      * WebKitSupport/SelectionHandler.cpp:
      (BlackBerry::WebKit::visiblePositionForPointIgnoringClipping):
      
      Source/WebKit/chromium:
      
      Reviewed by Julien Chaffraix.
      
      Update calls to new API.
      
      * src/ContextMenuClientImpl.cpp:
      (WebKit::selectMisspelledWord):
      * src/FrameLoaderClientImpl.cpp:
      (WebKit::FrameLoaderClientImpl::dispatchDecidePolicyForNavigationAction):
      * src/WebFrameImpl.cpp:
      (WebKit::WebFrameImpl::characterIndexForPoint):
      * src/WebPluginContainerImpl.cpp:
      (WebKit::WebPluginContainerImpl::isRectTopmost):
      * src/WebViewImpl.cpp:
      (WebKit::WebViewImpl::handleMouseDown):
      (WebKit::WebViewImpl::computeBlockBounds):
      (WebKit::WebViewImpl::bestTouchLinkNode):
      (WebKit::WebViewImpl::hitTestResultForWindowPos):
      
      Source/WebKit/efl:
      
      Reviewed by Julien Chaffraix.
      
      Update calls to new API.
      
      * ewk/ewk_frame.cpp:
      (ewk_frame_hit_test_new):
      
      Source/WebKit/mac:
      
      Reviewed by Julien Chaffraix.
      
      Update calls to new API.
      
      * WebCoreSupport/WebFrameLoaderClient.mm:
      (WebFrameLoaderClient::actionDictionary):
      * WebView/WebFrame.mm:
      (-[WebFrame elementAtPoint:]):
      * WebView/WebHTMLView.mm:
      (-[WebHTMLView elementAtPoint:allowShadowContent:]):
      
      Source/WebKit/qt:
      
      Reviewed by Julien Chaffraix.
      
      Update calls to new API.
      
      * WebCoreSupport/FrameLoaderClientQt.cpp:
      (WebCore::FrameLoaderClientQt::dispatchDecidePolicyForNavigationAction):
      * WebCoreSupport/QWebFrameAdapter.cpp:
      (QWebFrameAdapter::hitTestContent):
      * WebCoreSupport/QWebPageAdapter.cpp:
      (QWebPageAdapter::TouchAdjuster::findCandidatePointForTouch):
      (QWebPageAdapter::handleSoftwareInputPanel):
      (QWebPageAdapter::updatePositionDependentMenuActions):
      
      Source/WebKit/win:
      
      Reviewed by Julien Chaffraix.
      
      Update calls to new API.
      
      * WebActionPropertyBag.cpp:
      (WebActionPropertyBag::Read):
      * WebKit.vcproj/WebKitExports.def.in:
      * WebView.cpp:
      (WebView::handleContextMenuEvent):
      (WebView::elementAtPoint):
      
      Source/WebKit/wx:
      
      Reviewed by Julien Chaffraix.
      
      Update calls to new API.
      
      * WebFrame.cpp:
      (WebKit::WebFrame::HitTest):
      
      Source/WebKit2:
      
      Reviewed by Julien Chaffraix and Maciej Stachowiak.
      
      Update calls to new API and update exported symbols.
      
      * WebProcess/InjectedBundle/InjectedBundleNavigationAction.cpp:
      (WebKit::InjectedBundleNavigationAction::InjectedBundleNavigationAction):
      * WebProcess/WebPage/WebFrame.cpp:
      (WebKit::WebFrame::hitTest):
      * WebProcess/WebPage/WebPage.cpp:
      (WebKit::handleContextMenuEvent):
      (WebKit::WebPage::highlightPotentialActivation):
      (WebKit::WebPage::findZoomableAreaForPoint):
      * WebProcess/WebPage/mac/WebPageMac.mm:
      (WebKit::WebPage::characterIndexForPoint):
      (WebKit::WebPage::performDictionaryLookupAtLocation):
      (WebKit::WebPage::shouldDelayWindowOrderingEvent):
      (WebKit::WebPage::acceptsFirstMouse):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@142977 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      eb0e1f9f
  23. 09 Feb, 2013 1 commit
    • mkwst@chromium.org's avatar
      Use IGNORE_EXCEPTION for initialized, but unused, ExceptionCodes. · d15dbe65
      mkwst@chromium.org authored
      https://bugs.webkit.org/show_bug.cgi?id=109295
      
      Reviewed by Darin Adler.
      
      The monster patch in http://wkbug.com/108771 missed an entire class of
      ignored exceptions. It only dealt with call sites that never initialized
      the ExceptionCode variable, on the assumption that only such call sites
      would ignore the variable's value.
      
      That was a flawed assumption: a large number of sites that initialize the
      ExceptionCode to 0 ignore it regardless. This patch deals with the
      almost-as-large set of callsites that initialize the variable, pass it to
      a function, and then never touch it again.
      
      * Modules/indexeddb/IDBDatabase.cpp:
      (WebCore::IDBDatabase::forceClose):
      * accessibility/AccessibilityRenderObject.cpp:
      (WebCore::AccessibilityRenderObject::ariaSelectedTextRange):
      (WebCore::AccessibilityRenderObject::visiblePositionForIndex):
      (WebCore::AccessibilityRenderObject::indexForVisiblePosition):
      * accessibility/atk/WebKitAccessibleInterfaceText.cpp:
      (getSelectionOffsetsForObject):
      * accessibility/atk/WebKitAccessibleUtil.cpp:
      (selectionBelongsToObject):
      * dom/Node.cpp:
      (WebCore::Node::textRects):
      * editing/DeleteButtonController.cpp:
      (WebCore::DeleteButtonController::hide):
      * editing/EditingStyle.cpp:
      (WebCore::EditingStyle::styleAtSelectionStart):
      * editing/Editor.cpp:
      (WebCore::Editor::canDeleteRange):
      (WebCore::Editor::pasteAsPlainText):
      (WebCore::Editor::pasteAsFragment):
      (WebCore::Editor::shouldDeleteRange):
      (WebCore::Editor::dispatchCPPEvent):
      (WebCore::Editor::setComposition):
      (WebCore::Editor::advanceToNextMisspelling):
      (WebCore::isFrameInRange):
      * editing/EditorCommand.cpp:
      (WebCore::expandSelectionToGranularity):
      * editing/MergeIdenticalElementsCommand.cpp:
      (WebCore::MergeIdenticalElementsCommand::doApply):
      * editing/SplitElementCommand.cpp:
      (WebCore::SplitElementCommand::doUnapply):
      * editing/SplitTextNodeCommand.cpp:
      (WebCore::SplitTextNodeCommand::doApply):
      * editing/TextCheckingHelper.cpp:
      (WebCore::expandToParagraphBoundary):
      (WebCore::TextCheckingHelper::findFirstMisspellingOrBadGrammar):
      (WebCore::TextCheckingHelper::isUngrammatical):
      (WebCore::TextCheckingHelper::guessesForMisspelledOrUngrammaticalRange):
      * editing/TextInsertionBaseCommand.cpp:
      (WebCore::dispatchBeforeTextInsertedEvent):
      (WebCore::canAppendNewLineFeedToSelection):
      * editing/TextIterator.cpp:
      (WebCore::findPlainText):
      * editing/htmlediting.cpp:
      (WebCore::extendRangeToWrappingNodes):
      (WebCore::isNodeVisiblyContainedWithin):
      * editing/visible_units.cpp:
      (WebCore::nextBoundary):
      * html/FileInputType.cpp:
      (WebCore::FileInputType::createShadowSubtree):
      * html/HTMLKeygenElement.cpp:
      (WebCore::HTMLKeygenElement::HTMLKeygenElement):
      * html/HTMLScriptElement.cpp:
      (WebCore::HTMLScriptElement::setText):
      * html/HTMLTitleElement.cpp:
      (WebCore::HTMLTitleElement::setText):
      * html/HTMLTrackElement.cpp:
      (WebCore::HTMLTrackElement::didCompleteLoad):
      * html/RangeInputType.cpp:
      (WebCore::RangeInputType::createShadowSubtree):
      * html/SearchInputType.cpp:
      (WebCore::SearchInputType::createShadowSubtree):
      * html/TextFieldInputType.cpp:
      (WebCore::TextFieldInputType::createShadowSubtree):
      * html/track/TextTrackList.cpp:
      (TextTrackList::asyncEventTimerFired):
      * inspector/DOMPatchSupport.cpp:
      (WebCore::DOMPatchSupport::patchDocument):
      * inspector/InspectorDatabaseAgent.cpp:
      (WebCore):
      * inspector/InspectorFileSystemAgent.cpp:
      (WebCore):
      * page/DOMSelection.cpp:
      (WebCore::DOMSelection::addRange):
      * page/DragController.cpp:
      (WebCore::DragController::dispatchTextInputEventFor):
      * page/EventHandler.cpp:
      (WebCore::EventHandler::dispatchMouseEvent):
      (WebCore::EventHandler::handleTouchEvent):
      * page/FrameActionScheduler.cpp:
      (WebCore::EventFrameAction::fire):
      * platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm:
      (WebCore::MediaPlayerPrivateAVFoundationObjC::shouldWaitForLoadingOfResource):
      * svg/SVGDocument.cpp:
      (WebCore::SVGDocument::dispatchZoomEvent):
      (WebCore::SVGDocument::dispatchScrollEvent):
      * svg/SVGLength.cpp:
      (WebCore::SVGLength::SVGLength):
      (WebCore::SVGLength::value):
      * xml/parser/XMLDocumentParser.cpp:
      (WebCore::XMLDocumentParser::exitText):
      * xml/parser/XMLDocumentParserQt.cpp:
      (WebCore::XMLDocumentParser::parse):
      (WebCore::XMLDocumentParser::startDocument):
      (WebCore::XMLDocumentParser::parseCharacters):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@142375 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      d15dbe65
  24. 08 Feb, 2013 2 commits
    • mkwst@chromium.org's avatar
      Add a new IGNORE_EXCEPTION helper to ignore ExceptionCodes when they are expected but uninteresting · 33cdf43a
      mkwst@chromium.org authored
      https://bugs.webkit.org/show_bug.cgi?id=108771
      
      Reviewed by Eric Seidel.
      
      In cases where the ExceptionCode passed into a function is completely
      ignored, this patch replaces it with a new IGNORE_EXCEPTION macro. This
      makes our expectations about possible exceptions (or lack thereof)
      explicit, rather than relying on implicit assumptions about whether a
      variable is intentionally uninitialized or not. It also removes
      knowledge about the internals of ExceptionCodes (that they're currently
      ints, for instance) from code that shouldn't care, which will help with
      future refactorings.
      
      The implementation is entirely based upon ASSERT_NO_EXCEPTION, and
      shouldn't have any visible effect on the web. As long as all the
      current tests pass, we're good.
      
      * Modules/indexeddb/IDBRequest.cpp:
      (WebCore::IDBRequest::dispatchEvent):
      (WebCore::IDBRequest::uncaughtExceptionInEventHandler):
      * Modules/indexeddb/IDBTransaction.cpp:
      (WebCore::IDBTransaction::stop):
      * Modules/websockets/WebSocketChannel.cpp:
      (WebCore::WebSocketChannel::processBuffer):
      * dom/Document.cpp:
      (WebCore::Document::processHttpEquiv):
      * dom/ExceptionCodePlaceholder.h:
      (WebCore):
      * dom/Node.cpp:
      (WebCore::Node::normalize):
      * dom/Text.cpp:
      (WebCore::Text::replaceWholeText):
      * editing/AlternativeTextController.cpp:
      (WebCore::AlternativeTextController::insertDictatedText):
      * editing/AppendNodeCommand.cpp:
      (WebCore::AppendNodeCommand::doApply):
      (WebCore::AppendNodeCommand::doUnapply):
      * editing/CompositeEditCommand.cpp:
      (WebCore::CompositeEditCommand::insertNewDefaultParagraphElementAt):
      * editing/DeleteFromTextNodeCommand.cpp:
      (WebCore::DeleteFromTextNodeCommand::doUnapply):
      * editing/Editor.cpp:
      (WebCore::dispatchEditableContentChangedEvents):
      (WebCore::Editor::applyEditingStyleToElement):
      * editing/EditorCommand.cpp:
      (WebCore::executeFormatBlock):
      * editing/FormatBlockCommand.cpp:
      (WebCore::FormatBlockCommand::elementForFormatBlockCommand):
      * editing/InsertIntoTextNodeCommand.cpp:
      (WebCore::InsertIntoTextNodeCommand::doApply):
      (WebCore::InsertIntoTextNodeCommand::doUnapply):
      * editing/InsertListCommand.cpp:
      (WebCore::InsertListCommand::doApplyForSingleParagraph):
      * editing/InsertNodeBeforeCommand.cpp:
      (WebCore::InsertNodeBeforeCommand::doApply):
      (WebCore::InsertNodeBeforeCommand::doUnapply):
      * editing/RemoveCSSPropertyCommand.cpp:
      (WebCore::RemoveCSSPropertyCommand::doApply):
      (WebCore::RemoveCSSPropertyCommand::doUnapply):
      * editing/RemoveNodeCommand.cpp:
      (WebCore::RemoveNodeCommand::doApply):
      (WebCore::RemoveNodeCommand::doUnapply):
      * editing/ReplaceSelectionCommand.cpp:
      (WebCore::ReplaceSelectionCommand::removeRedundantStylesAndKeepStyleSpanInline):
      * editing/TextIterator.cpp:
      (WebCore::TextIterator::getLocationAndLengthFromRange):
      * editing/WrapContentsInDummySpanCommand.cpp:
      (WebCore::WrapContentsInDummySpanCommand::executeApply):
      (WebCore::WrapContentsInDummySpanCommand::doUnapply):
      * editing/htmlediting.cpp:
      (WebCore::comparePositions):
      * editing/markup.cpp:
      (WebCore::highestAncestorToWrapMarkup):
      * html/FTPDirectoryDocument.cpp:
      (WebCore::FTPDirectoryDocumentParser::appendEntry):
      (WebCore::FTPDirectoryDocumentParser::createTDForFilename):
      (WebCore::FTPDirectoryDocumentParser::loadDocumentTemplate):
      (WebCore::FTPDirectoryDocumentParser::createBasicDocument):
      * html/HTMLMediaElement.cpp:
      (WebCore::HTMLMediaElement::rewind):
      (WebCore::HTMLMediaElement::returnToRealtime):
      (WebCore::HTMLMediaElement::playInternal):
      (WebCore::HTMLMediaElement::percentLoaded):
      (WebCore::HTMLMediaElement::mediaPlayerTimeChanged):
      (WebCore::HTMLMediaElement::mediaPlayerDurationChanged):
      (WebCore::HTMLMediaElement::applyMediaFragmentURI):
      * html/HTMLOutputElement.cpp:
      (WebCore::HTMLOutputElement::setTextContentInternal):
      * html/HTMLSelectElement.cpp:
      (WebCore::HTMLSelectElement::remove):
      * html/HTMLTableElement.cpp:
      (WebCore::HTMLTableElement::createTHead):
      (WebCore::HTMLTableElement::deleteTHead):
      (WebCore::HTMLTableElement::createTFoot):
      (WebCore::HTMLTableElement::deleteTFoot):
      (WebCore::HTMLTableElement::createCaption):
      (WebCore::HTMLTableElement::deleteCaption):
      * html/HTMLTextAreaElement.cpp:
      (WebCore::HTMLTextAreaElement::setDefaultValue):
      * html/ImageDocument.cpp:
      (WebCore::ImageDocument::createDocumentStructure):
      * html/InputType.cpp:
      (WebCore::InputType::stepUpFromRenderer):
      * html/MediaController.cpp:
      (MediaController::bringElementUpToSpeed):
      (MediaController::asyncEventTimerFired):
      * html/MediaDocument.cpp:
      (WebCore::MediaDocumentParser::createDocumentStructure):
      (WebCore::MediaDocument::replaceMediaElementTimerFired):
      * html/PluginDocument.cpp:
      (WebCore::PluginDocumentParser::createDocumentStructure):
      * html/RangeInputType.cpp:
      (WebCore::RangeInputType::handleKeydownEvent):
      * html/TimeRanges.cpp:
      (TimeRanges::contain):
      (TimeRanges::nearest):
      * html/canvas/CanvasRenderingContext2D.cpp:
      (WebCore::CanvasRenderingContext2D::drawImageFromRect):
      * html/shadow/MediaControlElementTypes.cpp:
      (WebCore::MediaControlSeekButtonElement::seekTimerFired):
      * html/shadow/MediaControlElements.cpp:
      (WebCore::MediaControlPanelElement::setPosition):
      (WebCore::MediaControlPanelElement::resetPosition):
      (WebCore::MediaControlStatusDisplayElement::update):
      (WebCore::MediaControlRewindButtonElement::defaultEventHandler):
      (WebCore::MediaControlTimelineElement::defaultEventHandler):
      * html/shadow/MediaControls.cpp:
      (WebCore::MediaControls::updateCurrentTimeDisplay):
      (WebCore::MediaControls::createTextTrackDisplay):
      * html/shadow/MediaControlsApple.cpp:
      (WebCore::MediaControlsApple::updateCurrentTimeDisplay):
      * html/shadow/MediaControlsBlackBerry.cpp:
      (WebCore::MediaControlEmbeddedPanelElement::setPosition):
      (WebCore::MediaControlEmbeddedPanelElement::resetPosition):
      (WebCore::MediaControlFullscreenTimelineElement::defaultEventHandler):
      (WebCore::MediaControlsBlackBerry::updateCurrentTimeDisplay):
      * html/shadow/MediaControlsChromium.cpp:
      (WebCore::MediaControlsChromium::updateCurrentTimeDisplay):
      * html/track/InbandTextTrack.cpp:
      (WebCore::InbandTextTrack::addGenericCue):
      * inspector/InspectorCSSAgent.cpp:
      (WebCore::InspectorCSSAgent::buildArrayForMatchedRuleList):
      * inspector/InspectorHistory.cpp:
      (WebCore::InspectorHistory::markUndoableState):
      * inspector/InspectorResourceAgent.cpp:
      (WebCore::InspectorResourceAgent::replayXHR):
      * page/ContextMenuController.cpp:
      (WebCore::ContextMenuController::contextMenuItemSelected):
      * page/DOMWindow.cpp:
      (WebCore::didAddStorageEventListener):
      * page/DragController.cpp:
      (WebCore::documentFragmentFromDragData):
      * page/EventHandler.cpp:
      (WebCore::EventHandler::dispatchDragEvent):
      (WebCore::EventHandler::keyEvent):
      (WebCore::EventHandler::handleTextInputEvent):
      * page/Page.cpp:
      (WebCore::Page::findStringMatchingRanges):
      * platform/efl/RenderThemeEfl.cpp:
      (WebCore::RenderThemeEfl::paintMediaSliderTrack):
      * platform/graphics/blackberry/MediaPlayerPrivateBlackBerry.cpp:
      (WebCore::MediaPlayerPrivate::percentLoaded):
      * platform/gtk/RenderThemeGtk.cpp:
      (WebCore::RenderThemeGtk::paintMediaSliderTrack):
      * platform/mac/PasteboardMac.mm:
      (WebCore::Pasteboard::getDataSelection):
      (WebCore::documentFragmentWithImageResource):
      (WebCore::Pasteboard::documentFragment):
      * platform/mac/WebVideoFullscreenHUDWindowController.mm:
      (-[WebVideoFullscreenHUDWindowController setCurrentTime:]):
      (-[WebVideoFullscreenHUDWindowController setVolume:]):
      * platform/qt/RenderThemeQt.cpp:
      (WebCore::RenderThemeQt::paintMediaSliderTrack):
      * rendering/RenderNamedFlowThread.cpp:
      (WebCore::RenderNamedFlowThread::getRanges):
      * rendering/RenderThemeMac.mm:
      (WebCore::RenderThemeMac::paintMediaSliderTrack):
      * svg/SVGTRefElement.cpp:
      (WebCore::SVGTRefElement::detachTarget):
      * xml/XMLTreeViewer.cpp:
      (WebCore::XMLTreeViewer::transformDocumentToTreeView):
      * xml/parser/XMLDocumentParserLibxml2.cpp:
      (WebCore::XMLDocumentParser::endElementNs):
      * xml/parser/XMLDocumentParserQt.cpp:
      (WebCore::XMLDocumentParser::parseEndElement):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@142271 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      33cdf43a
    • mkwst@chromium.org's avatar
      Replace ExceptionCode assertions with ASSERT_NO_EXCEPTION macro. · 4d257487
      mkwst@chromium.org authored
      https://bugs.webkit.org/show_bug.cgi?id=109044
      
      Reviewed by Darin Adler.
      
      The pattern:
      
          ExceptionCode ec = 0;
          methodThatGeneratesException(ec);
          ASSERT(!ec);
      
      is more clearly and succinctly written as:
      
          methodThatGeneratesException(ASSERT_NO_EXCEPTION);
      
      This patch replaces the occurances of the former that never touch 'ec'
      again with the latter. It does the same for 'ASSERT(ec == 0);' (and, as
      a drive-by, replaces 'ASSERT(ec == 0)' with 'ASSERT(!ec)' in places
      where it does indeed matter that 'ec' get set properly.
      
      No change in behavior should result from this refactoring.
      
      * dom/ContainerNode.cpp:
      (WebCore::ContainerNode::takeAllChildrenFrom):
      * dom/Document.cpp:
      (WebCore::Document::setTitle):
      * dom/MessagePort.cpp:
      (WebCore::MessagePort::dispatchMessages):
      (WebCore::MessagePort::disentanglePorts):
      * editing/DeleteButtonController.cpp:
      (WebCore::enclosingDeletableElement):
      (WebCore::DeleteButtonController::createDeletionUI):
          Replaced inline ASSERT with ASSERT_NO_EXCEPTION.
      (WebCore::DeleteButtonController::show):
          Replaced 'ASSERT(ec == 0)' with 'ASSERT(!ec)' to match the style guide.
      * editing/EditorCommand.cpp:
      (WebCore::unionDOMRanges):
      * editing/ReplaceNodeWithSpanCommand.cpp:
      (WebCore::swapInNodePreservingAttributesAndChildren):
      * editing/ReplaceSelectionCommand.cpp:
      (WebCore::ReplacementFragment::ReplacementFragment):
      (WebCore::ReplacementFragment::removeNode):
      (WebCore::ReplacementFragment::insertNodeBefore):
      (WebCore::ReplacementFragment::insertFragmentForTestRendering):
      (WebCore::ReplacementFragment::restoreAndRemoveTestRenderingNodesToFragment):
      (WebCore::ReplaceSelectionCommand::insertAsListItems):
      * editing/SplitTextNodeCommand.cpp:
      (WebCore::SplitTextNodeCommand::doUnapply):
      * editing/TextIterator.cpp:
      (WebCore::CharacterIterator::range):
      (WebCore::BackwardsCharacterIterator::range):
      (WebCore::TextIterator::rangeFromLocationAndLength):
      (WebCore::collapsedToBoundary):
      * editing/htmlediting.cpp:
      (WebCore::createTabSpanElement):
      * editing/mac/EditorMac.mm:
      (WebCore::Editor::fontForSelection):
      (WebCore::Editor::fontAttributesForSelectionStart):
      * editing/markup.cpp:
      (WebCore::createMarkup):
      (WebCore::trimFragment):
      (WebCore::createFragmentFromMarkupWithContext):
      (WebCore::fillContainerFromString):
      (WebCore::createFragmentFromText):
      (WebCore::createFragmentFromNodes):
      * html/ColorInputType.cpp:
      (WebCore::ColorInputType::createShadowSubtree):
          Replaced inline ASSERT with ASSERT_NO_EXCEPTION.
      * html/HTMLOptionsCollection.cpp:
      (WebCore::HTMLOptionsCollection::add):
          Replaced 'ASSERT(ec == 0)' with 'ASSERT(!ec)' to match the style guide.
      * html/HTMLTextAreaElement.cpp:
      (WebCore::HTMLTextAreaElement::updatePlaceholderText):
      * html/HTMLTextFormControlElement.cpp:
      (WebCore::HTMLTextFormControlElement::indexForVisiblePosition):
      (WebCore::HTMLTextFormControlElement::setInnerTextValue):
      * html/TextFieldInputType.cpp:
      (WebCore::TextFieldInputType::updatePlaceholderText):
      * html/ValidationMessage.cpp:
      (WebCore::ValidationMessage::buildBubbleTree):
      * html/shadow/MediaControlElementTypes.cpp:
      (WebCore::MediaControlVolumeSliderElement::defaultEventHandler):
      * inspector/InspectorPageAgent.cpp:
      (WebCore::InspectorPageAgent::getCookies):
      * inspector/InspectorStyleSheet.cpp:
      (WebCore::InspectorStyleSheet::addRule):
      * loader/appcache/ApplicationCacheHost.cpp:
      (WebCore::ApplicationCacheHost::dispatchDOMEvent):
      * page/DOMSelection.cpp:
      (WebCore::DOMSelection::deleteFromDocument):
      * page/DragController.cpp:
      (WebCore::prepareClipboardForImageDrag):
      * rendering/RenderTextControl.cpp:
      (WebCore::RenderTextControl::visiblePositionForIndex):
          Replaced inline ASSERT with ASSERT_NO_EXCEPTION.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@142247 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      4d257487
  25. 07 Feb, 2013 2 commits
    • gavinp@chromium.org's avatar
      Unreviewed, rolling out r142118. · 0a23dbe0
      gavinp@chromium.org authored
      http://trac.webkit.org/changeset/142118
      https://bugs.webkit.org/show_bug.cgi?id=109044
      
      Broke SVG! Oh noes!
      
      * Modules/indexeddb/IDBCursor.cpp:
      (WebCore::IDBCursor::direction):
      * Modules/indexeddb/IDBObjectStore.cpp:
      (WebCore):
      * Modules/indexeddb/IDBTransaction.cpp:
      (WebCore::IDBTransaction::mode):
      * dom/ContainerNode.cpp:
      (WebCore::ContainerNode::takeAllChildrenFrom):
      * dom/Document.cpp:
      (WebCore::Document::setTitle):
      * dom/MessagePort.cpp:
      (WebCore::MessagePort::dispatchMessages):
      (WebCore::MessagePort::disentanglePorts):
      * editing/DeleteButtonController.cpp:
      (WebCore::enclosingDeletableElement):
      (WebCore::DeleteButtonController::createDeletionUI):
      (WebCore::DeleteButtonController::show):
      * editing/EditorCommand.cpp:
      (WebCore::unionDOMRanges):
      * editing/ReplaceNodeWithSpanCommand.cpp:
      (WebCore::swapInNodePreservingAttributesAndChildren):
      * editing/ReplaceSelectionCommand.cpp:
      (WebCore::ReplacementFragment::ReplacementFragment):
      (WebCore::ReplacementFragment::removeNode):
      (WebCore::ReplacementFragment::insertNodeBefore):
      (WebCore::ReplacementFragment::insertFragmentForTestRendering):
      (WebCore::ReplacementFragment::restoreAndRemoveTestRenderingNodesToFragment):
      (WebCore::ReplaceSelectionCommand::insertAsListItems):
      * editing/SplitTextNodeCommand.cpp:
      (WebCore::SplitTextNodeCommand::doUnapply):
      * editing/TextIterator.cpp:
      (WebCore::CharacterIterator::range):
      (WebCore::BackwardsCharacterIterator::range):
      (WebCore::TextIterator::rangeFromLocationAndLength):
      (WebCore::collapsedToBoundary):
      * editing/htmlediting.cpp:
      (WebCore::createTabSpanElement):
      * editing/mac/EditorMac.mm:
      (WebCore::Editor::fontForSelection):
      (WebCore::Editor::fontAttributesForSelectionStart):
      * editing/markup.cpp:
      (WebCore::createMarkup):
      (WebCore::trimFragment):
      (WebCore::createFragmentFromMarkupWithContext):
      (WebCore::fillContainerFromString):
      (WebCore::createFragmentFromText):
      (WebCore::createFragmentFromNodes):
      * html/ColorInputType.cpp:
      (WebCore::ColorInputType::createShadowSubtree):
      * html/HTMLOptionsCollection.cpp:
      (WebCore::HTMLOptionsCollection::add):
      * html/HTMLTextAreaElement.cpp:
      (WebCore::HTMLTextAreaElement::updatePlaceholderText):
      * html/HTMLTextFormControlElement.cpp:
      (WebCore::HTMLTextFormControlElement::indexForVisiblePosition):
      (WebCore::HTMLTextFormControlElement::setInnerTextValue):
      * html/TextFieldInputType.cpp:
      (WebCore::TextFieldInputType::updatePlaceholderText):
      * html/ValidationMessage.cpp:
      (WebCore::ValidationMessage::buildBubbleTree):
      * html/shadow/MediaControlElementTypes.cpp:
      (WebCore::MediaControlVolumeSliderElement::defaultEventHandler):
      * inspector/InspectorPageAgent.cpp:
      (WebCore::InspectorPageAgent::getCookies):
      * inspector/InspectorStyleSheet.cpp:
      (WebCore::InspectorStyleSheet::addRule):
      * loader/appcache/ApplicationCacheHost.cpp:
      (WebCore::ApplicationCacheHost::dispatchDOMEvent):
      * page/DOMSelection.cpp:
      (WebCore::DOMSelection::deleteFromDocument):
      * page/DragController.cpp:
      (WebCore::prepareClipboardForImageDrag):
      * rendering/RenderTextControl.cpp:
      (WebCore::RenderTextControl::visiblePositionForIndex):
      * rendering/style/SVGRenderStyle.h:
      (WebCore::SVGRenderStyle::initialBaselineShiftValue):
      (WebCore::SVGRenderStyle::initialKerning):
      (WebCore::SVGRenderStyle::initialStrokeDashOffset):
      (WebCore::SVGRenderStyle::initialStrokeWidth):
      * svg/SVGAnimatedLength.cpp:
      (WebCore::sharedSVGLength):
      (WebCore::SVGAnimatedLengthAnimator::addAnimatedTypes):
      (WebCore::SVGAnimatedLengthAnimator::calculateAnimatedValue):
      * svg/SVGAnimatedLengthList.cpp:
      (WebCore::SVGAnimatedLengthListAnimator::addAnimatedTypes):
      (WebCore::SVGAnimatedLengthListAnimator::calculateAnimatedValue):
      * svg/SVGLength.cpp:
      (WebCore::SVGLength::SVGLength):
      * svg/SVGTextContentElement.cpp:
      (WebCore::SVGTextContentElement::textLengthAnimated):
      * svg/animation/SVGSMILElement.cpp:
      (WebCore::constructQualifiedName):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@142126 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      0a23dbe0
    • mkwst@chromium.org's avatar
      Replace ExceptionCode assertions with ASSERT_NO_EXCEPTION macro. · 50f39a6e
      mkwst@chromium.org authored
      https://bugs.webkit.org/show_bug.cgi?id=109044
      
      Reviewed by Darin Adler.
      
      The pattern:
      
          ExceptionCode ec = 0;
          methodThatGeneratesException(ec);
          ASSERT(!ec);
      
      is more clearly and succinctly written as:
      
          methodThatGeneratesException(ASSERT_NO_EXCEPTION);
      
      This patch replaces the occurances of the former that never touch 'ec'
      again with the latter. It does the same for 'ASSERT(ec == 0);' (and, as
      a drive-by, replaces 'ASSERT(ec == 0)' with 'ASSERT(!ec)' in places
      where it does indeed matter that 'ec' get set properly.
      
      No change in behavior should result from this refactoring.
      
      * Modules/indexeddb/IDBCursor.cpp:
      (WebCore::IDBCursor::direction):
      * Modules/indexeddb/IDBObjectStore.cpp:
      (WebCore):
      * Modules/indexeddb/IDBTransaction.cpp:
      (WebCore::IDBTransaction::mode):
      * dom/ContainerNode.cpp:
      (WebCore::ContainerNode::takeAllChildrenFrom):
      * dom/Document.cpp:
      (WebCore::Document::setTitle):
      * dom/MessagePort.cpp:
      (WebCore::MessagePort::dispatchMessages):
      (WebCore::MessagePort::disentanglePorts):
      * editing/DeleteButtonController.cpp:
      (WebCore::enclosingDeletableElement):
      (WebCore::DeleteButtonController::createDeletionUI):
          Replaced inline ASSERT with ASSERT_NO_EXCEPTION.
      (WebCore::DeleteButtonController::show):
          Replaced 'ASSERT(ec == 0)' with 'ASSERT(!ec)' to match the style guide.
      * editing/EditorCommand.cpp:
      (WebCore::unionDOMRanges):
      * editing/ReplaceNodeWithSpanCommand.cpp:
      (WebCore::swapInNodePreservingAttributesAndChildren):
      * editing/ReplaceSelectionCommand.cpp:
      (WebCore::ReplacementFragment::ReplacementFragment):
      (WebCore::ReplacementFragment::removeNode):
      (WebCore::ReplacementFragment::insertNodeBefore):
      (WebCore::ReplacementFragment::insertFragmentForTestRendering):
      (WebCore::ReplacementFragment::restoreAndRemoveTestRenderingNodesToFragment):
      (WebCore::ReplaceSelectionCommand::insertAsListItems):
      * editing/SplitTextNodeCommand.cpp:
      (WebCore::SplitTextNodeCommand::doUnapply):
      * editing/TextIterator.cpp:
      (WebCore::CharacterIterator::range):
      (WebCore::BackwardsCharacterIterator::range):
      (WebCore::TextIterator::rangeFromLocationAndLength):
      (WebCore::collapsedToBoundary):
      * editing/htmlediting.cpp:
      (WebCore::createTabSpanElement):
      * editing/mac/EditorMac.mm:
      (WebCore::Editor::fontForSelection):
      (WebCore::Editor::fontAttributesForSelectionStart):
      * editing/markup.cpp:
      (WebCore::createMarkup):
      (WebCore::trimFragment):
      (WebCore::createFragmentFromMarkupWithContext):
      (WebCore::fillContainerFromString):
      (WebCore::createFragmentFromText):
      (WebCore::createFragmentFromNodes):
      * html/ColorInputType.cpp:
      (WebCore::ColorInputType::createShadowSubtree):
          Replaced inline ASSERT with ASSERT_NO_EXCEPTION.
      * html/HTMLOptionsCollection.cpp:
      (WebCore::HTMLOptionsCollection::add):
          Replaced 'ASSERT(ec == 0)' with 'ASSERT(!ec)' to match the style guide.
      * html/HTMLTextAreaElement.cpp:
      (WebCore::HTMLTextAreaElement::updatePlaceholderText):
      * html/HTMLTextFormControlElement.cpp:
      (WebCore::HTMLTextFormControlElement::indexForVisiblePosition):
      (WebCore::HTMLTextFormControlElement::setInnerTextValue):
      * html/TextFieldInputType.cpp:
      (WebCore::TextFieldInputType::updatePlaceholderText):
      * html/ValidationMessage.cpp:
      (WebCore::ValidationMessage::buildBubbleTree):
      * html/shadow/MediaControlElementTypes.cpp:
      (WebCore::MediaControlVolumeSliderElement::defaultEventHandler):
      * inspector/InspectorPageAgent.cpp:
      (WebCore::InspectorPageAgent::getCookies):
      * inspector/InspectorStyleSheet.cpp:
      (WebCore::InspectorStyleSheet::addRule):
      * loader/appcache/ApplicationCacheHost.cpp:
      (WebCore::ApplicationCacheHost::dispatchDOMEvent):
      * page/DOMSelection.cpp:
      (WebCore::DOMSelection::deleteFromDocument):
      * page/DragController.cpp:
      (WebCore::prepareClipboardForImageDrag):
      * rendering/RenderTextControl.cpp:
      (WebCore::RenderTextControl::visiblePositionForIndex):
      * rendering/style/SVGRenderStyle.h:
      (WebCore::SVGRenderStyle::initialBaselineShiftValue):
      (WebCore::SVGRenderStyle::initialKerning):
      (WebCore::SVGRenderStyle::initialStrokeDashOffset):
      (WebCore::SVGRenderStyle::initialStrokeWidth):
      * svg/SVGAnimatedLength.cpp:
      (WebCore::sharedSVGLength):
      (WebCore::SVGAnimatedLengthAnimator::addAnimatedTypes):
      (WebCore::SVGAnimatedLengthAnimator::calculateAnimatedValue):
      * svg/SVGAnimatedLengthList.cpp:
      (WebCore::SVGAnimatedLengthListAnimator::addAnimatedTypes):
      (WebCore::SVGAnimatedLengthListAnimator::calculateAnimatedValue):
      * svg/SVGLength.cpp:
      (WebCore::SVGLength::SVGLength):
      * svg/SVGTextContentElement.cpp:
      (WebCore::SVGTextContentElement::textLengthAnimated):
      * svg/animation/SVGSMILElement.cpp:
      (WebCore::constructQualifiedName):
          Replaced inline ASSERT with ASSERT_NO_EXCEPTION.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@142118 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      50f39a6e
  26. 23 Jan, 2013 1 commit
    • shinyak@chromium.org's avatar
      shadowAncestorNode() should be renamed to deprecatedShadowAncestorNode() · 659784bf
      shinyak@chromium.org authored
      https://bugs.webkit.org/show_bug.cgi?id=107624
      
      Reviewed by Dimitri Glazkov.
      
      Since Node::shadowAncestorNode() is deprecated, we would like to rename it to prevent from further use.
      
      Source/WebCore:
      
      No new tests, simple refactoring.
      
      * WebCore.order:
      * accessibility/AccessibilityRenderObject.cpp:
      (WebCore::AccessibilityRenderObject::accessibilityHitTest):
      * dom/Document.cpp:
      (WebCore::Document::handleZeroPadding):
      * dom/Node.cpp:
      (WebCore::Node::deprecatedShadowAncestorNode):
      * dom/Node.h:
      (Node):
      * editing/Editor.cpp:
      (WebCore::Editor::rangeOfString):
      (WebCore::Editor::countMatchesForText):
      * editing/ReplaceSelectionCommand.cpp:
      (WebCore::ReplacementFragment::ReplacementFragment):
      * page/DragController.cpp:
      (WebCore::elementUnderMouse):
      * page/EventHandler.cpp:
      (WebCore::EventHandler::handleMouseReleaseEvent):
      (WebCore::EventHandler::bestClickableNodeForTouchPoint):
      * page/FocusController.cpp:
      (WebCore::clearSelectionIfNeeded):
      * platform/blackberry/RenderThemeBlackBerry.cpp:
      (WebCore::RenderThemeBlackBerry::paintSearchFieldCancelButton):
      * rendering/HitTestResult.cpp:
      (WebCore::HitTestResult::setToNonShadowAncestor):
      (WebCore::HitTestResult::addNodeToRectBasedTestResult):
      
      Source/WebKit/blackberry:
      
      * Api/WebPage.cpp:
      (BlackBerry::WebKit::WebPagePrivate::webContext):
      * WebKitSupport/FatFingers.h:
      (BlackBerry::WebKit::FatFingersResult::node):
      * WebKitSupport/InPageSearchManager.cpp:
      (BlackBerry::WebKit::InPageSearchManager::scopeStringMatches):
      
      Source/WebKit/chromium:
      
      * src/WebFrameImpl.cpp:
      (WebKit::WebFrameImpl::scopeStringMatches):
      (WebKit::WebFrameImpl::setFindEndstateFocusAndSelection):
      
      Source/WebKit/qt:
      
      * WebCoreSupport/QWebPageAdapter.cpp:
      (QWebPageAdapter::inputMethodEvent):
      (QWebPageAdapter::inputMethodQuery):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@140541 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      659784bf
  27. 21 Dec, 2012 1 commit
    • timothy_horton@apple.com's avatar
      PDFPlugin: Cannot drop files/URLs on PDFPlugin · 8e3ce2f3
      timothy_horton@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=105516
      <rdar://problem/12729443>
      
      Reviewed by Alexey Proskuryakov.
      
      Add shouldAllowNavigationFromDrags to Plugin/PluginView/etc., which WebCore will
      consult when dragging over a PluginDocument to decide whether or not a drag may result in navigation.
      
      * WebProcess/Plugins/Netscape/NetscapePlugin.cpp:
      (WebKit::NetscapePlugin::shouldAllowNavigationFromDrags): Added, always returning false to keep existing behavior.
      * WebProcess/Plugins/Netscape/NetscapePlugin.h:
      (NetscapePlugin): Added.
      * WebProcess/Plugins/PDF/SimplePDFPlugin.h:
      (WebKit::SimplePDFPlugin::shouldAllowNavigationFromDrags): Added, always returning true. (Simple)PDFPlugin should
      navigate when dropped onto, just like an image or HTML document would.
      * WebProcess/Plugins/Plugin.h:
      (Plugin): Add shouldAllowNavigationFromDrags.
      * WebProcess/Plugins/PluginProxy.h: Add shouldAllowNavigationFromDrags.
      * WebProcess/Plugins/PluginView.cpp:
      (WebKit::PluginView::shouldAllowNavigationFromDrags): Forward shouldAllowNavigationFromDrags to the plugin.
      * WebProcess/Plugins/PluginView.h: Add shouldAllowNavigationFromDrags.
      
      * page/DragController.cpp:
      (WebCore::DragController::operationForLoad): If we drag over a PluginDocument, check if its PluginView
      claims to support navigation resulting from a drag (only PDFPlugin will for now). If it does, allow the drag.
      * plugins/PluginViewBase.h:
      (WebCore::PluginViewBase::shouldAllowNavigationFromDrags): Add shouldAllowNavigationFromDrags.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@138361 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      8e3ce2f3
  28. 11 Dec, 2012 1 commit
    • dpranke@chromium.org's avatar
      Switch to new PseudoElement based :before and :after · cecd9c05
      dpranke@chromium.org authored
      https://bugs.webkit.org/show_bug.cgi?id=104462
      
      Patch by Elliott Sprehn <esprehn@chromium.org> on 2012-12-11
      Reviewed by Antti Koivisto.
      
      Source/WebCore:
      
      Switch to the new PseudoElement based generated content implementation
      that moves :before and :after into the DOM. This also switches to using
      the ComposedShadowTreeWalker for determining the siblings of PseudoElement's
      making the new generated content implementation support adding :before
      and :after into <input> elements.
      
      Tests: fast/css-generated-content/block-inside-inline.html
             fast/css-generated-content/box-orient.html
      
      * dom/ComposedShadowTreeWalker.cpp:
      (WebCore::ComposedShadowTreeWalker::pseudoAwareNextSibling):
      (WebCore):
      (WebCore::ComposedShadowTreeWalker::pseudoAwarePreviousSibling):
      (WebCore::ComposedShadowTreeWalker::traverseParent):
      * dom/ComposedShadowTreeWalker.h:
      (ComposedShadowTreeWalker):
      * dom/Element.cpp:
      (WebCore::Element::attach):
      (WebCore::Element::recalcStyle):
      * dom/Node.cpp:
      * dom/Node.h:
      (Node):
      * dom/NodeRenderingContext.cpp:
      (WebCore::NodeRenderingContext::nextRenderer):
      (WebCore::NodeRenderingContext::previousRenderer):
      (WebCore::NodeRenderingContext::createRendererForElementIfNeeded):
      * dom/Position.cpp:
      (WebCore::Position::Position):
      (WebCore::Position::hasRenderedNonAnonymousDescendantsWithHeight):
      * editing/visible_units.cpp:
      (WebCore::logicallyPreviousBox):
      (WebCore::logicallyNextBox):
      (WebCore::startPositionForLine):
      (WebCore::endPositionForLine):
      * html/HTMLTextFormControlElement.cpp:
      (WebCore::HTMLTextFormControlElement::childShouldCreateRenderer):
      * page/DragController.cpp:
      (WebCore::DragController::draggableNode):
      * rendering/RenderBlock.cpp:
      (WebCore::RenderBlock::styleDidChange):
      (WebCore::RenderBlock::splitBlocks):
      (WebCore::RenderBlock::addChildIgnoringAnonymousColumnBlocks):
      (WebCore::RenderBlock::createReplacementRunIn):
      (WebCore::RenderBlock::isSelectionRoot):
      * rendering/RenderBlock.h:
      (RenderBlock):
      * rendering/RenderButton.cpp:
      * rendering/RenderButton.h:
      (RenderButton):
      * rendering/RenderInline.cpp:
      (WebCore::RenderInline::styleDidChange):
      (WebCore::RenderInline::addChildIgnoringContinuation):
      (WebCore::RenderInline::splitInlines):
      * rendering/RenderListItem.cpp:
      (WebCore::RenderListItem::updateMarkerLocation):
      * rendering/RenderObject.cpp:
      (WebCore::RenderObject::createVisiblePosition):
      * rendering/RenderObject.h:
      (WebCore::RenderObject::nonPseudoNode):
      (RenderObject):
      (WebCore::RenderObject::clearNode):
      (WebCore::RenderObject::generatingNode):
      * rendering/RenderObjectChildList.cpp:
      * rendering/RenderObjectChildList.h:
      (RenderObjectChildList):
      * rendering/RenderRubyText.cpp:
      * rendering/RenderRubyText.h:
      (RenderRubyText):
      * rendering/RenderTableRow.cpp:
      (WebCore::RenderTableRow::styleDidChange):
      * rendering/RenderTableRow.h:
      * rendering/RenderTableSection.cpp:
      (WebCore::RenderTableSection::addChild):
      * rendering/RenderWidget.cpp:
      (WebCore::RenderWidget::destroy):
      
      LayoutTests:
      
      Add test for block generated content inside inlines which is now supported
      properly, and also for using box-orient and reordering.
      
      before-content-continuation.html's expectations change because we now
      support block content properly.
      
      I skipped fast/css-generated-content/table-row-group-to-inline.html
      which needs a rebaseline after this this lands. Unfortunately the test
      output is still wrong because we leave an anonymous RenderTable in the
      tree, but that bug has always been there.
      
      I also skipped fast/css/empty-generated-content.html which needs rebaselines
      as we no longer create extra anonymous blocks, though the reason is not clear
      to me.
      
      * fast/css-generated-content/before-content-continuation-chain-expected.txt:
      * fast/css-generated-content/block-inside-inline-expected.html: Added.
      * fast/css-generated-content/block-inside-inline.html: Added.
      * fast/css-generated-content/box-orient-expected.html: Added.
      * fast/css-generated-content/box-orient.html: Added.
      * platform/chromium/TestExpectations:
      * platform/mac/TestExpectations:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@137336 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      cecd9c05
  29. 28 Nov, 2012 1 commit
    • simonjam@chromium.org's avatar
      Consolidate FrameLoader::load() into one function taking a FrameLoadRequest · c98850bc
      simonjam@chromium.org authored
      https://bugs.webkit.org/show_bug.cgi?id=102151
      
      Reviewed by Adam Barth.
      
      Source/WebCore:
      
      There's a FIXME that we have too many FrameLoader::load*() functions. This patch consolidates 3 into 1.
      There are still a few more load functions that will be consolidated later. Using FrameLoadRequest as
      the interface into FrameLoader will also provide a place to pass in the initiator. Finally, this matches
      the refactoring done with CachedResourceRequest and CachedResourceLoader.
      
      No new tests. No change in functionality.
      
      * WebCore.exp.in:
      * loader/FrameLoadRequest.h:
      (WebCore::FrameLoadRequest::FrameLoadRequest):
      (WebCore::FrameLoadRequest::setLockHistory): These are former arguments to load().
      (WebCore::FrameLoadRequest::lockHistory): Ditto.
      (FrameLoadRequest):
      (WebCore::FrameLoadRequest::setShouldCheckNewWindowPolicy): Ditto.
      (WebCore::FrameLoadRequest::shouldCheckNewWindowPolicy): Ditto.
      (WebCore::FrameLoadRequest::substituteData): Ditto.
      (WebCore::FrameLoadRequest::setSubstituteData): Ditto.
      (WebCore::FrameLoadRequest::hasSubstituteData): Ditto.
      * loader/FrameLoader.cpp:
      (WebCore::FrameLoader::load): No change in behavior, just merged it all into one function.
      * loader/FrameLoader.h:
      (FrameLoader):
      * page/DragController.cpp:
      (WebCore::DragController::performDrag):
      
      Source/WebKit/blackberry:
      
      * Api/WebPage.cpp:
      (BlackBerry::WebKit::WebPagePrivate::load):
      (BlackBerry::WebKit::WebPagePrivate::loadString):
      * WebCoreSupport/FrameLoaderClientBlackBerry.cpp:
      (WebCore::FrameLoaderClientBlackBerry::dispatchDidFailProvisionalLoad):
      
      Source/WebKit/chromium:
      
      * src/WebFrameImpl.cpp:
      (WebKit::WebFrameImpl::loadRequest):
      (WebKit::WebFrameImpl::loadData):
      * src/WebSharedWorkerImpl.cpp:
      (WebKit::WebSharedWorkerImpl::initializeLoader):
      
      Source/WebKit/efl:
      
      * ewk/ewk_frame.cpp:
      (_ewk_frame_contents_set_internal):
      
      Source/WebKit/gtk:
      
      * webkit/webkitwebframe.cpp:
      (webkit_web_frame_load_uri):
      (webkit_web_frame_load_data):
      (webkit_web_frame_load_request):
      
      Source/WebKit/mac:
      
      * Plugins/WebPluginController.mm:
      * WebView/WebFrame.mm:
      (-[WebFrame loadRequest:]):
      (-[WebFrame _loadData:MIMEType:textEncodingName:baseURL:unreachableURL:]):
      
      Source/WebKit/qt:
      
      * Api/qwebframe.cpp:
      (QWebFrame::QWebFrame):
      (QWebFrame::load):
      (QWebFrame::setHtml):
      (QWebFrame::setContent):
      * WebCoreSupport/DumpRenderTreeSupportQt.cpp:
      (DumpRenderTreeSupportQt::setAlternateHtml):
      (qt_dump_set_accepts_editing):
      * WebCoreSupport/FrameLoaderClientQt.cpp:
      (WebCore::FrameLoaderClientQt::callErrorPageExtension):
      
      Source/WebKit/win:
      
      * WebFrame.cpp:
      (WebFrame::loadRequest):
      (WebFrame::loadData):
      
      Source/WebKit/wince:
      
      * WebView.cpp:
      (WebView::load):
      
      Source/WebKit/wx:
      
      * WebFrame.cpp:
      (WebKit::WebFrame::SetPageSource):
      
      Source/WebKit2:
      
      * WebProcess/Plugins/PluginView.cpp:
      (WebKit::PluginView::performFrameLoadURLRequest):
      * WebProcess/WebPage/WebPage.cpp:
      (WebKit::WebPage::loadURLRequest):
      (WebKit::WebPage::loadData):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@135952 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      c98850bc
  30. 27 Nov, 2012 1 commit
    • ossy@webkit.org's avatar
      Unreviewed, rolling out r135786. · c022234d
      ossy@webkit.org authored
      http://trac.webkit.org/changeset/135786
      https://bugs.webkit.org/show_bug.cgi?id=103379
      
      It made 3 plugin tests timeout on several platforms (Requested
      by Ossy on #webkit).
      
      Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-11-27
      
      Source/WebCore:
      
      * CMakeLists.txt:
      * GNUmakefile.list.am:
      * Target.pri:
      * WebCore.exp.in:
      * WebCore.gypi:
      * WebCore.vcproj/WebCore.vcproj:
      * WebCore.xcodeproj/project.pbxproj:
      * loader/FrameLoadRequest.cpp: Removed.
      * loader/FrameLoadRequest.h:
      (WebCore::FrameLoadRequest::FrameLoadRequest):
      (FrameLoadRequest):
      * loader/FrameLoader.cpp:
      (WebCore::FrameLoader::load):
      * loader/FrameLoader.h:
      (FrameLoader):
      * page/DragController.cpp:
      (WebCore::DragController::performDrag):
      * plugins/PluginView.cpp:
      (WebCore::PluginView::performRequest):
      
      Source/WebKit/blackberry:
      
      * Api/WebPage.cpp:
      (BlackBerry::WebKit::WebPagePrivate::load):
      (BlackBerry::WebKit::WebPagePrivate::loadString):
      * WebCoreSupport/FrameLoaderClientBlackBerry.cpp:
      (WebCore::FrameLoaderClientBlackBerry::dispatchDidFailProvisionalLoad):
      
      Source/WebKit/chromium:
      
      * src/WebFrameImpl.cpp:
      (WebKit::WebFrameImpl::loadRequest):
      (WebKit::WebFrameImpl::loadData):
      * src/WebSharedWorkerImpl.cpp:
      (WebKit::WebSharedWorkerImpl::initializeLoader):
      
      Source/WebKit/efl:
      
      * ewk/ewk_frame.cpp:
      (ewk_frame_uri_set):
      (_ewk_frame_contents_set_internal):
      
      Source/WebKit/gtk:
      
      * webkit/webkitwebframe.cpp:
      (webkit_web_frame_load_uri):
      (webkit_web_frame_load_data):
      (webkit_web_frame_load_request):
      
      Source/WebKit/mac:
      
      * Plugins/WebPluginController.mm:
      * WebView/WebFrame.mm:
      (-[WebFrame loadRequest:]):
      (-[WebFrame _loadData:MIMEType:textEncodingName:baseURL:unreachableURL:]):
      
      Source/WebKit/qt:
      
      * Api/qwebframe.cpp:
      (QWebFrame::setHtml):
      (QWebFrame::setContent):
      * WebCoreSupport/DumpRenderTreeSupportQt.cpp:
      (DumpRenderTreeSupportQt::setAlternateHtml):
      * WebCoreSupport/FrameLoaderClientQt.cpp:
      (WebCore::FrameLoaderClientQt::callErrorPageExtension):
      * WebCoreSupport/QWebFrameAdapter.cpp:
      (QWebFrameAdapter::load):
      
      Source/WebKit/win:
      
      * WebFrame.cpp:
      (WebFrame::loadRequest):
      (WebFrame::loadData):
      
      Source/WebKit/wince:
      
      * WebView.cpp:
      (WebView::load):
      
      Source/WebKit/wx:
      
      * WebFrame.cpp:
      (WebKit::WebFrame::SetPageSource):
      
      Source/WebKit2:
      
      * WebProcess/Plugins/PluginView.cpp:
      (WebKit::PluginView::performFrameLoadURLRequest):
      * WebProcess/WebPage/WebPage.cpp:
      (WebKit::WebPage::loadURLRequest):
      (WebKit::WebPage::loadData):
      (WebKit::WebPage::linkClicked):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@135837 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      c022234d