1. 19 Jul, 2011 36 commits
    • aroben@apple.com's avatar
      Make TestFailures show existing bugs and a new bug link for flaky tests · 407243d1
      aroben@apple.com authored
      Fixes <http://webkit.org/b/63728> TestFailures page should make it easy to file bugs about
      flaky tests
      and
      <http://webkit.org/b/63830> TestFailures page doesn't show related bugs for possibly-flaky
      tests, but should
      
      Reviewed by Sam Weinig.
      
      * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/FlakyTestBugForm.js:
      Added. This is what's used to file new bugs about flaky tests.
      (FlakyTestBugForm): Calls up to the base class, stores the arguments, and sets our
      title, description, and URL.
      
      (FlakyTestBugForm.prototype._createBugDescription):
      (FlakyTestBugForm.prototype._createBugTitle):
      These do what they say.
      
      * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/FlakyTestBugForm_unittests.js:
      Added. Tests of the above.
      
      * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/TestFailures.css:
      (#failure-history > li):
      (#possibly-flaky-tests > li):
      (#failure-history > li, #possibly-flaky-tests > li):
      (#possibly-flaky-tests > li > :first-child):
      (.flakiness-examples-list):
      Styling to account for the new elements.
      
      (.expandable):
      (.expanded > .expandable):
      Generalized the .flakiness-example-list code to a generic .expandable class. Removed the
      transition properties because we can't transition to/from 'auto' (but really would like
      to!).
      
      * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/ViewController.js:
      (ViewController.prototype._displayBuilder): Moved code to create the FailingTestsBugForm
      here from _domForNewAndExistingBugs. Updated for changes to _domForPossiblyFlakyTests.
      (ViewController.prototype._domForNewAndExistingBugs): Changed to take a NewBugForm as an
      argument instead of creating one ourselves.
      (ViewController.prototype._domForPossiblyFlakyTests): Changed to take all analyzed builds as
      an argument instead of just the number of analyzed builds. Put the examples list inside a
      container <div>, which is also used to hold the new/existing bugs UI. Removed code to deal
      with animating the height of the examples list; we don't do this anymore because it's hard
      to make it work correctly with the asynchronous loading of existing bugs. When we populate
      the examples list, also set up the new/existing bug UI.
      
      * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/index.html: Pull in
      FlakyTestBugForm.
      
      * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/run-unittests.html:
      Pull in FlakyTestBugForm and its tests.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@91278 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      407243d1
    • robert@webkit.org's avatar
      REGRESSION: Incorrect layout at recline-online.com · cae18598
      robert@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=64030
      
      Reviewed by David Hyatt.
      
      Source/WebCore:
      
      http://trac.webkit.org/changeset/68362 dropped the check for cases
      where the render box is floating or inline. When the box is left or right
      aligned it is considered to be floating and needs to its margins set appropriately.
      
      Test: fast/table/align-right-within-left-aligned-div.html
            created by Dominic Cooney <dominicc@chromium.org>
      
      * rendering/RenderBox.cpp:
      (WebCore::RenderBox::computeInlineDirectionMargins):
      
      LayoutTests:
      
      * fast/table/align-right-within-left-aligned-div-expected.png: Added.
      * fast/table/align-right-within-left-aligned-div-expected.txt: Added.
      * fast/table/align-right-within-left-aligned-div.html: Added.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@91277 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      cae18598
    • xan@webkit.org's avatar
      ARMv7 backend broken, lacks 3 parameter rshift32 method · ec3bb9d6
      xan@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=64571
      
      Reviewed by Zoltan Herczeg.
      
      * assembler/MacroAssemblerARMv7.h:
      (JSC::MacroAssemblerARMv7::rshift32): add missing rshift32 method.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@91275 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      ec3bb9d6
    • rniwa@webkit.org's avatar
      Buildbot marks a nrwt bot red when tests are missing results · 5b2f0832
      rniwa@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=64812
      
      Reviewed by Tony Chang.
      
      Added "missing results" label for tests that are missing results.
      
      buildbot Now reports shows a label "X missing results" on a run when X tests were missing
      expected results on that run.
      
      Also rephrased "X failed" and "X were flaky" to "X failures" and "X flakes".
      
      * BuildSlaveSupport/build.webkit.org-config/master.cfg:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@91273 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      5b2f0832
    • aroben@apple.com's avatar
      Extract some of FailingTestsBugForm's code into a base class · c5f501f2
      aroben@apple.com authored
      Prep work for fixing <http://webkit.org/b/63728> TestFailures page should make it easy to
      file bugs about flaky tests
      
      Reviewed by Sam Weinig.
      
      * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/FailingTestsBugForm.js:
      Moved BugzillaConstants to new WebKitBugzilla file. Moved a bunch of other code from here to
      TestRelatedBugForm.js.
      
      * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/FailingTestsBugForm_unittests.js:
      Moved some tests to TestRelatedBugForm_unittests.js.
      
      * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/TestRelatedBugForm.js: Added.
      (TestRelatedBugForm):
      (TestRelatedBugForm.prototype.domElement):
      (TestRelatedBugForm.prototype._computeOperatingSystem):
      (TestRelatedBugForm.prototype._computePlatform):
      Code came from FailingTestsBugForm.
      
      * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/TestRelatedBugForm_unittests.js:
      Added. Tests came from FailingTestsBugForm_unittests.js
      
      * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/WebKitBugzilla.js:
      Added. Code came from FailingTestsBugForm.js.
      
      * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/index.html: Pull in
      TestRelatedBugForm.js and WebKitBugzilla.js. Moved Bugzilla.js out of the list of files that
      need to be pulled in early for parsing reasons.
      
      * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/run-unittests.html:
      Pull in TestRelatedBugForm and tests and WebKitBugzilla.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@91272 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      c5f501f2
    • bweinstein@apple.com's avatar
      Add back a change that was accidentally removed in r91266. · 855f2577
      bweinstein@apple.com authored
              
      Make sure to retain the WKPasteboardFilePromiseOwner before calling draggedImage because draggedImage releases
      its responder. Also make the comment more explicit, to keep this mistake from being made in the future.
              
      Rubber-stamped by Darin Adler.
      
      * WebProcess/WebCoreSupport/mac/WebDragClientMac.mm:
      (WebKit::WebDragClient::dragEnded):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@91271 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      855f2577
    • inferno@chromium.org's avatar
      Source/WebCore: Crash when removing unrenderered nodes in replacement fragment. · 820d7147
      inferno@chromium.org authored
      https://bugs.webkit.org/show_bug.cgi?id=64801
      
      Reviewed by Ryosuke Niwa.
      
      Test: editing/pasteboard/replacement-fragment-remove-unrendered-node-crash.html
      
      * editing/ReplaceSelectionCommand.cpp:
      (WebCore::ReplacementFragment::removeUnrenderedNodes):
      
      LayoutTests: Tests that we do not crash when removing unrendering nodes
      in a replacement fragment.
      https://bugs.webkit.org/show_bug.cgi?id=64801
      
      Reviewed by Ryosuke Niwa.
      
      * editing/pasteboard/replacement-fragment-remove-unrendered-node-crash-expected.txt: Added.
      * editing/pasteboard/replacement-fragment-remove-unrendered-node-crash.html: Added.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@91270 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      820d7147
    • rwlbuis@webkit.org's avatar
      2011-07-19 Rob Buis <rbuis@rim.com> · 8a953a1d
      rwlbuis@webkit.org authored
              https://bugs.webkit.org/show_bug.cgi?id=64673
              REGRESSION (Safari 5.0.5 - ToT): crash in SVG test http://dev.w3.org/SVG/profiles/1.1F2/test/harness/htmlObjectApproved/styling-pres-02-f.html
      
              Reviewed by Nikolas Zimmermann.
      
              Prevent calling back to the owning SVGTRefElement upon handling DOMSubtreeModified events.
      
              Test: svg/W3C-SVG-1.1-SE/styling-pres-02-f.svg
      
              * svg/SVGTRefElement.cpp:
              (WebCore::SubtreeModificationEventListener::handleEvent):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@91269 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      8a953a1d
    • tony@chromium.org's avatar
      use more specific types in CSSFlexValue · de2d9370
      tony@chromium.org authored
      https://bugs.webkit.org/show_bug.cgi?id=64763
      
      Reviewed by Ojan Vafai.
      
      No new tests because no change in functionality.
      
      * css/CSSFlexValue.h:
      (WebCore::CSSFlexValue::create):
      (WebCore::CSSFlexValue::isFlexValue): Make it possible to tell if
          we're a flex value or not.  Will be needed when we're copying
          values to RenderStyle.
      (WebCore::CSSFlexValue::positiveFlex): Use floats for positive and
          negative flex because in the render code, we use floats.
      (WebCore::CSSFlexValue::negativeFlex): Add accessors for these since
          we'll need it when reading the flex values.
      (WebCore::CSSFlexValue::preferredSize):
      (WebCore::CSSFlexValue::CSSFlexValue):
      * css/CSSParser.cpp:
      (WebCore::CSSParser::parseValidPrimitive): Make the type more
          specific.
      (WebCore::CSSParser::parseFlex):
      * css/CSSParser.h:
      * css/CSSValue.h:
      (WebCore::CSSValue::isFlexValue):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@91268 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      de2d9370
    • cfleizach@apple.com's avatar
      If the control associated with a <label> is hidden, the label is also hidden (incorrectly) · ff63faae
      cfleizach@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=64752
      
      Reviewed by Darin Adler.
      
      Source/WebCore: 
      
      Test: platform/mac/accessibility/label-element-with-hidden-control.html
      
      * accessibility/AccessibilityRenderObject.cpp:
      (WebCore::AccessibilityRenderObject::exposesTitleUIElement):
      
      LayoutTests: 
      
      * platform/mac/accessibility/label-element-with-hidden-control-expected.txt: Added.
      * platform/mac/accessibility/label-element-with-hidden-control.html: Added.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@91267 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      ff63faae
    • bweinstein@apple.com's avatar
      Speculative fix for: Crash under WebPage::platformDragEnded when dragging on Mac · 9744812c
      bweinstein@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=64766
      <rdar://problem/9548174>
      
      Reviewed by Enrica Casucci.
      
      I was unable to reproduce this bug, but Darin Adler and I discussed the probable issue. When starting the drag, we create 
      a WKPasteboardFilePromiseOwner, and a WKPasteboardOwner. When the drag is concluded, we call a method on the WKPasteboardFilePromiseOwner
      which uses the WKPasteboardOwner. However, we are not guaranteeing that the WKPasteboardOwner will be around when the 
      WKPasteboardFilePromiseOwner method is called.
              
      The fix is to retain both the WKPasteboardFilePromiseOwner and the WKPasteboardOwner that we need, making sure that we are keeping
      both objects alive.
              
      This patch also uses r91222 to replace WebPage::platformDragEnded, so WebPage doesn't need to know about the drag source.
      
      * WebProcess/WebCoreSupport/WebDragClient.cpp:
      (WebKit::WebDragClient::dragEnded): Add a non-Mac stub method, since the Mac is the only platform that does something here.
      * WebProcess/WebCoreSupport/WebDragClient.h:
      * WebProcess/WebCoreSupport/mac/WebDragClientMac.mm:
      (WebKit::WebDragClient::declareAndWriteDragImage): Use member variables instead of local variables.
      (WebKit::WebDragClient::dragEnded): Move code from WebPageMac::platformDragEnded to here, and clear both member variables.
      * WebProcess/WebPage/WebPage.cpp:
      (WebKit::WebPage::dragEnded): Don't call platformDragEnded anymore. WebCore::DragController::dragEnded calls WebDragClient::dragEnded,
          which does the same thing.
      * WebProcess/WebPage/WebPage.h:
      * WebProcess/WebPage/mac/WebPageMac.mm: Remove platformDragEnded.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@91266 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      9744812c
    • rniwa@webkit.org's avatar
      Remove failing Chromium test expectations after r91224. · 61b7eed8
      rniwa@webkit.org authored
      * platform/chromium/test_expectations.txt:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@91265 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      61b7eed8
    • vsevik@chromium.org's avatar
      Web Inspector: Backend should provide network resource identifiers that are... · 7eda8250
      vsevik@chromium.org authored
      Web Inspector: Backend should provide network resource identifiers that are unique across navigation.
      https://bugs.webkit.org/show_bug.cgi?id=64746
      
      Reviewed by Pavel Feldman.
      
      Source/WebCore:
      
      * inspector/ConsoleMessage.cpp:
      (WebCore::ConsoleMessage::ConsoleMessage):
      (WebCore::ConsoleMessage::addToFrontend):
      * inspector/ConsoleMessage.h:
      * inspector/IdentifiersFactory.cpp:
      (WebCore::IdentifiersFactory::createIdentifier):
      (WebCore::IdentifiersFactory::resourceId):
      (WebCore::IdentifiersFactory::addProcessIdPrefixTo):
      * inspector/IdentifiersFactory.h:
      * inspector/Inspector.json:
      * inspector/InspectorConsoleAgent.cpp:
      (WebCore::InspectorConsoleAgent::didReceiveResponse):
      (WebCore::InspectorConsoleAgent::didFailLoading):
      * inspector/InspectorPageAgent.h:
      * inspector/InspectorResourceAgent.cpp:
      (WebCore::InspectorResourceAgent::willSendRequest):
      (WebCore::InspectorResourceAgent::markResourceAsCached):
      (WebCore::InspectorResourceAgent::didReceiveResponse):
      (WebCore::InspectorResourceAgent::didReceiveData):
      (WebCore::InspectorResourceAgent::didFinishLoading):
      (WebCore::InspectorResourceAgent::didFailLoading):
      (WebCore::InspectorResourceAgent::didLoadResourceFromMemoryCache):
      (WebCore::InspectorResourceAgent::setInitialScriptContent):
      (WebCore::InspectorResourceAgent::setInitialXHRContent):
      (WebCore::InspectorResourceAgent::didReceiveXHRResponse):
      (WebCore::InspectorResourceAgent::didCreateWebSocket):
      (WebCore::InspectorResourceAgent::willSendWebSocketHandshakeRequest):
      (WebCore::InspectorResourceAgent::didReceiveWebSocketHandshakeResponse):
      (WebCore::InspectorResourceAgent::didCloseWebSocket):
      (WebCore::InspectorResourceAgent::getResourceContent):
      * inspector/InspectorResourceAgent.h:
      * inspector/InspectorTimelineAgent.cpp:
      (WebCore::InspectorTimelineAgent::willSendResourceRequest):
      (WebCore::InspectorTimelineAgent::willReceiveResourceData):
      (WebCore::InspectorTimelineAgent::willReceiveResourceResponse):
      (WebCore::InspectorTimelineAgent::didFinishLoadingResource):
      * inspector/NetworkResourcesData.cpp:
      (WebCore::NetworkResourcesData::ResourceData::ResourceData):
      (WebCore::NetworkResourcesData::resourceCreated):
      (WebCore::NetworkResourcesData::responseReceived):
      (WebCore::NetworkResourcesData::setResourceType):
      (WebCore::NetworkResourcesData::resourceType):
      (WebCore::NetworkResourcesData::setResourceContent):
      (WebCore::NetworkResourcesData::maybeAddResourceData):
      (WebCore::NetworkResourcesData::maybeDecodeDataToContent):
      (WebCore::NetworkResourcesData::addCachedResource):
      (WebCore::NetworkResourcesData::addResourceSharedBuffer):
      (WebCore::NetworkResourcesData::data):
      (WebCore::NetworkResourcesData::clear):
      (WebCore::NetworkResourcesData::ensureNoDataForResourceId):
      (WebCore::NetworkResourcesData::ensureFreeSpace):
      * inspector/NetworkResourcesData.h:
      (WebCore::NetworkResourcesData::ResourceData::resourceId):
      * inspector/TimelineRecordFactory.cpp:
      (WebCore::TimelineRecordFactory::createResourceSendRequestData):
      (WebCore::TimelineRecordFactory::createResourceReceiveResponseData):
      (WebCore::TimelineRecordFactory::createResourceFinishData):
      (WebCore::TimelineRecordFactory::createReceiveResourceData):
      * inspector/TimelineRecordFactory.h:
      
      LayoutTests:
      
      * inspector/timeline/timeline-network-resource-expected.txt:
      * platform/chromium/inspector/timeline/timeline-network-resource-expected.txt:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@91264 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      7eda8250
    • jberlin@webkit.org's avatar
      Fix assertion failure seen in plugins/return-npobject.html on Windows XP Debug bots. · 18b7ccb5
      jberlin@webkit.org authored
      Rubber-stamped by Adam Roben.
      
      * loader/ResourceLoader.cpp:
      (WebCore::ResourceLoader::didReceiveData):
      It is possible for a subclass to cancel the load from within didReceiveData, which would
      set m_documentLoader to 0.
      Remove the assertion I added that the DocumentLoader's frame is non-null.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@91263 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      18b7ccb5
    • weinig@apple.com's avatar
      Remove obsolete Mac NRWT test bots · 3e6877b5
      weinig@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=64806
      
      Reviewed by Adam Roben.
      
      Remove "Leopard Intel Release (NRWT)" and "SnowLeopard Intel Release (NRWT)"
      which have been disconnected for some time and have been obsoleted by
      the main testers using NRWT.
      
      * BuildSlaveSupport/build.webkit.org-config/config.json:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@91262 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      3e6877b5
    • weinig@apple.com's avatar
      webkit-patch rebaseline crashes on use · 72d7ef51
      weinig@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=64775
      
      Reviewed by Adam Roben.
      
      Fix incorrectly spelled attribute name.
      
      * Scripts/webkitpy/common/net/layouttestresults.py:
      The attribute is test_name, not filename.
      
      * Scripts/webkitpy/common/net/layouttestresults_unittest.py:
      Add test for tests_matching_failure_types.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@91261 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      72d7ef51
    • steveblock@google.com's avatar
      REGRESSION (r82194): jvalueToJavaValue() does not correctly set length of String property · 96013927
      steveblock@google.com authored
      https://bugs.webkit.org/show_bug.cgi?id=64730
      
      Reviewed by Alexey Proskuryakov.
      
      Covered by existing tests.
      
      * bridge/jni/v8/JNIUtilityPrivate.cpp:
      (JSC::Bindings::jvalueToJavaValue):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@91260 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      96013927
    • rniwa@webkit.org's avatar
      [chromium] rebaseline Chromium results after r91249 . · 34866095
      rniwa@webkit.org authored
      Unreviewed.
      
      Patch by Jeremy Moskovich <jeremy@chromium.org> on 2011-07-19
      
      * platform/chromium-linux/fast/speech/speech-bidi-rendering-expected.png: Added.
      * platform/chromium-win/fast/speech/input-text-speechbutton-expected.txt: Added.
      * platform/chromium-win/fast/speech/speech-bidi-rendering-expected.png: Added.
      * platform/chromium-win/fast/speech/speech-bidi-rendering-expected.txt: Added.
      * platform/chromium/test_expectations.txt:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@91259 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      34866095
    • yurys@chromium.org's avatar
      [Chromium] Web Inspector: add sanity test for shared worker inspector · d64d46dd
      yurys@chromium.org authored
      https://bugs.webkit.org/show_bug.cgi?id=64799
      
      Reviewed by Pavel Feldman.
      
      * src/js/Tests.js:
      (.TestSuite.prototype.testSharedWorker):
      (.TestSuite.prototype.evaluateInConsole_):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@91258 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      d64d46dd
    • weinig@apple.com's avatar
      Check in Leopard specific results for Selectors 3 tests. · b1cd1c56
      weinig@apple.com authored
      * platform/mac-leopard/css3/selectors3: Added.
      * platform/mac-leopard/css3/selectors3/html: Added.
      * platform/mac-leopard/css3/selectors3/html/css3-modsel-24-expected.txt: Copied from platform/mac/css3/selectors3/html/css3-modsel-24-expected.txt.
      * platform/mac-leopard/css3/selectors3/html/css3-modsel-68-expected.txt: Copied from platform/mac/css3/selectors3/html/css3-modsel-68-expected.txt.
      * platform/mac-leopard/css3/selectors3/xhtml: Added.
      * platform/mac-leopard/css3/selectors3/xhtml/css3-modsel-174a-expected.txt: Copied from platform/mac/css3/selectors3/xhtml/css3-modsel-174a-expected.txt.
      * platform/mac-leopard/css3/selectors3/xhtml/css3-modsel-174b-expected.txt: Copied from platform/mac/css3/selectors3/xhtml/css3-modsel-174b-expected.txt.
      * platform/mac-leopard/css3/selectors3/xhtml/css3-modsel-24-expected.txt: Copied from platform/mac/css3/selectors3/xhtml/css3-modsel-24-expected.txt.
      * platform/mac-leopard/css3/selectors3/xhtml/css3-modsel-68-expected.txt: Copied from platform/mac/css3/selectors3/xhtml/css3-modsel-68-expected.txt.
      * platform/mac-leopard/css3/selectors3/xml: Added.
      * platform/mac-leopard/css3/selectors3/xml/css3-modsel-174a-expected.txt: Copied from platform/mac/css3/selectors3/xml/css3-modsel-174a-expected.txt.
      * platform/mac-leopard/css3/selectors3/xml/css3-modsel-174b-expected.txt: Copied from platform/mac/css3/selectors3/xml/css3-modsel-174b-expected.txt.
      * platform/mac-leopard/css3/selectors3/xml/css3-modsel-24-expected.txt: Copied from platform/mac/css3/selectors3/xml/css3-modsel-24-expected.txt.
      * platform/mac-leopard/css3/selectors3/xml/css3-modsel-68-expected.txt: Copied from platform/mac/css3/selectors3/xml/css3-modsel-68-expected.txt.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@91257 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      b1cd1c56
    • vitalyr@chromium.org's avatar
      2011-07-19 Vitaly Repeshko <vitalyr@chromium.org> · 3391456e
      vitalyr@chromium.org authored
              [V8] Don't put CSSRuleLists in object groups.
              https://bugs.webkit.org/show_bug.cgi?id=64798
      
              Reviewed by Pavel Feldman.
      
              Retention of CSSRuleLists should be implemented using hidden
              references from holder objects. By putting lists in groups we
              artificially extend their lifetimes much more than necessary.
      
              * bindings/v8/V8GCController.cpp:
              (WebCore::GrouperVisitor::visitDOMWrapper):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@91256 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      3391456e
    • gyuyoung.kim@samsung.com's avatar
      [EFL] Add ewk_network.cpp|h files. · 235d0a8a
      gyuyoung.kim@samsung.com authored
      https://bugs.webkit.org/show_bug.cgi?id=63315
      
      Source/WebCore:
      
      Enable setOnLine(bool) on EFL port as well as Android and Chromium.
      
      Reviewed by Antonio Gomes.
      
      * platform/network/NetworkStateNotifier.cpp:
      * platform/network/NetworkStateNotifier.h:
      
      Source/WebKit/efl:
      
      ewk_network.cpp|h files are added to ewk in order to support APIs related to networking.
      In addition, ewk_network_state_notifier_online_set() is added to ewk_network.cpp in order
      to notify NetworkStateNotifier of network status.
      
      Reviewed by Antonio Gomes.
      
      * CMakeListsEfl.txt:
      * ewk/EWebKit.h:
      * ewk/ewk_network.cpp: Added.
      (ewk_network_proxy_uri_set):
      (ewk_network_proxy_uri_get):
      (ewk_network_state_notifier_online_set):
      * ewk/ewk_network.h:
      * ewk/ewk_settings.cpp:
      * ewk/ewk_settings.h:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@91255 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      235d0a8a
    • kov@webkit.org's avatar
      [GTK] Google Calendar thinks we're mobile · adab7955
      kov@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=63994
      
      Patch by Gustavo Noronha Silva  <gns@gnome.org> on 2011-07-11
      Reviewed by Xan Lopez.
      
      Further special-case Google Calendar, for it thinks WebKit+Linux
      means mobile, so we also have to spoof the OS.
      
      * WebCoreSupport/FrameLoaderClientGtk.cpp:
      (WebKit::FrameLoaderClient::userAgent): use the new WebKitGTK+
      private API that centralizes the logic now.
      * tests/testwebsettings.c: Add tests to make sure the Google
      special-cases only apply for the expected domains and when quirks
      special-casing is enabled.
      (test_non_quirky_user_agents):
      (test_webkit_web_settings_user_agent):
      * webkit/webkitwebsettings.cpp:
      (webkitUserAgent): make it static.
      (safariUserAgent): returns a fake Safari in Mac OS X User-Agent.
      (initializeDomainsList): moved from FrameLoaderClientGtk.
      (isGoogleDomain):ditto.
      (isGoogleCalendar): ditto.
      (userAgentForURL): ditto.
      (webkitWebSettingsUserAgentForUri): centralize the whole
      user agent spoofing logic in this new private API that can be used
      by the browser to know what's going to happen for a specific URI
      and also allows our API testing.
      * webkit/webkitwebsettingsprivate.h:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@91253 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      adab7955
    • loislo@chromium.org's avatar
      Web Inspector: implement import/export for timeline data. · 273992bc
      loislo@chromium.org authored
      https://bugs.webkit.org/show_bug.cgi?id=64601
      
      Reviewed by Yury Semikhatsky.
      
      Source/WebCore:
      
      Test: inspector/timeline/timeline-load.html
      
      * English.lproj/localizedStrings.js:
      * inspector/InspectorFrontendHost.cpp:
      (WebCore::FrontendMenuProvider::contextMenuItemSelected):
      * inspector/front-end/TimelinePanel.js:
      (WebInspector.TimelinePanel):
      (WebInspector.TimelinePanel.prototype._createFileSelector):
      (WebInspector.TimelinePanel.prototype._contextMenu):
      (WebInspector.TimelinePanel.prototype._exportToFile):
      (WebInspector.TimelinePanel.prototype._importFromFile):
      (WebInspector.TimelinePanel.prototype._addRecordToTimeline):
      (WebInspector.TimelinePanel.prototype._clearPanel):
      (WebInspector.TimelineModel):
      (WebInspector.TimelineModel.prototype._addRecord):
      (WebInspector.TimelineModel.prototype._importNextChunk):
      (WebInspector.TimelineModel.prototype._importFromFile):
      (WebInspector.TimelineModel.prototype._importFromFile.onError):
      (WebInspector.TimelineModel.prototype._exportToFile):
      (WebInspector.TimelineModel.prototype._reset):
      * inspector/front-end/utilities.js:
      ():
      
      LayoutTests:
      
      * inspector/timeline/timeline-load-expected.txt: Added.
      * inspector/timeline/timeline-load.html: Added.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@91252 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      273992bc
    • loki@webkit.org's avatar
      Add missing expected file after r91191 · 981a7b7f
      loki@webkit.org authored
      * platform/qt/svg/W3C-SVG-1.1-SE/painting-control-04-f-expected.txt: Added.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@91251 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      981a7b7f
    • vsevik@chromium.org's avatar
      Web Inspector: Rename agentIdentifierPrefix to processId, move out from page agent and make static. · 3788fea0
      vsevik@chromium.org authored
      https://bugs.webkit.org/show_bug.cgi?id=64729
      
      Reviewed by Pavel Feldman.
      
      Source/WebCore:
      
      * CMakeLists.txt:
      * GNUmakefile.list.am:
      * WebCore.gypi:
      * WebCore.pro:
      * WebCore.vcproj/WebCore.vcproj:
      * WebCore.xcodeproj/project.pbxproj:
      * inspector/IdentifiersFactory.cpp: Added.
      (WebCore::IdentifiersFactory::createIdentifier):
      * inspector/IdentifiersFactory.h: Added.
      (WebCore::IdentifiersFactory::setProcessId):
      * inspector/InspectorController.cpp:
      (WebCore::InspectorController::setProcessId):
      * inspector/InspectorController.h:
      * inspector/InspectorPageAgent.cpp:
      (WebCore::InspectorPageAgent::frameId):
      (WebCore::InspectorPageAgent::loaderId):
      * inspector/InspectorPageAgent.h:
      
      Source/WebKit/chromium:
      
      * public/WebDevToolsAgent.h:
      * src/WebDevToolsAgentImpl.cpp:
      (WebKit::WebDevToolsAgentImpl::setAgentIdentifierPrefix):
      (WebKit::WebDevToolsAgentImpl::setProcessId):
      * src/WebDevToolsAgentImpl.h:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@91250 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      3788fea0
    • jeremy@chromium.org's avatar
      Fix microphone icon placement in speech input control for dir=rtl. · 37eec66b
      jeremy@chromium.org authored
      https://bugs.webkit.org/show_bug.cgi?id=64668
      
      Reviewed by Dimitri Glazkov.
      
      Source/WebCore:
      
      Modify default stylesheet to propagate dir=rtl from the outer input
      control to the shadow DOM container.  This makes the microphone
      icon appear on the left for dir=rtl, which is the desired behavior.
      
      Test: fast/speech/speech-bidi-rendering.html
      
      * css/html.css:
      (input[x-webkit-speech][dir=rtl]::-webkit-textfield-decoration-container):
      
      LayoutTests:
      
      Added test that verifies placement of microphone icon for dir=rtl.
      
      * fast/speech/speech-bidi-rendering.html: Added.
      * platform/mac/fast/speech/speech-bidi-rendering-expected.png: Added.
      * platform/mac/fast/speech/speech-bidi-rendering-expected.txt: Added.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@91249 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      37eec66b
    • alexis.menard@openbossa.org's avatar
      [Qt][WK2] Make QDesktopWebView::navigationAction method usable in QML. · cc2dc4e1
      alexis.menard@openbossa.org authored
      https://bugs.webkit.org/show_bug.cgi?id=64690
      
      Make the API usable with QML by declaring what's needed
      with the macros.
      
      Reviewed by Benjamin Poulain.
      
      * UIProcess/API/qt/qdesktopwebview.h:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@91248 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      cc2dc4e1
    • commit-queue@webkit.org's avatar
      [EFL] Account for the invalid pointer case in WebCore::screenRect() · 2d18fb44
      commit-queue@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=64543
      
      Patch by Raphael Kubo da Costa <kubo@profusion.mobi> on 2011-07-19
      Reviewed by Antonio Gomes.
      
      Fix a regression introduced in r88245: it assumes the pointer passed
      to screenRect() is always valid.
      fast/frames/crash-removed-iframe.html proves this is not always true,
      so we need to do some sanity check on the pointer before using it.
      No new tests as this has been caught by the current test suite.
      
      * platform/efl/PlatformScreenEfl.cpp:
      (WebCore::screenRect):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@91247 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      2d18fb44
    • yutak@chromium.org's avatar
      Unreviewed. Edit Chromium test expectation for... · d18ff195
      yutak@chromium.org authored
      Unreviewed. Edit Chromium test expectation for http/tests/websocket/tests/hybi/reserved-opcodes.html.
      
      * platform/chromium/test_expectations.txt:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@91246 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      d18ff195
    • eric@webkit.org's avatar
      new-run-webkit-tests should support --leaks · 8bf898e1
      eric@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=63832
      
      Reviewed by Dirk Pranke.
      
      This may not be sufficient to actually transition over the leaks bot,
      but this is a huge step in the right direction.
      
      I had to make parse-malloc-history understand being passed more than
      one file (to avoid the silly cat | nonsense in old-run-webkit-tests).
      
      I removed some dead code relating to previous iterations of our crash detection.
      
      I created a new class "LeakDetector" to encapsulate all this logic.
      Eventually we should consider pulling that class out of mac.py and
      sharing with other ports.  However given that ORWT has had
      --leaks support on Mac for almost 7 years and no other port has added
      it, leaves me to believe we're in no rush to move LeakDetector.
      
      I've tested --leaks locally.  I suspect there are more bugs to shake out
      but it seems to work well enough to start.
      
      I also added support for --guard-malloc, but have not tested it much.  It
      should be viewed as experimental at this time.
      
      I also fixed various os.path uses to self._filesystem as I was reading
      through the various files to understand how best to fix this bug.
      
      * Scripts/old-run-webkit-tests:
      (parseLeaksandPrintUniqueLeaks):
      * Scripts/parse-malloc-history:
      (main):
      * Scripts/webkitpy/common/system/crashlogs.py:
      * Scripts/webkitpy/layout_tests/controllers/manager.py:
      * Scripts/webkitpy/layout_tests/controllers/worker.py:
      * Scripts/webkitpy/layout_tests/port/base.py:
      * Scripts/webkitpy/layout_tests/port/chromium_win.py:
      * Scripts/webkitpy/layout_tests/port/gtk.py:
      * Scripts/webkitpy/layout_tests/port/mac.py:
      * Scripts/webkitpy/layout_tests/port/mac_unittest.py:
      * Scripts/webkitpy/layout_tests/port/server_process.py:
      * Scripts/webkitpy/layout_tests/port/webkit.py:
      * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@91245 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      8bf898e1
    • commit-queue@webkit.org's avatar
      Patch by Robin Qiu <robin.qiu@torchmobile.com.cn> on 2011-07-19 · b4abfc88
      commit-queue@webkit.org authored
      Reviewed by Antonio Gomes.
      
      ScrollBar should initialize current position in constructor.
      https://bugs.webkit.org/show_bug.cgi?id=39284
      
      When ScrollBar is created, m_currentPos should be initialized to
      m_scrollableArea's current scrollPosition. Because scrollbars may
      be created after the content of m_scrollableArea has been scrolled.
      
      Source/WebCore:
      
      Test: scrollbars/scrollbar-initial-position.html
      
      * platform/Scrollbar.cpp:
      (WebCore::Scrollbar::Scrollbar):
      
      LayoutTests:
      
      * scrollbars/scrollbar-initial-position-expected.png: Added.
      * scrollbars/scrollbar-initial-position-expected.txt: Added.
      * scrollbars/scrollbar-initial-position.html: Added.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@91244 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      b4abfc88
    • yutak@chromium.org's avatar
      WebSocket: Implement hybi framing · 6a2ece20
      yutak@chromium.org authored
      https://bugs.webkit.org/show_bug.cgi?id=64522
      
      Reviewed by Kent Tamura.
      
      Source/WebCore:
      
      Implement WebSocket framing protocol which is mainly described in
      <http://tools.ietf.org/html/draft-ietf-hybi-thewebsocketprotocol-10#section-4> and
      <http://tools.ietf.org/html/draft-ietf-hybi-thewebsocketprotocol-10#section-6>.
      
      Hybi protocol introduces a new frame format which is drastically different from
      the old one. Notable differences are:
      - Binary data support.
      - Fragmentation support: a single message can be fragmented to multiple frames.
      - Ping-pong support.
      - Masking: frame content of a client must be masked to prevent cross-protocol attacks.
      
      This patch covers the following features:
      - Send a pong frame when a ping frame is received.
      - Receive fragmented frames.
      - Receive masked frames. (Servers do not have to mask frames, but they may if they wish.)
      
      The following features are NOT implemented yet:
      - Send or receive binary messages.
      - Send a ping message.
      - Send fragmented frames. (It is unclear whether this is necessary.)
      - Rewrite the frame content by WebSocket protocol extensions (like frame compression).
      
      New tests: http/tests/websocket/tests/hybi/broken-utf8.html
                 http/tests/websocket/tests/hybi/fragmented-control-frame.html
                 http/tests/websocket/tests/hybi/fragmented-frames.html
                 http/tests/websocket/tests/hybi/interleaved-fragments.html
                 http/tests/websocket/tests/hybi/long-control-frame.html
                 http/tests/websocket/tests/hybi/masked-frames.html
                 http/tests/websocket/tests/hybi/pong.html
                 http/tests/websocket/tests/hybi/reserved-bits.html
                 http/tests/websocket/tests/hybi/reserved-opcodes.html
                 http/tests/websocket/tests/hybi/too-long-payload.html
      
      * websockets/WebSocketChannel.cpp:
      (WebCore::WebSocketChannel::WebSocketChannel):
      (WebCore::WebSocketChannel::send):
      The original content of send() was moved to a private method sendFrameHixie76().
      (WebCore::WebSocketChannel::fail):
      Stop handling incoming data after the WebSocket connection is failed.
      It was unclear to me whether we should do the same thing for hixie-76 connection;
      for now, I kept the original behavior.
      (WebCore::WebSocketChannel::processBuffer):
      (WebCore::WebSocketChannel::resumeTimerFired):
      (WebCore::WebSocketChannel::startClosingHandshake):
      (WebCore::WebSocketChannel::closingTimerFired):
      (WebCore::WebSocketChannel::parseFrame):
      (WebCore::WebSocketChannel::processFrame):
      (WebCore::WebSocketChannel::processFrameHixie76):
      (WebCore::WebSocketChannel::sendFrame):
      (WebCore::WebSocketChannel::sendFrameHixie76):
      * websockets/WebSocketChannel.h:
      (WebCore::WebSocketChannel::isNonControlOpCode):
      (WebCore::WebSocketChannel::isControlOpCode):
      (WebCore::WebSocketChannel::isReservedOpCode):
      
      LayoutTests:
      
      Fix existing tests so they match the new frame format, and add tests for the new frame types
      and error conditions related to the new frame format.
      
      Unskip hybi tests on mac, win and chromium. Other ports (wk2, qt and gtk) still skip these tests
      because they do not support changing the value of "WebKitHixie76WebSocketProtocolEnabled"
      preference key via layoutTestController.overridePreferences() yet.
      
      * http/tests/websocket/tests/hybi/broken-utf8-expected.txt: Added.
      * http/tests/websocket/tests/hybi/broken-utf8.html: Added.
      * http/tests/websocket/tests/hybi/broken-utf8_wsh.py: Added.
      * http/tests/websocket/tests/hybi/client-close-expected.txt:
      * http/tests/websocket/tests/hybi/client-close.html:
      The format of a close frame has been changed. Currently, we do not include any payload
      in a close frame, thus it must start with "\x88\x80" (see section 4.1 of hybi-10
      specification for more details).
      * http/tests/websocket/tests/hybi/client-close_wsh.py:
      * http/tests/websocket/tests/hybi/fragmented-control-frame-expected.txt: Added.
      * http/tests/websocket/tests/hybi/fragmented-control-frame.html: Added.
      * http/tests/websocket/tests/hybi/fragmented-control-frame_wsh.py: Added.
      * http/tests/websocket/tests/hybi/fragmented-frames-expected.txt: Added.
      * http/tests/websocket/tests/hybi/fragmented-frames.html: Added.
      * http/tests/websocket/tests/hybi/fragmented-frames_wsh.py: Added.
      * http/tests/websocket/tests/hybi/interleaved-fragments-expected.txt: Added.
      * http/tests/websocket/tests/hybi/interleaved-fragments.html: Added.
      * http/tests/websocket/tests/hybi/interleaved-fragments_wsh.py: Added.
      * http/tests/websocket/tests/hybi/long-control-frame-expected.txt: Added.
      * http/tests/websocket/tests/hybi/long-control-frame.html: Added.
      * http/tests/websocket/tests/hybi/long-control-frame_wsh.py: Added.
      * http/tests/websocket/tests/hybi/masked-frames-expected.txt: Added.
      * http/tests/websocket/tests/hybi/masked-frames.html: Added.
      * http/tests/websocket/tests/hybi/masked-frames_wsh.py: Added.
      * http/tests/websocket/tests/hybi/pong-expected.txt: Added.
      * http/tests/websocket/tests/hybi/pong.html: Added.
      * http/tests/websocket/tests/hybi/pong_wsh.py: Added.
      * http/tests/websocket/tests/hybi/reserved-bits-expected.txt: Added.
      * http/tests/websocket/tests/hybi/reserved-bits.html: Added.
      * http/tests/websocket/tests/hybi/reserved-bits_wsh.py: Added.
      * http/tests/websocket/tests/hybi/reserved-opcodes-expected.txt: Added.
      * http/tests/websocket/tests/hybi/reserved-opcodes.html: Added.
      * http/tests/websocket/tests/hybi/reserved-opcodes_wsh.py: Added.
      * http/tests/websocket/tests/hybi/send2_wsh.py:
      Send two text frames at once.
      * http/tests/websocket/tests/hybi/too-long-payload-expected.txt: Added.
      * http/tests/websocket/tests/hybi/too-long-payload.html: Added.
      * http/tests/websocket/tests/hybi/too-long-payload_wsh.py: Added.
      * platform/chromium/test_expectations.txt:
      Derive test expectations of hixie76 tests, because these tests are likely to behave
      the same way as hixie76 tests. Will be checked later whether they really do.
      * platform/mac/Skipped:
      * platform/win/Skipped:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@91243 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      6a2ece20
    • zimmermann@webkit.org's avatar
      2011-07-19 Nikolas Zimmermann <nzimmermann@rim.com> · 877dc99f
      zimmermann@webkit.org authored
              REGRESSION (r88913): Preview in Safari's snippet editor has a fixed height instead of filling the entire pane
              https://bugs.webkit.org/show_bug.cgi?id=64059
      
              REGRESSION (r88913): <object> has wrong computed height
              https://bugs.webkit.org/show_bug.cgi?id=62769
      
              Reviewed by Rob Buis.
      
              Add new layout test in fast/css covering both bugs.
              Update svg/zoom/page results (this is a progression, but the test itself remains broken, see comment inline).
      
              * fast/css/replaced-element-implicit-size.html: Added.
              * platform/mac/fast/css/replaced-element-implicit-size-expected.png: Added.
              * platform/mac/fast/css/replaced-element-implicit-size-expected.txt: Added.
              * platform/mac/svg/zoom/page/zoom-svg-through-object-with-text-expected.png:
              * platform/mac/svg/zoom/page/zoom-svg-through-object-with-text-expected.txt:
      
      2011-07-19  Nikolas Zimmermann  <nzimmermann@rim.com>
      
              REGRESSION (r88913): Preview in Safari's snippet editor has a fixed height instead of filling the entire pane
              https://bugs.webkit.org/show_bug.cgi?id=64059
      
              REGRESSION (r88913): <object> has wrong computed height
              https://bugs.webkit.org/show_bug.cgi?id=62769
      
              Reviewed by Rob Buis.
      
              Fix misinterpretation of CSS 2.1 - "10.5 Content height: the 'height' property".
              It says "If the height of the containing block is not specified explicitelz (i.e. it depends on the
              content height), and this element is not absolutely positioned, the value computes to 'auto'".
      
              Checking whether the containing block height depends on the content height is not equal to checking
              whether the height property is set on the containing block, there are other ways to implicitly specify
              the height by setting top & bottom. Fix that by checking whether the containing block has a height
              property or top & bottom set.
      
              While I was at it, make computeReplacedLogicalWidth/Height a bit more explicit to make it easier to compare
              the code with the spec quoatations - this doesn't change the functionality only the readability.
              
              Test: fast/css/replaced-element-implicit-size.html
      
              * rendering/RenderReplaced.cpp:
              (WebCore::RenderReplaced::computeReplacedLogicalWidth): Cleanup comment, make code more explicit.
              (WebCore::RenderReplaced::logicalHeightIsAuto): Add helper method used by computeReplacedLogicalHeight.
              (WebCore::RenderReplaced::computeReplacedLogicalHeight): Fix height=auto detection.
              * rendering/RenderReplaced.h:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@91242 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      877dc99f
    • abarth@webkit.org's avatar
      garden-o-matic should have a "Triage Failures" button for iterating over failures · e3b1ada7
      abarth@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=64769
      
      Reviewed by Eric Seidel.
      
      This patch adds some global static state and refactors things a bit so
      that we can iterate over all the failures in the details pane.
      
      * Scripts/webkitpy/tool/servers/data/gardeningserver/base.js:
          - Add a generic callback iterator to iterate through a series of
            callbacks. We use this to iterate through the failures we want to
            display the details of.
      * Scripts/webkitpy/tool/servers/data/gardeningserver/index.html:
          - Add a toolbar for the results summary and change the buttons to
            be real buttons.
      * Scripts/webkitpy/tool/servers/data/gardeningserver/main.css:
          - Make the detail pane 75% of the window.
          - Make the buttons pretty.
          - Allow the failure type badges to apply to the details pane as well.
      * Scripts/webkitpy/tool/servers/data/gardeningserver/main.js:
          - Restructure how we bring up the details pane so we can iterate
            through a bunch of failures.
          - Remove the transition between results details because it's
            annoying when you want to click through a bunch of failures.
      * Scripts/webkitpy/tool/servers/data/gardeningserver/ui.js:
          - Add some more structure to the title bar for the results details
            so it's clearer which results we're currently displaying.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@91241 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      e3b1ada7
    • abarth@webkit.org's avatar
      garden-o-matic should live update as conditions change on the buildbot · 65ecad21
      abarth@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=64646
      
      Reviewed by Eric Seidel.
      
      This patch causes the garden-o-matic display to update every 10 minutes
      to show the latest failures.  This patch required a moderately large
      refactoring of main.js to make the display incremental instead of
      all-at-once.
      
      * Scripts/webkitpy/tool/servers/data/gardeningserver/base.js:
      * Scripts/webkitpy/tool/servers/data/gardeningserver/main.css:
      * Scripts/webkitpy/tool/servers/data/gardeningserver/main.js:
      * Scripts/webkitpy/tool/servers/data/gardeningserver/ui.js:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@91240 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      65ecad21
  2. 18 Jul, 2011 4 commits