1. 31 Aug, 2012 40 commits
    • fpizlo@apple.com's avatar
      JSArray::putDirectIndex should by default behave like JSObject::putDirect · 3fbbc4f8
      fpizlo@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=95630
      
      Reviewed by Gavin Barraclough.
      
      Source/JavaScriptCore: 
      
      * interpreter/Interpreter.cpp:
      (JSC::Interpreter::privateExecute):
      * jit/JITStubs.cpp:
      (JSC::DEFINE_STUB_FUNCTION):
      * jsc.cpp:
      (GlobalObject::finishCreation):
      * llint/LLIntSlowPaths.cpp:
      (JSC::LLInt::LLINT_SLOW_PATH_DECL):
      * runtime/JSArray.cpp:
      (JSC::SparseArrayValueMap::putDirect):
      (JSC::JSArray::defineOwnNumericProperty):
      (JSC::JSArray::putDirectIndexBeyondVectorLength):
      * runtime/JSArray.h:
      (SparseArrayValueMap):
      (JSArray):
      (JSC::JSArray::putDirectIndex):
      * runtime/JSONObject.cpp:
      (JSC::Walker::walk):
      * runtime/RegExpMatchesArray.cpp:
      (JSC::RegExpMatchesArray::reifyAllProperties):
      (JSC::RegExpMatchesArray::reifyMatchProperty):
      * runtime/StringPrototype.cpp:
      (JSC::splitStringByOneCharacterImpl):
      (JSC::stringProtoFuncSplit):
      
      Source/WebCore: 
      
      No new tests because no change in behavior.
      
      * bindings/js/SerializedScriptValue.cpp:
      (WebCore::CloneDeserializer::putProperty):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@127349 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      3fbbc4f8
    • ggaren@apple.com's avatar
      Rolled back in a piece of <http://trac.webkit.org/changeset/127293>. · a62184de
      ggaren@apple.com authored
          Shrink activation objects by half
          https://bugs.webkit.org/show_bug.cgi?id=95591
      
          Reviewed by Sam Weinig.
      
      * runtime/JSGlobalData.cpp:
      (JSC::JSGlobalData::JSGlobalData):
      * runtime/JSGlobalData.h:
      (JSGlobalData):
      * runtime/JSNameScope.h:
      (JSC::JSNameScope::JSNameScope):
      * runtime/JSWithScope.h:
      (JSC::JSWithScope::JSWithScope):
      * runtime/StrictEvalActivation.cpp:
      (JSC::StrictEvalActivation::StrictEvalActivation):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@127348 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      a62184de
    • japhet@chromium.org's avatar
      Source/WebCore: fast/loader/document-destruction-within-unload.html causes... · a9a58bb2
      japhet@chromium.org authored
      Source/WebCore: fast/loader/document-destruction-within-unload.html causes assertion failures on mac and qt.
      https://bugs.webkit.org/show_bug.cgi?id=66783
      
      Reviewed by Darin Adler.
      
      This was a not-quite-regression from trac.webkit.org/changeset/93521, in that we hit asserts
      in a case where we previously were use-after-freeing. Tweak how we handle cases where a Document
      is cleared from within an unload handler.
      
      No new tests, fixing fast/loader/document-destruction-within-unload.html on mac and qt.
      
      * loader/FrameLoader.cpp:
      (WebCore::FrameLoader::setDocumentLoader): Instead of trying to reattach a partially removed
          DocumentLoader if it is detached before being fully added, leave the old one in place, completed.
      (WebCore::FrameLoader::transitionToCommitted):
      
      LayoutTests: Unskip fast/loader/document-destruction-within-unload.html
      on mac and qt.
      https://bugs.webkit.org/show_bug.cgi?id=66783
      
      Reviewed by Darin Adler.
      
      * platform/mac/Skipped:
      * platform/qt/Skipped:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@127347 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      a9a58bb2
    • tony@chromium.org's avatar
      Make computeBlockDirectionMargins const · bd2f1e73
      tony@chromium.org authored
      https://bugs.webkit.org/show_bug.cgi?id=95595
      
      Reviewed by Ojan Vafai.
      
      This is a step in making computeLogicalHeight const.
      Refactor RenderBox::computeBlockDirectionMargins and make it const.
      Add a helper method computeAndSetBlockDirectionMargins for the callers outside of
      computeLogicalHeight that are calling this.
      
      No new tests, this is already covered by tests in fast/writing-mode and fast/multicol.
      
      * rendering/RenderBlock.cpp:
      (WebCore::RenderBlock::marginBeforeEstimateForChild): Switch to computeAndSetBlockDirectionMargins
      (WebCore::RenderBlock::layoutBlockChild): Switch to computeAndSetBlockDirectionMargins
      (WebCore::RenderBlock::insertFloatingObject): Switch to computeAndSetBlockDirectionMargins
      * rendering/RenderBox.cpp:
      (WebCore::RenderBox::computeLogicalHeight): Use const version and fill in a MarginValues struct (to be merged in the next patch).
      (WebCore::RenderBox::computeBlockDirectionMargins): Pass in out params.
      (WebCore):
      (WebCore::RenderBox::computeAndSetBlockDirectionMargins): Does the same as the old computeBlockDirectionMargins.
      * rendering/RenderBox.h:
      (RenderBox):
      * rendering/RenderDeprecatedFlexibleBox.cpp:
      (WebCore::RenderDeprecatedFlexibleBox::layoutHorizontalBox): Switch to computeAndSetBlockDirectionMargins
      (WebCore::RenderDeprecatedFlexibleBox::layoutVerticalBox): Switch to computeAndSetBlockDirectionMargins
      * rendering/RenderTableRow.cpp:
      (WebCore::RenderTableRow::layout): Switch to computeAndSetBlockDirectionMargins
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@127346 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      bd2f1e73
    • ggaren@apple.com's avatar
      Rolled back in a piece of <http://trac.webkit.org/changeset/127293>. · 70aed69e
      ggaren@apple.com authored
          Shrink activation objects by half
          https://bugs.webkit.org/show_bug.cgi?id=95591
      
          Reviewed by Sam Weinig.
      
      * dfg/DFGAbstractState.cpp:
      (JSC::DFG::AbstractState::execute):
      * jit/JITOpcodes.cpp:
      (JSC::JIT::emit_op_resolve_global_dynamic):
      * llint/LowLevelInterpreter32_64.asm:
      * llint/LowLevelInterpreter64.asm:
      * runtime/JSActivation.cpp:
      (JSC::JSActivation::JSActivation):
      * runtime/JSGlobalData.cpp:
      (JSC::JSGlobalData::JSGlobalData):
      * runtime/JSGlobalData.h:
      (JSGlobalData):
      * runtime/JSGlobalObject.cpp:
      (JSC::JSGlobalObject::reset):
      (JSC::JSGlobalObject::visitChildren):
      * runtime/JSGlobalObject.h:
      (JSGlobalObject):
      (JSC::JSGlobalObject::withScopeStructure):
      (JSC::JSGlobalObject::strictEvalActivationStructure):
      (JSC::JSGlobalObject::activationStructure):
      (JSC::JSGlobalObject::nameScopeStructure):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@127345 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      70aed69e
    • roger_fong@apple.com's avatar
      · f273a98a
      roger_fong@apple.com authored
      Unreviewed. CSS_VARIABLES are not enabled on Windows. Adding Windows specific results.
      
      * platform/win/fast/css/variables: Added.
      * platform/win/fast/css/variables/build-supports-variables-expected.txt: Added.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@127344 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      f273a98a
    • mhahnenberg@apple.com's avatar
      Remove use of ClassInfo in SpeculativeJIT::emitBranch · c1925150
      mhahnenberg@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=95623
      
      Reviewed by Filip Pizlo.
      
      * dfg/DFGAbstractState.cpp:
      (JSC::DFG::AbstractState::execute):
      * dfg/DFGSpeculativeJIT.h:
      (SpeculativeJIT):
      * dfg/DFGSpeculativeJIT32_64.cpp:
      (JSC::DFG::SpeculativeJIT::emitNonStringCellOrOtherBranch):
      (JSC::DFG::SpeculativeJIT::emitBranch):
      * dfg/DFGSpeculativeJIT64.cpp:
      (JSC::DFG::SpeculativeJIT::emitNonStringCellOrOtherBranch):
      (JSC::DFG::SpeculativeJIT::emitBranch):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@127343 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      c1925150
    • wjmaclean@chromium.org's avatar
      [chromium] Make link highlighter use same node selection criteria as Chromium for Android. · 41bcf4eb
      wjmaclean@chromium.org authored
      https://bugs.webkit.org/show_bug.cgi?id=95371
      
      Reviewed by James Robinson.
      
      This CL brings the selection criteria for link highlight targets into alignment with Chromium for Android.
      
      Source/WebKit/chromium:
      
      * src/WebViewImpl.cpp:
      (WebKit::highlightConditions):
      (WebKit::WebViewImpl::bestTouchLinkNode):
      * tests/data/test_touch_link_highlight.html:
      
      LayoutTests:
      
      * platform/chromium-linux/compositing/gestures/gesture-tapHighlight-simple-ZIndex.html: Copied from LayoutTests/platform/chromium-linux/compositing/gestures/gesture-tapHighlight-simple-background.html.
      * platform/chromium-linux/compositing/gestures/gesture-tapHighlight-simple-background.html:
      * platform/chromium-linux/compositing/gestures/gesture-tapHighlight-simple-body.html: Copied from LayoutTests/platform/chromium-linux/compositing/gestures/gesture-tapHighlight-simple-background.html.
      * platform/chromium-linux/platform/chromium-linux/compositing/gestures/gesture-tapHighlight-simple-ZIndex-expected.png: Added.
      * platform/chromium-linux/platform/chromium-linux/compositing/gestures/gesture-tapHighlight-simple-ZIndex-expected.txt: Added.
      * platform/chromium-linux/platform/chromium-linux/compositing/gestures/gesture-tapHighlight-simple-body-expected.png: Added.
      * platform/chromium-linux/platform/chromium-linux/compositing/gestures/gesture-tapHighlight-simple-body-expected.txt: Added.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@127342 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      41bcf4eb
    • roger_fong@apple.com's avatar
      Unreviewed. Adding expected failing results for some fast/css(3) tests. · 4af0913b
      roger_fong@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=95627.
      
      * platform/win/fast/css/image-resolution: Added.
      * platform/win/fast/css/image-resolution/image-resolution-expected.txt: Added.
      * platform/win/fast/css/image-set-setting-expected.txt: Added.
      * platform/win/fast/css/parse-border-image-repeat-null-crash-expected.txt: Added.
      * platform/win/fast/css3-text-decoration: Added.
      * platform/win/fast/css3-text-decoration/getComputedStyle: Added.
      * platform/win/fast/css3-text-decoration/getComputedStyle/getComputedStyle-text-decoration-line-expected.txt: Added.
      * platform/win/fast/css3-text-decoration/getComputedStyle/getComputedStyle-text-decoration-style-expected.txt: Added.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@127341 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      4af0913b
    • jamesr@google.com's avatar
      [chromium] Consolidate geometry unit testing functions for cc · e2478b7a
      jamesr@google.com authored
      https://bugs.webkit.org/show_bug.cgi?id=95526
      
      Reviewed by Julien Chaffraix.
      
      This consolidates geometry equality (rects, matrices) in CCGeometryUtils and removes a few duplicate macros for
      testing rect equality.
      
      * WebKit.gypi:
      * tests/CCDamageTrackerTest.cpp:
      (WebKitTests::TEST_F):
      * tests/CCGeometryTestUtils.cpp: Added.
      (WebKitTests):
      (WebKitTests::ExpectTransformationMatrixEq):
      * tests/CCGeometryTestUtils.h: Renamed from Source/WebKit/chromium/tests/CCLayerTreeTestCommon.h.
      (WebKit):
      (WebKitTests):
      * tests/CCLayerTreeHostTest.cpp:
      * tests/CCMathUtilTest.cpp:
      (WebKit::TEST):
      * tests/TiledLayerChromiumTest.cpp:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@127340 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      e2478b7a
    • ojan@chromium.org's avatar
      Mark some indexeddb tests as SLOW. They consistently time out for me · 3ae46fef
      ojan@chromium.org authored
      when I run with --fully-parallel.
      * platform/chromium/TestExpectations:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@127339 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      3ae46fef
    • ggaren@apple.com's avatar
      Rolled back in a piece of <http://trac.webkit.org/changeset/127293>. · d84288e5
      ggaren@apple.com authored
          Shrink activation objects by half
          https://bugs.webkit.org/show_bug.cgi?id=95591
      
          Reviewed by Sam Weinig.
      
      * heap/MarkedBlock.cpp:
      (JSC::MarkedBlock::MarkedBlock):
      * heap/MarkedBlock.h:
      (MarkedBlock):
      (JSC::MarkedBlock::globalData):
      (JSC):
      * heap/WeakSet.cpp:
      (JSC::WeakSet::addAllocator):
      * heap/WeakSet.h:
      (WeakSet):
      (JSC::WeakSet::WeakSet):
      (JSC::WeakSet::globalData):
      * runtime/JSGlobalData.h:
      (JSC::WeakSet::heap):
      (JSC):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@127338 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      d84288e5
    • ap@apple.com's avatar
      [WK2] Use initial process in multi-process mode, too · 4e55ecd2
      ap@apple.com authored
              https://bugs.webkit.org/show_bug.cgi?id=95612
      
              Reviewed by Sam Weinig.
      
              * UIProcess/WebContext.cpp:
              (WebKit::WebContext::WebContext):
              (WebKit::WebContext::warmInitialProcess):
              (WebKit::WebContext::disconnectProcess):
              (WebKit::WebContext::createWebPage):
              * UIProcess/WebContext.h:
              Added a boolean telling whether the last (normally, the only) process in m_processes
              is available for use in a new page.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@127337 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      4e55ecd2
    • jamesr@google.com's avatar
      [chromium] Clean up Web*Layer initialization paths · d0ba8888
      jamesr@google.com authored
      https://bugs.webkit.org/show_bug.cgi?id=95523
      
      Reviewed by Darin Fisher.
      
      Constructing a Web*LayerImpl (or other compositor type) wrapper shouldn't require knowledge of the underyling
      implementation. Also normalizes naming conventions in these files.
      
      * src/WebAnimationImpl.cpp:
      (WebKit::WebAnimation::create):
      (WebKit::WebAnimationImpl::WebAnimationImpl):
      * src/WebAnimationImpl.h:
      (WebAnimationImpl):
      * src/WebContentLayerImpl.cpp:
      (WebKit::WebContentLayerImpl::WebContentLayerImpl):
      (WebKit::WebContentLayerImpl::~WebContentLayerImpl):
      (WebKit::WebContentLayerImpl::layer):
      (WebKit::WebContentLayerImpl::setDoubleSided):
      (WebKit::WebContentLayerImpl::setContentsScale):
      (WebKit::WebContentLayerImpl::setUseLCDText):
      (WebKit::WebContentLayerImpl::setDrawCheckerboardForMissingTiles):
      * src/WebContentLayerImpl.h:
      (WebContentLayerImpl):
      * src/WebFloatAnimationCurveImpl.cpp:
      (WebKit::WebFloatAnimationCurve::create):
      (WebKit::WebFloatAnimationCurveImpl::WebFloatAnimationCurveImpl):
      * src/WebFloatAnimationCurveImpl.h:
      (WebFloatAnimationCurveImpl):
      * src/WebIOSurfaceLayerImpl.cpp:
      (WebKit::WebIOSurfaceLayer::create):
      (WebKit::WebIOSurfaceLayerImpl::WebIOSurfaceLayerImpl):
      * src/WebIOSurfaceLayerImpl.h:
      (WebIOSurfaceLayerImpl):
      * src/WebImageLayerImpl.cpp:
      (WebKit::WebImageLayer::create):
      (WebKit::WebImageLayerImpl::WebImageLayerImpl):
      * src/WebImageLayerImpl.h:
      (WebImageLayerImpl):
      * src/WebLayerImpl.cpp:
      (WebKit::WebLayer::create):
      (WebKit):
      (WebKit::WebLayerImpl::WebLayerImpl):
      * src/WebLayerImpl.h:
      (WebLayerImpl):
      * src/WebScrollbarLayerImpl.cpp:
      (WebKit::WebScrollbarLayer::create):
      (WebKit::WebScrollbarLayerImpl::WebScrollbarLayerImpl):
      * src/WebScrollbarLayerImpl.h:
      (WebScrollbarLayerImpl):
      * src/WebSolidColorLayerImpl.cpp:
      (WebKit::WebSolidColorLayer::create):
      (WebKit::WebSolidColorLayerImpl::WebSolidColorLayerImpl):
      * src/WebSolidColorLayerImpl.h:
      (WebSolidColorLayerImpl):
      * src/WebTransformAnimationCurveImpl.cpp:
      (WebKit::WebTransformAnimationCurve::create):
      (WebKit::WebTransformAnimationCurveImpl::WebTransformAnimationCurveImpl):
      * src/WebTransformAnimationCurveImpl.h:
      (WebTransformAnimationCurveImpl):
      * src/WebVideoLayerImpl.cpp:
      (WebKit::WebVideoLayer::create):
      (WebKit::WebVideoLayerImpl::WebVideoLayerImpl):
      * src/WebVideoLayerImpl.h:
      (WebVideoLayerImpl):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@127336 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      d0ba8888
    • commit-queue@webkit.org's avatar
      Unreviewed, rolling out r127309. · 39f2aaca
      commit-queue@webkit.org authored
      http://trac.webkit.org/changeset/127309
      https://bugs.webkit.org/show_bug.cgi?id=95624
      
      The Windows tests weren't actually fixed. (Requested by
      mhahnenberg on #webkit).
      
      Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-08-31
      
      * platform/win/Skipped:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@127335 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      39f2aaca
    • ap@apple.com's avatar
      [WK2] WebProcesses should not wait 60 seconds to close in multi-process mode · f9727c8c
      ap@apple.com authored
              https://bugs.webkit.org/show_bug.cgi?id=95616
      
              Reviewed by Darin Adler.
      
              * Shared/ChildProcess.cpp: (WebKit::ChildProcess::ChildProcess):
              * Shared/ChildProcess.h: (WebKit::ChildProcess::setTerminationTimeout):
              Expose a setter for timeout instead of taking it at construction time. If a derived
              class doesn't call the setter, default to 0.
      
              * PluginProcess/PluginProcess.cpp:
              (WebKit::PluginProcess::PluginProcess):
              (WebKit::PluginProcess::initializePluginProcess):
              Use timeout from initialization message.
      
              * WebProcess/WebProcess.cpp:
              (WebKit::WebProcess::WebProcess):
              (WebKit::WebProcess::initializeWebProcess):
              Ditto.
      
              * Shared/Plugins/PluginProcessCreationParameters.cpp:
              (WebKit::PluginProcessCreationParameters::encode):
              (WebKit::PluginProcessCreationParameters::decode):
              * Shared/Plugins/PluginProcessCreationParameters.h:
              * Shared/WebProcessCreationParameters.cpp:
              (WebKit::WebProcessCreationParameters::encode):
              (WebKit::WebProcessCreationParameters::decode):
              * Shared/WebProcessCreationParameters.h:
              Funnel timeout across process boundary.
      
              * UIProcess/Plugins/PluginProcessProxy.cpp: (WebKit::PluginProcessProxy::didFinishLaunching):
              Pass timeout as initialization message after launch.
      
              * UIProcess/WebContext.cpp:
              (WebKit::WebContext::createNewWebProcess): Pass timeout as initialization message
              (unlike plugin process proxy, web process proxy doesn't wait, and relies on the message
              being queued).
              (WebKit::WebContext::disconnectProcess): Skip invalidating global managers when
              one process quits. We still need to do something, but running this code would just
              result in assertion failures any time a page was closed.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@127334 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      f9727c8c
    • commit-queue@webkit.org's avatar
      Refactor LLInt and supporting code in preparation for the C Loop backend. · eebad5de
      commit-queue@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=95531.
      
      Patch by Mark Lam <mark.lam@apple.com> on 2012-08-31
      Reviewed by Filip Pizlo.
      
      * bytecode/GetByIdStatus.cpp:
      (JSC::GetByIdStatus::computeFromLLInt):
      * bytecode/PutByIdStatus.cpp:
      (JSC::PutByIdStatus::computeFromLLInt):
      * jit/JITExceptions.cpp:
      (JSC::genericThrow): Use ExecutableBase::catchRoutineFor() to fetch
          fetch the catch routine for a thrown exception.  This will allow
          us to redefine that for the C loop later, and still keep this
          code readable.
      * llint/LLIntOfflineAsmConfig.h: Moved ASM macros to
          LowLevelInterpreter.cpp which is the only place they are used. This
          will make it more convenient to redefine them for the C loop later.
      * llint/LLIntSlowPaths.cpp:
      (JSC::LLInt::setUpCall): Use ExecutableBase's hostCodeEntry()
          jsCodeEntryFor(), and jsCodeWithArityCheckEntryFor() for computing
          the entry points to functions being called.
      * llint/LLIntSlowPaths.h:
      (...
      eebad5de
    • jberlin@webkit.org's avatar
      [Lion] css3/filters/composited-during-animation-layertree.html produces empty results · f007554b
      jberlin@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=95622
      
      Move the empty results to mac-lion and add the ML results to mac to get the bots greener.
      
      * platform/mac-lion/css3/filters/composited-during-animation-layertree-expected.txt: Copied from LayoutTests/platform/mac/css3/filters/composited-during-animation-layertree-expected.txt.
      * platform/mac/css3/filters/composited-during-animation-layertree-expected.txt:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@127332 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      f007554b
    • roger_fong@apple.com's avatar
      Unreviewed. Getting rid of Windows specific results because CSS3 flexbox has... · d7187fa2
      roger_fong@apple.com authored
      Unreviewed. Getting rid of Windows specific results because CSS3 flexbox has been re-enabled here: https://bugs.webkit.org/show_bug.cgi?id=95382
      
      * platform/win/fast/css/getComputedStyle/computed-style-expected.txt: Removed.
      * platform/win/fast/css/getComputedStyle/computed-style-without-renderer-expected.txt: Removed.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@127331 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      d7187fa2
    • jberlin@webkit.org's avatar
      [Mountain Lion]... · b563f036
      jberlin@webkit.org authored
      [Mountain Lion] platform/mac/editing/spelling/removing-underline-after-accepting-autocorrection-using-punctuation.html failing.
      https://bugs.webkit.org/show_bug.cgi?id=95477
      
      Add Mountain Lion expected (failing?) results and move the ones previously in mac to mac-lion to get the bots greener.
      
      * platform/mac-lion/editing/spelling/removing-underline-after-accepting-autocorrection-using-punctuation-expected.png: Renamed from LayoutTests/platform/mac/editing/spelling/removing-underline-after-accepting-autocorrection-using-punctuation-expected.png.
      * platform/mac-lion/editing/spelling/removing-underline-after-accepting-autocorrection-using-punctuation-expected.txt: Copied from LayoutTests/platform/mac/editing/spelling/removing-underline-after-accepting-autocorrection-using-punctuation-expected.txt.
      * platform/mac/editing/spelling/removing-underline-after-accepting-autocorrection-using-punctuation-expected.txt:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@127330 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      b563f036
    • pdr@google.com's avatar
      Unreviewed update of fast/js/function-constructor-this-value.html expectations on Chromium · 790cffd0
      pdr@google.com authored
      https://bugs.webkit.org/show_bug.cgi?id=95617
      
      This test was added in r127323 but fails on Chromium ports.
      
      * platform/chromium/TestExpectations:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@127329 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      790cffd0
    • commit-queue@webkit.org's avatar
      [GTK] Assert on ChromeClientGtk::scroll with delta (0, -1). · 817296fa
      commit-queue@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=95590
      
      Change the assert to avoid hitting when the delta does not have any
      value > 0.
      
      Patch by José Dapena Paz <jdapena@igalia.com> on 2012-08-31
      Reviewed by Martin Robinson.
      
      * WebCoreSupport/ChromeClientGtk.cpp:
      (WebKit::ChromeClient::scroll):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@127328 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      817296fa
    • krit@webkit.org's avatar
      Introduce new CSS property for clip-path · 60c867ae
      krit@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=95474
      
      Reviewed by Tim Horton.
      
      Source/WebCore:
      
      This path introduces the new, prefixed CSS property 'clip-path' from the
      CSS Masking specification. In a first step the property just accepts
      'none' and the the basic shapes from CSS Exclusion. Later it will also be
      possible to reference SVG 'clipPath' elements - like Firefox already does.
      To enable the parsing of the shapes, the exclusion compiler flags
      around the shape parser were removed.
      
      http://dvcs.w3.org/hg/FXTF/raw-file/tip/masking/index.html
      
      Test: fast/masking/parsing-clip-path-shape.html
      
      * css/CSSComputedStyleDeclaration.cpp:
      (WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue): Return CSSValue for CSSPropertyWebkitClipPath.
      * css/CSSParser.cpp:
      (WebCore::CSSParser::parseValue): Add CSSPropertyWebkitClipPath.
      (WebCore::CSSParser::parseBasicShape): Modify parser function to accept CSSPropertyWebkitClipPath as well.
      * css/CSSParser.h:
      * css/CSSProperty.cpp:
      (WebCore::CSSProperty::isInheritedProperty):
      * css/CSSPropertyNames.in: Added property name -webkit-clip-path.
      * css/StyleBuilder.cpp:
      (ApplyPropertyClipPath): New property applier just for -webkit-clip-path.
      (WebCore::ApplyPropertyClipPath::setValue):
      (WebCore::ApplyPropertyClipPath::applyValue):
      (WebCore::ApplyPropertyClipPath::createHandler):
      (WebCore::StyleBuilder::StyleBuilder):
      * rendering/style/RenderStyle.cpp: Repaint if there is a difference between two BasicShapes.
      (WebCore::RenderStyle::diff):
      * rendering/style/RenderStyle.h:
      * rendering/style/StyleRareNonInheritedData.cpp:
      (WebCore::StyleRareNonInheritedData::StyleRareNonInheritedData):
      (WebCore::StyleRareNonInheritedData::operator==):
      (WebCore::StyleRareNonInheritedData::reportMemoryUsage):
      * rendering/style/StyleRareNonInheritedData.h: Add new member variable for clip shape.
      (StyleRareNonInheritedData):
      
      LayoutTests:
      
      Test parsing behavior of basic shapes on new introduced '-webkit-clip-path' CSS property.
      
      * fast/masking/parsing-clip-path-shape-expected.txt: Added.
      * fast/masking/parsing-clip-path-shape.html: Added.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@127327 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      60c867ae
    • zhajiang@rim.com's avatar
      [BlackBerry] ASSERT failure in RenderBlock::checkPositionedObjectsNeedLayout · 139b0cda
      zhajiang@rim.com authored
      https://bugs.webkit.org/show_bug.cgi?id=95611
      
      Reviewed by Antonio Gomes.
      Patch by Jacky Jiang <zhajiang@rim.com>
      
      PR:200127
      Remove r118405 now as we already have a new fix webkit/43f8394b for
      that issue and it is not reproducible anymore after the removal.
      In this way, we can get rid of this ASSERT failure as well.
      Thanks Antonio for the suggestion.
      
      * Api/WebPage.cpp:
      (BlackBerry::WebKit::WebPagePrivate::setViewportSize):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@127326 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      139b0cda
    • rwlbuis@webkit.org's avatar
      [BlackBerry] Eliminate WebGL IT policy · 605d295d
      rwlbuis@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=95604
      Internal RIM PR #198764
      
      Patch by Joshua Netterfield <jnetterfield@rim.com> on 2012-08-31
      Reviewed by Rob Buis.
      
      This is no longer a requirement for the BlackBerry port.
      
      Source/WebCore:
      
      No new tests, because this introduces no new functionality.
      
      * html/canvas/WebGLRenderingContext.cpp:
      (WebCore):
      (WebCore::WebGLRenderingContext::create):
      
      Source/WebKit/blackberry:
      
      * Api/WebPage.cpp:
      (BlackBerry::WebKit::WebPagePrivate::init):
      (BlackBerry::WebKit::WebPage::setWebGLEnabled):
      * WebKitSupport/AboutData.cpp:
      (BlackBerry::WebKit::configPage):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@127325 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      605d295d
    • ggaren@apple.com's avatar
      Not reviewed. · 833e2ff7
      ggaren@apple.com authored
      Removed some tabs that snuck into my last patch.
      
      * fast/js/function-constructor-this-value.html:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@127324 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      833e2ff7
    • ggaren@apple.com's avatar
      Use one object instead of two for closures, eliminating ScopeChainNode · 9170131b
      ggaren@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=95501
      
      Reviewed by Sam Weinig.
      
      Adding a test to demonstrate the behavior change in this patch.
      
      * fast/js/function-constructor-this-value-expected.txt: Added.
      * fast/js/function-constructor-this-value.html: Added.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@127323 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      9170131b
    • jonlee@apple.com's avatar
      ondisplay event handlers are not called · 37fe4dd4
      jonlee@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=95263
      <rdar://problem/12193359>
      
      Reviewed by Alexey Proskuryakov.
      
      Source/WebCore:
      
      To support the legacy API, we conflate ondisplay and onshow.
      
      * Modules/notifications/Notification.h:
      (WebCore::Notification::ondisplay): Use display event as an alias for the show event.
      (WebCore::Notification::setOndisplay):
      
      LayoutTests:
      
      Adjust the test to use the ondisplay handler, to fully test legacy API.
      
      * http/tests/notifications/legacy/show-expected.txt: Verify that event listener for ondisplay is
      the same as that for onshow.
      * http/tests/notifications/legacy/show.html:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@127321 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      37fe4dd4
    • roger_fong@apple.com's avatar
      Unreviewed. Adding passing test results for fast/canvas/canvas-strokeRect-alpha-shadow. · 03969ca5
      roger_fong@apple.com authored
      Test passes on Windows port now but Mac port currently uses expected failing results.
      
      * platform/win/fast/canvas/canvas-strokeRect-alpha-shadow-expected.txt: Added.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@127320 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      03969ca5
    • beidson@apple.com's avatar
      REGRESSION (r127252): incomplete repaint on Flash element after pinch to zoom · 7f30c054
      beidson@apple.com authored
             <rdar://problem/12217897> and https://bugs.webkit.org/show_bug.cgi?id=95607
      
             Reviewed by Simon Fraser.
      
             * WebProcess/Plugins/PluginView.cpp:
             (WebKit::PluginView::viewGeometryDidChange): Only give the window coordinate clip rect a chance
       to override the boundsRect() if the page scale factor is 1.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@127319 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      7f30c054
    • tony@chromium.org's avatar
      Remove ENABLE_CSS3_FLEXBOX compile time flag · b866aaa0
      tony@chromium.org authored
      https://bugs.webkit.org/show_bug.cgi?id=95382
      
      Reviewed by Ojan Vafai.
      
      Everyone is already enabling this by default and the spec has stablized.
      
      .:
      
      * Source/cmake/WebKitFeatures.cmake:
      * Source/cmakeconfig.h.cmake:
      * configure.ac:
      
      Source/JavaScriptCore:
      
      * Configurations/FeatureDefines.xcconfig:
      
      Source/WebCore:
      
      No new tests, shouldn't change anything.
      
      * Configurations/FeatureDefines.xcconfig:
      * GNUmakefile.am:
      * GNUmakefile.features.am:
      * css/CSSComputedStyleDeclaration.cpp:
      (WebCore):
      (WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):
      * css/CSSParser.cpp:
      (WebCore::isValidKeywordPropertyAndValue): Expand check range to include flex and inline-flex.
      (WebCore::isKeywordPropertyID):
      (WebCore::CSSParser::parseValue):
      * css/CSSPrimitiveValueMappings.h:
      (WebCore::CSSPrimitiveValue::CSSPrimitiveValue):
      * css/CSSProperty.cpp:
      (WebCore::CSSProperty::isInheritedProperty):
      * css/CSSPropertyNames.in:
      * css/CSSValueKeywords.in:
      * css/StyleBuilder.cpp:
      (WebCore::StyleBuilder::StyleBuilder):
      * css/StylePropertySet.cpp:
      (WebCore::StylePropertySet::getPropertyValue):
      (WebCore::StylePropertySet::asText):
      * css/StylePropertyShorthand.cpp:
      (WebCore::webkitFlexShorthand):
      (WebCore::shorthandForProperty):
      * css/StylePropertyShorthand.h:
      (WebCore):
      * css/StyleResolver.cpp:
      (WebCore::StyleResolver::collectMatchingRulesForList):
      * page/animation/CSSPropertyAnimation.cpp:
      (WebCore::CSSPropertyAnimation::ensurePropertyMap):
      * rendering/RenderObject.cpp:
      (WebCore::RenderObject::createObject):
      * rendering/style/RenderStyle.h:
      * rendering/style/RenderStyleConstants.h:
      
      Source/WebKit/chromium:
      
      * features.gypi:
      
      Source/WebKit/mac:
      
      * Configurations/FeatureDefines.xcconfig:
      
      Source/WebKit2:
      
      * Configurations/FeatureDefines.xcconfig:
      
      Tools:
      
      * Scripts/webkitperl/FeatureList.pm:
      * qmake/mkspecs/features/features.pri:
      
      WebKitLibraries:
      
      * win/tools/vsprops/FeatureDefines.vsprops:
      * win/tools/vsprops/FeatureDefinesCairo.vsprops:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@127318 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      b866aaa0
    • commit-queue@webkit.org's avatar
      [chromium] Add main versus impl thread asserts · c2e94945
      commit-queue@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=95596
      
      Patch by Christopher Cameron <ccameron@chromium.org> on 2012-08-31
      Reviewed by James Robinson.
      
      Add asserts to prioritized texture manager that specify that a
      function be called on the main or impl thread.
      
      Add debug signs that the main thread is blocked to the threaded
      proxy.
      
      Add a mechanism to simultaneously set the thread to the impl thread
      and indicate that the main thread is blocked.
      
      Update tests that hit asserts in the prioritized texture manager to
      set their impl thread and main thread blocked state correctly.
      
      Source/WebCore:
      
      * platform/graphics/chromium/cc/CCPrioritizedTextureManager.cpp:
      (WebCore::CCPrioritizedTextureManager::prioritizeTextures):
      (WebCore::CCPrioritizedTextureManager::clearPriorities):
      (WebCore::CCPrioritizedTextureManager::requestLate):
      (WebCore::CCPrioritizedTextureManager::acquireBackingTextureIfNeeded):
      (WebCore::CCPrioritizedTextureManager::reduceMemory):
      (WebCore::CCPrioritizedTextureManager::registerTexture):
      (WebCore::CCPrioritizedTextureManager::unregisterTexture):
      (WebCore::CCPrioritizedTextureManager::returnBackingTexture):
      (WebCore::CCPrioritizedTextureManager::createBacking):
      (WebCore::CCPrioritizedTextureManager::assertInvariants):
      * platform/graphics/chromium/cc/CCSingleThreadProxy.h:
      (WebCore):
      (DebugScopedSetImplThreadAndMainThreadBlocked):
      * platform/graphics/chromium/cc/CCThreadProxy.cpp:
      (WebCore::CCThreadProxy::compositeAndReadback):
      (WebCore::CCThreadProxy::finishAllRendering):
      (WebCore::CCThreadProxy::setVisible):
      (WebCore::CCThreadProxy::initializeRenderer):
      (WebCore::CCThreadProxy::recreateContext):
      (WebCore::CCThreadProxy::implSideRenderingStats):
      (WebCore::CCThreadProxy::start):
      (WebCore::CCThreadProxy::forceSerializeOnSwapBuffers):
      (WebCore::CCThreadProxy::acquireLayerTextures):
      
      Source/WebKit/chromium:
      
      * tests/CCPrioritizedTextureTest.cpp:
      (WTF::CCPrioritizedTextureTest::CCPrioritizedTextureTest):
      (WTF::CCPrioritizedTextureTest::~CCPrioritizedTextureTest):
      (WTF::CCPrioritizedTextureTest::validateTexture):
      (WTF::TEST_F):
      * tests/TiledLayerChromiumTest.cpp:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@127317 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      c2e94945
    • pdr@google.com's avatar
      Unreviewed update of fast/js/function-apply-aliased.html expectations. · 8421c193
      pdr@google.com authored
      fast/js/function-apply-aliased.html has been failing for TEXT for some time but
      the chromium-mac TestExpectations did not have an entry for mac. This patch
      updates the expectations to include all platforms.
      
      The bug (crbug.com/48239) has been updated to reflect this.
      
      * platform/chromium/TestExpectations:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@127316 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      8421c193
    • jberlin@webkit.org's avatar
      LayoutTests/http/tests/websocket/tests/hixie76/frame-lengths.html was removed.... · 2e330323
      jberlin@webkit.org authored
      LayoutTests/http/tests/websocket/tests/hixie76/frame-lengths.html was removed. Remove it from the Skipped list.
      
      * platform/mac-wk2/Skipped:
      * platform/qt-arm/Skipped:
      * platform/wincairo/Skipped:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@127315 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      2e330323
    • jberlin@webkit.org's avatar
      compositing/tiling/huge-layer* flakey · cd6e953e
      jberlin@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=48454
      
      These tests were disabled in r89631. Remove them from the Skipped list so that
      run-webkit-tests doesn't try to find them.
      
      * platform/win/Skipped:
      * platform/wincairo/Skipped:
      * platform/wk2/Skipped:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@127314 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      cd6e953e
    • psolanki@apple.com's avatar
      objc_msgSend and IMP should be cast appropriately before using · fcba1b6a
      psolanki@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=95242
      
      Reviewed by Benjamin Poulain.
      
      Follow on fix for Mac EWS - use objc-runtime.h instead of runtime.h so
      that it finds the declaration for objc_msgSend.
      
      * UIProcess/API/mac/PDFViewController.mm:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@127313 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      fcba1b6a
    • jberlin@webkit.org's avatar
      The fast/forms/ file tests were moved in the file sub-directory in r96918. Remove the · 8cbd5ad2
      jberlin@webkit.org authored
      old entries from the Skipped list.
      
      * platform/mac-wk2/Skipped:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@127312 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      8cbd5ad2
    • jamesr@google.com's avatar
      [chromium] Put compositor client interfaces in separate headers, normalize naming · 790fc840
      jamesr@google.com authored
      https://bugs.webkit.org/show_bug.cgi?id=95522
      
      Reviewed by Adam Barth.
      
      Source/WebCore:
      
      Client interfaces should be in their own headers so code implementing these interfaces do not have to
      transitively #include all of the compositor internals.
      
      We call things 'clients' not 'delegates' in the compositor.
      
      * WebCore.gypi:
      * platform/graphics/chromium/ContentLayerChromium.cpp:
      (WebCore::ContentLayerPainter::ContentLayerPainter):
      (WebCore::ContentLayerPainter::create):
      (WebCore::ContentLayerPainter::paint):
      (WebCore::ContentLayerChromium::create):
      (WebCore::ContentLayerChromium::ContentLayerChromium):
      (WebCore::ContentLayerChromium::drawsContent):
      (WebCore::ContentLayerChromium::createTextureUpdaterIfNeeded):
      * platform/graphics/chromium/ContentLayerChromium.h:
      (WebCore):
      (ContentLayerPainter):
      (ContentLayerChromium):
      (WebCore::ContentLayerChromium::clearClient):
      * platform/graphics/chromium/TextureLayerChromium.cpp:
      * platform/graphics/chromium/TextureLayerChromium.h:
      (WebCore):
      * platform/graphics/chromium/cc/CCLayerTreeHost.cpp:
      * platform/graphics/chromium/cc/CCLayerTreeHost.h:
      (WebCore):
      
      Source/WebKit/chromium:
      
      * src/WebContentLayerImpl.cpp:
      (WebKit::WebContentLayerImpl::~WebContentLayerImpl):
      * src/WebContentLayerImpl.h:
      (WebContentLayerImpl):
      * src/WebExternalTextureLayerImpl.h:
      * src/WebLayerTreeViewImpl.h:
      (WebCore):
      * tests/CCLayerTreeHostCommonTest.cpp:
      * tests/CCLayerTreeHostTest.cpp:
      (WebKitTests::ContentLayerChromiumWithUpdateTracking::create):
      (WebKitTests::ContentLayerChromiumWithUpdateTracking::ContentLayerChromiumWithUpdateTracking):
      (WebKitTests::CCLayerTreeHostTestDeviceScaleFactorScalesViewportAndLayers::CCLayerTreeHostTestDeviceScaleFactorScalesViewportAndLayers):
      (WebKitTests::CCLayerTreeHostTestAtomicCommit::CCLayerTreeHostTestAtomicCommit):
      (WebKitTests::CCLayerTreeHostTestAtomicCommitWithPartialUpdate::CCLayerTreeHostTestAtomicCommitWithPartialUpdate):
      (WebKitTests::CCLayerTreeHostTestLostContextWhileUpdatingResources::CCLayerTreeHostTestLostContextWhileUpdatingResources):
      (CCLayerTreeHostTestLostContextWhileUpdatingResources):
      * tests/ContentLayerChromiumTest.cpp:
      (WebKit::MockContentLayerChromiumClient::MockContentLayerChromiumClient):
      (WebKit::TEST):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@127311 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      790fc840
    • roger_fong@apple.com's avatar
    • mhahnenberg@apple.com's avatar
      Unskip plugins/npruntime/delete-plugin-within-* tests on Windows · 20117b85
      mhahnenberg@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=95597
      
      Reviewed by Darin Adler.
      
      * platform/win/Skipped:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@127309 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      20117b85