1. 04 Jul, 2007 12 commits
  2. 03 Jul, 2007 27 commits
    • darin's avatar
      * StringsNotToBeLocalized.txt: Updated for recent changes. · e391ed58
      darin authored
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@23978 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      e391ed58
    • thatcher's avatar
      Reviewed by Darin. · d2e2fbbd
      thatcher authored
              Remove HIWebView in 64-bit.
      
              Also disable a few calls that are now gone in 64-bit and filed these bugs:
      
              <rdar://problem/5311653> WebKit needs to adopt HIGetMousePosition where we used GetGlobalMouse before
              <rdar://problem/5311648> WebKit needs to move off of CopyEvent in WebBaseNetscapePluginView
              <rdar://problem/5311640> WebKit needs a new solution for HISearchWindowShow on 64-bit
      
              * Carbon/CarbonUtils.m:
              * Carbon/CarbonWindowAdapter.m:
              * Carbon/CarbonWindowContentView.m:
              * Carbon/CarbonWindowFrame.m:
              * Carbon/HIViewAdapter.m:
              (SetViewNeedsDisplay):
              * Carbon/HIWebView.m:
              (Draw):
              (SyncFrame):
              * Configurations/WebKit.xcconfig:
              * Plugins/WebBaseNetscapePluginView.mm:
              (+[WebBaseNetscapePluginView getCarbonEvent:]):
              (TSMEventHandler):
              * WebKit.LP64.exp: Added.
              * WebView/WebView.mm:
              (-[WebView _searchWithSpotlightFromMenu:]):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@23977 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      d2e2fbbd
    • thatcher's avatar
      f2d28d49
    • thatcher's avatar
      64-bit build fix. · d6837946
      thatcher authored
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@23975 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      d6837946
    • aroben's avatar
      Fixed update-webkit-localizable-strings to work with new extract-localizable-strings · c69c7cc8
      aroben authored
      Got rid of extract-webkit-localizable-strings because it was trying to
      do update-webkit-localizable-strings' job.
      
      Rubberstamped by Darin.
      
      * Scripts/extract-webkit-localizable-strings: Removed.
      * Scripts/update-webkit-localizable-strings: Renamed from
      extract-localizable-strings.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@23974 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      c69c7cc8
    • aroben's avatar
      Merge the Windows and Mac localized strings and exceptions files · f3514c34
      aroben authored
      WebKit:
      
              Merge the Windows and Mac localized strings and exceptions files
      
              Reviewed by Darin and Anders.
      
              * English.lproj/Localizable.strings: Added Windows strings.
              * StringsNotToBeLocalized.txt: Renamed from WebKit/English.lproj/StringsNotToBeLocalized.txt.
      
      WebKit/win:
      
              Merge the Windows and Mac localized strings and exceptions files
      
              Reviewed by Darin and Anders.
      
              * English.lproj/Localizable.strings: Added Mac strings.
              * English.lproj/StringsNotToBeLocalized.txt: Removed.
      
      WebKitTools:
      
              Modify scripts to keep Mac/Windows localized strings in sync
      
              extract-webkit-localizable-strings now handles extracting strings from
              both the Mac and Windows WebKit ports and updating their respective
              Localizable.strings files. extract-localizable-strings is now really a
              piece of plumbing rather than a top-level tool.
      
              Reviewed by Darin and Anders.
      
              * Scripts/extract-localizable-strings: Changed to handle multiple
              directories.
              * Scripts/extract-webkit-localizable-strings: Added.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@23972 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      f3514c34
    • adele's avatar
      Removed printf I accidently left in. · 9d421bf4
      adele authored
              * Misc/WebNSURLExtras.m: (mapHostNames):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@23971 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      9d421bf4
    • darin's avatar
      LayoutTests: · ba73e6e5
      darin authored
              Reviewed by Tim Hatcher.
      
              - tests for <rdar://problem/5221297> Font family name in the cssText for a DOMCSSStyleDeclaration needs quotes
      
              * editing/style/font-family-with-space-expected.txt: Added.
              * editing/style/font-family-with-space.html: Added.
      
              * fast/inspector/style-expected.txt: Updated expected results to expect "Lucida Grande" in quote marks.
      
      WebCore:
      
              Reviewed by Tim Hatcher.
      
              - fix <rdar://problem/5221297> Font family name in the cssText for a DOMCSSStyleDeclaration needs quotes
      
              Test: editing/style/font-family-with-space.html
      
              * css/FontFamilyValue.cpp:
              (WebCore::isValidCSSIdentifier): Added. Implements the same rule that the CSS lexer does.
              (WebCore::quoteStringIfNeeded): Changed to call isValidCSSIdentifier instead of just
              checking for a leading "#" character.
              * editing/markup.cpp:
              (WebCore::escapeTextForMarkup): Changed to take a String parameter for better efficiency.
              (WebCore::renderedText): Changed to return a String for better efficiency.
              (WebCore::addNamespace): Updated to pass String to escapeTextForMarkup.
              (WebCore::startMarkup): Updated to pass String to escapeTextForMarkup. Added missing call
              to escapeTextForMarkup in the special case for the style property.
              (WebCore::createMarkup): Changed from single quotes to double quotes and also added missing
              call to escapeTextForMarkup in two special cases for the style property.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@23969 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      ba73e6e5
    • adele's avatar
      Updating comment · aae935a9
      adele authored
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@23967 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      aae935a9
    • weinig's avatar
      Reviewed by Darin. · 9f5c75ef
      weinig authored
              Twelfth round of fixes for implicit 64-32 bit conversion errors.
              <rdar://problem/5292262>
      
              - Add casts and accompanying FIXMEs to avoid remaining compiler errors.
      
              * WebCore.xcodeproj/project.pbxproj:
              * loader/FrameLoader.cpp:
              (WebCore::FrameLoader::opened):
              (WebCore::FrameLoader::sendRemainingDelegateMessages):
              * loader/FrameLoader.h:
              * loader/ResourceLoader.cpp:
              (WebCore::ResourceLoader::didReceiveData):
              * platform/network/mac/ResourceHandleMac.mm:
              (-[WebCoreResourceHandleAsDelegate connection:didReceiveData:lengthReceived:]):
              (-[WebCoreResourceHandleAsDelegate connection:willStopBufferingData:]):
              * platform/network/mac/ResourceResponseMac.mm:
              (WebCore::ResourceResponse::nsURLResponse):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@23964 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      9f5c75ef
    • adele's avatar
      LayoutTests: · ac11dd1d
      adele authored
              Reviewed by Darin.
      
              Test for: <rdar://problem/5292988> domain names shouldn't contain ignorable characters
      
              * fast/encoding/idn-security-expected.txt: Added.
              * fast/encoding/idn-security.html: Added.
              * win/Skipped: Blocked by <rdar://problem/5301954>.
      
      WebKit:
      
              Reviewed by Darin.
      
              Fix for: <rdar://problem/5292988> domain names shouldn't contain ignorable characters
      
              * Misc/WebNSURLExtras.m:
              (isLookalikeCharacter): Renamed.  Also excludes any non-printable character, 
               any character considered as whitespace that isn't already converted to a space by ICU, any ignorable character,
               and any character excluded in Mozilla's blacklist: http://kb.mozillazine.org/Network.IDN.blacklist_chars
              (allCharactersInIDNScriptWhiteList):
      
      WebKitTools:
      
              Reviewed by Darin.
      
              Extended DumpRenderTree to test encoding and decoding host names.
      
              * DumpRenderTree/DumpRenderTree.m:
              (+[LayoutTestController isSelectorExcludedFromWebScript:]): Added cases for encodeHostName and decodeHostName.
              (+[LayoutTestController webScriptNameForSelector:]): ditto.
              (-[LayoutTestController decodeHostName:]): Added.
              (-[LayoutTestController encodeHostName:]): Added.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@23963 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      ac11dd1d
    • weinig's avatar
      Reviewed by Darin. · 091a5190
      weinig authored
              Eleventh round of fixes for implicit 64-32 bit conversion errors.
              <rdar://problem/5292262>
      
              Add functions to test long long and unsigned long long.
      
              * DumpRenderTree/DumpRenderTree.m:
              (+[LayoutTestController isSelectorExcludedFromWebScript:]):
              (+[LayoutTestController webScriptNameForSelector:]):
              (-[LayoutTestController objCLongLongRoundTrip:]):
              (-[LayoutTestController objCUnsignedLongLongRoundTrip:]):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@23961 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      091a5190
    • weinig's avatar
      JavaScriptCore: · e697c30f
      weinig authored
              Reviewed by Darin.
      
              Eleventh round of fixes for implicit 64-32 bit conversion errors.
              <rdar://problem/5292262>
      
              - Fixes a real bug where where we were setting long long and unsigned long long
                values to a long field.
      
              * bindings/objc/objc_utility.mm:
              (KJS::Bindings::convertValueToObjcValue):
      
      LayoutTests:
      
              Reviewed by Darin.
      
              Eleventh round of fixes for implicit 64-32 bit conversion errors.
              <rdar://problem/5292262>
      
              * fast/objc: Added.
              * fast/objc/longlongTest-expected.txt: Added.
              * fast/objc/longlongTest.html: Added.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@23960 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      e697c30f
    • darin's avatar
      Reviewed by Maciej. · 093aa085
      darin authored
              - fix <rdar://problem/5310848> WebDataSource lifetime problem -- may be cause of the leaks seen on the buildbot
      
              * WebView/WebDataSource.mm:
              (-[WebDataSourcePrivate dealloc]): Added a call to the new detachDataSource function.
              (-[WebDataSourcePrivate finalize]): Ditto.
      
              * WebView/WebDocumentLoaderMac.h: Added detachDataSource function to be used when the
              WebDataSource is deallocated. Added retain/releaseDataSource helper functions to be
              used to retain and release the data source object. Replaced the m_hasEverBeenDetached
              boolean with a more primitive and hence easier to understand m_isDataSourceRetained boolean.
      
              * WebView/WebDocumentLoaderMac.mm:
              (WebDocumentLoaderMac::WebDocumentLoaderMac): Initialize m_isDataSourceRetained to false.
              (WebDocumentLoaderMac::setDataSource): Call retainDataSource instead of calling HardRetain
              on the dataSource parameter. Also updated a comment.
              (WebDocumentLoaderMac::attachToFrame): Call retainDataSource unconditionally rather than
              trying to use m_hasEverBeenDetached to decide if a retain is needed. Also got rid of an
              assertion that m_loadingResources is empty -- not important any more.
              (WebDocumentLoaderMac::detachFromFrame): Call releaseDataSource instead of using
              HardRelease, but only if m_loadingResources is empty. If it's non-empty, then we'll
              do the releaseDataSource later in decreaseLoadCount.
              (WebDocumentLoaderMac::increaseLoadCount): Call retainDataSource unconditionally
              rather than calling HardRetain only if the old set of resources was empty.
              (WebDocumentLoaderMac::decreaseLoadCount): Call releaseDataSource if m_loadingResources
              is empty and we're not attached to a frame. If we are attached to a frame, then
              we'll do the releaseDataSource later in detachFromFrame.
              (WebDocumentLoaderMac::retainDataSource): Added. Calls CFRetain, but only if the data
              source is not already retained (according to the boolean).
              (WebDocumentLoaderMac::releaseDataSource): Added. Calls CFRelease, but only if the data
              source is currently retained (according to the boolean).
              (WebDocumentLoaderMac::detachDataSource): Added. Sets m_dataSource to nil. Since this
              is only called from WebDataSource's dealloc and finalize methods, it won't ever be called
              when the m_isDataSourceRetained boolean is true.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@23957 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      093aa085
    • andersca's avatar
      Reviewed by Adam. · c4dd9a8e
      andersca authored
              <rdar://problem/5093862>
              Nothing shown in plugin area when trying to play content using the DivX plugin
              
              Defer calling SetWindow for the DivX plugin, just like we do with the WMP plugin.
                      
              * plugins/win/PluginViewWin.cpp:
              (WebCore::PluginViewWin::determineQuirks):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@23956 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      c4dd9a8e
    • weinig's avatar
      Reviewed by Brady Eidson. · e2532ef2
      weinig authored
              Tenth round of fixes for implicit 64-32 bit conversion errors.
              <rdar://problem/5292262>
      
              - Add explicit casts.
      
              * kjs/dtoa.cpp:
              (Bigint::):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@23955 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      e2532ef2
    • darin's avatar
      - forgot to check in one file in the fix for <rdar://problem/5307880> · 279784b3
      darin authored
                some classes need finalize methods because of non-trivial work done in dealloc methods
      
              * WebView/WebView.mm: (-[WebViewPrivate finalize]): Delete identifierMap so it doesn't leak.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@23954 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      279784b3
    • weinig's avatar
      Reviewed by Brady Eidson. · f331ea30
      weinig authored
              Ninth round of fixes for implicit 64-32 bit conversion errors.
              <rdar://problem/5292262>
      
              - Fix function signature to use unsigned long instead of unsigned long long.
      
              * loader/ProgressTracker.cpp:
              (WebCore::ProgressTracker::completeProgress):
              * loader/ProgressTracker.h:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@23953 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      f331ea30
    • weinig's avatar
      Reviewed by Oliver. · ffd4b77f
      weinig authored
              Eighth round of fixes for implicit 64-32 bit conversion errors.
              <rdar://problem/5292262>
      
              - Convert SVG implementation files to use floats instead of doubles
                to match the spec/IDLs.
      
              * bindings/scripts/CodeGeneratorJS.pm:
              * ksvg2/svg/SVGAngle.cpp:
              * ksvg2/svg/SVGAnimatedTemplate.h:
              * ksvg2/svg/SVGAnimationElement.cpp:
              (WebCore::SVGAnimationElement::getEndTime):
              (WebCore::SVGAnimationElement::getStartTime):
              (WebCore::SVGAnimationElement::getCurrentTime):
              (WebCore::SVGAnimationElement::getSimpleDuration):
              * ksvg2/svg/SVGAnimationElement.h:
              * ksvg2/svg/SVGFitToViewBox.cpp:
              (WebCore::SVGFitToViewBox::parseViewBox):
              * ksvg2/svg/SVGLength.cpp:
              (WebCore::SVGLength::setValueAsString):
              * ksvg2/svg/SVGLinearGradientElement.cpp:
              (WebCore::SVGLinearGradientElement::buildGradient):
              * ksvg2/svg/SVGMatrix.idl:
              * ksvg2/svg/SVGNumber.idl:
              * ksvg2/svg/SVGParserUtilities.cpp:
              (WebCore::SVGPathParser::parseSVG):
              (WebCore::SVGPathParser::calculateArc):
              (WebCore::SVGPathParser::svgLineToHorizontal):
              (WebCore::SVGPathParser::svgLineToVertical):
              (WebCore::SVGPathParser::svgCurveToCubicSmooth):
              (WebCore::SVGPathParser::svgCurveToQuadratic):
              (WebCore::SVGPathParser::svgCurveToQuadraticSmooth):
              (WebCore::SVGPathParser::svgArcTo):
              * ksvg2/svg/SVGParserUtilities.h:
              * ksvg2/svg/SVGPathElement.cpp:
              (WebCore::SVGPathElement::SVGPathElement):
              (WebCore::SVGPathElement::getTotalLength):
              (WebCore::SVGPathElement::getPointAtLength):
              (WebCore::SVGPathElement::getPathSegAtLength):
              (WebCore::SVGPathElement::createSVGPathSegMovetoAbs):
              (WebCore::SVGPathElement::createSVGPathSegMovetoRel):
              (WebCore::SVGPathElement::createSVGPathSegLinetoAbs):
              (WebCore::SVGPathElement::createSVGPathSegLinetoRel):
              (WebCore::SVGPathElement::createSVGPathSegCurvetoCubicAbs):
              (WebCore::SVGPathElement::createSVGPathSegCurvetoCubicRel):
              (WebCore::SVGPathElement::createSVGPathSegCurvetoQuadraticAbs):
              (WebCore::SVGPathElement::createSVGPathSegCurvetoQuadraticRel):
              (WebCore::SVGPathElement::createSVGPathSegArcAbs):
              (WebCore::SVGPathElement::createSVGPathSegArcRel):
              (WebCore::SVGPathElement::createSVGPathSegLinetoHorizontalAbs):
              (WebCore::SVGPathElement::createSVGPathSegLinetoHorizontalRel):
              (WebCore::SVGPathElement::createSVGPathSegLinetoVerticalAbs):
              (WebCore::SVGPathElement::createSVGPathSegLinetoVerticalRel):
              (WebCore::SVGPathElement::createSVGPathSegCurvetoCubicSmoothAbs):
              (WebCore::SVGPathElement::createSVGPathSegCurvetoCubicSmoothRel):
              (WebCore::SVGPathElement::createSVGPathSegCurvetoQuadraticSmoothAbs):
              (WebCore::SVGPathElement::createSVGPathSegCurvetoQuadraticSmoothRel):
              (WebCore::SVGPathElement::svgMoveTo):
              (WebCore::SVGPathElement::svgLineTo):
              (WebCore::SVGPathElement::svgLineToHorizontal):
              (WebCore::SVGPathElement::svgLineToVertical):
              (WebCore::SVGPathElement::svgCurveToCubic):
              (WebCore::SVGPathElement::svgCurveToCubicSmooth):
              (WebCore::SVGPathElement::svgCurveToQuadratic):
              (WebCore::SVGPathElement::svgCurveToQuadraticSmooth):
              (WebCore::SVGPathElement::svgArcTo):
              (WebCore::SVGPathElement::parseMappedAttribute):
              * ksvg2/svg/SVGPathElement.h:
              * ksvg2/svg/SVGPathSegArc.cpp:
              (WebCore::SVGPathSegArcAbs::SVGPathSegArcAbs):
              (WebCore::SVGPathSegArcAbs::setX):
              (WebCore::SVGPathSegArcAbs::x):
              (WebCore::SVGPathSegArcAbs::setY):
              (WebCore::SVGPathSegArcAbs::y):
              (WebCore::SVGPathSegArcAbs::setR1):
              (WebCore::SVGPathSegArcAbs::r1):
              (WebCore::SVGPathSegArcAbs::setR2):
              (WebCore::SVGPathSegArcAbs::r2):
              (WebCore::SVGPathSegArcAbs::setAngle):
              (WebCore::SVGPathSegArcAbs::angle):
              (WebCore::SVGPathSegArcRel::SVGPathSegArcRel):
              (WebCore::SVGPathSegArcRel::setX):
              (WebCore::SVGPathSegArcRel::x):
              (WebCore::SVGPathSegArcRel::setY):
              (WebCore::SVGPathSegArcRel::y):
              (WebCore::SVGPathSegArcRel::setR1):
              (WebCore::SVGPathSegArcRel::r1):
              (WebCore::SVGPathSegArcRel::setR2):
              (WebCore::SVGPathSegArcRel::r2):
              (WebCore::SVGPathSegArcRel::setAngle):
              (WebCore::SVGPathSegArcRel::angle):
              * ksvg2/svg/SVGPathSegArc.h:
              * ksvg2/svg/SVGPathSegCurvetoCubic.cpp:
              (WebCore::SVGPathSegCurvetoCubicAbs::SVGPathSegCurvetoCubicAbs):
              (WebCore::SVGPathSegCurvetoCubicAbs::setX):
              (WebCore::SVGPathSegCurvetoCubicAbs::x):
              (WebCore::SVGPathSegCurvetoCubicAbs::setY):
              (WebCore::SVGPathSegCurvetoCubicAbs::y):
              (WebCore::SVGPathSegCurvetoCubicAbs::setX1):
              (WebCore::SVGPathSegCurvetoCubicAbs::x1):
              (WebCore::SVGPathSegCurvetoCubicAbs::setY1):
              (WebCore::SVGPathSegCurvetoCubicAbs::y1):
              (WebCore::SVGPathSegCurvetoCubicAbs::setX2):
              (WebCore::SVGPathSegCurvetoCubicAbs::x2):
              (WebCore::SVGPathSegCurvetoCubicAbs::setY2):
              (WebCore::SVGPathSegCurvetoCubicAbs::y2):
              (WebCore::SVGPathSegCurvetoCubicRel::SVGPathSegCurvetoCubicRel):
              (WebCore::SVGPathSegCurvetoCubicRel::setX):
              (WebCore::SVGPathSegCurvetoCubicRel::x):
              (WebCore::SVGPathSegCurvetoCubicRel::setY):
              (WebCore::SVGPathSegCurvetoCubicRel::y):
              (WebCore::SVGPathSegCurvetoCubicRel::setX1):
              (WebCore::SVGPathSegCurvetoCubicRel::x1):
              (WebCore::SVGPathSegCurvetoCubicRel::setY1):
              (WebCore::SVGPathSegCurvetoCubicRel::y1):
              (WebCore::SVGPathSegCurvetoCubicRel::setX2):
              (WebCore::SVGPathSegCurvetoCubicRel::x2):
              (WebCore::SVGPathSegCurvetoCubicRel::setY2):
              (WebCore::SVGPathSegCurvetoCubicRel::y2):
              * ksvg2/svg/SVGPathSegCurvetoCubic.h:
              * ksvg2/svg/SVGPathSegCurvetoCubicSmooth.cpp:
              (WebCore::SVGPathSegCurvetoCubicSmoothAbs::SVGPathSegCurvetoCubicSmoothAbs):
              (WebCore::SVGPathSegCurvetoCubicSmoothAbs::setX):
              (WebCore::SVGPathSegCurvetoCubicSmoothAbs::x):
              (WebCore::SVGPathSegCurvetoCubicSmoothAbs::setY):
              (WebCore::SVGPathSegCurvetoCubicSmoothAbs::y):
              (WebCore::SVGPathSegCurvetoCubicSmoothAbs::setX2):
              (WebCore::SVGPathSegCurvetoCubicSmoothAbs::x2):
              (WebCore::SVGPathSegCurvetoCubicSmoothAbs::setY2):
              (WebCore::SVGPathSegCurvetoCubicSmoothAbs::y2):
              (WebCore::SVGPathSegCurvetoCubicSmoothRel::SVGPathSegCurvetoCubicSmoothRel):
              (WebCore::SVGPathSegCurvetoCubicSmoothRel::setX):
              (WebCore::SVGPathSegCurvetoCubicSmoothRel::x):
              (WebCore::SVGPathSegCurvetoCubicSmoothRel::setY):
              (WebCore::SVGPathSegCurvetoCubicSmoothRel::y):
              (WebCore::SVGPathSegCurvetoCubicSmoothRel::setX2):
              (WebCore::SVGPathSegCurvetoCubicSmoothRel::x2):
              (WebCore::SVGPathSegCurvetoCubicSmoothRel::setY2):
              (WebCore::SVGPathSegCurvetoCubicSmoothRel::y2):
              * ksvg2/svg/SVGPathSegCurvetoCubicSmooth.h:
              * ksvg2/svg/SVGPathSegCurvetoQuadratic.cpp:
              (WebCore::SVGPathSegCurvetoQuadraticAbs::SVGPathSegCurvetoQuadraticAbs):
              (WebCore::SVGPathSegCurvetoQuadraticAbs::setX):
              (WebCore::SVGPathSegCurvetoQuadraticAbs::x):
              (WebCore::SVGPathSegCurvetoQuadraticAbs::setY):
              (WebCore::SVGPathSegCurvetoQuadraticAbs::y):
              (WebCore::SVGPathSegCurvetoQuadraticAbs::setX1):
              (WebCore::SVGPathSegCurvetoQuadraticAbs::x1):
              (WebCore::SVGPathSegCurvetoQuadraticAbs::setY1):
              (WebCore::SVGPathSegCurvetoQuadraticAbs::y1):
              (WebCore::SVGPathSegCurvetoQuadraticRel::SVGPathSegCurvetoQuadraticRel):
              (WebCore::SVGPathSegCurvetoQuadraticRel::setX):
              (WebCore::SVGPathSegCurvetoQuadraticRel::x):
              (WebCore::SVGPathSegCurvetoQuadraticRel::setY):
              (WebCore::SVGPathSegCurvetoQuadraticRel::y):
              (WebCore::SVGPathSegCurvetoQuadraticRel::setX1):
              (WebCore::SVGPathSegCurvetoQuadraticRel::x1):
              (WebCore::SVGPathSegCurvetoQuadraticRel::setY1):
              (WebCore::SVGPathSegCurvetoQuadraticRel::y1):
              * ksvg2/svg/SVGPathSegCurvetoQuadratic.h:
              (WebCore::SVGPathSegCurvetoQuadraticRel::toString):
              * ksvg2/svg/SVGPathSegCurvetoQuadraticSmooth.cpp:
              (WebCore::SVGPathSegCurvetoQuadraticSmoothAbs::SVGPathSegCurvetoQuadraticSmoothAbs):
              (WebCore::SVGPathSegCurvetoQuadraticSmoothAbs::setX):
              (WebCore::SVGPathSegCurvetoQuadraticSmoothAbs::x):
              (WebCore::SVGPathSegCurvetoQuadraticSmoothAbs::setY):
              (WebCore::SVGPathSegCurvetoQuadraticSmoothAbs::y):
              (WebCore::SVGPathSegCurvetoQuadraticSmoothRel::SVGPathSegCurvetoQuadraticSmoothRel):
              (WebCore::SVGPathSegCurvetoQuadraticSmoothRel::setX):
              (WebCore::SVGPathSegCurvetoQuadraticSmoothRel::x):
              (WebCore::SVGPathSegCurvetoQuadraticSmoothRel::setY):
              (WebCore::SVGPathSegCurvetoQuadraticSmoothRel::y):
              * ksvg2/svg/SVGPathSegCurvetoQuadraticSmooth.h:
              * ksvg2/svg/SVGPathSegLineto.cpp:
              (WebCore::SVGPathSegLinetoAbs::SVGPathSegLinetoAbs):
              (WebCore::SVGPathSegLinetoAbs::setX):
              (WebCore::SVGPathSegLinetoAbs::x):
              (WebCore::SVGPathSegLinetoAbs::setY):
              (WebCore::SVGPathSegLinetoAbs::y):
              (WebCore::SVGPathSegLinetoRel::SVGPathSegLinetoRel):
              (WebCore::SVGPathSegLinetoRel::setX):
              (WebCore::SVGPathSegLinetoRel::x):
              (WebCore::SVGPathSegLinetoRel::setY):
              (WebCore::SVGPathSegLinetoRel::y):
              * ksvg2/svg/SVGPathSegLineto.h:
              * ksvg2/svg/SVGPathSegLinetoHorizontal.cpp:
              (WebCore::SVGPathSegLinetoHorizontalAbs::SVGPathSegLinetoHorizontalAbs):
              (WebCore::SVGPathSegLinetoHorizontalAbs::setX):
              (WebCore::SVGPathSegLinetoHorizontalAbs::x):
              (WebCore::SVGPathSegLinetoHorizontalRel::SVGPathSegLinetoHorizontalRel):
              (WebCore::SVGPathSegLinetoHorizontalRel::setX):
              (WebCore::SVGPathSegLinetoHorizontalRel::x):
              * ksvg2/svg/SVGPathSegLinetoHorizontal.h:
              * ksvg2/svg/SVGPathSegLinetoVertical.cpp:
              (WebCore::SVGPathSegLinetoVerticalAbs::SVGPathSegLinetoVerticalAbs):
              (WebCore::SVGPathSegLinetoVerticalAbs::setY):
              (WebCore::SVGPathSegLinetoVerticalAbs::y):
              (WebCore::SVGPathSegLinetoVerticalRel::SVGPathSegLinetoVerticalRel):
              (WebCore::SVGPathSegLinetoVerticalRel::setY):
              (WebCore::SVGPathSegLinetoVerticalRel::y):
              * ksvg2/svg/SVGPathSegLinetoVertical.h:
              * ksvg2/svg/SVGPathSegList.cpp:
              (WebCore::SVGPathSegList::getPathSegAtLength):
              * ksvg2/svg/SVGPathSegList.h:
              * ksvg2/svg/SVGPathSegMoveto.cpp:
              (WebCore::SVGPathSegMovetoAbs::SVGPathSegMovetoAbs):
              (WebCore::SVGPathSegMovetoAbs::setX):
              (WebCore::SVGPathSegMovetoAbs::x):
              (WebCore::SVGPathSegMovetoAbs::setY):
              (WebCore::SVGPathSegMovetoAbs::y):
              (WebCore::SVGPathSegMovetoRel::SVGPathSegMovetoRel):
              (WebCore::SVGPathSegMovetoRel::setX):
              (WebCore::SVGPathSegMovetoRel::x):
              (WebCore::SVGPathSegMovetoRel::setY):
              (WebCore::SVGPathSegMovetoRel::y):
              * ksvg2/svg/SVGPathSegMoveto.h:
              * ksvg2/svg/SVGPolyElement.cpp:
              (WebCore::SVGPolyElement::svgPolyTo):
              * ksvg2/svg/SVGRadialGradientElement.cpp:
              (WebCore::SVGRadialGradientElement::buildGradient):
              * ksvg2/svg/SVGSVGElement.cpp:
              (WebCore::SVGSVGElement::viewport):
              (WebCore::SVGSVGElement::getCurrentTime):
              * ksvg2/svg/SVGStopElement.cpp:
              (WebCore::SVGStopElement::SVGStopElement):
              (WebCore::SVGStopElement::parseMappedAttribute):
              * ksvg2/svg/SVGStopElement.h:
              * ksvg2/svg/SVGTransform.cpp:
              (SVGTransform::translate):
              (SVGTransform::scale):
              * ksvg2/svg/SVGTransformDistance.cpp:
              (WebCore::SVGTransformDistance::addToSVGTransform):
              (WebCore::SVGTransformDistance::distance):
              * ksvg2/svg/SVGTransformable.cpp:
              (WebCore::SVGTransformable::parseTransformAttribute):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@23951 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      ffd4b77f
    • andersca's avatar
      LayoutTests: · 336a76bc
      andersca authored
              Reviewed by Darin.
      
              <rdar://problem/5289718>
              http://bugs.webkit.org/show_bug.cgi?id=14437
              CrashTracer: [REGRESSION] 76 crashes in Safari at com.apple.WebCore: WebCore::Frame::settings const + 6 (14437)
              
              Add test from Alexey Proskuryakov.
              
              * plugins/plugin-remove-subframe-expected.txt: Added.
              * plugins/plugin-remove-subframe.html: Added.
      
      WebCore:
      
              Reviewed by Darin.
      
              <rdar://problem/5289718>
              http://bugs.webkit.org/show_bug.cgi?id=14437
              CrashTracer: [REGRESSION] 76 crashes in Safari at com.apple.WebCore: WebCore::Frame::settings const + 6 (14437)
              
              Based on a patch from Maxime Britto.
              
              * page/mac/WebCoreFrameBridge.mm:
              (-[WebCoreFrameBridge stringByEvaluatingJavaScriptFromString:forceUserGesture:]):
              If the script caused the frame to go away, return nil. This can only happen if a plugin in a subframe destroys
              its frame.
      
              (-[WebCoreFrameBridge aeDescByEvaluatingJavaScriptFromString:]):
              ASSERT that this is only called on the main frame.
      
      WebKit:
      
              Reviewed by Darin.
      
              * WebView/WebView.mm:
              (-[WebView stringByEvaluatingJavaScriptFromString:]):
              ASSERT that the value returned isn't nil. It can't be nil when invoked on the main frame.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@23950 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      336a76bc
    • sullivan's avatar
      Written by Darin, reviewed by me · 2560bea4
      sullivan authored
              
              - fixed <rdar://problem/5249730> REGRESSION (Leopard, around 9A464): Safari opens the same local 
                documents more than once due to canonicalization change
      
              * loader/mac/LoaderNSURLExtras.m:
              (canonicalURL):
              pass URL through KURL so we get KURL's version of canonicalization as well as
              NSURLProtocol's version of canonicalization
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@23949 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      2560bea4
    • weinig's avatar
      LayoutTests: · a05655e5
      weinig authored
              Reviewed by Darin.
      
              Seventh round of fixes for implicit 64-32 bit conversion errors.
              <rdar://problem/5292262>
      
              - Change from double -> float caused some slight changes.
      
              * svg/W3C-SVG-1.1/animate-elem-33-t-expected.txt:
              * svg/W3C-SVG-1.1/animate-elem-37-t-expected.txt:
              * svg/W3C-SVG-1.1/animate-elem-39-t-expected.txt:
              * svg/W3C-SVG-1.1/animate-elem-80-t-expected.txt:
              * svg/W3C-SVG-1.1/animate-elem-81-t-expected.txt:
              * svg/W3C-SVG-1.1/animate-elem-82-t-expected.txt:
              * svg/W3C-SVG-1.1/animate-elem-83-t-expected.txt:
              * svg/W3C-SVG-1.1/coords-units-02-b-expected.txt:
              * svg/W3C-SVG-1.1/painting-render-01-b-expected.txt:
              * svg/W3C-SVG-1.1/script-handle-02-b-expected.txt:
              * svg/W3C-SVG-1.1/script-handle-03-b-expected.txt:
              * svg/W3C-SVG-1.1/script-handle-04-b-expected.txt:
              * svg/W3C-SVG-1.1/shapes-circle-02-t-expected.txt:
              * svg/W3C-SVG-1.1/shapes-ellipse-02-t-expected.txt:
              * svg/W3C-SVG-1.1/text-align-01-b-expected.txt:
              * svg/W3C-SVG-1.1/text-align-05-b-expected.txt:
              * svg/W3C-SVG-1.1/types-basicDOM-01-b-expected.txt:
      
      WebCore:
      
              Reviewed by Darin.
      
              Seventh round of fixes for implicit 64-32 bit conversion errors.
              <rdar://problem/5292262>
      
              - Adds more narrowPrecision functions to FloatPoint, FloatSize and FloatRect.
              - Changes over more implicit conversions to use new functions.
      
              * bindings/js/kjs_window.cpp:
              (KJS::WindowFunc::callAsFunction):
              * platform/graphics/FloatPoint.cpp:
              (WebCore::FloatPoint::matrixTransform):
              (WebCore::FloatPoint::narrowPrecision):
              * platform/graphics/FloatPoint.h:
              * platform/graphics/FloatRect.cpp:
              (WebCore::FloatRect::narrowPrecision):
              * platform/graphics/FloatRect.h:
              * platform/graphics/FloatSize.cpp:
              (WebCore::FloatSize::narrowPrecision):
              * platform/graphics/FloatSize.h:
              * platform/graphics/Path.cpp:
              (WebCore::Path::createRoundedRectangle):
              (WebCore::Path::createRectangle):
              (WebCore::Path::createEllipse):
              * platform/graphics/mac/ColorMac.mm:
              (WebCore::nsColor):
              * platform/graphics/mac/IconMac.mm:
              (WebCore::Icon::paint):
              * platform/graphics/svg/cg/CgSupport.cpp:
              (WebCore::applyStrokeStyleToContext):
              * platform/graphics/svg/cg/SVGPaintServerGradientCg.cpp:
              (WebCore::CGShadingRefForRadialGradient):
              (WebCore::SVGPaintServerGradient::updateQuartzGradientStopsCache):
              (WebCore::SVGPaintServerGradient::handleBoundingBoxModeAndGradientTransformation):
              * platform/graphics/svg/cg/SVGResourceMaskerCg.mm:
              (WebCore::applyLuminanceToAlphaFilter):
              (WebCore::applyExpandAlphatoGrayscaleFilter):
              (WebCore::transformImageIntoGrayscaleMask):
              * platform/mac/WebCoreTextRenderer.mm:
              (WebCoreDrawTextAtPoint):
              * rendering/RenderPath.cpp:
              (WebCore::RenderPath::mapAbsolutePointToLocal):
              * rendering/RenderSVGContainer.cpp:
              (WebCore::RenderSVGContainer::calcViewport):
              * rendering/RenderSVGImage.cpp:
              (WebCore::RenderSVGImage::nodeAtPoint):
              * rendering/RenderSVGText.cpp:
              (WebCore::RenderSVGText::relativeBBox):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@23948 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      a05655e5
    • andersca's avatar
      Reviewed by Adam. · 0d8cec65
      andersca authored
              <rdar://problem/5261523>
              Crash playing MP11 on cnbc.com
              
              The WMP Netscape plugin still creates a window even when windowless mode is turned on. Work around this by
              always removing the "windowlessvideo" parameter before passing it to the plugin.
              According to http://msdn2.microsoft.com/en-us/library/bb249373.aspx, "The windowlessVideo property is not 
              supported for Netscape Navigator. Setting a value for this property in Navigator may yield unexpected results."
              
              * plugins/win/PluginViewWin.cpp:
              (WebCore::PluginViewWndProc):
              (WebCore::PluginViewWin::paint):
              (WebCore::PluginViewWin::invalidateRect):
              (WebCore::PluginViewWin::determineQuirks):
              (WebCore::PluginViewWin::setParameters):
              (WebCore::PluginViewWin::PluginViewWin):
              (WebCore::PluginViewWin::init):
              * plugins/win/PluginViewWin.h:
              (WebCore::):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@23947 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      0d8cec65
    • bdash's avatar
      2007-07-04 Mark Rowe <mrowe@apple.com> · a1b1f73f
      bdash authored
              Unreviewed 64-bit build fixes.
      
              * WebCoreSupport/WebInspectorClient.mm: Let the compiler know that WebFrameView is a subclass of NSView.
              * WebView/WebDocumentInternal.h: Remove our preprocessor macro once we're done with it.
              * WebView/WebHTMLView.mm:
              (-[WebHTMLView markAllMatchesForText:caseSensitive:limit:]): Fix argument types.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@23946 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      a1b1f73f
    • staikos's avatar
      Patch from Qing Zhao to fix sunken state improperly set. · 9185b783
      staikos authored
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@23945 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      9185b783
    • antti's avatar
      LayoutTests: · a207fef1
      antti authored
              Reviewed by Maciej.
              
              Test for REGRESSION: misplaced selection ring remains after link is no longer focused.
              <rdar://problem/5205580>
      
              * fast/repaint/focus-layers-expected.checksum: Added.
              * fast/repaint/focus-layers-expected.png: Added.
              * fast/repaint/focus-layers-expected.txt: Added.
              * fast/repaint/focus-layers.html: Added.
      
      WebCore:
      
              Reviewed by Maciej.
              
              REGRESSION: misplaced selection ring remains after link is no longer focused.
              <rdar://problem/5205580>
              
              Fix placement of selection ring when part of the ring is in a different layer.
      
              * rendering/RenderFlow.cpp:
              (WebCore::RenderFlow::addFocusRingRects): Get coordinates right when moving to a different layer.
              * rendering/RenderObject.cpp:
              (WebCore::RenderObject::setStyle): 
              Don't reset state variables when not necessary.  When repaint() was called at the end of setSyle() it would
              get repaint rects wrong in some cases.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@23944 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      a207fef1
    • antti's avatar
      Reviewed by Maciej. · 82a77f52
      antti authored
              Blind fix for CrashTracer: [USER] 25 crashes in Safari at com.apple.WebCore: WebCore::Frame::document const + 6
              <rdar://problem/5263939>
              
              No one has managed to reproduce this but it looks like null check is needed here. There are plausible ways
              m_frame could be null for a live FrameView object.
      
              * page/FrameView.cpp:
              (WebCore::FrameView::needsLayout):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@23943 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      82a77f52
  3. 02 Jul, 2007 1 commit