1. 09 Jan, 2003 4 commits
  2. 08 Jan, 2003 4 commits
    • cblu's avatar
      WebCore: · 0ce577a1
      cblu authored
      	Fixed: 3111432 - Support OBJECT tags with type text/plain or text/html
      
              Reviewed by dave.
      
              * kwq/KWQKHTMLPart.mm:
              (KWQKHTMLPart::createPart): call [_bridge frameRequiredForMIMEType:] to determine if we should create a plug-in view or iframe
              * kwq/WebCoreBridge.h: add frameRequiredForMIMEType:
      
      WebKit:
      
      	Fixed: 3111432 - Support OBJECT tags with type text/plain or text/html
      
              Reviewed by dave.
      
              * WebCoreSupport.subproj/WebBridge.m:
              (-[WebBridge frameRequiredForMIMEType:]): added, returns YES for non-plug-in views
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@3279 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      0ce577a1
    • trey's avatar
      3136213 - Page loads stopped by backtracking don't finish when moving forward · 8807f2f1
      trey authored
      	We need to remove the entry from the KHTML image cache when a load
      	has an error, so it will be reloaded next time we try.
      
              Reviewed by Darin,
      
              * khtml/misc/loader.cpp:
              (Loader::slotFinished):  Remove cache entry on job error.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@3278 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      8807f2f1
    • darin's avatar
      Reviewed by Dave. · e94e43ff
      darin authored
      	- fixed 96/72 dpi snafu; no need to do something different for AppKit,
                because it always uses pixel sizes, not font size
      
              * khtml/css/css_valueimpl.cpp:
              * khtml/css/css_valueimpl.h:
              * khtml/css/cssstyleselector.cpp:
              * kwq/KWQPaintDeviceMetrics.mm:
      	Rolled out change from 2002-12-05
      
      	- a cut at implementing heretofore unimplemented QTextStream classes
      
              * kwq/KWQTextStream.h:
              * kwq/KWQTextStream.mm:
      	First cut implementation.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@3277 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      e94e43ff
    • sheridan's avatar
      Safari-49 stamp. · ca58bc0a
      sheridan authored
      Note that I am not using "Alexander" in the tag name any more (RIP Great Alex)
      and that I did not rev the marketing version.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@3272 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      ca58bc0a
  3. 05 Jan, 2003 2 commits
    • mjs's avatar
      JavaScriptCore: · 6bdbdeb1
      mjs authored
              Reviewed by no one cause I'm just changing copyright strings.
      
              * JavaScriptCore.pbproj/project.pbxproj: Added non-Apple copyrights to
      	copyright strings.
              * English.lproj/InfoPlist.strings: Likewise.
      
      WebCore:
      
              Reviewed by no one cause I'm just changing copyright strings.
      
              * WebCore.pbproj/project.pbxproj: Added non-Apple copyrights to
      	copyright strings.
              * English.lproj/InfoPlist.strings: Likewise.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@3266 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      6bdbdeb1
    • darin's avatar
      JavaScriptCore: · 9b19889b
      darin authored
              * JavaScriptCore.pbproj/project.pbxproj: Fix "Apple Compupter" typo.
      	Remove unneeded CFBundleLongVersionString we don't use anywhere else.
      
      WebFoundation:
      
              * WebFoundation.pbproj/project.pbxproj: Fix "Apple Compupter" typo.
      
      WebCore:
      
              * Resources/Info.plist: Fix "Apple Compupter" typo.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@3258 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      9b19889b
  4. 04 Jan, 2003 2 commits
  5. 03 Jan, 2003 4 commits
    • rjw's avatar
      Fix for 3138425. Don't open a new window when document.open() is called · 5f65a093
      rjw authored
              with < 2 parameters.
      
              Reviewed by darin.
      
              * khtml/ecma/kjs_html.cpp:
              (KJS::HTMLDocFunction::tryCall):
              * khtml/ecma/kjs_window.cpp:
              (WindowFunc::tryCall):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@3251 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      5f65a093
    • rjw's avatar
      WebCore: · b026936c
      rjw authored
              Fixed 3138743, 3138678, and 3138854.  Removed the RenderText
              widths cache, replaced it with a much simply monospace character
              cache.  Should be much faster for covered cases too!  Also fixed
              buffer overrun problem causing the crash in 3138854.
      
              Reviewed by darin.
      
              * khtml/rendering/font.cpp:
              (Font::isFixedPitch):
              * khtml/rendering/font.h:
              * khtml/rendering/render_text.cpp:
              (TextSlave::checkSelectionPoint):
              (RenderText::RenderText):
              (RenderText::setStyle):
              (RenderText::~RenderText):
              (RenderText::shouldUseMonospaceCache):
              (RenderText::cacheWidths):
              (RenderText::widthFromCache):
              (RenderText::trimmedMinMaxWidth):
              (RenderText::calcMinMaxWidth):
              (RenderText::setText):
              (RenderText::width):
              * khtml/rendering/render_text.h:
              * kwq/KWQFont.h:
              * kwq/KWQFont.mm:
              (QFont::isFixedPitch):
              * kwq/WebCoreTextRendererFactory.h:
              * kwq/WebCoreTextRendererFactory.m:
              (-[WebCoreTextRendererFactory isFontFixedPitch:]):
      
      WebKit:
              Support for fixes to 3138743, 3138678.  Added
              isFontFixedPitch used to determine if font is fixed
              pitch.  Makes use of appkit private _isFakeFixedPitch
              (detects courier and monoca).  Updated our fakey test
              to use the appkit's version.
      
              Reviewed by darin.
      
              * WebCoreSupport.subproj/WebTextRenderer.m:
              * WebCoreSupport.subproj/WebTextRendererFactory.m:
              (-[WebTextRendererFactory isFontFixedPitch:]):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@3250 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      b026936c
    • sullivan's avatar
      - fixed 3138673 -- reproducible crash in JavaScript · 70d94889
      sullivan authored
              Reviewed by Darin, OK'ed by Don.
      
              * khtml/xml/dom_docimpl.cpp:
              (DocumentImpl::setTitle):
      	Check for nil view or nil part before dereferencing.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@3248 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      70d94889
    • hyatt's avatar
      Fix for percentage table heights. A check was missing to · 7c6e5520
      hyatt authored
      	look for a fixed height on the containing block.
      
              Reviewed by darin
      
              * khtml/rendering/render_table.cpp:
              (RenderTable::layoutRows):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@3247 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      7c6e5520
  6. 02 Jan, 2003 6 commits
    • kocienda's avatar
      Building Safari-48 · b9e87464
      kocienda authored
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@3240 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      b9e87464
    • hyatt's avatar
      Fix for 3136473. <object>s with no specified size should be · b30fb841
      hyatt authored
      	0x0.  They should not be 300x200.  Fixes thinker.org.
      
              Reviewed by john and darin.
      
              * khtml/rendering/render_frames.cpp:
              (RenderPart::intrinsicWidth):
              (RenderPart::intrinsicHeight):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@3238 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      b30fb841
    • darin's avatar
      Reviewed by Maciej and Trey. · ba021ece
      darin authored
      	- fixed 3138063 -- REGRESSION: JavaScript-submitted form activates input type=image (webmail.mac.com)
      
      	JavaScript-submitted forms must not get a submit button activated as return-key-submitted ones do.
      
              * khtml/html/html_formimpl.h: Add boolean activateSubmitButton parameter to submit.
              * khtml/html/html_formimpl.cpp:
              (HTMLFormElementImpl::prepareSubmit): Pass true for activateSubmitButton.
              (HTMLFormElementImpl::submit): Only activate a button if activateSubmitButton is true.
      
              * khtml/dom/html_form.cpp: (HTMLFormElement::submit): Pass false for activateSubmitButton.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@3237 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      ba021ece
    • hyatt's avatar
      Fix for the 3137790. This patch passes the mouse event x and y as · 559ff05c
      hyatt authored
      	distinct arguments to constructZTree, so that the damageRect can
      	really reflect your clip rect.
      	This allows me to prune out layers that are clipped so
      	that if x,y aren't inside the clip rect, the layer doesn't get added to
      	the list.
      
      	This patch also makes the "clip" property apply to the element that specifies the clip instead of to the element's kids.  This is ambiguous in the spec, but it turns out other browsers do it this way, so there really is an interpretation that must be followed. :)
      
      	Reviewed by darin
      
              * khtml/rendering/render_layer.cpp:
              (RenderLayer::nodeAtPoint):
              (RenderLayer::constructZTree):
              * khtml/rendering/render_layer.h:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@3236 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      559ff05c
    • hyatt's avatar
      Fix for bug #3137935. When a float causes a line to get · a14d1741
      hyatt authored
      	moved down past the float, the line would incorrectly break
      	rather than expanding to use the newly-available width.
      
              Reviewed by darin.
      
              * khtml/rendering/bidi.cpp:
              (RenderFlow::findNextLineBreak):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@3235 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      a14d1741
    • darin's avatar
      Reviewed by John. · 5be0ed74
      darin authored
      	- fixed 3131190 -- <textarea wrap="hard"> eats text on blur
      
              * kwq/KWQTextArea.mm: (-[KWQTextArea paragraphs]): Add missing parentheses so we don't
      	always return 0 or 1 for the number of paragraphs.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@3234 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      5be0ed74
  7. 01 Jan, 2003 3 commits
    • mjs's avatar
      WebCore: · 51e8fadc
      mjs authored
              Reviewed by Darin.
      
      	- fixed 3130831 - HOMEPAGE: JavaScript that tries to intercept onmousedown fails, image gets dragged instead
      	- fixed 3125554 - while dragging to select text in a nested frame, you can start dragging a link or image
      
              * kwq/KWQKHTMLPart.h:
              * kwq/KWQKHTMLPart.mm:
      	(KWQKHTMLPart::KWQKHTMLPart): Initialize new mouseDownMayStartDrag
      	and mouseDownMayStartSelect methods.
              (KWQKHTMLPart::khtmlMousePressEvent): Make sure a mouse down
      	won't be used to start a drag or selection if the default action
      	is prevented on the mouse down event.
      	(KWQKHTMLPart::mouseDown): Since the default action wasn't
      	prevented, decide if this might be the start of a drag or
      	selection.
              (KWQKHTMLPart::khtmlMouseMoveEvent): On a drag or selection, call
      	back to the bridge to handle selection or autoscrolling
      	appropriately.
      	* kwq/WebCoreBridge.h: Prototype new methods.
      
      WebKit:
      
      	Reviewed by Darin.
      
      	- fixed 3130831 - HOMEPAGE: JavaScript that tries to intercept onmousedown fails, image gets dragged instead
      	- fixed 3125554 - while dragging to select text in a nested frame, you can start dragging a link or image
      
              * WebCoreSupport.subproj/WebBridge.m:
              (-[WebBridge handleMouseDragged:]): New method; call through the WebHTMLView.
              (-[WebBridge mayStartDragWithMouseDown:]): Likewise.
              (-[WebBridge handleAutoscrollForMouseDragged:]): Likewise.
              * WebView.subproj/WebHTMLView.m:
              (-[WebHTMLView mouseDragged:]): Instead of doing drag handling
      	here, just pass the event to WebCore.
      	(-[WebHTMLView draggedImage:endedAt:operation:]): Send a fake
      	mousemove event instead of sending the current event (likely a
      	mouse up as if it were a mouse move).
              * WebView.subproj/WebHTMLViewPrivate.h:
              * WebView.subproj/WebHTMLViewPrivate.m:
              (-[WebHTMLViewPrivate dealloc]): Release drag element if any.
              (-[WebHTMLView _dragImageForElement:]): New method. Split out the
      	code to make the special drag image for links.
      	(-[WebHTMLView _handleMouseDragged:]): Move all the drag handling
      	here. This method will get called only if WebCore hasn't blocked
      	default drag handling.
              (-[WebHTMLView _handleAutoscrollForMouseDragged:]): Do
      	autoscroll. Autoscroll is still lame, we need a timer.
              (-[WebHTMLView _mayStartDragWithMouseDown:]): Determine if the element
      	is a link or image and so may be dragged; remember the drag element.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@3229 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      51e8fadc
    • darin's avatar
      Reviewed by Don. · 9b33efdb
      darin authored
      	- fixed 3137566 -- non-reproducible nil-dereference in KHTMLView::clearPart
      	deallocating KWQPageState
      
              * kwq/KWQPageState.mm: (-[KWQPageState dealloc]): Add nil check.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@3228 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      9b33efdb
    • hyatt's avatar
      Fix tables so that malformations inside them are properly pulled · a176a20d
      hyatt authored
      	out of the table without being flattened.
      
      	Fixes 3131480.
      
              Reviewed by gramps
      
              * khtml/html/dtd.cpp:
              (DOM::checkChild):
              * khtml/html/htmlparser.cpp:
              (KHTMLParser::insertNode):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@3226 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      a176a20d
  8. 31 Dec, 2002 2 commits
    • kocienda's avatar
      Building Safari-47 · 9baeec4e
      kocienda authored
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@3220 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      9baeec4e
    • darin's avatar
      Reviewed by Trey. · c67613fa
      darin authored
      	- fixed 3132141 -- enter key does not work with input type=image
      
      	Made the logic handle image and submit type inputs in the same way.
      
              * khtml/html/html_formimpl.h: Remove unused m_clicked flags.
              * khtml/html/html_formimpl.cpp:
              (HTMLButtonElementImpl::HTMLButtonElementImpl): Remove code to set the m_clicked flag.
      	The only place this flag was looked at is better handled by the m_activeSubmit flag.
              (HTMLButtonElementImpl::defaultEventHandler): Remove more m_clicked flag code.
              (HTMLInputElementImpl::HTMLInputElementImpl): Remove more m_clicked flag code.
              (HTMLInputElementImpl::isSuccessfulSubmitButton): An image is also a successful submit
      	button, and unlike a submit element, it doesn't require a name because it will just submit
              x and y with no name in that case. I suppose we could rename this function, but I think it's
              still a pretty clear name even if not 100% accurate.
              (HTMLInputElementImpl::encoding): Remove use of m_clicked and use m_activeSubmit instead.
      	This was the only place using m_clicked at all. Also remove bogus check for a -1 coordinate.
      	The coordinate defaults to 0, not -1, and it was never happening.
              (HTMLInputElementImpl::defaultEventHandler): Remove more m_clicked flag code.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@3218 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      c67613fa
  9. 30 Dec, 2002 5 commits
    • hyatt's avatar
      Fix for 3129016, make sure that zero-height tables and lists · 5873ea08
      hyatt authored
      	will be skipped in a search for floats that occur before
      	them.  Makes usatoday work.
      
              Reviewed by gramps
      
              * khtml/rendering/render_flow.cpp:
              (RenderFlow::clearFloats):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@3214 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      5873ea08
    • darin's avatar
      Reviewed by Maciej. · 58521793
      darin authored
      	- fixed 3135642 -- ad frames are missing at channels.netscape.com
      
              * khtml/rendering/render_frames.cpp: (RenderPartObject::updateWidget): Updated to use the
      	same rule as Mozilla: Empty URL for an iframe means "about:blank".
      
              * khtml/ecma/kjs_window.cpp: (Window::isSafeScript): Loosen things so that it's safe for
      	a frame to manipulate an empty child frame, as well as an empty opened window. Also remove
      	the useless check for an empty document -- it never happens in practice.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@3213 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      58521793
    • kocienda's avatar
      Tests: · 40efe749
      kocienda authored
              Reviewed by Darin and Gramps
      
      	Added some more test cases as part of the work to fix this bug:
      
      	Radar 3136795 (type URL with ../ in it, get assertion)
      
      	I also notice an unrelated change in ifnsurlextensions-test.chk where
      	leading whitespace in a URL is now getting removed correctly. Bonus.
      
              * TestURLs.h
              * WebFoundation-Misc/ifnsurlextensions-test.chk
              * WebFoundation-Misc/ifnsurlextensions-test.m:
              (main)
      
      WebFoundation:
      
              Reviewed by Darin and Gramps
      
              Radar 3136795 (type URL with ../ in it, get assertion)
      
              The code to remove relative portions from URLs was eating leading slashes on
              URL paths. This caused absolute paths with relative portions to get mangled,
              resulting in a URL that the engine could not use. Now, leading slashes are no
              longer removed from URL paths, resulting in usuable URLs.
      
              * Misc.subproj/WebNSURLExtras.m:
              (pathRemovingDots)
              (-[NSURL _web_URLComponents])
      
      WebCore:
      
              Reviewed by Darin and Gramps
      
      	Fix for this bug:
      
      	Radar 3136795 (type URL with ../ in it, get assertion)
      
      	The code to remove relative portions from URLs was eating leading slashes on
      	URL paths. This caused absolute paths with relative portions to get mangled,
      	resulting in a URL that the engine could not use. Now, leading slashes are no
      	longer removed from URL paths, resulting in usuable URLs.
      
              * kwq/KWQKURL.mm:
              (copyPathRemovingDots)
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@3211 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      40efe749
    • darin's avatar
      WebCore: · 477551a4
      darin authored
              Reviewed by Don.
      
      	- fixed 3103287 -- body of page not rendered (page uses JavaScript trick to be both a frameset and a frame)
      
      	Our self-reference protection prevented this page from working.
      	To fix the bug, I did three things:
      
         	    1) fixed the hole in the WebCore self-reference protection, so we could remove the WebKit one
                     (the hole was that it didn't ignore #xxx suffixes)
       	    2) moved the self-reference protection into a single function so it wasn't copied and pasted all over
      	    3) allowed one level of self-reference; still enough to prevent infinite recursion
      
      	Then I tested with the site from bug 3103287 and the one from bug 3083732 to make sure that was still OK.
      
              * khtml/html/html_baseimpl.h: Added isURLAllowed().
              * khtml/html/html_baseimpl.cpp:
              (HTMLFrameElementImpl::isURLAllowed): Added. Does the self-reference check and the "local only" check.
      	This logic was repeated in three different places before. Note that since we don't use the "local only"
              feature, it's not too risky to slightly change how it works.
              (HTMLFrameElementImpl::updateForNewURL): Use isURLAllowed.
              (HTMLFrameElementImpl::attach): Ditto.
              (HTMLIFrameElementImpl::attach): Ditto.
      
      WebKit:
      
              Reviewed by Don.
      
      	- fixed 3103287 -- body of page not rendered (page uses JavaScript trick to be both a frameset and a frame)
      
      	Our self-reference checks prevented this page from working.
      	I just removed the WebKit one, since it was really just working around a problem with the WebCore
      	one that I fixed (didn't ignore #xxx suffixes).
      
              * WebCoreSupport.subproj/WebBridge.m:
              (-[WebBridge createChildFrameNamed:withURL:renderPart:allowsScrolling:marginWidth:marginHeight:]):
      	Remove self-reference check.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@3209 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      477551a4
    • darin's avatar
      Reviewed by Don. · c5764f8d
      darin authored
      	- fixed 3130566 -- REGRESSION: list item numbers are overlapping the text of the list items
      
      	Moved the hack that handles list items that are not in lists out of the parser and into
      	the DOM and Render tree code itself. This fixes the issue where the parser doesn't know which
      	will be the parent node of the list item, and other problems with the old hack.
      
              * khtml/html/html_listimpl.cpp: (HTMLLIElementImpl::attach): Find the parent list (OL or UL).
      	If there is no parent list, set a "not in list" flag on the render object so it knows to render
      	"inside" no matter what the style says. Also use this parent and a safer check to make the
      	start attribute work even when there is an intervening DOM element in the hierarchy.
      
              * khtml/html/htmlparser.cpp: (KHTMLParser::getElement): Remove the code that tries to set
      	the style of an LI based on the current node at the time it's parsed, because the current node
      	is now often not the OL or the UL due to our DTD fix to allow other nodes in lists.
      
              * khtml/rendering/render_list.h: Add isInside() to RenderListMarker, setNotInList(), notInList(),
      	and _notInList to RenderListItem.
      
              * khtml/rendering/render_list.cpp:
              (RenderListItem::RenderListItem): Initialize _notInList to false.
              (RenderListMarker::paintObject): Use isInside() instead of checking listStylePosition().
              (RenderListMarker::calcMinMaxWidth): Ditto.
              (RenderListMarker::baselinePosition): Ditto.
              (RenderListMarker::isInside): Return true if we are not in a list, or if "inside" style is requested.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@3208 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      c5764f8d
  10. 29 Dec, 2002 3 commits
    • darin's avatar
      Reviewed by Don. · bd2f5f11
      darin authored
      	- fixed 3134346 -- country menu at www.apple.com does not work when you go back to that page
      
              * kwq/KWQKHTMLPart.mm: (KWQKHTMLPart::openURLFromPageCache): Add call to checkCompleted().
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@3207 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      bd2f5f11
    • darin's avatar
      Reviewed by Maciej. · 45f34810
      darin authored
      	- fixed 3136391 -- PianoNanny.com screens turn to garbage when resized
      
      	Turns out browsers pass open calls to the window object if they show up at the document
      	with parameters. We now emulate that too.
      
              * khtml/ecma/kjs_html.cpp: (KJS::HTMLDocFunction::tryCall): If we get an open call with
      	parameters, pass it on to the window.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@3205 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      45f34810
    • darin's avatar
      Reviewed by Ken. · 65e464a5
      darin authored
      	- fixed 3134560 -- Lord of the Rings desktops don't load
      
              * khtml/ecma/kjs_window.cpp: (WindowFunc::tryCall): Removed the APPLE_CHANGES here.
      	The comment claims that we don't need the code because "JavaScript will do the work
      	below on demand", but that's not true for setting the base URL. Also, the comment
      	claims that this "adds an extra entry to the back/forward list", but testing does not
      	bear that out.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@3200 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      65e464a5
  11. 28 Dec, 2002 3 commits
    • kocienda's avatar
      Safari-46 build · fccdb286
      kocienda authored
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@3197 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      fccdb286
    • kocienda's avatar
      WebCore: · 11bb1581
      kocienda authored
              Reviewed by Gramps and Richard.
      
      	Fix for this bug:
      
      	Radar 3112233 (400 response when attaching files at mail.yahoo.com)
      
      	KHTML multipart form code called into KMimeType class to determine
      	the mime type for file attachments, however, our implementation of
      	KMimeType has only stubs which call ERROR.
      
      	I added some code into KWQKHTMLPart and WebCoreBridge so that the
      	code in html_formimpl can call through to the WebFoundation mime
      	file map we maintain.
      
              * khtml/html/html_formimpl.cpp:
              (HTMLFormElementImpl::formData)
              * kwq/KWQKHTMLPart.h:
              * kwq/KWQKHTMLPart.mm:
              (KWQKHTMLPart::mimeTypeForFileName)
              * kwq/WebCoreBridge.h:
      
      WebKit:
      
               Reviewed by Gramps and Richard
      
               Fix for this bug:
      
               Radar 3112233 (400 response when attaching files at mail.yahoo.com)
      
               I added the MIMETypeForPath method which accesses the WebFoundation mime
               file map we maintain. KHTML can now access this map by using the bridge.
      
               * WebCoreSupport.subproj/WebBridge.m:
               (-[WebBridge MIMETypeForPath:])
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@3195 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      11bb1581
    • darin's avatar
      Reviewed by Don. · ee114f40
      darin authored
      	- fixed 3136262 -- Shockwave Flash at movies.yahoo.com does not work
      
              * khtml/rendering/render_frames.cpp: (RenderPartObject::updateWidget):
      	Moved the class ID special case MIME types out of the if statement so they can be shared
      	in the case where we have an embed tag but no MIME type.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@3190 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      ee114f40
  12. 26 Dec, 2002 1 commit
    • darin's avatar
      WebFoundation: · 3aa0d5f3
      darin authored
              Reviewed by Don.
      
              * Misc.subproj/WebAssertions.h: Fixed CRASH macro to use 0xbbadbeef instead of 0xbadbeef
      	to reduce the chance that the address will be valid once we have allocated a lot of memory.
      
      WebCore:
      
              Reviewed by Don.
      
              * kwq/KWQAssertions.h: Fixed CRASH macro to use 0xbbadbeef instead of 0xbadbeef
      	to reduce the chance that the address will be valid once we have allocated a lot of memory.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@3189 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      3aa0d5f3
  13. 25 Dec, 2002 1 commit
    • rjw's avatar
      Fix for 3134543 (and widely reported dupes). Don't use render_text · 8f03ce2d
      rjw authored
              widths cache except for whitespace == PRE.  The problem was that additional
              spaces in the RenderText's string were being inappropiately measured.
              An alternate, more complex and risky, fix would account for the whitespace
              properties during scanning of the RenderText width buffer.  Considering
              the scenario for which this optimization was added (3133261), this
              simpler fix is adequate.
      
              Reviewed by Darin and Don.
      
              * khtml/rendering/render_text.cpp:
              (RenderText::computeWidths):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@3186 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      8f03ce2d