1. 09 Jan, 2003 5 commits
    • mjs's avatar
      Reviewed by Dave. · 3de55bfc
      mjs authored
      	- fixed Radar 3143013 - hang trying to load spiny.com/software
              * khtml/rendering/render_table.cpp:
              (RenderTable::layoutRows): Check for the render root as a loop
      	termination condition, to avoid an infinite loop for an absolute
      	but non-fixed table cell.
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@3286 268f45cc-cd09-0410-ab3c-d52691b4dbfc
    • hyatt's avatar
      The "flow-mode" quirk for lists is just that - a quirk, and should · f5cec5e3
      hyatt authored
      	not be applied when in strict mode.
      	Fixes diveintomark.org's navigation bar on the front page (issue #2
      	on his list).
              Reviewed by darin and maciej
              * khtml/css/html4.css:
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@3285 268f45cc-cd09-0410-ab3c-d52691b4dbfc
    • hyatt's avatar
      Finish the KONQBLOCK removal and make sure that table rows and · 6d17fb2b
      hyatt authored
      	cells encountered inside stray content cause the stray content to
      	close so that the rows and cells can be part of the table.
      	This fixes the versiontracker bug.  #3142319.
              Reviewed by darin.
              * khtml/html/htmlparser.cpp:
              * khtml/html/htmlparser.h:
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@3282 268f45cc-cd09-0410-ab3c-d52691b4dbfc
    • trey's avatar
      3142201 - home directory nuked during power download session · 66177e0b
      trey authored
      	We add checks for various error cases that could combine to cause this problem.  While we
      	never got a reproducible case, we are confident that this is the only file removal done
      	in the download code, and its ability to wreak havoc has been clipped.
              Reviewed by Richard.
              * Downloads.subproj/WebDownloadHandler.m:
              (-[WebDownloadHandler cleanUpAfterFailure]):  Only nuke the partial download if in fact we created
      	a new download file.  Never nuke a directory.
              (-[WebDownloadHandler createFileIfNecessary]):  Don't add "." to the foo-1 filenames we generate
      	if the original filename doesn't have any extension.
              * WebView.subproj/WebMainResourceClient.m:
              (-[WebMainResourceClient continueAfterContentPolicy:response:]):
      	If the policyDelegate gives us a nil filename, just stop the whole load, instead of trying to
      	overwrite the user's home directory.
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@3281 268f45cc-cd09-0410-ab3c-d52691b4dbfc
    • hyatt's avatar
      Revert the redundancy that dirk noticed. · 5066da21
      hyatt authored
      	Fixing issue #3 on diveintomark.org's list, which actually involved
      	merging calcAbsoluteVertical to KHTML's trunk and then fixing
      	a math error in the bottom computation.
              Reviewed by NOBODY (OOPS!).
              * khtml/html/html_baseimpl.cpp:
              * khtml/rendering/render_box.cpp:
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@3280 268f45cc-cd09-0410-ab3c-d52691b4dbfc
  2. 08 Jan, 2003 6 commits
  3. 05 Jan, 2003 6 commits
  4. 04 Jan, 2003 2 commits
  5. 03 Jan, 2003 8 commits
    • rjw's avatar
      Fixed 3139129. Added application/xhtml+xml to list of supported type. · aa9061c7
      rjw authored
              Reviewed by gramps.
              * WebView.subproj/WebDataSourcePrivate.m:
              (+[WebDataSource _repTypes]):
              * WebView.subproj/WebViewPrivate.m:
              (+[WebView _viewTypes]):
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@3252 268f45cc-cd09-0410-ab3c-d52691b4dbfc
    • rjw's avatar
      Fix for 3138425. Don't open a new window when document.open() is called · 5f65a093
      rjw authored
              with < 2 parameters.
              Reviewed by darin.
              * khtml/ecma/kjs_html.cpp:
              * khtml/ecma/kjs_window.cpp:
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@3251 268f45cc-cd09-0410-ab3c-d52691b4dbfc
    • rjw's avatar
      WebCore: · b026936c
      rjw authored
              Fixed 3138743, 3138678, and 3138854.  Removed the RenderText
              widths cache, replaced it with a much simply monospace character
              cache.  Should be much faster for covered cases too!  Also fixed
              buffer overrun problem causing the crash in 3138854.
              Reviewed by darin.
              * khtml/rendering/font.cpp:
              * khtml/rendering/font.h:
              * khtml/rendering/render_text.cpp:
              * khtml/rendering/render_text.h:
              * kwq/KWQFont.h:
              * kwq/KWQFont.mm:
              * kwq/WebCoreTextRendererFactory.h:
              * kwq/WebCoreTextRendererFactory.m:
              (-[WebCoreTextRendererFactory isFontFixedPitch:]):
              Support for fixes to 3138743, 3138678.  Added
              isFontFixedPitch used to determine if font is fixed
              pitch.  Makes use of appkit private _isFakeFixedPitch
              (detects courier and monoca).  Updated our fakey test
              to use the appkit's version.
              Reviewed by darin.
              * WebCoreSupport.subproj/WebTextRenderer.m:
              * WebCoreSupport.subproj/WebTextRendererFactory.m:
              (-[WebTextRendererFactory isFontFixedPitch:]):
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@3250 268f45cc-cd09-0410-ab3c-d52691b4dbfc
    • darin's avatar
      Reviewed by Chris. · 4d497e95
      darin authored
      	- fixed leak of WebIconLoader observed using leaks tool
              * WebView.subproj/WebDataSourcePrivate.m:
              (-[WebDataSourcePrivate dealloc]): Tell the icon loader to stop loading.
      	Add a FIXME asking why we had to do this to fix the leak.
              (-[WebDataSource _loadIcon]): Add an assertion.
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@3249 268f45cc-cd09-0410-ab3c-d52691b4dbfc
    • sullivan's avatar
      - fixed 3138673 -- reproducible crash in JavaScript · 70d94889
      sullivan authored
              Reviewed by Darin, OK'ed by Don.
              * khtml/xml/dom_docimpl.cpp:
      	Check for nil view or nil part before dereferencing.
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@3248 268f45cc-cd09-0410-ab3c-d52691b4dbfc
    • hyatt's avatar
      Fix for percentage table heights. A check was missing to · 7c6e5520
      hyatt authored
      	look for a fixed height on the containing block.
              Reviewed by darin
              * khtml/rendering/render_table.cpp:
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@3247 268f45cc-cd09-0410-ab3c-d52691b4dbfc
    • rjw's avatar
      Fix to 3131226. Don't force a layout when the document view is set · 595f51b4
      rjw authored
              on the page's scrollview.  A layout would occur indirectly as a result
              of reflectScrolledClipView: being called when the document view
              was set.  The khtmlpart/khtmlview/WebHTMLView would be out of sync
              at this point and a layout would have unintended and incorrect
              side effects.
              Reviewed by Darin (and tested by John).
              * WebView.subproj/WebDynamicScrollBarsView.h:
              * WebView.subproj/WebDynamicScrollBarsView.m:
              (-[WebDynamicScrollBarsView updateScrollers]):
              * WebView.subproj/WebViewPrivate.m:
              (-[WebView _setDocumentView:]):
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@3246 268f45cc-cd09-0410-ab3c-d52691b4dbfc
    • darin's avatar
      Reviewed by Maciej. · 94e6d75e
      darin authored
      	- fixed 3138213 -- browser hangs trying to open Apple travel site
              * kjs/date_object.cpp: (timetUsingCF): Check for very-negative year numbers too.
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@3245 268f45cc-cd09-0410-ab3c-d52691b4dbfc
  6. 02 Jan, 2003 11 commits
    • kocienda's avatar
      Setting version to 49u · d1d93ce6
      kocienda authored
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@3244 268f45cc-cd09-0410-ab3c-d52691b4dbfc
    • kocienda's avatar
      Building Safari-48 · b9e87464
      kocienda authored
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@3240 268f45cc-cd09-0410-ab3c-d52691b4dbfc
    • rjw's avatar
      Increase the minimum font size to 9pt. This bounds the lower · 3d3be9b3
      rjw authored
              size of the sizes array used for named sizes.  Net effect is
              to increase xx-small from 8pt to 9pt.  xx-small is used by
              Reviewed by hyatt.
              * WebView.subproj/WebPreferences.m:
              (+[WebPreferences load]):
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@3239 268f45cc-cd09-0410-ab3c-d52691b4dbfc
    • hyatt's avatar
      Fix for 3136473. <object>s with no specified size should be · b30fb841
      hyatt authored
      	0x0.  They should not be 300x200.  Fixes thinker.org.
              Reviewed by john and darin.
              * khtml/rendering/render_frames.cpp:
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@3238 268f45cc-cd09-0410-ab3c-d52691b4dbfc
    • darin's avatar
      Reviewed by Maciej and Trey. · ba021ece
      darin authored
      	- fixed 3138063 -- REGRESSION: JavaScript-submitted form activates input type=image (webmail.mac.com)
      	JavaScript-submitted forms must not get a submit button activated as return-key-submitted ones do.
              * khtml/html/html_formimpl.h: Add boolean activateSubmitButton parameter to submit.
              * khtml/html/html_formimpl.cpp:
              (HTMLFormElementImpl::prepareSubmit): Pass true for activateSubmitButton.
              (HTMLFormElementImpl::submit): Only activate a button if activateSubmitButton is true.
              * khtml/dom/html_form.cpp: (HTMLFormElement::submit): Pass false for activateSubmitButton.
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@3237 268f45cc-cd09-0410-ab3c-d52691b4dbfc
    • hyatt's avatar
      Fix for the 3137790. This patch passes the mouse event x and y as · 559ff05c
      hyatt authored
      	distinct arguments to constructZTree, so that the damageRect can
      	really reflect your clip rect.
      	This allows me to prune out layers that are clipped so
      	that if x,y aren't inside the clip rect, the layer doesn't get added to
      	the list.
      	This patch also makes the "clip" property apply to the element that specifies the clip instead of to the element's kids.  This is ambiguous in the spec, but it turns out other browsers do it this way, so there really is an interpretation that must be followed. :)
      	Reviewed by darin
              * khtml/rendering/render_layer.cpp:
              * khtml/rendering/render_layer.h:
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@3236 268f45cc-cd09-0410-ab3c-d52691b4dbfc
    • hyatt's avatar
      Fix for bug #3137935. When a float causes a line to get · a14d1741
      hyatt authored
      	moved down past the float, the line would incorrectly break
      	rather than expanding to use the newly-available width.
              Reviewed by darin.
              * khtml/rendering/bidi.cpp:
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@3235 268f45cc-cd09-0410-ab3c-d52691b4dbfc
    • darin's avatar
      Reviewed by John. · 5be0ed74
      darin authored
      	- fixed 3131190 -- <textarea wrap="hard"> eats text on blur
              * kwq/KWQTextArea.mm: (-[KWQTextArea paragraphs]): Add missing parentheses so we don't
      	always return 0 or 1 for the number of paragraphs.
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@3234 268f45cc-cd09-0410-ab3c-d52691b4dbfc
    • darin's avatar
      Reviewed by Don. · 55effb60
      darin authored
              - at Scott and Don's request, roll out small text anti-aliasing cutoff
              Turns out this makes small text look worse, not better. We're not going to respect
              this setting, and in Panther AppKit will almost certainly be changed not to either.
              * WebCoreSupport.subproj/WebTextRenderer.m: Rolled out yesterday's change using CVS.
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@3233 268f45cc-cd09-0410-ab3c-d52691b4dbfc
    • darin's avatar
      Reviewed by John and Don. · 23b9ad79
      darin authored
      	- fixed 3137661 -- REGRESSION: autoscroll selection is broken
      	The new logic in WebCore is slightly pickier, and can't abide a mouse-moved event
      	coming in during a drag. Unfortunately, we were sending a fake mouse-moved event
      	during a drag, so lets not do that.
              * WebView.subproj/WebHTMLView.m:
              (-[WebHTMLView mouseDown:]): Cancel any scheduled fake mouse-moved event.
              (-[WebHTMLView mouseUp:]): Send a fake mouse-moved event because we didn't update during the drag.
              * WebView.subproj/WebHTMLViewPrivate.m: (-[WebHTMLView _frameOrBoundsChanged]):
      	Don't schedule a fake mouse-moved event if the mouse is down, because that means we are in the
              middle of a drag.
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@3232 268f45cc-cd09-0410-ab3c-d52691b4dbfc
    • darin's avatar
      Reviewed by John and Ken. · bbd1f7da
      darin authored
      	- fixed 3135548 -- exception in Internet Explorer bookmark import code at first startup
              * Bookmarks.subproj/WebBookmarkImporter.m:
              (_breakStringIntoLines): Break lines before a <DT> or </DL>.
              (_HREFTextFromSpec): Rewrite to simplify, search in a case-insensitive manner.
              (-[WebBookmarkImporter initWithPath:]): Change prefix checks to be case-insensitive.
      	Don't discard folders altogether if the name can't be parsed as that would mess up
      	nesting w.r.t the next </DL>. Make the </DL> handling robust so we misparse, but don't
      	crash the whole application by raising an exception.
              * English.lproj/StringsNotToBeLocalized.txt: Updated for this change and recent changes.
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@3231 268f45cc-cd09-0410-ab3c-d52691b4dbfc
  7. 01 Jan, 2003 2 commits
    • rjw's avatar
      Obey the font smoothing size preference (3137618). · 92f3789b
      rjw authored
              Reviewed by Don and Darin.
              * WebCoreSupport.subproj/WebTextRenderer.m:
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@3230 268f45cc-cd09-0410-ab3c-d52691b4dbfc
    • mjs's avatar
      WebCore: · 51e8fadc
      mjs authored
              Reviewed by Darin.
      	- fixed 3130831 - HOMEPAGE: JavaScript that tries to intercept onmousedown fails, image gets dragged instead
      	- fixed 3125554 - while dragging to select text in a nested frame, you can start dragging a link or image
              * kwq/KWQKHTMLPart.h:
              * kwq/KWQKHTMLPart.mm:
      	(KWQKHTMLPart::KWQKHTMLPart): Initialize new mouseDownMayStartDrag
      	and mouseDownMayStartSelect methods.
              (KWQKHTMLPart::khtmlMousePressEvent): Make sure a mouse down
      	won't be used to start a drag or selection if the default action
      	is prevented on the mouse down event.
      	(KWQKHTMLPart::mouseDown): Since the default action wasn't
      	prevented, decide if this might be the start of a drag or
              (KWQKHTMLPart::khtmlMouseMoveEvent): On a drag or selection, call
      	back to the bridge to handle selection or autoscrolling
      	* kwq/WebCoreBridge.h: Prototype new methods.
      	Reviewed by Darin.
      	- fixed 3130831 - HOMEPAGE: JavaScript that tries to intercept onmousedown fails, image gets dragged instead
      	- fixed 3125554 - while dragging to select text in a nested frame, you can start dragging a link or image
              * WebCoreSupport.subproj/WebBridge.m:
              (-[WebBridge handleMouseDragged:]): New method; call through the WebHTMLView.
              (-[WebBridge mayStartDragWithMouseDown:]): Likewise.
              (-[WebBridge handleAutoscrollForMouseDragged:]): Likewise.
              * WebView.subproj/WebHTMLView.m:
              (-[WebHTMLView mouseDragged:]): Instead of doing drag handling
      	here, just pass the event to WebCore.
      	(-[WebHTMLView draggedImage:endedAt:operation:]): Send a fake
      	mousemove event instead of sending the current event (likely a
      	mouse up as if it were a mouse move).
              * WebView.subproj/WebHTMLViewPrivate.h:
              * WebView.subproj/WebHTMLViewPrivate.m:
              (-[WebHTMLViewPrivate dealloc]): Release drag element if any.
              (-[WebHTMLView _dragImageForElement:]): New method. Split out the
      	code to make the special drag image for links.
      	(-[WebHTMLView _handleMouseDragged:]): Move all the drag handling
      	here. This method will get called only if WebCore hasn't blocked
      	default drag handling.
              (-[WebHTMLView _handleAutoscrollForMouseDragged:]): Do
      	autoscroll. Autoscroll is still lame, we need a timer.
              (-[WebHTMLView _mayStartDragWithMouseDown:]): Determine if the element
      	is a link or image and so may be dragged; remember the drag element.
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@3229 268f45cc-cd09-0410-ab3c-d52691b4dbfc