1. 21 Jan, 2003 1 commit
    • mjs's avatar
      Reviewed by Ken. · 3ddf5d37
      mjs authored
      	- fixed 3151982 - missing content at debka.com after iframe is written using document.write
      	- fixed 3000234 - javascript problem writing iframe at cycleworld.com
      
              * khtml/html/htmltokenizer.cpp:
              (HTMLTokenizer::scriptHandler): If we come out of the script with
      	the parser in skip mode, don't throw away the whole rest of the
      	document - instead, parse it as usual. The parser's skip mode will
      	take care of skipping stuff as needed and will detect close tags
      	for special tags like <iframe>.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@3363 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      3ddf5d37
  2. 20 Jan, 2003 5 commits
    • hyatt's avatar
      Fix :hover performance regression on wsj.com. Moving my · 061700e7
      hyatt authored
      	<a name="foo"> quirk down into the :hover rule  matching code,
      	so that we'll know never to apply :hover to anchorless <a>s.
      
              Reviewed by gramps
      
              * khtml/css/cssstyleselector.cpp:
              * khtml/rendering/render_object.cpp:
              (RenderObject::setHoverAndActive):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@3362 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      061700e7
    • mjs's avatar
      WebCore: · aa81b2bb
      mjs authored
              Reviewed by Trey.
      
      	- fixed 3132120 - onchange handler not firing on mac.com webmail
      
              * khtml/rendering/render_form.h:
              * khtml/rendering/render_replaced.cpp:
              (RenderWidget::handleFocusOut): Moved empty virtual method here from render_form.
              (RenderWidget::eventFilter): Uncomment call to handleFocusOut - we
      	need it to send onChange properly.
      	* khtml/rendering/render_replaced.h:
              * kwq/KWQObject.h: Add empty eventFilter virtual method.
              * kwq/KWQComboBox.h: Remove no longer needed empty eventFilter.
              * kwq/KWQEvent.h: Implement a bit more of QFocusEvent.
              * kwq/KWQTextArea.mm:
              (-[KWQTextArea _createTextView]): Tell the text view its widget.
              (-[KWQTextAreaTextView setWidget:]): New method to set widget.
              (-[KWQTextAreaTextView becomeFirstResponder]): In addition to the usual stuff,
      	call the widget's event filter with a focus in event.
              (-[KWQTextAreaTextView resignFirstResponder]): In addition to the usual stuff,
      	call the widget's event filter with a focus out event.
              * kwq/KWQTextField.mm:
              (-[KWQTextField becomeFirstResponder]): Cleaned up a bit.
              (-[KWQTextField fieldWillBecomeFirstResponder]): Call the widget's event filter with a focus in event.
              (-[KWQTextField fieldWillResignFirstResponder]): Call the widget's event filter with a focus out event.
              * kwq/KWQView.mm:
      
      WebKit:
      
              Reviewed by Trey.
      
      	- fixed 3132120 - onchange handler not firing on mac.com webmail
      
              * WebView.subproj/WebHTMLViewPrivate.m:
              (-[WebNSTextView resignFirstResponder]): If we really resign first responder, and
      	our delegate responds to filedWillBecomeFirstResponder, then call that method.
              (-[WebNSTextView becomeFirstResponder]): If we really become first responder, and
      	our delegate responds to filedWillBecomeFirstResponder, then call that method.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@3361 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      aa81b2bb
    • hyatt's avatar
      Fix for 3147213. <nobr> is treated like other inlines now, · 3862c857
      hyatt authored
      	so it can contain blocks.  <wbr> is also fixed.  This fixes
      	tvguide.com.
      
              Reviewed by john
      
              * khtml/html/dtd.cpp:
              (DOM::checkChild):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@3360 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      3862c857
    • hyatt's avatar
      Gah. Fix positioned objects and floating objects so that they · 0f6efab4
      hyatt authored
      	don't append themselves to the list of runs in normal flow.
      	An astoundingly basic bug. :(
      
              Reviewed by john
      
              * khtml/rendering/bidi.cpp:
              (appendRunsForObject):
              * khtml/rendering/render_flow.cpp:
              (RenderFlow::addChildToFlow):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@3357 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      0f6efab4
    • hyatt's avatar
      Fixes for 3150561 (blog articles vanish on stylesheet switch) and · ed93ca74
      hyatt authored
              and 3150560 (crash changing fixed positioned element to normal
              positioning dynamically).
      
              This change makes layers able to deal with dynamic changes in
              position that cause you to have to either remove a layer from
              the hierarchy while preserving the children or to insert a
              layer into the hierarchy in between a parent and its descendants.
      
      	This patch also rewrites :hover/:active so that they can actually
      	be used in selectors other than the rightmost selector (e.g., so you
      	can write a rule like "li:hover > a").
      
      	Also, layers will now properly clear out their hover/active state
      	when the mouse is no longer inside them.
      
      	With these fixes, Eric Meyer's "Pure CSS Menus" work (perfectly)
      	and the repainting problems on sites like brainjar.com and
      	diveintomark.org and wired.com are fixed.
      
              Reviewed by mjs and john.
      
              * khtml/css/css_stylesheetimpl.h:
              * khtml/css/cssparser.cpp:
              (StyleBaseImpl::parseSelector):
              * khtml/css/cssparser.h:
              * khtml/css/cssstyleselector.cpp:
              * khtml/css/cssstyleselector.h:
              * khtml/dom/html_head.cpp:
              (HTMLLinkElement::setDisabled):
              * khtml/rendering/render_box.cpp:
              (RenderBox::setStyle):
              * khtml/rendering/render_box.h:
              * khtml/rendering/render_container.cpp:
              (RenderContainer::appendChildNode):
              (RenderContainer::insertChildNode):
              * khtml/rendering/render_flow.cpp:
              (RenderFlow::setStyle):
              * khtml/rendering/render_flow.h:
              * khtml/rendering/render_layer.cpp:
              (RenderLayer::addChild):
              (RenderLayer::removeOnlyThisLayer):
              (RenderLayer::insertOnlyThisLayer):
              (RenderLayer::clearOtherLayersHoverActiveState):
              (RenderLayer::clearHoverAndActiveState):
              (RenderLayer::nodeAtPoint):
              (RenderLayer::constructZTree):
              * khtml/rendering/render_layer.h:
              * khtml/rendering/render_object.cpp:
              (RenderObject::addLayers):
              (RenderObject::moveLayers):
              (RenderObject::findNextLayer):
              (RenderObject::setStyle):
              (RenderObject::setHoverAndActive):
              * khtml/rendering/render_object.h:
              * khtml/rendering/render_style.cpp:
              (RenderStyle::diff):
              * khtml/rendering/render_style.h:
              * khtml/xml/dom_docimpl.cpp:
              (DocumentImpl::DocumentImpl):
              * khtml/xml/dom_docimpl.h:
              * khtml/xml/dom_elementimpl.cpp:
              (ElementImpl::recalcStyle):
              * khtml/xml/dom_nodeimpl.cpp:
              (NodeBaseImpl::setActive):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@3356 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      ed93ca74
  3. 18 Jan, 2003 1 commit
    • mjs's avatar
      Reviewed by John. · 48a4a372
      mjs authored
      	- fixed 3149511 - Blogger.com window closes after update is posted
      
              * khtml/ecma/kjs_window.cpp:
              (WindowFunc::tryCall): For now, don't allow closing the window at
      	all if it wasn't opened by JavaScript, since we don't support the
      	history object and so can't tell if the window has only one
      	history item.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@3355 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      48a4a372
  4. 17 Jan, 2003 7 commits
    • darin's avatar
      Reviewed by Dave. · f34db7c8
      darin authored
      	- fixed the crashing so the layout tests work
      
              * khtml/rendering/render_layer.h: Add a node pointer result.
              * khtml/rendering/render_layer.cpp: (RenderLayer::elementList):
      	Return the node pointer so we can destroy it when done with it.
      
              * khtml/rendering/render_object.h: Make renderArena() const.
              * khtml/rendering/render_object.cpp: (RenderObject::renderArena): Make it const.
      
              * kwq/KWQRenderTreeDebug.cpp: (writeLayers): Free the Z layer list when done.
      	Without this things just crashed.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@3353 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      f34db7c8
    • rjw's avatar
      Fixed 3126141. Allow pages with plugins to be cached. This is safe · 2684cf6a
      rjw authored
              because plugins are cleanly started/stopped when their containing views are
              added/removed from the view hierarchy.
      
              Reviewed by trey.
      
              * kwq/KWQKHTMLPart.mm:
              (KWQKHTMLPart::canCachePage):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@3352 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      2684cf6a
    • hyatt's avatar
      The new table code from Lars. Also includes bug fixes for · be02abb2
      hyatt authored
      	percentage height children in table cells, for positioning
      	of tables, and for width distribution of percentage width
      	cells.
      
              Reviewed by darin
      
              * ForwardingHeaders/rendering/table_layout.h: Added.
              * WebCore.pbproj/project.pbxproj:
              * khtml/css/cssparser.cpp:
              (StyleBaseImpl::parseValue):
              * khtml/css/cssstyleselector.cpp:
              * khtml/css/cssvalues.c:
              (findValue):
              * khtml/css/cssvalues.h:
              * khtml/css/cssvalues.in:
              * khtml/css/html4.css:
              * khtml/dom/html_table.cpp:
              (HTMLTableElement::insertRow):
              (HTMLTableElement::deleteRow):
              (HTMLTableRowElement::insertCell):
              (HTMLTableRowElement::deleteCell):
              (HTMLTableSectionElement::insertRow):
              (HTMLTableSectionElement::deleteRow):
              * khtml/html/html_tableimpl.cpp:
              (HTMLTableElementImpl::HTMLTableElementImpl):
              (HTMLTableElementImpl::setTFoot):
              (HTMLTableElementImpl::setTBody):
              (HTMLTableElementImpl::createTHead):
              (HTMLTableElementImpl::createTFoot):
              (HTMLTableElementImpl::insertRow):
              (HTMLTableElementImpl::deleteRow):
              (HTMLTableElementImpl::addChild):
              (HTMLTableElementImpl::parseAttribute):
              (HTMLTableElementImpl::attach):
              (HTMLTablePartElementImpl::parseAttribute):
              (HTMLTableSectionElementImpl::HTMLTableSectionElementImpl):
              (HTMLTableSectionElementImpl::~HTMLTableSectionElementImpl):
              (HTMLTableSectionElementImpl::insertRow):
              (HTMLTableSectionElementImpl::deleteRow):
              (HTMLTableSectionElementImpl::numRows):
              (HTMLTableRowElementImpl::rowIndex):
              (HTMLTableRowElementImpl::insertCell):
              (HTMLTableRowElementImpl::deleteCell):
              (HTMLTableCellElementImpl::HTMLTableCellElementImpl):
              (HTMLTableCellElementImpl::parseAttribute):
              (HTMLTableCellElementImpl::attach):
              (HTMLTableColElementImpl::HTMLTableColElementImpl):
              (HTMLTableColElementImpl::parseAttribute):
              * khtml/html/html_tableimpl.h:
              * khtml/html/htmlparser.cpp:
              (KHTMLParser::insertNode):
              (KHTMLParser::getElement):
              * khtml/rendering/bidi.cpp:
              (RenderFlow::layoutInlineChildren):
              * khtml/rendering/render_body.cpp:
              (RenderBody::availableHeight):
              * khtml/rendering/render_body.h:
              * khtml/rendering/render_box.cpp:
              (RenderBox::contentWidth):
              (RenderBox::contentHeight):
              (RenderBox::calcReplacedWidth):
              (RenderBox::calcReplacedHeight):
              (RenderBox::availableHeight):
              (RenderBox::calcAbsoluteVertical):
              * khtml/rendering/render_box.h:
              * khtml/rendering/render_flow.cpp:
              (RenderFlow::layoutBlockChildren):
              (RenderFlow::leftOffset):
              (RenderFlow::rightOffset):
              (RenderFlow::addOverHangingFloats):
              (RenderFlow::calcBlockMinMaxWidth):
              (RenderFlow::calcMinMaxWidth):
              * khtml/rendering/render_form.cpp:
              * khtml/rendering/render_form.h:
              * khtml/rendering/render_frames.cpp:
              * khtml/rendering/render_frames.h:
              * khtml/rendering/render_object.cpp:
              (RenderObject::createObject):
              (RenderObject::paddingTop):
              (RenderObject::paddingBottom):
              (RenderObject::paddingLeft):
              (RenderObject::paddingRight):
              * khtml/rendering/render_object.h:
              * khtml/rendering/render_replaced.cpp:
              (RenderReplaced::calcMinMaxWidth):
              * khtml/rendering/render_root.cpp:
              (RenderRoot::RenderRoot):
              (RenderRoot::layout):
              (RenderRoot::paintObject):
              * khtml/rendering/render_root.h:
              * khtml/rendering/render_style.cpp:
              (StyleSurroundData::StyleSurroundData):
              * khtml/rendering/render_style.h:
              * khtml/rendering/render_table.cpp:
              (RenderTable::RenderTable):
              (RenderTable::~RenderTable):
              (RenderTable::setStyle):
              (RenderTable::position):
              (RenderTable::addChild):
              (RenderTable::calcWidth):
              (RenderTable::layout):
              (RenderTable::setCellWidths):
              (RenderTable::paint):
              (RenderTable::calcMinMaxWidth):
              (RenderTable::splitColumn):
              (RenderTable::appendColumn):
              (RenderTable::colElement):
              (RenderTable::recalcSections):
              (RenderTable::removeChildNode):
              (RenderTable::dump):
              (RenderTableSection::RenderTableSection):
              (RenderTableSection::~RenderTableSection):
              (RenderTableSection::detach):
              (RenderTableSection::setStyle):
              (RenderTableSection::addChild):
              (RenderTableSection::ensureRows):
              (RenderTableSection::addCell):
              (RenderTableSection::setCellWidths):
              (RenderTableSection::calcRowHeight):
              (RenderTableSection::layoutRows):
              (RenderTableSection::paint):
              (RenderTableSection::recalcCells):
              (RenderTableSection::clearGrid):
              (RenderTableSection::removeChildNode):
              (RenderTableSection::dump):
              (RenderTableRow::RenderTableRow):
              (RenderTableRow::detach):
              (RenderTableRow::setStyle):
              (RenderTableRow::addChild):
              (RenderTableRow::removeChildNode):
              (RenderTableRow::dump):
              (RenderTableRow::layout):
              (RenderTableCell::RenderTableCell):
              (RenderTableCell::detach):
              (RenderTableCell::updateFromElement):
              (RenderTableCell::getCellPercentageHeight):
              (RenderTableCell::setCellPercentageHeight):
              (RenderTableCell::calcMinMaxWidth):
              (RenderTableCell::baselinePosition):
              (RenderTableCell::setStyle):
              (RenderTableCell::paint):
              (RenderTableCell::paintBoxDecorations):
              (RenderTableCell::dump):
              (RenderTableCol::RenderTableCol):
              (RenderTableCol::updateFromElement):
              (RenderTableCol::addChild):
              (RenderTableCol::dump):
              * khtml/rendering/render_table.h:
              * khtml/rendering/table_layout.cpp: Added.
              (FixedTableLayout::FixedTableLayout):
              (FixedTableLayout::~FixedTableLayout):
              (FixedTableLayout::calcWidthArray):
              (FixedTableLayout::calcMinMaxWidth):
              (FixedTableLayout::layout):
              (AutoTableLayout::AutoTableLayout):
              (AutoTableLayout::~AutoTableLayout):
              (AutoTableLayout::recalcColumn):
              (AutoTableLayout::fullRecalc):
              (AutoTableLayout::calcMinMaxWidth):
              (AutoTableLayout::calcEffectiveWidth):
              (AutoTableLayout::insertSpanCell):
              (AutoTableLayout::layout):
              (AutoTableLayout::calcPercentages):
              * khtml/rendering/table_layout.h: Added.
              * khtml/xml/dom_docimpl.cpp:
              (DocumentImpl::createHTMLElement):
              * khtml/xml/dom_nodeimpl.cpp:
              (NodeImpl::NodeImpl):
              (NodeImpl::dump):
              * khtml/xml/dom_nodeimpl.h:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@3351 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      be02abb2
    • darin's avatar
      Reviewed by Dave. · 1bb17f28
      darin authored
      	- clean room rewrite of QCString::operator<<.
      
              * kwq/KWQCString.mm: (operator<<): Rewrote it.
      
      	- update format of render tree dumping for real use
      
              * khtml/rendering/render_layer.h: Added elementList().
              * khtml/rendering/render_layer.cpp: (RenderLayer::elementList): Added.
      
              * kwq/KWQRenderTreeDebug.cpp:
              (operator<<): Added an overload for writing out QRect.
              (writeIndent): Added.
              (write): Use the overload for QRect, also reorganize to dump layers.
              (writeLayers): Use this to dump the layers.
              (externalRepresentation): Call writeLayers instead of write.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@3350 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      1bb17f28
    • darin's avatar
      Reviewed by Ken. · 1bd92ea0
      darin authored
      	- removed unused KWQDrawUtil code
      
              * ForwardingHeaders/qdrawutil.h: Emptied this file out.
      
              * kwq/KWQDrawUtil.h: Removed.
              * kwq/KWQDrawUtil.mm: Removed.
              * WebCore.pbproj/project.pbxproj: Removed KWQDrawUtil.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@3348 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      1bd92ea0
    • darin's avatar
      WebCore: · 39628ea0
      darin authored
              Reviewed by John.
      
      	- updated copyright to include expat copyrights
      
              * WebCore.pbproj/project.pbxproj: Added expat copyrights on the end.
      	Got text of copyrights from Acknowledgments.rtf in WebBrowser.
      
      WebBrowser:
      
              Reviewed by John.
      
      	- updated acknowledgments to latest text from legal that mentions expat
      
              * Help/English.lproj/Acknowledgments.rtf: New drop from legal.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@3347 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      39628ea0
    • mjs's avatar
      Reviewed by Dave. · 760b2e8f
      mjs authored
      	- fixed 3148141 - crash in KJS::WindowFunc::tryCall leaving certain site
      
              * kwq/KWQKHTMLPart.mm:
              (KWQKHTMLPart::setView): If setting the view to nil and we have a
      	document, detach the document. This means that we are removing a
      	frame from the tree, so we want to run it's onUnload handler now,
      	rather than later when things are no longer fully hooked up.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@3345 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      760b2e8f
  5. 16 Jan, 2003 5 commits
    • rjw's avatar
      Fixed 3148932. Account for zero width characters · 77a985bc
      rjw authored
              in <pre> fixed-width optimization.
      
              Reviewed by hyatt.
      
              * khtml/rendering/render_text.cpp:
              (RenderText::widthFromCache):
      
              Reviewed by Richard (written by Mike S.)  'Clean' implementations of these
              functions that were too similar to the Qt implementations.
      
              * kwq/KWQString.mm:
              (QString::left):
              (QString::right):
              (QString::mid):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@3344 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      77a985bc
    • mjs's avatar
      Reviewed by Darin. · bfdaa330
      mjs authored
      	- fixed 3144771 - Crash in KJS::WindowFunc::tryCall leaving www.smogcheck.org
      
      	I fixed this by making sure we couldn't send the unload event twice, which was
      	happening before in certain circumstances.
      
              * khtml/khtml_part.cpp:
              (KHTMLPart::closeURL): When emitting load event, note that unload
      	event has not yet been sent.
              (KHTMLPart::checkEmitLoadEvent): Note when unload event has been
      	sent to avoid sending it twice.
              * khtml/khtmlpart_p.h:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@3343 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      bfdaa330
    • darin's avatar
      Removed the Safari-49 markers to reduce confusion since · 361e7403
      darin authored
      49 was never used and includes changes that were not in 51.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@3337 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      361e7403
    • darin's avatar
      WebCore: · 615a7e07
      darin authored
              Reviewed by John.
      
      	- added an API for dumping the external representation of the render tree for testing
      
              * kwq/KWQRenderTreeDebug.h: Added.
              * kwq/KWQRenderTreeDebug.cpp: Added.
      
              * kwq/KWQTextStream.h: Added more overloads for operator<<.
              * kwq/KWQTextStream.mm: (QTextStream::operator<<): Implemented them.
      
              * kwq/WebCoreBridge.h: Added renderTreeAsExternalRepresentation.
              * kwq/WebCoreBridge.mm: (-[WebCoreBridge renderTreeAsExternalRepresentation]): Added.
      
      	- removed remnants of an earlier more-naive cut at this same sort of thing
      	- removed ForwardingHeaders from the project since that doesn't really help Project Builder
      
              * kwq/WebCoreTestController.h: Removed.
              * kwq/WebCoreTestController.m: Removed.
              * WebCore.exp: Removed WebCoreTestController.
              * WebCore-combined.exp: Re-generated.
              * WebCore.pbproj/project.pbxproj: Removed WebCoreTestController and ForwardingHeaders.
      
      WebKit:
      
              Reviewed by John.
      
      	- added an API for dumping the external representation of the render tree for testing
      
              * Misc.subproj/WebCoreStatistics.h: Added renderTreeAsExternalRepresentation.
              * Misc.subproj/WebCoreStatistics.m: (-[WebFrame renderTreeAsExternalRepresentation]): Added.
      
      	- removed remnants of an earlier more-naive cut at this same sort of thing
      
              * Misc.subproj/WebTestController.h: Removed.
              * Misc.subproj/WebTestController.m: Removed.
              * WebKit.exp: Removed WebTestController.
              * WebKit.pbproj/project.pbxproj: Removed WebTestController.
      
      	- other changes
      
              * WebCoreSupport.subproj/WebBridge.m: Had added new copyright date to touch a file.
      	That's not needed any more, but the date should be updated anyway.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@3333 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      615a7e07
    • sheridan's avatar
      Safari-52 stamp · de81c91e
      sheridan authored
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@3330 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      de81c91e
  6. 15 Jan, 2003 2 commits
    • trey's avatar
      3144458 - user's credentials are present in a form that is revisited via b/f or history · 2c65ac11
      trey authored
      	We now never save/restore password fields.  Also if the page has a form with a password
      	field that would be submitted securely, we do not save anything on that page.
      
              Reviewed by Darin.
      
              * force-clean-timestamp:  PB isn't smart enough to know what to rebuild.
              * khtml/html/html_formimpl.cpp:
              (HTMLFormElementImpl::formWouldHaveSecureSubmission):  Utility function.
              (HTMLFormElementImpl::attach):  Tell doc if we've added a secure form.
              (HTMLFormElementImpl::parseAttribute):  Tell doc if form became secure.
              (HTMLInputElementImpl::state):  Assert that we never save password fields.
              (HTMLInputElementImpl::restoreState):  Assert that we never restore password fields.
              (HTMLInputElementImpl::attach):  Tell doc if we've added a password field.
              * khtml/html/html_formimpl.h:
              * khtml/xml/dom_docimpl.cpp:
              (DocumentImpl::DocumentImpl):  Init count of secure forms, password fields.
              (DocumentImpl::passwordFieldAdded):
              (DocumentImpl::passwordFieldRemoved):
              (DocumentImpl::hasPasswordField):  New methods to count password fields.
              (DocumentImpl::secureFormAdded):
              (DocumentImpl::secureFormRemoved):
              (DocumentImpl::hasSecureForm):  New methods to count secure forms.
              * khtml/xml/dom_docimpl.h:
              * kwq/KWQKHTMLPart.mm:
              (KWQKHTMLPart::canCachePage):   Never let pages with password fields in the page cache.
              (KWQKHTMLPart::saveDocumentState):  Do not save form state if page has a form with
      	a password field that would be submitted securely
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@3328 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      2c65ac11
    • darin's avatar
      WebCore: · c12a0350
      darin authored
              Reviewed by Ken.
      
      	- fixed problem where Content-Type was coming in with suffixes like "charset"
      
              * kwq/WebCoreBridge.h: Add contentType and refresh parameters, and remove "headers"
      	parameter, from openURL method.
              * kwq/WebCoreBridge.mm:
              (-[WebCoreBridge openURL:reload:contentType:refresh:lastModified:pageCache:]): Get the
      	content type from a parameter, and the refresh header from a separate parameter rather
      	than extracting both from a headers dictionary.
      
      WebKit:
      
              Reviewed by Ken.
      
      	- fixed problem where Content-Type was going into WebCore with suffixes like "charset"
      
              * WebView.subproj/WebDataSourcePrivate.m: (-[WebDataSource _commitIfReady:]):
      	Pass in contentType from the response, rather than the "Content-Type" header.
      	Also pass in the refresh header separately.
      
              * English.lproj/StringsNotToBeLocalized.txt: Updated for above change.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@3326 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      c12a0350
  7. 14 Jan, 2003 4 commits
    • darin's avatar
      Reviewed by Maciej. · 5c611c4d
      darin authored
      	- fixed 3147036 -- words separated only by newlines are getting rammed together on XML page
      	- fixed 3147032 -- preformatted text is missing much whitespace on XML page
      
              * khtml/xml/xml_tokenizer.cpp: (XMLHandler::characters): Don't try to strip whitespace at all,
      	because it needs to be in the DOM.
      
      	- add support for more MIME types
      
              * khtml/khtml_part.cpp: (KHTMLPart::begin): Add "application/xml" and "application/xhtml+xml".
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@3325 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      5c611c4d
    • hyatt's avatar
      Make FOUC work with XML. · bcb09ec8
      hyatt authored
              Reviewed by darin.
      
              * khtml/html/html_baseimpl.cpp:
              (HTMLBodyElementImpl::attach):
              * khtml/xml/dom_xmlimpl.cpp:
              (ProcessingInstructionImpl::ProcessingInstructionImpl):
              (ProcessingInstructionImpl::checkStyleSheet):
              (ProcessingInstructionImpl::isLoading):
              (ProcessingInstructionImpl::sheetLoaded):
              (ProcessingInstructionImpl::setStyleSheet):
              * khtml/xml/dom_xmlimpl.h:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@3322 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      bcb09ec8
    • darin's avatar
      Reviewed by Maciej. · 0bb44c36
      darin authored
      	- first cut at XML parsing with expat
      
              * khtml/khtml_part.cpp: (KHTMLPart::begin): Remove APPLE_CHANGES and use the XML
      	code for text/xml documents.
      
              * WebCore.pbproj/project.pbxproj: Added the ForwardingHeaders to the project.
      	Added new QXml files, removed old ones.
      
              * kwq/KWQXml.h: Removed.
              * kwq/KWQXml.mm: Removed.
      
              * kwq/KWQXmlAttributes.h: Added.
              * kwq/KWQXmlAttributes.mm: Added.
              * kwq/KWQXmlDefaultHandler.h: Added.
              * kwq/KWQXmlDefaultHandler.mm: Added.
              * kwq/KWQXmlSimpleReader.h: Added.
              * kwq/KWQXmlSimpleReader.mm: Added.
      
              * kwq/KWQString.h: Add fromUtf8 functions.
              * kwq/KWQString.mm: (QString::fromUtf8): Added. Simple implementation just
      	calls fromStringWithEncoding. We may need something more efficient later,
      	at least for all-ASCII text.
      
      	- other changes
      
              * khtml/khtml_part.h: Fix spelling of occurrence.
      
              * khtml/misc/decoder.cpp: (Decoder::decode): Turn on Japanese auto-detect.
      	It doesn't seem to work yet, but this does no harm.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@3321 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      0bb44c36
    • rjw's avatar
      Fix for 3139120. This patch was contributed by Mitz Pettel. It correctly · 2028aa44
      rjw authored
              handles the visually ordered encodings.  The patch also picks up changes
              from kde that accounts for european numbers correctly in bidiReorderLine().
      
              Reviewed by Dave.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@3319 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      2028aa44
  8. 13 Jan, 2003 1 commit
    • darin's avatar
      Reviewed by Ken. · 908cf2a7
      darin authored
      	- fixed 3143781 -- submitting the same form twice doesn't work properly
      	(example at directory.apple.com)
      
              * kwq/KWQKHTMLPart.mm: (KWQKHTMLPart::submitForm): Only run the "don't submit the same
      	form twice" logic when the form is one that affects the frame that the form is in.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@3314 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      908cf2a7
  9. 12 Jan, 2003 5 commits
    • darin's avatar
      * WebCorePrefix.h: Needed to touch this file since we now have plain C source (expat). · 767b3718
      darin authored
              * kwq/KWQKHTMLPart.cpp: Reformatted a bit.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@3312 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      767b3718
    • darin's avatar
      Reviewed by Maciej. · 68877da7
      darin authored
      	- first step towards integrating expat for XML support: make it compile and link
      
              * kwq/KWQXml.mm: (QXmlSimpleReader::parse): Put in a placeholder that calls expat.
      	Mainly just used to make sure we link.
      
              * WebCore.pbproj/project.pbxproj: Added expat files.
      
              * expat/COPYING: Added.
              * expat/Changes: Added.
              * expat/MANIFEST: Added.
              * expat/README: Added.
              * expat/expat_config.h: Added.
              * expat/lib/ascii.h: Added.
              * expat/lib/asciitab.h: Added.
              * expat/lib/expat.h: Added.
              * expat/lib/iasciitab.h: Added.
              * expat/lib/internal.h: Added.
              * expat/lib/latin1tab.h: Added.
              * expat/lib/nametab.h: Added.
              * expat/lib/utf8tab.h: Added.
              * expat/lib/xmlparse.c: Added.
              * expat/lib/xmlrole.c: Added.
              * expat/lib/xmlrole.h: Added.
              * expat/lib/xmltok.c: Added.
              * expat/lib/xmltok.h: Added.
              * expat/lib/xmltok_impl.c: Added.
              * expat/lib/xmltok_impl.h: Added.
              * expat/lib/xmltok_ns.c: Added.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@3308 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      68877da7
    • darin's avatar
      Reviewed by Dave. · d8d3bd9d
      darin authored
      	- minor cleanup of plug-in-related classes in ECMA directory
      
              * khtml/ecma/kjs_navigator.cpp: Remove unneeded PluginBase member functions
      	ref() and deref(). Instead just make Plugin and MimeType both derive from
      	PluginBase and remove APPLE_CHANGES.
              (Navigator::getValueProperty): Don't use "Konqueror" for the fallback.
      	Just return Undefined() for that case since we will never reach it anyway.
      
      	- simplify the logic in khtmlMoveMouseEvent so it's easier to decipher
      
              * kwq/KWQKHTMLPart.mm: (KWQKHTMLPart::khtmlMouseMoveEvent): By merging two
      	identical if statements, the logic of this function becomes much clearer.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@3305 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      d8d3bd9d
    • darin's avatar
      Reviewed by Dave. · 50560aa1
      darin authored
      	- fixed a bunch of places where KHTML did !x == y instead of !(x == y) or x != y.
      
              * khtml/css/cssstyleselector.cpp: (CSSStyleSelector::applyRule):
              * khtml/html/htmlparser.cpp: (KHTMLParser::insertNode):
              * khtml/misc/loader.cpp: (Cache::requestImage), (Cache::requestStyleSheet):
              * khtml/rendering/render_flow.cpp: (RenderFlow::setStyle):
      	Changed !x == y to x != y. In each case, there's a reason that this does not create
      	any problem in practice, which is why we didn't rush to get this in for beta 1.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@3304 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      50560aa1
    • darin's avatar
      Reviewed by John. · 895eae19
      darin authored
      	- fixed 3144789 -- reproducible crash in KHTMLParser::freeBlock on a page at www.library.arizona.edu
      
              * khtml/html/htmlparser.cpp: (KHTMLParser::finished): Call freeBlock here rather than
      	waiting until the parser is destroyed. This fixes the bug because when the parser is
              destroyed, the document is already destroyed, so we have a dangling current pointer to an
      	already-destroyed node.
      
      	- fixed 3142024 -- crash/hang/assert on java.sun.com in HTMLTokenizer
      
      	The bug was caused by an erroneous clicked signal that was being emitted by
      	QListBox at just the wrong time.
      
              * kwq/KWQListBox.h: Added _changingSelection boolean.
              * kwq/KWQListBox.mm: (QListBox::QListBox): Set _changingSelection to false.
              (QListBox::setSelected): Set _changingSelection to true.
              (-[KWQListBoxTableViewDelegate tableViewSelectionDidChange:]): Only emit the "clicked"
      	signal if _changingSelection is false.
      
              * khtml/html/htmltokenizer.h: Add debug-only boolean inWrite.
              * khtml/html/htmltokenizer.cpp: (HTMLTokenizer::HTMLTokenizer): Set inWrite to false.
      	(HTMLTokenizer::write): Set inWrite to true.
      	(HTMLTokenizer::~HTMLTokenizer): Assert that inWrite is not true.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@3303 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      895eae19
  10. 11 Jan, 2003 1 commit
    • darin's avatar
      Reviewed by Dave. · c935e41a
      darin authored
      	- fixed 3136944 -- mouseover feedback over non-mapped part of image map claims
      	link to current page
      
              * kwq/WebCoreBridge.mm: (-[WebCoreBridge elementAtPoint:]):
      	Change code so we won't call completeURL and complete a null ATTR_HREF (which is distinct
      	from an empty ATTR_HREF). Did a similar cleanup on the image code.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@3301 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      c935e41a
  11. 10 Jan, 2003 1 commit
    • darin's avatar
      JavaScriptCore: · 33188225
      darin authored
              * JavaScriptCore.pbproj/project.pbxproj: Add the year 2003, remove CFBundleIconFile,
      	bump marketing version to 0.8.1 and version to 52u to keep up with the branch,
      	remove CFHumanReadableCopyright, remove NSPrincipalClass.
      
              * English.lproj/InfoPlist.strings: Updated to match above changes.
      
      WebFoundation:
      
              * WebFoundation.pbproj/project.pbxproj: Add the year 2003, remove CFBundleIconFile,
      	bump marketing version to 0.8.1 and version to 52u to keep up with the branch,
      	remove NSHumanReadableCopyright, remove NSPrincipalClass.
      
              * English.lproj/InfoPlist.strings: Update to match above.
      
      WebCore:
      
              * WebCore.pbproj/project.pbxproj: Add the year 2003, remove CFBundleIconFile,
      	bump marketing version to 0.8.1 and version to 52u to keep up with the branch,
      	remove NSHumanReadableCopyright, remove NSPrincipalClass, remove SKIP_INSTALL
      	that was in the Info plist instead of project settings.
      
              * English.lproj/InfoPlist.strings: Update to match above.
      
      WebKit:
      
              * WebKit.pbproj/project.pbxproj: Add the year 2003, remove CFBundleIconFile,
      	bump marketing version to 0.8.1 and version to 52u to keep up with the branch,
      	remove CFHumanReadableCopyright, remove NSPrincipalClass.
      
              * English.lproj/InfoPlist.strings: Updated to match above changes.
      
      WebBrowser:
      
              * WebBrowser.pbproj/project.pbxproj: Add 2003 to copyright, bump versions
      	to 0.8.1 and 52u to keep up with the branch.
      
              * English.lproj/InfoPlist.strings: Update to match above.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@3300 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      33188225
  12. 09 Jan, 2003 4 commits
  13. 08 Jan, 2003 3 commits
    • cblu's avatar
      WebCore: · 0ce577a1
      cblu authored
      	Fixed: 3111432 - Support OBJECT tags with type text/plain or text/html
      
              Reviewed by dave.
      
              * kwq/KWQKHTMLPart.mm:
              (KWQKHTMLPart::createPart): call [_bridge frameRequiredForMIMEType:] to determine if we should create a plug-in view or iframe
              * kwq/WebCoreBridge.h: add frameRequiredForMIMEType:
      
      WebKit:
      
      	Fixed: 3111432 - Support OBJECT tags with type text/plain or text/html
      
              Reviewed by dave.
      
              * WebCoreSupport.subproj/WebBridge.m:
              (-[WebBridge frameRequiredForMIMEType:]): added, returns YES for non-plug-in views
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@3279 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      0ce577a1
    • trey's avatar
      3136213 - Page loads stopped by backtracking don't finish when moving forward · 8807f2f1
      trey authored
      	We need to remove the entry from the KHTML image cache when a load
      	has an error, so it will be reloaded next time we try.
      
              Reviewed by Darin,
      
              * khtml/misc/loader.cpp:
              (Loader::slotFinished):  Remove cache entry on job error.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@3278 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      8807f2f1
    • darin's avatar
      Reviewed by Dave. · e94e43ff
      darin authored
      	- fixed 96/72 dpi snafu; no need to do something different for AppKit,
                because it always uses pixel sizes, not font size
      
              * khtml/css/css_valueimpl.cpp:
              * khtml/css/css_valueimpl.h:
              * khtml/css/cssstyleselector.cpp:
              * kwq/KWQPaintDeviceMetrics.mm:
      	Rolled out change from 2002-12-05
      
      	- a cut at implementing heretofore unimplemented QTextStream classes
      
              * kwq/KWQTextStream.h:
              * kwq/KWQTextStream.mm:
      	First cut implementation.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@3277 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      e94e43ff