- 01 Jul, 2011 40 commits
-
-
commit-queue@webkit.org authored
Reviewed by Oliver Hunt. Lexer error messages are currently appalling https://bugs.webkit.org/show_bug.cgi?id=63340 Updated expected test results. * fast/js/basic-strict-mode-expected.txt: * fast/js/kde/parse-expected.txt: * fast/js/kde/string-1-n-expected.txt: * fast/js/kde/string-2-n-expected.txt: * fast/js/numeric-escapes-in-string-literals-expected.txt: * fast/js/removing-Cf-characters-expected.txt: * fast/regex/non-pattern-characters-expected.txt: * http/tests/websocket/tests/bad-sub-protocol-control-chars-expected.txt: * loader/reload-subresource-when-type-changes-expected.txt: * sputnik/Conformance/07_Lexical_Conventions/7.3_Line_Terminators/S7.3_A2.1_T1-expected.txt: * sputnik/Conformance/07_Lexical_Conventions/7.3_Line_Terminators/S7.3_A2.1_T2-expected.txt: * sputnik/Conformance/07_Lexical_Conventions/7.3_Line_Terminators/S7.3_A2.2_T1-expected.txt: * sputnik/Conformance/07_Lexical_Conventions/7.3_Line_Terminators/S7.3_A2.2_T2-expected.txt: * sputnik/Conformance/07_Lexical_Conventions/7.3_Line_Terminators/S7.3_A2.3-expected.txt: * sputnik/Conformance/07_Lexical_Conventions/7.3_Line_Terminators/S7.3_A2.4-expected.txt: * sputnik/Conformance/07_Lexical_Conventions/7.4_Comments/S7.4_A2_T2-expected.txt: * sputnik/Conformance/07_Lexical_Conventions/7.8_Literals/7.8.3_Numeric_Literals/S7.8.3_A6.1_T1-expected.txt: * sputnik/Conformance/07_Lexical_Conventions/7.8_Literals/7.8.3_Numeric_Literals/S7.8.3_A6.1_T2-expected.txt: * sputnik/Conformance/07_Lexical_Conventions/7.8_Literals/7.8.3_Numeric_Literals/S7.8.3_A6.2_T1-expected.txt: * sputnik/Conformance/07_Lexical_Conventions/7.8_Literals/7.8.3_Numeric_Literals/S7.8.3_A6.2_T2-expected.txt: * sputnik/Conformance/07_Lexical_Conventions/7.8_Literals/7.8.4_String_Literals/S7.8.4_A1.1_T1-expected.txt: * sputnik/Conformance/07_Lexical_Conventions/7.8_Literals/7.8.4_String_Literals/S7.8.4_A1.1_T2-expected.txt: * sputnik/Conformance/07_Lexical_Conventions/7.8_Literals/7.8.4_String_Literals/S7.8.4_A1.2_T1-expected.txt: * sputnik/Conformance/07_Lexical_Conventions/7.8_Literals/7.8.4_String_Literals/S7.8.4_A1.2_T2-expected.txt: * sputnik/Conformance/07_Lexical_Conventions/7.8_Literals/7.8.4_String_Literals/S7.8.4_A3.1_T1-expected.txt: * sputnik/Conformance/07_Lexical_Conventions/7.8_Literals/7.8.4_String_Literals/S7.8.4_A3.1_T2-expected.txt: * sputnik/Conformance/07_Lexical_Conventions/7.8_Literals/7.8.4_String_Literals/S7.8.4_A3.2_T1-expected.txt: * sputnik/Conformance/07_Lexical_Conventions/7.8_Literals/7.8.4_String_Literals/S7.8.4_A3.2_T2-expected.txt: * sputnik/Conformance/07_Lexical_Conventions/7.8_Literals/7.8.4_String_Literals/S7.8.4_A7.1_T4-expected.txt: * sputnik/Conformance/07_Lexical_Conventions/7.8_Literals/7.8.4_String_Literals/S7.8.4_A7.2_T1-expected.txt: * sputnik/Conformance/07_Lexical_Conventions/7.8_Literals/7.8.4_String_Literals/S7.8.4_A7.2_T2-expected.txt: * sputnik/Conformance/07_Lexical_Conventions/7.8_Literals/7.8.4_String_Literals/S7.8.4_A7.2_T3-expected.txt: * sputnik/Conformance/07_Lexical_Conventions/7.8_Literals/7.8.4_String_Literals/S7.8.4_A7.2_T4-expected.txt: * sputnik/Conformance/07_Lexical_Conventions/7.8_Literals/7.8.4_String_Literals/S7.8.4_A7.2_T5-expected.txt: * sputnik/Conformance/07_Lexical_Conventions/7.8_Literals/7.8.4_String_Literals/S7.8.4_A7.2_T6-expected.txt: * sputnik/Conformance/07_Lexical_Conventions/7.8_Literals/7.8.5_Regular_Expression_Literals/S7.8.5_A1.2_T1-expected.txt: * sputnik/Conformance/08_Types/8.4_The_String_Type/S8.4_A13_T1-expected.txt: * sputnik/Conformance/08_Types/8.4_The_String_Type/S8.4_A13_T2-expected.txt: * sputnik/Conformance/08_Types/8.4_The_String_Type/S8.4_A14_T1-expected.txt: * sputnik/Conformance/08_Types/8.4_The_String_Type/S8.4_A14_T2-expected.txt: 2011-07-01 Juan C. Montemayor <jmont@apple.com> Reviewed by Oliver Hunt. Lexer error messages are currently appalling https://bugs.webkit.org/show_bug.cgi?id=63340 Added error messages for the Lexer. These messages will be displayed instead of the lexer error messages from the parser that are currently shown. * parser/Lexer.cpp: (JSC::Lexer::getInvalidCharMessage): (JSC::Lexer::setCode): (JSC::Lexer::parseString): (JSC::Lexer::lex): (JSC::Lexer::clear): * parser/Lexer.h: (JSC::Lexer::getErrorMessage): (JSC::Lexer::setOffset): * parser/Parser.cpp: (JSC::Parser::parse): git-svn-id: http://svn.webkit.org/repository/webkit/trunk@90265 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
aroben@apple.com authored
Fixes <http://webkit.org/b/63833> TestFailures page causes a bunch of spew in the Inspector's console about unsafe headers Reviewed by Dan Bates. * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Utilities.js: (fetchResource): Removed unnecessary code to set Content-Length and Connection headers. git-svn-id: http://svn.webkit.org/repository/webkit/trunk@90264 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
abarth@webkit.org authored
Reviewed by Adam Barth. Switch Snow Leopard over to new-run-webkit-tests (except for wk2) https://bugs.webkit.org/show_bug.cgi?id=63786 We're down to one bug blocking the "move to NRWT" bug: https://bugs.webkit.org/show_bug.cgi?id=34984 so we're trying transitioning Snow Leopard to NRWT as an experiment. If we run into any blocking issues we'll of course roll this back out (or anyone reading this should feel encouraged to). * Scripts/run-webkit-tests: git-svn-id: http://svn.webkit.org/repository/webkit/trunk@90263 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
abarth@webkit.org authored
Add a compat shim for --leaks. Support for --leaks will be added in https://bugs.webkit.org/show_bug.cgi?id=63832. * Scripts/webkitpy/layout_tests/run_webkit_tests.py: git-svn-id: http://svn.webkit.org/repository/webkit/trunk@90262 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
aroben@apple.com authored
The failure is tracked by <http://webkit.org/b/63829>. * platform/mac-leopard/media/media-blocked-by-beforeload-expected.txt: Added. git-svn-id: http://svn.webkit.org/repository/webkit/trunk@90261 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
vangelis@chromium.org authored
Reviewed by James Robinson. [chromium] Reserve all tile textures at layer update time to guarantee that they will be available at draw time. https://bugs.webkit.org/show_bug.cgi?id=63760 In addition, this patch unreserves textures used by RenderSurface's right after the RenderSurface has been used to free up memory for subsequent RenderSurfaces. This patch also "fixes" the pages that display a blue background when running out of texture memory as the root layer tiles get reserved first and are guaranteed to get textures. * platform/graphics/chromium/ContentLayerChromium.cpp: (WebCore::ContentLayerChromium::ContentLayerChromium): (WebCore::ContentLayerChromium::visibleLayerRect): (WebCore::ContentLayerChromium::setIsMask): * platform/graphics/chromium/ContentLayerChromium.h: * platform/graphics/chromium/ImageLayerChromium.cpp: (WebCore::ImageLayerChromium::paintContentsIfDirty): * platform/graphics/chromium/LayerRendererChromium.cpp: (WebCore::LayerRendererChromium::paintLayerContents): (WebCore::LayerRendererChromium::drawLayer): (WebCore::LayerRendererChromium::initializeSharedObjects): * platform/graphics/chromium/LayerTexture.cpp: (WebCore::LayerTexture::unreserve): * platform/graphics/chromium/LayerTexture.h: * platform/graphics/chromium/LayerTilerChromium.cpp: (WebCore::LayerTilerChromium::prepareToUpdate): (WebCore::LayerTilerChromium::updateRect): (WebCore::LayerTilerChromium::drawTiles): * platform/graphics/chromium/RenderSurfaceChromium.cpp: (WebCore::RenderSurfaceChromium::releaseContentsTexture): * platform/graphics/chromium/RenderSurfaceChromium.h: * platform/graphics/chromium/TextureManager.cpp: (WebCore::TextureManager::unprotectTexture): * platform/graphics/chromium/TextureManager.h: git-svn-id: http://svn.webkit.org/repository/webkit/trunk@90260 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
jshin@chromium.org authored
Reviewed by Alexey Proskuryakov. Add ScriptCodesFromICU.h to wtf/unicode and make necessary changes in build files for ports not using ICU. Add icu/unicode/uscript.h for ports using ICU. It's taken from ICU 3.6 (the version used on Mac OS 10.5) http://bugs.webkit.org/show_bug.cgi?id=20797 * GNUmakefile.list.am: * JavaScriptCore.gypi: * icu/unicode/uscript.h: Added for UScriptCode enum. * wtf/unicode/ScriptCodesFromICU.h: UScriptCode enum added. * wtf/unicode/icu/UnicodeIcu.h: * wtf/unicode/brew/UnicodeBrew.h: * wtf/unicode/glib/UnicodeGLib.h: * wtf/unicode/qt4/UnicodeQt4.h: * wtf/unicode/wince/UnicodeWinCE.h: 2011-07-01 Jungshik Shin <jshin@chromium.org> Reviewed by Alexey Proskuryakov. Add uscript.h to icu/unicode to get JavaScriptGlue get built. The same file was added to JavaScriptCore/icu/unicode. http://bugs.webkit.org/show_bug.cgi?id=20797 * icu/unicode/uscript.h: Added. 2011-07-01 Jungshik Shin <jshin@chromium.org> Reviewed by Alexey Proskuryakov. Allow generic font family settings per script code. https://bugs.webkit.org/show_bug.cgi?id=20797 Make generic font family getters/setters accept an additional argument (script code). It has a default value so that if an embedder does not have/want a per-script font family setting, call-sites don't have to be changed. This is to prepare for fixing bug 10874 (font selection is not language-dependent) and bug 18085. uscript.h has been updated to that of ICU 3.6 (the version of ICU on Mac OS 10.5) There should be no change in layout and no new layout test is added. * WebCore.exp.in: * icu/unicode/uscript.h: updated to ICU 4.6 * page/Settings.cpp: (WebCore::setGenericFontFamilyMap): helper to set generic family per script (WebCore::getGenericFontFamilyForScript): helper function used by getters for fooFontFamily. (WebCore::Settings::standardFontFamily): (WebCore::Settings::setStandardFontFamily): (WebCore::Settings::fixedFontFamily): (WebCore::Settings::setFixedFontFamily): (WebCore::Settings::serifFontFamily): (WebCore::Settings::setSerifFontFamily): (WebCore::Settings::sansSerifFontFamily): (WebCore::Settings::setSansSerifFontFamily): (WebCore::Settings::cursiveFontFamily): (WebCore::Settings::setCursiveFontFamily): (WebCore::Settings::fantasyFontFamily): (WebCore::Settings::setFantasyFontFamily): * page/Settings.h: setter and getter for FooFontFamily have a new optional argument, scriptCode. git-svn-id: http://svn.webkit.org/repository/webkit/trunk@90259 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
kbalazs@webkit.org authored
[Qt][WK2] netscape-dom-access.html needs new result https://bugs.webkit.org/show_bug.cgi?id=63454 * platform/qt-wk2/Skipped: * platform/qt-wk2/plugins/netscape-dom-access-expected.txt: Added. git-svn-id: http://svn.webkit.org/repository/webkit/trunk@90258 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
kbalazs@webkit.org authored
Unreviewed, rolling out r90254. http://trac.webkit.org/changeset/90254 https://bugs.webkit.org/show_bug.cgi?id=63825 "committed with a totally broken changelog" (Requested by kbalazs on #webkit). * platform/qt-wk2/Skipped: * platform/qt-wk2/plugins/netscape-dom-access-expected.txt: Removed. git-svn-id: http://svn.webkit.org/repository/webkit/trunk@90257 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
kbalazs@webkit.org authored
Reviewed by Tony Chang. IndexedDB: Fix constants for webkitIDBTransaction.READ_WRITE/READ_ONLY https://bugs.webkit.org/show_bug.cgi?id=63754 Update layout tests to use the right values for webkitIDBTransaction.READ_WRITE/READ_ONLY. * storage/indexeddb/constants-expected.txt: * storage/indexeddb/constants.html: git-svn-id: http://svn.webkit.org/repository/webkit/trunk@90254 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
tony@chromium.org authored
Reviewed by Ojan Vafai. rename StyleFlexibleBoxData to StyleDeprecatedFlexibleBoxData https://bugs.webkit.org/show_bug.cgi?id=63773 We will have a similar struct to hold CSS3 flexible box data, so this makes way for the new class. I will rename the member variable in RenderStyle.h in a follow up change. * CMakeLists.txt: * GNUmakefile.list.am: * WebCore.gypi: * WebCore.order: * WebCore.pro: * WebCore.vcproj/WebCore.vcproj: * WebCore.xcodeproj/project.pbxproj: * rendering/style/RenderStyle.h: * rendering/style/StyleAllInOne.cpp: * rendering/style/StyleDeprecatedFlexibleBoxData.cpp: (WebCore::StyleDeprecatedFlexibleBoxData::StyleDeprecatedFlexibleBoxData): (WebCore::StyleDeprecatedFlexibleBoxData::operator==): * rendering/style/StyleDeprecatedFlexibleBoxData.h: (WebCore::StyleDeprecatedFlexibleBoxData::create): (WebCore::StyleDeprecatedFlexibleBoxData::copy): (WebCore::StyleDeprecatedFlexibleBoxData::operator!=): * rendering/style/StyleRareNonInheritedData.h: git-svn-id: http://svn.webkit.org/repository/webkit/trunk@90253 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
hans@chromium.org authored
Reviewed by Tony Chang. IndexedDB: Fix constants for webkitIDBTransaction.READ_WRITE/READ_ONLY https://bugs.webkit.org/show_bug.cgi?id=63754 Update layout tests to use the right values for webkitIDBTransaction.READ_WRITE/READ_ONLY. * storage/indexeddb/constants-expected.txt: * storage/indexeddb/constants.html: 2011-07-01 Hans Wennborg <hans@chromium.org> Reviewed by Tony Chang. IndexedDB: Fix constants for webkitIDBTransaction.READ_WRITE/READ_ONLY https://bugs.webkit.org/show_bug.cgi?id=63754 Fix values for the webkitIDBTransaction.READ_WRITE/READ_ONLY constants. Douglas Stockwell pointed out that these were reverse of what the spec says. * storage/IDBTransaction.h: * storage/IDBTransaction.idl: git-svn-id: http://svn.webkit.org/repository/webkit/trunk@90252 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
paroga@webkit.org authored
Reviewed by Daniel Bates. [CMake] Add cpu detection for MIPS https://bugs.webkit.org/show_bug.cgi?id=63693 * Source/CMakeLists.txt: git-svn-id: http://svn.webkit.org/repository/webkit/trunk@90251 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
leviw@chromium.org authored
Reviewed by Eric Seidel. Switch positionForPoint to new layout types https://bugs.webkit.org/show_bug.cgi?id=63774 Switching positionForPoint functions to new layout unit abstraction. No new tests, no functionality changes. * rendering/RenderBR.cpp: (WebCore::RenderBR::positionForPoint): * rendering/RenderBR.h: * rendering/RenderBlock.cpp: (WebCore::RenderBlock::positionForPoint): * rendering/RenderBlock.h: * rendering/RenderBox.cpp: (WebCore::RenderBox::positionForPoint): * rendering/RenderBox.h: * rendering/RenderFileUploadControl.cpp: (WebCore::RenderFileUploadControl::positionForPoint): * rendering/RenderFileUploadControl.h: * rendering/RenderInline.cpp: (WebCore::RenderInline::positionForPoint): * rendering/RenderInline.h: * rendering/RenderObject.cpp: (WebCore::RenderObject::positionForPoint): * rendering/RenderReplaced.cpp: (WebCore::RenderReplaced::positionForPoint): * rendering/RenderReplaced.h: * rendering/RenderText.cpp: (WebCore::RenderText::positionForPoint): * rendering/RenderText.h: * rendering/RenderTextControlSingleLine.cpp: (WebCore::RenderTextControlInnerBlock::positionForPoint): * rendering/RenderTextControlSingleLine.h: * rendering/svg/RenderSVGInlineText.cpp: (WebCore::RenderSVGInlineText::positionForPoint): * rendering/svg/RenderSVGInlineText.h: * rendering/svg/RenderSVGText.cpp: (WebCore::RenderSVGText::positionForPoint): * rendering/svg/RenderSVGText.h: git-svn-id: http://svn.webkit.org/repository/webkit/trunk@90250 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
scherkus@chromium.org authored
Reviewed by Darin Fisher. Re-enable WTF_USE_WEBAUDIO_FFMPEG for Chromium https://bugs.webkit.org/show_bug.cgi?id=63783 * features.gypi: 2011-07-01 Andrew Scherkus <scherkus@chromium.org> Reviewed by Darin Fisher. Re-enable WTF_USE_WEBAUDIO_FFMPEG for Chromium https://bugs.webkit.org/show_bug.cgi?id=63783 * WebCore.gyp/WebCore.gyp: git-svn-id: http://svn.webkit.org/repository/webkit/trunk@90249 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
paroga@webkit.org authored
Reviewed by Daniel Bates. [CMake] Don't compile unused bindings https://bugs.webkit.org/show_bug.cgi?id=63741 * UseJSC.cmake: Added IF (ENABLE_XXX) around files. git-svn-id: http://svn.webkit.org/repository/webkit/trunk@90248 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
barraclough@apple.com authored
Escaping of forwardslashes in strings incorrect if multiple exist. Reviewed by Sam Weinig. Source/JavaScriptCore: The bug is in the parameters passed to a substring - should be start & length, but we're passing start & end indices! * runtime/RegExpObject.cpp: (JSC::regExpObjectSource): LayoutTests: Add tests with multiple forward slashes. * fast/regex/script-tests/toString.js: * fast/regex/toString-expected.txt: git-svn-id: http://svn.webkit.org/repository/webkit/trunk@90247 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
abarth@webkit.org authored
Reviewed by Darin Adler. ReportCrash destabilizes new-run-webkit-tests https://bugs.webkit.org/show_bug.cgi?id=63795 ReportCrash chews up too many system resources that it destablizes tests run concurrently. This patch causes us to spin down all the worker processes when ReportCrash is running. Also, this patch causes the master process to tell the user we're waiting for the crash reporter rather than having that be the worker's job. This stops the user from getting spammed with too many "waiting for crash reporter" messages and also cleans up some minor UI issues with the meter. * Scripts/webkitpy/layout_tests/layout_package/manager.py: * Scripts/webkitpy/layout_tests/layout_package/single_test_runner.py: * Scripts/webkitpy/layout_tests/port/base.py: * Scripts/webkitpy/layout_tests/port/server_process.py: git-svn-id: http://svn.webkit.org/repository/webkit/trunk@90246 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
tony@chromium.org authored
Fix the chromium build. sql is a new top level directory. * DEPS: git-svn-id: http://svn.webkit.org/repository/webkit/trunk@90245 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
rniwa@webkit.org authored
Rolled DEPS. * DEPS: git-svn-id: http://svn.webkit.org/repository/webkit/trunk@90244 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
mihaip@chromium.org authored
Add failing test expectations for Chromium media tests on Windows 7 and Vista. * platform/chromium/test_expectations.txt: git-svn-id: http://svn.webkit.org/repository/webkit/trunk@90243 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
kbalazs@webkit.org authored
Reviewed by Andreas Kling. [Qt][WK2] Clean up skipped list https://bugs.webkit.org/show_bug.cgi?id=61644 * platform/qt-wk2/Skipped: Remove everything that we skip via the common wk2 list. git-svn-id: http://svn.webkit.org/repository/webkit/trunk@90242 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
aroben@apple.com authored
Roll out r90194 http://trac.webkit.org/changeset/90194 https://bugs.webkit.org/show_bug.cgi?id=63778 Fixes <http://webkit.org/b/63812> REGRESSION (r90194): Multiple tests intermittently failing assertions in WriteBarrierBase<JSC::Structure>::get * runtime/JSCell.h: (JSC::JSCell::JSCell::~JSCell): git-svn-id: http://svn.webkit.org/repository/webkit/trunk@90241 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
joone.hur@collabora.co.uk authored
Reviewed by Martin Robinson. [GTK] Add DeviceOrientation feature https://bugs.webkit.org/show_bug.cgi?id=63720 Add configure option to enable/disable DeviceOrientation feature. * configure.ac: 2011-07-01 Joone Hur <joone.hur@collabora.co.uk> Reviewed by Martin Robinson. [GTK] Add DeviceOrientation feature https://bugs.webkit.org/show_bug.cgi?id=63720 Add DeviceMotionClientGtk.cpp and DeviceOrientationClientGtk.cpp to WebKitGtk+ build. * GNUmakefile.am: Add DeviceMotionClientGtk.cpp, DeviceOrientationClientGtk.cpp. 2011-07-01 Joone Hur <joone.hur@collabora.co.uk> Reviewed by Martin Robinson. [GTK] Add DeviceOrientation feature https://bugs.webkit.org/show_bug.cgi?id=63720 Add empty implementation of DeviceMotionClient and DeviceOrientationClient callback methods. * GNUmakefile.am: * WebCoreSupport/DeviceMotionClientGtk.cpp: Added. (WebCore::DeviceMotionClientGtk::DeviceMotionClientGtk): (WebCore::DeviceMotionClientGtk::~DeviceMotionClientGtk): (WebCore::DeviceMotionClientGtk::deviceMotionControllerDestroyed): (WebCore::DeviceMotionClientGtk::setController): (WebCore::DeviceMotionClientGtk::startUpdating): (WebCore::DeviceMotionClientGtk::stopUpdating): (WebCore::DeviceMotionClientGtk::currentDeviceMotion): * WebCoreSupport/DeviceMotionClientGtk.h: Added. * WebCoreSupport/DeviceOrientationClientGtk.cpp: Added. (WebCore::DeviceOrientationClientGtk::DeviceOrientationClientGtk): (WebCore::DeviceOrientationClientGtk::~DeviceOrientationClientGtk): (WebCore::DeviceOrientationClientGtk::deviceOrientationControllerDestroyed): (WebCore::DeviceOrientationClientGtk::setController): (WebCore::DeviceOrientationClientGtk::startUpdating): (WebCore::DeviceOrientationClientGtk::stopUpdating): (WebCore::DeviceOrientationClientGtk::lastOrientation): * WebCoreSupport/DeviceOrientationClientGtk.h: Added. * webkit/webkitwebview.cpp: (webkit_web_view_init): git-svn-id: http://svn.webkit.org/repository/webkit/trunk@90240 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
aroben@apple.com authored
r90229 moved the "Need a short description and bug URL" line to the top of the ChangeLog template. But webkitpy didn't know this, so the various rollout-related commands were leaving that line in the ChangeLog. Fixes <http://webkit.org/b/63815> REGRESSION (r90229): webkit-patch rollout and sheriffbot rollout are broken Reviewed by Dan Bates. * Scripts/webkitpy/common/checkout/changelog.py: (ChangeLog.update_with_unreviewed_message): Changed to look for the "Need a short description and bug URL" line instead of the "Reviewed by" line as the first line of the ChangeLog template. * Scripts/webkitpy/common/checkout/changelog_unittest.py: (ChangeLogTest): Updated _new_entry_boilerplate to match what prepare-ChangeLog now generates. git-svn-id: http://svn.webkit.org/repository/webkit/trunk@90239 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
bweinstein@apple.com authored
cancelled by willSendRequest https://bugs.webkit.org/show_bug.cgi?id=63753 Reviewed by Darin Adler. Source/WebKit2: When deciding a policy for a null request, call the callback that was passed to WebKit2 and say that we used the loader. * WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp: (WebKit::WebFrameLoaderClient::dispatchDecidePolicyForResponse): LayoutTests: Unskip WebKit2 tests that now pass. * platform/wk2/Skipped: git-svn-id: http://svn.webkit.org/repository/webkit/trunk@90238 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
oliver@apple.com authored
Reviewed by Gavin Barraclough. Add optimised paths for a few maths functions https://bugs.webkit.org/show_bug.cgi?id=63757 Relanding as a Mac only patch. This adds specialised thunks for Math.abs, Math.round, Math.ceil, Math.floor, Math.log, and Math.exp as they are apparently more important in real web content than we thought, which is somewhat mind-boggling. On average doubles the performance of the common cases (eg. actually passing numbers in). They're not as efficient as they could be, but this way gives them the most portability. * assembler/MacroAssemblerARM.h: (JSC::MacroAssemblerARM::supportsDoubleBitops): (JSC::MacroAssemblerARM::andnotDouble): * assembler/MacroAssemblerARMv7.h: (JSC::MacroAssemblerARMv7::supportsDoubleBitops): (JSC::MacroAssemblerARMv7::andnotDouble): * assembler/MacroAssemblerMIPS.h: (JSC::MacroAssemblerMIPS::andnotDouble): (JSC::MacroAssemblerMIPS::supportsDoubleBitops): * assembler/MacroAssemblerSH4.h: (JSC::MacroAssemblerSH4::supportsDoubleBitops): (JSC::MacroAssemblerSH4::andnotDouble): * assembler/MacroAssemblerX86.h: (JSC::MacroAssemblerX86::supportsDoubleBitops): * assembler/MacroAssemblerX86Common.h: (JSC::MacroAssemblerX86Common::andnotDouble): * assembler/MacroAssemblerX86_64.h: (JSC::MacroAssemblerX86_64::supportsDoubleBitops): * assembler/X86Assembler.h: (JSC::X86Assembler::andnpd_rr): * create_hash_table: * jit/SpecializedThunkJIT.h: (JSC::SpecializedThunkJIT::finalize): (JSC::SpecializedThunkJIT::callDoubleToDouble): * jit/ThunkGenerators.cpp: (JSC::floorThunkGenerator): (JSC::ceilThunkGenerator): (JSC::roundThunkGenerator): (JSC::expThunkGenerator): (JSC::logThunkGenerator): (JSC::absThunkGenerator): * jit/ThunkGenerators.h: git-svn-id: http://svn.webkit.org/repository/webkit/trunk@90237 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
aroben@apple.com authored
Failures are tracked by <http://webkit.org/b/63806> and <http://webkit.org/b/63807>. * platform/win/Skipped: Added http/tests/cache/history-only-cached-subresource-loads-max-age-https.html and fast/loader/create-frame-in-DOMContentLoaded.html. git-svn-id: http://svn.webkit.org/repository/webkit/trunk@90236 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
aroben@apple.com authored
The failure is tracked by <http://webkit.org/b/63809>. * platform/win/fast/events/panScroll-click-hyperlink-expected.txt: git-svn-id: http://svn.webkit.org/repository/webkit/trunk@90235 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
aroben@apple.com authored
The failure is tracked by <http://webkit.org/b/63811>. * platform/win/accessibility/aria-labelledby-overrides-aria-label-expected.txt: git-svn-id: http://svn.webkit.org/repository/webkit/trunk@90234 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
aroben@apple.com authored
Fixes <http://webkit.org/b/63810> REGRESSION (r90159): fast/events/window-onerror5.html failing * fast/events/window-onerror5-expected.txt: Updated for progression. git-svn-id: http://svn.webkit.org/repository/webkit/trunk@90233 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
http://webkit.org/b/63814ddkilzer@apple.com authored
Fixes the following build error in clang: JavaScriptCore/jit/JITOpcodes32_64.cpp:741:36:{741:9-741:35}: error: operator '?:' has lower precedence than '+'; '+' will be evaluated first [-Werror,-Wparentheses,3] map(m_bytecodeOffset + dynamic ? OPCODE_LENGTH(op_resolve_global_dynamic) : OPCODE_LENGTH(op_resolve_global), dst, regT1, regT0); ~~~~~~~~~~~~~~~~~~~~~~~~~~ ^ JavaScriptCore/jit/JITOpcodes32_64.cpp:741:36: note: place parentheses around the '+' expression to silence this warning [3] map(m_bytecodeOffset + dynamic ? OPCODE_LENGTH(op_resolve_global_dynamic) : OPCODE_LENGTH(op_resolve_global), dst, regT1, regT0); ^ ( ) fix-it:"JavaScriptCore/jit/JITOpcodes32_64.cpp":{741:9-741:9}:"(" fix-it:"JavaScriptCore/jit/JITOpcodes32_64.cpp":{741:35-741:35}:")" JavaScriptCore/jit/JITOpcodes32_64.cpp:741:36:{741:28-741:94}: note: place parentheses around the '?:' expression to evaluate it first [3] map(m_bytecodeOffset + dynamic ? OPCODE_LENGTH(op_resolve_global_dynamic) : OPCODE_LENGTH(op_resolve_global), dst, regT1, regT0); ~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ 1 error generated. * jit/JITOpcodes32_64.cpp: (JSC::JIT::emit_op_resolve_global): Add parenthesis to make the tertiary expression evaluate first. git-svn-id: http://svn.webkit.org/repository/webkit/trunk@90232 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
kbalazs@webkit.org authored
Reviewed by Andreas Kling. [X11][WK2] plugins/mouse-evets-fixedpos.html is failing because of broken event propagation https://bugs.webkit.org/show_bug.cgi?id=63239 * platform/qt-wk2/Skipped: 2011-07-01 Balazs Kelemen <kbalazs@webkit.org> Reviewed by Andreas Kling. [X11][WK2] plugins/mouse-evets-fixedpos.html is failing because of broken event propagation https://bugs.webkit.org/show_bug.cgi?id=63239 * WebProcess/Plugins/Netscape/x11/NetscapePluginX11.cpp: Revert the return value of NPP_HandleEvent because the plugin function returns with 0 if it handled the event. (WebKit::NetscapePlugin::platformHandleMouseEvent): (WebKit::NetscapePlugin::platformHandleWheelEvent): (WebKit::NetscapePlugin::platformHandleMouseEnterEvent): (WebKit::NetscapePlugin::platformHandleMouseLeaveEvent): (WebKit::NetscapePlugin::platformHandleKeyboardEvent): git-svn-id: http://svn.webkit.org/repository/webkit/trunk@90231 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
aroben@apple.com authored
We used to do this, but some refactoring in r90165 broke this logic. Fixes <http://webkit.org/b/63808> REGRESSION (r90165): TestFailures page always loads all builds back to the beginning of time Reviewed by Dan Bates. * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/LayoutTestHistoryAnalyzer.js: (LayoutTestHistoryAnalyzer.prototype.start): Stop fetching old builds once we're told that all current failures have been explained. git-svn-id: http://svn.webkit.org/repository/webkit/trunk@90230 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
aroben@apple.com authored
https://bugs.webkit.org/show_bug.cgi?id=63804 Reviewed by Darin Adler. commit-log-editor was changed in r46899 to move the bug title and URL to the top of the commit message in order to make git-based tools, which expect the first line of the commit message to be a summary of the change, to work better. But this reordering of the ChangeLog entry was unpredictable and unexpected. I changed prepare-ChangeLog to put the bug title and URL at the top of the ChangeLog entry so that commit-log-editor doesn't have to move them. Then I changed commit-log-editor not to try to move them. * Scripts/commit-log-editor: Partially reverted r46899. We no longer save the "Reviewed by" line and try to move it down below the bug title and URL. The order of the text in the ChangeLog is now preserved, except that we insert a "Patch by" line just above the "Reviewed by" line in cases where the committer and author are not the same person. * Scripts/prepare-ChangeLog: Moved the "Reviewed by" line down below the bug title and URL. git-svn-id: http://svn.webkit.org/repository/webkit/trunk@90229 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
commit-queue@webkit.org authored
Reviewed by Adam Roben. [CSSRegions] Add build slave https://bugs.webkit.org/show_bug.cgi?id=62372 * BuildSlaveSupport/build.webkit.org-config/config.json: Add an entry for a release build of Mac. git-svn-id: http://svn.webkit.org/repository/webkit/trunk@90228 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
commit-queue@webkit.org authored
Reviewed by Laszlo Gombos. [Qt][Symbian] Update .def file for Symbian https://bugs.webkit.org/show_bug.cgi?id=61200 Add newly introduced symbols to fix the Symbian build. * symbian/eabi/QtWebKitu.def: git-svn-id: http://svn.webkit.org/repository/webkit/trunk@90227 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
commit-queue@webkit.org authored
Reviewed by Adam Roben. accessibility/aria-labelledby-overrides-aria-label.html failing on Windows since it was added https://bugs.webkit.org/show_bug.cgi?id=63191 * accessibility/aria-labelledby-overrides-aria-label-expected.txt: Removed. * accessibility/aria-labelledby-overrides-aria-label.html: * platform/mac/accessibility/aria-labelledby-overrides-aria-label-expected.txt: Added. * platform/win/accessibility/aria-labelledby-overrides-aria-label-expected.txt: git-svn-id: http://svn.webkit.org/repository/webkit/trunk@90226 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
commit-queue@webkit.org authored
Reviewed by Kent Tamura. Disallow clicking an [X] button in 'search' input forms when 'disabled' attribute or 'readonly' attribute is set. https://bugs.webkit.org/show_bug.cgi?id=63709 Added a test that checks whether the content in 'search' input forms with 'disabled' attribute or 'readonly' attribute is cleared or not, when an [X] button is clicked. * fast/forms/search-disabled-readonly-expected.txt: Added. * fast/forms/search-disabled-readonly.html: Added. 2011-07-01 Kentaro Hara <haraken@google.com> Reviewed by Kent Tamura. Disallow clicking an [X] button in 'search' input forms when 'disabled' attribute or 'readonly' attribute is set. https://bugs.webkit.org/show_bug.cgi?id=63709 Ignore a cancel button event on a 'search' input form if 'disabled' attribute or 'readonly' attribute is set to the input form. Test: fast/forms/search-disabled-readonly.html * html/shadow/TextControlInnerElements.cpp: (WebCore::SearchFieldCancelButtonElement::defaultEventHandler): git-svn-id: http://svn.webkit.org/repository/webkit/trunk@90225 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
mrowe@apple.com authored
REGRESSION (r90163): WebKit2 bot is failing 100% of the tests. r90163 bumped the version of the WKBundlePageLoaderClient passed in by WebKitTestRunner from 0 to 1. This made it run in to the ad-hoc client version checking implemented directly in WKBundlePageSetPageLoaderClient, resulting in no client being set. After r90162 the ad-hoc checking is not necessary as the APIClient template takes care of the relevant version checks. * Shared/APIClient.h: (WebKit::APIClient::initialize): Fix a bug I noticed along the way: don't attempt to copy anything if the client version is newer than what we support. This matches the behavior of the ad-hoc version checking. * UIProcess/API/C/WKContext.cpp: (WKContextSetInjectedBundleClient): Drop the ad-hoc version checking. (WKContextSetHistoryClient): Ditto. (WKContextSetDownloadClient): Ditto. * UIProcess/API/C/WKCookieManager.cpp: (WKCookieManagerSetClient): Ditto. * UIProcess/API/C/WKGeolocationManager.cpp: (WKGeolocationManagerSetProvider): Ditto. * UIProcess/API/C/WKIconDatabase.cpp: (WKIconDatabaseSetIconDatabaseClient): Ditto. * UIProcess/API/C/WKPage.cpp: (WKPageSetPageContextMenuClient): Ditto. (WKPageSetPageFindClient): Ditto. (WKPageSetPageFormClient): Ditto. (WKPageSetPageLoaderClient): Ditto. (WKPageSetPagePolicyClient): Ditto. (WKPageSetPageResourceLoadClient): Ditto. (WKPageSetPageUIClient): Ditto. * WebProcess/InjectedBundle/API/c/WKBundle.cpp: (WKBundleSetClient): Ditto. * WebProcess/InjectedBundle/API/c/WKBundlePage.cpp: (WKBundlePageSetContextMenuClient): Ditto. (WKBundlePageSetEditorClient): Ditto. (WKBundlePageSetFormClient): Ditto. (WKBundlePageSetPageLoaderClient): Ditto. (WKBundlePageSetResourceLoadClient): Ditto. (WKBundlePageSetPolicyClient): Ditto. (WKBundlePageSetUIClient): Ditto. (WKBundlePageSetFullScreenClient): Ditto. git-svn-id: http://svn.webkit.org/repository/webkit/trunk@90224 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-