- 21 Aug, 2013 21 commits
-
-
simon.fraser@apple.com authored
https://bugs.webkit.org/show_bug.cgi?id=120135 Source/WebCore: Reviewed by Jer Noble. When removing a filter on an inline child of a compositing layer, the inline loses its RenderLayer and compositing layer, but we fail to repaint the compositing layer that the inline is now painting into. This worked correctly for opacity, because opacity toggles cause layouts (which then paint the correct layer), so do the same for filters. Test: css3/filters/remove-filter-repaint.html * rendering/style/RenderStyle.cpp: (WebCore::RenderStyle::changeRequiresLayout): Return true if we toggled between having filters and not. Drive-by cleanup, making use of new convenience function for hasOpacity(). * rendering/style/StyleRareNonInheritedData.cpp: (WebCore::StyleRareNonInheritedData::hasFilters): Returns true if we have any filters. * rendering/style/StyleRareNonInheritedData.h: (WebCore::StyleRareNonInheritedData::hasOpacity): Convenience function that returns true if opacity is < 1. LayoutTests: Reviewed by Jer Noble. Ref test for removing a filter on an inline. * css3/filters/remove-filter-repaint-expected.html: Added. * css3/filters/remove-filter-repaint.html: Added. git-svn-id: http://svn.webkit.org/repository/webkit/trunk@154430 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
commit-queue@webkit.org authored
Exception in global setter doesn't unwind correctly Patch by Yi Shen <max.hong.shen@gmail.com> on 2013-08-21 Reviewed by Geoffrey Garen. Source/JavaScriptCore: Call VM_THROW_EXCEPTION_AT_END in op_put_to_scope if the setter throws exception. * jit/JITStubs.cpp: (JSC::DEFINE_STUB_FUNCTION): LayoutTests: Add test for calling global setter which throws exception. * fast/js/script-tests/throw-exception-in-global-setter.js: Added. (g): * fast/js/throw-exception-in-global-setter-expected.txt: Added. * fast/js/throw-exception-in-global-setter.html: Added. git-svn-id: http://svn.webkit.org/repository/webkit/trunk@154429 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
ap@apple.com authored
https://bugs.webkit.org/show_bug.cgi?id=73694 http/tests/cookies/simple-cookies-max-age.html sometimes fails on Lion Intel Release (Tests) https://bugs.webkit.org/show_bug.cgi?id=73695 http/tests/cookies/single-quoted-value.html intermittently fails on Mac https://bugs.webkit.org/show_bug.cgi?id=105603 Reviewed by Dan Bernstein. Woark around a CFNetwork issue by using Max-Age=-1 instead of Max-Age=0. Since it's WebKit that we are testing and not the lower level networking, this does not change test coverage. * http/tests/cookies/resources/clearCookies.cgi: * http/tests/cookies/resources/cookies-test-pre.js: * http/tests/cookies/simple-cookies-max-age.html: * http/tests/websocket/tests/hybi/httponly-cookie.pl: * platform/mac-wk2/TestExpectations: * platform/mac/TestExpectations: git-svn-id: http://svn.webkit.org/repository/webkit/trunk@154425 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
bfulgham@apple.com authored
* platform/win/TestExpectations: Renable some tests git-svn-id: http://svn.webkit.org/repository/webkit/trunk@154424 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
timothy_horton@apple.com authored
It was freaking lint-test-expectations out. * TestExpectations: git-svn-id: http://svn.webkit.org/repository/webkit/trunk@154420 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
fpizlo@apple.com authored
https://bugs.webkit.org/show_bug.cgi?id=119872 Source/JavaScriptCore: Reviewed by Mark Hahnenberg. Apparently, unsigned + signed = unsigned. Work around it with a cast. * dfg/DFGByteCodeParser.cpp: (JSC::DFG::ByteCodeParser::parseBlock): LayoutTests: Reviewed by Mark Hahnenberg. * fast/js/dfg-switch-imm-negative-expected.txt: Added. * fast/js/dfg-switch-imm-negative.html: Added. * fast/js/jsc-test-list: * fast/js/script-tests/dfg-switch-imm-negative.js: Added. (foo): git-svn-id: http://svn.webkit.org/repository/webkit/trunk@154419 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
timothy_horton@apple.com authored
https://bugs.webkit.org/show_bug.cgi?id=120031 <rdar://problem/14606819> Reviewed by Simon Fraser. Hit-test for plugin obscurity in the root document. To do this, we also need to convert the indicator rectangle into root view coordinates before hit testing its edges. This resolves the case where an iframe which clips its content was reporting the indicator as not obscured, despite the fact that it was obscured from the point of view of the user. Updated test plugins/unavailable-plugin-indicator-obscurity.html * rendering/RenderEmbeddedObject.cpp: (WebCore::RenderEmbeddedObject::isReplacementObscured): Update the unavailable plugin indicator test to also ensure that plugins are correctly known to be obscured when contained within and clipped by an <iframe>. * plugins/unavailable-plugin-indicator-obscurity-expected.txt: * plugins/unavailable-plugin-indicator-obscurity.html: git-svn-id: http://svn.webkit.org/repository/webkit/trunk@154412 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
ap@apple.com authored
REGRESSION (r143931): set-cookie-on-redirect.html still breaking subsequent tests Reviewed by Brady Eidson. Work around <rdar://problem/10080130> by making the cookie persistent, session cookies are deleted in a way that confuses some code paths in CFNetwork. I'll unskip tests later, with another cookie reliability fix. * http/tests/cookies/resources/set-cookie-on-redirect.php: git-svn-id: http://svn.webkit.org/repository/webkit/trunk@154410 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
fpizlo@apple.com authored
https://bugs.webkit.org/show_bug.cgi?id=120099 Source/JavaScriptCore: Reviewed by Mark Hahnenberg. JSDataView should not store the ArrayBuffer* in the butterfly indexing header, since JSDataView may have ordinary JS indexed properties. * runtime/ClassInfo.h: * runtime/JSArrayBufferView.cpp: (JSC::JSArrayBufferView::ConstructionContext::ConstructionContext): (JSC::JSArrayBufferView::finishCreation): * runtime/JSArrayBufferView.h: (JSC::hasArrayBuffer): * runtime/JSArrayBufferViewInlines.h: (JSC::JSArrayBufferView::buffer): (JSC::JSArrayBufferView::neuter): (JSC::JSArrayBufferView::byteOffset): * runtime/JSCell.cpp: (JSC::JSCell::slowDownAndWasteMemory): * runtime/JSCell.h: * runtime/JSDataView.cpp: (JSC::JSDataView::JSDataView): (JSC::JSDataView::create): (JSC::JSDataView::slowDownAndWasteMemory): * runtime/JSDataView.h: (JSC::JSDataView::buffer): * runtime/JSGenericTypedArrayView.h: * runtime/JSGenericTypedArrayViewInlines.h: (JSC::::visitChildren): (JSC::::slowDownAndWasteMemory): LayoutTests: Reviewed by Mark Hahnenberg. * fast/js/regress/ArrayBuffer-DataView-alloc-large-long-lived-expected.txt: Added. * fast/js/regress/ArrayBuffer-DataView-alloc-large-long-lived.html: Added. * fast/js/regress/ArrayBuffer-DataView-alloc-long-lived-expected.txt: Added. * fast/js/regress/ArrayBuffer-DataView-alloc-long-lived.html: Added. * fast/js/regress/DataView-custom-properties-expected.txt: Added. * fast/js/regress/DataView-custom-properties.html: Added. * fast/js/regress/script-tests/ArrayBuffer-DataView-alloc-large-long-lived.js: Added. * fast/js/regress/script-tests/ArrayBuffer-DataView-alloc-long-lived.js: Added. * fast/js/regress/script-tests/DataView-custom-properties.js: Added. * platform/mac/TestExpectations: git-svn-id: http://svn.webkit.org/repository/webkit/trunk@154408 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
mhahnenberg@apple.com authored
Rubber stamped by Filip Pizlo. Source/JavaScriptCore: * heap/CopyVisitorInlines.h: (JSC::CopyVisitor::visitItem): LayoutTests: Added a new test that triggered the old ASSERT. It's a useful test to have because we create TypedArrays with custom properties. * fast/js/regress/ArrayBuffer-Int8Array-alloc-large-long-lived-fragmented-expected.txt: Added. * fast/js/regress/ArrayBuffer-Int8Array-alloc-large-long-lived-fragmented.html: Added. * fast/js/regress/script-tests/ArrayBuffer-Int8Array-alloc-large-long-lived-fragmented.js: Added. git-svn-id: http://svn.webkit.org/repository/webkit/trunk@154407 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
timothy_horton@apple.com authored
https://bugs.webkit.org/show_bug.cgi?id=120129 Rolling out http://trac.webkit.org/changeset/154399. * rendering/RenderBlock.cpp: * rendering/RenderBlock.h: * rendering/RenderBlockLineLayout.cpp: (WebCore::RenderBlock::LineBreaker::skipLeadingWhitespace): * rendering/RenderBox.h: * fast/block/margin-collapse/self-collapsing-block-with-float-descendant-expected.html: Removed. * fast/block/margin-collapse/self-collapsing-block-with-float-descendant.html: Removed. git-svn-id: http://svn.webkit.org/repository/webkit/trunk@154404 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
fpizlo@apple.com authored
https://bugs.webkit.org/show_bug.cgi?id=120022 Source/JavaScriptCore: Reviewed by Oliver Hunt. Adds inlining of typed array allocations in the DFG. Any operation of the form: new foo(blah) or: foo(blah) where 'foo' is a typed array constructor and 'blah' is exactly one argument, is turned into the NewTypedArray intrinsic. Later, of child1 (i.e. 'blah') is predicted integer, we generate inline code for an allocation. Otherwise it turns into a call to an operation that behaves like the constructor would if it was passed one argument (i.e. it may wrap a buffer or it may create a copy or another array, or it may allocate an array of that length). * bytecode/SpeculatedType.cpp: (JSC::speculationFromTypedArrayType): (JSC::speculationFromClassInfo): * bytecode/SpeculatedType.h: * dfg/DFGAbstractInterpreterInlines.h: (JSC::DFG::::executeEffects): * dfg/DFGBackwardsPropagationPhase.cpp: (JSC::DFG::BackwardsPropagationPhase::propagate): * dfg/DFGByteCodeParser.cpp: (JSC::DFG::ByteCodeParser::handleTypedArrayConstructor): (JSC::DFG::ByteCodeParser::handleConstantInternalFunction): * dfg/DFGCCallHelpers.h: (JSC::DFG::CCallHelpers::setupArgumentsWithExecState): * dfg/DFGCSEPhase.cpp: (JSC::DFG::CSEPhase::putStructureStoreElimination): * dfg/DFGClobberize.h: (JSC::DFG::clobberize): * dfg/DFGFixupPhase.cpp: (JSC::DFG::FixupPhase::fixupNode): * dfg/DFGGraph.cpp: (JSC::DFG::Graph::dump): * dfg/DFGNode.h: (JSC::DFG::Node::hasTypedArrayType): (JSC::DFG::Node::typedArrayType): * dfg/DFGNodeType.h: * dfg/DFGOperations.cpp: (JSC::DFG::newTypedArrayWithSize): (JSC::DFG::newTypedArrayWithOneArgument): * dfg/DFGOperations.h: (JSC::DFG::operationNewTypedArrayWithSizeForType): (JSC::DFG::operationNewTypedArrayWithOneArgumentForType): * dfg/DFGPredictionPropagationPhase.cpp: (JSC::DFG::PredictionPropagationPhase::propagate): * dfg/DFGSafeToExecute.h: (JSC::DFG::safeToExecute): * dfg/DFGSpeculativeJIT.cpp: (JSC::DFG::SpeculativeJIT::compileNewTypedArray): * dfg/DFGSpeculativeJIT.h: (JSC::DFG::SpeculativeJIT::callOperation): * dfg/DFGSpeculativeJIT32_64.cpp: (JSC::DFG::SpeculativeJIT::compile): * dfg/DFGSpeculativeJIT64.cpp: (JSC::DFG::SpeculativeJIT::compile): * jit/JITOpcodes.cpp: (JSC::JIT::emit_op_new_object): * jit/JITOpcodes32_64.cpp: (JSC::JIT::emit_op_new_object): * runtime/JSArray.h: (JSC::JSArray::allocationSize): * runtime/JSArrayBufferView.h: (JSC::JSArrayBufferView::allocationSize): * runtime/JSGenericTypedArrayViewConstructorInlines.h: (JSC::constructGenericTypedArrayView): * runtime/JSObject.h: (JSC::JSFinalObject::allocationSize): * runtime/TypedArrayType.cpp: (JSC::constructorClassInfoForType): * runtime/TypedArrayType.h: (JSC::indexToTypedArrayType): LayoutTests: Reviewed by Oliver Hunt. * fast/js/regress/Float64Array-alloc-long-lived-expected.txt: Added. * fast/js/regress/Float64Array-alloc-long-lived.html: Added. * fast/js/regress/Int16Array-alloc-long-lived-expected.txt: Added. * fast/js/regress/Int16Array-alloc-long-lived.html: Added. * fast/js/regress/Int8Array-alloc-long-lived-expected.txt: Added. * fast/js/regress/Int8Array-alloc-long-lived.html: Added. * fast/js/regress/script-tests/Float64Array-alloc-long-lived.js: Added. * fast/js/regress/script-tests/Int16Array-alloc-long-lived.js: Added. * fast/js/regress/script-tests/Int32Array-alloc-long-lived.js: * fast/js/regress/script-tests/Int8Array-alloc-long-lived.js: Added. git-svn-id: http://svn.webkit.org/repository/webkit/trunk@154403 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
https://webkit.org/b/120099timothy_horton@apple.com authored
<https://webkit.org/b/120099> Assertion failure in JSC::SlotVisitor::copyLater when marking DataView Mark fast/canvas/webgl/array-message-passing.html as crashing on debug, for now. * platform/mac/TestExpectations: git-svn-id: http://svn.webkit.org/repository/webkit/trunk@154402 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
simon.fraser@apple.com authored
https://bugs.webkit.org/show_bug.cgi?id=120104 Source/WebCore: Reviewed by David Hyatt. Opacity was ignored custom scrollbar pseudoelements because custom scrollbar renderers never create layers, and opacity is normally handled by the RenderLayer code. Fix by having RenderScrollbarTheme and RenderScrollbarPart do the transparency layers necessary for opacity. RenderScrollbarPart handles opacity for individual parts. Because ScrollbarThemeComposite::paint() renders the parts on after another (with no nesting), opacity handling for the entire scrollbar needs special-casing. This is done by willPaintScrollbar()/didPaintScrollbar() on the theme. RenderScrollbarTheme consults the opacity the scrollbar (which we get from the ScrollbarBGPart renderer) to decide whether to set up a transparency layer. Test: scrollbars/scrollbar-parts-opacity.html * platform/ScrollbarThemeComposite.cpp: (WebCore::ScrollbarThemeComposite::paint): * platform/ScrollbarThemeComposite.h: (WebCore::ScrollbarThemeComposite::willPaintScrollbar): (WebCore::ScrollbarThemeComposite::didPaintScrollbar): * rendering/RenderScrollbar.cpp: (WebCore::RenderScrollbar::opacity): * rendering/RenderScrollbar.h: * rendering/RenderScrollbarPart.cpp: (WebCore::RenderScrollbarPart::paintIntoRect): * rendering/RenderScrollbarTheme.cpp: (WebCore::RenderScrollbarTheme::willPaintScrollbar): (WebCore::RenderScrollbarTheme::didPaintScrollbar): * rendering/RenderScrollbarTheme.h: LayoutTests: Reviewed by David Hyatt. Ref test for custom scrollbars with opacity on the bar itself, and on the thumb. * scrollbars/scrollbar-parts-opacity-expected.html: Added. * scrollbars/scrollbar-parts-opacity.html: Added. git-svn-id: http://svn.webkit.org/repository/webkit/trunk@154400 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
robert@webkit.org authored
https://bugs.webkit.org/show_bug.cgi?id=119979 Reviewed by David Hyatt. Source/WebCore: If a float has a self-collapsing ancestor with clearance then it needs to respect that clearance when placing itself on the line. Test: fast/block/margin-collapse/self-collapsing-block-with-float-descendant.html * rendering/RenderBlock.cpp: (WebCore::RenderBlock::marginOffsetForSelfCollapsingBlock): * rendering/RenderBlock.h: * rendering/RenderBlockLineLayout.cpp: (WebCore::RenderBlock::LineBreaker::skipLeadingWhitespace): * rendering/RenderBox.h: (WebCore::RenderBox::previousInFlowSiblingBox): LayoutTests: * fast/block/margin-collapse/self-collapsing-block-with-float-descendant-expected.html: Added. * fast/block/margin-collapse/self-collapsing-block-with-float-descendant.html: Added. git-svn-id: http://svn.webkit.org/repository/webkit/trunk@154399 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
bfulgham@apple.com authored
* platform/win/TestExpectations: We can reactivate cssom/cssvalue-comparison.html git-svn-id: http://svn.webkit.org/repository/webkit/trunk@154394 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
https://webkit.org/b/120113bfulgham@apple.com authored
Reviewed by Anders Carlsson. * platform/win/TestExpectations: Turn on two CSS_IMAGE_SET-based tests that now pass on Windows. git-svn-id: http://svn.webkit.org/repository/webkit/trunk@154392 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
allan.jensen@digia.com authored
https://bugs.webkit.org/show_bug.cgi?id=100050 Reviewed by Antti Koivisto. Source/WebCore: Always let WidthIterator iterate over an entire TextRun to avoid problems with pixel rounding or shaping on partial runs. This fix is necessary for Qt because the complex font-path can not disable shaping, leading to the complex path painting slighly different from the fast path, which messes up selection painting. No change in functionality, no new tests. * platform/graphics/Font.cpp: (WebCore::Font::drawText): (WebCore::Font::drawEmphasisMarks): (WebCore::Font::selectionRectForText): (WebCore::Font::offsetForPosition): * platform/graphics/FontFastPath.cpp: (WebCore::Font::getGlyphsAndAdvancesForSimpleText): (WebCore::Font::selectionRectForSimpleText): (WebCore::Font::offsetForPositionForSimpleText): * platform/graphics/GlyphBuffer.h: (WebCore::GlyphBuffer::add): (GlyphBuffer): * platform/graphics/WidthIterator.cpp: (WebCore::WidthIterator::advanceInternal): * platform/graphics/WidthIterator.h: (WidthIterator): Removed now unused advanceOneCharacter method. LayoutTests: * fast/text/resources/PTS55F-webfont.ttf: Added. * fast/text/partial-textruns-expected.html: Added. * fast/text/partial-textruns.html: Added. git-svn-id: http://svn.webkit.org/repository/webkit/trunk@154384 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
tonikitoo@webkit.org authored
Harden RenderBox::canBeScrolledAndHasScrollableArea logic https://bugs.webkit.org/show_bug.cgi?id=104373 Reviewed by Simon Fraser. Patch by Antonio Gomes <a1.gomes@sisa.samsung.com> Source/WebCore: Previously if a say div has a overflown content on 'y' but is styled as "overflow-x: auto; overflow-y: hidden", RenderBox::canBeProgramaticallyScrolled would still return true. It interfers, among other things, with the way autoscroll works. Patch fixes it by adding two helper methods to RenderBox class in order to verify a box' scrollability in a given axis (x or y); They are used when checking if a given box is in fact programatically scrollable. Test: fast/events/autoscroll-overflow-hidden-longhands.html WebKit autoscroll behavior now matches Firefox and Opera12 (pre-blink) in that sense. * rendering/RenderBox.cpp: (WebCore::RenderBox::canBeProgramaticallyScrolled): * rendering/RenderBox.h: (WebCore::RenderBox::hasScrollableOverflowX): (WebCore::RenderBox::hasScrollableOverflowY): LayoutTests: Patch adds a test to ensure autoscrolling only happens on a given axis if it is scrollable in that direction, according to its style. * fast/events/autoscroll-overflow-hidden-longhands-expected.txt: Added. * fast/events/autoscroll-overflow-hidden-longhands.html: Added. git-svn-id: http://svn.webkit.org/repository/webkit/trunk@154383 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
https://bugs.webkit.org/show_bug.cgi?id=119760tonikitoo@webkit.org authored
Reviewed by Darin Adler. Patch by Antonio Gomes <a1.gomes@sisa.samsung.com> Source/WebCore: Consider the case of the following HTML: <div style="overflow:hidden; width: 100px; height: 100px" > <input id="input" type="text" size=10 value="any text here!"/> <button style="position:relative; top: 100px; left: 100px"/> </div> If ones starts a text selection by dragging the mouse from within the input field, and continues to drag beyong the outer div boundary, the latter will be scrolled no matter its overflow:hidden style. That happens because when the autoscroll has started, it gets propagated up to the current layer's parent layer, instead of the to current layer's enclosing scrollable layer. Patch fixes the issue by hardening the way scrolling is propagated upwards when autoscroll is being performed. RenderLayer::enclosingScrollableLayer method also got rewritten in terms of RenderLayer tree traversing, instead of RenderObject tree. The rewrite adds support for cross frame upwards traversal. Test: fast/events/autoscroll-upwards-propagation.html * rendering/RenderLayer.cpp: (WebCore::parentLayerCrossFrame): (WebCore::RenderLayer::enclosingScrollableLayer): (WebCore::RenderLayer::scrollRectToVisible): LayoutTests: * fast/events/autoscroll-upwards-propagation-expected.txt: Added. * fast/events/autoscroll-upwards-propagation.html: Added. git-svn-id: http://svn.webkit.org/repository/webkit/trunk@154382 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
barraclough@apple.com authored
REGRESSION (r154300): http/tests/security/cross-frame-access-getOwnPropertyDescriptor is failing or crashing on the bots Reviewed by Geoff Garen. Previously we allowed cross-frame access to these properties, but hid the descriptors. Now we allow access, but make them read-only, non-configurable. * http/tests/security/cross-frame-access-getOwnPropertyDescriptor-expected.txt: * http/tests/security/cross-frame-access-getOwnPropertyDescriptor.html: * platform/mac/TestExpectations: - Update test/results/expectations. git-svn-id: http://svn.webkit.org/repository/webkit/trunk@154379 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
- 20 Aug, 2013 19 commits
-
-
fpizlo@apple.com authored
https://bugs.webkit.org/show_bug.cgi?id=120083 Unreviewed. Fixed the test to work in web mode and removed the failure expectation. * fast/js/regress/script-tests/emscripten-cube2hash.js: (else.Module.string_appeared_here): * platform/mac/TestExpectations: git-svn-id: http://svn.webkit.org/repository/webkit/trunk@154377 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
fpizlo@apple.com authored
Rubber stamped by Oliver Hunt. * TestExpectations: * fast/js/regress/emscripten-memops-expected.txt: Added. * fast/js/regress/emscripten-memops.html: Added. * fast/js/regress/script-tests/emscripten-memops.js: Added. (.Module.string_appeared_here): (else.Module.string_appeared_here): (else.else.Module.string_appeared_here): (else.else): (globalEval): (Runtime.stackSave): (Runtime.stackRestore): (Runtime.forceAlign): (Runtime.isNumberType): (Runtime.isPointerType): (Runtime.isStructType): (or64): (and64): (xor64): (getNativeTypeSize): (getNativeFieldSize): (dedup): (.set var): (getAlignSize): (calculateStructAlignment): (.else.alignment): (generateStructInfo): (dynCall): (addFunction): (removeFunction): (warnOnce): (.Runtime.funcWrappers.func): (getFuncWrapper): (UTF8Processor.this.processCChar): (UTF8Processor.this.processJSString): (UTF8Processor): (stackAlloc): (staticAlloc): (dynamicAlloc): (alignMemory): (makeBigInt): (assert): (ccall): (getCFunc): (.toC): (.fromC): (ccallFunc): (setValue): (getValue): (.set else): (.set return): (allocate): (Pointer_stringify): (alignMemoryPage): (enlargeMemory): (callRuntimeCallbacks): (preRun): (ensureInitRuntime): (preMain): (exitRuntime): (postRun): (addOnPreRun): (addOnInit): (addOnPreMain): (addOnExit): (addOnPostRun): (intArrayFromString): (intArrayToString): (writeStringToMemory): (writeArrayToMemory): (unSign): (reSign): (Math.string_appeared_here): (addRunDependency): (removeRunDependency): (loadMemoryInitializer.applyData): (loadMemoryInitializer.set addOnPreRun): (__ATINIT__.push): (STATIC_BASE): (copyTempDouble): (___setErrNo): (PATH.splitPath): (PATH.normalizeArray): (PATH.normalize.join): (PATH.normalize): (PATH.dirname): (PATH.basename): (PATH.join): (PATH.trim): (PATH.relative): (TTY.register): (TTY.stream_ops.open): (TTY.stream_ops.close): (TTY.stream_ops.read): (TTY.stream_ops.write): (TTY.default_tty_ops.get_char): (TTY.default_tty_ops.put_char): (TTY.default_tty1_ops.put_char): (MEMFS.mount): (MEMFS.create_node): (MEMFS.node_ops.getattr): (MEMFS.node_ops.setattr): (MEMFS.node_ops.lookup): (MEMFS.node_ops.mknod): (MEMFS.node_ops.rename): (MEMFS.node_ops.unlink): (MEMFS.node_ops.rmdir): (MEMFS.node_ops.readdir): (MEMFS.node_ops.symlink): (MEMFS.node_ops.readlink): (MEMFS.stream_ops.set else): (MEMFS.stream_ops.read): (MEMFS.stream_ops.write): (MEMFS.stream_ops.llseek): (MEMFS.stream_ops.allocate): (MEMFS.stream_ops.set return): (MEMFS.stream_ops.mmap): (_fflush): (FS.ErrnoError): (FS.handleFSError): (FS.hashName): (FS.hashAddNode): (FS.hashRemoveNode): (FS.lookupNode): (FS.): (FS.destroyNode): (FS.isRoot): (FS.isMountpoint): (FS.isFile): (FS.isDir): (FS.isLink): (FS.isChrdev): (FS.isBlkdev): (FS.isFIFO): (FS.cwd): (FS.var): (FS.lookupPath): (FS.getPath): (FS.modeStringToFlags): (FS.flagsToPermissionString): (FS.nodePermissions): (FS.mayLookup): (FS.mayMknod): (FS.mayCreate): (FS.mayDelete): (FS.mayOpen): (FS.chrdev_stream_ops.open): (FS.chrdev_stream_ops.llseek): (FS.major): (FS.minor): (FS.makedev): (FS.registerDevice): (FS.getDevice): (FS.nextfd): (FS.getStream): (FS.closeStream): (FS.getMode): (FS.joinPath): (FS.absolutePath): (FS.standardizePath): (FS.findObject): (FS.analyzePath): (FS.createFolder): (FS.createPath): (FS.createFile): (FS.createDataFile): (FS.createDevice): (FS.createLink): (FS.forceLoadFile): (FS.LazyUint8Array): (FS.LazyUint8Array.prototype.get if): (FS.LazyUint8Array.prototype): (FS.LazyUint8Array.prototype.setDataGetter): (FS.LazyUint8Array.prototype.cacheLength.doXHR): (FS.LazyUint8Array.prototype.cacheLength): (FS.get Object): (FS.get var): (FS.keys.forEach): (FS.processData.finish): (FS.processData): (FS.else): (FS.createPreloadedFile): (FS.createDefaultDirectories): (FS.createDefaultDevices.): (FS.createDefaultDevices): (FS.createStandardStreams): (FS.staticInit): (FS.init): (FS.quit): (FS.mount): (FS.lookup): (FS.mknod): (FS.create): (FS.mkdir): (FS.mkdev): (FS.symlink): (FS.rename): (FS.rmdir): (FS.readdir): (FS.unlink): (FS.readlink): (FS.stat): (FS.lstat): (FS.chmod): (FS.lchmod): (FS.fchmod): (FS.chown): (FS.lchown): (FS.fchown): (FS.truncate): (FS.ftruncate): (FS.utime): (FS.open): (FS.close): (FS.llseek): (FS.read): (FS.write): (FS.allocate): (FS.mmap): (_send): (_pwrite): (_write): (_fwrite): (__reallyNegative): (.getNextArg): (.switch.case.string_appeared_here.case.string_appeared_here.case.string_appeared_here.case.string_appeared_here.case.string_appeared_here.case.string_appeared_here.case.string_appeared_here.break): (.switch.case.string_appeared_here.case.string_appeared_here.case.string_appeared_here.case.string_appeared_here.case.string_appeared_here.case.string_appeared_here.break): (_fprintf): (_printf): (_abort): (___errno_location): (_sbrk.Runtime.dynamicAlloc): (_sbrk): (_sysconf): (_time): (Browser.mainLoop.pause): (Browser.mainLoop.resume): (Browser.mainLoop.updateStatus): (Browser.init.imagePlugin.string_appeared_here): (Browser.init.img.onload): (Browser.init.img.onerror): (Browser.init.audioPlugin.string_appeared_here): (Browser.init.finish): (Browser.init.fail): (Browser.init.audio.onerror.encode64): (Browser.init.audio.onerror): (Browser.init.audio): (Browser.init.else): (Browser.init.pointerLockChange): (Browser.init.canvas): (Browser.init): (Browser.destroyContext): (Browser.fullScreenChange): (Browser.requestFullScreen): (Browser.requestAnimationFrame): (Browser.safeRequestAnimationFrame): (Browser.safeSetTimeout): (Browser.safeSetInterval): (Browser.getMimetype): (Browser.getUserMedia): (Browser.getMovementX): (Browser.getMovementY): (Browser.calculateMouseEvent): (Browser.xhr.onload): (Browser.xhrLoad): (Browser.updateResizeListeners): (Browser.setCanvasSize): (Browser.setFullScreenCanvasSize): (Browser.setWindowedCanvasSize): (__ATINIT__.unshift): (__ATMAIN__.push): (__ATEXIT__.push): (Module.string_appeared_here): (invoke_ii): (invoke_v): (invoke_iii): (invoke_vi): (asmPrintInt): (asmPrintFloat): (asm): (Runtime.stackAlloc): (ExitStatus): (Module.string_appeared_here.Module.callMain.callMain.pad): (Module.string_appeared_here.Module.callMain): (run.doRun): (run.else): (run): (exit): (abort): git-svn-id: http://svn.webkit.org/repository/webkit/trunk@154376 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
seokju@webkit.org authored
* platform/qt-mac/TestExpectations: fast/css/giant-stylesheet-crash.html was removed. git-svn-id: http://svn.webkit.org/repository/webkit/trunk@154374 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
https://webkit.org/b/120095rniwa@webkit.org authored
<https://webkit.org/b/120095> Delete fast/css/giant-stylesheet-crash.html since it flakily timeout or crash Reviewed by Antti Koivisto. Deleted the test. This test was added in r82054 but it has been crashing since r154242. Since our expected behavior is to crash at the moment, this test's description doesn't even match the expected behavior anymore. Furthermore, it intermittently times out due to DRT taking too long to allocate memory before it can crash. * fast/css/giant-stylesheet-crash-expected.txt: Removed. * fast/css/giant-stylesheet-crash.html: Removed. git-svn-id: http://svn.webkit.org/repository/webkit/trunk@154372 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
https://webkit.org/b/120032dbates@webkit.org authored
of <input type="file"> is meaningful Following <http://trac.webkit.org/changeset/154332>, add GTK-specific expected results for test LayoutTests/accessibility/file-upload-button-stringvalue.html. * platform/gtk-wk2/accessibility/file-upload-button-stringvalue-expected.txt: Added; expected failure results until we fix <https://webkit.org/b/64285>. * platform/gtk/accessibility/file-upload-button-stringvalue-expected.txt: Added. git-svn-id: http://svn.webkit.org/repository/webkit/trunk@154359 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
timothy_horton@apple.com authored
One recently regressed: webkit.org/b/120086 http/tests/security/cross-frame-access-getOwnPropertyDescriptor.html One was recently added in a failing state: webkit.org/b/120083 fast/js/regress/emscripten-cube2hash.html * platform/mac/TestExpectations: git-svn-id: http://svn.webkit.org/repository/webkit/trunk@154357 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
https://webkit.org/b/120087rniwa@webkit.org authored
Add the test expectation. * platform/mac/TestExpectations: git-svn-id: http://svn.webkit.org/repository/webkit/trunk@154356 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
rniwa@webkit.org authored
Also add an intermittent test failure expectation to http/tests/inspector/resource-tree/resource-tree-document-url.html * platform/mac/TestExpectations: * platform/mac-lion/fast/repaint/japanese-rl-selection-repaint-in-regions-expected.txt: git-svn-id: http://svn.webkit.org/repository/webkit/trunk@154355 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
rniwa@webkit.org authored
since allocating 2GB of RAM takes a long time sometimes. * TestExpectations: git-svn-id: http://svn.webkit.org/repository/webkit/trunk@154352 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
https://webkit.org/b/119849hmuller@adobe.com authored
Reviewed by Alexandru Chiculita. Source/WebCore: Completed the implementation of RasterShape::firstIncludedIntervalLogicalTop(). The method now computes first logical top location where a line segment can be laid out within a RasterShape, i.e. a shape derived from an image valued URL resource. A detailed description of the algorithm can be found in http://hansmuller-webkit.blogspot.com/2013/08/first-fit-location-for-image-shapes.html. The new tests exposed a bug in the existing getIncludedIntervals() method. A shape with a vertical gap that spans the entire line now causes the method to short circuit and return an empty interval list. Tests: fast/shapes/shape-inside/shape-inside-image-003.html fast/shapes/shape-inside/shape-inside-image-004.html fast/shapes/shape-inside/shape-inside-image-005.html * rendering/shapes/RasterShape.cpp: (WebCore::RasterShapeIntervals::firstIncludedIntervalY): (WebCore::RasterShapeIntervals::getIncludedIntervals): (WebCore::RasterShape::firstIncludedIntervalLogicalTop): * rendering/shapes/RasterShape.h: LayoutTests: Verify that the first fit algorithm works correctly for complex image shapes. For this set of tests the image is specified with an SVG file. * fast/shapes/resources/svg-shape-001.svg: Added. * fast/shapes/shape-inside/shape-inside-image-003-expected.html: Added. * fast/shapes/shape-inside/shape-inside-image-003.html: Added. * fast/shapes/shape-inside/shape-inside-image-004-expected.html: Added. * fast/shapes/shape-inside/shape-inside-image-004.html: Added. * fast/shapes/shape-inside/shape-inside-image-005-expected.html: Added. * fast/shapes/shape-inside/shape-inside-image-005.html: Added. git-svn-id: http://svn.webkit.org/repository/webkit/trunk@154349 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
msaboff@apple.com authored
REGRESSION (r128400): BBC4 website not displaying pictures Reviewed by Oliver Hunt. Source/JavaScriptCore: * runtime/RegExpMatchesArray.h: (JSC::RegExpMatchesArray::createStructure): Changed the array IndexingType to be ArrayWithSlowPutArrayStorage so that the match results will be reified before any other modification to the results array. LayoutTests: Added regression tests for fix. * fast/js/regress/regexp-match-reify-before-putbyval-expected.txt: Added. * fast/js/regress/regexp-match-reify-before-putbyval.html: Added. * fast/js/regress/script-tests/regexp-match-reify-before-putbyval.js: Added. git-svn-id: http://svn.webkit.org/repository/webkit/trunk@154346 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
fpizlo@apple.com authored
https://bugs.webkit.org/show_bug.cgi?id=120033 Source/JavaScriptCore: Reviewed by Mark Hahnenberg. If PutClosureVar is may-aliased to another PutClosureVar or GetClosureVar then we should bail attempts to CSE. * dfg/DFGCSEPhase.cpp: (JSC::DFG::CSEPhase::scopedVarLoadElimination): (JSC::DFG::CSEPhase::scopedVarStoreElimination): LayoutTests: Reviewed by Mark Hahnenberg. Add the test that actually failed as a JSRegress test. We should track its performance anyway. Add a regression test for the actual failure. Add .html and -expected.txt files for a JSRegress test that is already in the repo. * fast/js/dfg-get-closure-var-put-closure-var-interference.html: Added. * fast/js/dfg-get-closure-var-put-closure-var-interference-expected.txt: Added. * fast/js/regress/array-nonarray-polymorhpic-access-expected.txt: Added. * fast/js/regress/array-nonarray-polymorhpic-access.html: Added. * fast/js/regress/emscripten-cube2hash-expected.txt: Added. * fast/js/regress/emscripten-cube2hash.html: Added. * fast/js/regress/script-tests/emscripten-cube2hash.js: Added. (.Module.string_appeared_here): (else.Module.string_appeared_here): (else.else.Module.string_appeared_here): (else.else): (globalEval): (Runtime.stackSave): (Runtime.stackRestore): (Runtime.forceAlign): (Runtime.isNumberType): (Runtime.isPointerType): (Runtime.isStructType): (or64): (and64): (xor64): (getNativeTypeSize): (getNativeFieldSize): (dedup): (.set var): (getAlignSize): (calculateStructAlignment): (.else.alignment): (generateStructInfo): (dynCall): (addFunction): (removeFunction): (warnOnce): (.Runtime.funcWrappers.func): (getFuncWrapper): (UTF8Processor.this.processCChar): (UTF8Processor.this.processJSString): (UTF8Processor): (stackAlloc): (staticAlloc): (dynamicAlloc): (alignMemory): (makeBigInt): (assert): (ccall): (getCFunc): (.toC): (.fromC): (ccallFunc): (setValue): (getValue): (.set else): (.set return): (allocate): (Pointer_stringify): (alignMemoryPage): (enlargeMemory): (callRuntimeCallbacks): (preRun): (ensureInitRuntime): (preMain): (exitRuntime): (postRun): (addOnPreRun): (addOnInit): (addOnPreMain): (addOnExit): (addOnPostRun): (intArrayFromString): (intArrayToString): (writeStringToMemory): (writeArrayToMemory): (unSign): (reSign): (Math.string_appeared_here): (addRunDependency): (removeRunDependency): (loadMemoryInitializer.applyData): (loadMemoryInitializer.set addOnPreRun): (__ATINIT__.push): (STATIC_BASE): (copyTempDouble): (___setErrNo): (PATH.splitPath): (PATH.normalizeArray): (PATH.normalize.join): (PATH.normalize): (PATH.dirname): (PATH.basename): (PATH.join): (PATH.trim): (PATH.relative): (TTY.register): (TTY.stream_ops.open): (TTY.stream_ops.close): (TTY.stream_ops.read): (TTY.stream_ops.write): (TTY.default_tty_ops.get_char): (TTY.default_tty_ops.put_char): (TTY.default_tty1_ops.put_char): (MEMFS.mount): (MEMFS.create_node): (MEMFS.node_ops.getattr): (MEMFS.node_ops.setattr): (MEMFS.node_ops.lookup): (MEMFS.node_ops.mknod): (MEMFS.node_ops.rename): (MEMFS.node_ops.unlink): (MEMFS.node_ops.rmdir): (MEMFS.node_ops.readdir): (MEMFS.node_ops.symlink): (MEMFS.node_ops.readlink): (MEMFS.stream_ops.set else): (MEMFS.stream_ops.read): (MEMFS.stream_ops.write): (MEMFS.stream_ops.llseek): (MEMFS.stream_ops.allocate): (MEMFS.stream_ops.set return): (MEMFS.stream_ops.mmap): (_fflush): (FS.ErrnoError): (FS.handleFSError): (FS.hashName): (FS.hashAddNode): (FS.hashRemoveNode): (FS.lookupNode): (FS.): (FS.destroyNode): (FS.isRoot): (FS.isMountpoint): (FS.isFile): (FS.isDir): (FS.isLink): (FS.isChrdev): (FS.isBlkdev): (FS.isFIFO): (FS.cwd): (FS.var): (FS.lookupPath): (FS.getPath): (FS.modeStringToFlags): (FS.flagsToPermissionString): (FS.nodePermissions): (FS.mayLookup): (FS.mayMknod): (FS.mayCreate): (FS.mayDelete): (FS.mayOpen): (FS.chrdev_stream_ops.open): (FS.chrdev_stream_ops.llseek): (FS.major): (FS.minor): (FS.makedev): (FS.registerDevice): (FS.getDevice): (FS.nextfd): (FS.getStream): (FS.closeStream): (FS.getMode): (FS.joinPath): (FS.absolutePath): (FS.standardizePath): (FS.findObject): (FS.analyzePath): (FS.createFolder): (FS.createPath): (FS.createFile): (FS.createDataFile): (FS.createDevice): (FS.createLink): (FS.forceLoadFile): (FS.LazyUint8Array): (FS.LazyUint8Array.prototype.get if): (FS.LazyUint8Array.prototype): (FS.LazyUint8Array.prototype.setDataGetter): (FS.LazyUint8Array.prototype.cacheLength.doXHR): (FS.LazyUint8Array.prototype.cacheLength): (FS.get Object): (FS.get var): (FS.keys.forEach): (FS.processData.finish): (FS.processData): (FS.else): (FS.createPreloadedFile): (FS.createDefaultDirectories): (FS.createDefaultDevices.): (FS.createDefaultDevices): (FS.createStandardStreams): (FS.staticInit): (FS.init): (FS.quit): (FS.mount): (FS.lookup): (FS.mknod): (FS.create): (FS.mkdir): (FS.mkdev): (FS.symlink): (FS.rename): (FS.rmdir): (FS.readdir): (FS.unlink): (FS.readlink): (FS.stat): (FS.lstat): (FS.chmod): (FS.lchmod): (FS.fchmod): (FS.chown): (FS.lchown): (FS.fchown): (FS.truncate): (FS.ftruncate): (FS.utime): (FS.open): (FS.close): (FS.llseek): (FS.read): (FS.write): (FS.allocate): (FS.mmap): (_send): (_pwrite): (_write): (_fwrite): (__reallyNegative): (.getNextArg): (.switch.case.string_appeared_here.case.string_appeared_here.case.string_appeared_here.case.string_appeared_here.case.string_appeared_here.case.string_appeared_here.case.string_appeared_here.break): (.switch.case.string_appeared_here.case.string_appeared_here.case.string_appeared_here.case.string_appeared_here.case.string_appeared_here.case.string_appeared_here.break): (_fprintf): (_printf): (_fputs): (_fputc): (_puts): (_abort): (___errno_location): (_sbrk.Runtime.dynamicAlloc): (_sbrk): (_sysconf): (_time): (Browser.mainLoop.pause): (Browser.mainLoop.resume): (Browser.mainLoop.updateStatus): (Browser.init.imagePlugin.string_appeared_here): (Browser.init.img.onload): (Browser.init.img.onerror): (Browser.init.audioPlugin.string_appeared_here): (Browser.init.finish): (Browser.init.fail): (Browser.init.audio.onerror.encode64): (Browser.init.audio.onerror): (Browser.init.audio): (Browser.init.else): (Browser.init.pointerLockChange): (Browser.init.canvas): (Browser.init): (Browser.destroyContext): (Browser.fullScreenChange): (Browser.requestFullScreen): (Browser.requestAnimationFrame): (Browser.safeRequestAnimationFrame): (Browser.safeSetTimeout): (Browser.safeSetInterval): (Browser.getMimetype): (Browser.getUserMedia): (Browser.getMovementX): (Browser.getMovementY): (Browser.calculateMouseEvent): (Browser.xhr.onload): (Browser.xhrLoad): (Browser.updateResizeListeners): (Browser.setCanvasSize): (Browser.setFullScreenCanvasSize): (Browser.setWindowedCanvasSize): (__ATINIT__.unshift): (__ATMAIN__.push): (__ATEXIT__.push): (Module.string_appeared_here): (invoke_ii): (invoke_v): (invoke_iii): (invoke_vi): (asmPrintInt): (asmPrintFloat): (asm): (Runtime.stackAlloc): (i64Math): (i64Math.): (Module.string_appeared_here.Module.callMain.callMain.pad): (Module.string_appeared_here.Module.callMain): (run.doRun): (run.else): (run): (exit): (abort): * fast/js/script-tests/dfg-get-closure-var-put-closure-var-interference.js: Added. (foo): (thingy.return.bar): (thingy.return.baz): (thingy): (runIt): git-svn-id: http://svn.webkit.org/repository/webkit/trunk@154344 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
bruno.d@partner.samsung.com authored
https://bugs.webkit.org/show_bug.cgi?id=92000 Implements the text-decoration shorthand (with -webkit- prefix), as specified by the CSS3 Text Decoration specification: http://dev.w3.org/csswg/css-text-decor-3/#text-decoration-property Backported from Blink: https://src.chromium.org/viewvc/blink?revision=156266&view=revision git-svn-id: http://svn.webkit.org/repository/webkit/trunk@154338 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
https://webkit.org/b/120032dbates@webkit.org authored
of <input type="file"> is meaningful Reviewed by Chris Fleizach. Adds a DRT test to ensure that AccessibilityObject::stringValue() returns a meaningful string for a single file- and multiple files-file upload control. * accessibility/file-upload-button-stringvalue.html: Added. * platform/mac-wk2/accessibility/file-upload-button-stringvalue-expected.txt: Added. * platform/mac/accessibility/file-upload-button-stringvalue-expected.txt: Added. git-svn-id: http://svn.webkit.org/repository/webkit/trunk@154332 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
https://webkit.org/b/120025antti@apple.com authored
<https://webkit.org/b/120025> REGRESSION (r154254): fast/frames/frameset-frameborder-inheritance.html failing on Apple MountainLion Debug WK1 (Tests) Reviewed by Anders Carlsson. Source/WebCore: * html/HTMLDocument.cpp: (WebCore::HTMLDocument::isFrameSet): * html/HTMLFrameElement.cpp: (WebCore::HTMLFrameElement::didAttachRenderers): Make helper public in HTMLFrameSetElement. * html/HTMLFrameSetElement.cpp: (WebCore::HTMLFrameSetElement::findContaining): Static function for finding containing frameset, if any. (WebCore::HTMLFrameSetElement::willAttachRenderers): This broke in refactoring. We should exit the loop when the first containing frameset is found. Fix by refactoring more. * html/HTMLFrameSetElement.h: (WebCore::isHTMLFrameSetElement): (WebCore::toHTMLFrameSetElement): Add casting functions. * rendering/RenderFrameSet.cpp: (WebCore::RenderFrameSet::frameSet): LayoutTests: * platform/mac/TestExpectations: Unskip. git-svn-id: http://svn.webkit.org/repository/webkit/trunk@154326 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
https://webkit.org/b/120023antti@apple.com authored
<https://webkit.org/b/120023> REGRESSION(r154257): svg/custom/bug78807.svg and svg/custom/use-invalid-style.svg failing Source/WebCore: Reviewed by Andreas Kling. * xml/XMLErrors.cpp: (WebCore::XMLErrors::insertErrorMessageBlock): "reattach" had accidentally turned into "detach" in refactoring. LayoutTests: Reviewed by by Andreas Kling. * TestExpectations: Unskip. git-svn-id: http://svn.webkit.org/repository/webkit/trunk@154323 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
https://webkit.org/b/119969antti@apple.com authored
Source/WebCore: Reviewed by Andreas Kling. PseudoElement no longer has parent and calling Element::insertedInto for them crashes as it tries to access it. Normally there are no pseudo elements when Element::insertedInto() is invoked as they get detached and attached along with rendering. However in this case the page inserts a <style> that uses ::before along with an element that it applies to. Stylesheet insertion triggers synchronous style recalc that attaches rendering to all newly insered elements. Later Element::insertedInto gets called for the element that has pseudo element and we crash. Test: fast/css-generated-content/insert-stylesheet-and-pseudo-crash.html * dom/Element.cpp: (WebCore::Element::insertedInto): (WebCore::Element::removedFrom): Remove calls to insertedInto/removedFrom for pseudo elements. They are not considered to be in document. When they are added normally during render tree attach these calls don't happen either. LayoutTests: Reviewed by Andreas Kling. * fast/css-generated-content/insert-stylesheet-and-pseudo-crash-expected.txt: Added. * fast/css-generated-content/insert-stylesheet-and-pseudo-crash.html: Added. git-svn-id: http://svn.webkit.org/repository/webkit/trunk@154320 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
simon.pena@samsung.com authored
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@154319 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
https://webkit.org/b/117584simon.pena@samsung.com authored
<https://webkit.org/b/117584> [GTK][WK1] http/tests/loading/unfinished-load-back-to-cached-page-callbacks.html is failing Update DumpRenderTree to handle the WEBKIT_LOAD_FAILED status, printing didFailLoadWithError. Tools: Behave like other ports, and handle WEBKIT_LOAD_FAILED status in DumpRenderTree, printing didFailLoadWithError. * DumpRenderTree/gtk/DumpRenderTree.cpp: (webFrameLoadStatusNotified): LayoutTests: Adding that print makes http/tests/loading/unfinished-load-back-to-cached-page-callbacks.html and http/tests/loading/unfinished-main-resource-back-to-cached-page-callbacks.html, although it requires to modify the expected results for http/tests/loading/pdf-commit-load-callbacks.html. * platform/gtk-wk1/TestExpectations: Unskip http/tests/loading/unfinished-load-back-to-cached-page-callbacks.html and http/tests/loading/unfinished-main-resource-back-to-cached-page-callbacks.html * platform/gtk/http/tests/loading/pdf-commit-load-callbacks-expected.txt: Update the expected results. git-svn-id: http://svn.webkit.org/repository/webkit/trunk@154318 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-