1. 08 Feb, 2012 2 commits
    • haraken@chromium.org's avatar
      Rename [DelegatingPutFunction] IDL to [CustomNamedSetter] IDL · 70850529
      haraken@chromium.org authored
      https://bugs.webkit.org/show_bug.cgi?id=77963
      
      Reviewed by Adam Barth.
      
      This patch renames [DelegatingPutFunction] IDL to [CustomNamedSetter] IDL,
      for clarification and for naming consistency with [NamedGetter] and [CustomIndexedSetter].
      
      No tests. No change in behavior.
      
      * bindings/scripts/CodeGeneratorJS.pm:
      (GenerateHeader):
      (GenerateImplementation):
      * bindings/scripts/CodeGeneratorV8.pm:
      (GenerateHeaderNamedAndIndexedPropertyAccessors):
      (GenerateImplementationIndexer):
      (GenerateImplementationNamedPropertyGetter):
      * bindings/scripts/test/TestInterface.idl:
      * css/CSSStyleDeclaration.idl:
      * dom/DOMStringMap.idl:
      * html/HTMLAppletElement.idl:
      * html/HTMLEmbedElement.idl:
      * html/HTMLObjectElement.idl:
      * page/History.idl:
      * page/Location.idl:
      * storage/Storage.idl:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@107051 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      70850529
    • haraken@chromium.org's avatar
      Replace [CheckNodeSecurity] with [CheckAccessToNode] · 81045559
      haraken@chromium.org authored
      https://bugs.webkit.org/show_bug.cgi?id=77971
      
      Reviewed by Adam Barth.
      
      Source/WebCore:
      
      [CheckNodeSecurity] is not implemented by code generators.
      This patch replaces [CheckNodeSecurity] with [CheckAccessToNode].
      
      Test: http/tests/security/cross-frame-access-frameelement.html
      
      * page/DOMWindow.idl:
      
      LayoutTests:
      
      The added test checks if frameElement is accessible from the same or cross origin iframe.
      
      * http/tests/security/cross-frame-access-frameelement-expected.txt: Added.
      * http/tests/security/cross-frame-access-frameelement.html: Added.
      * http/tests/security/resources/cross-frame-access-frameelement-from-iframe.html: Added.
      * platform/chromium/http/tests/security/cross-frame-access-put-expected.txt: Updated the test result.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@107046 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      81045559
  2. 07 Feb, 2012 8 commits
    • haraken@chromium.org's avatar
      Add "JS" prefix to JSC-specific IDLs · efee39f4
      haraken@chromium.org authored
      https://bugs.webkit.org/show_bug.cgi?id=77846
      
      Reviewed by Darin Adler.
      
      In bug 77693, we have added "JS" prefix to several JSC specific IDLs.
      This patch adds "JS" prefix to the remaining JSC specific IDLs.
      Specifically, this patch renames IDLs as follows:
      
      [CustomDefineOwnProperty] => [JSCustomDefineOwnProperty]
      [CustomPrototypeDefineOwnProperty] => [JSCustomPrototypeDefineOwnProperty]
      [GenerateNativeConverter] => [JSGenerateToNativeObject]  (Note: For naming consistency
      with [JSGenerateToJS] and [JSCustomToNativeObject])
      [DelegatingGetOwnPropertySlot] => [JSCustomGetOwnPropertySlotDelegate]  (Note: Should be prefixed "JS",
      should be prefixed with "Custom", and for naming consistency with [CustomGetOwnPropertySlot])
      
      No tests. No change in behavior.
      
      * bindings/scripts/CodeGeneratorJS.pm:
      (GenerateGetOwnPropertySlotBody):
      (GenerateGetOwnPropertyDescriptorBody):
      (GenerateHeader):
      (GenerateImplementation):
      * bindings/scripts/test/TestTypedArray.idl:
      * dom/Attr.idl:
      * dom/DataTransferItemList.idl:
      * dom/Document.idl:
      * dom/DocumentType.idl:
      * dom/Element.idl:
      * dom/Node.idl:
      * fileapi/DirectoryEntry.idl:
      * fileapi/DirectoryEntrySync.idl:
      * fileapi/File.idl:
      * fileapi/FileEntry.idl:
      * fileapi/FileEntrySync.idl:
      * fileapi/WebKitBlobBuilder.idl:
      * html/DOMFormData.idl:
      * html/DOMURL.idl:
      * html/HTMLAppletElement.idl:
      * html/HTMLCanvasElement.idl:
      * html/HTMLElement.idl:
      * html/HTMLEmbedElement.idl:
      * html/HTMLImageElement.idl:
      * html/HTMLMediaElement.idl:
      * html/HTMLObjectElement.idl:
      * html/HTMLOptionElement.idl:
      * html/HTMLOptionsCollection.idl:
      * html/HTMLTableCaptionElement.idl:
      * html/HTMLTableSectionElement.idl:
      * html/HTMLVideoElement.idl:
      * html/TextTrackCue.idl:
      * html/canvas/Float32Array.idl:
      * html/canvas/Float64Array.idl:
      * html/canvas/Int16Array.idl:
      * html/canvas/Int32Array.idl:
      * html/canvas/Int8Array.idl:
      * html/canvas/Uint16Array.idl:
      * html/canvas/Uint32Array.idl:
      * html/canvas/Uint8Array.idl:
      * html/canvas/Uint8ClampedArray.idl:
      * mediastream/LocalMediaStream.idl:
      * page/DOMWindow.idl:
      * page/History.idl:
      * page/Location.idl:
      * storage/StorageInfo.idl:
      * svg/SVGElement.idl:
      * svg/SVGElementInstance.idl:
      * workers/DedicatedWorkerContext.idl:
      * workers/SharedWorker.idl:
      * workers/SharedWorkerContext.idl:
      * workers/Worker.idl:
      * workers/WorkerContext.idl:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@107041 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      efee39f4
    • eae@chromium.org's avatar
      Add pixelSnappedX/Y/Width/Height methods · d6dd62fb
      eae@chromium.org authored
      https://bugs.webkit.org/show_bug.cgi?id=78040
      
      Reviewed by Eric Seidel.
      
      Add pixel snapped versions of x/y/width/height methods. These return the
      same value as the x/w/width/height methods for now but once we move over
      to sub pixel layout they will snap the subpixel value to a device pixel
      and return an integer value.
      
      When snapping the left and top edge is simply rounded to the nearest
      device pixel.
      The right and bottom edges are computed by subtracting the rounded left/
      top edge from the precise location and size. This ensures that the edges
      all line up with device pixels and that the total size of an object,
      including borders, is at most one pixel off.
      
      In summary, the values are computed as follows:
              x: round(x)
              y: round(y)
              maxX: round(x + width)
              maxY: round(y + height)
              width: round(x + width) - round(x)
              height: round(y + height) - round(y)
      
      We use the term pixel snapped to indicate that the numbers are not merely
      rounded. This also matches the naming used by the line box tree.
      
      No new tests, no functionality changes.
      
      * page/PrintContext.cpp:
      (WebCore::PrintContext::pageNumberForElement):
      * rendering/RenderBlock.cpp:
      (WebCore::::collectIfNeeded):
      * rendering/RenderBlock.h:
      (RenderBlock):
      (WebCore::RenderBlock::pixelSnappedLogicalRightOffsetForLine):
      (WebCore::RenderBlock::pixelSnappedLogicalLeftOffsetForLine):
      (WebCore::RenderBlock::FloatingObject::pixelSnappedX):
      (WebCore::RenderBlock::FloatingObject::pixelSnappedMaxX):
      (WebCore::RenderBlock::FloatingObject::pixelSnappedY):
      (WebCore::RenderBlock::FloatingObject::pixelSnappedMaxY):
      (WebCore::RenderBlock::FloatingObject::pixelSnappedWidth):
      (WebCore::RenderBlock::FloatingObject::pixelSnappedHeight):
      (FloatingObject):
      (WebCore::RenderBlock::pixelSnappedLogicalTopForFloat):
      (WebCore::RenderBlock::pixelSnappedLogicalBottomForFloat):
      (WebCore::RenderBlock::pixelSnappedLogicalLeftForFloat):
      (WebCore::RenderBlock::pixelSnappedLogicalRightForFloat):
      * rendering/RenderBlockLineLayout.cpp:
      (WebCore::LineWidth::shrinkAvailableWidthForNewFloatIfNeeded):
      * rendering/RenderBox.cpp:
      (WebCore::RenderBox::pixelSnappedClientWidth):
      (WebCore):
      (WebCore::RenderBox::pixelSnappedClientHeight):
      (WebCore::RenderBox::scrollHeight):
      * rendering/RenderBox.h:
      (WebCore::RenderBox::pixelSnappedWidth):
      (WebCore::RenderBox::pixelSnappedHeight):
      (RenderBox):
      (WebCore::RenderBox::pixelSnappedOffsetWidth):
      (WebCore::RenderBox::pixelSnappedOffsetHeight):
      (WebCore::RenderBox::clientLogicalWidth):
      (WebCore::RenderBox::clientLogicalHeight):
      * rendering/RenderBoxModelObject.cpp:
      (WebCore::RenderBoxModelObject::pixelSnappedOffsetWidth):
      (WebCore):
      (WebCore::RenderBoxModelObject::pixelSnappedOffsetHeight):
      * rendering/RenderBoxModelObject.h:
      (WebCore::RenderBoxModelObject::pixelSnappedOffsetLeft):
      (WebCore::RenderBoxModelObject::pixelSnappedOffsetTop):
      (RenderBoxModelObject):
      * rendering/RenderLayer.cpp:
      (WebCore::RenderLayer::pixelSnappedScrollWidth):
      (WebCore):
      (WebCore::RenderLayer::pixelSnappedScrollHeight):
      (WebCore::RenderLayer::computeScrollDimensions):
      (WebCore::RenderLayer::updateScrollInfoAfterLayout):
      * rendering/RenderLayer.h:
      (RenderLayer):
      * rendering/RenderListBox.cpp:
      (WebCore::RenderListBox::scrollHeight):
      * rendering/RenderTheme.cpp:
      (WebCore::RenderTheme::volumeSliderOffsetFromMuteButton):
      * rendering/RenderTreeAsText.cpp:
      (WebCore::write):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@107032 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      d6dd62fb
    • andersca@apple.com's avatar
      Use the non-fast-scrollable region to detect when we can't do fast scrolling · 858c9c88
      andersca@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=78056
      <rdar://problem/10247932>
      
      Reviewed by Sam Weinig.
      
      * page/scrolling/ScrollingCoordinator.cpp:
      (WebCore::ScrollingCoordinator::frameViewLayoutUpdated):
      Actually set the non-fast scrollable region on the scrolling tree state.
      
      * page/scrolling/ScrollingTree.cpp:
      (WebCore::ScrollingTree::tryToHandleWheelEvent):
      Check if the wheel event's position is inside the non-fast-scrollable region
      and return false if it is.
      
      (WebCore::ScrollingTree::updateMainFrameScrollPosition):
      Store the cached main frame scroll position so we can use it in tryToHandleWheelEvent.
      
      * platform/graphics/Region.cpp:
      * platform/graphics/Region.h:
      Add a simple contains(const IntPoint&) member function.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@107013 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      858c9c88
    • andersca@apple.com's avatar
      Scrolling tree should keep track of region we can't do fast scrolling for · 6c3da667
      andersca@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=78050
      
      Reviewed by Dan Bernstein.
      
      We currently won't do fast scrolling for subframes and other types of scrollable areas.
      Because of this, we'll have the scrolling tree keep a region of the page for which we can't
      do fast scrolling. This region will be updated after layout.
      
      * page/FrameView.cpp:
      (WebCore::FrameView::scrollableAreaBoundingBox):
      Return the bounding box.
      
      * page/scrolling/ScrollingCoordinator.cpp:
      (WebCore::ScrollingCoordinator::frameViewLayoutUpdated):
      Go through all the scrollable areas in this frame view and compute the region which we can't do
      fast scrolling for.
      
      * page/scrolling/ScrollingTree.cpp:
      (WebCore::ScrollingTree::commitNewTreeState):
      Update the non-fast-scrollable region.
      
      * page/scrolling/ScrollingTreeState.cpp:
      (WebCore::ScrollingTreeState::setNonFastScrollableRegion):
      Set the non-fast-scrollable region if it's changed.
      
      * platform/ScrollableArea.h:
      Add scrollableAreaBoundingBox member function.
      
      * rendering/RenderLayer.cpp:
      (WebCore::RenderLayer::scrollableAreaBoundingBox):
      Return the bounding box.
      
      * rendering/RenderListBox.cpp:
      (WebCore::RenderListBox::scrollableAreaBoundingBox):
      Return the bounding box.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@107001 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      6c3da667
    • andersca@apple.com's avatar
      ScrollableAreaSet should be moved from Page to FrameView · 11a1a75a
      andersca@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=62762
      
      Reviewed by Beth Dakin.
      
      Source/WebCore:
      
      It makes more sense for the set of scrollable areas to be per frame view instead of per page;
      scrollable areas are associated with a containing frame view and their lifecycle follows the lifecycle of the
      frame view much more closely. This could even fix a bunch of crashes where a scrollable area outlived its containing page.
      
      * WebCore.exp.in:
      Replace the Page member functions with FrameView member functions instead.
      
      * page/EventHandler.cpp:
      (WebCore::EventHandler::mouseMoved):
      Check if the frame view contains the given layer.
      
      (WebCore::EventHandler::updateMouseEventTargetNode):
      Ditto.
      
      * page/FocusController.cpp:
      (WebCore::contentAreaDidShowOrHide):
      Add helper function.
      
      (WebCore::FocusController::setContainingWindowIsVisible):
      Call contentAreaDidShowOrHide for the main frame view, and for all scrollable areas
      inside all subframe views.
      
      * page/FrameView.cpp:
      (WebCore::FrameView::FrameView):
      Use early returns to make the code more clear. Also, don't add the scrollable area to the set here.
      
      (WebCore::FrameView::~FrameView):
      Don't remove the scrollable area here.
      
      (WebCore::FrameView::zoomAnimatorTransformChanged):
      m_page is gone so use m_frame->page() instead.
      
      (WebCore::FrameView::setAnimatorsAreActive):
      Call ScrollAnimator::setIsActive for all the scrollable areas in this frame view. Previously we used to do
      this for all scrollable areas on the page, but since setAnimatorsAreActive will be called for each document,
      this will be done implicitly.
      
      (WebCore::FrameView::notifyPageThatContentAreaWillPaint):
      Call ScrollableArea::contentDidPaint for this frame view and all its immediate scrollable areas. Previously, we used
      to do this for all scrollable areas on the page, but we only need to do it for this frame view.
      
      (WebCore::FrameView::scrollAnimatorEnabled):
      Get the page from m_frame since m_page is gone.
      
      (WebCore::FrameView::addScrollableArea):
      (WebCore::FrameView::removeScrollableArea):
      (WebCore::FrameView::containsScrollableArea):
      Move these member functions here from Page.
      
      (WebCore::FrameView::addChild):
      If we are adding a frame view, add it to the scrollable area set.
      
      (WebCore::FrameView::removeChild):
      If we are removing a frame view, remove it from the scrollable area set.
      
      * page/FrameView.h:
      Move the member function declarations and the scrollable area set member variable here from Page.
      
      * page/Page.cpp:
      (WebCore::Page::~Page):
      Don't call disconnectPage on the scrollable areas anymore.
      
      * platform/ScrollView.h:
      (ScrollView):
      Make addChild and removeChild virtual.
      
      * platform/ScrollableArea.h:
      Remove disconnectFromPage.
      
      * rendering/RenderLayer.cpp:
      (WebCore::RenderLayer::RenderLayer):
      (WebCore::RenderLayer::~RenderLayer):
      (WebCore::RenderLayer::styleChanged):
      The frame view now keeps track of the scrollable areas.
      
      * rendering/RenderLayer.h:
      Remove the page member variable and disconnectFromPage.
      
      * rendering/RenderListBox.cpp:
      (WebCore::RenderListBox::RenderListBox):
      (WebCore::RenderListBox::~RenderListBox):
      The frame view now keeps track of the scrollable areas.
      
      * rendering/RenderListBox.h:
      Remove the page member variable and disconnectFromPage.
      
      Source/WebKit/chromium:
      
      Update for changes to WebCore now that the scrollable area set is kept per frame view.
      
      * src/ScrollbarGroup.cpp:
      (WebKit::ScrollbarGroup::ScrollbarGroup):
      (WebKit::ScrollbarGroup::~ScrollbarGroup):
      * src/ScrollbarGroup.h:
      (WebCore):
      (ScrollbarGroup):
      * src/WebPluginContainerImpl.cpp:
      (WebKit::WebPluginContainerImpl::scrollbarGroup):
      
      Source/WebKit2:
      
      * WebProcess/Plugins/PDF/BuiltInPDFView.cpp:
      (WebKit::BuiltInPDFView::initialize):
      Call FrameView::addScrollableArea instead.
      
      (WebKit::BuiltInPDFView::destroy):
      Call FrameView::removeScrollableArea instead.
      
      * WebProcess/Plugins/PDF/BuiltInPDFView.h:
      Remove disconnectFromPage since it no longer exists on ScrollableArea.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@106977 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      11a1a75a
    • apavlov@chromium.org's avatar
      [CRASH] bool EventHandler::dispatchSyntheticTouchEventIfEnabled(const... · af67674c
      apavlov@chromium.org authored
      [CRASH] bool EventHandler::dispatchSyntheticTouchEventIfEnabled(const PlatformMouseEvent& event) references a NULL pointer
      https://bugs.webkit.org/show_bug.cgi?id=77953
      
      Reviewed by Andreas Kling.
      
      * page/EventHandler.cpp:
      (WebCore::EventHandler::dispatchSyntheticTouchEventIfEnabled):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@106916 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      af67674c
    • haraken@chromium.org's avatar
      Unreviewed, rolling out r106912. · ad679e46
      haraken@chromium.org authored
      http://trac.webkit.org/changeset/106912
      https://bugs.webkit.org/show_bug.cgi?id=77947
      
      "AppleWebKit build is broken" (Requested by haraken on
      #webkit).
      
      Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-02-07
      
      Source/WebCore:
      
      * dom/ScriptExecutionContext.cpp:
      (WebCore::ScriptExecutionContext::~ScriptExecutionContext):
      (WebCore):
      * dom/ScriptExecutionContext.h:
      (WebCore):
      (ScriptExecutionContext):
      * html/DOMURL.cpp:
      (WebCore::DOMURL::DOMURL):
      (WebCore):
      (WebCore::DOMURL::~DOMURL):
      (WebCore::DOMURL::contextDestroyed):
      (WebCore::DOMURL::createObjectURL):
      (WebCore::DOMURL::revokeObjectURL):
      * html/DOMURL.h:
      (WebCore::DOMURL::create):
      (DOMURL):
      * html/DOMURL.idl:
      * html/PublicURLManager.h: Removed.
      * page/DOMWindow.cpp:
      (WebCore):
      (WebCore::DOMWindow::webkitURL):
      * page/DOMWindow.h:
      (DOMWindow):
      * page/DOMWindow.idl:
      * workers/WorkerContext.cpp:
      (WebCore):
      (WebCore::WorkerContext::webkitURL):
      * workers/WorkerContext.h:
      (WorkerContext):
      * workers/WorkerContext.idl:
      
      LayoutTests:
      
      * fast/dom/DOMURL/check-instanceof-domurl-functions-expected.txt: Removed.
      * fast/dom/DOMURL/check-instanceof-domurl-functions.html: Removed.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@106914 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      ad679e46
    • commit-queue@webkit.org's avatar
      Migrate createObjectURL & revokeObjectURL to static (Class) methods. · 19047ab7
      commit-queue@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=74386
      
      Patch by Kaustubh Atrawalkar <kaustubh@motorola.com> on 2012-02-07
      Reviewed by David Levin.
      
      Source/WebCore:
      
      Test: fast/dom/DOMURL/check-instanceof-domurl-functions.html
      Already Existing:
          fast/files/revoke-blob-url.html
          fast/dom/window-domurl-crash.html
          fast/files/apply-blob-url-to-img.html
          fast/files/create-blob-url-crash.html
          fast/files/workers/inline-worker-via-blob-url.html
      
      * dom/ScriptExecutionContext.cpp:
      (WebCore::ScriptExecutionContext::fileThread):
      (WebCore):
      (WebCore::ScriptExecutionContext::publicURLManager):
      * dom/ScriptExecutionContext.h:
      (WebCore):
      (ScriptExecutionContext):
      * html/DOMURL.cpp:
      (WebCore):
      (WebCore::DOMURL::createObjectURL): Changed to static.
      (WebCore::DOMURL::revokeObjectURL): ditto.
      * html/DOMURL.h:
      (DOMURL):
      (WebCore::DOMURL::create):
      * html/DOMURL.idl:
      * html/PublicURLManager.h: Added.
      (WebCore):
      (PublicURLManager):
      (WebCore::PublicURLManager::create):
      (WebCore::PublicURLManager::contextDestroyed):
      (WebCore::PublicURLManager::blobURLs):
      (WebCore::PublicURLManager::streamURLs):
      * page/DOMWindow.cpp: Removed object initialization for DOMURL.
      (WebCore):
      * page/DOMWindow.h: ditto.
      (DOMWindow):
      * page/DOMWindow.idl:
      * workers/WorkerContext.cpp:
      (WebCore):
      * workers/WorkerContext.h:
      (WorkerContext):
      * workers/WorkerContext.idl:
      
      LayoutTests:
      
      Added test to check if createObjectURL & revokeObjectURL are static functions.
      
      * fast/dom/DOMURL/check-instanceof-domurl-functions-expected.txt: Added.
      * fast/dom/DOMURL/check-instanceof-domurl-functions.html: Added.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@106912 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      19047ab7
  3. 06 Feb, 2012 16 commits
    • wangxianzhu@chromium.org's avatar
      Avoid Page::updateViewportArguments() if the causing frame is not the main frame · 8a6966f7
      wangxianzhu@chromium.org authored
      https://bugs.webkit.org/show_bug.cgi?id=77387
      
      Reviewed by Kenneth Rohde Christiansen.
      
      * dom/Document.cpp:
      (WebCore::Document::processViewport):
      (WebCore::Document::updateViewportArguments):
      (WebCore::Document::setInPageCache):
      * dom/Document.h:
      (Document):
      * html/HTMLBodyElement.cpp:
      (WebCore::HTMLBodyElement::insertedIntoDocument):
      * page/Frame.cpp:
      (WebCore::Frame::setDocument):
      * page/Page.cpp:
      (WebCore::Page::viewportArguments):
      (WebCore):
      * page/Page.h:
      (Page):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@106899 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      8a6966f7
    • haraken@chromium.org's avatar
      Rename [DontCheckEnums], [ReturnsNew], [DoNotCheckDomainSecurityOnGet], · c51b24cf
      haraken@chromium.org authored
      [DoNotCheckDomainSecurityOnSet] and [ImplementationFunction] IDLs
      https://bugs.webkit.org/show_bug.cgi?id=77852
      
      Reviewed by Adam Barth.
      
      This patch renames [DontCheckEnums], [ReturnsNew], [DoNotCheckDomainSecurityOnGet],
      [DoNotCheckDomainSecurityOnSet] and [ImplementationFunction] IDLs for clarification.
      
      [DontCheckEnums] => [DoNotCheckConstants]  (This IDL inserts assertions to check if a
      constant value is equal to the expected constant value)
      [ReturnsNew] => [ReturnNewObject] (For clarification)
      [DoNotCheckDomainSecurityOnGet] => [DoNotCheckDomainSecurityOnGetter] (For naming consistency
      with other [*Getter] IDLs)
      [DoNotCheckDomainSecurityOnSet] => [DoNotCheckDomainSecurityOnSetter] (For naming consistency
      with other [*Setter] IDLs)
      [ImplementationFunction=] => [ImplementedAs=] (For clarification. This IDL specifies a method
      name in implementation)
      
      No tests. No change in behavior.
      
      * bindings/scripts/CodeGenerator.pm:
      (ShouldCheckEnums):
      (GenerateCompileTimeCheckForEnumsIfNeeded):
      * bindings/scripts/CodeGeneratorJS.pm:
      (GenerateHeader):
      (GenerateImplementation):
      (NativeToJSValue):
      * bindings/scripts/CodeGeneratorV8.pm:
      (GenerateSingleBatchedAttribute):
      (GenerateFunctionCallString):
      (NativeToJSValue):
      
      * bindings/scripts/test/TestObj.idl:
      * bindings/scripts/test/TestTypedArray.idl:
      
      * bindings/scripts/test/JS/JSTestInterface.cpp:
      (WebCore):
      * bindings/scripts/test/JS/JSTestObj.cpp:
      (WebCore):
      * bindings/scripts/test/V8/V8TestInterface.cpp:
      (WebCore):
      * bindings/scripts/test/V8/V8TestObj.cpp:
      (WebCore):
      
      * css/WebKitCSSFilterValue.idl:
      * css/WebKitCSSTransformValue.idl:
      * dom/DOMCoreException.idl:
      * dom/Document.idl:
      * dom/EventException.idl:
      * dom/RangeException.idl:
      * fileapi/FileException.idl:
      * fileapi/OperationNotAllowedException.idl:
      * html/HTMLFormElement.idl:
      * html/canvas/Float32Array.idl:
      * html/canvas/Float64Array.idl:
      * html/canvas/Int16Array.idl:
      * html/canvas/Int32Array.idl:
      * html/canvas/Int8Array.idl:
      * html/canvas/OESStandardDerivatives.idl:
      * html/canvas/OESVertexArrayObject.idl:
      * html/canvas/Uint16Array.idl:
      * html/canvas/Uint32Array.idl:
      * html/canvas/Uint8Array.idl:
      * html/canvas/Uint8ClampedArray.idl:
      * html/canvas/WebGLCompressedTextures.idl:
      * html/canvas/WebGLDebugRendererInfo.idl:
      * html/canvas/WebGLRenderingContext.idl:
      * inspector/JavaScriptCallFrame.idl:
      * loader/appcache/DOMApplicationCache.idl:
      * page/Console.idl:
      * page/DOMWindow.idl:
      * page/Location.idl:
      * storage/IDBCursor.idl:
      * storage/IDBDatabaseException.idl:
      * storage/IDBObjectStore.idl:
      * storage/SQLException.idl:
      * svg/SVGComponentTransferFunctionElement.idl:
      * svg/SVGException.idl:
      * svg/SVGFEBlendElement.idl:
      * svg/SVGFEColorMatrixElement.idl:
      * svg/SVGFECompositeElement.idl:
      * svg/SVGFEConvolveMatrixElement.idl:
      * svg/SVGFEDisplacementMapElement.idl:
      * svg/SVGFEMorphologyElement.idl:
      * svg/SVGFETurbulenceElement.idl:
      * svg/SVGGradientElement.idl:
      * xml/XMLHttpRequestException.idl:
      * xml/XPathException.idl:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@106892 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      c51b24cf
    • haraken@chromium.org's avatar
      Unreviewed, rolling out r106883. · 768a22ba
      haraken@chromium.org authored
      http://trac.webkit.org/changeset/106883
      https://bugs.webkit.org/show_bug.cgi?id=77852
      
      build failure around Chromium V8 bindings
      
      * bindings/scripts/CodeGenerator.pm:
      (ShouldCheckEnums):
      (GenerateCompileTimeCheckForEnumsIfNeeded):
      * bindings/scripts/CodeGeneratorJS.pm:
      (GenerateHeader):
      (GenerateImplementation):
      (NativeToJSValue):
      * bindings/scripts/CodeGeneratorV8.pm:
      (GenerateSingleBatchedAttribute):
      (GenerateFunctionCallString):
      (NativeToJSValue):
      * bindings/scripts/test/JS/JSTestInterface.cpp:
      (WebCore):
      * bindings/scripts/test/JS/JSTestObj.cpp:
      (WebCore):
      * bindings/scripts/test/TestObj.idl:
      * bindings/scripts/test/TestTypedArray.idl:
      * bindings/scripts/test/V8/V8TestInterface.cpp:
      (WebCore):
      * bindings/scripts/test/V8/V8TestObj.cpp:
      (WebCore):
      * css/WebKitCSSFilterValue.idl:
      * css/WebKitCSSTransformValue.idl:
      * dom/DOMCoreException.idl:
      * dom/Document.idl:
      * dom/EventException.idl:
      * dom/RangeException.idl:
      * fileapi/FileException.idl:
      * fileapi/OperationNotAllowedException.idl:
      * html/HTMLFormElement.idl:
      * html/canvas/Float32Array.idl:
      * html/canvas/Float64Array.idl:
      * html/canvas/Int16Array.idl:
      * html/canvas/Int32Array.idl:
      * html/canvas/Int8Array.idl:
      * html/canvas/OESStandardDerivatives.idl:
      * html/canvas/OESVertexArrayObject.idl:
      * html/canvas/Uint16Array.idl:
      * html/canvas/Uint32Array.idl:
      * html/canvas/Uint8Array.idl:
      * html/canvas/Uint8ClampedArray.idl:
      * html/canvas/WebGLCompressedTextures.idl:
      * html/canvas/WebGLDebugRendererInfo.idl:
      * html/canvas/WebGLRenderingContext.idl:
      * inspector/JavaScriptCallFrame.idl:
      * loader/appcache/DOMApplicationCache.idl:
      * page/Console.idl:
      * page/DOMWindow.idl:
      * page/Location.idl:
      * storage/IDBCursor.idl:
      * storage/IDBDatabaseException.idl:
      * storage/IDBObjectStore.idl:
      * storage/SQLException.idl:
      * svg/SVGComponentTransferFunctionElement.idl:
      * svg/SVGException.idl:
      * svg/SVGFEBlendElement.idl:
      * svg/SVGFEColorMatrixElement.idl:
      * svg/SVGFECompositeElement.idl:
      * svg/SVGFEConvolveMatrixElement.idl:
      * svg/SVGFEDisplacementMapElement.idl:
      * svg/SVGFEMorphologyElement.idl:
      * svg/SVGFETurbulenceElement.idl:
      * svg/SVGGradientElement.idl:
      * xml/XMLHttpRequestException.idl:
      * xml/XPathException.idl:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@106889 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      768a22ba
    • leviw@chromium.org's avatar
      Correct usage of LayoutUnits in dom, editing, page, accessibility, inspector, and loader · b00d4820
      leviw@chromium.org authored
      https://bugs.webkit.org/show_bug.cgi?id=77891
      
      Reviewed by Darin Adler.
      
      Updating the usage of LayoutUnits in the dom, editing, page, accessibility, inspector, and loader
      directories to properly use LayoutUnits vs ints.
      
      No new tests. No new behavior.
      
      * accessibility/AccessibilityObject.h:
      (WebCore::AccessibilityObject::boundsForVisiblePositionRange):
      (WebCore::AccessibilityObject::doAXBoundsForRange):
      * accessibility/AccessibilityRenderObject.cpp:
      (WebCore::AccessibilityRenderObject::isOffScreen):
      (WebCore::AccessibilityRenderObject::clickPoint):
      (WebCore::AccessibilityRenderObject::boundsForVisiblePositionRange):
      (WebCore::AccessibilityRenderObject::doAXBoundsForRange):
      (WebCore::AccessibilityRenderObject::accessibilityImageMapHitTest):
      * accessibility/AccessibilityRenderObject.h:
      (AccessibilityRenderObject):
      * accessibility/AccessibilitySlider.cpp:
      (WebCore::AccessibilitySlider::elementAccessibilityHitTest):
      * accessibility/AccessibilitySlider.h:
      (AccessibilitySlider):
      * accessibility/mac/WebAccessibilityObjectWrapper.mm:
      (-[WebAccessibilityObjectWrapper accessibilityShowContextMenu]):
      * css/CSSComputedStyleDeclaration.cpp:
      (WebCore::computedTransform):
      (WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):
      * dom/Clipboard.h:
      (WebCore::Clipboard::dragLocation):
      (Clipboard):
      * dom/DocumentMarkerController.cpp:
      (WebCore::DocumentMarkerController::renderedRectsForMarkers):
      * dom/DocumentMarkerController.h:
      * dom/Element.cpp:
      (WebCore::Element::screenRect):
      * dom/Element.h:
      (Element):
      * editing/Editor.cpp:
      (WebCore::Editor::rangeForPoint):
      (WebCore::Editor::firstRectForRange):
      * editing/RenderedPosition.cpp:
      (WebCore::RenderedPosition::absoluteRect):
      * editing/RenderedPosition.h:
      (WebCore::RenderedPosition::absoluteRect):
      (RenderedPosition):
      * editing/VisiblePosition.h:
      (VisiblePosition):
      * inspector/DOMNodeHighlighter.cpp:
      * loader/SubframeLoader.cpp:
      (WebCore::SubframeLoader::createJavaAppletWidget):
      * loader/SubframeLoader.h:
      (SubframeLoader):
      * page/EventHandler.cpp:
      (WebCore::EventHandler::handleMousePressEvent):
      * page/Frame.cpp:
      (WebCore::Frame::nodeImage):
      * page/win/FrameCGWin.cpp:
      (WebCore::Frame::nodeImage):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@106884 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      b00d4820
    • haraken@chromium.org's avatar
      Rename [DontCheckEnums], [ReturnsNew], [DoNotCheckDomainSecurityOnGet], · 3d1bedd8
      haraken@chromium.org authored
      [DoNotCheckDomainSecurityOnSet] and [ImplementationFunction] IDLs
      https://bugs.webkit.org/show_bug.cgi?id=77852
      
      Reviewed by Adam Barth.
      
      This patch renames [DontCheckEnums], [ReturnsNew], [DoNotCheckDomainSecurityOnGet],
      [DoNotCheckDomainSecurityOnSet] and [ImplementationFunction] IDLs for clarification.
      
      [DontCheckEnums] => [DoNotCheckConstants]  (This IDL inserts assertions to check if a
      constant value is equal to the expected constant value)
      [ReturnsNew] => [ReturnNewObject] (For clarification)
      [DoNotCheckDomainSecurityOnGet] => [DoNotCheckDomainSecurityOnGetter] (For naming consistency
      with other [*Getter] IDLs)
      [DoNotCheckDomainSecurityOnSet] => [DoNotCheckDomainSecurityOnSetter] (For naming consistency
      with other [*Setter] IDLs)
      [ImplementationFunction=] => [ImplementedAs=] (For clarification. This IDL specifies a method
      name in implementation)
      
      No tests. No change in behavior.
      
      * bindings/scripts/CodeGenerator.pm:
      (ShouldCheckEnums):
      (GenerateCompileTimeCheckForEnumsIfNeeded):
      * bindings/scripts/CodeGeneratorJS.pm:
      (GenerateHeader):
      (GenerateImplementation):
      (NativeToJSValue):
      * bindings/scripts/CodeGeneratorV8.pm:
      (GenerateSingleBatchedAttribute):
      (GenerateFunctionCallString):
      (NativeToJSValue):
      
      * bindings/scripts/test/TestObj.idl:
      * bindings/scripts/test/TestTypedArray.idl:
      
      * bindings/scripts/test/JS/JSTestInterface.cpp: Updated run-bindings-tests results.
      (WebCore):
      * bindings/scripts/test/JS/JSTestObj.cpp: Ditto.
      (WebCore):
      * bindings/scripts/test/V8/V8TestInterface.cpp: Ditto.
      (WebCore):
      * bindings/scripts/test/V8/V8TestObj.cpp: Ditto.
      (WebCore):
      
      * bindings/scripts/test/TestObj.idl:
      * bindings/scripts/test/TestTypedArray.idl:
      * css/WebKitCSSFilterValue.idl:
      * css/WebKitCSSTransformValue.idl:
      * dom/DOMCoreException.idl:
      * dom/Document.idl:
      * dom/EventException.idl:
      * dom/RangeException.idl:
      * fileapi/FileException.idl:
      * fileapi/OperationNotAllowedException.idl:
      * html/HTMLFormElement.idl:
      * html/canvas/Float32Array.idl:
      * html/canvas/Float64Array.idl:
      * html/canvas/Int16Array.idl:
      * html/canvas/Int32Array.idl:
      * html/canvas/Int8Array.idl:
      * html/canvas/OESStandardDerivatives.idl:
      * html/canvas/OESVertexArrayObject.idl:
      * html/canvas/Uint16Array.idl:
      * html/canvas/Uint32Array.idl:
      * html/canvas/Uint8Array.idl:
      * html/canvas/Uint8ClampedArray.idl:
      * html/canvas/WebGLCompressedTextures.idl:
      * html/canvas/WebGLDebugRendererInfo.idl:
      * html/canvas/WebGLRenderingContext.idl:
      * inspector/JavaScriptCallFrame.idl:
      * loader/appcache/DOMApplicationCache.idl:
      * page/Console.idl:
      * page/DOMWindow.idl:
      * page/Location.idl:
      * storage/IDBCursor.idl:
      * storage/IDBDatabaseException.idl:
      * storage/IDBObjectStore.idl:
      * storage/SQLException.idl:
      * svg/SVGComponentTransferFunctionElement.idl:
      * svg/SVGException.idl:
      * svg/SVGFEBlendElement.idl:
      * svg/SVGFEColorMatrixElement.idl:
      * svg/SVGFECompositeElement.idl:
      * svg/SVGFEConvolveMatrixElement.idl:
      * svg/SVGFEDisplacementMapElement.idl:
      * svg/SVGFEMorphologyElement.idl:
      * svg/SVGFETurbulenceElement.idl:
      * svg/SVGGradientElement.idl:
      * xml/XMLHttpRequestException.idl:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@106883 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      3d1bedd8
    • commit-queue@webkit.org's avatar
      Add webGLErrorsToConsoleEnabled Settings flag · 4e75437a
      commit-queue@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=77696
      
      Patch by Gregg Tavares <gman@google.com> on 2012-02-06
      Reviewed by Kenneth Russell.
      
      No new tests as there is no change in behavior.
      
      * html/canvas/WebGLRenderingContext.cpp:
      (WebCore):
      (WebCore::WebGLRenderingContext::setupFlags):
      * page/Settings.cpp:
      (WebCore::Settings::Settings):
      * page/Settings.h:
      (Settings):
      (WebCore::Settings::webGLErrorsToConsoleEnabled):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@106881 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      4e75437a
    • andersca@apple.com's avatar
      Source/WebCore: Overlay scrollbars flash when window is simply activated · e760514a
      andersca@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=77911
      <rdar://problem/10211995>
      
      Reviewed by Kenneth Russell.
      
      Add a new member function, FocusController::setContainingWindowIsVisible, and move the code
      that calls ScrollableArea::contentAreaDidShow/ScrollableArea::contentAreaDidHide there, since
      we only want to flash scrollers when the window becomes visible.
      
      * WebCore.exp.in:
      * page/FocusController.cpp:
      (WebCore::FocusController::FocusController):
      (WebCore::FocusController::setActive):
      (WebCore::FocusController::setContainingWindowIsVisible):
      (WebCore):
      * page/FocusController.h:
      (FocusController):
      (WebCore::FocusController::containingWindowIsVisible):
      
      * platform/mac/ScrollAnimatorMac.mm:
      (-[WebScrollbarPainterControllerDelegate scrollerImpPair:setContentAreaNeedsDisplayInRect:]):
      Call ScrollAnimatorMac::contentAreaWillPaint here, since that will trigger AppKit to flash the scrollers.
      
      Source/WebKit/mac: Overlay scrollbars flash when window is simply activated
      https://bugs.webkit.org/show_bug.cgi?id=77911
      <rdar://problem/10211995>
      
      Reviewed by Kenneth Russell.
      
      * WebView/WebView.mm:
      (-[WebView _windowWillOrderOnScreen:]):
      (-[WebView _windowWillOrderOffScreen:]):
      Call FocusController::setContainingWindowIsVisible.
      
      Source/WebKit2: Overlay scrollbars flash when window is simply activated
      https://bugs.webkit.org/show_bug.cgi?id=77911
      
      Reviewed by Kenneth Russell.
      
      * UIProcess/API/mac/WKView.mm:
      (-[WKView _updateWindowVisibility]):
      Use -[NSWindow isVisible] here, since we also want to consider the window hidden if the application itself is hidden.
      
      (-[WKView _windowDidOrderOffScreen:]):
      (-[WKView _windowDidOrderOnScreen:]):
      Call -[WKView updateWindowVisibility].
      
      * WebProcess/WebPage/WebPage.cpp:
      (WebKit::WebPage::setWindowIsVisible):
      Call FocusController::setContainingWindowIsVisible.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@106875 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      e760514a
    • commit-queue@webkit.org's avatar
      postMessage leaks MemoryEvent object · a8de6aa5
      commit-queue@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=77893
      
      Patch by Greg Simon <gregsimon@chromium.org> on 2012-02-06
      Reviewed by Adam Barth.
      
      Changed from PassRefPtr().leakRef() to RefPtr.get() when
      calling into FrameLoaderClient to stop +1 extra ref.
      
      * page/DOMWindow.cpp:
      (WebCore::DOMWindow::postMessageTimerFired):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@106874 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      a8de6aa5
    • jochen@chromium.org's avatar
      Before accessing a frame's script controller in V8 bindings, first check that... · 9d58c55e
      jochen@chromium.org authored
      Before accessing a frame's script controller in V8 bindings, first check that the frame actually exists
      https://bugs.webkit.org/show_bug.cgi?id=77370
      
      Reviewed by Adam Barth.
      
      I don't have a working reproduction of the crash yet. As soon as I have
      one,  I will add new layout tests.
      
      * bindings/v8/PageScriptDebugServer.cpp:
      (WebCore::PageScriptDebugServer::addListener):
      * bindings/v8/ScheduledAction.cpp:
      (WebCore::ScheduledAction::execute):
      * bindings/v8/ScriptCachedFrameData.cpp:
      (WebCore::ScriptCachedFrameData::restore):
      * page/DOMTimer.cpp:
      (WebCore::DOMTimer::DOMTimer): remove temporary debug code
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@106846 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      9d58c55e
    • andersca@apple.com's avatar
      Wheel event handler count not updated when adding handlers to the window · 639303ac
      andersca@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=77895
      
      Reviewed by Dan Bernstein.
      
      Source/WebCore:
      
      Test: fast/events/wheelevent-handler-count.html
      
      * page/DOMWindow.cpp:
      (WebCore::DOMWindow::addEventListener):
      (WebCore::DOMWindow::removeEventListener):
      Update the wheel event count.
      
      * testing/Internals.cpp:
      (WebCore::Internals::wheelEventHandlerCount):
      * testing/Internals.h:
      * testing/Internals.idl:
      Add wheelEventHandlerCount to window.internals.
      
      LayoutTests:
      
      * fast/events/wheelevent-handler-count-expected.txt: Added.
      * fast/events/wheelevent-handler-count.html: Added.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@106839 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      639303ac
    • caio.oliveira@openbossa.org's avatar
      Provide more attribute methods in Element · 5fc3ab92
      caio.oliveira@openbossa.org authored
      https://bugs.webkit.org/show_bug.cgi?id=77800
      
      Reviewed by Ryosuke Niwa.
      
      Source/WebCore:
      
      Reduce the clients of NamedNodeMap. This will make easier to change the
      implementation of our attribute storage. The clients now use Element methods
      that expose Attribute* accessors.
      
      Instead of checking the existence of NamedNodeMap, clients can call
      hasAttributes() or hasAttributesWithoutUpdate() (that skips updating invalid
      style or animation svg attributes).
      
      If there are attributes, they can be accessed by index via attributeCount() /
      attributeItem(), as well as by QualifiedName. Those accessors assume there are an
      attribute storage.
      
      * css/SelectorChecker.cpp:
      (WebCore::anyAttributeMatches):
      (WebCore::SelectorChecker::checkOneSelector):
      * css/SelectorChecker.h:
      (WebCore::SelectorChecker::checkExactAttribute):
      * dom/DatasetDOMStringMap.cpp:
      (WebCore::DatasetDOMStringMap::getNames):
      (WebCore::DatasetDOMStringMap::item):
      (WebCore::DatasetDOMStringMap::contains):
      * dom/Document.cpp:
      (WebCore::Document::importNode): use setAttributesFromElement() instead of manually copying.
      * dom/Element.h:
      (Element):
      (WebCore::Element::hasAttributesWithoutUpdate):
      (WebCore):
      (WebCore::Element::attributeCount):
      (WebCore::Element::attributeItem):
      (WebCore::Element::getAttributeItem):
      (WebCore::Element::removeAttribute):
      * dom/Node.cpp:
      (WebCore::Node::isDefaultNamespace):
      (WebCore::Node::lookupNamespaceURI):
      (WebCore::Node::lookupNamespacePrefix):
      (WebCore::Node::compareDocumentPosition):
      * editing/ApplyStyleCommand.cpp:
      (WebCore::hasNoAttributeOrOnlyStyleAttribute):
      (WebCore::isEmptyFontTag):
      * editing/EditingStyle.cpp:
      (WebCore::EditingStyle::elementIsStyledSpanOrHTMLEquivalent):
      * editing/InsertParagraphSeparatorCommand.cpp:
      (WebCore::highestVisuallyEquivalentDivBelowRoot):
      * editing/MarkupAccumulator.cpp:
      (WebCore::MarkupAccumulator::appendElement):
      * editing/markup.cpp:
      (WebCore::completeURLs):
      (WebCore::StyledMarkupAccumulator::appendElement):
      * html/HTMLEmbedElement.cpp:
      (WebCore::HTMLEmbedElement::parametersForPlugin):
      * html/HTMLInputElement.cpp:
      (WebCore::HTMLInputElement::updateType):
      * html/HTMLObjectElement.cpp:
      (WebCore::HTMLObjectElement::parametersForPlugin):
      * html/HTMLParamElement.cpp:
      (WebCore::HTMLParamElement::isURLAttribute):
      * html/parser/HTMLFormattingElementList.cpp:
      (WebCore::attributeCountWithoutUpdate):
      (WebCore::HTMLFormattingElementList::tryToEnsureNoahsArkConditionQuickly):
      (WebCore::HTMLFormattingElementList::ensureNoahsArkCondition): Store Attribute*
      to avoid looking up the right element again by name.
      * inspector/DOMEditor.cpp:
      (WebCore::DOMEditor::innerPatchNode):
      (WebCore::DOMEditor::createDigest):
      * inspector/InspectorDOMAgent.cpp:
      (WebCore::InspectorDOMAgent::setAttributesAsText):
      (WebCore::InspectorDOMAgent::performSearch):
      (WebCore::InspectorDOMAgent::buildArrayForElementAttributes):
      * page/PageSerializer.cpp:
      (WebCore::isCharsetSpecifyingNode):
      * svg/SVGStyledElement.cpp:
      (WebCore::SVGStyledElement::getPresentationAttribute):
      * xml/XPathFunctions.cpp:
      (WebCore::XPath::FunLang::evaluate):
      * xml/XPathNodeSet.cpp:
      (WebCore::XPath::NodeSet::traversalSort):
      * xml/XPathStep.cpp:
      (WebCore::XPath::Step::nodesInAxis):
      * xml/parser/XMLDocumentParserLibxml2.cpp:
      (WebCore::XMLDocumentParser::XMLDocumentParser):
      * xml/parser/XMLTreeBuilder.cpp:
      (WebCore::XMLTreeBuilder::XMLTreeBuilder):
      
      Source/WebKit/chromium:
      
      * src/WebPageSerializerImpl.cpp:
      (WebKit::WebPageSerializerImpl::openTagToString): access attributes via Element interface.
      
      Source/WebKit/qt:
      
      * Api/qwebelement.cpp:
      (QWebElement::attributeNames): access attributes via Element interface.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@106833 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      5fc3ab92
    • jchaffraix@webkit.org's avatar
      Unreviewed, rolling out r106797 and r106806. · 33dde258
      jchaffraix@webkit.org authored
      http://trac.webkit.org/changeset/106797
      http://trac.webkit.org/changeset/106806
      https://bugs.webkit.org/show_bug.cgi?id=77888
      
      The change is still causing some crashes in webaudio/ on the
      Chromium bots (Requested by jchaffraix on #webkit).
      
      Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-02-06
      
      Source/WebCore: 
      
      * Modules/intents/IntentRequest.cpp:
      (WebCore::IntentRequest::create):
      * bindings/generic/ActiveDOMCallback.cpp:
      (WebCore::ActiveDOMCallback::ActiveDOMCallback):
      * dom/ActiveDOMObject.cpp:
      (WebCore::ActiveDOMObject::ActiveDOMObject):
      (WebCore::ActiveDOMObject::~ActiveDOMObject):
      * dom/ActiveDOMObject.h:
      (ActiveDOMObject):
      * dom/DocumentEventQueue.cpp:
      (WebCore::DocumentEventQueue::DocumentEventQueue):
      * dom/ScriptExecutionContext.cpp:
      (WebCore::ScriptExecutionContext::ScriptExecutionContext):
      (WebCore::ScriptExecutionContext::~ScriptExecutionContext):
      (WebCore::ScriptExecutionContext::canSuspendActiveDOMObjects):
      (WebCore::ScriptExecutionContext::suspendActiveDOMObjects):
      (WebCore::ScriptExecutionContext::resumeActiveDOMObjects):
      (WebCore::ScriptExecutionContext::stopActiveDOMObjects):
      * dom/ScriptExecutionContext.h:
      (ScriptExecutionContext):
      * fileapi/DOMFileSystem.cpp:
      (WebCore::DOMFileSystem::create):
      * fileapi/FileReader.cpp:
      (WebCore):
      * fileapi/FileReader.h:
      (WebCore::FileReader::create):
      * fileapi/FileWriter.cpp:
      (WebCore):
      * fileapi/FileWriter.h:
      (WebCore::FileWriter::create):
      * history/CachedFrame.cpp:
      (WebCore::CachedFrame::CachedFrame):
      * html/HTMLAudioElement.cpp:
      (WebCore::HTMLAudioElement::create):
      (WebCore::HTMLAudioElement::createForJSConstructor):
      * html/HTMLMarqueeElement.cpp:
      (WebCore::HTMLMarqueeElement::create):
      * html/HTMLVideoElement.cpp:
      (WebCore::HTMLVideoElement::create):
      * mediastream/PeerConnection.cpp:
      (WebCore::PeerConnection::create):
      * notifications/Notification.cpp:
      (WebCore::Notification::create):
      * notifications/NotificationCenter.cpp:
      * notifications/NotificationCenter.h:
      (WebCore::NotificationCenter::create):
      * page/DOMTimer.cpp:
      (WebCore::DOMTimer::install):
      (WebCore::DOMTimer::fired):
      * page/EventSource.cpp:
      (WebCore::EventSource::create):
      * page/SuspendableTimer.cpp:
      (WebCore::SuspendableTimer::SuspendableTimer):
      * storage/IDBDatabase.cpp:
      (WebCore::IDBDatabase::create):
      * storage/IDBRequest.cpp:
      (WebCore::IDBRequest::create):
      * storage/IDBTransaction.cpp:
      (WebCore::IDBTransaction::create):
      * storage/IDBVersionChangeRequest.cpp:
      (WebCore::IDBVersionChangeRequest::create):
      * webaudio/AudioContext.cpp:
      (WebCore::AudioContext::create):
      * websockets/WebSocket.cpp:
      * websockets/WebSocket.h:
      (WebCore::WebSocket::create):
      * workers/SharedWorker.cpp:
      (WebCore::SharedWorker::create):
      * workers/Worker.cpp:
      (WebCore::Worker::create):
      * xml/XMLHttpRequest.cpp:
      (WebCore::XMLHttpRequest::create):
      
      LayoutTests: 
      
      * fast/events/resources/suspend-subframe-1.html: Removed.
      * fast/events/resources/suspend-subframe-2.html: Removed.
      * fast/events/suspend-timers-expected.txt: Removed.
      * fast/events/suspend-timers.html: Removed.
      * platform/chromium/test_expectations.txt:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@106823 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      33dde258
    • haraken@chromium.org's avatar
      Rename [HasIndexGetter], [HasNameGetter] and [HasCustomIndexSetter] IDLs · 6d052a1e
      haraken@chromium.org authored
      https://bugs.webkit.org/show_bug.cgi?id=77848
      
      Reviewed by Adam Barth.
      
      For naming consistency with [CustomGetter] and [CustomSetter],
      this patch renames the following IDLs:
      
      [HasIndexGetter] => [IndexedGetter]  (Remove "Has". This IDL is for "indexed" properties
      in the Web IDL: http://dev.w3.org/2006/webapi/WebIDL/#idl-indexed-properties)
      [HasCustomIndexSetter] => [CustomIndexedSetter]  (Ditto.)
      [HasNameGetter] => [NamedGetter] (Remove "Has". This IDL is for "named" properties
      in the Web IDL: http://dev.w3.org/2006/webapi/WebIDL/#idl-named-properties)
      
      No tests. No change in behavior.
      
      * bindings/scripts/CodeGeneratorJS.pm:
      (GenerateGetOwnPropertySlotBody):
      (GenerateGetOwnPropertyDescriptorBody):
      (GenerateHeader):
      (GenerateImplementation):
      * bindings/scripts/CodeGeneratorV8.pm:
      (GenerateHeaderNamedAndIndexedPropertyAccessors):
      (GenerateImplementationIndexer):
      (GenerateImplementationNamedPropertyGetter):
      
      * bindings/scripts/test/TestEventTarget.idl: No change in run-bindings-tests results.
      * bindings/scripts/test/TestTypedArray.idl: Ditto.
      
      * Modules/gamepad/GamepadList.idl:
      * css/CSSRuleList.idl:
      * css/CSSStyleDeclaration.idl:
      * css/CSSValueList.idl:
      * css/MediaList.idl:
      * css/StyleSheetList.idl:
      * css/WebKitCSSFilterValue.idl:
      * css/WebKitCSSKeyframesRule.idl:
      * css/WebKitCSSTransformValue.idl:
      * dom/ClientRectList.idl:
      * dom/DOMStringList.idl:
      * dom/DOMStringMap.idl:
      * dom/DataTransferItemList.idl:
      * dom/NamedNodeMap.idl:
      * dom/NodeList.idl:
      * dom/TouchList.idl:
      * fileapi/EntryArray.idl:
      * fileapi/EntryArraySync.idl:
      * fileapi/FileList.idl:
      * html/DOMSettableTokenList.idl:
      * html/DOMTokenList.idl:
      * html/HTMLAllCollection.idl:
      * html/HTMLCollection.idl:
      * html/HTMLFormElement.idl:
      * html/HTMLOptionsCollection.idl:
      * html/HTMLPropertiesCollection.idl:
      * html/HTMLSelectElement.idl:
      * html/TextTrackCueList.idl:
      * html/canvas/CanvasPixelArray.idl:
      * html/canvas/Float32Array.idl:
      * html/canvas/Float64Array.idl:
      * html/canvas/Int16Array.idl:
      * html/canvas/Int32Array.idl:
      * html/canvas/Int8Array.idl:
      * html/canvas/Uint16Array.idl:
      * html/canvas/Uint32Array.idl:
      * html/canvas/Uint8Array.idl:
      * html/canvas/Uint8ClampedArray.idl:
      * html/track/TextTrackList.idl:
      * mediastream/MediaStreamList.idl:
      * mediastream/MediaStreamTrackList.idl:
      * page/SpeechInputResultList.idl:
      * page/WebKitAnimationList.idl:
      * plugins/DOMMimeTypeArray.idl:
      * plugins/DOMPlugin.idl:
      * plugins/DOMPluginArray.idl:
      * storage/Storage.idl:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@106798 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      6d052a1e
    • commit-queue@webkit.org's avatar
      Source/WebCore: Ensure timers and other active DOM objects do not fire in suspended documents. · 6e77be08
      commit-queue@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=53733
      
      ScriptExecutionContext now remembers it has suspended active DOM objects
      and suspends all newly installed active DOM objects as well.
      
      All create-calls active DOM objects now calls the post constructor method
      suspendIfNeeded that updates the suspend state. It is post constructor
      because the suspend/resume functions are virtual and thus can not be called
      from constructors.
      
      Patch by Allan Sandfeld Jensen <allan.jensen@nokia.com> on 2012-02-06
      Reviewed by Mihai Parparita.
      
      Test: fast/events/suspend-timers.html
      
      * Modules/intents/IntentRequest.cpp:
      (WebCore::IntentRequest::create):
      * bindings/generic/ActiveDOMCallback.cpp:
      (WebCore::ActiveDOMCallback::ActiveDOMCallback):
      * dom/ActiveDOMObject.cpp:
      (WebCore::ActiveDOMObject::ActiveDOMObject):
      (WebCore::ActiveDOMObject::~ActiveDOMObject):
      (WebCore::ActiveDOMObject::suspendIfNeeded):
      * dom/ActiveDOMObject.h:
      (WebCore::ActiveDOMObject::suspendIfNeededCalled):
      * dom/DocumentEventQueue.cpp:
      (WebCore::DocumentEventQueue::DocumentEventQueue):
      * dom/ScriptExecutionContext.cpp:
      (WebCore::ScriptExecutionContext::ScriptExecutionContext):
      (WebCore::ScriptExecutionContext::~ScriptExecutionContext):
      (WebCore::ScriptExecutionContext::canSuspendActiveDOMObjects):
      (WebCore::ScriptExecutionContext::suspendActiveDOMObjects):
      (WebCore::ScriptExecutionContext::resumeActiveDOMObjects):
      (WebCore::ScriptExecutionContext::stopActiveDOMObjects):
      (WebCore::ScriptExecutionContext::suspendActiveDOMObjectIfNeeded):
      * dom/ScriptExecutionContext.h:
      (WebCore::ScriptExecutionContext::activeDOMObjectsAreSuspended):
      * fileapi/DOMFileSystem.cpp:
      (WebCore::DOMFileSystem::create):
      * fileapi/FileReader.cpp:
      (WebCore::FileReader::create):
      * fileapi/FileReader.h:
      * fileapi/FileWriter.cpp:
      (WebCore::FileWriter::create):
      * fileapi/FileWriter.h:
      * history/CachedFrame.cpp:
      (WebCore::CachedFrame::CachedFrame):
      * html/HTMLAudioElement.cpp:
      (WebCore::HTMLAudioElement::create):
      * html/HTMLMarqueeElement.cpp:
      (WebCore::HTMLMarqueeElement::create):
      * html/HTMLVideoElement.cpp:
      (WebCore::HTMLVideoElement::create):
      * mediastream/PeerConnection.cpp:
      (WebCore::PeerConnection::create):
      * notifications/Notification.cpp:
      (WebCore::Notification::create):
      * notifications/NotificationCenter.cpp:
      (WebCore::NotificationCenter::create):
      * notifications/NotificationCenter.h:
      * page/DOMTimer.cpp:
      (WebCore::DOMTimer::install):
      (WebCore::DOMTimer::fired):
      * page/EventSource.cpp:
      (WebCore::EventSource::create):
      * page/SuspendableTimer.cpp:
      (WebCore::SuspendableTimer::SuspendableTimer):
      * storage/IDBDatabase.cpp:
      (WebCore::IDBDatabase::create):
      * storage/IDBRequest.cpp:
      (WebCore::IDBRequest::create):
      * storage/IDBTransaction.cpp:
      (WebCore::IDBTransaction::create):
      * webaudio/AudioContext.cpp:
      (WebCore::AudioContext::create):
      * websockets/WebSocket.cpp:
      (WebCore::WebSocket::create):
      * websockets/WebSocket.h:
      * workers/SharedWorker.cpp:
      (WebCore::SharedWorker::create):
      * workers/Worker.cpp:
      (WebCore::Worker::create):
      * xml/XMLHttpRequest.cpp:
      (WebCore::XMLHttpRequest::create):
      
      LayoutTests: Test that timers do not fire from subframes of suspended documents.
      https://bugs.webkit.org/show_bug.cgi?id=53733
      
      Patch by Allan Sandfeld Jensen <allan.jensen@nokia.com> on 2012-02-06
      Reviewed by Mihai Parparita.
      
      * fast/events/resources/suspend-subframe-1.html: Added.
      * fast/events/resources/suspend-subframe-2.html: Added.
      * fast/events/suspend-timers-expected.txt: Added.
      * fast/events/suspend-timers.html: Added.
      * platform/chromium/test_expectations.txt:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@106797 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      6e77be08
    • barraclough@apple.com's avatar
      Remove JSObject defineGetter/defineSetter lookupGetter/lookupSetter · 81aa89f0
      barraclough@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=77451
      
      Reviewed by Sam Weinig.
      
      These can now all be implemented in terms of defineOwnProperty & getPropertyDescriptor.
      Also remove initializeGetterSetterProperty, since this is equivalent to putDirectAccessor.
      
      Source/JavaScriptCore: 
      
      * JavaScriptCore.exp:
      * debugger/DebuggerActivation.cpp:
      (JSC::DebuggerActivation::defineOwnProperty):
      * debugger/DebuggerActivation.h:
      (DebuggerActivation):
      * runtime/ClassInfo.h:
      (MethodTable):
      (JSC):
      * runtime/JSBoundFunction.cpp:
      (JSC::JSBoundFunction::finishCreation):
      * runtime/JSCell.cpp:
      (JSC):
      * runtime/JSCell.h:
      (JSCell):
      * runtime/JSFunction.cpp:
      (JSC::JSFunction::getOwnPropertySlot):
      (JSC::JSFunction::getOwnPropertyDescriptor):
      * runtime/JSGlobalObject.cpp:
      (JSC::JSGlobalObject::defineOwnProperty):
      (JSC):
      * runtime/JSGlobalObject.h:
      (JSGlobalObject):
      * runtime/JSObject.cpp:
      (JSC):
      * runtime/JSObject.h:
      (JSObject):
      * runtime/ObjectPrototype.cpp:
      (JSC::objectProtoFuncDefineGetter):
      (JSC::objectProtoFuncDefineSetter):
      (JSC::objectProtoFuncLookupGetter):
      (JSC::objectProtoFuncLookupSetter):
      
      Source/WebCore: 
      
      * bindings/js/JSDOMWindowCustom.cpp:
      (WebCore):
      (WebCore::JSDOMWindow::defineOwnProperty):
      * bindings/js/JSDOMWindowShell.cpp:
      (WebCore):
      * bindings/js/JSDOMWindowShell.h:
      (JSDOMWindowShell):
      * bindings/js/JSLocationCustom.cpp:
      (WebCore::JSLocation::defineOwnProperty):
      (WebCore::JSLocationPrototype::defineOwnProperty):
      * bindings/scripts/CodeGeneratorJS.pm:
      (GenerateHeader):
      * page/DOMWindow.idl:
      * page/Location.idl:
      
      Source/WebKit/qt: 
      
      * Api/qwebframe.cpp:
      (QWebFramePrivate::addQtSenderToGlobalObject):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@106783 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      81aa89f0
    • haraken@chromium.org's avatar
      Rename [TreatNullAs=EmptyString] to [TreatNullAs=NullString], · e45cb179
      haraken@chromium.org authored
      [TreatUndefinedAs=EmptyString] to [TreatUndefinedAs=NullString]
      https://bugs.webkit.org/show_bug.cgi?id=77611
      
      Reviewed by Adam Barth.
      
      While the Web IDL spec requires [TreatNullAs=EmptyString] and [TreatUndefinedAs=EmptyString],
      the current WebKit treats them as (not an empty string but) a null string.
      To avoid confusion, this patch renames [TreatNullAs=EmptyString] to [TreatNullAs=NullString],
      and [TreatUndefinedAs=EmptyString] to [TreatUndefinedAs=NullString].
      (Eventually we should fix WebKit so that it uses an empty string and then
      rename them to [TreatNullAs=EmptyString] and [TreatUndefinedAs=EmptyString].)
      
      No tests. No change in behavior.
      
      * bindings/scripts/CodeGeneratorJS.pm: Added FIXME.
      (JSValueToNative):
      * bindings/scripts/CodeGeneratorV8.pm: Ditto.
      (GetNativeTypeFromSignature):
      
      * bindings/scripts/test/TestObj.idl:
      * css/CSSCharsetRule.idl:
      * css/CSSPageRule.idl:
      * css/CSSRule.idl:
      * css/CSSStyleDeclaration.idl:
      * css/CSSStyleRule.idl:
      * css/CSSValue.idl:
      * css/MediaList.idl:
      * css/WebKitCSSKeyframesRule.idl:
      * dom/Attr.idl:
      * dom/CharacterData.idl:
      * dom/DOMImplementation.idl:
      * dom/Document.idl:
      * dom/Element.idl:
      * dom/NamedNodeMap.idl:
      * dom/Node.idl:
      * dom/ProcessingInstruction.idl:
      * dom/ShadowRoot.idl:
      * fileapi/Blob.idl:
      * fileapi/DirectoryEntry.idl:
      * fileapi/DirectoryEntrySync.idl:
      * fileapi/Entry.idl:
      * fileapi/EntrySync.idl:
      * fileapi/WebKitBlobBuilder.idl:
      * html/HTMLAnchorElement.idl:
      * html/HTMLButtonElement.idl:
      * html/HTMLCanvasElement.idl:
      * html/HTMLDocument.idl:
      * html/HTMLElement.idl:
      * html/HTMLFieldSetElement.idl:
      * html/HTMLFormElement.idl:
      * html/HTMLFrameElement.idl:
      * html/HTMLInputElement.idl:
      * html/HTMLKeygenElement.idl:
      * html/HTMLMediaElement.idl:
      * html/HTMLObjectElement.idl:
      * html/HTMLOutputElement.idl:
      * html/HTMLScriptElement.idl:
      * html/HTMLSelectElement.idl:
      * html/HTMLTextAreaElement.idl:
      * html/HTMLTitleElement.idl:
      * html/canvas/CanvasRenderingContext2D.idl:
      * page/Console.idl:
      * page/DOMWindow.idl:
      * storage/StorageEvent.idl:
      * svg/SVGAngle.idl:
      * svg/SVGElement.idl:
      * svg/SVGLength.idl:
      * svg/SVGScriptElement.idl:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@106776 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      e45cb179
  4. 05 Feb, 2012 2 commits
    • haraken@chromium.org's avatar
      Rename [JSCCustom*] IDL to [JSCustom*] IDL · 34e76a66
      haraken@chromium.org authored
      https://bugs.webkit.org/show_bug.cgi?id=77844
      
      Reviewed by Adam Barth.
      
      Most existing JSC-specific IDLs have "JS" prefix. We can rename [JSCCustom] to
      [JSCustom], [JSCCustomGetter] to [JSCustomGetter], and [JSCCustomSetter] to
      [JSCustomSetter].
      
      No tests. No change in behavior.
      
      * bindings/scripts/CodeGeneratorJS.pm:
      (GenerateHeader):
      (GenerateImplementation):
      * css/CSSStyleDeclaration.idl:
      * html/HTMLDocument.idl:
      * html/canvas/DataView.idl:
      * page/DOMWindow.idl:
      * page/MemoryInfo.idl:
      * webaudio/ConvolverNode.idl:
      * webaudio/DOMWindowWebAudio.idl:
      * webaudio/WaveShaperNode.idl:
      * websockets/DOMWindowWebSocket.idl:
      * workers/WorkerContext.idl:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@106773 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      34e76a66
    • andersca@apple.com's avatar
      The scrolling tree should be aware of any wheel event handlers on the page · 4ef10879
      andersca@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=77840
      
      Reviewed by Andreas Kling.
      
      If there are wheel event handlers on the page, any wheel events must be redispatched
      to the main thread so they can go through the DOM event handling.
      
      * dom/Document.cpp:
      (WebCore::wheelEventHandlerCountChanged):
      Inform the scrolling coordinator that the wheel event count changed.
      
      (WebCore::Document::didAddWheelEventHandler):
      (WebCore::Document::didRemoveWheelEventHandler):
      Call wheelEventHandlerCountChanged.
      
      * page/scrolling/ScrollingCoordinator.cpp:
      (WebCore::ScrollingCoordinator::frameViewWheelEventHandlerCountChanged):
      Call recomputeWheelEventHandlerCount.
      
      (WebCore::ScrollingCoordinator::recomputeWheelEventHandlerCount):
      Update the scrolling tree state.
      
      * page/scrolling/ScrollingTree.cpp:
      (WebCore::ScrollingTree::ScrollingTree):
      Initialize m_hasWheelEventHandlers to false.
      
      (WebCore::ScrollingTree::tryToHandleWheelEvent):
      If m_hasWheelEventHandlers is true, bail.
      
      (WebCore::ScrollingTree::commitNewTreeState):
      Update m_hasWheelEventHandlers.
      
      * page/scrolling/ScrollingTreeState.cpp:
      (WebCore::ScrollingTreeState::ScrollingTreeState):
      (WebCore::ScrollingTreeState::setWheelEventHandlerCount):
      Add getter and setter for the wheel event handler count.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@106766 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      4ef10879
  5. 04 Feb, 2012 3 commits
    • andersca@apple.com's avatar
      Remove dead code from ScrollingCoordinator · 971b549e
      andersca@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=77821
      
      Reviewed by Sam Weinig.
      
      * WebCore.exp.in:
      * page/scrolling/ScrollingCoordinator.cpp:
      (WebCore::ScrollingCoordinator::ScrollingCoordinator):
      * page/scrolling/ScrollingCoordinator.h:
      (ScrollingCoordinator):
      * page/scrolling/mac/ScrollingCoordinatorMac.mm:
      (WebCore::ScrollingCoordinator::frameViewScrollLayerDidChange):
      * rendering/RenderLayerCompositor.cpp:
      (WebCore::RenderLayerCompositor::frameViewDidChangeSize):
      (WebCore::RenderLayerCompositor::updateRootLayerPosition):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@106752 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      971b549e
    • andersca@apple.com's avatar
      The scrolling tree should inform the main scrolling coordinator when the scroll position changes · 175a9220
      andersca@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=77818
      
      Reviewed by Sam Weinig.
      
      * page/scrolling/ScrollingCoordinator.cpp:
      (WebCore::ScrollingCoordinator::updateMainFrameScrollPosition):
      Set the main frame scroll position.
      
      * page/scrolling/ScrollingTree.cpp:
      (WebCore::ScrollingTree::updateMainFrameScrollPosition):
      Call ScrollingCoordinator::updateMainFrameScrollPosition on the main thread.
      
      * page/scrolling/mac/ScrollingTreeNodeMac.mm:
      (WebCore::ScrollingTreeNodeMac::scrollBy):
      Call ScrollingTree::updateMainFrameScrollPosition.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@106750 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      175a9220
    • haraken@chromium.org's avatar
      Add the "JS" prefix to JSC specific IDL attributes · 72b14d6f
      haraken@chromium.org authored
      https://bugs.webkit.org/show_bug.cgi?id=77693
      
      Reviewed by Darin Adler.
      
      Some JSC specific IDLs do not have "JS" prefix, e.g. [CustomIsReachable].
      It might be OK since JSC is the main JavaScript engine in WebKit, but
      distinguishing IDLs widely used in WebKit and IDLs used in JSC only would help
      people understand the role of IDLs.
      
      This patch renames the following JSC specific IDLs:
      
          CustomFinalize => JSCustomFinalize
          CustomIsReachable => JSCustomIsReachable
          CustomMarkFunction => JSCustomMarkFunction
          CustomToJS => JSCustomToJS
          CustomNativeConverter => JSCustomToNativeObject (Note: For naming consistency with [JSCustomToJS])
          GenerateIsReachable => JSGenerateIsReachable
          GenerateToJS => JSGenerateToJS
          NoStaticTables => JSNoStaticTables
          WindowEventListener => JSWindowEventListener
          InlineGetOwnPropertySlot => JSInlineGetOwnPropertySlot
          DelegatingPrototypePutFunction => JSCustomPrototypePutDelegate
      
      No tests. No changes in behavior.
      
      * bindings/scripts/CodeGeneratorJS.pm:
      (GenerateGetOwnPropertySlotBody):
      (GenerateGetOwnPropertyDescriptorBody):
      (GenerateHeader):
      (GenerateImplementation):
      * bindings/scripts/CodeGeneratorV8.pm:
      (HasCustomToV8Implementation):
      
      * bindings/scripts/test/TestTypedArray.idl: No change in run-bindings-tests results.
      
      * css/CSSRule.idl:
      * css/CSSRuleList.idl:
      * css/CSSStyleDeclaration.idl:
      * css/CSSValue.idl:
      * css/MediaList.idl:
      * css/MediaQueryListListener.idl:
      * css/StyleMedia.idl:
      * css/StyleSheet.idl:
      * css/StyleSheetList.idl:
      * dom/Attr.idl:
      * dom/DOMCoreException.idl:
      * dom/DOMImplementation.idl:
      * dom/DOMStringMap.idl:
      * dom/Document.idl:
      * dom/Element.idl:
      * dom/ErrorEvent.idl:
      * dom/Event.idl:
      * dom/EventException.idl:
      * dom/EventListener.idl:
      * dom/MessageChannel.idl:
      * dom/MessageEvent.idl:
      * dom/MessagePort.idl:
      * dom/NamedNodeMap.idl:
      * dom/Node.idl:
      * dom/NodeFilter.idl:
      * dom/NodeIterator.idl:
      * dom/NodeList.idl:
      * dom/TreeWalker.idl:
      * dom/WebKitNamedFlow.idl:
      * fileapi/Blob.idl:
      * fileapi/DOMFileSystem.idl:
      * fileapi/DOMFileSystemSync.idl:
      * fileapi/DirectoryEntry.idl:
      * fileapi/DirectoryEntrySync.idl:
      * fileapi/DirectoryReader.idl:
      * fileapi/DirectoryReaderSync.idl:
      * fileapi/Entry.idl:
      * fileapi/EntryArray.idl:
      * fileapi/EntryArraySync.idl:
      * fileapi/EntrySync.idl:
      * fileapi/File.idl:
      * fileapi/FileEntry.idl:
      * fileapi/FileEntrySync.idl:
      * fileapi/FileError.idl:
      * fileapi/FileException.idl:
      * fileapi/FileList.idl:
      * fileapi/FileReader.idl:
      * fileapi/FileReaderSync.idl:
      * fileapi/FileWriter.idl:
      * fileapi/Metadata.idl:
      * fileapi/OperationNotAllowedException.idl:
      * fileapi/WebKitBlobBuilder.idl:
      * html/DOMFormData.idl:
      * html/DOMSettableTokenList.idl:
      * html/DOMTokenList.idl:
      * html/DOMURL.idl:
      * html/HTMLAllCollection.idl:
      * html/HTMLBodyElement.idl:
      * html/HTMLCollection.idl:
      * html/HTMLFrameSetElement.idl:
      * html/ImageData.idl:
      * html/MediaController.idl:
      * html/TextTrack.idl:
      * html/TextTrackCue.idl:
      * html/VoidCallback.idl:
      * html/canvas/ArrayBuffer.idl:
      * html/canvas/ArrayBufferView.idl:
      * html/canvas/CanvasRenderingContext.idl:
      * html/canvas/DataView.idl:
      * html/canvas/Float32Array.idl:
      * html/canvas/Float64Array.idl:
      * html/canvas/Int16Array.idl:
      * html/canvas/Int32Array.idl:
      * html/canvas/Int8Array.idl:
      * html/canvas/OESStandardDerivatives.idl:
      * html/canvas/OESTextureFloat.idl:
      * html/canvas/OESVertexArrayObject.idl:
      * html/canvas/Uint16Array.idl:
      * html/canvas/Uint32Array.idl:
      * html/canvas/Uint8Array.idl:
      * html/canvas/Uint8ClampedArray.idl:
      * html/canvas/WebGLCompressedTextures.idl:
      * html/canvas/WebGLDebugRendererInfo.idl:
      * html/canvas/WebGLDebugShaders.idl:
      * html/canvas/WebGLLoseContext.idl:
      * html/canvas/WebGLRenderingContext.idl:
      * html/track/TextTrackList.idl:
      * loader/appcache/DOMApplicationCache.idl:
      * mediastream/LocalMediaStream.idl:
      * page/BarInfo.idl:
      * page/Console.idl:
      * page/DOMSelection.idl:
      * page/DOMWindow.idl:
      * page/EventSource.idl:
      * page/Geolocation.idl:
      * page/History.idl:
      * page/Location.idl:
      * page/Navigator.idl:
      * page/Screen.idl:
      * page/WorkerNavigator.idl:
      * plugins/DOMMimeTypeArray.idl:
      * plugins/DOMPluginArray.idl:
      * storage/Database.idl:
      * storage/DatabaseSync.idl:
      * storage/IDBAny.idl:
      * storage/IDBKey.idl:
      * storage/SQLError.idl:
      * storage/SQLException.idl:
      * storage/SQLResultSet.idl:
      * storage/SQLResultSetRowList.idl:
      * storage/SQLTransaction.idl:
      * storage/SQLTransactionSync.idl:
      * storage/Storage.idl:
      * svg/SVGElementInstance.idl:
      * svg/SVGPathSeg.idl:
      * webaudio/AudioBufferCallback.idl:
      * webaudio/AudioBufferSourceNode.idl:
      * webaudio/AudioContext.idl:
      * webaudio/AudioDestinationNode.idl:
      * webaudio/AudioGain.idl:
      * webaudio/AudioGainNode.idl:
      * webaudio/AudioPannerNode.idl:
      * webaudio/AudioProcessingEvent.idl:
      * webaudio/BiquadFilterNode.idl:
      * webaudio/ConvolverNode.idl:
      * webaudio/DelayNode.idl:
      * webaudio/DynamicsCompressorNode.idl:
      * webaudio/HighPass2FilterNode.idl:
      * webaudio/JavaScriptAudioNode.idl:
      * webaudio/LowPass2FilterNode.idl:
      * webaudio/MediaElementAudioSourceNode.idl:
      * webaudio/OfflineAudioCompletionEvent.idl:
      * webaudio/RealtimeAnalyserNode.idl:
      * webaudio/WaveShaperNode.idl:
      * websockets/CloseEvent.idl:
      * websockets/WebSocket.idl:
      * workers/AbstractWorker.idl:
      * workers/DedicatedWorkerContext.idl:
      * workers/SharedWorker.idl:
      * workers/SharedWorkerContext.idl:
      * workers/Worker.idl:
      * workers/WorkerContext.idl:
      * workers/WorkerLocation.idl:
      * xml/XMLHttpRequest.idl:
      * xml/XMLHttpRequestException.idl:
      * xml/XMLHttpRequestProgressEvent.idl:
      * xml/XMLHttpRequestUpload.idl:
      * xml/XPathResult.idl:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@106737 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      72b14d6f
  6. 03 Feb, 2012 9 commits
    • bdakin@apple.com's avatar
      https://bugs.webkit.org/show_bug.cgi?id=77782 · 0d0640f8
      bdakin@apple.com authored
      WebPageProxy::didNewFirstVisuallyNonEmptyLayout should is called more than 
      once on some pages with frames
      -and corresponding-
      <rdar://problem/10798474>
      
      Reviewed by Sam Weinig.
      
      Source/WebCore: 
      
      startCountingRelevantRepaintedObjects() should only be called for the main 
      frame. Otherwise, the counter will be re-set inappropriately, and 
      didNewFirstVisuallyNonEmptyLayout may even end up firing more than once. 
      * page/FrameView.cpp:
      (WebCore::FrameView::performPostLayoutTasks):
      
      Tools: 
      
      One new test.
      * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
      * TestWebKitAPI/Tests/WebKit2/NewFirstVisuallyNonEmptyLayoutFrames.cpp: Added.
      (TestWebKitAPI):
      (TestWebKitAPI::didForceRepaint):
      (TestWebKitAPI::didFinishLoadForFrame):
      (TestWebKitAPI::didNewFirstVisuallyNonEmptyLayout):
      (TestWebKitAPI::setPageLoaderClient):
      (TestWebKitAPI::TEST):
      * TestWebKitAPI/Tests/WebKit2/NewFirstVisuallyNonEmptyLayoutFrames_Bundle.cpp: Added.
      (TestWebKitAPI):
      (NewFirstVisuallyNonEmptyLayoutFramesTest):
      (TestWebKitAPI::NewFirstVisuallyNonEmptyLayoutFramesTest::NewFirstVisuallyNonEmptyLayoutFramesTest):
      (TestWebKitAPI::NewFirstVisuallyNonEmptyLayoutFramesTest::didCreatePage):
      * TestWebKitAPI/Tests/WebKit2/lots-of-iframes.html: Added.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@106725 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      0d0640f8
    • andersca@apple.com's avatar
      WebKit2 should dispatch wheel events to the new ScrollingTree class · d481a1b1
      andersca@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=77795
      
      Reviewed by Andreas Kling.
      
      Source/WebCore:
      
      * WebCore.exp.in:
      Add new symbols needed by WebKit2.
      
      * WebCore.xcodeproj/project.pbxproj:
      Make ScrollingTree.h private so it can be included by WebKit2.
      
      * page/scrolling/ScrollingCoordinator.cpp:
      (WebCore::ScrollingCoordinator::scrollingTree):
      * page/scrolling/ScrollingCoordinator.h:
      Add a scrolling tree getter.
      
      Source/WebKit2:
      
      Replace all uses of ScrollingCoordinator with ScrollingTree instead.
      Also, don't try to handle gesture events on the scrolling thread anymore;
      we don't need to to that right now.
      
      * WebProcess/WebPage/EventDispatcher.cpp:
      (WebKit::EventDispatcher::addScrollingTreeForPage):
      (WebKit::EventDispatcher::removeScrollingTreeForPage):
      (WebKit::EventDispatcher::wheelEvent):
      (WebKit::EventDispatcher::gestureEvent):
      * WebProcess/WebPage/EventDispatcher.h:
      (WebCore):
      (EventDispatcher):
      * WebProcess/WebPage/mac/TiledCoreAnimationDrawingArea.mm:
      (WebKit::TiledCoreAnimationDrawingArea::TiledCoreAnimationDrawingArea):
      (WebKit::TiledCoreAnimationDrawingArea::~TiledCoreAnimationDrawingArea):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@106723 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      d481a1b1
    • andersca@apple.com's avatar
      The scrolling tree should be able to handle wheel events · f0a46993
      andersca@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=77794
      
      Reviewed by Andreas Kling.
      
      * page/scrolling/ScrollingTree.cpp:
      (WebCore::ScrollingTree::tryToHandleWheelEvent):
      New function. Currently this always returns that it was able to handle the wheel event,
      but this will change in the future.
      
      (WebCore::ScrollingTree::handleWheelEvent):
      Ask the root node to handle the wheel event.
      
      * page/scrolling/ScrollingTreeNode.h:
      Add a handleWheelEvent pure virtual member function.
      
      * page/scrolling/mac/ScrollingTreeNodeMac.mm:
      (WebCore::ScrollingTreeNodeMac::handleWheelEvent):
      Call scrollBy for now. Eventually this should use a scroll elasticity controller to handle
      things like rubber-banding.
      
      (WebCore::ScrollingTreeNodeMac::scrollPosition):
      (WebCore::ScrollingTreeNodeMac::setScrollPosition):
      Add getters and setters for the scroll position.
      
      (WebCore::ScrollingTreeNodeMac::scrollBy):
      Update the scroll position given the offset.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@106720 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      f0a46993
    • andersca@apple.com's avatar
      Apply changed properties from the updated scrolling tree state · a6397e7b
      andersca@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=77792
      
      Reviewed by Andreas Kling.
      
      * page/scrolling/ScrollingTreeNode.cpp:
      (WebCore::ScrollingTreeNode::update):
      Update the tree node properties from the scrolling tree state.
      
      * page/scrolling/ScrollingTreeNode.h:
      (WebCore::ScrollingTreeNode::scrollingTree):
      (WebCore::ScrollingTreeNode::viewportRect):
      (WebCore::ScrollingTreeNode::contentsSize):
      Add getters.
      
      * page/scrolling/ScrollingTreeState.h:
      (WebCore::ScrollingTreeState::changedProperties):
      New function for accessing the changed properties of the scrolling tree state.
      
      * page/scrolling/mac/ScrollingTreeNodeMac.h:
      * page/scrolling/mac/ScrollingTreeNodeMac.mm:
      (WebCore::ScrollingTreeNodeMac::update):
      Update the scroll layer from the scrolling tree if necessary.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@106711 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      a6397e7b
    • andersca@apple.com's avatar
      Commit scrolling tree state changes to the scrolling tree · de0f993d
      andersca@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=77780
      
      Reviewed by Darin Adler.
      
      * WebCore.xcodeproj/project.pbxproj:
      * page/scrolling/ScrollingCoordinator.cpp:
      (WebCore::ScrollingCoordinator::commitTreeState):
      Send the new scrolling tree state over to the ScrollingTree on the scrolling thread.
      
      * page/scrolling/ScrollingTree.cpp:
      (WebCore::ScrollingTree::ScrollingTree):
      Create a root node.
      
      (WebCore::ScrollingTree::commitNewTreeState):
      Update the root node.
      
      * page/scrolling/ScrollingTreeNode.cpp: Copied from Source/WebCore/page/scrolling/ScrollingTree.cpp.
      * page/scrolling/ScrollingTreeNode.h: Copied from Source/WebCore/page/scrolling/ScrollingTree.cpp.
      Stub out an abstract ScrollingTreeNode class.
      
      * page/scrolling/mac/ScrollingCoordinatorMac.mm:
      (WebCore::ScrollingCoordinator::frameViewScrollLayerDidChange):
      Update the scroll layer on the tree state.
      
      * page/scrolling/mac/ScrollingTreeNodeMac.h: Copied from Source/WebCore/page/scrolling/ScrollingTree.cpp.
      * page/scrolling/mac/ScrollingTreeNodeMac.mm: Copied from Source/WebCore/page/scrolling/ScrollingTree.cpp.
      Stub out the concrete ScrollingTreeNodeMac subclass.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@106696 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      de0f993d
    • antti@apple.com's avatar
      Rename CSSMutableStyleDeclaration.h/.cpp to StylePropertySet.h/.cpp · f660180b
      antti@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=77779
      
      Reviewed by Darin Adler.
      
      Source/WebCore: 
      
      Match the new class name.
      
      * CMakeLists.txt:
      * GNUmakefile.list.am:
      * Target.pri:
      * WebCore.gypi:
      * WebCore.vcproj/WebCore.vcproj:
      * WebCore.xcodeproj/project.pbxproj:
      * bindings/js/JSCSSStyleDeclarationCustom.cpp:
      * bindings/js/JSDOMBinding.h:
      * bindings/scripts/CodeGeneratorJS.pm:
      (NativeToJSValue):
      * bindings/scripts/CodeGeneratorObjC.pm:
      (AddIncludesForType):
      * css/CSSAllInOne.cpp:
      * css/CSSComputedStyleDeclaration.cpp:
      * css/CSSFontFaceRule.cpp:
      * css/CSSFontFaceRule.h:
      * css/CSSFontSelector.cpp:
      * css/CSSMutableStyleDeclaration.cpp: Removed.
      * css/CSSMutableStyleDeclaration.h: Removed.
      * css/CSSPageRule.cpp:
      * css/CSSParser.cpp:
      * css/CSSStyleRule.cpp:
      * css/CSSStyleRule.h:
      * css/StylePropertySet.cpp: Copied from Source/WebCore/css/CSSMutableStyleDeclaration.cpp.
      * css/StylePropertySet.h: Copied from Source/WebCore/css/CSSMutableStyleDeclaration.h.
      * css/WebKitCSSKeyframeRule.cpp:
      * css/WebKitCSSKeyframeRule.h:
      * css/WebKitCSSKeyframesRule.cpp:
      * css/WebKitCSSMatrix.cpp:
      * dom/CSSMappedAttributeDeclaration.h:
      * dom/ElementAttributeData.h:
      * dom/StyledElement.cpp:
      * dom/StyledElement.h:
      * editing/ApplyStyleCommand.cpp:
      * editing/DeleteButtonController.cpp:
      * editing/EditingStyle.cpp:
      * editing/Editor.cpp:
      * editing/EditorCommand.cpp:
      * editing/RemoveCSSPropertyCommand.cpp:
      * editing/ReplaceSelectionCommand.cpp:
      * editing/markup.cpp:
      * html/canvas/CanvasRenderingContext2D.cpp:
      * html/shadow/MeterShadowElement.cpp:
      * inspector/InspectorCSSAgent.cpp:
      * inspector/InspectorDOMAgent.cpp:
      * page/DragController.cpp:
      * page/Frame.cpp:
      * rendering/RenderLayer.cpp:
      * rendering/RenderTreeAsText.cpp:
      * svg/SVGFontFaceElement.h:
      (WebCore):
      
      Source/WebKit/mac: 
      
      * WebView/WebHTMLView.mm:
      
      Source/WebKit/qt: 
      
      * Api/qwebelement.cpp:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@106695 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      f660180b
    • andersca@apple.com's avatar
      Update the tree state after layout and add a way to commit it · 52297d85
      andersca@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=77767
      
      Reviewed by Andreas Kling.
      
      * page/FrameView.cpp:
      (WebCore::FrameView::performPostLayoutTasks):
      Call ScrollingCoordinator::frameViewLayoutUpdated if we have a scrolling coordinator.
      
      * page/scrolling/ScrollingCoordinator.cpp:
      (WebCore::ScrollingCoordinator::ScrollingCoordinator):
      Initialize m_scrollingTreeStateCommitterTimer.
      
      (WebCore::ScrollingCoordinator::frameViewLayoutUpdated):
      Update the viewport rect and contents size of the frame view.
      
      (WebCore::ScrollingCoordinator::scheduleTreeStateCommit):
      Schedule a tree state commit unless we've already scheduled one or there are no changed properties.
      
      (WebCore::ScrollingCoordinator::scrollingTreeStateCommitterTimerFired):
      Call commitTreeState().
      
      (WebCore::ScrollingCoordinator::commitTreeStateIfNeeded):
      Commit the tree state unless there are no changed properties.
      
      (WebCore::ScrollingCoordinator::commitTreeState):
      Commit the tree state. We currently don't do anything with the committed state yet.
      
      * page/scrolling/ScrollingCoordinator.h:
      Add new member functions and the timer member variable.
      
      * page/scrolling/ScrollingTreeState.cpp:
      (WebCore::ScrollingTreeState::commit):
      Copy the current tree state and restore the changed properties on the original.
      
      * page/scrolling/ScrollingTreeState.h:
      (WebCore::ScrollingTreeState::hasChangedProperties):
      Return whether there are any changed properties in the tree state.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@106690 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      52297d85
    • andersca@apple.com's avatar
      ScrollingTreeState should keep track of the scroll layer · 0bd81df9
      andersca@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=77762
      
      Reviewed by Andreas Kling.
      
      * WebCore.xcodeproj/project.pbxproj:
      * page/scrolling/ScrollingTreeState.h:
      (ScrollingTreeState):
      * page/scrolling/mac/ScrollingTreeStateMac.mm: Copied from Source/WebCore/page/scrolling/ScrollingTreeState.h.
      (WebCore):
      (WebCore::ScrollingTreeState::platformScrollLayer):
      (WebCore::ScrollingTreeState::setScrollLayer):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@106683 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      0bd81df9
    • antti@apple.com's avatar
      https://bugs.webkit.org/show_bug.cgi?id=77740 · e89e04dc
      antti@apple.com authored
      Split CSSMutableStyleDeclaration into separate internal and CSSOM types 
      
      Reviewed by Andreas Kling and Darin Adler.
      
      Source/WebCore: 
      
      Split the CSSMutableStyleDeclaration into an internal type (StylePropertySet) and a CSSOM implementation type (PropertySetCSSStyleDeclaration).
              
      To keep things somewhat manageable, this patch does NOT
      
      - rename or add any files (so files names won't match types)
      - rename fields, methods or variables to match new type names (like CSSStyleRule::declaration() -> CSSStyleRule::propertySet())
      - try to realize any memory or performance gains (StylePropertySet loses the vptr but gains PropertySetCSSStyleDeclaration*)
      
      * WebCore.exp.in:
      * css/CSSComputedStyleDeclaration.cpp:
      (WebCore::CSSComputedStyleDeclaration::copy):
      (WebCore::CSSComputedStyleDeclaration::makeMutable):
      (WebCore::CSSComputedStyleDeclaration::copyPropertiesInSet):
      * css/CSSComputedStyleDeclaration.h:
      (WebCore):
      (CSSComputedStyleDeclaration):
      * css/CSSFontFaceRule.h:
      (WebCore::CSSFontFaceRule::style):
      (WebCore::CSSFontFaceRule::declaration):
      (WebCore::CSSFontFaceRule::setDeclaration):
      (CSSFontFaceRule):
      * css/CSSFontSelector.cpp:
      (WebCore::CSSFontSelector::addFontFaceRule):
      * css/CSSMutableStyleDeclaration.cpp:
      (PropertySetCSSStyleDeclaration):
      (WebCore::PropertySetCSSStyleDeclaration::create):
      (WebCore::PropertySetCSSStyleDeclaration::PropertySetCSSStyleDeclaration):
      (WebCore):
      (WebCore::StylePropertySet::StylePropertySet):
      (WebCore::StylePropertySet::~StylePropertySet):
      (WebCore::StylePropertySet::deref):
      (WebCore::StylePropertySet::contextStyleSheet):
      (WebCore::StylePropertySet::copyPropertiesFrom):
      (WebCore::StylePropertySet::getPropertyValue):
      (WebCore::StylePropertySet::borderSpacingValue):
      (WebCore::StylePropertySet::appendFontLonghandValueIfExplicit):
      (WebCore::StylePropertySet::fontValue):
      (WebCore::StylePropertySet::get4Values):
      (WebCore::StylePropertySet::getLayeredShorthandValue):
      (WebCore::StylePropertySet::getShorthandValue):
      (WebCore::StylePropertySet::getCommonValue):
      (WebCore::StylePropertySet::getPropertyCSSValue):
      (WebCore::StylePropertySet::removeShorthandProperty):
      (WebCore::StylePropertySet::removeProperty):
      (WebCore::StylePropertySet::setNeedsStyleRecalc):
      (WebCore::StylePropertySet::propertyIsImportant):
      (WebCore::StylePropertySet::getPropertyShorthand):
      (WebCore::StylePropertySet::isPropertyImplicit):
      (WebCore::StylePropertySet::setProperty):
      (WebCore::StylePropertySet::parseDeclaration):
      (WebCore::StylePropertySet::addParsedProperties):
      (WebCore::StylePropertySet::addParsedProperty):
      (WebCore::StylePropertySet::asText):
      (WebCore::StylePropertySet::merge):
      (WebCore::StylePropertySet::addSubresourceStyleURLs):
      (WebCore::StylePropertySet::copyBlockProperties):
      (WebCore::StylePropertySet::removeBlockProperties):
      (WebCore::StylePropertySet::removePropertiesInSet):
      (WebCore::StylePropertySet::findPropertyWithId):
      (WebCore::StylePropertySet::propertyMatches):
      (WebCore::StylePropertySet::removeEquivalentProperties):
      (WebCore::StylePropertySet::copy):
      (WebCore::StylePropertySet::copyPropertiesInSet):
      (WebCore::StylePropertySet::ensureCSSStyleDeclaration):
      (WebCore::PropertySetCSSStyleDeclaration::length):
      (WebCore::PropertySetCSSStyleDeclaration::item):
      (WebCore::PropertySetCSSStyleDeclaration::parentRule):
      (WebCore::PropertySetCSSStyleDeclaration::cssText):
      (WebCore::PropertySetCSSStyleDeclaration::setCssText):
      (WebCore::PropertySetCSSStyleDeclaration::getPropertyCSSValue):
      (WebCore::PropertySetCSSStyleDeclaration::getPropertyValue):
      (WebCore::PropertySetCSSStyleDeclaration::getPropertyPriority):
      (WebCore::PropertySetCSSStyleDeclaration::getPropertyShorthand):
      (WebCore::PropertySetCSSStyleDeclaration::isPropertyImplicit):
      (WebCore::PropertySetCSSStyleDeclaration::setProperty):
      (WebCore::PropertySetCSSStyleDeclaration::removeProperty):
      (WebCore::PropertySetCSSStyleDeclaration::getPropertyCSSValueInternal):
      (WebCore::PropertySetCSSStyleDeclaration::getPropertyValueInternal):
      (WebCore::PropertySetCSSStyleDeclaration::setPropertyInternal):
      (WebCore::PropertySetCSSStyleDeclaration::parentStyleSheet):
      (WebCore::PropertySetCSSStyleDeclaration::copy):
      (WebCore::PropertySetCSSStyleDeclaration::makeMutable):
      (WebCore::PropertySetCSSStyleDeclaration::cssPropertyMatches):
      * css/CSSMutableStyleDeclaration.h:
      (WebCore):
      (StylePropertySet):
      (WebCore::StylePropertySet::create):
      (WebCore::StylePropertySet::createInline):
      * css/CSSPageRule.h:
      (WebCore):
      * css/CSSParser.cpp:
      (WebCore::parseColorValue):
      (WebCore::parseSimpleLengthValue):
      (WebCore::CSSParser::parseValue):
      (WebCore::CSSParser::parseDeclaration):
      (WebCore::CSSParser::createStyleRule):
      (WebCore::CSSParser::createFontFaceRule):
      (WebCore::CSSParser::createPageRule):
      (WebCore::CSSParser::createKeyframeRule):
      * css/CSSParser.h:
      (WebCore):
      (CSSParser):
      * css/CSSStyleDeclaration.h:
      (WebCore):
      (CSSStyleDeclaration):
      * css/CSSStyleRule.h:
      (WebCore::CSSStyleRule::style):
      (WebCore::CSSStyleRule::setDeclaration):
      (WebCore::CSSStyleRule::declaration):
      (CSSStyleRule):
      * css/CSSStyleSelector.cpp:
      (WebCore::leftToRightDeclaration):
      (WebCore::rightToLeftDeclaration):
      (WebCore::CSSStyleSelector::addMatchedDeclaration):
      (WebCore::CSSStyleSelector::collectMatchingRulesForList):
      (WebCore::CSSStyleSelector::matchAllRules):
      (WebCore::CSSStyleSelector::styleForKeyframe):
      (WebCore::isInsideRegionRule):
      (WebCore::CSSStyleSelector::applyDeclaration):
      (WebCore::CSSStyleSelector::applyDeclarations):
      (WebCore::CSSStyleSelector::matchPageRulesForList):
      * css/CSSStyleSelector.h:
      (CSSStyleSelector):
      (MatchedStyleDeclaration):
      * css/WebKitCSSKeyframeRule.cpp:
      (WebCore::WebKitCSSKeyframeRule::setDeclaration):
      * css/WebKitCSSKeyframeRule.h:
      (WebCore::WebKitCSSKeyframeRule::style):
      (WebCore::WebKitCSSKeyframeRule::declaration):
      (WebKitCSSKeyframeRule):
      * css/WebKitCSSMatrix.cpp:
      (WebCore::WebKitCSSMatrix::setMatrixValue):
      * dom/Attr.h:
      (WebCore::Attr::style):
      * dom/Attribute.h:
      (WebCore::Attribute::decl):
      * dom/CSSMappedAttributeDeclaration.h:
      (WebCore::CSSMappedAttributeDeclaration::declaration):
      (WebCore::CSSMappedAttributeDeclaration::CSSMappedAttributeDeclaration):
      (CSSMappedAttributeDeclaration):
      * dom/Document.cpp:
      (WebCore::Document::createCSSStyleDeclaration):
      * dom/ElementAttributeData.h:
      (ElementAttributeData):
      * dom/NamedNodeMap.cpp:
      (WebCore::NamedNodeMap::ensureInlineStyleDecl):
      * dom/NamedNodeMap.h:
      (WebCore::NamedNodeMap::inlineStyleDecl):
      (NamedNodeMap):
      * dom/StyledElement.cpp:
      (WebCore::StyledElement::updateStyleAttribute):
      (WebCore::StyledElement::copyNonAttributeProperties):
      (WebCore::StyledElement::addSubresourceAttributeURLs):
      * dom/StyledElement.h:
      (WebCore::StyledElement::additionalAttributeStyle):
      (WebCore::StyledElement::inlineStyleDecl):
      (WebCore::StyledElement::ensureInlineStyleDecl):
      * editing/ApplyStyleCommand.cpp:
      (WebCore::ApplyStyleCommand::applyRelativeFontStyleChange):
      (WebCore::ApplyStyleCommand::removeEmbeddingUpToEnclosingBlock):
      (WebCore::ApplyStyleCommand::applyInlineStyleToNodeRange):
      (WebCore::ApplyStyleCommand::removeCSSStyle):
      (WebCore::ApplyStyleCommand::addBlockStyle):
      (WebCore::ApplyStyleCommand::addInlineStyleIfNeeded):
      * editing/DeleteButtonController.cpp:
      (WebCore::DeleteButtonController::createDeletionUI):
      * editing/EditingStyle.cpp:
      (WebCore::copyEditingProperties):
      (WebCore::editingStyleFromComputedStyle):
      (WebCore):
      (WebCore::HTMLElementEquivalent::propertyExistsInStyle):
      (HTMLElementEquivalent):
      (WebCore::HTMLElementEquivalent::valueIsPresentInStyle):
      (HTMLTextDecorationEquivalent):
      (WebCore::HTMLTextDecorationEquivalent::propertyExistsInStyle):
      (WebCore::HTMLTextDecorationEquivalent::valueIsPresentInStyle):
      (HTMLAttributeEquivalent):
      (WebCore::HTMLAttributeEquivalent::valueIsPresentInStyle):
      (WebCore::HTMLAttributeEquivalent::attributeValueAsCSSValue):
      (WebCore::EditingStyle::EditingStyle):
      (WebCore::getRGBAFontColor):
      (WebCore::EditingStyle::setProperty):
      (WebCore::EditingStyle::setStyle):
      (WebCore::EditingStyle::overrideWithStyle):
      (WebCore::EditingStyle::extractAndRemoveTextDirection):
      (WebCore::EditingStyle::removeStyleAddedByNode):
      (WebCore::EditingStyle::removeStyleConflictingWithStyleOfNode):
      (WebCore::EditingStyle::triStateOfStyle):
      (WebCore::EditingStyle::conflictsWithInlineStyleOfElement):
      (WebCore::EditingStyle::elementIsStyledSpanOrHTMLEquivalent):
      (WebCore::elementMatchesAndPropertyIsNotInInlineStyleDecl):
      (WebCore::EditingStyle::mergeStyle):
      (WebCore::styleFromMatchedRulesForElement):
      (WebCore::EditingStyle::mergeStyleFromRules):
      (WebCore::EditingStyle::mergeStyleFromRulesForSerialization):
      (WebCore::removePropertiesInStyle):
      (WebCore::EditingStyle::removeStyleFromRulesAndContext):
      (WebCore::EditingStyle::removePropertiesInElementDefaultStyle):
      (WebCore::EditingStyle::forceInline):
      (WebCore::reconcileTextDecorationProperties):
      (WebCore::StyleChange::StyleChange):
      (WebCore::setTextDecorationProperty):
      (WebCore::StyleChange::extractTextStyles):
      (WebCore::diffTextDecorations):
      (WebCore::fontWeightIsBold):
      (WebCore::getTextAlignment):
      (WebCore::getPropertiesNotIn):
      (WebCore::getIdentifierValue):
      (WebCore::isTransparentColorValue):
      (WebCore::hasTransparentBackgroundColor):
      * editing/EditingStyle.h:
      (WebCore):
      (WebCore::EditingStyle::create):
      (EditingStyle):
      (WebCore::EditingStyle::style):
      (StyleChange):
      * editing/Editor.cpp:
      (WebCore::Editor::setBaseWritingDirection):
      (WebCore::Editor::applyEditingStyleToElement):
      * editing/EditorCommand.cpp:
      (WebCore::applyCommandToFrame):
      (WebCore::executeApplyStyle):
      (WebCore::executeToggleStyleInList):
      (WebCore::executeApplyParagraphStyle):
      (WebCore::executeMakeTextWritingDirectionLeftToRight):
      (WebCore::executeMakeTextWritingDirectionNatural):
      (WebCore::executeMakeTextWritingDirectionRightToLeft):
      * editing/FrameSelection.cpp:
      (WebCore::FrameSelection::copyTypingStyle):
      * editing/FrameSelection.h:
      (WebCore):
      * editing/RemoveCSSPropertyCommand.cpp:
      (WebCore::RemoveCSSPropertyCommand::doApply):
      (WebCore::RemoveCSSPropertyCommand::doUnapply):
      * editing/ReplaceSelectionCommand.cpp:
      (WebCore::ReplaceSelectionCommand::removeRedundantStylesAndKeepStyleSpanInline):
      * editing/ReplaceSelectionCommand.h:
      (WebCore):
      * editing/markup.cpp:
      (WebCore):
      (StyledMarkupAccumulator):
      (WebCore::StyledMarkupAccumulator::wrapWithStyleNode):
      (WebCore::StyledMarkupAccumulator::appendStyleNodeOpenTag):
      (WebCore::propertyMissingOrEqualToNone):
      * html/HTMLTableCellElement.cpp:
      (WebCore::HTMLTableCellElement::additionalAttributeStyle):
      * html/HTMLTableCellElement.h:
      (HTMLTableCellElement):
      * html/HTMLTableColElement.cpp:
      (WebCore::HTMLTableColElement::additionalAttributeStyle):
      * html/HTMLTableColElement.h:
      (HTMLTableColElement):
      * html/HTMLTableElement.cpp:
      (WebCore::leakBorderStyle):
      (WebCore::HTMLTableElement::additionalAttributeStyle):
      (WebCore::HTMLTableElement::createSharedCellStyle):
      (WebCore::HTMLTableElement::additionalCellStyle):
      (WebCore::leakGroupBorderStyle):
      (WebCore::HTMLTableElement::additionalGroupStyle):
      * html/HTMLTableElement.h:
      (HTMLTableElement):
      * html/HTMLTableSectionElement.cpp:
      (WebCore::HTMLTableSectionElement::additionalAttributeStyle):
      * html/HTMLTableSectionElement.h:
      (HTMLTableSectionElement):
      * html/ValidationMessage.cpp:
      (WebCore::adjustBubblePosition):
      * html/canvas/CanvasRenderingContext2D.cpp:
      (WebCore::CanvasRenderingContext2D::setFont):
      * html/shadow/MediaControlElements.cpp:
      (WebCore::MediaControlPanelElement::setPosition):
      (WebCore::MediaControlPanelElement::resetPosition):
      (WebCore::MediaControlPanelElement::makeOpaque):
      (WebCore::MediaControlPanelElement::makeTransparent):
      * html/shadow/SliderThumbElement.cpp:
      (WebCore::TrackLimiterElement::create):
      * inspector/InspectorCSSAgent.cpp:
      (WebCore::InspectorCSSAgent::buildArrayForAttributeStyles):
      * inspector/InspectorStyleSheet.cpp:
      (WebCore::InspectorStyle::setPropertyText):
      (WebCore::InspectorStyleSheetForInlineStyle::getStyleAttributeRanges):
      * page/DragController.cpp:
      (WebCore::DragController::concludeEditDrag):
      * page/PageSerializer.cpp:
      (WebCore::PageSerializer::retrieveResourcesForCSSDeclaration):
      * page/PageSerializer.h:
      (WebCore):
      (PageSerializer):
      * rendering/RenderLayer.cpp:
      (WebCore::RenderLayer::resize):
      * rendering/RenderTreeAsText.cpp:
      (WebCore::isEmptyOrUnstyledAppleStyleSpan):
      * svg/SVGFontFaceElement.cpp:
      (WebCore::SVGFontFaceElement::SVGFontFaceElement):
      
      Source/WebKit/mac: 
      
      * WebView/WebFrame.mm:
      (-[WebFrame _typingStyle]):
      
      Source/WebKit/qt: 
      
      * Api/qwebelement.cpp:
      (QWebElement::styleProperty):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@106681 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      e89e04dc