- 08 Feb, 2012 15 commits
-
-
zimmermann@webkit.org authored
https://bugs.webkit.org/show_bug.cgi?id=78084 Reviewed by Hajime Morita. Source/WebCore: SVGLoad event fires too early, making it impossible to use the vanilla repaint.js harness (runRepaintTest). We're using a hack called runSVGRepaintTest() at the moment in trunk, which runs runRepaintTest() from a 0ms timer, which is not reliable. The main difference between HTML onload and SVG onload is that HTMLs event is a "window event", thus dispatched through DOMWindow (eg. <body onload="alert(event.target)" will yield Document, <svg onload="alert(evt.target)"> will say SVGSVGElement). Consider: <svg onload="alert('1')> <g onload="alert('2)"> <rect onload="alert('3')"/> </svg> As soon as the <rect> finishes parsing (SVGElement::finishedParsingChildren), it's SVGLoad event is fired. So first you'll see '3', then '2', then '1'. Using: <svg onload="alert('1')> <g onload="alert('2)"> <image xlink:href="someExternal.jpg" onload="alert('3')"/> </svg> will yield the same SVGLoad order. When using <image externalREsourcesRequired="true", first the '1' will fire, then '3', then '2', all as expected and specified in SVG. http://www.w3.org/TR/SVG/interact.html#LoadEvent says: "The event is triggered at the point at which the user agent has fully parsed the element and its descendants and is ready to act appropriately upon that element, such as being ready to render the element to the target device. Referenced external resources that are required must be loaded, parsed and ready to render before the event is triggered. Optional external resources are not required to be ready for the event to be triggered." What we don't implement correctly is the second part of the first sentence: "and is ready to act appropriately upon that element, such as being ready to render the element to the target device". We currently fire the SVGLoad event, right after </svg> is seen, if no externalResourceRequired="true" attributes are set anywhere. This is not wrong, but not correct for WebKit, as we're not yet "ready to render". HTML fires its window onload event from Document::implicitClose(), where it calls Document::dispatchWindowLoadEvent. At this point we're ready to render. So I'm now aligning the timing of the outermost <svg> elements SVGLoad event, to be equal to HTML. This lets use use the repaint.js harness w/o any special SVG tricks. Covered by existing tests. * dom/Document.cpp: (WebCore::Document::implicitClose): Dispatch SVGLoad event for outermost <svg> elements from here, as HTML does for its window onload event. * svg/SVGDocumentExtensions.cpp: (WebCore::SVGDocumentExtensions::dispatchSVGLoadEventToOutermostSVGElements): Sends a SVGLoad event to all outermost <svg> elements in a document, if possible. There can be multiple ones, if using <svg><foreignObject><svg>... - the <svg> in the <fO> also acts as outermost <svg> element. * svg/SVGDocumentExtensions.h: Add new dispatchSVGLoadEventToOutermostSVGElements() helper. * svg/SVGElement.cpp: (WebCore::SVGElement::isOutermostSVGSVGElement): Moved from SVGSVGElement into SVGElement, and renamed from isOutermostSVG(). (WebCore::SVGElement::sendSVGLoadEventIfPossible): Don't dispatch load events to outermost <svg> elements, if Document::implicitClose() wasn't called yet. (WebCore::SVGElement::finishParsingChildren): Stop using the default SVGLoad dispatching logic for outermost <svg> elements. * svg/SVGElement.h: Add isOutermostSVGSVGElement(). * svg/SVGSVGElement.cpp: Rename isOutermostSVG to isOutermostSVGSVGElement. (WebCore::SVGSVGElement::currentScale): (WebCore::SVGSVGElement::setCurrentScale): (WebCore::SVGSVGElement::localCoordinateSpaceTransform): (WebCore::SVGSVGElement::createRenderer): * svg/SVGSVGElement.h: Move isOutermostSVG() to SVGElement. * svg/SVGStyledElement.cpp: (WebCore::SVGStyledElement::title): Rename isOutermostSVG to isOutermostSVGSVGElement. LayoutTests: Remove runSVGRepaintTest() from repaint.js again, and convert all *.svg tests to use runRepaintTest() directly. This is now possible as the outermost <svg> elements load event timing as aligned with HTML. * fast/repaint/resources/repaint.js: Remove runSVGRepaintTest(), it's no longer needed. (runRepaintTest): s/document.rootElement/document.documentElement/ to make it work for all HTML/XHTML and SVG documents (XHTML was broken). * platform/chromium/test_expectations.txt: * platform/mac/svg/custom/SVGPoint-matrixTransform-expected.png: * platform/mac/svg/custom/SVGPoint-matrixTransform-expected.txt: * platform/mac/svg/custom/getTransformToElement-expected.png: * platform/mac/svg/custom/getTransformToElement-expected.txt: * platform/mac/svg/custom/polyline-setattribute-points-null-expected.png: * platform/mac/svg/custom/polyline-setattribute-points-null-expected.txt: * platform/mac/svg/custom/text-ctm-expected.png: * platform/mac/svg/custom/text-ctm-expected.txt: * platform/mac/svg/custom/text-hit-test-expected.png: * platform/mac/svg/custom/text-hit-test-expected.txt: * platform/mac/svg/filters/filter-refresh-expected.png: * svg/carto.net/tabgroup.svg: * svg/carto.net/window.svg: * svg/css/shadow-changes.svg: * svg/custom/loadevents-externalresourcesrequired.svg: * svg/dom/SVGPathSegList-segment-modification.svg: * svg/dom/SVGPathSegList-xml-dom-synchronization2.xhtml: * svg/dom/SVGRectElement/rect-modify-rx.svg: * svg/filters/animate-fill.svg: * svg/filters/feImage-reference-invalidation.svg: * svg/filters/feImage-target-add-to-document.svg: * svg/filters/feImage-target-changes-id.svg: * svg/filters/feImage-target-id-change.svg: * svg/filters/feImage-target-reappend-to-document.svg: * svg/filters/feImage-target-remove-from-document.svg: * svg/filters/filter-refresh.svg: * svg/filters/filter-width-update.svg: * svg/filters/invalidate-on-child-layout.svg: * svg/hixie/perf/001.xml: * svg/hixie/perf/002.xml: * svg/hixie/perf/003.xml: * svg/hixie/perf/004.xml: * svg/hixie/perf/005.xml: * svg/hixie/perf/006.xml: * svg/hixie/perf/007.xml: * svg/repaint/container-repaint.svg: * svg/repaint/filter-child-repaint.svg: * svg/repaint/image-href-change.svg: * svg/repaint/image-with-clip-path.svg: * svg/text/text-text-05-t.svg: * svg/zoom/page/absolute-sized-document-no-scrollbars.svg: * svg/zoom/page/absolute-sized-document-scrollbars.svg: * svg/zoom/page/relative-sized-document-scrollbars.svg: * svg/zoom/page/zoom-coords-viewattr-01-b.svg: * svg/zoom/page/zoom-foreignObject.svg: * svg/zoom/page/zoom-mask-with-percentages.svg: * svg/zoom/resources/testPageZoom.js: (repaintTest): * svg/zoom/text/absolute-sized-document-no-scrollbars.svg: * svg/zoom/text/absolute-sized-document-scrollbars.svg: * svg/zoom/text/relative-sized-document-scrollbars.svg: * svg/zoom/text/zoom-coords-viewattr-01-b.svg: * svg/zoom/text/zoom-foreignObject.svg: git-svn-id: http://svn.webkit.org/repository/webkit/trunk@107057 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
apavlov@chromium.org authored
https://bugs.webkit.org/show_bug.cgi?id=78090 Reviewed by Vsevolod Vlasov. * inspector/InspectorDOMAgent.cpp: (WebCore::InspectorDOMAgent::updateTouchEventEmulationInPage): git-svn-id: http://svn.webkit.org/repository/webkit/trunk@107056 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
apavlov@chromium.org authored
https://bugs.webkit.org/show_bug.cgi?id=77865 Reviewed by Pavel Feldman. Source/WebCore: Test: inspector/styles/lazy-computed-style.html * inspector/front-end/StylesSidebarPane.js: (WebInspector.StylesSidebarPane): (WebInspector.StylesSidebarPane.prototype._executeRebuildUpdate): (WebInspector.StylesSidebarPane.prototype._refreshComputedStyleSection): (WebInspector.ComputedStyleSidebarPane.prototype.expand): (WebInspector.ComputedStylePropertiesSection.prototype.onpopulate): LayoutTests: * http/tests/inspector/elements-test.js: (initialize_ElementTest.InspectorTest.selectNodeAndWaitForStylesWithComputed.stylesCallback): (initialize_ElementTest.InspectorTest.selectNodeAndWaitForStylesWithComputed): * inspector/elements/elements-panel-styles.html: * inspector/styles/css-live-edit.html: * inspector/styles/lazy-computed-style-expected.txt: Added. * inspector/styles/lazy-computed-style.html: Added. * inspector/styles/styles-computed-trace.html: git-svn-id: http://svn.webkit.org/repository/webkit/trunk@107055 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
tommyw@google.com authored
https://bugs.webkit.org/show_bug.cgi?id=77954 When readyState changes a callback should be triggered. Reviewed by Adam Barth. Tests for the Media Stream API will be provided by the bug 56587, pending enough landed code. * dom/EventNames.h: (WebCore): * mediastream/PeerConnection.cpp: (WebCore::PeerConnection::changeReadyState): * mediastream/PeerConnection.h: (PeerConnection): (WebCore::PeerConnection::didChangeState): * mediastream/PeerConnection.idl: * platform/mediastream/PeerConnectionHandlerClient.h: (PeerConnectionHandlerClient): git-svn-id: http://svn.webkit.org/repository/webkit/trunk@107054 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
rniwa@webkit.org authored
https://bugs.webkit.org/show_bug.cgi?id=78012 Reviewed by Adam Barth. Use resolve paths using filesystem.relpath before passing it to find_files.find. * Scripts/webkitpy/performance_tests/perftestsrunner.py: (PerfTestsRunner): (PerfTestsRunner._collect_tests): * Scripts/webkitpy/performance_tests/perftestsrunner_unittest.py: (test_collect_tests): (test_collect_tests.add_file): git-svn-id: http://svn.webkit.org/repository/webkit/trunk@107053 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
ossy@webkit.org authored
Skip a new test because of missing AuthenticationChallenges support. * platform/qt/Skipped: * platform/wk2/Skipped: git-svn-id: http://svn.webkit.org/repository/webkit/trunk@107052 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
haraken@chromium.org authored
https://bugs.webkit.org/show_bug.cgi?id=77963 Reviewed by Adam Barth. This patch renames [DelegatingPutFunction] IDL to [CustomNamedSetter] IDL, for clarification and for naming consistency with [NamedGetter] and [CustomIndexedSetter]. No tests. No change in behavior. * bindings/scripts/CodeGeneratorJS.pm: (GenerateHeader): (GenerateImplementation): * bindings/scripts/CodeGeneratorV8.pm: (GenerateHeaderNamedAndIndexedPropertyAccessors): (GenerateImplementationIndexer): (GenerateImplementationNamedPropertyGetter): * bindings/scripts/test/TestInterface.idl: * css/CSSStyleDeclaration.idl: * dom/DOMStringMap.idl: * html/HTMLAppletElement.idl: * html/HTMLEmbedElement.idl: * html/HTMLObjectElement.idl: * page/History.idl: * page/Location.idl: * storage/Storage.idl: git-svn-id: http://svn.webkit.org/repository/webkit/trunk@107051 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
commit-queue@webkit.org authored
https://bugs.webkit.org/show_bug.cgi?id=77929 Patch by Shinya Kawanaka <shinyak@google.com> on 2012-02-08 Reviewed by Hajime Morita. ShadowRoot's life cycle can be consufing If Element::ensureShadowRoot() is used. So we want to remove Element::ensureShadowRoot(). This patch replaces Element::ensureShadowRoot() if it is used in object construction phase. No new tests, no change in behavior. * html/HTMLDetailsElement.cpp: (WebCore::HTMLDetailsElement::createShadowSubtree): * html/HTMLKeygenElement.cpp: (WebCore::HTMLKeygenElement::HTMLKeygenElement): * html/HTMLMeterElement.cpp: (WebCore::HTMLMeterElement::createShadowSubtree): * html/HTMLProgressElement.cpp: (WebCore::HTMLProgressElement::createShadowSubtree): * html/HTMLSummaryElement.cpp: (WebCore::HTMLSummaryElement::createShadowSubtree): * html/HTMLTextAreaElement.cpp: (WebCore::HTMLTextAreaElement::createShadowSubtree): git-svn-id: http://svn.webkit.org/repository/webkit/trunk@107050 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
zimmermann@webkit.org authored
Not reviewed. Add missing results for a new SVG test. * platform/mac/svg/custom/use-disappears-after-style-update-expected.png: Added. * platform/mac/svg/custom/use-disappears-after-style-update-expected.txt: Added. git-svn-id: http://svn.webkit.org/repository/webkit/trunk@107049 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
podivilov@chromium.org authored
Unreviewed, remove deleted touch-gesture-scroll.html test from test_expectations.txt. * platform/chromium/test_expectations.txt: git-svn-id: http://svn.webkit.org/repository/webkit/trunk@107048 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
dmazzoni@google.com authored
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@107047 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
haraken@chromium.org authored
https://bugs.webkit.org/show_bug.cgi?id=77971 Reviewed by Adam Barth. Source/WebCore: [CheckNodeSecurity] is not implemented by code generators. This patch replaces [CheckNodeSecurity] with [CheckAccessToNode]. Test: http/tests/security/cross-frame-access-frameelement.html * page/DOMWindow.idl: LayoutTests: The added test checks if frameElement is accessible from the same or cross origin iframe. * http/tests/security/cross-frame-access-frameelement-expected.txt: Added. * http/tests/security/cross-frame-access-frameelement.html: Added. * http/tests/security/resources/cross-frame-access-frameelement-from-iframe.html: Added. * platform/chromium/http/tests/security/cross-frame-access-put-expected.txt: Updated the test result. git-svn-id: http://svn.webkit.org/repository/webkit/trunk@107046 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
haraken@chromium.org authored
https://bugs.webkit.org/show_bug.cgi?id=78081 Reviewed by Adam Barth. [CustomPushEventHandlerScope] is a JSC-specific IDL attribute. This patch renames it to [JSCustomPushEventHandlerScope] No tests. No change in behavior. * bindings/scripts/CodeGeneratorJS.pm: (GenerateHeader): * dom/Node.idl: * html/HTMLElement.idl: git-svn-id: http://svn.webkit.org/repository/webkit/trunk@107045 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
philn@webkit.org authored
https://bugs.webkit.org/show_bug.cgi?id=77959 Reviewed by Martin Robinson. Add a new WebKitGTK WebSetting to enable/disable WebAudio at runtime. * UIProcess/API/gtk/WebKitSettings.cpp: (webKitSettingsSetProperty): (webKitSettingsGetProperty): (webkit_settings_class_init): (webkit_settings_get_enable_webaudio): (webkit_settings_set_enable_webaudio): * UIProcess/API/gtk/WebKitSettings.h: * UIProcess/API/gtk/tests/TestWebKitSettings.cpp: (testWebKitSettings): git-svn-id: http://svn.webkit.org/repository/webkit/trunk@107044 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
mrobinson@webkit.org authored
https://bugs.webkit.org/show_bug.cgi?id=76789 Reviewed by Philippe Normand. Add a WebKitResponsePolicyDecision GObject, use it for response policy decisions and add a test. * GNUmakefile.am: Added new source files to the list. * UIProcess/API/gtk/WebKitPolicyClient.cpp: (decidePolicyForResponseCallback): Added this callback which creates the request and fires the signal. (attachPolicyClientToPage): Added new callback to the C API policy client. * UIProcess/API/gtk/WebKitResponsePolicyDecision.cpp: Added. * UIProcess/API/gtk/WebKitResponsePolicyDecision.h: Added. * UIProcess/API/gtk/WebKitResponsePolicyDecisionPrivate.h: Added. * UIProcess/API/gtk/docs/webkit2gtk-docs.sgml: Added new docs. * UIProcess/API/gtk/docs/webkit2gtk-sections.txt: Ditto. * UIProcess/API/gtk/tests/TestWebKitPolicyClient.cpp: (testResponsePolicy): Added this test for response policy decisions. (serverCallback): Added a SoupServer to test policy response policy decisions. (beforeAll): Ditto. (afterAll): Ditto. git-svn-id: http://svn.webkit.org/repository/webkit/trunk@107043 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
- 07 Feb, 2012 25 commits
-
-
commit-queue@webkit.org authored
https://bugs.webkit.org/show_bug.cgi?id=78067 Patch by James Robinson <jamesr@chromium.org> on 2012-02-07 Reviewed by Adam Barth. Source/Platform: This moves several geometry-related headers in the chromium WebKit platform API to Platform/chromium/public. These require a bit of extra work since when WEBKIT_IMPLEMENTATION is set they #include headers from WebCore/platform such as IntPoint so that the implementations of several functions can be inlined. Since we do not want to add anything in WebCore to the include path of projects that depend on the Platform API this poses a bit of an issue. I've added an extra build step to copy the specific headers used into the SHARED_INTERMEDIATE_DIR to preserve this inlining. Eventually we'll move the cross-platform code, including these headers, into somewhere under Platform/, but doing that requires non-trivial modifications to every build system in WebKit. * Platform.gyp/Platform.gyp: * Platform.gyp/copy_webcore_headers.py: Added. (CopyHeaders): (Main): * chromium/public/WebFloatPoint.h: Copied from Source/WebKit/chromium/public/platform/WebFloatPoint.h. (WebKit): (WebFloatPoint): (WebKit::WebFloatPoint::WebFloatPoint): (WebKit::WebFloatPoint::operator=): (WebKit::WebFloatPoint::operator WebCore::FloatPoint): (WebKit::operator==): (WebKit::operator!=): * chromium/public/WebFloatQuad.h: Copied from Source/WebKit/chromium/public/platform/WebFloatQuad.h. (WebKit): (WebFloatQuad): (WebKit::WebFloatQuad::WebFloatQuad): (WebKit::WebFloatQuad::operator=): * chromium/public/WebFloatRect.h: Copied from Source/WebKit/chromium/public/platform/WebFloatRect.h. (WebKit): (WebFloatRect): (WebKit::WebFloatRect::isEmpty): (WebKit::WebFloatRect::WebFloatRect): (WebKit::WebFloatRect::operator=): (WebKit::WebFloatRect::operator WebCore::FloatRect): (WebKit::operator==): (WebKit::operator!=): * chromium/public/WebPoint.h: Copied from Source/WebKit/chromium/public/platform/WebPoint.h. (WebKit): (WebPoint): (WebKit::WebPoint::WebPoint): (WebKit::WebPoint::operator=): (WebKit::WebPoint::operator WebCore::IntPoint): (WebKit::WebPoint::operator gfx::Point): (WebKit::operator==): (WebKit::operator!=): * chromium/public/WebRect.h: Copied from Source/WebKit/chromium/public/platform/WebRect.h. (WebKit): (WebRect): (WebKit::WebRect::isEmpty): (WebKit::WebRect::WebRect): (WebKit::WebRect::operator=): (WebKit::WebRect::operator WebCore::IntRect): (WebKit::WebRect::operator gfx::Rect): (WebKit::operator==): (WebKit::operator!=): * chromium/public/WebSize.h: Copied from Source/WebKit/chromium/public/platform/WebSize.h. (WebKit): (WebSize): (WebKit::WebSize::isEmpty): (WebKit::WebSize::WebSize): (WebKit::WebSize::operator=): (WebKit::WebSize::operator WebCore::IntSize): (WebKit::WebSize::operator gfx::Size): (WebKit::operator==): (WebKit::operator!=): Source/WebKit/chromium: Add forwarding headers for several API types moved into Platform. * public/platform/WebFloatPoint.h: * public/platform/WebFloatQuad.h: * public/platform/WebFloatRect.h: * public/platform/WebPoint.h: * public/platform/WebRect.h: * public/platform/WebSize.h: git-svn-id: http://svn.webkit.org/repository/webkit/trunk@107042 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
haraken@chromium.org authored
https://bugs.webkit.org/show_bug.cgi?id=77846 Reviewed by Darin Adler. In bug 77693, we have added "JS" prefix to several JSC specific IDLs. This patch adds "JS" prefix to the remaining JSC specific IDLs. Specifically, this patch renames IDLs as follows: [CustomDefineOwnProperty] => [JSCustomDefineOwnProperty] [CustomPrototypeDefineOwnProperty] => [JSCustomPrototypeDefineOwnProperty] [GenerateNativeConverter] => [JSGenerateToNativeObject] (Note: For naming consistency with [JSGenerateToJS] and [JSCustomToNativeObject]) [DelegatingGetOwnPropertySlot] => [JSCustomGetOwnPropertySlotDelegate] (Note: Should be prefixed "JS", should be prefixed with "Custom", and for naming consistency with [CustomGetOwnPropertySlot]) No tests. No change in behavior. * bindings/scripts/CodeGeneratorJS.pm: (GenerateGetOwnPropertySlotBody): (GenerateGetOwnPropertyDescriptorBody): (GenerateHeader): (GenerateImplementation): * bindings/scripts/test/TestTypedArray.idl: * dom/Attr.idl: * dom/DataTransferItemList.idl: * dom/Document.idl: * dom/DocumentType.idl: * dom/Element.idl: * dom/Node.idl: * fileapi/DirectoryEntry.idl: * fileapi/DirectoryEntrySync.idl: * fileapi/File.idl: * fileapi/FileEntry.idl: * fileapi/FileEntrySync.idl: * fileapi/WebKitBlobBuilder.idl: * html/DOMFormData.idl: * html/DOMURL.idl: * html/HTMLAppletElement.idl: * html/HTMLCanvasElement.idl: * html/HTMLElement.idl: * html/HTMLEmbedElement.idl: * html/HTMLImageElement.idl: * html/HTMLMediaElement.idl: * html/HTMLObjectElement.idl: * html/HTMLOptionElement.idl: * html/HTMLOptionsCollection.idl: * html/HTMLTableCaptionElement.idl: * html/HTMLTableSectionElement.idl: * html/HTMLVideoElement.idl: * html/TextTrackCue.idl: * html/canvas/Float32Array.idl: * html/canvas/Float64Array.idl: * html/canvas/Int16Array.idl: * html/canvas/Int32Array.idl: * html/canvas/Int8Array.idl: * html/canvas/Uint16Array.idl: * html/canvas/Uint32Array.idl: * html/canvas/Uint8Array.idl: * html/canvas/Uint8ClampedArray.idl: * mediastream/LocalMediaStream.idl: * page/DOMWindow.idl: * page/History.idl: * page/Location.idl: * storage/StorageInfo.idl: * svg/SVGElement.idl: * svg/SVGElementInstance.idl: * workers/DedicatedWorkerContext.idl: * workers/SharedWorker.idl: * workers/SharedWorkerContext.idl: * workers/Worker.idl: * workers/WorkerContext.idl: git-svn-id: http://svn.webkit.org/repository/webkit/trunk@107041 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
morrita@google.com authored
https://bugs.webkit.org/show_bug.cgi?id=78066 Reviewed by Ryosuke Niwa. Added a new default constructor. ex-default constructor will be removed in an upcoming change. * public/WebTextCheckingResult.h: (WebKit::WebTextCheckingResult::WebTextCheckingResult): (WebTextCheckingResult): git-svn-id: http://svn.webkit.org/repository/webkit/trunk@107040 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
haraken@chromium.org authored
https://bugs.webkit.org/show_bug.cgi?id=78076 Reviewed by Adam Barth. This patch renames the [HasOverridingNameGetter] attribute to the [CustomNamedGetter] attribute, for naming consistency with [CustomNamedSetter]. Test: bindings/scripts/test/TestCustomNamedGetter.idl * bindings/scripts/CodeGeneratorJS.pm: (GenerateGetOwnPropertySlotBody): (GenerateGetOwnPropertyDescriptorBody): (GenerateHeader): (GenerateImplementation): * bindings/scripts/CodeGeneratorV8.pm: (GenerateHeaderNamedAndIndexedPropertyAccessors): (GenerateImplementationNamedPropertyGetter): * html/HTMLDocument.idl: * html/HTMLFormElement.idl: * html/HTMLFrameSetElement.idl: * bindings/scripts/test/TestCustomNamedGetter.idl: Renamed from Source/WebCore/bindings/scripts/test/TestOverridingNameGetter.idl. * bindings/scripts/test/CPP/WebDOMTestCustomNamedGetter.cpp: Updated run-bindings-tests results. (WebDOMTestCustomNamedGetter::WebDOMTestCustomNamedGetterPrivate::WebDOMTestCustomNamedGetterPrivate): (WebDOMTestCustomNamedGetter::WebDOMTestCustomNamedGetterPrivate): (WebDOMTestCustomNamedGetter::WebDOMTestCustomNamedGetter): (WebDOMTestCustomNamedGetter::operator=): (WebDOMTestCustomNamedGetter::impl): (WebDOMTestCustomNamedGetter::~WebDOMTestCustomNamedGetter): (WebDOMTestCustomNamedGetter::anotherFunction): (toWebCore): (toWebKit): * bindings/scripts/test/CPP/WebDOMTestCustomNamedGetter.h: Ditto. (WebCore): (WebDOMTestCustomNamedGetter): * bindings/scripts/test/GObject/WebKitDOMTestCustomNamedGetter.cpp: Ditto. (WebKit): (WebKit::kit): (webkit_dom_test_custom_named_getter_another_function): (WebKit::core): (webkit_dom_test_custom_named_getter_finalize): (webkit_dom_test_custom_named_getter_set_property): (webkit_dom_test_custom_named_getter_get_property): (webkit_dom_test_custom_named_getter_constructed): (webkit_dom_test_custom_named_getter_class_init): (webkit_dom_test_custom_named_getter_init): (WebKit::wrapTestCustomNamedGetter): * bindings/scripts/test/GObject/WebKitDOMTestCustomNamedGetter.h: Ditto. (_WebKitDOMTestCustomNamedGetter): (_WebKitDOMTestCustomNamedGetterClass): * bindings/scripts/test/GObject/WebKitDOMTestCustomNamedGetterPrivate.h: Ditto. (WebKit): * bindings/scripts/test/GObject/WebKitDOMTestOverridingNameGetter.h: Ditto. * bindings/scripts/test/JS/JSTestCustomNamedGetter.cpp: Ditto. (WebCore): (WebCore::JSTestCustomNamedGetterConstructor::JSTestCustomNamedGetterConstructor): (WebCore::JSTestCustomNamedGetterConstructor::finishCreation): (WebCore::JSTestCustomNamedGetterConstructor::getOwnPropertySlot): (WebCore::JSTestCustomNamedGetterConstructor::getOwnPropertyDescriptor): (WebCore::JSTestCustomNamedGetterPrototype::self): (WebCore::JSTestCustomNamedGetterPrototype::getOwnPropertySlot): (WebCore::JSTestCustomNamedGetterPrototype::getOwnPropertyDescriptor): (WebCore::JSTestCustomNamedGetter::JSTestCustomNamedGetter): (WebCore::JSTestCustomNamedGetter::finishCreation): (WebCore::JSTestCustomNamedGetter::createPrototype): (WebCore::JSTestCustomNamedGetter::destroy): (WebCore::JSTestCustomNamedGetter::getOwnPropertySlot): (WebCore::JSTestCustomNamedGetter::getOwnPropertyDescriptor): (WebCore::jsTestCustomNamedGetterConstructor): (WebCore::JSTestCustomNamedGetter::getConstructor): (WebCore::jsTestCustomNamedGetterPrototypeFunctionAnotherFunction): (WebCore::isObservable): (WebCore::JSTestCustomNamedGetterOwner::isReachableFromOpaqueRoots): (WebCore::JSTestCustomNamedGetterOwner::finalize): (WebCore::toJS): (WebCore::toTestCustomNamedGetter): * bindings/scripts/test/JS/JSTestCustomNamedGetter.h: Ditto. (WebCore): (JSTestCustomNamedGetter): (WebCore::JSTestCustomNamedGetter::create): (WebCore::JSTestCustomNamedGetter::createStructure): (WebCore::JSTestCustomNamedGetter::impl): (WebCore::JSTestCustomNamedGetter::releaseImpl): (WebCore::JSTestCustomNamedGetter::releaseImplIfNotNull): (JSTestCustomNamedGetterOwner): (WebCore::wrapperOwner): (WebCore::wrapperContext): (JSTestCustomNamedGetterPrototype): (WebCore::JSTestCustomNamedGetterPrototype::create): (WebCore::JSTestCustomNamedGetterPrototype::createStructure): (WebCore::JSTestCustomNamedGetterPrototype::JSTestCustomNamedGetterPrototype): (JSTestCustomNamedGetterConstructor): (WebCore::JSTestCustomNamedGetterConstructor::create): (WebCore::JSTestCustomNamedGetterConstructor::createStructure): * bindings/scripts/test/JS/JSTestOverridingNameGetter.cpp: * bindings/scripts/test/ObjC/DOMTestCustomNamedGetter.h: Ditto. * bindings/scripts/test/ObjC/DOMTestCustomNamedGetter.mm: Ditto. (-[DOMTestCustomNamedGetter dealloc]): (-[DOMTestCustomNamedGetter finalize]): (-[DOMTestCustomNamedGetter anotherFunction:]): (core): (kit): * bindings/scripts/test/ObjC/DOMTestCustomNamedGetterInternal.h: Ditto. (WebCore): * bindings/scripts/test/V8/V8TestCustomNamedGetter.cpp: Ditto. (WebCore): (TestCustomNamedGetterInternal): (WebCore::TestCustomNamedGetterInternal::V8_USE): (WebCore::TestCustomNamedGetterInternal::anotherFunctionCallback): (WebCore::ConfigureV8TestCustomNamedGetterTemplate): (WebCore::V8TestCustomNamedGetter::GetRawTemplate): (WebCore::V8TestCustomNamedGetter::GetTemplate): (WebCore::V8TestCustomNamedGetter::HasInstance): (WebCore::V8TestCustomNamedGetter::wrapSlow): (WebCore::V8TestCustomNamedGetter::derefObject): * bindings/scripts/test/V8/V8TestCustomNamedGetter.h: Ditto. (WebCore): (V8TestCustomNamedGetter): (WebCore::V8TestCustomNamedGetter::toNative): (WebCore::V8TestCustomNamedGetter::existingWrapper): (WebCore::V8TestCustomNamedGetter::wrap): (WebCore::toV8): git-svn-id: http://svn.webkit.org/repository/webkit/trunk@107039 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
eae@chromium.org authored
https://bugs.webkit.org/show_bug.cgi?id=77918 Reviewed by Eric Seidel. Change RenderTableSection cell width, row height and border calculations back to use integers. Table layout is done on integer bounds to comply with the specification and to ensure that columns given the same width, including percentage widths, are rendered with identical widths. The same applies to heights. No new tests. * rendering/RenderTableSection.cpp: (WebCore::RenderTableSection::setCellLogicalWidths): (WebCore::RenderTableSection::calcRowLogicalHeight): (WebCore::RenderTableSection::layoutRows): (WebCore::RenderTableSection::calcOuterBorderBefore): (WebCore::RenderTableSection::calcOuterBorderAfter): (WebCore::RenderTableSection::calcOuterBorderStart): (WebCore::RenderTableSection::calcOuterBorderEnd): (WebCore::RenderTableSection::paintObject): (WebCore::RenderTableSection::nodeAtPoint): * rendering/RenderTableSection.h: (RenderTableSection): (WebCore::RenderTableSection::RowStruct::RowStruct): (WebCore::RenderTableSection::outerBorderBefore): (WebCore::RenderTableSection::outerBorderAfter): (WebCore::RenderTableSection::outerBorderStart): (WebCore::RenderTableSection::outerBorderEnd): git-svn-id: http://svn.webkit.org/repository/webkit/trunk@107038 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
commit-queue@webkit.org authored
https://bugs.webkit.org/show_bug.cgi?id=78061 Patch by Gregg Tavares <gman@google.com> on 2012-02-07 Reviewed by Kenneth Russell. * public/WebSettings.h: * src/WebSettingsImpl.cpp: (WebKit::WebSettingsImpl::setWebGLErrorsToConsoleEnabled): (WebKit): * src/WebSettingsImpl.h: (WebSettingsImpl): git-svn-id: http://svn.webkit.org/repository/webkit/trunk@107037 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
commit-queue@webkit.org authored
gesture recognizer. https://bugs.webkit.org/show_bug.cgi?id=77492 Patch by Robert Kroeger <rjkroege@chromium.org> on 2012-02-07 Reviewed by Adam Barth. * wtf/Platform.h: Source/WebCore: [chromium] Remove the no longer necessary Chromium gesture recognizer. https://bugs.webkit.org/show_bug.cgi?id=77492 Patch by Robert Kroeger <rjkroege@chromium.org> on 2012-02-07 Reviewed by Adam Barth. * WebCore.gypi: * platform/PlatformGestureRecognizer.h: Removed. * platform/chromium/FramelessScrollView.h: (WebCore): (FramelessScrollView): * platform/chromium/GestureRecognizerChromium.cpp: Removed. * platform/chromium/GestureRecognizerChromium.h: Removed. * platform/chromium/PopupContainer.cpp: (WebCore): * platform/chromium/PopupContainer.h: * platform/chromium/PopupListBox.cpp: (WebCore): * platform/chromium/PopupListBox.h: (PopupListBox): Source/WebKit: [chromium] Remove no longer necessary Chromium gesture recognizer code. https://bugs.webkit.org/show_bug.cgi?id=77492 Patch by Robert Kroeger <rjkroege@chromium.org> on 2012-02-07 Reviewed by Adam Barth. * blackberry/WebCoreSupport/AboutDataEnableFeatures.in: Source/WebKit/chromium: [chromium] Remove no longer necessary Chromium gesture recognizer code. https://bugs.webkit.org/show_bug.cgi?id=77492 Patch by Robert Kroeger <rjkroege@chromium.org> on 2012-02-07 Reviewed by Adam Barth. * WebKit.gypi: * features.gypi: * src/WebFrameImpl.cpp: (WebKit::WebFrameImpl::createFrameView): * src/WebPopupMenuImpl.cpp: (WebKit::WebPopupMenuImpl::WebPopupMenuImpl): (WebKit::WebPopupMenuImpl::handleTouchEvent): * src/WebPopupMenuImpl.h: * src/WebViewImpl.cpp: (WebKit::WebViewImpl::WebViewImpl): (WebKit::WebViewImpl::touchEvent): * src/WebViewImpl.h: (WebCore): (WebViewImpl): * tests/InnerGestureRecognizerTest.cpp: Removed. LayoutTests: [chromium] Remove unnecessary Chromium gesture recognizer tests. https://bugs.webkit.org/show_bug.cgi?id=77492 Patch by Robert Kroeger <rjkroege@chromium.org> on 2012-02-07 Reviewed by Adam Barth. * fast/events/touch/page-scaled-touch-gesture-click-expected.txt: * fast/events/touch/page-scaled-touch-gesture-click.html: * fast/events/touch/touch-gesture-click-expected.txt: Removed. * fast/events/touch/touch-gesture-click.html: Removed. * fast/events/touch/touch-gesture-scroll-expected.txt: Removed. * fast/events/touch/touch-gesture-scroll.html: Removed. * platform/chromium/fast/events/touch/touch-gesture-click-expected.txt: Removed. * platform/chromium/fast/events/touch/touch-gesture-scroll-expected.txt: Removed. git-svn-id: http://svn.webkit.org/repository/webkit/trunk@107036 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
arv@chromium.org authored
https://bugs.webkit.org/show_bug.cgi?id=78052 Reviewed by Nate Chapin. Source/WebCore: Before this patch the code generator did not add the named hidden reference when the data node was a DOM Node. This lead to us having to create custom toV8 bindings in a few places. Covered by existing tests * Target.pri: * UseV8.cmake: * WebCore.gypi: * bindings/scripts/CodeGeneratorV8.pm: (GenerateNormalAttrGetter): (HasCustomToV8Implementation): * bindings/v8/custom/V8DOMStringMapCustom.cpp: * bindings/v8/custom/V8DOMTokenListCustom.cpp: Removed. * bindings/v8/custom/V8NamedNodeMapCustom.cpp: LayoutTests: * platform/chromium/test_expectations.txt: git-svn-id: http://svn.webkit.org/repository/webkit/trunk@107035 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
haraken@chromium.org authored
https://bugs.webkit.org/show_bug.cgi?id=78059 Reviewed by Adam Barth. CodeGeneratorGObject.pm does not support custom attributes. We can skip generating code for attributes with [Custom]. The change would make sense, since CodeGeneratorGObject.pm already skips attributes with [CustomGetter] or [CustomSetter]. Test: bindings/scripts/test/TestObj.idl * bindings/scripts/CodeGeneratorGObject.pm: (SkipAttribute): * bindings/scripts/test/GObject/WebKitDOMTestObj.cpp: git-svn-id: http://svn.webkit.org/repository/webkit/trunk@107034 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
leo.yang@torchmobile.com.cn authored
https://bugs.webkit.org/show_bug.cgi?id=77843 Reviewed by Rob Buis. Initial upstream, no new tests. * blackberry/WebCoreSupport/ChromeClientBlackBerry.cpp: Added. * blackberry/WebCoreSupport/ChromeClientBlackBerry.h: Added. git-svn-id: http://svn.webkit.org/repository/webkit/trunk@107033 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
eae@chromium.org authored
https://bugs.webkit.org/show_bug.cgi?id=78040 Reviewed by Eric Seidel. Add pixel snapped versions of x/y/width/height methods. These return the same value as the x/w/width/height methods for now but once we move over to sub pixel layout they will snap the subpixel value to a device pixel and return an integer value. When snapping the left and top edge is simply rounded to the nearest device pixel. The right and bottom edges are computed by subtracting the rounded left/ top edge from the precise location and size. This ensures that the edges all line up with device pixels and that the total size of an object, including borders, is at most one pixel off. In summary, the values are computed as follows: x: round(x) y: round(y) maxX: round(x + width) maxY: round(y + height) width: round(x + width) - round(x) height: round(y + height) - round(y) We use the term pixel snapped to indicate that the numbers are not merely rounded. This also matches the naming used by the line box tree. No new tests, no functionality changes. * page/PrintContext.cpp: (WebCore::PrintContext::pageNumberForElement): * rendering/RenderBlock.cpp: (WebCore::::collectIfNeeded): * rendering/RenderBlock.h: (RenderBlock): (WebCore::RenderBlock::pixelSnappedLogicalRightOffsetForLine): (WebCore::RenderBlock::pixelSnappedLogicalLeftOffsetForLine): (WebCore::RenderBlock::FloatingObject::pixelSnappedX): (WebCore::RenderBlock::FloatingObject::pixelSnappedMaxX): (WebCore::RenderBlock::FloatingObject::pixelSnappedY): (WebCore::RenderBlock::FloatingObject::pixelSnappedMaxY): (WebCore::RenderBlock::FloatingObject::pixelSnappedWidth): (WebCore::RenderBlock::FloatingObject::pixelSnappedHeight): (FloatingObject): (WebCore::RenderBlock::pixelSnappedLogicalTopForFloat): (WebCore::RenderBlock::pixelSnappedLogicalBottomForFloat): (WebCore::RenderBlock::pixelSnappedLogicalLeftForFloat): (WebCore::RenderBlock::pixelSnappedLogicalRightForFloat): * rendering/RenderBlockLineLayout.cpp: (WebCore::LineWidth::shrinkAvailableWidthForNewFloatIfNeeded): * rendering/RenderBox.cpp: (WebCore::RenderBox::pixelSnappedClientWidth): (WebCore): (WebCore::RenderBox::pixelSnappedClientHeight): (WebCore::RenderBox::scrollHeight): * rendering/RenderBox.h: (WebCore::RenderBox::pixelSnappedWidth): (WebCore::RenderBox::pixelSnappedHeight): (RenderBox): (WebCore::RenderBox::pixelSnappedOffsetWidth): (WebCore::RenderBox::pixelSnappedOffsetHeight): (WebCore::RenderBox::clientLogicalWidth): (WebCore::RenderBox::clientLogicalHeight): * rendering/RenderBoxModelObject.cpp: (WebCore::RenderBoxModelObject::pixelSnappedOffsetWidth): (WebCore): (WebCore::RenderBoxModelObject::pixelSnappedOffsetHeight): * rendering/RenderBoxModelObject.h: (WebCore::RenderBoxModelObject::pixelSnappedOffsetLeft): (WebCore::RenderBoxModelObject::pixelSnappedOffsetTop): (RenderBoxModelObject): * rendering/RenderLayer.cpp: (WebCore::RenderLayer::pixelSnappedScrollWidth): (WebCore): (WebCore::RenderLayer::pixelSnappedScrollHeight): (WebCore::RenderLayer::computeScrollDimensions): (WebCore::RenderLayer::updateScrollInfoAfterLayout): * rendering/RenderLayer.h: (RenderLayer): * rendering/RenderListBox.cpp: (WebCore::RenderListBox::scrollHeight): * rendering/RenderTheme.cpp: (WebCore::RenderTheme::volumeSliderOffsetFromMuteButton): * rendering/RenderTreeAsText.cpp: (WebCore::write): git-svn-id: http://svn.webkit.org/repository/webkit/trunk@107032 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
jchaffraix@webkit.org authored
Add / update the baselines for fast/text/synthetic-bold-transformed.html and svg/custom/use-disappears-after-style-update.svg. * platform/chromium-linux-x86/svg/custom/use-disappears-after-style-update-expected.txt: Added. * platform/chromium-linux/fast/text/synthetic-bold-transformed-expected.png: Added. * platform/chromium-linux/svg/custom/use-disappears-after-style-update-expected.txt: Added. * platform/chromium-mac-snowleopard/fast/text/synthetic-bold-transformed-expected.png: Added. * platform/chromium-mac-snowleopard/svg/custom/use-disappears-after-style-update-expected.png: Added. * platform/chromium-win-vista/svg/custom/use-disappears-after-style-update-expected.txt: Added. * platform/chromium-win-xp/svg/custom/use-disappears-after-style-update-expected.txt: Added. * platform/chromium-win/fast/text/synthetic-bold-transformed-expected.png: Added. * platform/chromium-win/svg/custom/use-disappears-after-style-update-expected.png: Added. * platform/chromium-win/svg/custom/use-disappears-after-style-update-expected.txt: Added. git-svn-id: http://svn.webkit.org/repository/webkit/trunk@107031 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
mikelawther@chromium.org authored
https://bugs.webkit.org/show_bug.cgi?id=77960 Source/WebCore: Adds simple number/percent expression evaluation. rgb() and hsl() functions now allow simple calc() expressions. Reviewed by Ojan Vafai. * css/CSSCalculationValue.cpp: (WebCore): (WebCore::CSSCalcValue::doubleValue): (WebCore::CSSCalcPrimitiveValue::doubleValue): (WebCore::CSSCalcBinaryOperation::doubleValue): (CSSCalcBinaryOperation): (WebCore::CSSCalcBinaryOperation::evaluate): * css/CSSCalculationValue.h: (CSSCalcExpressionNode): (WebCore::CSSCalcValue::isInt): (CSSCalcValue): * css/CSSParser.cpp: (WebCore::CSSParser::parsedDouble): LayoutTests: Reviewed by Ojan Vafai. * css3/calc/color-hsl-expected.txt: * css3/calc/color-rgb-expected.txt: git-svn-id: http://svn.webkit.org/repository/webkit/trunk@107030 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
kling@webkit.org authored
<http://webkit.org/b/78068> Reviewed by Ryosuke Niwa. Create CSS_IDENT values for attribute styles in the document's CSSValuePool. This regressed in r106756 and I suspect it'll fix up the cycler regression. * dom/StyledElement.cpp: (WebCore::StyledElement::addCSSProperty): git-svn-id: http://svn.webkit.org/repository/webkit/trunk@107029 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
timothy@apple.com authored
This also makes sure the inspector WKView is in a window before the page is loaded. This avoids some redundant work caused by moving it to a window later. https://webkit.org/b/78064 Reviewed by Brian Weinstein. * UIProcess/WebInspectorProxy.cpp: (WebKit::WebInspectorProxy::createInspectorPage): Set m_isAttached here... (WebKit::WebInspectorProxy::didLoadInspectorPage): ... instead of here. * UIProcess/WebInspectorProxy.h: (WebInspectorProxy): * UIProcess/mac/WebInspectorProxyMac.mm: (WebKit::WebInspectorProxy::createInspectorWindow): Added. Factored out of platformOpen. (WebKit::WebInspectorProxy::updateInspectorWindowTitle): Added. Factored out of platformInspectedURLChanged. (WebKit::WebInspectorProxy::platformCreateInspectorPage): Call platformAttach or createInspectorWindow. (WebKit::WebInspectorProxy::platformOpen): Make the view or window visible. (WebKit::WebInspectorProxy::platformDidClose): Only message m_inspectorWindow if it isn't nil. (WebKit::WebInspectorProxy::platformInspectedURLChanged): Store the urlString and call updateInspectorWindowTitle. (WebKit::WebInspectorProxy::inspectedViewFrameDidChange): Return early if not visible. (WebKit::WebInspectorProxy::platformAttach): Start out hidden if we are not visible yet. Destroy the window. (WebKit::WebInspectorProxy::platformDetach): Use createInspectorWindow to create it again. git-svn-id: http://svn.webkit.org/repository/webkit/trunk@107028 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
noel.gordon@gmail.com authored
https://bugs.webkit.org/show_bug.cgi?id=78055 Reviewed by Noam Rosenthal. TextureMapperQt.{cpp,h} were removed in r106659, remove references to these files from the gyp projects. * WebCore.gypi: git-svn-id: http://svn.webkit.org/repository/webkit/trunk@107027 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
tony@chromium.org authored
https://bugs.webkit.org/show_bug.cgi?id=78036 Reviewed by Darin Adler. Source/JavaScriptCore: * Configurations/FeatureDefines.xcconfig: Add ENABLE_DASHBOARD_SUPPORT to FEATURE_DEFINES. Source/WebCore: In r89362, we started running the preprocessor through CSSPropertyNames.in. Now we can move DashboardSupportCSSPropertyNames.in into CSSPropertyNames.in and wrap it in an #if. No new tests, build refactoring. * Configurations/FeatureDefines.xcconfig: Add ENABLE_DASHBOARD_SUPPORT to FEATURE_DEFINES. * DerivedSources.make: Remove DashboardSupportCSSPropertyNames.in. * DerivedSources.pri: Remove DashboardSupportCSSPropertyNames.in. * WebCore.xcodeproj/project.pbxproj: Remove DashboardSupportCSSPropertyNames.in. * css/CSSPropertyNames.in: Wrap -webkit-dashboard-region in an #if. * css/DashboardSupportCSSPropertyNames.in: Removed. Source/WebKit/mac: * Configurations/FeatureDefines.xcconfig: Add ENABLE_DASHBOARD_SUPPORT to FEATURE_DEFINES. Source/WebKit2: * Configurations/FeatureDefines.xcconfig: Add ENABLE_DASHBOARD_SUPPORT to FEATURE_DEFINES. git-svn-id: http://svn.webkit.org/repository/webkit/trunk@107026 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
commit-queue@webkit.org authored
https://bugs.webkit.org/show_bug.cgi?id=75522 Patch by Xingnan Wang <xingnan.wang@intel.com> on 2012-02-07 Reviewed by Tony Chang. Add the FFTFrame implementation using Intel IPP's DFT algorithm. * WebCore.gyp/WebCore.gyp: * WebCore.gypi: * platform/audio/FFTFrame.h: (FFTFrame): * platform/audio/FFTFrameStub.cpp: * platform/audio/ipp/FFTFrameIPP.cpp: Added. (WebCore): (WebCore::FFTFrame::FFTFrame): (WebCore::FFTFrame::initialize): (WebCore::FFTFrame::cleanup): (WebCore::FFTFrame::~FFTFrame): (WebCore::FFTFrame::multiply): (WebCore::FFTFrame::doFFT): (WebCore::FFTFrame::doInverseFFT): (WebCore::FFTFrame::realData): (WebCore::FFTFrame::imagData): (WebCore::FFTFrame::getUpToDateComplexData): git-svn-id: http://svn.webkit.org/repository/webkit/trunk@107025 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
enne@google.com authored
https://bugs.webkit.org/show_bug.cgi?id=78033 Reviewed by James Robinson. There's no need to enumerate all tag names when searching for a top-level frame. If a render view's document has a frame, then that frame is not the top-level one. * rendering/RenderLayerCompositor.cpp: (WebCore::RenderLayerCompositor::shouldPropagateCompositingToEnclosingFrame): * rendering/RenderLayerCompositor.h: (RenderLayerCompositor): git-svn-id: http://svn.webkit.org/repository/webkit/trunk@107024 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
commit-queue@webkit.org authored
https://bugs.webkit.org/show_bug.cgi?id=77907 Patch by Chris Palmer <palmer@google.com> on 2012-02-07 Reviewed by Eric Seidel. Source/WebCore: Test is LayoutTests/http/tests/appcache/deferred-events-delete-while-raising-timer.html. * loader/FrameLoader.cpp: (WebCore::FrameLoader::checkTimerFired): LayoutTests: * http/tests/appcache/deferred-events-delete-while-raising-timer-expected.txt: Added. * http/tests/appcache/deferred-events-delete-while-raising-timer.html: Added. * http/tests/appcache/resources/deferred-events-delete-while-raising-timer-1.html: Added. * http/tests/appcache/resources/deferred-events-delete-while-raising-timer-2.html: Added. git-svn-id: http://svn.webkit.org/repository/webkit/trunk@107023 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
commit-queue@webkit.org authored
https://bugs.webkit.org/show_bug.cgi?id=78039 Patch by Justin Novosad <junov@chromium.org> on 2012-02-07 Reviewed by Stephen White. Adding the --enable-deferred-2d-canvas switch to DumpRenderTree * DumpRenderTree/chromium/DumpRenderTree.cpp: (main): * DumpRenderTree/chromium/TestShell.cpp: (TestShell::TestShell): (TestShell::resetWebSettings): (TestShell::runFileTest): * DumpRenderTree/chromium/TestShell.h: (TestShell::setDeferred2dCanvasEnabled): (TestShell): * DumpRenderTree/chromium/WebPreferences.cpp: (WebPreferences::reset): (WebPreferences::applyTo): * DumpRenderTree/chromium/WebPreferences.h: (WebPreferences): git-svn-id: http://svn.webkit.org/repository/webkit/trunk@107022 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
commit-queue@webkit.org authored
https://bugs.webkit.org/show_bug.cgi?id=78029 Patch by Yong Li <yoli@rim.com> on 2012-02-07 Reviewed by Rob Buis. When a redirect is rejected by security origin check, the ResourceRequest will be cleared (see DocumentThreadableLoader::redirectReceived()). In this case, we should stop handling the request. No new tests because existing tests (like http:/tests/xmlhttprequest/redirect-cross -origin-tripmine.html) can cover this. * platform/network/blackberry/NetworkJob.cpp: (WebCore::NetworkJob::startNewJobWithRequest): git-svn-id: http://svn.webkit.org/repository/webkit/trunk@107021 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
gyuyoung.kim@samsung.com authored
https://bugs.webkit.org/show_bug.cgi?id=77928 Reviewed by Daniel Bates. CMake has used *Programs* directory for executable. In addition, shared libraries are being built in source directory. It is better to set common places in order to maintain executable and libraries. *bin* is for executable and *lib* is for library. .: * CMakeLists.txt: Set library output path. * Source/cmake/WebKitFS.cmake: Remove *Programs* creation. Source/JavaScriptCore: * shell/CMakeLists.txt: Change *Programs* with *bin*. Source/WebKit2: * CMakeLists.txt: Tools: * DumpRenderTree/efl/CMakeLists.txt: * EWebLauncher/CMakeLists.txt: * Scripts/run-launcher: * Scripts/webkitdirs.pm: (jscProductDir): * Scripts/webkitpy/layout_tests/port/efl.py: (EflPort._path_to_driver): (EflPort._path_to_image_diff): git-svn-id: http://svn.webkit.org/repository/webkit/trunk@107020 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
commit-queue@webkit.org authored
https://bugs.webkit.org/show_bug.cgi?id=78034 Source/WebCore: Patch by David Barton <dbarton@mathscribe.com> on 2012-02-07 Reviewed by Eric Seidel. Per Darin Adler, I am breaking up the patch fixing bug 52444 into smaller pieces. This patch removes a couple unused functions, some extra blank lines, unused #include directives, etc., and adds a very few WebKit-standard changes to these files. No new tests. * rendering/mathml/RenderMathMLBlock.cpp: (WebCore): * rendering/mathml/RenderMathMLBlock.h: (WebCore::RenderMathMLBlock::getBoxModelObjectHeight): - changed to a static member function since 'this' is unused; removed redundant non-const version (WebCore::RenderMathMLBlock::getBoxModelObjectWidth): - changed to a static member function since 'this' is unused; removed redundant non-const version (WebCore): * rendering/mathml/RenderMathMLFraction.cpp: * rendering/mathml/RenderMathMLMath.cpp: * rendering/mathml/RenderMathMLMath.h: * rendering/mathml/RenderMathMLOperator.h: (WebCore): * rendering/mathml/RenderMathMLRoot.cpp: * rendering/mathml/RenderMathMLRow.cpp: * rendering/mathml/RenderMathMLRow.h: * rendering/mathml/RenderMathMLSquareRoot.cpp: * rendering/mathml/RenderMathMLSquareRoot.h: * rendering/mathml/RenderMathMLSubSup.cpp: * rendering/mathml/RenderMathMLSubSup.h: * rendering/mathml/RenderMathMLUnderOver.cpp: * rendering/mathml/RenderMathMLUnderOver.h: LayoutTests: Patch by David Barton <dbarton@mathscribe.com> on 2012-02-07 Reviewed by Eric Seidel. The rendering of the scrollbar in row-expected.png was flaky, presumably due to a test environment timing issue, so I removed it. * mathml/presentation/row.xhtml: * platform/mac/mathml/presentation/row-expected.png: * platform/mac/mathml/presentation/row-expected.txt: git-svn-id: http://svn.webkit.org/repository/webkit/trunk@107019 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
commit-queue@webkit.org authored
Override expected-failure mac-leopard/media/media-blocked-by-beforeload-expected.txt with copy of expected-success expectation, for chromium-mac-leopard. https://bugs.webkit.org/show_bug.cgi?id=78030 Unreviewed. Patch by Ami Fischman <fischman@chromium.org> on 2012-02-07 * platform/chromium-mac-leopard/media/media-blocked-by-beforeload-expected.txt: Added. git-svn-id: http://svn.webkit.org/repository/webkit/trunk@107018 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-