1. 24 Jun, 2009 4 commits
  2. 23 Jun, 2009 36 commits
    • oliver@apple.com's avatar
      <rdar://problem/6992806> REGRESSION: Enumeration can skip new properties in... · 8fda65e2
      oliver@apple.com authored
      <rdar://problem/6992806> REGRESSION: Enumeration can skip new properties in cases of prototypes that have more than 64 (26593)
      <https://bugs.webkit.org/show_bug.cgi?id=26593>
      
      Reviewed by Gavin Barraclough.
      
      Add tests to ensure we correctly invalidate caching that depends on structure chains
      that include dictionaries.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@45039 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      8fda65e2
    • agl@chromium.org's avatar
      2009-06-23 Adam Langley <agl@google.com> · 6e4dedd2
      agl@chromium.org authored
              Reviewed by Eric Seidel.
      
              Chromium: Fix crash with inherited font-size in <option>
      
              https://bugs.webkit.org/show_bug.cgi?id=26656
              http://code.google.com/p/chromium/issues/detail?id=14853
      
              In r42597 (https://bugs.webkit.org/show_bug.cgi?id=25244), I changed
              the <select> handing for Chromium to fix a rendering bug. However,
              although the font-size is correctly ignored, getRowHeight wasn't
              updated and so was calculating the height of the rows in an
              inconsistent manner. This can lead to a crash.
      
              * manual-tests/optgroup-empty-and-nested.html: adding test case for crash
              * platform/chromium/PopupMenuChromium.cpp:
              (WebCore::PopupListBox::getRowHeight):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@45038 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      6e4dedd2
    • eric@webkit.org's avatar
      2009-06-23 Takeshi Yoshino <tyoshino@google.com> · 87eca840
      eric@webkit.org authored
              Reviewed by Mark Rowe.
      
              Bug 26537: Builds from command-line fail if custom build product directory is set and ~/Library/Preferences/xcodebuild.plist exists
              https://bugs.webkit.org/show_bug.cgi?id=26537
      
              Let determineBaseProductDir subroutine remove
              ~/Library/Preferences/xcodebuild.plist. It can prevent xcodebuild from
              respecting global settings such as a custom build products directory
              (<rdar://problem/5585899>).
      
              * Scripts/webkitdirs.pm:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@45032 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      87eca840
    • beidson@apple.com's avatar
      2009-06-23 Brady Eidson <beidson@apple.com> · a9b9735b
      beidson@apple.com authored
              Patch by Antti Koivisto.
              Reviewed by Brady Eidson.
      
              <rdar://problem/6988010> Failed resources not reloaded when built against Tiger SDK
      
              A latent bug that cache revalidation uncovered.  When a CachedResource failed to load,
              it should always be revalidated upon reload.
      
              * loader/CachedResource.cpp:
              (WebCore::CachedResource::canUseCacheValidator):
              (WebCore::CachedResource::mustRevalidate):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@45031 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      a9b9735b
    • ojan@chromium.org's avatar
      2009-06-23 Ojan Vafai <ojan@chromium.org> · 1062b2ef
      ojan@chromium.org authored
              Reviewed by Mark Rowe.
      
              Resets the results for a test that was missed in
              http://trac.webkit.org/changeset/45016.
      
              * editing/execCommand/5142012-3-expected.txt:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@45027 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      1062b2ef
    • eric@webkit.org's avatar
      2009-06-23 Eric Seidel <eric@webkit.org> · ba1b6d76
      eric@webkit.org authored
              Reviewed by Dave Levin.
      
              Make SCM.run_command smarter, and make all previous
              os.system and subprocess.popen use SCM.run_command instead.
              https://bugs.webkit.org/show_bug.cgi?id=26666
      
              This makes it easier to handle errors in a standard way throughout all the code.
              Since this new code raises by default when the exit_code != 0,
              we should prevent future problems of bugzilla-tool continuing after
              a git or svn command failed.
      
              * Scripts/modules/scm.py:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@45026 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      ba1b6d76
    • beidson@apple.com's avatar
      2009-06-23 Brady Eidson <beidson@apple.com> · 3040ad0f
      beidson@apple.com authored
              Reviewed by Darin Adler.
      
              <rdar://problem/6950660> REGRESSION: iSale 5.5.3 crashes after I click a template to load
      
              Due to some subtle WebKit changes - presumably some delegate callback behavior - a latent bug in 
              iSale was uncovered where they aren't properly retaining their FrameLoadDelegate, and we ended up
              calling back to a dealloc'ed object.
      
              * WebView/WebView.mm:
              (-[WebView _needsAdobeFrameReloadingQuirk]): Use more intelligent C++-style initialization.
              (-[WebView _needsKeyboardEventDisambiguationQuirks]): Ditto.
              (-[WebView _needsFrameLoadDelegateRetainQuirk]): YES for iSale versions under 5.6
              (-[WebView dealloc]): Release the delegate if the quirk is in effect.
              (-[WebView setFrameLoadDelegate:]): Retain the new delegate if the quirk is in effect.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@45021 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      3040ad0f
    • mitz@apple.com's avatar
      Reviewed by Darin Adler. · 2dce36c5
      mitz@apple.com authored
              - fix <rdar://problem/6634228> Crash in [NSScroller mouseDown:] beneath
                EventHandler::passMouseDownEventToWidget()
      
              * page/mac/EventHandlerMac.mm:
              (WebCore::EventHandler::passMouseDownEventToWidget): Surround the
              -mouseDown: call with calls to Widget::beforeMouseDown() and
              Widget::afterMouseDown(), which prevent the widget's view hierarchy from
              being removed from its parent view while the scroller is tracking the
              mouse.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@45019 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      2dce36c5
    • weinig@apple.com's avatar
      WebCore: · 36c14421
      weinig@apple.com authored
      2009-06-23  Sam Weinig  <sam@webkit.org>
      
              Reviewed by Dave Hyatt.
      
              Fix for https://bugs.webkit.org/show_bug.cgi?id=26516
              Add initial implementation of DataGridDataSource
      
              - Initial implementation only supports the initialize callback function.
      
              Test: fast/dom/HTMLDataGridElement/DataGridDataSource-basic.html
      
              * WebCore.xcodeproj/project.pbxproj:
              * GNUmakefile.am:
              * WebCore.pro:
              * WebCore.vcproj/WebCore.vcproj:
              * WebCore.xcodeproj/project.pbxproj:
              * WebCoreSources.bkl:
              * bindings/js/JSDataGridDataSource.cpp: Added.
              (WebCore::JSDataGridDataSource::JSDataGridDataSource):
              (WebCore::JSDataGridDataSource::~JSDataGridDataSource):
              (WebCore::JSDataGridDataSource::initialize):
              * bindings/js/JSDataGridDataSource.h: Added.
              (WebCore::JSDataGridDataSource::create):
              (WebCore::JSDataGridDataSource::isJSDataGridDataSource):
              (WebCore::JSDataGridDataSource::jsDataSource):
              (WebCore::asJSDataGridDataSource):
              * bindings/js/JSHTMLDataGridElementCustom.cpp: Added.
              (WebCore::JSHTMLDataGridElement::listener):
              (WebCore::JSHTMLDataGridElement::setListener):
              * html/DataGridDataSource.h: Added.
              (WebCore::DataGridDataSource::~DataGridDataSource):
              (WebCore::DataGridDataSource::isJSDataGridDataSource):
              * html/HTMLDataGridElement.cpp:
              (WebCore::HTMLDataGridElement::HTMLDataGridElement):
              (WebCore::HTMLDataGridElement::setDataSource):
              (WebCore::HTMLDataGridElement::initializationTimerFired):
              * html/HTMLDataGridElement.h:
              (WebCore::HTMLDataGridElement::dataSource):
              * html/HTMLDataGridElement.idl:
      
      LayoutTests:
      
      2009-06-23  Sam Weinig  <sam@webkit.org>
      
              Reviewed by Dave Hyatt.
      
              Test for https://bugs.webkit.org/show_bug.cgi?id=26516
              Add initial implementation of DataGridDataSource
      
              * fast/dom/HTMLDataGridElement: Added.
              * fast/dom/HTMLDataGridElement/DataGridDataSource-basic-expected.txt: Added.
              * fast/dom/HTMLDataGridElement/DataGridDataSource-basic.html: Added.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@45018 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      36c14421
    • jparent@chromium.org's avatar
      WebCore: · 0f0ad610
      jparent@chromium.org authored
      2009-06-23  Ryosuke Niwa  <rniwa@google.com>
      
              Reviewed by Justin Garcia.
      
              Undo the changeset 21212 to fix the regression bug 14062.
              The changeset 21212 attempted to fix rdar://problem/5002441.
              The changeset 21212 modified InsertTextCommand::input so as to convert
              all spaces in text to non-breaking spaces for rdar://problem/5002441.
              However, the bug was originally caused by rebalanceWhitespaceAt
              and this workaround introduced a regression bug 14062.
              Because rebalanceWhitespaceAt appears to behave correctly now,
              the workaround introduced in 21212 is no longer needed.
      
              Test: editing/inserting/space-after-removeformat.html
      
              * editing/InsertTextCommand.cpp:
              (WebCore::InsertTextCommand::input):
      
      LayoutTests:
      
      2009-06-23  Ryosuke Niwa  <rniwa@google.com>
      
              Reviewed by Justin Garcia.
      
              Undo the changeset 21212 to fix the regression bug 14062.
              The changeset 21212 attempted to fix rdar://problem/5002441.
              The changeset 21212 modified InsertTextCommand::input so as to convert
              all spaces in text to non-breaking spaces for rdar://problem/5002441.
              However, the bug was originally caused by rebalanceWhitespaceAt
              and this workaround introduced a regression bug 14062.
              Because rebalanceWhitespaceAt appears to behave correctly now,
              the workaround introduced in 21212 is no longer needed.
      
              The following test cases are affected by this change.
              This patch removes unappropriate non-breaking spaces (&nbsp;) and
              inserts normal spaces instead.
      
              * editing/deleting/2610675-1-expected.txt: Replaced.
              * editing/deleting/2610675-2-expected.txt: Replaced.
              * editing/deleting/2610675-3-expected.txt: Replaced.
              * editing/inserting/insert-before-link-1-expected.txt: Replaced.
              * editing/inserting/space-after-removeformat-expected.txt: Added.
              * editing/inserting/space-after-removeformat.html: Added.
              * platform/mac/editing/execCommand/5482023-expected.checksum: Replaced.
              * platform/mac/editing/execCommand/5482023-expected.png: Replaced.
              * platform/mac/editing/execCommand/5482023-expected.txt: Replaced.
              * platform/mac/editing/input/text-input-controller-expected.txt: Replaced.
              * platform/mac/editing/inserting/editable-html-element-expected.checksum: Replaced.
              * platform/mac/editing/inserting/editable-html-element-expected.png: Replaced.
              * platform/mac/editing/inserting/editable-html-element-expected.txt: Replaced.
              * platform/mac/editing/pasteboard/4989774-expected.checksum: Replaced.
              * platform/mac/editing/pasteboard/4989774-expected.png: Replaced.
              * platform/mac/editing/pasteboard/4989774-expected.txt: Replaced.
              * platform/mac/editing/selection/4983858-expected.checksum: Replaced.
              * platform/mac/editing/selection/4983858-expected.png: Replaced.
              * platform/mac/editing/selection/4983858-expected.txt: Replaced.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@45016 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      0f0ad610
    • bdakin@apple.com's avatar
      WebCore: · abe8d153
      bdakin@apple.com authored
      2009-06-23  Beth Dakin  <bdakin@apple.com>
      
              Reviewed by Dave Hyatt.
      
              Fix for https://bugs.webkit.org/show_bug.cgi?id=26523 <col> 
              elements width can't be changed with javascript
      
              This patch both fixes setting the width attribute directly in 
              JavaScript, and setting the width on the style attribute. 
      
              * html/HTMLTableColElement.cpp:
              (WebCore::HTMLTableColElement::parseMappedAttribute): If we have a 
              new width, call setNeedsLayoutAndPrefWidthsRecalc()
      
              Call calcPrefWidths() on the table cols.
              * rendering/AutoTableLayout.cpp:
              (WebCore::AutoTableLayout::recalcColumn):
              * rendering/FixedTableLayout.cpp:
              (WebCore::FixedTableLayout::calcWidthArray):
              
              Call layoutIfNeeded on the table cols.
              * rendering/RenderTable.cpp:
              (WebCore::RenderTable::layout):
      
              * rendering/RenderTableCol.cpp:
              (WebCore::RenderTableCol::clippedOverflowRectForRepaint): Use new 
              table() convenience function.
              (WebCore::RenderTableCol::calcPrefWidths): Just call 
              setPrefWidthsDirty(false) on ourself and our children.
              (WebCore::RenderTableCol::table):
              * rendering/RenderTableCol.h:
      
      LayoutTests:
      
      2009-06-23  Beth Dakin  <bdakin@apple.com>
      
              Reviewed by Dave Hyatt.
      
              Test for https://bugs.webkit.org/show_bug.cgi?id=26523 <col> 
              elements width can't be changed with javascript
      
              * fast/dom/HTMLTableColElement: Added.
              * fast/dom/HTMLTableColElement/resize-table-using-col-width.html: Added.
              * platform/mac/fast/dom/HTMLTableColElement: Added.
              * platform/mac/fast/dom/HTMLTableColElement/resize-table-using-col-width-expected.checksum: Added.
              * platform/mac/fast/dom/HTMLTableColElement/resize-table-using-col-width-expected.png: Added.
              * platform/mac/fast/dom/HTMLTableColElement/resize-table-using-col-width-expected.txt: Added.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@45015 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      abe8d153
    • ojan@chromium.org's avatar
      WebCore: · 7ae729be
      ojan@chromium.org authored
      2009-06-23  Ojan Vafai  <ojan@chromium.org>
      
              Reviewed by Dan Bernstein.
      
              Add logic to CSSStyleDeclaration::diff to deal with font-sizes that are
              keyword values. When diff is called on a CSSStyleDeclaration, we check
              the keywordSize to see if font-size matches a keyword value.
      
              This ensures that when we diff a CSSMutableStyleDeclaration returned from
              copyInheritableProperties on a CSSComputedStyleDeclaration that we
              correctly identify matching font-sizes.
      
              https://bugs.webkit.org/show_bug.cgi?id=26279
      
              Test: editing/inserting/font-size-clears-from-typing-style.html
      
              * css/CSSComputedStyleDeclaration.cpp:
              (WebCore::CSSComputedStyleDeclaration::cssPropertyMatches):
              * css/CSSComputedStyleDeclaration.h:
              * css/CSSStyleDeclaration.cpp:
              (WebCore::CSSStyleDeclaration::cssPropertyMatches):
              (WebCore::CSSStyleDeclaration::diff):
              * css/CSSStyleDeclaration.h:
      
      LayoutTests:
      
      2009-06-23  Ojan Vafai  <ojan@chromium.org>
      
              Reviewed by Dan Bernstein.
      
              This test hits an edge case where typingStyle would never get cleared.
              In addition to making every text insertion go into its own text node,
              this caused large performance problems.
      
              https://bugs.webkit.org/show_bug.cgi?id=26279
      
              * editing/execCommand/5770834-1-expected.txt:
                  These results match how they were before r43243. It's not clear to me
                  why changes to font-size are affecting text-align styling though.
              * editing/inserting/font-size-clears-from-typing-style-expected.txt: Added.
              * editing/inserting/font-size-clears-from-typing-style.html: Added.
              * editing/inserting/resources/TEMPLATE.html: Copied from LayoutTests/editing/execCommand/resources/TEMPLATE.html.
              * editing/inserting/resources/font-size-clears-from-typing-style.js: Added.
              * platform/mac/editing/execCommand/remove-formatting-2-expected.txt:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@45014 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      7ae729be
    • treat@webkit.org's avatar
      2009-06-23 Joe Mason <joe.mason@torchmobile.com> · caf9053c
      treat@webkit.org authored
              Reviewed by Adam Treat.
      
              https://bugs.webkit.org/show_bug.cgi?id=26664
              * Scripts/prepare-ChangeLog: Added --git-index mode to list only the
              changes which are already staged in the index.  Useful to create an
              entry for what you're about to commit while ignoring unstaged changes.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@45012 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      caf9053c
    • treat@webkit.org's avatar
      2009-06-23 Yong Li <yong.li@torchmobile.com> · 401f9b79
      treat@webkit.org authored
              Reviewed by George Staikos.
      
              https://bugs.webkit.org/show_bug.cgi?id=26654
              Add the proper export define for the JavaScriptCore API when building for WINCE.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@45011 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      401f9b79
    • andersca@apple.com's avatar
      2009-06-23 Anders Carlsson <andersca@apple.com> · 04d75d57
      andersca@apple.com authored
              Reviewed by Darin Adler.
      
              - Fix <rdar://problem/6965672>
              
              Defer calls to WKPCInvalidateRect, so we don't try to invalidate while waiting for a reply, since
              that is too early.
              
              * Plugins/Hosted/NetscapePluginHostProxy.h:
              (WebKit::NetscapePluginHostProxy::isProcessingRequests):
              * Plugins/Hosted/NetscapePluginHostProxy.mm:
              (WebKit::NetscapePluginHostProxy::NetscapePluginHostProxy):
              (WebKit::NetscapePluginHostProxy::processRequests):
              (WKPCInvalidateRect):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@45010 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      04d75d57
    • kmccullough@apple.com's avatar
      WebCore: · f53c7458
      kmccullough@apple.com authored
      2009-06-23  Kevin McCullough  <kmccullough@apple.com>
      
              Reviewed by Darin Adler.
      
              <rdar://problem/6994790> CrashTracer: [USER] 8 crashes in Mail trying to
              add a blank line to pasted Facebook content (under
              CompositeEditCommand::positionAvoidingSpecialElementBoundary)
      
              - Just added null checks and I will create a new bug to prevent the
              bad behavior.
      
              * editing/CompositeEditCommand.cpp:
              (WebCore::CompositeEditCommand::positionAvoidingSpecialElementBoundary):
      
      LayoutTests:
      
      2009-06-23  Kevin McCullough  <kmccullough@apple.com>
      
              Reviewed by Darin Adler.
      
              <rdar://problem/6994790> CrashTracer: [USER] 8 crashes in Mail trying to
              add a blank line to pasted Facebook content (under
              CompositeEditCommand::positionAvoidingSpecialElementBoundary)
      
              * editing/inserting/return-with-object-element-expected.txt: Added.
              * editing/inserting/return-with-object-element.html: Added.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@45009 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      f53c7458
    • simon.fraser@apple.com's avatar
      2009-06-23 Simon Fraser <simon.fraser@apple.com> · 3702c3e9
      simon.fraser@apple.com authored
              Build fix.
      
              Wrap shouldDoSoftwarePaint() in #if USE(ACCELERATED_COMPOSITING) to avoid warning when
              ACCELERATED_COMPOSITING is not defined.
      
              * rendering/RenderLayer.cpp:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@45007 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      3702c3e9
    • simon.fraser@apple.com's avatar
      2009-06-23 Simon Fraser <simon.fraser@apple.com> · ef9dafe5
      simon.fraser@apple.com authored
              Reviewed by Dave Hyatt.
      
              https://bugs.webkit.org/show_bug.cgi?id=24863
      
              Fix reflection painting on elements with compositing layers.
      
              Test: compositing/reflections/reflection-on-composited.html
      
              * rendering/RenderLayer.h:
              Add a new PaintLayerPaintingReflection flag which is set while painting inside
              reflections.
              (WebCore::RenderLayer::setPaintingInsideReflection):
              Add a setter so that RenderLayerBacking can call it.
      
              * rendering/RenderLayer.cpp:
              (WebCore::shouldDoSoftwarePaint):
              Utility to clarify the logic of when a composited layer should do a software paint.
      
              (WebCore::RenderLayer::paintLayer):
              Use shouldDoSoftwarePaint() to determine when to software-paint a reflected layer.
              Remove transform-related tests from the reflection-painting if test because they appear
              to be unnecessary.
      
              * rendering/RenderLayerBacking.cpp:
              (WebCore::RenderLayerBacking::paintIntoLayer):
              Add the code to paint reflections to the composited layer painting method.
      
              * rendering/RenderReplica.cpp:
              (WebCore::RenderReplica::paint):
              Set the PaintLayerPaintingReflection flag.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@45005 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      ef9dafe5
    • antti@apple.com's avatar
      WebCore: · 218b0a13
      antti@apple.com authored
      2009-06-23  Antti Koivisto  <antti@apple.com>
      
              Reviewed by Darin Adler.
              
              https://bugs.webkit.org/show_bug.cgi?id=26643
              Memory cache should respect Cache-Control: no-store
              
              Make resources with Cache-Control: no-store uncacheable in the memory cache.
              They get evicted immediately when all clients are gone and are always
              reloaded from the server.
      
              Conforms to RFC2616 14.9.2 and seems also match Firefox behavior.
      
              * loader/CachedResource.cpp:
              (WebCore::CachedResource::removeClient):
              (WebCore::CachedResource::canUseCacheValidator):
              (WebCore::CachedResource::mustRevalidate):
              * platform/network/ResourceResponseBase.cpp:
              (WebCore::ResourceResponseBase::ResourceResponseBase):
              (WebCore::ResourceResponseBase::parseCacheControlDirectives):
              (WebCore::ResourceResponseBase::cacheControlContainsNoStore):
              * platform/network/ResourceResponseBase.h:
      
      LayoutTests:
      
      2009-06-23  Antti Koivisto  <antti@apple.com>
      
              Reviewed by Darin Adler.
              
              https://bugs.webkit.org/show_bug.cgi?id=26643
              Memory cache should respect Cache-Control: no-store
              
              Update the test to cover no-store.
      
              * http/tests/cache/subresource-expiration-expected.txt:
              * http/tests/cache/subresource-expiration.html:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@45003 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      218b0a13
    • beidson@apple.com's avatar
      Windows build fix · bfc5d3f3
      beidson@apple.com authored
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@45002 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      bfc5d3f3
    • simon.fraser@apple.com's avatar
      2009-06-23 Simon Fraser <simon.fraser@apple.com> · 1efc448e
      simon.fraser@apple.com authored
              Reviewed by Dave Hyatt
      
              First part of https://bugs.webkit.org/show_bug.cgi?id=26652
      
              * rendering/RenderLayer.cpp:
              (WebCore::RenderLayer::paint):
              (WebCore::RenderLayer::paintLayer):
              * rendering/RenderLayer.h:
              (WebCore::RenderLayer::):
              * rendering/RenderReplica.cpp:
              (WebCore::RenderReplica::paint):
              Replace the 3 boolean params to RenderLayer::paintLayer() with a bit mask for readability.
      
              * rendering/RenderLayerBacking.cpp:
              (WebCore::RenderLayerBacking::paintIntoLayer):
              (WebCore::RenderLayerBacking::paintContents):
              * rendering/RenderLayerBacking.h:
              Remove the unused 'haveTransparency' param to paintIntoLayer().
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@45001 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      1efc448e
    • kmccullough@apple.com's avatar
      WebCore: · c326351a
      kmccullough@apple.com authored
      2009-06-23  Kevin McCullough  <kmccullough@apple.com>
      
              Reviewed by Adele Peterson.
      
              <rdar://problem/6902203> REGRESSION: 'Return' insertion point incorrect
              after manually quoting blank line then hitting return
      
              If the insertion point is both the begining and ending visible position
              then we need to insert at the end instead of the begining, which is what
              would normally happen if the insertion point was as the begining.
      
              * editing/BreakBlockquoteCommand.cpp:
              (WebCore::BreakBlockquoteCommand::doApply):
      
      LayoutTests:
      
      2009-06-23  Kevin McCullough  <kmccullough@apple.com>
      
              Reviewed by Adele Peterson.
      
              <rdar://problem/6902203> REGRESSION: 'Return' insertion point incorrect
              after manually quoting blank line then hitting return
      
              * editing/inserting/insert-br-quoted-007-expected.txt: Added.
              * editing/inserting/insert-br-quoted-007.html: Added.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@45000 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      c326351a
    • beidson@apple.com's avatar
      2009-06-23 Brady Eidson <beidson@apple.com> · d9bfdc8c
      beidson@apple.com authored
              Reviewed by Sam Weinig, and looked over by Eric Carlson.
      
              <rdar://problem/6980466> Media elements should provide option for changing pitch correction
      
              Introduce a new boolean property to HTMLMediaElement called webkitPreservesPitch for script to control this.
      
              * html/HTMLMediaElement.cpp:
              (WebCore::HTMLMediaElement::HTMLMediaElement): Currently the platforms that have a flexible pitch preservation 
                property (Quicktime on Mac and Win) have had it on by default, so continue that default for now.
              (WebCore::HTMLMediaElement::loadResource):
              (WebCore::HTMLMediaElement::webkitPreservesPitch):
              (WebCore::HTMLMediaElement::setWebkitPreservesPitch):
              * html/HTMLMediaElement.h:
              * html/HTMLMediaElement.idl:
      
              * platform/graphics/MediaPlayer.cpp:
              (WebCore::NullMediaPlayerPrivate::setPreservesPitch):
              (WebCore::MediaPlayer::MediaPlayer):
              (WebCore::MediaPlayer::preservesPitch):
              (WebCore::MediaPlayer::setPreservesPitch):
              * platform/graphics/MediaPlayer.h:
              * platform/graphics/MediaPlayerPrivate.h:
              (WebCore::MediaPlayerPrivateInterface::setPreservesPitch):
      
              * platform/graphics/mac/MediaPlayerPrivateQTKit.h:
              * platform/graphics/mac/MediaPlayerPrivateQTKit.mm:
              (WebCore::MediaPlayerPrivate::MediaPlayerPrivate):
              (WebCore::MediaPlayerPrivate::createQTMovie): Rework to allow recreation of the movie with almost the
                exact same attributes as before, with pitch preservation being the difference.
              (WebCore::MediaPlayerPrivate::setPreservesPitch): Recreate the QTMovie if the flag actually changes.
              (WebCore::MediaPlayerPrivate::updateStates): Restore current time and rate if this is a recreated movie.
              (WebCore::MediaPlayerPrivate::timeChanged): Clear the time-to-be-restored, as this callback means it
                has been effectively overwritten.
      
              * platform/graphics/win/MediaPlayerPrivateQuickTimeWin.cpp:
              (WebCore::MediaPlayerPrivate::load):
              (WebCore::MediaPlayerPrivate::setPreservesPitch):
              * platform/graphics/win/MediaPlayerPrivateQuickTimeWin.h:
              * platform/graphics/win/QTMovieWin.cpp:
              (QTMovieWinPrivate::QTMovieWinPrivate):
              (QTMovieWinPrivate::~QTMovieWinPrivate):
              (QTMovieWinPrivate::task): Restore current time and rate if this is a re-created movie.
              (QTMovieWin::play): Clear the time-to-be-restored, as this effectively overwrites it.
              (QTMovieWin::pause): Ditto.
              (QTMovieWin::setRate): Ditto.
              (QTMovieWin::setCurrentTime): Ditto.
              (QTMovieWin::setPreservesPitch): Recreate the Movie if the flag actually changes.
              (QTMovieWin::load): Rework to allow recreation of the Movie with similar state as the movie before it, 
                but changing the pitch preservation flag.
              * platform/graphics/win/QTMovieWin.h:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@44999 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      d9bfdc8c
    • eric.carlson@apple.com's avatar
      2009-06-23 Eric Carlson <eric.carlson@apple.com> · e2bcabad
      eric.carlson@apple.com authored
              Reviewed by Simon Fraser.
      
              <rdar://problem/6998286> Crash after leaving page with <video>
              
              Don't try to post events after going into the page cache.
      
              * html/HTMLMediaElement.cpp:
              (WebCore::HTMLMediaElement::documentWillBecomeInactive): Cancel pending events and stop
              event timers so we won't try to post events after going into the cache.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@44998 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      e2bcabad
    • darin@chromium.org's avatar
      2009-06-23 Jeremy Orlow <jorlow@chromium.org> · 399aeaee
      darin@chromium.org authored
              Reviewed by Brady Eidson.
      
              Simplify the interaction between LocalStorageArea/SessionStorageArea
              and StorageArea by creating a "blockUntilImportComplete()" function
              rather than bouncing back and forth between the child and parent
              classes in a somewhat unintuitive manner.
      
              This patch also paves the way for LocalStorageArea and
              SessionStorageArea being merged into one.  It's part of several in a
              set which are separating syncing (to disk) code from the rest of the
              implementation so that local storage and session storage's code can be
              unified.
      
              https://bugs.webkit.org/show_bug.cgi?id=25376
      
              * storage/LocalStorageArea.cpp:
              (WebCore::LocalStorageArea::blockUntilImportComplete):
              * storage/LocalStorageArea.h:
              * storage/StorageArea.cpp:
              (WebCore::StorageArea::length):
              (WebCore::StorageArea::key):
              (WebCore::StorageArea::getItem):
              (WebCore::StorageArea::setItem):
              (WebCore::StorageArea::removeItem):
              (WebCore::StorageArea::clear):
              (WebCore::StorageArea::contains):
              * storage/StorageArea.h:
              (WebCore::StorageArea::blockUntilImportComplete):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@44997 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      399aeaee
    • simon.fraser@apple.com's avatar
      2009-06-23 Simon Fraser <simon.fraser@apple.com> · 83c3627e
      simon.fraser@apple.com authored
              Reviewed by Darin Adler.
      
              <rdar://problem/6997929> Assertion at WebCore::RenderLayer::updateClipRects with hardware acceleration
      
              The updatingControlTints() painting pass goes through compositing layer boundaries,
              so we need to ensure we don't cache clip rects computed with the wrong root by
              setting temporaryClipRects to true.
      
              * rendering/RenderLayer.cpp:
              (WebCore::RenderLayer::paintLayer):
      
              * rendering/RenderLayerBacking.cpp:
              (WebCore::RenderLayerBacking::contentOffsetInCompostingLayer):
              Remove a printf that I left in by mistake.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@44996 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      83c3627e
    • andersca@apple.com's avatar
      WebCore: · 45eefea1
      andersca@apple.com authored
      2009-06-23  Anders Carlsson  <andersca@apple.com>
      
              Reviewed by Darin Adler.
      
              WebCore side of <rdar://problem/6946094>.
              
              * platform/win/ClipboardWin.cpp:
              (WebCore::ClipboardWin::setExternalDataObject):
              * platform/win/ClipboardWin.h:
      
      WebKit/win:
      
      2009-06-23  Anders Carlsson  <andersca@apple.com>
      
              Reviewed by Darin Adler.
      
              WebKit side of <rdar://problem/6946094>.
      
              * Interfaces/IWebUIDelegate.idl:
              Add a newPasteboard out parameter to willPerformDragSourceAction.
              
              * WebCoreSupport/WebDragClient.cpp:
              (WebDragClient::willPerformDragSourceAction):
              Implement this. If the client returns a new pasteboard, use it for the drag.
              
              * WebCoreSupport/WebInspectorDelegate.h:
              (WebInspectorDelegate::willPerformDragSourceAction):
              Add the new parameter.
      
      WebKitTools:
      
      2009-06-23  Anders Carlsson  <andersca@apple.com>
      
              Reviewed by Darin Adler.
              
              Update for WebKit changes.
              
              * DumpRenderTree/win/UIDelegate.h:
              (UIDelegate::willPerformDragSourceAction):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@44995 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      45eefea1
    • darin@chromium.org's avatar
      2009-06-23 Darin Fisher <darin@chromium.org> · 099083ef
      darin@chromium.org authored
              Reviewed by Darin Adler.
      
              https://bugs.webkit.org/show_bug.cgi?id=26650
      
              Add setFormContentType and setFormData since it is awkward for Chromium
              to use setFormInfoFromRequest to set the underlying members.  Also, add
              a clearChildren method that Chromium needs.  These methods are used as
              part of the Chromium code that serializes a HistoryItem for storing in
              the browser's session history.
      
              * history/HistoryItem.cpp:
              * history/HistoryItem.h:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@44994 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      099083ef
    • treat@webkit.org's avatar
      2009-06-23 Joe Mason <joe.mason@torchmobile.com> · bac633d9
      treat@webkit.org authored
              Reviewed by Adam Treat.
      
              Authors: Yong Li <yong.li@torchmobile.com>, Joe Mason <joe.mason@torchmobile.com>
      
              https://bugs.webkit.org/show_bug.cgi?id=26611
              Implement currentThreadStackBase on WINCE by adding a global,
              g_stackBase, which must be set to the address of a local variable
              by the caller before calling any WebKit function that invokes JSC.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@44993 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      bac633d9
    • eric.carlson@apple.com's avatar
      2009-06-23 Eric Carlson <eric.carlson@apple.com> · 4b7bc1ce
      eric.carlson@apple.com authored
              Reviewed by NOBODY, layout tests fix.
              
              'timeupdate' events are, by definition, timing dependent so it isn't
              a good idea to log them in layout test results.
      
              * media/event-attributes-expected.txt:
              * media/event-attributes.html:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@44992 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      4b7bc1ce
    • eric.carlson@apple.com's avatar
      2009-06-23 Eric Carlson <eric.carlson@apple.com> · db9b17f2
      eric.carlson@apple.com authored
              Reviewed by Darin Adler.
      
              <rdar://problem/6978938> Need HTML 5 event attributes for media elements
      
              Test: media/event-attributes.html
      
              * html/HTMLAttributeNames.in: Add media event attribute names.
              * html/HTMLMediaElement.cpp:
              (WebCore::HTMLMediaElement::parseMappedAttribute): Handle media event attributes.
      
      2009-06-23  Eric Carlson  <eric.carlson@apple.com>
      
              Reviewed by Darin Adler.
              
              <rdar://problem/6978938> Need HTML 5 event attributes for media elements
      
              * media/event-attributes-expected.txt: Added.
              * media/event-attributes.html: Added.
              * media/progress-event-total.html: Cleanup, use event handler attributes.
              * media/progress-event.html: Ditto.
      
              * media/video-size-intrinsic-scale.html: Remove duplicate 'waitForEvent("ratechange")'
              * media/video-source-add-src.html: Ditto.
              * media/video-source-error.html: Ditto.
              * media/video-timeupdate-during-playback.html: Ditto.
      
              * platform/gtk/Skipped: Skip new test.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@44991 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      db9b17f2
    • hausmann@webkit.org's avatar
      2009-06-23 Thiago Macieira <thiago.macieira@nokia.com> · 71af5fe2
      hausmann@webkit.org authored
              Reviewed by Simon Hausmann.
      
              Fix Qt build with Phonon.
      
              The #include <phonon> header no longer exists. And the <Phonon> or
              <Phonon/Phonon> headers have never existed (neither for us nor for the
              Phonon sources). You have to select each and every header that you do
              want now.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@44990 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      71af5fe2
    • vestbo@webkit.org's avatar
      2009-06-23 Tor Arne Vestbø <tor.arne.vestbo@nokia.com> · c966e0bb
      vestbo@webkit.org authored
              Reviewed by Simon Hausmann.
      
              Remove duplicated code in Qt & GTK logging initialization
      
              We now share the getChannelFromName() function in Logging.cpp
      
              * platform/gtk/LoggingGtk.cpp:
              * platform/qt/LoggingQt.cpp:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@44989 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      c966e0bb
    • vestbo@webkit.org's avatar
      2009-06-23 Tor Arne Vestbø <tor.arne.vestbo@nokia.com> · 8d3a6461
      vestbo@webkit.org authored
              Reviewed by Simon Hausmann.
      
              Rename the plugin logging channel to plural form 'Plugins'
      
              This matches both the other logging channel names, as well as the
              WebKit logging channel used by Safari/Mac for plugins.
      
              * platform/Logging.cpp:
              * platform/Logging.h:
              * platform/gtk/LoggingGtk.cpp:
              * platform/mac/LoggingMac.mm:
              * platform/qt/LoggingQt.cpp:
              * platform/win/LoggingWin.cpp:
              * plugins/PluginDebug.h:
              * plugins/gtk/PluginPackageGtk.cpp:
              * plugins/mac/PluginPackageMac.cpp:
              * plugins/mac/PluginViewMac.cpp:
              * plugins/qt/PluginPackageQt.cpp:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@44988 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      8d3a6461
    • vestbo@webkit.org's avatar
      2009-06-23 Tor Arne Vestbø <tor.arne.vestbo@nokia.com> · c0b3f83a
      vestbo@webkit.org authored
              Reviewed by Simon Hausmann.
      
              Fix NPAPI mouse translation issues on Mac
      
              The WindowRef we pass to the plugin refers to the the top level window,
              so the x and y positions have to be relative to this position, but we
              have to manually compensate for title bar decorations and other parents
              of the QWebView since contentsToWindow() only traverses to the QWebView.
      
              Previously we did this compensation when passing on mouse coordinates to
              the plugin, which caused various issues with translations such as not
              being able to close the Flash settings dialog, or the hand cursor not
              appearing over links.
      
              We now do the compensation as part of the call to NPP_SetWindow, and
              then pass mouse coordinates in global context without any compensation,
              similar to how both Safari and Mozilla does it.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@44987 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      c0b3f83a
    • vestbo@webkit.org's avatar
      2009-06-23 Tor Arne Vestbø <tor.arne.vestbo@nokia.com> · 96080150
      vestbo@webkit.org authored
              Rubber-stamped by Simon Hausmann.
      
              [Qt] Resolve absolute path to library install_name manually
      
              Since our target.path is set to the Qt directory (to be able
              to do 'make install') the 'absolute_library_soname' option
              to QMake did not do the right thing.
      
              We now compute the absolute path manually using DESTDIR.
      
              * WebCore.pro:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@44986 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      96080150