1. 17 Feb, 2006 13 commits
    • justing's avatar
      Reviewed by eric · 3c35fbb7
      justing authored
              
              This test appears to be occasionally hanging.  Disabling it while
              I figure out why.
      
              * editing/selection/drag-to-contenteditable-iframe.html: Removed.
              * editing/selection/drag-to-contenteditable-iframe.html-disabled: Added.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@12879 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      3c35fbb7
    • eseidel's avatar
      2006-02-17 Eric Seidel <eseidel@apple.com> · a8395b0b
      eseidel authored
              Reviewed by Beth.
      
              * Scripts/build-webkit: make win32 actually report errors
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@12878 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      a8395b0b
    • eseidel's avatar
      2006-02-17 Eric Seidel <eseidel@apple.com> · c9eabaae
      eseidel authored
              Reviewed by adele.
      
              * Scripts/run-webkit-tests: Ignore quicktime plugin leaks
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@12877 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      c9eabaae
    • eseidel's avatar
      2006-02-17 Eric Seidel <eseidel@apple.com> · 33c7fdfb
      eseidel authored
              Reviewed by adele.
      
              * Scripts/run-webkit-tests: Ignore flash leaks
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@12876 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      33c7fdfb
    • thatcher's avatar
      Reviewed by Tim H. · 7eae4945
      thatcher authored
              Added left position and margin-bottom to blog footer.
      
              * css/main.css:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@12875 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      7eae4945
    • adele's avatar
      Reviewed by Beth. · 96b71de3
      adele authored
              Adding isEdited/setEdited hooks so onChange will fire for the new text fields.
      
              * rendering/RenderTextField.cpp:
              (WebCore::m_dirty):
              (WebCore::RenderTextField::updateFromElement): setEdited to false when value attribute has changed.
              (WebCore::RenderTextField::subtreeHasChanged): setEdited to true when anonymous editable div has changed.
              * rendering/RenderTextField.h:
              (WebCore::RenderTextField::isEdited):
              (WebCore::RenderTextField::setEdited):
              (WebCore::RenderTextField::isTextField):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@12874 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      96b71de3
    • ggaren's avatar
      Reviewed by John. · efee5676
      ggaren authored
              - Fixed <rdar://problem/4448534> TOT REGRESSION: crash in KJS::
              Bindings::Instance::deref when leaving page @ gigaom.com
      
              * bindings/c/c_instance.cpp:
              (KJS::Bindings::CInstance::~CInstance): Since we cache the class object
              globally, we shouldn't delete it, so don't.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@12873 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      efee5676
    • vicki's avatar
      Reviewed by Justin. · bd08086c
      vicki authored
       
              Get rid of handleFocusOut on text fields and textareas - move this functionality to the place
              where we resign focus on the previous node in setFocusNode.  Add isTextField on RenderObject
              as one way to distinguish from contenteditable elements - Win IE does not fire onChange for 
              contenteditable elements, so we won't either. Also, expose the dirty bit variables previously 
              checked in handleFocusOut methods in isEdited() and setEdited().
      
              Fixes the following bugs:
              <rdar://problem/4315673> REGRESSION (1.2.2 - 1.3): onChange and onFocus events firing order differs for mouse click and tab (7227)
              <rdar://problem/4447009> for text fields, onChange should fire before onBlur to match Win IE
      
              Test case is on the way.
      
              * dom/DocumentImpl.cpp:
              (WebCore::DocumentImpl::setFocusNode): For textareas and text fields, fire a change event
              on the node that is resigning focus.  Make sure the blur event fires after the change event - 4447009.
              * rendering/render_form.cpp:
              (WebCore::RenderLineEdit::slotReturnPressed): Replace call to handleFocusOut with equivalent code.
              (WebCore::RenderLineEdit::isEdited): Added.
              (WebCore::RenderLineEdit::setEdited): Added.
              (WebCore::RenderTextArea::setEdited): Added.
              * rendering/render_form.h:
              (WebCore::RenderLineEdit::isTextField): Added.
              (WebCore::RenderTextArea::isTextArea): Make this non-virtual.
              (WebCore::RenderTextArea::isEdited): Added.
              * rendering/render_object.h:
              (WebCore::RenderObject::isEdited): Added.
              (WebCore::RenderObject::setEdited): Added.
              (WebCore::RenderObject::isTextField): Added.
              * rendering/render_replaced.h: Remove handleFocusOut().
              * rendering/render_replaced.cpp: Ditto.
              (WebCore::RenderWidget::eventFilter): Remove call to handleFocusOut().  Safe to do here,
              since we call setFocusNode immediately beforehand.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@12872 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      bd08086c
    • adele's avatar
      LayoutTests: · 1c9ddded
      adele authored
              Reviewed by Anders Carlsson.
      
              - test for http://bugzilla.opendarwin.org/show_bug.cgi?id=7265
                REGRESSION: noscript, noframes, nolayer, noembed tags insert break inside paragraph tag
      
              * fast/parser/nofoo-tags-inside-paragraph-expected.checksum: Added.
              * fast/parser/nofoo-tags-inside-paragraph-expected.png: Added.
              * fast/parser/nofoo-tags-inside-paragraph-expected.txt: Added.
              * fast/parser/nofoo-tags-inside-paragraph.html: Added.
      
      WebCore:
      
              Test: fast/parser/nofoo-tags-inside-paragraph.html
      
              Reviewed by Anders Carlsson.
      
              - fix http://bugzilla.opendarwin.org/show_bug.cgi?id=7265
                REGRESSION: noscript, noframes, nolayer, noembed tags insert break inside paragraph tag
      
              * khtml/html/htmlparser.cpp:
              (HTMLParser::isInline): Treat noframes, nolayer, noembed and skipped noscript
              as inline elements.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@12871 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      1c9ddded
    • adele's avatar
      Reviewed by Hyatt. · b458599d
      adele authored
              - fix http://bugzilla.opendarwin.org/show_bug.cgi?id=7235
                Pure CSS Tooltips method renders wrong and creates artifacts
      
              * manual-tests/bugzilla-7235.html: Added.
              * rendering/render_box.cpp:
              (WebCore::RenderBox::absolutePosition): Copied in here the logic for positioning
              relative to a relpositioned inline from RenderLayer::updateLayerPosition.
              (WebCore::RenderBox::computeAbsoluteRepaintRect): Ditto.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@12870 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      b458599d
    • adele's avatar
      LayoutTests: · 6658b94d
      adele authored
              Reviewed by Maciej.
      
              - test for http://bugzilla.opendarwin.org/show_bug.cgi?id=7218
                Text underlined on mouse over
      
              * fast/css/universal-hover-quirk-expected.checksum: Added.
              * fast/css/universal-hover-quirk-expected.png: Added.
              * fast/css/universal-hover-quirk-expected.txt: Added.
              * fast/css/universal-hover-quirk.html: Added.
      
      WebCore:
      
              Test: fast/css/universal-hover-quirk.html
      
              Reviewed by Maciej.
      
              - fix http://bugzilla.opendarwin.org/show_bug.cgi?id=7218
                Text underlined on mouse over
      
              * css/cssstyleselector.cpp:
              (WebCore::CSSStyleSelector::checkOneSelector): Prevent *:hover and *:active
              from matching anything in quirks mode.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@12869 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      6658b94d
    • adele's avatar
      LayoutTests: · 7fc3e830
      adele authored
              Reviewed by Dave Hyatt.
      
              - test for http://bugzilla.opendarwin.org/show_bug.cgi?id=7216
                white-space: pre-wrap collapses leading whitespace following a newline
      
              * fast/text/whitespace/pre-wrap-spaces-after-newline-expected.checksum: Added.
              * fast/text/whitespace/pre-wrap-spaces-after-newline-expected.png: Added.
              * fast/text/whitespace/pre-wrap-spaces-after-newline-expected.txt: Added.
              * fast/text/whitespace/pre-wrap-spaces-after-newline.html: Added.
      
      WebCore:
      
              Test: fast/text/whitespace/pre-wrap-spaces-after-newline.html
      
              Reviewed by Dave Hyatt.
      
              - fix http://bugzilla.opendarwin.org/show_bug.cgi?id=7216
                white-space: pre-wrap collapses leading whitespace following a newline
      
              * rendering/bidi.cpp:
              (khtml::RenderBlock::bidiReorderLine): Use previousLineBrokeCleanly instead of
              resetBidiAtEnd now that the former is always correct.
              (khtml::RenderBlock::layoutInlineChildren): Use new skipTrailingNewline flag.
              (khtml::RenderBlock::findNextLineBreak): Set previousLineBrokeCleanly for line breaks
              caused by newlines as well. Added skipTrailingNewline flag.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@12868 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      7fc3e830
    • tomernic's avatar
      Reviewed by Adele. · 7a565845
      tomernic authored
              <rdar://problem/4193286> enabledPlugin returns a non-NULL object even when plugins are
              disabled (4140)
      
              * khtml/ecma/kjs_navigator.cpp:
              (KJS::MimeType::getValueProperty):
              Only return a Plugin object for the "enabledPlugin" property if plugins are enabled.  This
              matches what other browsers do.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@12867 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      7a565845
  2. 16 Feb, 2006 23 commits
    • thatcher's avatar
      Reviewed by Maciej. · 441338e3
      thatcher authored
              
              Fixes PNGs with 8bit alpha on IE.
      
              * css/ie.css: attach the pngbehavior.htc to img tags
              * images/blank.png: Added.
              * index.html: add the width and height to the download img
              * pngbehavior.htc: Added.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@12866 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      441338e3
    • darin's avatar
      Reviewed by Eric and Justin. · 85c3a50e
      darin authored
              - fix http://bugzilla.opendarwin.org/show_bug.cgi?id=7310
                fix leaks by using RefPtr more
      
              * bindings/objc/DOM.mm:
              (-[DOMDocument adoptNode:]):
              (-[DOMDocument createElement:]):
              (-[DOMDocument createDocumentFragment]):
              (-[DOMDocument createTextNode:]):
              (-[DOMDocument createComment:]):
              (-[DOMDocument createCDATASection:]):
              (-[DOMDocument createProcessingInstruction::]):
              (-[DOMDocument createEntityReference:]):
              (-[DOMDocument importNode::]):
              (-[DOMDocument createElementNS::]):
              (-[DOMDocument createRange]):
              (-[DOMDocument createCSSStyleDeclaration]):
              (-[DOMDocument createNodeIterator::::]):
              (-[DOMDocument createTreeWalker::::]):
              * bindings/objc/DOMCSS.mm:
              (-[DOMCSSStyleDeclaration getPropertyCSSValue:]):
              * bindings/objc/DOMEvents.mm:
              (-[DOMDocument createEvent:]):
              * bridge/mac/MacFrame.h:
              * bridge/mac/MacFrame.mm:
              (WebCore::MacFrame::MacFrame):
              (WebCore::MacFrame::freeClipboard):
              (WebCore::MacFrame::setView):
              (WebCore::MacFrame::wheelEvent):
              (WebCore::MacFrame::openURLFromPageCache):
              (WebCore::MacFrame::mouseDownViewIfStillGood):
              (WebCore::MacFrame::khtmlMouseMoveEvent):
              (WebCore::MacFrame::dispatchCPPEvent):
              (WebCore::MacFrame::mouseDown):
              (WebCore::MacFrame::mouseDragged):
              (WebCore::MacFrame::mouseUp):
              (WebCore::MacFrame::mouseMoved):
              (WebCore::MacFrame::sendContextMenuEvent):
              (WebCore::MacFrame::dispatchDragSrcEvent):
              * bridge/mac/WebCoreFrameBridge.mm:
              (-[WebCoreFrameBridge convertToDOMRange:]):
              (-[WebCoreFrameBridge convertNSRangeToDOMRange:]):
              (-[WebCoreFrameBridge selectNSRange:]):
              (-[WebCoreFrameBridge smartDeleteRangeForProposedRange:]):
              (-[WebCoreFrameBridge typingStyle]):
              (-[WebCoreFrameBridge dragOperationForDraggingInfo:]):
              (-[WebCoreFrameBridge dragExitedWithDraggingInfo:]):
              (-[WebCoreFrameBridge concludeDragForDraggingInfo:]):
              * css/css_computedstyle.cpp:
              (WebCore::CSSComputedStyleDeclarationImpl::CSSComputedStyleDeclarationImpl):
              (WebCore::CSSComputedStyleDeclarationImpl::cssText):
              (WebCore::CSSComputedStyleDeclarationImpl::setCssText):
              (WebCore::CSSComputedStyleDeclarationImpl::getPropertyCSSValue):
              (WebCore::CSSComputedStyleDeclarationImpl::getPropertyValue):
              (WebCore::CSSComputedStyleDeclarationImpl::removeProperty):
              (WebCore::CSSComputedStyleDeclarationImpl::setProperty):
              (WebCore::CSSComputedStyleDeclarationImpl::item):
              (WebCore::CSSComputedStyleDeclarationImpl::copyInheritableProperties):
              (WebCore::CSSComputedStyleDeclarationImpl::copy):
              (WebCore::CSSComputedStyleDeclarationImpl::makeMutable):
              * css/css_computedstyle.h:
              * css/css_grammar.y:
              * css/css_ruleimpl.cpp:
              (WebCore::CSSStyleRuleImpl::~CSSStyleRuleImpl):
              (WebCore::CSSStyleRuleImpl::setDeclaration):
              * css/css_ruleimpl.h:
              (DOM::CSSStyleRuleImpl::style):
              (DOM::CSSStyleRuleImpl::declaration):
              * css/css_valueimpl.cpp:
              (WebCore::propertyID):
              (WebCore::quoteStringIfNeeded):
              (WebCore::CSSStyleDeclarationImpl::getPropertyCSSValue):
              (WebCore::CSSStyleDeclarationImpl::getPropertyValue):
              (WebCore::CSSStyleDeclarationImpl::getPropertyPriority):
              (WebCore::CSSStyleDeclarationImpl::getPropertyShorthand):
              (WebCore::CSSStyleDeclarationImpl::isPropertyImplicit):
              (WebCore::CSSStyleDeclarationImpl::setProperty):
              (WebCore::CSSStyleDeclarationImpl::removeProperty):
              (WebCore::CSSStyleDeclarationImpl::isPropertyName):
              (WebCore::CSSMutableStyleDeclarationImpl::getPropertyValue):
              (WebCore::CSSMutableStyleDeclarationImpl::get4Values):
              (WebCore::CSSMutableStyleDeclarationImpl::getShortHandValue):
              (WebCore::CSSMutableStyleDeclarationImpl::getPropertyCSSValue):
              (WebCore::CSSMutableStyleDeclarationImpl::removeProperty):
              (WebCore::CSSMutableStyleDeclarationImpl::setProperty):
              (WebCore::CSSMutableStyleDeclarationImpl::setStringProperty):
              (WebCore::CSSMutableStyleDeclarationImpl::setImageProperty):
              (WebCore::CSSMutableStyleDeclarationImpl::parseDeclaration):
              (WebCore::CSSMutableStyleDeclarationImpl::setLengthProperty):
              (WebCore::CSSMutableStyleDeclarationImpl::item):
              (WebCore::CSSMutableStyleDeclarationImpl::cssText):
              (WebCore::CSSMutableStyleDeclarationImpl::setCssText):
              (WebCore::CSSMutableStyleDeclarationImpl::copyBlockProperties):
              (WebCore::CSSStyleDeclarationImpl::copyPropertiesInSet):
              (WebCore::CSSMutableStyleDeclarationImpl::removePropertiesInSet):
              (WebCore::CSSMutableStyleDeclarationImpl::makeMutable):
              (WebCore::CSSMutableStyleDeclarationImpl::copy):
              (WebCore::CSSInheritedValueImpl::cssText):
              (WebCore::CSSInitialValueImpl::cssText):
              (WebCore::CSSValueListImpl::append):
              (WebCore::CSSValueListImpl::cssText):
              (WebCore::CSSPrimitiveValueImpl::CSSPrimitiveValueImpl):
              (WebCore::CSSPrimitiveValueImpl::cleanup):
              (WebCore::CSSPrimitiveValueImpl::setStringValue):
              (WebCore::CSSPrimitiveValueImpl::getStringValue):
              (WebCore::CSSPrimitiveValueImpl::parseString):
              (WebCore::CSSPrimitiveValueImpl::cssText):
              (WebCore::CSSImageValueImpl::CSSImageValueImpl):
              (WebCore::CSSBorderImageValueImpl::CSSBorderImageValueImpl):
              (WebCore::CSSBorderImageValueImpl::cssText):
              (WebCore::FontFamilyValueImpl::FontFamilyValueImpl):
              (WebCore::FontFamilyValueImpl::cssText):
              (WebCore::FontValueImpl::cssText):
              (WebCore::ShadowValueImpl::ShadowValueImpl):
              (WebCore::ShadowValueImpl::cssText):
              (WebCore::CSSProperty::cssText):
              * css/css_valueimpl.h:
              (WebCore::CSSValueImpl::setCssText):
              (WebCore::CSSValueListImpl::item):
              (WebCore::CSSPrimitiveValueImpl::getFloatValue):
              (WebCore::CSSPrimitiveValueImpl::getCounterValue):
              (WebCore::CSSPrimitiveValueImpl::getRectValue):
              (WebCore::CSSPrimitiveValueImpl::getRGBColorValue):
              (WebCore::CSSPrimitiveValueImpl::getPairValue):
              (WebCore::CSSPrimitiveValueImpl::getDashboardRegionValue):
              (WebCore::CSSPrimitiveValueImpl::):
              (WebCore::CSSQuirkPrimitiveValueImpl::CSSQuirkPrimitiveValueImpl):
              (WebCore::CounterImpl::identifier):
              (WebCore::CounterImpl::listStyle):
              (WebCore::CounterImpl::separator):
              (WebCore::RectImpl::top):
              (WebCore::RectImpl::right):
              (WebCore::RectImpl::bottom):
              (WebCore::RectImpl::left):
              (WebCore::RectImpl::setTop):
              (WebCore::RectImpl::setRight):
              (WebCore::RectImpl::setBottom):
              (WebCore::RectImpl::setLeft):
              (WebCore::PairImpl::first):
              (WebCore::PairImpl::second):
              (WebCore::PairImpl::setFirst):
              (WebCore::PairImpl::setSecond):
              (WebCore::DashboardRegionImpl::DashboardRegionImpl):
              (WebCore::FontFamilyValueImpl::fontName):
              (WebCore::CSSProperty::CSSProperty):
              (WebCore::CSSProperty::value):
              (WebCore::CSSMutableStyleDeclarationImpl::setNode):
              (WebCore::CSSMutableStyleDeclarationImpl::setProperty):
              (WebCore::CSSMutableStyleDeclarationImpl::removeProperty):
              * css/cssparser.cpp:
              (CSSParser::createStyleDeclaration):
              (CSSParser::parseDashboardRegions):
              * css/cssparser.h:
              (WebCore::Value::):
              (WebCore::qString):
              (WebCore::domString):
              (WebCore::atomicString):
              (WebCore::ValueList::current):
              (WebCore::ValueList::next):
              (WebCore::CSSParser::current):
              * css/cssstyleselector.cpp:
              (WebCore::CSSStyleSelector::applyProperty):
              * dom/DOMImplementationImpl.cpp:
              (DOM::DOMImplementationImpl::createDocument):
              (DOM::DOMImplementationImpl::instance):
              * dom/DOMImplementationImpl.h:
              * dom/DocumentImpl.cpp:
              (WebCore::DocumentImpl::DocumentImpl):
              (WebCore::DocumentImpl::~DocumentImpl):
              (WebCore::DocumentImpl::setDocType):
              (WebCore::DocumentImpl::createElement):
              (WebCore::DocumentImpl::createDocumentFragment):
              (WebCore::DocumentImpl::createTextNode):
              (WebCore::DocumentImpl::createComment):
              (WebCore::DocumentImpl::createCDATASection):
              (WebCore::DocumentImpl::createProcessingInstruction):
              (WebCore::DocumentImpl::createEntityReference):
              (WebCore::DocumentImpl::createEditingTextNode):
              (WebCore::DocumentImpl::createCSSStyleDeclaration):
              (WebCore::DocumentImpl::importNode):
              (WebCore::DocumentImpl::adoptNode):
              (WebCore::DocumentImpl::createElementNS):
              (WebCore::DocumentImpl::setTitle):
              (WebCore::DocumentImpl::createRange):
              (WebCore::DocumentImpl::createNodeIterator):
              (WebCore::DocumentImpl::createTreeWalker):
              (WebCore::DocumentImpl::setStyleSheet):
              (WebCore::DocumentImpl::setHoverNode):
              (WebCore::DocumentImpl::setActiveNode):
              (WebCore::DocumentImpl::setFocusNode):
              (WebCore::DocumentImpl::defaultView):
              (WebCore::DocumentImpl::createEvent):
              (WebCore::DocumentImpl::setHTMLWindowEventListener):
              (WebCore::DocumentImpl::addWindowEventListener):
              (WebCore::DocumentImpl::createHTMLEventListener):
              (WebCore::DocumentImpl::images):
              (WebCore::DocumentImpl::applets):
              (WebCore::DocumentImpl::embeds):
              (WebCore::DocumentImpl::objects):
              (WebCore::DocumentImpl::links):
              (WebCore::DocumentImpl::forms):
              (WebCore::DocumentImpl::anchors):
              (WebCore::DocumentImpl::all):
              (WebCore::DocumentImpl::windowNamedItems):
              (WebCore::DocumentImpl::documentNamedItems):
              (WebCore::DocumentImpl::getElementsByName):
              * dom/DocumentImpl.h:
              (WebCore::DocumentImpl::realDocType):
              (WebCore::DocumentImpl::createAttribute):
              (WebCore::DocumentImpl::title):
              (WebCore::DocumentImpl::styleSelector):
              (WebCore::DocumentImpl::setRestoreState):
              (WebCore::DocumentImpl::restoreState):
              (WebCore::DocumentImpl::view):
              (WebCore::DocumentImpl::docLoader):
              (WebCore::DocumentImpl::tokenizer):
              (WebCore::DocumentImpl::focusNode):
              (WebCore::DocumentImpl::hoverNode):
              (WebCore::DocumentImpl::activeNode):
              (WebCore::DocumentImpl::policyBaseURL):
              (WebCore::DocumentImpl::setPolicyBaseURL):
              (WebCore::DocumentImpl::):
              (WebCore::DocumentImpl::transformSourceDocument):
              (WebCore::DocumentImpl::domTreeVersion):
              (WebCore::DocumentImpl::decoder):
              * dom/NodeListImpl.cpp:
              (DOM::NodeListImpl::NodeListImpl):
              (DOM::NodeListImpl::~NodeListImpl):
              (DOM::NodeListImpl::recursiveLength):
              (DOM::NodeListImpl::recursiveItem):
              (DOM::NodeListImpl::itemById):
              * dom/NodeListImpl.h:
              * dom/dom2_eventsimpl.cpp:
              (WebCore::RegisteredEventListener::RegisteredEventListener):
              * dom/dom2_eventsimpl.h:
              (WebCore::operator!=):
              * dom/dom2_traversalimpl.cpp:
              (DOM::TraversalImpl::TraversalImpl):
              (DOM::NodeIteratorImpl::NodeIteratorImpl):
              (DOM::TreeWalkerImpl::TreeWalkerImpl):
              * dom/dom2_traversalimpl.h:
              (WebCore::TraversalImpl::root):
              (WebCore::TraversalImpl::filter):
              (WebCore::NodeIteratorImpl::referenceNode):
              (WebCore::NodeIteratorImpl::setPointerBeforeReferenceNode):
              (WebCore::NodeIteratorImpl::setDetached):
              (WebCore::NodeIteratorImpl::document):
              (WebCore::TreeWalkerImpl::currentNode):
              * dom/dom_position.cpp:
              (WebCore::Position::computedStyle):
              * dom/dom_position.h:
              * dom/xml_tokenizer.cpp:
              (WebCore::XMLTokenizer::insertErrorMessageBlock):
              * editing/ApplyStyleCommand.cpp:
              (WebCore::createFontElement):
              (WebCore::createStyleSpanElement):
              (WebCore::ApplyStyleCommand::ApplyStyleCommand):
              (WebCore::ApplyStyleCommand::updateStartEnd):
              (WebCore::ApplyStyleCommand::applyRelativeFontStyleChange):
              (WebCore::ApplyStyleCommand::extractTextDecorationStyle):
              (WebCore::ApplyStyleCommand::extractAndNegateTextDecorationStyle):
              (WebCore::ApplyStyleCommand::applyTextDecorationStyle):
              (WebCore::ApplyStyleCommand::removeInlineStyle):
              (WebCore::ApplyStyleCommand::addInlineStyleIfNeeded):
              (WebCore::ApplyStyleCommand::computedFontSize):
              * editing/ApplyStyleCommand.h:
              (WebCore::ApplyStyleCommand::style):
              * editing/EditCommand.cpp:
              (WebCore::EditCommandPtr::setTypingStyle):
              (WebCore::EditCommand::setTypingStyle):
              (WebCore::EditCommand::styleAtPosition):
              * editing/EditCommand.h:
              (WebCore::EditCommand::document):
              (WebCore::EditCommand::typingStyle):
              * editing/InsertLineBreakCommand.cpp:
              (WebCore::InsertLineBreakCommand::InsertLineBreakCommand):
              (WebCore::InsertLineBreakCommand::doApply):
              * editing/InsertTextCommand.cpp:
              (WebCore::InsertTextCommand::prepareForTextInsertion):
              * editing/ReplaceSelectionCommand.cpp:
              (WebCore::computeAndStoreNodeDesiredStyle):
              (WebCore::NodeDesiredStyle::NodeDesiredStyle):
              (WebCore::ReplaceSelectionCommand::doApply):
              * editing/ReplaceSelectionCommand.h:
              (WebCore::NodeDesiredStyle::node):
              (WebCore::NodeDesiredStyle::style):
              (WebCore::ReplacementFragment::root):
              * editing/WrapContentsInDummySpanCommand.cpp:
              (WebCore::WrapContentsInDummySpanCommand::doApply):
              * editing/htmlediting.cpp:
              (WebCore::createDefaultParagraphElement):
              (WebCore::createBreakElement):
              * editing/markup.cpp:
              (WebCore::createFragmentFromMarkup):
              (WebCore::createParagraphContentsFromString):
              * editing/visible_text.cpp:
              (khtml::TextIterator::rangeFromLocationAndLength):
              * editing/visible_text.h:
              (WebCore::isCollapsibleWhitespace):
              (WebCore::WordAwareIterator::range):
              * khtml/ecma/kjs_css.cpp:
              (KJS::DOMCSSStyleDeclaration::cssPropertyGetter):
              (KJS::DOMCSSStyleDeclarationProtoFunc::callAsFunction):
              * khtml/ecma/kjs_dom.cpp:
              (KJS::DOMDocumentProtoFunc::callAsFunction):
              * khtml/ecma/kjs_html.cpp:
              (KJS::KJS::HTMLSelectCollection::put):
              (KJS::OptionConstructorImp::construct):
              * khtml/html/HTMLElementImpl.cpp:
              (WebCore::HTMLElementImpl::createContextualFragment):
              (WebCore::HTMLElementImpl::setInnerHTML):
              (WebCore::HTMLElementImpl::setOuterHTML):
              (WebCore::HTMLElementImpl::setOuterText):
              * khtml/html/HTMLElementImpl.h:
              * khtml/html/HTMLNameCollectionImpl.cpp:
              (WebCore::HTMLNameCollectionImpl::HTMLNameCollectionImpl):
              (WebCore::HTMLNameCollectionImpl::traverseNextItem):
              * khtml/html/HTMLNameCollectionImpl.h:
              * khtml/html/html_documentimpl.cpp:
              (WebCore::HTMLDocumentImpl::createElement):
              * khtml/html/html_documentimpl.h:
              (WebCore::HTMLDocumentImpl::collectionInfo):
              * khtml/html/htmlfactory.cpp:
              (DOM::htmlConstructor):
              (DOM::headConstructor):
              (DOM::bodyConstructor):
              (DOM::baseConstructor):
              (DOM::linkConstructor):
              (DOM::metaConstructor):
              (DOM::styleConstructor):
              (DOM::titleConstructor):
              (DOM::frameConstructor):
              (DOM::framesetConstructor):
              (DOM::iframeConstructor):
              (DOM::formConstructor):
              (DOM::buttonConstructor):
              (DOM::inputConstructor):
              (DOM::isindexConstructor):
              (DOM::fieldsetConstructor):
              (DOM::labelConstructor):
              (DOM::legendConstructor):
              (DOM::optgroupConstructor):
              (DOM::optionConstructor):
              (DOM::selectConstructor):
              (DOM::textareaConstructor):
              (DOM::dlConstructor):
              (DOM::ulConstructor):
              (DOM::olConstructor):
              (DOM::dirConstructor):
              (DOM::menuConstructor):
              (DOM::liConstructor):
              (DOM::blockquoteConstructor):
              (DOM::divConstructor):
              (DOM::headingConstructor):
              (DOM::hrConstructor):
              (DOM::paragraphConstructor):
              (DOM::preConstructor):
              (DOM::basefontConstructor):
              (DOM::fontConstructor):
              (DOM::modConstructor):
              (DOM::anchorConstructor):
              (DOM::imageConstructor):
              (DOM::mapConstructor):
              (DOM::areaConstructor):
              (DOM::canvasConstructor):
              (DOM::appletConstructor):
              (DOM::embedConstructor):
              (DOM::objectConstructor):
              (DOM::paramConstructor):
              (DOM::scriptConstructor):
              (DOM::tableConstructor):
              (DOM::tableCaptionConstructor):
              (DOM::tableColConstructor):
              (DOM::tableRowConstructor):
              (DOM::tableCellConstructor):
              (DOM::tableSectionConstructor):
              (DOM::brConstructor):
              (DOM::quoteConstructor):
              (DOM::marqueeConstructor):
              (DOM::HTMLElementFactory::createHTMLElement):
              * khtml/html/htmlfactory.h:
              * khtml/html/htmlparser.cpp:
              (HTMLParser::parseToken):
              (HTMLParser::textCreateErrorCheck):
              (HTMLParser::commentCreateErrorCheck):
              (HTMLParser::headCreateErrorCheck):
              (HTMLParser::bodyCreateErrorCheck):
              (HTMLParser::framesetCreateErrorCheck):
              (HTMLParser::iframeCreateErrorCheck):
              (HTMLParser::formCreateErrorCheck):
              (HTMLParser::isindexCreateErrorCheck):
              (HTMLParser::selectCreateErrorCheck):
              (HTMLParser::ddCreateErrorCheck):
              (HTMLParser::dtCreateErrorCheck):
              (HTMLParser::nestedCreateErrorCheck):
              (HTMLParser::nestedStyleCreateErrorCheck):
              (HTMLParser::tableCellCreateErrorCheck):
              (HTMLParser::tableSectionCreateErrorCheck):
              (HTMLParser::noembedCreateErrorCheck):
              (HTMLParser::noframesCreateErrorCheck):
              (HTMLParser::noscriptCreateErrorCheck):
              (HTMLParser::mapCreateErrorCheck):
              (HTMLParser::getNode):
              * khtml/html/htmlparser.h:
              * khtml/html/htmltokenizer.cpp:
              (WebCore::HTMLTokenizer::parseTag):
              (WebCore::HTMLTokenizer::processToken):
              * khtml/html/htmltokenizer.h:
              * ksvg2/misc/SVGDocumentExtensions.cpp:
              (WebCore::SVGDocumentExtensions::createSVGEventListener):
              * ksvg2/misc/SVGDocumentExtensions.h:
              * ksvg2/svg/SVGDOMImplementationImpl.cpp:
              (SVGDOMImplementationImpl::createDocumentType):
              (SVGDOMImplementationImpl::createDocument):
              (SVGDOMImplementationImpl::createCSSStyleSheet):
              * ksvg2/svg/SVGDOMImplementationImpl.h:
              * ksvg2/svg/SVGDocumentImpl.cpp:
              (WebCore::SVGDocumentImpl::createElement):
              (WebCore::SVGDocumentImpl::dispatchZoomEvent):
              (WebCore::SVGDocumentImpl::dispatchKeyEvent):
              (WebCore::SVGDocumentImpl::dispatchUIEvent):
              (WebCore::SVGDocumentImpl::dispatchMouseEvent):
              * ksvg2/svg/SVGDocumentImpl.h:
              * ksvg2/svg/SVGElementImpl.cpp:
              (WebCore::SVGElementImpl::addSVGEventListener):
              * ksvg2/svg/SVGSVGElementImpl.cpp:
              (WebCore::SVGSVGElementImpl::addSVGWindowEventListner):
              * page/Frame.cpp:
              (WebCore::Frame::view):
              (WebCore::Frame::begin):
              (WebCore::Frame::computeAndSetTypingStyle):
              (WebCore::Frame::selectionHasStyle):
              (WebCore::Frame::selectionStartHasStyle):
              (WebCore::Frame::selectionStartStylePropertyValue):
              (WebCore::Frame::selectionComputedStyle):
              (WebCore::Frame::forceLayout):
              (WebCore::Frame::sendResizeEvent):
              (WebCore::Frame::sendScrollEvent):
              (WebCore::Frame::clearTimers):
              (WebCore::Frame::styleForSelectionStart):
              * page/FramePrivate.h:
              * page/FrameTree.h:
              (WebCore::FrameTree::name):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@12865 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      85c3a50e
    • justing's avatar
      Changed by Darin on my machine. · bf7ae82d
      justing authored
              * coding/coding-style.html: Re-merged in changes Darin made to the guidelines
              a few days back. 
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@12863 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      bf7ae82d
    • harrison's avatar
      Reviewed by Darin. · d9721985
      harrison authored
              Test:
              * manual-tests/mail-attachments.html: Added.
              Automated test not currently possible because widgets do not actually draw when not in a window.
              Geoff and Justin are fixing that and will add this test.
      
              * rendering/render_frames.cpp:
              (WebCore::RenderPartObject::updateWidget):
              Fix unique param check when processing object tag attributes.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@12862 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      d9721985
    • thatcher's avatar
      088352fb
    • thatcher's avatar
      Fix build failure. · f481220a
      thatcher authored
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@12858 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      f481220a
    • thatcher's avatar
      Added -Wno-deprecated-declarations to all the ObjC binding files to prevent deprecation · df555b05
      thatcher authored
              warnings. Using <rdar://problem/4448350> to track this.
      
              * JavaScriptCore.xcodeproj/project.pbxproj:
              * bindings/objc/objc_jsobject.h: Removed empty file.
              * bindings/objc/objc_jsobject.mm: Removed empty file.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@12857 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      df555b05
    • adele's avatar
      Reviewed by Darin. · b0a2d7b4
      adele authored
              - Fixed http://bugzilla.opendarwin.org/show_bug.cgi?id=7113
              Typing in editable overflow:hidden div doesn't scroll
      
              * bridge/mac/WebCoreFrameBridge.mm: (-[WebCoreFrameBridge ensureSelectionVisible]):
                Changed scrollRectToVisible call so that it will align to the edge instead of trying to center the selection.  
                Centering looks funny when it happens after typing, deleting, moving the cursor, etc.
              * rendering/render_layer.cpp: (WebCore::RenderLayer::scrollRectToVisible):
                Use scrollWidth() and scrollHeight() functions instead of m_scrollWidth and m_scrollHeight.  
                These functions will cause the correct scroll dimensions to be calculated for overflow:hidden layers.
                Also subtracted scrollbar width and height when calculating the layer bounds. This was causing scroll problems in overflow:scroll.
                I also did some cleanup to use xPos() and yPos() instead of m_x and m_y, and to use scrollYOffset() instead of m_scrollY.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@12856 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      b0a2d7b4
    • adele's avatar
      LayoutTests: · 1e385966
      adele authored
              Updating results for fix:
              http://bugzilla.opendarwin.org/show_bug.cgi?id=6812
              Missing focus ring on new text fields
      
              * fast/forms/input-appearance-focus-expected.checksum:
              * fast/forms/input-appearance-focus-expected.png:
      
      WebCore:
      
              Reviewed by Darin.
      
              - Fixed http://bugzilla.opendarwin.org/show_bug.cgi?id=6812
              Missing focus ring on new text fields
      
              Tests:
              * fast/forms/input-appearance-focus.html: Updated.
      
              * rendering/render_object.cpp: (WebCore::RenderObject::paintOutline): 
               call supportsFocusRing instead of checking the appearance.
              * rendering/render_theme.cpp: (khtml::RenderTheme::supportsFocusRing): Added. 
               Checks appearance.  Theme will draw focus ring if there's an appearance, but not for the new text fields.
              * rendering/render_theme.h:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@12855 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      1e385966
    • darin's avatar
      Added a file and function to a change log entry. · 13d3507e
      darin authored
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@12854 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      13d3507e
    • darin's avatar
      Reviewed by Hyatt. · d85b585f
      darin authored
              - eliminate QFrame and QObject::inherits, fix some strange stuff
                in RenderCanvas that showed up when I tested that change
      
              * kwq/KWQFrame.h: Removed.
              * kwq/KWQFrame.mm: Removed.
      
              * bridge/mac/FrameViewMac.mm: Added.
      
              * WebCore.xcodeproj/project.pbxproj: Updated for adds and removes.
              * WebCore.vcproj/WebCore/WebCore.vcproj: Updated for removes.
      
              * bridge/mac/WebCoreFrameBridge.mm:
              (-[WebCoreFrameBridge RenderObject::nodeInfoAtPoint:]):
              * khtml/ecma/kjs_window.cpp:
              (KJS::FrameArray::indexGetter):
              (KJS::FrameArray::nameGetter):
              * kwq/KWQAccObject.mm:
              (-[KWQAccObject doAXTextMarkerForPosition:]):
              * kwq/KWQRenderTreeDebug.cpp:
              (write):
              * page/Frame.cpp:
              (WebCore::isFrameElement):
              * page/FramePrivate.h:
              (WebCore::FramePrivate::FramePrivate):
              Change QObject::inherits callers to call the "is" functions directly.
      
              * kwq/KWQObject.h:
              * kwq/KWQObject.cpp: Removed QObject::inherits, QObject::isQFrame,
              and QObject::isQScrollView.
      
              * kwq/KWQScrollView.h: Inherit from Widget instead of QFrame.
              Remove isQScrollView.
              * kwq/KWQScrollView.mm: Remove isQScrollView.
      
              * page/FrameView.h:
              * page/FrameView.cpp: Changed underMouse and clickNode to be RefPtr.
              Added m_hasBorder.
              (WebCore::FrameViewPrivate::FrameViewPrivate):
              (WebCore::FrameViewPrivate::~FrameViewPrivate):
              (WebCore::FrameViewPrivate::reset):
              (WebCore::FrameView::layout):
              (WebCore::FrameView::viewportMousePressEvent):
              (WebCore::FrameView::invalidateClick):
              (WebCore::FrameView::viewportMouseReleaseEvent):
              (WebCore::FrameView::keyPressEvent):
              (WebCore::FrameView::dispatchDragEvent): Use RefPtr for MouseEventImpl.
              (WebCore::FrameView::nodeUnderMouse):
              (WebCore::FrameView::dispatchMouseEvent):
              (WebCore::FrameView::setHasBorder): Added.
              (WebCore::FrameView::hasBorder): Added.
              (WebCore::FrameView::borderWidth): Added.
      
              * rendering/render_canvas.h: Eliminated unneeded setWidth/Height overrides.
              Eliminated viewportWidth(), viewportHeight(), m_rootWidth, m_rootHeight,
              m_viewportWidth, and m_viewportHeight.
              * rendering/render_canvas.cpp:
              (RenderCanvas::calcHeight): Remove unneeded code to set height when there's
              no view.
              (RenderCanvas::calcWidth): Fix code to set width to visibleWidth(). Removed
              incorrect old width setting, and removed unneeded code to set width when
              there's no view. Also removed incorrect margin-setting code.
              (RenderCanvas::layout): Removed incorrect code to set width and height.
              Instead letting calcWidth and calcHeight do the job.
              (RenderCanvas::repaintViewRectangle): Use new FrameView::hasBorder instead
              of QFrame::frameStyle.
              (RenderCanvas::viewRect): Removed unneeded "root width" feature for a canvas
              without a view.
      
              * rendering/render_frames.cpp:
              (WebCore::RenderFrame::slotViewCleared): Use new setHasBorder.
              (WebCore::RenderPartObject::slotViewCleared): Ditto.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@12853 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      d85b585f
    • eseidel's avatar
      2006-02-17 Eric Seidel <eseidel@apple.com> · bffab9a6
      eseidel authored
              Reviewed by justing.
      
              Close several age-old leaks in xslt code.
              Tests already were catching these.
      
              * khtml/xsl/xsl_stylesheetimpl.cpp:
              (WebCore::XSLStyleSheetImpl::loadChildSheets):
              (WebCore::XSLStyleSheetImpl::locateStylesheetSubResource):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@12852 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      bffab9a6
    • tomernic's avatar
      Reviewed by Geoff. · a86ce131
      tomernic authored
              <rdar://problem/4428609> Flash Player 8.0.22 can crash Safari (and WebKit apps)
              with javascript disabled (7015)
      
              Added a test case, manual-tests/NPN_Invoke.  This is a skeleton of a Netscape
              plugin which uses NPN_Invoke() to call the window.alert() JavaScript function.
              
              * bridge/mac/MacFrame.mm:
              (WebCore::MacFrame::windowScriptNPObject):
              Removed the check Darin added to return 0 when JavaScript is disabled.
              This method cannot return 0, because plugins are not guaranteed to check
              for that.
              Removed my old fix for Radar 4428609 (7015) in favor of a better solution.
              Instead of creating a "dummy" JSObject to represent the window script object
              when JavaScript is disabled, we use the new JavaScriptCore bindings API to 
              create a "no script" NPObject.  This solution is better because it does not
              cause entry into any JavaScript interpreter code.
      
              * manual-tests/NPN_Invoke: Added.
              * manual-tests/NPN_Invoke/English.lproj: Added.
              * manual-tests/NPN_Invoke/English.lproj/Localized.r: Added.
              * manual-tests/NPN_Invoke/Info.plist: Added.
              * manual-tests/NPN_Invoke/NPN_Invoke.xcodeproj: Added.
              * manual-tests/NPN_Invoke/NPN_Invoke.xcodeproj/project.pbxproj: Added.
              * manual-tests/NPN_Invoke/main.c: Added.
              * manual-tests/NPN_Invoke/test.html: Added.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@12851 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      a86ce131
    • tomernic's avatar
      Reviewed by Geoff. · 0f5d4088
      tomernic authored
              <rdar://problem/4428609> Flash Player 8.0.22 can crash Safari (and WebKit apps) with
              javascript disabled (7015)
      
              * bindings/NP_jsobject.cpp:
              (_NPN_CreateNoScriptObject):
              Returns an NPObject which is not bound to a JavaScript object.  This kind of NPObject
              can be given to a plugin as the "window script object" when JavaScript is disabled.
              The object has a custom NPClass, NPNoScriptObjectClass, which has no defined methods.
              Because of this, none of the NPN_* functions called by the plugin on this "no script
              object" will cause entry into JavaScript code.
              (_NPN_InvokeDefault):
              Make sure the NPVariant is filled before returning from this function.  This never
              mattered before because we never reached this case, having only created NPObjects of
              the class NPScriptObjectClass.
              (_NPN_Invoke):
              ditto
              (_NPN_Evaluate):
              ditto
              (_NPN_GetProperty):
              ditto
      
              * bindings/NP_jsobject.h:
              Declared _NPN_CreateNoScriptObject().
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@12850 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      0f5d4088
    • darin's avatar
      Fixing name to use "ue" since I can't figure out how to include · 34eed419
      darin authored
      and umlaut in a change log message.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@12849 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      34eed419
    • darin's avatar
      Reviewed by me, change by Peter Kummel. · b50ee18e
      darin authored
              * kjs/operations.cpp: (KJS::isNegInf): Fix Windows code, which was
              checking for positive infinity (rolling in fix from KDE side).
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@12848 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      b50ee18e
    • ap's avatar
      Fix by Mitz Pettel, reviewed by Darin. · 7bf7c02c
      ap authored
              - fix http://bugzilla.opendarwin.org/show_bug.cgi?id=7274
                Assertion failure in TimerBase::checkHeapIndex() (Timer.cpp:199) !timerHeap->isEmpty()
      
              * platform/Timer.cpp:
              (WebCore::TimerBase::stop): Call setNextFireTime(0) unconditionally to make sure the timer
              is removed from timersReadyToFire so that fireTimers doesn't try to fire a deleted timer.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@12847 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      7bf7c02c
    • mjs's avatar
      Reviewed and landed by Maciej. · 90475907
      mjs authored
              Made the author name bold on the frontpage.
              Moved the "Posted by" line up under the title and made the author name
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@12846 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      90475907
    • justing's avatar
      · efe5f8b6
      justing authored
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@12845 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      efe5f8b6
    • justing's avatar
      WebKit: · 8cf4b8ff
      justing authored
              Reviewed by darin
              
              <http://bugzilla.opendarwin.org/show_bug.cgi?id=7148>
              Add drag and drop support to DumpRenderTree
              
              Added a UI delegate method so that DumpRenderTree can perform dragging on its own.
              Made _updateFocusState SPI, to allow us to test the behavior and appearance of
              windows that have or don't have focus.
      
              * WebView/WebHTMLView.m:
              (-[WebHTMLView _updateFocusState]):
              (-[NSArray viewDidMoveToWindow]):
              (-[NSArray windowDidBecomeKey:]):
              (-[NSArray windowDidResignKey:]):
              (-[NSArray dragImage:at:offset:event:pasteboard:source:slideBack:]):
              (-[NSArray becomeFirstResponder]):
              (-[NSArray resignFirstResponder]):
              (-[WebHTMLView _formControlIsResigningFirstResponder:]):
              * WebView/WebHTMLViewInternal.h:
              * WebView/WebHTMLViewPrivate.h:
              * WebView/WebUIDelegatePrivate.h:
              * WebView/WebView.m:
      
      WebKitTools:
      
              Reviewed by darin
              
              <http://bugzilla.opendarwin.org/show_bug.cgi?id=7148>
              Add drag and drop support to DumpRenderTree
              
              Intercept the drag start using the new UI delegate method, package an NSDraggingInfo,
              and send dragging updates.  Put DumpRenderTree's WebView into an offscreen window.
      
              * DumpRenderTree/DumpRenderTree.m:
              (main):
              (-[WaitUntilDoneDelegate webView:didCommitLoadForFrame:]):
              (-[WaitUntilDoneDelegate webView:dragImage:at:offset:event:pasteboard:source:slideBack:forView:]):
              (-[WaitUntilDoneDelegate webViewFocus:]):
              (+[LayoutTestController isSelectorExcludedFromWebScript:]):
              (+[LayoutTestController webScriptNameForSelector:]):
              (-[LayoutTestController setWindowIsKey:]):
              (-[LayoutTestController setMainFrameIsFirstResponder:]):
              (-[EventSendingController init]):
              (-[EventSendingController mouseDown]):
              (-[EventSendingController mouseUp]):
              (-[EventSendingController mouseMoveToX:Y:]):
              (dumpRenderTree):
              (-[DumpRenderTreeWindow isKeyWindow]):
              (-[DumpRenderTreeDraggingInfo initWithImage:offset:pasteboard:source:]):
              (-[DumpRenderTreeDraggingInfo dealloc]):
              (-[DumpRenderTreeDraggingInfo draggingDestinationWindow]):
              (-[DumpRenderTreeDraggingInfo draggingSourceOperationMask]):
              (-[DumpRenderTreeDraggingInfo draggingLocation]):
              (-[DumpRenderTreeDraggingInfo draggedImageLocation]):
              (-[DumpRenderTreeDraggingInfo draggedImage]):
              (-[DumpRenderTreeDraggingInfo draggingPasteboard]):
              (-[DumpRenderTreeDraggingInfo draggingSource]):
              (-[DumpRenderTreeDraggingInfo draggingSequenceNumber]):
              (-[DumpRenderTreeDraggingInfo slideDraggedImageTo:]):
              (-[DumpRenderTreeDraggingInfo namesOfPromisedFilesDroppedAtDestination:]):
              * DumpRenderTree/TextInputController.m:
              (-[TextInputController firstRectForCharactersFrom:length:]):
              (-[TextInputController characterIndexForPointX:Y:]):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@12844 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      8cf4b8ff
    • justing's avatar
      Reviewed by darin · 9f96b2ad
      justing authored
              
              <http://bugzilla.opendarwin.org/show_bug.cgi?id=7148>
              Add drag and drop support to DumpRenderTree
      
              * css1/basic/comments-expected.checksum:
              * css1/basic/comments-expected.png:
              * css1/basic/containment-expected.checksum:
              * css1/basic/containment-expected.png:
              * css1/basic/id_as_selector-expected.checksum:
              * css1/basic/id_as_selector-expected.png:
              * css1/basic/inheritance-expected.checksum:
              * css1/basic/inheritance-expected.png:
              * css1/box_properties/border-expected.checksum:
              * css1/box_properties/border-expected.png:
              * css1/box_properties/border_bottom-expected.checksum:
              * css1/box_properties/border_bottom-expected.png:
              * css1/box_properties/border_bottom_width-expected.checksum:
              * css1/box_properties/border_bottom_width-expected.png:
              * css1/box_properties/border_left-expected.checksum:
              * css1/box_properties/border_left-expected.png:
              * css1/box_properties/border_left_width-expected.checksum:
              * css1/box_properties/border_left_width-expected.png:
              * css1/box_properties/border_right_inline-expected.checksum:
              * css1/box_properties/border_right_inline-expected.png:
              * css1/box_properties/border_right_width-expected.checksum:
              * css1/box_properties/border_right_width-expected.png:
              * css1/box_properties/border_style-expected.checksum:
              * css1/box_properties/border_style-expected.png:
              * css1/box_properties/border_top-expected.checksum:
              * css1/box_properties/border_top-expected.png:
              * css1/box_properties/border_top_width-expected.checksum:
              * css1/box_properties/border_top_width-expected.png:
              * css1/box_properties/border_width-expected.checksum:
              * css1/box_properties/border_width-expected.png:
              * css1/box_properties/clear-expected.checksum:
              * css1/box_properties/clear-expected.png:
              * css1/box_properties/clear_float-expected.checksum:
              * css1/box_properties/clear_float-expected.png:
              * css1/box_properties/float_elements_in_series-expected.checksum:
              * css1/box_properties/float_elements_in_series-expected.png:
              * css1/box_properties/float_margin-expected.checksum:
              * css1/box_properties/float_margin-expected.png:
              * css1/box_properties/float_on_text_elements-expected.checksum:
              * css1/box_properties/float_on_text_elements-expected.png:
              * css1/box_properties/height-expected.checksum:
              * css1/box_properties/height-expected.png:
              * css1/box_properties/margin-expected.checksum:
              * css1/box_properties/margin-expected.png:
              * css1/box_properties/margin_bottom-expected.checksum:
              * css1/box_properties/margin_bottom-expected.png:
              * css1/box_properties/margin_inline-expected.checksum:
              * css1/box_properties/margin_inline-expected.png:
              * css1/box_properties/margin_left-expected.checksum:
              * css1/box_properties/margin_left-expected.png:
              * css1/box_properties/margin_right-expected.checksum:
              * css1/box_properties/margin_right-expected.png:
              * css1/box_properties/margin_top-expected.checksum:
              * css1/box_properties/margin_top-expected.png:
              * css1/box_properties/padding-expected.checksum:
              * css1/box_properties/padding-expected.png:
              * css1/box_properties/padding_bottom-expected.checksum:
              * css1/box_properties/padding_bottom-expected.png:
              * css1/box_properties/padding_inline-expected.checksum:
              * css1/box_properties/padding_inline-expected.png:
              * css1/box_properties/padding_left-expected.checksum:
              * css1/box_properties/padding_left-expected.png:
              * css1/box_properties/padding_right-expected.checksum:
              * css1/box_properties/padding_right-expected.png:
              * css1/box_properties/padding_top-expected.checksum:
              * css1/box_properties/padding_top-expected.png:
              * css1/box_properties/width-expected.checksum:
              * css1/box_properties/width-expected.png:
              * css1/cascade/cascade_order-expected.checksum:
              * css1/cascade/cascade_order-expected.png:
              * css1/classification/display-expected.checksum:
              * css1/classification/display-expected.png:
              * css1/classification/list_style_type-expected.checksum:
              * css1/classification/list_style_type-expected.png:
              * css1/classification/white_space-expected.checksum:
              * css1/classification/white_space-expected.png:
              * css1/color_and_background/background-expected.checksum:
              * css1/color_and_background/background-expected.png:
              * css1/color_and_background/background_attachment-expected.checksum:
              * css1/color_and_background/background_attachment-expected.png:
              * css1/color_and_background/background_position-expected.checksum:
              * css1/color_and_background/background_position-expected.png:
              * css1/color_and_background/background_repeat-expected.checksum:
              * css1/color_and_background/background_repeat-expected.png:
              * css1/conformance/forward_compatible_parsing-expected.checksum:
              * css1/conformance/forward_compatible_parsing-expected.png:
              * css1/font_properties/font-expected.checksum:
              * css1/font_properties/font-expected.png:
              * css1/font_properties/font_family-expected.checksum:
              * css1/font_properties/font_family-expected.png:
              * css1/font_properties/font_size-expected.checksum:
              * css1/font_properties/font_size-expected.png:
              * css1/font_properties/font_weight-expected.checksum:
              * css1/font_properties/font_weight-expected.png:
              * css1/formatting_model/floating_elements-expected.checksum:
              * css1/formatting_model/floating_elements-expected.png:
              * css1/formatting_model/height_of_lines-expected.checksum:
              * css1/formatting_model/height_of_lines-expected.png:
              * css1/formatting_model/horizontal_formatting-expected.checksum:
              * css1/formatting_model/horizontal_formatting-expected.png:
              * css1/formatting_model/inline_elements-expected.checksum:
              * css1/formatting_model/inline_elements-expected.png:
              * css1/formatting_model/replaced_elements-expected.checksum:
              * css1/formatting_model/replaced_elements-expected.png:
              * css1/formatting_model/vertical_formatting-expected.checksum:
              * css1/formatting_model/vertical_formatting-expected.png:
              * css1/pseudo/anchor-expected.checksum:
              * css1/pseudo/anchor-expected.png:
              * css1/pseudo/firstletter-expected.checksum:
              * css1/pseudo/firstletter-expected.png:
              * css1/pseudo/firstline-expected.checksum:
              * css1/pseudo/firstline-expected.png:
              * css1/pseudo/multiple_pseudo_elements-expected.checksum:
              * css1/pseudo/multiple_pseudo_elements-expected.png:
              * css1/text_properties/letter_spacing-expected.checksum:
              * css1/text_properties/letter_spacing-expected.png:
              * css1/text_properties/line_height-expected.checksum:
              * css1/text_properties/line_height-expected.png:
              * css1/text_properties/text-transCapitalize-expected.checksum:
              * css1/text_properties/text-transCapitalize-expected.png:
              * css1/text_properties/text_decoration-expected.checksum:
              * css1/text_properties/text_decoration-expected.png:
              * css1/text_properties/text_indent-expected.checksum:
              * css1/text_properties/text_indent-expected.png:
              * css1/text_properties/text_transform-expected.checksum:
              * css1/text_properties/text_transform-expected.png:
              * css1/text_properties/vertical_align-expected.checksum:
              * css1/text_properties/vertical_align-expected.png:
              * css1/text_properties/word_spacing-expected.checksum:
              * css1/text_properties/word_spacing-expected.png:
              * css1/units/color_units-expected.checksum:
              * css1/units/color_units-expected.png:
              * css1/units/length_units-expected.checksum:
              * css1/units/length_units-expected.png:
              * css2.1/t0801-c412-hz-box-00-b-a-expected.checksum:
              * css2.1/t0801-c412-hz-box-00-b-a-expected.png:
              * css2.1/t0803-c5502-mrgn-r-02-c-expected.checksum:
              * css2.1/t0803-c5502-mrgn-r-02-c-expected.png:
              * css2.1/t0803-c5505-mrgn-02-c-expected.checksum:
              * css2.1/t0803-c5505-mrgn-02-c-expected.png:
              * css2.1/t080301-c411-vt-mrgn-00-b-expected.checksum:
              * css2.1/t080301-c411-vt-mrgn-00-b-expected.png:
              * css2.1/t0905-c5525-fltclr-00-c-ag-expected.checksum:
              * css2.1/t0905-c5525-fltclr-00-c-ag-expected.png:
              * css2.1/t0905-c5525-fltmrgn-00-c-ag-expected.checksum:
              * css2.1/t0905-c5525-fltmrgn-00-c-ag-expected.png:
              * css2.1/t0905-c5525-fltwidth-00-c-g-expected.checksum:
              * css2.1/t0905-c5525-fltwidth-00-c-g-expected.png:
              * css2.1/t1002-c5523-width-02-b-g-expected.checksum:
              * css2.1/t1002-c5523-width-02-b-g-expected.png:
              * css2.1/t140201-c535-bg-fixd-00-b-g-expected.checksum:
              * css2.1/t140201-c535-bg-fixd-00-b-g-expected.png:
              * css2.1/t140201-c537-bgfxps-00-c-ag-expected.checksum:
              * css2.1/t140201-c537-bgfxps-00-c-ag-expected.png:
              * css2.1/t1508-c527-font-07-b-expected.checksum:
              * css2.1/t1508-c527-font-07-b-expected.png:
              * editing/deleting/delete-after-span-ws-001-expected.checksum:
              * editing/deleting/delete-after-span-ws-001-expected.png:
              * editing/deleting/delete-after-span-ws-002-expected.checksum:
              * editing/deleting/delete-after-span-ws-002-expected.png:
              * editing/deleting/delete-after-span-ws-003-expected.checksum:
              * editing/deleting/delete-after-span-ws-003-expected.png:
              * editing/deleting/delete-and-undo-expected.checksum:
              * editing/deleting/delete-and-undo-expected.png:
              * editing/deleting/delete-and-undo-expected.txt:
              * editing/deleting/delete-line-end-ws-001-expected.checksum:
              * editing/deleting/delete-line-end-ws-001-expected.png:
              * editing/deleting/delete-line-end-ws-002-expected.checksum:
              * editing/deleting/delete-line-end-ws-002-expected.png:
              * editing/inserting/insert-div-023-expected.checksum:
              * editing/inserting/insert-div-023-expected.png:
              * editing/selection/caret-and-focus-ring.html:
              * editing/selection/drag-to-contenteditable-iframe-expected.checksum: Added.
              * editing/selection/drag-to-contenteditable-iframe-expected.png: Added.
              * editing/selection/drag-to-contenteditable-iframe-expected.txt: Added.
              * editing/selection/drag-to-contenteditable-iframe.html: Added.
              * editing/selection/focus_editable_html-expected.checksum:
              * editing/selection/focus_editable_html-expected.png:
              * editing/selection/iframe-expected.checksum:
              * editing/selection/iframe-expected.png:
              * editing/selection/replaced-boundaries-3-expected.checksum:
              * editing/selection/replaced-boundaries-3-expected.png:
              * editing/selection/select-all-001-expected.checksum:
              * editing/selection/select-all-001-expected.png:
              * editing/selection/select-all-002-expected.checksum:
              * editing/selection/select-all-002-expected.png:
              * editing/selection/select-all-003-expected.checksum:
              * editing/selection/select-all-003-expected.png:
              * editing/selection/select-all-004-expected.checksum:
              * editing/selection/select-all-004-expected.png:
              * editing/selection/select-box-expected.checksum:
              * editing/selection/select-box-expected.png:
              * editing/selection/selection-background.html:
              * editing/selection/unrendered-001-expected.checksum:
              * editing/selection/unrendered-001-expected.png:
              * editing/selection/unrendered-002-expected.checksum:
              * editing/selection/unrendered-002-expected.png:
              * editing/selection/unrendered-003-expected.checksum:
              * editing/selection/unrendered-003-expected.png:
              * editing/selection/unrendered-004-expected.checksum:
              * editing/selection/unrendered-004-expected.png:
              * editing/selection/unrendered-005-expected.checksum:
              * editing/selection/unrendered-005-expected.png:
              * editing/undo/4063751-expected.txt:
              * editing/undo/redo-typing-001-expected.txt:
              * editing/undo/undo-typing-001-expected.checksum:
              * editing/undo/undo-typing-001-expected.png:
              * editing/undo/undo-typing-001-expected.txt:
              * fast/block/basic/016-expected.checksum:
              * fast/block/basic/016-expected.png:
              * fast/block/basic/text-indent-rtl-expected.checksum:
              * fast/block/float/008-expected.checksum:
              * fast/block/float/008-expected.png:
              * fast/block/float/013-expected.checksum:
              * fast/block/float/013-expected.png:
              * fast/block/float/019-expected.checksum:
              * fast/block/float/019-expected.png:
              * fast/block/float/021-expected.checksum:
              * fast/block/float/021-expected.png:
              * fast/block/float/025-expected.checksum:
              * fast/block/float/025-expected.png:
              * fast/block/float/026-expected.checksum:
              * fast/block/float/026-expected.png:
              * fast/block/float/027-expected.checksum:
              * fast/block/float/027-expected.png:
              * fast/block/float/028-expected.checksum:
              * fast/block/float/028-expected.png:
              * fast/block/float/032-expected.checksum:
              * fast/block/float/032-expected.png:
              * fast/block/float/033-expected.checksum:
              * fast/block/float/033-expected.png:
              * fast/block/margin-collapse/103-expected.checksum:
              * fast/block/margin-collapse/103-expected.png:
              * fast/block/margin-collapse/104-expected.checksum:
              * fast/block/margin-collapse/104-expected.png:
              * fast/block/positioning/047-expected.checksum:
              * fast/block/positioning/047-expected.png:
              * fast/block/positioning/051-expected.checksum:
              * fast/block/positioning/051-expected.png:
              * fast/block/positioning/055-expected.checksum:
              * fast/block/positioning/055-expected.png:
              * fast/block/positioning/auto/007-expected.checksum:
              * fast/block/positioning/auto/007-expected.png:
              * fast/block/positioning/relayout-on-position-change-expected.checksum:
              * fast/box-sizing/box-sizing-expected.checksum:
              * fast/box-sizing/box-sizing-expected.png:
              * fast/clip/014-expected.checksum:
              * fast/clip/014-expected.png:
              * fast/css-generated-content/014-expected.checksum:
              * fast/css-generated-content/014-expected.png:
              * fast/css/005-expected.checksum:
              * fast/css/005-expected.png:
              * fast/css/MarqueeLayoutTest-expected.checksum:
              * fast/css/MarqueeLayoutTest-expected.png:
              * fast/css/imageTileOpacity-expected.checksum:
              * fast/css/imageTileOpacity-expected.png:
              * fast/css/word-space-extra-expected.checksum:
              * fast/css/word-space-extra-expected.png:
              * fast/dom/HTMLObjectElement/object-as-frame.html:
              * fast/dom/focus-contenteditable-expected.checksum:
              * fast/dom/focus-contenteditable-expected.png:
              * fast/dom/window-onFocus.html:
              * fast/dynamic/008-expected.checksum:
              * fast/dynamic/008-expected.png:
              * fast/encoding/utf-16-big-endian-expected.checksum:
              * fast/encoding/utf-16-big-endian-expected.png:
              * fast/encoding/utf-16-little-endian-expected.checksum:
              * fast/encoding/utf-16-little-endian-expected.png:
              * fast/flexbox/009-expected.checksum:
              * fast/flexbox/009-expected.png:
              * fast/flexbox/016-expected.checksum:
              * fast/flexbox/016-expected.png:
              * fast/forms/001-expected.checksum:
              * fast/forms/001-expected.png:
              * fast/forms/003-expected.checksum:
              * fast/forms/003-expected.png:
              * fast/forms/004-expected.checksum:
              * fast/forms/004-expected.png:
              * fast/forms/HTMLOptionElement_label01-expected.checksum:
              * fast/forms/HTMLOptionElement_label01-expected.png:
              * fast/forms/HTMLOptionElement_label02-expected.checksum:
              * fast/forms/HTMLOptionElement_label02-expected.png:
              * fast/forms/HTMLOptionElement_label03-expected.checksum:
              * fast/forms/HTMLOptionElement_label03-expected.png:
              * fast/forms/HTMLOptionElement_label04-expected.checksum:
              * fast/forms/HTMLOptionElement_label04-expected.png:
              * fast/forms/button-sizes-expected.checksum:
              * fast/forms/button-sizes-expected.png:
              * fast/forms/checkbox-radio-onchange-expected.checksum:
              * fast/forms/checkbox-radio-onchange-expected.png:
              * fast/forms/form-element-geometry-expected.checksum:
              * fast/forms/form-element-geometry-expected.png:
              * fast/forms/indeterminate-expected.checksum:
              * fast/forms/indeterminate-expected.png:
              * fast/forms/option-script-expected.checksum:
              * fast/forms/option-script-expected.png:
              * fast/forms/option-strip-whitespace-expected.checksum:
              * fast/forms/option-strip-whitespace-expected.png:
              * fast/forms/radio_checked-expected.checksum:
              * fast/forms/radio_checked-expected.png:
              * fast/forms/radio_checked_dynamic-expected.checksum:
              * fast/forms/radio_checked_dynamic-expected.png:
              * fast/forms/textAreaLineHeight-expected.checksum:
              * fast/forms/textAreaLineHeight-expected.png:
              * fast/inline-block/tricky-baseline-expected.checksum:
              * fast/inline-block/tricky-baseline-expected.png:
              * fast/invalid/014-expected.checksum:
              * fast/invalid/014-expected.png:
              * fast/lists/008-expected.checksum:
              * fast/lists/008-expected.png:
              * fast/lists/li-br-expected.checksum:
              * fast/lists/li-br-expected.png:
              * fast/lists/olstart-expected.checksum:
              * fast/lists/olstart-expected.png:
              * fast/loader/form-events-back-forward.html: Removed.
              * fast/loader/form-events-back-forward.html-disabled: Added.
              * fast/overflow/002-expected.checksum:
              * fast/overflow/002-expected.png:
              * fast/overflow/003-expected.checksum:
              * fast/overflow/003-expected.png:
              * fast/overflow/005-expected.checksum:
              * fast/overflow/005-expected.png:
              * fast/overflow/006-expected.checksum:
              * fast/overflow/006-expected.png:
              * fast/overflow/007-expected.checksum:
              * fast/overflow/007-expected.png:
              * fast/overflow/image-selection-highlight-expected.checksum:
              * fast/overflow/image-selection-highlight-expected.png:
              * fast/overflow/overflow-auto-table-expected.checksum:
              * fast/overflow/overflow-auto-table-expected.png:
              * fast/overflow/overflow-rtl-expected.checksum:
              * fast/overflow/overflow-rtl-expected.png:
              * fast/overflow/overflow-text-hit-testing-expected.checksum:
              * fast/overflow/overflow-text-hit-testing-expected.png:
              * fast/overflow/scrollRevealButton-expected.checksum:
              * fast/overflow/scrollRevealButton-expected.png:
              * fast/parser/comments-expected.checksum:
              * fast/parser/comments-expected.png:
              * fast/parser/document-write-option-expected.checksum:
              * fast/parser/document-write-option-expected.png:
              * fast/parser/entities-in-xhtml-expected.checksum:
              * fast/parser/entities-in-xhtml-expected.png:
              * fast/replaced/005-expected.checksum:
              * fast/replaced/005-expected.png:
              * fast/replaced/width100percent-expected.checksum:
              * fast/replaced/width100percent-expected.png:
              * fast/selectors/166-expected.checksum:
              * fast/selectors/166-expected.png:
              * fast/table/023-expected.checksum:
              * fast/table/023-expected.png:
              * fast/table/034-expected.checksum:
              * fast/table/034-expected.png:
              * fast/table/040-expected.checksum:
              * fast/table/040-expected.png:
              * fast/table/border-collapsing/004-expected.checksum:
              * fast/table/border-collapsing/004-expected.png:
              * fast/table/edge-offsets-expected.checksum:
              * fast/table/edge-offsets-expected.png:
              * fast/table/height-percent-test-expected.checksum:
              * fast/table/height-percent-test-expected.png:
              * fast/table/overflowHidden-expected.checksum:
              * fast/table/overflowHidden-expected.png:
              * fast/table/wide-colspan-expected.checksum:
              * fast/table/wide-colspan-expected.png:
              * fast/table/wide-column-expected.checksum:
              * fast/table/wide-column-expected.png:
              * fast/text/softHyphen-expected.checksum:
              * fast/text/softHyphen-expected.png:
              * fast/text/whitespace/024-expected.checksum:
              * fast/text/whitespace/024-expected.png:
              * fast/tokenizer/004-expected.checksum:
              * fast/tokenizer/004-expected.png:
              * svg/custom/feDisplacementMap-01-expected.png: Removed.
              * svg/custom/junk-data-expected.checksum:
              * svg/custom/junk-data-expected.png:
              * svg/custom/missing-xlink-expected.checksum:
              * svg/custom/missing-xlink-expected.png:
              * svg/custom/path-bad-data-expected.checksum:
              * svg/custom/path-bad-data-expected.png:
              * traversal/tree-walker-004-expected.checksum:
              * traversal/tree-walker-004-expected.png:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@12843 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      9f96b2ad
    • justing's avatar
      · 1858833f
      justing authored
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@12842 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      1858833f
    • justing's avatar
      · b32c5213
      justing authored
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@12841 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      b32c5213
  3. 15 Feb, 2006 4 commits
    • ggaren's avatar
      JavaScriptCore: · cd217c5d
      ggaren authored
              Reviewed by Maciej, Eric.
      
              - WebCore half of fix for <rdar://problem/4176077> CrashTracer: 6569
              crashes in DashboardClient at com.apple.JavaScriptCore:
              KJS::Bindings::ObjcFallbackObjectImp::type()
      
              WebCore and JavaScriptCore weren't sharing Instance objects very
              nicely. I made them use RefPtrs, and sent them to bed without dessert.
      
              * bindings/jni/jni_instance.cpp: Made _instance a RefPtr
              (JavaInstance::~JavaInstance):
              (JObjectWrapper::JObjectWrapper):
              * bindings/jni/jni_instance.h:
              (KJS::Bindings::JObjectWrapper::ref):
              (KJS::Bindings::JObjectWrapper::deref):
              * bindings/jni/jni_runtime.cpp: Made _array a RefPtr
              (JavaArray::~JavaArray):
              (JavaArray::JavaArray):
              * bindings/jni/jni_runtime.h:
              (KJS::Bindings::JavaArray::operator=):
              * bindings/objc/objc_runtime.h:
              - Prohibited copying because that would muss the ref count.
              - Prohibited construction without instance because an instance wrapper
              without an instance is almost certainly a bug.
              * bindings/objc/objc_runtime.mm:
              (ObjcFallbackObjectImp::ObjcFallbackObjectImp):
              * bindings/runtime.cpp:
              (KJS::Bindings::Instance::Instance):
              (KJS::Bindings::Instance::createBindingForLanguageInstance):
              (KJS::Bindings::Instance::createRuntimeObject):
              * bindings/runtime.h:
              (KJS::Bindings::Instance::ref):
              (KJS::Bindings::Instance::deref):
              * bindings/runtime_object.cpp:
              (RuntimeObjectImp::RuntimeObjectImp):
              (RuntimeObjectImp::fallbackObjectGetter):
              (RuntimeObjectImp::fieldGetter):
              (RuntimeObjectImp::methodGetter):
              (RuntimeObjectImp::getOwnPropertySlot):
              (RuntimeObjectImp::put):
              (RuntimeObjectImp::canPut):
              * bindings/runtime_object.h: 
              - Removed ownsInstance data member because RefPtr takes care of 
              instance lifetime now. 
              - Prohibited copying because that would muss the ref count.
              - Prohibited construction without instance because an instance wrapper
              without an instance is almost certainly a bug.
              (KJS::RuntimeObjectImp::getInternalInstance):
      
      LayoutTests:
      
              Reviewed by Eric.
      
              - Layout test for <rdar://problem/4176077> CrashTracer: 6569
              crashes in DashboardClient at com.apple.JavaScriptCore:
              KJS::Bindings::ObjcFallbackObjectImp::type()
      
              * plugins: Added.
              * plugins/undefined-property-crash-expected.txt: Added.
              * plugins/undefined-property-crash.html: Added.
      
      WebCore:
      
              Reviewed by Maciej, Eric.
      
              - WebCore half of fix for <rdar://problem/4176077> CrashTracer: 6569 
              crashes in DashboardClient at com.apple.JavaScriptCore: 
              KJS::Bindings::ObjcFallbackObjectImp::type() 
      
              WebCore and JavaScriptCore weren't sharing Instance objects very
              nicely. I made them use RefPtrs, and sent them to bed without dessert.
      
              * khtml/html/html_objectimpl.cpp: 
              (WebCore::HTMLAppletElementImpl::HTMLAppletElementImpl): Made 
              appletInstance a RefPtr
              (WebCore::HTMLAppletElementImpl::getAppletInstance):
              (WebCore::HTMLAppletElementImpl::detach):
              (WebCore::HTMLEmbedElementImpl::HTMLEmbedElementImpl): Made
              embedInstance a RefPtr
              (WebCore::HTMLEmbedElementImpl::getEmbedInstance):
              (WebCore::HTMLEmbedElementImpl::detach):
              (WebCore::HTMLObjectElementImpl::HTMLObjectElementImpl): Made
              objectInstance a RefPtr
              (WebCore::HTMLObjectElementImpl::getObjectInstance): 
              (WebCore::HTMLObjectElementImpl::detach):
              * bindings/js/JSDOMCore.cpp:
              * khtml/ecma/kjs_dom.cpp:
              (KJS::getRuntimeObject):
              * khtml/html/html_objectimpl.h:
      
      WebKitTools:
      
              Reviewed by Eric.
      
              * DumpRenderTree/DumpRenderTree.m:
              (-[LayoutTestController invokeUndefinedMethodFromWebScript:withArguments:]): 
              Added a dummy method for the sake of LayoutTests/plugins/
              undefined-property-crash.html. (It tests a crash due to fallback 
              object use. WebCore won't create a fallback object if the method is 
              not defined.)
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@12840 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      cd217c5d
    • thatcher's avatar
      Reviewed by Tim H. · 384f9ae1
      thatcher authored
              Updated the site to use the new layout.
      
              * .htaccess: Added.
              * ChangeLog:
              * blog/wp-content/themes/classic: Removed.
              * blog/wp-content/themes/classic/comments-popup.php: Removed.
              * blog/wp-content/themes/classic/comments.php: Removed.
              * blog/wp-content/themes/classic/footer.php: Removed.
              * blog/wp-content/themes/classic/header.php: Removed.
              * blog/wp-content/themes/classic/index.php: Removed.
              * blog/wp-content/themes/classic/sidebar.php: Removed.
              * blog/wp-content/themes/classic/style.css: Removed.
              * blog/wp-content/themes/default: Removed.
              * blog/wp-content/themes/default/404.php: Removed.
              * blog/wp-content/themes/default/archive.php: Removed.
              * blog/wp-content/themes/default/archives.php: Removed.
              * blog/wp-content/themes/default/comments-popup.php: Removed.
              * blog/wp-content/themes/default/comments.php: Removed.
              * blog/wp-content/them...
      384f9ae1
    • eseidel's avatar
      2006-02-15 Eric Seidel <eseidel@apple.com> · a3301e83
      eseidel authored
              
              Add files missing from previous commit.
              
              * svg/custom/feDisplacementMap-01-expected.checksum: Added.
              * svg/custom/feDisplacementMap-01-expected.png: Added.
              * svg/custom/feDisplacementMap-01-expected.txt: Added.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@12838 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      a3301e83
    • ggaren's avatar
      Reviewed by Eric. · 05911199
      ggaren authored
              - Fixed http://bugzilla.opendarwin.org/show_bug.cgi?id=4674
              LEAK: WheelEventImpl leaked when mousewheel used
      
              No test case because it requires manual mouse wheeling.
      
              * dom/NodeImpl.cpp:
              (WebCore::NodeImpl::dispatchWheelEvent): Use a RefPtr instead of just
              leaking the WheelEventImpl.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@12837 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      05911199