GitLab

        Reviewed by James Robinson.

        new-run-webkit-tests ignores trailing EOL differences in text tests
        https://bugs.webkit.org/show_bug.cgi?id=36983

        Changed the handling of new-line characters within new-run-webkit-tests
        to match old-run-webkit-tests.  Differences in leading and trailing empty
        lines in text expectation files are no longer ignored.

        * Scripts/webkitpy/layout_tests/port/base.py:
        * Scripts/webkitpy/layout_tests/port/test.py:
        Added unit tests.  Removed old duplicate unit test entries.
        * Scripts/webkitpy/layout_tests/test_types/text_diff.py:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@74362 268f45cc-cd09-0410-ab3c-d52691b4dbfc

https://bugs.webkit.org/show_bug.cgi?id=49861

Reviewed by Simon Fraser.

.: 

* DerivedSources.pro:
* GNUmakefile.am:
* MakeFile:
* MakeFile.shared:
* Tools: Renamed from WebKitTools.
* WebKit.pro:
* cmake/WebKitPackaging.cmake:
* wscript:

BugsSite: 

* PrettyPatch/PrettyPatch.rb:
* committers-autocomplete.js:

Tools: 

* BuildSlaveSupport/build.webkit.org-config/master.cfg:
* CodeCoverage/README:
* DumpRenderTree/qt/DumpRenderTreeQt.cpp:
(WebCore::DumpRenderTree::initializeFonts):
* EWSTools/start-commit-queue.sh:
* EWSTools/start-queue.sh:
* GNUmakefile.am:
* MIDLWrapper/MIDLWrapper.cpp:
(wmain):
* MiniBrowser/qt/MiniBrowser.pro:
* Scripts/build-api-tests:
* Scripts/build-dumprendertree:
* Scripts/build-webkit:
* Scripts/build-webkittestrunner:
* Scripts/generate-coverage-data:
* Scripts/old-run-webkit-tests:
* Scripts/run-api-tests:
* Scripts/run-iexploder-tests:
* Scripts/run-javascriptcore-tests:
* Scripts/run-mangleme-tests:
* Scripts/run-sunspider:
* Scripts/run-webkit-...

        Unreviewed, rolling out r74136.
        http://trac.webkit.org/changeset/74136
        https://bugs.webkit.org/show_bug.cgi?id=51135

        r74136 breaks chromium canary bots because some tests are not
        rebaselined correctly to resolve EOL differences (Requested by
        jianli on #webkit).

        * Scripts/webkitpy/layout_tests/port/base.py:
        * Scripts/webkitpy/layout_tests/port/test.py:
        * Scripts/webkitpy/layout_tests/test_types/text_diff.py:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@74163 268f45cc-cd09-0410-ab3c-d52691b4dbfc

        Reviewed by James Robinson.

        new-run-webkit-tests ignores trailing EOL differences in text tests
        https://bugs.webkit.org/show_bug.cgi?id=36983

        Changed the handling of new-line characters within new-run-webkit-tests
        to match old-run-webkit-tests.  Differences in leading and trailing empty
        lines in text expectation files are no longer ignored.

        * Scripts/webkitpy/layout_tests/port/base.py:
        * Scripts/webkitpy/layout_tests/port/test.py:
        Added unit tests.  Removed old duplicate unit test entries.
        * Scripts/webkitpy/layout_tests/test_types/text_diff.py:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@74136 268f45cc-cd09-0410-ab3c-d52691b4dbfc

        Unreviewed, rolling out r73222.
        http://trac.webkit.org/changeset/73222
        https://bugs.webkit.org/show_bug.cgi?id=50449

        r73211 seemed to break Chromium's "Webkit Win (dbg)(2)" bot.
        (Requested by yutak on #webkit).

        * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
        * Scripts/webkitpy/layout_tests/layout_package/message_broker.py:
        * Scripts/webkitpy/layout_tests/layout_package/message_broker_unittest.py:
        * Scripts/webkitpy/layout_tests/port/base.py:
        * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
        * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@73259 268f45cc-cd09-0410-ab3c-d52691b4dbfc

        Fix Qt build.

        * WebKitTestRunner/qt/PlatformWebViewQt.cpp:
        (WTR::PlatformWebView::PlatformWebView):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@73222 268f45cc-cd09-0410-ab3c-d52691b4dbfc

        Reviewed by Tony Chang.

        config.webkit_base_dir returns a path with a trailing slash
        https://bugs.webkit.org/show_bug.cgi?id=50197

        config.webkit_base_dir() should return a path without a trailing slash,
        like all the other methods that return paths.

        Undoes MockFileSytem changes by r72640, since they're no longer
        necessary for GetBaselinesTest to pass.

        * Scripts/webkitpy/common/system/filesystem_mock.py:
        * Scripts/webkitpy/layout_tests/port/base.py:
        * Scripts/webkitpy/layout_tests/port/config.py:
        * Scripts/webkitpy/layout_tests/port/config_unittest.py:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@72940 268f45cc-cd09-0410-ab3c-d52691b4dbfc

        Reviewed by Tony Chang.

        nrwt - clean up create_driver interface and print out the
        command line used for DumpRenderTree/TestShell.

        This patch adds a driver_cmd_line() call to the Port class in
        order to retrive the command line to print it out (as part of
        --print config).

        In addition, this patch cleans up the Port.create_driver()
        signature and the Driver constructor interface to take a worker
        number and no longer require the image_path argument (Chromium's
        drivers now synthesize the image_path from the worker number
        internally).

        https://bugs.webkit.org/show_bug.cgi?id=49934

        * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
        * Scripts/webkitpy/layout_tests/layout_package/printing.py:
        * Scripts/webkitpy/layout_tests/layout_package/printing_unittest.py:
        * Scripts/webkitpy/layout_tests/port/base.py:
        * Scripts/webkitpy/layout_tests/port/base_unittest.py:
        * Scripts/webkitpy/layout_tests/port/chromium.py:
        * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
        * Scripts/webkitpy/layout_tests/port/dryrun.py:
        * Scripts/webkitpy/layout_tests/port/port_testcase.py:
        * Scripts/webkitpy/layout_tests/port/test.py:
        * Scripts/webkitpy/layout_tests/port/webkit.py:
        * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
        * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@72708 268f45cc-cd09-0410-ab3c-d52691b4dbfc

        Reviewed by Shinichiro Hamaji.

        Simplify Driver.run_test() so that it takes only one parameter, TestInput.

        https://bugs.webkit.org/show_bug.cgi?id=49812

        * Scripts/webkitpy/layout_tests/driver_test.py:
        * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
        * Scripts/webkitpy/layout_tests/port/base.py:
        * Scripts/webkitpy/layout_tests/port/base_unittest.py:
        * Scripts/webkitpy/layout_tests/port/chromium.py:
        * Scripts/webkitpy/layout_tests/port/dryrun.py:
        * Scripts/webkitpy/layout_tests/port/test.py:
        * Scripts/webkitpy/layout_tests/port/webkit.py:
        * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
        * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@72551 268f45cc-cd09-0410-ab3c-d52691b4dbfc

        Refactor TestTypeBase.compare_output().

        Introduce a TestOutput class and update compare_output() of each test
        types so that they can take both actual and expected TestOutput objects.

        https://bugs.webkit.org/show_bug.cgi?id=49431

        * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
        * Scripts/webkitpy/layout_tests/layout_package/test_output.py: Added.
        * Scripts/webkitpy/layout_tests/port/base.py:
        * Scripts/webkitpy/layout_tests/port/chromium.py:
        * Scripts/webkitpy/layout_tests/port/dryrun.py:
        * Scripts/webkitpy/layout_tests/port/test.py:
        * Scripts/webkitpy/layout_tests/port/webkit.py:
        * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
        * Scripts/webkitpy/layout_tests/test_types/image_diff.py:
        * Scripts/webkitpy/layout_tests/test_types/test_type_base.py:
        * Scripts/webkitpy/layout_tests/test_types/text_diff.py:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@72249 268f45cc-cd09-0410-ab3c-d52691b4dbfc

        Reviewed by Eric Seidel.

        Fix the webkit_base_dir logic in webkitpy/layout_tests/port/config.py.
        It turns out that NRWT can't use the code in scm.find_checkout_root()
        because the Chromium bots don't do full checkouts of the WebKit
        tree; they only check out subdirectories like WebKitTools/Scripts.
        Until we can figure out a better approach for this, I've
        restored the base_dir-detecting code from NRWT, which works in
        any directory tree, scm or no.

        This also restores the files modified in r71475 and r71474.

        https://bugs.webkit.org/show_bug.cgi?id=49151

        * WebKitTools/Scripts/webkitpy/layout_tests/port/config.py
        * WebKitTools/Scripts/webkitpy/layout_tests/port/config_unittest.py

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@71580 268f45cc-cd09-0410-ab3c-d52691b4dbfc

        Unreviewed, rolling out r71474.
        http://trac.webkit.org/changeset/71474
        https://bugs.webkit.org/show_bug.cgi?id=48280

        breaks chromium webkit tests
        https://bugs.webkit.org/show_bug.cgi?id=49151

        * Scripts/webkitpy/layout_tests/port/base.py:
        * Scripts/webkitpy/layout_tests/port/base_unittest.py:
        * Scripts/webkitpy/layout_tests/port/config.py:
        * Scripts/webkitpy/layout_tests/port/config_unittest.py:
        * Scripts/webkitpy/layout_tests/port/google_chrome_unittest.py:
        * Scripts/webkitpy/layout_tests/port/webkit.py:
        * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
        * Scripts/webkitpy/tool/mocktool.py:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@71491 268f45cc-cd09-0410-ab3c-d52691b4dbfc

        Reviewed by Eric Siedel.

        new-run-webkit-tests: update port/base and port/webkit to use the
        new FileSystem and Config abstractions, pulling more logic out of
        the base Port classes into separate, mockable objects.

        Also create a MockFileSystem object, a MockConfig object, move
        MockExecutive into common/system to be next to executive, and
        update the config object to use a FileSystem.

        https://bugs.webkit.org/show_bug.cgi?id=48280

        * Scripts/webkitpy/common/newstringio.py: Added.
        * Scripts/webkitpy/common/newstringio_unittest.py: Added.
        * Scripts/webkitpy/common/system/executive_mock.py: Added.
        * Scripts/webkitpy/common/system/filesystem_mock.py: Added.
        * Scripts/webkitpy/layout_tests/port/base.py:
        * Scripts/webkitpy/layout_tests/port/base_unittest.py:
        * Scripts/webkitpy/layout_tests/port/config.py:
        * Scripts/webkitpy/layout_tests/port/config_mock.py:
        * Scripts/webkitpy/layout_tests/port/config_unittest.py:
        * Scripts/webkitpy/layout_tests/port/google_chrome_unittest.py:
        * Scripts/webkitpy/layout_tests/port/webkit.py:
        * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
        * Scripts/webkitpy/tool/mocktool.py:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@71474 268f45cc-cd09-0410-ab3c-d52691b4dbfc

        Reviewed by Adam Barth.

        build-webkit spams system.log by repeatedly checking for PBXProductDirectory in com.apple.Xcode
        https://bugs.webkit.org/show_bug.cgi?id=49051

        This is a speculative fix.  The unit tests cover these methods, however
        I don't know if this will fully stop the system.log spam.

        * Scripts/webkitpy/layout_tests/port/base.py:
        * Scripts/webkitpy/layout_tests/port/webkit.py:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@71398 268f45cc-cd09-0410-ab3c-d52691b4dbfc

        Reviewed by Eric Seidel.

        new-run-webkit-tests produces corrupt PNG baselines on Windows
        https://bugs.webkit.org/show_bug.cgi?id=47867

        * Scripts/webkitpy/layout_tests/port/base.py:


git-svn-id: http://svn.webkit.org/repository/webkit/trunk@70017 268f45cc-cd09-0410-ab3c-d52691b4dbfc

        Reviewed by Eric Siedel.

        new-run-webkit-tests: clean up the options-parsing code in the port
        classes.

        This change modifies the Port interface to have a get_option() and
        set_option_default() method for accessing the options argument
        passed to the constructor. If the constructor is not passed an
        options argument, we default to a MockOptions() argument from
        mocktool, which has the same semantics we want.

        Note that there is a disadvantage to port.get_option('foo') over
        port._options.foo, which is that you lose some of the checking
        for whether 'foo' is set (typos result in the default value, not
        an exception being raised. This is desired in this case, since the
        Port class is not allowed to assume that options does have any
        particular values set, and so this change ensures that all of
        the subclasses are following the same, intended, logic.

        Arguably this is the wrong semantics to have, and the Port
        classes should be able to assume a default set of
        attributes/arguments, but that change will need to wait for a
        different CL where we can modify new-run-webkit-tests to pull a
        list of arguments from the port factory routines.

        Also, add unit tests for webkitpy.tool.mocktool.MockOptions .

        https://bugs.webkit.org/show_bug.cgi?id=47510

        * Scripts/webkitpy/layout_tests/port/base.py:
        * Scripts/webkitpy/layout_tests/port/base_unittest.py:
        * Scripts/webkitpy/layout_tests/port/chromium.py:
        * Scripts/webkitpy/layout_tests/port/chromium_gpu_unittest.py:
        * Scripts/webkitpy/layout_tests/port/chromium_linux.py:
        * Scripts/webkitpy/layout_tests/port/chromium_mac.py:
        * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
        * Scripts/webkitpy/layout_tests/port/chromium_win.py:
        * Scripts/webkitpy/layout_tests/port/dryrun.py:
        * Scripts/webkitpy/layout_tests/port/factory_unittest.py:
        * Scripts/webkitpy/layout_tests/port/mac_unittest.py:
        * Scripts/webkitpy/layout_tests/port/port_testcase.py:
        * Scripts/webkitpy/layout_tests/port/test.py:
        * Scripts/webkitpy/layout_tests/port/webkit.py:
        * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests_unittest.py:
        * Scripts/webkitpy/tool/mocktool_unittest.py: Added.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@70013 268f45cc-cd09-0410-ab3c-d52691b4dbfc

        Reviewed by Eric Seidel.

        Re-submit a revised version of r69638 - enabling new-run-webkit-tests
        under cygwin. The initial version had a bug in base:uri_to_test_name
        that was causing tests to fail. This version corrects that bug, but
        also makes the code safer by calling cygpath more reliably, and
        leaving a long-running cygpath process open.

        This patch also corrects a couple of minor bugs in http_lock_unittest,
        chromium_unittest, and dedpulicate_tests_unittest that showed up
        while testing this.

        https://bugs.webkit.org/show_bug.cgi?id=47220

        * Scripts/webkitpy/common/system/path.py:
        * Scripts/webkitpy/common/system/path_unittest.py:
        * Scripts/webkitpy/layout_tests/deduplicate_tests_unittest.py:
        * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
        * Scripts/webkitpy/layout_tests/port/base.py:
        * Scripts/webkitpy/layout_tests/port/base_unittest.py:
        * Scripts/webkitpy/layout_tests/port/chromium.py:
        * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
        * Scripts/webkitpy/layout_tests/port/http_lock_unittest.py:
        * Scripts/webkitpy/layout_tests/run_webkit_tests.py:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@70012 268f45cc-cd09-0410-ab3c-d52691b4dbfc

        Reviewed by Eric Seidel.

        new-run-webkit-tests will now handle missing Ruby installs (or
        missing PrettyPatch scripts) more cleanly - previously this
        would be detected when we actually tried to create the diff, and
        the error message was obscure. Now we'll log a warning up front
        and otherwise be silent.

        This change also refactors some global variables to be class or
        instance variables to be slightly more testable and more
        modular. There are no cases where we create lots of port objects
        and can't afford to test for configurations repeatedly, so
        there's no performance concern here.

        https://bugs.webkit.org/show_bug.cgi?id=47466

        * Scripts/webkitpy/layout_tests/port/base.py:
        * Scripts/webkitpy/layout_tests/port/base_unittest.py:
        * Scripts/webkitpy/layout_tests/port/chromium.py:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@69820 268f45cc-cd09-0410-ab3c-d52691b4dbfc

        Unreviewed, rolling out r69638.
        http://trac.webkit.org/changeset/69638
        https://bugs.webkit.org/show_bug.cgi?id=47595

        "Broke win and chromium-win bots" (Requested by dglazkov on
        #webkit).

        * Scripts/webkitpy/common/system/path.py:
        * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
        * Scripts/webkitpy/layout_tests/port/base.py:
        * Scripts/webkitpy/layout_tests/port/base_unittest.py:
        * Scripts/webkitpy/layout_tests/port/chromium.py:
        * Scripts/webkitpy/layout_tests/run_webkit_tests.py:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@69674 268f45cc-cd09-0410-ab3c-d52691b4dbfc

        Reviewed by Eric Seidel.

        This patch enables new-run-webkit-tests (in particular the
        chromium-win port) to run under Cygwin as well as Win32. Mostly
        this just required some conversions from cygwin paths to Win32
        paths when we spawn off Win32 binaries like test_shell.

        https://bugs.webkit.org/show_bug.cgi?id=47220

        * Scripts/webkitpy/common/system/path.py:
        - Expose the cygpath() function for path conversion

        * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
        * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
        - shift filename->uri conversion in the TestInfo objects to the
          dump_render_tree thread

        * Scripts/webkitpy/layout_tests/port/base.py:
        * Scripts/webkitpy/layout_tests/port/chromium.py:
        - use cygpath()

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@69638 268f45cc-cd09-0410-ab3c-d52691b4dbfc

https://bugs.webkit.org/show_bug.cgi?id=47072

Patch by Gabor Rapcsanyi <rgabor@inf.u-szeged.hu> on 2010-10-12
Reviewed by Tony Chang.

* Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
* Scripts/webkitpy/layout_tests/port/base.py:
* Scripts/webkitpy/layout_tests/port/http_lock.py: Added.
* Scripts/webkitpy/layout_tests/port/http_lock_unittest.py: Added.
* Scripts/webkitpy/layout_tests/run_webkit_tests.py:



git-svn-id: http://svn.webkit.org/repository/webkit/trunk@69578 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Linux having similar SVG failures to windows. Revision r69226 added
http/tests/appcache/main-resource-redirect.html which does not work
on chromium yet.

* platform/chromium-linux/fast/blockflow/fieldsets-expected.checksum: Added.
* platform/chromium-linux/fast/blockflow/fieldsets-expected.png: Added.
* platform/chromium-linux/svg/filters/feDisplacementMap-expected.checksum: Copied from LayoutTests/platform/chromium-win/svg/filters/feDisplacementMap-expected.checksum.
* platform/chromium-linux/svg/filters/feDisplacementMap-expected.png: Copied from LayoutTests/platform/chromium-win/svg/filters/feDisplacementMap-expected.png.
* platform/chromium-win/fast/blockflow/fieldsets-expected.checksum: Added.
* platform/chromium-win/fast/blockflow/fieldsets-expected.png: Added.
* platform/chromium-win/fast/blockflow/fieldsets-expected.txt: Added.
* platform/chromium/test_expectations.txt:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@69241 268f45cc-cd09-0410-ab3c-d52691b4dbfc

        Reviewed by Ojan Vafai.

        [chromium] fix image diffing in NRWT
        https://bugs.webkit.org/show_bug.cgi?id=47128

        * Scripts/webkitpy/layout_tests/port/chromium.py: Stop using
            NamedTemporaryFile since it doesn't work on Windows.
        * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@69153 268f45cc-cd09-0410-ab3c-d52691b4dbfc

        Reviewed by Adam Barth.

        aroben's change in r68792 actually broke new-run-webkit-tests when
        running the DRT code path. His change was intended to fix the
        way we were converting windows paths to URIs when running under
        Cygwin (the paths were getting one too many "/" on the front).
        However, the change ended up breaking the chromium_win port, which
        had slightly different logic.

        This patch removes the port-specific code and adds tests to make
        sure we're getting the behavior we expect. The Port object no longer
        exposes a get_absolute_path() method that can be used outside of
        of converting test filenames, because it's unreliable otherwise
        (we don't have the right context to know which conversion is intended).

        https://bugs.webkit.org/show_bug.cgi?id=47140

        * Scripts/webkitpy/layout_tests/port/base.py:
        * Scripts/webkitpy/layout_tests/port/base_unittest.py:
        * Scripts/webkitpy/layout_tests/port/chromium_win.py:
        * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
        * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@69065 268f45cc-cd09-0410-ab3c-d52691b4dbfc

        Reviewed by Eric Seidel.

        WebSocket tests are flaky
        https://bugs.webkit.org/show_bug.cgi?id=46956

        Hosting the WebSocket tests using the Python HTTP server causes the
        tests to time out occationally.  This patch moves the tests to be
        hosted by the usual Apache server.

        This patch doesn't completely eliminate the flakiness.  However,
        testing on my local machine shows that it reduces it by a large factor.
        I suspect there's more flakiness hiding in the Python server, but this
        patch makes some amount of progress on the issue.

        * http/tests/websocket: Copied from LayoutTests/websocket.
        * http/tests/websocket/tests/alert-in-event-handler.html:
        * http/tests/websocket/tests/bad-handshake-crash.html:
        * http/tests/websocket/tests/bad-sub-protocol-control-chars.html:
        * http/tests/websocket/tests/bad-sub-protocol-empty.html:
        * http/tests/websocket/tests/bad-sub-protocol-non-ascii.html:
        * http/tests/websocket/tests/bufferedAmount-after-close.html:
        * http/tests/websocket/tests/close-on-navigate-new-location.html:
        * http/tests/websocket/tests/close-on-unload-and-force-gc.html:
        * http/tests/websocket/tests/close-on-unload-reference-in-parent.html:
        * http/tests/websocket/tests/close-on-unload.html:
        * http/tests/websocket/tests/cross-origin-expected.txt:
        * http/tests/websocket/tests/cross-origin.html:
        * http/tests/websocket/tests/error-detect.html:
        * http/tests/websocket/tests/frame-length-longer-than-buffer.html:
        * http/tests/websocket/tests/frame-length-overflow.html:
        * http/tests/websocket/tests/frame-length-skip.html:
        * http/tests/websocket/tests/handshake-challenge-randomness.html:
        * http/tests/websocket/tests/handshake-error.html:
        * http/tests/websocket/tests/handshake-fail-by-cross-origin-expected.txt:
        * http/tests/websocket/tests/handshake-fail-by-cross-origin.html:
        * http/tests/websocket/tests/handshake-fail-by-no-cr.html:
        * http/tests/websocket/tests/handshake-fail-by-sub-protocol-mismatch.html:
        * http/tests/websocket/tests/httponly-cookie.pl:
        * http/tests/websocket/tests/long-invalid-header.html:
        * http/tests/websocket/tests/null-character.html:
        * http/tests/websocket/tests/reload-crash.html:
        * http/tests/websocket/tests/resources/close-on-unload-iframe-reference-in-parent.html:
        * http/tests/websocket/tests/resources/close-on-unload-iframe.html:
        * http/tests/websocket/tests/resources/js-test-post-function.js: Copied from LayoutTests/fast/js/resources/js-test-post-function.js.
        * http/tests/websocket/tests/resources/js-test-pre.js: Copied from LayoutTests/fast/js/resources/js-test-pre.js.
        * http/tests/websocket/tests/resources/js-test-style.css: Copied from LayoutTests/fast/js/resources/js-test-style.css.
        * http/tests/websocket/tests/resources/reload-crash-iframe.html:
        * http/tests/websocket/tests/script-tests/TEMPLATE.html:
        * http/tests/websocket/tests/script-tests/cross-origin.js:
        (endTest):
        * http/tests/websocket/tests/send-after-close-on-unload.html:
        * http/tests/websocket/tests/send-throw.html:
        * http/tests/websocket/tests/send.html:
        * http/tests/websocket/tests/simple.html:
        * http/tests/websocket/tests/sub-protocol-with-space.html:
        * http/tests/websocket/tests/sub-protocol.html:
        * http/tests/websocket/tests/unicode.html:
        * http/tests/websocket/tests/url-no-trailing-slash.html:
        * http/tests/websocket/tests/url-parsing-expected.txt:
        * http/tests/websocket/tests/url-parsing.html:
        * http/tests/websocket/tests/url-with-credential.html:
        * http/tests/websocket/tests/url-with-empty-query.html:
        * http/tests/websocket/tests/url-with-query-for-no-query.html:
        * http/tests/websocket/tests/url-with-query.html:
        * http/tests/websocket/tests/websocket-event-target.html:
        * http/tests/websocket/tests/websocket-protocol-ignored.html:
        * platform/chromium-gpu/test_expectations.txt:
        * platform/chromium/test_expectations.txt:
        * platform/mac/test_expectations.txt:
        * platform/win/Skipped:
        * websocket: Removed.
        * websocket/resources: Removed.
        * websocket/resources/server-failed-to-start.html: Removed.
        * websocket/tests: Removed.
        * websocket/tests/alert-in-event-handler-expected.txt: Removed.
        * websocket/tests/alert-in-event-handler.html: Removed.
        * websocket/tests/bad-handshake-crash-expected.txt: Removed.
        * websocket/tests/bad-handshake-crash.html: Removed.
        * websocket/tests/bad-handshake-crash_wsh.py: Removed.
        * websocket/tests/bad-sub-protocol-control-chars-expected.txt: Removed.
        * websocket/tests/bad-sub-protocol-control-chars.html: Removed.
        * websocket/tests/bad-sub-protocol-empty-expected.txt: Removed.
        * websocket/tests/bad-sub-protocol-empty.html: Removed.
        * websocket/tests/bad-sub-protocol-non-ascii-expected.txt: Removed.
        * websocket/tests/bad-sub-protocol-non-ascii.html: Removed.
        * websocket/tests/bufferedAmount-after-close-expected.txt: Removed.
        * websocket/tests/bufferedAmount-after-close.html: Removed.
        * websocket/tests/close-on-navigate-new-location-expected.txt: Removed.
        * websocket/tests/close-on-navigate-new-location.html: Removed.
        * websocket/tests/close-on-unload-and-force-gc-expected.txt: Removed.
        * websocket/tests/close-on-unload-and-force-gc.html: Removed.
        * websocket/tests/close-on-unload-expected.txt: Removed.
        * websocket/tests/close-on-unload-reference-in-parent-expected.txt: Removed.
        * websocket/tests/close-on-unload-reference-in-parent.html: Removed.
        * websocket/tests/close-on-unload.html: Removed.
        * websocket/tests/close-on-unload_wsh.py: Removed.
        * websocket/tests/cross-origin-expected.txt: Removed.
        * websocket/tests/cross-origin.html: Removed.
        * websocket/tests/echo-challenge_wsh.py: Removed.
        * websocket/tests/echo-cookie_wsh.py: Removed.
        * websocket/tests/echo-location_wsh.py: Removed.
        * websocket/tests/echo_wsh.py: Removed.
        * websocket/tests/error-detect-expected.txt: Removed.
        * websocket/tests/error-detect.html: Removed.
        * websocket/tests/fixed-origin_wsh.py: Removed.
        * websocket/tests/frame-length-longer-than-buffer-expected.txt: Removed.
        * websocket/tests/frame-length-longer-than-buffer.html: Removed.
        * websocket/tests/frame-length-longer-than-buffer_wsh.py: Removed.
        * websocket/tests/frame-length-overflow-expected.txt: Removed.
        * websocket/tests/frame-length-overflow.html: Removed.
        * websocket/tests/frame-length-overflow_wsh.py: Removed.
        * websocket/tests/frame-length-skip-expected.txt: Removed.
        * websocket/tests/frame-length-skip.html: Removed.
        * websocket/tests/frame-length-skip_wsh.py: Removed.
        * websocket/tests/frame-lengths-expected.txt: Removed.
        * websocket/tests/frame-lengths.html: Removed.
        * websocket/tests/handler_map.txt: Removed.
        * websocket/tests/handshake-challenge-randomness-expected.txt: Removed.
        * websocket/tests/handshake-challenge-randomness.html: Removed.
        * websocket/tests/handshake-error-expected.txt: Removed.
        * websocket/tests/handshake-error.html: Removed.
        * websocket/tests/handshake-error_wsh.py: Removed.
        * websocket/tests/handshake-fail-by-cross-origin-expected.txt: Removed.
        * websocket/tests/handshake-fail-by-cross-origin.html: Removed.
        * websocket/tests/handshake-fail-by-no-cr-expected.txt: Removed.
        * websocket/tests/handshake-fail-by-no-cr.html: Removed.
        * websocket/tests/handshake-fail-by-no-cr_wsh.py: Removed.
        * websocket/tests/handshake-fail-by-sub-protocol-mismatch-expected.txt: Removed.
        * websocket/tests/handshake-fail-by-sub-protocol-mismatch.html: Removed.
        * websocket/tests/httponly-cookie-expected.txt: Removed.
        * websocket/tests/httponly-cookie.pl: Removed.
        * websocket/tests/long-invalid-header-expected.txt: Removed.
        * websocket/tests/long-invalid-header.html: Removed.
        * websocket/tests/long-invalid-header_wsh.py: Removed.
        * websocket/tests/multiple-connections-expected.txt: Removed.
        * websocket/tests/multiple-connections.html: Removed.
        * websocket/tests/no-query_wsh.py: Removed.
        * websocket/tests/null-character-expected.txt: Removed.
        * websocket/tests/null-character.html: Removed.
        * websocket/tests/origin-test_wsh.py: Removed.
        * websocket/tests/protocol-test_wsh.py: Removed.
        * websocket/tests/reload-crash-expected.txt: Removed.
        * websocket/tests/reload-crash.html: Removed.
        * websocket/tests/resources: Removed.
        * websocket/tests/resources/close-on-unload-iframe-reference-in-parent.html: Removed.
        * websocket/tests/resources/close-on-unload-iframe.html: Removed.
        * websocket/tests/resources/reload-crash-iframe.html: Removed.
        * websocket/tests/script-tests: Removed.
        * websocket/tests/script-tests/TEMPLATE.html: Removed.
        * websocket/tests/script-tests/alert-in-event-handler.js: Removed.
        * websocket/tests/script-tests/bad-handshake-crash.js: Removed.
        * websocket/tests/script-tests/bad-sub-protocol-control-chars.js: Removed.
        * websocket/tests/script-tests/bad-sub-protocol-empty.js: Removed.
        * websocket/tests/script-tests/bad-sub-protocol-non-ascii.js: Removed.
        * websocket/tests/script-tests/bufferedAmount-after-close.js: Removed.
        * websocket/tests/script-tests/cross-origin.js: Removed.
        * websocket/tests/script-tests/error-detect.js: Removed.
        * websocket/tests/script-tests/frame-length-longer-than-buffer.js: Removed.
        * websocket/tests/script-tests/frame-length-skip.js: Removed.
        * websocket/tests/script-tests/handshake-challenge-randomness.js: Removed.
        * websocket/tests/script-tests/handshake-error.js: Removed.
        * websocket/tests/script-tests/handshake-fail-by-cross-origin.js: Removed.
        * websocket/tests/script-tests/handshake-fail-by-no-cr.js: Removed.
        * websocket/tests/script-tests/handshake-fail-by-sub-protocol-mismatch.js: Removed.
        * websocket/tests/script-tests/long-invalid-header.js: Removed.
        * websocket/tests/script-tests/null-character.js: Removed.
        * websocket/tests/script-tests/send-throw.js: Removed.
        * websocket/tests/script-tests/send.js: Removed.
        * websocket/tests/script-tests/simple.js: Removed.
        * websocket/tests/script-tests/sub-protocol-with-space.js: Removed.
        * websocket/tests/script-tests/sub-protocol.js: Removed.
        * websocket/tests/script-tests/unicode.js: Removed.
        * websocket/tests/script-tests/url-no-trailing-slash.js: Removed.
        * websocket/tests/script-tests/url-parsing.js: Removed.
        * websocket/tests/script-tests/url-with-credential.js: Removed.
        * websocket/tests/script-tests/url-with-empty-query.js: Removed.
        * websocket/tests/script-tests/url-with-query-for-no-query.js: Removed.
        * websocket/tests/script-tests/url-with-query.js: Removed.
        * websocket/tests/script-tests/websocket-event-target.js: Removed.
        * websocket/tests/script-tests/websocket-protocol-ignored.js: Removed.
        * websocket/tests/send-after-close-on-unload-expected.txt: Removed.
        * websocket/tests/send-after-close-on-unload.html: Removed.
        * websocket/tests/send-expected.txt: Removed.
        * websocket/tests/send-throw-expected.txt: Removed.
        * websocket/tests/send-throw.html: Removed.
        * websocket/tests/send.html: Removed.
        * websocket/tests/send2_wsh.py: Removed.
        * websocket/tests/send_wsh.py: Removed.
        * websocket/tests/simple-expected.txt: Removed.
        * websocket/tests/simple-stress-expected.txt: Removed.
        * websocket/tests/simple-stress.html: Removed.
        * websocket/tests/simple.html: Removed.
        * websocket/tests/simple_wsh.py: Removed.
        * websocket/tests/sub-protocol-expected.txt: Removed.
        * websocket/tests/sub-protocol-with-space-expected.txt: Removed.
        * websocket/tests/sub-protocol-with-space.html: Removed.
        * websocket/tests/sub-protocol.html: Removed.
        * websocket/tests/unicode-expected.txt: Removed.
        * websocket/tests/unicode.html: Removed.
        * websocket/tests/unicode_wsh.py: Removed.
        * websocket/tests/unknown-frame-type_wsh.py: Removed.
        * websocket/tests/url-no-trailing-slash-expected.txt: Removed.
        * websocket/tests/url-no-trailing-slash.html: Removed.
        * websocket/tests/url-parsing-expected.txt: Removed.
        * websocket/tests/url-parsing.html: Removed.
        * websocket/tests/url-with-credential-expected.txt: Removed.
        * websocket/tests/url-with-credential.html: Removed.
        * websocket/tests/url-with-empty-query-expected.txt: Removed.
        * websocket/tests/url-with-empty-query.html: Removed.
        * websocket/tests/url-with-query-expected.txt: Removed.
        * websocket/tests/url-with-query-for-no-query-expected.txt: Removed.
        * websocket/tests/url-with-query-for-no-query.html: Removed.
        * websocket/tests/url-with-query.html: Removed.
        * websocket/tests/websocket-event-target-expected.txt: Removed.
        * websocket/tests/websocket-event-target.html: Removed.
        * websocket/tests/websocket-pending-activity-expected.txt: Removed.
        * websocket/tests/websocket-pending-activity.html: Removed.
        * websocket/tests/websocket-protocol-ignored-expected.txt: Removed.
        * websocket/tests/websocket-protocol-ignored.html: Removed.
        * websocket/tests/workers: Removed.
        * websocket/tests/workers/close-in-onmessage-crash-expected.txt: Removed.
        * websocket/tests/workers/close-in-onmessage-crash.html: Removed.
        * websocket/tests/workers/close-in-shared-worker-expected.txt: Removed.
        * websocket/tests/workers/close-in-shared-worker.html: Removed.
        * websocket/tests/workers/close-in-worker-expected.txt: Removed.
        * websocket/tests/workers/close-in-worker.html: Removed.
        * websocket/tests/workers/resources: Removed.
        * websocket/tests/workers/resources/close-in-onmessage-crash.js: Removed.
        * websocket/tests/workers/resources/close-in-worker.js: Removed.
        * websocket/tests/workers/resources/echo-challenge_wsh.py: Removed.
        * websocket/tests/workers/resources/echo_wsh.py: Removed.
        * websocket/tests/workers/resources/simple_wsh.py: Removed.
        * websocket/tests/workers/resources/worker-handshake-challenge-randomness.js: Removed.
        * websocket/tests/workers/resources/worker-simple.js: Removed.
        * websocket/tests/workers/shared-worker-simple-expected.txt: Removed.
        * websocket/tests/workers/shared-worker-simple.html: Removed.
        * websocket/tests/workers/worker-handshake-challenge-randomness-expected.txt: Removed.
        * websocket/tests/workers/worker-handshake-challenge-randomness.html: Removed.
        * websocket/tests/workers/worker-simple-expected.txt: Removed.
        * websocket/tests/workers/worker-simple.html: Removed.
2010-09-30  Adam Barth  <abarth@webkit.org>

        Reviewed by Eric Seidel.

        WebSocket tests are flaky
        https://bugs.webkit.org/show_bug.cgi?id=46956

        Update these tools to understand how to run the WebSocket tests off the
        Apache server.

        * Scripts/old-run-webkit-tests:
        * Scripts/webkitpy/layout_tests/port/base.py:
        * Scripts/webkitpy/layout_tests/port/websocket_server.py:
        * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:


git-svn-id: http://svn.webkit.org/repository/webkit/trunk@68914 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Reviewed by Adam Barth.

Fixes <http://webkit.org/b/46890> <rdar://problem/8496637> Many tests
in webkitpy.layout_tests.run_webkit_tests_unittest assert on Windows

* Scripts/webkitpy/layout_tests/port/base.py:
(Port.filename_to_uri): Treat Cygwin like other UNIX-y platforms by
assuming paths already have a leading slash.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@68792 268f45cc-cd09-0410-ab3c-d52691b4dbfc

        Reviewed by Ojan Vafai.

        new-run-webkit-httpd fails if Perl is not installed
        https://bugs.webkit.org/show_bug.cgi?id=46602

        Make Port._read_configuration catch all exceptions, since trying to run
        perl (because of _webkit_build_directory) when it's not installed throws
        a WindowsError or OSError, not an IOError (this became an issue after
        r68268, since ChromiumPort ends up calling Port.default_configuration in
        its constructor, which means that we're ending up on this codepath in
        non-NRWT cases too, e.g. for the Chromium NaCl tests, which use
        new-run-webkit-httpd).

        * Scripts/webkitpy/layout_tests/port/base.py:
        * Scripts/webkitpy/layout_tests/port/base_unittest.py:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@68365 268f45cc-cd09-0410-ab3c-d52691b4dbfc

        Reviewed by Adam Barth.

        Modify the Port interface to take only a series of keyword arguments
        in the constructor, and modify Port/factory.get() to accomodate that,
        and to accept user=XXX as an argument so we can pass
        webkitpy.common.system.user.User objects in.

        Then, modify new-run-webkit-tests and rebaseline-chromium-webkit-tests
        to use the common routine in webkitpy.common.system.user.open_url()
        to display HTML files.

        There was a routine in the Port interface to do the same thing,
        but I see no need for a port-specific hook for this, since it is
        something that will always be executed by the host environment
        and displaying web pages has nothing to do with running layout tests.

        Note that new-run-webkit-tests used to use test_shell to display
        the page; this is potentially useful so that you can actually click
        from a result to the broken page; however, since DumpRenderTree
        doesn't support this functionality, it will be going away eventually.

        https://bugs.webkit.org/show_bug.cgi?id=46128

        * Scripts/webkitpy/layout_tests/port/base.py:
        * Scripts/webkitpy/layout_tests/port/base_unittest.py:
        * Scripts/webkitpy/layout_tests/port/chromium.py:
        * Scripts/webkitpy/layout_tests/port/chromium_linux.py:
        * Scripts/webkitpy/layout_tests/port/chromium_mac.py:
        * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
        * Scripts/webkitpy/layout_tests/port/chromium_win.py:
        * Scripts/webkitpy/layout_tests/port/dryrun.py:
        * Scripts/webkitpy/layout_tests/port/factory.py:
        * Scripts/webkitpy/layout_tests/port/google_chrome.py:
        * Scripts/webkitpy/layout_tests/port/google_chrome_unittest.py:
        * Scripts/webkitpy/layout_tests/port/gtk.py:
        * Scripts/webkitpy/layout_tests/port/mac.py:
        * Scripts/webkitpy/layout_tests/port/qt.py:
        * Scripts/webkitpy/layout_tests/port/test.py:
        * Scripts/webkitpy/layout_tests/port/webkit.py:
        * Scripts/webkitpy/layout_tests/port/win.py:
        * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py:
        * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
        * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@68008 268f45cc-cd09-0410-ab3c-d52691b4dbfc

        Reviewed by Ojan Vafai.

        new-run-webkit-tests: pull the list of tests from the Port, and
           make it possible to run with no actual test files in the filesystem.

        This set of changes allows us to delete the special
        webkitpy/layout_tests/data directory and test the generic code without
        touching the filesystem (except to write results). This speeds up
        test-webkitpy substantially.

        This also cleans up and removes several code paths in the generic
        code and fixes some minor bugs, notably in the test_expectations
        parsing, which was previously fragile if the tests weren't present.

        We also change the way we diff image results to be able to do so
        in memory, without relying on files. This slows down chromium
        test_shell, which always writes images to files, but should speed
        up DRT and ImageDiff-based implementations slightly.

        Note that pulling the list of tests to run from the Port will allow
        ports to specify what tests to run as an inclusive list; previously
        you could only do this as an exclusive list by using a
        test_expectations file or Skipped files; nothing actually uses this
        feature yet and it's unclear if it should be used.

        Note that there are no functional changes -- apart from now
        always printing out the location of the checksum file when we are
        tracing test runs -- and the total number of lines of non-test code
        actually drops by two.

        There is some more cleanup that can be done in the Port/Driver
        interface and in some handling of filenames, but I'll save that
        for another change.

        https://bugs.webkit.org/show_bug.cgi?id=45801

        * Scripts/webkitpy/layout_tests/data/*: Removed.
            - no longer need special mock layout_tests_directory in the
              repository.
        * Scripts/webkitpy/layout_tests/layout_package/printing.py:
            - add code to display missing text files, checksums when tracing
            - update to not look at the filesystem directly.
        * Scripts/webkitpy/layout_tests/layout_package/printing_unittest.py:
            - add more unit tests
        * Scripts/webkitpy/layout_tests/layout_package/test_expectations.py:
            - remove tests_are_present flag
            - update with changes in Port interface - no longer access
              the filesystem directly, although we still use os.path for
              filename manipulation.
        * Scripts/webkitpy/layout_tests/layout_package/test_expectations_unittest.py:
            - add more unit tests
        * Scripts/webkitpy/layout_tests/layout_package/test_files.py: Removed.
            - renamed to port/test_files.py
        * Scripts/webkitpy/layout_tests/port/base.py:
            - change diff_image() to expect actual image data, not filenames
            - add expected_checksum(), expected_image(), expected_text() to
              return the content of the files so that we don't need a filesystem
            - add path_exists(), path_isdir() for filesystem-like access.
            - add test_dirs() to keep clobber-test-results from needing to
              actually look at a real layout tests dir
            - add tests() to return the list of tests to run on the port
              (calls port/test_files to do the work).
            - add update_baseline() to be able to save new baselines
            - add uri_to_test_name() from port/dryrun.py so we can easily check
              filename_to_uri()
        * Scripts/webkitpy/layout_tests/port/base_unittest.py:
            - add more unit tests
        * Scripts/webkitpy/layout_tests/port/chromium.py:
            - change diff_image() to accept image content, not filenames.
              This will be slower for test_shell/image_diff, but faster
              for DRT/ImageDiff.
        * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
            - add more unit tests
        * Scripts/webkitpy/layout_tests/port/dryrun.py:
            - simplify greatly
        * Scripts/webkitpy/layout_tests/port/port_testcase.py:
            - add more unit tests
        * Scripts/webkitpy/layout_tests/port/test.py:
            - massive rewrite to use in-script list of tests and expectations
        * Scripts/webkitpy/layout_tests/port/test_files.py:
            - rename from layout_package/test_files.
        * Scripts/webkitpy/layout_tests/port/test_files_unittest.py:
            - add unit tests
        * Scripts/webkitpy/layout_tests/port/webkit.py:
            - update diff_image() to take image contents, not files. Should
              make things slightly faster.
        * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py:
            - update with changes to diff_image()
        * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests_unittest.py:
            - update with changes to diff_image()
        * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
            - remove tests_are_present from test_expectations
            - pull the list of tests from port.tests() instead
              of calling test_files.py directly.
        * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
            - update unit tests
        * Scripts/webkitpy/layout_tests/test_types/image_diff.py:
            - update with changes to
        * Scripts/webkitpy/layout_tests/test_types/test_type_base.py:
            - update with change in Port interface
        * Scripts/webkitpy/layout_tests/test_types/text_diff.py:
            - update with change in Port interface
        * Scripts/webkitpy/style/checkers/test_expectations.py:
            - remove the tests_are_present flag

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@67974 268f45cc-cd09-0410-ab3c-d52691b4dbfc

        Reviewed by Ojan Vafai.

        new-run-webkit-tests: refactor command line args getting passed to DRT

        This change cleans up some argument parsing between functions to get
        rid of some overlapping data structures. There should be no functional
        changes in this patch; it is pure refactoring in preparation for
        landing the Chrome GPU port and adding a generic way to pass
        args to DRT/TestShell.

        https://bugs.webkit.org/show_bug.cgi?id=46135

        * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
          - pass the options argument explicitly to the threads and drivers,
            also consolidate the passing of options to the driver.
          - pass options directly to process_output() to remove a couple
            parameters (minor cleanup).
        * Scripts/webkitpy/layout_tests/port/base.py:
          - pass the options argument to Port.create_driver().
        * Scripts/webkitpy/layout_tests/port/base_unittest.py:
          - update Port.create_driver() test
        * Scripts/webkitpy/layout_tests/port/chromium.py:
          - pass the options argument to Port.create_driver(), and clean up
            building of the cmd line for DRT.
        * Scripts/webkitpy/layout_tests/port/dryrun.py:
          - pass the options argument to Port.create_driver()
        * Scripts/webkitpy/layout_tests/port/test.py:
          - pass the options argument to Port.create_driver()
        * Scripts/webkitpy/layout_tests/port/webkit.py:
          - pass the options argument to Port.create_driver(), and clean up
            building of the cmd line for DRT.
        * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
          - consolidate args in _get_dump_render_tree_args and rename to
            _get_test_args(); move all of the command-line args to the
            Port implementations.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@67905 268f45cc-cd09-0410-ab3c-d52691b4dbfc

* Scripts/webkitpy/layout_tests/port/base.py:
* platform/chromium-mac/fast/repaint/table-cell-move-expected.checksum: Removed.
* platform/chromium-mac/fast/repaint/table-cell-move-expected.png: Removed.
* platform/chromium-mac/fast/repaint/table-extra-bottom-grow-expected.checksum: Removed.
* platform/chromium-mac/fast/repaint/table-extra-bottom-grow-expected.png: Removed.
* platform/chromium-win/fast/repaint/table-cell-move-expected.checksum:
* platform/chromium-win/fast/repaint/table-cell-move-expected.png:
* platform/chromium-win/fast/repaint/table-extra-bottom-grow-expected.checksum:
* platform/chromium-win/fast/repaint/table-extra-bottom-grow-expected.png:
* platform/chromium/test_expectations.txt:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@67897 268f45cc-cd09-0410-ab3c-d52691b4dbfc

* platform/chromium-mac/fast/repaint/table-cell-move-expected.checksum: Added.
* platform/chromium-mac/fast/repaint/table-cell-move-expected.png: Added.
* platform/chromium-mac/fast/repaint/table-extra-bottom-grow-expected.checksum: Added.
* platform/chromium-mac/fast/repaint/table-extra-bottom-grow-expected.png: Added.
* platform/chromium-win/fast/repaint/table-cell-move-expected.checksum:
* platform/chromium-win/fast/repaint/table-cell-move-expected.png:
* platform/chromium-win/fast/repaint/table-extra-bottom-grow-expected.checksum:
* platform/chromium-win/fast/repaint/table-extra-bottom-grow-expected.png:
* platform/chromium/test_expectations.txt:
Removed duplicate expectations entries to allow rebaselining tool to work.
Disabled 2d.imageData.get.source.outside.html test as it fails on Chromium.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@67892 268f45cc-cd09-0410-ab3c-d52691b4dbfc

        Reviewed by Tony Chang.

        NRWT fails with UnicodeDecodeError on editing/selection/mixed-editability-10.html
        https://bugs.webkit.org/show_bug.cgi?id=45791

        Force filenames to be raw bytes before running difflib.unified_diff.

        * Scripts/webkitpy/layout_tests/port/base.py:
        * Scripts/webkitpy/layout_tests/port/base_unittest.py:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@67560 268f45cc-cd09-0410-ab3c-d52691b4dbfc

        Reviewed by Ojan Vafai.

        new-run-webkit-tests: still more unit tests

        Clean up and remove unnecessary code. Biggest notable change is
        moving the chromium-specific imagediff code from port/base to
        port/chromium.

        Add more unit tests for run_webkit_tests.py, port/base.py,
        port/factory.py, port/dryrun.py, and
        layout_package/dump_render_tree_thread.py

        This covers almost all of the generic and test code paths except for
        a few error paths involving invalid or port-specific command line
        arguments, and the code path for uploading results files to the
        buildbots.

        https://bugs.webkit.org/show_bug.cgi?id=45090

        * Scripts/webkitpy/layout_tests/data/failures/expected/hang.html: Added.
        * Scripts/webkitpy/layout_tests/data/http/tests/passes/text-expected.txt: Copied from WebKitTools/Scripts/webkitpy/layout_tests/data/passes/text-expected.txt.
        * Scripts/webkitpy/layout_tests/data/http/tests/passes/text.html: Copied from WebKitTools/Scripts/webkitpy/layout_tests/data/passes/text.html.
        * Scripts/webkitpy/layout_tests/data/http/tests/ssl/text-expected.txt: Copied from WebKitTools/Scripts/webkitpy/layout_tests/data/passes/text-expected.txt.
        * Scripts/webkitpy/layout_tests/data/http/tests/ssl/text.html: Copied from WebKitTools/Scripts/webkitpy/layout_tests/data/passes/text.html.
        * Scripts/webkitpy/layout_tests/data/platform/test/test_expectations.txt:
        * Scripts/webkitpy/layout_tests/data/websocket/tests/passes/text-expected.txt: Copied from WebKitTools/Scripts/webkitpy/layout_tests/data/passes/text-expected.txt.
        * Scripts/webkitpy/layout_tests/data/websocket/tests/passes/text.html: Copied from WebKitTools/Scripts/webkitpy/layout_tests/data/passes/text.html.
        * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
        * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread_unittest.py: Added.
        * Scripts/webkitpy/layout_tests/port/base.py:
        * Scripts/webkitpy/layout_tests/port/base_unittest.py:
        * Scripts/webkitpy/layout_tests/port/chromium.py:
        * Scripts/webkitpy/layout_tests/port/dryrun.py:
        * Scripts/webkitpy/layout_tests/port/factory_unittest.py:
        * Scripts/webkitpy/layout_tests/port/mac_unittest.py:
        * Scripts/webkitpy/layout_tests/port/port_testcase.py: Added.
        * Scripts/webkitpy/layout_tests/port/server_process.py:
        * Scripts/webkitpy/layout_tests/port/test.py:
        * Scripts/webkitpy/layout_tests/port/webkit.py:
        * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
        * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@66937 268f45cc-cd09-0410-ab3c-d52691b4dbfc

        Reviewed by Adam Barth.

        webkit-patch command to find the ports covering a specific layout test
        https://bugs.webkit.org/show_bug.cgi?id=42832

        To use it: webkit-patch skipped-ports some/layout/test.html

        * Scripts/webkitpy/layout_tests/port/base.py:
        * Scripts/webkitpy/layout_tests/port/base_unittest.py:
        * Scripts/webkitpy/layout_tests/port/chromium.py:
        * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
        * Scripts/webkitpy/layout_tests/port/factory.py:
        * Scripts/webkitpy/layout_tests/port/factory_unittest.py:
        * Scripts/webkitpy/layout_tests/port/test.py:
        * Scripts/webkitpy/layout_tests/port/webkit.py:
        * Scripts/webkitpy/layout_tests/port/webkit_unittest.py:
        * Scripts/webkitpy/tool/commands/queries.py:
        * Scripts/webkitpy/tool/commands/queries_unittest.py:
        * Scripts/webkitpy/tool/main.py:
        * Scripts/webkitpy/tool/mocktool.py:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@66872 268f45cc-cd09-0410-ab3c-d52691b4dbfc

        Reviewed by Adam Barth.

        Fix reading configuraiton in NWRT to work on Windows.
        https://bugs.webkit.org/show_bug.cgi?id=45180

        * Scripts/webkitpy/layout_tests/port/base.py: Added 'perl' argument, because Windows doesn't know what to do
            with the file otherwise.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@66761 268f45cc-cd09-0410-ab3c-d52691b4dbfc

        Reviewed by Eric Seidel.

        Add feature detection support to NRWT.
        https://bugs.webkit.org/show_bug.cgi?id=41842

        * Scripts/webkitpy/layout_tests/port/base.py:
        * Scripts/webkitpy/layout_tests/port/qt.py:
        * Scripts/webkitpy/layout_tests/port/webkit.py:
        * Scripts/webkitpy/layout_tests/port/webkit_unittest.py: Added.


git-svn-id: http://svn.webkit.org/repository/webkit/trunk@66727 268f45cc-cd09-0410-ab3c-d52691b4dbfc

        Reviewed by Tony Chang.

        Land a patched version of r66542 - change TestRunner to have an
        separate cleanup method and fix the ordering of cleanup between
        TestRunner and the printing module, and then wrap everything in a
        try/finally block to ensure reliable cleanup without needing to
        rely on stuff happening in the destructor of the TestRunner.

        Also refactor run_webkit_tests.run() to be much smaller and cleaner
        by creating a bunch of helper methods and moving more stuff into
        the TestRunner class.

        This fixes the crash at the end of the linux test run of
        new-run-webkit-tests (and undoes the rollout in 66547).

        https://bugs.webkit.org/show_bug.cgi?id=44902

        * Scripts/webkitpy/layout_tests/data/failures/expected/exception.html: Added.
        * Scripts/webkitpy/layout_tests/data/failures/expected/keyboard.html: Added.
        * Scripts/webkitpy/layout_tests/data/passes/error-expected.txt: Added.
        * Scripts/webkitpy/layout_tests/data/passes/error.html: Added.
        * Scripts/webkitpy/layout_tests/data/platform/test/test_expectations.txt:
        * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
        * Scripts/webkitpy/layout_tests/layout_package/printing.py:
        * Scripts/webkitpy/layout_tests/layout_package/printing_unittest.py:
        * Scripts/webkitpy/layout_tests/port/base.py:
        * Scripts/webkitpy/layout_tests/port/test.py:
        * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
        * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@66640 268f45cc-cd09-0410-ab3c-d52691b4dbfc

        Unreviewed, rolling out r66542.
        http://trac.webkit.org/changeset/66542
        https://bugs.webkit.org/show_bug.cgi?id=44902

        r66542 - the weird logging dependencies in Python stuck again ...

        * Scripts/webkitpy/layout_tests/data/failures/expected/exception.html: Removed.
        * Scripts/webkitpy/layout_tests/data/failures/expected/keyboard.html: Removed.
        * Scripts/webkitpy/layout_tests/data/passes/error-expected.txt: Removed.
        * Scripts/webkitpy/layout_tests/data/passes/error.html: Removed.
        * Scripts/webkitpy/layout_tests/data/platform/test/test_expectations.txt:
        * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
        * Scripts/webkitpy/layout_tests/layout_package/printing.py:
        * Scripts/webkitpy/layout_tests/layout_package/printing_unittest.py:
        * Scripts/webkitpy/layout_tests/port/base.py:
        * Scripts/webkitpy/layout_tests/port/test.py:
        * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
        * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@66547 268f45cc-cd09-0410-ab3c-d52691b4dbfc

        Reviewed by Ojan Vafai.

        new-run-webkit-tests: add more unit tests

        Add more unit tests for new-run-webkit-tests; we now cover all but
        the most obscure code paths in the generic code. We still need to
        add coverage for the http server and web socket paths, and add better
        coverage of the platform-specific logic. Note that the rebaselining
        tool is still not well tested.

        Also clean up some of the configuration logic for the printing
        module and the way it interacts with the Python logging module; that
        is a crufty interface, to be certain.

        https://bugs.webkit.org/show_bug.cgi?id=44902

        * Scripts/webkitpy/layout_tests/data/failures/expected/exception.html: Added.
        * Scripts/webkitpy/layout_tests/data/failures/expected/keyboard.html: Added.
        * Scripts/webkitpy/layout_tests/data/passes/error-expected.txt: Added.
        * Scripts/webkitpy/layout_tests/data/passes/error.html: Added.
        * Scripts/webkitpy/layout_tests/data/platform/test/test_expectations.txt:
        * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
        * Scripts/webkitpy/layout_tests/layout_package/printing.py:
        * Scripts/webkitpy/layout_tests/layout_package/printing_unittest.py:
        * Scripts/webkitpy/layout_tests/port/base.py:
        * Scripts/webkitpy/layout_tests/port/test.py:
        * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
        * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@66542 268f45cc-cd09-0410-ab3c-d52691b4dbfc