GitLab

        Reviewed by James Robinson.

        new-run-webkit-tests ignores trailing EOL differences in text tests
        https://bugs.webkit.org/show_bug.cgi?id=36983

        Changed the handling of new-line characters within new-run-webkit-tests
        to match old-run-webkit-tests.  Differences in leading and trailing empty
        lines in text expectation files are no longer ignored.

        * Scripts/webkitpy/layout_tests/port/base.py:
        * Scripts/webkitpy/layout_tests/port/test.py:
        Added unit tests.  Removed old duplicate unit test entries.
        * Scripts/webkitpy/layout_tests/test_types/text_diff.py:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@74362 268f45cc-cd09-0410-ab3c-d52691b4dbfc

        Reviewed by James Robinson.

        Even more rebaselining needed for new-run-webkit-tests update
        https://bugs.webkit.org/show_bug.cgi?id=51340

        * http/tests/misc/webtiming-ssl-expected.txt:
        * storage/indexeddb/cursor-delete-expected.txt:
        * storage/indexeddb/cursor-index-delete-expected.txt:
        * storage/indexeddb/transaction-crash-on-abort-expected.txt:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@74361 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Reviewed by Oliver Hunt.

JavaScriptCore: 

This patch adds a class 'StackBounds', to hold information about the machine stack.
The implementation of this class broadly adheres to the current implmentation of
stack limit checking, and as such does not solve the problem of determining stack
extent, but gives us a common place to do so.

Currently two mechanism are provided to determine the stack origin (the point the
stack is growing away from). currentThreadStackBase() in Collector provides a
more accurate determination of the stack origin, so use this to calculate
StackBounds::m_origin; WTFThreadData::approximatedStackStart is less accurate, and
as such can be removed.  Cache the StackBounds on WTFThreadData such that they
need only be determined once per thread, and for non-API contexts cache this
information in JSGlobalData, to save a thread-specific access.

For the time being retain the estimate of stack size used by JSC's parser
(128 * sizeof(void*) * 1024), with a view to replacing this with something more
accurate in the near future.

* parser/JSParser.cpp:
(JSC::JSParser::canRecurse):
(JSC::JSParser::JSParser):
    Change to use StackBounds.
* runtime/Collector.cpp:
(JSC::Heap::registerThread):
(JSC::Heap::markCurrentThreadConservativelyInternal):
    Change to use StackBounds, cached on JSGlobalData.
* runtime/JSGlobalData.cpp:
(JSC::JSGlobalData::JSGlobalData):
* runtime/JSGlobalData.h:
(JSC::JSGlobalData::stack):
    Add a cached copy of StackBounds.
* wtf/StackBounds.cpp: Copied from JavaScriptCore/runtime/Collector.cpp.
(WTF::estimateStackBound):
(WTF::StackBounds::initialize):
(WTF::getStackMax):
    Copy code from Collector.cpp to determine stack origin.
* wtf/StackBounds.h: Added.
(WTF::StackBounds::StackBounds):
    No argument constructor; returns a null StackBounds.
(WTF::StackBounds::currentThreadStackBounds):
    Returns a StackBounds object representing the stack limits
    of the current thread.
(WTF::StackBounds::origin):
    Returns to stack origin (the point the stack is growing away
    from; the highest extent of the stack on machines where the
    stack grows downwards.
(WTF::StackBounds::recursionLimit):
    Returns a limit value that is 'a comfortable distance from
    the end of the stack'. Our concept of this is currently 1 page
    away from the end, however the default value may be tuned in
    the future, and clients may override passing a larger delta;
    should only be called on StackBounds object representing the
    stack of the thread this method is called on (checked by
    checkConsistency).
(WTF::StackBounds::recursionCheck):
    Checks whether we are currently 'a comfortable distance from
    the end of the stack'. Our concept of this is currently 1 page
    away from the end, however the default value may be tuned in
    the future, and clients may override passing a larger delta
    to apply when checking, if they wish to do so. This method
    should only be called on StackBounds object representing the
    stack of the thread this method is called on (checked by
    checkConsistency).
(WTF::StackBounds::current):
    Approximate current stack position. On machines where the stack
    is growing downwards this is the lowest address that might need
    conservative collection.
(WTF::StackBounds::isGrowingDownward):
    True for all platforms other than WINCE, which has to check.
(WTF::StackBounds::checkConsistency):
    This is called in methods that shoulds only be operating on a
    valid set of bounds; as such we expect m_origin != m_bounds
    (i.e. stack size != zero) - we're really testing that this
    object is not null (the constructor initializes both fields
    to zero).  Also checks that current() is within the stack's
    bounds.
* wtf/WTFThreadData.cpp:
(WTF::WTFThreadData::WTFThreadData):
* wtf/WTFThreadData.h:
(WTF::WTFThreadData::stack):
    Add the StackBounds member variable.

JavaScriptGlue: 

Add forwarding header for StackBounds.h.

* ForwardingHeaders/wtf/StackBounds.h: Added.

WebCore: 

Add forwarding header for StackBounds.h.

* ForwardingHeaders/wtf/StackBounds.h: Added.



git-svn-id: http://svn.webkit.org/repository/webkit/trunk@74360 268f45cc-cd09-0410-ab3c-d52691b4dbfc

        Reviewed by Sam Weinig.

        Flash plug-in does not work on YouTube video page when accelerated compositing is disabled
        https://bugs.webkit.org/show_bug.cgi?id=51348
        <rdar://problem/8787667>

        * Platform/CoreIPC/HandleMessage.h:
        (CoreIPC::callMemberFunction):
        Add new overload.

        * PluginProcess/PluginControllerProxy.cpp:
        (WebKit::PluginControllerProxy::create):
        (WebKit::PluginControllerProxy::PluginControllerProxy):
        These now take an additional isAcceleratedCompositingEnabled parameter.

        (WebKit::PluginControllerProxy::isAcceleratedCompositingEnabled):
        Return m_isAcceleratedCompositingEnabled.

        * PluginProcess/PluginControllerProxy.h:
        * PluginProcess/WebProcessConnection.cpp:
        (WebKit::WebProcessConnection::createPlugin):
        This now takes an additional isAcceleratedCompositingEnabled parameter.

        * PluginProcess/WebProcessConnection.messages.in:
        Add isAcceleratedCompositingEnabled parameter to the CreatePlugin message.

        * WebProcess/Plugins/PluginProxy.cpp:
        (WebKit::PluginProxy::initialize):
        Pass isAcceleratedCompositingEnabled when sending the CreatePlugin message.


git-svn-id: http://svn.webkit.org/repository/webkit/trunk@74359 268f45cc-cd09-0410-ab3c-d52691b4dbfc

        Unreviewed, rolling out r74278.
        http://trac.webkit.org/changeset/74278
        https://bugs.webkit.org/show_bug.cgi?id=50833

        [chromium] Causes many layout tests to crash

        * platform/graphics/chromium/LayerRendererChromium.cpp:
        (WebCore::LayerRendererChromium::LayerRendererChromium):
        (WebCore::LayerRendererChromium::prepareToDrawLayers):
        (WebCore::LayerRendererChromium::drawLayers):
        (WebCore::LayerRendererChromium::useRenderSurface):
        (WebCore::LayerRendererChromium::setScissorToRect):
        * platform/graphics/chromium/LayerRendererChromium.h:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@74358 268f45cc-cd09-0410-ab3c-d52691b4dbfc

        Reviewed by Sam Weinig.

        Factored common page set management into a new PageBlock base class
        https://bugs.webkit.org/show_bug.cgi?id=51285

        * Android.mk:
        * CMakeLists.txt:
        * GNUmakefile.am:
        * JavaScriptCore.gypi:
        * JavaScriptCore.vcproj/WTF/WTF.vcproj:
        * JavaScriptCore.xcodeproj/project.pbxproj:
        * interpreter/RegisterFile.h:
        (JSC::RegisterFile::RegisterFile):
        * jit/ExecutableAllocator.cpp:
        (JSC::ExecutableAllocator::intializePageSize):
        * wtf/PageAllocation.cpp: Removed.
        * wtf/PageAllocation.h:
        (WTF::PageAllocation::deallocate):
        (WTF::PageAllocation::PageAllocation):
        * wtf/PageReservation.h:
        (WTF::PageReservation::commit):
        (WTF::PageReservation::decommit):
        (WTF::PageReservation::deallocate):
        (WTF::PageReservation::PageReservation):
        * wtf/wtf.pri:
2010-12-20  Geoffrey Garen  <ggaren@apple.com>

        Reviewed by Sam Weinig.

        Factored common page set management into a new PageBlock base class
        https://bugs.webkit.org/show_bug.cgi?id=51285

        * ForwardingHeaders/wtf/PageBlock.h: Added.
2010-12-20  Geoffrey Garen  <ggaren@apple.com>

        Reviewed by Sam Weinig.

        Factored common page set management into a new PageBlock base class
        https://bugs.webkit.org/show_bug.cgi?id=51285

        * ForwardingHeaders/wtf/PageBlock.h: Added.


git-svn-id: http://svn.webkit.org/repository/webkit/trunk@74357 268f45cc-cd09-0410-ab3c-d52691b4dbfc

https://bugs.webkit.org/show_bug.cgi?id=51303

Reviewed by Shinichiro Hamaji.

* Scripts/webkitpy/style/checkers/cpp.py:
(_FunctionState.begin): Add is_declaration and changed the line count
start to begin at -1 (which will keep the results consistent, since
the starting line number passed in is one less in this change).
(detect_functions): changed function detection to now catch trivial
functions and declarations.
(check_pass_ptr_usage): Don't check for Pass*Ptr on the first line
of the function as this may look at return values (when processing
a declaration).
* Scripts/webkitpy/style/checkers/cpp_unittest.py:
(FunctionDetectionTest.perform_function_detection): Basic mechanics
of testing the function detection.
(FunctionDetectionTest.test_basic_function_detection): Test a simple
function.
(FunctionDetectionTest.test_function_declaration_detection): Test a
declaration.
(FunctionDetectionTest.test_non_functions): A test case for a case
that caused the code to fail due to the { being in quotes.
(PassPtrTest.test_pass_ref_ptr_return_value): Added some more test
cases to help catch false alarms for return values.
(PassPtrTest.test_pass_ref_ptr_member_variable): Ensure that
we don't get false alarms for member variables either.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@74356 268f45cc-cd09-0410-ab3c-d52691b4dbfc

        Unreviewed, rolling out r74345.
        http://trac.webkit.org/changeset/74345
        https://bugs.webkit.org/show_bug.cgi?id=51115

        Not the correct fix.

        * Platform/CoreIPC/Connection.h:
        * Platform/CoreIPC/qt/ConnectionQt.cpp:
        (CoreIPC::Connection::open):


git-svn-id: http://svn.webkit.org/repository/webkit/trunk@74355 268f45cc-cd09-0410-ab3c-d52691b4dbfc

        Reviewed by Jeremy Orlow.

        GeolocationPositionCache should do database access on background thread
        https://bugs.webkit.org/show_bug.cgi?id=50825

        Covered by existing Geolocation tests.

        * page/Coordinates.h:
        (WebCore::Coordinates::threadSafeCopy):
        * page/GeolocationPositionCache.cpp:
        (WebCore::GeolocationPositionCache::GeolocationPositionCache):
        (WebCore::GeolocationPositionCache::addUser):
        (WebCore::GeolocationPositionCache::removeUser):
        (WebCore::GeolocationPositionCache::setDatabasePath):
        (WebCore::GeolocationPositionCache::setCachedPosition):
        (WebCore::GeolocationPositionCache::cachedPosition):
        (WebCore::GeolocationPositionCache::startBackgroundThread):
        (WebCore::GeolocationPositionCache::threadEntryPoint):
        (WebCore::GeolocationPositionCache::threadEntryPointImpl):
        (WebCore::GeolocationPositionCache::triggerReadFromDatabase):
        (WebCore::GeolocationPositionCache::readFromDatabase):
        (WebCore::GeolocationPositionCache::readFromDatabaseImpl):
        (WebCore::GeolocationPositionCache::triggerWriteToDatabase):
        (WebCore::GeolocationPositionCache::writeToDatabase):
        (WebCore::GeolocationPositionCache::writeToDatabaseImpl):
        * page/GeolocationPositionCache.h:
        * page/Geoposition.h:
        (WebCore::Geoposition::threadSafeCopy):
        (WebCore::Geoposition::Geoposition):


git-svn-id: http://svn.webkit.org/repository/webkit/trunk@74354 268f45cc-cd09-0410-ab3c-d52691b4dbfc

        Unreviewed build fix.

        [Qt][V8] Add  missing sources to the pro file and remove duplications to fix linking.

        No new tests needed.

        * WebCore.pro:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@74353 268f45cc-cd09-0410-ab3c-d52691b4dbfc

        Reviewed by Yury Semikhatsky.

        Web Inspector: Make CSSCompletions a real class rather than singleton
        https://bugs.webkit.org/show_bug.cgi?id=51332

        Drive-by: make use of keywords from re2js in the CSS tokenizer
        (apparently, various authors have presumed that re2js is processed at build time).

        No new tests, as this is a refactoring.

        * inspector/front-end/CSSCompletions.js:
        (WebInspector.CSSCompletions):
        (WebInspector.CSSCompletions.prototype.startsWith):
        (WebInspector.CSSCompletions.prototype.firstStartsWith):
        (WebInspector.CSSCompletions.prototype._firstIndexOfPrefix):
        (WebInspector.CSSCompletions.prototype.keySet):
        (WebInspector.CSSCompletions.prototype.next):
        (WebInspector.CSSCompletions.prototype.previous):
        (WebInspector.CSSCompletions.prototype._closest):
        * inspector/front-end/SourceCSSTokenizer.js:
        (WebInspector.SourceCSSTokenizer):
        * inspector/front-end/SourceCSSTokenizer.re2js:
        * inspector/front-end/StylesSidebarPane.js:
        (WebInspector.StylePropertyTreeElement.prototype):
        * inspector/front-end/inspector.js:
        (WebInspector.doLoadedDone.propertyNamesCallback):
        (WebInspector.doLoadedDone):


git-svn-id: http://svn.webkit.org/repository/webkit/trunk@74352 268f45cc-cd09-0410-ab3c-d52691b4dbfc

        Unreviewed. Rebased platform-specific test expectations following default expectations change in r74234.

        * platform/mac-leopard/inspector/extensions-resources-expected.txt:



git-svn-id: http://svn.webkit.org/repository/webkit/trunk@74351 268f45cc-cd09-0410-ab3c-d52691b4dbfc

        Reviewed by Yury Semikhatsky.

        Web Inspector: "Add conditional breakpoint" - create breakpoint only after condition is provided.
        https://bugs.webkit.org/show_bug.cgi?id=50813

        * inspector/front-end/SourceFrame.js:
        (WebInspector.SourceFrame.prototype._addBreakpoint):
        (WebInspector.SourceFrame.prototype._breakpointRemoved):
        (WebInspector.SourceFrame.prototype._breakpointChanged):
        (WebInspector.SourceFrame.prototype._setBreakpointDecoration):
        (WebInspector.SourceFrame.prototype._removeBreakpointDecoration):
        (WebInspector.SourceFrame.prototype._contextMenu.addConditionalBreakpoint.didEditBreakpointCondition):
        (WebInspector.SourceFrame.prototype._contextMenu.addConditionalBreakpoint):
        (WebInspector.SourceFrame.prototype._contextMenu.else.editBreakpointCondition.didEditBreakpointCondition):
        (WebInspector.SourceFrame.prototype._contextMenu.else.editBreakpointCondition):
        (WebInspector.SourceFrame.prototype._contextMenu):
        (WebInspector.SourceFrame.prototype._editBreakpointCondition.finishEditing):
        (WebInspector.SourceFrame.prototype._editBreakpointCondition):
        (WebInspector.SourceFrame.prototype._continueToLine):
        (WebInspector.SourceFrame.prototype._setBreakpoint):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@74350 268f45cc-cd09-0410-ab3c-d52691b4dbfc

        Reviewed by Xan Lopez.

        no-caret-repaint-in-non-content-editable-element.html does not need to disable CaretBrowsing
        https://bugs.webkit.org/show_bug.cgi?id=51308

        Patch removes the useless statement to disable caret browsing from
        no-caret-repaint-in-non-content-editable-element.html.

        Caret browsing gets toggled OFF before the execution of each test
        on the DRTs that support testing it (GTK+, Qt and Chromium). On Mac or
        Windows's DRT testing this feature is unsupport, so caret
        browsing is also disabled by default.

        * fast/repaint/no-caret-repaint-in-non-content-editable-element.html:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@74349 268f45cc-cd09-0410-ab3c-d52691b4dbfc

        Reviewed by Xan Lopez.

        [GTK+] Simplify spatial navigation handling in EditorClientGtk.cpp
        https://bugs.webkit.org/show_bug.cgi?id=51302

        Patch changes:
        1) The editor command for LEFT arrow key press without modifier
           from MoveBackward to MoveLeft;
        2) And similarly changes the editor command for RIGHT arrow key
          press without modifier from MoveForward to MoveRight.

        It has no implications since SelectionController::modifyMovingRight()
        handles "MoveRight" equaly to how SelectionController::modifyMovingForward()
        handles "MoveForward" when the granularity is 'CharacterGranularity'.
        The former falls back to the later in the case of other editor commands.

        Analogously, the same applies to how SelectionController::modifyMovingLeft() and
        SelectionController::modifyMovingForward() handle "MoveLeft" and "MoveBackward"
        editor commands, respectively.

        With this change we can remove the spatial navigation hack from moveCursorCallback(),
        in EditorClientGtk.cpp.

        * WebCoreSupport/EditorClientGtk.cpp:
        (WebKit::moveCursorCallback):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@74348 268f45cc-cd09-0410-ab3c-d52691b4dbfc

        Unreviewed. Removed custom expectation for a passing test.

        * platform/chromium/test_expectations.txt:


git-svn-id: http://svn.webkit.org/repository/webkit/trunk@74347 268f45cc-cd09-0410-ab3c-d52691b4dbfc

        Unreviewed, added the proper expected result file.

        * platform/gtk/fast/text/emphasis-overlap-expected.txt: Added.
        * platform/gtk/fast/text/emphasis-overlap.html: Removed.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@74346 268f45cc-cd09-0410-ab3c-d52691b4dbfc

        Reviewed by Kenneth Rohde Christiansen.

        [Qt][WK2] Crash in web process after the connection had been closed
        https://bugs.webkit.org/show_bug.cgi?id=51115

        Do not call connectionDidClose with a connection that has been explicitly
        invalidated on the listener thread.
        * Platform/CoreIPC/Connection.h:
        * Platform/CoreIPC/qt/ConnectionQt.cpp:
        (CoreIPC::Connection::disconnectHandler): Added.
        (CoreIPC::Connection::open):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@74345 268f45cc-cd09-0410-ab3c-d52691b4dbfc

https://bugs.webkit.org/show_bug.cgi?id=51330

Reviewed by Andreas Kling.

Redefine the scopes to improve readability. Objects are now created in
the scope they are used in.

* WebCoreSupport/FrameLoaderClientQt.cpp:
(WebCore::FrameLoaderClientQt::createPlugin):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@74344 268f45cc-cd09-0410-ab3c-d52691b4dbfc

        Reviewed by Jeremy Orlow.

        IDBTransactionBackedImpl instances can be accidentally deleted during calls to abort/commit.
        https://bugs.webkit.org/show_bug.cgi?id=51112

        * storage/indexeddb/transaction-crash-on-abort-expected.txt: Added.
        * storage/indexeddb/transaction-crash-on-abort.html: Added.

2010-12-20  Andrei Popescu  <andreip@google.com>

        Reviewed by Jeremy Orlow.

        IDBTransactionBackedImpl instances can be accidentally deleted during calls to abort/commit.
        https://bugs.webkit.org/show_bug.cgi?id=51112

        Makes IDBTransactionBackendImpl objects take a self reference while executing commit and abort.

        Test: storage/indexeddb/transaction-crash-on-abort.html

        * storage/IDBTransactionBackendImpl.cpp:
        (WebCore::IDBTransactionBackendImpl::abort):
        (WebCore::IDBTransactionBackendImpl::commit):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@74343 268f45cc-cd09-0410-ab3c-d52691b4dbfc

        Reviewed by Jeremy Orlow.

        IDBCursor::delete is not implemented.
        https://bugs.webkit.org/show_bug.cgi?id=51110

        * storage/indexeddb/cursor-delete-expected.txt: Added.
        * storage/indexeddb/cursor-delete.html: Added.
        * storage/indexeddb/cursor-index-delete-expected.txt: Added.
        * storage/indexeddb/cursor-index-delete.html: Added.
2010-12-20  Andrei Popescu  <andreip@google.com>

        Reviewed by Jeremy Orlow.

        IDBCursor::delete is not implemented.
        https://bugs.webkit.org/show_bug.cgi?id=51110

        Implement IDBCursor::delete.
        See http://dvcs.w3.org/hg/IndexedDB/raw-file/tip/Overview.html#widl-IDBCursor-delete

        Tests: storage/indexeddb/cursor-delete.html
               storage/indexeddb/cursor-index-delete.html

        * storage/IDBCursor.cpp:
        (WebCore::IDBCursor::deleteFunction):
        * storage/IDBCursor.h:
        * storage/IDBCursor.idl:
        * storage/IDBCursorBackendImpl.cpp:
        (WebCore::IDBCursorBackendImpl::IDBCursorBackendImpl):
        (WebCore::IDBCursorBackendImpl::deleteFunction):
        (WebCore::IDBCursorBackendImpl::loadCurrentRow):
        * storage/IDBCursorBackendImpl.h:
        (WebCore::IDBCursorBackendImpl::create):
        * storage/IDBCursorBackendInterface.h:
        * storage/IDBIndexBackendImpl.cpp:
        (WebCore::IDBIndexBackendImpl::openCursorInternal):
        * storage/IDBKey.cpp:
        (WebCore::IDBKey::fromQuery):
        * storage/IDBObjectStoreBackendImpl.cpp:
        (WebCore::IDBObjectStoreBackendImpl::deleteInternal):
        (WebCore::IDBObjectStoreBackendImpl::openCursorInternal):
2010-12-20  Andrei Popescu  <andreip@google.com>

        Reviewed by Jeremy Orlow.

        IDBCursor::delete is not implemented.
        https://bugs.webkit.org/show_bug.cgi?id=51110

        * public/WebIDBCursor.h:
        (WebKit::WebIDBCursor::remove):
        (WebKit::WebIDBCursor::deleteFunction):
        * src/IDBCursorBackendProxy.cpp:
        (WebCore::IDBCursorBackendProxy::deleteFunction):
        * src/IDBCursorBackendProxy.h:
        * src/WebIDBCursorImpl.cpp:
        (WebKit::WebIDBCursorImpl::deleteFunction):
        * src/WebIDBCursorImpl.h:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@74342 268f45cc-cd09-0410-ab3c-d52691b4dbfc

        Unreviewed. Update Chromium test expectations.

        * platform/chromium/test_expectations.txt:


git-svn-id: http://svn.webkit.org/repository/webkit/trunk@74341 268f45cc-cd09-0410-ab3c-d52691b4dbfc

        Unreviewed expectation results update. Added also the tests
        failing due to the pixman rounding color issue to the same section
        of the skipped file: bug 49964.

        * platform/gtk/Skipped:
        * platform/gtk/fast/repaint/text-emphasis-h-expected.txt: Added.
        * platform/gtk/fast/repaint/text-emphasis-v-expected.txt: Added.
        * platform/gtk/fast/text/emphasis-overlap.html: Added.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@74340 268f45cc-cd09-0410-ab3c-d52691b4dbfc

        [GTK] editing/selection/extend-by-character-003.html is flakey
        https://bugs.webkit.org/show_bug.cgi?id=51325

        Skip flakey test.

        * platform/gtk/Skipped:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@74339 268f45cc-cd09-0410-ab3c-d52691b4dbfc

        Unreviewed. Update Chromium test expectations.

        * platform/chromium/test_expectations.txt:


git-svn-id: http://svn.webkit.org/repository/webkit/trunk@74338 268f45cc-cd09-0410-ab3c-d52691b4dbfc

[Qt] fast/text/emphasis-overlap.html fails
https://bugs.webkit.org/show_bug.cgi?id=51324

* platform/qt/Skipped: fast/text/emphasis-overlap.html added until fix.



git-svn-id: http://svn.webkit.org/repository/webkit/trunk@74337 268f45cc-cd09-0410-ab3c-d52691b4dbfc

[Qt] Add platform specific expected result for new test introduced in r74321.

* platform/qt/fast/parser/xml-colon-entity-expected.txt: Copied from LayoutTests/fast/parser/xml-colon-entity-expected.txt.



git-svn-id: http://svn.webkit.org/repository/webkit/trunk@74336 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Add new tests to the Skipped list, because of missing layoutTestController.testRepaint()

* platform/qt/Skipped:
 - fast/repaint/text-emphasis-h.html added
 - fast/repaint/text-emphasis-v.html added



git-svn-id: http://svn.webkit.org/repository/webkit/trunk@74335 268f45cc-cd09-0410-ab3c-d52691b4dbfc

        Reviewed by Antonio Gomes.

        [CMAKE] Rename WEBKITTOOLS_DIR to TOOLS_DIR
        https://bugs.webkit.org/show_bug.cgi?id=51319

        Change WEBKITTOOLS_DIR variable's name and value to TOOLS_DIR and tools/.

        * CMakeLists.txt:
2010-12-20  Ryuan Choi  <ryuan.choi@samsung.com>

        Reviewed by Antonio Gomes.

        [CMAKE] Rename WEBKITTOOLS_DIR to TOOLS_DIR
        https://bugs.webkit.org/show_bug.cgi?id=51319

        * CMakeListsEfl.txt:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@74334 268f45cc-cd09-0410-ab3c-d52691b4dbfc

        Reviewed by Pavel Feldman.

        Web Inspector: After a multiline command execution Console does not show the command prompt
        https://bugs.webkit.org/show_bug.cgi?id=51257

        * inspector/front-end/TextPrompt.js:
        (WebInspector.TextPrompt.prototype._moveBackInHistory):
        (WebInspector.TextPrompt.prototype._moveForwardInHistory):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@74333 268f45cc-cd09-0410-ab3c-d52691b4dbfc

https://bugs.webkit.org/show_bug.cgi?id=51291

Reviewed by Sam Weinig.

.: 

* Examples: Copied from WebKitExamplePlugins.
* WebKitExamplePlugins: Removed.
* WebKitExamplePlugins/NetscapeCocoaPlugin: Removed.
* WebKitExamplePlugins/NetscapeCocoaPlugin/English.lproj: Removed.
* WebKitExamplePlugins/NetscapeCocoaPlugin/English.lproj/InfoPlist.strings: Removed.
* WebKitExamplePlugins/NetscapeCocoaPlugin/Info.plist: Removed.
* WebKitExamplePlugins/NetscapeCocoaPlugin/MenuHandler.h: Removed.
* WebKitExamplePlugins/NetscapeCocoaPlugin/MenuHandler.m: Removed.
* WebKitExamplePlugins/NetscapeCocoaPlugin/NetscapeCocoaPlugin.xcodeproj: Removed.
* WebKitExamplePlugins/NetscapeCocoaPlugin/NetscapeCocoaPlugin.xcodeproj/project.pbxproj: Removed.
* WebKitExamplePlugins/NetscapeCocoaPlugin/main.m: Removed.
* WebKitExamplePlugins/NetscapeCocoaPlugin/test.html: Removed.
* WebKitExamplePlugins/NetscapeCoreAnimationMoviePlugin: Removed.
* WebKitExamplePlugins/NetscapeCoreAnimationMoviePlugin/English.lproj: Removed.
* WebKitExamplePlugins/NetscapeCoreAnimationMoviePlugin/English.lproj/InfoPlist.strings: Removed.
* WebKitExamplePlugins/NetscapeCoreAnimationMoviePlugin/Info.plist: Removed.
* WebKitExamplePlugins/NetscapeCoreAnimationMoviePlugin/MovieControllerLayer.h: Removed.
* WebKitExamplePlugins/NetscapeCoreAnimationMoviePlugin/MovieControllerLayer.m: Removed.
* WebKitExamplePlugins/NetscapeCoreAnimationMoviePlugin/NetscapeCoreAnimationMoviePlugin.xcodeproj: Removed.
* WebKitExamplePlugins/NetscapeCoreAnimationMoviePlugin/NetscapeCoreAnimationMoviePlugin.xcodeproj/project.pbxproj: Removed.
* WebKitExamplePlugins/NetscapeCoreAnimationMoviePlugin/Pause.tiff: Removed.
* WebKitExamplePlugins/NetscapeCoreAnimationMoviePlugin/Play.tiff: Removed.
* WebKitExamplePlugins/NetscapeCoreAnimationMoviePlugin/SliderTrackCenter.tiff: Removed.
* WebKitExamplePlugins/NetscapeCoreAnimationMoviePlugin/SliderTrackLeft.tiff: Removed.
* WebKitExamplePlugins/NetscapeCoreAnimationMoviePlugin/SliderTrackRight.tiff: Removed.
* WebKitExamplePlugins/NetscapeCoreAnimationMoviePlugin/Thumb.tiff: Removed.
* WebKitExamplePlugins/NetscapeCoreAnimationMoviePlugin/main.m: Removed.
* WebKitExamplePlugins/NetscapeCoreAnimationMoviePlugin/test.html: Removed.
* WebKitExamplePlugins/NetscapeCoreAnimationPlugin: Removed.
* WebKitExamplePlugins/NetscapeCoreAnimationPlugin/Composition.qtz: Removed.
* WebKitExamplePlugins/NetscapeCoreAnimationPlugin/English.lproj: Removed.
* WebKitExamplePlugins/NetscapeCoreAnimationPlugin/English.lproj/InfoPlist.strings: Removed.
* WebKitExamplePlugins/NetscapeCoreAnimationPlugin/Info.plist: Removed.
* WebKitExamplePlugins/NetscapeCoreAnimationPlugin/NetscapeCoreAnimationPlugin.xcodeproj: Removed.
* WebKitExamplePlugins/NetscapeCoreAnimationPlugin/NetscapeCoreAnimationPlugin.xcodeproj/project.pbxproj: Removed.
* WebKitExamplePlugins/NetscapeCoreAnimationPlugin/main.m: Removed.
* WebKitExamplePlugins/NetscapeCoreAnimationPlugin/test.html: Removed.
* WebKitExamplePlugins/NetscapeInputMethodPlugin: Removed.
* WebKitExamplePlugins/NetscapeInputMethodPlugin/English.lproj: Removed.
* WebKitExamplePlugins/NetscapeInputMethodPlugin/English.lproj/InfoPlist.strings: Removed.
* WebKitExamplePlugins/NetscapeInputMethodPlugin/Info.plist: Removed.
* WebKitExamplePlugins/NetscapeInputMethodPlugin/NetscapeInputMethodPlugin.xcodeproj: Removed.
* WebKitExamplePlugins/NetscapeInputMethodPlugin/NetscapeInputMethodPlugin.xcodeproj/project.pbxproj: Removed.
* WebKitExamplePlugins/NetscapeInputMethodPlugin/main.m: Removed.
* WebKitExamplePlugins/NetscapeInputMethodPlugin/test.html: Removed.
* cmake/WebKitPackaging.cmake:

BugsSite: 

* PrettyPatch/PrettyPatch.rb:

Tools: 

* Scripts/webkitpy/common/config/build.py:



git-svn-id: http://svn.webkit.org/repository/webkit/trunk@74332 268f45cc-cd09-0410-ab3c-d52691b4dbfc

        Reviewed by Antonio Gomes.

        [chromium] editing/selection/extend-selection-home-end.html should have one expected result
        https://bugs.webkit.org/show_bug.cgi?id=49873

        Change 100px to 5em in editing/selection/extend-selection-home-end.html so that chromium
        results are the same as the non-chromium results.

        * editing/selection/resources/extend-selection.js: Change 100px to 5em.
        * platform/chromium-win/editing/selection/extend-selection-home-end-expected.txt: Removed.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@74331 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Reviewed by Sam Weinig.

* UIProcess/API/mac/WKView.mm:
(-[WKView performKeyEquivalent:]): Do not retain the view. Doing so is necessary in
-[WebHTMLView performKeyEquivalent:], which this method was based upon, but not here, because
there is no way for the web process to cause the WKView to be released while it is handling
the event.



git-svn-id: http://svn.webkit.org/repository/webkit/trunk@74330 268f45cc-cd09-0410-ab3c-d52691b4dbfc

https://bugs.webkit.org/show_bug.cgi?id=51315

Reviewed by Sam Weinig.

* UIProcess/API/mac/WKView.mm:
(-[WKView performKeyEquivalent:]): Use a RetainPtr to ensure that the view is released in the
early return code path.



git-svn-id: http://svn.webkit.org/repository/webkit/trunk@74329 268f45cc-cd09-0410-ab3c-d52691b4dbfc

        Reviewed by Ariya Hidayat.

        [Qt] Blur distance should not be affected by transformations
        https://bugs.webkit.org/show_bug.cgi?id=51161

        From the spec at http://dev.w3.org/html5/2dcontext/#dom-context-2d-shadowblur:
        "The shadowBlur attribute specifies the level of the blurring effect.
        (The units do not map to coordinate space units, and are not affected
        by the current transformation matrix.)"

        Add test to ensure that the blur radius is not affected by the CTM.

        * fast/canvas/canvas-scale-shadowBlur-expected.txt: Added.
        * fast/canvas/canvas-scale-shadowBlur.html: Added.
        * fast/canvas/canvas-scale-strokePath-shadow-expected.txt: Increase
          shadowBlur and test tolerance to ease testing and support the
          different blurring algorithms.
        * fast/canvas/script-tests/canvas-scale-shadowBlur.js: Added.
        * fast/canvas/script-tests/canvas-scale-strokePath-shadow.js:
2010-12-19  Helder Correia  <helder@sencha.com>

        Reviewed by Ariya Hidayat.

        [Qt] Blur distance should not be affected by transformations
        https://bugs.webkit.org/show_bug.cgi?id=51161

        From the spec at http://dev.w3.org/html5/2dcontext/#dom-context-2d-shadowblur:
        "The shadowBlur attribute specifies the level of the blurring effect.
        (The units do not map to coordinate space units, and are not affected
        by the current transformation matrix.)"

        Test: fast/canvas/canvas-scale-shadowBlur.html

        * platform/graphics/ContextShadow.cpp:
        (WebCore::ContextShadow::adjustBlurDistance):
        * platform/graphics/ContextShadow.h:
        * platform/graphics/cairo/ContextShadowCairo.cpp:
        (WebCore::ContextShadow::beginShadowLayer):
        * platform/graphics/qt/ContextShadowQt.cpp:
        (WebCore::ContextShadow::beginShadowLayer):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@74328 268f45cc-cd09-0410-ab3c-d52691b4dbfc

        Reviewed by Kenneth Rohde Christiansen.

        [Qt] [WK2] QWKPagePrivate::paint() does not need to save the graphics context
        https://bugs.webkit.org/show_bug.cgi?id=51300

        Remove the unnecessary save() and restore() on the QPainter.

        * UIProcess/API/qt/qwkpage.cpp:
        (QWKPagePrivate::paint):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@74327 268f45cc-cd09-0410-ab3c-d52691b4dbfc

https://bugs.webkit.org/show_bug.cgi?id=51307

Reviewed by Cameron Zwarich.

WebCore: 

Tests: fast/repaint/text-emphasis-h.html
       fast/repaint/text-emphasis-v.html

* rendering/InlineFlowBox.cpp:
(WebCore::InlineFlowBox::addTextBoxVisualOverflow): Added flippedness check.

LayoutTests: 

* fast/repaint/text-emphasis-h-expected.checksum: Added.
* fast/repaint/text-emphasis-h-expected.png: Added.
* fast/repaint/text-emphasis-h-expected.txt: Added.
* fast/repaint/text-emphasis-h.html: Added.
* fast/repaint/text-emphasis-v-expected.checksum: Added.
* fast/repaint/text-emphasis-v-expected.png: Added.
* fast/repaint/text-emphasis-v-expected.txt: Added.
* fast/repaint/text-emphasis-v.html: Added.



git-svn-id: http://svn.webkit.org/repository/webkit/trunk@74326 268f45cc-cd09-0410-ab3c-d52691b4dbfc

        Reviewed by Andreas Kling.

        Remove m_drawsContents from RenderSVGContainer.h
        https://bugs.webkit.org/show_bug.cgi?id=51305

        Remove m_drawsContents, its getter and setter and the call
        sites, since it has no effect anymore.

        * WebCore.order:
        * rendering/RenderSVGContainer.cpp:
        (WebCore::RenderSVGContainer::RenderSVGContainer):
        (WebCore::RenderSVGContainer::paint):
        * rendering/RenderSVGContainer.h:
        * rendering/RenderSVGResourceContainer.h:
        * rendering/SVGImageBufferTools.cpp:
        (WebCore::SVGImageBufferTools::renderSubtreeToImageBuffer):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@74325 268f45cc-cd09-0410-ab3c-d52691b4dbfc

        Reviewed by Andreas Kling.

        [Qt] [WK2] Client are expected to render their own background for WebPages
        https://bugs.webkit.org/show_bug.cgi?id=51296

        Remove the rendering of the checkerboard from the tiled DrawingAreaProxy

        * UIProcess/TiledDrawingAreaProxy.cpp:
        (WebKit::TiledDrawingAreaProxy::paint):
        * UIProcess/TiledDrawingAreaTile.h:
        * UIProcess/qt/TiledDrawingAreaTileQt.cpp:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@74324 268f45cc-cd09-0410-ab3c-d52691b4dbfc

        Reviewed by Kenneth Rohde Christiansen.

        WebKit does not build with worker but without the javascript debugger
        https://bugs.webkit.org/show_bug.cgi?id=51293

        Add missing guard for calls depending on the debugger.

        * inspector/InspectorController.cpp:
        (WebCore::InspectorController::populateScriptObjects):
        (WebCore::InspectorController::postWorkerNotificationToFrontend):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@74323 268f45cc-cd09-0410-ab3c-d52691b4dbfc