1. 16 Aug, 2013 40 commits
    • bfulgham@apple.com's avatar
      [Windows] DRT is not using the same preferences as the Mac build. · 3ba5e00c
      bfulgham@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=119822
      
      Reviewed by Darin Adler.
      
      * DumpRenderTree/win/DumpRenderTree.cpp:
      (runTest): Process Windows message queue using CFRunLoop to allow
      dispatch routines to run properly.
      (dllLauncherEntryPoint): Wrap CG-specific setup code in a macro
      to prevent problems on WinCairo port.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@154198 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      3ba5e00c
    • zandobersek@gmail.com's avatar
      <https://webkit.org/b/119887> [Soup] The testing NetworkStorageSession should... · b18e95aa
      zandobersek@gmail.com authored
      <https://webkit.org/b/119887> [Soup] The testing NetworkStorageSession should have a proper SoupSession
      
      Reviewed by Martin Robinson.
      
      After r154144, a testing NetworkStorageSession is enforced when running the layout tests
      through WebKitTestRunner. Ports using the Soup networking backend don't assign any SoupSession
      objects to such NetworkStorageSession objects as it's usually the case. This is causing problems
      as the ResourceHandleInternal uses the SoupSession that's provided by the NetworkingContext's
      NetworkStorageSession, which ends up being null if the testing-specific NetworkStorageSession is used.
      As a result, all the layout tests are crashing under WKTR.
      
      * platform/network/NetworkStorageSession.h: Make the SoupSession member a GRefPtr.
      (WebCore::NetworkStorageSession::soupSession): Return the GRefPtr's pointer.
      * platform/network/ResourceHandle.h: Declare the new createTestingSession method.
      * platform/network/soup/CookieJarSoup.cpp: 
      (WebCore::cookieJarForSession): Instead of returning the default SoupCookieJar when there's no SoupSession
      provided by the NetworkStorageSession, assert that there now always is one, and return the session's cookie
      jar. For testing NetworkStorageSession objects, their SoupSession objects will always use the default cookie jar.
      * platform/network/soup/NetworkStorageSessionSoup.cpp:
      (WebCore::NetworkStorageSession::NetworkStorageSession): Adopt the given SoupSession reference pointer.
      (WebCore::NetworkStorageSession::switchToNewTestingSession): Use a newly-created, testing-specific SoupSession.
      * platform/network/soup/ResourceHandleSoup.cpp:
      (WebCore::ResourceHandle::createTestingSession): Define the new createTestingSession method. It creates a new
      SoupSession through createSoupSession, but uses the default SoupCookieJar, as provided by WebCore::soupCookieJar.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@154197 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      b18e95aa
    • commit-queue@webkit.org's avatar
      <https://webkit.org/b/118105> Web Inspector: AX: Add support for ARIA... · ef05bcd7
      commit-queue@webkit.org authored
      <https://webkit.org/b/118105> Web Inspector: AX: Add support for ARIA tablists/tabs to inspector tabs
      
      Patch by James Craig <james@cookiecrook.com> on 2013-08-16
      Reviewed by Joseph Pecoraro.
      
      Updating accessibility roles and attributes for single-select toolbar item sets.
      
      * UserInterface/ActivateButtonNavigationItem.js:
      (WebInspector.ActivateButtonNavigationItem):
      (WebInspector.ActivateButtonNavigationItem.prototype.set activated):
      * UserInterface/ActivateButtonToolbarItem.js:
      (WebInspector.ActivateButtonToolbarItem):
      * UserInterface/ButtonToolbarItem.js:
      (WebInspector.ButtonToolbarItem):
      * UserInterface/SidebarPanel.js:
      (WebInspector.SidebarPanel):
      * UserInterface/Toolbar.js:
      (WebInspector.Toolbar):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@154196 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      ef05bcd7
    • jer.noble@apple.com's avatar
      [Mac] Unreviewed gardening. Rebaseline after r154124. · ed3f7e48
      jer.noble@apple.com authored
      * platform/mac-lion/fast/js/global-constructors-attributes-expected.txt:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@154195 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      ed3f7e48
    • bfulgham@apple.com's avatar
      [Windows] URL printing code in DRT doesn't match WTR or Mac DRT · 267fb091
      bfulgham@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=119583
      
      Reviewed by Alexey Proskuryakov.
      
      * DumpRenderTree/win/DumpRenderTree.cpp:
      (urlSuitableForTestResult): Revise URL output to match Mac DRT by emiting last path
      component if the URL does not contain the expected base URL.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@154194 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      267fb091
    • bfulgham@apple.com's avatar
      [Windows] Unreviewed gardening. Correct Windows test expectations after JSC changes. · 98ad5dd0
      bfulgham@apple.com authored
      * platform/win/fast/js/dom-static-property-for-in-iteration-expected.txt:
      * platform/win/fast/js/global-constructors-attributes-shared-worker-expected.txt:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@154193 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      98ad5dd0
    • psolanki@apple.com's avatar
      <https://webkit.org/b/119852> Frame::scriptController() should return a reference · c5b5dad7
      psolanki@apple.com authored
      Reviewed by Andreas Kling.
      
      m_script is never NULL so we can just return a reference. Also remove some pointless null
      checks as a result of doing this.
      
      Source/WebCore:
      
      * Modules/websockets/WebSocket.cpp:
      (WebCore::WebSocket::connect):
      * bindings/js/JSDOMWindowBase.cpp:
      (WebCore::toJS):
      (WebCore::toJSDOMWindow):
      * bindings/js/JSDOMWindowShell.cpp:
      (WebCore::toJS):
      (WebCore::toJSDOMWindowShell):
      * bindings/js/JSEventListener.cpp:
      (WebCore::JSEventListener::handleEvent):
      * bindings/js/JSLazyEventListener.cpp:
      (WebCore::JSLazyEventListener::initializeJSFunction):
      * bindings/js/PageScriptDebugServer.cpp:
      (WebCore::PageScriptDebugServer::setJavaScriptPaused):
      * bindings/js/ScheduledAction.cpp:
      (WebCore::ScheduledAction::execute):
      * bindings/js/ScriptCachedFrameData.cpp:
      (WebCore::ScriptCachedFrameData::ScriptCachedFrameData):
      (WebCore::ScriptCachedFrameData::restore):
      * bindings/js/ScriptEventListener.cpp:
      (WebCore::createAttributeEventListener):
      (WebCore::eventListenerHandlerScriptState):
      * bindings/js/ScriptState.cpp:
      (WebCore::mainWorldScriptState):
      (WebCore::scriptStateFromNode):
      (WebCore::scriptStateFromPage):
      * bindings/objc/DOM.mm:
      (-[DOMNode JSC::Bindings::]):
      * bindings/objc/DOMInternal.mm:
      (-[WebScriptObject _initializeScriptDOMNodeImp]):
      * dom/Document.cpp:
      (WebCore::Document::disableEval):
      (WebCore::Document::ensurePlugInsInjectedScript):
      * dom/ScriptElement.cpp:
      (WebCore::ScriptElement::prepareScript):
      (WebCore::ScriptElement::executeScript):
      * history/CachedFrame.cpp:
      (WebCore::CachedFrameBase::restore):
      * html/HTMLCanvasElement.cpp:
      (WebCore::HTMLCanvasElement::createRenderer):
      * html/HTMLElement.cpp:
      (WebCore::HTMLElement::rendererIsNeeded):
      * html/HTMLMediaElement.cpp:
      (WebCore::HTMLMediaElement::controls):
      * html/HTMLPlugInElement.cpp:
      (WebCore::HTMLPlugInElement::getInstance):
      (WebCore::HTMLPlugInElement::getNPObject):
      * html/HTMLPlugInImageElement.cpp:
      (WebCore::HTMLPlugInImageElement::didAddUserAgentShadowRoot):
      * html/parser/HTMLParserOptions.cpp:
      (WebCore::HTMLParserOptions::HTMLParserOptions):
      * inspector/InspectorAgent.cpp:
      (WebCore::InspectorAgent::didClearWindowObjectInWorld):
      * inspector/InspectorClient.cpp:
      (WebCore::InspectorClient::doDispatchMessageOnFrontendPage):
      * inspector/InspectorFrontendClientLocal.cpp:
      (WebCore::InspectorFrontendClientLocal::evaluateAsBoolean):
      (WebCore::InspectorFrontendClientLocal::evaluateOnLoad):
      * inspector/InspectorOverlay.cpp:
      (WebCore::InspectorOverlay::evaluateInOverlay):
      * inspector/InspectorPageAgent.cpp:
      (WebCore::InspectorPageAgent::getScriptExecutionStatus):
      (WebCore::InspectorPageAgent::didClearWindowObjectInWorld):
      * inspector/PageRuntimeAgent.cpp:
      (WebCore::PageRuntimeAgent::reportExecutionContextCreation):
      * loader/DocumentWriter.cpp:
      (WebCore::DocumentWriter::begin):
      * loader/FrameLoader.cpp:
      (WebCore::FrameLoader::urlSelected):
      (WebCore::FrameLoader::submitForm):
      (WebCore::FrameLoader::cancelAndClear):
      (WebCore::FrameLoader::clear):
      (WebCore::FrameLoader::prepareForCachedPageRestore):
      (WebCore::FrameLoader::dispatchDidClearWindowObjectsInAllWorlds):
      (WebCore::FrameLoader::dispatchDidClearWindowObjectInWorld):
      * loader/SubframeLoader.cpp:
      (WebCore::SubframeLoader::requestFrame):
      * loader/cache/CachedResourceLoader.cpp:
      (WebCore::CachedResourceLoader::canRequest):
      * page/EventSource.cpp:
      (WebCore::EventSource::create):
      * page/Frame.cpp:
      (WebCore::Frame::willDetachPage):
      * page/Frame.h:
      (WebCore::Frame::script):
      * page/Navigator.cpp:
      (WebCore::shouldHideFourDot):
      * page/Page.cpp:
      (WebCore::Page::setDebugger):
      * platform/graphics/wince/MediaPlayerProxy.cpp:
      (WebCore::WebMediaPlayerProxy::pluginInstance):
      (WebCore::WebMediaPlayerProxy::invokeMethod):
      * plugins/PluginView.cpp:
      (WebCore::PluginView::~PluginView):
      (WebCore::PluginView::performRequest):
      (WebCore::PluginView::load):
      (WebCore::PluginView::bindingInstance):
      (WebCore::PluginView::getValue):
      * plugins/efl/PluginViewEfl.cpp:
      (WebCore::PluginView::platformGetValue):
      * xml/XMLHttpRequest.cpp:
      (WebCore::XMLHttpRequest::open):
      * xml/XMLTreeViewer.cpp:
      (WebCore::XMLTreeViewer::transformDocumentToTreeView):
      
      Source/WebKit/blackberry:
      
      * Api/WebPage.cpp:
      (BlackBerry::WebKit::WebPagePrivate::load):
      (BlackBerry::WebKit::WebPagePrivate::executeJavaScript):
      (BlackBerry::WebKit::WebPagePrivate::executeJavaScriptInIsolatedWorld):
      (BlackBerry::WebKit::WebPage::executeJavaScriptFunction):
      (BlackBerry::WebKit::WebPage::globalContext):
      * WebCoreSupport/FrameLoaderClientBlackBerry.cpp:
      (WebCore::FrameLoaderClientBlackBerry::dispatchDidClearWindowObjectInWorld):
      
      Source/WebKit/efl:
      
      * WebCoreSupport/DumpRenderTreeSupportEfl.cpp:
      (DumpRenderTreeSupportEfl::evaluateScriptInIsolatedWorld):
      (DumpRenderTreeSupportEfl::globalContextRefForFrame):
      * WebCoreSupport/FrameLoaderClientEfl.cpp:
      (WebCore::FrameLoaderClientEfl::dispatchDidClearWindowObjectInWorld):
      * ewk/ewk_frame.cpp:
      (ewk_frame_script_execute):
      * ewk/ewk_view.cpp:
      (ewk_view_js_object_add):
      
      Source/WebKit/gtk:
      
      * WebCoreSupport/FrameLoaderClientGtk.cpp:
      (WebKit::FrameLoaderClient::dispatchDidClearWindowObjectInWorld):
      * webkit/webkitwebframe.cpp:
      (webkit_web_frame_get_global_context):
      * webkit/webkitwebview.cpp:
      (webkit_web_view_execute_script):
      
      Source/WebKit/mac:
      
      * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
      (WebKit::NetscapePluginInstanceProxy::cleanup):
      (WebKit::NetscapePluginInstanceProxy::getWindowNPObject):
      (WebKit::NetscapePluginInstanceProxy::getPluginElementNPObject):
      (WebKit::NetscapePluginInstanceProxy::evaluate):
      (WebKit::NetscapePluginInstanceProxy::invoke):
      (WebKit::NetscapePluginInstanceProxy::invokeDefault):
      (WebKit::NetscapePluginInstanceProxy::construct):
      (WebKit::NetscapePluginInstanceProxy::getProperty):
      (WebKit::NetscapePluginInstanceProxy::setProperty):
      (WebKit::NetscapePluginInstanceProxy::removeProperty):
      (WebKit::NetscapePluginInstanceProxy::hasProperty):
      (WebKit::NetscapePluginInstanceProxy::hasMethod):
      (WebKit::NetscapePluginInstanceProxy::enumerate):
      (WebKit::NetscapePluginInstanceProxy::demarshalValueFromArray):
      * Plugins/WebNetscapePluginView.mm:
      (-[WebNetscapePluginView getVariable:value:]):
      (-[WebNetscapePluginView _destroyPlugin]):
      * Plugins/WebPluginController.mm:
      * WebCoreSupport/WebFrameLoaderClient.mm:
      * WebCoreSupport/WebInspectorClient.mm:
      (WebInspectorFrontendClient::save):
      (WebInspectorFrontendClient::append):
      * WebView/WebFrame.mm:
      (-[WebFrame _attachScriptDebugger]):
      (-[WebFrame _stringByEvaluatingJavaScriptFromString:forceUserGesture:]):
      (-[WebFrame _stringByEvaluatingJavaScriptFromString:withGlobalObject:inScriptWorld:]):
      (-[WebFrame _globalContextForScriptWorld:]):
      (-[WebFrame jsWrapperForNode:inScriptWorld:]):
      (-[WebFrame windowObject]):
      (-[WebFrame globalContext]):
      (-[WebFrame javaScriptContext]):
      * WebView/WebScriptDebugger.mm:
      (WebScriptDebugger::initGlobalCallFrame):
      (WebScriptDebugger::callEvent):
      * WebView/WebView.mm:
      (-[WebView windowScriptObject]):
      (-[WebView aeDescByEvaluatingJavaScriptFromString:]):
      
      Source/WebKit/qt:
      
      * Api/qwebelement.cpp:
      (setupScriptContext):
      (QWebElement::evaluateJavaScript):
      * WebCoreSupport/DumpRenderTreeSupportQt.cpp:
      (DumpRenderTreeSupportQt::evaluateScriptInIsolatedWorld):
      * WebCoreSupport/QWebFrameAdapter.cpp:
      (QWebFrameAdapter::evaluateJavaScript):
      (QWebFrameAdapter::addToJavaScriptWindowObject):
      
      Source/WebKit/win:
      
      * WebFrame.cpp:
      (WebFrame::globalContext):
      (WebFrame::globalContextForScriptWorld):
      (WebFrame::dispatchDidClearWindowObjectInWorld):
      (WebFrame::stringByEvaluatingJavaScriptInScriptWorld):
      * WebView.cpp:
      (WebView::stringByEvaluatingJavaScriptFromString):
      
      Source/WebKit2:
      
      * WebProcess/Plugins/Netscape/NPRuntimeObjectMap.cpp:
      (WebKit::NPRuntimeObjectMap::globalObject):
      * WebProcess/Plugins/PluginView.cpp:
      (WebKit::PluginView::performJavaScriptURLRequest):
      (WebKit::PluginView::windowScriptNPObject):
      (WebKit::PluginView::pluginElementNPObject):
      * WebProcess/WebPage/WebFrame.cpp:
      (WebKit::WebFrame::jsContext):
      (WebKit::WebFrame::jsContextForWorld):
      (WebKit::WebFrame::jsWrapperForWorld):
      * WebProcess/WebPage/WebInspector.cpp:
      (WebKit::WebInspector::didSave):
      (WebKit::WebInspector::didAppend):
      * WebProcess/WebPage/WebPage.cpp:
      (WebKit::WebPage::runJavaScriptInMainFrame):
      
      Tools:
      
      * DumpRenderTree/blackberry/DumpRenderTree.cpp:
      (BlackBerry::WebKit::DumpRenderTree::resetToConsistentStateBeforeTesting):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@154192 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      c5b5dad7
    • jer.noble@apple.com's avatar
      [Mac] [WK2] Some inspector tests intermittently asserts in InspectorOverlay::paint · 7d290d0c
      jer.noble@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=105988
      
      Unreviewed gardening. Mark tests as flakey (crashing) in WK1 expectations as well as WK2.
      
      * platform/mac-wk2/TestExpectations:
      * platform/mac/TestExpectations:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@154189 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      7d290d0c
    • akling@apple.com's avatar
      Attempt to fix the Qt/MountainLion build after r154142. · 2c462d01
      akling@apple.com authored
      * platform/graphics/qt/MediaPlayerPrivateQt.cpp:
      (WebCore::MediaPlayerPrivateQt::commitLoad):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@154188 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      2c462d01
    • akling@apple.com's avatar
      Windows build juice. · bf5fe238
      akling@apple.com authored
      * WebView.cpp:
      (WebView::paintIntoBackingStore):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@154187 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      bf5fe238
    • allan.jensen@digia.com's avatar
      [Qt] Kerning in fast font path breaks letter-spacing · b8b3a436
      allan.jensen@digia.com authored
      https://bugs.webkit.org/show_bug.cgi?id=119838
      
      Reviewed by Jocelyn Turcotte.
      
      Source/WebCore:
      
      Mark fonts with both kerning and letter-spacing as unsupported by the simple font-path.
      
      Test: fast/text/letter-spacing-kerned.html
      
      * platform/graphics/WidthIterator.h:
      (WebCore::WidthIterator::supportsTypesettingFeatures):
      
      LayoutTests:
      
      Test that kerning does not break letter spacing.
      
      * fast/text/letter-spacing-kerned-expected.html: Added.
      * fast/text/letter-spacing-kerned.html: Added.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@154186 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      b8b3a436
    • bfulgham@apple.com's avatar
      [Windows] Unreviewed gardening. Turn on a now-passing test. · 9408cf4d
      bfulgham@apple.com authored
      * platform/win/TestExpectations: Reactivate fast/text/split-text-crash.xhtml
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@154185 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      9408cf4d
    • akling@apple.com's avatar
      <https://webkit.org/b/119893> FrameView::frame() should return a reference. · 618f96f2
      akling@apple.com authored
      Reviewed by Antti Koivisto.
      
      FrameView::m_frame was only ever null for a brief moment during CachedFrame teardown.
      Leave it alone instead, and update the assertion that depended on this behavior.
      This enables us to make FrameView::frame() return a Frame&, exposing a ton of
      unnecessary null checks.
      
      * history/CachedFrame.cpp:
      (WebCore::CachedFrame::destroy):
      
          Remove call to FrameView::clearFrame() that was the only way to get a null
          FrameView::m_frame. Immediately followed by a call to CachedFrame::clear() where
          the FrameView would get destroyed anyway.
      
      (WebCore::CachedFrame::clear):
      
          Update an assertion to support the case where the Document's Frame pointer has
          been cleared out and CachedFrame is still clinging to the FrameView.
      
      * history/CachedPage.h:
      
          Made CachedPage::destroy() private as it was only called by ~CachedPage().
      
      * /:
      
          Frame* FrameView::frame() => Frame& FrameView::frame()
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@154184 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      618f96f2
    • beidson@apple.com's avatar
      (NetworkProcess) Sync XHRs should load using async ResourceHandles, not... · d74b7e09
      beidson@apple.com authored
      (NetworkProcess)  Sync XHRs should load using async ResourceHandles, not ResourceHandle::loadResourceSynchronously
      https://bugs.webkit.org/show_bug.cgi?id=119493
      
      Reviewed by Alexey Proskuryakov.
      
      Source/WebCore:
      
      No new tests (Covered by plenty of existing tests).
      
      * WebCore.exp.in:
      * WebCore.xcodeproj/project.pbxproj:
      
      * platform/network/SynchronousLoaderClient.h: Make platformBadResponseError public
      
      * platform/network/mac/ResourceHandleMac.mm:
      (WebCore::ResourceHandle::platformLoadResourceSynchronously): Add comments/FIXMEs spelling out how wrong this code is.
      
      Source/WebKit2:
      
      This patch does the following:
        - Consolidates SchedulableLoader and NetworkResourceLoader into one class.
        - Removes SyncNetworkResourceLoader.
        - Adds a NetworkLoaderClient interface that customizes certain behaviors of the NetworkResourceLoader.
        - Implements a SynchronousNetworkLoaderClient and AsynchronousNetworkLoaderClient for the two different types of loads.
      
      The AsynchronousNetworkLoaderClient results in messaging back progress to the WebProcess as the load progresses.
      The SynchronousNetworkLoaderClient accumulates the response, data, and error to be communicated back to the WebProcess
      only when the load is complete.
      
      Update small swaths of code to reflect that NetworkResourceLoader is the One True Loader (tm):
      * NetworkProcess/HostRecord.cpp:
      (WebKit::HostRecord::scheduleResourceLoader):
      (WebKit::HostRecord::addLoaderInProgress):
      (WebKit::removeLoaderFromQueue):
      (WebKit::HostRecord::removeLoader):
      (WebKit::HostRecord::servePendingRequestsForQueue):
      (WebKit::HostRecord::limitsRequests):
      * NetworkProcess/HostRecord.h:
      
      * NetworkProcess/NetworkConnectionToWebProcess.cpp:
      (WebKit::NetworkConnectionToWebProcess::didClose):
      (WebKit::NetworkConnectionToWebProcess::performSynchronousLoad):
      (WebKit::NetworkConnectionToWebProcess::removeLoadIdentifier):
      * NetworkProcess/NetworkConnectionToWebProcess.h:
      
      * NetworkProcess/NetworkProcess.cpp:
      * NetworkProcess/NetworkResourceLoadScheduler.cpp:
      (WebKit::NetworkResourceLoadScheduler::scheduleLoader):
      (WebKit::NetworkResourceLoadScheduler::removeLoader):
      (WebKit::NetworkResourceLoadScheduler::receivedRedirect):
      (WebKit::NetworkResourceLoadScheduler::removeScheduledLoaders):
      (WebKit::NetworkResourceLoadScheduler::scheduleRemoveLoader):
      * NetworkProcess/NetworkResourceLoadScheduler.h:
      
      Combine ScheduleableLoader and NetworkResourceLoader into NetworkResourceLoader:
      * NetworkProcess/NetworkResourceLoader.cpp:
      (WebKit::NetworkResourceLoader::NetworkResourceLoader):
      (WebKit::NetworkResourceLoader::~NetworkResourceLoader):
      (WebKit::NetworkResourceLoader::isSynchronous):
      (WebKit::NetworkResourceLoader::start):
      (WebKit::NetworkResourceLoader::didReceiveResponseAsync):
      (WebKit::NetworkResourceLoader::didReceiveBuffer):
      (WebKit::NetworkResourceLoader::didFinishLoading):
      (WebKit::NetworkResourceLoader::didFail):
      (WebKit::NetworkResourceLoader::willSendRequestAsync):
      (WebKit::NetworkResourceLoader::continueWillSendRequest):
      (WebKit::NetworkResourceLoader::didSendData):
      (WebKit::NetworkResourceLoader::shouldUseCredentialStorage):
      (WebKit::NetworkResourceLoader::didReceiveAuthenticationChallenge):
      (WebKit::NetworkResourceLoader::consumeSandboxExtensions):
      (WebKit::NetworkResourceLoader::invalidateSandboxExtensions):
      (WebKit::NetworkResourceLoader::canAuthenticateAgainstProtectionSpaceAsync):
      * NetworkProcess/NetworkResourceLoader.h:
      (WebKit::NetworkResourceLoader::create):
      (WebKit::NetworkResourceLoader::connectionToWebProcess):
      (WebKit::NetworkResourceLoader::priority):
      (WebKit::NetworkResourceLoader::request):
      (WebKit::NetworkResourceLoader::isLoadingMainResource):
      (WebKit::NetworkResourceLoader::setHostRecord):
      (WebKit::NetworkResourceLoader::hostRecord):
      (WebKit::NetworkResourceLoader::sendAbortingOnFailure):
      
      Add an abstract NetworkLoaderClient to adapt a load to be either synchronous or asynchronous:
      * NetworkProcess/NetworkLoaderClient.h:
      (WebKit::NetworkLoaderClient::~NetworkLoaderClient):
      (WebKit::NetworkLoaderClient::isSynchronous):
      (WebKit::NetworkLoaderClient::NetworkLoaderClient):
      
      The asynchronous loader client, primarily to message progress back to the WebProcess as it happens:
      * NetworkProcess/AsynchronousNetworkLoaderClient.cpp: Added.
      (WebKit::AsynchronousNetworkLoaderClient::AsynchronousNetworkLoaderClient):
      (WebKit::AsynchronousNetworkLoaderClient::willSendRequest):
      (WebKit::AsynchronousNetworkLoaderClient::canAuthenticateAgainstProtectionSpace):
      (WebKit::AsynchronousNetworkLoaderClient::didReceiveResponse):
      (WebKit::AsynchronousNetworkLoaderClient::didReceiveBuffer):
      (WebKit::AsynchronousNetworkLoaderClient::didSendData):
      (WebKit::AsynchronousNetworkLoaderClient::didFinishLoading):
      (WebKit::AsynchronousNetworkLoaderClient::didFail):
      * NetworkProcess/AsynchronousNetworkLoaderClient.h:
      (WebKit::AsynchronousNetworkLoaderClient::create):
      
      The synchronous loader client, primarily to accumulate results of the load to send back to the WebProcess all at once:
      * NetworkProcess/SynchronousNetworkLoaderClient.cpp: Added.
      (WebKit::SynchronousNetworkLoaderClient::SynchronousNetworkLoaderClient):
      (WebKit::SynchronousNetworkLoaderClient::~SynchronousNetworkLoaderClient):
      (WebKit::SynchronousNetworkLoaderClient::willSendRequest):
      (WebKit::SynchronousNetworkLoaderClient::canAuthenticateAgainstProtectionSpace):
      (WebKit::SynchronousNetworkLoaderClient::didReceiveResponse):
      (WebKit::SynchronousNetworkLoaderClient::didReceiveBuffer):
      (WebKit::SynchronousNetworkLoaderClient::didFinishLoading):
      (WebKit::SynchronousNetworkLoaderClient::didFail):
      (WebKit::SynchronousNetworkLoaderClient::sendDelayedReply):
      * NetworkProcess/SynchronousNetworkLoaderClient.h: Added.
      (WebKit::SynchronousNetworkLoaderClient::create):
      
      * NetworkProcess/SchedulableLoader.cpp: Removed.
      * NetworkProcess/SchedulableLoader.h: Removed.
      * NetworkProcess/SyncNetworkResourceLoader.cpp: Removed.
      * NetworkProcess/SyncNetworkResourceLoader.h: Removed.
      
      * WebKit2.xcodeproj/project.pbxproj:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@154183 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      d74b7e09
    • commit-queue@webkit.org's avatar
      <https://webkit.org/b/119889> [WinCairo] Compile error. · 4b56ce25
      commit-queue@webkit.org authored
      Patch by peavo@outlook.com <peavo@outlook.com> on 2013-08-16
      Reviewed by Brent Fulgham.
      
      * platform/network/curl/ResourceHandleManager.cpp:
      (WebCore::certificatePath): Use correct function name.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@154182 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      4b56ce25
    • bfulgham@apple.com's avatar
      [Windows] Unreviewed build correction after r154165. · 5488f6c6
      bfulgham@apple.com authored
      * WebCore.vcxproj/copyForwardingHeaders.cmd: Copy html/shadow header files
      to WebKit include location.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@154181 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      5488f6c6
    • bfulgham@apple.com's avatar
      Source/WebCore: [Windows] Prevent dangling CACFLayer when switching to/from Tiled backing. · da07a862
      bfulgham@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=119818
      
      Reviewed by Darin Adler.
      
      Covered by existing: compositing/tiling/empty-to-tiled.html
      
      * platform/graphics/ca/win/PlatformCALayerWin.cpp:
      (PlatformCALayer::~PlatformCALayer): Remove deleted layer from its
      parent layer 
      
      LayoutTests: [Windows] Enable previously-failing compositing/tiling/empty-to-tiled.html
      https://bugs.webkit.org/show_bug.cgi?id=119818
      
      Reviewed by Darin Adler.
      
      * platform/win/TestExpectations: Re-enable empty-to-tiled.html
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@154180 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      da07a862
    • zarvai@inf.u-szeged.hu's avatar
      [Qt] Unreviewed gardening. Rebase js tests after r154127. · 20202ad3
      zarvai@inf.u-szeged.hu authored
      Patch by Tamas Czene <tczene@inf.u-szeged.hu> on 2013-08-16
      
      * platform/qt/fast/js/constructor-length-expected.txt:
      * platform/qt/fast/js/global-constructors-attributes-expected.txt:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@154179 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      20202ad3
    • akling@apple.com's avatar
      <https://webkit.org/b/119866> Frame::eventHandler() should return a reference. · d18f79bb
      akling@apple.com authored
      Reviewed by Anders Carlsson.
      
      Frame::m_eventHandler is never null.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@154178 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      d18f79bb
    • commit-queue@webkit.org's avatar
      [EFL] fast/forms/datalist/input-list.html is failing · 3da11d5c
      commit-queue@webkit.org authored
      Unreviewed EFL gardening. unskip LayoutTests/fast/forms/datalist/input-list.html test.
      
      Patch by Santosh Mahto <santosh.ma@samsung.com> on 2013-08-16
      
      * platform/efl/TestExpectations:
      * platform/efl/fast/forms/datalist/input-list-expected.txt: Added.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@154177 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      3da11d5c
    • zandobersek@gmail.com's avatar
      Unreviewed, rolling out r153749. · 93bea371
      zandobersek@gmail.com authored
      http://trac.webkit.org/changeset/153749
      https://bugs.webkit.org/show_bug.cgi?id=119892
      
      The bison generation of the glslang* files has now been fixed. (Requested by zdobersek on #webkit).
      
      Patch by Commit Queue <commit-queue@webkit.org> on 2013-08-16
      
      Source/ThirdParty/ANGLE: 
      
      * GNUmakefile.am: Preserve the libANGLE.la dependency on the ANGLE's GNUmakefile.am.
      
      Source/WebCore: 
      
      * GNUmakefile.am:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@154176 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      93bea371
    • commit-queue@webkit.org's avatar
      [GTK] fixing localizedString method name · 1e53b273
      commit-queue@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=119884
      
      The method name defined in LocalizedStringsGtk.cpp doesn't not match
      the one used in LocalizedStrings.h
      
      Patch by Danilo Cesar Lemes de Paula <danilo.cesar@collabora.co.uk> on 2013-08-16
      Reviewed by Gustavo Noronha Silva.
      
      * platform/gtk/LocalizedStringsGtk.cpp:
      (WebCore::textTrackOffMenuItemText):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@154175 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      1e53b273
    • commit-queue@webkit.org's avatar
      [CSS Masking] Add -webkit-mask-source-type property, with auto, alpha and luminance values · 88cd3de6
      commit-queue@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=119614
      
      Source/WebCore:
      
      Added the -webkit-mask-source-type property, which can have a value of auto, alpha or
      luminance. The default value is auto. This patch contains only the parsing of the property,
      not the actual implementation of the types of masks. The parsing of mask-source-type in the
      -webkit-mask property will be handled in a separate patch.
      
      Patch by Andrei Parvu <parvu@adobe.com> on 2013-08-16
      Reviewed by Dirk Schulze.
      
      Test: fast/masking/parsing-mask-source-type.html
      
      * css/CSSComputedStyleDeclaration.cpp: Added case for CSSPropertyWebkitMaskType.
      (WebCore::ComputedStyleExtractor::propertyValue):
      * css/CSSParser.cpp: Parsed the values for CSSPropertyWebkitMaskType.
      (WebCore::CSSParser::parseValue):
      (WebCore::CSSParser::parseFillProperty):
      * css/CSSProperty.cpp:
      (WebCore::CSSProperty::isInheritedProperty):
      * css/CSSPropertyNames.in: Added -webkit-mask-type property.
      * css/CSSToStyleMap.cpp: map the provided mask type to the FillLayer class.
      (WebCore::CSSToStyleMap::mapFillMaskType):
      * css/CSSToStyleMap.h:
      * css/DeprecatedStyleBuilder.cpp:
      (WebCore::DeprecatedStyleBuilder::DeprecatedStyleBuilder):
      * css/StyleResolver.cpp:
      (WebCore::StyleResolver::applyProperty):
      * rendering/style/FillLayer.cpp: Added the m_maskType property to the FillLayer class.
      (WebCore::FillLayer::FillLayer):
      (WebCore::FillLayer::operator=):
      (WebCore::FillLayer::operator==):
      * rendering/style/FillLayer.h: Added methods for working with m_maskType.
      (WebCore::FillLayer::maskType):
      (WebCore::FillLayer::isMaskTypeSet):
      (WebCore::FillLayer::setMaskType):
      (WebCore::FillLayer::clearMaskType):
      (WebCore::FillLayer::initialMaskType):
      * rendering/style/RenderStyleConstants.h: Added the EMaskSourceType enum.
      
      LayoutTests:
      
      Added tests for the parsing of the -webkit-mask-source-type property
      
      Patch by Andrei Parvu <parvu@adobe.com> on 2013-08-16
      Reviewed by Dirk Schulze.
      
      * fast/masking/parsing-mask-expected.txt:
      * fast/masking/parsing-mask-source-type-expected.txt: Added.
      * fast/masking/parsing-mask-source-type.html: Added.
      * fast/masking/parsing-mask.html:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@154174 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      88cd3de6
    • commit-queue@webkit.org's avatar
      <https://webkit.org/b/119742> REGRESSION(FTL): Fix register usage in mips... · b09e60e9
      commit-queue@webkit.org authored
      <https://webkit.org/b/119742> REGRESSION(FTL): Fix register usage in mips implementation of ctiVMHandleException
      
      Patch by Balazs Kilvady <kilvadyb@homejinni.com> on 2013-08-16
      Reviewed by Allan Sandfeld Jensen.
      
      ctiVMHandleException must jump/return using register ra (r31).
      
      * jit/JITStubsMIPS.h:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@154173 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      b09e60e9
    • rakuco@webkit.org's avatar
      <https://webkit.org/b/119885> [CMake] Always build our generated versions of... · e112f205
      rakuco@webkit.org authored
      <https://webkit.org/b/119885> [CMake] Always build our generated versions of ANGLE's glslang.cpp and glslang_tab.cpp
      
      Reviewed by Gyuyoung Kim.
      
      Now that r154109 has landed, all Bison versions (at least from 2.3 up
      to the latest 3.0) should be able to generate versions of glslang* that
      build correctly.
      
      Since the idea is to remove the prebuilt files from future imports of
      ANGLE, always building our own versions is a good idea, and allows us
      to get rid of some very ugly CMake checks.
      
      * CMakeLists.txt: Always build glslang.cpp and glslang_tab.cpp from
      DERIVED_SOURCES_WEBCORE_DIR.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@154172 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      e112f205
    • simon.pena@samsung.com's avatar
      [GTK] Unreviewed gardening. Rebaseline after r154127 and add new baseline after r153647. · f4636912
      simon.pena@samsung.com authored
      * platform/gtk-wk1/TestExpectations:
      x-frame-options-deny-meta-tag-in-body.html fails in Release and
      Debug.
      * platform/gtk/TestExpectations: CSS Image filter is not enabled
      in GTK bots. Also remove entry for deleted test.
      * platform/gtk/fast/forms/search/search-size-with-decorations-expected.png: Added.
      * platform/gtk/fast/forms/search/search-size-with-decorations-expected.txt: Added.
      * platform/gtk/fast/js/constructor-length-expected.txt:
      Rebaselined after r154127.
      * platform/gtk/fast/js/global-constructors-attributes-dedicated-worker-expected.txt:
      ditto.
      * platform/gtk/fast/js/global-constructors-attributes-expected.txt:
      ditto.
      * platform/gtk/fast/js/global-constructors-attributes-shared-worker-expected.txt:
      ditto.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@154171 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      f4636912
    • commit-queue@webkit.org's avatar
      <https://webkit.org/b/119879> Fix sh4 build after r154156. · 4134c296
      commit-queue@webkit.org authored
      Patch by Julien Brianceau <jbrianceau@nds.com> on 2013-08-16
      Reviewed by Allan Sandfeld Jensen.
      
      Fix typo in JITStubsSH4.h file.
      
      * jit/JITStubsSH4.h:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@154170 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      4134c296
    • allan.jensen@digia.com's avatar
      Reskip tests that times out. · 5fa9af2e
      allan.jensen@digia.com authored
      Unreviewed gardening.
      
      * platform/qt/TestExpectations:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@154169 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      5fa9af2e
    • commit-queue@webkit.org's avatar
      <https://webkit.org/b/119880> [Qt] Build fix (broken since r154142). · 6647ee2f
      commit-queue@webkit.org authored
      Patch by Julien Brianceau <jbrianceau@nds.com> on 2013-08-16
      Reviewed by Gyuyoung Kim.
      
      Since r154142, Frame::loader() is a reference (and not a pointer anymore).
      
      * xml/parser/XMLDocumentParserQt.cpp:
      (WebCore::XMLDocumentParser::parseStartElement):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@154168 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      6647ee2f
    • rgabor@webkit.org's avatar
      [Qt][ARM] Unreviewed buildfix after 154127. · ae0456c2
      rgabor@webkit.org authored
      * WebProcess/WebPage/CoordinatedGraphics/CoordinatedLayerTreeHost.h: Add missing header.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@154167 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      ae0456c2
    • commit-queue@webkit.org's avatar
      [WebGL] Vertex attribute binding validation method · 9232285d
      commit-queue@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=119515
      
      This patch refactors WebGLRenderingContext code by moving the vertex
      attribute binding validation to a separate method. It is now
      possible to use that validation in other parts of the code. The
      code is more clear now.
      
      Patch by Przemyslaw Szymanski <p.szymanski3@samsung.com> on 2013-08-16
      Reviewed by Christophe Dumez.
      
      No new tests. Covered by existing tests. No behaviour changed.
      LayoutTests/webgl/resources/webgl_test_files/conformance/rendering/gl-drawelements.html
      LayoutTests/webgl/resources/webgl_test_files/conformance/rendering/draw-elements-out-of-bounds.html
      LayoutTests/webgl/resources/webgl_test_files/conformance/rendering/draw-arrays-out-of-bounds.html
      
      * html/canvas/WebGLRenderingContext.cpp:
      (WebCore::WebGLRenderingContext::validateVertexAttributes):
      * html/canvas/WebGLVertexArrayObjectOES.h:
      (WebCore::WebGLVertexArrayObjectOES::VertexAttribState::isBound):
      (WebCore::WebGLVertexArrayObjectOES::VertexAttribState::validateBinding):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@154166 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      9232285d
    • antti@apple.com's avatar
      <https://webkit.org/b/119865> Parent pointer and shadow root host pointer should not be shared · f269b27a
      antti@apple.com authored
      Reviewed by Andreas Kling.
      
      Node::m_parentOrShadowHostNode is currently used both as the parent pointer for regular nodes and as the host
      pointer for ShadowRoots. This is confusing. It is also slow as it introduces a branch to all code paths that 
      want to traverse ancestors normally, without leaving the shadow trees. This is much more popular than
      traversing through.
              
      This patch makes the Node have a pure parent pointer only and adds the host element pointer as a separate
      member in ShadowRoot. This eliminates the ShadowRoot test branch from Node::parentNode() as the pointer is
      now always null in the root node.
              
      ShadowRoot grows by a pointer. This is not significant as there are few ShadowRoots compared to Nodes.
      
      * css/StyleResolver.cpp:
      (WebCore::StyleResolver::pushParentShadowRoot):
      (WebCore::StyleResolver::popParentShadowRoot):
      * dom/Attr.cpp:
      (WebCore::Attr::createTextChild):
      * dom/ComposedShadowTreeWalker.cpp:
      (WebCore::ComposedShadowTreeWalker::traverseParentBackToShadowRootOrHost):
      * dom/ContainerNode.cpp:
      (WebCore::ContainerNode::insertBeforeCommon):
      (WebCore::ContainerNode::removeBetween):
      * dom/ContainerNodeAlgorithms.cpp:
      (WebCore::ChildNodeInsertionNotifier::notifyDescendantInsertedIntoDocument):
      (WebCore::ChildNodeRemovalNotifier::notifyDescendantRemovedFromDocument):
      * dom/ContainerNodeAlgorithms.h:
      (WebCore::appendChildToContainer):
      (WebCore::Private::addChildNodesToDeletionQueue):
      * dom/Document.h:
      (WebCore::Node::Node):
      * dom/Element.cpp:
      (WebCore::Element::addShadowRoot):
      (WebCore::Element::removeShadowRoot):
      * dom/ElementRareData.h:
      (WebCore::ElementRareData::releasePseudoElement):
      * dom/EventPathWalker.cpp:
      (WebCore::EventPathWalker::moveToParent):
      * dom/EventRetargeter.cpp:
      (WebCore::determineDispatchBehavior):
      * dom/EventRetargeter.h:
      (WebCore::EventRetargeter::eventTargetRespectingTargetRules):
      * dom/Node.cpp:
      (WebCore::Node::shadowHost):
      (WebCore::Node::deprecatedShadowAncestorNode):
      (WebCore::Node::parentOrShadowHostElement):
      * dom/Node.h:
      (WebCore::Node::hasTreeSharedParent):
              
          Shadow host elements refs the ShadowRoot. There is no reason to use TreeShared to keep it alive.
      
      (WebCore::Node::setParentNode):
      (WebCore::Node::parentNode):
      (WebCore::Node::parentNodeGuaranteedHostFree):
      * dom/PseudoElement.cpp:
      (WebCore::PseudoElement::PseudoElement):
      * dom/ShadowRoot.cpp:
      (WebCore::ShadowRoot::ShadowRoot):
      (WebCore::ShadowRoot::setInnerHTML):
      (WebCore::ShadowRoot::setApplyAuthorStyles):
      (WebCore::ShadowRoot::setResetStyleInheritance):
      * dom/ShadowRoot.h:
              
          Rename host() -> hostElement() for clarity.
      
      (WebCore::Node::parentOrShadowHostNode):
      * dom/Text.cpp:
      (WebCore::isSVGShadowText):
      * dom/TreeScope.cpp:
      (WebCore::TreeScope::focusedElement):
      * html/shadow/ContentDistributor.cpp:
      (WebCore::ContentDistributor::ensureDistribution):
      * html/shadow/InsertionPoint.cpp:
      (WebCore::InsertionPoint::insertedInto):
      (WebCore::InsertionPoint::removedFrom):
      (WebCore::InsertionPoint::parseAttribute):
      * page/DragController.cpp:
      (WebCore::asFileInput):
      * page/EventHandler.cpp:
      (WebCore::EventHandler::handleMousePressEvent):
      (WebCore::instanceAssociatedWithShadowTreeElement):
      * page/FocusController.cpp:
      (WebCore::FocusNavigationScope::owner):
      * rendering/RenderBlock.cpp:
      (WebCore::RenderBlock::hasLineIfEmpty):
      * rendering/RenderLayer.cpp:
      (WebCore::rendererForScrollbar):
      * svg/SVGElementInstance.h:
      (WebCore::SVGElementInstance::setParentNode):
                  
          Renamed so it works with appendChildToContainer template.
      
      * svg/SVGStyledElement.cpp:
      (WebCore::SVGStyledElement::title):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@154165 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      f269b27a
    • zandobersek@gmail.com's avatar
      Unreviewed GTK build fix for debug configurations. · 3b296395
      zandobersek@gmail.com authored
      * webkit/webkitwebframe.cpp:
      (WebKit::kit): Remove the bogus assertion for Frame::loader() that now returns a reference.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@154164 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      3b296395
    • bfulgham@apple.com's avatar
      [Windows] Unreviewed gardening. Correct some test expectations that now pass. · 7f4fd5d2
      bfulgham@apple.com authored
      * platform/win/editing/selection/caret-ltr-right-expected.txt:
      * platform/win/editing/selection/caret-rtl-2-left-expected.txt:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@154163 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      7f4fd5d2
    • mhahnenberg@apple.com's avatar
      <https://webkit.org/b/119833> Concurrent compilation thread should not trigger WriteBarriers · 941ab380
      mhahnenberg@apple.com authored
      Reviewed by Oliver Hunt.
      
      The concurrent compilation thread should interact minimally with the Heap, including not
      triggering WriteBarriers. This is a prerequisite for generational GC.
      
      * JavaScriptCore.xcodeproj/project.pbxproj:
      * bytecode/CodeBlock.cpp:
      (JSC::CodeBlock::addOrFindConstant):
      (JSC::CodeBlock::findConstant):
      * bytecode/CodeBlock.h:
      (JSC::CodeBlock::addConstantLazily):
      * dfg/DFGByteCodeParser.cpp:
      (JSC::DFG::ByteCodeParser::getJSConstantForValue):
      (JSC::DFG::ByteCodeParser::constantUndefined):
      (JSC::DFG::ByteCodeParser::constantNull):
      (JSC::DFG::ByteCodeParser::one):
      (JSC::DFG::ByteCodeParser::constantNaN):
      (JSC::DFG::ByteCodeParser::InlineStackEntry::InlineStackEntry):
      * dfg/DFGCommonData.cpp:
      (JSC::DFG::CommonData::notifyCompilingStructureTransition):
      * dfg/DFGCommonData.h:
      * dfg/DFGDesiredTransitions.cpp: Added.
      (JSC::DFG::DesiredTransition::DesiredTransition):
      (JSC::DFG::DesiredTransition::reallyAdd):
      (JSC::DFG::DesiredTransitions::DesiredTransitions):
      (JSC::DFG::DesiredTransitions::~DesiredTransitions):
      (JSC::DFG::DesiredTransitions::addLazily):
      (JSC::DFG::DesiredTransitions::reallyAdd):
      * dfg/DFGDesiredTransitions.h: Added.
      * dfg/DFGDesiredWeakReferences.cpp: Added.
      (JSC::DFG::DesiredWeakReferences::DesiredWeakReferences):
      (JSC::DFG::DesiredWeakReferences::~DesiredWeakReferences):
      (JSC::DFG::DesiredWeakReferences::addLazily):
      (JSC::DFG::DesiredWeakReferences::reallyAdd):
      * dfg/DFGDesiredWeakReferences.h: Added.
      * dfg/DFGDesiredWriteBarriers.cpp: Added.
      (JSC::DFG::DesiredWriteBarrier::DesiredWriteBarrier):
      (JSC::DFG::DesiredWriteBarrier::trigger):
      (JSC::DFG::DesiredWriteBarriers::DesiredWriteBarriers):
      (JSC::DFG::DesiredWriteBarriers::~DesiredWriteBarriers):
      (JSC::DFG::DesiredWriteBarriers::addImpl):
      (JSC::DFG::DesiredWriteBarriers::trigger):
      * dfg/DFGDesiredWriteBarriers.h: Added.
      (JSC::DFG::DesiredWriteBarriers::add):
      (JSC::DFG::initializeLazyWriteBarrier):
      * dfg/DFGFixupPhase.cpp:
      (JSC::DFG::FixupPhase::truncateConstantToInt32):
      * dfg/DFGGraph.h:
      (JSC::DFG::Graph::convertToConstant):
      * dfg/DFGJITCompiler.h:
      (JSC::DFG::JITCompiler::addWeakReference):
      * dfg/DFGPlan.cpp:
      (JSC::DFG::Plan::Plan):
      (JSC::DFG::Plan::reallyAdd):
      * dfg/DFGPlan.h:
      * dfg/DFGSpeculativeJIT32_64.cpp:
      (JSC::DFG::SpeculativeJIT::compile):
      * dfg/DFGSpeculativeJIT64.cpp:
      (JSC::DFG::SpeculativeJIT::compile):
      * runtime/WriteBarrier.h:
      (JSC::WriteBarrierBase::set):
      (JSC::WriteBarrier::WriteBarrier):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@154162 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      941ab380
    • benjamin@webkit.org's avatar
      Fix x86 32bits build after r154158 · 69c2a1d7
      benjamin@webkit.org authored
      * assembler/X86Assembler.h: Add missing #ifdef for the x86_64 instructions.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@154161 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      69c2a1d7
    • darin@apple.com's avatar
      [iOS] Get iOS port off legacy clipboard · f003159b
      darin@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=116412
      
      Reviewed by Daniel Bates.
      
      * dom/Clipboard.h: Turn off legacy style clipboard for iOS.
      Next patch will be able to remove legacy style entirely!
      
      * editing/Editor.cpp:
      (WebCore::Editor::dispatchCPPEvent): Attach the frame to the
      pasteboard directly explicitly. This is a layering violation, but
      is needed until we change how iOS pasteboard communicates with the
      host to use platform strategies instead of the editor client.
      
      * editing/ios/EditorIOS.mm: Removed Editor::newGeneralClipboard and
      the include of ClipboardIOS.h.
      
      * platform/Pasteboard.h: Added the setFrame function (iOS-only) and
      frame and change count data members.
      
      * platform/ios/ClipboardIOS.h: Emptied out. Later we can remove this.
      * platform/ios/ClipboardIOS.mm: Ditto.
      
      * platform/ios/PasteboardIOS.mm:
      (WebCore::Pasteboard::Pasteboard): Initialize m_frame to zero.
      (WebCore::Pasteboard::createForCopyAndPaste): Added.
      (WebCore::Pasteboard::createPrivate): Added.
      (WebCore::Pasteboard::writePasteboard): Added. Empty function, like
      writeClipboard. Eventually need to remove or implement this.
      (WebCore::Pasteboard::setFrame): Added. Sets frame and change count.
      (WebCore::Pasteboard::hasData): Moved here from ClipboardIOS.
      (WebCore::utiTypeFromCocoaType): Ditto.
      (WebCore::cocoaTypeFromHTMLClipboardType): Ditto.
      (WebCore::Pasteboard::clear): Ditto.
      (WebCore::Pasteboard::readString): Ditto.
      (WebCore::addHTMLClipboardTypesForCocoaType): Ditto.
      (WebCore::Pasteboard::writeString): Ditto.
      (WebCore::Pasteboard::types): Ditto.
      (WebCore::Pasteboard::readFilenames): Ditto.
      
      * WebCore.exp.in: Move Clipboard destructor from Mac-only section to
      common section shared by Mac and iOS.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@154160 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      f003159b
    • rniwa@webkit.org's avatar
      Build fix attempt after r154156. · c9e74feb
      rniwa@webkit.org authored
      * jit/JITStubs.cpp:
      (JSC::cti_vm_handle_exception): encode!
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@154159 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      c9e74feb
    • benjamin@webkit.org's avatar
      [JSC] x86: Use inc and dec when possible · a3ceaf4a
      benjamin@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=119831
      
      Reviewed by Geoffrey Garen.
      
      When incrementing or decrementing by an immediate of 1, use the insctructions
      inc and dec instead of add and sub.
      The instructions have good timing and their encoding is smaller.
      
      * assembler/MacroAssemblerX86Common.h:
      (JSC::MacroAssemblerX86_64::add32):
      (JSC::MacroAssemblerX86_64::sub32):
      * assembler/MacroAssemblerX86_64.h:
      (JSC::MacroAssemblerX86_64::add64):
      (JSC::MacroAssemblerX86_64::sub64):
      * assembler/X86Assembler.h:
      (JSC::X86Assembler::dec_r):
      (JSC::X86Assembler::decq_r):
      (JSC::X86Assembler::inc_r):
      (JSC::X86Assembler::incq_r):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@154158 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      a3ceaf4a
    • fpizlo@apple.com's avatar
      Sometimes, the DFG uses a GetById for typed array length accesses despite... · 151e9aff
      fpizlo@apple.com authored
      Sometimes, the DFG uses a GetById for typed array length accesses despite profiling data that indicates that it's a typed array length access
      https://bugs.webkit.org/show_bug.cgi?id=119874
      
      Reviewed by Oliver Hunt and Mark Hahnenberg.
              
      It was a confusion between heuristics in DFG::ArrayMode that are assuming that
      you'll use ForceExit if array profiles are empty, the JIT creating empty profiles
      sometimes for typed array length accesses, and the FixupPhase assuming that a
      ForceExit ArrayMode means that it should continue using a generic GetById.
      
      This fixes the confusion.
      
      * dfg/DFGFixupPhase.cpp:
      (JSC::DFG::FixupPhase::fixupNode):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@154157 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      151e9aff