1. 27 Sep, 2011 40 commits
    • commit-queue@webkit.org's avatar
      Unreviewed, rolling out r96131. · 3b381c1e
      commit-queue@webkit.org authored
      http://trac.webkit.org/changeset/96131
      https://bugs.webkit.org/show_bug.cgi?id=68927
      
      It made 18+ tests crash on all platform (Requested by
      Ossy_night on #webkit).
      
      Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2011-09-27
      
      Source/JavaScriptCore:
      
      * JavaScriptCore.exp:
      * JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:
      * interpreter/Interpreter.cpp:
      (JSC::Interpreter::throwException):
      * interpreter/Interpreter.h:
      * jsc.cpp:
      (GlobalObject::finishCreation):
      * parser/Parser.h:
      (JSC::Parser::parse):
      * runtime/CommonIdentifiers.h:
      * runtime/Error.cpp:
      (JSC::addErrorInfo):
      * runtime/Error.h:
      
      LayoutTests:
      
      * fast/js/exception-properties-expected.txt:
      * fast/js/script-tests/exception-properties.js:
      * fast/js/script-tests/stack-trace.js: Removed.
      * fast/js/stack-trace-expected.txt: Removed.
      * fast/js/stack-trace.html: Removed.
      * platform/chromium/test_expectations.txt:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@96146 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      3b381c1e
    • commit-queue@webkit.org's avatar
      [Qt] QDesktopWebView load zero size view test missing · e0804487
      commit-queue@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=68655
      
      Patch by Gopal Raghavan <gopal.1.raghavan@nokia.com> on 2011-09-27
      Reviewed by Chang Shu.
      
      Added test case to check load behavior with zero size view.
      
      * UIProcess/API/qt/tests/qmltests/DesktopWebView/tst_loadZeroSizeView.qml: Added.
      * UIProcess/API/qt/tests/qmltests/qmltests.pro:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@96145 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      e0804487
    • levin@chromium.org's avatar
      watchlist: Add the filename pattern for definitions. · 8c1d52fb
      levin@chromium.org authored
      https://bugs.webkit.org/show_bug.cgi?id=68917
      
      Reviewed by Adam Barth.
      
      * Scripts/webkitpy/common/watchlist/filenamepattern.py: Added.
      * Scripts/webkitpy/common/watchlist/filenamepattern_unittest.py: Added.
      * Scripts/webkitpy/common/watchlist/watchlist.py: Added the filename pattern
      for definitions.
      * Scripts/webkitpy/common/watchlist/watchlist_unittest.py: Added tests.
      * Scripts/webkitpy/common/watchlist/watchlistparser_unittest.py: Typo fix.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@96144 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      8c1d52fb
    • mhahnenberg@apple.com's avatar
      De-virtualize JSCell::getPrimitiveNumber · 061133e0
      mhahnenberg@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=68851
      
      Reviewed by Darin Adler.
      
      * JavaScriptCore.exp:
      * JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:
      
      Changed JSCell::getPrimitiveNumber to manually handle the dispatch for 
      JSCells (JSObject and JSString in this case).
      * runtime/JSCell.cpp:
      (JSC::JSCell::getPrimitiveNumber):
      * runtime/JSCell.h:
      
      Removed JSNotAnObject::getPrimitiveNumber since its return value doesn't 
      matter and it already implements defaultValue, so JSObject::getPrimitiveNumber
      can cover the case for JSNotAnObject.
      * runtime/JSNotAnObject.cpp:
      * runtime/JSNotAnObject.h:
      
      De-virtualized JSObject::getPrimitiveNumber and JSString::getPrimitiveNumber 
      and changed them to be const.  Also made JSString::getPrimitiveNumber public 
      because it needs to be called from JSCell::getPrimitiveNumber and also since it's 
      no longer virtual, we want people who have a more specific pointer (JSString* 
      instead of JSCell*) to not have to pay the cost of a virtual method call.
      * runtime/JSObject.cpp:
      (JSC::JSObject::getPrimitiveNumber):
      * runtime/JSObject.h:
      * runtime/JSString.cpp:
      (JSC::JSString::getPrimitiveNumber):
      * runtime/JSString.h:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@96143 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      061133e0
    • dino@apple.com's avatar
      Add 'filter' value to RenderStyle · 5a05ec18
      dino@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=68471
      
      Reviewed by Simon Fraser.
      
      Add a filter property to RenderStyle when ENABLE(CSS_FILTERS)
      is turned on. Similar to -webkit-transform, -webkit-filter is a
      list of FilterOperations, each identifying what type of operation
      it is. This change simply adds the basic objects, it does not
      parse the property to generate the list.
      
      * CMakeLists.txt:
      * GNUmakefile.list.am:
      * WebCore.gypi:
      * WebCore.pro:
      * WebCore.vcproj/WebCore.vcproj:
      * WebCore.xcodeproj/project.pbxproj:
      * platform/graphics/filters/FilterOperation.h: Added.
      (WebCore::FilterOperation::~FilterOperation):
      (WebCore::FilterOperation::operator!=):
      (WebCore::FilterOperation::getOperationType):
      (WebCore::FilterOperation::isSameType):
      (WebCore::FilterOperation::FilterOperation):
      (WebCore::ReferenceFilterOperation::create):
      (WebCore::ReferenceFilterOperation::reference):
      (WebCore::ReferenceFilterOperation::operator==):
      (WebCore::ReferenceFilterOperation::ReferenceFilterOperation):
      (WebCore::BasicColorMatrixFilterOperation::create):
      (WebCore::BasicColorMatrixFilterOperation::amount):
      (WebCore::BasicColorMatrixFilterOperation::operator==):
      (WebCore::BasicColorMatrixFilterOperation::BasicColorMatrixFilterOperation):
      (WebCore::BasicComponentTransferFilterOperation::create):
      (WebCore::BasicComponentTransferFilterOperation::amount):
      (WebCore::BasicComponentTransferFilterOperation::operator==):
      (WebCore::BasicComponentTransferFilterOperation::BasicComponentTransferFilterOperation):
      (WebCore::GammaFilterOperation::create):
      (WebCore::GammaFilterOperation::amplitude):
      (WebCore::GammaFilterOperation::exponent):
      (WebCore::GammaFilterOperation::offset):
      (WebCore::GammaFilterOperation::operator==):
      (WebCore::GammaFilterOperation::GammaFilterOperation):
      (WebCore::BlurFilterOperation::create):
      (WebCore::BlurFilterOperation::stdDeviationX):
      (WebCore::BlurFilterOperation::stdDeviationY):
      (WebCore::BlurFilterOperation::operator==):
      (WebCore::BlurFilterOperation::BlurFilterOperation):
      (WebCore::SharpenFilterOperation::create):
      (WebCore::SharpenFilterOperation::radius):
      (WebCore::SharpenFilterOperation::threshold):
      (WebCore::SharpenFilterOperation::amount):
      (WebCore::SharpenFilterOperation::operator==):
      (WebCore::SharpenFilterOperation::SharpenFilterOperation):
      (WebCore::DropShadowFilterOperation::create):
      (WebCore::DropShadowFilterOperation::shadow):
      (WebCore::DropShadowFilterOperation::operator==):
      (WebCore::DropShadowFilterOperation::DropShadowFilterOperation):
      * platform/graphics/filters/FilterOperations.cpp: Added.
      (WebCore::FilterOperations::FilterOperations):
      (WebCore::FilterOperations::operator==):
      * platform/graphics/filters/FilterOperations.h: Added.
      (WebCore::FilterOperations::operator!=):
      (WebCore::FilterOperations::clear):
      (WebCore::FilterOperations::operations):
      (WebCore::FilterOperations::size):
      (WebCore::FilterOperations::at):
      * rendering/style/RenderStyle.cpp:
      (WebCore::RenderStyle::RenderStyle):
      * rendering/style/RenderStyle.h:
      (WebCore::InheritedFlags::filter):
      (WebCore::InheritedFlags::hasFilter):
      (WebCore::InheritedFlags::setFilter):
      (WebCore::InheritedFlags::initialFilter):
      * rendering/style/StyleAllInOne.cpp: Added include of new StyleFilterData.
      * rendering/style/StyleFilterData.cpp: Added.
      (WebCore::StyleFilterData::StyleFilterData):
      (WebCore::StyleFilterData::operator==):
      * rendering/style/StyleFilterData.h: Added.
      (WebCore::StyleFilterData::create):
      (WebCore::StyleFilterData::copy):
      (WebCore::StyleFilterData::operator!=):
      * rendering/style/StyleRareNonInheritedData.cpp:
      (WebCore::StyleRareNonInheritedData::StyleRareNonInheritedData):
      (WebCore::StyleRareNonInheritedData::operator==):
      * rendering/style/StyleRareNonInheritedData.h: New filter DataRef.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@96142 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      5a05ec18
    • jamesr@google.com's avatar
      [chromium] LayerRenderChromium asserts about leaking textures. · 4b83315e
      jamesr@google.com authored
      https://bugs.webkit.org/show_bug.cgi?id=68190
      
      Reviewed by Kenneth Russell.
      
      This introduces an interface TextureAllocator that the TextureManager uses to allocate/deallocate textures.
      This means that TextureManager does not need to depend directly on GraphicsContext3D, other than for the format
      enum type, making it more testable.  It also allows us to track the allocations by subclassing TextureAllocator
      to make sure we aren't leaking any textures.
      
      * WebCore.gypi:
      * platform/graphics/chromium/Canvas2DLayerChromium.cpp:
      (WebCore::Canvas2DLayerChromium::updateCompositorResources):
      * platform/graphics/chromium/Canvas2DLayerChromium.h:
      * platform/graphics/chromium/ImageLayerChromium.cpp:
      (WebCore::ImageLayerTextureUpdater::updateTextureRect):
      * platform/graphics/chromium/LayerChromium.h:
      (WebCore::LayerChromium::updateCompositorResources):
      * platform/graphics/chromium/LayerRendererChromium.cpp:
      (WebCore::LayerRendererChromium::LayerRendererChromium):
      (WebCore::LayerRendererChromium::releaseRenderSurfaceTextures):
      (WebCore::LayerRendererChromium::drawLayers):
      (WebCore::LayerRendererChromium::useRenderSurface):
      (WebCore::LayerRendererChromium::initializeSharedObjects):
      (WebCore::LayerRendererChromium::cleanupSharedObjects):
      * platform/graphics/chromium/LayerRendererChromium.h:
      (WebCore::LayerRendererChromium::renderSurfaceTextureAllocator):
      (WebCore::LayerRendererChromium::contentsTextureAllocator):
      * platform/graphics/chromium/LayerTextureUpdater.h:
      * platform/graphics/chromium/LayerTextureUpdaterCanvas.cpp:
      (WebCore::LayerTextureUpdaterBitmap::updateTextureRect):
      (WebCore::LayerTextureUpdaterSkPicture::updateTextureRect):
      * platform/graphics/chromium/LayerTextureUpdaterCanvas.h:
      * platform/graphics/chromium/ManagedTexture.cpp:
      (WebCore::ManagedTexture::bindTexture):
      (WebCore::ManagedTexture::framebufferTexture2D):
      * platform/graphics/chromium/ManagedTexture.h:
      * platform/graphics/chromium/TextureManager.cpp:
      (WebCore::TextureManager::memoryUseBytes):
      (WebCore::TextureManager::deleteEvictedTextures):
      (WebCore::TextureManager::evictAndDeleteAllTextures):
      (WebCore::TextureManager::removeTexture):
      (WebCore::TextureManager::allocateTexture):
      (WebCore::TextureManager::requestTexture):
      * platform/graphics/chromium/TextureManager.h:
      (WebCore::TextureAllocator::~TextureAllocator):
      * platform/graphics/chromium/TiledLayerChromium.cpp:
      (WebCore::TiledLayerChromium::updateCompositorResources):
      * platform/graphics/chromium/TiledLayerChromium.h:
      * platform/graphics/chromium/TrackingTextureAllocator.cpp: Added.
      (WebCore::TrackingTextureAllocator::TrackingTextureAllocator):
      (WebCore::TrackingTextureAllocator::~TrackingTextureAllocator):
      (WebCore::TrackingTextureAllocator::createTexture):
      (WebCore::TrackingTextureAllocator::deleteTexture):
      * platform/graphics/chromium/TrackingTextureAllocator.h: Copied from Source/WebCore/platform/graphics/chromium/ManagedTexture.h.
      (WebCore::TrackingTextureAllocator::create):
      (WebCore::TrackingTextureAllocator::currentMemoryUseBytes):
      * platform/graphics/chromium/VideoLayerChromium.cpp:
      (WebCore::VideoLayerChromium::updateCompositorResources):
      (WebCore::VideoLayerChromium::updateTexture):
      * platform/graphics/chromium/VideoLayerChromium.h:
      * platform/graphics/chromium/WebGLLayerChromium.cpp:
      (WebCore::WebGLLayerChromium::updateCompositorResources):
      * platform/graphics/chromium/WebGLLayerChromium.h:
      * platform/graphics/chromium/cc/CCHeadsUpDisplay.cpp:
      (WebCore::CCHeadsUpDisplay::draw):
      * platform/graphics/chromium/cc/CCLayerTreeHost.cpp:
      (WebCore::CCLayerTreeHost::~CCLayerTreeHost):
      (WebCore::CCLayerTreeHost::deleteContentsTexturesOnCCThread):
      (WebCore::CCLayerTreeHost::commitToOnCCThread):
      (WebCore::CCLayerTreeHost::didRecreateGraphicsContext):
      (WebCore::CCLayerTreeHost::updateCompositorResources):
      * platform/graphics/chromium/cc/CCLayerTreeHost.h:
      * platform/graphics/chromium/cc/CCLayerTreeHostImpl.cpp:
      (WebCore::CCLayerTreeHostImpl::contentsTextureAllocator):
      (WebCore::CCLayerTreeHostImpl::initializeLayerRenderer):
      * platform/graphics/chromium/cc/CCLayerTreeHostImpl.h:
      * platform/graphics/chromium/cc/CCRenderSurface.cpp:
      (WebCore::CCRenderSurface::drawSurface):
      * platform/graphics/chromium/cc/CCSingleThreadProxy.cpp:
      (WebCore::CCSingleThreadProxy::setNeedsCommit):
      (WebCore::CCSingleThreadProxy::stop):
      (WebCore::CCSingleThreadProxy::recreateContextIfNeeded):
      (WebCore::CCSingleThreadProxy::commitIfNeeded):
      * platform/graphics/chromium/cc/CCThreadProxy.cpp:
      (WebCore::CCThreadProxy::commitOnCCThread):
      (WebCore::CCThreadProxy::layerTreeHostClosedOnCCThread):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@96141 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      4b83315e
    • commit-queue@webkit.org's avatar
      [EFL] Make ewk_view emit the "load,document,finished" signal. · 574618d1
      commit-queue@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=66782
      
      Patch by Raphael Kubo da Costa <kubo@profusion.mobi> on 2011-09-27
      Reviewed by Antonio Gomes.
      
      Currently, only ewk_frame emits the "load,document,finished" signal
      when FrameLoaderClientEfl::dispatchDidFinishDocumentLoad() calls
      ewk_frame_load_document_finished().
      
      However, in some cases it is not even possible to connect to the
      "frame,created" signal to properly monitor the
      "load,document,finished" signal, as the former is not emitted.
      fast/frames/frame-unload-crash.html, for example, has a page with an
      iframe inside an iframe, and this innermost iframe does not seem to be
      loaded via FrameLoaderClientEfl::createFrame (which calls all the
      machinery which then emits the "frame,created" signal).
      
      We now make ewk_frame_load_document_finished() call the newly-created
      ewk_view_load_document_finished() function, whose job is to emit the
      "load,document,signal" with the frame as its parameter. This way, one
      can just connect to the view and make sure all the signals will get
      delivered.
      
      * ewk/ewk_frame.cpp:
      (ewk_frame_load_document_finished):
      * ewk/ewk_private.h:
      * ewk/ewk_view.cpp:
      (ewk_view_load_document_finished):
      * ewk/ewk_view.h:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@96140 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      574618d1
    • robert@webkit.org's avatar
      Reviewed by David Hyatt. · ec941c9f
      robert@webkit.org authored
      Replaced elements squeezed when width is specified as percentage inside a table with Auto layout
      https://bugs.webkit.org/show_bug.cgi?id=29447
      
      Source/WebCore:
      
      If inserting a 'replaced' element (e.g. image, plugin) in a table cell that is not descendant from
      a block with fixed layout then do not squeeze the element, let it use its intrinsic width and height.
      
      Test: fast/replaced/table-percent-width.html
      
      * rendering/RenderBox.cpp:
      (WebCore::avoidSqueezingWidth):
      (WebCore::avoidSqueezingHeight):
      (WebCore::RenderBox::containingBlockReplacedLogicalWidthForContent):
      (WebCore::RenderBox::computeReplacedLogicalWidthUsing):
      (WebCore::RenderBox::computeReplacedLogicalHeightUsing):
      * rendering/RenderBox.h:
      
      LayoutTests:
      
      * fast/replaced/table-percent-width.html: Added.
      * fast/replaced/table-percent-width-expected.txt: Added.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@96139 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      ec941c9f
    • simon.fraser@apple.com's avatar
      https://bugs.webkit.org/show_bug.cgi?id=67858 · c8bf6391
      simon.fraser@apple.com authored
      Roll r96070 back in now that the crash has been fixed in r96130.
      
      Source/WebCore:
      
      Reviewed by Darin Adler.
      
      When non-overlay scrollbars are hidden on a composited iframe, nothing invalidated
      the scrollbar areas or the scroll corner, so the scrollbars appear to remain.
      
      Fix by invalidating the scrollbars and scroll corner when they are removed. Invalidation
      on scrollbar creation appears to happen via updating the scrollbar style.
      
      Tested by compositing/iframes/repaint-after-losing-scrollbars.html which no longer shows
      stale scrollbars when run manually, even though the green squares are missing from the
      pixel result (bug 67878).
      
      * page/FrameView.cpp:
      (WebCore::FrameView::updateScrollCorner): Pass the corner rect into invalidateScrollCorner().
      * platform/ScrollView.cpp:
      (WebCore::ScrollView::setHasHorizontalScrollbar): Invalidate the scrollbar area if hiding it.
      (WebCore::ScrollView::setHasVerticalScrollbar): Ditto.
      (WebCore::ScrollView::updateScrollbars): In the case where both scrollbars are going away,
      compute the scroll corner rect while we still have scrollbars, and then invalidate it
      explicitly. (updateScrollCorner() doesn't, because it doesn't have access to the old corner
      rect.)
      * platform/ScrollableArea.cpp:
      (WebCore::ScrollableArea::invalidateScrollCorner): Pass the rect in, because we can't
      compute it in the case where the scrollbars are going away.
      * platform/ScrollableArea.h: Pass in a rect to invalidateScrollCorner(), which matches
      invalidateScrollbar().
      * rendering/RenderLayerCompositor.cpp:
      (WebCore::RenderLayerCompositor::destroyRootLayer): Pass the corner rect into invalidateScrollCorner().
      * rendering/RenderScrollbarPart.cpp: Ditto.
      (WebCore::RenderScrollbarPart::imageChanged): Ditto.
      
      LayoutTests:
      
      * compositing/iframes/repaint-after-losing-scrollbars-expected.png:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@96138 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      c8bf6391
    • mihaip@chromium.org's avatar
      Fix Chromium Mac build after r96130. · 4a6f4af4
      mihaip@chromium.org authored
      * page/FrameView.cpp:
      (WebCore::FrameView::layerForOverhangAreas):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@96137 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      4a6f4af4
    • carlosgc@webkit.org's avatar
      [GTK] Use WebKitWebContext in WebKitWebView · 26674bdc
      carlosgc@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=67990
      
      Reviewed by Martin Robinson.
      
      Use webkit_web_context_get_default() instead of
      WKContextGetSharedProcessContext() and add API to create a view
      with a given web context and to return the current context
      associated to the view.
      
      * GNUmakefile.am: Add new files to compilation.
      * UIProcess/API/gtk/WebKitPrivate.h: Added.
      * UIProcess/API/gtk/WebKitWebContext.cpp:
      (webkitWebContextGetWKContext): Private API to get the WKContext
      wrapped by the WebKitWebContext.
      * UIProcess/API/gtk/WebKitWebContextPrivate.h: Added.
      * UIProcess/API/gtk/WebKitWebView.cpp:
      (webkitWebViewConstructed): Create the webpage using the web
      context of the view.
      (webkitWebViewSetProperty):
      (webkitWebViewGetProperty):
      (webkit_web_view_init):
      (webkit_web_view_class_init):
      (webkit_web_view_new): Create a new view with the default context.
      (webkit_web_view_new_with_context): Create a new view with the
      given context.
      (webkit_web_view_get_context): Return the context.
      * UIProcess/API/gtk/WebKitWebView.h:
      * UIProcess/API/gtk/tests/testwebview.c: Added.
      (testWebViewDefaultContext):
      (main):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@96136 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      26674bdc
    • commit-queue@webkit.org's avatar
      [v8] Code calling the typed array optimization script is fragile, depends on typed array hierarchy. · 0687d09a
      commit-queue@webkit.org authored
      Install the flag, which indicates whether or not the optimization
      script was executed, on the global object.
      
      https://bugs.webkit.org/show_bug.cgi?id=68890
      
      Patch by Ulan Degenbaev <ulan@chromium.org> on 2011-09-27
      Reviewed by Kenneth Russell.
      
      * Source/WebCore/bindings/v8/custom/V8ArrayBufferViewCustom.cpp:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@96135 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      0687d09a
    • commit-queue@webkit.org's avatar
      Autofocus on readonly inputs does not focus the element. · c35469b2
      commit-queue@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=24092
      
      Patch by Kaustubh Atrawalkar <kaustubh@motorola.com> on 2011-09-27
      Reviewed by Ryosuke Niwa.
      
      Source/WebCore:
      
      Readonly input elements should be autofocusable. Removed the check.
      
      Tests: fast/forms/autofocus-readonly-attribute.html
      
      * html/HTMLFormControlElement.cpp:
      (WebCore::shouldAutofocus):
      
      LayoutTests:
      
      * fast/forms/autofocus-readonly-attribute-expected.txt: Added.
      * fast/forms/autofocus-readonly-attribute.html: Added.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@96134 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      c35469b2
    • carlosgc@webkit.org's avatar
      [GTK] Add WebKitWebContext to GTK API · aa8dbecd
      carlosgc@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=67931
      
      Reviewed by Philippe Normand.
      
      Initial implementation of WebKitWebContext for WebKit2 GTK API.
      
      * GNUmakefile.am: Add new files to compilation.
      * UIProcess/API/gtk/WebKitWebContext.cpp: Added.
      (webkitWebContextFinalize):
      (webkit_web_context_init):
      (webkit_web_context_class_init):
      (createDefaultWebContext):
      (webkit_web_context_get_default):
      * UIProcess/API/gtk/WebKitWebContext.h: Added.
      * UIProcess/API/gtk/tests/testwebcontext.c:
      (testWebContextDefault):
      (main):
      * UIProcess/API/gtk/webkit2.h: Add <webkit2/WebKitWebContext.h>.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@96133 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      aa8dbecd
    • mihaip@chromium.org's avatar
      Remove duplicate of fast/text/international/Geeza-Pro-vertical-metrics-adjustment.html · 870d6bdd
      mihaip@chromium.org authored
      https://bugs.webkit.org/show_bug.cgi?id=68915
      
      Reviewed by Ryosuke Niwa.
      
      r92496 and r92881 were only trying to move the baselines to
      platform/mac-snowleopard/platform/mac/fast, but they also inadvertedly
      copied the test itself.
      
      * platform/mac-snowleopard/platform/mac/fast/text/international/Geeza-Pro-vertical-metrics-adjustment.html: Removed.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@96132 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      870d6bdd
    • commit-queue@webkit.org's avatar
      Implement Error.stack · f177874f
      commit-queue@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=66994
      
      Patch by Juan Carlos Montemayor Elosua <j.mont@me.com> on 2011-09-27
      Reviewed by Oliver Hunt.
      
      Source/JavaScriptCore:
      
      This patch utilizes topCallFrame to create a stack trace when
      an error is thrown. Users will also be able to use the stack()
      command in jsc to get arrays with stack trace information.
      
      * JavaScriptCore.exp:
      * JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:
      * interpreter/Interpreter.cpp:
      (JSC::getCallerLine):
      (JSC::getSourceURLFromCallFrame):
      (JSC::getStackFrameCodeType):
      (JSC::Interpreter::getStackTrace):
      (JSC::Interpreter::throwException):
      * interpreter/Interpreter.h:
      (JSC::StackFrame::toString):
      * jsc.cpp:
      (GlobalObject::finishCreation):
      (functionJSCStack):
      * parser/Parser.h:
      (JSC::Parser::parse):
      * runtime/CommonIdentifiers.h:
      * runtime/Error.cpp:
      (JSC::addErrorInfo):
      * runtime/Error.h:
      
      LayoutTests:
      
      Unit tests that contain both normal and special cases for stack trace
      generation.
      
      * fast/js/exception-properties-expected.txt:
      * fast/js/script-tests/exception-properties.js:
      * fast/js/script-tests/stack-trace.js: Added.
      (printStack):
      (hostThrower):
      (callbacker):
      (outer):
      (inner):
      (evaler):
      (normalOuter):
      (normalInner):
      (scripterInner):
      (scripterOuter):
      * fast/js/stack-trace-expected.txt: Added.
      * fast/js/stack-trace.html: Added.
      * platform/chromium/test_expectations.txt:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@96131 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      f177874f
    • simon.fraser@apple.com's avatar
      Clean up how FrameView accesses the RenderView · 2839bc0f
      simon.fraser@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=68914
      
      Reviewed by Sam Weinig.
      
      Clean up how FrameView accesses the content renderer of its
      frame. Previously, this was done in several different ways,
      only some of which did null-checking.
      
      Use an inline method to avoid having to expose Frame
      in the header.
      
      Standardize the terminology to use 'root' for this RenderView.
      
      * page/FrameView.cpp:
      (WebCore::rootRenderer):
      (WebCore::FrameView::setFrameRect):
      (WebCore::FrameView::adjustViewSize):
      (WebCore::FrameView::updateCompositingLayers):
      (WebCore::FrameView::clearBackingStores):
      (WebCore::FrameView::restoreBackingStores):
      (WebCore::FrameView::layerForHorizontalScrollbar):
      (WebCore::FrameView::layerForVerticalScrollbar):
      (WebCore::FrameView::layerForScrollCorner):
      (WebCore::FrameView::layerForOverhangAreas):
      (WebCore::FrameView::syncCompositingStateForThisFrame):
      (WebCore::FrameView::hasCompositedContent):
      (WebCore::FrameView::enterCompositingMode):
      (WebCore::FrameView::isSoftwareRenderable):
      (WebCore::FrameView::didMoveOnscreen):
      (WebCore::FrameView::willMoveOffscreen):
      (WebCore::FrameView::layout):
      (WebCore::FrameView::embeddedContentBox):
      (WebCore::FrameView::contentsInCompositedLayer):
      (WebCore::FrameView::scrollContentsFastPath):
      (WebCore::FrameView::scrollContentsSlowPath):
      (WebCore::FrameView::maintainScrollPositionAtAnchor):
      (WebCore::FrameView::scrollPositionChanged):
      (WebCore::FrameView::repaintFixedElementsAfterScrolling):
      (WebCore::FrameView::visibleContentsResized):
      (WebCore::FrameView::scheduleRelayoutOfSubtree):
      (WebCore::FrameView::needsLayout):
      (WebCore::FrameView::setNeedsLayout):
      (WebCore::FrameView::performPostLayoutTasks):
      (WebCore::FrameView::updateControlTints):
      (WebCore::FrameView::paintContents):
      (WebCore::FrameView::forceLayoutForPagination):
      (WebCore::FrameView::adjustPageHeightDeprecated):
      (WebCore::FrameView::isVerticalDocument):
      (WebCore::FrameView::isFlippedDocument):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@96130 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      2839bc0f
    • abarth@webkit.org's avatar
      garden-o-matic results view should sort test and builder names · 28c2cb2c
      abarth@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=68488
      
      Reviewed by Andy Estes.
      
      Previously, the test and builder names were displayed in an arbitrary
      order that changed from time to time.  That confused one user study
      participant.  This patch sorts the lists so that they occur in a
      predictable order.
      
      * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/results.js:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@96129 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      28c2cb2c
    • enne@google.com's avatar
      [Chromium] Layout Test compositing/video-page-visibility.html is failing on GPU linux · d93e30c5
      enne@google.com authored
      https://bugs.webkit.org/show_bug.cgi?id=68882
      
      	Unreviewed rebaseline.
      
      * platform/chromium-gpu-linux/compositing/video-page-visibility-expected.png: Added.
      * platform/chromium/test_expectations.txt:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@96128 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      d93e30c5
    • commit-queue@webkit.org's avatar
      AXObjectCache cleared unnecessarily when non-top Document is detached. · e45033b8
      commit-queue@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=68636
      
      Patch by Dominic Mazzoni <dmazzoni@google.com> on 2011-09-27
      Reviewed by Chris Fleizach.
      
      Source/WebCore:
      
      Test: accessibility/deleting-iframe-destroys-axcache.html
      
      * dom/Document.cpp:
      (WebCore::Document::attach):
      (WebCore::Document::detach):
      
      LayoutTests:
      
      * accessibility/deleting-iframe-destroys-axcache.html: Added.
      * platform/mac/accessibility/deleting-iframe-destroys-axcache-expected.txt: Added.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@96127 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      e45033b8
    • commit-queue@webkit.org's avatar
      Unreviewed, rolling out r96108, r96111, r96113, and r96116. · 6c81e4a8
      commit-queue@webkit.org authored
      http://trac.webkit.org/changeset/96108
      http://trac.webkit.org/changeset/96111
      http://trac.webkit.org/changeset/96113
      http://trac.webkit.org/changeset/96116
      https://bugs.webkit.org/show_bug.cgi?id=68913
      
      Wait for working Qt5 (Requested by ossy on #webkit).
      
      Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2011-09-27
      
      .:
      
      * Source/WebKit.pro:
      
      Source/WebCore:
      
      * WebCore.pri:
      * platform/graphics/qt/GraphicsLayerQt.cpp:
      
      Source/WebKit/qt:
      
      * Api/qgraphicswebview.cpp:
      * Api/qgraphicswebview.h:
      * Api/qwebframe.h:
      * Api/qwebhistory.h:
      * Api/qwebpage.h:
      * Api/qwebsettings.h:
      * Api/qwebview.h:
      * QtWebKit.pro:
      * WebCoreSupport/PageClientQt.h:
      * WebCoreSupport/QtWebComboBox.cpp:
      * WebCoreSupport/QtWebComboBox.h:
      * declarative/declarative.pro:
      * declarative/qdeclarativewebview.cpp:
      * declarative/qdeclarativewebview_p.h:
      * docs/webkitsnippets/webpage/main.cpp:
      * examples/platformplugin/WebNotificationPresenter.h:
      * tests/tests.pri:
      
      Source/WebKit2:
      
      * UIProcess/API/qt/qdesktopwebview.cpp:
      (QDesktopWebViewPrivate::startDrag):
      (QDesktopWebViewPrivate::didChangeToolTip):
      (QDesktopWebViewPrivate::didChangeCursor):
      (QDesktopWebViewPrivate::showContextMenu):
      (QDesktopWebViewPrivate::chooseFiles):
      * UIProcess/API/qt/qdesktopwebview.h:
      * UIProcess/API/qt/tests/tests.pri:
      * UIProcess/API/qt/tests/tests.pro:
      * UIProcess/qt/ViewInterface.h:
      * UIProcess/qt/WebPopupMenuProxyQtDesktop.cpp:
      (WebKit::WebPopupMenuProxyQtDesktop::WebPopupMenuProxyQtDesktop):
      
      Tools:
      
      * DumpRenderTree/qt/DumpRenderTree.pro:
      * DumpRenderTree/qt/ImageDiff.pro:
      * MiniBrowser/qt/BrowserView.cpp:
      (BrowserView::BrowserView):
      * MiniBrowser/qt/BrowserView.h:
      * MiniBrowser/qt/BrowserWindow.cpp:
      (BrowserWindow::BrowserWindow):
      (BrowserWindow::urlChanged):
      (BrowserWindow::~BrowserWindow):
      * MiniBrowser/qt/BrowserWindow.h:
      * MiniBrowser/qt/MiniBrowser.pro:
      * MiniBrowser/qt/MiniBrowserApplication.h:
      * MiniBrowser/qt/main.cpp:
      * QtTestBrowser/QtTestBrowser.pro:
      * QtTestBrowser/launcherwindow.cpp:
      * QtTestBrowser/launcherwindow.h:
      * QtTestBrowser/locationedit.h:
      * QtTestBrowser/main.cpp:
      * QtTestBrowser/mainwindow.cpp:
      * QtTestBrowser/mainwindow.h:
      * QtTestBrowser/webinspector.h:
      * QtTestBrowser/webpage.cpp:
      * QtTestBrowser/webview.cpp:
      * WebKitTestRunner/InjectedBundle/qt/InjectedBundle.pro:
      * WebKitTestRunner/PlatformWebView.h:
      * WebKitTestRunner/qt/EventSenderProxyQt.cpp:
      * WebKitTestRunner/qt/PlatformWebViewQt.cpp:
      (WTR::WebView::wkView):
      (WTR::WebView::pageRef):
      (WTR::WebView::~WebView):
      (WTR::WebView::WebView):
      (WTR::PlatformWebView::PlatformWebView):
      (WTR::PlatformWebView::sendEvent):
      (WTR::PlatformWebView::postEvent):
      * WebKitTestRunner/qt/WebKitTestRunner.pro:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@96126 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      6c81e4a8
    • rniwa@webkit.org's avatar
      dump-as-markup conversion: editing/pasteboard/merge-end-list.html and merge-end-table.html · 5408ee22
      rniwa@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=68857
      
      Reviewed by Kent Tamura.
      
      Converted the tests into dump-as-markup tests. Also split each test into two tests.
      
      * editing/pasteboard/merge-end-list-2-expected.txt: Added.
      * editing/pasteboard/merge-end-list-2.html: Added.
      * editing/pasteboard/merge-end-list-expected.txt: Added.
      * editing/pasteboard/merge-end-list.html:
      * editing/pasteboard/merge-end-table-2-expected.txt: Added.
      * editing/pasteboard/merge-end-table-2.html: Added.
      * editing/pasteboard/merge-end-table-expected.txt: Added.
      * editing/pasteboard/merge-end-table.html:
      * platform/chromium-cg-mac-leopard/editing/pasteboard/merge-end-list-expected.png: Removed.
      * platform/chromium-cg-mac-leopard/editing/pasteboard/merge-end-table-expected.png: Removed.
      * platform/chromium-cg-mac/editing/pasteboard/merge-end-list-expected.png: Removed.
      * platform/chromium-cg-mac/editing/pasteboard/merge-end-table-expected.png: Removed.
      * platform/chromium-linux/editing/pasteboard/merge-end-list-expected.png: Removed.
      * platform/chromium-linux/editing/pasteboard/merge-end-table-expected.png: Removed.
      * platform/chromium-mac/editing/pasteboard/merge-end-list-expected.png: Removed.
      * platform/chromium-mac/editing/pasteboard/merge-end-table-expected.png: Removed.
      * platform/chromium-win/editing/pasteboard/merge-end-list-expected.png: Removed.
      * platform/chromium-win/editing/pasteboard/merge-end-list-expected.txt: Removed.
      * platform/chromium-win/editing/pasteboard/merge-end-table-expected.png: Removed.
      * platform/chromium-win/editing/pasteboard/merge-end-table-expected.txt: Removed.
      * platform/gtk/editing/pasteboard/merge-end-list-expected.png: Removed.
      * platform/gtk/editing/pasteboard/merge-end-list-expected.txt: Removed.
      * platform/gtk/editing/pasteboard/merge-end-table-expected.png: Removed.
      * platform/gtk/editing/pasteboard/merge-end-table-expected.txt: Removed.
      * platform/mac-leopard/editing/pasteboard/merge-end-list-expected.png: Removed.
      * platform/mac-leopard/editing/pasteboard/merge-end-table-expected.png: Removed.
      * platform/mac/editing/pasteboard/merge-end-list-expected.png: Removed.
      * platform/mac/editing/pasteboard/merge-end-list-expected.txt: Removed.
      * platform/mac/editing/pasteboard/merge-end-table-expected.png: Removed.
      * platform/mac/editing/pasteboard/merge-end-table-expected.txt: Removed.
      * platform/qt/editing/pasteboard/merge-end-list-expected.png: Removed.
      * platform/qt/editing/pasteboard/merge-end-list-expected.txt: Removed.
      * platform/qt/editing/pasteboard/merge-end-table-expected.png: Removed.
      * platform/qt/editing/pasteboard/merge-end-table-expected.txt: Removed.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@96125 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      5408ee22
    • jchaffraix@webkit.org's avatar
      Crash in WebCore::HTMLParser::createHead · 4ac55ef2
      jchaffraix@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=32426
      
      Reviewed by Darin Adler.
      
      The crash was fixed some time ago but the test was not landed which kept the bug open.
      
      * fast/parser/crash-HTMLParser-createHead.html: Added.
      Tweaked the test case as we now throw an exception (DOM Exception 12).
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@96124 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      4ac55ef2
    • ossy@webkit.org's avatar
      Fix ENABLE(SQL_DATABASE)=0 build after r95919 · 2c0eb986
      ossy@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=68902
      
      r95919 enabled OFFLINE_WEB_APPLICATIONS by default and
      it needs SQLite stuff even if ENABLE_SQL_DATABASE=0.
      
      Reviewed by Adam Barth.
      
      * platform/sql/SQLiteAuthorizer.cpp:
      * platform/sql/SQLiteDatabase.cpp:
      * platform/sql/SQLiteFileSystem.cpp:
      * platform/sql/SQLiteStatement.cpp:
      * platform/sql/SQLiteTransaction.cpp:
      * storage/DatabaseAuthorizer.cpp:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@96123 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      2c0eb986
    • jchaffraix@webkit.org's avatar
      Crash because CSSPrimitiveValue::computeLengthDouble assumes fontMetrics are available · 0412fbc9
      jchaffraix@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=66291
      
      Reviewed by Darin Adler.
      
      Source/WebCore:
      
      Test: fast/canvas/crash-set-font.html
      
      This is Yet Another Missing updateFont (similar to bug 57756 and likely others). Here the issue is that
      applying one of the font properties could mutate the parent style's font if m_parentStyle == m_style.
      We would then query the newly created font when applying CSSPropertyFontSize, which has no font fallback
      list as Font::update was never called.
      
      The right fix would be to refactor of how we handle fonts to avoid such manual updates (see bug 62390).
      Until this happens, it is better not to crash.
      
      * css/CSSStyleSelector.cpp:
      (WebCore::CSSStyleSelector::applyProperty): Added updateFont() here as the fonts could have been
      mutated by the previous property change. Also added a comment explaining why it is safe to do it
      this way.
      
      LayoutTests:
      
      * fast/canvas/crash-set-font-expected.txt: Added.
      * fast/canvas/crash-set-font.html: Added.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@96122 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      0412fbc9
    • carlosgc@webkit.org's avatar
      [GTK] Rename WebKit2 GTK+ API main header as webkit2.h · 062e2018
      carlosgc@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=65178
      
      Reviewed by Martin Robinson.
      
      Source/WebKit2:
      
      * GNUmakefile.am: Add webkit2.h.
      * UIProcess/API/gtk/WebKitWebView.h:
      * UIProcess/API/gtk/webkit2.h: Renamed from Source/WebKit2/UIProcess/API/gtk/webkit/webkit.h.
      * webkit2gtk.pc.in: Use webkitgtk-<api-version> as include dir.
      
      Tools:
      
      * GNUmakefile.am:
      * GtkLauncher/main.c: Include <webkit2/webkit2.h>.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@96121 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      062e2018
    • noam.rosenthal@nokia.com's avatar
      [Texmap] Code cleanup: remove unused boundingRect/visibleRect calculations · 761bb317
      noam.rosenthal@nokia.com authored
      https://bugs.webkit.org/show_bug.cgi?id=68897
      
      Reviewed by Andreas Kling.
      
      No new functionality so no new tests.
      
      * platform/graphics/texmap/TextureMapperNode.cpp:
      (WebCore::TextureMapperNode::computeAllTransforms):
      (WebCore::TextureMapperNode::computeTiles):
      (WebCore::TextureMapperNode::syncCompositingState):
      * platform/graphics/texmap/TextureMapperNode.h:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@96120 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      761bb317
    • noam.rosenthal@nokia.com's avatar
      [Texmap][Qt] Refactor texture-upload to allow direct chunk update · 12fafad4
      noam.rosenthal@nokia.com authored
      https://bugs.webkit.org/show_bug.cgi?id=68808
      
      Add a function to BitmapTexture for direct pixel updates.
      Modify BitmapTextureGL::endPaint to use that function. Since the BGRA
      to RGBA swizzling is done inside that function, there's no need for the
      RGBA32PremultipliedBuffer class to contain such function. Also,
      RGBA32PremultipliedBuffer was renamed to BGRA32PremultipliedBuffer, correcting
      an old mistake.
      
      Reviewed by Andreas Kling.
      
      No new tests. Existing tests in LayoutTests/compositing test this.
      
      * platform/graphics/opengl/TextureMapperGL.cpp:
      (WebCore::BitmapTextureGL::beginPaint):
      (WebCore::BitmapTextureGL::endPaint):
      (WebCore::swizzleBGRAToRGBA):
      (WebCore::BitmapTextureGL::updateContents):
      * platform/graphics/opengl/TextureMapperGL.h:
      (WebCore::BGRA32PremultimpliedBuffer::~BGRA32PremultimpliedBuffer):
      * platform/graphics/qt/TextureMapperQt.cpp:
      (WebCore::BitmapTextureQt::updateContents):
      (WebCore::BGRA32PremultimpliedBufferQt::data):
      (WebCore::BGRA32PremultimpliedBuffer::create):
      * platform/graphics/qt/TextureMapperQt.h:
      * platform/graphics/texmap/TextureMapper.h:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@96118 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      12fafad4
    • ossy@webkit.org's avatar
      [Qt][WK2] Buildfix after r96108. · 709da72a
      ossy@webkit.org authored
      Rubber-stamped by Andreas Kling.
      
      Source/WebKit/qt:
      
      * tests/tests.pri:
      
      Tools:
      
      * WebKitTestRunner/InjectedBundle/qt/InjectedBundle.pro:
      * WebKitTestRunner/qt/EventSenderProxyQt.cpp:
      * WebKitTestRunner/qt/WebKitTestRunner.pro:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@96116 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      709da72a
    • levin@chromium.org's avatar
      watchlist: Change watchlistparser.py to be class based. · 36f5e827
      levin@chromium.org authored
      https://bugs.webkit.org/show_bug.cgi?id=68869
      
      Reviewed by Eric Seidel.
      
      * Scripts/webkitpy/common/watchlist/watchlistparser.py:
      * Scripts/webkitpy/common/watchlist/watchlistparser_unittest.py:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@96115 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      36f5e827
    • loislo@chromium.org's avatar
      Unreviewed followupfix for r96110. · 17803022
      loislo@chromium.org authored
      This is a small adjustment of the heap size delta calculation.
      
      * inspector/performance/resources/performance-test.js:
      (initialize_TimeTracker.InspectorTest.runPerformanceTest.Timer.prototype.done):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@96114 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      17803022
    • vestbo@webkit.org's avatar
      [Qt] Fix build of declarative plugin against Qt5 · 2af8ce6e
      vestbo@webkit.org authored
      Reviewed by Andreas Kling.
      
      * declarative/declarative.pro:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@96113 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      2af8ce6e
    • levin@chromium.org's avatar
      watchlist: Break out the diff boilerplate to allow for re-use. · 9f9b251a
      levin@chromium.org authored
      https://bugs.webkit.org/show_bug.cgi?id=68871
      
      Reviewed by Eric Seidel.
      
      * Scripts/webkitpy/common/checkout/diff_parser_unittest.py:
      Break out the diff into a new file.
      * Scripts/webkitpy/common/checkout/diff_test_data.py: Added.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@96112 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      9f9b251a
    • vestbo@webkit.org's avatar
      [Qt] Fix build of WebKit2 unit-tests after r96108 · c831c1a3
      vestbo@webkit.org authored
      Reviewed by Andreas Kling.
      
      * UIProcess/API/qt/tests/tests.pri:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@96111 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      c831c1a3
    • loislo@chromium.org's avatar
      Web Inspector: UI performance: introduce heap size tracking stats. · a0fb964e
      loislo@chromium.org authored
      https://bugs.webkit.org/show_bug.cgi?id=68901
      
      It is interesting how much the heap memory is used by Inspector in order of running the test.
      
      Reviewed by Yury Semikhatsky.
      
      Tools:
      
      * DumpRenderTree/chromium/TestShell.cpp:
      (TestShell::showDevTools):
      (TestShell::closeDevTools):
      
      LayoutTests:
      
      * inspector/performance/resources/network-append-30-requests.html:
      * inspector/performance/resources/performance-test.js:
      (initialize_TimeTracker.InspectorTest.runPerformanceTest.Timer):
      (initialize_TimeTracker.InspectorTest.runPerformanceTest.Timer.prototype._getJSHeapSize):
      (initialize_TimeTracker.InspectorTest.runPerformanceTest.Timer.prototype.done):
      (initialize_TimeTracker.InspectorTest.runPerformanceTest.Timer.prototype._dump):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@96110 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      a0fb964e
    • wjmaclean@chromium.org's avatar
      Layout Test platform/chromium/compositing/zoom-animator-scale-test.html is failing. · 677c814c
      wjmaclean@chromium.org authored
      https://bugs.webkit.org/show_bug.cgi?id=68852
      
      Rebaseline GPU tests for Mac, Win.
      
      Reviewed by Shinichiro Hamaji.
      
      * platform/chromium-gpu-cg-mac/platform/chromium/compositing/zoom-animator-scale-test-expected.png:
      * platform/chromium-gpu-mac/platform/chromium/compositing/zoom-animator-scale-test-expected.png:
      * platform/chromium-gpu-win/platform/chromium/compositing/zoom-animator-scale-test-expected.png:
      * platform/chromium/test_expectations.txt:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@96109 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      677c814c
    • vestbo@webkit.org's avatar
      [Qt] Fix build against Qt5 after refactor of widgets out of QtGUi · cc648d9c
      vestbo@webkit.org authored
      QWidget and friends now live in the QtWidgets library. We update
      includes in implementation files and private headers to us the
      non-module-prefixed path, and leave the lookup for the include
      path. For public headers we have to ifdef the includes as the
      user might now have the modules we need in his QT config.
      
      Finally, QSGCanvas is no longer a QWidget but a QWindow, so we
      have to update our code and use windowHandle() for setting the
      parent relationships.
      
      https://bugs.webkit.org/show_bug.cgi?id=68687
      
      Reviewed by Andreas Kling.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@96108 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      cc648d9c
    • commit-queue@webkit.org's avatar
      Clipped high quality blur in skia has been fixed. Rebaseline layout tests. · 92b307b1
      commit-queue@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=68577
      
      Patch by Ben Wagner <bungeman@chromium.org> on 2011-09-27
      Reviewed by Kenneth Russell.
      
      * platform/chromium-linux-x86/fast/box-shadow: Removed.
      * platform/chromium-linux/fast/box-shadow/inset-box-shadows-expected.png:
      * platform/chromium-mac/fast/box-shadow/inset-box-shadow-radius-expected.png:
      * platform/chromium-mac/fast/box-shadow/inset-box-shadows-expected.png:
      * platform/chromium-mac/fast/box-shadow/shadow-buffer-partial-expected.png:
      * platform/chromium-win/fast/box-shadow/inset-box-shadow-radius-expected.png:
      * platform/chromium-win/fast/box-shadow/inset-box-shadows-expected.png:
      * platform/chromium-win/fast/box-shadow/shadow-buffer-partial-expected.png:
      * platform/chromium/test_expectations.txt:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@96107 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      92b307b1
    • pfeldman@chromium.org's avatar
      Source/WebCore: Web Inspector: split DOM.attributesUpdated into... · 60657a7c
      pfeldman@chromium.org authored
      Source/WebCore: Web Inspector: split DOM.attributesUpdated into attributeModified and attributeRemoved.
      Send attribute name and value within the event.
      https://bugs.webkit.org/show_bug.cgi?id=68613
      
      Reviewed by Yury Semikhatsky.
      
      * dom/Element.cpp:
      (WebCore::Element::setAttribute):
      (WebCore::Element::removeAttribute):
      * inspector/Inspector.draft-01.json:
      * inspector/Inspector.json:
      * inspector/InspectorDOMAgent.cpp:
      (WebCore::InspectorDOMAgent::didModifyDOMAttr):
      (WebCore::InspectorDOMAgent::didRemoveDOMAttr):
      * inspector/InspectorDOMAgent.h:
      * inspector/InspectorInstrumentation.cpp:
      (WebCore::InspectorInstrumentation::didModifyDOMAttrImpl):
      (WebCore::InspectorInstrumentation::didRemoveDOMAttrImpl):
      * inspector/InspectorInstrumentation.h:
      (WebCore::InspectorInstrumentation::didModifyDOMAttr):
      (WebCore::InspectorInstrumentation::didRemoveDOMAttr):
      * inspector/front-end/DOMAgent.js:
      (WebInspector.DOMNode.prototype._addAttribute):
      (WebInspector.DOMNode.prototype._setAttribute):
      (WebInspector.DOMNode.prototype._removeAttribute):
      (WebInspector.DOMAgent.prototype._attributeModified):
      (WebInspector.DOMAgent.prototype._attributeRemoved):
      (WebInspector.DOMAgent.prototype._inlineStyleInvalidated):
      (WebInspector.DOMAgent.prototype._loadNodeAttributes):
      (WebInspector.DOMDispatcher.prototype.attributeModified):
      (WebInspector.DOMDispatcher.prototype.attributeRemoved):
      * inspector/front-end/ElementsPanel.js:
      (WebInspector.ElementsPanel):
      (WebInspector.ElementsPanel.prototype._attributesUpdated):
      * inspector/front-end/MetricsSidebarPane.js:
      (WebInspector.MetricsSidebarPane):
      (WebInspector.MetricsSidebarPane.prototype._attributesUpdated):
      * inspector/front-end/StylesSidebarPane.js:
      (WebInspector.StylesSidebarPane):
      (WebInspector.StylesSidebarPane.prototype._attributesModified):
      (WebInspector.StylesSidebarPane.prototype._attributesRemoved):
      (WebInspector.StylesSidebarPane.prototype._styleInvalidated):
      (WebInspector.StylePropertyTreeElement.prototype.event):
      (WebInspector.StylePropertyTreeElement.prototype):
      * inspector/validate-protocol-compatibility:
      
      LayoutTests: Web Inspector: split DOM.attributesUpdated into attributeModified and attributeRemoved. Send attribute name and value within the event.
      https://bugs.webkit.org/show_bug.cgi?id=68613
      
      Reviewed by Yury Semikhatsky.
      
      * inspector/elements/mutate-unknown-node.html-disabled:
      * inspector/elements/set-attribute.html:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@96106 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      60657a7c
    • caio.oliveira@openbossa.org's avatar
      [Qt][WK2] Add support for hover API in Qt WebKit2 · 77a825a9
      caio.oliveira@openbossa.org authored
      https://bugs.webkit.org/show_bug.cgi?id=68369
      
      Reviewed by Andreas Kling.
      
      Source/WebKit2:
      
      Based on the patch from Igor Oliveira in the same bug.
      
      Expose a linkHovered() signal in QDesktopWebView, that passes the QUrl and the
      QString corresponding to the link title. I left textContent out because was
      unsure of its use case.
      
      In QDesktopWebView we store the last URL and title emitted to make sure we send
      the signal only if either value changes. Tests were added to the QML element to
      check: if values are correctly emitted and if we don't emit more signals than
      necessary.
      
      * UIProcess/API/qt/qdesktopwebview.cpp:
      (QDesktopWebViewPrivate::didMouseMoveOverElement):
      * UIProcess/API/qt/qdesktopwebview.h:
      * UIProcess/API/qt/qdesktopwebview_p.h:
      * UIProcess/API/qt/tests/qmltests/DesktopWebView/tst_linkHovered.qml: Added.
      * UIProcess/API/qt/tests/qmltests/common/test2.html:
      * UIProcess/API/qt/tests/qmltests/qmltests.pro:
      * UIProcess/qt/ClientImpl.cpp:
      (qt_wk_mouseDidMoveOverElement):
      * UIProcess/qt/ClientImpl.h:
      * UIProcess/qt/QtWebPageProxy.cpp:
      (QtWebPageProxy::init):
      * UIProcess/qt/TouchViewInterface.h:
      (WebKit::TouchViewInterface::didMouseMoveOverElement):
      * UIProcess/qt/ViewInterface.h:
      
      Tools:
      
      Change the statusbar to show the link URL when hovering links in
      MiniBrowser using QDesktopWebView.
      
      * MiniBrowser/qt/BrowserWindow.cpp:
      (BrowserWindow::BrowserWindow):
      (BrowserWindow::onLinkHovered):
      * MiniBrowser/qt/BrowserWindow.h:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@96105 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      77a825a9